1 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
5 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
7 and it's representation name (for the NIH)
9 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
11 conversion of YBR to RGB pixels. So, now, the conversion is made using
14 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
16 format) to replace 'at-run' dicom files generated by the
17 TestAllReadCompareDicom test
19 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
22 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
25 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Testing/TestMAkeIcon.cxx : complete the test
28 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
31 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
35 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
38 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * Test/ : accelerate tests (it's not very significant accelerations).
40 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
42 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Testing/TestSequence.cxx : add test for sequences of images... test that
44 we have the same serie or the same study UID
46 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
49 * src/gdcmDict.h : remove commented code
50 * src/gdcmDocument.cxx : initialize values
51 * src/gdcmFile.cxx : bug fix when reading values
52 * gdcmPython/demo/ : change file names. Remove useless files
54 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmFile.cxx : remove the default array of initialization.
56 The static array contained pointers to non-static values (comming from
57 strings). To have coherences, when creating files, these values can't be
58 static. So, the array can't be static, too ! To simplify, the array have
59 been replaced by repeted lines to insert values in the File
61 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
63 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
65 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
67 (Dicom Element) into the Sequence Item
69 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/*.cxx : first parss to normalize file organisation
72 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmDirList.[h|cxx] : add method to find a directory
74 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
76 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
77 * Finish cleaning up my JPEG mess. Should be ok now.
78 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
79 contained within the RLE* class(doh!)
81 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
82 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
83 * SerieHeader::AddFileName() creates as many Coherent Files lists
84 (same Serie UID) as it founds different Serie UID
85 amongst the files instead of discarting any file
86 that doesn't match with the first one he found.
87 * SerieHeader::OrderGdcmFileList has now one parameter :
88 the Coherent Files list the user wants to sort
89 * SerieHeader::GetFirstCoherentFileList() |
90 * SerieHeader::GetLastCoherentFileList() | allow to parse
91 the set of Coherent Files lists
92 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
93 compatibility (it returns the *first* Coherent Files list,
94 since there was only one before)
95 * Test/TestSerieHeader gets gdcmData as a default root directory
97 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * Remove friend between DocEntry and File classes
99 * Remove friend between PixelReadConverter and RLEFramesInfo,
102 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
104 0002|0000. The value was incorrect.
106 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
109 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmUtil.cxx : compilation fix on Win32
111 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
112 variable, to be easy found. Add methods to change the default UID.
113 Amelioration of the CreateUniqueUID to use the correct default UID.
114 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
117 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * Test/TestVR.cxx : fix memory leaks
120 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
121 * Rewrite the base 256 to base 10 conversion, using string operation only.
122 This allows us to get rid of the problematic 64bits integer type (does not
123 always exist on target platform).
125 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
126 * Add construct and destructor to class gdcm::Debug to close the debug file
128 * Don't let uset to open twice the same file
129 * gdcm has now an official UID prefix,
130 supplied by http://www.medicalconnections.co.uk
131 1.2.826.0.1.3680043.2.1143
132 (Thx to Mathieu for providing URL)
133 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
134 to be able to perform some more tests
135 * gdcm::ContentEntry : Contructors and Destructor are now protected,
136 in order to be sure no user will try to use them.
137 (at user level, only the children classes are meaningfull)
139 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * move RLEInfo & JPEGInfo from Document to File
142 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * FIX : remove so many friend between classes
145 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
147 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
149 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
150 In order to avoid missbehaviour :
151 . gdcm::DocEntry is now specialized in
152 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
153 - gdcm::ContentEntry (Dicom entry with a 'content')
154 . gdcm::ContentEntry is specialized in
155 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
156 characters value, or integers)
157 - gdcm::BinEntry (Dicom entry with a non strig representable value
158 (user hasn't any longer to thing about the precedence of his dynamic_casts)
160 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * Test/VTKTest*.cxx : bug fix under linux
163 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
165 use with python. Some methods are moved from Document to ElementSet or
166 DocEntrySet. The equivalent methods to ElementSet have been added to
167 SQItem and are virtual in DocEntrySet. Methods that may have the same code
168 in SQItem and ElementSet is directly placed in DocEntrySet
170 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * Test/VTKTest*.cxx : remove the show variable in each test method because
172 it's useless (the viewer variable replace this variable)
174 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmDocument.cxx : bug fix on potential memory leak
176 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
177 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
178 Add ClearXxx methods to remove all the content of the list or map
179 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
181 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
182 * methods ReplaceOrCreate renamed as Insert
183 (nobody will be any longer confused by 'CreateOrReplace')
185 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Grealty simplify the JPEg decompression, no need to differenciate based on
187 the JPEG possible type (with/without fragment, with/without multiple frame).
188 Everything is done throught the JPEG IO Suspension mechanism in IJG
190 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
191 * Stage 3 of normalization :
192 in order to avoid any missunderstanding while reading method names :
193 - All the methods xxxEntry now deal with dicom Entries
194 - Methods GetEntry splitted into
197 - Method SetEntry renamed as SetEntryValue
198 - Method SetEntryBinArea let as it was
200 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
201 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
202 - Position correctly the entry points for JPEG2000 and JPEG-LS
203 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
205 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
207 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
208 with other method names
209 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
210 * Test/TestDicomDirElement.cxx : add new test
212 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
213 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
214 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
215 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
216 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
217 So can't you use __int64 in ostream at all.
219 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * bug fix for compilation on MSVC6
221 * gdcmPython/gdcm.i : rename of classes missed
223 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
224 * Stage 2 of names normalization :
225 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
226 (easy to understand ...)
227 - gdcm::FileHelper replaces old class gdcm::File
229 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
231 type and not a string. So, there remove problems on the format of the
234 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
235 * Add Example/TestPapyrus.cxx
236 - reads a Papyrus file (gdcm::Header compliant),
237 - gets the pixels of all the images, using low level iterators
238 - writes an multiframes Dicom image.
239 (Just to show it's *possible* to do that)
240 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
243 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
245 Thus, DicomDirXXX are created with a flad that indicates if the created
246 object is empty or not (when not empty, the DicomDirElement is used to
249 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
251 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
253 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
256 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
258 Remove all access to the hash-tables or lists in the objects.
260 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
262 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
263 be complient with all the gdcm source code
265 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
269 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
273 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * Test/ : rename VTK tests to have a best name for the tests
275 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
276 GetFirstEntry/GetNextEntry use
278 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * In SerieHeader::ImagePositionPatientOrdering()
280 // a Dicom 'Serie' may contain scout views
281 // and images may have differents directions.
282 // -> More than one may have the same 'pos'
283 // Sorting has then NO meaning !
284 Thx to Eduardo Davila for reporting bug.
286 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
288 test. Now it's on image content and not on the resulting visualisation...
289 might solve the problem on linux when using the OpenGL drivers
291 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
293 DicomDirSerie, DicomDirImage
294 Dict, DictSet classes :
295 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
296 -remove InitTraversal method.
297 * UPD Test programs + Example programs
299 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
300 * remove useless and never updated keyword \ingroup
301 * Solve pb when structure (list, map, ...) is empty.
302 Thx to Benoit for reporting bug
304 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
305 * Taking into account of 'Transfer Syntax' value
306 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
309 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
311 is no memory access violation
312 * gdcmPython/demo : add python demos using VTK
314 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
315 * FIX 'Dictionnary' is now spelt 'Dictionary'
316 'wether' is now spelt 'whether'
317 'archieve' is now spelt 'archive' ;-)
319 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
320 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
321 related methods, in order not to expose internal mechanisms
324 * REM methods that exposed internal mechanisms :
325 DicomDir::GetDicomDirPatients()
326 DicomDirPatient::GetDicomDirStudies()
327 DicomDirStudy::GetDicomDirSeries()
328 DicomDirSerie::GetDicomDirImages()
329 * UPD Test programs :
333 * UPD Example program
335 * ADD DictSet methods
339 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Removed the Print/indent/default parameter mess. There is absolutely no
341 reason to have to methods, moreover with the second taking the ostream as
342 *SECOND* parameter. This was clearly a bad hack to get things compile.
344 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Complete rewrite of the GetMacAddress code. Now the code is *much*
346 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
347 Unfortunately the main code does not work on SunOS, thus provide a specific
348 code for this platform only (and Win32 of course). Since this seems to be
349 working, change CreateUniqueUID to use GetMACAddress instead of the
350 problematic GctestetIPAddress
352 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Unfortunately to be able to test gdcmDirList I had to break the API
354 a little. Now the class is not a std::list anymore but has a member
355 std::vector (more ITK compatible). Allow unit testing on Win32 and
358 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * Update SerieHeader to take into account a Serie Instance UID to properly
362 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
363 * ENH - Comment out Mathieu's (dangerous) Super Hack
364 for dealing with BIGENDIAN processors
365 - Move equivalent stuff to BinEntry::WriteContent
366 When necessary, 16 Bits Pixels are swapped in a small buffer
367 and then written. This avoid allocating a huge buffer, in
368 PixelWriteConvertor, and avoid modifying the Pixel Area.
370 Probabely, the same operation will have to be done when we want
371 to write image with Big Endian Transfert Syntax,
372 and we are working on Little Endian Processor
374 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
377 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
378 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
379 all the dict content.
380 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
382 * Test/TestDict.cxx : add a new test for the dict classes
384 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
386 file. Debug is yanked if compiled with NDEBUG
388 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmDictSet.h : set the default output to the os variable
390 * src/gdcmDictEntry.[h|cxx] : add the Print method
391 * gdcmPython/demo/ : add a new test
393 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
394 * merging of Test/PrintDicomDir and Test/TestDicomDir
395 * removal of now redundant Test/PrintDicomDir
396 * enhancement of Example/PrintDicomDir
398 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * Now, python test might work on systems
400 * Add the PrintDicomDir test
402 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
403 * FIX : First entry following group 0002 was lost for
404 Explicit Big Endian Transfer Syntax files
405 (group and elem not swaped)
407 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
408 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
409 Big Endian Transfer Syntax supposed the group following 0002
410 begins always by element 0000 (element 0000 is *optional*)
411 To avoid further troubles, let's be pessimistic, and use
412 Document::HandleOutOfGroup0002() method
413 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
414 (related pb not yet solved)
416 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * Bug fix for the python part use
418 * Now, PrintHeader.py pass... but outside the ctest use. shit !
420 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
423 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
424 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
425 a string and should ask the global TS dict what are the propreties of
428 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
429 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
430 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
431 to swap the Swap Code, at parsing time, when we come out of group 0002
432 and Transfer Syntax is Big Endian
433 We should be able to read now 'true DICOM" Big Endian coded images
434 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
435 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
437 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
438 * Hopefully fix the bug on MacOSX and static global initialization.
439 This is the only -minor- patch I found that both please MacOSX and VS6.
440 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
441 but this would require a lot of change. Another approach would be that Global
442 create those string and GDCM_UNFOUND becomes a pointer to a string (which
443 gdcm::Global would destroy at exit).
445 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Fix bug on MacOSX with static initialization in a multy threaded
447 environment. static const string in a header file used to be ill
448 initialized provoquing the freeze of any tests. patch should solve this
451 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
452 * According to Benoit's suggestion, and without any objection from anybody
453 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
454 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
455 - method gdcmDicomDirObject::GetEntry() renamed as
456 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
458 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
459 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
460 you debug/warning message just as c++ streams which make them very convinient
461 to use. Once this is stabilize I will change the ostringstrem to be
462 redirected to a file (ofstream).
463 * Properly support C99 extension: __FUNCTION__ which allow us to display
464 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
466 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
467 * Removal of useless and dangerous methods :
468 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
469 GetDocEntryByName, GetEntryByName, GetDictEntryByName
470 * Removal of usless methods :
471 Dict::PrintByName, Dict::GetDictEntryByName
472 * Commenting out of probabely useless methods :
473 Dict::GetDictEntryNames()
474 Dict::GetDictEntryNamesByCategory()
475 DictSet::GetPubDictEntryNames()
476 DictSet::GetPubDictEntryNamesByCategory()
477 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
478 * ENH : Use dicomTS.dic as described in 2004 version
479 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
480 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
481 Add Accessors on VM (Value Multiplicity), and VM related methods
482 * ADD : Add a list of 'Dicom Attribute types', as found in
483 http://medical.nema.org/dicom/2004/04_15PU.PDF
485 * ADD : Add dicomGroupNameAbbreviations.dic
486 should be used to write a method to replace the former
487 Dict::GetDictEntryNamesByCategory()
489 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
491 to read in the file... and only it ! Length is the efective length of the
492 data in the DocEntry structure
494 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
496 And now use a static function call instead, with a global variable. i
497 This is much closer to the VTK approach. Hopefully should be bulletproof
498 and easier to use...hopefully
500 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
503 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
506 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
508 ValEntry, BinEntry, SeqEntry creation or replace
510 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
512 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
514 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
515 when specifying the VR
516 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
517 * src/gdcmDocEntry.cxx : amelioration of print
519 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
520 * ADD : Add the method Util::IsCurrentProcessorBigEndian
521 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
522 * ADD Method Document::ComputeGroupLength
523 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
524 in order to allow further VR modification by user
525 * REM : removal of once-called method File::WriteBase
526 integration of its code in formerly one-line method File::Write
528 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
530 replace the different values "??", "Unkn", "Unknown".
531 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
532 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
533 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
534 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
536 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
539 * Set the gdcm::Base class to some Printable classes
541 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmFile.[h|cxx] : add the Print method
543 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
544 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
545 * src/gdcmDocument.h : remove the PrintLevel informations
546 * Example/PrintFile.cxx : use the new gdcm::File::Print
548 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
550 problems when compiling with the python wrapping
552 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
554 writting in ImplicitVR
556 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
557 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
558 JPEG decompression, especially when dicom frames are split into several
559 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
560 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
562 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmHeader.cxx : change the initialisation of default header.
564 Now, this header is readable by gdm, e-film, DicomWorks
566 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
568 Rename Decompressed to Raw
569 * Use the API changes in gdcm::File.
570 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
573 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
575 each added entry in the header. Replace the 'Planes' field by the 'Number
578 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
580 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
582 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
584 At this time, this image isn't readable by e-film... waiting JPR help to
587 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
589 DocEntry. Now use methods of the Document !
591 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Test/ShowDicomSeq.cxx : bug fix
594 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
596 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
597 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
598 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
600 * Test/TestCopyRescaleDicom.cxx : remove unused variable
601 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
602 containing found sequences
604 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
607 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
608 Some fields in BinEntry must be copied to not seg fault when making the :
609 gdcm::File *copy = new gdcm::File( copyH );
610 and tests are now made on good variables
612 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
614 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
616 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
617 * Add vtkGdcmWriter example and test
619 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
620 * Test/TestUtil.cxx : reformat the source code
621 * vtk/vtkGdcmReader.cxx : remove and change prints
622 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
624 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
625 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
627 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
629 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
631 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
633 by an eof to prevent all bad read of the file... and in this case, the
636 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * Example/Volume2Dicom.cxx : comment unused variables
638 * Test/PrintDicomDir.cxx : comment unused variables
639 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
640 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
641 method that is redondant with AddEntry.
642 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
645 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * Bug fix due my last commit (compilation under Windows).
647 * Example/Volume2Dicom : bug fix in the file and reformatting source code
648 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
650 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
652 - Remove printf / sprintf
653 - include iostream AFTER gdcm so we don't get warnings
654 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
656 - Also remove tons of include from header files, hopefully this should
657 speeup the compilation time, since it was becoming a dog slow.
658 - Remove gdcm.h as it include way too many files and slow down compilation
659 (plus it is not up to date)
660 - remove 'using namespace std' this is BAD !
662 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * Remove memory leaks on the DicomDir
664 * Remove some useless data in DicomDirObject
665 * Add usefull methods in SQItem, to be complient withe the ElementSet
667 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
670 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
672 future, with convertion)
673 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
674 and ImageDataSize values. Remove the method to get the PixelReadConverter
675 from the output of the class
677 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
680 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
682 and vtkErrorMacro use.
683 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
685 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
688 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
689 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
690 The string leaves only in the fonction. So when we make a .c_str(), we
691 get the pointeur on the first element, element that will be destroyed
692 immediately after thee instruction.
693 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
694 file has been opened : the test must be made on the content of the
695 pointer and not directly on the pointer !
698 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
700 the python part recompiles
702 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
704 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
705 X session is killed (for my computer... it seems to not be identic on
708 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
710 avoid problems (otherwise, the difference test between the visible image
711 and the reference is incorrect. If the reference is greater than the
712 screen resolution, it's produce errors).
713 Can be used for only one image. Can be used with a visible flag.
714 * vtk/vtkGdcmReader.cxx : remove commented codes.
715 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
716 under windows at compilation
717 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
719 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
721 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
722 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
723 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
724 tests on the image size X, Y, Z
726 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
728 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
729 between the class name and the file name
731 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * src/ : fix compilation warnings for the Write method (2 different
733 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
734 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
735 variable... create a static method in gdcm::Document to access to
736 this variable content.
738 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
739 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
740 file, to be accessed by other files (like gdcmFile). Remove commented
741 code. Move the change of the header to the gdcmFile, using the
743 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
744 To be sure of that (and simplify calls), the Write of the header now
745 gets a file name and not a file pointer (std::ifstream).
746 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
747 DocEntryArchive. Remove all open of the written file
749 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
750 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
752 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
754 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
756 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
757 some corresponding methods. Write correctly the file and check before
759 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
760 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
761 is now on RGB data (as before my last commit
762 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
764 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
765 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
766 Add a print information of the type of the entry
767 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
768 It was in the gdcmFile, and all write have been regrouped
769 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
770 Write correctly all dicom files (in decompressed mode only at this time)
771 * Test/ : test on files are now made using Raw data and not color data if
773 * Example/PrintFile.cxx : add more printings
775 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * Amelioration of code, remove some code copy. For the loading of
777 BinEntry (in gdcmDocument), add the test to verify if the file is already
780 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
782 remove a DocEntry in the header (push an empty DocEntry)
783 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
784 lines. Bug fix in the initialization of the PixelConvert and the
786 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
787 use in TestCopyDicom (now this test can run under windows... but fails)
788 * Test/TestCopyDicom.cxx : amelioration of the test :
789 - test the pixels written
790 - add test points to quickly find where is the error
791 - can set a file name input and output in arguments
792 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
793 amelioration of the test output
795 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
797 all replaced DocEntry's
798 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
799 Now, each needed DocEntry to modify is duplicated, modified and inserted
800 to the header using DocEntryArchive. Thus, after save, we can restore the
801 header initial state.
803 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
806 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
807 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
808 correct to copy it. The DictEntry is specified at the DocEntry creation,
809 then, it musn't change in the time.
810 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
811 header correctly. At this time, the change is only made for the first
812 level of the Document. In the future, it might consider sequences.
813 The change is made by replacing a DocEntry by an other that is created
814 outside the class. The old value is kept. When we restore the header
815 status, the added DocEntry is deleted and replaced by the old value.
816 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
817 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
818 set the write type to explicit VR, implicit VR or ACR. Add methods to set
819 the write mode to native, decompressed or RGB (but not used at this time)
821 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
823 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
825 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
827 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
829 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
830 set because already copied when copying the BinEntry's of the header
831 * Test/TestAllReadCompareDicom.cxx : remove warnings
833 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
835 Two problems appear when doing it :
836 - with the gdcmFile : when the GetImageData method is called, the pixels
837 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
838 data (pixels). And each structure destruct the data when it's
839 destructed. So we have two destructions for the same data. To solve it,
840 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
841 data or not. If it doesn't own data, then they will not destroyed by
843 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
844 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
845 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
846 create a double destruction of the same DocEntry's. So, to solve it,
847 the TagHT is simply cleared and the DicomDir* elements are destroyed.
848 * TODO : add an entry concerning memory leaks in the DicomDir
850 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
851 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
852 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
855 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
857 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
858 after it have been deleted
860 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * FIX: src/* fix the doxygen warnings.
862 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
863 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
864 was erroneously defined with a size of 15 instead of 16. [many thanks
865 to Jean Michel Rouet for pointing out this bug].
867 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
868 1. Finish merging JMR patch for writting DICOM from scratch
869 2. Fix -hopefully- bug with MONOCHROME and space vs null character
870 3. Use const ref when possible
871 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
872 5. A few more comments
873 6. CreateUniqueUID can now be called without parameter"
875 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
876 * ENH: Slightly bigger patch:
877 1. Getting toward full integration of JMR patch for writting dicom from scratch
878 2. Update Test to test part of this patch: CreateUniqueUID
879 3. File was not close properly in gdcmDict
880 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
881 5. Use of const ref instead of copy (speed issue)
882 6. Remove temporary (duplicate) string in TranslateToKey
883 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
884 8. Do not repeat virtual in subclasses
885 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
887 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
888 * Apply first patch toward better string comparison when dealing with broken
889 DICOM files. Essentially the string could be padded with a space instead
890 of a null character as defined by standard
892 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
894 because never used... and in the same time, that's remove some memory leaks
896 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
897 * src/gdcmFile.cxx : now delete the PixelConvert instance.
898 * In examples and tests : change the type of image data variables from void*
899 to uint8_t*. Remmove all delete on image data variables
901 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
902 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
903 Verify the file pointer value before open the file, and if it's not null,
904 a verbose message is generated.
905 Close correctly the file when the file isn't considered dicom-like. The
906 correctly close is a call to CloseFile.
907 When closing the file pointer, test if its not null to close the file.
908 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
909 file. For an uncompressed image, the copied data correspond in the least
910 case to the image size (calculated) or the image size specified in the
911 header. A verbose is generated if these two size mismatch
913 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
914 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
915 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
916 break under windows (with msvc6 compilation).
918 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
919 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
920 compiling with MSVC6)
922 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
923 * Bugs fix for the Windows build with VC6
924 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
925 needed (only for projects required VTK). If the VTK is included in all
926 projects, there is conflicts with the jpeg lib of vtk when compiling the
927 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
928 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
929 when compiling the gdcm_wrap.cxx file (created by the compilation of the
931 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
932 (like it's already made for the cout use). Otherwise, conflict with the
935 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
938 - comments on the DicomDir::Method related usage added.
939 - now that we use the namespace gdcm, a lot of internal classes do
940 NOT need to be wrapped anymore.
941 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
942 DicomDir::Method) new example added.
944 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
945 * Improve string manipulation. I now inforce the notion of 'DicomString'
946 A DicomString can contain as many \0 as they want
947 and it is *always* of even length.
948 We only support odd length for very rare case.
949 And in the near future this should be removed.
951 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * /binary_write/ gdcm source. Now even on big endian we are writting
953 little endian. This should -heopfully- fix some tests
955 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
956 * Now the dictionary is compiled into gdcm lib. This is a default
957 behavior, thus any dic file specified is picked before failback to
958 the one comiled into lib
960 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
961 * Change internals for gdcmDict. Don't use any 'new' any more.
962 This should definitely solve any leak problem, and we should be
963 as fast as before, as long as don't modify too much the dictionary.
965 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
966 * STYLE: ivars should start with a capital letter.
967 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
968 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
970 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
972 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
973 new 2004 dictionaries added (thanks to JPR).
974 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
975 * CLEANUP_ROUND (15) for gdcmPixelConvert
976 - RLEFrame::NumberFragments is now of type unsigned int
977 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
978 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
981 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
982 * Initial work in gathering all transfer syntax accessors. clearly
983 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
984 ivars, but only one transfersyntax (class) ivar with equivalent method on
987 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
988 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
989 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
990 discussed (plus I didn't like having a 2000 lines patch not commited)
992 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
994 * CLEANUP_ROUND (14) for gdcmPixelConvert
995 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
996 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
997 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
999 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1000 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1001 into File::Pixel_Data.
1003 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1005 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1006 * CLEANUP_ROUND (13) for gdcmPixelConvert
1007 Substituted File::ParsePixelData() with PixelConvert::Print() new
1009 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1010 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1011 method to those classes.
1012 - src/gdcmFile.[cxx|h]:
1013 -- Added a ::Print() method.
1014 -- PixelConverter is now a reference instead of a member.
1015 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1016 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1018 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1020 collaboration diagram and inheritance diagram should be generated with
1022 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1023 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1024 pointlessly wrapped (see
1025 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1026 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1027 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1028 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1029 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1030 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1031 -- File::Initialise: PixelConverter setup moved away to
1032 PixelConverter::GrabInformationsFromHeader()
1033 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1034 interpretation moved away to PixelConverter::BuildRGBImage()
1036 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1037 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1038 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1040 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1042 displayed on Win32 when a brutal abort() occurs (because of uncatched
1043 exception). See TODO new entry of this commit for more on this.
1044 * TODO added new entry.
1045 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1046 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1047 - HandleColor is no longer called from gdcmFile.cxx
1048 - gdcmPixelConvert.cxx clean up on method arguments and internal
1049 variable names for semantical coherence.
1051 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * Finished lossless transition, not only do we now read all lossless jpeg
1053 images, without the need of the Cornwell lib, but we do read them properly now
1054 * To reduce code (well to avoid code duplication), I defined a common place
1055 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1056 redefine symbols. This is not perfect but this the best solution I found for a
1057 compilation time jpeg option.
1059 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1060 * Update jpeg ijg lib to support lossless jpeg implementation
1061 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1063 * Also added a special copyright for dcmtk since we use their bugfixes.
1066 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1068 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1069 matters, as stated in warning note at beginning of %include section).
1070 * src/gdcmDicomDir*.[cxx|h]: coding style
1071 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1072 * src/gdcmJpeg8.cxx: doxygen fix.
1073 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1074 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1075 from File:: to PixelConvert::.
1077 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1079 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1080 - more code moved away from File:: to PixelConvert::
1081 - fat setup of PixelConverter set in place in File::Initialise.
1083 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1084 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1085 namespace at the file system level. So now you should convert your examples
1087 gdcmHeader -> gdcm::Header
1088 It would be nice if people keep in mind to no open the namespace, since it
1089 allows compilation on broken plateform which were defining common symbol in
1090 the standart namespace (like LP, Unknown ...)
1092 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1094 The JPEG fragments are now parsed at the same stage than the RLE
1095 information. All code related to JPEG is now in gdcmPixelConvert:
1096 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1097 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1098 export a gdcmFile:: method. Those are simply global functions
1099 (for the time being this is better than having them attach to
1100 either gdcmFile:: or gdcmPixelConvert::).
1101 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1102 and stores the result in a gdcmJPEGFragmentsInfo.
1103 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1104 code (among other stuff) moved away from gdcmFile:; to
1107 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1109 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1110 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1111 clean up of RLE related code.
1112 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1113 - src/gdcmRLE.cxx removed
1114 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1115 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1116 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1117 * CLEANUP_ROUND (9) for gdcmPixelConvert
1118 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1119 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1120 away from gdcmFile:: to gdcmPixelConvert::.
1122 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1124 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1125 This is because Parse7Fe0 used to parse the pixels to compute the
1126 length. This task was passed over to FindDocEntryLengthOB() a long
1127 time ago, EXCEPT I had forgotten the OW case...
1128 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1129 we just recylce the code for parsing RLE fragments and computing
1131 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1132 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1133 with the retired Parse7Fe0().
1134 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1135 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1137 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1138 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1139 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1140 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1141 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1142 * CLEANUP_ROUND (4) for gdcmPixelConvert
1143 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1144 to return an unused length.
1146 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1147 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1148 this should be cleanner from the plane view. The iostream are erally a pain
1149 to use to do simple stuff.
1151 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1152 * Redo the compilation of the ijg jpeg library. Now only one source is
1153 necesseray. No need to rename file by hand what so ever. CMake handle the
1154 copying of the file within different directory, configure header file to
1155 modify some symbol. The only addition made to ijg wasd a mangle table so
1156 that symbol are different whether we are within 8bits or 12bits.
1158 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * Added documentation of vtkgdcmReader on Website:
1160 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1161 with it's binary name).
1162 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1163 the Website to be more complete.
1164 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1165 doxygenated documentation.
1166 - Doc/DoxyVtkGdcmReaderExamples.txt added
1167 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1168 DoxyVtkGdmReaderExamples.html )
1169 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1170 * CLEANUP_ROUND (3) for gdcmPixelConvert
1171 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1173 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * CLEANUP_ROUND (2) for gdcmPixelConvert
1175 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1177 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * CLEANUP_ROUND for gdcmPixelConvert:
1179 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1180 - src/gdcmPixelStuff[h|cxx] removed
1181 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1182 - src/CMakeLists.txt changed accordingly
1183 * GDCMHOME clean up:
1184 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1185 gdcmVersion.py moved to newly created ATTIC related
1186 gdcmPython/SetupOldies/ directory.
1187 * Autotools clean up:
1188 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1189 - autogen.sh configure.in acinclude.m4 python.m4 removed
1191 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1193 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1194 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1196 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * TODO updated with Mathieu suggestions. I proposed a template for
1198 describing TODO entries and used it for new entries.
1199 * Added Doc/Website/CodingStyle.html, Developpers.html,
1200 DeveloppersPython.html, GdcmDataCvs.html and
1201 DownloadVersion0_1.html, DownloadVersion0_3.html.
1202 * Some Doc/*.txt Doxygen files (which do not really concern the
1203 documentation itself, but the website) moved to html and
1204 placed in directory Doc/Website:
1205 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1206 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1207 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1208 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1209 * CMakeLists.txt changed accordingly.
1210 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1211 DeveloppersPython.html
1212 * INSTALL nows refers to Doc/Website/Installation.html
1214 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * Added Doc/Website directory, that contains a first raw version
1218 2004-09-23 Jean-Pierre Roux
1219 * FIX In order not to be poluted any longer by casting problems,
1220 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1221 we can now delete[] it safely
1222 * VoidArea is now called BinArea (less confusing name),
1223 and all the methods called ...VoidArea... are now ... BinArea...
1224 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1226 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1228 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1229 up to the destructor of gdcmElementSet to clean up TagHt and it's
1232 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1234 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1236 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * ENH: added some utility method that builds a flat dictionary
1238 holding all the Dicom entries contained in the recursive structure
1239 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1240 an example of usage.
1241 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1242 BuildFlatHashTable() that build a flat dictionary.
1243 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1244 gdcmDocument is now a friend of gdcmElementSet.
1245 - src/gdcmElementSet.cxx: clean up.
1246 - Example/FlatHashTablePrint.cxx added.
1247 - Example/CmakeLists.txt changed accordingly
1249 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1251 moved away from gdcmDocEntrySet (since this class is an abstract class
1252 acting like an interface). SQDepthLevel and BaseTagKey are now
1254 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1255 and associated accessors. Doxygenation of the class.
1256 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1258 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1259 Use SQDepthLevel accessor instead. ::Print() adapted.
1260 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1261 - src/gdcmDocument.cxx changed accordingly.
1263 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1264 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1265 - The following is the doxygen comment of the typedef declaration
1266 of gdcmTagKey in src/gdcmCommon.h:
1267 gdcmTagKey is made to old an "universal" (as in URL, Universal
1268 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1269 A dicom tag always has a group and an element, but a set of tags
1270 embeded in various (optionally nested) sequences and sharing
1271 the same group and element all share the same (group, element)
1272 "identifier". Hence the (group, element) cannot be used as an
1273 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1274 In order to construct a proper tag identifier (i.e. a key) we
1275 consider the following definition of a TagKey:
1276 - let Group, Element be the string representation of the
1277 group and element dicom tag members,
1278 - let ItemNumber be the string representation of the integer
1279 index of the considered item number of a sequence,
1280 Let the key of a tag embeded in a sequence, noted SeqTag, be
1282 /ItemNumber#Group|Element
1283 where "/", "#" and "|" are characters acting as separators.
1284 Then the general form of a gdcmTagKey is given by:
1285 Group|Element<SeqTag>
1286 where <SeqTag> means NO or many instances of SeqTag.
1287 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1290 but the gdcmTagKey of a tag "embeded" is the first item of
1291 a sequence, itself nested in the third item of a sequence is the
1293 0004|1220/2#0008|0082/0#0008|0090
1294 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1295 order to hold the new sequence compatible key. Previously, the
1296 GetKey() method would look in the underlying gdcmDictEntry.
1297 - src/gdcmDocEntry.cxx:
1298 -- constructor now copies the underlying DictEntry key, in the local
1300 -- ::Print: displays the member Key, instead of the (group, element).
1301 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1302 - src/gdcmDocEntrySet.h:xi
1303 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1304 -- now has a new BaseTagKey member.
1306 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1307 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1309 This poses the problem with the semantics of the following lines
1310 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1311 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1312 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1313 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1314 to the long FIXME note for what the problem is. Nevertheless in
1315 order to get things working the dicom dictionary was altered !
1316 Please fix things urgently...
1317 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1318 information), see above note on moving the member VoidArea. Nevertheless
1319 the following entries previously correctly set as US are now inproperly
1321 0028 1201 OW IMG Red Palette Color Lookup Table Data
1322 0028 1202 OW IMG Green Palette Color Lookup Table Data
1323 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1324 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1325 of gdcmDocEntry moved to gdcmSeqEntry.
1326 * src/gdcmSeqEntry.cxx: STYLE.
1328 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1329 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1331 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * gdcmPython/testSuite.py: all the test suite in python is now moved
1333 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1334 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1335 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1337 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1339 to avoid inclusion recursion until STL is reached.
1340 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1341 mecanism. errno.h is not included in gdcm anymore.
1342 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1343 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1345 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1346 gdcmData/TestAllEntryVerifyReference.txt
1347 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1348 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1349 exception_on_error parameter.
1350 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1351 - vtk/vtkGdcmReader.cxx changed accordingly,
1352 - Example/*.cxx and Test/*.cxx changed accordingly.
1354 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1355 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1356 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1357 enable_sequences removed from gdcmHeader constructor and dependencies.
1358 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1359 * gdcmPython/demo/PrintHeader.py: dummy fix.
1360 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1361 skip_shadow removed from gdcmHeader constructor and dependencies.
1362 * Example/*.cxx and Test/*.cxx changed accordingly.
1364 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1366 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1368 2004-07-21 Jean-Pierre Roux
1369 * FIX Now, Parsing and Printing a DICOMDIR do work!
1370 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1372 2004-07-20 Jean-Pierre Roux
1373 * FIX Some brain damaged headers have Zero-Lenght fields
1374 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1376 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1377 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1378 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1379 variable (instance of gdcmDebug) by a definition macro, and the instance
1380 is now in static in the gdcmDebug class
1381 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1382 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1384 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * WARNING: ctest now depends more tightly on gdcmData. You should
1386 check out gdcmData properly for things to run smoothly...
1387 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1388 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1389 we need the pixels not be loaded in order to use the ValEntry
1390 that displays position and size).
1391 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1392 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1393 be deprecated. If you have any doubts about the advantages of a
1394 modern scripting language (read Python) versus grass root C++ (i.e.
1395 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1396 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1397 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1398 Anyhow, consider documenting the gdcmData images in
1399 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1401 * Test/CMakeLists.txt:
1402 - now uses TestAllEntryVerify.cxx
1403 - specific comments on oldACR00001.ima (now renamed in gdcmData
1404 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1405 gdcmData/TestAllEntryVerifyReference.txt
1408 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/*.[h|cxx] : typedef clean up
1410 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1411 - TagKey renamed to gdcmTagKey (for external usage)
1412 - VRKey renamed to gdcmVRKey (for external usage)
1413 - removal of typedef duplication.
1414 - Removed all unecessary inline keyword from class inline definitions.
1415 - Some method|function(void) declarations replaced with method|function().
1416 * src/jpeg/libijg12/jdhuff12.c:
1417 - printf polluting ctest removed.
1418 - TAB removal for comminting
1420 - TestAllReadCompareDicom.cxx: added a test that compares all the
1421 images in gdcmDataImages.h with corresponding images in
1422 gdcmData/BaselineDicom/. When baseline images are not present
1423 this test creates them.
1424 Note: we need to validate each reference image, but before that
1425 I'd like to rename them with a more explicit name...
1426 - CMakeLists.txt: changed accordingly.
1427 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1428 including each header needed).
1430 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1431 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1432 test suite to the Example directory. Are concerned:
1437 - TestWriteSimple.cxx
1438 * Test/CMakeLists.txt: added some comments on reasons for black listing
1439 image gdcmData/oldACR00001.ima
1441 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1442 * Test/CmakeList.txt: removed the following from black list (to be coherent
1443 with removal from gdcmData):
1444 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1445 - gdcm-MR-PHILIPS-16.dcm
1447 Added the following because after last cvs update, they cause
1448 ctest -R TestReadWriteReadCompare
1450 - gdcm-MR-SIEMENS-16-1.acr
1452 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1453 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1454 new comments in this file) we temporarily (sigh) move to a weaker
1456 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1457 we don't need to black list the following images anymore:
1458 - 8BitsUncompressedColor.dcm
1460 - US-PAL-8-10x-echo.dcm
1461 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1462 fixes and the beautified code ;-)
1463 This fixes the bug introduced in version 1.42 (when beautifying)
1464 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1465 Note: ctest was blind to this bug (this means we need to still
1466 improve the test suite). The bug could be detected by using
1467 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1469 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1470 and by displaying the (garbage) produced file temp.XDCM...
1472 2004-06-29 Jean-Pierre Roux
1473 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1474 - replace by uggly but working old code :-(
1475 A lot of things should be OK again.
1476 It's really urgent to have a test suite that *tests*,
1477 to prevent Frog's beautifying sessions to break all the stuff
1478 (twice, withing a fortnigh ...)
1480 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1481 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1482 redundancy) to added Test/TestReadWriteReadCompare.cxx
1483 * Test/CmakeList.txt: because the compare test of
1484 Test/TestReadWriteReadCompare.cxx fails, the following images are
1485 black listed: - 8BitsUncompressedColor.dcm
1487 - US-PAL-8-10x-echo.dcm
1488 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1489 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1490 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1491 and ad-hoc kludge. This kludge is now removed, and on encountering
1492 such an image (OB field brain damaged) we set errno. Then in
1493 ::FindDocLength() we "fix" the length as being ALL what remains
1494 in the file (until EOF). We then proceed, hoping for the best...
1495 This fixes a SegFault in ShowDicom when trying to write such an
1497 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1498 (because TestWriteRead breaks on it, after a non conformal commit?).
1499 ctest now runs properly, except for MakeDicomDir (which was always
1500 broken) and the Python related stuff (still not fixed).
1502 2004-06-24 Jean-Pierre Roux
1503 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1504 FIX : Test/TestReadWrite now iterates on all the file names
1505 (instead of infinite loop)
1506 ENH : Test/TestWriteRead now iterates on all the file names
1508 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1509 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1511 2004-06-24 Jean-Pierre Roux
1512 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1513 when SamplesPerPixel =3
1514 - now Write is no longer confused by
1515 'BitsAllocated = 12" and 'BitsStored=12"
1516 - "UN" value representation Elements are now written correctly
1517 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1518 ENH : - now gdcmHeader has its own Write methods
1519 (in order to split the job that has not to be done
1522 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1523 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1524 loop on the same image until memory went out.
1525 Note: this means we still have gobs of memory loss in PrintDocument
1526 * src/gdcmDocument.cxx: fixes problem on parsing on file
1527 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1529 2004-06-24 Jean-Pierre Roux
1530 FIX : Write - All the Sequences and Sequence Item are now written
1531 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1532 is added a the end, when necessary.
1533 - A lot of brain-damaged images, that were read correctly are
1534 now written correctly
1535 - length compatible BinEntry are now loaded correctly
1536 (even for odd groups)
1537 Note : only Explicit Value Representation was checked.
1538 (question : is implicit VR really necessary for gdcm ?)
1540 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1541 * DEVELOPPER: added a proposition of coding style.
1542 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1545 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1547 Use the gdcmDocEntry::Print() and Write() instead.
1548 * src/gdcmDocument.cxx: bug fix.
1550 2004-06-22 Jean-Pierre Roux
1551 FIX : gdcmDocument.cxx
1552 - Now we do recognize the JpegLossLess format (there was a misstyping in
1553 code 'beautyfication' :-(
1554 - Now we automaticaticaly load the Luts, if any
1556 2004-06-22 Jean-Pierre Roux
1557 In order : to write Sequences, whatever their imbrication level,
1558 : to allow user to create his own Sequences
1559 a lot of modif where necessary (adding, moving, or virtualising methods)
1561 WARNING : save your own sources *before* cvs up !
1564 ADD virtual void Write(FILE *fp, FileType filetype);
1567 ADD virtual void Write(FILE *fp, FileType filetype);
1568 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1571 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1572 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1573 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1574 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1575 ADD std::string GetEntryByName(TagName name);
1576 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1578 std::string vr = "unkn",
1579 std::string fourth = "unkn",
1580 std::string name = "unkn");
1581 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1582 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1583 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1584 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1585 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1586 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1587 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1588 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1591 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1592 ADD virtual std::string GetEntryByName (TagName tagName);
1593 ADD virtual std::string GetEntryVRByName (TagName tagName);
1594 REM virtual bool Write(FILE *, FileType);
1595 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1596 FILE *_fp, FileType type);
1597 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1598 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1599 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1600 REM virtual std::string GetEntryByName (std::string tagName);
1601 REM virtual std::string GetEntryVRByName (std::string tagName);
1602 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1603 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1604 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1606 std::string vr = "unkn",
1607 std::string fourth = "unkn",
1608 std::string name = "unkn");
1609 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1610 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1611 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1612 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1615 ADD virtual void Write(FILE *fp, FileType filetype);
1618 ADD virtual void Write(FILE *fp,FileType filetype);
1621 ADD virtual void Write(FILE *fp, FileType filetype);
1622 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1623 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1624 REM std::string GetEntryByName(TagName name);
1627 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1629 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1631 The default constructor invoked by the line
1632 gdcmHeader *f1 = new gdcmHeader( header );
1633 was gdcmHeader::gdcmHeader(bool) instead of the expected
1634 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1635 Hence the parsing wasn't executed... See also below.
1636 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1637 as explicit constructor didn't do the trick to fix the above problem.
1638 Could anyone explain why ?
1639 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1640 properly calls gdcmValEntry::Print() (that was weed out from
1641 code related to gdcmBinEntry).
1643 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * In order to fix memory leaks:
1645 - Test/TestWriteSimple.cxx: added cleaning of free store through
1647 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1648 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1649 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1650 (through the call to ::AddDicomDirMeta()) or the destructor
1651 would crash when deleting uninitialized ::metaElems].
1652 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1653 - src/gdcmDocument.cxx:
1654 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1655 from dynamic stores.
1656 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1657 was causing memory leaks.
1658 - src/gdcmSQItem.cxx:
1659 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1660 cleanly handled with polymophism: sorry but my milage is low).
1661 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1662 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1663 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1664 This avoids SegFaulting.
1665 - src/gdcmSQItem.h: coding style.
1667 - Test/TestWriteSimple still severely sucks. The output image content
1668 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1669 damaged when displayed with vtkgdcmViewer.
1670 - on memory leaks: TestWriteSimple leaks really less (see entry
1671 of 2004-06-18 in Changelog file for the call to valgrind).
1672 - on segfaults: ctest now passes all the tests but one (no more
1674 * Erroneous leading white fix:
1675 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1676 white[s] (as opposed to from >> xxx, that removes it [them].
1677 - src/gdcmTS.cxx: ditto.
1678 - gdcmPython/testSuite.py: dirty related kludge removed.
1679 * src/*: remaining references to gdcmParser removed.
1680 * src/*[cxx|h]: added copy[way]left header.
1683 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * In order to fix writing of dicom files:
1685 - Test/TestWriteSimple.cxx: a simpler example of writing.
1686 - Test/CMakeLists.txt changed accordingly.
1687 - src/gdcmDocument.cxx:
1688 -- The destructor now recursilvely removes potential sequences.
1689 -- Bug fix in ::IsJPEG2000()
1690 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1691 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1693 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1694 to only declared) and build on top of
1695 ::GetDocEntryByNumber(guint16, guint16).
1696 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1697 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1698 for usage in destructor and treatement of promotion in
1699 ::ReplaceOrCreateByNumber().
1700 - src/gdcmSQItem.cxx: destructor should better handle his job.
1701 Test/TestWriteSimple now runs (or at least it DOES something).
1702 * We can now start hutting memory links. A good starting point is:
1703 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1704 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1705 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1707 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1708 * Valgrind note: after Mathieu Malaterre teached me how to read
1709 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1711 Using gcc, you can force the STL to use malloc and to free memory as
1712 soon as possible by globally disabling memory caching.
1713 With 3.2.2 and later, you should export the environment variable
1714 GLIBCPP_FORCE_NEW before running your program.
1715 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1716 simply vanish (it is still not clear to me, whether this means that
1717 STL std::string leaks or if valgrind believes it leaks...).
1718 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1719 running bin/gdcmTests makeDicomDir):
1720 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1721 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1723 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1724 SegFaulting (I drowned in DicomDir related code when trying to
1725 understand why the list is empty...).
1726 * src/gdcmDocument.h: first BSD license header try.
1727 * Doc/License.txt added.
1729 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * src/gdcmDocument.[h|cxx]:
1731 - Clean up of the Transfer related predicates. They are now all based
1732 on new method isGivenTransferSyntax, that (should) handle properly
1733 the padding problem.
1734 - general clean up, simplification, and coding style.
1735 - Specific clean up of Parse7FE0() (umproperly named actually).
1736 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1738 2004-06-14 Jean-Pierre Roux
1740 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1741 - fix the display of SQItem ordinal number
1742 - add the GetSQItemByOrdinalNumber method
1743 - remove some useless never written private methods
1745 2004-06-14 Jean-Pierre Roux
1747 - adding a constructor taking a gdcmDocEntry as an input param
1748 - ReplaceOrCreateByNumber now returns :
1749 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1750 a gdcmValEntry * if a string value is passed as a param
1752 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1753 according to the param type (no longer sets a gdcmDocEntry)
1754 - GetValEntryByNumber, GetBinEntryByNumber added
1755 - NewValEntryByNumber and NewBinEntryByNumber added
1757 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1759 - GetSQItemNumber and SetSQItemNumber added, to provide
1760 a (relative) Item identier inside a given Sequence
1761 \warning : some pb remaining around this number
1763 - AddEntry now takes the Item Number as a param
1765 - adding a constructor taking a gdcmDocEntry as an input param
1767 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1768 * Memory leak hunt with the following command:
1769 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1770 --show-reachable=yes gdcmTests PrintDocument
1771 It looks like many (all?) leaks are due to the STL (or a bad usage
1772 of the STL. The lines producing the leaks now have a comment with
1773 a "MEMORY LEAK" tag: you can retrieve them with
1774 grep "MEMORY LEAK" src/*
1775 Here are two typical examples which I can't help fixing:
1780 char * test = "babo";
1781 name = test; //// <--- valgrind detects 960 bytes lost in
1782 //// call to std::string::operator=(char const*)
1783 name.clear(); //// Doesn't help !
1791 std::cout << "Type a bunch of characters followed by RETURN: ";
1792 getline(std::cin, line); //// <--- valgrind dectects a loss
1793 //// of 1320 bytes in call to
1794 /// std::basic_istream<>& std::getline<>
1800 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1801 * src/gdcmHeader.[cxx|h]:
1802 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1803 and related, moved away to gdcmDocument.
1804 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1805 the corresponding protected accessors of inherited class
1806 gdcmDocument, removed ! As a consequence gdcmFile had to be
1807 declared friend of class gdcmDocument (see below).
1808 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1809 - Clean up of undefined or unused methods.
1810 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1811 account the changes to gdcmHeader.h).
1812 * src/gdcmDocument.h:
1813 - gdcmFile is now a friend class (in order to take into account the
1814 changes to gdcmHeader.h).
1815 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1816 (see changes to gdcmHeader.h).
1817 - Accessors (reading on the form GetEntry*) are now public.
1818 - Clean up of undefined or unused methods.
1819 * src/gdcmDocument.cxx:
1820 - adaptation to changes to gdcmDocument.h
1821 - ::OpenFile now writes a verbose message when file cannot be opened.
1822 - some std::string properly set to VRKey
1823 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1824 references to gdcmDocument.
1825 * Test/TestFindTags.cxx: changed accordingly to above changes.
1826 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1827 cvs repository gdcmData.
1829 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1830 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1831 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1832 conflicts with gdcmValEntry::voidArea.
1833 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1834 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1835 Value representation between StringRepresentable and BinaryRepresentable.
1836 * src/gdcmDocument.cxx:
1837 - method ParseDES: proper indentation restored and usage of
1838 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1839 - method LoadDocEntry: the fingerprint left in the SetValue() of
1840 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1841 removed. Reverting to previous code segment with the proper
1842 dynamic_cast< gdcmValEntry* >.
1843 Note: this was (partially) breaking the python test suite
1844 (gdcmPython/testSuite.py) that made usage of the above
1845 fingerprint to check presence of "Pixel Data".
1846 * src/gdcmDocEntry.h: coding style.
1847 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1848 now taken into account.
1849 * gdcmPython/gdcm.i: adaptation to the new internal representation
1850 of gdcm (exit gdcmParser, hello gdcmDocument).
1851 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1853 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1854 anymore, but instead prints the loaded Python dictionary.
1855 * .... alas, the python testSuite is still broken.
1857 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1858 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1860 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1861 * src/gdcmUtil.h : export methods
1863 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1864 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1866 * Initial addition of automatic python testing
1867 * Initial addition of automatic image comparison
1869 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1870 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1871 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1873 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1874 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1875 * Test/ShowDicom.cxx : bug fix for msvc compilation
1876 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1878 2004-05-04 Jean-Pierre Roux
1879 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1880 new concepts (and new classes) :
1881 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1882 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1883 - Sequence Doc Entries (gdcmSeqEntries)
1884 a Sequence is composed of Items.
1885 Each item is a set of Doc Entries (this is recursive)
1886 The non uniqueness of the 'Dicom tag' is due to this recursivity
1887 (never taken into account)
1888 Our unability to add a new 'entry' in the header
1889 at the proper location (neither in the H-Table (map or multimap),
1890 nor in the Chained List is also due to this recursivity.
1891 Don't try, right now, to use/modify/compile these new sources :
1892 nothing is finished.
1893 We just commit all the stuff, 'as is', in order not to loose it.
1895 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1898 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1899 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1900 file prefix (SetFilePrefix)
1902 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * Add a new test: ShowDicom, for now this is just the c++ version of
1904 checkRead.sh, later it will be able to compare the image read against a
1906 * Replace the DEBUG on the stack with a global entry in cmake interface:
1907 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1909 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1910 * Add an example subdir, with a real example on how to read + write a
1913 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1915 * Doc/CMakeLists.txt: the main page is now properly differentiated
1916 between the developper and user version.
1917 * Doc/doxygen.config.in: dropped search related obsolete flags
1918 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1920 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * DEVELOPPER: added some helpfull comments for compile/test/install
1924 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1925 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1926 src directory, now generated in the build dir.
1927 2. Tests as mentionned smarter
1929 4. Add a new method in gdcmDict that return the PubDict by name
1930 this is interesting for 3rd party lib like ITK,
1931 where we could set the institution name / patient name...
1933 * ENH: 1. Now the test suite is working for real
1934 2. All binaries are now output in the gdcm-bin directory
1935 (this was not true before)
1937 2004-04-28 Jean-Pierre Roux
1938 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1939 SeQuence indented printing of Dicom Header.
1940 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1941 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1942 Computation of SQDepthLevel is now part of gdcmHeader constructor
1943 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1944 tree-like structure of a Dicom Header.
1945 * FIX Test code cleaning
1947 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * ENH: Adding automatic testing
1949 1. Need a DartConfig.cmake to submit to public
1950 2. Add a test driver gdcmTest.cxx
1951 3. gdcmTestMain, an helper for the main test driver gdcmTest
1952 4. Files in Test don't have a main anymore, this becomes interesting
1953 when we add more and more tests, thus dsw don't have to load
1955 * ENH: Adding a GDCM_DATA_ROOT for testing
1956 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1957 one file instead of seven + some small cleanup
1959 2004-04-22 Jean-Pierre Roux
1960 * ENH Minor changes to the Print() methods.
1961 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1962 Header printing. Example given with :
1963 > PrintHeader fileName 2 new
1964 (SQ based tree-like structure still to be done for the Header ...)
1966 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1968 1. I have added some unsigned where needed
1969 2. Some function parameter not used -> (void)
1970 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1971 4. g++ don't like character '\' in comment
1972 5. #define jpeg_create_decompress jCreaDecompress
1973 this really need to be fixed
1974 6. virtualize destructor of gdcmObject ... leakage
1975 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1976 this also really need to be fixed
1977 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1978 remove compression file
1979 (as we only do decompression, right ?)
1980 * ENH: Change malloc/calloc/free with c++ equivalent
1982 2004-04-21 Jean-Pierre Roux
1983 * FIX gdcmHeaderHelper::GetXSpacing
1984 when a single value is found (bug ?), xpacing is now
1985 defaulted to yspacing
1987 2004-04-19 Jean-Pierre Roux
1988 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1989 * ENH add parameters :
1990 bool exception_on_error = false,
1991 bool enable_sequences = false,
1992 bool ignore_shadow = false
1993 to the gdcmFile constructors to be full gdcmParser compliant
1994 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1995 to allow reading of PAPYRUS 3.0 files
1997 2004-04-06 Jean-Pierre Roux
1998 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2000 2004-04-02 Jean-Pierre Roux
2001 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2002 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2003 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2005 2004-03-30 Jean-Pierre Roux
2006 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2007 for ACR file, written out as DICOM files (hope so...)
2009 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2011 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2012 moved to base class gdcmParser and only the specialisation is kept
2014 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2015 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2016 already does the job.
2017 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2018 (to be consistent with gdcmParser::WriteEntries).
2020 2004-03-30 Benoit Regrain
2021 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2022 upate of the object's instance. It's passed to 2 in the unfavorable
2023 case : one in the ExecuteInformation, one in the ExecuteData
2025 2004-03-29 Jean-Pierre Roux
2026 * ENH : Check on file type to be written moved
2027 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2028 * FIX : gdcmObject::ResetBoundaries now stops properly
2029 when end-of-list is reached
2030 : gdcmVersion modified (as Benoit Regrain asked)
2032 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2033 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2034 * src/gdcmUtil.cxx: added forgotten iostream include.
2035 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2036 equivalent to ExplicitVR in existing code).
2038 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2040 now contains all the gdcmGlobal related code.
2041 * minor coding style and doxygenation changes.
2043 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2045 now contains all the Debug related code.
2046 * minor clean-up of includes in src/*.cxx
2047 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2048 CreateCleanString) removed.
2049 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2050 * Doc/DoxyMainPageUser.txt added.
2051 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2052 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2053 src/gdcmDirList.cxx)
2055 2004-03-24 Jean-Pierre Roux
2056 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2058 2004-03-23 Jean-Pierre Roux
2059 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2060 big endian made volumes
2061 * ENH Now gdcmParser constructor and destructor are protected to forbid
2062 end user to instanciate class gdcmParser
2063 (only gdcmHeader and gdcmDicomDir are meaningfull)
2065 2004-03-22 Benoit Regrain
2066 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2067 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2068 gdcmSerie to gdcmDicomDirSerie
2070 2004-03-19 Jean-Pierre Roux
2071 * ENH Now the tree-like structure describing a DICOMDIR comming from
2072 an already existing DICOMDIR file is consistent with
2073 the home-made tree-like structure build ex-nihilo
2074 or build from the files held (recursively) in a Directory
2075 functions gdcmDicomDir::CheckBoundaries()
2076 gdcmObject::SetBoundaries() added
2078 2004-03-17 Jean-Pierre Roux
2079 * REM (Eric Boix bug) : removal of meaningless
2080 gdcmDicomDirImage::NewImage function.
2081 * FIX now file names and directory name are written properly in the
2083 * FIX now gdcmDicomDir constructor may be call without any trick
2086 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2087 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2088 of gdcmDicomDirImage::NewImage as empty function.
2090 2004-02-28 Jean-Pierre Roux
2091 * ENH add gdcmDicomDir:NewPatient
2092 add gdcmDicomDirPatient:NewStudy
2093 add gdcmDicomDirStudy:NewSerie
2094 add gdcmDicomDirSerie:NewImage
2095 to allow making gdcDicomDir object.
2096 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2097 (as opposite to the gdcmHeader chained list)
2099 2004-02-11 Benoit Regrain
2100 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2101 when using from python
2103 2004-02-10 Benoit Regrain
2104 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2105 * FIX : in gdcmDicomDir when the directory is empty
2106 * ENH : add callback and methods to get the progression of dicomDir
2109 2004-02-06 Jean-Pierre Roux
2110 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2111 - GDCM_META added to gdcmDicomDirType
2112 - class gdcmMeta created
2113 * ENH : - A brief summary is now displayed at the beginning of
2114 'testDicomDir' to help disaster magnitude estimation
2115 * REM : Now useless Test/explDICOMDIR.cxx
2117 2004-02-05 Benoit Regrain
2118 * ENH : add methods in gdcmObject to get the hash table or the list of
2120 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2121 * FIX : wrapping python for TagHeaderEntryHT
2123 2004-02-04 Benoit Regrain
2124 * FIX : even length for some strings when writting the dicom dir
2125 * FIX : sort the images in the dicom dir
2126 * FIX : Bug fix for python use of dicom dir
2127 * ADD : a python demo
2129 2004-02-04 Jean-Pierre Roux
2130 * FIX : Final solution (?) for icone embedded images
2131 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2132 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2133 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2134 gdcmData/gdcm-MR-SIEMENS-16.acr1
2135 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2136 to make full checking easier
2138 2004-02-04 Benoit Regrain
2139 * FIX : WriteEntries : coding style & logic in parameters
2140 * FIX : Set the elements to create the DicomDir in a dictionary file
2142 2004-02-03 Benoit Regrain
2143 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2144 * gdcmDicomDir : add the load of directory
2145 * Bug fix and print add-on
2147 2004-02-03 Jean-Pierre Roux
2148 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2149 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2150 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2151 * FIX gdcmParser.cxx : 'group length' elements are now considered
2152 as integers, even for shadow groups, when file is Implicit VR
2154 2004-02-02 Jean-Pierre Roux
2155 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2157 of the last synonym :-(
2158 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2160 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2161 * FIX taking into account the possible 7fe0,0010 multiplicity
2162 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2163 to allow removal of references to 7fe0,0010, to deal with
2164 ACR-NEMA images, when 0028,0200 is meaningfull
2166 2004-01-31 Jean-Pierre Roux
2167 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2168 no longer writes 'Un' on disk
2169 * FIX SQ elements with actual length are now dealt with corectly
2170 * FIX gdcmFile::WriteBase make the difference, for color images, between
2171 the length (for Palette expanded images)
2172 and Raw Length (non expanded image + Palette)
2173 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2174 (that broke Write). Replaced by UL.
2175 Aware user will reload the field if he
2176 thinks it's necesssary
2178 2004-01-30 Jean-Pierre Roux
2179 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2180 when 'dirty Acr' is found, to be compliant with the new
2181 IsReadable() methods.
2183 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2184 (no DOUBLE images in kosher DICOM,
2185 but so usefull for people that miss them ;-)
2187 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2188 DICOMDIR related utilities (not checked as Windoze compliant)
2190 2004-01-28 Jean-Pierre Roux
2191 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2193 2004-01-27 Jean-Pierre Roux
2194 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2195 to allow skipping the shadow elements, to save memory space.
2196 The TRUE value for this param has to be used
2197 with a FALSE value for the 'enable_sequence' param.
2198 ('public elements' may be embedded in 'shadow Sequences')
2199 * gdcmHeader methods now deal with 'embedded icones images' in the header
2200 (even when an 'icone image sequence' is announced by the
2201 element (0x0088,0x0200), but there is NO icone at all ...
2203 * gdcmHeader sometimes Image Location value doesn't follow
2204 the supposed processor endianity (see gdcmData/cr172241.dcm).
2207 * gdcmHeader add the method
2208 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2209 to get *all* the Header Entries with the same tag.
2210 GetHeaderEntrySameName is probabely *useless*
2211 (no meaning : Name is *not* an identifier within the Dictionary)
2213 2004-01-26 Benoit Regrain
2214 * Bug fix in the print of hexadecimal representations. Remove long fields
2215 in the print and add a third level of print to print them
2217 2004-01-23 Benoit Regrain
2218 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2219 * Bug fix on test suite after remove the strip made on not string fields
2220 * Split the IsReadable method between gdcmParser which test that the file
2221 is dicom and gdcmHeader which test that it's an image file
2223 2004-01-22 Benoit Regrain
2224 * DicomDir : clean code, add methods, set variables in protected or private
2225 * gdcmUtil : bug fix for the clean string method
2227 2004-01-19 Benoit Regrain
2228 * Add the use of shadow dictionaries
2229 * bug fix and coding style
2231 2004-01-19 Benoit Regrain
2232 * src/gdcmFile.cxx : bug fix concerning the close of file
2233 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2234 * Add the update of header entries using the shadow library
2236 2004-01-19 Benoit Regrain
2237 * removal of file gdcmHeader2.cxx
2238 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2239 inheriting from gdcmParser. This split is to prepare the integration
2240 of dicom dir parsing
2241 * bug fix under python
2243 2004-01-16 Jean-Pierre Roux
2244 * REM removal of class gdcmHeaderEntrySet
2245 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2246 * ADD add file gdcmHeader2.cxx
2247 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2249 2004-01-15 Benoit Regrain
2250 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2251 entries created while parsing the header. Thus, they will be destroyed
2252 when the gdcmDictSet will be destroyed
2253 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2256 2004-01-15 Benoit Regrain
2257 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2258 made a fatal error because of the memory release at the end of program.
2259 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2260 some memory and vtk seems to have some problems with that.
2261 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2263 2004-01-14 Benoit Regrain
2264 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2265 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2266 * src/*.[h|cxx] : make changes due to class name changes
2267 * gdcmPython/demo/*.py : bug fix due to method names
2269 2004-01-13 Benoit Regrain
2270 * src/*.[h|cxx] : coding style
2271 * vtk/*.[h|cxx] : coding style
2273 2004-01-13 Benoit Regrain
2274 * gdcmPython/testSuite.py : test the readable flag of file for tests
2275 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2276 It's lied to the stl compilation by MSVC (windows, always windows...)
2277 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2279 2004-01-12 Benoit Regrain
2280 * src/*.h : add comments
2281 * src/gdcmDictSet.h : set the method BuildDictPath in public
2282 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2283 directly setted in the source code
2284 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2287 2004-01-09 Benoit Regrain
2288 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2289 * setup.py : use a reference to gdcmVERSION
2291 2004-01-07 Benoit Regrain
2292 * Modification to compile with the distutils.
2295 2003-12-10 Benoit Regrain
2296 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2297 can use a gdcmHeaderHelper to load data
2298 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2299 made in the source code
2301 2003-12-10 Benoit Regrain
2302 * Update Windows projects and .cvsignore files
2304 2003-11-12 Jean-Pierre Roux
2305 * ENH gdcmHeader constructor has one more parameter (default value : false)
2306 that allows the user to 'go inside' the SeQuences only
2308 gdcmElValSet:Print takes it into account
2310 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * ENH: Update gdcmPython/CMakeLists
2312 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2313 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2315 2003-11-10 Jean-Pierre Roux
2316 * FIX : gdcmHeader::LoadElements is now based
2317 on the ListTag listElem member,
2318 not longer on the TagElValueHT tagHt member
2319 * ENH : PrintPubElVal shows (temporarily) both results,
2320 with the tagHt member and the listElem member.
2321 (it's easier to 'see' the problems when using Printheader)
2323 * FIX : old private member LgrElem is now splitted into
2324 ReadLength : Length actually found on disk (updated only
2325 if bug fixing is necessary), for internal
2327 UsableLength : Updated by FixFoundLength, to fix a bug
2328 or to allow Parser going on.
2329 Will allow to re-write a kosher header when a SeQuence
2330 with a length (not 0000) is found
2331 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2332 because gdcmElValSet::Add does not update ListElem
2335 2003-11-07 Jean-Pierre Roux
2336 * FIX misstyping in Transfert Syntax name table
2337 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2338 when they have an actual length (not 0000 nor FFFFF)
2339 (Nobody should care of it, but DICOMDIR explorers)
2341 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2342 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2344 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2345 * ENH: vtkGdcmReader now supports LUT !
2346 (vtkgdcmViewer for now is not able to use them though)
2348 2003-11-05 Jean-Pierre Roux
2349 * in testSuite.py : new files names for checking the package
2350 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2351 that returns the pixel area size to the *aware* (vtk) user
2352 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2354 2003-11-05 Benoit Regrain
2355 * in testSuite.py : Modify the rules for checking the paths
2356 : Explicit error messages
2357 * in __init__.py : Related modif
2359 2003-11-03 Jean-Pierre Roux
2360 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2361 to be used by aware (vtk) users that want to manage
2362 LUT (and no to turn the PALETTE image into an RGB pixels one)
2363 * GetPixelType now returns 8U for 24 Bits images
2364 (vtkGdcmReader compliant)
2366 2003-10-31 Jean-Pierre Roux
2367 * Removal of *all* gdcmData images and add them again
2368 in order to loose the 'history' of un-anonymised images
2370 2003-10-31 Jean-Pierre Roux
2371 * RMV : removal of useless jBitsInJsample.h
2372 for both 8 and 12 Bits JPEG Lossy Libraries
2374 2003-10-31 Jean-Pierre Roux
2375 * ENH : Add the functions gdcmFile::GetImageDataRaw
2376 gdcmFile::GetImageDataIntoVectorRaw
2377 that act as GetImageData and GetImageDataIntoVector
2378 except the making of an RGB Plane from Gray Plane + LUT
2379 Intended to aware (vtk) users who know how to manage
2382 GetLUTRGBA return a R,G,B,A LUT if any
2383 lgrTotaleRaw gives the 'Raw' length
2384 GetImageDataRaw returns the gray Plane
2385 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2386 (They stay Grey, just like with other Dicom viewers :-(
2388 2003-10-30 Jean-Pierre Roux
2389 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2391 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2392 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2393 being coherents dicom files.
2395 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2398 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2399 * ENH: Two steps is necessary to please VC++ compiler...
2400 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2401 * ENH: Add include dir to medcon lib
2402 * FIX: only one function is being exported for now !
2403 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2405 2003-10-29 Jean-Pierre Roux
2406 * adding gdcmHeader::GetLUTRGBA
2407 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2408 --> Mathieu, the modif u're waiting for is not yet committed
2409 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2411 2003-10-27 Jean-Pierre Roux
2412 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2413 00191113.dcm DermaColorLossLess.dcm
2414 MxTwinLossLess.dcm RadBWLossLess.dcm
2415 * ENH: For version prior to vtkImageViewer2 -r 1.19
2416 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2418 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * Removal of ido stuff in CMakeLists.txt
2421 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2422 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2423 * FIX: remove a call to ->Modified ... see comments
2424 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2426 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2427 * FIX: Problem with path for libvtkgdcmPython
2428 * ENH: Try adding a search script for python site-package
2429 * RMV: Remove some file from medcon lib that are not necessary
2430 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2431 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2432 * FIX: More pragma disable fro VC++,
2433 I don't think I break something as it is also disable in VTK/ITK.
2434 But it fasten debug compilation time.
2436 2003-10-23 Jean-Pierre Roux
2437 * gdcm now deals with 16 Bits Run Length Encoded images
2438 (they are compressed as 2 planes images,
2439 one for the high Bytes, the other for low Bytes)
2441 2003-10-22 Jean-Pierre Roux
2442 * Now CheckRead takes into account :
2443 - the bugged 'Leonardo' Siemens images
2444 - the XA images, sent thru the burning VPRO station
2445 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2448 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * FIX: When copying a Makefile.am to CMakeLists.txt
2450 one should remove the '\'
2452 2003-10-22 Jean-Pierre Roux
2453 * in gdcmData adding a bugged 'Leonardo' Siemens image
2454 (wrong lengths in header)
2455 OK with gdcm, KO with the other viewers :-)
2456 * add a GE dlx XA image, thru the VEPRO burning station
2459 2003-10-21 Jean-Pierre Roux
2460 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2461 for a brutal checking of vtkgdcmViewer compliance
2463 2003-10-21 Jean-Pierre Roux
2464 * add the files for 'xmedcon' Jpeg Lossless library
2465 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2467 2003-10-21 Jean-Pierre Roux
2468 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2470 2003-10-21 Jean-Pierre Roux
2471 * garbage Siemens 'Leonardo' images dealt with
2472 (the patch is easy to remove)
2473 * cosmetic changes to avoid warnings
2475 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2476 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2477 no need to press 'r' now.
2479 2003-10-20 Jean-Pierre Roux
2480 * upgrade of checkRead.sh checkWrite.sh according
2481 to new Jpeg Lossless decompressor
2482 * add US.3405.1.dcm, a genuine RGB medical file ...
2483 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2484 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2486 2003-10-15 Jean-Pierre Roux
2487 * general anonymisation in gdcmData
2488 * adding the 'color files' from
2489 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2490 * adding some well knowed bugged-header images
2491 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2492 waiting for their inclusion in Python testsuite
2494 2003-10-15 Jean-Pierre Roux
2495 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2496 no longer seg faults when file is not found
2498 2003-10-14 Jean-Pierre Roux
2499 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2502 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2503 * TODO: *.in file to genereate a UseGDCM later
2505 2003-10-14 Jean-Pierre Roux
2506 * Some supposed-to-be Dicom Images have no preamble.
2507 OpenFile takes it into account
2508 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2509 * Missing elements added in dicomV3.dic
2510 (just to be affraid : have a look at
2511 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2512 and do it again next year ;->
2514 2003-10-13 Jean-Pierre Roux
2515 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2516 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2517 But there are NOT. It's fixed !
2519 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2520 * FIX: "jpeglib.h" was not found on VC++
2521 * FIX: vtkgdcm was not being installed
2523 2003-10-10 Jean-Pierre Roux
2524 * ENH : OpenFile closes the file if it *really* doesn't look like
2525 an ACR-NEMA / DICOM one.
2526 * FIX : testWrite no longer writes an empty file if the source file
2527 is not gdcm Readable
2528 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2531 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2532 * FIX: CMake generate now documentation
2533 * ENH: out of source doc build !
2534 * ENH: Generate both user and dev documentation
2535 * ENH: Should work on windows too
2536 * ENH: Only one doxygen config.in file is needed
2537 * FIX: make install should be ok now on ùnix plateform
2538 * FIX: PATH to dictionary was wrong (missing /)
2539 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2541 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2542 * vtkGdcmReader is now able to read rgb dicom file.
2543 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2544 * added a gdcmViewer to vtk test, use mouse to control
2545 window level & window width
2547 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * CMake-ification of gdcm, we have now two build system
2549 * FIX: on cygwin Wsock32 doesn't exist
2550 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2552 2003-10-06 Emanuel Ollart
2553 * FIX : compilation process wad broken.
2554 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2556 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * change gdcmViewer -> vtkgdcmViewer
2558 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2560 2003-10-06 Jean-Pierre Roux
2561 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2562 ( e.g : well known GE images with a wrong elem length,
2563 : Philips MRI Images with a wrong Huffman table)
2564 * still to be done : allow the reading of bugged LEONARDO Siemens images
2566 2003-10-03 Jean-Pierre Roux
2567 * Odd length strings are padded with '\0' (not with spaces,
2568 to remain compliant with already defined strings,
2569 like Transfert Syntax UID and others)
2571 2003-10-03 Jean-Pierre Roux
2572 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2573 to allow displaying RGB images (not only by affim ;-)
2575 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * vtkGdcmReader is now able to read rgb dicom file.
2577 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2579 2003-10-03 Jean-Pierre Roux
2580 * A few nasty patches to allow the reading of a lot of nasty images
2581 ( e.g : well known GE images with a wrong elem length,
2582 : Philips MRI Images with a wrong Huffman table)
2583 * still to be done : allow the reading of bugged LEONARDO Siemens images
2585 2003-10-03 Jean-Pierre Roux
2586 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2588 2003-10-03 Jean-Pierre Roux
2589 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2590 to allow displaying RGB images (not only by affim ;-)
2592 2003-10-03 Jean-Pierre Roux
2593 * gdcmFile::GetImageDataIntoVector now
2594 - deals with MultiFrames MultiFragments Run Length Encoded files
2595 - deals with YcBcR (YBR_FULL) files
2596 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2597 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2599 (no sample found :-(
2601 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2602 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2603 Two reasons: - clear things
2604 - third parties acces gdcm through header files, so won't
2605 suffer anymore VC++ complains
2607 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2608 * add argv[1] in testvtkGdcmReader.cxx
2611 2003-09-24 Jean-Pierre Roux
2612 * The lines are now eigthy characters long.for
2613 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2615 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2616 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2617 char* to std::string. Thus, the use of strdup becomes useless. (see
2618 previous commis of Malaterre)
2619 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2620 before the last Malaterre's commit.
2622 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2623 * This commit should fix the Debug building under VC++, the problem
2624 was mainly a mixture of debug and release lib being loaded at startup.
2625 * I also remove a depency to a specific C function: strdup. Because I had
2626 to force the link to msvcrtd (whereas strdup is in libc).
2628 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2629 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2630 located in the gdcmCommon.h file. All use of reference of tha has been
2631 changed to now use the variable GDCM_UNFOUND.
2633 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2635 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2636 Dicom dictionary. The test suite can now be run again. Note:
2637 I'm note very happy with the " (RET)" changes. I believe this
2638 RETAINED comment should be dropped when parsing the dictionary.
2639 - PACKAGER corrected
2641 - AUTHORS updated and now in alphabetical order
2642 * Makefile.am now exports gdcm.dsw for Windoze users.
2644 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2645 * cygwin complains about missing std:: in subdir Test/
2647 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2648 * remove some methods that are now in gdcmHeaderHelper
2650 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2651 * vtkGdcmReader set spacing and origin correctly
2653 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * Fix a few delete/delete[] mismatch
2656 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2658 interpretation to data given by gdcmHeader. For instance there are
2659 heuristics to get informations (look at different places).
2660 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2661 sorting DICOM images based on different strategies.
2662 * modified Makefiles accordingly.
2664 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2665 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2666 when building in debug mode
2667 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2668 src/win32/gdcmdll.dsp
2669 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2671 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2672 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2675 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2676 * src/win32/libgdcmjpeg12.dsp was not dos format
2677 * src/win32/libgdcmjpeg12.dsp :
2678 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2679 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2681 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2682 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2684 * src/gdcmFile.cxx : bug fix in affectation type
2685 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2686 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2687 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2688 symbols... future problem ?
2690 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2691 * src/win32/libgdcmijpeg12.dsp was missing
2692 * modified gdcm.dsw accordingly
2694 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2695 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2697 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2698 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2699 commit of JPR (before his hollidays to facilitate our work).
2700 * setup.py : bug fix in code. Modifications made while the last commit
2701 of JPR. The code hasn't been tested before the commit... it's so
2702 useless to make that (for best programmer that is JPR) !!!
2704 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * tagged the current version as Version0_3 (i.e. version 0.3)
2707 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2708 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2709 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2710 * *.dsp : modifications to use new libgdcmijpeg8 library
2711 * setup.py : bug fix on VTKPATH variable
2712 * PACKAGER : adding all concerning windows
2714 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2717 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2718 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2719 test suite reported error.
2720 * PACKAGER file added (describes what a packager must do when
2721 packaging a new release).
2722 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2723 * configure.in: upgraded version number to 0.3.0
2724 * fixing build of rpm (through rpm -ta):
2725 - Doc/Makefile.am exports proper doxygen files
2726 - src/jpeg/libijg8/Makefile.am exports the include files.
2728 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2730 * src/gdcmHeader.h : formatting code
2732 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2733 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2734 We were obtaining error message from vtk. Now, creation of file list
2735 is made in an internal list to prevent this problem.
2736 Bug fix when output is empty.
2737 Bug fix in update of progress value. Previous commit for this was a bad
2739 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2741 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * src/gdcmHeader.h : added method to get the file name
2743 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2744 files. Added method to remove all files on the input
2745 Added FIXME comment concerning the bad parsing of header made by
2746 ExecuteInformation method (in ExecuteData method)
2748 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2750 when using make instal.
2751 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2752 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2754 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * setup.py : adding include dir of jpeg lib to compile all sources
2756 * */Win32/*.dsp : JPR fix for windows compilation
2758 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2759 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2761 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2762 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2764 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * setup.py is again effective on un*x (takes into account the
2766 addon of the jpeg library)
2767 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2768 * Doc/Doxy* updated (includes above enhancements)
2769 * INSTALL now points to web documentation
2771 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * src/gdcmHeader.h doesn't make unnecessary reference to
2774 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2776 * src/gdcm*.[cxx|h] :
2777 - to allow compilation with gcc 3.x
2778 -- clean up of STL usage (added explicit usage of std::)
2779 -- small fixes on exceptions.
2780 Note: linking not tested !
2781 - clean of doxygen comments to avoid warnings at documentation
2783 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2784 dependent convertion).
2786 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * Clean up of previous JPR garbage commit (not even commented in the
2789 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2790 - moved all jpeg related files from src to src/jpeg/libijg8, with
2791 addition/modification of Makefile.am and configure.in.
2792 - the testSuite is still brain damage (not guilty).
2794 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2795 * WrapVTK.py : modifications to get correctly vtk source files to
2797 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2798 (FileName -> Filename)
2800 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * vtk/vtkGdcmReader.[cxx/h]:
2802 - UpdateProgress method should now be effective
2803 - removed the limitation on having only images loaded (as opposed
2805 - when building a stack of images/volume, a lesser number of
2806 gdcmHeader and gdcmFile instances should be used (hopefully
2807 accelerating things).
2808 - when building a stack of images/volumes, files which are not
2809 loadable (wrong path-filename, wrong permissions on existing file,
2810 or file not parsable by gdcm) are replaced with a black image
2811 in the stack (for the caller to notice the problem).
2813 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2816 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2817 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2818 between standard library (std) and vtk library (problems are found
2819 under Windows... thanks Windows !)
2821 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2824 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2826 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2829 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * When compiling with distutils (see setup.py) the C++ compiler is
2831 called with different flags than the default ones (with automake).
2832 In order to fix all those warning, I compiled gdcm with the command
2833 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2834 and went for warning fixes:
2835 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2836 up from unused variables.
2837 - vtk/vtkGdcmReader.cxx: potential bug fix.
2838 * src/gdcmHeader.h: Doxygen warning cleanup
2840 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * gdcmPython/gdcm.i:
2842 - typemaps correction to take into account the systematic replacement
2843 of "using namespace std" with std:: prefix e.g. std::list,
2844 std::string... (cf changes of 2003-05-21).
2845 - gdcmGlob global variable of type gdcmGlobal (defined in
2846 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2847 exported to Python a as cvar.
2848 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2849 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2850 gdcmDictSet.GetPubDictTagNames() and
2851 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2852 C++ static methods).
2853 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2854 with the above changes.
2856 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2857 * setup.py, manifest.in : bug fix under linux
2859 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2860 * Modification of setup.py to compile vtk part too. Then, we have 2
2861 wrappers which must work with same distutils. For that, we have a
2862 generic distutils in distusiltsWrapping.py ; with :
2863 - build_extWrap class to wrap generically all extensions,
2864 - ExtensionWrap base class for all wrapping extension that contains
2866 - Wrapper interface which wrap sources
2867 + In WrapSwig.py we have extension and wrapper for Swig
2868 + In WrapVTK.py we have extension and wrapper for VTK
2869 * MANIFEST.in : modifications to consider vtk directory and new python
2870 files for compilation
2872 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2873 * Added python wrappers of vtkGdcmReader vtk class (see the
2874 source in vtk/vtkGdcmReader.cxx) :
2875 - vtk/Makefile.am now builds a library
2876 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2877 python library (as opposed to _gdcm.so wich are the python
2878 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2879 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2881 - configure.in has an additional flag --enable-vtk that needs
2882 to be set to enable compilation of vtk related code, that is:
2883 + vtk/vtkGdcmReader.so and
2884 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2885 + gdcmPython/vtkgdcmPython.so (see above)
2886 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2887 be read when compressed or when HighBit + 1 != BitsStored),
2888 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2889 the usage of the python wrapper of vtkGdcmReader vtk class.
2890 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2891 * src/*.[h] all occurences of stl classes are now prefixed with
2892 std::, and all occurences of "using namespace std;" where removed.
2893 This is to avoid pollution of global namespace in included files.
2894 Apparently vtk does not avoid this pitfall: when using both
2895 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2896 collision of various stl members (principally cout...).
2897 * gdcmPython/testSuite.py now cleanly removes temprory generated
2899 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2900 comply with above changes)
2902 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2903 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2904 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2905 vtk data structure (an image Flip was required).
2906 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2907 * cosmetic changes in documentation.
2909 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2910 * src/gdcmHeader.cxx: the constructor no longer exits when an
2911 unexisting file is given as argument.
2912 * The subdirectory Data (containing all the images used for the
2913 test suite) is not part of this repository anymore. A new module
2914 containing those images is now available at
2915 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2916 with the name gdcmData.
2917 All the python scripts (including the package initialisation file
2918 gdcmPython/__init__.py) were adapated to take this change into
2919 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2921 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2922 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2923 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2924 demo of the usage of this class.
2925 Compilation of this vtk part is only done when using the --enable-vtk
2926 at configure (or autogen.sh) stage.
2928 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2929 * More memory link related corrections and documentation fixes.
2931 - maximum info is obtained with a command of the form:
2932 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2933 --show-reachable=yes PrintHeader
2934 - the remaining reachable blocks seem to come from the STL
2935 allocation scheme through the usage of map and list. It looks
2936 like this memory cannot be freed but it is not a memory leak
2937 (in fact further invocation to the STL would recollect the
2938 unused memory allthough it cannot explicitely be freed).
2939 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2940 of displaying an image parsed with gdcm and displayed with VTK.
2941 Note: some images don't seem to work e.g.
2942 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2943 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2944 Allthough this weakens the semantics, it is a ditch attempt to
2945 make gdcm more thread friendly.
2947 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2948 * Memory link hunt (by using valgrind through the command
2949 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2950 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2951 gdcmHeader::_dicom_vr.
2952 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2953 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2955 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2957 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2958 * src/Makefile.am now exports all the necessary include files at
2962 * UpdateGroupLength replaced by new one
2965 * UpdateGroupLength re-written using H-Table
2966 (named UpdateGroupLengthNew untill checks are over)
2968 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2969 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2970 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2972 - gdcmHeader::GetPubElValSet removed.
2973 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2974 UpdateGroupLength, WriteElements, Write.
2975 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2976 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2977 carried the same semantics.
2978 - src/gdcmHeaderIdo.cxx changed accordingly.
2979 - gdcmFile::WriteBase now regroups all the codes from previous
2980 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2981 - enum FileType moved to gdcmCommon.h
2982 * src/gdcmHeader.cxx AddDefault trashed
2983 * gdcmGetXSize added
2984 * getimageDataSize now calls gdcmGetXSize
2985 * Test/*.cxx changed to agree with above changes
2987 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2989 (to avoid double call by end user).
2990 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2991 by end user, since gdcmHeader::gdcmHeader now handles it.
2993 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * gdcm/Doc many doxygen changes:
2995 - Doxyfile now has two different versions, DoxyfileUsers that generates
2996 the html.users end users oriented documentation and
2997 DoxyfileDeveloppers that generates the html.developper developper
2998 oriented documentation.
2999 - README changed accordingly
3000 - requirement.txt removed (old design info moved to TODO).
3001 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3002 DoxyMainPage.txt, DoxyPython.txt provide more information.
3003 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3004 be updated by simply regenerating the docs with doxygen and copying
3005 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3006 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3007 all the tests in the form "if (<map>.count() >1)" were removed.
3008 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3009 ill-formed documentation sections.
3010 * src/gdcmHeader.cxx: ditto
3012 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3013 * setup.py fixed for un*x (needed macro for stdint.h)
3014 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3015 un*ces with sh-utils test utility.
3016 * gdcmPython/demo/test.py renamed to PrintHeader.py
3017 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3018 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3019 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3020 * src/gdcm*.cxx JPR's bad inclusion fixed.
3022 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3024 * gdcmPython/demo/test.py changed accordingly.
3026 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3027 * gdcmPython/Makefile.am fixed linking against libstdc++
3028 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3029 * Swig subdir (historical tests of swig version 1.3.17++) removed
3030 * Test/testChangeEntete.cxx some lines commented out in order to make
3032 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3033 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3035 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3037 hence the user doesn't need this explicit call.
3038 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3039 i.e. LoadElements() call removed.
3040 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3041 - src/Makefile.am declares the proper flag for g++.
3042 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3043 for adding user defined new tags.
3044 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3045 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3046 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3048 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3049 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3050 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3051 src/Makefile.am : the project should properly compile and install
3052 with the autotools, included the python wrappers part.
3053 * gdcm.spec.in : added a spec file for RPM packaging.
3055 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3056 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3058 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3060 to exported to the environement (see gdcmPython/testSuite.py
3062 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3063 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3064 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3065 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3066 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3068 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * gdcmPython/__init__.py doesn't crash anymore when running in
3070 in InstallMode or PreInstallMode but with an environment given
3071 value of GDCM_DICT_PATH.
3072 * src/gdcmDictSet.[cxx/h] coding style.
3074 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3076 * src/gdcm.h general comments moved to TODO, and README
3077 * src/gdcm.h should now be seen as a user commodity (including it
3078 should suffice to fully use gdcm). It is nowhere including within
3079 any of the kernel files src/*.cxx and src/*.h.
3081 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3083 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3085 * src/gdcm*.cxx only include their corresponding include file
3086 (as opposed to gdcm.h)
3087 * gdcmPython/gdcm.i changed accordingly
3088 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3089 the autogen.sh generated "make snapshot" command to work.
3090 * autogen.sh removed history related references to crea package.
3092 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * distutilsSwigCPlusPlus.py work around some swig portability
3096 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3098 was done in a last ditch attempt to get setup.py _really_
3099 operationnal. The python/gdcmPython layaout add the advantage
3100 of hidding away the python related distutils specific files
3101 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3102 Alas, the src directory was out of scope (i.e. it's relative
3103 position to setup.py was ../src) which made things impossible to
3104 handle (see previous version of python/setup.py). Crossing fingers...
3106 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3107 * python/setup.py now works on Un*x. (harder than I thougth)
3108 * python/distutilsSwigCPlusPlus.py can now have include files
3109 among the list of sources.
3111 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3112 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3113 * modifications in MSVC projects
3115 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * As stated by the first lines of Test/ExceptionAndPython/README, it
3117 looks like we can move back to original usage of exception within
3118 src/gdcm* and hence remove the errno stuff that was introduced
3119 as a quick and dirty fixture of this problem (added to the TODO).
3120 * Doc/Doxyfile configuration file for Doxygen and corresponding
3121 README file for usage added.
3122 * Test/testWrite.cxx added. This new test comes from a split of
3123 test.cxx that is now reverted to its original purpous i.e.
3124 testing the proper parsing of a Dicom related file.
3125 testWrite.cxx concentrates on testing the IO part of gdcm.
3126 * Test/bug1.cxx (containing a bug on WIn32) added.
3127 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3128 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3129 whose purpose is to publish the content of the TagNames of the
3130 Dicom public dictionary were not accessible without an
3131 instance of class gdcmHeader.
3132 - those methods are now static methods of gdcmDictSet and hence
3133 require no instances at all to be invocated.
3134 - within gdcmDictSet this change required to change some method
3135 to class methods (i.e. are now static) among which SetDictPath
3136 (renamed to BuildDictPath) and LoadDefaultPubDict.
3137 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3138 the above changes by calling the new method classes of gdcmDictSet.
3139 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3140 the above to be effective.
3141 * python/gdcmPython: in order to wrap properly the above changes
3142 for Python, swig version now needs to be > 1.3.17.
3143 * python/gdcmPython/Makefile fixed to adapt itself to new
3144 configure/make shema introduced by Johan Montagnat (thanks for the
3145 contribution). Alas this Makefile cannot be turned into a proper
3146 Makefile.am without some heavy changes in the configure.in
3147 (for python dectection).
3148 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3149 now avoids publishing the empty entries.
3151 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3152 * python/setup.py : bug fix concerning install under windows
3153 ExtraPath reused :-P
3154 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3156 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3157 * Dicts/dicomV3.dic : remove double spaces !!!
3158 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3159 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3162 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3163 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3164 method. Doxygenation.
3165 * src/gdcm.h clean up of JPR spurious comments.
3167 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * python/distutilsSwigCPlusPlus.py now properly collects the
3169 shadow classes generated by "swig -c++" (gdcm.py in our case)
3170 when using "python setup.py install".
3171 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3172 reexports the working classes.
3173 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3174 by the classical C errno scheme. This is to prevent an obscure
3175 behavior of the python wrappers when importing wxPython.wx prior
3176 to gdcmPython (which ended up in an abort call). An illustration
3177 of this oddity can be found in the Test/ExceptionAndPython
3178 subdir (see the README file). This problem probably due to
3179 an combination of g++ and dynamic loading.
3180 * added Test/ExceptionAndPython (see above)
3182 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * Changed the layout of the python part to avoid bloating main
3184 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3185 i.e. the distutils arsenal. All the python related stuff is
3186 again in a python subdir, but the package itself is now in
3188 * setup.py was cleaned up:
3189 - pythonIncludePath removed
3190 - python setup.py bdist target is now functional.
3191 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3192 collision with other packages). gdcmPython/demo/*.py changed
3195 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3196 * python subdir moved to gdcmPython (preparation of distutils packaging).
3197 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3198 distutils installer is operational.
3199 * - gdcmPython/__init__.py now properly loads the swig generated
3200 shadow classes (from gdcm.py).
3201 - gdcmPython/demo/*.py changed to import the package gdcmPython
3202 instead of gdcmPython/demo/load.py.
3203 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3205 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3206 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3207 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3208 entries within the associated public Dicom dictionary resp. the same
3209 information but sorted by the fourth field (PAT, IMG, DIR) of the
3211 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3212 are now in the "???" group.
3213 - python/gdcm.i changed accordingly,
3214 - python/demo/printGroupedPublicDict.py added, that gives an example
3215 of the above new functionalities in Python.
3217 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * src/gdcm.h, gdcmHeader.cxx:
3219 - historic references to glib's g_malloc and g_free (#defined)
3220 were definitively removed.
3221 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3222 * src/gdcmElValSet.cxx:
3223 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3224 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3225 - GetElValue(string) renamed to GetElValueByName.
3226 - Added GetElementByName(string).
3227 * src/gdcmHeader.cxx: added
3228 - GetPubElValRepByNumber(guint16, guint16)
3229 - GetPubElValRepByName(string)
3230 - GetShaElValRepByNumber(guint16, guint16)
3231 - GetShaElValRepByName(string)
3232 - GetShaElValByNumber(guint16, guint16)
3233 - GetShaElValRepByName(string)
3234 - GetElValRepByNumber(guint16, guint16)
3235 - GetElValRepByName(string)
3236 - GetElValByNumber(guint16, guint16)
3237 - GetElValRepByName(string)
3238 * Doc/requirements.txt added.
3240 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3241 * Test/Makefile building now depends on the one of libgdcm.so
3242 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3243 pixel data) aware which enables finding the address (offset) of
3244 the pixel data of JPEG encoded DICOM files. This leaves only a single
3245 file in the testSuite whose pixel data address (offset) is unknown.
3246 * python/testSuite.py changed accordingly.
3248 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3249 * VC++ has some strong limitations when working with the STL, as stated
3250 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3251 "Also note that some STL containers (map, set, queue, list, deque)
3252 cannot be exported. [...]
3253 Some STL classes contain nested classes. These classes can not
3255 This is caused by a designed limitation that once a template
3256 class is instantiated, it can not be re-instantiated and
3258 Since our usage of map<> is ubiquitous in gdcm, this "designed
3259 limitation" of VC++ is a pitfall.
3260 Hence the Python wrappers of gdcm cannot be incrementally linked
3261 against the c++ dynamic library. The dirty but only workaround is
3262 to forget about incremental link of dynamic libraries and to generate
3263 the Python wrappers library with the inclusions of the underlying C++
3265 The following modifications concern this matter on Win32/VC++:
3266 - wrapping python correct with standalone wrapped dll (don't use separate
3267 dll under windows !!!!)
3268 - python21_d debug mode enabled (ask Frog how to use it :-)
3269 - NO problem with having an STL member of class for example string in C++
3270 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3271 - Python test of dcmlib in Python is ok under windows on a large set
3273 * removed glib references
3274 * typedef's inserted in gdcm.i for correct swig type management
3276 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3277 * python/demo/*.py load.py extracted from test.py. Added explore.py
3278 that only displays required tags and testAll.py that parses all
3279 the files of the testsuite without using unittest.
3280 * python/testSuite.py other additional test on new files added.
3281 * Data/* new test files added accordingly to the testSuite.
3282 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3283 the vr in the file differs from the one of the dictionary.
3285 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3287 values, but limits itself to values which are below a user specified
3288 size (by default 1024 bytes).
3289 * python/gdcm.i : elements not loaded (because their size is above the
3290 user specified treshold) are exported with their TagKey as key of the
3291 python dictionary. This enables the testsuite to make some checks
3292 on the unloaded elements (since we have their offset and size).
3293 * python/testSuite.py
3294 - now tests for the existence and proper value of the pixel data
3295 - two new examples added.
3296 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3298 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3300 aware. See the strategy comments in gdcmHeader::FindLength().
3301 * Test/test.cxx now accepts a filename as first argument.
3302 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3303 * python/testSuite.py changed to integrate test on above files.
3305 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3306 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3307 the vr was also RET.
3308 * python/testSuite.py more tests added.
3310 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * python/testSuite.py unittest test suite added (uses Data)
3312 * Data/* dcm and acr files for the test suite.
3313 * glib dependance removed from un*x version. We now use ISO C99
3314 7.18 Integer types (see stdint.h)
3315 - python/Makefile, src/Makefile src/gdcm.h
3316 * src/ when an explicit vr (like dicom files) suddenly poped an
3317 implicit element we use to mark the underlying DictEntry of the
3318 concerned ElValue with "Implicit". This strategy was damageable
3319 too the public or provite dictionaries, since some of their vr
3320 would be changed. Since Header::FindLength heavily relies on the
3321 detection by Header::FindVR of falsely explicit elements, I
3322 added an extra ImplicitVr member to ElValue (boolean).
3323 The rest of the changes we the necessary adaptations.
3325 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3326 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3328 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3330 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * Adaptation for porting to VC++:
3333 o forced to use std namespace (for string to be known)
3334 o all class use __declspec export style on WIN32
3335 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3336 (in stdlib.h on Win32 but in std:: for gcc)
3337 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3338 variable GDCM_DICT_PATH.
3339 * src/gdcmHeader.cxx verbose comments made discrete.
3341 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3342 * python/gdcm.i: added a typemap that converts a C++ hashing table
3343 to native Python dictionary.
3344 * python/demo/test.py:
3345 - now uses the native dictionary for exploration of gdcmHeader.
3346 - takes an optional filename argument (the file to parse).
3347 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3348 PubElVals hashing table.
3349 * Dicts/dicomV3.dic removed error prone trailing spaces.
3351 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3352 * Python wrapping process moved away from src/Makefile to
3353 newly created python/Makefile (as well as gdcm.i)
3354 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3355 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3356 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3357 from the environement variable GDCM_DICT_PATH (when existing).
3358 * src/gdcmDict::GetTag bug fix.
3360 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3361 * Straightforward temporary fixes for swig to build the python wrappers.
3362 src/Makefile now has a python working entry [by working we mean
3363 that we can import the shadow classes without errors].
3365 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3366 * hashtest.cxx removed (since already in Test)
3367 * src/gdcmlib.h renamed to src/gdcm.h
3368 * src/dcm.i renamed to src/gdcm.i
3369 * src/Makefile prepared for python wrapping
3371 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3372 * src/gdcmHeader.cxx :
3373 - Parsing of header is now separated from loading of element values
3374 (see gdcmHeader::LoadElements).
3375 - general clean up of hopefully all file access (creation of
3376 ReadInt16 and ReadInt32)
3378 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3379 * src/gdcmHeader.cxx :
3380 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3382 - SetLgrElem renamed to SetLength
3383 - GetLgrElem renamed to GetLength
3384 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3385 * src/gdcmElValSet.cxx fixed both GetElValue methods
3386 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3387 due to IdoDude was cleaned out.
3389 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3390 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3391 concentrates on finding the value representation (when it exists).
3392 RecupLgr now only finds the element value length, and it avoids
3393 returning the unecessary skL (skipped length).
3394 Also, offsetCourant was simply removed (with taille_fich) since
3395 it was redundant with the File position internals (by using
3396 ftell and fseek). This also made skL (see above in RecupLgr) usage
3398 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3399 on the libido specificities which are handled through class
3401 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3404 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3405 * Truckload of changes. Parsing of header is barely functional
3406 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3408 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3409 * src/gdcmHeader.cxx many addons of low level methods
3411 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3412 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3413 and _IdDcmSWAP_LONG.
3415 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3416 * This corresponds to all the changes decided at the meeting of
3417 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob