1 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
3 and it's representation name (for the NIH)
5 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
7 conversion of YBR to RGB pixels. So, now, the conversion is made using
10 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
12 format) to replace 'at-run' dicom files generated by the
13 TestAllReadCompareDicom test
15 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
18 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
21 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * Testing/TestMAkeIcon.cxx : complete the test
24 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
27 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
31 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
34 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * Test/ : accelerate tests (it's not very significant accelerations).
36 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
38 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * Testing/TestSequence.cxx : add test for sequences of images... test that
40 we have the same serie or the same study UID
42 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
45 * src/gdcmDict.h : remove commented code
46 * src/gdcmDocument.cxx : initialize values
47 * src/gdcmFile.cxx : bug fix when reading values
48 * gdcmPython/demo/ : change file names. Remove useless files
50 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmFile.cxx : remove the default array of initialization.
52 The static array contained pointers to non-static values (comming from
53 strings). To have coherences, when creating files, these values can't be
54 static. So, the array can't be static, too ! To simplify, the array have
55 been replaced by repeted lines to insert values in the File
57 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
59 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
61 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
62 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
63 (Dicom Element) into the Sequence Item
65 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/*.cxx : first parss to normalize file organisation
68 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmDirList.[h|cxx] : add method to find a directory
70 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
72 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Finish cleaning up my JPEG mess. Should be ok now.
74 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
75 contained within the RLE* class(doh!)
77 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
78 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
79 * SerieHeader::AddFileName() creates as many Coherent Files lists
80 (same Serie UID) as it founds different Serie UID
81 amongst the files instead of discarting any file
82 that doesn't match with the first one he found.
83 * SerieHeader::OrderGdcmFileList has now one parameter :
84 the Coherent Files list the user wants to sort
85 * SerieHeader::GetFirstCoherentFileList() |
86 * SerieHeader::GetLastCoherentFileList() | allow to parse
87 the set of Coherent Files lists
88 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
89 compatibility (it returns the *first* Coherent Files list,
90 since there was only one before)
91 * Test/TestSerieHeader gets gdcmData as a default root directory
93 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * Remove friend between DocEntry and File classes
95 * Remove friend between PixelReadConverter and RLEFramesInfo,
98 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
100 0002|0000. The value was incorrect.
102 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
105 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmUtil.cxx : compilation fix on Win32
107 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
108 variable, to be easy found. Add methods to change the default UID.
109 Amelioration of the CreateUniqueUID to use the correct default UID.
110 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
113 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * Test/TestVR.cxx : fix memory leaks
116 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 * Rewrite the base 256 to base 10 conversion, using string operation only.
118 This allows us to get rid of the problematic 64bits integer type (does not
119 always exist on target platform).
121 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
122 * Add construct and destructor to class gdcm::Debug to close the debug file
124 * Don't let uset to open twice the same file
125 * gdcm has now an official UID prefix,
126 supplied by http://www.medicalconnections.co.uk
127 1.2.826.0.1.3680043.2.1143
128 (Thx to Mathieu for providing URL)
129 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
130 to be able to perform some more tests
131 * gdcm::ContentEntry : Contructors and Destructor are now protected,
132 in order to be sure no user will try to use them.
133 (at user level, only the children classes are meaningfull)
135 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * move RLEInfo & JPEGInfo from Document to File
138 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * FIX : remove so many friend between classes
141 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
143 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
145 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
146 In order to avoid missbehaviour :
147 . gdcm::DocEntry is now specialized in
148 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
149 - gdcm::ContentEntry (Dicom entry with a 'content')
150 . gdcm::ContentEntry is specialized in
151 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
152 characters value, or integers)
153 - gdcm::BinEntry (Dicom entry with a non strig representable value
154 (user hasn't any longer to thing about the precedence of his dynamic_casts)
156 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * Test/VTKTest*.cxx : bug fix under linux
159 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
161 use with python. Some methods are moved from Document to ElementSet or
162 DocEntrySet. The equivalent methods to ElementSet have been added to
163 SQItem and are virtual in DocEntrySet. Methods that may have the same code
164 in SQItem and ElementSet is directly placed in DocEntrySet
166 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * Test/VTKTest*.cxx : remove the show variable in each test method because
168 it's useless (the viewer variable replace this variable)
170 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/gdcmDocument.cxx : bug fix on potential memory leak
172 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
173 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
174 Add ClearXxx methods to remove all the content of the list or map
175 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
177 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
178 * methods ReplaceOrCreate renamed as Insert
179 (nobody will be any longer confused by 'CreateOrReplace')
181 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Grealty simplify the JPEg decompression, no need to differenciate based on
183 the JPEG possible type (with/without fragment, with/without multiple frame).
184 Everything is done throught the JPEG IO Suspension mechanism in IJG
186 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
187 * Stage 3 of normalization :
188 in order to avoid any missunderstanding while reading method names :
189 - All the methods xxxEntry now deal with dicom Entries
190 - Methods GetEntry splitted into
193 - Method SetEntry renamed as SetEntryValue
194 - Method SetEntryBinArea let as it was
196 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
198 - Position correctly the entry points for JPEG2000 and JPEG-LS
199 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
201 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
203 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
204 with other method names
205 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
206 * Test/TestDicomDirElement.cxx : add new test
208 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
210 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
211 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
212 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
213 So can't you use __int64 in ostream at all.
215 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * bug fix for compilation on MSVC6
217 * gdcmPython/gdcm.i : rename of classes missed
219 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
220 * Stage 2 of names normalization :
221 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
222 (easy to understand ...)
223 - gdcm::FileHelper replaces old class gdcm::File
225 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
227 type and not a string. So, there remove problems on the format of the
230 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
231 * Add Example/TestPapyrus.cxx
232 - reads a Papyrus file (gdcm::Header compliant),
233 - gets the pixels of all the images, using low level iterators
234 - writes an multiframes Dicom image.
235 (Just to show it's *possible* to do that)
236 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
239 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
241 Thus, DicomDirXXX are created with a flad that indicates if the created
242 object is empty or not (when not empty, the DicomDirElement is used to
245 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
247 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
249 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
252 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
254 Remove all access to the hash-tables or lists in the objects.
256 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
258 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
259 be complient with all the gdcm source code
261 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
265 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
269 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * Test/ : rename VTK tests to have a best name for the tests
271 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
272 GetFirstEntry/GetNextEntry use
274 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
275 * In SerieHeader::ImagePositionPatientOrdering()
276 // a Dicom 'Serie' may contain scout views
277 // and images may have differents directions.
278 // -> More than one may have the same 'pos'
279 // Sorting has then NO meaning !
280 Thx to Eduardo Davila for reporting bug.
282 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
284 test. Now it's on image content and not on the resulting visualisation...
285 might solve the problem on linux when using the OpenGL drivers
287 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
288 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
289 DicomDirSerie, DicomDirImage
290 Dict, DictSet classes :
291 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
292 -remove InitTraversal method.
293 * UPD Test programs + Example programs
295 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
296 * remove useless and never updated keyword \ingroup
297 * Solve pb when structure (list, map, ...) is empty.
298 Thx to Benoit for reporting bug
300 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
301 * Taking into account of 'Transfer Syntax' value
302 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
305 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
307 is no memory access violation
308 * gdcmPython/demo : add python demos using VTK
310 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
311 * FIX 'Dictionnary' is now spelt 'Dictionary'
312 'wether' is now spelt 'whether'
313 'archieve' is now spelt 'archive' ;-)
315 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
316 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
317 related methods, in order not to expose internal mechanisms
320 * REM methods that exposed internal mechanisms :
321 DicomDir::GetDicomDirPatients()
322 DicomDirPatient::GetDicomDirStudies()
323 DicomDirStudy::GetDicomDirSeries()
324 DicomDirSerie::GetDicomDirImages()
325 * UPD Test programs :
329 * UPD Example program
331 * ADD DictSet methods
335 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * Removed the Print/indent/default parameter mess. There is absolutely no
337 reason to have to methods, moreover with the second taking the ostream as
338 *SECOND* parameter. This was clearly a bad hack to get things compile.
340 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * Complete rewrite of the GetMacAddress code. Now the code is *much*
342 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
343 Unfortunately the main code does not work on SunOS, thus provide a specific
344 code for this platform only (and Win32 of course). Since this seems to be
345 working, change CreateUniqueUID to use GetMACAddress instead of the
346 problematic GctestetIPAddress
348 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
349 * Unfortunately to be able to test gdcmDirList I had to break the API
350 a little. Now the class is not a std::list anymore but has a member
351 std::vector (more ITK compatible). Allow unit testing on Win32 and
354 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 * Update SerieHeader to take into account a Serie Instance UID to properly
358 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
359 * ENH - Comment out Mathieu's (dangerous) Super Hack
360 for dealing with BIGENDIAN processors
361 - Move equivalent stuff to BinEntry::WriteContent
362 When necessary, 16 Bits Pixels are swapped in a small buffer
363 and then written. This avoid allocating a huge buffer, in
364 PixelWriteConvertor, and avoid modifying the Pixel Area.
366 Probabely, the same operation will have to be done when we want
367 to write image with Big Endian Transfert Syntax,
368 and we are working on Little Endian Processor
370 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
373 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
374 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
375 all the dict content.
376 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
378 * Test/TestDict.cxx : add a new test for the dict classes
380 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
381 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
382 file. Debug is yanked if compiled with NDEBUG
384 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmDictSet.h : set the default output to the os variable
386 * src/gdcmDictEntry.[h|cxx] : add the Print method
387 * gdcmPython/demo/ : add a new test
389 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
390 * merging of Test/PrintDicomDir and Test/TestDicomDir
391 * removal of now redundant Test/PrintDicomDir
392 * enhancement of Example/PrintDicomDir
394 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * Now, python test might work on systems
396 * Add the PrintDicomDir test
398 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
399 * FIX : First entry following group 0002 was lost for
400 Explicit Big Endian Transfer Syntax files
401 (group and elem not swaped)
403 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
404 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
405 Big Endian Transfer Syntax supposed the group following 0002
406 begins always by element 0000 (element 0000 is *optional*)
407 To avoid further troubles, let's be pessimistic, and use
408 Document::HandleOutOfGroup0002() method
409 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
410 (related pb not yet solved)
412 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * Bug fix for the python part use
414 * Now, PrintHeader.py pass... but outside the ctest use. shit !
416 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
419 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
420 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
421 a string and should ask the global TS dict what are the propreties of
424 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
425 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
426 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
427 to swap the Swap Code, at parsing time, when we come out of group 0002
428 and Transfer Syntax is Big Endian
429 We should be able to read now 'true DICOM" Big Endian coded images
430 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
431 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
433 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Hopefully fix the bug on MacOSX and static global initialization.
435 This is the only -minor- patch I found that both please MacOSX and VS6.
436 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
437 but this would require a lot of change. Another approach would be that Global
438 create those string and GDCM_UNFOUND becomes a pointer to a string (which
439 gdcm::Global would destroy at exit).
441 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
442 * Fix bug on MacOSX with static initialization in a multy threaded
443 environment. static const string in a header file used to be ill
444 initialized provoquing the freeze of any tests. patch should solve this
447 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
448 * According to Benoit's suggestion, and without any objection from anybody
449 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
450 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
451 - method gdcmDicomDirObject::GetEntry() renamed as
452 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
454 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
455 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
456 you debug/warning message just as c++ streams which make them very convinient
457 to use. Once this is stabilize I will change the ostringstrem to be
458 redirected to a file (ofstream).
459 * Properly support C99 extension: __FUNCTION__ which allow us to display
460 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
462 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
463 * Removal of useless and dangerous methods :
464 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
465 GetDocEntryByName, GetEntryByName, GetDictEntryByName
466 * Removal of usless methods :
467 Dict::PrintByName, Dict::GetDictEntryByName
468 * Commenting out of probabely useless methods :
469 Dict::GetDictEntryNames()
470 Dict::GetDictEntryNamesByCategory()
471 DictSet::GetPubDictEntryNames()
472 DictSet::GetPubDictEntryNamesByCategory()
473 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
474 * ENH : Use dicomTS.dic as described in 2004 version
475 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
476 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
477 Add Accessors on VM (Value Multiplicity), and VM related methods
478 * ADD : Add a list of 'Dicom Attribute types', as found in
479 http://medical.nema.org/dicom/2004/04_15PU.PDF
481 * ADD : Add dicomGroupNameAbbreviations.dic
482 should be used to write a method to replace the former
483 Dict::GetDictEntryNamesByCategory()
485 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
487 to read in the file... and only it ! Length is the efective length of the
488 data in the DocEntry structure
490 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
492 And now use a static function call instead, with a global variable. i
493 This is much closer to the VTK approach. Hopefully should be bulletproof
494 and easier to use...hopefully
496 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
497 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
499 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
502 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
504 ValEntry, BinEntry, SeqEntry creation or replace
506 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
508 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
510 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
511 when specifying the VR
512 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
513 * src/gdcmDocEntry.cxx : amelioration of print
515 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
516 * ADD : Add the method Util::IsCurrentProcessorBigEndian
517 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
518 * ADD Method Document::ComputeGroupLength
519 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
520 in order to allow further VR modification by user
521 * REM : removal of once-called method File::WriteBase
522 integration of its code in formerly one-line method File::Write
524 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
526 replace the different values "??", "Unkn", "Unknown".
527 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
528 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
529 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
530 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
532 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
535 * Set the gdcm::Base class to some Printable classes
537 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmFile.[h|cxx] : add the Print method
539 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
540 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
541 * src/gdcmDocument.h : remove the PrintLevel informations
542 * Example/PrintFile.cxx : use the new gdcm::File::Print
544 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
546 problems when compiling with the python wrapping
548 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
550 writting in ImplicitVR
552 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
553 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
554 JPEG decompression, especially when dicom frames are split into several
555 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
556 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
558 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmHeader.cxx : change the initialisation of default header.
560 Now, this header is readable by gdm, e-film, DicomWorks
562 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
564 Rename Decompressed to Raw
565 * Use the API changes in gdcm::File.
566 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
569 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
571 each added entry in the header. Replace the 'Planes' field by the 'Number
574 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
576 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
578 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
580 At this time, this image isn't readable by e-film... waiting JPR help to
583 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
585 DocEntry. Now use methods of the Document !
587 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * Test/ShowDicomSeq.cxx : bug fix
590 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
592 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
593 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
594 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
596 * Test/TestCopyRescaleDicom.cxx : remove unused variable
597 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
598 containing found sequences
600 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
603 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
604 Some fields in BinEntry must be copied to not seg fault when making the :
605 gdcm::File *copy = new gdcm::File( copyH );
606 and tests are now made on good variables
608 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
609 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
610 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
612 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
613 * Add vtkGdcmWriter example and test
615 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * Test/TestUtil.cxx : reformat the source code
617 * vtk/vtkGdcmReader.cxx : remove and change prints
618 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
620 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
621 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
623 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
625 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
627 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
629 by an eof to prevent all bad read of the file... and in this case, the
632 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Example/Volume2Dicom.cxx : comment unused variables
634 * Test/PrintDicomDir.cxx : comment unused variables
635 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
636 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
637 method that is redondant with AddEntry.
638 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
641 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * Bug fix due my last commit (compilation under Windows).
643 * Example/Volume2Dicom : bug fix in the file and reformatting source code
644 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
646 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 - Remove printf / sprintf
649 - include iostream AFTER gdcm so we don't get warnings
650 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
652 - Also remove tons of include from header files, hopefully this should
653 speeup the compilation time, since it was becoming a dog slow.
654 - Remove gdcm.h as it include way too many files and slow down compilation
655 (plus it is not up to date)
656 - remove 'using namespace std' this is BAD !
658 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Remove memory leaks on the DicomDir
660 * Remove some useless data in DicomDirObject
661 * Add usefull methods in SQItem, to be complient withe the ElementSet
663 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
666 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
668 future, with convertion)
669 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
670 and ImageDataSize values. Remove the method to get the PixelReadConverter
671 from the output of the class
673 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
676 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
678 and vtkErrorMacro use.
679 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
681 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
684 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
685 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
686 The string leaves only in the fonction. So when we make a .c_str(), we
687 get the pointeur on the first element, element that will be destroyed
688 immediately after thee instruction.
689 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
690 file has been opened : the test must be made on the content of the
691 pointer and not directly on the pointer !
694 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
696 the python part recompiles
698 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
700 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
701 X session is killed (for my computer... it seems to not be identic on
704 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
706 avoid problems (otherwise, the difference test between the visible image
707 and the reference is incorrect. If the reference is greater than the
708 screen resolution, it's produce errors).
709 Can be used for only one image. Can be used with a visible flag.
710 * vtk/vtkGdcmReader.cxx : remove commented codes.
711 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
712 under windows at compilation
713 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
715 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
717 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
719 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
720 tests on the image size X, Y, Z
722 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
724 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
725 between the class name and the file name
727 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/ : fix compilation warnings for the Write method (2 different
729 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
730 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
731 variable... create a static method in gdcm::Document to access to
732 this variable content.
734 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
736 file, to be accessed by other files (like gdcmFile). Remove commented
737 code. Move the change of the header to the gdcmFile, using the
739 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
740 To be sure of that (and simplify calls), the Write of the header now
741 gets a file name and not a file pointer (std::ifstream).
742 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
743 DocEntryArchive. Remove all open of the written file
745 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
748 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
750 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
752 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
753 some corresponding methods. Write correctly the file and check before
755 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
756 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
757 is now on RGB data (as before my last commit
758 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
760 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
761 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
762 Add a print information of the type of the entry
763 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
764 It was in the gdcmFile, and all write have been regrouped
765 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
766 Write correctly all dicom files (in decompressed mode only at this time)
767 * Test/ : test on files are now made using Raw data and not color data if
769 * Example/PrintFile.cxx : add more printings
771 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
772 * Amelioration of code, remove some code copy. For the loading of
773 BinEntry (in gdcmDocument), add the test to verify if the file is already
776 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
778 remove a DocEntry in the header (push an empty DocEntry)
779 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
780 lines. Bug fix in the initialization of the PixelConvert and the
782 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
783 use in TestCopyDicom (now this test can run under windows... but fails)
784 * Test/TestCopyDicom.cxx : amelioration of the test :
785 - test the pixels written
786 - add test points to quickly find where is the error
787 - can set a file name input and output in arguments
788 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
789 amelioration of the test output
791 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
793 all replaced DocEntry's
794 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
795 Now, each needed DocEntry to modify is duplicated, modified and inserted
796 to the header using DocEntryArchive. Thus, after save, we can restore the
797 header initial state.
799 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
800 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
802 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
803 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
804 correct to copy it. The DictEntry is specified at the DocEntry creation,
805 then, it musn't change in the time.
806 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
807 header correctly. At this time, the change is only made for the first
808 level of the Document. In the future, it might consider sequences.
809 The change is made by replacing a DocEntry by an other that is created
810 outside the class. The old value is kept. When we restore the header
811 status, the added DocEntry is deleted and replaced by the old value.
812 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
813 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
814 set the write type to explicit VR, implicit VR or ACR. Add methods to set
815 the write mode to native, decompressed or RGB (but not used at this time)
817 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
819 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
821 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
823 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
825 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
826 set because already copied when copying the BinEntry's of the header
827 * Test/TestAllReadCompareDicom.cxx : remove warnings
829 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
830 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
831 Two problems appear when doing it :
832 - with the gdcmFile : when the GetImageData method is called, the pixels
833 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
834 data (pixels). And each structure destruct the data when it's
835 destructed. So we have two destructions for the same data. To solve it,
836 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
837 data or not. If it doesn't own data, then they will not destroyed by
839 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
840 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
841 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
842 create a double destruction of the same DocEntry's. So, to solve it,
843 the TagHT is simply cleared and the DicomDir* elements are destroyed.
844 * TODO : add an entry concerning memory leaks in the DicomDir
846 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
847 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
848 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
851 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
853 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
854 after it have been deleted
856 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
857 * FIX: src/* fix the doxygen warnings.
858 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
859 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
860 was erroneously defined with a size of 15 instead of 16. [many thanks
861 to Jean Michel Rouet for pointing out this bug].
863 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 1. Finish merging JMR patch for writting DICOM from scratch
865 2. Fix -hopefully- bug with MONOCHROME and space vs null character
866 3. Use const ref when possible
867 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
868 5. A few more comments
869 6. CreateUniqueUID can now be called without parameter"
871 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
872 * ENH: Slightly bigger patch:
873 1. Getting toward full integration of JMR patch for writting dicom from scratch
874 2. Update Test to test part of this patch: CreateUniqueUID
875 3. File was not close properly in gdcmDict
876 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
877 5. Use of const ref instead of copy (speed issue)
878 6. Remove temporary (duplicate) string in TranslateToKey
879 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
880 8. Do not repeat virtual in subclasses
881 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
883 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
884 * Apply first patch toward better string comparison when dealing with broken
885 DICOM files. Essentially the string could be padded with a space instead
886 of a null character as defined by standard
888 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
890 because never used... and in the same time, that's remove some memory leaks
892 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * src/gdcmFile.cxx : now delete the PixelConvert instance.
894 * In examples and tests : change the type of image data variables from void*
895 to uint8_t*. Remmove all delete on image data variables
897 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
898 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
899 Verify the file pointer value before open the file, and if it's not null,
900 a verbose message is generated.
901 Close correctly the file when the file isn't considered dicom-like. The
902 correctly close is a call to CloseFile.
903 When closing the file pointer, test if its not null to close the file.
904 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
905 file. For an uncompressed image, the copied data correspond in the least
906 case to the image size (calculated) or the image size specified in the
907 header. A verbose is generated if these two size mismatch
909 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
911 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
912 break under windows (with msvc6 compilation).
914 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
916 compiling with MSVC6)
918 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
919 * Bugs fix for the Windows build with VC6
920 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
921 needed (only for projects required VTK). If the VTK is included in all
922 projects, there is conflicts with the jpeg lib of vtk when compiling the
923 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
924 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
925 when compiling the gdcm_wrap.cxx file (created by the compilation of the
927 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
928 (like it's already made for the cout use). Otherwise, conflict with the
931 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
934 - comments on the DicomDir::Method related usage added.
935 - now that we use the namespace gdcm, a lot of internal classes do
936 NOT need to be wrapped anymore.
937 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
938 DicomDir::Method) new example added.
940 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Improve string manipulation. I now inforce the notion of 'DicomString'
942 A DicomString can contain as many \0 as they want
943 and it is *always* of even length.
944 We only support odd length for very rare case.
945 And in the near future this should be removed.
947 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * /binary_write/ gdcm source. Now even on big endian we are writting
949 little endian. This should -heopfully- fix some tests
951 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * Now the dictionary is compiled into gdcm lib. This is a default
953 behavior, thus any dic file specified is picked before failback to
954 the one comiled into lib
956 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
957 * Change internals for gdcmDict. Don't use any 'new' any more.
958 This should definitely solve any leak problem, and we should be
959 as fast as before, as long as don't modify too much the dictionary.
961 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * STYLE: ivars should start with a capital letter.
963 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
964 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
966 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
968 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
969 new 2004 dictionaries added (thanks to JPR).
970 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
971 * CLEANUP_ROUND (15) for gdcmPixelConvert
972 - RLEFrame::NumberFragments is now of type unsigned int
973 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
974 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
977 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
978 * Initial work in gathering all transfer syntax accessors. clearly
979 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
980 ivars, but only one transfersyntax (class) ivar with equivalent method on
983 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
985 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
986 discussed (plus I didn't like having a 2000 lines patch not commited)
988 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
990 * CLEANUP_ROUND (14) for gdcmPixelConvert
991 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
992 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
993 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
995 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
996 anymore and hence avoids storing a copy of PixelConvert::Decompressed
997 into File::Pixel_Data.
999 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1001 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1002 * CLEANUP_ROUND (13) for gdcmPixelConvert
1003 Substituted File::ParsePixelData() with PixelConvert::Print() new
1005 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1006 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1007 method to those classes.
1008 - src/gdcmFile.[cxx|h]:
1009 -- Added a ::Print() method.
1010 -- PixelConverter is now a reference instead of a member.
1011 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1012 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1014 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1016 collaboration diagram and inheritance diagram should be generated with
1018 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1019 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1020 pointlessly wrapped (see
1021 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1022 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1023 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1024 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1025 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1026 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1027 -- File::Initialise: PixelConverter setup moved away to
1028 PixelConverter::GrabInformationsFromHeader()
1029 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1030 interpretation moved away to PixelConverter::BuildRGBImage()
1032 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1034 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1036 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1038 displayed on Win32 when a brutal abort() occurs (because of uncatched
1039 exception). See TODO new entry of this commit for more on this.
1040 * TODO added new entry.
1041 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1042 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1043 - HandleColor is no longer called from gdcmFile.cxx
1044 - gdcmPixelConvert.cxx clean up on method arguments and internal
1045 variable names for semantical coherence.
1047 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * Finished lossless transition, not only do we now read all lossless jpeg
1049 images, without the need of the Cornwell lib, but we do read them properly now
1050 * To reduce code (well to avoid code duplication), I defined a common place
1051 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1052 redefine symbols. This is not perfect but this the best solution I found for a
1053 compilation time jpeg option.
1055 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * Update jpeg ijg lib to support lossless jpeg implementation
1057 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1059 * Also added a special copyright for dcmtk since we use their bugfixes.
1062 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1064 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1065 matters, as stated in warning note at beginning of %include section).
1066 * src/gdcmDicomDir*.[cxx|h]: coding style
1067 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1068 * src/gdcmJpeg8.cxx: doxygen fix.
1069 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1070 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1071 from File:: to PixelConvert::.
1073 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1075 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1076 - more code moved away from File:: to PixelConvert::
1077 - fat setup of PixelConverter set in place in File::Initialise.
1079 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1080 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1081 namespace at the file system level. So now you should convert your examples
1083 gdcmHeader -> gdcm::Header
1084 It would be nice if people keep in mind to no open the namespace, since it
1085 allows compilation on broken plateform which were defining common symbol in
1086 the standart namespace (like LP, Unknown ...)
1088 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1090 The JPEG fragments are now parsed at the same stage than the RLE
1091 information. All code related to JPEG is now in gdcmPixelConvert:
1092 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1093 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1094 export a gdcmFile:: method. Those are simply global functions
1095 (for the time being this is better than having them attach to
1096 either gdcmFile:: or gdcmPixelConvert::).
1097 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1098 and stores the result in a gdcmJPEGFragmentsInfo.
1099 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1100 code (among other stuff) moved away from gdcmFile:; to
1103 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1105 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1106 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1107 clean up of RLE related code.
1108 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1109 - src/gdcmRLE.cxx removed
1110 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1111 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1112 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1113 * CLEANUP_ROUND (9) for gdcmPixelConvert
1114 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1115 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1116 away from gdcmFile:: to gdcmPixelConvert::.
1118 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1120 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1121 This is because Parse7Fe0 used to parse the pixels to compute the
1122 length. This task was passed over to FindDocEntryLengthOB() a long
1123 time ago, EXCEPT I had forgotten the OW case...
1124 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1125 we just recylce the code for parsing RLE fragments and computing
1127 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1128 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1129 with the retired Parse7Fe0().
1130 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1131 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1133 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1134 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1135 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1136 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1137 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1138 * CLEANUP_ROUND (4) for gdcmPixelConvert
1139 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1140 to return an unused length.
1142 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1143 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1144 this should be cleanner from the plane view. The iostream are erally a pain
1145 to use to do simple stuff.
1147 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1148 * Redo the compilation of the ijg jpeg library. Now only one source is
1149 necesseray. No need to rename file by hand what so ever. CMake handle the
1150 copying of the file within different directory, configure header file to
1151 modify some symbol. The only addition made to ijg wasd a mangle table so
1152 that symbol are different whether we are within 8bits or 12bits.
1154 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1155 * Added documentation of vtkgdcmReader on Website:
1156 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1157 with it's binary name).
1158 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1159 the Website to be more complete.
1160 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1161 doxygenated documentation.
1162 - Doc/DoxyVtkGdcmReaderExamples.txt added
1163 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1164 DoxyVtkGdmReaderExamples.html )
1165 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1166 * CLEANUP_ROUND (3) for gdcmPixelConvert
1167 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1169 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * CLEANUP_ROUND (2) for gdcmPixelConvert
1171 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1173 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * CLEANUP_ROUND for gdcmPixelConvert:
1175 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1176 - src/gdcmPixelStuff[h|cxx] removed
1177 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1178 - src/CMakeLists.txt changed accordingly
1179 * GDCMHOME clean up:
1180 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1181 gdcmVersion.py moved to newly created ATTIC related
1182 gdcmPython/SetupOldies/ directory.
1183 * Autotools clean up:
1184 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1185 - autogen.sh configure.in acinclude.m4 python.m4 removed
1187 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1189 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1190 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1192 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * TODO updated with Mathieu suggestions. I proposed a template for
1194 describing TODO entries and used it for new entries.
1195 * Added Doc/Website/CodingStyle.html, Developpers.html,
1196 DeveloppersPython.html, GdcmDataCvs.html and
1197 DownloadVersion0_1.html, DownloadVersion0_3.html.
1198 * Some Doc/*.txt Doxygen files (which do not really concern the
1199 documentation itself, but the website) moved to html and
1200 placed in directory Doc/Website:
1201 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1202 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1203 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1204 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1205 * CMakeLists.txt changed accordingly.
1206 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1207 DeveloppersPython.html
1208 * INSTALL nows refers to Doc/Website/Installation.html
1210 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * Added Doc/Website directory, that contains a first raw version
1214 2004-09-23 Jean-Pierre Roux
1215 * FIX In order not to be poluted any longer by casting problems,
1216 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1217 we can now delete[] it safely
1218 * VoidArea is now called BinArea (less confusing name),
1219 and all the methods called ...VoidArea... are now ... BinArea...
1220 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1222 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1224 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1225 up to the destructor of gdcmElementSet to clean up TagHt and it's
1228 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1230 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1232 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * ENH: added some utility method that builds a flat dictionary
1234 holding all the Dicom entries contained in the recursive structure
1235 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1236 an example of usage.
1237 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1238 BuildFlatHashTable() that build a flat dictionary.
1239 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1240 gdcmDocument is now a friend of gdcmElementSet.
1241 - src/gdcmElementSet.cxx: clean up.
1242 - Example/FlatHashTablePrint.cxx added.
1243 - Example/CmakeLists.txt changed accordingly
1245 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1247 moved away from gdcmDocEntrySet (since this class is an abstract class
1248 acting like an interface). SQDepthLevel and BaseTagKey are now
1250 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1251 and associated accessors. Doxygenation of the class.
1252 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1254 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1255 Use SQDepthLevel accessor instead. ::Print() adapted.
1256 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1257 - src/gdcmDocument.cxx changed accordingly.
1259 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1261 - The following is the doxygen comment of the typedef declaration
1262 of gdcmTagKey in src/gdcmCommon.h:
1263 gdcmTagKey is made to old an "universal" (as in URL, Universal
1264 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1265 A dicom tag always has a group and an element, but a set of tags
1266 embeded in various (optionally nested) sequences and sharing
1267 the same group and element all share the same (group, element)
1268 "identifier". Hence the (group, element) cannot be used as an
1269 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1270 In order to construct a proper tag identifier (i.e. a key) we
1271 consider the following definition of a TagKey:
1272 - let Group, Element be the string representation of the
1273 group and element dicom tag members,
1274 - let ItemNumber be the string representation of the integer
1275 index of the considered item number of a sequence,
1276 Let the key of a tag embeded in a sequence, noted SeqTag, be
1278 /ItemNumber#Group|Element
1279 where "/", "#" and "|" are characters acting as separators.
1280 Then the general form of a gdcmTagKey is given by:
1281 Group|Element<SeqTag>
1282 where <SeqTag> means NO or many instances of SeqTag.
1283 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1286 but the gdcmTagKey of a tag "embeded" is the first item of
1287 a sequence, itself nested in the third item of a sequence is the
1289 0004|1220/2#0008|0082/0#0008|0090
1290 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1291 order to hold the new sequence compatible key. Previously, the
1292 GetKey() method would look in the underlying gdcmDictEntry.
1293 - src/gdcmDocEntry.cxx:
1294 -- constructor now copies the underlying DictEntry key, in the local
1296 -- ::Print: displays the member Key, instead of the (group, element).
1297 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1298 - src/gdcmDocEntrySet.h:xi
1299 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1300 -- now has a new BaseTagKey member.
1302 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1303 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1305 This poses the problem with the semantics of the following lines
1306 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1307 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1308 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1309 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1310 to the long FIXME note for what the problem is. Nevertheless in
1311 order to get things working the dicom dictionary was altered !
1312 Please fix things urgently...
1313 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1314 information), see above note on moving the member VoidArea. Nevertheless
1315 the following entries previously correctly set as US are now inproperly
1317 0028 1201 OW IMG Red Palette Color Lookup Table Data
1318 0028 1202 OW IMG Green Palette Color Lookup Table Data
1319 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1320 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1321 of gdcmDocEntry moved to gdcmSeqEntry.
1322 * src/gdcmSeqEntry.cxx: STYLE.
1324 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1327 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * gdcmPython/testSuite.py: all the test suite in python is now moved
1329 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1330 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1331 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1333 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1335 to avoid inclusion recursion until STL is reached.
1336 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1337 mecanism. errno.h is not included in gdcm anymore.
1338 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1339 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1341 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1342 gdcmData/TestAllEntryVerifyReference.txt
1343 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1344 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1345 exception_on_error parameter.
1346 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1347 - vtk/vtkGdcmReader.cxx changed accordingly,
1348 - Example/*.cxx and Test/*.cxx changed accordingly.
1350 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1352 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1353 enable_sequences removed from gdcmHeader constructor and dependencies.
1354 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1355 * gdcmPython/demo/PrintHeader.py: dummy fix.
1356 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1357 skip_shadow removed from gdcmHeader constructor and dependencies.
1358 * Example/*.cxx and Test/*.cxx changed accordingly.
1360 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1362 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1364 2004-07-21 Jean-Pierre Roux
1365 * FIX Now, Parsing and Printing a DICOMDIR do work!
1366 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1368 2004-07-20 Jean-Pierre Roux
1369 * FIX Some brain damaged headers have Zero-Lenght fields
1370 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1372 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1373 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1374 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1375 variable (instance of gdcmDebug) by a definition macro, and the instance
1376 is now in static in the gdcmDebug class
1377 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1378 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1380 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * WARNING: ctest now depends more tightly on gdcmData. You should
1382 check out gdcmData properly for things to run smoothly...
1383 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1384 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1385 we need the pixels not be loaded in order to use the ValEntry
1386 that displays position and size).
1387 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1388 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1389 be deprecated. If you have any doubts about the advantages of a
1390 modern scripting language (read Python) versus grass root C++ (i.e.
1391 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1392 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1393 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1394 Anyhow, consider documenting the gdcmData images in
1395 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1397 * Test/CMakeLists.txt:
1398 - now uses TestAllEntryVerify.cxx
1399 - specific comments on oldACR00001.ima (now renamed in gdcmData
1400 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1401 gdcmData/TestAllEntryVerifyReference.txt
1404 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * src/*.[h|cxx] : typedef clean up
1406 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1407 - TagKey renamed to gdcmTagKey (for external usage)
1408 - VRKey renamed to gdcmVRKey (for external usage)
1409 - removal of typedef duplication.
1410 - Removed all unecessary inline keyword from class inline definitions.
1411 - Some method|function(void) declarations replaced with method|function().
1412 * src/jpeg/libijg12/jdhuff12.c:
1413 - printf polluting ctest removed.
1414 - TAB removal for comminting
1416 - TestAllReadCompareDicom.cxx: added a test that compares all the
1417 images in gdcmDataImages.h with corresponding images in
1418 gdcmData/BaselineDicom/. When baseline images are not present
1419 this test creates them.
1420 Note: we need to validate each reference image, but before that
1421 I'd like to rename them with a more explicit name...
1422 - CMakeLists.txt: changed accordingly.
1423 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1424 including each header needed).
1426 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1428 test suite to the Example directory. Are concerned:
1433 - TestWriteSimple.cxx
1434 * Test/CMakeLists.txt: added some comments on reasons for black listing
1435 image gdcmData/oldACR00001.ima
1437 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * Test/CmakeList.txt: removed the following from black list (to be coherent
1439 with removal from gdcmData):
1440 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1441 - gdcm-MR-PHILIPS-16.dcm
1443 Added the following because after last cvs update, they cause
1444 ctest -R TestReadWriteReadCompare
1446 - gdcm-MR-SIEMENS-16-1.acr
1448 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1449 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1450 new comments in this file) we temporarily (sigh) move to a weaker
1452 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1453 we don't need to black list the following images anymore:
1454 - 8BitsUncompressedColor.dcm
1456 - US-PAL-8-10x-echo.dcm
1457 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1458 fixes and the beautified code ;-)
1459 This fixes the bug introduced in version 1.42 (when beautifying)
1460 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1461 Note: ctest was blind to this bug (this means we need to still
1462 improve the test suite). The bug could be detected by using
1463 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1465 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1466 and by displaying the (garbage) produced file temp.XDCM...
1468 2004-06-29 Jean-Pierre Roux
1469 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1470 - replace by uggly but working old code :-(
1471 A lot of things should be OK again.
1472 It's really urgent to have a test suite that *tests*,
1473 to prevent Frog's beautifying sessions to break all the stuff
1474 (twice, withing a fortnigh ...)
1476 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1477 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1478 redundancy) to added Test/TestReadWriteReadCompare.cxx
1479 * Test/CmakeList.txt: because the compare test of
1480 Test/TestReadWriteReadCompare.cxx fails, the following images are
1481 black listed: - 8BitsUncompressedColor.dcm
1483 - US-PAL-8-10x-echo.dcm
1484 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1485 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1486 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1487 and ad-hoc kludge. This kludge is now removed, and on encountering
1488 such an image (OB field brain damaged) we set errno. Then in
1489 ::FindDocLength() we "fix" the length as being ALL what remains
1490 in the file (until EOF). We then proceed, hoping for the best...
1491 This fixes a SegFault in ShowDicom when trying to write such an
1493 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1494 (because TestWriteRead breaks on it, after a non conformal commit?).
1495 ctest now runs properly, except for MakeDicomDir (which was always
1496 broken) and the Python related stuff (still not fixed).
1498 2004-06-24 Jean-Pierre Roux
1499 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1500 FIX : Test/TestReadWrite now iterates on all the file names
1501 (instead of infinite loop)
1502 ENH : Test/TestWriteRead now iterates on all the file names
1504 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1507 2004-06-24 Jean-Pierre Roux
1508 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1509 when SamplesPerPixel =3
1510 - now Write is no longer confused by
1511 'BitsAllocated = 12" and 'BitsStored=12"
1512 - "UN" value representation Elements are now written correctly
1513 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1514 ENH : - now gdcmHeader has its own Write methods
1515 (in order to split the job that has not to be done
1518 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1519 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1520 loop on the same image until memory went out.
1521 Note: this means we still have gobs of memory loss in PrintDocument
1522 * src/gdcmDocument.cxx: fixes problem on parsing on file
1523 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1525 2004-06-24 Jean-Pierre Roux
1526 FIX : Write - All the Sequences and Sequence Item are now written
1527 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1528 is added a the end, when necessary.
1529 - A lot of brain-damaged images, that were read correctly are
1530 now written correctly
1531 - length compatible BinEntry are now loaded correctly
1532 (even for odd groups)
1533 Note : only Explicit Value Representation was checked.
1534 (question : is implicit VR really necessary for gdcm ?)
1536 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1537 * DEVELOPPER: added a proposition of coding style.
1538 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1541 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1542 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1543 Use the gdcmDocEntry::Print() and Write() instead.
1544 * src/gdcmDocument.cxx: bug fix.
1546 2004-06-22 Jean-Pierre Roux
1547 FIX : gdcmDocument.cxx
1548 - Now we do recognize the JpegLossLess format (there was a misstyping in
1549 code 'beautyfication' :-(
1550 - Now we automaticaticaly load the Luts, if any
1552 2004-06-22 Jean-Pierre Roux
1553 In order : to write Sequences, whatever their imbrication level,
1554 : to allow user to create his own Sequences
1555 a lot of modif where necessary (adding, moving, or virtualising methods)
1557 WARNING : save your own sources *before* cvs up !
1560 ADD virtual void Write(FILE *fp, FileType filetype);
1563 ADD virtual void Write(FILE *fp, FileType filetype);
1564 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1567 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1568 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1569 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1570 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1571 ADD std::string GetEntryByName(TagName name);
1572 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1574 std::string vr = "unkn",
1575 std::string fourth = "unkn",
1576 std::string name = "unkn");
1577 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1578 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1579 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1580 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1581 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1582 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1583 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1584 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1587 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1588 ADD virtual std::string GetEntryByName (TagName tagName);
1589 ADD virtual std::string GetEntryVRByName (TagName tagName);
1590 REM virtual bool Write(FILE *, FileType);
1591 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1592 FILE *_fp, FileType type);
1593 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1594 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1595 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1596 REM virtual std::string GetEntryByName (std::string tagName);
1597 REM virtual std::string GetEntryVRByName (std::string tagName);
1598 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1599 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1600 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1602 std::string vr = "unkn",
1603 std::string fourth = "unkn",
1604 std::string name = "unkn");
1605 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1606 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1607 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1608 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1611 ADD virtual void Write(FILE *fp, FileType filetype);
1614 ADD virtual void Write(FILE *fp,FileType filetype);
1617 ADD virtual void Write(FILE *fp, FileType filetype);
1618 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1619 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1620 REM std::string GetEntryByName(TagName name);
1623 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1625 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1626 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1627 The default constructor invoked by the line
1628 gdcmHeader *f1 = new gdcmHeader( header );
1629 was gdcmHeader::gdcmHeader(bool) instead of the expected
1630 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1631 Hence the parsing wasn't executed... See also below.
1632 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1633 as explicit constructor didn't do the trick to fix the above problem.
1634 Could anyone explain why ?
1635 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1636 properly calls gdcmValEntry::Print() (that was weed out from
1637 code related to gdcmBinEntry).
1639 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * In order to fix memory leaks:
1641 - Test/TestWriteSimple.cxx: added cleaning of free store through
1643 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1644 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1645 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1646 (through the call to ::AddDicomDirMeta()) or the destructor
1647 would crash when deleting uninitialized ::metaElems].
1648 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1649 - src/gdcmDocument.cxx:
1650 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1651 from dynamic stores.
1652 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1653 was causing memory leaks.
1654 - src/gdcmSQItem.cxx:
1655 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1656 cleanly handled with polymophism: sorry but my milage is low).
1657 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1658 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1659 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1660 This avoids SegFaulting.
1661 - src/gdcmSQItem.h: coding style.
1663 - Test/TestWriteSimple still severely sucks. The output image content
1664 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1665 damaged when displayed with vtkgdcmViewer.
1666 - on memory leaks: TestWriteSimple leaks really less (see entry
1667 of 2004-06-18 in Changelog file for the call to valgrind).
1668 - on segfaults: ctest now passes all the tests but one (no more
1670 * Erroneous leading white fix:
1671 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1672 white[s] (as opposed to from >> xxx, that removes it [them].
1673 - src/gdcmTS.cxx: ditto.
1674 - gdcmPython/testSuite.py: dirty related kludge removed.
1675 * src/*: remaining references to gdcmParser removed.
1676 * src/*[cxx|h]: added copy[way]left header.
1679 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1680 * In order to fix writing of dicom files:
1681 - Test/TestWriteSimple.cxx: a simpler example of writing.
1682 - Test/CMakeLists.txt changed accordingly.
1683 - src/gdcmDocument.cxx:
1684 -- The destructor now recursilvely removes potential sequences.
1685 -- Bug fix in ::IsJPEG2000()
1686 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1687 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1689 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1690 to only declared) and build on top of
1691 ::GetDocEntryByNumber(guint16, guint16).
1692 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1693 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1694 for usage in destructor and treatement of promotion in
1695 ::ReplaceOrCreateByNumber().
1696 - src/gdcmSQItem.cxx: destructor should better handle his job.
1697 Test/TestWriteSimple now runs (or at least it DOES something).
1698 * We can now start hutting memory links. A good starting point is:
1699 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1700 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1701 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1703 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1704 * Valgrind note: after Mathieu Malaterre teached me how to read
1705 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1707 Using gcc, you can force the STL to use malloc and to free memory as
1708 soon as possible by globally disabling memory caching.
1709 With 3.2.2 and later, you should export the environment variable
1710 GLIBCPP_FORCE_NEW before running your program.
1711 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1712 simply vanish (it is still not clear to me, whether this means that
1713 STL std::string leaks or if valgrind believes it leaks...).
1714 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1715 running bin/gdcmTests makeDicomDir):
1716 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1717 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1719 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1720 SegFaulting (I drowned in DicomDir related code when trying to
1721 understand why the list is empty...).
1722 * src/gdcmDocument.h: first BSD license header try.
1723 * Doc/License.txt added.
1725 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * src/gdcmDocument.[h|cxx]:
1727 - Clean up of the Transfer related predicates. They are now all based
1728 on new method isGivenTransferSyntax, that (should) handle properly
1729 the padding problem.
1730 - general clean up, simplification, and coding style.
1731 - Specific clean up of Parse7FE0() (umproperly named actually).
1732 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1734 2004-06-14 Jean-Pierre Roux
1736 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1737 - fix the display of SQItem ordinal number
1738 - add the GetSQItemByOrdinalNumber method
1739 - remove some useless never written private methods
1741 2004-06-14 Jean-Pierre Roux
1743 - adding a constructor taking a gdcmDocEntry as an input param
1744 - ReplaceOrCreateByNumber now returns :
1745 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1746 a gdcmValEntry * if a string value is passed as a param
1748 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1749 according to the param type (no longer sets a gdcmDocEntry)
1750 - GetValEntryByNumber, GetBinEntryByNumber added
1751 - NewValEntryByNumber and NewBinEntryByNumber added
1753 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1755 - GetSQItemNumber and SetSQItemNumber added, to provide
1756 a (relative) Item identier inside a given Sequence
1757 \warning : some pb remaining around this number
1759 - AddEntry now takes the Item Number as a param
1761 - adding a constructor taking a gdcmDocEntry as an input param
1763 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1764 * Memory leak hunt with the following command:
1765 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1766 --show-reachable=yes gdcmTests PrintDocument
1767 It looks like many (all?) leaks are due to the STL (or a bad usage
1768 of the STL. The lines producing the leaks now have a comment with
1769 a "MEMORY LEAK" tag: you can retrieve them with
1770 grep "MEMORY LEAK" src/*
1771 Here are two typical examples which I can't help fixing:
1776 char * test = "babo";
1777 name = test; //// <--- valgrind detects 960 bytes lost in
1778 //// call to std::string::operator=(char const*)
1779 name.clear(); //// Doesn't help !
1787 std::cout << "Type a bunch of characters followed by RETURN: ";
1788 getline(std::cin, line); //// <--- valgrind dectects a loss
1789 //// of 1320 bytes in call to
1790 /// std::basic_istream<>& std::getline<>
1796 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * src/gdcmHeader.[cxx|h]:
1798 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1799 and related, moved away to gdcmDocument.
1800 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1801 the corresponding protected accessors of inherited class
1802 gdcmDocument, removed ! As a consequence gdcmFile had to be
1803 declared friend of class gdcmDocument (see below).
1804 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1805 - Clean up of undefined or unused methods.
1806 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1807 account the changes to gdcmHeader.h).
1808 * src/gdcmDocument.h:
1809 - gdcmFile is now a friend class (in order to take into account the
1810 changes to gdcmHeader.h).
1811 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1812 (see changes to gdcmHeader.h).
1813 - Accessors (reading on the form GetEntry*) are now public.
1814 - Clean up of undefined or unused methods.
1815 * src/gdcmDocument.cxx:
1816 - adaptation to changes to gdcmDocument.h
1817 - ::OpenFile now writes a verbose message when file cannot be opened.
1818 - some std::string properly set to VRKey
1819 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1820 references to gdcmDocument.
1821 * Test/TestFindTags.cxx: changed accordingly to above changes.
1822 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1823 cvs repository gdcmData.
1825 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1826 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1827 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1828 conflicts with gdcmValEntry::voidArea.
1829 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1830 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1831 Value representation between StringRepresentable and BinaryRepresentable.
1832 * src/gdcmDocument.cxx:
1833 - method ParseDES: proper indentation restored and usage of
1834 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1835 - method LoadDocEntry: the fingerprint left in the SetValue() of
1836 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1837 removed. Reverting to previous code segment with the proper
1838 dynamic_cast< gdcmValEntry* >.
1839 Note: this was (partially) breaking the python test suite
1840 (gdcmPython/testSuite.py) that made usage of the above
1841 fingerprint to check presence of "Pixel Data".
1842 * src/gdcmDocEntry.h: coding style.
1843 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1844 now taken into account.
1845 * gdcmPython/gdcm.i: adaptation to the new internal representation
1846 of gdcm (exit gdcmParser, hello gdcmDocument).
1847 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1849 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1850 anymore, but instead prints the loaded Python dictionary.
1851 * .... alas, the python testSuite is still broken.
1853 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1854 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1856 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1857 * src/gdcmUtil.h : export methods
1859 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1860 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1862 * Initial addition of automatic python testing
1863 * Initial addition of automatic image comparison
1865 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1867 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1869 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1870 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1871 * Test/ShowDicom.cxx : bug fix for msvc compilation
1872 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1874 2004-05-04 Jean-Pierre Roux
1875 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1876 new concepts (and new classes) :
1877 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1878 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1879 - Sequence Doc Entries (gdcmSeqEntries)
1880 a Sequence is composed of Items.
1881 Each item is a set of Doc Entries (this is recursive)
1882 The non uniqueness of the 'Dicom tag' is due to this recursivity
1883 (never taken into account)
1884 Our unability to add a new 'entry' in the header
1885 at the proper location (neither in the H-Table (map or multimap),
1886 nor in the Chained List is also due to this recursivity.
1887 Don't try, right now, to use/modify/compile these new sources :
1888 nothing is finished.
1889 We just commit all the stuff, 'as is', in order not to loose it.
1891 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1894 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1895 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1896 file prefix (SetFilePrefix)
1898 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1899 * Add a new test: ShowDicom, for now this is just the c++ version of
1900 checkRead.sh, later it will be able to compare the image read against a
1902 * Replace the DEBUG on the stack with a global entry in cmake interface:
1903 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1905 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1906 * Add an example subdir, with a real example on how to read + write a
1909 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1911 * Doc/CMakeLists.txt: the main page is now properly differentiated
1912 between the developper and user version.
1913 * Doc/doxygen.config.in: dropped search related obsolete flags
1914 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1916 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * DEVELOPPER: added some helpfull comments for compile/test/install
1920 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1922 src directory, now generated in the build dir.
1923 2. Tests as mentionned smarter
1925 4. Add a new method in gdcmDict that return the PubDict by name
1926 this is interesting for 3rd party lib like ITK,
1927 where we could set the institution name / patient name...
1929 * ENH: 1. Now the test suite is working for real
1930 2. All binaries are now output in the gdcm-bin directory
1931 (this was not true before)
1933 2004-04-28 Jean-Pierre Roux
1934 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1935 SeQuence indented printing of Dicom Header.
1936 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1937 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1938 Computation of SQDepthLevel is now part of gdcmHeader constructor
1939 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1940 tree-like structure of a Dicom Header.
1941 * FIX Test code cleaning
1943 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * ENH: Adding automatic testing
1945 1. Need a DartConfig.cmake to submit to public
1946 2. Add a test driver gdcmTest.cxx
1947 3. gdcmTestMain, an helper for the main test driver gdcmTest
1948 4. Files in Test don't have a main anymore, this becomes interesting
1949 when we add more and more tests, thus dsw don't have to load
1951 * ENH: Adding a GDCM_DATA_ROOT for testing
1952 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1953 one file instead of seven + some small cleanup
1955 2004-04-22 Jean-Pierre Roux
1956 * ENH Minor changes to the Print() methods.
1957 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1958 Header printing. Example given with :
1959 > PrintHeader fileName 2 new
1960 (SQ based tree-like structure still to be done for the Header ...)
1962 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1963 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1964 1. I have added some unsigned where needed
1965 2. Some function parameter not used -> (void)
1966 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1967 4. g++ don't like character '\' in comment
1968 5. #define jpeg_create_decompress jCreaDecompress
1969 this really need to be fixed
1970 6. virtualize destructor of gdcmObject ... leakage
1971 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1972 this also really need to be fixed
1973 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1974 remove compression file
1975 (as we only do decompression, right ?)
1976 * ENH: Change malloc/calloc/free with c++ equivalent
1978 2004-04-21 Jean-Pierre Roux
1979 * FIX gdcmHeaderHelper::GetXSpacing
1980 when a single value is found (bug ?), xpacing is now
1981 defaulted to yspacing
1983 2004-04-19 Jean-Pierre Roux
1984 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1985 * ENH add parameters :
1986 bool exception_on_error = false,
1987 bool enable_sequences = false,
1988 bool ignore_shadow = false
1989 to the gdcmFile constructors to be full gdcmParser compliant
1990 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1991 to allow reading of PAPYRUS 3.0 files
1993 2004-04-06 Jean-Pierre Roux
1994 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1996 2004-04-02 Jean-Pierre Roux
1997 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1998 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1999 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2001 2004-03-30 Jean-Pierre Roux
2002 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2003 for ACR file, written out as DICOM files (hope so...)
2005 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2007 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2008 moved to base class gdcmParser and only the specialisation is kept
2010 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2011 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2012 already does the job.
2013 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2014 (to be consistent with gdcmParser::WriteEntries).
2016 2004-03-30 Benoit Regrain
2017 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2018 upate of the object's instance. It's passed to 2 in the unfavorable
2019 case : one in the ExecuteInformation, one in the ExecuteData
2021 2004-03-29 Jean-Pierre Roux
2022 * ENH : Check on file type to be written moved
2023 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2024 * FIX : gdcmObject::ResetBoundaries now stops properly
2025 when end-of-list is reached
2026 : gdcmVersion modified (as Benoit Regrain asked)
2028 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2030 * src/gdcmUtil.cxx: added forgotten iostream include.
2031 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2032 equivalent to ExplicitVR in existing code).
2034 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2036 now contains all the gdcmGlobal related code.
2037 * minor coding style and doxygenation changes.
2039 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2041 now contains all the Debug related code.
2042 * minor clean-up of includes in src/*.cxx
2043 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2044 CreateCleanString) removed.
2045 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2046 * Doc/DoxyMainPageUser.txt added.
2047 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2048 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2049 src/gdcmDirList.cxx)
2051 2004-03-24 Jean-Pierre Roux
2052 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2054 2004-03-23 Jean-Pierre Roux
2055 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2056 big endian made volumes
2057 * ENH Now gdcmParser constructor and destructor are protected to forbid
2058 end user to instanciate class gdcmParser
2059 (only gdcmHeader and gdcmDicomDir are meaningfull)
2061 2004-03-22 Benoit Regrain
2062 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2063 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2064 gdcmSerie to gdcmDicomDirSerie
2066 2004-03-19 Jean-Pierre Roux
2067 * ENH Now the tree-like structure describing a DICOMDIR comming from
2068 an already existing DICOMDIR file is consistent with
2069 the home-made tree-like structure build ex-nihilo
2070 or build from the files held (recursively) in a Directory
2071 functions gdcmDicomDir::CheckBoundaries()
2072 gdcmObject::SetBoundaries() added
2074 2004-03-17 Jean-Pierre Roux
2075 * REM (Eric Boix bug) : removal of meaningless
2076 gdcmDicomDirImage::NewImage function.
2077 * FIX now file names and directory name are written properly in the
2079 * FIX now gdcmDicomDir constructor may be call without any trick
2082 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2083 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2084 of gdcmDicomDirImage::NewImage as empty function.
2086 2004-02-28 Jean-Pierre Roux
2087 * ENH add gdcmDicomDir:NewPatient
2088 add gdcmDicomDirPatient:NewStudy
2089 add gdcmDicomDirStudy:NewSerie
2090 add gdcmDicomDirSerie:NewImage
2091 to allow making gdcDicomDir object.
2092 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2093 (as opposite to the gdcmHeader chained list)
2095 2004-02-11 Benoit Regrain
2096 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2097 when using from python
2099 2004-02-10 Benoit Regrain
2100 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2101 * FIX : in gdcmDicomDir when the directory is empty
2102 * ENH : add callback and methods to get the progression of dicomDir
2105 2004-02-06 Jean-Pierre Roux
2106 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2107 - GDCM_META added to gdcmDicomDirType
2108 - class gdcmMeta created
2109 * ENH : - A brief summary is now displayed at the beginning of
2110 'testDicomDir' to help disaster magnitude estimation
2111 * REM : Now useless Test/explDICOMDIR.cxx
2113 2004-02-05 Benoit Regrain
2114 * ENH : add methods in gdcmObject to get the hash table or the list of
2116 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2117 * FIX : wrapping python for TagHeaderEntryHT
2119 2004-02-04 Benoit Regrain
2120 * FIX : even length for some strings when writting the dicom dir
2121 * FIX : sort the images in the dicom dir
2122 * FIX : Bug fix for python use of dicom dir
2123 * ADD : a python demo
2125 2004-02-04 Jean-Pierre Roux
2126 * FIX : Final solution (?) for icone embedded images
2127 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2128 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2129 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2130 gdcmData/gdcm-MR-SIEMENS-16.acr1
2131 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2132 to make full checking easier
2134 2004-02-04 Benoit Regrain
2135 * FIX : WriteEntries : coding style & logic in parameters
2136 * FIX : Set the elements to create the DicomDir in a dictionary file
2138 2004-02-03 Benoit Regrain
2139 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2140 * gdcmDicomDir : add the load of directory
2141 * Bug fix and print add-on
2143 2004-02-03 Jean-Pierre Roux
2144 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2145 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2146 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2147 * FIX gdcmParser.cxx : 'group length' elements are now considered
2148 as integers, even for shadow groups, when file is Implicit VR
2150 2004-02-02 Jean-Pierre Roux
2151 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2153 of the last synonym :-(
2154 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2156 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2157 * FIX taking into account the possible 7fe0,0010 multiplicity
2158 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2159 to allow removal of references to 7fe0,0010, to deal with
2160 ACR-NEMA images, when 0028,0200 is meaningfull
2162 2004-01-31 Jean-Pierre Roux
2163 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2164 no longer writes 'Un' on disk
2165 * FIX SQ elements with actual length are now dealt with corectly
2166 * FIX gdcmFile::WriteBase make the difference, for color images, between
2167 the length (for Palette expanded images)
2168 and Raw Length (non expanded image + Palette)
2169 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2170 (that broke Write). Replaced by UL.
2171 Aware user will reload the field if he
2172 thinks it's necesssary
2174 2004-01-30 Jean-Pierre Roux
2175 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2176 when 'dirty Acr' is found, to be compliant with the new
2177 IsReadable() methods.
2179 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2180 (no DOUBLE images in kosher DICOM,
2181 but so usefull for people that miss them ;-)
2183 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2184 DICOMDIR related utilities (not checked as Windoze compliant)
2186 2004-01-28 Jean-Pierre Roux
2187 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2189 2004-01-27 Jean-Pierre Roux
2190 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2191 to allow skipping the shadow elements, to save memory space.
2192 The TRUE value for this param has to be used
2193 with a FALSE value for the 'enable_sequence' param.
2194 ('public elements' may be embedded in 'shadow Sequences')
2195 * gdcmHeader methods now deal with 'embedded icones images' in the header
2196 (even when an 'icone image sequence' is announced by the
2197 element (0x0088,0x0200), but there is NO icone at all ...
2199 * gdcmHeader sometimes Image Location value doesn't follow
2200 the supposed processor endianity (see gdcmData/cr172241.dcm).
2203 * gdcmHeader add the method
2204 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2205 to get *all* the Header Entries with the same tag.
2206 GetHeaderEntrySameName is probabely *useless*
2207 (no meaning : Name is *not* an identifier within the Dictionary)
2209 2004-01-26 Benoit Regrain
2210 * Bug fix in the print of hexadecimal representations. Remove long fields
2211 in the print and add a third level of print to print them
2213 2004-01-23 Benoit Regrain
2214 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2215 * Bug fix on test suite after remove the strip made on not string fields
2216 * Split the IsReadable method between gdcmParser which test that the file
2217 is dicom and gdcmHeader which test that it's an image file
2219 2004-01-22 Benoit Regrain
2220 * DicomDir : clean code, add methods, set variables in protected or private
2221 * gdcmUtil : bug fix for the clean string method
2223 2004-01-19 Benoit Regrain
2224 * Add the use of shadow dictionaries
2225 * bug fix and coding style
2227 2004-01-19 Benoit Regrain
2228 * src/gdcmFile.cxx : bug fix concerning the close of file
2229 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2230 * Add the update of header entries using the shadow library
2232 2004-01-19 Benoit Regrain
2233 * removal of file gdcmHeader2.cxx
2234 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2235 inheriting from gdcmParser. This split is to prepare the integration
2236 of dicom dir parsing
2237 * bug fix under python
2239 2004-01-16 Jean-Pierre Roux
2240 * REM removal of class gdcmHeaderEntrySet
2241 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2242 * ADD add file gdcmHeader2.cxx
2243 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2245 2004-01-15 Benoit Regrain
2246 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2247 entries created while parsing the header. Thus, they will be destroyed
2248 when the gdcmDictSet will be destroyed
2249 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2252 2004-01-15 Benoit Regrain
2253 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2254 made a fatal error because of the memory release at the end of program.
2255 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2256 some memory and vtk seems to have some problems with that.
2257 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2259 2004-01-14 Benoit Regrain
2260 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2261 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2262 * src/*.[h|cxx] : make changes due to class name changes
2263 * gdcmPython/demo/*.py : bug fix due to method names
2265 2004-01-13 Benoit Regrain
2266 * src/*.[h|cxx] : coding style
2267 * vtk/*.[h|cxx] : coding style
2269 2004-01-13 Benoit Regrain
2270 * gdcmPython/testSuite.py : test the readable flag of file for tests
2271 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2272 It's lied to the stl compilation by MSVC (windows, always windows...)
2273 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2275 2004-01-12 Benoit Regrain
2276 * src/*.h : add comments
2277 * src/gdcmDictSet.h : set the method BuildDictPath in public
2278 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2279 directly setted in the source code
2280 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2283 2004-01-09 Benoit Regrain
2284 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2285 * setup.py : use a reference to gdcmVERSION
2287 2004-01-07 Benoit Regrain
2288 * Modification to compile with the distutils.
2291 2003-12-10 Benoit Regrain
2292 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2293 can use a gdcmHeaderHelper to load data
2294 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2295 made in the source code
2297 2003-12-10 Benoit Regrain
2298 * Update Windows projects and .cvsignore files
2300 2003-11-12 Jean-Pierre Roux
2301 * ENH gdcmHeader constructor has one more parameter (default value : false)
2302 that allows the user to 'go inside' the SeQuences only
2304 gdcmElValSet:Print takes it into account
2306 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2307 * ENH: Update gdcmPython/CMakeLists
2308 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2309 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2311 2003-11-10 Jean-Pierre Roux
2312 * FIX : gdcmHeader::LoadElements is now based
2313 on the ListTag listElem member,
2314 not longer on the TagElValueHT tagHt member
2315 * ENH : PrintPubElVal shows (temporarily) both results,
2316 with the tagHt member and the listElem member.
2317 (it's easier to 'see' the problems when using Printheader)
2319 * FIX : old private member LgrElem is now splitted into
2320 ReadLength : Length actually found on disk (updated only
2321 if bug fixing is necessary), for internal
2323 UsableLength : Updated by FixFoundLength, to fix a bug
2324 or to allow Parser going on.
2325 Will allow to re-write a kosher header when a SeQuence
2326 with a length (not 0000) is found
2327 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2328 because gdcmElValSet::Add does not update ListElem
2331 2003-11-07 Jean-Pierre Roux
2332 * FIX misstyping in Transfert Syntax name table
2333 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2334 when they have an actual length (not 0000 nor FFFFF)
2335 (Nobody should care of it, but DICOMDIR explorers)
2337 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2338 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2340 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2341 * ENH: vtkGdcmReader now supports LUT !
2342 (vtkgdcmViewer for now is not able to use them though)
2344 2003-11-05 Jean-Pierre Roux
2345 * in testSuite.py : new files names for checking the package
2346 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2347 that returns the pixel area size to the *aware* (vtk) user
2348 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2350 2003-11-05 Benoit Regrain
2351 * in testSuite.py : Modify the rules for checking the paths
2352 : Explicit error messages
2353 * in __init__.py : Related modif
2355 2003-11-03 Jean-Pierre Roux
2356 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2357 to be used by aware (vtk) users that want to manage
2358 LUT (and no to turn the PALETTE image into an RGB pixels one)
2359 * GetPixelType now returns 8U for 24 Bits images
2360 (vtkGdcmReader compliant)
2362 2003-10-31 Jean-Pierre Roux
2363 * Removal of *all* gdcmData images and add them again
2364 in order to loose the 'history' of un-anonymised images
2366 2003-10-31 Jean-Pierre Roux
2367 * RMV : removal of useless jBitsInJsample.h
2368 for both 8 and 12 Bits JPEG Lossy Libraries
2370 2003-10-31 Jean-Pierre Roux
2371 * ENH : Add the functions gdcmFile::GetImageDataRaw
2372 gdcmFile::GetImageDataIntoVectorRaw
2373 that act as GetImageData and GetImageDataIntoVector
2374 except the making of an RGB Plane from Gray Plane + LUT
2375 Intended to aware (vtk) users who know how to manage
2378 GetLUTRGBA return a R,G,B,A LUT if any
2379 lgrTotaleRaw gives the 'Raw' length
2380 GetImageDataRaw returns the gray Plane
2381 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2382 (They stay Grey, just like with other Dicom viewers :-(
2384 2003-10-30 Jean-Pierre Roux
2385 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2387 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2389 being coherents dicom files.
2391 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2392 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2394 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2395 * ENH: Two steps is necessary to please VC++ compiler...
2396 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2397 * ENH: Add include dir to medcon lib
2398 * FIX: only one function is being exported for now !
2399 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2401 2003-10-29 Jean-Pierre Roux
2402 * adding gdcmHeader::GetLUTRGBA
2403 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2404 --> Mathieu, the modif u're waiting for is not yet committed
2405 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2407 2003-10-27 Jean-Pierre Roux
2408 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2409 00191113.dcm DermaColorLossLess.dcm
2410 MxTwinLossLess.dcm RadBWLossLess.dcm
2411 * ENH: For version prior to vtkImageViewer2 -r 1.19
2412 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2414 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2415 * Removal of ido stuff in CMakeLists.txt
2417 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2418 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2419 * FIX: remove a call to ->Modified ... see comments
2420 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2422 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * FIX: Problem with path for libvtkgdcmPython
2424 * ENH: Try adding a search script for python site-package
2425 * RMV: Remove some file from medcon lib that are not necessary
2426 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2427 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2428 * FIX: More pragma disable fro VC++,
2429 I don't think I break something as it is also disable in VTK/ITK.
2430 But it fasten debug compilation time.
2432 2003-10-23 Jean-Pierre Roux
2433 * gdcm now deals with 16 Bits Run Length Encoded images
2434 (they are compressed as 2 planes images,
2435 one for the high Bytes, the other for low Bytes)
2437 2003-10-22 Jean-Pierre Roux
2438 * Now CheckRead takes into account :
2439 - the bugged 'Leonardo' Siemens images
2440 - the XA images, sent thru the burning VPRO station
2441 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2444 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2445 * FIX: When copying a Makefile.am to CMakeLists.txt
2446 one should remove the '\'
2448 2003-10-22 Jean-Pierre Roux
2449 * in gdcmData adding a bugged 'Leonardo' Siemens image
2450 (wrong lengths in header)
2451 OK with gdcm, KO with the other viewers :-)
2452 * add a GE dlx XA image, thru the VEPRO burning station
2455 2003-10-21 Jean-Pierre Roux
2456 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2457 for a brutal checking of vtkgdcmViewer compliance
2459 2003-10-21 Jean-Pierre Roux
2460 * add the files for 'xmedcon' Jpeg Lossless library
2461 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2463 2003-10-21 Jean-Pierre Roux
2464 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2466 2003-10-21 Jean-Pierre Roux
2467 * garbage Siemens 'Leonardo' images dealt with
2468 (the patch is easy to remove)
2469 * cosmetic changes to avoid warnings
2471 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2472 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2473 no need to press 'r' now.
2475 2003-10-20 Jean-Pierre Roux
2476 * upgrade of checkRead.sh checkWrite.sh according
2477 to new Jpeg Lossless decompressor
2478 * add US.3405.1.dcm, a genuine RGB medical file ...
2479 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2480 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2482 2003-10-15 Jean-Pierre Roux
2483 * general anonymisation in gdcmData
2484 * adding the 'color files' from
2485 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2486 * adding some well knowed bugged-header images
2487 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2488 waiting for their inclusion in Python testsuite
2490 2003-10-15 Jean-Pierre Roux
2491 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2492 no longer seg faults when file is not found
2494 2003-10-14 Jean-Pierre Roux
2495 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2498 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2499 * TODO: *.in file to genereate a UseGDCM later
2501 2003-10-14 Jean-Pierre Roux
2502 * Some supposed-to-be Dicom Images have no preamble.
2503 OpenFile takes it into account
2504 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2505 * Missing elements added in dicomV3.dic
2506 (just to be affraid : have a look at
2507 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2508 and do it again next year ;->
2510 2003-10-13 Jean-Pierre Roux
2511 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2512 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2513 But there are NOT. It's fixed !
2515 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * FIX: "jpeglib.h" was not found on VC++
2517 * FIX: vtkgdcm was not being installed
2519 2003-10-10 Jean-Pierre Roux
2520 * ENH : OpenFile closes the file if it *really* doesn't look like
2521 an ACR-NEMA / DICOM one.
2522 * FIX : testWrite no longer writes an empty file if the source file
2523 is not gdcm Readable
2524 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2527 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2528 * FIX: CMake generate now documentation
2529 * ENH: out of source doc build !
2530 * ENH: Generate both user and dev documentation
2531 * ENH: Should work on windows too
2532 * ENH: Only one doxygen config.in file is needed
2533 * FIX: make install should be ok now on ùnix plateform
2534 * FIX: PATH to dictionary was wrong (missing /)
2535 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2537 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * vtkGdcmReader is now able to read rgb dicom file.
2539 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2540 * added a gdcmViewer to vtk test, use mouse to control
2541 window level & window width
2543 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2544 * CMake-ification of gdcm, we have now two build system
2545 * FIX: on cygwin Wsock32 doesn't exist
2546 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2548 2003-10-06 Emanuel Ollart
2549 * FIX : compilation process wad broken.
2550 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2552 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2553 * change gdcmViewer -> vtkgdcmViewer
2554 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2556 2003-10-06 Jean-Pierre Roux
2557 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2558 ( e.g : well known GE images with a wrong elem length,
2559 : Philips MRI Images with a wrong Huffman table)
2560 * still to be done : allow the reading of bugged LEONARDO Siemens images
2562 2003-10-03 Jean-Pierre Roux
2563 * Odd length strings are padded with '\0' (not with spaces,
2564 to remain compliant with already defined strings,
2565 like Transfert Syntax UID and others)
2567 2003-10-03 Jean-Pierre Roux
2568 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2569 to allow displaying RGB images (not only by affim ;-)
2571 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2572 * vtkGdcmReader is now able to read rgb dicom file.
2573 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2575 2003-10-03 Jean-Pierre Roux
2576 * A few nasty patches to allow the reading of a lot of nasty images
2577 ( e.g : well known GE images with a wrong elem length,
2578 : Philips MRI Images with a wrong Huffman table)
2579 * still to be done : allow the reading of bugged LEONARDO Siemens images
2581 2003-10-03 Jean-Pierre Roux
2582 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2584 2003-10-03 Jean-Pierre Roux
2585 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2586 to allow displaying RGB images (not only by affim ;-)
2588 2003-10-03 Jean-Pierre Roux
2589 * gdcmFile::GetImageDataIntoVector now
2590 - deals with MultiFrames MultiFragments Run Length Encoded files
2591 - deals with YcBcR (YBR_FULL) files
2592 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2593 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2595 (no sample found :-(
2597 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2598 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2599 Two reasons: - clear things
2600 - third parties acces gdcm through header files, so won't
2601 suffer anymore VC++ complains
2603 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2604 * add argv[1] in testvtkGdcmReader.cxx
2607 2003-09-24 Jean-Pierre Roux
2608 * The lines are now eigthy characters long.for
2609 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2611 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2612 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2613 char* to std::string. Thus, the use of strdup becomes useless. (see
2614 previous commis of Malaterre)
2615 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2616 before the last Malaterre's commit.
2618 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2619 * This commit should fix the Debug building under VC++, the problem
2620 was mainly a mixture of debug and release lib being loaded at startup.
2621 * I also remove a depency to a specific C function: strdup. Because I had
2622 to force the link to msvcrtd (whereas strdup is in libc).
2624 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2625 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2626 located in the gdcmCommon.h file. All use of reference of tha has been
2627 changed to now use the variable GDCM_UNFOUND.
2629 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2631 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2632 Dicom dictionary. The test suite can now be run again. Note:
2633 I'm note very happy with the " (RET)" changes. I believe this
2634 RETAINED comment should be dropped when parsing the dictionary.
2635 - PACKAGER corrected
2637 - AUTHORS updated and now in alphabetical order
2638 * Makefile.am now exports gdcm.dsw for Windoze users.
2640 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2641 * cygwin complains about missing std:: in subdir Test/
2643 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2644 * remove some methods that are now in gdcmHeaderHelper
2646 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2647 * vtkGdcmReader set spacing and origin correctly
2649 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2650 * Fix a few delete/delete[] mismatch
2652 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2653 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2654 interpretation to data given by gdcmHeader. For instance there are
2655 heuristics to get informations (look at different places).
2656 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2657 sorting DICOM images based on different strategies.
2658 * modified Makefiles accordingly.
2660 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2662 when building in debug mode
2663 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2664 src/win32/gdcmdll.dsp
2665 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2667 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2668 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2671 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2672 * src/win32/libgdcmjpeg12.dsp was not dos format
2673 * src/win32/libgdcmjpeg12.dsp :
2674 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2675 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2677 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2678 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2680 * src/gdcmFile.cxx : bug fix in affectation type
2681 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2682 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2683 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2684 symbols... future problem ?
2686 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2687 * src/win32/libgdcmijpeg12.dsp was missing
2688 * modified gdcm.dsw accordingly
2690 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2691 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2693 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2694 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2695 commit of JPR (before his hollidays to facilitate our work).
2696 * setup.py : bug fix in code. Modifications made while the last commit
2697 of JPR. The code hasn't been tested before the commit... it's so
2698 useless to make that (for best programmer that is JPR) !!!
2700 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * tagged the current version as Version0_3 (i.e. version 0.3)
2703 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2704 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2705 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2706 * *.dsp : modifications to use new libgdcmijpeg8 library
2707 * setup.py : bug fix on VTKPATH variable
2708 * PACKAGER : adding all concerning windows
2710 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2713 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2714 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2715 test suite reported error.
2716 * PACKAGER file added (describes what a packager must do when
2717 packaging a new release).
2718 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2719 * configure.in: upgraded version number to 0.3.0
2720 * fixing build of rpm (through rpm -ta):
2721 - Doc/Makefile.am exports proper doxygen files
2722 - src/jpeg/libijg8/Makefile.am exports the include files.
2724 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2726 * src/gdcmHeader.h : formatting code
2728 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2730 We were obtaining error message from vtk. Now, creation of file list
2731 is made in an internal list to prevent this problem.
2732 Bug fix when output is empty.
2733 Bug fix in update of progress value. Previous commit for this was a bad
2735 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2737 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * src/gdcmHeader.h : added method to get the file name
2739 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2740 files. Added method to remove all files on the input
2741 Added FIXME comment concerning the bad parsing of header made by
2742 ExecuteInformation method (in ExecuteData method)
2744 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2746 when using make instal.
2747 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2748 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2750 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * setup.py : adding include dir of jpeg lib to compile all sources
2752 * */Win32/*.dsp : JPR fix for windows compilation
2754 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2757 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2758 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2760 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * setup.py is again effective on un*x (takes into account the
2762 addon of the jpeg library)
2763 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2764 * Doc/Doxy* updated (includes above enhancements)
2765 * INSTALL now points to web documentation
2767 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcmHeader.h doesn't make unnecessary reference to
2770 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2772 * src/gdcm*.[cxx|h] :
2773 - to allow compilation with gcc 3.x
2774 -- clean up of STL usage (added explicit usage of std::)
2775 -- small fixes on exceptions.
2776 Note: linking not tested !
2777 - clean of doxygen comments to avoid warnings at documentation
2779 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2780 dependent convertion).
2782 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * Clean up of previous JPR garbage commit (not even commented in the
2785 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2786 - moved all jpeg related files from src to src/jpeg/libijg8, with
2787 addition/modification of Makefile.am and configure.in.
2788 - the testSuite is still brain damage (not guilty).
2790 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2791 * WrapVTK.py : modifications to get correctly vtk source files to
2793 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2794 (FileName -> Filename)
2796 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * vtk/vtkGdcmReader.[cxx/h]:
2798 - UpdateProgress method should now be effective
2799 - removed the limitation on having only images loaded (as opposed
2801 - when building a stack of images/volume, a lesser number of
2802 gdcmHeader and gdcmFile instances should be used (hopefully
2803 accelerating things).
2804 - when building a stack of images/volumes, files which are not
2805 loadable (wrong path-filename, wrong permissions on existing file,
2806 or file not parsable by gdcm) are replaced with a black image
2807 in the stack (for the caller to notice the problem).
2809 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2812 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2813 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2814 between standard library (std) and vtk library (problems are found
2815 under Windows... thanks Windows !)
2817 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2820 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2822 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2825 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * When compiling with distutils (see setup.py) the C++ compiler is
2827 called with different flags than the default ones (with automake).
2828 In order to fix all those warning, I compiled gdcm with the command
2829 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2830 and went for warning fixes:
2831 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2832 up from unused variables.
2833 - vtk/vtkGdcmReader.cxx: potential bug fix.
2834 * src/gdcmHeader.h: Doxygen warning cleanup
2836 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * gdcmPython/gdcm.i:
2838 - typemaps correction to take into account the systematic replacement
2839 of "using namespace std" with std:: prefix e.g. std::list,
2840 std::string... (cf changes of 2003-05-21).
2841 - gdcmGlob global variable of type gdcmGlobal (defined in
2842 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2843 exported to Python a as cvar.
2844 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2845 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2846 gdcmDictSet.GetPubDictTagNames() and
2847 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2848 C++ static methods).
2849 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2850 with the above changes.
2852 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2853 * setup.py, manifest.in : bug fix under linux
2855 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2856 * Modification of setup.py to compile vtk part too. Then, we have 2
2857 wrappers which must work with same distutils. For that, we have a
2858 generic distutils in distusiltsWrapping.py ; with :
2859 - build_extWrap class to wrap generically all extensions,
2860 - ExtensionWrap base class for all wrapping extension that contains
2862 - Wrapper interface which wrap sources
2863 + In WrapSwig.py we have extension and wrapper for Swig
2864 + In WrapVTK.py we have extension and wrapper for VTK
2865 * MANIFEST.in : modifications to consider vtk directory and new python
2866 files for compilation
2868 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2869 * Added python wrappers of vtkGdcmReader vtk class (see the
2870 source in vtk/vtkGdcmReader.cxx) :
2871 - vtk/Makefile.am now builds a library
2872 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2873 python library (as opposed to _gdcm.so wich are the python
2874 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2875 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2877 - configure.in has an additional flag --enable-vtk that needs
2878 to be set to enable compilation of vtk related code, that is:
2879 + vtk/vtkGdcmReader.so and
2880 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2881 + gdcmPython/vtkgdcmPython.so (see above)
2882 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2883 be read when compressed or when HighBit + 1 != BitsStored),
2884 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2885 the usage of the python wrapper of vtkGdcmReader vtk class.
2886 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2887 * src/*.[h] all occurences of stl classes are now prefixed with
2888 std::, and all occurences of "using namespace std;" where removed.
2889 This is to avoid pollution of global namespace in included files.
2890 Apparently vtk does not avoid this pitfall: when using both
2891 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2892 collision of various stl members (principally cout...).
2893 * gdcmPython/testSuite.py now cleanly removes temprory generated
2895 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2896 comply with above changes)
2898 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2899 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2900 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2901 vtk data structure (an image Flip was required).
2902 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2903 * cosmetic changes in documentation.
2905 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2906 * src/gdcmHeader.cxx: the constructor no longer exits when an
2907 unexisting file is given as argument.
2908 * The subdirectory Data (containing all the images used for the
2909 test suite) is not part of this repository anymore. A new module
2910 containing those images is now available at
2911 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2912 with the name gdcmData.
2913 All the python scripts (including the package initialisation file
2914 gdcmPython/__init__.py) were adapated to take this change into
2915 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2917 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2918 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2919 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2920 demo of the usage of this class.
2921 Compilation of this vtk part is only done when using the --enable-vtk
2922 at configure (or autogen.sh) stage.
2924 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2925 * More memory link related corrections and documentation fixes.
2927 - maximum info is obtained with a command of the form:
2928 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2929 --show-reachable=yes PrintHeader
2930 - the remaining reachable blocks seem to come from the STL
2931 allocation scheme through the usage of map and list. It looks
2932 like this memory cannot be freed but it is not a memory leak
2933 (in fact further invocation to the STL would recollect the
2934 unused memory allthough it cannot explicitely be freed).
2935 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2936 of displaying an image parsed with gdcm and displayed with VTK.
2937 Note: some images don't seem to work e.g.
2938 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2939 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2940 Allthough this weakens the semantics, it is a ditch attempt to
2941 make gdcm more thread friendly.
2943 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2944 * Memory link hunt (by using valgrind through the command
2945 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2946 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2947 gdcmHeader::_dicom_vr.
2948 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2949 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2951 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2953 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2954 * src/Makefile.am now exports all the necessary include files at
2958 * UpdateGroupLength replaced by new one
2961 * UpdateGroupLength re-written using H-Table
2962 (named UpdateGroupLengthNew untill checks are over)
2964 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2965 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2966 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2968 - gdcmHeader::GetPubElValSet removed.
2969 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2970 UpdateGroupLength, WriteElements, Write.
2971 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2972 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2973 carried the same semantics.
2974 - src/gdcmHeaderIdo.cxx changed accordingly.
2975 - gdcmFile::WriteBase now regroups all the codes from previous
2976 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2977 - enum FileType moved to gdcmCommon.h
2978 * src/gdcmHeader.cxx AddDefault trashed
2979 * gdcmGetXSize added
2980 * getimageDataSize now calls gdcmGetXSize
2981 * Test/*.cxx changed to agree with above changes
2983 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2985 (to avoid double call by end user).
2986 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2987 by end user, since gdcmHeader::gdcmHeader now handles it.
2989 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2990 * gdcm/Doc many doxygen changes:
2991 - Doxyfile now has two different versions, DoxyfileUsers that generates
2992 the html.users end users oriented documentation and
2993 DoxyfileDeveloppers that generates the html.developper developper
2994 oriented documentation.
2995 - README changed accordingly
2996 - requirement.txt removed (old design info moved to TODO).
2997 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2998 DoxyMainPage.txt, DoxyPython.txt provide more information.
2999 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3000 be updated by simply regenerating the docs with doxygen and copying
3001 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3002 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3003 all the tests in the form "if (<map>.count() >1)" were removed.
3004 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3005 ill-formed documentation sections.
3006 * src/gdcmHeader.cxx: ditto
3008 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * setup.py fixed for un*x (needed macro for stdint.h)
3010 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3011 un*ces with sh-utils test utility.
3012 * gdcmPython/demo/test.py renamed to PrintHeader.py
3013 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3014 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3015 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3016 * src/gdcm*.cxx JPR's bad inclusion fixed.
3018 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3020 * gdcmPython/demo/test.py changed accordingly.
3022 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * gdcmPython/Makefile.am fixed linking against libstdc++
3024 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3025 * Swig subdir (historical tests of swig version 1.3.17++) removed
3026 * Test/testChangeEntete.cxx some lines commented out in order to make
3028 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3029 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3031 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3033 hence the user doesn't need this explicit call.
3034 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3035 i.e. LoadElements() call removed.
3036 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3037 - src/Makefile.am declares the proper flag for g++.
3038 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3039 for adding user defined new tags.
3040 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3041 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3042 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3044 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3045 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3046 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3047 src/Makefile.am : the project should properly compile and install
3048 with the autotools, included the python wrappers part.
3049 * gdcm.spec.in : added a spec file for RPM packaging.
3051 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3052 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3054 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3056 to exported to the environement (see gdcmPython/testSuite.py
3058 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3059 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3060 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3061 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3062 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3064 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * gdcmPython/__init__.py doesn't crash anymore when running in
3066 in InstallMode or PreInstallMode but with an environment given
3067 value of GDCM_DICT_PATH.
3068 * src/gdcmDictSet.[cxx/h] coding style.
3070 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3071 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3072 * src/gdcm.h general comments moved to TODO, and README
3073 * src/gdcm.h should now be seen as a user commodity (including it
3074 should suffice to fully use gdcm). It is nowhere including within
3075 any of the kernel files src/*.cxx and src/*.h.
3077 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3079 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3081 * src/gdcm*.cxx only include their corresponding include file
3082 (as opposed to gdcm.h)
3083 * gdcmPython/gdcm.i changed accordingly
3084 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3085 the autogen.sh generated "make snapshot" command to work.
3086 * autogen.sh removed history related references to crea package.
3088 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * distutilsSwigCPlusPlus.py work around some swig portability
3092 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3094 was done in a last ditch attempt to get setup.py _really_
3095 operationnal. The python/gdcmPython layaout add the advantage
3096 of hidding away the python related distutils specific files
3097 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3098 Alas, the src directory was out of scope (i.e. it's relative
3099 position to setup.py was ../src) which made things impossible to
3100 handle (see previous version of python/setup.py). Crossing fingers...
3102 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * python/setup.py now works on Un*x. (harder than I thougth)
3104 * python/distutilsSwigCPlusPlus.py can now have include files
3105 among the list of sources.
3107 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3108 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3109 * modifications in MSVC projects
3111 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3112 * As stated by the first lines of Test/ExceptionAndPython/README, it
3113 looks like we can move back to original usage of exception within
3114 src/gdcm* and hence remove the errno stuff that was introduced
3115 as a quick and dirty fixture of this problem (added to the TODO).
3116 * Doc/Doxyfile configuration file for Doxygen and corresponding
3117 README file for usage added.
3118 * Test/testWrite.cxx added. This new test comes from a split of
3119 test.cxx that is now reverted to its original purpous i.e.
3120 testing the proper parsing of a Dicom related file.
3121 testWrite.cxx concentrates on testing the IO part of gdcm.
3122 * Test/bug1.cxx (containing a bug on WIn32) added.
3123 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3124 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3125 whose purpose is to publish the content of the TagNames of the
3126 Dicom public dictionary were not accessible without an
3127 instance of class gdcmHeader.
3128 - those methods are now static methods of gdcmDictSet and hence
3129 require no instances at all to be invocated.
3130 - within gdcmDictSet this change required to change some method
3131 to class methods (i.e. are now static) among which SetDictPath
3132 (renamed to BuildDictPath) and LoadDefaultPubDict.
3133 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3134 the above changes by calling the new method classes of gdcmDictSet.
3135 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3136 the above to be effective.
3137 * python/gdcmPython: in order to wrap properly the above changes
3138 for Python, swig version now needs to be > 1.3.17.
3139 * python/gdcmPython/Makefile fixed to adapt itself to new
3140 configure/make shema introduced by Johan Montagnat (thanks for the
3141 contribution). Alas this Makefile cannot be turned into a proper
3142 Makefile.am without some heavy changes in the configure.in
3143 (for python dectection).
3144 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3145 now avoids publishing the empty entries.
3147 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3148 * python/setup.py : bug fix concerning install under windows
3149 ExtraPath reused :-P
3150 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3152 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3153 * Dicts/dicomV3.dic : remove double spaces !!!
3154 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3155 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3158 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3159 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3160 method. Doxygenation.
3161 * src/gdcm.h clean up of JPR spurious comments.
3163 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * python/distutilsSwigCPlusPlus.py now properly collects the
3165 shadow classes generated by "swig -c++" (gdcm.py in our case)
3166 when using "python setup.py install".
3167 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3168 reexports the working classes.
3169 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3170 by the classical C errno scheme. This is to prevent an obscure
3171 behavior of the python wrappers when importing wxPython.wx prior
3172 to gdcmPython (which ended up in an abort call). An illustration
3173 of this oddity can be found in the Test/ExceptionAndPython
3174 subdir (see the README file). This problem probably due to
3175 an combination of g++ and dynamic loading.
3176 * added Test/ExceptionAndPython (see above)
3178 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3179 * Changed the layout of the python part to avoid bloating main
3180 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3181 i.e. the distutils arsenal. All the python related stuff is
3182 again in a python subdir, but the package itself is now in
3184 * setup.py was cleaned up:
3185 - pythonIncludePath removed
3186 - python setup.py bdist target is now functional.
3187 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3188 collision with other packages). gdcmPython/demo/*.py changed
3191 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3192 * python subdir moved to gdcmPython (preparation of distutils packaging).
3193 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3194 distutils installer is operational.
3195 * - gdcmPython/__init__.py now properly loads the swig generated
3196 shadow classes (from gdcm.py).
3197 - gdcmPython/demo/*.py changed to import the package gdcmPython
3198 instead of gdcmPython/demo/load.py.
3199 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3201 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3202 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3203 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3204 entries within the associated public Dicom dictionary resp. the same
3205 information but sorted by the fourth field (PAT, IMG, DIR) of the
3207 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3208 are now in the "???" group.
3209 - python/gdcm.i changed accordingly,
3210 - python/demo/printGroupedPublicDict.py added, that gives an example
3211 of the above new functionalities in Python.
3213 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3214 * src/gdcm.h, gdcmHeader.cxx:
3215 - historic references to glib's g_malloc and g_free (#defined)
3216 were definitively removed.
3217 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3218 * src/gdcmElValSet.cxx:
3219 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3220 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3221 - GetElValue(string) renamed to GetElValueByName.
3222 - Added GetElementByName(string).
3223 * src/gdcmHeader.cxx: added
3224 - GetPubElValRepByNumber(guint16, guint16)
3225 - GetPubElValRepByName(string)
3226 - GetShaElValRepByNumber(guint16, guint16)
3227 - GetShaElValRepByName(string)
3228 - GetShaElValByNumber(guint16, guint16)
3229 - GetShaElValRepByName(string)
3230 - GetElValRepByNumber(guint16, guint16)
3231 - GetElValRepByName(string)
3232 - GetElValByNumber(guint16, guint16)
3233 - GetElValRepByName(string)
3234 * Doc/requirements.txt added.
3236 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3237 * Test/Makefile building now depends on the one of libgdcm.so
3238 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3239 pixel data) aware which enables finding the address (offset) of
3240 the pixel data of JPEG encoded DICOM files. This leaves only a single
3241 file in the testSuite whose pixel data address (offset) is unknown.
3242 * python/testSuite.py changed accordingly.
3244 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3245 * VC++ has some strong limitations when working with the STL, as stated
3246 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3247 "Also note that some STL containers (map, set, queue, list, deque)
3248 cannot be exported. [...]
3249 Some STL classes contain nested classes. These classes can not
3251 This is caused by a designed limitation that once a template
3252 class is instantiated, it can not be re-instantiated and
3254 Since our usage of map<> is ubiquitous in gdcm, this "designed
3255 limitation" of VC++ is a pitfall.
3256 Hence the Python wrappers of gdcm cannot be incrementally linked
3257 against the c++ dynamic library. The dirty but only workaround is
3258 to forget about incremental link of dynamic libraries and to generate
3259 the Python wrappers library with the inclusions of the underlying C++
3261 The following modifications concern this matter on Win32/VC++:
3262 - wrapping python correct with standalone wrapped dll (don't use separate
3263 dll under windows !!!!)
3264 - python21_d debug mode enabled (ask Frog how to use it :-)
3265 - NO problem with having an STL member of class for example string in C++
3266 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3267 - Python test of dcmlib in Python is ok under windows on a large set
3269 * removed glib references
3270 * typedef's inserted in gdcm.i for correct swig type management
3272 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3273 * python/demo/*.py load.py extracted from test.py. Added explore.py
3274 that only displays required tags and testAll.py that parses all
3275 the files of the testsuite without using unittest.
3276 * python/testSuite.py other additional test on new files added.
3277 * Data/* new test files added accordingly to the testSuite.
3278 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3279 the vr in the file differs from the one of the dictionary.
3281 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3282 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3283 values, but limits itself to values which are below a user specified
3284 size (by default 1024 bytes).
3285 * python/gdcm.i : elements not loaded (because their size is above the
3286 user specified treshold) are exported with their TagKey as key of the
3287 python dictionary. This enables the testsuite to make some checks
3288 on the unloaded elements (since we have their offset and size).
3289 * python/testSuite.py
3290 - now tests for the existence and proper value of the pixel data
3291 - two new examples added.
3292 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3294 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3295 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3296 aware. See the strategy comments in gdcmHeader::FindLength().
3297 * Test/test.cxx now accepts a filename as first argument.
3298 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3299 * python/testSuite.py changed to integrate test on above files.
3301 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3302 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3303 the vr was also RET.
3304 * python/testSuite.py more tests added.
3306 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * python/testSuite.py unittest test suite added (uses Data)
3308 * Data/* dcm and acr files for the test suite.
3309 * glib dependance removed from un*x version. We now use ISO C99
3310 7.18 Integer types (see stdint.h)
3311 - python/Makefile, src/Makefile src/gdcm.h
3312 * src/ when an explicit vr (like dicom files) suddenly poped an
3313 implicit element we use to mark the underlying DictEntry of the
3314 concerned ElValue with "Implicit". This strategy was damageable
3315 too the public or provite dictionaries, since some of their vr
3316 would be changed. Since Header::FindLength heavily relies on the
3317 detection by Header::FindVR of falsely explicit elements, I
3318 added an extra ImplicitVr member to ElValue (boolean).
3319 The rest of the changes we the necessary adaptations.
3321 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3322 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3324 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3326 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3327 * Adaptation for porting to VC++:
3329 o forced to use std namespace (for string to be known)
3330 o all class use __declspec export style on WIN32
3331 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3332 (in stdlib.h on Win32 but in std:: for gcc)
3333 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3334 variable GDCM_DICT_PATH.
3335 * src/gdcmHeader.cxx verbose comments made discrete.
3337 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3338 * python/gdcm.i: added a typemap that converts a C++ hashing table
3339 to native Python dictionary.
3340 * python/demo/test.py:
3341 - now uses the native dictionary for exploration of gdcmHeader.
3342 - takes an optional filename argument (the file to parse).
3343 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3344 PubElVals hashing table.
3345 * Dicts/dicomV3.dic removed error prone trailing spaces.
3347 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * Python wrapping process moved away from src/Makefile to
3349 newly created python/Makefile (as well as gdcm.i)
3350 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3351 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3352 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3353 from the environement variable GDCM_DICT_PATH (when existing).
3354 * src/gdcmDict::GetTag bug fix.
3356 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3357 * Straightforward temporary fixes for swig to build the python wrappers.
3358 src/Makefile now has a python working entry [by working we mean
3359 that we can import the shadow classes without errors].
3361 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3362 * hashtest.cxx removed (since already in Test)
3363 * src/gdcmlib.h renamed to src/gdcm.h
3364 * src/dcm.i renamed to src/gdcm.i
3365 * src/Makefile prepared for python wrapping
3367 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3368 * src/gdcmHeader.cxx :
3369 - Parsing of header is now separated from loading of element values
3370 (see gdcmHeader::LoadElements).
3371 - general clean up of hopefully all file access (creation of
3372 ReadInt16 and ReadInt32)
3374 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * src/gdcmHeader.cxx :
3376 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3378 - SetLgrElem renamed to SetLength
3379 - GetLgrElem renamed to GetLength
3380 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3381 * src/gdcmElValSet.cxx fixed both GetElValue methods
3382 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3383 due to IdoDude was cleaned out.
3385 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3386 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3387 concentrates on finding the value representation (when it exists).
3388 RecupLgr now only finds the element value length, and it avoids
3389 returning the unecessary skL (skipped length).
3390 Also, offsetCourant was simply removed (with taille_fich) since
3391 it was redundant with the File position internals (by using
3392 ftell and fseek). This also made skL (see above in RecupLgr) usage
3394 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3395 on the libido specificities which are handled through class
3397 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3400 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3401 * Truckload of changes. Parsing of header is barely functional
3402 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3404 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3405 * src/gdcmHeader.cxx many addons of low level methods
3407 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3408 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3409 and _IdDcmSWAP_LONG.
3411 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3412 * This corresponds to all the changes decided at the meeting of
3413 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob