1 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Unfortunately to be able to test gdcmDirList I had to break the API
3 a little. Now the class is not a std::list anymore but has a member
4 std::vector (more ITK compatible). Allow unit testing on Win32 and
7 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Update SerieHeader to take into account a Serie Instance UID to properly
11 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
12 * ENH - Comment out Mathieu's (dangerous) Super Hack
13 for dealing with BIGENDIAN processors
14 - Move equivalent stuff to BinEntry::WriteContent
15 When necessary, 16 Bits Pixels are swapped in a small buffer
16 and then written. This avoid allocating a huge buffer, in
17 PixelWriteConveror, and avoid modifying the Pixel Area.
19 Probabely, the same operation will have to be done when we want
20 to write image with Big Endian Transfert Syntax,
21 and we are working onj Little Endian Processor
23 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
26 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
27 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
29 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
31 * Test/TestDict.cxx : add a new test for the dict classes
33 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
35 file. Debug is yanked if compiled with NDEBUG
37 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmDictSet.h : set the default output to the os variable
39 * src/gdcmDictEntry.[h|cxx] : add the Print method
40 * gdcmPython/demo/ : add a new test
42 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
43 * merging of Test/PrintDicomDir and Test/TestDicomDir
44 * removal of now redundant Test/PrintDicomDir
45 * enhancement of Example/PrintDicomDir
47 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Now, python test might work on systems
49 * Add the PrintDicomDir test
51 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
52 * FIX : First entry following group 0002 was lost for
53 Explicit Big Endian Transfer Syntax files
54 (group and elem not swaped)
56 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
57 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
58 Big Endian Transfer Syntax supposed the group following 0002
59 begins always by element 0000 (element 0000 is *optional*)
60 To avoid further troubles, let's be pessimistic, and use
61 Document::HandleOutOfGroup0002() method
62 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
63 (related pb not yet solved)
65 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * Bug fix for the python part use
67 * Now, PrintHeader.py pass... but outside the ctest use. shit !
69 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
72 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
74 a string and should ask the global TS dict what are the propreties of
77 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
78 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
79 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
80 to swap the Swap Code, at parsing time, when we come out of group 0002
81 and Transfer Syntax is Big Endian
82 We should be able to read now 'true DICOM" Big Endian coded images
83 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
84 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
86 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Hopefully fix the bug on MacOSX and static global initialization.
88 This is the only -minor- patch I found that both please MacOSX and VS6.
89 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
90 but this would require a lot of change. Another approach would be that Global
91 create those string and GDCM_UNFOUND becomes a pointer to a string (which
92 gdcm::Global would destroy at exit).
94 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
95 * Fix bug on MacOSX with static initialization in a multy threaded
96 environment. static const string in a header file used to be ill
97 initialized provoquing the freeze of any tests. patch should solve this
100 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
101 * According to Benoit's suggestion, and without any objection from anybody
102 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
103 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
104 - method gdcmDicomDirObject::GetEntry() renamed as
105 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
107 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
109 you debug/warning message just as c++ streams which make them very convinient
110 to use. Once this is stabilize I will change the ostringstrem to be
111 redirected to a file (ofstream).
112 * Properly support C99 extension: __FUNCTION__ which allow us to display
113 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
115 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * Removal of useless and dangerous methods :
117 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
118 GetDocEntryByName, GetEntryByName, GetDictEntryByName
119 * Removal of usless methods :
120 Dict::PrintByName, Dict::GetDictEntryByName
121 * Commenting out of probabely useless methods :
122 Dict::GetDictEntryNames()
123 Dict::GetDictEntryNamesByCategory()
124 DictSet::GetPubDictEntryNames()
125 DictSet::GetPubDictEntryNamesByCategory()
126 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
127 * ENH : Use dicomTS.dic as described in 2004 version
128 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
129 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
130 Add Accessors on VM (Value Multiplicity), and VM related methods
131 * ADD : Add a list of 'Dicom Attribute types', as found in
132 http://medical.nema.org/dicom/2004/04_15PU.PDF
134 * ADD : Add dicomGroupNameAbbreviations.dic
135 should be used to write a method to replace the former
136 Dict::GetDictEntryNamesByCategory()
138 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
140 to read in the file... and only it ! Length is the efective length of the
141 data in the DocEntry structure
143 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
144 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
145 And now use a static function call instead, with a global variable. i
146 This is much closer to the VTK approach. Hopefully should be bulletproof
147 and easier to use...hopefully
149 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
152 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
155 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
157 ValEntry, BinEntry, SeqEntry creation or replace
159 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
161 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
163 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
164 when specifying the VR
165 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
166 * src/gdcmDocEntry.cxx : amelioration of print
168 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
169 * ADD : Add the method Util::IsCurrentProcessorBigEndian
170 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
171 * ADD Method Document::ComputeGroupLength
172 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
173 in order to allow further VR modification by user
174 * REM : removal of once-called method File::WriteBase
175 integration of its code in formerly one-line method File::Write
177 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
179 replace the different values "??", "Unkn", "Unknown".
180 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
181 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
182 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
183 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
185 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
188 * Set the gdcm::Base class to some Printable classes
190 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmFile.[h|cxx] : add the Print method
192 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
193 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
194 * src/gdcmDocument.h : remove the PrintLevel informations
195 * Example/PrintFile.cxx : use the new gdcm::File::Print
197 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
199 problems when compiling with the python wrapping
201 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
203 writting in ImplicitVR
205 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
206 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
207 JPEG decompression, especially when dicom frames are split into several
208 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
209 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
211 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmHeader.cxx : change the initialisation of default header.
213 Now, this header is readable by gdm, e-film, DicomWorks
215 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
217 Rename Decompressed to Raw
218 * Use the API changes in gdcm::File.
219 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
222 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
224 each added entry in the header. Replace the 'Planes' field by the 'Number
227 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
229 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
231 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
233 At this time, this image isn't readable by e-film... waiting JPR help to
236 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
238 DocEntry. Now use methods of the Document !
240 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * Test/ShowDicomSeq.cxx : bug fix
243 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
245 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
246 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
247 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
249 * Test/TestCopyRescaleDicom.cxx : remove unused variable
250 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
251 containing found sequences
253 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
256 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
257 Some fields in BinEntry must be copied to not seg fault when making the :
258 gdcm::File *copy = new gdcm::File( copyH );
259 and tests are now made on good variables
261 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
263 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
265 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
266 * Add vtkGdcmWriter example and test
268 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * Test/TestUtil.cxx : reformat the source code
270 * vtk/vtkGdcmReader.cxx : remove and change prints
271 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
273 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
274 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
276 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
278 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
280 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
282 by an eof to prevent all bad read of the file... and in this case, the
285 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * Example/Volume2Dicom.cxx : comment unused variables
287 * Test/PrintDicomDir.cxx : comment unused variables
288 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
289 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
290 method that is redondant with AddEntry.
291 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
294 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * Bug fix due my last commit (compilation under Windows).
296 * Example/Volume2Dicom : bug fix in the file and reformatting source code
297 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
299 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
301 - Remove printf / sprintf
302 - include iostream AFTER gdcm so we don't get warnings
303 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
305 - Also remove tons of include from header files, hopefully this should
306 speeup the compilation time, since it was becoming a dog slow.
307 - Remove gdcm.h as it include way too many files and slow down compilation
308 (plus it is not up to date)
309 - remove 'using namespace std' this is BAD !
311 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Remove memory leaks on the DicomDir
313 * Remove some useless data in DicomDirObject
314 * Add usefull methods in SQItem, to be complient withe the ElementSet
316 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
319 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
321 future, with convertion)
322 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
323 and ImageDataSize values. Remove the method to get the PixelReadConverter
324 from the output of the class
326 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
329 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
331 and vtkErrorMacro use.
332 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
334 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
337 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
338 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
339 The string leaves only in the fonction. So when we make a .c_str(), we
340 get the pointeur on the first element, element that will be destroyed
341 immediately after thee instruction.
342 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
343 file has been opened : the test must be made on the content of the
344 pointer and not directly on the pointer !
347 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
349 the python part recompiles
351 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
353 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
354 X session is killed (for my computer... it seems to not be identic on
357 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
359 avoid problems (otherwise, the difference test between the visible image
360 and the reference is incorrect. If the reference is greater than the
361 screen resolution, it's produce errors).
362 Can be used for only one image. Can be used with a visible flag.
363 * vtk/vtkGdcmReader.cxx : remove commented codes.
364 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
365 under windows at compilation
366 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
368 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
370 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
372 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
373 tests on the image size X, Y, Z
375 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
377 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
378 between the class name and the file name
380 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * src/ : fix compilation warnings for the Write method (2 different
382 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
383 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
384 variable... create a static method in gdcm::Document to access to
385 this variable content.
387 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
389 file, to be accessed by other files (like gdcmFile). Remove commented
390 code. Move the change of the header to the gdcmFile, using the
392 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
393 To be sure of that (and simplify calls), the Write of the header now
394 gets a file name and not a file pointer (std::ifstream).
395 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
396 DocEntryArchive. Remove all open of the written file
398 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
401 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
403 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
405 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
406 some corresponding methods. Write correctly the file and check before
408 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
409 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
410 is now on RGB data (as before my last commit
411 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
413 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
415 Add a print information of the type of the entry
416 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
417 It was in the gdcmFile, and all write have been regrouped
418 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
419 Write correctly all dicom files (in decompressed mode only at this time)
420 * Test/ : test on files are now made using Raw data and not color data if
422 * Example/PrintFile.cxx : add more printings
424 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * Amelioration of code, remove some code copy. For the loading of
426 BinEntry (in gdcmDocument), add the test to verify if the file is already
429 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
431 remove a DocEntry in the header (push an empty DocEntry)
432 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
433 lines. Bug fix in the initialization of the PixelConvert and the
435 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
436 use in TestCopyDicom (now this test can run under windows... but fails)
437 * Test/TestCopyDicom.cxx : amelioration of the test :
438 - test the pixels written
439 - add test points to quickly find where is the error
440 - can set a file name input and output in arguments
441 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
442 amelioration of the test output
444 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
446 all replaced DocEntry's
447 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
448 Now, each needed DocEntry to modify is duplicated, modified and inserted
449 to the header using DocEntryArchive. Thus, after save, we can restore the
450 header initial state.
452 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
455 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
457 correct to copy it. The DictEntry is specified at the DocEntry creation,
458 then, it musn't change in the time.
459 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
460 header correctly. At this time, the change is only made for the first
461 level of the Document. In the future, it might consider sequences.
462 The change is made by replacing a DocEntry by an other that is created
463 outside the class. The old value is kept. When we restore the header
464 status, the added DocEntry is deleted and replaced by the old value.
465 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
466 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
467 set the write type to explicit VR, implicit VR or ACR. Add methods to set
468 the write mode to native, decompressed or RGB (but not used at this time)
470 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
472 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
474 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
476 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
478 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
479 set because already copied when copying the BinEntry's of the header
480 * Test/TestAllReadCompareDicom.cxx : remove warnings
482 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
484 Two problems appear when doing it :
485 - with the gdcmFile : when the GetImageData method is called, the pixels
486 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
487 data (pixels). And each structure destruct the data when it's
488 destructed. So we have two destructions for the same data. To solve it,
489 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
490 data or not. If it doesn't own data, then they will not destroyed by
492 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
493 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
494 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
495 create a double destruction of the same DocEntry's. So, to solve it,
496 the TagHT is simply cleared and the DicomDir* elements are destroyed.
497 * TODO : add an entry concerning memory leaks in the DicomDir
499 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
501 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
504 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
506 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
507 after it have been deleted
509 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
510 * FIX: src/* fix the doxygen warnings.
511 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
512 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
513 was erroneously defined with a size of 15 instead of 16. [many thanks
514 to Jean Michel Rouet for pointing out this bug].
516 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 1. Finish merging JMR patch for writting DICOM from scratch
518 2. Fix -hopefully- bug with MONOCHROME and space vs null character
519 3. Use const ref when possible
520 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
521 5. A few more comments
522 6. CreateUniqueUID can now be called without parameter"
524 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * ENH: Slightly bigger patch:
526 1. Getting toward full integration of JMR patch for writting dicom from scratch
527 2. Update Test to test part of this patch: CreateUniqueUID
528 3. File was not close properly in gdcmDict
529 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
530 5. Use of const ref instead of copy (speed issue)
531 6. Remove temporary (duplicate) string in TranslateToKey
532 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
533 8. Do not repeat virtual in subclasses
534 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
536 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
537 * Apply first patch toward better string comparison when dealing with broken
538 DICOM files. Essentially the string could be padded with a space instead
539 of a null character as defined by standard
541 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
543 because never used... and in the same time, that's remove some memory leaks
545 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * src/gdcmFile.cxx : now delete the PixelConvert instance.
547 * In examples and tests : change the type of image data variables from void*
548 to uint8_t*. Remmove all delete on image data variables
550 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
552 Verify the file pointer value before open the file, and if it's not null,
553 a verbose message is generated.
554 Close correctly the file when the file isn't considered dicom-like. The
555 correctly close is a call to CloseFile.
556 When closing the file pointer, test if its not null to close the file.
557 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
558 file. For an uncompressed image, the copied data correspond in the least
559 case to the image size (calculated) or the image size specified in the
560 header. A verbose is generated if these two size mismatch
562 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
564 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
565 break under windows (with msvc6 compilation).
567 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
569 compiling with MSVC6)
571 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * Bugs fix for the Windows build with VC6
573 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
574 needed (only for projects required VTK). If the VTK is included in all
575 projects, there is conflicts with the jpeg lib of vtk when compiling the
576 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
577 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
578 when compiling the gdcm_wrap.cxx file (created by the compilation of the
580 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
581 (like it's already made for the cout use). Otherwise, conflict with the
584 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
587 - comments on the DicomDir::Method related usage added.
588 - now that we use the namespace gdcm, a lot of internal classes do
589 NOT need to be wrapped anymore.
590 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
591 DicomDir::Method) new example added.
593 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
594 * Improve string manipulation. I now inforce the notion of 'DicomString'
595 A DicomString can contain as many \0 as they want
596 and it is *always* of even length.
597 We only support odd length for very rare case.
598 And in the near future this should be removed.
600 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 * /binary_write/ gdcm source. Now even on big endian we are writting
602 little endian. This should -heopfully- fix some tests
604 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * Now the dictionary is compiled into gdcm lib. This is a default
606 behavior, thus any dic file specified is picked before failback to
607 the one comiled into lib
609 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
610 * Change internals for gdcmDict. Don't use any 'new' any more.
611 This should definitely solve any leak problem, and we should be
612 as fast as before, as long as don't modify too much the dictionary.
614 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
615 * STYLE: ivars should start with a capital letter.
616 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
617 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
619 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
621 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
622 new 2004 dictionaries added (thanks to JPR).
623 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
624 * CLEANUP_ROUND (15) for gdcmPixelConvert
625 - RLEFrame::NumberFragments is now of type unsigned int
626 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
627 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
630 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
631 * Initial work in gathering all transfer syntax accessors. clearly
632 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
633 ivars, but only one transfersyntax (class) ivar with equivalent method on
636 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
637 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
638 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
639 discussed (plus I didn't like having a 2000 lines patch not commited)
641 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
642 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
643 * CLEANUP_ROUND (14) for gdcmPixelConvert
644 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
645 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
646 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
648 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
649 anymore and hence avoids storing a copy of PixelConvert::Decompressed
650 into File::Pixel_Data.
652 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
654 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
655 * CLEANUP_ROUND (13) for gdcmPixelConvert
656 Substituted File::ParsePixelData() with PixelConvert::Print() new
658 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
659 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
660 method to those classes.
661 - src/gdcmFile.[cxx|h]:
662 -- Added a ::Print() method.
663 -- PixelConverter is now a reference instead of a member.
664 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
665 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
667 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
669 collaboration diagram and inheritance diagram should be generated with
671 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
672 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
673 pointlessly wrapped (see
674 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
675 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
676 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
677 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
678 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
679 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
680 -- File::Initialise: PixelConverter setup moved away to
681 PixelConverter::GrabInformationsFromHeader()
682 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
683 interpretation moved away to PixelConverter::BuildRGBImage()
685 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
687 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
689 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
691 displayed on Win32 when a brutal abort() occurs (because of uncatched
692 exception). See TODO new entry of this commit for more on this.
693 * TODO added new entry.
694 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
695 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
696 - HandleColor is no longer called from gdcmFile.cxx
697 - gdcmPixelConvert.cxx clean up on method arguments and internal
698 variable names for semantical coherence.
700 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
701 * Finished lossless transition, not only do we now read all lossless jpeg
702 images, without the need of the Cornwell lib, but we do read them properly now
703 * To reduce code (well to avoid code duplication), I defined a common place
704 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
705 redefine symbols. This is not perfect but this the best solution I found for a
706 compilation time jpeg option.
708 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
709 * Update jpeg ijg lib to support lossless jpeg implementation
710 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
712 * Also added a special copyright for dcmtk since we use their bugfixes.
715 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
717 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
718 matters, as stated in warning note at begining of %include section).
719 * src/gdcmDicomDir*.[cxx|h]: coding style
720 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
721 * src/gdcmJpeg8.cxx: doxygen fix.
722 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
723 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
724 from File:: to PixelConvert::.
726 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
727 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
728 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
729 - more code moved away from File:: to PixelConvert::
730 - fat setup of PixelConverter set in place in File::Initialise.
732 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
733 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
734 namespace at the file system level. So now you should convert your examples
736 gdcmHeader -> gdcm::Header
737 It would be nice if people keep in mind to no open the namespace, since it
738 allows compilation on broken plateform which were defining common symbol in
739 the standart namespace (like LP, Unknown ...)
741 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
743 The JPEG fragments are now parsed at the same stage than the RLE
744 information. All code related to JPEG is now in gdcmPixelConvert:
745 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
746 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
747 export a gdcmFile:: method. Those are simply global functions
748 (for the time being this is better than having them attach to
749 either gdcmFile:: or gdcmPixelConvert::).
750 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
751 and stores the result in a gdcmJPEGFragmentsInfo.
752 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
753 code (among other stuff) moved away from gdcmFile:; to
756 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
758 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
759 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
760 clean up of RLE related code.
761 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
762 - src/gdcmRLE.cxx removed
763 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
764 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
765 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
766 * CLEANUP_ROUND (9) for gdcmPixelConvert
767 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
768 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
769 away from gdcmFile:: to gdcmPixelConvert::.
771 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
773 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
774 This is because Parse7Fe0 used to parse the pixels to compute the
775 length. This task was passed over to FindDocEntryLengthOB() a long
776 time ago, EXCEPT I had forgotten the OW case...
777 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
778 we just recylce the code for parsing RLE fragments and computing
780 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
781 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
782 with the retired Parse7Fe0().
783 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
784 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
786 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
788 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
789 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
790 - src/CMakeLists.txt: alphabetic order reodering + new entries.
791 * CLEANUP_ROUND (4) for gdcmPixelConvert
792 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
793 to return an unused length.
795 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
796 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
797 this should be cleanner from the plane view. The iostream are erally a pain
798 to use to do simple stuff.
800 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
801 * Redo the compilation of the ijg jpeg library. Now only one source is
802 necesseray. No need to rename file by hand what so ever. CMake handle the
803 copying of the file within different directory, configure header file to
804 modify some symbol. The only addition made to ijg wasd a mangle table so
805 that symbol are different wether we are within 8bits or 12bits.
807 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * Added documentation of vtkgdcmReader on Website:
809 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
810 with it's binary name).
811 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
812 the Website to be more complete.
813 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
814 doxygenated documentation.
815 - Doc/DoxyVtkGdcmReaderExamples.txt added
816 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
817 DoxyVtkGdmReaderExamples.html )
818 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
819 * CLEANUP_ROUND (3) for gdcmPixelConvert
820 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
822 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * CLEANUP_ROUND (2) for gdcmPixelConvert
824 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
826 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * CLEANUP_ROUND for gdcmPixelConvert:
828 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
829 - src/gdcmPixelStuff[h|cxx] removed
830 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
831 - src/CMakeLists.txt changed accordingly
833 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
834 gdcmVersion.py moved to newly created ATTIC related
835 gdcmPython/SetupOldies/ directory.
836 * Autotools clean up:
837 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
838 - autogen.sh configure.in acinclude.m4 python.m4 removed
840 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * src/*.cxx *.h Reference to License.htm fixed to License.html.
842 * Doc/CMakeLists.txt, doxygen.config.in: fix.
843 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
845 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
846 * TODO updated with Mathieu suggestions. I proposed a template for
847 describing TODO entries and used it for new entries.
848 * Added Doc/Website/CodingStyle.html, Developpers.html,
849 DeveloppersPython.html, GdcmDataCvs.html and
850 DownloadVersion0_1.html, DownloadVersion0_3.html.
851 * Some Doc/*.txt Doxygen files (which do not really concern the
852 documentation itself, but the website) moved to html and
853 placed in directory Doc/Website:
854 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
855 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
856 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
857 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
858 * CMakeLists.txt changed accordingly.
859 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
860 DeveloppersPython.html
861 * INSTALL nows refers to Doc/Website/Installation.html
863 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * Added Doc/Website directory, that contains a first raw version
867 2004-09-23 Jean-Pierre Roux
868 * FIX In order not to be poluted any longer by casting problems,
869 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
870 we can now delete[] it safely
871 * VoidArea is now called BinArea (less confusing name),
872 and all the methods called ...VoidArea... are now ... BinArea...
873 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
875 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
877 clear) TagHT, which is an inherited member of gdcmElementSet. It is
878 up to the destructor of gdcmElementSet to clean up TagHt and it's
881 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * Test/CMakeLists.txt: update to follow gdcmData renamings.
883 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
885 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
886 * ENH: added some utility method that builds a flat dictionnary
887 holding all the Dicom entries contained in the recursive structure
888 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
890 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
891 BuildFlatHashTable() that build a flat dictionary.
892 - src/gdcmElementSet.h: added a new private GetTag() accessor.
893 gdcmDocument is now a friend of gdcmElementSet.
894 - src/gdcmElementSet.cxx: clean up.
895 - Example/FlatHashTablePrint.cxx added.
896 - Example/CmakeLists.txt changed accordingly
898 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
899 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
900 moved away from gdcmDocEntrySet (since this class is an abstract class
901 acting like an interface). SQDepthLevel and BaseTagKey are now
903 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
904 and associated accessors. Doxygenation of the class.
905 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
907 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
908 Use SQDepthLevel accessor instead. ::Print() adapted.
909 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
910 - src/gdcmDocument.cxx changed accordingly.
912 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
914 - The following is the doxygen comment of the typedef declaration
915 of gdcmTagKey in src/gdcmCommon.h:
916 gdcmTagKey is made to old an "universal" (as in URL, Universal
917 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
918 A dicom tag always has a group and an element, but a set of tags
919 embeded in various (optionally nested) sequences and sharing
920 the same group and element all share the same (group, element)
921 "identifier". Hence the (group, element) cannot be used as an
922 identifier (in gdcm we shall refer to a "TagKey") of a tag.
923 In order to construct a proper tag identifier (i.e. a key) we
924 consider the following definition of a TagKey:
925 - let Group, Element be the string representation of the
926 group and element dicom tag members,
927 - let ItemNumber be the string representation of the integer
928 index of the considered item number of a sequence,
929 Let the key of a tag embeded in a sequence, noted SeqTag, be
931 /ItemNumber#Group|Element
932 where "/", "#" and "|" are characters acting as separators.
933 Then the general form of a gdcmTagKey is given by:
934 Group|Element<SeqTag>
935 where <SeqTag> means NO or many instances of SeqTag.
936 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
939 but the gdcmTagKey of a tag "embeded" is the first item of
940 a sequence, itself nested in the third item of a sequence is the
942 0004|1220/2#0008|0082/0#0008|0090
943 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
944 order to hold the new sequence compatible key. Previously, the
945 GetKey() method would look in the underlying gdcmDictEntry.
946 - src/gdcmDocEntry.cxx:
947 -- constructor now copies the underlying DictEntry key, in the local
949 -- ::Print: displays the member Key, instead of the (group, element).
950 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
951 - src/gdcmDocEntrySet.h:xi
952 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
953 -- now has a new BaseTagKey member.
955 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
956 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
958 This poses the problem with the semantics of the following lines
959 LoadEntryVoidArea(0x0028,0x1201); // R LUT
960 LoadEntryVoidArea(0x0028,0x1202); // G LUT
961 LoadEntryVoidArea(0x0028,0x1203); // B LUT
962 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
963 to the long FIXME note for what the problem is. Nevertheless in
964 order to get things working the dicom dictionary was altered !
965 Please fix things urgently...
966 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
967 information), see above note on moving the member VoidArea. Nevertheless
968 the following entries previously correctly set as US are now inproperly
970 0028 1201 OW IMG Red Palette Color Lookup Table Data
971 0028 1202 OW IMG Green Palette Color Lookup Table Data
972 0028 1203 OW IMG Blue Palette Color Lookup Table Data
973 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
974 of gdcmDocEntry moved to gdcmSeqEntry.
975 * src/gdcmSeqEntry.cxx: STYLE.
977 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * Test/TestAllEntryVerify.cxx minor fix and added comments.
980 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * gdcmPython/testSuite.py: all the test suite in python is now moved
982 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
983 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
984 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
986 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
988 to avoid inclusion recursion until STL is reached.
989 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
990 mecanism. errno.h is not included in gdcm anymore.
991 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
992 (gdcmFormatError now inherits from gdcmFormatUnexpected).
994 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
995 gdcmData/TestAllEntryVerifyReference.txt
996 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
997 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
998 exception_on_error parameter.
999 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1000 - vtk/vtkGdcmReader.cxx changed accordingly,
1001 - Example/*.cxx and Test/*.cxx changed accordingly.
1003 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1005 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1006 enable_sequences removed from gdcmHeader constructor and dependencies.
1007 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1008 * gdcmPython/demo/PrintHeader.py: dummy fix.
1009 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1010 skip_shadow removed from gdcmHeader constructor and dependencies.
1011 * Example/*.cxx and Test/*.cxx changed accordingly.
1013 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1015 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1017 2004-07-21 Jean-Pierre Roux
1018 * FIX Now, Parsing and Printing a DICOMDIR do work!
1019 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1021 2004-07-20 Jean-Pierre Roux
1022 * FIX Some brain damaged headers have Zero-Lenght fields
1023 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1025 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1026 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1027 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1028 variable (instance of gdcmDebug) by a definition macro, and the instance
1029 is now in static in the gdcmDebug class
1030 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1031 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1033 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1034 * WARNING: ctest now depends more tightly on gdcmData. You should
1035 check out gdcmData properly for things to run smoothly...
1036 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1037 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1038 we need the pixels not be loaded in order to use the ValEntry
1039 that displays position and size).
1040 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1041 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1042 be deprecated. If you have any doubts about the advantages of a
1043 modern scripting language (read Python) versus grass root C++ (i.e.
1044 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1045 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1046 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1047 Anyhow, consider documenting the gdcmData images in
1048 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1050 * Test/CMakeLists.txt:
1051 - now uses TestAllEntryVerify.cxx
1052 - specific comments on oldACR00001.ima (now renamed in gdcmData
1053 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1054 gdcmData/TestAllEntryVerifyReference.txt
1057 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * src/*.[h|cxx] : typedef clean up
1059 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1060 - TagKey renamed to gdcmTagKey (for external usage)
1061 - VRKey renamed to gdcmVRKey (for external usage)
1062 - removal of typedef duplication.
1063 - Removed all unecessary inline keyword from class inline definitions.
1064 - Some method|function(void) declarations replaced with method|function().
1065 * src/jpeg/libijg12/jdhuff12.c:
1066 - printf polluting ctest removed.
1067 - TAB removal for comminting
1069 - TestAllReadCompareDicom.cxx: added a test that compares all the
1070 images in gdcmDataImages.h with corresponding images in
1071 gdcmData/BaselineDicom/. When baseline images are not present
1072 this test creates them.
1073 Note: we need to validate each reference image, but before that
1074 I'd like to rename them with a more explicit name...
1075 - CMakeLists.txt: changed accordingly.
1076 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1077 including each header needed).
1079 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1081 test suite to the Example directory. Are concerned:
1086 - TestWriteSimple.cxx
1087 * Test/CMakeLists.txt: added some comments on reasons for black listing
1088 image gdcmData/oldACR00001.ima
1090 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * Test/CmakeList.txt: removed the following from black list (to be coherent
1092 with removal from gdcmData):
1093 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1094 - gdcm-MR-PHILIPS-16.dcm
1096 Added the following because after last cvs update, they cause
1097 ctest -R TestReadWriteReadCompare
1099 - gdcm-MR-SIEMENS-16-1.acr
1101 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1102 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1103 new comments in this file) we temporarily (sigh) move to a weaker
1105 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1106 we don't need to black list the following images anymore:
1107 - 8BitsUncompressedColor.dcm
1109 - US-PAL-8-10x-echo.dcm
1110 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1111 fixes and the beautified code ;-)
1112 This fixes the bug introduced in version 1.42 (when beautifying)
1113 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1114 Note: ctest was blind to this bug (this means we need to still
1115 improve the test suite). The bug could be detected by using
1116 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1118 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1119 and by displaying the (garbage) produced file temp.XDCM...
1121 2004-06-29 Jean-Pierre Roux
1122 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1123 - replace by uggly but working old code :-(
1124 A lot of things should be OK again.
1125 It's really urgent to have a test suite that *tests*,
1126 to prevent Frog's beautifying sessions to break all the stuff
1127 (twice, withing a fortnigh ...)
1129 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1131 redundancy) to added Test/TestReadWriteReadCompare.cxx
1132 * Test/CmakeList.txt: because the compare test of
1133 Test/TestReadWriteReadCompare.cxx fails, the following images are
1134 black listed: - 8BitsUncompressedColor.dcm
1136 - US-PAL-8-10x-echo.dcm
1137 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1138 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1139 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1140 and ad-hoc kludge. This kludge is now removed, and on encountering
1141 such an image (OB field brain damaged) we set errno. Then in
1142 ::FindDocLength() we "fix" the length as being ALL what remains
1143 in the file (until EOF). We then proceed, hoping for the best...
1144 This fixes a SegFault in ShowDicom when trying to write such an
1146 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1147 (because TestWriteRead breaks on it, after a non conformal commit?).
1148 ctest now runs properly, except for MakeDicomDir (which was always
1149 broken) and the Python related stuff (still not fixed).
1151 2004-06-24 Jean-Pierre Roux
1152 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1153 FIX : Test/TestReadWrite now iterates on all the file names
1154 (instead of infinite loop)
1155 ENH : Test/TestWriteRead now iterates on all the file names
1157 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1160 2004-06-24 Jean-Pierre Roux
1161 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1162 when SamplesPerPixel =3
1163 - now Write is no longer confused by
1164 'BitsAllocated = 12" and 'BitsStored=12"
1165 - "UN" value representation Elements are now written correctly
1166 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1167 ENH : - now gdcmHeader has its own Write methods
1168 (in order to split the job that has not to be done
1171 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1173 loop on the same image until memory went out.
1174 Note: this means we still have gobs of memory loss in PrintDocument
1175 * src/gdcmDocument.cxx: fixes problem on parsing on file
1176 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1178 2004-06-24 Jean-Pierre Roux
1179 FIX : Write - All the Sequences and Sequence Item are now written
1180 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1181 is added a the end, when necessary.
1182 - A lot of brain-damaged images, that were read correctly are
1183 now written correctly
1184 - length compatible BinEntry are now loaded correctly
1185 (even for odd groups)
1186 Note : only Explicit Value Representation was checked.
1187 (question : is implicit VR really necessary for gdcm ?)
1189 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * DEVELOPPER: added a proposition of coding style.
1191 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1194 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1195 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1196 Use the gdcmDocEntry::Print() and Write() instead.
1197 * src/gdcmDocument.cxx: bug fix.
1199 2004-06-22 Jean-Pierre Roux
1200 FIX : gdcmDocument.cxx
1201 - Now we do recognize the JpegLossLess format (there was a misstyping in
1202 code 'beautyfication' :-(
1203 - Now we automaticaticaly load the Luts, if any
1205 2004-06-22 Jean-Pierre Roux
1206 In order : to write Sequences, whatever their imbrication level,
1207 : to allow user to create his own Sequences
1208 a lot of modif where necessary (adding, moving, or virtualising methods)
1210 WARNING : save your own sources *before* cvs up !
1213 ADD virtual void Write(FILE *fp, FileType filetype);
1216 ADD virtual void Write(FILE *fp, FileType filetype);
1217 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1220 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1221 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1222 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1223 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1224 ADD std::string GetEntryByName(TagName name);
1225 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1227 std::string vr = "unkn",
1228 std::string fourth = "unkn",
1229 std::string name = "unkn");
1230 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1231 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1232 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1233 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1234 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1235 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1236 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1237 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1240 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1241 ADD virtual std::string GetEntryByName (TagName tagName);
1242 ADD virtual std::string GetEntryVRByName (TagName tagName);
1243 REM virtual bool Write(FILE *, FileType);
1244 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1245 FILE *_fp, FileType type);
1246 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1247 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1248 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1249 REM virtual std::string GetEntryByName (std::string tagName);
1250 REM virtual std::string GetEntryVRByName (std::string tagName);
1251 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1252 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1253 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1255 std::string vr = "unkn",
1256 std::string fourth = "unkn",
1257 std::string name = "unkn");
1258 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1259 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1260 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1261 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1264 ADD virtual void Write(FILE *fp, FileType filetype);
1267 ADD virtual void Write(FILE *fp,FileType filetype);
1270 ADD virtual void Write(FILE *fp, FileType filetype);
1271 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1272 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1273 REM std::string GetEntryByName(TagName name);
1276 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1278 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1280 The default constructor invoked by the line
1281 gdcmHeader *f1 = new gdcmHeader( header );
1282 was gdcmHeader::gdcmHeader(bool) instead of the expected
1283 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1284 Hence the parsing wasn't executed... See also below.
1285 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1286 as explicit constructor didn't do the trick to fix the above problem.
1287 Could anyone explain why ?
1288 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1289 properly calls gdcmValEntry::Print() (that was weed out from
1290 code related to gdcmBinEntry).
1292 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * In order to fix memory leaks:
1294 - Test/TestWriteSimple.cxx: added cleaning of free store through
1296 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1297 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1298 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1299 (through the call to ::AddDicomDirMeta()) or the destructor
1300 would crash when deleting uninitialized ::metaElems].
1301 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1302 - src/gdcmDocument.cxx:
1303 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1304 from dynamic stores.
1305 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1306 was causing memory leaks.
1307 - src/gdcmSQItem.cxx:
1308 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1309 cleanly handled with polymophism: sorry but my milage is low).
1310 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1311 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1312 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1313 This avoids SegFaulting.
1314 - src/gdcmSQItem.h: coding style.
1316 - Test/TestWriteSimple still severely sucks. The output image content
1317 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1318 damaged when displayed with vtkgdcmViewer.
1319 - on memory leaks: TestWriteSimple leaks really less (see entry
1320 of 2004-06-18 in Changelog file for the call to valgrind).
1321 - on segfaults: ctest now passes all the tests but one (no more
1323 * Erroneous leading white fix:
1324 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1325 white[s] (as opposed to from >> xxx, that removes it [them].
1326 - src/gdcmTS.cxx: ditto.
1327 - gdcmPython/testSuite.py: dirty related kludge removed.
1328 * src/*: remaining references to gdcmParser removed.
1329 * src/*[cxx|h]: added copy[way]left header.
1332 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * In order to fix writing of dicom files:
1334 - Test/TestWriteSimple.cxx: a simpler example of writing.
1335 - Test/CMakeLists.txt changed accordingly.
1336 - src/gdcmDocument.cxx:
1337 -- The destructor now recursilvely removes potential sequences.
1338 -- Bug fix in ::IsJPEG2000()
1339 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1340 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1342 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1343 to only declared) and build on top of
1344 ::GetDocEntryByNumber(guint16, guint16).
1345 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1346 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1347 for usage in destructor and treatement of promotion in
1348 ::ReplaceOrCreateByNumber().
1349 - src/gdcmSQItem.cxx: destructor should better handle his job.
1350 Test/TestWriteSimple now runs (or at least it DOES something).
1351 * We can now start hutting memory links. A good starting point is:
1352 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1353 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1354 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1356 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * Valgrind note: after Mathieu Malaterre teached me how to read
1358 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1360 Using gcc, you can force the STL to use malloc and to free memory as
1361 soon as possible by globally disabling memory caching.
1362 With 3.2.2 and later, you should export the environment variable
1363 GLIBCPP_FORCE_NEW before running your program.
1364 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1365 simply vanish (it is still not clear to me, whether this means that
1366 STL std::string leaks or if valgrind believes it leaks...).
1367 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1368 running bin/gdcmTests makeDicomDir):
1369 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1370 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1372 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1373 SegFaulting (I drowned in DicomDir related code when trying to
1374 understand why the list is empty...).
1375 * src/gdcmDocument.h: first BSD license header try.
1376 * Doc/License.txt added.
1378 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * src/gdcmDocument.[h|cxx]:
1380 - Clean up of the Transfer related predicates. They are now all based
1381 on new method isGivenTransferSyntax, that (should) handle properly
1382 the padding problem.
1383 - general clean up, simplification, and coding style.
1384 - Specific clean up of Parse7FE0() (umproperly named actually).
1385 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1387 2004-06-14 Jean-Pierre Roux
1389 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1390 - fix the display of SQItem ordinal number
1391 - add the GetSQItemByOrdinalNumber method
1392 - remove some useless never written private methods
1394 2004-06-14 Jean-Pierre Roux
1396 - adding a constructor taking a gdcmDocEntry as an input param
1397 - ReplaceOrCreateByNumber now returns :
1398 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1399 a gdcmValEntry * if a string value is passed as a param
1401 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1402 according to the param type (no longer sets a gdcmDocEntry)
1403 - GetValEntryByNumber, GetBinEntryByNumber added
1404 - NewValEntryByNumber and NewBinEntryByNumber added
1406 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1408 - GetSQItemNumber and SetSQItemNumber added, to provide
1409 a (relative) Item identier inside a given Sequence
1410 \warning : some pb remaining around this number
1412 - AddEntry now takes the Item Number as a param
1414 - adding a constructor taking a gdcmDocEntry as an input param
1416 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * Memory leak hunt with the following command:
1418 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1419 --show-reachable=yes gdcmTests PrintDocument
1420 It looks like many (all?) leaks are due to the STL (or a bad usage
1421 of the STL. The lines producing the leaks now have a comment with
1422 a "MEMORY LEAK" tag: you can retrieve them with
1423 grep "MEMORY LEAK" src/*
1424 Here are two typical examples which I can't help fixing:
1429 char * test = "babo";
1430 name = test; //// <--- valgrind detects 960 bytes lost in
1431 //// call to std::string::operator=(char const*)
1432 name.clear(); //// Doesn't help !
1440 std::cout << "Type a bunch of characters followed by RETURN: ";
1441 getline(std::cin, line); //// <--- valgrind dectects a loss
1442 //// of 1320 bytes in call to
1443 /// std::basic_istream<>& std::getline<>
1449 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * src/gdcmHeader.[cxx|h]:
1451 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1452 and related, moved away to gdcmDocument.
1453 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1454 the corresponding protected accessors of inherited class
1455 gdcmDocument, removed ! As a consequence gdcmFile had to be
1456 declared friend of class gdcmDocument (see below).
1457 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1458 - Clean up of undefined or unused methods.
1459 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1460 account the changes to gdcmHeader.h).
1461 * src/gdcmDocument.h:
1462 - gdcmFile is now a friend class (in order to take into account the
1463 changes to gdcmHeader.h).
1464 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1465 (see changes to gdcmHeader.h).
1466 - Accessors (reading on the form GetEntry*) are now public.
1467 - Clean up of undefined or unused methods.
1468 * src/gdcmDocument.cxx:
1469 - adaptation to changes to gdcmDocument.h
1470 - ::OpenFile now writes a verbose message when file cannot be opened.
1471 - some std::string properly set to VRKey
1472 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1473 references to gdcmDocument.
1474 * Test/TestFindTags.cxx: changed accordingly to above changes.
1475 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1476 cvs repository gdcmData.
1478 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1479 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1480 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1481 conflicts with gdcmValEntry::voidArea.
1482 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1483 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1484 Value representation between StringRepresentable and BinaryRepresentable.
1485 * src/gdcmDocument.cxx:
1486 - method ParseDES: proper indentation restored and usage of
1487 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1488 - method LoadDocEntry: the fingerprint left in the SetValue() of
1489 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1490 removed. Reverting to previous code segment with the proper
1491 dynamic_cast< gdcmValEntry* >.
1492 Note: this was (partially) breaking the python test suite
1493 (gdcmPython/testSuite.py) that made usage of the above
1494 fingerprint to check presence of "Pixel Data".
1495 * src/gdcmDocEntry.h: coding style.
1496 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1497 now taken into account.
1498 * gdcmPython/gdcm.i: adaptation to the new internal representation
1499 of gdcm (exit gdcmParser, hello gdcmDocument).
1500 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1502 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1503 anymore, but instead prints the loaded Python dictionary.
1504 * .... alas, the python testSuite is still broken.
1506 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1509 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1510 * src/gdcmUtil.h : export methods
1512 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1513 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1515 * Initial addition of automatic python testing
1516 * Initial addition of automatic image comparison
1518 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1519 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1520 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1522 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1523 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1524 * Test/ShowDicom.cxx : bug fix for msvc compilation
1525 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1527 2004-05-04 Jean-Pierre Roux
1528 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1529 new concepts (and new classes) :
1530 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1531 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1532 - Sequence Doc Entries (gdcmSeqEntries)
1533 a Sequence is composed of Items.
1534 Each item is a set of Doc Entries (this is recursive)
1535 The non uniqueness of the 'Dicom tag' is due to this recursivity
1536 (never taken into account)
1537 Our unability to add a new 'entry' in the header
1538 at the proper location (neither in the H-Table (map or multimap),
1539 nor in the Chained List is also due to this recursivity.
1540 Don't try, right now, to use/modify/compile these new sources :
1541 nothing is finished.
1542 We just commit all the stuff, 'as is', in order not to loose it.
1544 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1545 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1547 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1548 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1549 file prefix (SetFilePrefix)
1551 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1552 * Add a new test: ShowDicom, for now this is just the c++ version of
1553 checkRead.sh, later it will be able to compare the image read against a
1555 * Replace the DEBUG on the stack with a global entry in cmake interface:
1556 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1558 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1559 * Add an example subdir, with a real example on how to read + write a
1562 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1564 * Doc/CMakeLists.txt: the main page is now properly differentiated
1565 between the developper and user version.
1566 * Doc/doxygen.config.in: dropped search related obsolete flags
1567 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1569 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * DEVELOPPER: added some helpfull comments for compile/test/install
1573 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1574 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1575 src directory, now generated in the build dir.
1576 2. Tests as mentionned smarter
1578 4. Add a new method in gdcmDict that return the PubDict by name
1579 this is interesting for 3rd party lib like ITK,
1580 where we could set the institution name / patient name...
1582 * ENH: 1. Now the test suite is working for real
1583 2. All binaries are now output in the gdcm-bin directory
1584 (this was not true before)
1586 2004-04-28 Jean-Pierre Roux
1587 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1588 SeQuence indented printing of Dicom Header.
1589 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1590 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1591 Computation of SQDepthLevel is now part of gdcmHeader constructor
1592 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1593 tree-like structure of a Dicom Header.
1594 * FIX Test code cleaning
1596 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1597 * ENH: Adding automatic testing
1598 1. Need a DartConfig.cmake to submit to public
1599 2. Add a test driver gdcmTest.cxx
1600 3. gdcmTestMain, an helper for the main test driver gdcmTest
1601 4. Files in Test don't have a main anymore, this becomes interesting
1602 when we add more and more tests, thus dsw don't have to load
1604 * ENH: Adding a GDCM_DATA_ROOT for testing
1605 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1606 one file instead of seven + some small cleanup
1608 2004-04-22 Jean-Pierre Roux
1609 * ENH Minor changes to the Print() methods.
1610 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1611 Header printing. Example given with :
1612 > PrintHeader fileName 2 new
1613 (SQ based tree-like structure still to be done for the Header ...)
1615 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1616 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1617 1. I have added some unsigned where needed
1618 2. Some function parameter not used -> (void)
1619 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1620 4. g++ don't like character '\' in comment
1621 5. #define jpeg_create_decompress jCreaDecompress
1622 this really need to be fixed
1623 6. virtualize destructor of gdcmObject ... leakage
1624 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1625 this also really need to be fixed
1626 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1627 remove compression file
1628 (as we only do decompression, right ?)
1629 * ENH: Change malloc/calloc/free with c++ equivalent
1631 2004-04-21 Jean-Pierre Roux
1632 * FIX gdcmHeaderHelper::GetXSpacing
1633 when a single value is found (bug ?), xpacing is now
1634 defaulted to yspacing
1636 2004-04-19 Jean-Pierre Roux
1637 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1638 * ENH add parameters :
1639 bool exception_on_error = false,
1640 bool enable_sequences = false,
1641 bool ignore_shadow = false
1642 to the gdcmFile constructors to be full gdcmParser compliant
1643 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1644 to allow reading of PAPYRUS 3.0 files
1646 2004-04-06 Jean-Pierre Roux
1647 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1649 2004-04-02 Jean-Pierre Roux
1650 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1651 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1652 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1654 2004-03-30 Jean-Pierre Roux
1655 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1656 for ACR file, written out as DICOM files (hope so...)
1658 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1659 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1660 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1661 moved to base class gdcmParser and only the specialisation is kept
1663 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1664 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1665 already does the job.
1666 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1667 (to be consistent with gdcmParser::WriteEntries).
1669 2004-03-30 Benoit Regrain
1670 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1671 upate of the object's instance. It's passed to 2 in the unfavorable
1672 case : one in the ExecuteInformation, one in the ExecuteData
1674 2004-03-29 Jean-Pierre Roux
1675 * ENH : Check on file type to be written moved
1676 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1677 * FIX : gdcmObject::ResetBoundaries now stops properly
1678 when end-of-list is reached
1679 : gdcmVersion modified (as Benoit Regrain asked)
1681 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1683 * src/gdcmUtil.cxx: added forgotten iostream include.
1684 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1685 equivalent to ExplicitVR in existing code).
1687 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1688 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1689 now contains all the gdcmGlobal related code.
1690 * minor coding style and doxygenation changes.
1692 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1694 now contains all the Debug related code.
1695 * minor clean-up of includes in src/*.cxx
1696 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1697 CreateCleanString) removed.
1698 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1699 * Doc/DoxyMainPageUser.txt added.
1700 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1701 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1702 src/gdcmDirList.cxx)
1704 2004-03-24 Jean-Pierre Roux
1705 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1707 2004-03-23 Jean-Pierre Roux
1708 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1709 big endian made volumes
1710 * ENH Now gdcmParser constructor and destructor are protected to forbid
1711 end user to instanciate class gdcmParser
1712 (only gdcmHeader and gdcmDicomDir are meaningfull)
1714 2004-03-22 Benoit Regrain
1715 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1716 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1717 gdcmSerie to gdcmDicomDirSerie
1719 2004-03-19 Jean-Pierre Roux
1720 * ENH Now the tree-like structure describing a DICOMDIR comming from
1721 an already existing DICOMDIR file is consistent with
1722 the home-made tree-like structure build ex-nihilo
1723 or build from the files held (recursively) in a Directory
1724 functions gdcmDicomDir::CheckBoundaries()
1725 gdcmObject::SetBoundaries() added
1727 2004-03-17 Jean-Pierre Roux
1728 * REM (Eric Boix bug) : removal of meaningless
1729 gdcmDicomDirImage::NewImage function.
1730 * FIX now file names and directory name are written properly in the
1732 * FIX now gdcmDicomDir constructor may be call without any trick
1735 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1737 of gdcmDicomDirImage::NewImage as empty function.
1739 2004-02-28 Jean-Pierre Roux
1740 * ENH add gdcmDicomDir:NewPatient
1741 add gdcmDicomDirPatient:NewStudy
1742 add gdcmDicomDirStudy:NewSerie
1743 add gdcmDicomDirSerie:NewImage
1744 to allow making gdcDicomDir object.
1745 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1746 (as opposite to the gdcmHeader chained list)
1748 2004-02-11 Benoit Regrain
1749 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1750 when using from python
1752 2004-02-10 Benoit Regrain
1753 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1754 * FIX : in gdcmDicomDir when the directory is empty
1755 * ENH : add callback and methods to get the progression of dicomDir
1758 2004-02-06 Jean-Pierre Roux
1759 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1760 - GDCM_META added to gdcmDicomDirType
1761 - class gdcmMeta created
1762 * ENH : - A brief summary is now displayed at the beginning of
1763 'testDicomDir' to help disaster magnitude estimation
1764 * REM : Now useless Test/explDICOMDIR.cxx
1766 2004-02-05 Benoit Regrain
1767 * ENH : add methods in gdcmObject to get the hash table or the list of
1769 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1770 * FIX : wrapping python for TagHeaderEntryHT
1772 2004-02-04 Benoit Regrain
1773 * FIX : even length for some strings when writting the dicom dir
1774 * FIX : sort the images in the dicom dir
1775 * FIX : Bug fix for python use of dicom dir
1776 * ADD : a python demo
1778 2004-02-04 Jean-Pierre Roux
1779 * FIX : Final solution (?) for icone embedded images
1780 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1781 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1782 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1783 gdcmData/gdcm-MR-SIEMENS-16.acr1
1784 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1785 to make full checking easier
1787 2004-02-04 Benoit Regrain
1788 * FIX : WriteEntries : coding style & logic in parameters
1789 * FIX : Set the elements to create the DicomDir in a dictionary file
1791 2004-02-03 Benoit Regrain
1792 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1793 * gdcmDicomDir : add the load of directory
1794 * Bug fix and print add-on
1796 2004-02-03 Jean-Pierre Roux
1797 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1798 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1799 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1800 * FIX gdcmParser.cxx : 'group length' elements are now considered
1801 as integers, even for shadow groups, when file is Implicit VR
1803 2004-02-02 Jean-Pierre Roux
1804 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1806 of the last synonym :-(
1807 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1809 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1810 * FIX taking into account the possible 7fe0,0010 multiplicity
1811 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1812 to allow removal of references to 7fe0,0010, to deal with
1813 ACR-NEMA images, when 0028,0200 is meaningfull
1815 2004-01-31 Jean-Pierre Roux
1816 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1817 no longer writes 'Un' on disk
1818 * FIX SQ elements with actual length are now dealt with corectly
1819 * FIX gdcmFile::WriteBase make the difference, for color images, between
1820 the length (for Palette expanded images)
1821 and Raw Length (non expanded image + Palette)
1822 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1823 (that broke Write). Replaced by UL.
1824 Aware user will reload the field if he
1825 thinks it's necesssary
1827 2004-01-30 Jean-Pierre Roux
1828 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1829 when 'dirty Acr' is found, to be compliant with the new
1830 IsReadable() methods.
1832 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1833 (no DOUBLE images in kosher DICOM,
1834 but so usefull for people that miss them ;-)
1836 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1837 DICOMDIR related utilities (not checked as Windoze compliant)
1839 2004-01-28 Jean-Pierre Roux
1840 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1842 2004-01-27 Jean-Pierre Roux
1843 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1844 to allow skipping the shadow elements, to save memory space.
1845 The TRUE value for this param has to be used
1846 with a FALSE value for the 'enable_sequence' param.
1847 ('public elements' may be embedded in 'shadow Sequences')
1848 * gdcmHeader methods now deal with 'embedded icones images' in the header
1849 (even when an 'icone image sequence' is announced by the
1850 element (0x0088,0x0200), but there is NO icone at all ...
1852 * gdcmHeader sometimes Image Location value doesn't follow
1853 the supposed processor endianity (see gdcmData/cr172241.dcm).
1856 * gdcmHeader add the method
1857 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1858 to get *all* the Header Entries with the same tag.
1859 GetHeaderEntrySameName is probabely *useless*
1860 (no meaning : Name is *not* an identifier within the Dictionnary)
1862 2004-01-26 Benoit Regrain
1863 * Bug fix in the print of hexadecimal representations. Remove long fields
1864 in the print and add a third level of print to print them
1866 2004-01-23 Benoit Regrain
1867 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1868 * Bug fix on test suite after remove the strip made on not string fields
1869 * Split the IsReadable method between gdcmParser which test that the file
1870 is dicom and gdcmHeader which test that it's an image file
1872 2004-01-22 Benoit Regrain
1873 * DicomDir : clean code, add methods, set variables in protected or private
1874 * gdcmUtil : bug fix for the clean string method
1876 2004-01-19 Benoit Regrain
1877 * Add the use of shadow dictionaries
1878 * bug fix and coding style
1880 2004-01-19 Benoit Regrain
1881 * src/gdcmFile.cxx : bug fix concerning the close of file
1882 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1883 * Add the update of header entries using the shadow library
1885 2004-01-19 Benoit Regrain
1886 * removal of file gdcmHeader2.cxx
1887 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1888 inheriting from gdcmParser. This split is to prepare the integration
1889 of dicom dir parsing
1890 * bug fix under python
1892 2004-01-16 Jean-Pierre Roux
1893 * REM removal of class gdcmHeaderEntrySet
1894 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1895 * ADD add file gdcmHeader2.cxx
1896 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1898 2004-01-15 Benoit Regrain
1899 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1900 entries created while parsing the header. Thus, they will be destroyed
1901 when the gdcmDictSet will be destroyed
1902 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1905 2004-01-15 Benoit Regrain
1906 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1907 made a fatal error because of the memory release at the end of program.
1908 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1909 some memory and vtk seems to have some problems with that.
1910 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1912 2004-01-14 Benoit Regrain
1913 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1914 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1915 * src/*.[h|cxx] : make changes due to class name changes
1916 * gdcmPython/demo/*.py : bug fix due to method names
1918 2004-01-13 Benoit Regrain
1919 * src/*.[h|cxx] : coding style
1920 * vtk/*.[h|cxx] : coding style
1922 2004-01-13 Benoit Regrain
1923 * gdcmPython/testSuite.py : test the readable flag of file for tests
1924 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1925 It's lied to the stl compilation by MSVC (windows, always windows...)
1926 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1928 2004-01-12 Benoit Regrain
1929 * src/*.h : add comments
1930 * src/gdcmDictSet.h : set the method BuildDictPath in public
1931 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1932 directly setted in the source code
1933 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1936 2004-01-09 Benoit Regrain
1937 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1938 * setup.py : use a reference to gdcmVERSION
1940 2004-01-07 Benoit Regrain
1941 * Modification to compile with the distutils.
1944 2003-12-10 Benoit Regrain
1945 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1946 can use a gdcmHeaderHelper to load data
1947 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1948 made in the source code
1950 2003-12-10 Benoit Regrain
1951 * Update Windows projects and .cvsignore files
1953 2003-11-12 Jean-Pierre Roux
1954 * ENH gdcmHeader constructor has one more parameter (default value : false)
1955 that allows the user to 'go inside' the SeQuences only
1957 gdcmElValSet:Print takes it into account
1959 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1960 * ENH: Update gdcmPython/CMakeLists
1961 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1962 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1964 2003-11-10 Jean-Pierre Roux
1965 * FIX : gdcmHeader::LoadElements is now based
1966 on the ListTag listElem member,
1967 not longer on the TagElValueHT tagHt member
1968 * ENH : PrintPubElVal shows (temporarily) both results,
1969 with the tagHt member and the listElem member.
1970 (it's easier to 'see' the problems when using Printheader)
1972 * FIX : old private member LgrElem is now splitted into
1973 ReadLength : Length actually found on disk (updated only
1974 if bug fixing is necessary), for internal
1976 UsableLength : Updated by FixFoundLength, to fix a bug
1977 or to allow Parser going on.
1978 Will allow to re-write a kosher header when a SeQuence
1979 with a length (not 0000) is found
1980 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1981 because gdcmElValSet::Add does not update ListElem
1984 2003-11-07 Jean-Pierre Roux
1985 * FIX misstyping in Transfert Syntax name table
1986 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1987 when they have an actual length (not 0000 nor FFFFF)
1988 (Nobody should care of it, but DICOMDIR explorers)
1990 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1993 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1994 * ENH: vtkGdcmReader now supports LUT !
1995 (vtkgdcmViewer for now is not able to use them though)
1997 2003-11-05 Jean-Pierre Roux
1998 * in testSuite.py : new files names for checking the package
1999 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2000 that returns the pixel area size to the *aware* (vtk) user
2001 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2003 2003-11-05 Benoit Regrain
2004 * in testSuite.py : Modify the rules for checking the paths
2005 : Explicit error messages
2006 * in __init__.py : Related modif
2008 2003-11-03 Jean-Pierre Roux
2009 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2010 to be used by aware (vtk) users that want to manage
2011 LUT (and no to turn the PALETTE image into an RGB pixels one)
2012 * GetPixelType now returns 8U for 24 Bits images
2013 (vtkGdcmReader compliant)
2015 2003-10-31 Jean-Pierre Roux
2016 * Removal of *all* gdcmData images and add them again
2017 in order to loose the 'history' of un-anonymised images
2019 2003-10-31 Jean-Pierre Roux
2020 * RMV : removal of useless jBitsInJsample.h
2021 for both 8 and 12 Bits JPEG Lossy Libraries
2023 2003-10-31 Jean-Pierre Roux
2024 * ENH : Add the functions gdcmFile::GetImageDataRaw
2025 gdcmFile::GetImageDataIntoVectorRaw
2026 that act as GetImageData and GetImageDataIntoVector
2027 except the making of an RGB Plane from Gray Plane + LUT
2028 Intended to aware (vtk) users who know how to manage
2031 GetLUTRGBA return a R,G,B,A LUT if any
2032 lgrTotaleRaw gives the 'Raw' length
2033 GetImageDataRaw returns the gray Plane
2034 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2035 (They stay Grey, just like with other Dicom viewers :-(
2037 2003-10-30 Jean-Pierre Roux
2038 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2040 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2041 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2042 being coherents dicom files.
2044 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2045 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2047 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2048 * ENH: Two steps is necessary to please VC++ compiler...
2049 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2050 * ENH: Add include dir to medcon lib
2051 * FIX: only one function is being exported for now !
2052 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2054 2003-10-29 Jean-Pierre Roux
2055 * adding gdcmHeader::GetLUTRGBA
2056 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2057 --> Mathieu, the modif u're waiting for is not yet committed
2058 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2060 2003-10-27 Jean-Pierre Roux
2061 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2062 00191113.dcm DermaColorLossLess.dcm
2063 MxTwinLossLess.dcm RadBWLossLess.dcm
2064 * ENH: For version prior to vtkImageViewer2 -r 1.19
2065 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2067 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * Removal of ido stuff in CMakeLists.txt
2070 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2072 * FIX: remove a call to ->Modified ... see comments
2073 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2075 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * FIX: Problem with path for libvtkgdcmPython
2077 * ENH: Try adding a search script for python site-package
2078 * RMV: Remove some file from medcon lib that are not necessary
2079 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2080 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2081 * FIX: More pragma disable fro VC++,
2082 I don't think I break something as it is also disable in VTK/ITK.
2083 But it fasten debug compilation time.
2085 2003-10-23 Jean-Pierre Roux
2086 * gdcm now deals with 16 Bits Run Length Encoded images
2087 (they are compressed as 2 planes images,
2088 one for the high Bytes, the other for low Bytes)
2090 2003-10-22 Jean-Pierre Roux
2091 * Now CheckRead takes into account :
2092 - the bugged 'Leonardo' Siemens images
2093 - the XA images, sent thru the burning VPRO station
2094 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2097 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * FIX: When copying a Makefile.am to CMakeLists.txt
2099 one should remove the '\'
2101 2003-10-22 Jean-Pierre Roux
2102 * in gdcmData adding a bugged 'Leonardo' Siemens image
2103 (wrong lengths in header)
2104 OK with gdcm, KO with the other viewers :-)
2105 * add a GE dlx XA image, thru the VEPRO burning station
2108 2003-10-21 Jean-Pierre Roux
2109 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2110 for a brutal checking of vtkgdcmViewer compliance
2112 2003-10-21 Jean-Pierre Roux
2113 * add the files for 'xmedcon' Jpeg Lossless library
2114 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2116 2003-10-21 Jean-Pierre Roux
2117 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2119 2003-10-21 Jean-Pierre Roux
2120 * garbage Siemens 'Leonardo' images dealt with
2121 (the patch is easy to remove)
2122 * cosmetic changes to avoid warnings
2124 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2126 no need to press 'r' now.
2128 2003-10-20 Jean-Pierre Roux
2129 * upgrade of checkRead.sh checkWrite.sh according
2130 to new Jpeg Lossless decompressor
2131 * add US.3405.1.dcm, a genuine RGB medical file ...
2132 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2133 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2135 2003-10-15 Jean-Pierre Roux
2136 * general anonymisation in gdcmData
2137 * adding the 'color files' from
2138 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2139 * adding some well knowed bugged-header images
2140 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2141 waiting for their inclusion in Python testsuite
2143 2003-10-15 Jean-Pierre Roux
2144 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2145 no longer seg faults when file is not found
2147 2003-10-14 Jean-Pierre Roux
2148 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2151 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * TODO: *.in file to genereate a UseGDCM later
2154 2003-10-14 Jean-Pierre Roux
2155 * Some supposed-to-be Dicom Images have no preamble.
2156 OpenFile takes it into account
2157 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2158 * Missing elements added in dicomV3.dic
2159 (just to be affraid : have a look at
2160 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2161 and do it again next year ;->
2163 2003-10-13 Jean-Pierre Roux
2164 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2165 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2166 But there are NOT. It's fixed !
2168 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2169 * FIX: "jpeglib.h" was not found on VC++
2170 * FIX: vtkgdcm was not being installed
2172 2003-10-10 Jean-Pierre Roux
2173 * ENH : OpenFile closes the file if it *really* doesn't look like
2174 an ACR-NEMA / DICOM one.
2175 * FIX : testWrite no longer writes an empty file if the source file
2176 is not gdcm Readable
2177 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2180 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2181 * FIX: CMake generate now documentation
2182 * ENH: out of source doc build !
2183 * ENH: Generate both user and dev documentation
2184 * ENH: Should work on windows too
2185 * ENH: Only one doxygen config.in file is needed
2186 * FIX: make install should be ok now on ùnix plateform
2187 * FIX: PATH to dictionary was wrong (missing /)
2188 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2190 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2191 * vtkGdcmReader is now able to read rgb dicom file.
2192 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2193 * added a gdcmViewer to vtk test, use mouse to control
2194 window level & window width
2196 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * CMake-ification of gdcm, we have now two build system
2198 * FIX: on cygwin Wsock32 doesn't exist
2199 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2201 2003-10-06 Emanuel Ollart
2202 * FIX : compilation process wad broken.
2203 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2205 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2206 * change gdcmViewer -> vtkgdcmViewer
2207 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2209 2003-10-06 Jean-Pierre Roux
2210 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2211 ( e.g : well known GE images with a wrong elem length,
2212 : Philips MRI Images with a wrong Huffman table)
2213 * still to be done : allow the reading of bugged LEONARDO Siemens images
2215 2003-10-03 Jean-Pierre Roux
2216 * Odd length strings are padded with '\0' (not with spaces,
2217 to remain compliant with already defined strings,
2218 like Transfert Syntax UID and others)
2220 2003-10-03 Jean-Pierre Roux
2221 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2222 to allow displaying RGB images (not only by affim ;-)
2224 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2225 * vtkGdcmReader is now able to read rgb dicom file.
2226 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2228 2003-10-03 Jean-Pierre Roux
2229 * A few nasty patches to allow the reading of a lot of nasty images
2230 ( e.g : well known GE images with a wrong elem length,
2231 : Philips MRI Images with a wrong Huffman table)
2232 * still to be done : allow the reading of bugged LEONARDO Siemens images
2234 2003-10-03 Jean-Pierre Roux
2235 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2237 2003-10-03 Jean-Pierre Roux
2238 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2239 to allow displaying RGB images (not only by affim ;-)
2241 2003-10-03 Jean-Pierre Roux
2242 * gdcmFile::GetImageDataIntoVector now
2243 - deals with MultiFrames MultiFragments Run Length Encoded files
2244 - deals with YcBcR (YBR_FULL) files
2245 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2246 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2248 (no sample found :-(
2250 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2252 Two reasons: - clear things
2253 - third parties acces gdcm through header files, so won't
2254 suffer anymore VC++ complains
2256 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2257 * add argv[1] in testvtkGdcmReader.cxx
2260 2003-09-24 Jean-Pierre Roux
2261 * The lines are now eigthy characters long.for
2262 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2264 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2265 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2266 char* to std::string. Thus, the use of strdup becomes useless. (see
2267 previous commis of Malaterre)
2268 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2269 before the last Malaterre's commit.
2271 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * This commit should fix the Debug building under VC++, the problem
2273 was mainly a mixture of debug and release lib being loaded at startup.
2274 * I also remove a depency to a specific C function: strdup. Because I had
2275 to force the link to msvcrtd (whereas strdup is in libc).
2277 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2278 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2279 located in the gdcmCommon.h file. All use of reference of tha has been
2280 changed to now use the variable GDCM_UNFOUND.
2282 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2284 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2285 Dicom dictionary. The test suite can now be run again. Note:
2286 I'm note very happy with the " (RET)" changes. I believe this
2287 RETAINED comment should be dropped when parsing the dictionary.
2288 - PACKAGER corrected
2290 - AUTHORS updated and now in alphabetical order
2291 * Makefile.am now exports gdcm.dsw for Windoze users.
2293 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * cygwin complains about missing std:: in subdir Test/
2296 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * remove some methods that are now in gdcmHeaderHelper
2299 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * vtkGdcmReader set spacing and origin correctly
2302 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * Fix a few delete/delete[] mismatch
2305 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2306 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2307 interpretation to data given by gdcmHeader. For instance there are
2308 heuristics to get informations (look at different places).
2309 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2310 sorting DICOM images based on different strategies.
2311 * modified Makefiles accordingly.
2313 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2314 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2315 when building in debug mode
2316 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2317 src/win32/gdcmdll.dsp
2318 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2320 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2324 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2325 * src/win32/libgdcmjpeg12.dsp was not dos format
2326 * src/win32/libgdcmjpeg12.dsp :
2327 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2328 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2330 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2331 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2333 * src/gdcmFile.cxx : bug fix in affectation type
2334 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2335 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2336 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2337 symbols... future problem ?
2339 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2340 * src/win32/libgdcmijpeg12.dsp was missing
2341 * modified gdcm.dsw accordingly
2343 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2344 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2346 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2347 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2348 commit of JPR (before his hollidays to facilitate our work).
2349 * setup.py : bug fix in code. Modifications made while the last commit
2350 of JPR. The code hasn't been tested before the commit... it's so
2351 useless to make that (for best programmer that is JPR) !!!
2353 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * tagged the current version as Version0_3 (i.e. version 0.3)
2356 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2357 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2358 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2359 * *.dsp : modifications to use new libgdcmijpeg8 library
2360 * setup.py : bug fix on VTKPATH variable
2361 * PACKAGER : adding all concerning windows
2363 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2366 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2367 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2368 test suite reported error.
2369 * PACKAGER file added (describes what a packager must do when
2370 packaging a new release).
2371 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2372 * configure.in: upgraded version number to 0.3.0
2373 * fixing build of rpm (through rpm -ta):
2374 - Doc/Makefile.am exports proper doxygen files
2375 - src/jpeg/libijg8/Makefile.am exports the include files.
2377 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2378 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2379 * src/gdcmHeader.h : formatting code
2381 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2382 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2383 We were obtaining error message from vtk. Now, creation of file list
2384 is made in an internal list to prevent this problem.
2385 Bug fix when output is empty.
2386 Bug fix in update of progress value. Previous commit for this was a bad
2388 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2390 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2391 * src/gdcmHeader.h : added method to get the file name
2392 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2393 files. Added method to remove all files on the input
2394 Added FIXME comment concerning the bad parsing of header made by
2395 ExecuteInformation method (in ExecuteData method)
2397 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2399 when using make instal.
2400 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2401 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2403 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2404 * setup.py : adding include dir of jpeg lib to compile all sources
2405 * */Win32/*.dsp : JPR fix for windows compilation
2407 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2408 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2410 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2411 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2413 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * setup.py is again effective on un*x (takes into account the
2415 addon of the jpeg library)
2416 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2417 * Doc/Doxy* updated (includes above enhancements)
2418 * INSTALL now points to web documentation
2420 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * src/gdcmHeader.h doesn't make unnecessary reference to
2423 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2425 * src/gdcm*.[cxx|h] :
2426 - to allow compilation with gcc 3.x
2427 -- clean up of STL usage (added explicit usage of std::)
2428 -- small fixes on exceptions.
2429 Note: linking not tested !
2430 - clean of doxygen comments to avoid warnings at documentation
2432 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2433 dependent convertion).
2435 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * Clean up of previous JPR garbage commit (not even commented in the
2438 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2439 - moved all jpeg related files from src to src/jpeg/libijg8, with
2440 addition/modification of Makefile.am and configure.in.
2441 - the testSuite is still brain damage (not guilty).
2443 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2444 * WrapVTK.py : modifications to get correctly vtk source files to
2446 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2447 (FileName -> Filename)
2449 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * vtk/vtkGdcmReader.[cxx/h]:
2451 - UpdateProgress method should now be effective
2452 - removed the limitation on having only images loaded (as opposed
2454 - when building a stack of images/volume, a lesser number of
2455 gdcmHeader and gdcmFile instances should be used (hopefully
2456 accelerating things).
2457 - when building a stack of images/volumes, files which are not
2458 loadable (wrong path-filename, wrong permissions on existing file,
2459 or file not parsable by gdcm) are replaced with a black image
2460 in the stack (for the caller to notice the problem).
2462 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2465 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2466 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2467 between standard library (std) and vtk library (problems are found
2468 under Windows... thanks Windows !)
2470 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2473 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2475 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2478 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * When compiling with distutils (see setup.py) the C++ compiler is
2480 called with different flags than the default ones (with automake).
2481 In order to fix all those warning, I compiled gdcm with the command
2482 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2483 and went for warning fixes:
2484 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2485 up from unused variables.
2486 - vtk/vtkGdcmReader.cxx: potential bug fix.
2487 * src/gdcmHeader.h: Doxygen warning cleanup
2489 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2490 * gdcmPython/gdcm.i:
2491 - typemaps correction to take into account the systematic replacement
2492 of "using namespace std" with std:: prefix e.g. std::list,
2493 std::string... (cf changes of 2003-05-21).
2494 - gdcmGlob global variable of type gdcmGlobal (defined in
2495 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2496 exported to Python a as cvar.
2497 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2498 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2499 gdcmDictSet.GetPubDictTagNames() and
2500 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2501 C++ static methods).
2502 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2503 with the above changes.
2505 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2506 * setup.py, manifest.in : bug fix under linux
2508 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2509 * Modification of setup.py to compile vtk part too. Then, we have 2
2510 wrappers which must work with same distutils. For that, we have a
2511 generic distutils in distusiltsWrapping.py ; with :
2512 - build_extWrap class to wrap generically all extensions,
2513 - ExtensionWrap base class for all wrapping extension that contains
2515 - Wrapper interface which wrap sources
2516 + In WrapSwig.py we have extension and wrapper for Swig
2517 + In WrapVTK.py we have extension and wrapper for VTK
2518 * MANIFEST.in : modifications to consider vtk directory and new python
2519 files for compilation
2521 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2522 * Added python wrappers of vtkGdcmReader vtk class (see the
2523 source in vtk/vtkGdcmReader.cxx) :
2524 - vtk/Makefile.am now builds a library
2525 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2526 python library (as opposed to _gdcm.so wich are the python
2527 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2528 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2530 - configure.in has an additional flag --enable-vtk that needs
2531 to be set to enable compilation of vtk related code, that is:
2532 + vtk/vtkGdcmReader.so and
2533 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2534 + gdcmPython/vtkgdcmPython.so (see above)
2535 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2536 be read when compressed or when HighBit + 1 != BitsStored),
2537 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2538 the usage of the python wrapper of vtkGdcmReader vtk class.
2539 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2540 * src/*.[h] all occurences of stl classes are now prefixed with
2541 std::, and all occurences of "using namespace std;" where removed.
2542 This is to avoid pollution of global namespace in included files.
2543 Apparently vtk does not avoid this pitfall: when using both
2544 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2545 collision of various stl members (principally cout...).
2546 * gdcmPython/testSuite.py now cleanly removes temprory generated
2548 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2549 comply with above changes)
2551 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2552 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2553 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2554 vtk data structure (an image Flip was required).
2555 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2556 * cosmetic changes in documentation.
2558 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2559 * src/gdcmHeader.cxx: the constructor no longer exits when an
2560 unexisting file is given as argument.
2561 * The subdirectory Data (containing all the images used for the
2562 test suite) is not part of this repository anymore. A new module
2563 containing those images is now available at
2564 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2565 with the name gdcmData.
2566 All the python scripts (including the package initialisation file
2567 gdcmPython/__init__.py) were adapated to take this change into
2568 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2570 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2571 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2572 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2573 demo of the usage of this class.
2574 Compilation of this vtk part is only done when using the --enable-vtk
2575 at configure (or autogen.sh) stage.
2577 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2578 * More memory link related corrections and documentation fixes.
2580 - maximum info is obtained with a command of the form:
2581 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2582 --show-reachable=yes PrintHeader
2583 - the remaining reachable blocks seem to come from the STL
2584 allocation scheme through the usage of map and list. It looks
2585 like this memory cannot be freed but it is not a memory leak
2586 (in fact further invocation to the STL would recollect the
2587 unused memory allthough it cannot explicitely be freed).
2588 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2589 of displaying an image parsed with gdcm and displayed with VTK.
2590 Note: some images don't seem to work e.g.
2591 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2592 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2593 Allthough this weakens the semantics, it is a ditch attempt to
2594 make gdcm more thread friendly.
2596 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2597 * Memory link hunt (by using valgrind through the command
2598 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2599 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2600 gdcmHeader::_dicom_vr.
2601 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2602 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2604 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2606 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2607 * src/Makefile.am now exports all the necessary include files at
2611 * UpdateGroupLength replaced by new one
2614 * UpdateGroupLength re-written using H-Table
2615 (named UpdateGroupLengthNew untill checks are over)
2617 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2618 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2619 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2621 - gdcmHeader::GetPubElValSet removed.
2622 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2623 UpdateGroupLength, WriteElements, Write.
2624 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2625 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2626 carried the same semantics.
2627 - src/gdcmHeaderIdo.cxx changed accordingly.
2628 - gdcmFile::WriteBase now regroups all the codes from previous
2629 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2630 - enum FileType moved to gdcmCommon.h
2631 * src/gdcmHeader.cxx AddDefault trashed
2632 * gdcmGetXSize added
2633 * getimageDataSize now calls gdcmGetXSize
2634 * Test/*.cxx changed to agree with above changes
2636 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2638 (to avoid double call by end user).
2639 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2640 by end user, since gdcmHeader::gdcmHeader now handles it.
2642 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2643 * gdcm/Doc many doxygen changes:
2644 - Doxyfile now has two different versions, DoxyfileUsers that generates
2645 the html.users end users oriented documentation and
2646 DoxyfileDeveloppers that generates the html.developper developper
2647 oriented documentation.
2648 - README changed accordingly
2649 - requirement.txt removed (old design info moved to TODO).
2650 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2651 DoxyMainPage.txt, DoxyPython.txt provide more information.
2652 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2653 be updated by simply regenerating the docs with doxygen and copying
2654 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2655 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2656 all the tests in the form "if (<map>.count() >1)" were removed.
2657 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2658 ill-formed documentation sections.
2659 * src/gdcmHeader.cxx: ditto
2661 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * setup.py fixed for un*x (needed macro for stdint.h)
2663 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2664 un*ces with sh-utils test utility.
2665 * gdcmPython/demo/test.py renamed to PrintHeader.py
2666 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2667 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2668 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2669 * src/gdcm*.cxx JPR's bad inclusion fixed.
2671 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2673 * gdcmPython/demo/test.py changed accordingly.
2675 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * gdcmPython/Makefile.am fixed linking against libstdc++
2677 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2678 * Swig subdir (historical tests of swig version 1.3.17++) removed
2679 * Test/testChangeEntete.cxx some lines commented out in order to make
2681 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2682 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2684 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2686 hence the user doesn't need this explicit call.
2687 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2688 i.e. LoadElements() call removed.
2689 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2690 - src/Makefile.am declares the proper flag for g++.
2691 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2692 for adding user defined new tags.
2693 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2694 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2695 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2697 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2698 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2699 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2700 src/Makefile.am : the project should properly compile and install
2701 with the autotools, included the python wrappers part.
2702 * gdcm.spec.in : added a spec file for RPM packaging.
2704 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2705 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2707 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2709 to exported to the environement (see gdcmPython/testSuite.py
2711 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2712 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2713 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2714 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2715 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2717 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * gdcmPython/__init__.py doesn't crash anymore when running in
2719 in InstallMode or PreInstallMode but with an environement given
2720 value of GDCM_DICT_PATH.
2721 * src/gdcmDictSet.[cxx/h] coding style.
2723 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2725 * src/gdcm.h general comments moved to TODO, and README
2726 * src/gdcm.h should now be seen as a user commodity (including it
2727 should suffice to fully use gdcm). It is nowhere including within
2728 any of the kernel files src/*.cxx and src/*.h.
2730 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2732 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2734 * src/gdcm*.cxx only include their corresponding include file
2735 (as opposed to gdcm.h)
2736 * gdcmPython/gdcm.i changed accordingly
2737 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2738 the autogen.sh generated "make snapshot" command to work.
2739 * autogen.sh removed history related references to crea package.
2741 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * distutilsSwigCPlusPlus.py work around some swig portability
2745 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2747 was done in a last ditch attempt to get setup.py _really_
2748 operationnal. The python/gdcmPython layaout add the advantage
2749 of hidding away the python related distutils specific files
2750 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2751 Alas, the src directory was out of scope (i.e. it's relative
2752 position to setup.py was ../src) which made things impossible to
2753 handle (see previous version of python/setup.py). Crossing fingers...
2755 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * python/setup.py now works on Un*x. (harder than I thougth)
2757 * python/distutilsSwigCPlusPlus.py can now have include files
2758 among the list of sources.
2760 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2761 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2762 * modifications in MSVC projects
2764 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * As stated by the first lines of Test/ExceptionAndPython/README, it
2766 looks like we can move back to original usage of exception within
2767 src/gdcm* and hence remove the errno stuff that was introduced
2768 as a quick and dirty fixture of this problem (added to the TODO).
2769 * Doc/Doxyfile configuration file for Doxygen and corresponding
2770 README file for usage added.
2771 * Test/testWrite.cxx added. This new test comes from a split of
2772 test.cxx that is now reverted to its original purpous i.e.
2773 testing the proper parsing of a Dicom related file.
2774 testWrite.cxx concentrates on testing the IO part of gdcm.
2775 * Test/bug1.cxx (containing a bug on WIn32) added.
2776 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2777 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2778 whose purpose is to publish the content of the TagNames of the
2779 Dicom public dictionnary were not accessible without an
2780 instance of class gdcmHeader.
2781 - those methods are now static methods of gdcmDictSet and hence
2782 require no instances at all to be invocated.
2783 - within gdcmDictSet this change required to change some method
2784 to class methods (i.e. are now static) among which SetDictPath
2785 (renamed to BuildDictPath) and LoadDefaultPubDict.
2786 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2787 the above changes by calling the new method classes of gdcmDictSet.
2788 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2789 the above to be effective.
2790 * python/gdcmPython: in order to wrap properly the above changes
2791 for Python, swig version now needs to be > 1.3.17.
2792 * python/gdcmPython/Makefile fixed to adapt itself to new
2793 configure/make shema introduced by Johan Montagnat (thanks for the
2794 contribution). Alas this Makefile cannot be turned into a proper
2795 Makefile.am without some heavy changes in the configure.in
2796 (for python dectection).
2797 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2798 now avoids publishing the empty entries.
2800 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2801 * python/setup.py : bug fix concerning install under windows
2802 ExtraPath reused :-P
2803 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2805 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2806 * Dicts/dicomV3.dic : remove double spaces !!!
2807 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2808 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2811 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2813 method. Doxygenation.
2814 * src/gdcm.h clean up of JPR spurious comments.
2816 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * python/distutilsSwigCPlusPlus.py now properly collects the
2818 shadow classes generated by "swig -c++" (gdcm.py in our case)
2819 when using "python setup.py install".
2820 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2821 reexports the working classes.
2822 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2823 by the classical C errno scheme. This is to prevent an obscure
2824 behavior of the python wrappers when importing wxPython.wx prior
2825 to gdcmPython (which ended up in an abort call). An illustration
2826 of this oddity can be found in the Test/ExceptionAndPython
2827 subdir (see the README file). This problem probably due to
2828 an combination of g++ and dynamic loading.
2829 * added Test/ExceptionAndPython (see above)
2831 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * Changed the layout of the python part to avoid bloating main
2833 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2834 i.e. the distutils arsenal. All the python related stuff is
2835 again in a python subdir, but the package itself is now in
2837 * setup.py was cleaned up:
2838 - pythonIncludePath removed
2839 - python setup.py bdist target is now functional.
2840 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2841 collision with other packages). gdcmPython/demo/*.py changed
2844 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * python subdir moved to gdcmPython (preparation of distutils packaging).
2846 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2847 distutils installer is operational.
2848 * - gdcmPython/__init__.py now properly loads the swig generated
2849 shadow classes (from gdcm.py).
2850 - gdcmPython/demo/*.py changed to import the package gdcmPython
2851 instead of gdcmPython/demo/load.py.
2852 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2854 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2856 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2857 entries within the associated public Dicom dictionary resp. the same
2858 information but sorted by the fourth field (PAT, IMG, DIR) of the
2860 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2861 are now in the "???" group.
2862 - python/gdcm.i changed accordingly,
2863 - python/demo/printGroupedPublicDict.py added, that gives an example
2864 of the above new functionalities in Python.
2866 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * src/gdcm.h, gdcmHeader.cxx:
2868 - historic references to glib's g_malloc and g_free (#defined)
2869 were definitively removed.
2870 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2871 * src/gdcmElValSet.cxx:
2872 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2873 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2874 - GetElValue(string) renamed to GetElValueByName.
2875 - Added GetElementByName(string).
2876 * src/gdcmHeader.cxx: added
2877 - GetPubElValRepByNumber(guint16, guint16)
2878 - GetPubElValRepByName(string)
2879 - GetShaElValRepByNumber(guint16, guint16)
2880 - GetShaElValRepByName(string)
2881 - GetShaElValByNumber(guint16, guint16)
2882 - GetShaElValRepByName(string)
2883 - GetElValRepByNumber(guint16, guint16)
2884 - GetElValRepByName(string)
2885 - GetElValByNumber(guint16, guint16)
2886 - GetElValRepByName(string)
2887 * Doc/requirements.txt added.
2889 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2890 * Test/Makefile building now depends on the one of libgdcm.so
2891 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2892 pixel data) aware which enables finding the address (offset) of
2893 the pixel data of JPEG encoded DICOM files. This leaves only a single
2894 file in the testSuite whose pixel data address (offset) is unknown.
2895 * python/testSuite.py changed accordingly.
2897 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2898 * VC++ has some strong limitations when working with the STL, as stated
2899 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2900 "Also note that some STL containers (map, set, queue, list, deque)
2901 cannot be exported. [...]
2902 Some STL classes contain nested classes. These classes can not
2904 This is caused by a designed limitation that once a template
2905 class is instantiated, it can not be re-instantiated and
2907 Since our usage of map<> is ubiquitous in gdcm, this "designed
2908 limitation" of VC++ is a pitfall.
2909 Hence the Python wrappers of gdcm cannot be incrementally linked
2910 against the c++ dynamic library. The dirty but only workaround is
2911 to forget about incremental link of dynamic libraries and to generate
2912 the Python wrappers library with the inclusions of the underlying C++
2914 The following modifications concern this matter on Win32/VC++:
2915 - wrapping python correct with standalone wrapped dll (don't use separate
2916 dll under windows !!!!)
2917 - python21_d debug mode enabled (ask Frog how to use it :-)
2918 - NO problem with having an STL member of class for example string in C++
2919 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2920 - Python test of dcmlib in Python is ok under windows on a large set
2922 * removed glib references
2923 * typedef's inserted in gdcm.i for correct swig type management
2925 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * python/demo/*.py load.py extracted from test.py. Added explore.py
2927 that only displays required tags and testAll.py that parses all
2928 the files of the testsuite without using unittest.
2929 * python/testSuite.py other additional test on new files added.
2930 * Data/* new test files added accordingly to the testSuite.
2931 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2932 the vr in the file differs from the one of the dictionary.
2934 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2936 values, but limits itself to values which are below a user specified
2937 size (by default 1024 bytes).
2938 * python/gdcm.i : elements not loaded (because their size is above the
2939 user specified treshold) are exported with their TagKey as key of the
2940 python dictionary. This enables the testsuite to make some checks
2941 on the unloaded elements (since we have their offset and size).
2942 * python/testSuite.py
2943 - now tests for the existence and proper value of the pixel data
2944 - two new examples added.
2945 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2947 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2949 aware. See the strategy comments in gdcmHeader::FindeLength().
2950 * Test/test.cxx now accepts a filename as first argument.
2951 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2952 * python/testSuite.py changed to integrate test on above files.
2954 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2956 the vr was also RET.
2957 * python/testSuite.py more tests added.
2959 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * python/testSuite.py unittest test suite added (uses Data)
2961 * Data/* dcm and acr files for the test suite.
2962 * glib dependance removed from un*x version. We now use ISO C99
2963 7.18 Integer types (see stdint.h)
2964 - python/Makefile, src/Makefile src/gdcm.h
2965 * src/ when an explicit vr (like dicom files) suddenly poped an
2966 implicit element we use to mark the underlying DictEntry of the
2967 concerned ElValue with "Implicit". This strategy was damageable
2968 too the public or provite dictionaries, since some of their vr
2969 would be changed. Since Header::FindLength heavily relies on the
2970 detection by Header::FindVR of falsely explicit elements, I
2971 added an extra ImplicitVr member to ElValue (boolean).
2972 The rest of the changes we the necessary adaptations.
2974 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2977 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2979 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2980 * Adaptation for porting to VC++:
2982 o forced to use std namespace (for string to be known)
2983 o all class use __declspec export style on WIN32
2984 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2985 (in stdlib.h on Win32 but in std:: for gcc)
2986 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2987 variable GDCM_DICT_PATH.
2988 * src/gdcmHeader.cxx verbose comments made discrete.
2990 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2991 * python/gdcm.i: added a typemap that converts a C++ hashing table
2992 to native Python dictionary.
2993 * python/demo/test.py:
2994 - now uses the native dictionary for exploration of gdcmHeader.
2995 - takes an optional filename argument (the file to parse).
2996 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2997 PubElVals hashing table.
2998 * Dicts/dicomV3.dic removed error prone trailing spaces.
3000 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3001 * Python wrapping process moved away from src/Makefile to
3002 newly created python/Makefile (as well as gdcm.i)
3003 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3004 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3005 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3006 from the environement variable GDCM_DICT_PATH (when existing).
3007 * src/gdcmDict::GetTag bug fix.
3009 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3010 * Straightforward temporary fixes for swig to build the python wrappers.
3011 src/Makefile now has a python working entry [by working we mean
3012 that we can import de shadow classes without errors].
3014 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * hashtest.cxx removed (since already in Test)
3016 * src/gdcmlib.h renamed to src/gdcm.h
3017 * src/dcm.i renamed to src/gdcm.i
3018 * src/Makefile prepared for python wrapping
3020 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3021 * src/gdcmHeader.cxx :
3022 - Parsing of header is now separated from loading of element values
3023 (see gdcmHeader::LoadElements).
3024 - general clean up of hopefully all file access (creation of
3025 ReadInt16 and ReadInt32)
3027 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * src/gdcmHeader.cxx :
3029 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3031 - SetLgrElem renamed to SetLength
3032 - GetLgrElem renamed to GetLength
3033 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3034 * src/gdcmElValSet.cxx fixed both GetElValue methods
3035 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3036 due to IdoDude was cleaned out.
3038 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3040 concentrates on finding the value representation (when it exists).
3041 RecupLgr now only finds the element value length, and it avoids
3042 returning the unecessary skL (skipped length).
3043 Also, offsetCourant was simply removed (with taille_fich) since
3044 it was redundant with the File position internals (by using
3045 ftell and fseek). This also made skL (see above in RecupLgr) usage
3047 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3048 on the libido specificities which are handled through class
3050 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3053 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * Truckload of changes. Parsing of header is barely functional
3055 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3057 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * src/gdcmHeader.cxx many addons of low level methods
3060 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3062 and _IdDcmSWAP_LONG.
3064 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * This corresponds to all the changes decided at the meeting of
3066 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob