2 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
3 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
4 Big Endian Transfer Syntax supposed the group following 0002
5 begins always by element 0000 (element 0000 is *optional*)
6 To avoid further troubles, let's be pessimistic, and use
7 Document::HandleOutOfGroup0002() method
8 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
9 (related pb not yet solved)
11 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Bug fix for the python part use
13 * Now, PrintHeader.py pass... but outside the ctest use. shit !
15 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
18 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
20 a string and should ask the global TS dict what are the propreties of
23 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
24 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
25 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
26 to swap the Swap Code, at parsing time, when we come out of group 0002
27 and Transfer Syntax is Big Endian
28 We should be able to read now 'true DICOM" Big Endian coded images
29 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
30 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
32 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
33 * Hopefully fix the bug on MacOSX and static global initialization.
34 This is the only -minor- patch I found that both please MacOSX and VS6.
35 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
36 but this would require a lot of change. Another approach would be that Global
37 create those string and GDCM_UNFOUND becomes a pointer to a string (which
38 gdcm::Global would destroy at exit).
40 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Fix bug on MacOSX with static initialization in a multy threaded
42 environment. static const string in a header file used to be ill
43 initialized provoquing the freeze of any tests. patch should solve this
46 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
47 * According to Benoit's suggestion, and without any objection from anybody
48 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
49 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
50 - method gdcmDicomDirObject::GetEntry() renamed as
51 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
53 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
55 you debug/warning message just as c++ streams which make them very convinient
56 to use. Once this is stabilize I will change the ostringstrem to be
57 redirected to a file (ofstream).
58 * Properly support C99 extension: __FUNCTION__ which allow us to display
59 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
61 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
62 * Removal of useless and dangerous methods :
63 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
64 GetDocEntryByName, GetEntryByName, GetDictEntryByName
65 * Removal of usless methods :
66 Dict::PrintByName, Dict::GetDictEntryByName
67 * Commenting out of probabely useless methods :
68 Dict::GetDictEntryNames()
69 Dict::GetDictEntryNamesByCategory()
70 DictSet::GetPubDictEntryNames()
71 DictSet::GetPubDictEntryNamesByCategory()
72 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
73 * ENH : Use dicomTS.dic as described in 2004 version
74 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
75 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
76 Add Accessors on VM (Value Multiplicity), and VM related methods
77 * ADD : Add a list of 'Dicom Attribute types', as found in
78 http://medical.nema.org/dicom/2004/04_15PU.PDF
80 * ADD : Add dicomGroupNameAbbreviations.dic
81 should be used to write a method to replace the former
82 Dict::GetDictEntryNamesByCategory()
84 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
86 to read in the file... and only it ! Length is the efective length of the
87 data in the DocEntry structure
89 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
91 And now use a static function call instead, with a global variable. i
92 This is much closer to the VTK approach. Hopefully should be bulletproof
93 and easier to use...hopefully
95 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
98 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
101 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
103 ValEntry, BinEntry, SeqEntry creation or replace
105 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
107 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
109 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
110 when specifying the VR
111 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
112 * src/gdcmDocEntry.cxx : amelioration of print
114 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
115 * ADD : Add the method Util::IsCurrentProcessorBigEndian
116 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
117 * ADD Method Document::ComputeGroupLength
118 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
119 in order to allow further VR modification by user
120 * REM : removal of once-called method File::WriteBase
121 integration of its code in formerly one-line method File::Write
123 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
125 replace the different values "??", "Unkn", "Unknown".
126 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
127 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
128 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
129 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
131 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
134 * Set the gdcm::Base class to some Printable classes
136 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmFile.[h|cxx] : add the Print method
138 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
139 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
140 * src/gdcmDocument.h : remove the PrintLevel informations
141 * Example/PrintFile.cxx : use the new gdcm::File::Print
143 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
145 problems when compiling with the python wrapping
147 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
149 writting in ImplicitVR
151 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
152 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
153 JPEG decompression, especially when dicom frames are split into several
154 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
155 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
157 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * src/gdcmHeader.cxx : change the initialisation of default header.
159 Now, this header is readable by gdm, e-film, DicomWorks
161 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
163 Rename Decompressed to Raw
164 * Use the API changes in gdcm::File.
165 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
168 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
170 each added entry in the header. Replace the 'Planes' field by the 'Number
173 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
175 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
177 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
179 At this time, this image isn't readable by e-film... waiting JPR help to
182 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
184 DocEntry. Now use methods of the Document !
186 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * Test/ShowDicomSeq.cxx : bug fix
189 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
191 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
192 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
193 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
195 * Test/TestCopyRescaleDicom.cxx : remove unused variable
196 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
197 containing found sequences
199 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
202 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
203 Some fields in BinEntry must be copied to not seg fault when making the :
204 gdcm::File *copy = new gdcm::File( copyH );
205 and tests are now made on good variables
207 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
209 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
211 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
212 * Add vtkGdcmWriter example and test
214 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * Test/TestUtil.cxx : reformat the source code
216 * vtk/vtkGdcmReader.cxx : remove and change prints
217 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
219 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
220 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
222 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
224 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
226 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
228 by an eof to prevent all bad read of the file... and in this case, the
231 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * Example/Volume2Dicom.cxx : comment unused variables
233 * Test/PrintDicomDir.cxx : comment unused variables
234 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
235 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
236 method that is redondant with AddEntry.
237 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
240 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * Bug fix due my last commit (compilation under Windows).
242 * Example/Volume2Dicom : bug fix in the file and reformatting source code
243 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
245 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 - Remove printf / sprintf
248 - include iostream AFTER gdcm so we don't get warnings
249 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
251 - Also remove tons of include from header files, hopefully this should
252 speeup the compilation time, since it was becoming a dog slow.
253 - Remove gdcm.h as it include way too many files and slow down compilation
254 (plus it is not up to date)
255 - remove 'using namespace std' this is BAD !
257 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * Remove memory leaks on the DicomDir
259 * Remove some useless data in DicomDirObject
260 * Add usefull methods in SQItem, to be complient withe the ElementSet
262 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
265 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
267 future, with convertion)
268 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
269 and ImageDataSize values. Remove the method to get the PixelReadConverter
270 from the output of the class
272 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
275 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
277 and vtkErrorMacro use.
278 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
280 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
283 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
284 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
285 The string leaves only in the fonction. So when we make a .c_str(), we
286 get the pointeur on the first element, element that will be destroyed
287 immediately after thee instruction.
288 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
289 file has been opened : the test must be made on the content of the
290 pointer and not directly on the pointer !
293 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
295 the python part recompiles
297 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
299 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
300 X session is killed (for my computer... it seems to not be identic on
303 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
305 avoid problems (otherwise, the difference test between the visible image
306 and the reference is incorrect. If the reference is greater than the
307 screen resolution, it's produce errors).
308 Can be used for only one image. Can be used with a visible flag.
309 * vtk/vtkGdcmReader.cxx : remove commented codes.
310 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
311 under windows at compilation
312 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
314 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
316 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
318 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
319 tests on the image size X, Y, Z
321 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
323 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
324 between the class name and the file name
326 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * src/ : fix compilation warnings for the Write method (2 different
328 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
329 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
330 variable... create a static method in gdcm::Document to access to
331 this variable content.
333 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
335 file, to be accessed by other files (like gdcmFile). Remove commented
336 code. Move the change of the header to the gdcmFile, using the
338 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
339 To be sure of that (and simplify calls), the Write of the header now
340 gets a file name and not a file pointer (std::ifstream).
341 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
342 DocEntryArchive. Remove all open of the written file
344 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
347 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
349 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
351 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
352 some corresponding methods. Write correctly the file and check before
354 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
355 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
356 is now on RGB data (as before my last commit
357 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
359 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
361 Add a print information of the type of the entry
362 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
363 It was in the gdcmFile, and all write have been regrouped
364 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
365 Write correctly all dicom files (in decompressed mode only at this time)
366 * Test/ : test on files are now made using Raw data and not color data if
368 * Example/PrintFile.cxx : add more printings
370 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * Amelioration of code, remove some code copy. For the loading of
372 BinEntry (in gdcmDocument), add the test to verify if the file is already
375 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
377 remove a DocEntry in the header (push an empty DocEntry)
378 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
379 lines. Bug fix in the initialization of the PixelConvert and the
381 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
382 use in TestCopyDicom (now this test can run under windows... but fails)
383 * Test/TestCopyDicom.cxx : amelioration of the test :
384 - test the pixels written
385 - add test points to quickly find where is the error
386 - can set a file name input and output in arguments
387 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
388 amelioration of the test output
390 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
392 all replaced DocEntry's
393 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
394 Now, each needed DocEntry to modify is duplicated, modified and inserted
395 to the header using DocEntryArchive. Thus, after save, we can restore the
396 header initial state.
398 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
401 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
403 correct to copy it. The DictEntry is specified at the DocEntry creation,
404 then, it musn't change in the time.
405 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
406 header correctly. At this time, the change is only made for the first
407 level of the Document. In the future, it might consider sequences.
408 The change is made by replacing a DocEntry by an other that is created
409 outside the class. The old value is kept. When we restore the header
410 status, the added DocEntry is deleted and replaced by the old value.
411 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
412 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
413 set the write type to explicit VR, implicit VR or ACR. Add methods to set
414 the write mode to native, decompressed or RGB (but not used at this time)
416 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
418 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
420 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
422 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
424 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
425 set because already copied when copying the BinEntry's of the header
426 * Test/TestAllReadCompareDicom.cxx : remove warnings
428 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
430 Two problems appear when doing it :
431 - with the gdcmFile : when the GetImageData method is called, the pixels
432 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
433 data (pixels). And each structure destruct the data when it's
434 destructed. So we have two destructions for the same data. To solve it,
435 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
436 data or not. If it doesn't own data, then they will not destroyed by
438 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
439 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
440 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
441 create a double destruction of the same DocEntry's. So, to solve it,
442 the TagHT is simply cleared and the DicomDir* elements are destroyed.
443 * TODO : add an entry concerning memory leaks in the DicomDir
445 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
447 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
450 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
452 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
453 after it have been deleted
455 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
456 * FIX: src/* fix the doxygen warnings.
457 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
458 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
459 was erroneously defined with a size of 15 instead of 16. [many thanks
460 to Jean Michel Rouet for pointing out this bug].
462 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
463 1. Finish merging JMR patch for writting DICOM from scratch
464 2. Fix -hopefully- bug with MONOCHROME and space vs null character
465 3. Use const ref when possible
466 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
467 5. A few more comments
468 6. CreateUniqueUID can now be called without parameter"
470 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 * ENH: Slightly bigger patch:
472 1. Getting toward full integration of JMR patch for writting dicom from scratch
473 2. Update Test to test part of this patch: CreateUniqueUID
474 3. File was not close properly in gdcmDict
475 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
476 5. Use of const ref instead of copy (speed issue)
477 6. Remove temporary (duplicate) string in TranslateToKey
478 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
479 8. Do not repeat virtual in subclasses
480 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
482 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Apply first patch toward better string comparison when dealing with broken
484 DICOM files. Essentially the string could be padded with a space instead
485 of a null character as defined by standard
487 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
489 because never used... and in the same time, that's remove some memory leaks
491 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmFile.cxx : now delete the PixelConvert instance.
493 * In examples and tests : change the type of image data variables from void*
494 to uint8_t*. Remmove all delete on image data variables
496 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
498 Verify the file pointer value before open the file, and if it's not null,
499 a verbose message is generated.
500 Close correctly the file when the file isn't considered dicom-like. The
501 correctly close is a call to CloseFile.
502 When closing the file pointer, test if its not null to close the file.
503 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
504 file. For an uncompressed image, the copied data correspond in the least
505 case to the image size (calculated) or the image size specified in the
506 header. A verbose is generated if these two size mismatch
508 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
510 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
511 break under windows (with msvc6 compilation).
513 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
515 compiling with MSVC6)
517 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * Bugs fix for the Windows build with VC6
519 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
520 needed (only for projects required VTK). If the VTK is included in all
521 projects, there is conflicts with the jpeg lib of vtk when compiling the
522 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
523 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
524 when compiling the gdcm_wrap.cxx file (created by the compilation of the
526 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
527 (like it's already made for the cout use). Otherwise, conflict with the
530 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
533 - comments on the DicomDir::Method related usage added.
534 - now that we use the namespace gdcm, a lot of internal classes do
535 NOT need to be wrapped anymore.
536 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
537 DicomDir::Method) new example added.
539 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
540 * Improve string manipulation. I now inforce the notion of 'DicomString'
541 A DicomString can contain as many \0 as they want
542 and it is *always* of even length.
543 We only support odd length for very rare case.
544 And in the near future this should be removed.
546 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * /binary_write/ gdcm source. Now even on big endian we are writting
548 little endian. This should -heopfully- fix some tests
550 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
551 * Now the dictionary is compiled into gdcm lib. This is a default
552 behavior, thus any dic file specified is picked before failback to
553 the one comiled into lib
555 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
556 * Change internals for gdcmDict. Don't use any 'new' any more.
557 This should definitely solve any leak problem, and we should be
558 as fast as before, as long as don't modify too much the dictionary.
560 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
561 * STYLE: ivars should start with a capital letter.
562 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
563 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
565 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
567 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
568 new 2004 dictionaries added (thanks to JPR).
569 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
570 * CLEANUP_ROUND (15) for gdcmPixelConvert
571 - RLEFrame::NumberFragments is now of type unsigned int
572 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
573 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
576 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
577 * Initial work in gathering all transfer syntax accessors. clearly
578 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
579 ivars, but only one transfersyntax (class) ivar with equivalent method on
582 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
583 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
584 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
585 discussed (plus I didn't like having a 2000 lines patch not commited)
587 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
589 * CLEANUP_ROUND (14) for gdcmPixelConvert
590 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
591 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
592 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
594 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
595 anymore and hence avoids storing a copy of PixelConvert::Decompressed
596 into File::Pixel_Data.
598 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
600 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
601 * CLEANUP_ROUND (13) for gdcmPixelConvert
602 Substituted File::ParsePixelData() with PixelConvert::Print() new
604 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
605 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
606 method to those classes.
607 - src/gdcmFile.[cxx|h]:
608 -- Added a ::Print() method.
609 -- PixelConverter is now a reference instead of a member.
610 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
611 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
613 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
614 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
615 collaboration diagram and inheritance diagram should be generated with
617 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
618 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
619 pointlessly wrapped (see
620 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
621 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
622 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
623 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
624 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
625 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
626 -- File::Initialise: PixelConverter setup moved away to
627 PixelConverter::GrabInformationsFromHeader()
628 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
629 interpretation moved away to PixelConverter::BuildRGBImage()
631 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
632 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
633 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
635 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
637 displayed on Win32 when a brutal abort() occurs (because of uncatched
638 exception). See TODO new entry of this commit for more on this.
639 * TODO added new entry.
640 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
641 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
642 - HandleColor is no longer called from gdcmFile.cxx
643 - gdcmPixelConvert.cxx clean up on method arguments and internal
644 variable names for semantical coherence.
646 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
647 * Finished lossless transition, not only do we now read all lossless jpeg
648 images, without the need of the Cornwell lib, but we do read them properly now
649 * To reduce code (well to avoid code duplication), I defined a common place
650 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
651 redefine symbols. This is not perfect but this the best solution I found for a
652 compilation time jpeg option.
654 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
655 * Update jpeg ijg lib to support lossless jpeg implementation
656 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
658 * Also added a special copyright for dcmtk since we use their bugfixes.
661 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
663 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
664 matters, as stated in warning note at begining of %include section).
665 * src/gdcmDicomDir*.[cxx|h]: coding style
666 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
667 * src/gdcmJpeg8.cxx: doxygen fix.
668 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
669 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
670 from File:: to PixelConvert::.
672 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
674 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
675 - more code moved away from File:: to PixelConvert::
676 - fat setup of PixelConverter set in place in File::Initialise.
678 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
679 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
680 namespace at the file system level. So now you should convert your examples
682 gdcmHeader -> gdcm::Header
683 It would be nice if people keep in mind to no open the namespace, since it
684 allows compilation on broken plateform which were defining common symbol in
685 the standart namespace (like LP, Unknown ...)
687 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
689 The JPEG fragments are now parsed at the same stage than the RLE
690 information. All code related to JPEG is now in gdcmPixelConvert:
691 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
692 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
693 export a gdcmFile:: method. Those are simply global functions
694 (for the time being this is better than having them attach to
695 either gdcmFile:: or gdcmPixelConvert::).
696 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
697 and stores the result in a gdcmJPEGFragmentsInfo.
698 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
699 code (among other stuff) moved away from gdcmFile:; to
702 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
704 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
705 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
706 clean up of RLE related code.
707 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
708 - src/gdcmRLE.cxx removed
709 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
710 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
711 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
712 * CLEANUP_ROUND (9) for gdcmPixelConvert
713 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
714 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
715 away from gdcmFile:: to gdcmPixelConvert::.
717 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
719 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
720 This is because Parse7Fe0 used to parse the pixels to compute the
721 length. This task was passed over to FindDocEntryLengthOB() a long
722 time ago, EXCEPT I had forgotten the OW case...
723 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
724 we just recylce the code for parsing RLE fragments and computing
726 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
727 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
728 with the retired Parse7Fe0().
729 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
730 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
732 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
733 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
734 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
735 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
736 - src/CMakeLists.txt: alphabetic order reodering + new entries.
737 * CLEANUP_ROUND (4) for gdcmPixelConvert
738 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
739 to return an unused length.
741 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
742 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
743 this should be cleanner from the plane view. The iostream are erally a pain
744 to use to do simple stuff.
746 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
747 * Redo the compilation of the ijg jpeg library. Now only one source is
748 necesseray. No need to rename file by hand what so ever. CMake handle the
749 copying of the file within different directory, configure header file to
750 modify some symbol. The only addition made to ijg wasd a mangle table so
751 that symbol are different wether we are within 8bits or 12bits.
753 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
754 * Added documentation of vtkgdcmReader on Website:
755 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
756 with it's binary name).
757 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
758 the Website to be more complete.
759 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
760 doxygenated documentation.
761 - Doc/DoxyVtkGdcmReaderExamples.txt added
762 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
763 DoxyVtkGdmReaderExamples.html )
764 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
765 * CLEANUP_ROUND (3) for gdcmPixelConvert
766 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
768 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
769 * CLEANUP_ROUND (2) for gdcmPixelConvert
770 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
772 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * CLEANUP_ROUND for gdcmPixelConvert:
774 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
775 - src/gdcmPixelStuff[h|cxx] removed
776 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
777 - src/CMakeLists.txt changed accordingly
779 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
780 gdcmVersion.py moved to newly created ATTIC related
781 gdcmPython/SetupOldies/ directory.
782 * Autotools clean up:
783 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
784 - autogen.sh configure.in acinclude.m4 python.m4 removed
786 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * src/*.cxx *.h Reference to License.htm fixed to License.html.
788 * Doc/CMakeLists.txt, doxygen.config.in: fix.
789 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
791 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
792 * TODO updated with Mathieu suggestions. I proposed a template for
793 describing TODO entries and used it for new entries.
794 * Added Doc/Website/CodingStyle.html, Developpers.html,
795 DeveloppersPython.html, GdcmDataCvs.html and
796 DownloadVersion0_1.html, DownloadVersion0_3.html.
797 * Some Doc/*.txt Doxygen files (which do not really concern the
798 documentation itself, but the website) moved to html and
799 placed in directory Doc/Website:
800 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
801 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
802 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
803 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
804 * CMakeLists.txt changed accordingly.
805 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
806 DeveloppersPython.html
807 * INSTALL nows refers to Doc/Website/Installation.html
809 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * Added Doc/Website directory, that contains a first raw version
813 2004-09-23 Jean-Pierre Roux
814 * FIX In order not to be poluted any longer by casting problems,
815 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
816 we can now delete[] it safely
817 * VoidArea is now called BinArea (less confusing name),
818 and all the methods called ...VoidArea... are now ... BinArea...
819 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
821 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
822 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
823 clear) TagHT, which is an inherited member of gdcmElementSet. It is
824 up to the destructor of gdcmElementSet to clean up TagHt and it's
827 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * Test/CMakeLists.txt: update to follow gdcmData renamings.
829 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
831 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
832 * ENH: added some utility method that builds a flat dictionnary
833 holding all the Dicom entries contained in the recursive structure
834 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
836 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
837 BuildFlatHashTable() that build a flat dictionary.
838 - src/gdcmElementSet.h: added a new private GetTag() accessor.
839 gdcmDocument is now a friend of gdcmElementSet.
840 - src/gdcmElementSet.cxx: clean up.
841 - Example/FlatHashTablePrint.cxx added.
842 - Example/CmakeLists.txt changed accordingly
844 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
846 moved away from gdcmDocEntrySet (since this class is an abstract class
847 acting like an interface). SQDepthLevel and BaseTagKey are now
849 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
850 and associated accessors. Doxygenation of the class.
851 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
853 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
854 Use SQDepthLevel accessor instead. ::Print() adapted.
855 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
856 - src/gdcmDocument.cxx changed accordingly.
858 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
860 - The following is the doxygen comment of the typedef declaration
861 of gdcmagKey in src/gdcmCommon.h:
862 gdcmTagKey is made to old an "universal" (as in URL, Universal
863 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
864 A dicom tag allways has a group and an element, but a set of tags
865 embeded in various (optionally nested) sequences and sharing
866 the same group and element all share the same (group, element)
867 "identifier". Hence the (group, element) cannot be used as an
868 identifier (in gdcm we shall refer to a "TagKey") of a tag.
869 In order to construct a proper tag identifier (i.e. a key) we
870 consider the following definition of a TagKey:
871 - let Group, Element be the string representation of the
872 group and element dicom tag members,
873 - let ItemNumber be the string representation of the integer
874 index of the considered item number of a sequence,
875 Let the key of a tag embeded in a sequence, noted SeqTag, be
877 /ItemNumber#Group|Element
878 where "/", "#" and "|" are characters acting as separators.
879 Then the general form of a gdcmTagKey is given by:
880 Group|Element<SeqTag>
881 where <SeqTag> means NO or many instances of SeqTag.
882 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
885 but the gdcmTagKey of a tag "embeded" is the first item of
886 a sequence, itself nested in the third item of a sequence is the
888 0004|1220/2#0008|0082/0#0008|0090
889 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
890 order to hold the new sequence compatible key. Previously, the
891 GetKey() method would look in the underlying gdcmDictEntry.
892 - src/gdcmDocEntry.cxx:
893 -- constructor now copies the underlying DictEntry key, in the local
895 -- ::Print: displays the member Key, instead of the (group, element).
896 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
897 - src/gdcmDocEntrySet.h:xi
898 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
899 -- now has a new BaseTagKey member.
901 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
902 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
904 This poses the problem with the semantics of the following lines
905 LoadEntryVoidArea(0x0028,0x1201); // R LUT
906 LoadEntryVoidArea(0x0028,0x1202); // G LUT
907 LoadEntryVoidArea(0x0028,0x1203); // B LUT
908 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
909 to the long FIXME note for what the problem is. Nevertheless in
910 order to get things working the dicom dictionary was altered !
911 Please fix things urgently...
912 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
913 information), see above note on moving the member VoidArea. Nevertheless
914 the following entries previously correctly set as US are now inproperly
916 0028 1201 OW IMG Red Palette Color Lookup Table Data
917 0028 1202 OW IMG Green Palette Color Lookup Table Data
918 0028 1203 OW IMG Blue Palette Color Lookup Table Data
919 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
920 of gdcmDocEntry moved to gdcmSeqEntry.
921 * src/gdcmSeqEntry.cxx: STYLE.
923 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
924 * Test/TestAllEntryVerify.cxx minor fix and added comments.
926 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
927 * gdcmPython/testSuite.py: all the test suite in python is now moved
928 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
929 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
930 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
932 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
934 to avoid inclusion recursion until STL is reached.
935 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
936 mecanism. errno.h is not included in gdcm anymore.
937 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
938 (gdcmFormatError now inherits from gdcmFormatUnexpected).
940 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
941 gdcmData/TestAllEntryVerifyReference.txt
942 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
943 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
944 exception_on_error parameter.
945 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
946 - vtk/vtkGdcmReader.cxx changed accordingly,
947 - Example/*.cxx and Test/*.cxx changed accordingly.
949 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
951 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
952 enable_sequences removed from gdcmHeader constructor and dependencies.
953 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
954 * gdcmPython/demo/PrintHeader.py: dummy fix.
955 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
956 skip_shadow removed from gdcmHeader constructor and dependencies.
957 * Example/*.cxx and Test/*.cxx changed accordingly.
959 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
961 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
963 2004-07-21 Jean-Pierre Roux
964 * FIX Now, Parsing and Printing a DICOMDIR do work!
965 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
967 2004-07-20 Jean-Pierre Roux
968 * FIX Some brain damaged headers have Zero-Lenght fields
969 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
971 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
972 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
973 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
974 variable (instance of gdcmDebug) by a definition macro, and the instance
975 is now in static in the gdcmDebug class
976 * src/gdcmSQItem.h : (FIXME) remove an undefined method
977 * Test/PrintAllDocument.cxx : bug fix in the result of the test
979 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * WARNING: ctest now depends more tightly on gdcmData. You should
981 check out gdcmData properly for things to run smoothly...
982 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
983 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
984 we need the pixels not be loaded in order to use the ValEntry
985 that displays position and size).
986 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
987 This is a C++ based equivalent of gdcmPython/testSuite.py that should
988 be deprecated. If you have any doubts about the advantages of a
989 modern scripting language (read Python) versus grass root C++ (i.e.
990 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
991 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
992 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
993 Anyhow, consider documenting the gdcmData images in
994 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
996 * Test/CMakeLists.txt:
997 - now uses TestAllEntryVerify.cxx
998 - specific comments on oldACR00001.ima (now renamed in gdcmData
999 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1000 gdcmData/TestAllEntryVerifyReference.txt
1003 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * src/*.[h|cxx] : typedef clean up
1005 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1006 - TagKey renamed to gdcmTagKey (for external usage)
1007 - VRKey renamed to gdcmVRKey (for external usage)
1008 - removal of typedef duplication.
1009 - Removed all unecessary inline keyword from class inline definitions.
1010 - Some method|function(void) declarations replaced with method|function().
1011 * src/jpeg/libijg12/jdhuff12.c:
1012 - printf polluting ctest removed.
1013 - TAB removal for comminting
1015 - TestAllReadCompareDicom.cxx: added a test that compares all the
1016 images in gdcmDataImages.h with corresponding images in
1017 gdcmData/BaselineDicom/. When baseline images are not present
1018 this test creates them.
1019 Note: we need to validate each reference image, but before that
1020 I'd like to rename them with a more explicit name...
1021 - CMakeLists.txt: changed accordingly.
1022 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1023 including each header needed).
1025 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1027 test suite to the Example directory. Are concerned:
1032 - TestWriteSimple.cxx
1033 * Test/CMakeLists.txt: added some comments on reasons for black listing
1034 image gdcmData/oldACR00001.ima
1036 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * Test/CmakeList.txt: removed the following from black list (to be coherent
1038 with removal from gdcmData):
1039 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1040 - gdcm-MR-PHILIPS-16.dcm
1042 Added the following because after last cvs update, they cause
1043 ctest -R TestReadWriteReadCompare
1045 - gdcm-MR-SIEMENS-16-1.acr
1047 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1048 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1049 new comments in this file) we temporarily (sigh) move to a weaker
1051 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1052 we don't need to black list the following images anymore:
1053 - 8BitsUncompressedColor.dcm
1055 - US-PAL-8-10x-echo.dcm
1056 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1057 fixes and the beautified code ;-)
1058 This fixes the bug introduced in version 1.42 (when beautifying)
1059 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1060 Note: ctest was blind to this bug (this means we need to still
1061 improve the test suite). The bug could be detected by using
1062 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1064 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1065 and by displaying the (garbage) produced file temp.XDCM...
1067 2004-06-29 Jean-Pierre Roux
1068 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1069 - replace by uggly but working old code :-(
1070 A lot of things should be OK again.
1071 It's really urgent to have a test suite that *tests*,
1072 to prevent Frog's beautifying sessions to break all the stuff
1073 (twice, withing a fortnigh ...)
1075 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1077 redundancy) to added Test/TestReadWriteReadCompare.cxx
1078 * Test/CmakeList.txt: because the compare test of
1079 Test/TestReadWriteReadCompare.cxx fails, the following images are
1080 black listed: - 8BitsUncompressedColor.dcm
1082 - US-PAL-8-10x-echo.dcm
1083 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1084 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1085 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1086 and ad-hoc kludge. This kludge is now removed, and on encountering
1087 such an image (OB field brain damaged) we set errno. Then in
1088 ::FindDocLength() we "fix" the length as being ALL what remains
1089 in the file (until EOF). We then proceed, hoping for the best...
1090 This fixes a SegFault in ShowDicom when trying to write such an
1092 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1093 (because TestWriteRead breaks on it, after a non conformal commit?).
1094 ctest now runs properly, except for MakeDicomDir (which was allways
1095 broken) and the Python related stuff (still not fixed).
1097 2004-06-24 Jean-Pierre Roux
1098 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1099 FIX : Test/TestReadWrite now iterates on all the file names
1100 (instead of infinite loop)
1101 ENH : Test/TestWriteRead now iterates on all the file names
1103 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1106 2004-06-24 Jean-Pierre Roux
1107 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1108 when SamplesPerPixel =3
1109 - now Write is no longer confused by
1110 'BitsAllocated = 12" and 'BitsStored=12"
1111 - "UN" value representation Elements are now written correctly
1112 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1113 ENH : - now gdcmHeader has its own Write methods
1114 (in order to split the job that has not to be done
1117 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1119 loop on the same image until memory went out.
1120 Note: this means we still have gobs of memory loss in PrintDocument
1121 * src/gdcmDocument.cxx: fixes problem on parsing on file
1122 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1124 2004-06-24 Jean-Pierre Roux
1125 FIX : Write - All the Sequences and Sequence Item are now written
1126 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1127 is added a the end, when necessary.
1128 - A lot of brain-damaged images, that were read correctly are
1129 now written correctly
1130 - length compatible BinEntry are now loaded correctly
1131 (even for odd groups)
1132 Note : only Explicit Value Representation was checked.
1133 (question : is implicit VR really necessary for gdcm ?)
1135 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * DEVELOPPER: added a proposition of coding style.
1137 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1140 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1141 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1142 Use the gdcmDocEntry::Print() and Write() instead.
1143 * src/gdcmDocument.cxx: bug fix.
1145 2004-06-22 Jean-Pierre Roux
1146 FIX : gdcmDocument.cxx
1147 - Now we do recognize the JpegLossLess format (there was a misstyping in
1148 code 'beautyfication' :-(
1149 - Now we automaticaticaly load the Luts, if any
1151 2004-06-22 Jean-Pierre Roux
1152 In order : to write Sequences, whatever their imbrication level,
1153 : to allow user to create his own Sequences
1154 a lot of modif where necessary (adding, moving, or virtualising methods)
1156 WARNING : save your own sources *before* cvs up !
1159 ADD virtual void Write(FILE *fp, FileType filetype);
1162 ADD virtual void Write(FILE *fp, FileType filetype);
1163 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1166 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1167 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1168 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1169 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1170 ADD std::string GetEntryByName(TagName name);
1171 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1173 std::string vr = "unkn",
1174 std::string fourth = "unkn",
1175 std::string name = "unkn");
1176 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1177 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1178 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1179 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1180 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1181 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1182 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1183 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1186 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1187 ADD virtual std::string GetEntryByName (TagName tagName);
1188 ADD virtual std::string GetEntryVRByName (TagName tagName);
1189 REM virtual bool Write(FILE *, FileType);
1190 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1191 FILE *_fp, FileType type);
1192 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1193 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1194 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1195 REM virtual std::string GetEntryByName (std::string tagName);
1196 REM virtual std::string GetEntryVRByName (std::string tagName);
1197 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1198 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1199 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1201 std::string vr = "unkn",
1202 std::string fourth = "unkn",
1203 std::string name = "unkn");
1204 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1205 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1206 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1207 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1210 ADD virtual void Write(FILE *fp, FileType filetype);
1213 ADD virtual void Write(FILE *fp,FileType filetype);
1216 ADD virtual void Write(FILE *fp, FileType filetype);
1217 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1218 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1219 REM std::string GetEntryByName(TagName name);
1222 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1224 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1226 The default constructor invoked by the line
1227 gdcmHeader *f1 = new gdcmHeader( header );
1228 was gdcmHeader::gdcmHeader(bool) instead of the expected
1229 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1230 Hence the parsing wasn't executed... See also below.
1231 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1232 as explicit constructor didn't do the trick to fix the above problem.
1233 Could anyone explain why ?
1234 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1235 properly calls gdcmValEntry::Print() (that was weed out from
1236 code related to gdcmBinEntry).
1238 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * In order to fix memory leaks:
1240 - Test/TestWriteSimple.cxx: added cleaning of free store through
1242 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1243 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1244 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1245 (through the call to ::AddDicomDirMeta()) or the destructor
1246 would crash when deleting uninitialized ::metaElems].
1247 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1248 - src/gdcmDocument.cxx:
1249 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1250 from dynamic stores.
1251 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1252 was causing memory leaks.
1253 - src/gdcmSQItem.cxx:
1254 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1255 cleanly handled with polymophism: sorry but my milage is low).
1256 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1257 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1258 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1259 This avoids SegFaulting.
1260 - src/gdcmSQItem.h: coding style.
1262 - Test/TestWriteSimple still severely sucks. The output image content
1263 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1264 damaged when displayed with vtkgdcmViewer.
1265 - on memory leaks: TestWriteSimple leaks really less (see entry
1266 of 2004-06-18 in Changelog file for the call to valgrind).
1267 - on segfaults: ctest now passes all the tests but one (no more
1269 * Erroneous leading white fix:
1270 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1271 white[s] (as opposed to from >> xxx, that removes it [them].
1272 - src/gdcmTS.cxx: ditto.
1273 - gdcmPython/testSuite.py: dirty related kludge removed.
1274 * src/*: remaining references to gdcmParser removed.
1275 * src/*[cxx|h]: added copy[way]left header.
1278 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * In order to fix writing of dicom files:
1280 - Test/TestWriteSimple.cxx: a simpler example of writing.
1281 - Test/CMakeLists.txt changed accordingly.
1282 - src/gdcmDocument.cxx:
1283 -- The destructor now recursilvely removes potential sequences.
1284 -- Bug fix in ::IsJPEG2000()
1285 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1286 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1288 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1289 to only declared) and build on top of
1290 ::GetDocEntryByNumber(guint16, guint16).
1291 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1292 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1293 for usage in destructor and treatement of promotion in
1294 ::ReplaceOrCreateByNumber().
1295 - src/gdcmSQItem.cxx: destructor should better handle his job.
1296 Test/TestWriteSimple now runs (or at least it DOES something).
1297 * We can now start hutting memory links. A good starting point is:
1298 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1299 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1300 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1302 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * Valgrind note: after Mathieu Malaterre teached me how to read
1304 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1306 Using gcc, you can force the STL to use malloc and to free memory as
1307 soon as possible by globally disabling memory caching.
1308 With 3.2.2 and later, you should export the environment variable
1309 GLIBCPP_FORCE_NEW before running your program.
1310 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1311 simply vanish (it is still not clear to me, whether this means that
1312 STL std::string leaks or if valgrind believes it leaks...).
1313 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1314 running bin/gdcmTests makeDicomDir):
1315 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1316 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1318 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1319 SegFaulting (I drowned in DicomDir related code when trying to
1320 understand why the list is empty...).
1321 * src/gdcmDocument.h: first BSD license header try.
1322 * Doc/License.txt added.
1324 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * src/gdcmDocument.[h|cxx]:
1326 - Clean up of the Transfer related predicates. They are now all based
1327 on new method isGivenTransferSyntax, that (should) handle properly
1328 the padding problem.
1329 - general clean up, simplification, and coding style.
1330 - Specific clean up of Parse7FE0() (umproperly named actually).
1331 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1333 2004-06-14 Jean-Pierre Roux
1335 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1336 - fix the display of SQItem ordinal number
1337 - add the GetSQItemByOrdinalNumber method
1338 - remove some useless never written private methods
1340 2004-06-14 Jean-Pierre Roux
1342 - adding a constructor taking a gdcmDocEntry as an input param
1343 - ReplaceOrCreateByNumber now returns :
1344 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1345 a gdcmValEntry * if a string value is passed as a param
1347 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1348 according to the param type (no longer sets a gdcmDocEntry)
1349 - GetValEntryByNumber, GetBinEntryByNumber added
1350 - NewValEntryByNumber and NewBinEntryByNumber added
1352 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1354 - GetSQItemNumber and SetSQItemNumber added, to provide
1355 a (relative) Item identier inside a given Sequence
1356 \warning : some pb remaining around this number
1358 - AddEntry now takes the Item Number as a param
1360 - adding a constructor taking a gdcmDocEntry as an input param
1362 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * Memory leak hunt with the following command:
1364 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1365 --show-reachable=yes gdcmTests PrintDocument
1366 It looks like many (all?) leaks are due to the STL (or a bad usage
1367 of the STL. The lines producing the leaks now have a comment with
1368 a "MEMORY LEAK" tag: you can retrieve them with
1369 grep "MEMORY LEAK" src/*
1370 Here are two typical examples which I can't help fixing:
1375 char * test = "babo";
1376 name = test; //// <--- valgrind detects 960 bytes lost in
1377 //// call to std::string::operator=(char const*)
1378 name.clear(); //// Doesn't help !
1386 std::cout << "Type a bunch of characters followed by RETURN: ";
1387 getline(std::cin, line); //// <--- valgrind dectects a loss
1388 //// of 1320 bytes in call to
1389 /// std::basic_istream<>& std::getline<>
1395 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * src/gdcmHeader.[cxx|h]:
1397 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1398 and related, moved away to gdcmDocument.
1399 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1400 the corresponding protected accessors of inherited class
1401 gdcmDocument, removed ! As a consequence gdcmFile had to be
1402 declared friend of class gdcmDocument (see below).
1403 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1404 - Clean up of undefined or unused methods.
1405 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1406 account the changes to gdcmHeader.h).
1407 * src/gdcmDocument.h:
1408 - gdcmFile is now a friend class (in order to take into account the
1409 changes to gdcmHeader.h).
1410 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1411 (see changes to gdcmHeader.h).
1412 - Accessors (reading on the form GetEntry*) are now public.
1413 - Clean up of undefined or unused methods.
1414 * src/gdcmDocument.cxx:
1415 - adaptation to changes to gdcmDocument.h
1416 - ::OpenFile now writes a verbose message when file cannot be opened.
1417 - some std::string properly set to VRKey
1418 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1419 references to gdcmDocument.
1420 * Test/TestFindTags.cxx: changed accordingly to above changes.
1421 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1422 cvs repository gdcmData.
1424 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1426 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1427 conflicts with gdcmValEntry::voidArea.
1428 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1429 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1430 Value representation between StringRepresentable and BinaryRepresentable.
1431 * src/gdcmDocument.cxx:
1432 - method ParseDES: proper indentation restored and usage of
1433 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1434 - method LoadDocEntry: the fingerprint left in the SetValue() of
1435 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1436 removed. Reverting to previous code segment with the proper
1437 dynamic_cast< gdcmValEntry* >.
1438 Note: this was (partially) breaking the python test suite
1439 (gdcmPython/testSuite.py) that made usage of the above
1440 fingerprint to check presence of "Pixel Data".
1441 * src/gdcmDocEntry.h: coding style.
1442 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1443 now taken into account.
1444 * gdcmPython/gdcm.i: adaptation to the new internal representation
1445 of gdcm (exit gdcmParser, hello gdcmDocument).
1446 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1448 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1449 anymore, but instead prints the loaded Python dictionary.
1450 * .... alas, the python testSuite is still broken.
1452 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1453 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1455 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1456 * src/gdcmUtil.h : export methods
1458 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1461 * Initial addition of automatic python testing
1462 * Initial addition of automatic image comparison
1464 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1465 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1466 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1468 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1469 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1470 * Test/ShowDicom.cxx : bug fix for msvc compilation
1471 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1473 2004-05-04 Jean-Pierre Roux
1474 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1475 new concepts (and new classes) :
1476 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1477 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1478 - Sequence Doc Entries (gdcmSeqEntries)
1479 a Sequence is composed of Items.
1480 Each item is a set of Doc Entries (this is recursive)
1481 The non uniqueness of the 'Dicom tag' is due to this recursivity
1482 (never taken into account)
1483 Our unability to add a new 'entry' in the header
1484 at the proper location (neither in the H-Table (map or multimap),
1485 nor in the Chained List is also due to this recursivity.
1486 Don't try, right now, to use/modify/compile these new sources :
1487 nothing is finished.
1488 We just commit all the stuff, 'as is', in order not to loose it.
1490 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1491 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1493 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1494 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1495 file prefix (SetFilePrefix)
1497 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * Add a new test: ShowDicom, for now this is just the c++ version of
1499 checkRead.sh, later it will be able to compare the image read against a
1501 * Replace the DEBUG on the stack with a global entry in cmake interface:
1502 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1504 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1505 * Add an example subdir, with a real example on how to read + write a
1508 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1509 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1510 * Doc/CMakeLists.txt: the main page is now properly differentiated
1511 between the developper and user version.
1512 * Doc/doxygen.config.in: dropped search related obsolete flags
1513 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1515 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1516 * DEVELOPPER: added some helpfull comments for compile/test/install
1519 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1520 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1521 src directory, now generated in the build dir.
1522 2. Tests as mentionned smarter
1524 4. Add a new method in gdcmDict that return the PubDict by name
1525 this is interesting for 3rd party lib like ITK,
1526 where we could set the institution name / patient name...
1528 * ENH: 1. Now the test suite is working for real
1529 2. All binaries are now output in the gdcm-bin directory
1530 (this was not true before)
1532 2004-04-28 Jean-Pierre Roux
1533 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1534 SeQuence indented printing of Dicom Header.
1535 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1536 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1537 Computation of SQDepthLevel is now part of gdcmHeader constructor
1538 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1539 tree-like structure of a Dicom Header.
1540 * FIX Test code cleaning
1542 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * ENH: Adding automatic testing
1544 1. Need a DartConfig.cmake to submit to public
1545 2. Add a test driver gdcmTest.cxx
1546 3. gdcmTestMain, an helper for the main test driver gdcmTest
1547 4. Files in Test don't have a main anymore, this becomes interesting
1548 when we add more and more tests, thus dsw don't have to load
1550 * ENH: Adding a GDCM_DATA_ROOT for testing
1551 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1552 one file instead of seven + some small cleanup
1554 2004-04-22 Jean-Pierre Roux
1555 * ENH Minor changes to the Print() methods.
1556 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1557 Header printing. Example given with :
1558 > PrintHeader fileName 2 new
1559 (SQ based tree-like structure still to be done for the Header ...)
1561 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1562 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1563 1. I have added some unsigned where needed
1564 2. Some function parameter not used -> (void)
1565 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1566 4. g++ don't like character '\' in comment
1567 5. #define jpeg_create_decompress jCreaDecompress
1568 this really need to be fixed
1569 6. virtualize destructor of gdcmObject ... leakage
1570 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1571 this also really need to be fixed
1572 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1573 remove compression file
1574 (as we only do decompression, right ?)
1575 * ENH: Change malloc/calloc/free with c++ equivalent
1577 2004-04-21 Jean-Pierre Roux
1578 * FIX gdcmHeaderHelper::GetXSpacing
1579 when a single value is found (bug ?), xpacing is now
1580 defaulted to yspacing
1582 2004-04-19 Jean-Pierre Roux
1583 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1584 * ENH add parameters :
1585 bool exception_on_error = false,
1586 bool enable_sequences = false,
1587 bool ignore_shadow = false
1588 to the gdcmFile constructors to be full gdcmParser compliant
1589 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1590 to allow reading of PAPYRUS 3.0 files
1592 2004-04-06 Jean-Pierre Roux
1593 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1595 2004-04-02 Jean-Pierre Roux
1596 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1597 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1598 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1600 2004-03-30 Jean-Pierre Roux
1601 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1602 for ACR file, written out as DICOM files (hope so...)
1604 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1605 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1606 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1607 moved to base class gdcmParser and only the specialisation is kept
1609 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1610 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1611 already does the job.
1612 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1613 (to be consistent with gdcmParser::WriteEntries).
1615 2004-03-30 Benoit Regrain
1616 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1617 upate of the object's instance. It's passed to 2 in the unfavorable
1618 case : one in the ExecuteInformation, one in the ExecuteData
1620 2004-03-29 Jean-Pierre Roux
1621 * ENH : Check on file type to be written moved
1622 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1623 * FIX : gdcmObject::ResetBoundaries now stops properly
1624 when end-of-list is reached
1625 : gdcmVersion modified (as Benoit Regrain asked)
1627 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1628 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1629 * src/gdcmUtil.cxx: added forgotten iostream include.
1630 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1631 equivalent to ExplicitVR in existing code).
1633 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1634 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1635 now contains all the gdcmGlobal related code.
1636 * minor coding style and doxygenation changes.
1638 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1640 now contains all the Debug related code.
1641 * minor clean-up of includes in src/*.cxx
1642 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1643 CreateCleanString) removed.
1644 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1645 * Doc/DoxyMainPageUser.txt added.
1646 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1647 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1648 src/gdcmDirList.cxx)
1650 2004-03-24 Jean-Pierre Roux
1651 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1653 2004-03-23 Jean-Pierre Roux
1654 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1655 big endian made volumes
1656 * ENH Now gdcmParser constructor and destructor are protected to forbid
1657 end user to instanciate class gdcmParser
1658 (only gdcmHeader and gdcmDicomDir are meaningfull)
1660 2004-03-22 Benoit Regrain
1661 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1662 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1663 gdcmSerie to gdcmDicomDirSerie
1665 2004-03-19 Jean-Pierre Roux
1666 * ENH Now the tree-like structure describing a DICOMDIR comming from
1667 an already existing DICOMDIR file is consistent with
1668 the home-made tree-like structure build ex-nihilo
1669 or build from the files held (recursively) in a Directory
1670 functions gdcmDicomDir::CheckBoundaries()
1671 gdcmObject::SetBoundaries() added
1673 2004-03-17 Jean-Pierre Roux
1674 * REM (Eric Boix bug) : removal of meaningless
1675 gdcmDicomDirImage::NewImage function.
1676 * FIX now file names and directory name are written properly in the
1678 * FIX now gdcmDicomDir constructor may be call without any trick
1681 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1683 of gdcmDicomDirImage::NewImage as empty function.
1685 2004-02-28 Jean-Pierre Roux
1686 * ENH add gdcmDicomDir:NewPatient
1687 add gdcmDicomDirPatient:NewStudy
1688 add gdcmDicomDirStudy:NewSerie
1689 add gdcmDicomDirSerie:NewImage
1690 to allow making gdcDicomDir object.
1691 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1692 (as opposite to the gdcmHeader chained list)
1694 2004-02-11 Benoit Regrain
1695 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1696 when using from python
1698 2004-02-10 Benoit Regrain
1699 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1700 * FIX : in gdcmDicomDir when the directory is empty
1701 * ENH : add callback and methods to get the progression of dicomDir
1704 2004-02-06 Jean-Pierre Roux
1705 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1706 - GDCM_META added to gdcmDicomDirType
1707 - class gdcmMeta created
1708 * ENH : - A brief summary is now displayed at the beginning of
1709 'testDicomDir' to help disaster magnitude estimation
1710 * REM : Now useless Test/explDICOMDIR.cxx
1712 2004-02-05 Benoit Regrain
1713 * ENH : add methods in gdcmObject to get the hash table or the list of
1715 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1716 * FIX : wrapping python for TagHeaderEntryHT
1718 2004-02-04 Benoit Regrain
1719 * FIX : even length for some strings when writting the dicom dir
1720 * FIX : sort the images in the dicom dir
1721 * FIX : Bug fix for python use of dicom dir
1722 * ADD : a python demo
1724 2004-02-04 Jean-Pierre Roux
1725 * FIX : Final solution (?) for icone embedded images
1726 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1727 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1728 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1729 gdcmData/gdcm-MR-SIEMENS-16.acr1
1730 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1731 to make full checking easier
1733 2004-02-04 Benoit Regrain
1734 * FIX : WriteEntries : coding style & logic in parameters
1735 * FIX : Set the elements to create the DicomDir in a dictionary file
1737 2004-02-03 Benoit Regrain
1738 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1739 * gdcmDicomDir : add the load of directory
1740 * Bug fix and print add-on
1742 2004-02-03 Jean-Pierre Roux
1743 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1744 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1745 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1746 * FIX gdcmParser.cxx : 'group length' elements are now considered
1747 as integers, even for shadow groups, when file is Implicit VR
1749 2004-02-02 Jean-Pierre Roux
1750 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1752 of the last synonym :-(
1753 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1755 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1756 * FIX taking into account the possible 7fe0,0010 multiplicity
1757 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1758 to allow removal of references to 7fe0,0010, to deal with
1759 ACR-NEMA images, when 0028,0200 is meaningfull
1761 2004-01-31 Jean-Pierre Roux
1762 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1763 no longer writes 'Un' on disk
1764 * FIX SQ elements with actual length are now dealt with corectly
1765 * FIX gdcmFile::WriteBase make the difference, for color images, between
1766 the length (for Palette expanded images)
1767 and Raw Length (non expanded image + Palette)
1768 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1769 (that broke Write). Replaced by UL.
1770 Aware user will reload the field if he
1771 thinks it's necesssary
1773 2004-01-30 Jean-Pierre Roux
1774 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1775 when 'dirty Acr' is found, to be compliant with the new
1776 IsReadable() methods.
1778 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1779 (no DOUBLE images in kosher DICOM,
1780 but so usefull for people that miss them ;-)
1782 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1783 DICOMDIR related utilities (not checked as Windoze compliant)
1785 2004-01-28 Jean-Pierre Roux
1786 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1788 2004-01-27 Jean-Pierre Roux
1789 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1790 to allow skipping the shadow elements, to save memory space.
1791 The TRUE value for this param has to be used
1792 with a FALSE value for the 'enable_sequence' param.
1793 ('public elements' may be embedded in 'shadow Sequences')
1794 * gdcmHeader methods now deal with 'embedded icones images' in the header
1795 (even when an 'icone image sequence' is announced by the
1796 element (0x0088,0x0200), but there is NO icone at all ...
1798 * gdcmHeader sometimes Image Location value doesn't follow
1799 the supposed processor endianity (see gdcmData/cr172241.dcm).
1802 * gdcmHeader add the method
1803 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1804 to get *all* the Header Entries with the same tag.
1805 GetHeaderEntrySameName is probabely *useless*
1806 (no meaning : Name is *not* an identifier within the Dictionnary)
1808 2004-01-26 Benoit Regrain
1809 * Bug fix in the print of hexadecimal representations. Remove long fields
1810 in the print and add a third level of print to print them
1812 2004-01-23 Benoit Regrain
1813 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1814 * Bug fix on test suite after remove the strip made on not string fields
1815 * Split the IsReadable method between gdcmParser which test that the file
1816 is dicom and gdcmHeader which test that it's an image file
1818 2004-01-22 Benoit Regrain
1819 * DicomDir : clean code, add methods, set variables in protected or private
1820 * gdcmUtil : bug fix for the clean string method
1822 2004-01-19 Benoit Regrain
1823 * Add the use of shadow dictionaries
1824 * bug fix and coding style
1826 2004-01-19 Benoit Regrain
1827 * src/gdcmFile.cxx : bug fix concerning the close of file
1828 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1829 * Add the update of header entries using the shadow library
1831 2004-01-19 Benoit Regrain
1832 * removal of file gdcmHeader2.cxx
1833 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1834 inheriting from gdcmParser. This split is to prepare the integration
1835 of dicom dir parsing
1836 * bug fix under python
1838 2004-01-16 Jean-Pierre Roux
1839 * REM removal of class gdcmHeaderEntrySet
1840 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1841 * ADD add file gdcmHeader2.cxx
1842 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1844 2004-01-15 Benoit Regrain
1845 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1846 entries created while parsing the header. Thus, they will be destroyed
1847 when the gdcmDictSet will be destroyed
1848 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1851 2004-01-15 Benoit Regrain
1852 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1853 made a fatal error because of the memory release at the end of program.
1854 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1855 some memory and vtk seems to have some problems with that.
1856 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1858 2004-01-14 Benoit Regrain
1859 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1860 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1861 * src/*.[h|cxx] : make changes due to class name changes
1862 * gdcmPython/demo/*.py : bug fix due to method names
1864 2004-01-13 Benoit Regrain
1865 * src/*.[h|cxx] : coding style
1866 * vtk/*.[h|cxx] : coding style
1868 2004-01-13 Benoit Regrain
1869 * gdcmPython/testSuite.py : test the readable flag of file for tests
1870 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1871 It's lied to the stl compilation by MSVC (windows, always windows...)
1872 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1874 2004-01-12 Benoit Regrain
1875 * src/*.h : add comments
1876 * src/gdcmDictSet.h : set the method BuildDictPath in public
1877 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1878 directly setted in the source code
1879 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1882 2004-01-09 Benoit Regrain
1883 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1884 * setup.py : use a reference to gdcmVERSION
1886 2004-01-07 Benoit Regrain
1887 * Modification to compile with the distutils.
1890 2003-12-10 Benoit Regrain
1891 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1892 can use a gdcmHeaderHelper to load data
1893 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1894 made in the source code
1896 2003-12-10 Benoit Regrain
1897 * Update Windows projects and .cvsignore files
1899 2003-11-12 Jean-Pierre Roux
1900 * ENH gdcmHeader constructor has one more parameter (default value : false)
1901 that allows the user to 'go inside' the SeQuences only
1903 gdcmElValSet:Print takes it into account
1905 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1906 * ENH: Update gdcmPython/CMakeLists
1907 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1908 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1910 2003-11-10 Jean-Pierre Roux
1911 * FIX : gdcmHeader::LoadElements is now based
1912 on the ListTag listElem member,
1913 not longer on the TagElValueHT tagHt member
1914 * ENH : PrintPubElVal shows (temporarily) both results,
1915 with the tagHt member and the listElem member.
1916 (it's easier to 'see' the problems when using Printheader)
1918 * FIX : old private member LgrElem is now splitted into
1919 ReadLength : Length actually found on disk (updated only
1920 if bug fixing is necessary), for internal
1922 UsableLength : Updated by FixFoundLength, to fix a bug
1923 or to allow Parser going on.
1924 Will allow to re-write a kosher header when a SeQuence
1925 with a length (not 0000) is found
1926 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1927 because gdcmElValSet::Add does not update ListElem
1930 2003-11-07 Jean-Pierre Roux
1931 * FIX misstyping in Transfert Syntax name table
1932 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1933 when they have an actual length (not 0000 nor FFFFF)
1934 (Nobody should care of it, but DICOMDIR explorers)
1936 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1939 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1940 * ENH: vtkGdcmReader now supports LUT !
1941 (vtkgdcmViewer for now is not able to use them though)
1943 2003-11-05 Jean-Pierre Roux
1944 * in testSuite.py : new files names for checking the package
1945 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1946 that returns the pixel area size to the *aware* (vtk) user
1947 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1949 2003-11-05 Benoit Regrain
1950 * in testSuite.py : Modify the rules for checking the paths
1951 : Explicit error messages
1952 * in __init__.py : Related modif
1954 2003-11-03 Jean-Pierre Roux
1955 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1956 to be used by aware (vtk) users that want to manage
1957 LUT (and no to turn the PALETTE image into an RGB pixels one)
1958 * GetPixelType now returns 8U for 24 Bits images
1959 (vtkGdcmReader compliant)
1961 2003-10-31 Jean-Pierre Roux
1962 * Removal of *all* gdcmData images and add them again
1963 in order to loose the 'history' of un-anonymised images
1965 2003-10-31 Jean-Pierre Roux
1966 * RMV : removal of useless jBitsInJsample.h
1967 for both 8 and 12 Bits JPEG Lossy Libraries
1969 2003-10-31 Jean-Pierre Roux
1970 * ENH : Add the functions gdcmFile::GetImageDataRaw
1971 gdcmFile::GetImageDataIntoVectorRaw
1972 that act as GetImageData and GetImageDataIntoVector
1973 except the making of an RGB Plane from Gray Plane + LUT
1974 Intended to aware (vtk) users who know how to manage
1977 GetLUTRGBA return a R,G,B,A LUT if any
1978 lgrTotaleRaw gives the 'Raw' length
1979 GetImageDataRaw returns the gray Plane
1980 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1981 (They stay Grey, just like with other Dicom viewers :-(
1983 2003-10-30 Jean-Pierre Roux
1984 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1986 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1987 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1988 being coherents dicom files.
1990 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1993 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1994 * ENH: Two steps is necessary to please VC++ compiler...
1995 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1996 * ENH: Add include dir to medcon lib
1997 * FIX: only one function is being exported for now !
1998 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2000 2003-10-29 Jean-Pierre Roux
2001 * adding gdcmHeader::GetLUTRGBA
2002 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2003 --> Mathieu, the modif u're waiting for is not yet committed
2004 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2006 2003-10-27 Jean-Pierre Roux
2007 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2008 00191113.dcm DermaColorLossLess.dcm
2009 MxTwinLossLess.dcm RadBWLossLess.dcm
2010 * ENH: For version prior to vtkImageViewer2 -r 1.19
2011 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2013 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2014 * Removal of ido stuff in CMakeLists.txt
2016 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2017 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2018 * FIX: remove a call to ->Modified ... see comments
2019 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2021 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * FIX: Problem with path for libvtkgdcmPython
2023 * ENH: Try adding a search script for python site-package
2024 * RMV: Remove some file from medcon lib that are not necessary
2025 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2026 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2027 * FIX: More pragma disable fro VC++,
2028 I don't think I break something as it is also disable in VTK/ITK.
2029 But it fasten debug compilation time.
2031 2003-10-23 Jean-Pierre Roux
2032 * gdcm now deals with 16 Bits Run Length Encoded images
2033 (they are compressed as 2 planes images,
2034 one for the high Bytes, the other for low Bytes)
2036 2003-10-22 Jean-Pierre Roux
2037 * Now CheckRead takes into account :
2038 - the bugged 'Leonardo' Siemens images
2039 - the XA images, sent thru the burning VPRO station
2040 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2043 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2044 * FIX: When copying a Makefile.am to CMakeLists.txt
2045 one should remove the '\'
2047 2003-10-22 Jean-Pierre Roux
2048 * in gdcmData adding a bugged 'Leonardo' Siemens image
2049 (wrong lengths in header)
2050 OK with gdcm, KO with the other viewers :-)
2051 * add a GE dlx XA image, thru the VEPRO burning station
2054 2003-10-21 Jean-Pierre Roux
2055 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2056 for a brutal checking of vtkgdcmViewer compliance
2058 2003-10-21 Jean-Pierre Roux
2059 * add the files for 'xmedcon' Jpeg Lossless library
2060 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2062 2003-10-21 Jean-Pierre Roux
2063 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2065 2003-10-21 Jean-Pierre Roux
2066 * garbage Siemens 'Leonardo' images dealt with
2067 (the patch is easy to remove)
2068 * cosmetic changes to avoid warnings
2070 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2072 no need to press 'r' now.
2074 2003-10-20 Jean-Pierre Roux
2075 * upgrade of checkRead.sh checkWrite.sh according
2076 to new Jpeg Lossless decompressor
2077 * add US.3405.1.dcm, a genuine RGB medical file ...
2078 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2079 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2081 2003-10-15 Jean-Pierre Roux
2082 * general anonymisation in gdcmData
2083 * adding the 'color files' from
2084 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2085 * adding some well knowed bugged-header images
2086 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2087 waiting for their inclusion in Python testsuite
2089 2003-10-15 Jean-Pierre Roux
2090 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2091 no longer seg faults when file is not found
2093 2003-10-14 Jean-Pierre Roux
2094 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2097 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * TODO: *.in file to genereate a UseGDCM later
2100 2003-10-14 Jean-Pierre Roux
2101 * Some supposed-to-be Dicom Images have no preamble.
2102 OpenFile takes it into account
2103 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2104 * Missing elements added in dicomV3.dic
2105 (just to be affraid : have a look at
2106 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2107 and do it again next year ;->
2109 2003-10-13 Jean-Pierre Roux
2110 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2111 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2112 But there are NOT. It's fixed !
2114 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2115 * FIX: "jpeglib.h" was not found on VC++
2116 * FIX: vtkgdcm was not being installed
2118 2003-10-10 Jean-Pierre Roux
2119 * ENH : OpenFile closes the file if it *really* doesn't look like
2120 an ACR-NEMA / DICOM one.
2121 * FIX : testWrite no longer writes an empty file if the source file
2122 is not gdcm Readable
2123 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2126 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2127 * FIX: CMake generate now documentation
2128 * ENH: out of source doc build !
2129 * ENH: Generate both user and dev documentation
2130 * ENH: Should work on windows too
2131 * ENH: Only one doxygen config.in file is needed
2132 * FIX: make install should be ok now on ùnix plateform
2133 * FIX: PATH to dictionary was wrong (missing /)
2134 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2136 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2137 * vtkGdcmReader is now able to read rgb dicom file.
2138 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2139 * added a gdcmViewer to vtk test, use mouse to control
2140 window level & window width
2142 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * CMake-ification of gdcm, we have now two build system
2144 * FIX: on cygwin Wsock32 doesn't exist
2145 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2147 2003-10-06 Emanuel Ollart
2148 * FIX : compilation process wad broken.
2149 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2151 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * change gdcmViewer -> vtkgdcmViewer
2153 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2155 2003-10-06 Jean-Pierre Roux
2156 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2157 ( e.g : well known GE images with a wrong elem length,
2158 : Philips MRI Images with a wrong Huffman table)
2159 * still to be done : allow the reading of bugged LEONARDO Siemens images
2161 2003-10-03 Jean-Pierre Roux
2162 * Odd length strings are padded with '\0' (not with spaces,
2163 to remain compliant with already defined strings,
2164 like Transfert Syntax UID and others)
2166 2003-10-03 Jean-Pierre Roux
2167 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2168 to allow displaying RGB images (not only by affim ;-)
2170 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2171 * vtkGdcmReader is now able to read rgb dicom file.
2172 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2174 2003-10-03 Jean-Pierre Roux
2175 * A few nasty patches to allow the reading of a lot of nasty images
2176 ( e.g : well known GE images with a wrong elem length,
2177 : Philips MRI Images with a wrong Huffman table)
2178 * still to be done : allow the reading of bugged LEONARDO Siemens images
2180 2003-10-03 Jean-Pierre Roux
2181 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2183 2003-10-03 Jean-Pierre Roux
2184 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2185 to allow displaying RGB images (not only by affim ;-)
2187 2003-10-03 Jean-Pierre Roux
2188 * gdcmFile::GetImageDataIntoVector now
2189 - deals with MultiFrames MultiFragments Run Length Encoded files
2190 - deals with YcBcR (YBR_FULL) files
2191 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2192 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2194 (no sample found :-(
2196 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2198 Two reasons: - clear things
2199 - third parties acces gdcm through header files, so won't
2200 suffer anymore VC++ complains
2202 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2203 * add argv[1] in testvtkGdcmReader.cxx
2206 2003-09-24 Jean-Pierre Roux
2207 * The lines are now eigthy characters long.for
2208 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2210 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2211 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2212 char* to std::string. Thus, the use of strdup becomes useless. (see
2213 previous commis of Malaterre)
2214 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2215 before the last Malaterre's commit.
2217 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2218 * This commit should fix the Debug building under VC++, the problem
2219 was mainly a mixture of debug and release lib being loaded at startup.
2220 * I also remove a depency to a specific C function: strdup. Because I had
2221 to force the link to msvcrtd (whereas strdup is in libc).
2223 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2225 located in the gdcmCommon.h file. All use of reference of tha has been
2226 changed to now use the variable GDCM_UNFOUND.
2228 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2230 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2231 Dicom dictionary. The test suite can now be run again. Note:
2232 I'm note very happy with the " (RET)" changes. I believe this
2233 RETAINED comment should be dropped when parsing the dictionary.
2234 - PACKAGER corrected
2236 - AUTHORS updated and now in alphabetical order
2237 * Makefile.am now exports gdcm.dsw for Windoze users.
2239 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * cygwin complains about missing std:: in subdir Test/
2242 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2243 * remove some methods that are now in gdcmHeaderHelper
2245 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2246 * vtkGdcmReader set spacing and origin correctly
2248 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2249 * Fix a few delete/delete[] mismatch
2251 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2252 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2253 interpretation to data given by gdcmHeader. For instance there are
2254 heuristics to get informations (look at different places).
2255 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2256 sorting DICOM images based on different strategies.
2257 * modified Makefiles accordingly.
2259 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2260 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2261 when building in debug mode
2262 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2263 src/win32/gdcmdll.dsp
2264 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2266 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2267 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2270 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2271 * src/win32/libgdcmjpeg12.dsp was not dos format
2272 * src/win32/libgdcmjpeg12.dsp :
2273 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2274 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2276 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2277 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2279 * src/gdcmFile.cxx : bug fix in affectation type
2280 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2281 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2282 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2283 symbols... future problem ?
2285 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2286 * src/win32/libgdcmijpeg12.dsp was missing
2287 * modified gdcm.dsw accordingly
2289 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2292 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2293 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2294 commit of JPR (before his hollidays to facilitate our work).
2295 * setup.py : bug fix in code. Modifications made while the last commit
2296 of JPR. The code hasn't been tested before the commit... it's so
2297 useless to make that (for best programmer that is JPR) !!!
2299 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * tagged the current version as Version0_3 (i.e. version 0.3)
2302 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2303 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2304 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2305 * *.dsp : modifications to use new libgdcmijpeg8 library
2306 * setup.py : bug fix on VTKPATH variable
2307 * PACKAGER : adding all concerning windows
2309 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2310 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2312 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2313 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2314 test suite reported error.
2315 * PACKAGER file added (describes what a packager must do when
2316 packaging a new release).
2317 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2318 * configure.in: upgraded version number to 0.3.0
2319 * fixing build of rpm (through rpm -ta):
2320 - Doc/Makefile.am exports proper doxygen files
2321 - src/jpeg/libijg8/Makefile.am exports the include files.
2323 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2324 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2325 * src/gdcmHeader.h : formatting code
2327 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2328 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2329 We were obtaining error message from vtk. Now, creation of file list
2330 is made in an internal list to prevent this problem.
2331 Bug fix when output is empty.
2332 Bug fix in update of progress value. Previous commit for this was a bad
2334 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2336 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * src/gdcmHeader.h : added method to get the file name
2338 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2339 files. Added method to remove all files on the input
2340 Added FIXME comment concerning the bad parsing of header made by
2341 ExecuteInformation method (in ExecuteData method)
2343 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2345 when using make instal.
2346 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2347 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2349 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2350 * setup.py : adding include dir of jpeg lib to compile all sources
2351 * */Win32/*.dsp : JPR fix for windows compilation
2353 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2354 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2356 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2357 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2359 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * setup.py is again effective on un*x (takes into account the
2361 addon of the jpeg library)
2362 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2363 * Doc/Doxy* updated (includes above enhancements)
2364 * INSTALL now points to web documentation
2366 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * src/gdcmHeader.h doesn't make unnecessary reference to
2369 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2371 * src/gdcm*.[cxx|h] :
2372 - to allow compilation with gcc 3.x
2373 -- clean up of STL usage (added explicit usage of std::)
2374 -- small fixes on exceptions.
2375 Note: linking not tested !
2376 - clean of doxygen comments to avoid warnings at documentation
2378 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2379 dependent convertion).
2381 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * Clean up of previous JPR garbage commit (not even commented in the
2384 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2385 - moved all jpeg related files from src to src/jpeg/libijg8, with
2386 addition/modification of Makefile.am and configure.in.
2387 - the testSuite is still brain damage (not guilty).
2389 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2390 * WrapVTK.py : modifications to get correctly vtk source files to
2392 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2393 (FileName -> Filename)
2395 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2396 * vtk/vtkGdcmReader.[cxx/h]:
2397 - UpdateProgress method should now be effective
2398 - removed the limitation on having only images loaded (as opposed
2400 - when building a stack of images/volume, a lesser number of
2401 gdcmHeader and gdcmFile instances should be used (hopefully
2402 accelerating things).
2403 - when building a stack of images/volumes, files which are not
2404 loadable (wrong path-filename, wrong permissions on existing file,
2405 or file not parsable by gdcm) are replaced with a black image
2406 in the stack (for the caller to notice the problem).
2408 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2411 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2412 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2413 between standard library (std) and vtk library (problems are found
2414 under Windows... thanks Windows !)
2416 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2419 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2421 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2424 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * When compiling with distutils (see setup.py) the C++ compiler is
2426 called with different flags than the default ones (with automake).
2427 In order to fix all those warning, I compiled gdcm with the command
2428 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2429 and went for warning fixes:
2430 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2431 up from unused variables.
2432 - vtk/vtkGdcmReader.cxx: potential bug fix.
2433 * src/gdcmHeader.h: Doxygen warning cleanup
2435 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * gdcmPython/gdcm.i:
2437 - typemaps correction to take into account the systematic replacement
2438 of "using namespace std" with std:: prefix e.g. std::list,
2439 std::string... (cf changes of 2003-05-21).
2440 - gdcmGlob global variable of type gdcmGlobal (defined in
2441 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2442 exported to Python a as cvar.
2443 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2444 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2445 gdcmDictSet.GetPubDictTagNames() and
2446 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2447 C++ static methods).
2448 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2449 with the above changes.
2451 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2452 * setup.py, manifest.in : bug fix under linux
2454 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2455 * Modification of setup.py to compile vtk part too. Then, we have 2
2456 wrappers which must work with same distutils. For that, we have a
2457 generic distutils in distusiltsWrapping.py ; with :
2458 - build_extWrap class to wrap generically all extensions,
2459 - ExtensionWrap base class for all wrapping extension that contains
2461 - Wrapper interface which wrap sources
2462 + In WrapSwig.py we have extension and wrapper for Swig
2463 + In WrapVTK.py we have extension and wrapper for VTK
2464 * MANIFEST.in : modifications to consider vtk directory and new python
2465 files for compilation
2467 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2468 * Added python wrappers of vtkGdcmReader vtk class (see the
2469 source in vtk/vtkGdcmReader.cxx) :
2470 - vtk/Makefile.am now builds a library
2471 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2472 python library (as opposed to _gdcm.so wich are the python
2473 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2474 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2476 - configure.in has an additional flag --enable-vtk that needs
2477 to be set to enable compilation of vtk related code, that is:
2478 + vtk/vtkGdcmReader.so and
2479 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2480 + gdcmPython/vtkgdcmPython.so (see above)
2481 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2482 be read when compressed or when HighBit + 1 != BitsStored),
2483 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2484 the usage of the python wrapper of vtkGdcmReader vtk class.
2485 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2486 * src/*.[h] all occurences of stl classes are now prefixed with
2487 std::, and all occurences of "using namespace std;" where removed.
2488 This is to avoid pollution of global namespace in included files.
2489 Apparently vtk does not avoid this pitfall: when using both
2490 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2491 collision of various stl members (principally cout...).
2492 * gdcmPython/testSuite.py now cleanly removes temprory generated
2494 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2495 comply with above changes)
2497 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2498 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2499 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2500 vtk data structure (an image Flip was required).
2501 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2502 * cosmetic changes in documentation.
2504 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2505 * src/gdcmHeader.cxx: the constructor no longer exits when an
2506 unexisting file is given as argument.
2507 * The subdirectory Data (containing all the images used for the
2508 test suite) is not part of this repository anymore. A new module
2509 containing those images is now available at
2510 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2511 with the name gdcmData.
2512 All the python scripts (including the package initialisation file
2513 gdcmPython/__init__.py) were adapated to take this change into
2514 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2516 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2517 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2518 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2519 demo of the usage of this class.
2520 Compilation of this vtk part is only done when using the --enable-vtk
2521 at configure (or autogen.sh) stage.
2523 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2524 * More memory link related corrections and documentation fixes.
2526 - maximum info is obtained with a command of the form:
2527 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2528 --show-reachable=yes PrintHeader
2529 - the remaining reachable blocks seem to come from the STL
2530 allocation scheme through the usage of map and list. It looks
2531 like this memory cannot be freed but it is not a memory leak
2532 (in fact further invocation to the STL would recollect the
2533 unused memory allthough it cannot explicitely be freed).
2534 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2535 of displaying an image parsed with gdcm and displayed with VTK.
2536 Note: some images don't seem to work e.g.
2537 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2538 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2539 Allthough this weakens the semantics, it is a ditch attempt to
2540 make gdcm more thread friendly.
2542 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2543 * Memory link hunt (by using valgrind through the command
2544 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2545 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2546 gdcmHeader::_dicom_vr.
2547 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2548 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2550 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2552 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2553 * src/Makefile.am now exports all the necessary include files at
2557 * UpdateGroupLength replaced by new one
2560 * UpdateGroupLength re-written using H-Table
2561 (named UpdateGroupLengthNew untill checks are over)
2563 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2564 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2565 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2567 - gdcmHeader::GetPubElValSet removed.
2568 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2569 UpdateGroupLength, WriteElements, Write.
2570 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2571 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2572 carried the same semantics.
2573 - src/gdcmHeaderIdo.cxx changed accordingly.
2574 - gdcmFile::WriteBase now regroups all the codes from previous
2575 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2576 - enum FileType moved to gdcmCommon.h
2577 * src/gdcmHeader.cxx AddDefault trashed
2578 * gdcmGetXSize added
2579 * getimageDataSize now calls gdcmGetXSize
2580 * Test/*.cxx changed to agree with above changes
2582 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2583 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2584 (to avoid double call by end user).
2585 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2586 by end user, since gdcmHeader::gdcmHeader now handles it.
2588 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * gdcm/Doc many doxygen changes:
2590 - Doxyfile now has two different versions, DoxyfileUsers that generates
2591 the html.users end users oriented documentation and
2592 DoxyfileDeveloppers that generates the html.developper developper
2593 oriented documentation.
2594 - README changed accordingly
2595 - requirement.txt removed (old design info moved to TODO).
2596 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2597 DoxyMainPage.txt, DoxyPython.txt provide more information.
2598 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2599 be updated by simply regenerating the docs with doxygen and copying
2600 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2601 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2602 all the tests in the form "if (<map>.count() >1)" were removed.
2603 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2604 ill-formed documentation sections.
2605 * src/gdcmHeader.cxx: ditto
2607 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * setup.py fixed for un*x (needed macro for stdint.h)
2609 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2610 un*ces with sh-utils test utility.
2611 * gdcmPython/demo/test.py renamed to PrintHeader.py
2612 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2613 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2614 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2615 * src/gdcm*.cxx JPR's bad inclusion fixed.
2617 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2618 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2619 * gdcmPython/demo/test.py changed accordingly.
2621 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * gdcmPython/Makefile.am fixed linking against libstdc++
2623 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2624 * Swig subdir (historical tests of swig version 1.3.17++) removed
2625 * Test/testChangeEntete.cxx some lines commented out in order to make
2627 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2628 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2630 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2632 hence the user doesn't need this explicit call.
2633 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2634 i.e. LoadElements() call removed.
2635 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2636 - src/Makefile.am declares the proper flag for g++.
2637 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2638 for adding user defined new tags.
2639 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2640 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2641 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2643 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2644 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2645 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2646 src/Makefile.am : the project should properly compile and install
2647 with the autotools, included the python wrappers part.
2648 * gdcm.spec.in : added a spec file for RPM packaging.
2650 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2651 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2653 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2655 to exported to the environement (see gdcmPython/testSuite.py
2657 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2658 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2659 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2660 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2661 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2663 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * gdcmPython/__init__.py doesn't crash anymore when running in
2665 in InstallMode or PreInstallMode but with an environement given
2666 value of GDCM_DICT_PATH.
2667 * src/gdcmDictSet.[cxx/h] coding style.
2669 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2671 * src/gdcm.h general comments moved to TODO, and README
2672 * src/gdcm.h should now be seen as a user commodity (including it
2673 should suffice to fully use gdcm). It is nowhere including within
2674 any of the kernel files src/*.cxx and src/*.h.
2676 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2678 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2680 * src/gdcm*.cxx only include their corresponding include file
2681 (as opposed to gdcm.h)
2682 * gdcmPython/gdcm.i changed accordingly
2683 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2684 the autogen.sh generated "make snapshot" command to work.
2685 * autogen.sh removed history related references to crea package.
2687 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * distutilsSwigCPlusPlus.py work around some swig portability
2691 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2693 was done in a last ditch attempt to get setup.py _really_
2694 operationnal. The python/gdcmPython layaout add the advantage
2695 of hidding away the python related distutils specific files
2696 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2697 Alas, the src directory was out of scope (i.e. it's relative
2698 position to setup.py was ../src) which made things impossible to
2699 handle (see previous version of python/setup.py). Crossing fingers...
2701 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2702 * python/setup.py now works on Un*x. (harder than I thougth)
2703 * python/distutilsSwigCPlusPlus.py can now have include files
2704 among the list of sources.
2706 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2707 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2708 * modifications in MSVC projects
2710 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * As stated by the first lines of Test/ExceptionAndPython/README, it
2712 looks like we can move back to original usage of exception within
2713 src/gdcm* and hence remove the errno stuff that was introduced
2714 as a quick and dirty fixture of this problem (added to the TODO).
2715 * Doc/Doxyfile configuration file for Doxygen and corresponding
2716 README file for usage added.
2717 * Test/testWrite.cxx added. This new test comes from a split of
2718 test.cxx that is now reverted to its original purpous i.e.
2719 testing the proper parsing of a Dicom related file.
2720 testWrite.cxx concentrates on testing the IO part of gdcm.
2721 * Test/bug1.cxx (containing a bug on WIn32) added.
2722 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2723 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2724 whose purpose is to publish the content of the TagNames of the
2725 Dicom public dictionnary were not accessible without an
2726 instance of class gdcmHeader.
2727 - those methods are now static methods of gdcmDictSet and hence
2728 require no instances at all to be invocated.
2729 - within gdcmDictSet this change required to change some method
2730 to class methods (i.e. are now static) among which SetDictPath
2731 (renamed to BuildDictPath) and LoadDefaultPubDict.
2732 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2733 the above changes by calling the new method classes of gdcmDictSet.
2734 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2735 the above to be effective.
2736 * python/gdcmPython: in order to wrap properly the above changes
2737 for Python, swig version now needs to be > 1.3.17.
2738 * python/gdcmPython/Makefile fixed to adapt itself to new
2739 configure/make shema introduced by Johan Montagnat (thanks for the
2740 contribution). Alas this Makefile cannot be turned into a proper
2741 Makefile.am without some heavy changes in the configure.in
2742 (for python dectection).
2743 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2744 now avoids publishing the empty entries.
2746 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2747 * python/setup.py : bug fix concerning install under windows
2748 ExtraPath reused :-P
2749 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2751 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2752 * Dicts/dicomV3.dic : remove double spaces !!!
2753 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2754 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2757 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2758 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2759 method. Doxygenation.
2760 * src/gdcm.h clean up of JPR spurious comments.
2762 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2763 * python/distutilsSwigCPlusPlus.py now properly collects the
2764 shadow classes generated by "swig -c++" (gdcm.py in our case)
2765 when using "python setup.py install".
2766 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2767 reexports the working classes.
2768 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2769 by the classical C errno scheme. This is to prevent an obscure
2770 behavior of the python wrappers when importing wxPython.wx prior
2771 to gdcmPython (which ended up in an abort call). An illustration
2772 of this oddity can be found in the Test/ExceptionAndPython
2773 subdir (see the README file). This problem probably due to
2774 an combination of g++ and dynamic loading.
2775 * added Test/ExceptionAndPython (see above)
2777 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2778 * Changed the layout of the python part to avoid bloating main
2779 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2780 i.e. the distutils arsenal. All the python related stuff is
2781 again in a python subdir, but the package itself is now in
2783 * setup.py was cleaned up:
2784 - pythonIncludePath removed
2785 - python setup.py bdist target is now functional.
2786 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2787 collision with other packages). gdcmPython/demo/*.py changed
2790 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * python subdir moved to gdcmPython (preparation of distutils packaging).
2792 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2793 distutils installer is operational.
2794 * - gdcmPython/__init__.py now properly loads the swig generated
2795 shadow classes (from gdcm.py).
2796 - gdcmPython/demo/*.py changed to import the package gdcmPython
2797 instead of gdcmPython/demo/load.py.
2798 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2800 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2802 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2803 entries within the associated public Dicom dictionary resp. the same
2804 information but sorted by the fourth field (PAT, IMG, DIR) of the
2806 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2807 are now in the "???" group.
2808 - python/gdcm.i changed accordingly,
2809 - python/demo/printGroupedPublicDict.py added, that gives an example
2810 of the above new functionalities in Python.
2812 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * src/gdcm.h, gdcmHeader.cxx:
2814 - historic references to glib's g_malloc and g_free (#defined)
2815 were definitively removed.
2816 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2817 * src/gdcmElValSet.cxx:
2818 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2819 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2820 - GetElValue(string) renamed to GetElValueByName.
2821 - Added GetElementByName(string).
2822 * src/gdcmHeader.cxx: added
2823 - GetPubElValRepByNumber(guint16, guint16)
2824 - GetPubElValRepByName(string)
2825 - GetShaElValRepByNumber(guint16, guint16)
2826 - GetShaElValRepByName(string)
2827 - GetShaElValByNumber(guint16, guint16)
2828 - GetShaElValRepByName(string)
2829 - GetElValRepByNumber(guint16, guint16)
2830 - GetElValRepByName(string)
2831 - GetElValByNumber(guint16, guint16)
2832 - GetElValRepByName(string)
2833 * Doc/requirements.txt added.
2835 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * Test/Makefile building now depends on the one of libgdcm.so
2837 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2838 pixel data) aware which enables finding the address (offset) of
2839 the pixel data of JPEG encoded DICOM files. This leaves only a single
2840 file in the testSuite whose pixel data address (offset) is unknown.
2841 * python/testSuite.py changed accordingly.
2843 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2844 * VC++ has some strong limitations when working with the STL, as stated
2845 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2846 "Also note that some STL containers (map, set, queue, list, deque)
2847 cannot be exported. [...]
2848 Some STL classes contain nested classes. These classes can not
2850 This is caused by a designed limitation that once a template
2851 class is instantiated, it can not be re-instantiated and
2853 Since our usage of map<> is ubiquitous in gdcm, this "designed
2854 limitation" of VC++ is a pitfall.
2855 Hence the Python wrappers of gdcm cannot be incrementally linked
2856 against the c++ dynamic library. The dirty but only workaround is
2857 to forget about incremental link of dynamic libraries and to generate
2858 the Python wrappers library with the inclusions of the underlying C++
2860 The following modifications concern this matter on Win32/VC++:
2861 - wrapping python correct with standalone wrapped dll (don't use separate
2862 dll under windows !!!!)
2863 - python21_d debug mode enabled (ask Frog how to use it :-)
2864 - NO problem with having an STL member of class for example string in C++
2865 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2866 - Python test of dcmlib in Python is ok under windows on a large set
2868 * removed glib references
2869 * typedef's inserted in gdcm.i for correct swig type management
2871 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * python/demo/*.py load.py extracted from test.py. Added explore.py
2873 that only displays required tags and testAll.py that parses all
2874 the files of the testsuite without using unittest.
2875 * python/testSuite.py other additional test on new files added.
2876 * Data/* new test files added accordingly to the testSuite.
2877 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2878 the vr in the file differs from the one of the dictionary.
2880 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2881 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2882 values, but limits itself to values which are below a user specified
2883 size (by default 1024 bytes).
2884 * python/gdcm.i : elements not loaded (because their size is above the
2885 user specified treshold) are exported with their TagKey as key of the
2886 python dictionary. This enables the testsuite to make some checks
2887 on the unloaded elements (since we have their offset and size).
2888 * python/testSuite.py
2889 - now tests for the existence and proper value of the pixel data
2890 - two new examples added.
2891 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2893 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2895 aware. See the strategy comments in gdcmHeader::FindeLength().
2896 * Test/test.cxx now accepts a filename as first argument.
2897 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2898 * python/testSuite.py changed to integrate test on above files.
2900 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2901 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2902 the vr was also RET.
2903 * python/testSuite.py more tests added.
2905 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2906 * python/testSuite.py unittest test suite added (uses Data)
2907 * Data/* dcm and acr files for the test suite.
2908 * glib dependance removed from un*x version. We now use ISO C99
2909 7.18 Integer types (see stdint.h)
2910 - python/Makefile, src/Makefile src/gdcm.h
2911 * src/ when an explicit vr (like dicom files) suddenly poped an
2912 implicit element we use to mark the underlying DictEntry of the
2913 concerned ElValue with "Implicit". This strategy was damageable
2914 too the public or provite dictionaries, since some of their vr
2915 would be changed. Since Header::FindLength heavily relies on the
2916 detection by Header::FindVR of falsely explicit elements, I
2917 added an extra ImplicitVr member to ElValue (boolean).
2918 The rest of the changes we the necessary adaptations.
2920 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2921 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2923 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2925 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * Adaptation for porting to VC++:
2928 o forced to use std namespace (for string to be known)
2929 o all class use __declspec export style on WIN32
2930 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2931 (in stdlib.h on Win32 but in std:: for gcc)
2932 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2933 variable GDCM_DICT_PATH.
2934 * src/gdcmHeader.cxx verbose comments made discrete.
2936 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2937 * python/gdcm.i: added a typemap that converts a C++ hashing table
2938 to native Python dictionary.
2939 * python/demo/test.py:
2940 - now uses the native dictionary for exploration of gdcmHeader.
2941 - takes an optional filename argument (the file to parse).
2942 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2943 PubElVals hashing table.
2944 * Dicts/dicomV3.dic removed error prone trailing spaces.
2946 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2947 * Python wrapping process moved away from src/Makefile to
2948 newly created python/Makefile (as well as gdcm.i)
2949 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2950 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2951 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2952 from the environement variable GDCM_DICT_PATH (when existing).
2953 * src/gdcmDict::GetTag bug fix.
2955 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * Straightforward temporary fixes for swig to build the python wrappers.
2957 src/Makefile now has a python working entry [by working we mean
2958 that we can import de shadow classes without errors].
2960 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * hashtest.cxx removed (since allready in Test)
2962 * src/gdcmlib.h renamed to src/gdcm.h
2963 * src/dcm.i renamed to src/gdcm.i
2964 * src/Makefile prepared for python wrapping
2966 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * src/gdcmHeader.cxx :
2968 - Parsing of header is now separated from loading of element values
2969 (see gdcmHeader::LoadElements).
2970 - general clean up of hopefully all file access (creation of
2971 ReadInt16 and ReadInt32)
2973 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * src/gdcmHeader.cxx :
2975 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2977 - SetLgrElem renamed to SetLength
2978 - GetLgrElem renamed to GetLength
2979 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2980 * src/gdcmElValSet.cxx fixed both GetElValue methods
2981 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2982 due to IdoDude was cleaned out.
2984 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2986 concentrates on finding the value representation (when it exists).
2987 RecupLgr now only finds the element value length, and it avoids
2988 returning the unecessary skL (skipped length).
2989 Also, offsetCourant was simply removed (with taille_fich) since
2990 it was redundant with the File position internals (by using
2991 ftell and fseek). This also made skL (see above in RecupLgr) usage
2993 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2994 on the libido specificities which are handled through class
2996 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2999 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * Truckload of changes. Parsing of header is barely functional
3001 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3003 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3004 * src/gdcmHeader.cxx many addons of low level methods
3006 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3008 and _IdDcmSWAP_LONG.
3010 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * This corresponds to all the changes decided at the meeting of
3012 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob