1 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * According to Benoit's suggestion, and without any objection from anybody
3 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
4 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
5 - method gdcmDicomDirObject::GetEntry() renamed as
6 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
8 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
10 you debug/warning message just as c++ streams which make them very convinient
11 to use. Once this is stabilize I will change the ostringstrem to be
12 redirected to a file (ofstream).
13 * Properly support C99 extension: __FUNCTION__ which allow us to display
14 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
16 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
17 * Removal of useless and dangerous methods :
18 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
19 GetDocEntryByName, GetEntryByName, GetDictEntryByName
20 * Removal of usless methods :
21 Dict::PrintByName, Dict::GetDictEntryByName
22 * Commenting out of probabely useless methods :
23 Dict::GetDictEntryNames()
24 Dict::GetDictEntryNamesByCategory()
25 DictSet::GetPubDictEntryNames()
26 DictSet::GetPubDictEntryNamesByCategory()
27 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
28 * ENH : Use dicomTS.dic as described in 2004 version
29 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
30 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
31 Add Accessors on VM (Value Multiplicity), and VM related methods
32 * ADD : Add a list of 'Dicom Attribute types', as found in
33 http://medical.nema.org/dicom/2004/04_15PU.PDF
35 * ADD : Add dicomGroupNameAbbreviations.dic
36 should be used to write a method to replace the former
37 Dict::GetDictEntryNamesByCategory()
39 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
41 to read in the file... and only it ! Length is the efective length of the
42 data in the DocEntry structure
44 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
46 And now use a static function call instead, with a global variable. i
47 This is much closer to the VTK approach. Hopefully should be bulletproof
48 and easier to use...hopefully
50 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
53 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
56 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
58 ValEntry, BinEntry, SeqEntry creation or replace
60 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
62 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
64 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
65 when specifying the VR
66 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
67 * src/gdcmDocEntry.cxx : amelioration of print
69 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
70 * ADD : Add the method Util::IsCurrentProcessorBigEndian
71 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
72 * ADD Method Document::ComputeGroupLength
73 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
74 in order to allow further VR modification by user
75 * REM : removal of once-called method File::WriteBase
76 integration of its code in formerly one-line method File::Write
78 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
80 replace the different values "??", "Unkn", "Unknown".
81 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
82 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
83 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
84 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
86 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
89 * Set the gdcm::Base class to some Printable classes
91 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmFile.[h|cxx] : add the Print method
93 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
94 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
95 * src/gdcmDocument.h : remove the PrintLevel informations
96 * Example/PrintFile.cxx : use the new gdcm::File::Print
98 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
100 problems when compiling with the python wrapping
102 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
104 writting in ImplicitVR
106 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
107 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
108 JPEG decompression, especially when dicom frames are split into several
109 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
110 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
112 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmHeader.cxx : change the initialisation of default header.
114 Now, this header is readable by gdm, e-film, DicomWorks
116 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
118 Rename Decompressed to Raw
119 * Use the API changes in gdcm::File.
120 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
123 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
125 each added entry in the header. Replace the 'Planes' field by the 'Number
128 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
130 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
132 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
134 At this time, this image isn't readable by e-film... waiting JPR help to
137 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
139 DocEntry. Now use methods of the Document !
141 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * Test/ShowDicomSeq.cxx : bug fix
144 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
146 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
147 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
148 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
150 * Test/TestCopyRescaleDicom.cxx : remove unused variable
151 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
152 containing found sequences
154 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
157 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
158 Some fields in BinEntry must be copied to not seg fault when making the :
159 gdcm::File *copy = new gdcm::File( copyH );
160 and tests are now made on good variables
162 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
164 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
166 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
167 * Add vtkGdcmWriter example and test
169 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * Test/TestUtil.cxx : reformat the source code
171 * vtk/vtkGdcmReader.cxx : remove and change prints
172 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
174 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
175 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
177 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
179 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
181 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
183 by an eof to prevent all bad read of the file... and in this case, the
186 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * Example/Volume2Dicom.cxx : comment unused variables
188 * Test/PrintDicomDir.cxx : comment unused variables
189 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
190 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
191 method that is redondant with AddEntry.
192 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
195 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * Bug fix due my last commit (compilation under Windows).
197 * Example/Volume2Dicom : bug fix in the file and reformatting source code
198 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
200 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 - Remove printf / sprintf
203 - include iostream AFTER gdcm so we don't get warnings
204 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
206 - Also remove tons of include from header files, hopefully this should
207 speeup the compilation time, since it was becoming a dog slow.
208 - Remove gdcm.h as it include way too many files and slow down compilation
209 (plus it is not up to date)
210 - remove 'using namespace std' this is BAD !
212 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * Remove memory leaks on the DicomDir
214 * Remove some useless data in DicomDirObject
215 * Add usefull methods in SQItem, to be complient withe the ElementSet
217 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
220 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
222 future, with convertion)
223 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
224 and ImageDataSize values. Remove the method to get the PixelReadConverter
225 from the output of the class
227 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
230 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
232 and vtkErrorMacro use.
233 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
235 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
238 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
239 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
240 The string leaves only in the fonction. So when we make a .c_str(), we
241 get the pointeur on the first element, element that will be destroyed
242 immediately after thee instruction.
243 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
244 file has been opened : the test must be made on the content of the
245 pointer and not directly on the pointer !
248 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
250 the python part recompiles
252 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
254 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
255 X session is killed (for my computer... it seems to not be identic on
258 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
260 avoid problems (otherwise, the difference test between the visible image
261 and the reference is incorrect. If the reference is greater than the
262 screen resolution, it's produce errors).
263 Can be used for only one image. Can be used with a visible flag.
264 * vtk/vtkGdcmReader.cxx : remove commented codes.
265 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
266 under windows at compilation
267 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
269 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
271 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
273 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
274 tests on the image size X, Y, Z
276 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
278 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
279 between the class name and the file name
281 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/ : fix compilation warnings for the Write method (2 different
283 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
284 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
285 variable... create a static method in gdcm::Document to access to
286 this variable content.
288 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
290 file, to be accessed by other files (like gdcmFile). Remove commented
291 code. Move the change of the header to the gdcmFile, using the
293 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
294 To be sure of that (and simplify calls), the Write of the header now
295 gets a file name and not a file pointer (std::ifstream).
296 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
297 DocEntryArchive. Remove all open of the written file
299 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
302 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
304 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
306 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
307 some corresponding methods. Write correctly the file and check before
309 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
310 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
311 is now on RGB data (as before my last commit
312 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
314 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
316 Add a print information of the type of the entry
317 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
318 It was in the gdcmFile, and all write have been regrouped
319 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
320 Write correctly all dicom files (in decompressed mode only at this time)
321 * Test/ : test on files are now made using Raw data and not color data if
323 * Example/PrintFile.cxx : add more printings
325 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * Amelioration of code, remove some code copy. For the loading of
327 BinEntry (in gdcmDocument), add the test to verify if the file is already
330 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
332 remove a DocEntry in the header (push an empty DocEntry)
333 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
334 lines. Bug fix in the initialization of the PixelConvert and the
336 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
337 use in TestCopyDicom (now this test can run under windows... but fails)
338 * Test/TestCopyDicom.cxx : amelioration of the test :
339 - test the pixels written
340 - add test points to quickly find where is the error
341 - can set a file name input and output in arguments
342 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
343 amelioration of the test output
345 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
347 all replaced DocEntry's
348 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
349 Now, each needed DocEntry to modify is duplicated, modified and inserted
350 to the header using DocEntryArchive. Thus, after save, we can restore the
351 header initial state.
353 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
356 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
358 correct to copy it. The DictEntry is specified at the DocEntry creation,
359 then, it musn't change in the time.
360 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
361 header correctly. At this time, the change is only made for the first
362 level of the Document. In the future, it might consider sequences.
363 The change is made by replacing a DocEntry by an other that is created
364 outside the class. The old value is kept. When we restore the header
365 status, the added DocEntry is deleted and replaced by the old value.
366 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
367 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
368 set the write type to explicit VR, implicit VR or ACR. Add methods to set
369 the write mode to native, decompressed or RGB (but not used at this time)
371 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
373 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
375 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
377 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
379 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
380 set because already copied when copying the BinEntry's of the header
381 * Test/TestAllReadCompareDicom.cxx : remove warnings
383 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
385 Two problems appear when doing it :
386 - with the gdcmFile : when the GetImageData method is called, the pixels
387 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
388 data (pixels). And each structure destruct the data when it's
389 destructed. So we have two destructions for the same data. To solve it,
390 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
391 data or not. If it doesn't own data, then they will not destroyed by
393 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
394 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
395 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
396 create a double destruction of the same DocEntry's. So, to solve it,
397 the TagHT is simply cleared and the DicomDir* elements are destroyed.
398 * TODO : add an entry concerning memory leaks in the DicomDir
400 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
402 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
405 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
407 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
408 after it have been deleted
410 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * FIX: src/* fix the doxygen warnings.
412 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
413 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
414 was erroneously defined with a size of 15 instead of 16. [many thanks
415 to Jean Michel Rouet for pointing out this bug].
417 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
418 1. Finish merging JMR patch for writting DICOM from scratch
419 2. Fix -hopefully- bug with MONOCHROME and space vs null character
420 3. Use const ref when possible
421 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
422 5. A few more comments
423 6. CreateUniqueUID can now be called without parameter"
425 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * ENH: Slightly bigger patch:
427 1. Getting toward full integration of JMR patch for writting dicom from scratch
428 2. Update Test to test part of this patch: CreateUniqueUID
429 3. File was not close properly in gdcmDict
430 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
431 5. Use of const ref instead of copy (speed issue)
432 6. Remove temporary (duplicate) string in TranslateToKey
433 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
434 8. Do not repeat virtual in subclasses
435 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
437 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
438 * Apply first patch toward better string comparison when dealing with broken
439 DICOM files. Essentially the string could be padded with a space instead
440 of a null character as defined by standard
442 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
444 because never used... and in the same time, that's remove some memory leaks
446 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmFile.cxx : now delete the PixelConvert instance.
448 * In examples and tests : change the type of image data variables from void*
449 to uint8_t*. Remmove all delete on image data variables
451 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
453 Verify the file pointer value before open the file, and if it's not null,
454 a verbose message is generated.
455 Close correctly the file when the file isn't considered dicom-like. The
456 correctly close is a call to CloseFile.
457 When closing the file pointer, test if its not null to close the file.
458 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
459 file. For an uncompressed image, the copied data correspond in the least
460 case to the image size (calculated) or the image size specified in the
461 header. A verbose is generated if these two size mismatch
463 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
465 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
466 break under windows (with msvc6 compilation).
468 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
470 compiling with MSVC6)
472 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * Bugs fix for the Windows build with VC6
474 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
475 needed (only for projects required VTK). If the VTK is included in all
476 projects, there is conflicts with the jpeg lib of vtk when compiling the
477 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
478 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
479 when compiling the gdcm_wrap.cxx file (created by the compilation of the
481 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
482 (like it's already made for the cout use). Otherwise, conflict with the
485 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
488 - comments on the DicomDir::Method related usage added.
489 - now that we use the namespace gdcm, a lot of internal classes do
490 NOT need to be wrapped anymore.
491 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
492 DicomDir::Method) new example added.
494 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * Improve string manipulation. I now inforce the notion of 'DicomString'
496 A DicomString can contain as many \0 as they want
497 and it is *always* of even length.
498 We only support odd length for very rare case.
499 And in the near future this should be removed.
501 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
502 * /binary_write/ gdcm source. Now even on big endian we are writting
503 little endian. This should -heopfully- fix some tests
505 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
506 * Now the dictionary is compiled into gdcm lib. This is a default
507 behavior, thus any dic file specified is picked before failback to
508 the one comiled into lib
510 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
511 * Change internals for gdcmDict. Don't use any 'new' any more.
512 This should definitely solve any leak problem, and we should be
513 as fast as before, as long as don't modify too much the dictionary.
515 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
516 * STYLE: ivars should start with a capital letter.
517 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
518 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
520 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
522 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
523 new 2004 dictionaries added (thanks to JPR).
524 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
525 * CLEANUP_ROUND (15) for gdcmPixelConvert
526 - RLEFrame::NumberFragments is now of type unsigned int
527 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
528 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
531 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
532 * Initial work in gathering all transfer syntax accessors. clearly
533 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
534 ivars, but only one transfersyntax (class) ivar with equivalent method on
537 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
538 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
539 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
540 discussed (plus I didn't like having a 2000 lines patch not commited)
542 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
544 * CLEANUP_ROUND (14) for gdcmPixelConvert
545 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
546 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
547 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
549 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
550 anymore and hence avoids storing a copy of PixelConvert::Decompressed
551 into File::Pixel_Data.
553 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
555 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
556 * CLEANUP_ROUND (13) for gdcmPixelConvert
557 Substituted File::ParsePixelData() with PixelConvert::Print() new
559 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
560 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
561 method to those classes.
562 - src/gdcmFile.[cxx|h]:
563 -- Added a ::Print() method.
564 -- PixelConverter is now a reference instead of a member.
565 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
566 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
568 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
570 collaboration diagram and inheritance diagram should be generated with
572 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
573 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
574 pointlessly wrapped (see
575 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
576 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
577 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
578 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
579 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
580 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
581 -- File::Initialise: PixelConverter setup moved away to
582 PixelConverter::GrabInformationsFromHeader()
583 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
584 interpretation moved away to PixelConverter::BuildRGBImage()
586 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
587 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
588 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
590 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
592 displayed on Win32 when a brutal abort() occurs (because of uncatched
593 exception). See TODO new entry of this commit for more on this.
594 * TODO added new entry.
595 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
596 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
597 - HandleColor is no longer called from gdcmFile.cxx
598 - gdcmPixelConvert.cxx clean up on method arguments and internal
599 variable names for semantical coherence.
601 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
602 * Finished lossless transition, not only do we now read all lossless jpeg
603 images, without the need of the Cornwell lib, but we do read them properly now
604 * To reduce code (well to avoid code duplication), I defined a common place
605 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
606 redefine symbols. This is not prefect but this the best solution I found for a
607 compilation time jpeg option.
609 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
610 * Update jpeg ijg lib to support lossless jpeg implementation
611 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
613 * Also added a special copyright for dcmtk since we use their bugfixes.
616 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
617 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
618 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
619 matters, as stated in warning note at begining of %include section).
620 * src/gdcmDicomDir*.[cxx|h]: coding style
621 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
622 * src/gdcmJpeg8.cxx: doxygen fix.
623 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
624 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
625 from File:: to PixelConvert::.
627 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
629 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
630 - more code moved away from File:: to PixelConvert::
631 - fat setup of PixelConverter set in place in File::Initialise.
633 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
634 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
635 namespace at the file system level. So now you should convert your examples
637 gdcmHeader -> gdcm::Header
638 It would be nice if people keep in mind to no open the namespace, since it
639 allows compilation on broken plateform which were defining common symbol in
640 the standart namespace (like LP, Unknown ...)
642 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
644 The JPEG fragments are now parsed at the same stage than the RLE
645 information. All code related to JPEG is now in gdcmPixelConvert:
646 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
647 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
648 export a gdcmFile:: method. Those are simply global functions
649 (for the time being this is better than having them attach to
650 either gdcmFile:: or gdcmPixelConvert::).
651 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
652 and stores the result in a gdcmJPEGFragmentsInfo.
653 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
654 code (among other stuff) moved away from gdcmFile:; to
657 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
659 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
660 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
661 clean up of RLE related code.
662 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
663 - src/gdcmRLE.cxx removed
664 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
665 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
666 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
667 * CLEANUP_ROUND (9) for gdcmPixelConvert
668 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
669 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
670 away from gdcmFile:: to gdcmPixelConvert::.
672 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
674 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
675 This is because Parse7Fe0 used to parse the pixels to compute the
676 length. This task was passed over to FindDocEntryLengthOB() a long
677 time ago, EXCEPT I had forgotten the OW case...
678 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
679 we just recylce the code for parsing RLE fragments and computing
681 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
682 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
683 with the retired Parse7Fe0().
684 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
685 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
687 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
689 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
690 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
691 - src/CMakeLists.txt: alphabetic order reodering + new entries.
692 * CLEANUP_ROUND (4) for gdcmPixelConvert
693 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
694 to return an unused length.
696 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
697 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
698 this should be cleanner from the plane view. The iostream are erally a pain
699 to use to do simple stuff.
701 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
702 * Redo the compilation of the ijg jpeg library. Now only one source is
703 necesseray. No need to rename file by hand what so ever. CMake handle the
704 copying of the file within different directory, configure header file to
705 modify some symbol. The only addition made to ijg wasd a mangle table so
706 that symbol are different wether we are within 8bits or 12bits.
708 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * Added documentation of vtkgdcmReader on Website:
710 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
711 with it's binary name).
712 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
713 the Website to be more complete.
714 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
715 doxygenated documentation.
716 - Doc/DoxyVtkGdcmReaderExamples.txt added
717 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
718 DoxyVtkGdmReaderExamples.html )
719 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
720 * CLEANUP_ROUND (3) for gdcmPixelConvert
721 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
723 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * CLEANUP_ROUND (2) for gdcmPixelConvert
725 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
727 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * CLEANUP_ROUND for gdcmPixelConvert:
729 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
730 - src/gdcmPixelStuff[h|cxx] removed
731 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
732 - src/CMakeLists.txt changed accordingly
734 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
735 gdcmVersion.py moved to newly created ATTIC related
736 gdcmPython/SetupOldies/ directory.
737 * Autotools clean up:
738 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
739 - autogen.sh configure.in acinclude.m4 python.m4 removed
741 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * src/*.cxx *.h Reference to License.htm fixed to License.html.
743 * Doc/CMakeLists.txt, doxygen.config.in: fix.
744 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
746 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * TODO updated with Mathieu suggestions. I proposed a template for
748 describing TODO entries and used it for new entries.
749 * Added Doc/Website/CodingStyle.html, Developpers.html,
750 DeveloppersPython.html, GdcmDataCvs.html and
751 DownloadVersion0_1.html, DownloadVersion0_3.html.
752 * Some Doc/*.txt Doxygen files (which do not really concern the
753 documentation itself, but the website) moved to html and
754 placed in directory Doc/Website:
755 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
756 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
757 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
758 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
759 * CMakeLists.txt changed accordingly.
760 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
761 DeveloppersPython.html
762 * INSTALL nows refers to Doc/Website/Installation.html
764 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * Added Doc/Website directory, that contains a first raw version
768 2004-09-23 Jean-Pierre Roux
769 * FIX In order not to be poluted any longer by casting problems,
770 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
771 we can now delete[] it safely
772 * VoidArea is now called BinArea (less confusing name),
773 and all the methods called ...VoidArea... are now ... BinArea...
774 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
776 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
778 clear) TagHT, which is an inherited member of gdcmElementSet. It is
779 up to the destructor of gdcmElementSet to clean up TagHt and it's
782 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * Test/CMakeLists.txt: update to follow gdcmData renamings.
784 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
786 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * ENH: added some utility method that builds a flat dictionnary
788 holding all the Dicom entries contained in the recursive structure
789 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
791 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
792 BuildFlatHashTable() that build a flat dictionary.
793 - src/gdcmElementSet.h: added a new private GetTag() accessor.
794 gdcmDocument is now a friend of gdcmElementSet.
795 - src/gdcmElementSet.cxx: clean up.
796 - Example/FlatHashTablePrint.cxx added.
797 - Example/CmakeLists.txt changed accordingly
799 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
801 moved away from gdcmDocEntrySet (since this class is an abstract class
802 acting like an interface). SQDepthLevel and BaseTagKey are now
804 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
805 and associated accessors. Doxygenation of the class.
806 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
808 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
809 Use SQDepthLevel accessor instead. ::Print() adapted.
810 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
811 - src/gdcmDocument.cxx changed accordingly.
813 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
815 - The following is the doxygen comment of the typedef declaration
816 of gdcmagKey in src/gdcmCommon.h:
817 gdcmTagKey is made to old an "universal" (as in URL, Universal
818 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
819 A dicom tag allways has a group and an element, but a set of tags
820 embeded in various (optionally nested) sequences and sharing
821 the same group and element all share the same (group, element)
822 "identifier". Hence the (group, element) cannot be used as an
823 identifier (in gdcm we shall refer to a "TagKey") of a tag.
824 In order to construct a proper tag identifier (i.e. a key) we
825 consider the following definition of a TagKey:
826 - let Group, Element be the string representation of the
827 group and element dicom tag members,
828 - let ItemNumber be the string representation of the integer
829 index of the considered item number of a sequence,
830 Let the key of a tag embeded in a sequence, noted SeqTag, be
832 /ItemNumber#Group|Element
833 where "/", "#" and "|" are characters acting as separators.
834 Then the general form of a gdcmTagKey is given by:
835 Group|Element<SeqTag>
836 where <SeqTag> means NO or many instances of SeqTag.
837 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
840 but the gdcmTagKey of a tag "embeded" is the first item of
841 a sequence, itself nested in the third item of a sequence is the
843 0004|1220/2#0008|0082/0#0008|0090
844 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
845 order to hold the new sequence compatible key. Previously, the
846 GetKey() method would look in the underlying gdcmDictEntry.
847 - src/gdcmDocEntry.cxx:
848 -- constructor now copies the underlying DictEntry key, in the local
850 -- ::Print: displays the member Key, instead of the (group, element).
851 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
852 - src/gdcmDocEntrySet.h:xi
853 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
854 -- now has a new BaseTagKey member.
856 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
857 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
859 This poses the problem with the semantics of the following lines
860 LoadEntryVoidArea(0x0028,0x1201); // R LUT
861 LoadEntryVoidArea(0x0028,0x1202); // G LUT
862 LoadEntryVoidArea(0x0028,0x1203); // B LUT
863 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
864 to the long FIXME note for what the problem is. Nevertheless in
865 order to get things working the dicom dictionary was altered !
866 Please fix things urgently...
867 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
868 information), see above note on moving the member VoidArea. Nevertheless
869 the following entries previously correctly set as US are now inproperly
871 0028 1201 OW IMG Red Palette Color Lookup Table Data
872 0028 1202 OW IMG Green Palette Color Lookup Table Data
873 0028 1203 OW IMG Blue Palette Color Lookup Table Data
874 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
875 of gdcmDocEntry moved to gdcmSeqEntry.
876 * src/gdcmSeqEntry.cxx: STYLE.
878 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * Test/TestAllEntryVerify.cxx minor fix and added comments.
881 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * gdcmPython/testSuite.py: all the test suite in python is now moved
883 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
884 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
885 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
887 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
889 to avoid inclusion recursion until STL is reached.
890 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
891 mecanism. errno.h is not included in gdcm anymore.
892 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
893 (gdcmFormatError now inherits from gdcmFormatUnexpected).
895 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
896 gdcmData/TestAllEntryVerifyReference.txt
897 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
898 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
899 exception_on_error parameter.
900 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
901 - vtk/vtkGdcmReader.cxx changed accordingly,
902 - Example/*.cxx and Test/*.cxx changed accordingly.
904 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
906 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
907 enable_sequences removed from gdcmHeader constructor and dependencies.
908 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
909 * gdcmPython/demo/PrintHeader.py: dummy fix.
910 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
911 skip_shadow removed from gdcmHeader constructor and dependencies.
912 * Example/*.cxx and Test/*.cxx changed accordingly.
914 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
916 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
918 2004-07-21 Jean-Pierre Roux
919 * FIX Now, Parsing and Printing a DICOMDIR do work!
920 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
922 2004-07-20 Jean-Pierre Roux
923 * FIX Some brain damaged headers have Zero-Lenght fields
924 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
926 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
927 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
928 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
929 variable (instance of gdcmDebug) by a definition macro, and the instance
930 is now in static in the gdcmDebug class
931 * src/gdcmSQItem.h : (FIXME) remove an undefined method
932 * Test/PrintAllDocument.cxx : bug fix in the result of the test
934 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * WARNING: ctest now depends more tightly on gdcmData. You should
936 check out gdcmData properly for things to run smoothly...
937 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
938 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
939 we need the pixels not be loaded in order to use the ValEntry
940 that displays position and size).
941 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
942 This is a C++ based equivalent of gdcmPython/testSuite.py that should
943 be deprecated. If you have any doubts about the advantages of a
944 modern scripting language (read Python) versus grass root C++ (i.e.
945 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
946 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
947 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
948 Anyhow, consider documenting the gdcmData images in
949 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
951 * Test/CMakeLists.txt:
952 - now uses TestAllEntryVerify.cxx
953 - specific comments on oldACR00001.ima (now renamed in gdcmData
954 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
955 gdcmData/TestAllEntryVerifyReference.txt
958 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * src/*.[h|cxx] : typedef clean up
960 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
961 - TagKey renamed to gdcmTagKey (for external usage)
962 - VRKey renamed to gdcmVRKey (for external usage)
963 - removal of typedef duplication.
964 - Removed all unecessary inline keyword from class inline definitions.
965 - Some method|function(void) declarations replaced with method|function().
966 * src/jpeg/libijg12/jdhuff12.c:
967 - printf polluting ctest removed.
968 - TAB removal for comminting
970 - TestAllReadCompareDicom.cxx: added a test that compares all the
971 images in gdcmDataImages.h with corresponding images in
972 gdcmData/BaselineDicom/. When baseline images are not present
973 this test creates them.
974 Note: we need to validate each reference image, but before that
975 I'd like to rename them with a more explicit name...
976 - CMakeLists.txt: changed accordingly.
977 * Example/*.cxx: examples now only include gdcm.h (as opposed to
978 including each header needed).
980 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * Test/*.cxx and Example/*.cxx: moved some examples away from the
982 test suite to the Example directory. Are concerned:
987 - TestWriteSimple.cxx
988 * Test/CMakeLists.txt: added some comments on reasons for black listing
989 image gdcmData/oldACR00001.ima
991 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * Test/CmakeList.txt: removed the following from black list (to be coherent
993 with removal from gdcmData):
994 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
995 - gdcm-MR-PHILIPS-16.dcm
997 Added the following because after last cvs update, they cause
998 ctest -R TestReadWriteReadCompare
1000 - gdcm-MR-SIEMENS-16-1.acr
1002 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1003 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1004 new comments in this file) we temporarily (sigh) move to a weaker
1006 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1007 we don't need to black list the following images anymore:
1008 - 8BitsUncompressedColor.dcm
1010 - US-PAL-8-10x-echo.dcm
1011 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1012 fixes and the beautified code ;-)
1013 This fixes the bug introduced in version 1.42 (when beautifying)
1014 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1015 Note: ctest was blind to this bug (this means we need to still
1016 improve the test suite). The bug could be detected by using
1017 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1019 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1020 and by displaying the (garbage) produced file temp.XDCM...
1022 2004-06-29 Jean-Pierre Roux
1023 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1024 - replace by uggly but working old code :-(
1025 A lot of things should be OK again.
1026 It's really urgent to have a test suite that *tests*,
1027 to prevent Frog's beautifying sessions to break all the stuff
1028 (twice, withing a fortnigh ...)
1030 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1031 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1032 redundancy) to added Test/TestReadWriteReadCompare.cxx
1033 * Test/CmakeList.txt: because the compare test of
1034 Test/TestReadWriteReadCompare.cxx fails, the following images are
1035 black listed: - 8BitsUncompressedColor.dcm
1037 - US-PAL-8-10x-echo.dcm
1038 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1039 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1040 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1041 and ad-hoc kludge. This kludge is now removed, and on encountering
1042 such an image (OB field brain damaged) we set errno. Then in
1043 ::FindDocLength() we "fix" the length as being ALL what remains
1044 in the file (until EOF). We then proceed, hoping for the best...
1045 This fixes a SegFault in ShowDicom when trying to write such an
1047 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1048 (because TestWriteRead breaks on it, after a non conformal commit?).
1049 ctest now runs properly, except for MakeDicomDir (which was allways
1050 broken) and the Python related stuff (still not fixed).
1052 2004-06-24 Jean-Pierre Roux
1053 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1054 FIX : Test/TestReadWrite now iterates on all the file names
1055 (instead of infinite loop)
1056 ENH : Test/TestWriteRead now iterates on all the file names
1058 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1061 2004-06-24 Jean-Pierre Roux
1062 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1063 when SamplesPerPixel =3
1064 - now Write is no longer confused by
1065 'BitsAllocated = 12" and 'BitsStored=12"
1066 - "UN" value representation Elements are now written correctly
1067 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1068 ENH : - now gdcmHeader has its own Write methods
1069 (in order to split the job that has not to be done
1072 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1074 loop on the same image until memory went out.
1075 Note: this means we still have gobs of memory loss in PrintDocument
1076 * src/gdcmDocument.cxx: fixes problem on parsing on file
1077 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1079 2004-06-24 Jean-Pierre Roux
1080 FIX : Write - All the Sequences and Sequence Item are now written
1081 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1082 is added a the end, when necessary.
1083 - A lot of brain-damaged images, that were read correctly are
1084 now written correctly
1085 - length compatible BinEntry are now loaded correctly
1086 (even for odd groups)
1087 Note : only Explicit Value Representation was checked.
1088 (question : is implicit VR really necessary for gdcm ?)
1090 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * DEVELOPPER: added a proposition of coding style.
1092 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1095 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1097 Use the gdcmDocEntry::Print() and Write() instead.
1098 * src/gdcmDocument.cxx: bug fix.
1100 2004-06-22 Jean-Pierre Roux
1101 FIX : gdcmDocument.cxx
1102 - Now we do recognize the JpegLossLess format (there was a misstyping in
1103 code 'beautyfication' :-(
1104 - Now we automaticaticaly load the Luts, if any
1106 2004-06-22 Jean-Pierre Roux
1107 In order : to write Sequences, whatever their imbrication level,
1108 : to allow user to create his own Sequences
1109 a lot of modif where necessary (adding, moving, or virtualising methods)
1111 WARNING : save your own sources *before* cvs up !
1114 ADD virtual void Write(FILE *fp, FileType filetype);
1117 ADD virtual void Write(FILE *fp, FileType filetype);
1118 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1121 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1122 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1123 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1124 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1125 ADD std::string GetEntryByName(TagName name);
1126 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1128 std::string vr = "unkn",
1129 std::string fourth = "unkn",
1130 std::string name = "unkn");
1131 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1132 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1133 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1134 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1135 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1136 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1137 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1138 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1141 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1142 ADD virtual std::string GetEntryByName (TagName tagName);
1143 ADD virtual std::string GetEntryVRByName (TagName tagName);
1144 REM virtual bool Write(FILE *, FileType);
1145 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1146 FILE *_fp, FileType type);
1147 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1148 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1149 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1150 REM virtual std::string GetEntryByName (std::string tagName);
1151 REM virtual std::string GetEntryVRByName (std::string tagName);
1152 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1153 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1154 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1156 std::string vr = "unkn",
1157 std::string fourth = "unkn",
1158 std::string name = "unkn");
1159 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1160 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1161 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1162 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1165 ADD virtual void Write(FILE *fp, FileType filetype);
1168 ADD virtual void Write(FILE *fp,FileType filetype);
1171 ADD virtual void Write(FILE *fp, FileType filetype);
1172 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1173 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1174 REM std::string GetEntryByName(TagName name);
1177 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1179 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1181 The default constructor invoked by the line
1182 gdcmHeader *f1 = new gdcmHeader( header );
1183 was gdcmHeader::gdcmHeader(bool) instead of the expected
1184 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1185 Hence the parsing wasn't executed... See also below.
1186 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1187 as explicit constructor didn't do the trick to fix the above problem.
1188 Could anyone explain why ?
1189 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1190 properly calls gdcmValEntry::Print() (that was weed out from
1191 code related to gdcmBinEntry).
1193 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * In order to fix memory leaks:
1195 - Test/TestWriteSimple.cxx: added cleaning of free store through
1197 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1198 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1199 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1200 (through the call to ::AddDicomDirMeta()) or the destructor
1201 would crash when deleting uninitialized ::metaElems].
1202 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1203 - src/gdcmDocument.cxx:
1204 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1205 from dynamic stores.
1206 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1207 was causing memory leaks.
1208 - src/gdcmSQItem.cxx:
1209 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1210 cleanly handled with polymophism: sorry but my milage is low).
1211 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1212 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1213 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1214 This avoids SegFaulting.
1215 - src/gdcmSQItem.h: coding style.
1217 - Test/TestWriteSimple still severely sucks. The output image content
1218 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1219 damaged when displayed with vtkgdcmViewer.
1220 - on memory leaks: TestWriteSimple leaks really less (see entry
1221 of 2004-06-18 in Changelog file for the call to valgrind).
1222 - on segfaults: ctest now passes all the tests but one (no more
1224 * Erroneous leading white fix:
1225 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1226 white[s] (as opposed to from >> xxx, that removes it [them].
1227 - src/gdcmTS.cxx: ditto.
1228 - gdcmPython/testSuite.py: dirty related kludge removed.
1229 * src/*: remaining references to gdcmParser removed.
1230 * src/*[cxx|h]: added copy[way]left header.
1233 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * In order to fix writing of dicom files:
1235 - Test/TestWriteSimple.cxx: a simpler example of writing.
1236 - Test/CMakeLists.txt changed accordingly.
1237 - src/gdcmDocument.cxx:
1238 -- The destructor now recursilvely removes potential sequences.
1239 -- Bug fix in ::IsJPEG2000()
1240 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1241 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1243 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1244 to only declared) and build on top of
1245 ::GetDocEntryByNumber(guint16, guint16).
1246 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1247 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1248 for usage in destructor and treatement of promotion in
1249 ::ReplaceOrCreateByNumber().
1250 - src/gdcmSQItem.cxx: destructor should better handle his job.
1251 Test/TestWriteSimple now runs (or at least it DOES something).
1252 * We can now start hutting memory links. A good starting point is:
1253 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1254 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1255 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1257 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * Valgrind note: after Mathieu Malaterre teached me how to read
1259 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1261 Using gcc, you can force the STL to use malloc and to free memory as
1262 soon as possible by globally disabling memory caching.
1263 With 3.2.2 and later, you should export the environment variable
1264 GLIBCPP_FORCE_NEW before running your program.
1265 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1266 simply vanish (it is still not clear to me, whether this means that
1267 STL std::string leaks or if valgrind believes it leaks...).
1268 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1269 running bin/gdcmTests makeDicomDir):
1270 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1271 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1273 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1274 SegFaulting (I drowned in DicomDir related code when trying to
1275 understand why the list is empty...).
1276 * src/gdcmDocument.h: first BSD license header try.
1277 * Doc/License.txt added.
1279 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * src/gdcmDocument.[h|cxx]:
1281 - Clean up of the Transfer related predicates. They are now all based
1282 on new method isGivenTransferSyntax, that (should) handle properly
1283 the padding problem.
1284 - general clean up, simplification, and coding style.
1285 - Specific clean up of Parse7FE0() (umproperly named actually).
1286 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1288 2004-06-14 Jean-Pierre Roux
1290 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1291 - fix the display of SQItem ordinal number
1292 - add the GetSQItemByOrdinalNumber method
1293 - remove some useless never written private methods
1295 2004-06-14 Jean-Pierre Roux
1297 - adding a constructor taking a gdcmDocEntry as an input param
1298 - ReplaceOrCreateByNumber now returns :
1299 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1300 a gdcmValEntry * if a string value is passed as a param
1302 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1303 according to the param type (no longer sets a gdcmDocEntry)
1304 - GetValEntryByNumber, GetBinEntryByNumber added
1305 - NewValEntryByNumber and NewBinEntryByNumber added
1307 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1309 - GetSQItemNumber and SetSQItemNumber added, to provide
1310 a (relative) Item identier inside a given Sequence
1311 \warning : some pb remaining around this number
1313 - AddEntry now takes the Item Number as a param
1315 - adding a constructor taking a gdcmDocEntry as an input param
1317 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1318 * Memory leak hunt with the following command:
1319 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1320 --show-reachable=yes gdcmTests PrintDocument
1321 It looks like many (all?) leaks are due to the STL (or a bad usage
1322 of the STL. The lines producing the leaks now have a comment with
1323 a "MEMORY LEAK" tag: you can retrieve them with
1324 grep "MEMORY LEAK" src/*
1325 Here are two typical examples which I can't help fixing:
1330 char * test = "babo";
1331 name = test; //// <--- valgrind detects 960 bytes lost in
1332 //// call to std::string::operator=(char const*)
1333 name.clear(); //// Doesn't help !
1341 std::cout << "Type a bunch of characters followed by RETURN: ";
1342 getline(std::cin, line); //// <--- valgrind dectects a loss
1343 //// of 1320 bytes in call to
1344 /// std::basic_istream<>& std::getline<>
1350 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * src/gdcmHeader.[cxx|h]:
1352 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1353 and related, moved away to gdcmDocument.
1354 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1355 the corresponding protected accessors of inherited class
1356 gdcmDocument, removed ! As a consequence gdcmFile had to be
1357 declared friend of class gdcmDocument (see below).
1358 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1359 - Clean up of undefined or unused methods.
1360 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1361 account the changes to gdcmHeader.h).
1362 * src/gdcmDocument.h:
1363 - gdcmFile is now a friend class (in order to take into account the
1364 changes to gdcmHeader.h).
1365 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1366 (see changes to gdcmHeader.h).
1367 - Accessors (reading on the form GetEntry*) are now public.
1368 - Clean up of undefined or unused methods.
1369 * src/gdcmDocument.cxx:
1370 - adaptation to changes to gdcmDocument.h
1371 - ::OpenFile now writes a verbose message when file cannot be opened.
1372 - some std::string properly set to VRKey
1373 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1374 references to gdcmDocument.
1375 * Test/TestFindTags.cxx: changed accordingly to above changes.
1376 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1377 cvs repository gdcmData.
1379 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1380 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1381 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1382 conflicts with gdcmValEntry::voidArea.
1383 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1384 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1385 Value representation between StringRepresentable and BinaryRepresentable.
1386 * src/gdcmDocument.cxx:
1387 - method ParseDES: proper indentation restored and usage of
1388 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1389 - method LoadDocEntry: the fingerprint left in the SetValue() of
1390 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1391 removed. Reverting to previous code segment with the proper
1392 dynamic_cast< gdcmValEntry* >.
1393 Note: this was (partially) breaking the python test suite
1394 (gdcmPython/testSuite.py) that made usage of the above
1395 fingerprint to check presence of "Pixel Data".
1396 * src/gdcmDocEntry.h: coding style.
1397 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1398 now taken into account.
1399 * gdcmPython/gdcm.i: adaptation to the new internal representation
1400 of gdcm (exit gdcmParser, hello gdcmDocument).
1401 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1403 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1404 anymore, but instead prints the loaded Python dictionary.
1405 * .... alas, the python testSuite is still broken.
1407 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1408 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1410 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1411 * src/gdcmUtil.h : export methods
1413 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1414 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1416 * Initial addition of automatic python testing
1417 * Initial addition of automatic image comparison
1419 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1420 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1421 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1423 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1424 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1425 * Test/ShowDicom.cxx : bug fix for msvc compilation
1426 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1428 2004-05-04 Jean-Pierre Roux
1429 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1430 new concepts (and new classes) :
1431 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1432 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1433 - Sequence Doc Entries (gdcmSeqEntries)
1434 a Sequence is composed of Items.
1435 Each item is a set of Doc Entries (this is recursive)
1436 The non uniqueness of the 'Dicom tag' is due to this recursivity
1437 (never taken into account)
1438 Our unability to add a new 'entry' in the header
1439 at the proper location (neither in the H-Table (map or multimap),
1440 nor in the Chained List is also due to this recursivity.
1441 Don't try, right now, to use/modify/compile these new sources :
1442 nothing is finished.
1443 We just commit all the stuff, 'as is', in order not to loose it.
1445 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1446 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1448 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1449 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1450 file prefix (SetFilePrefix)
1452 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * Add a new test: ShowDicom, for now this is just the c++ version of
1454 checkRead.sh, later it will be able to compare the image read against a
1456 * Replace the DEBUG on the stack with a global entry in cmake interface:
1457 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1459 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * Add an example subdir, with a real example on how to read + write a
1463 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1465 * Doc/CMakeLists.txt: the main page is now properly differentiated
1466 between the developper and user version.
1467 * Doc/doxygen.config.in: dropped search related obsolete flags
1468 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1470 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1471 * DEVELOPPER: added some helpfull comments for compile/test/install
1474 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1476 src directory, now generated in the build dir.
1477 2. Tests as mentionned smarter
1479 4. Add a new method in gdcmDict that return the PubDict by name
1480 this is interesting for 3rd party lib like ITK,
1481 where we could set the institution name / patient name...
1483 * ENH: 1. Now the test suite is working for real
1484 2. All binaries are now output in the gdcm-bin directory
1485 (this was not true before)
1487 2004-04-28 Jean-Pierre Roux
1488 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1489 SeQuence indented printing of Dicom Header.
1490 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1491 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1492 Computation of SQDepthLevel is now part of gdcmHeader constructor
1493 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1494 tree-like structure of a Dicom Header.
1495 * FIX Test code cleaning
1497 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * ENH: Adding automatic testing
1499 1. Need a DartConfig.cmake to submit to public
1500 2. Add a test driver gdcmTest.cxx
1501 3. gdcmTestMain, an helper for the main test driver gdcmTest
1502 4. Files in Test don't have a main anymore, this becomes interesting
1503 when we add more and more tests, thus dsw don't have to load
1505 * ENH: Adding a GDCM_DATA_ROOT for testing
1506 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1507 one file instead of seven + some small cleanup
1509 2004-04-22 Jean-Pierre Roux
1510 * ENH Minor changes to the Print() methods.
1511 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1512 Header printing. Example given with :
1513 > PrintHeader fileName 2 new
1514 (SQ based tree-like structure still to be done for the Header ...)
1516 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1518 1. I have added some unsigned where needed
1519 2. Some function parameter not used -> (void)
1520 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1521 4. g++ don't like character '\' in comment
1522 5. #define jpeg_create_decompress jCreaDecompress
1523 this really need to be fixed
1524 6. virtualize destructor of gdcmObject ... leakage
1525 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1526 this also really need to be fixed
1527 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1528 remove compression file
1529 (as we only do decompression, right ?)
1530 * ENH: Change malloc/calloc/free with c++ equivalent
1532 2004-04-21 Jean-Pierre Roux
1533 * FIX gdcmHeaderHelper::GetXSpacing
1534 when a single value is found (bug ?), xpacing is now
1535 defaulted to yspacing
1537 2004-04-19 Jean-Pierre Roux
1538 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1539 * ENH add parameters :
1540 bool exception_on_error = false,
1541 bool enable_sequences = false,
1542 bool ignore_shadow = false
1543 to the gdcmFile constructors to be full gdcmParser compliant
1544 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1545 to allow reading of PAPYRUS 3.0 files
1547 2004-04-06 Jean-Pierre Roux
1548 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1550 2004-04-02 Jean-Pierre Roux
1551 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1552 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1553 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1555 2004-03-30 Jean-Pierre Roux
1556 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1557 for ACR file, written out as DICOM files (hope so...)
1559 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1561 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1562 moved to base class gdcmParser and only the specialisation is kept
1564 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1565 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1566 already does the job.
1567 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1568 (to be consistent with gdcmParser::WriteEntries).
1570 2004-03-30 Benoit Regrain
1571 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1572 upate of the object's instance. It's passed to 2 in the unfavorable
1573 case : one in the ExecuteInformation, one in the ExecuteData
1575 2004-03-29 Jean-Pierre Roux
1576 * ENH : Check on file type to be written moved
1577 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1578 * FIX : gdcmObject::ResetBoundaries now stops properly
1579 when end-of-list is reached
1580 : gdcmVersion modified (as Benoit Regrain asked)
1582 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1584 * src/gdcmUtil.cxx: added forgotten iostream include.
1585 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1586 equivalent to ExplicitVR in existing code).
1588 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1590 now contains all the gdcmGlobal related code.
1591 * minor coding style and doxygenation changes.
1593 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1594 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1595 now contains all the Debug related code.
1596 * minor clean-up of includes in src/*.cxx
1597 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1598 CreateCleanString) removed.
1599 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1600 * Doc/DoxyMainPageUser.txt added.
1601 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1602 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1603 src/gdcmDirList.cxx)
1605 2004-03-24 Jean-Pierre Roux
1606 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1608 2004-03-23 Jean-Pierre Roux
1609 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1610 big endian made volumes
1611 * ENH Now gdcmParser constructor and destructor are protected to forbid
1612 end user to instanciate class gdcmParser
1613 (only gdcmHeader and gdcmDicomDir are meaningfull)
1615 2004-03-22 Benoit Regrain
1616 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1617 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1618 gdcmSerie to gdcmDicomDirSerie
1620 2004-03-19 Jean-Pierre Roux
1621 * ENH Now the tree-like structure describing a DICOMDIR comming from
1622 an already existing DICOMDIR file is consistent with
1623 the home-made tree-like structure build ex-nihilo
1624 or build from the files held (recursively) in a Directory
1625 functions gdcmDicomDir::CheckBoundaries()
1626 gdcmObject::SetBoundaries() added
1628 2004-03-17 Jean-Pierre Roux
1629 * REM (Eric Boix bug) : removal of meaningless
1630 gdcmDicomDirImage::NewImage function.
1631 * FIX now file names and directory name are written properly in the
1633 * FIX now gdcmDicomDir constructor may be call without any trick
1636 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1637 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1638 of gdcmDicomDirImage::NewImage as empty function.
1640 2004-02-28 Jean-Pierre Roux
1641 * ENH add gdcmDicomDir:NewPatient
1642 add gdcmDicomDirPatient:NewStudy
1643 add gdcmDicomDirStudy:NewSerie
1644 add gdcmDicomDirSerie:NewImage
1645 to allow making gdcDicomDir object.
1646 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1647 (as opposite to the gdcmHeader chained list)
1649 2004-02-11 Benoit Regrain
1650 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1651 when using from python
1653 2004-02-10 Benoit Regrain
1654 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1655 * FIX : in gdcmDicomDir when the directory is empty
1656 * ENH : add callback and methods to get the progression of dicomDir
1659 2004-02-06 Jean-Pierre Roux
1660 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1661 - GDCM_META added to gdcmDicomDirType
1662 - class gdcmMeta created
1663 * ENH : - A brief summary is now displayed at the beginning of
1664 'testDicomDir' to help disaster magnitude estimation
1665 * REM : Now useless Test/explDICOMDIR.cxx
1667 2004-02-05 Benoit Regrain
1668 * ENH : add methods in gdcmObject to get the hash table or the list of
1670 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1671 * FIX : wrapping python for TagHeaderEntryHT
1673 2004-02-04 Benoit Regrain
1674 * FIX : even length for some strings when writting the dicom dir
1675 * FIX : sort the images in the dicom dir
1676 * FIX : Bug fix for python use of dicom dir
1677 * ADD : a python demo
1679 2004-02-04 Jean-Pierre Roux
1680 * FIX : Final solution (?) for icone embedded images
1681 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1682 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1683 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1684 gdcmData/gdcm-MR-SIEMENS-16.acr1
1685 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1686 to make full checking easier
1688 2004-02-04 Benoit Regrain
1689 * FIX : WriteEntries : coding style & logic in parameters
1690 * FIX : Set the elements to create the DicomDir in a dictionary file
1692 2004-02-03 Benoit Regrain
1693 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1694 * gdcmDicomDir : add the load of directory
1695 * Bug fix and print add-on
1697 2004-02-03 Jean-Pierre Roux
1698 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1699 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1700 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1701 * FIX gdcmParser.cxx : 'group length' elements are now considered
1702 as integers, even for shadow groups, when file is Implicit VR
1704 2004-02-02 Jean-Pierre Roux
1705 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1707 of the last synonym :-(
1708 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1710 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1711 * FIX taking into account the possible 7fe0,0010 multiplicity
1712 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1713 to allow removal of references to 7fe0,0010, to deal with
1714 ACR-NEMA images, when 0028,0200 is meaningfull
1716 2004-01-31 Jean-Pierre Roux
1717 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1718 no longer writes 'Un' on disk
1719 * FIX SQ elements with actual length are now dealt with corectly
1720 * FIX gdcmFile::WriteBase make the difference, for color images, between
1721 the length (for Palette expanded images)
1722 and Raw Length (non expanded image + Palette)
1723 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1724 (that broke Write). Replaced by UL.
1725 Aware user will reload the field if he
1726 thinks it's necesssary
1728 2004-01-30 Jean-Pierre Roux
1729 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1730 when 'dirty Acr' is found, to be compliant with the new
1731 IsReadable() methods.
1733 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1734 (no DOUBLE images in kosher DICOM,
1735 but so usefull for people that miss them ;-)
1737 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1738 DICOMDIR related utilities (not checked as Windoze compliant)
1740 2004-01-28 Jean-Pierre Roux
1741 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1743 2004-01-27 Jean-Pierre Roux
1744 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1745 to allow skipping the shadow elements, to save memory space.
1746 The TRUE value for this param has to be used
1747 with a FALSE value for the 'enable_sequence' param.
1748 ('public elements' may be embedded in 'shadow Sequences')
1749 * gdcmHeader methods now deal with 'embedded icones images' in the header
1750 (even when an 'icone image sequence' is announced by the
1751 element (0x0088,0x0200), but there is NO icone at all ...
1753 * gdcmHeader sometimes Image Location value doesn't follow
1754 the supposed processor endianity (see gdcmData/cr172241.dcm).
1757 * gdcmHeader add the method
1758 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1759 to get *all* the Header Entries with the same tag.
1760 GetHeaderEntrySameName is probabely *useless*
1761 (no meaning : Name is *not* an identifier within the Dictionnary)
1763 2004-01-26 Benoit Regrain
1764 * Bug fix in the print of hexadecimal representations. Remove long fields
1765 in the print and add a third level of print to print them
1767 2004-01-23 Benoit Regrain
1768 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1769 * Bug fix on test suite after remove the strip made on not string fields
1770 * Split the IsReadable method between gdcmParser which test that the file
1771 is dicom and gdcmHeader which test that it's an image file
1773 2004-01-22 Benoit Regrain
1774 * DicomDir : clean code, add methods, set variables in protected or private
1775 * gdcmUtil : bug fix for the clean string method
1777 2004-01-19 Benoit Regrain
1778 * Add the use of shadow dictionaries
1779 * bug fix and coding style
1781 2004-01-19 Benoit Regrain
1782 * src/gdcmFile.cxx : bug fix concerning the close of file
1783 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1784 * Add the update of header entries using the shadow library
1786 2004-01-19 Benoit Regrain
1787 * removal of file gdcmHeader2.cxx
1788 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1789 inheriting from gdcmParser. This split is to prepare the integration
1790 of dicom dir parsing
1791 * bug fix under python
1793 2004-01-16 Jean-Pierre Roux
1794 * REM removal of class gdcmHeaderEntrySet
1795 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1796 * ADD add file gdcmHeader2.cxx
1797 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1799 2004-01-15 Benoit Regrain
1800 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1801 entries created while parsing the header. Thus, they will be destroyed
1802 when the gdcmDictSet will be destroyed
1803 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1806 2004-01-15 Benoit Regrain
1807 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1808 made a fatal error because of the memory release at the end of program.
1809 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1810 some memory and vtk seems to have some problems with that.
1811 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1813 2004-01-14 Benoit Regrain
1814 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1815 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1816 * src/*.[h|cxx] : make changes due to class name changes
1817 * gdcmPython/demo/*.py : bug fix due to method names
1819 2004-01-13 Benoit Regrain
1820 * src/*.[h|cxx] : coding style
1821 * vtk/*.[h|cxx] : coding style
1823 2004-01-13 Benoit Regrain
1824 * gdcmPython/testSuite.py : test the readable flag of file for tests
1825 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1826 It's lied to the stl compilation by MSVC (windows, always windows...)
1827 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1829 2004-01-12 Benoit Regrain
1830 * src/*.h : add comments
1831 * src/gdcmDictSet.h : set the method BuildDictPath in public
1832 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1833 directly setted in the source code
1834 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1837 2004-01-09 Benoit Regrain
1838 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1839 * setup.py : use a reference to gdcmVERSION
1841 2004-01-07 Benoit Regrain
1842 * Modification to compile with the distutils.
1845 2003-12-10 Benoit Regrain
1846 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1847 can use a gdcmHeaderHelper to load data
1848 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1849 made in the source code
1851 2003-12-10 Benoit Regrain
1852 * Update Windows projects and .cvsignore files
1854 2003-11-12 Jean-Pierre Roux
1855 * ENH gdcmHeader constructor has one more parameter (default value : false)
1856 that allows the user to 'go inside' the SeQuences only
1858 gdcmElValSet:Print takes it into account
1860 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1861 * ENH: Update gdcmPython/CMakeLists
1862 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1863 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1865 2003-11-10 Jean-Pierre Roux
1866 * FIX : gdcmHeader::LoadElements is now based
1867 on the ListTag listElem member,
1868 not longer on the TagElValueHT tagHt member
1869 * ENH : PrintPubElVal shows (temporarily) both results,
1870 with the tagHt member and the listElem member.
1871 (it's easier to 'see' the problems when using Printheader)
1873 * FIX : old private member LgrElem is now splitted into
1874 ReadLength : Length actually found on disk (updated only
1875 if bug fixing is necessary), for internal
1877 UsableLength : Updated by FixFoundLength, to fix a bug
1878 or to allow Parser going on.
1879 Will allow to re-write a kosher header when a SeQuence
1880 with a length (not 0000) is found
1881 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1882 because gdcmElValSet::Add does not update ListElem
1885 2003-11-07 Jean-Pierre Roux
1886 * FIX misstyping in Transfert Syntax name table
1887 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1888 when they have an actual length (not 0000 nor FFFFF)
1889 (Nobody should care of it, but DICOMDIR explorers)
1891 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1894 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: vtkGdcmReader now supports LUT !
1896 (vtkgdcmViewer for now is not able to use them though)
1898 2003-11-05 Jean-Pierre Roux
1899 * in testSuite.py : new files names for checking the package
1900 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1901 that returns the pixel area size to the *aware* (vtk) user
1902 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1904 2003-11-05 Benoit Regrain
1905 * in testSuite.py : Modify the rules for checking the paths
1906 : Explicit error messages
1907 * in __init__.py : Related modif
1909 2003-11-03 Jean-Pierre Roux
1910 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1911 to be used by aware (vtk) users that want to manage
1912 LUT (and no to turn the PALETTE image into an RGB pixels one)
1913 * GetPixelType now returns 8U for 24 Bits images
1914 (vtkGdcmReader compliant)
1916 2003-10-31 Jean-Pierre Roux
1917 * Removal of *all* gdcmData images and add them again
1918 in order to loose the 'history' of un-anonymised images
1920 2003-10-31 Jean-Pierre Roux
1921 * RMV : removal of useless jBitsInJsample.h
1922 for both 8 and 12 Bits JPEG Lossy Libraries
1924 2003-10-31 Jean-Pierre Roux
1925 * ENH : Add the functions gdcmFile::GetImageDataRaw
1926 gdcmFile::GetImageDataIntoVectorRaw
1927 that act as GetImageData and GetImageDataIntoVector
1928 except the making of an RGB Plane from Gray Plane + LUT
1929 Intended to aware (vtk) users who know how to manage
1932 GetLUTRGBA return a R,G,B,A LUT if any
1933 lgrTotaleRaw gives the 'Raw' length
1934 GetImageDataRaw returns the gray Plane
1935 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1936 (They stay Grey, just like with other Dicom viewers :-(
1938 2003-10-30 Jean-Pierre Roux
1939 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1941 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1942 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1943 being coherents dicom files.
1945 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1948 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1949 * ENH: Two steps is necessary to please VC++ compiler...
1950 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1951 * ENH: Add include dir to medcon lib
1952 * FIX: only one function is being exported for now !
1953 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1955 2003-10-29 Jean-Pierre Roux
1956 * adding gdcmHeader::GetLUTRGBA
1957 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1958 --> Mathieu, the modif u're waiting for is not yet committed
1959 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1961 2003-10-27 Jean-Pierre Roux
1962 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1963 00191113.dcm DermaColorLossLess.dcm
1964 MxTwinLossLess.dcm RadBWLossLess.dcm
1965 * ENH: For version prior to vtkImageViewer2 -r 1.19
1966 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1968 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * Removal of ido stuff in CMakeLists.txt
1971 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1972 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1973 * FIX: remove a call to ->Modified ... see comments
1974 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1976 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * FIX: Problem with path for libvtkgdcmPython
1978 * ENH: Try adding a search script for python site-package
1979 * RMV: Remove some file from medcon lib that are not necessary
1980 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1981 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1982 * FIX: More pragma disable fro VC++,
1983 I don't think I break something as it is also disable in VTK/ITK.
1984 But it fasten debug compilation time.
1986 2003-10-23 Jean-Pierre Roux
1987 * gdcm now deals with 16 Bits Run Length Encoded images
1988 (they are compressed as 2 planes images,
1989 one for the high Bytes, the other for low Bytes)
1991 2003-10-22 Jean-Pierre Roux
1992 * Now CheckRead takes into account :
1993 - the bugged 'Leonardo' Siemens images
1994 - the XA images, sent thru the burning VPRO station
1995 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1998 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * FIX: When copying a Makefile.am to CMakeLists.txt
2000 one should remove the '\'
2002 2003-10-22 Jean-Pierre Roux
2003 * in gdcmData adding a bugged 'Leonardo' Siemens image
2004 (wrong lengths in header)
2005 OK with gdcm, KO with the other viewers :-)
2006 * add a GE dlx XA image, thru the VEPRO burning station
2009 2003-10-21 Jean-Pierre Roux
2010 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2011 for a brutal checking of vtkgdcmViewer compliance
2013 2003-10-21 Jean-Pierre Roux
2014 * add the files for 'xmedcon' Jpeg Lossless library
2015 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2017 2003-10-21 Jean-Pierre Roux
2018 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2020 2003-10-21 Jean-Pierre Roux
2021 * garbage Siemens 'Leonardo' images dealt with
2022 (the patch is easy to remove)
2023 * cosmetic changes to avoid warnings
2025 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2026 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2027 no need to press 'r' now.
2029 2003-10-20 Jean-Pierre Roux
2030 * upgrade of checkRead.sh checkWrite.sh according
2031 to new Jpeg Lossless decompressor
2032 * add US.3405.1.dcm, a genuine RGB medical file ...
2033 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2034 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2036 2003-10-15 Jean-Pierre Roux
2037 * general anonymisation in gdcmData
2038 * adding the 'color files' from
2039 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2040 * adding some well knowed bugged-header images
2041 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2042 waiting for their inclusion in Python testsuite
2044 2003-10-15 Jean-Pierre Roux
2045 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2046 no longer seg faults when file is not found
2048 2003-10-14 Jean-Pierre Roux
2049 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2052 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2053 * TODO: *.in file to genereate a UseGDCM later
2055 2003-10-14 Jean-Pierre Roux
2056 * Some supposed-to-be Dicom Images have no preamble.
2057 OpenFile takes it into account
2058 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2059 * Missing elements added in dicomV3.dic
2060 (just to be affraid : have a look at
2061 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2062 and do it again next year ;->
2064 2003-10-13 Jean-Pierre Roux
2065 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2066 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2067 But there are NOT. It's fixed !
2069 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2070 * FIX: "jpeglib.h" was not found on VC++
2071 * FIX: vtkgdcm was not being installed
2073 2003-10-10 Jean-Pierre Roux
2074 * ENH : OpenFile closes the file if it *really* doesn't look like
2075 an ACR-NEMA / DICOM one.
2076 * FIX : testWrite no longer writes an empty file if the source file
2077 is not gdcm Readable
2078 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2081 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2082 * FIX: CMake generate now documentation
2083 * ENH: out of source doc build !
2084 * ENH: Generate both user and dev documentation
2085 * ENH: Should work on windows too
2086 * ENH: Only one doxygen config.in file is needed
2087 * FIX: make install should be ok now on ùnix plateform
2088 * FIX: PATH to dictionary was wrong (missing /)
2089 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2091 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2092 * vtkGdcmReader is now able to read rgb dicom file.
2093 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2094 * added a gdcmViewer to vtk test, use mouse to control
2095 window level & window width
2097 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * CMake-ification of gdcm, we have now two build system
2099 * FIX: on cygwin Wsock32 doesn't exist
2100 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2102 2003-10-06 Emanuel Ollart
2103 * FIX : compilation process wad broken.
2104 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2106 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2107 * change gdcmViewer -> vtkgdcmViewer
2108 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2110 2003-10-06 Jean-Pierre Roux
2111 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2112 ( e.g : well known GE images with a wrong elem length,
2113 : Philips MRI Images with a wrong Huffman table)
2114 * still to be done : allow the reading of bugged LEONARDO Siemens images
2116 2003-10-03 Jean-Pierre Roux
2117 * Odd length strings are padded with '\0' (not with spaces,
2118 to remain compliant with already defined strings,
2119 like Transfert Syntax UID and others)
2121 2003-10-03 Jean-Pierre Roux
2122 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2123 to allow displaying RGB images (not only by affim ;-)
2125 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2126 * vtkGdcmReader is now able to read rgb dicom file.
2127 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2129 2003-10-03 Jean-Pierre Roux
2130 * A few nasty patches to allow the reading of a lot of nasty images
2131 ( e.g : well known GE images with a wrong elem length,
2132 : Philips MRI Images with a wrong Huffman table)
2133 * still to be done : allow the reading of bugged LEONARDO Siemens images
2135 2003-10-03 Jean-Pierre Roux
2136 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2138 2003-10-03 Jean-Pierre Roux
2139 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2140 to allow displaying RGB images (not only by affim ;-)
2142 2003-10-03 Jean-Pierre Roux
2143 * gdcmFile::GetImageDataIntoVector now
2144 - deals with MultiFrames MultiFragments Run Length Encoded files
2145 - deals with YcBcR (YBR_FULL) files
2146 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2147 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2149 (no sample found :-(
2151 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2153 Two reasons: - clear things
2154 - third parties acces gdcm through header files, so won't
2155 suffer anymore VC++ complains
2157 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * add argv[1] in testvtkGdcmReader.cxx
2161 2003-09-24 Jean-Pierre Roux
2162 * The lines are now eigthy characters long.for
2163 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2165 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2166 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2167 char* to std::string. Thus, the use of strdup becomes useless. (see
2168 previous commis of Malaterre)
2169 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2170 before the last Malaterre's commit.
2172 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2173 * This commit should fix the Debug building under VC++, the problem
2174 was mainly a mixture of debug and release lib being loaded at startup.
2175 * I also remove a depency to a specific C function: strdup. Because I had
2176 to force the link to msvcrtd (whereas strdup is in libc).
2178 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2179 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2180 located in the gdcmCommon.h file. All use of reference of tha has been
2181 changed to now use the variable GDCM_UNFOUND.
2183 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2185 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2186 Dicom dictionary. The test suite can now be run again. Note:
2187 I'm note very happy with the " (RET)" changes. I believe this
2188 RETAINED comment should be dropped when parsing the dictionary.
2189 - PACKAGER corrected
2191 - AUTHORS updated and now in alphabetical order
2192 * Makefile.am now exports gdcm.dsw for Windoze users.
2194 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2195 * cygwin complains about missing std:: in subdir Test/
2197 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2198 * remove some methods that are now in gdcmHeaderHelper
2200 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * vtkGdcmReader set spacing and origin correctly
2203 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * Fix a few delete/delete[] mismatch
2206 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2208 interpretation to data given by gdcmHeader. For instance there are
2209 heuristics to get informations (look at different places).
2210 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2211 sorting DICOM images based on different strategies.
2212 * modified Makefiles accordingly.
2214 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2216 when building in debug mode
2217 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2218 src/win32/gdcmdll.dsp
2219 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2221 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2222 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2225 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * src/win32/libgdcmjpeg12.dsp was not dos format
2227 * src/win32/libgdcmjpeg12.dsp :
2228 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2229 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2231 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2232 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2234 * src/gdcmFile.cxx : bug fix in affectation type
2235 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2236 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2237 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2238 symbols... future problem ?
2240 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * src/win32/libgdcmijpeg12.dsp was missing
2242 * modified gdcm.dsw accordingly
2244 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2245 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2247 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2248 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2249 commit of JPR (before his hollidays to facilitate our work).
2250 * setup.py : bug fix in code. Modifications made while the last commit
2251 of JPR. The code hasn't been tested before the commit... it's so
2252 useless to make that (for best programmer that is JPR) !!!
2254 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * tagged the current version as Version0_3 (i.e. version 0.3)
2257 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2258 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2259 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2260 * *.dsp : modifications to use new libgdcmijpeg8 library
2261 * setup.py : bug fix on VTKPATH variable
2262 * PACKAGER : adding all concerning windows
2264 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2267 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2268 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2269 test suite reported error.
2270 * PACKAGER file added (describes what a packager must do when
2271 packaging a new release).
2272 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2273 * configure.in: upgraded version number to 0.3.0
2274 * fixing build of rpm (through rpm -ta):
2275 - Doc/Makefile.am exports proper doxygen files
2276 - src/jpeg/libijg8/Makefile.am exports the include files.
2278 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2279 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2280 * src/gdcmHeader.h : formatting code
2282 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2283 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2284 We were obtaining error message from vtk. Now, creation of file list
2285 is made in an internal list to prevent this problem.
2286 Bug fix when output is empty.
2287 Bug fix in update of progress value. Previous commit for this was a bad
2289 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2291 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2292 * src/gdcmHeader.h : added method to get the file name
2293 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2294 files. Added method to remove all files on the input
2295 Added FIXME comment concerning the bad parsing of header made by
2296 ExecuteInformation method (in ExecuteData method)
2298 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2300 when using make instal.
2301 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2302 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2304 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2305 * setup.py : adding include dir of jpeg lib to compile all sources
2306 * */Win32/*.dsp : JPR fix for windows compilation
2308 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2309 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2311 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2312 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2314 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * setup.py is again effective on un*x (takes into account the
2316 addon of the jpeg library)
2317 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2318 * Doc/Doxy* updated (includes above enhancements)
2319 * INSTALL now points to web documentation
2321 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * src/gdcmHeader.h doesn't make unnecessary reference to
2324 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2326 * src/gdcm*.[cxx|h] :
2327 - to allow compilation with gcc 3.x
2328 -- clean up of STL usage (added explicit usage of std::)
2329 -- small fixes on exceptions.
2330 Note: linking not tested !
2331 - clean of doxygen comments to avoid warnings at documentation
2333 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2334 dependent convertion).
2336 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * Clean up of previous JPR garbage commit (not even commented in the
2339 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2340 - moved all jpeg related files from src to src/jpeg/libijg8, with
2341 addition/modification of Makefile.am and configure.in.
2342 - the testSuite is still brain damage (not guilty).
2344 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2345 * WrapVTK.py : modifications to get correctly vtk source files to
2347 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2348 (FileName -> Filename)
2350 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * vtk/vtkGdcmReader.[cxx/h]:
2352 - UpdateProgress method should now be effective
2353 - removed the limitation on having only images loaded (as opposed
2355 - when building a stack of images/volume, a lesser number of
2356 gdcmHeader and gdcmFile instances should be used (hopefully
2357 accelerating things).
2358 - when building a stack of images/volumes, files which are not
2359 loadable (wrong path-filename, wrong permissions on existing file,
2360 or file not parsable by gdcm) are replaced with a black image
2361 in the stack (for the caller to notice the problem).
2363 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2366 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2367 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2368 between standard library (std) and vtk library (problems are found
2369 under Windows... thanks Windows !)
2371 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2374 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2376 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2379 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2380 * When compiling with distutils (see setup.py) the C++ compiler is
2381 called with different flags than the default ones (with automake).
2382 In order to fix all those warning, I compiled gdcm with the command
2383 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2384 and went for warning fixes:
2385 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2386 up from unused variables.
2387 - vtk/vtkGdcmReader.cxx: potential bug fix.
2388 * src/gdcmHeader.h: Doxygen warning cleanup
2390 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * gdcmPython/gdcm.i:
2392 - typemaps correction to take into account the systematic replacement
2393 of "using namespace std" with std:: prefix e.g. std::list,
2394 std::string... (cf changes of 2003-05-21).
2395 - gdcmGlob global variable of type gdcmGlobal (defined in
2396 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2397 exported to Python a as cvar.
2398 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2399 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2400 gdcmDictSet.GetPubDictTagNames() and
2401 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2402 C++ static methods).
2403 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2404 with the above changes.
2406 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2407 * setup.py, manifest.in : bug fix under linux
2409 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2410 * Modification of setup.py to compile vtk part too. Then, we have 2
2411 wrappers which must work with same distutils. For that, we have a
2412 generic distutils in distusiltsWrapping.py ; with :
2413 - build_extWrap class to wrap generically all extensions,
2414 - ExtensionWrap base class for all wrapping extension that contains
2416 - Wrapper interface which wrap sources
2417 + In WrapSwig.py we have extension and wrapper for Swig
2418 + In WrapVTK.py we have extension and wrapper for VTK
2419 * MANIFEST.in : modifications to consider vtk directory and new python
2420 files for compilation
2422 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2423 * Added python wrappers of vtkGdcmReader vtk class (see the
2424 source in vtk/vtkGdcmReader.cxx) :
2425 - vtk/Makefile.am now builds a library
2426 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2427 python library (as opposed to _gdcm.so wich are the python
2428 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2429 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2431 - configure.in has an additional flag --enable-vtk that needs
2432 to be set to enable compilation of vtk related code, that is:
2433 + vtk/vtkGdcmReader.so and
2434 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2435 + gdcmPython/vtkgdcmPython.so (see above)
2436 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2437 be read when compressed or when HighBit + 1 != BitsStored),
2438 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2439 the usage of the python wrapper of vtkGdcmReader vtk class.
2440 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2441 * src/*.[h] all occurences of stl classes are now prefixed with
2442 std::, and all occurences of "using namespace std;" where removed.
2443 This is to avoid pollution of global namespace in included files.
2444 Apparently vtk does not avoid this pitfall: when using both
2445 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2446 collision of various stl members (principally cout...).
2447 * gdcmPython/testSuite.py now cleanly removes temprory generated
2449 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2450 comply with above changes)
2452 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2453 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2454 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2455 vtk data structure (an image Flip was required).
2456 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2457 * cosmetic changes in documentation.
2459 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2460 * src/gdcmHeader.cxx: the constructor no longer exits when an
2461 unexisting file is given as argument.
2462 * The subdirectory Data (containing all the images used for the
2463 test suite) is not part of this repository anymore. A new module
2464 containing those images is now available at
2465 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2466 with the name gdcmData.
2467 All the python scripts (including the package initialisation file
2468 gdcmPython/__init__.py) were adapated to take this change into
2469 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2471 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2472 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2473 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2474 demo of the usage of this class.
2475 Compilation of this vtk part is only done when using the --enable-vtk
2476 at configure (or autogen.sh) stage.
2478 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2479 * More memory link related corrections and documentation fixes.
2481 - maximum info is obtained with a command of the form:
2482 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2483 --show-reachable=yes PrintHeader
2484 - the remaining reachable blocks seem to come from the STL
2485 allocation scheme through the usage of map and list. It looks
2486 like this memory cannot be freed but it is not a memory leak
2487 (in fact further invocation to the STL would recollect the
2488 unused memory allthough it cannot explicitely be freed).
2489 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2490 of displaying an image parsed with gdcm and displayed with VTK.
2491 Note: some images don't seem to work e.g.
2492 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2493 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2494 Allthough this weakens the semantics, it is a ditch attempt to
2495 make gdcm more thread friendly.
2497 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2498 * Memory link hunt (by using valgrind through the command
2499 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2500 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2501 gdcmHeader::_dicom_vr.
2502 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2503 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2505 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2507 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2508 * src/Makefile.am now exports all the necessary include files at
2512 * UpdateGroupLength replaced by new one
2515 * UpdateGroupLength re-written using H-Table
2516 (named UpdateGroupLengthNew untill checks are over)
2518 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2519 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2520 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2522 - gdcmHeader::GetPubElValSet removed.
2523 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2524 UpdateGroupLength, WriteElements, Write.
2525 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2526 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2527 carried the same semantics.
2528 - src/gdcmHeaderIdo.cxx changed accordingly.
2529 - gdcmFile::WriteBase now regroups all the codes from previous
2530 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2531 - enum FileType moved to gdcmCommon.h
2532 * src/gdcmHeader.cxx AddDefault trashed
2533 * gdcmGetXSize added
2534 * getimageDataSize now calls gdcmGetXSize
2535 * Test/*.cxx changed to agree with above changes
2537 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2539 (to avoid double call by end user).
2540 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2541 by end user, since gdcmHeader::gdcmHeader now handles it.
2543 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * gdcm/Doc many doxygen changes:
2545 - Doxyfile now has two different versions, DoxyfileUsers that generates
2546 the html.users end users oriented documentation and
2547 DoxyfileDeveloppers that generates the html.developper developper
2548 oriented documentation.
2549 - README changed accordingly
2550 - requirement.txt removed (old design info moved to TODO).
2551 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2552 DoxyMainPage.txt, DoxyPython.txt provide more information.
2553 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2554 be updated by simply regenerating the docs with doxygen and copying
2555 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2556 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2557 all the tests in the form "if (<map>.count() >1)" were removed.
2558 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2559 ill-formed documentation sections.
2560 * src/gdcmHeader.cxx: ditto
2562 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * setup.py fixed for un*x (needed macro for stdint.h)
2564 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2565 un*ces with sh-utils test utility.
2566 * gdcmPython/demo/test.py renamed to PrintHeader.py
2567 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2568 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2569 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2570 * src/gdcm*.cxx JPR's bad inclusion fixed.
2572 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2574 * gdcmPython/demo/test.py changed accordingly.
2576 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * gdcmPython/Makefile.am fixed linking against libstdc++
2578 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2579 * Swig subdir (historical tests of swig version 1.3.17++) removed
2580 * Test/testChangeEntete.cxx some lines commented out in order to make
2582 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2583 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2585 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2587 hence the user doesn't need this explicit call.
2588 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2589 i.e. LoadElements() call removed.
2590 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2591 - src/Makefile.am declares the proper flag for g++.
2592 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2593 for adding user defined new tags.
2594 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2595 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2596 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2598 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2599 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2600 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2601 src/Makefile.am : the project should properly compile and install
2602 with the autotools, included the python wrappers part.
2603 * gdcm.spec.in : added a spec file for RPM packaging.
2605 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2606 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2608 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2610 to exported to the environement (see gdcmPython/testSuite.py
2612 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2613 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2614 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2615 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2616 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2618 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * gdcmPython/__init__.py doesn't crash anymore when running in
2620 in InstallMode or PreInstallMode but with an environement given
2621 value of GDCM_DICT_PATH.
2622 * src/gdcmDictSet.[cxx/h] coding style.
2624 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2626 * src/gdcm.h general comments moved to TODO, and README
2627 * src/gdcm.h should now be seen as a user commodity (including it
2628 should suffice to fully use gdcm). It is nowhere including within
2629 any of the kernel files src/*.cxx and src/*.h.
2631 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2633 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2635 * src/gdcm*.cxx only include their corresponding include file
2636 (as opposed to gdcm.h)
2637 * gdcmPython/gdcm.i changed accordingly
2638 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2639 the autogen.sh generated "make snapshot" command to work.
2640 * autogen.sh removed history related references to crea package.
2642 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2643 * distutilsSwigCPlusPlus.py work around some swig portability
2646 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2648 was done in a last ditch attempt to get setup.py _really_
2649 operationnal. The python/gdcmPython layaout add the advantage
2650 of hidding away the python related distutils specific files
2651 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2652 Alas, the src directory was out of scope (i.e. it's relative
2653 position to setup.py was ../src) which made things impossible to
2654 handle (see previous version of python/setup.py). Crossing fingers...
2656 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * python/setup.py now works on Un*x. (harder than I thougth)
2658 * python/distutilsSwigCPlusPlus.py can now have include files
2659 among the list of sources.
2661 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2662 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2663 * modifications in MSVC projects
2665 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * As stated by the first lines of Test/ExceptionAndPython/README, it
2667 looks like we can move back to original usage of exception within
2668 src/gdcm* and hence remove the errno stuff that was introduced
2669 as a quick and dirty fixture of this problem (added to the TODO).
2670 * Doc/Doxyfile configuration file for Doxygen and corresponding
2671 README file for usage added.
2672 * Test/testWrite.cxx added. This new test comes from a split of
2673 test.cxx that is now reverted to its original purpous i.e.
2674 testing the proper parsing of a Dicom related file.
2675 testWrite.cxx concentrates on testing the IO part of gdcm.
2676 * Test/bug1.cxx (containing a bug on WIn32) added.
2677 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2678 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2679 whose purpose is to publish the content of the TagNames of the
2680 Dicom public dictionnary were not accessible without an
2681 instance of class gdcmHeader.
2682 - those methods are now static methods of gdcmDictSet and hence
2683 require no instances at all to be invocated.
2684 - within gdcmDictSet this change required to change some method
2685 to class methods (i.e. are now static) among which SetDictPath
2686 (renamed to BuildDictPath) and LoadDefaultPubDict.
2687 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2688 the above changes by calling the new method classes of gdcmDictSet.
2689 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2690 the above to be effective.
2691 * python/gdcmPython: in order to wrap properly the above changes
2692 for Python, swig version now needs to be > 1.3.17.
2693 * python/gdcmPython/Makefile fixed to adapt itself to new
2694 configure/make shema introduced by Johan Montagnat (thanks for the
2695 contribution). Alas this Makefile cannot be turned into a proper
2696 Makefile.am without some heavy changes in the configure.in
2697 (for python dectection).
2698 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2699 now avoids publishing the empty entries.
2701 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2702 * python/setup.py : bug fix concerning install under windows
2703 ExtraPath reused :-P
2704 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2706 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2707 * Dicts/dicomV3.dic : remove double spaces !!!
2708 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2709 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2712 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2714 method. Doxygenation.
2715 * src/gdcm.h clean up of JPR spurious comments.
2717 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * python/distutilsSwigCPlusPlus.py now properly collects the
2719 shadow classes generated by "swig -c++" (gdcm.py in our case)
2720 when using "python setup.py install".
2721 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2722 reexports the working classes.
2723 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2724 by the classical C errno scheme. This is to prevent an obscure
2725 behavior of the python wrappers when importing wxPython.wx prior
2726 to gdcmPython (which ended up in an abort call). An illustration
2727 of this oddity can be found in the Test/ExceptionAndPython
2728 subdir (see the README file). This problem probably due to
2729 an combination of g++ and dynamic loading.
2730 * added Test/ExceptionAndPython (see above)
2732 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * Changed the layout of the python part to avoid bloating main
2734 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2735 i.e. the distutils arsenal. All the python related stuff is
2736 again in a python subdir, but the package itself is now in
2738 * setup.py was cleaned up:
2739 - pythonIncludePath removed
2740 - python setup.py bdist target is now functional.
2741 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2742 collision with other packages). gdcmPython/demo/*.py changed
2745 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * python subdir moved to gdcmPython (preparation of distutils packaging).
2747 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2748 distutils installer is operational.
2749 * - gdcmPython/__init__.py now properly loads the swig generated
2750 shadow classes (from gdcm.py).
2751 - gdcmPython/demo/*.py changed to import the package gdcmPython
2752 instead of gdcmPython/demo/load.py.
2753 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2755 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2757 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2758 entries within the associated public Dicom dictionary resp. the same
2759 information but sorted by the fourth field (PAT, IMG, DIR) of the
2761 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2762 are now in the "???" group.
2763 - python/gdcm.i changed accordingly,
2764 - python/demo/printGroupedPublicDict.py added, that gives an example
2765 of the above new functionalities in Python.
2767 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcm.h, gdcmHeader.cxx:
2769 - historic references to glib's g_malloc and g_free (#defined)
2770 were definitively removed.
2771 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2772 * src/gdcmElValSet.cxx:
2773 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2774 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2775 - GetElValue(string) renamed to GetElValueByName.
2776 - Added GetElementByName(string).
2777 * src/gdcmHeader.cxx: added
2778 - GetPubElValRepByNumber(guint16, guint16)
2779 - GetPubElValRepByName(string)
2780 - GetShaElValRepByNumber(guint16, guint16)
2781 - GetShaElValRepByName(string)
2782 - GetShaElValByNumber(guint16, guint16)
2783 - GetShaElValRepByName(string)
2784 - GetElValRepByNumber(guint16, guint16)
2785 - GetElValRepByName(string)
2786 - GetElValByNumber(guint16, guint16)
2787 - GetElValRepByName(string)
2788 * Doc/requirements.txt added.
2790 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * Test/Makefile building now depends on the one of libgdcm.so
2792 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2793 pixel data) aware which enables finding the address (offset) of
2794 the pixel data of JPEG encoded DICOM files. This leaves only a single
2795 file in the testSuite whose pixel data address (offset) is unknown.
2796 * python/testSuite.py changed accordingly.
2798 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2799 * VC++ has some strong limitations when working with the STL, as stated
2800 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2801 "Also note that some STL containers (map, set, queue, list, deque)
2802 cannot be exported. [...]
2803 Some STL classes contain nested classes. These classes can not
2805 This is caused by a designed limitation that once a template
2806 class is instantiated, it can not be re-instantiated and
2808 Since our usage of map<> is ubiquitous in gdcm, this "designed
2809 limitation" of VC++ is a pitfall.
2810 Hence the Python wrappers of gdcm cannot be incrementally linked
2811 against the c++ dynamic library. The dirty but only workaround is
2812 to forget about incremental link of dynamic libraries and to generate
2813 the Python wrappers library with the inclusions of the underlying C++
2815 The following modifications concern this matter on Win32/VC++:
2816 - wrapping python correct with standalone wrapped dll (don't use separate
2817 dll under windows !!!!)
2818 - python21_d debug mode enabled (ask Frog how to use it :-)
2819 - NO problem with having an STL member of class for example string in C++
2820 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2821 - Python test of dcmlib in Python is ok under windows on a large set
2823 * removed glib references
2824 * typedef's inserted in gdcm.i for correct swig type management
2826 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * python/demo/*.py load.py extracted from test.py. Added explore.py
2828 that only displays required tags and testAll.py that parses all
2829 the files of the testsuite without using unittest.
2830 * python/testSuite.py other additional test on new files added.
2831 * Data/* new test files added accordingly to the testSuite.
2832 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2833 the vr in the file differs from the one of the dictionary.
2835 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2837 values, but limits itself to values which are below a user specified
2838 size (by default 1024 bytes).
2839 * python/gdcm.i : elements not loaded (because their size is above the
2840 user specified treshold) are exported with their TagKey as key of the
2841 python dictionary. This enables the testsuite to make some checks
2842 on the unloaded elements (since we have their offset and size).
2843 * python/testSuite.py
2844 - now tests for the existence and proper value of the pixel data
2845 - two new examples added.
2846 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2848 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2850 aware. See the strategy comments in gdcmHeader::FindeLength().
2851 * Test/test.cxx now accepts a filename as first argument.
2852 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2853 * python/testSuite.py changed to integrate test on above files.
2855 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2856 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2857 the vr was also RET.
2858 * python/testSuite.py more tests added.
2860 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * python/testSuite.py unittest test suite added (uses Data)
2862 * Data/* dcm and acr files for the test suite.
2863 * glib dependance removed from un*x version. We now use ISO C99
2864 7.18 Integer types (see stdint.h)
2865 - python/Makefile, src/Makefile src/gdcm.h
2866 * src/ when an explicit vr (like dicom files) suddenly poped an
2867 implicit element we use to mark the underlying DictEntry of the
2868 concerned ElValue with "Implicit". This strategy was damageable
2869 too the public or provite dictionaries, since some of their vr
2870 would be changed. Since Header::FindLength heavily relies on the
2871 detection by Header::FindVR of falsely explicit elements, I
2872 added an extra ImplicitVr member to ElValue (boolean).
2873 The rest of the changes we the necessary adaptations.
2875 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2876 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2878 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2880 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2881 * Adaptation for porting to VC++:
2883 o forced to use std namespace (for string to be known)
2884 o all class use __declspec export style on WIN32
2885 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2886 (in stdlib.h on Win32 but in std:: for gcc)
2887 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2888 variable GDCM_DICT_PATH.
2889 * src/gdcmHeader.cxx verbose comments made discrete.
2891 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2892 * python/gdcm.i: added a typemap that converts a C++ hashing table
2893 to native Python dictionary.
2894 * python/demo/test.py:
2895 - now uses the native dictionary for exploration of gdcmHeader.
2896 - takes an optional filename argument (the file to parse).
2897 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2898 PubElVals hashing table.
2899 * Dicts/dicomV3.dic removed error prone trailing spaces.
2901 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2902 * Python wrapping process moved away from src/Makefile to
2903 newly created python/Makefile (as well as gdcm.i)
2904 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2905 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2906 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2907 from the environement variable GDCM_DICT_PATH (when existing).
2908 * src/gdcmDict::GetTag bug fix.
2910 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * Straightforward temporary fixes for swig to build the python wrappers.
2912 src/Makefile now has a python working entry [by working we mean
2913 that we can import de shadow classes without errors].
2915 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * hashtest.cxx removed (since allready in Test)
2917 * src/gdcmlib.h renamed to src/gdcm.h
2918 * src/dcm.i renamed to src/gdcm.i
2919 * src/Makefile prepared for python wrapping
2921 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * src/gdcmHeader.cxx :
2923 - Parsing of header is now separated from loading of element values
2924 (see gdcmHeader::LoadElements).
2925 - general clean up of hopefully all file access (creation of
2926 ReadInt16 and ReadInt32)
2928 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * src/gdcmHeader.cxx :
2930 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2932 - SetLgrElem renamed to SetLength
2933 - GetLgrElem renamed to GetLength
2934 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2935 * src/gdcmElValSet.cxx fixed both GetElValue methods
2936 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2937 due to IdoDude was cleaned out.
2939 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2940 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2941 concentrates on finding the value representation (when it exists).
2942 RecupLgr now only finds the element value length, and it avoids
2943 returning the unecessary skL (skipped length).
2944 Also, offsetCourant was simply removed (with taille_fich) since
2945 it was redundant with the File position internals (by using
2946 ftell and fseek). This also made skL (see above in RecupLgr) usage
2948 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2949 on the libido specificities which are handled through class
2951 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2954 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * Truckload of changes. Parsing of header is barely functional
2956 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2958 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * src/gdcmHeader.cxx many addons of low level methods
2961 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2962 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2963 and _IdDcmSWAP_LONG.
2965 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2966 * This corresponds to all the changes decided at the meeting of
2967 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob