1 Mon Oct 18 10:27:49 2005 by regrain
2 * Remove useless constructor of gdcm::Document
3 * Remove useless parameter in the constructor of gdcm::ElementSet
4 * Split gdcmCommon to separate the System specifications to the gdcm
7 Mon Oct 18 10:27:49 2005 by regrain
8 * Minor coding-style clean up
9 * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
10 by the DataEntry. This unique entry considers all datas like binary datas.
11 Some methods are added to interpret - at fly - the binary datas.
12 Due to this important change, some methods of the DocEntrySet, concerning
13 the BinEntry and ValEntry classes, are erased ; and new methods for the
14 DataEntry class are created.
15 Some methods to set the ValEntry or the BinEntry are renamed to
16 correspond to the new DataEntry, like for example :
17 - SetValEntry -> SetEntryString
18 - SetBinEntry -> SetEntryBinArea
19 This change will remove all useless creation of the string when working
22 Thu Aug 25 16:59:49 2005 by jpr
24 Now Print displays the BinEntry Content (if it's printable, and loaded)
25 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
27 Appreciate the difference having a look at PrintFile result for
28 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
30 Thu Aug 25 16:55:47 2005 by jpr
32 Add methods to check the 'printability' of a bin area
34 Thu Aug 25 15:45:40 2005 by jpr
36 According to Mathieu's suggestion, Print now display FL BinEntries in a human
39 Thu Aug 25 15:12:43 2005 by jpr
41 According to Mathieu's suggestion, *all* the elements 0x000
42 are now named 'Group Length' (even if they belong to a Shadow Group')
44 Wed Aug 24 14:09:13 2005 by jpr
45 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
46 Removal of QD patch for Private Sequence + Immplicit VR.
47 Add a clean solution (Backtracking if an Item Starter is found
50 Tue Aug 23 14:57:49 2005 by jpr
52 Brutal patch, waiting till we find a clever way to guess
53 if a doc entry is a Sequence,
54 - when it's odd number
55 - and the file is Implicit VR Transfert Syntax
56 It solves temporarily some Philips Medical Systems image problems
58 Mon Aug 22 18:17:54 200 by jpr
60 Save a *few* microseconds at run time : inline method Util::GetVersion()
63 Tue Aug 23 14:58:49 2005 by jpr
64 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
65 Improve 'Print' methods
67 Sat Aug 20 11:10:24 2005by jpr
69 Use new style FileHelper contructor
71 Sat Aug 20 11:04:50 2005 by jpr
73 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
74 in order not to do the job twice when using new style FileHelper Constructor.
76 Fri Aug 19 18:31:07 2005 by malaterre
78 ENH: Provide a GetVersion function, apparently need for python
80 Fri Aug 19 15:12:15 2005 by jpr
82 Initialize UserFunction pointer to 0, even for 'deprecated' form
85 Sat Jul 30 20:27:00 2005 by jpr
86 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
87 User is now allowed to pass a Pointer to a function of his own
88 to allow modification of pixel order (i.e. : Mirror, TopDown, )
89 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
90 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
91 NB : the "uint8_t *" type of first param is just for prototyping.
92 User will Cast it according what he founds with f->GetPixelType()
93 See ctkgdcmSerieViewer for an example
95 Sat Jul 30 20:13:24 2005 by jpr
97 Add SerieHelper::IsCoherent() method to allow checking that the files with same
98 Serie UID have the same sizes and pixel type.
100 Fri Jul 29 17:07:16 2005 by jpr
103 SetSortOrderToDirect() or SetSortOrderToReverse()
104 to choose the ways the File* will be sorted.
106 Thu Jul 21 06:55:50 2005 by jpr
107 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
110 Thu Jul 21 06:55:30 2005 by jpr
112 Add an example of use for SerieHelper
114 Thu Jul 21 07:00:15 2005 by jpr
116 Extend 'Restriction' syntax :
117 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
118 std::string const &value, int op)
120 /// \brief comparaison operators
130 Wed Jul 20 15:39:00 2005 by jpr
132 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
133 (e.g. Private entries when the TS is Implict VR)
134 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
135 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
137 Wed Jul 20 16:49:41 2005 by jpr
139 Use GDCM_LEGACY for DicomDir, as well
141 Wed Jul 20 15:31:01 2005 by jpr
143 We can now anonymize 'BinEntries' as well
145 Wed Jul 20 15:29:42 2005 by jpr
147 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
148 16, written in hexadecimal.
149 (usefull to allow terminal user to pass the (private) elements he wants to
152 Tue Jul 19 17:25:53 2005 by jpr
154 Add some comments on the 'Patient Position'
156 Tue Jul 19 11:04:58 2005 by jpr
158 Add SerieHelper::AddGdcmFile(File *header) method.
159 * \brief add a gdcm::File to the first (and supposed to be unique) list
160 * of the gdcm::SerieHelper.
161 * \warning : this method should be used by aware users only!
162 * User is supposed to know the files he want to deal with
163 * and consider them they belong to the same Serie
164 * (even if their Serie UID is different)
165 * user will probabely OrderFileList() this list (actually, ordering
166 * user choosen gdm::File is the sole interest of this method)
167 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
168 * vtkGdcmReader parsing twice the same files.
169 * *no* coherence check is performed, but those specified
170 * by SerieHelper::AddRestriction()
172 Mon Jul 18 12:20:20 2005 by jpr
174 In order to prepare the future extension of SerieHelper::AddRestriction (key,
176 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
178 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
180 Sun Jul 17 06:27:49 2005 by jpr
182 Use new style for Loading files
184 Tue Jul 12 19:08:12 2005 by jpr
185 gdcmCommon.cxx, gdcmSQItem.cxx
186 To speed up DicomDir, instead of copying -and removing the source afterwards-
187 each entry of the SQItem (found after gdcm::Document parsing) towards
188 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
189 the chained list itself.
191 Tue Jul 12 16:55:43 2005 by jpr
193 AnonymizeNoLoad has now one more option :
195 to give the (single Patient) directory name whose content we want to anonymize.
197 Mon Jul 11 10:20:25 2005 by jpr
198 gdcmDicomDirStudy.cxx
201 Fri Jul 8 21:07:12 2005 by jpr
203 Add the VISIT object within DicomDir
205 Fri Jul 8 12:15:08 2005 by jpr
207 Use new style for DicomDir loading
209 Fri Jul 8 16:36:48 2005 by jpr
211 To remain unimpared, gdcm::FileHelper class needs also its
212 void FileHelper::SetLoadMode(int loadMode)
213 void FileHelper::SetFileName(std::string const &fileName)
214 bool FileHelper::Load()
216 Thu Jul 7 19:31:53 2005 by jpr
218 Begin of kosherization of Example
221 Thu Jul 7 18:37:40 2005 by jpr
223 On the way to gdcm2 ...
224 Now, the stand way to use a file is :
225 gdcm::File *f = new gdcm::File();
226 f->SetLoadMode ( user say here what he wants *not* to load );
227 f->SetFileName("myFile.gdcm");
229 Old styles are kept, not to break the C++ API.
230 - gdcm::File *f = new gdcm::File("myFile.gdcm");
231 - f->Load("myFile.gdcm");
232 Due to the syntaxic abilities of Python maybe some troubles will occur
235 Thu Jul 7 15:55:39 2005 by jpr
237 Comment out the time consuming, never used/useless
238 'Extended tag' stuff for Sequence embedded Entries
240 Thu Jul 7 15:11:38 2005 by jpr
242 Move code lines LTTG so save some CPU time.
245 Tue Jun 7 13:12:10 2005 CEST by jpr
247 Use Argument Manager in 'utilities'
249 Thu Jul 7 12:12:32 2005 by jpr
251 Due to something stupid in the gdcm::File constructor, the file was parsed
252 twice when we used old style, e.g :
253 gdcm::File *f = new gdcm::File(fileName);
254 instead of new style, e.g. :
255 gdcm::File *f = new gdcm::File( );
256 f->SetLoadMode ( choose what you want *not* to load here );
259 Wed Jul 6 11:53:43 2005 by jpr
260 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
261 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
262 param, in order not to have to recompile to gdcm::Debug::DebugOn().
264 Wed Jul 6 17:18:42 2005 by jpr
266 According to Mathieu's requirement, Load twice the same file keeps the rseult of
267 the first Load (instead of doing it twice)
269 Wed Jul 6 11:25:12 2005 by jpr
271 - Clean out the Entries if a Document is parsed more than once
272 - Uncomment (usefull) warning messages
274 Wed Jul 6 10:42:33 2005 by jpr
276 - Comment out a for the moment too much verbose warning message.
277 - Delay some statement as late as possible, to save some CPU time when they're
280 Wed Jul 6 13:01:08 2005 by jpr
282 Now gdcmFile::Load() returns false if file is not gdcm parsable
283 Only gdcmDocument::Load() did it, before.
284 Thx to Benoit for reporting bug
286 Sun Jul 3 14:42:04 2005 by jpr
288 Should avoid some troubles with 'no length' SQItems within 'true length'
290 Thx to Loic Boussel for providing data to fix the bug.
292 Sun Jul 3 14:42:04 2005 by jpr
294 Should avoid some troubles with 'no length' SQItems within 'true length'
296 Thx to Loic Boussel for providing data to fix the bug.
298 Sun Jul 3 14:47:23 2005 by jpr
302 Fri Jul 1 13:25:51 2005 by jpr
303 gdcmPixelReadConvert.cxx
304 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
305 (e.g. PrintFile on a DICOMDIR document)
307 Thu Jun 30 16:49:02 2005 by jpr
309 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
310 Boussel's Hall of Shame Dicom images
312 Wed Jun 29 17:58:33 2005 by jpr
314 Add the NO_SHADOWSEQ load mode
316 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * Quite a few new dictionaries were added in gdcm. The file:
318 gdcm/Dict/README should always explain were the info was found
319 (in case of double check). Also some dict are still only
320 express as 'template' (they contain 'xx'), therefore
321 a python script should be run first to generate a full dict.
322 In the longer term this python script should be replaced by
325 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * dicomV3.dic is deprecated in favor of gdcm.dic
327 There is now a dictionary per family:
328 - dicomV3.dic -> DICOM V3
329 - Papyrus.dic -> Papyrus
330 - NIH.dic -> tags that were never allowed in the main standard
332 Fri Jun 24 12:50:20 2005 CEST by jpr
334 Pixel Spacing related problems : update comments.
335 Thx to D. Clunie for providing data to check the code
337 Fri Jun 24 12:55:58 2005 by jpr
338 Summer nights are really too hot to sleep.
339 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
341 Thu Jun 23 11:20:23 2005 by jpr
343 Extend warning message, for debugging purpose
345 Wed Jun 22 10:11:23 2005 by jpr
349 Wed Jun 22 10:00:29 2005 by jpr
350 gdcmPixelReadConvert.cxx
351 Fix misstyping, while removing spurious \t characters
353 Wed Jun 22 09:52:32 2005 by jpr
354 gdcmPixelReadConvert.cxx
355 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
357 That break at lot of viewers ...
358 We now *propagate the sign bit* upon the unused ones, better than masking them
360 Thx to Luca Picello for profiding data to fix the bug
362 Wed Jun 22 09:53:52 2005 by jpr
364 gdcm images are now "GDCM 1.1" built.
366 Mon Jun 20 19:10:17 2005 by jpr
368 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
370 Mon Jun 20 17:58:53 2005 by jpr
372 Preventive bug fix for LUT Data.
373 I said : LUT Date, *not* Palette Color
375 Sun Jun 19 17:57:29 2005 by jpr
377 To avoid warnings at compile time
379 Fri Jun 17 14:27:52 2005 by jpr
383 Fri Jun 17 14:36:07 2005 by jpr
387 Fri Jun 17 14:35:00 2005 by jpr
389 Add some accessors for debugging purpose
391 Tue Jun 14 15:56:41 2005 by jpr
392 gdcmPixelReadConvert.cxx
393 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
394 (3 * 65536 short int ...)
396 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
398 Mon Jun 13 17:43:48 2005 by jpr
399 gdcmPixelReadConvert.cxx
400 Some more oddities dealt with.
401 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
402 Still looking for accurate info on the web about it
404 Fri Jun 10 16:05:38 2005 by jpr
406 Bug fix in Load method.
407 Thx to Benoit for providing fix.
408 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
410 lantency with the Util::Format function
412 Tue Jun 7 15:48:35 2005 by jpr
414 The highy time consuming method GetMacAdress is now called just once
416 Tue Jun 7 11:58:29 2005 by jpr
417 gdcmDicomDirElement.cxx
418 Use TranslateToKey better than Format
420 Tue Jun 7 12:07:20 by jpr
422 Remove some spurious calls to Format
423 // according to 'Purify', TranslateToKey is one of the most
424 // time consuming methods.
425 // Let's try to shorten it !
427 Mon Jun 6 14:37:58 2005
428 class ArgMgr (for Arguments Manager) is designed for
429 command line arguments management
430 (to make programmer's live easier)
431 (could be used for any kind of 'command line program')
433 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Adding users file in CVSROOT for mail blaming
436 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
437 * Adding potential support for JPEG-LS DICOM files.
439 Fri Jun 3 18:05:23 2005 by jpr
441 Fix VR processing, to be CP-288 conform.
442 Now we can parse any kind of DICOM SR.
444 Fri Jun 3 11:05:15 2005 by jpr
448 Thu Jun 2 15:42:18 2005 by jpr
450 Add warning about Load Mode
452 Thu Jun 2 16:20:14 2005 by jpr
454 Harden gdcm::File::IsReadable(), in order not to be confused any longer
455 by lost of Pixel Element
457 Fri May 27 12:51:00 2005 by jpr
459 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
461 And avoid some memry leaks -hope so-
463 Wed May 25 14:54:17 2005 by jpr
465 Should avoid some memory leaks
467 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Adding potential support for mpeg and jpeg2000 through two new lin
469 - JasPer for JPEG2000
470 - libmpeg2 from the MPEG consortium
471 Also adding intial work to use this lib.
473 Fri May 20 10:27:55 2005 by jpr
476 (this time, it's wasn't dangerous at run time)
478 Thu May 19 17:31:21 2005 by jpr
480 FIX possible troubles when checking
481 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
482 Thx to Mathieu for reporting bug
484 Wed May 18 12:12:07 2005 by jpr
486 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
487 Thx to Dennis Hu for providing a sample image to fix the bug.
489 Tue May 17 14:44:09 2005 by jpr
491 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
492 before 'Pixel Spacing', when we want to get X or Y Spacing.
494 Tue May 17 19:10:49 2005 by jpr
496 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
497 at LTTG (Least Time To Go)
498 around Bits Allocated, Bits Stored, High Bit Position,
499 to avoid unaware user to mess up the stuff.
501 Tue May 3 11:43:04 2005 by jpr
503 Load returns now a bool (allow user not to call IsReadable() )
505 Tue May 3 11:51:06 2005by jpr
507 Now the gdcm::File remains unimpaired after writting, in any case
509 Fri Apr 29 17:10:55 2005by jpr
511 Don't abort the prog when File not open
513 Wed Apr 27 12:00:35 2005 by jpr
515 Removal of now useless lut-related stuff
517 Wed Apr 27 11:52:27 2005 by jpr
519 Pb of 'Bits Allocated = 12' is now dealt with in
520 FileHelper::CheckMandatoryElements, no longer in File::Write.
521 Thx to Mathieu for reporting bug.
523 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
527 Tue Apr 26 18:18:23 2005 by jpr
529 Should leave gdcm::Document constructor in a much quicker
530 and much cleaner way when anything wrong occurs.
532 Tue Apr 26 18:25:49 2005 by jpr
533 gdcmPixelReadConvert.cxx
534 Prepare MPEG Dicom encapsulated processing (within a loooong future)
536 Fri Apr 22 14:59:58 2005 by jpr
538 Modify Print() output
540 Fri Apr 22 15:37:57 2005 by jpr
542 Prepare (future) MPEG integration
544 Thu Apr 21 09:40:00 2005 by jpr
546 Taking into account Dicom MPEG
548 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
549 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
550 But this is a case where we should really signify the user there is
551 few chance the serie is really a serie...
553 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * FIX : on X, the python part is correctly installed. All files are
555 installed in gdcm sub-directory
557 Tue Apr 19 11:58:19 2005 by jpr
559 Should suppress some warnings from Borland compiler
561 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Builder/ : add something to facilitate the RPM creation of gdcm
564 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
565 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
567 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
569 Thu Apr 14 16:26:19 2005 by jpr
571 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
573 // Old style (still available) :
574 dcmdir = new gdcm::DicomDir(dirName, true);
576 // new style (user is allowed no to load Sequences an/or Shadow Groups)
577 dcmdir = new gdcm::DicomDir( );
578 dcmdir->SetParseDir(true);
579 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
580 dcmdir->Load(dirName);
582 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
583 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
585 * Fix compilation on gcc 2.96 (which does not have ios::failure)
587 Mon Apr 4 17:15:24 2005 by jpr
589 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
591 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
593 and it's representation name (for the NIH)
595 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
597 conversion of YBR to RGB pixels. So, now, the conversion is made using
600 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
602 format) to replace 'at-run' dicom files generated by the
603 TestAllReadCompareDicom test
605 Tue Mar 22 12:29:37 2005 by jpr
607 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
608 and it's VR is forced to UL
609 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
610 and/or with Shadow groups
611 use SetLoadMode (NO_SEQ | NO-SHADOW);
613 Tue Mar 22 12:40:13 2005 by jpr
615 *FIX Restore pushed out elements
617 Fri Mar 11 12:08:31 2005 by jpr
619 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
621 Fri Mar 11 12:12:13 2005 by jpr
623 Final removal of gdcmFileHelper::InitializeDefaultFile();
625 Wed Mar 9 20:29:38 2005 by jpr
627 Add Anonymize method (not yet fully checked)
629 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
630 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
632 Wed Mar 2 18:18:32 2005by jpr
634 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
637 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
640 Mon Feb 21 18:45:41 2005 by jpr
642 * Replace method CheckMetaElements by CheckManadatoryElements
643 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
644 (probabely some stuff still missing)
645 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
646 between a given call and the next one (to add images to a Serie he just
648 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
649 between a given call and the next one, or to reuse an already existing
650 Study UID (i he wants to add his own Series to an already existing Study)
652 Thu Feb 17 17:18:33 2005 by jpr
654 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
655 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
656 Thx to Benoit for reporting bug
658 Thu Feb 17 11:56:20 2005 by jpr
660 Prepare FileMetaInformationVersion (group 0002) management
662 Thu Feb 17 12:02:47 2005 by jpr
664 Group 0002 management
666 Thu Feb 17 12:03:32 2005 by jpr
667 gdcmDocEntryArchive.cxx
670 Wed Feb 16 11:19:19 2005 CET by jpr
671 gdcmPixelReadConvert.cxx
672 Taking into account MONOCHROME1 + Signed Pixels (?!)
674 Tue Feb 15 19:12:34 2005 by jpr
676 Taking into account the difference between MONOCHROME1 (low values = bright)
677 and MONOCHROME2 (low values = dark)
679 Mon Feb 14 11:45:04 2005by jpr
681 Remove some useless mask operations, to save CPU time
683 Mon Feb 14 15:51:10 2005 by jpr
685 *never* forget to re-compile just *before* committing!
687 Mon Feb 14 15:34:27 2005 by jpr
689 First commit on the post 1.0 (Version? / Tag? / Branch?) :
692 Mon Feb 14 11:45:47 2005 by jpr
694 remove useless comments
696 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * Testing/TestMAkeIcon.cxx : complete the test
699 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
702 Fri Feb 11 16:22:18 2005 by jpr
704 Typo, comments, doxygenation
706 Thu Feb 10 11:55:26 2005 by jpr
708 AnonymizeNoLoad improvement
710 Thu Feb 10 10:07:19 2005 by jpr
712 Duplicate Matthieu's hack to prevent bombing in Anonymize
714 Thu Feb 10 12:20:34 2005by jpr
716 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
718 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
719 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
720 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
721 virtual bool SetValEntry(std::string const &content,
722 virtual bool SetBinEntry(uint8_t *content, int lgth,
723 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
724 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
725 virtual ValEntry *InsertValEntry(std::string const &value,
726 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
727 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
729 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
730 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
733 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
734 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
736 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * Test/ : accelerate tests (it's not very significant accelerations).
738 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
740 Mon Feb 7 15:48:34 2005 by jpr
742 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
745 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * Testing/TestSequence.cxx : add test for sequences of images... test that
747 we have the same serie or the same study UID
749 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
750 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
752 * src/gdcmDict.h : remove commented code
753 * src/gdcmDocument.cxx : initialize values
754 * src/gdcmFile.cxx : bug fix when reading values
755 * gdcmPython/demo/ : change file names. Remove useless files
757 Sun Feb 6 15:31:09 2005 by jpr
759 Update comments for DicomDir stuff
761 Sun Feb 6 15:39:35 2005 by jpr
763 * Add method File::AnonymizeNoLoad, to allow anomymizing files
764 even when the pixels are not gdcm Readable
765 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
766 to allow user to choose the elements whose value
767 he wants to white out / replace
769 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * src/gdcmFile.cxx : remove the default array of initialization.
771 The static array contained pointers to non-static values (comming from
772 strings). To have coherences, when creating files, these values can't be
773 static. So, the array can't be static, too ! To simplify, the array have
774 been replaced by repeted lines to insert values in the File
776 Fri Feb 4 15:49:01 2005 by jpr
778 * Add GetFirstValEntry + GetNextValEntry, for Python users
779 * Some more Doxygenation + typo fixing
781 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
783 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
785 Thu Feb 3 18:12:46 2005 by jpr
786 gdcmPixelReadConvert.cxx
789 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
790 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
791 (Dicom Element) into the Sequence Item
793 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/*.cxx : first parss to normalize file organisation
796 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
797 * src/gdcmDirList.[h|cxx] : add method to find a directory
798 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
800 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
801 * Finish cleaning up my JPEG mess. Should be ok now.
802 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
803 contained within the RLE* class(doh!)
805 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
806 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
807 * SerieHeader::AddFileName() creates as many Coherent Files lists
808 (same Serie UID) as it founds different Serie UID
809 amongst the files instead of discarting any file
810 that doesn't match with the first one he found.
811 * SerieHeader::OrderGdcmFileList has now one parameter :
812 the Coherent Files list the user wants to sort
813 * SerieHeader::GetFirstCoherentFileList() |
814 * SerieHeader::GetLastCoherentFileList() | allow to parse
815 the set of Coherent Files lists
816 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
817 compatibility (it returns the *first* Coherent Files list,
818 since there was only one before)
819 * Test/TestSerieHeader gets gdcmData as a default root directory
821 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * Remove friend between DocEntry and File classes
823 * Remove friend between PixelReadConverter and RLEFramesInfo,
826 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
827 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
828 0002|0000. The value was incorrect.
830 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
831 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
833 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * src/gdcmUtil.cxx : compilation fix on Win32
835 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
836 variable, to be easy found. Add methods to change the default UID.
837 Amelioration of the CreateUniqueUID to use the correct default UID.
838 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
841 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
842 * Test/TestVR.cxx : fix memory leaks
844 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
845 * Rewrite the base 256 to base 10 conversion, using string operation only.
846 This allows us to get rid of the problematic 64bits integer type (does not
847 always exist on target platform).
849 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
850 * Add construct and destructor to class gdcm::Debug to close the debug file
852 * Don't let uset to open twice the same file
853 * gdcm has now an official UID prefix,
854 supplied by http://www.medicalconnections.co.uk
855 1.2.826.0.1.3680043.2.1143
856 (Thx to Mathieu for providing URL)
857 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
858 to be able to perform some more tests
859 * gdcm::ContentEntry : Contructors and Destructor are now protected,
860 in order to be sure no user will try to use them.
861 (at user level, only the children classes are meaningfull)
863 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * move RLEInfo & JPEGInfo from Document to File
866 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
867 * FIX : remove so many friend between classes
869 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
870 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
871 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
873 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
874 In order to avoid missbehaviour :
875 . gdcm::DocEntry is now specialized in
876 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
877 - gdcm::ContentEntry (Dicom entry with a 'content')
878 . gdcm::ContentEntry is specialized in
879 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
880 characters value, or integers)
881 - gdcm::BinEntry (Dicom entry with a non strig representable value
882 (user hasn't any longer to thing about the precedence of his dynamic_casts)
884 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
885 * Test/VTKTest*.cxx : bug fix under linux
887 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
888 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
889 use with python. Some methods are moved from Document to ElementSet or
890 DocEntrySet. The equivalent methods to ElementSet have been added to
891 SQItem and are virtual in DocEntrySet. Methods that may have the same code
892 in SQItem and ElementSet is directly placed in DocEntrySet
894 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
895 * Test/VTKTest*.cxx : remove the show variable in each test method because
896 it's useless (the viewer variable replace this variable)
898 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
899 * src/gdcmDocument.cxx : bug fix on potential memory leak
900 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
901 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
902 Add ClearXxx methods to remove all the content of the list or map
903 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
905 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
906 * methods ReplaceOrCreate renamed as Insert
907 (nobody will be any longer confused by 'CreateOrReplace')
909 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * Grealty simplify the JPEg decompression, no need to differenciate based on
911 the JPEG possible type (with/without fragment, with/without multiple frame).
912 Everything is done throught the JPEG IO Suspension mechanism in IJG
914 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
915 * Stage 3 of normalization :
916 in order to avoid any missunderstanding while reading method names :
917 - All the methods xxxEntry now deal with dicom Entries
918 - Methods GetEntry splitted into
921 - Method SetEntry renamed as SetEntryValue
922 - Method SetEntryBinArea let as it was
924 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
925 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
926 - Position correctly the entry points for JPEG2000 and JPEG-LS
927 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
929 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
930 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
931 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
932 with other method names
933 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
934 * Test/TestDicomDirElement.cxx : add new test
936 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
937 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
938 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
939 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
940 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
941 So can't you use __int64 in ostream at all.
943 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
944 * bug fix for compilation on MSVC6
945 * gdcmPython/gdcm.i : rename of classes missed
947 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
948 * Stage 2 of names normalization :
949 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
950 (easy to understand ...)
951 - gdcm::FileHelper replaces old class gdcm::File
953 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
954 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
955 type and not a string. So, there remove problems on the format of the
958 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
959 * Add Example/TestPapyrus.cxx
960 - reads a Papyrus file (gdcm::Header compliant),
961 - gets the pixels of all the images, using low level iterators
962 - writes an multiframes Dicom image.
963 (Just to show it's *possible* to do that)
964 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
967 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
968 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
969 Thus, DicomDirXXX are created with a flad that indicates if the created
970 object is empty or not (when not empty, the DicomDirElement is used to
973 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
974 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
975 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
977 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
978 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
980 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
981 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
982 Remove all access to the hash-tables or lists in the objects.
984 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
985 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
986 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
987 be complient with all the gdcm source code
989 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
990 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
993 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
994 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
997 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
998 * Test/ : rename VTK tests to have a best name for the tests
999 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
1000 GetFirstEntry/GetNextEntry use
1002 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1003 * In SerieHeader::ImagePositionPatientOrdering()
1004 // a Dicom 'Serie' may contain scout views
1005 // and images may have differents directions.
1006 // -> More than one may have the same 'pos'
1007 // Sorting has then NO meaning !
1008 Thx to Eduardo Davila for reporting bug.
1010 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1011 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
1012 test. Now it's on image content and not on the resulting visualisation...
1013 might solve the problem on linux when using the OpenGL drivers
1015 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1016 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
1017 DicomDirSerie, DicomDirImage
1018 Dict, DictSet classes :
1019 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
1020 -remove InitTraversal method.
1021 * UPD Test programs + Example programs
1023 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1024 * remove useless and never updated keyword \ingroup
1025 * Solve pb when structure (list, map, ...) is empty.
1026 Thx to Benoit for reporting bug
1028 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1029 * Taking into account of 'Transfer Syntax' value
1030 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1033 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1034 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1035 is no memory access violation
1036 * gdcmPython/demo : add python demos using VTK
1038 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1039 * FIX 'Dictionnary' is now spelt 'Dictionary'
1040 'wether' is now spelt 'whether'
1041 'archieve' is now spelt 'archive' ;-)
1043 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1044 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1045 related methods, in order not to expose internal mechanisms
1048 * REM methods that exposed internal mechanisms :
1049 DicomDir::GetDicomDirPatients()
1050 DicomDirPatient::GetDicomDirStudies()
1051 DicomDirStudy::GetDicomDirSeries()
1052 DicomDirSerie::GetDicomDirImages()
1053 * UPD Test programs :
1057 * UPD Example program
1059 * ADD DictSet methods
1063 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1064 * Removed the Print/indent/default parameter mess. There is absolutely no
1065 reason to have to methods, moreover with the second taking the ostream as
1066 *SECOND* parameter. This was clearly a bad hack to get things compile.
1068 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1069 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1070 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1071 Unfortunately the main code does not work on SunOS, thus provide a specific
1072 code for this platform only (and Win32 of course). Since this seems to be
1073 working, change CreateUniqueUID to use GetMACAddress instead of the
1074 problematic GctestetIPAddress
1076 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1077 * Unfortunately to be able to test gdcmDirList I had to break the API
1078 a little. Now the class is not a std::list anymore but has a member
1079 std::vector (more ITK compatible). Allow unit testing on Win32 and
1082 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Update SerieHeader to take into account a Serie Instance UID to properly
1086 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1087 * ENH - Comment out Mathieu's (dangerous) Super Hack
1088 for dealing with BIGENDIAN processors
1089 - Move equivalent stuff to BinEntry::WriteContent
1090 When necessary, 16 Bits Pixels are swapped in a small buffer
1091 and then written. This avoid allocating a huge buffer, in
1092 PixelWriteConvertor, and avoid modifying the Pixel Area.
1094 Probabely, the same operation will have to be done when we want
1095 to write image with Big Endian Transfert Syntax,
1096 and we are working on Little Endian Processor
1098 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1099 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1101 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1102 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1103 all the dict content.
1104 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1106 * Test/TestDict.cxx : add a new test for the dict classes
1108 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1109 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1110 file. Debug is yanked if compiled with NDEBUG
1112 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1113 * src/gdcmDictSet.h : set the default output to the os variable
1114 * src/gdcmDictEntry.[h|cxx] : add the Print method
1115 * gdcmPython/demo/ : add a new test
1117 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1118 * merging of Test/PrintDicomDir and Test/TestDicomDir
1119 * removal of now redundant Test/PrintDicomDir
1120 * enhancement of Example/PrintDicomDir
1122 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1123 * Now, python test might work on systems
1124 * Add the PrintDicomDir test
1126 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1127 * FIX : First entry following group 0002 was lost for
1128 Explicit Big Endian Transfer Syntax files
1129 (group and elem not swaped)
1131 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1132 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1133 Big Endian Transfer Syntax supposed the group following 0002
1134 begins always by element 0000 (element 0000 is *optional*)
1135 To avoid further troubles, let's be pessimistic, and use
1136 Document::HandleOutOfGroup0002() method
1137 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1138 (related pb not yet solved)
1140 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1141 * Bug fix for the python part use
1142 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1144 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1145 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1147 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1148 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1149 a string and should ask the global TS dict what are the propreties of
1152 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1153 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1154 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1155 to swap the Swap Code, at parsing time, when we come out of group 0002
1156 and Transfer Syntax is Big Endian
1157 We should be able to read now 'true DICOM" Big Endian coded images
1158 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1159 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1161 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1162 * Hopefully fix the bug on MacOSX and static global initialization.
1163 This is the only -minor- patch I found that both please MacOSX and VS6.
1164 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1165 but this would require a lot of change. Another approach would be that Global
1166 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1167 gdcm::Global would destroy at exit).
1169 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1170 * Fix bug on MacOSX with static initialization in a multy threaded
1171 environment. static const string in a header file used to be ill
1172 initialized provoquing the freeze of any tests. patch should solve this
1175 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1176 * According to Benoit's suggestion, and without any objection from anybody
1177 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1178 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1179 - method gdcmDicomDirObject::GetEntry() renamed as
1180 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1182 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1183 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1184 you debug/warning message just as c++ streams which make them very convinient
1185 to use. Once this is stabilize I will change the ostringstrem to be
1186 redirected to a file (ofstream).
1187 * Properly support C99 extension: __FUNCTION__ which allow us to display
1188 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1190 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1191 * Removal of useless and dangerous methods :
1192 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1193 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1194 * Removal of usless methods :
1195 Dict::PrintByName, Dict::GetDictEntryByName
1196 * Commenting out of probabely useless methods :
1197 Dict::GetDictEntryNames()
1198 Dict::GetDictEntryNamesByCategory()
1199 DictSet::GetPubDictEntryNames()
1200 DictSet::GetPubDictEntryNamesByCategory()
1201 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1202 * ENH : Use dicomTS.dic as described in 2004 version
1203 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1204 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1205 Add Accessors on VM (Value Multiplicity), and VM related methods
1206 * ADD : Add a list of 'Dicom Attribute types', as found in
1207 http://medical.nema.org/dicom/2004/04_15PU.PDF
1209 * ADD : Add dicomGroupNameAbbreviations.dic
1210 should be used to write a method to replace the former
1211 Dict::GetDictEntryNamesByCategory()
1213 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1215 to read in the file... and only it ! Length is the efective length of the
1216 data in the DocEntry structure
1218 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1219 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1220 And now use a static function call instead, with a global variable. i
1221 This is much closer to the VTK approach. Hopefully should be bulletproof
1222 and easier to use...hopefully
1224 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1225 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1227 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1228 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1230 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1231 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1232 ValEntry, BinEntry, SeqEntry creation or replace
1234 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1235 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1236 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1238 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1239 when specifying the VR
1240 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1241 * src/gdcmDocEntry.cxx : amelioration of print
1243 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1244 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1245 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1246 * ADD Method Document::ComputeGroupLength
1247 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1248 in order to allow further VR modification by user
1249 * REM : removal of once-called method File::WriteBase
1250 integration of its code in formerly one-line method File::Write
1252 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1253 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1254 replace the different values "??", "Unkn", "Unknown".
1255 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1256 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1257 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1258 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1260 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1261 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1263 * Set the gdcm::Base class to some Printable classes
1265 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1266 * src/gdcmFile.[h|cxx] : add the Print method
1267 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1268 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1269 * src/gdcmDocument.h : remove the PrintLevel informations
1270 * Example/PrintFile.cxx : use the new gdcm::File::Print
1272 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1273 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1274 problems when compiling with the python wrapping
1276 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1277 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1278 writting in ImplicitVR
1280 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1281 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1282 JPEG decompression, especially when dicom frames are split into several
1283 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1284 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1286 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1287 * src/gdcmHeader.cxx : change the initialisation of default header.
1288 Now, this header is readable by gdm, e-film, DicomWorks
1290 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1291 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1292 Rename Decompressed to Raw
1293 * Use the API changes in gdcm::File.
1294 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1297 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1298 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1299 each added entry in the header. Replace the 'Planes' field by the 'Number
1302 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1303 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1304 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1306 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1307 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1308 At this time, this image isn't readable by e-film... waiting JPR help to
1311 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1312 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1313 DocEntry. Now use methods of the Document !
1315 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1316 * Test/ShowDicomSeq.cxx : bug fix
1318 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1320 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1321 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1322 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1324 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1325 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1326 containing found sequences
1328 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1329 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1331 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1332 Some fields in BinEntry must be copied to not seg fault when making the :
1333 gdcm::File *copy = new gdcm::File( copyH );
1334 and tests are now made on good variables
1336 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1337 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1338 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1340 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1341 * Add vtkGdcmWriter example and test
1343 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1344 * Test/TestUtil.cxx : reformat the source code
1345 * vtk/vtkGdcmReader.cxx : remove and change prints
1346 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1348 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1349 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1351 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1353 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1355 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1357 by an eof to prevent all bad read of the file... and in this case, the
1358 file isn't readable.
1360 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1361 * Example/Volume2Dicom.cxx : comment unused variables
1362 * Test/PrintDicomDir.cxx : comment unused variables
1363 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1364 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1365 method that is redondant with AddEntry.
1366 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1369 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1370 * Bug fix due my last commit (compilation under Windows).
1371 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1372 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1374 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 - Remove printf / sprintf
1377 - include iostream AFTER gdcm so we don't get warnings
1378 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1380 - Also remove tons of include from header files, hopefully this should
1381 speeup the compilation time, since it was becoming a dog slow.
1382 - Remove gdcm.h as it include way too many files and slow down compilation
1383 (plus it is not up to date)
1384 - remove 'using namespace std' this is BAD !
1386 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1387 * Remove memory leaks on the DicomDir
1388 * Remove some useless data in DicomDirObject
1389 * Add usefull methods in SQItem, to be complient withe the ElementSet
1391 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1392 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1394 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1395 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1396 future, with convertion)
1397 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1398 and ImageDataSize values. Remove the method to get the PixelReadConverter
1399 from the output of the class
1401 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1402 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1404 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1405 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1406 and vtkErrorMacro use.
1407 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1409 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1410 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1412 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1413 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1414 The string leaves only in the fonction. So when we make a .c_str(), we
1415 get the pointeur on the first element, element that will be destroyed
1416 immediately after thee instruction.
1417 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1418 file has been opened : the test must be made on the content of the
1419 pointer and not directly on the pointer !
1422 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1423 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1424 the python part recompiles
1426 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1427 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1428 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1429 X session is killed (for my computer... it seems to not be identic on
1432 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1433 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1434 avoid problems (otherwise, the difference test between the visible image
1435 and the reference is incorrect. If the reference is greater than the
1436 screen resolution, it's produce errors).
1437 Can be used for only one image. Can be used with a visible flag.
1438 * vtk/vtkGdcmReader.cxx : remove commented codes.
1439 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1440 under windows at compilation
1441 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1442 for grayscale images
1443 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1445 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1446 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1447 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1448 tests on the image size X, Y, Z
1450 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1451 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1452 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1453 between the class name and the file name
1455 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1456 * src/ : fix compilation warnings for the Write method (2 different
1457 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1458 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1459 variable... create a static method in gdcm::Document to access to
1460 this variable content.
1462 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1463 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1464 file, to be accessed by other files (like gdcmFile). Remove commented
1465 code. Move the change of the header to the gdcmFile, using the
1467 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1468 To be sure of that (and simplify calls), the Write of the header now
1469 gets a file name and not a file pointer (std::ifstream).
1470 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1471 DocEntryArchive. Remove all open of the written file
1473 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1474 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1476 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1478 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1480 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1481 some corresponding methods. Write correctly the file and check before
1483 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1484 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1485 is now on RGB data (as before my last commit
1486 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1488 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1489 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1490 Add a print information of the type of the entry
1491 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1492 It was in the gdcmFile, and all write have been regrouped
1493 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1494 Write correctly all dicom files (in decompressed mode only at this time)
1495 * Test/ : test on files are now made using Raw data and not color data if
1497 * Example/PrintFile.cxx : add more printings
1499 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1500 * Amelioration of code, remove some code copy. For the loading of
1501 BinEntry (in gdcmDocument), add the test to verify if the file is already
1504 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1505 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1506 remove a DocEntry in the header (push an empty DocEntry)
1507 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1508 lines. Bug fix in the initialization of the PixelConvert and the
1510 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1511 use in TestCopyDicom (now this test can run under windows... but fails)
1512 * Test/TestCopyDicom.cxx : amelioration of the test :
1513 - test the pixels written
1514 - add test points to quickly find where is the error
1515 - can set a file name input and output in arguments
1516 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1517 amelioration of the test output
1519 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1520 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1521 all replaced DocEntry's
1522 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1523 Now, each needed DocEntry to modify is duplicated, modified and inserted
1524 to the header using DocEntryArchive. Thus, after save, we can restore the
1525 header initial state.
1527 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1528 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1530 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1531 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1532 correct to copy it. The DictEntry is specified at the DocEntry creation,
1533 then, it musn't change in the time.
1534 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1535 header correctly. At this time, the change is only made for the first
1536 level of the Document. In the future, it might consider sequences.
1537 The change is made by replacing a DocEntry by an other that is created
1538 outside the class. The old value is kept. When we restore the header
1539 status, the added DocEntry is deleted and replaced by the old value.
1540 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1541 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1542 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1543 the write mode to native, decompressed or RGB (but not used at this time)
1545 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1546 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1547 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1549 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1550 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1551 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1553 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1554 set because already copied when copying the BinEntry's of the header
1555 * Test/TestAllReadCompareDicom.cxx : remove warnings
1557 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1558 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1559 Two problems appear when doing it :
1560 - with the gdcmFile : when the GetImageData method is called, the pixels
1561 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1562 data (pixels). And each structure destruct the data when it's
1563 destructed. So we have two destructions for the same data. To solve it,
1564 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1565 data or not. If it doesn't own data, then they will not destroyed by
1567 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1568 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1569 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1570 create a double destruction of the same DocEntry's. So, to solve it,
1571 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1572 * TODO : add an entry concerning memory leaks in the DicomDir
1574 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1575 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1576 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1579 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1580 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1581 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1582 after it have been deleted
1584 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1585 * FIX: src/* fix the doxygen warnings.
1586 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1587 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1588 was erroneously defined with a size of 15 instead of 16. [many thanks
1589 to Jean Michel Rouet for pointing out this bug].
1591 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1592 1. Finish merging JMR patch for writting DICOM from scratch
1593 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1594 3. Use const ref when possible
1595 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1596 5. A few more comments
1597 6. CreateUniqueUID can now be called without parameter"
1599 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1600 * ENH: Slightly bigger patch:
1601 1. Getting toward full integration of JMR patch for writting dicom from scratch
1602 2. Update Test to test part of this patch: CreateUniqueUID
1603 3. File was not close properly in gdcmDict
1604 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1605 5. Use of const ref instead of copy (speed issue)
1606 6. Remove temporary (duplicate) string in TranslateToKey
1607 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1608 8. Do not repeat virtual in subclasses
1609 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1611 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * Apply first patch toward better string comparison when dealing with broken
1613 DICOM files. Essentially the string could be padded with a space instead
1614 of a null character as defined by standard
1616 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1618 because never used... and in the same time, that's remove some memory leaks
1620 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1621 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1622 * In examples and tests : change the type of image data variables from void*
1623 to uint8_t*. Remmove all delete on image data variables
1625 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1627 Verify the file pointer value before open the file, and if it's not null,
1628 a verbose message is generated.
1629 Close correctly the file when the file isn't considered dicom-like. The
1630 correctly close is a call to CloseFile.
1631 When closing the file pointer, test if its not null to close the file.
1632 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1633 file. For an uncompressed image, the copied data correspond in the least
1634 case to the image size (calculated) or the image size specified in the
1635 header. A verbose is generated if these two size mismatch
1637 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1638 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1639 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1640 break under windows (with msvc6 compilation).
1642 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1643 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1644 compiling with MSVC6)
1646 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * Bugs fix for the Windows build with VC6
1648 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1649 needed (only for projects required VTK). If the VTK is included in all
1650 projects, there is conflicts with the jpeg lib of vtk when compiling the
1651 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1652 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1653 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1655 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1656 (like it's already made for the cout use). Otherwise, conflict with the
1659 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1661 * gdcmPython/gdcm.i:
1662 - comments on the DicomDir::Method related usage added.
1663 - now that we use the namespace gdcm, a lot of internal classes do
1664 NOT need to be wrapped anymore.
1665 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1666 DicomDir::Method) new example added.
1668 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * Improve string manipulation. I now inforce the notion of 'DicomString'
1670 A DicomString can contain as many \0 as they want
1671 and it is *always* of even length.
1672 We only support odd length for very rare case.
1673 And in the near future this should be removed.
1675 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * /binary_write/ gdcm source. Now even on big endian we are writting
1677 little endian. This should -heopfully- fix some tests
1679 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1680 * Now the dictionary is compiled into gdcm lib. This is a default
1681 behavior, thus any dic file specified is picked before failback to
1682 the one comiled into lib
1684 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * Change internals for gdcmDict. Don't use any 'new' any more.
1686 This should definitely solve any leak problem, and we should be
1687 as fast as before, as long as don't modify too much the dictionary.
1689 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * STYLE: ivars should start with a capital letter.
1691 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1692 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1694 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1695 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1696 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1697 new 2004 dictionaries added (thanks to JPR).
1698 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1699 * CLEANUP_ROUND (15) for gdcmPixelConvert
1700 - RLEFrame::NumberFragments is now of type unsigned int
1701 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1702 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1705 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1706 * Initial work in gathering all transfer syntax accessors. clearly
1707 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1708 ivars, but only one transfersyntax (class) ivar with equivalent method on
1711 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1713 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1714 discussed (plus I didn't like having a 2000 lines patch not commited)
1716 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1717 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1718 * CLEANUP_ROUND (14) for gdcmPixelConvert
1719 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1720 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1721 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1722 CloseFile() anymore.
1723 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1724 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1725 into File::Pixel_Data.
1727 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1728 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1729 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1730 * CLEANUP_ROUND (13) for gdcmPixelConvert
1731 Substituted File::ParsePixelData() with PixelConvert::Print() new
1733 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1734 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1735 method to those classes.
1736 - src/gdcmFile.[cxx|h]:
1737 -- Added a ::Print() method.
1738 -- PixelConverter is now a reference instead of a member.
1739 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1740 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1742 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1743 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1744 collaboration diagram and inheritance diagram should be generated with
1746 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1747 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1748 pointlessly wrapped (see
1749 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1750 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1751 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1752 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1753 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1754 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1755 -- File::Initialise: PixelConverter setup moved away to
1756 PixelConverter::GrabInformationsFromHeader()
1757 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1758 interpretation moved away to PixelConverter::BuildRGBImage()
1760 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1762 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1764 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1766 displayed on Win32 when a brutal abort() occurs (because of uncatched
1767 exception). See TODO new entry of this commit for more on this.
1768 * TODO added new entry.
1769 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1770 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1771 - HandleColor is no longer called from gdcmFile.cxx
1772 - gdcmPixelConvert.cxx clean up on method arguments and internal
1773 variable names for semantical coherence.
1775 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1776 * Finished lossless transition, not only do we now read all lossless jpeg
1777 images, without the need of the Cornwell lib, but we do read them properly now
1778 * To reduce code (well to avoid code duplication), I defined a common place
1779 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1780 redefine symbols. This is not perfect but this the best solution I found for a
1781 compilation time jpeg option.
1783 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * Update jpeg ijg lib to support lossless jpeg implementation
1785 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1787 * Also added a special copyright for dcmtk since we use their bugfixes.
1790 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1792 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1793 matters, as stated in warning note at beginning of %include section).
1794 * src/gdcmDicomDir*.[cxx|h]: coding style
1795 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1796 * src/gdcmJpeg8.cxx: doxygen fix.
1797 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1798 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1799 from File:: to PixelConvert::.
1801 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1803 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1804 - more code moved away from File:: to PixelConvert::
1805 - fat setup of PixelConverter set in place in File::Initialise.
1807 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1808 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1809 namespace at the file system level. So now you should convert your examples
1811 gdcmHeader -> gdcm::Header
1812 It would be nice if people keep in mind to no open the namespace, since it
1813 allows compilation on broken plateform which were defining common symbol in
1814 the standard namespace (like LP, Unknown ...)
1816 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1817 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1818 The JPEG fragments are now parsed at the same stage than the RLE
1819 information. All code related to JPEG is now in gdcmPixelConvert:
1820 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1821 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1822 export a gdcmFile:: method. Those are simply global functions
1823 (for the time being this is better than having them attach to
1824 either gdcmFile:: or gdcmPixelConvert::).
1825 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1826 and stores the result in a gdcmJPEGFragmentsInfo.
1827 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1828 code (among other stuff) moved away from gdcmFile:; to
1831 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1833 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1834 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1835 clean up of RLE related code.
1836 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1837 - src/gdcmRLE.cxx removed
1838 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1839 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1840 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1841 * CLEANUP_ROUND (9) for gdcmPixelConvert
1842 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1843 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1844 away from gdcmFile:: to gdcmPixelConvert::.
1846 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1848 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1849 This is because Parse7Fe0 used to parse the pixels to compute the
1850 length. This task was passed over to FindDocEntryLengthOB() a long
1851 time ago, EXCEPT I forgot the OW case...
1852 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1853 we just recylce the code for parsing RLE fragments and computing
1855 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1856 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1857 with the retired Parse7Fe0().
1858 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1859 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1861 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1863 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1864 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1865 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1866 * CLEANUP_ROUND (4) for gdcmPixelConvert
1867 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1868 to return an unused length.
1870 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1872 this should be cleanner from the plane view. The iostream are erally a pain
1873 to use to do simple stuff.
1875 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * Redo the compilation of the ijg jpeg library. Now only one source is
1877 necesseray. No need to rename file by hand what so ever. CMake handle the
1878 copying of the file within different directory, configure header file to
1879 modify some symbol. The only addition made to ijg wasd a mangle table so
1880 that symbol are different whether we are within 8bits or 12bits.
1882 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1883 * Added documentation of vtkgdcmReader on Website:
1884 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1885 with it's binary name).
1886 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1887 the Website to be more complete.
1888 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1889 doxygenated documentation.
1890 - Doc/DoxyVtkGdcmReaderExamples.txt added
1891 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1892 DoxyVtkGdmReaderExamples.html )
1893 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1894 * CLEANUP_ROUND (3) for gdcmPixelConvert
1895 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1897 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * CLEANUP_ROUND (2) for gdcmPixelConvert
1899 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1901 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * CLEANUP_ROUND for gdcmPixelConvert:
1903 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1904 - src/gdcmPixelStuff[h|cxx] removed
1905 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1906 - src/CMakeLists.txt changed accordingly
1907 * GDCMHOME clean up:
1908 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1909 gdcmVersion.py moved to newly created ATTIC related
1910 gdcmPython/SetupOldies/ directory.
1911 * Autotools clean up:
1912 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1913 - autogen.sh configure.in acinclude.m4 python.m4 removed
1915 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1916 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1917 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1918 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1920 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * TODO updated with Mathieu suggestions. I proposed a template for
1922 describing TODO entries and used it for new entries.
1923 * Added Doc/Website/CodingStyle.html, Developpers.html,
1924 DeveloppersPython.html, GdcmDataCvs.html and
1925 DownloadVersion0_1.html, DownloadVersion0_3.html.
1926 * Some Doc/*.txt Doxygen files (which do not really concern the
1927 documentation itself, but the website) moved to html and
1928 placed in directory Doc/Website:
1929 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1930 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1931 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1932 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1933 * CMakeLists.txt changed accordingly.
1934 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1935 DeveloppersPython.html
1936 * INSTALL nows refers to Doc/Website/Installation.html
1938 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * Added Doc/Website directory, that contains a first raw version
1942 2004-09-23 Jean-Pierre Roux
1943 * FIX In order not to be poluted any longer by casting problems,
1944 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1945 we can now delete[] it safely
1946 * VoidArea is now called BinArea (less confusing name),
1947 and all the methods called ...VoidArea... are now ... BinArea...
1948 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1950 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1952 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1953 up to the destructor of gdcmElementSet to clean up TagHt and it's
1956 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1957 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1958 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1960 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1961 * ENH: added some utility method that builds a flat dictionary
1962 holding all the Dicom entries contained in the recursive structure
1963 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1964 an example of usage.
1965 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1966 BuildFlatHashTable() that build a flat dictionary.
1967 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1968 gdcmDocument is now a friend of gdcmElementSet.
1969 - src/gdcmElementSet.cxx: clean up.
1970 - Example/FlatHashTablePrint.cxx added.
1971 - Example/CmakeLists.txt changed accordingly
1973 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1975 moved away from gdcmDocEntrySet (since this class is an abstract class
1976 acting like an interface). SQDepthLevel and BaseTagKey are now
1978 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1979 and associated accessors. Doxygenation of the class.
1980 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1982 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1983 Use SQDepthLevel accessor instead. ::Print() adapted.
1984 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1985 - src/gdcmDocument.cxx changed accordingly.
1987 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1989 - The following is the doxygen comment of the typedef declaration
1990 of gdcmTagKey in src/gdcmCommon.h:
1991 gdcmTagKey is made to old an "universal" (as in URL, Universal
1992 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1993 A dicom tag always has a group and an element, but a set of tags
1994 embeded in various (optionally nested) sequences and sharing
1995 the same group and element all share the same (group, element)
1996 "identifier". Hence the (group, element) cannot be used as an
1997 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1998 In order to construct a proper tag identifier (i.e. a key) we
1999 consider the following definition of a TagKey:
2000 - let Group, Element be the string representation of the
2001 group and element dicom tag members,
2002 - let ItemNumber be the string representation of the integer
2003 index of the considered item number of a sequence,
2004 Let the key of a tag embeded in a sequence, noted SeqTag, be
2006 /ItemNumber#Group|Element
2007 where "/", "#" and "|" are characters acting as separators.
2008 Then the general form of a gdcmTagKey is given by:
2009 Group|Element<SeqTag>
2010 where <SeqTag> means NO or many instances of SeqTag.
2011 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
2014 but the gdcmTagKey of a tag "embeded" is the first item of
2015 a sequence, itself nested in the third item of a sequence is the
2017 0004|1220/2#0008|0082/0#0008|0090
2018 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
2019 order to hold the new sequence compatible key. Previously, the
2020 GetKey() method would look in the underlying gdcmDictEntry.
2021 - src/gdcmDocEntry.cxx:
2022 -- constructor now copies the underlying DictEntry key, in the local
2024 -- ::Print: displays the member Key, instead of the (group, element).
2025 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2026 - src/gdcmDocEntrySet.h:xi
2027 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2028 -- now has a new BaseTagKey member.
2030 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2031 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2033 This poses the problem with the semantics of the following lines
2034 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2035 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2036 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2037 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2038 to the long FIXME note for what the problem is. Nevertheless in
2039 order to get things working the dicom dictionary was altered !
2040 Please fix things urgently...
2041 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2042 information), see above note on moving the member VoidArea. Nevertheless
2043 the following entries previously correctly set as US are now inproperly
2045 0028 1201 OW IMG Red Palette Color Lookup Table Data
2046 0028 1202 OW IMG Green Palette Color Lookup Table Data
2047 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2048 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2049 of gdcmDocEntry moved to gdcmSeqEntry.
2050 * src/gdcmSeqEntry.cxx: STYLE.
2052 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2055 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * gdcmPython/testSuite.py: all the test suite in python is now moved
2057 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2058 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2059 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2061 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2062 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2063 to avoid inclusion recursion until STL is reached.
2064 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2065 mecanism. errno.h is not included in gdcm anymore.
2066 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2067 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2069 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2070 gdcmData/TestAllEntryVerifyReference.txt
2071 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2072 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2073 exception_on_error parameter.
2074 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2075 - vtk/vtkGdcmReader.cxx changed accordingly,
2076 - Example/*.cxx and Test/*.cxx changed accordingly.
2078 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2080 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2081 enable_sequences removed from gdcmHeader constructor and dependencies.
2082 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2083 * gdcmPython/demo/PrintHeader.py: dummy fix.
2084 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2085 skip_shadow removed from gdcmHeader constructor and dependencies.
2086 * Example/*.cxx and Test/*.cxx changed accordingly.
2088 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2090 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2092 2004-07-21 Jean-Pierre Roux
2093 * FIX Now, Parsing and Printing a DICOMDIR do work!
2094 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2096 2004-07-20 Jean-Pierre Roux
2097 * FIX Some brain damaged headers have Zero-Lenght fields
2098 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2100 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2101 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2102 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2103 variable (instance of gdcmDebug) by a definition macro, and the instance
2104 is now in static in the gdcmDebug class
2105 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2106 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2108 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2109 * WARNING: ctest now depends more tightly on gdcmData. You should
2110 check out gdcmData properly for things to run smoothly...
2111 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2112 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2113 we need the pixels not be loaded in order to use the ValEntry
2114 that displays position and size).
2115 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2116 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2117 be deprecated. If you have any doubts about the advantages of a
2118 modern scripting language (read Python) versus grass root C++ (i.e.
2119 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2120 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2121 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2122 Anyhow, consider documenting the gdcmData images in
2123 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2125 * Test/CMakeLists.txt:
2126 - now uses TestAllEntryVerify.cxx
2127 - specific comments on oldACR00001.ima (now renamed in gdcmData
2128 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2129 gdcmData/TestAllEntryVerifyReference.txt
2132 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * src/*.[h|cxx] : typedef clean up
2134 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2135 - TagKey renamed to gdcmTagKey (for external usage)
2136 - VRKey renamed to gdcmVRKey (for external usage)
2137 - removal of typedef duplication.
2138 - Removed all unecessary inline keyword from class inline definitions.
2139 - Some method|function(void) declarations replaced with method|function().
2140 * src/jpeg/libijg12/jdhuff12.c:
2141 - printf polluting ctest removed.
2142 - TAB removal for comminting
2144 - TestAllReadCompareDicom.cxx: added a test that compares all the
2145 images in gdcmDataImages.h with corresponding images in
2146 gdcmData/BaselineDicom/. When baseline images are not present
2147 this test creates them.
2148 Note: we need to validate each reference image, but before that
2149 I'd like to rename them with a more explicit name...
2150 - CMakeLists.txt: changed accordingly.
2151 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2152 including each header needed).
2154 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2156 test suite to the Example directory. Are concerned:
2161 - TestWriteSimple.cxx
2162 * Test/CMakeLists.txt: added some comments on reasons for black listing
2163 image gdcmData/oldACR00001.ima
2165 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * Test/CmakeList.txt: removed the following from black list (to be coherent
2167 with removal from gdcmData):
2168 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2169 - gdcm-MR-PHILIPS-16.dcm
2171 Added the following because after last cvs update, they cause
2172 ctest -R TestReadWriteReadCompare
2174 - gdcm-MR-SIEMENS-16-1.acr
2176 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2177 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2178 new comments in this file) we temporarily (sigh) move to a weaker
2180 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2181 we don't need to black list the following images anymore:
2182 - 8BitsUncompressedColor.dcm
2184 - US-PAL-8-10x-echo.dcm
2185 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2186 fixes and the beautified code ;-)
2187 This fixes the bug introduced in version 1.42 (when beautifying)
2188 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2189 Note: ctest was blind to this bug (this means we need to still
2190 improve the test suite). The bug could be detected by using
2191 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2193 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2194 and by displaying the (garbage) produced file temp.XDCM...
2196 2004-06-29 Jean-Pierre Roux
2197 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2198 - replace by uggly but working old code :-(
2199 A lot of things should be OK again.
2200 It's really urgent to have a test suite that *tests*,
2201 to prevent Frog's beautifying sessions to break all the stuff
2202 (twice, withing a fortnigh ...)
2204 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2205 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2206 redundancy) to added Test/TestReadWriteReadCompare.cxx
2207 * Test/CmakeList.txt: because the compare test of
2208 Test/TestReadWriteReadCompare.cxx fails, the following images are
2209 black listed: - 8BitsUncompressedColor.dcm
2211 - US-PAL-8-10x-echo.dcm
2212 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2213 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2214 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2215 and ad-hoc kludge. This kludge is now removed, and on encountering
2216 such an image (OB field brain damaged) we set errno. Then in
2217 ::FindDocLength() we "fix" the length as being ALL what remains
2218 in the file (until EOF). We then proceed, hoping for the best...
2219 This fixes a SegFault in ShowDicom when trying to write such an
2221 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2222 (because TestWriteRead breaks on it, after a non conformal commit?).
2223 ctest now runs properly, except for MakeDicomDir (which was always
2224 broken) and the Python related stuff (still not fixed).
2226 2004-06-24 Jean-Pierre Roux
2227 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2228 FIX : Test/TestReadWrite now iterates on all the file names
2229 (instead of infinite loop)
2230 ENH : Test/TestWriteRead now iterates on all the file names
2232 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2235 2004-06-24 Jean-Pierre Roux
2236 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2237 when SamplesPerPixel =3
2238 - now Write is no longer confused by
2239 'BitsAllocated = 12" and 'BitsStored=12"
2240 - "UN" value representation Elements are now written correctly
2241 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2242 ENH : - now gdcmHeader has its own Write methods
2243 (in order to split the job that has not to be done
2246 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2248 loop on the same image until memory went out.
2249 Note: this means we still have gobs of memory loss in PrintDocument
2250 * src/gdcmDocument.cxx: fixes problem on parsing on file
2251 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2253 2004-06-24 Jean-Pierre Roux
2254 FIX : Write - All the Sequences and Sequence Item are now written
2255 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2256 is added a the end, when necessary.
2257 - A lot of brain-damaged images, that were read correctly are
2258 now written correctly
2259 - length compatible BinEntry are now loaded correctly
2260 (even for odd groups)
2261 Note : only Explicit Value Representation was checked.
2262 (question : is implicit VR really necessary for gdcm ?)
2264 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * DEVELOPPER: added a proposition of coding style.
2266 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2269 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2270 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2271 Use the gdcmDocEntry::Print() and Write() instead.
2272 * src/gdcmDocument.cxx: bug fix.
2274 2004-06-22 Jean-Pierre Roux
2275 FIX : gdcmDocument.cxx
2276 - Now we do recognize the JpegLossLess format (there was a misstyping in
2277 code 'beautyfication' :-(
2278 - Now we automaticaticaly load the Luts, if any
2280 2004-06-22 Jean-Pierre Roux
2281 In order : to write Sequences, whatever their imbrication level,
2282 : to allow user to create his own Sequences
2283 a lot of modif where necessary (adding, moving, or virtualising methods)
2285 WARNING : save your own sources *before* cvs up !
2288 ADD virtual void Write(FILE *fp, FileType filetype);
2291 ADD virtual void Write(FILE *fp, FileType filetype);
2292 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2295 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2296 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2297 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2298 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2299 ADD std::string GetEntryByName(TagName name);
2300 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2302 std::string vr = "unkn",
2303 std::string fourth = "unkn",
2304 std::string name = "unkn");
2305 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2306 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2307 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2308 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2309 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2310 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2311 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2312 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2315 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2316 ADD virtual std::string GetEntryByName (TagName tagName);
2317 ADD virtual std::string GetEntryVRByName (TagName tagName);
2318 REM virtual bool Write(FILE *, FileType);
2319 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2320 FILE *_fp, FileType type);
2321 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2322 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2323 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2324 REM virtual std::string GetEntryByName (std::string tagName);
2325 REM virtual std::string GetEntryVRByName (std::string tagName);
2326 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2327 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2328 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2330 std::string vr = "unkn",
2331 std::string fourth = "unkn",
2332 std::string name = "unkn");
2333 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2334 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2335 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2336 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2339 ADD virtual void Write(FILE *fp, FileType filetype);
2342 ADD virtual void Write(FILE *fp,FileType filetype);
2345 ADD virtual void Write(FILE *fp, FileType filetype);
2346 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2347 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2348 REM std::string GetEntryByName(TagName name);
2351 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2353 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2355 The default constructor invoked by the line
2356 gdcmHeader *f1 = new gdcmHeader( header );
2357 was gdcmHeader::gdcmHeader(bool) instead of the expected
2358 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2359 Hence the parsing wasn't executed... See also below.
2360 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2361 as explicit constructor didn't do the trick to fix the above problem.
2362 Could anyone explain why ?
2363 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2364 properly calls gdcmValEntry::Print() (that was weed out from
2365 code related to gdcmBinEntry).
2367 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * In order to fix memory leaks:
2369 - Test/TestWriteSimple.cxx: added cleaning of free store through
2371 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2372 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2373 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2374 (through the call to ::AddDicomDirMeta()) or the destructor
2375 would crash when deleting uninitialized ::metaElems].
2376 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2377 - src/gdcmDocument.cxx:
2378 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2379 from dynamic stores.
2380 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2381 was causing memory leaks.
2382 - src/gdcmSQItem.cxx:
2383 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2384 cleanly handled with polymophism: sorry but my milage is low).
2385 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2386 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2387 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2388 This avoids SegFaulting.
2389 - src/gdcmSQItem.h: coding style.
2391 - Test/TestWriteSimple still severely sucks. The output image content
2392 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2393 damaged when displayed with vtkgdcmViewer.
2394 - on memory leaks: TestWriteSimple leaks really less (see entry
2395 of 2004-06-18 in Changelog file for the call to valgrind).
2396 - on segfaults: ctest now passes all the tests but one (no more
2398 * Erroneous leading white fix:
2399 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2400 white[s] (as opposed to from >> xxx, that removes it [them].
2401 - src/gdcmTS.cxx: ditto.
2402 - gdcmPython/testSuite.py: dirty related kludge removed.
2403 * src/*: remaining references to gdcmParser removed.
2404 * src/*[cxx|h]: added copy[way]left header.
2407 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * In order to fix writing of dicom files:
2409 - Test/TestWriteSimple.cxx: a simpler example of writing.
2410 - Test/CMakeLists.txt changed accordingly.
2411 - src/gdcmDocument.cxx:
2412 -- The destructor now recursilvely removes potential sequences.
2413 -- Bug fix in ::IsJPEG2000()
2414 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2415 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2417 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2418 to only declared) and build on top of
2419 ::GetDocEntryByNumber(guint16, guint16).
2420 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2421 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2422 for usage in destructor and treatement of promotion in
2423 ::ReplaceOrCreateByNumber().
2424 - src/gdcmSQItem.cxx: destructor should better handle his job.
2425 Test/TestWriteSimple now runs (or at least it DOES something).
2426 * We can now start hutting memory links. A good starting point is:
2427 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2428 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2429 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2431 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * Valgrind note: after Mathieu Malaterre teached me how to read
2433 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2435 Using gcc, you can force the STL to use malloc and to free memory as
2436 soon as possible by globally disabling memory caching.
2437 With 3.2.2 and later, you should export the environment variable
2438 GLIBCPP_FORCE_NEW before running your program.
2439 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2440 simply vanish (it is still not clear to me, whether this means that
2441 STL std::string leaks or if valgrind believes it leaks...).
2442 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2443 running bin/gdcmTests makeDicomDir):
2444 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2445 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2447 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2448 SegFaulting (I drowned in DicomDir related code when trying to
2449 understand why the list is empty...).
2450 * src/gdcmDocument.h: first BSD license header try.
2451 * Doc/License.txt added.
2453 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * src/gdcmDocument.[h|cxx]:
2455 - Clean up of the Transfer related predicates. They are now all based
2456 on new method isGivenTransferSyntax, that (should) handle properly
2457 the padding problem.
2458 - general clean up, simplification, and coding style.
2459 - Specific clean up of Parse7FE0() (umproperly named actually).
2460 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2462 2004-06-14 Jean-Pierre Roux
2464 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2465 - fix the display of SQItem ordinal number
2466 - add the GetSQItemByOrdinalNumber method
2467 - remove some useless never written private methods
2469 2004-06-14 Jean-Pierre Roux
2471 - adding a constructor taking a gdcmDocEntry as an input param
2472 - ReplaceOrCreateByNumber now returns :
2473 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2474 a gdcmValEntry * if a string value is passed as a param
2476 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2477 according to the param type (no longer sets a gdcmDocEntry)
2478 - GetValEntryByNumber, GetBinEntryByNumber added
2479 - NewValEntryByNumber and NewBinEntryByNumber added
2481 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2483 - GetSQItemNumber and SetSQItemNumber added, to provide
2484 a (relative) Item identier inside a given Sequence
2485 \warning : some pb remaining around this number
2487 - AddEntry now takes the Item Number as a param
2489 - adding a constructor taking a gdcmDocEntry as an input param
2491 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * Memory leak hunt with the following command:
2493 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2494 --show-reachable=yes gdcmTests PrintDocument
2495 It looks like many (all?) leaks are due to the STL (or a bad usage
2496 of the STL. The lines producing the leaks now have a comment with
2497 a "MEMORY LEAK" tag: you can retrieve them with
2498 grep "MEMORY LEAK" src/*
2499 Here are two typical examples which I can't help fixing:
2504 char * test = "babo";
2505 name = test; //// <--- valgrind detects 960 bytes lost in
2506 //// call to std::string::operator=(char const*)
2507 name.clear(); //// Doesn't help !
2515 std::cout << "Type a bunch of characters followed by RETURN: ";
2516 getline(std::cin, line); //// <--- valgrind dectects a loss
2517 //// of 1320 bytes in call to
2518 /// std::basic_istream<>& std::getline<>
2524 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * src/gdcmHeader.[cxx|h]:
2526 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2527 and related, moved away to gdcmDocument.
2528 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2529 the corresponding protected accessors of inherited class
2530 gdcmDocument, removed ! As a consequence gdcmFile had to be
2531 declared friend of class gdcmDocument (see below).
2532 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2533 - Clean up of undefined or unused methods.
2534 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2535 account the changes to gdcmHeader.h).
2536 * src/gdcmDocument.h:
2537 - gdcmFile is now a friend class (in order to take into account the
2538 changes to gdcmHeader.h).
2539 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2540 (see changes to gdcmHeader.h).
2541 - Accessors (reading on the form GetEntry*) are now public.
2542 - Clean up of undefined or unused methods.
2543 * src/gdcmDocument.cxx:
2544 - adaptation to changes to gdcmDocument.h
2545 - ::OpenFile now writes a verbose message when file cannot be opened.
2546 - some std::string properly set to VRKey
2547 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2548 references to gdcmDocument.
2549 * Test/TestFindTags.cxx: changed accordingly to above changes.
2550 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2551 cvs repository gdcmData.
2553 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2555 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2556 conflicts with gdcmValEntry::voidArea.
2557 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2558 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2559 Value representation between StringRepresentable and BinaryRepresentable.
2560 * src/gdcmDocument.cxx:
2561 - method ParseDES: proper indentation restored and usage of
2562 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2563 - method LoadDocEntry: the fingerprint left in the SetValue() of
2564 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2565 removed. Reverting to previous code segment with the proper
2566 dynamic_cast< gdcmValEntry* >.
2567 Note: this was (partially) breaking the python test suite
2568 (gdcmPython/testSuite.py) that made usage of the above
2569 fingerprint to check presence of "Pixel Data".
2570 * src/gdcmDocEntry.h: coding style.
2571 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2572 now taken into account.
2573 * gdcmPython/gdcm.i: adaptation to the new internal representation
2574 of gdcm (exit gdcmParser, hello gdcmDocument).
2575 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2577 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2578 anymore, but instead prints the loaded Python dictionary.
2579 * .... alas, the python testSuite is still broken.
2581 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2582 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2584 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2585 * src/gdcmUtil.h : export methods
2587 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2588 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2590 * Initial addition of automatic python testing
2591 * Initial addition of automatic image comparison
2593 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2594 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2595 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2597 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2598 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2599 * Test/ShowDicom.cxx : bug fix for msvc compilation
2600 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2602 2004-05-04 Jean-Pierre Roux
2603 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2604 new concepts (and new classes) :
2605 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2606 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2607 - Sequence Doc Entries (gdcmSeqEntries)
2608 a Sequence is composed of Items.
2609 Each item is a set of Doc Entries (this is recursive)
2610 The non uniqueness of the 'Dicom tag' is due to this recursivity
2611 (never taken into account)
2612 Our unability to add a new 'entry' in the header
2613 at the proper location (neither in the H-Table (map or multimap),
2614 nor in the Chained List is also due to this recursivity.
2615 Don't try, right now, to use/modify/compile these new sources :
2616 nothing is finished.
2617 We just commit all the stuff, 'as is', in order not to loose it.
2619 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2620 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2622 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2623 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2624 file prefix (SetFilePrefix)
2626 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * Add a new test: ShowDicom, for now this is just the c++ version of
2628 checkRead.sh, later it will be able to compare the image read against a
2630 * Replace the DEBUG on the stack with a global entry in cmake interface:
2631 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2633 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2634 * Add an example subdir, with a real example on how to read + write a
2637 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2639 * Doc/CMakeLists.txt: the main page is now properly differentiated
2640 between the developper and user version.
2641 * Doc/doxygen.config.in: dropped search related obsolete flags
2642 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2644 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * DEVELOPPER: added some helpfull comments for compile/test/install
2648 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2649 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2650 src directory, now generated in the build dir.
2651 2. Tests as mentionned smarter
2653 4. Add a new method in gdcmDict that return the PubDict by name
2654 this is interesting for 3rd party lib like ITK,
2655 where we could set the institution name / patient name...
2657 * ENH: 1. Now the test suite is working for real
2658 2. All binaries are now output in the gdcm-bin directory
2659 (this was not true before)
2661 2004-04-28 Jean-Pierre Roux
2662 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2663 SeQuence indented printing of Dicom Header.
2664 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2665 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2666 Computation of SQDepthLevel is now part of gdcmHeader constructor
2667 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2668 tree-like structure of a Dicom Header.
2669 * FIX Test code cleaning
2671 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2672 * ENH: Adding automatic testing
2673 1. Need a DartConfig.cmake to submit to public
2674 2. Add a test driver gdcmTest.cxx
2675 3. gdcmTestMain, an helper for the main test driver gdcmTest
2676 4. Files in Test don't have a main anymore, this becomes interesting
2677 when we add more and more tests, thus dsw don't have to load
2679 * ENH: Adding a GDCM_DATA_ROOT for testing
2680 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2681 one file instead of seven + some small cleanup
2683 2004-04-22 Jean-Pierre Roux
2684 * ENH Minor changes to the Print() methods.
2685 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2686 Header printing. Example given with :
2687 > PrintHeader fileName 2 new
2688 (SQ based tree-like structure still to be done for the Header ...)
2690 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2691 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2692 1. I have added some unsigned where needed
2693 2. Some function parameter not used -> (void)
2694 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2695 4. g++ don't like character '\' in comment
2696 5. #define jpeg_create_decompress jCreaDecompress
2697 this really need to be fixed
2698 6. virtualize destructor of gdcmObject ... leakage
2699 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2700 this also really need to be fixed
2701 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2702 remove compression file
2703 (as we only do decompression, right ?)
2704 * ENH: Change malloc/calloc/free with c++ equivalent
2706 2004-04-21 Jean-Pierre Roux
2707 * FIX gdcmHeaderHelper::GetXSpacing
2708 when a single value is found (bug ?), xpacing is now
2709 defaulted to yspacing
2711 2004-04-19 Jean-Pierre Roux
2712 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2713 * ENH add parameters :
2714 bool exception_on_error = false,
2715 bool enable_sequences = false,
2716 bool ignore_shadow = false
2717 to the gdcmFile constructors to be full gdcmParser compliant
2718 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2719 to allow reading of PAPYRUS 3.0 files
2721 2004-04-06 Jean-Pierre Roux
2722 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2724 2004-04-02 Jean-Pierre Roux
2725 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2726 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2727 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2729 2004-03-30 Jean-Pierre Roux
2730 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2731 for ACR file, written out as DICOM files (hope so...)
2733 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2735 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2736 moved to base class gdcmParser and only the specialisation is kept
2738 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2739 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2740 already does the job.
2741 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2742 (to be consistent with gdcmParser::WriteEntries).
2744 2004-03-30 Benoit Regrain
2745 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2746 upate of the object's instance. It's passed to 2 in the unfavorable
2747 case : one in the ExecuteInformation, one in the ExecuteData
2749 2004-03-29 Jean-Pierre Roux
2750 * ENH : Check on file type to be written moved
2751 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2752 * FIX : gdcmObject::ResetBoundaries now stops properly
2753 when end-of-list is reached
2754 : gdcmVersion modified (as Benoit Regrain asked)
2756 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2758 * src/gdcmUtil.cxx: added forgotten iostream include.
2759 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2760 equivalent to ExplicitVR in existing code).
2762 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2763 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2764 now contains all the gdcmGlobal related code.
2765 * minor coding style and doxygenation changes.
2767 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2769 now contains all the Debug related code.
2770 * minor clean-up of includes in src/*.cxx
2771 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2772 CreateCleanString) removed.
2773 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2774 * Doc/DoxyMainPageUser.txt added.
2775 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2776 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2777 src/gdcmDirList.cxx)
2779 2004-03-24 Jean-Pierre Roux
2780 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2782 2004-03-23 Jean-Pierre Roux
2783 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2784 big endian made volumes
2785 * ENH Now gdcmParser constructor and destructor are protected to forbid
2786 end user to instanciate class gdcmParser
2787 (only gdcmHeader and gdcmDicomDir are meaningfull)
2789 2004-03-22 Benoit Regrain
2790 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2791 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2792 gdcmSerie to gdcmDicomDirSerie
2794 2004-03-19 Jean-Pierre Roux
2795 * ENH Now the tree-like structure describing a DICOMDIR comming from
2796 an already existing DICOMDIR file is consistent with
2797 the home-made tree-like structure build ex-nihilo
2798 or build from the files held (recursively) in a Directory
2799 functions gdcmDicomDir::CheckBoundaries()
2800 gdcmObject::SetBoundaries() added
2802 2004-03-17 Jean-Pierre Roux
2803 * REM (Eric Boix bug) : removal of meaningless
2804 gdcmDicomDirImage::NewImage function.
2805 * FIX now file names and directory name are written properly in the
2807 * FIX now gdcmDicomDir constructor may be call without any trick
2810 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2812 of gdcmDicomDirImage::NewImage as empty function.
2814 2004-02-28 Jean-Pierre Roux
2815 * ENH add gdcmDicomDir:NewPatient
2816 add gdcmDicomDirPatient:NewStudy
2817 add gdcmDicomDirStudy:NewSerie
2818 add gdcmDicomDirSerie:NewImage
2819 to allow making gdcDicomDir object.
2820 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2821 (as opposite to the gdcmHeader chained list)
2823 2004-02-11 Benoit Regrain
2824 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2825 when using from python
2827 2004-02-10 Benoit Regrain
2828 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2829 * FIX : in gdcmDicomDir when the directory is empty
2830 * ENH : add callback and methods to get the progression of dicomDir
2833 2004-02-06 Jean-Pierre Roux
2834 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2835 - GDCM_META added to gdcmDicomDirType
2836 - class gdcmMeta created
2837 * ENH : - A brief summary is now displayed at the beginning of
2838 'testDicomDir' to help disaster magnitude estimation
2839 * REM : Now useless Test/explDICOMDIR.cxx
2841 2004-02-05 Benoit Regrain
2842 * ENH : add methods in gdcmObject to get the hash table or the list of
2844 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2845 * FIX : wrapping python for TagHeaderEntryHT
2847 2004-02-04 Benoit Regrain
2848 * FIX : even length for some strings when writting the dicom dir
2849 * FIX : sort the images in the dicom dir
2850 * FIX : Bug fix for python use of dicom dir
2851 * ADD : a python demo
2853 2004-02-04 Jean-Pierre Roux
2854 * FIX : Final solution (?) for icone embedded images
2855 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2856 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2857 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2858 gdcmData/gdcm-MR-SIEMENS-16.acr1
2859 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2860 to make full checking easier
2862 2004-02-04 Benoit Regrain
2863 * FIX : WriteEntries : coding style & logic in parameters
2864 * FIX : Set the elements to create the DicomDir in a dictionary file
2866 2004-02-03 Benoit Regrain
2867 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2868 * gdcmDicomDir : add the load of directory
2869 * Bug fix and print add-on
2871 2004-02-03 Jean-Pierre Roux
2872 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2873 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2874 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2875 * FIX gdcmParser.cxx : 'group length' elements are now considered
2876 as integers, even for shadow groups, when file is Implicit VR
2878 2004-02-02 Jean-Pierre Roux
2879 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2881 of the last synonym :-(
2882 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2884 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2885 * FIX taking into account the possible 7fe0,0010 multiplicity
2886 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2887 to allow removal of references to 7fe0,0010, to deal with
2888 ACR-NEMA images, when 0028,0200 is meaningfull
2890 2004-01-31 Jean-Pierre Roux
2891 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2892 no longer writes 'Un' on disk
2893 * FIX SQ elements with actual length are now dealt with corectly
2894 * FIX gdcmFile::WriteBase make the difference, for color images, between
2895 the length (for Palette expanded images)
2896 and Raw Length (non expanded image + Palette)
2897 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2898 (that broke Write). Replaced by UL.
2899 Aware user will reload the field if he
2900 thinks it's necesssary
2902 2004-01-30 Jean-Pierre Roux
2903 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2904 when 'dirty Acr' is found, to be compliant with the new
2905 IsReadable() methods.
2907 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2908 (no DOUBLE images in kosher DICOM,
2909 but so usefull for people that miss them ;-)
2911 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2912 DICOMDIR related utilities (not checked as Windoze compliant)
2914 2004-01-28 Jean-Pierre Roux
2915 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2917 2004-01-27 Jean-Pierre Roux
2918 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2919 to allow skipping the shadow elements, to save memory space.
2920 The TRUE value for this param has to be used
2921 with a FALSE value for the 'enable_sequence' param.
2922 ('public elements' may be embedded in 'shadow Sequences')
2923 * gdcmHeader methods now deal with 'embedded icones images' in the header
2924 (even when an 'icone image sequence' is announced by the
2925 element (0x0088,0x0200), but there is NO icone at all ...
2927 * gdcmHeader sometimes Image Location value doesn't follow
2928 the supposed processor endianity (see gdcmData/cr172241.dcm).
2931 * gdcmHeader add the method
2932 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2933 to get *all* the Header Entries with the same tag.
2934 GetHeaderEntrySameName is probabely *useless*
2935 (no meaning : Name is *not* an identifier within the Dictionary)
2937 2004-01-26 Benoit Regrain
2938 * Bug fix in the print of hexadecimal representations. Remove long fields
2939 in the print and add a third level of print to print them
2941 2004-01-23 Benoit Regrain
2942 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2943 * Bug fix on test suite after remove the strip made on not string fields
2944 * Split the IsReadable method between gdcmParser which test that the file
2945 is dicom and gdcmHeader which test that it's an image file
2947 2004-01-22 Benoit Regrain
2948 * DicomDir : clean code, add methods, set variables in protected or private
2949 * gdcmUtil : bug fix for the clean string method
2951 2004-01-19 Benoit Regrain
2952 * Add the use of shadow dictionaries
2953 * bug fix and coding style
2955 2004-01-19 Benoit Regrain
2956 * src/gdcmFile.cxx : bug fix concerning the close of file
2957 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2958 * Add the update of header entries using the shadow library
2960 2004-01-19 Benoit Regrain
2961 * removal of file gdcmHeader2.cxx
2962 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2963 inheriting from gdcmParser. This split is to prepare the integration
2964 of dicom dir parsing
2965 * bug fix under python
2967 2004-01-16 Jean-Pierre Roux
2968 * REM removal of class gdcmHeaderEntrySet
2969 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2970 * ADD add file gdcmHeader2.cxx
2971 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2973 2004-01-15 Benoit Regrain
2974 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2975 entries created while parsing the header. Thus, they will be destroyed
2976 when the gdcmDictSet will be destroyed
2977 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2980 2004-01-15 Benoit Regrain
2981 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2982 made a fatal error because of the memory release at the end of program.
2983 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2984 some memory and vtk seems to have some problems with that.
2985 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2987 2004-01-14 Benoit Regrain
2988 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2989 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2990 * src/*.[h|cxx] : make changes due to class name changes
2991 * gdcmPython/demo/*.py : bug fix due to method names
2993 2004-01-13 Benoit Regrain
2994 * src/*.[h|cxx] : coding style
2995 * vtk/*.[h|cxx] : coding style
2997 2004-01-13 Benoit Regrain
2998 * gdcmPython/testSuite.py : test the readable flag of file for tests
2999 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
3000 It's lied to the stl compilation by MSVC (windows, always windows...)
3001 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
3003 2004-01-12 Benoit Regrain
3004 * src/*.h : add comments
3005 * src/gdcmDictSet.h : set the method BuildDictPath in public
3006 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
3007 directly setted in the source code
3008 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
3011 2004-01-09 Benoit Regrain
3012 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
3013 * setup.py : use a reference to gdcmVERSION
3015 2004-01-07 Benoit Regrain
3016 * Modification to compile with the distutils.
3019 2003-12-10 Benoit Regrain
3020 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3021 can use a gdcmHeaderHelper to load data
3022 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3023 made in the source code
3025 2003-12-10 Benoit Regrain
3026 * Update Windows projects and .cvsignore files
3028 2003-11-12 Jean-Pierre Roux
3029 * ENH gdcmHeader constructor has one more parameter (default value : false)
3030 that allows the user to 'go inside' the SeQuences only
3032 gdcmElValSet:Print takes it into account
3034 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3035 * ENH: Update gdcmPython/CMakeLists
3036 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3037 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3039 2003-11-10 Jean-Pierre Roux
3040 * FIX : gdcmHeader::LoadElements is now based
3041 on the ListTag listElem member,
3042 not longer on the TagElValueHT tagHt member
3043 * ENH : PrintPubElVal shows (temporarily) both results,
3044 with the tagHt member and the listElem member.
3045 (it's easier to 'see' the problems when using Printheader)
3047 * FIX : old private member LgrElem is now splitted into
3048 ReadLength : Length actually found on disk (updated only
3049 if bug fixing is necessary), for internal
3051 UsableLength : Updated by FixFoundLength, to fix a bug
3052 or to allow Parser going on.
3053 Will allow to re-write a kosher header when a SeQuence
3054 with a length (not 0000) is found
3055 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3056 because gdcmElValSet::Add does not update ListElem
3059 2003-11-07 Jean-Pierre Roux
3060 * FIX misstyping in Transfert Syntax name table
3061 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3062 when they have an actual length (not 0000 nor FFFFF)
3063 (Nobody should care of it, but DICOMDIR explorers)
3065 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3066 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3068 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3069 * ENH: vtkGdcmReader now supports LUT !
3070 (vtkgdcmViewer for now is not able to use them though)
3072 2003-11-05 Jean-Pierre Roux
3073 * in testSuite.py : new files names for checking the package
3074 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3075 that returns the pixel area size to the *aware* (vtk) user
3076 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3078 2003-11-05 Benoit Regrain
3079 * in testSuite.py : Modify the rules for checking the paths
3080 : Explicit error messages
3081 * in __init__.py : Related modif
3083 2003-11-03 Jean-Pierre Roux
3084 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3085 to be used by aware (vtk) users that want to manage
3086 LUT (and no to turn the PALETTE image into an RGB pixels one)
3087 * GetPixelType now returns 8U for 24 Bits images
3088 (vtkGdcmReader compliant)
3090 2003-10-31 Jean-Pierre Roux
3091 * Removal of *all* gdcmData images and add them again
3092 in order to loose the 'history' of un-anonymised images
3094 2003-10-31 Jean-Pierre Roux
3095 * RMV : removal of useless jBitsInJsample.h
3096 for both 8 and 12 Bits JPEG Lossy Libraries
3098 2003-10-31 Jean-Pierre Roux
3099 * ENH : Add the functions gdcmFile::GetImageDataRaw
3100 gdcmFile::GetImageDataIntoVectorRaw
3101 that act as GetImageData and GetImageDataIntoVector
3102 except the making of an RGB Plane from Gray Plane + LUT
3103 Intended to aware (vtk) users who know how to manage
3106 GetLUTRGBA return a R,G,B,A LUT if any
3107 lgrTotaleRaw gives the 'Raw' length
3108 GetImageDataRaw returns the gray Plane
3109 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3110 (They stay Grey, just like with other Dicom viewers :-(
3112 2003-10-30 Jean-Pierre Roux
3113 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3115 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3116 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3117 being coherents dicom files.
3119 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3120 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3122 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3123 * ENH: Two steps is necessary to please VC++ compiler...
3124 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3125 * ENH: Add include dir to medcon lib
3126 * FIX: only one function is being exported for now !
3127 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3129 2003-10-29 Jean-Pierre Roux
3130 * adding gdcmHeader::GetLUTRGBA
3131 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3132 --> Mathieu, the modif u're waiting for is not yet committed
3133 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3135 2003-10-27 Jean-Pierre Roux
3136 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3137 00191113.dcm DermaColorLossLess.dcm
3138 MxTwinLossLess.dcm RadBWLossLess.dcm
3139 * ENH: For version prior to vtkImageViewer2 -r 1.19
3140 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3142 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3143 * Removal of ido stuff in CMakeLists.txt
3145 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3146 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3147 * FIX: remove a call to ->Modified ... see comments
3148 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3150 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3151 * FIX: Problem with path for libvtkgdcmPython
3152 * ENH: Try adding a search script for python site-package
3153 * RMV: Remove some file from medcon lib that are not necessary
3154 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3155 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3156 * FIX: More pragma disable fro VC++,
3157 I don't think I break something as it is also disable in VTK/ITK.
3158 But it fasten debug compilation time.
3160 2003-10-23 Jean-Pierre Roux
3161 * gdcm now deals with 16 Bits Run Length Encoded images
3162 (they are compressed as 2 planes images,
3163 one for the high Bytes, the other for low Bytes)
3165 2003-10-22 Jean-Pierre Roux
3166 * Now CheckRead takes into account :
3167 - the bugged 'Leonardo' Siemens images
3168 - the XA images, sent thru the burning VPRO station
3169 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3172 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3173 * FIX: When copying a Makefile.am to CMakeLists.txt
3174 one should remove the '\'
3176 2003-10-22 Jean-Pierre Roux
3177 * in gdcmData adding a bugged 'Leonardo' Siemens image
3178 (wrong lengths in header)
3179 OK with gdcm, KO with the other viewers :-)
3180 * add a GE dlx XA image, thru the VEPRO burning station
3183 2003-10-21 Jean-Pierre Roux
3184 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3185 for a brutal checking of vtkgdcmViewer compliance
3187 2003-10-21 Jean-Pierre Roux
3188 * add the files for 'xmedcon' Jpeg Lossless library
3189 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3191 2003-10-21 Jean-Pierre Roux
3192 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3194 2003-10-21 Jean-Pierre Roux
3195 * garbage Siemens 'Leonardo' images dealt with
3196 (the patch is easy to remove)
3197 * cosmetic changes to avoid warnings
3199 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3200 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3201 no need to press 'r' now.
3203 2003-10-20 Jean-Pierre Roux
3204 * upgrade of checkRead.sh checkWrite.sh according
3205 to new Jpeg Lossless decompressor
3206 * add US.3405.1.dcm, a genuine RGB medical file ...
3207 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3208 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3210 2003-10-15 Jean-Pierre Roux
3211 * general anonymisation in gdcmData
3212 * adding the 'color files' from
3213 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3214 * adding some well knowed bugged-header images
3215 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3216 waiting for their inclusion in Python testsuite
3218 2003-10-15 Jean-Pierre Roux
3219 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3220 no longer seg faults when file is not found
3222 2003-10-14 Jean-Pierre Roux
3223 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3226 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3227 * TODO: *.in file to genereate a UseGDCM later
3229 2003-10-14 Jean-Pierre Roux
3230 * Some supposed-to-be Dicom Images have no preamble.
3231 OpenFile takes it into account
3232 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3233 * Missing elements added in dicomV3.dic
3234 (just to be affraid : have a look at
3235 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3236 and do it again next year ;->
3238 2003-10-13 Jean-Pierre Roux
3239 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3240 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3241 But there are NOT. It's fixed !
3243 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3244 * FIX: "jpeglib.h" was not found on VC++
3245 * FIX: vtkgdcm was not being installed
3247 2003-10-10 Jean-Pierre Roux
3248 * ENH : OpenFile closes the file if it *really* doesn't look like
3249 an ACR-NEMA / DICOM one.
3250 * FIX : testWrite no longer writes an empty file if the source file
3251 is not gdcm Readable
3252 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3255 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3256 * FIX: CMake generate now documentation
3257 * ENH: out of source doc build !
3258 * ENH: Generate both user and dev documentation
3259 * ENH: Should work on windows too
3260 * ENH: Only one doxygen config.in file is needed
3261 * FIX: make install should be ok now on Unix plateform
3262 * FIX: PATH to dictionary was wrong (missing /)
3263 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3265 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3266 * vtkGdcmReader is now able to read rgb dicom file.
3267 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3268 * added a gdcmViewer to vtk test, use mouse to control
3269 window level & window width
3271 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3272 * CMake-ification of gdcm, we have now two build system
3273 * FIX: on cygwin Wsock32 doesn't exist
3274 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3276 2003-10-06 Emanuel Ollart
3277 * FIX : compilation process wad broken.
3278 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3280 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3281 * change gdcmViewer -> vtkgdcmViewer
3282 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3284 2003-10-06 Jean-Pierre Roux
3285 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3286 ( e.g : well known GE images with a wrong elem length,
3287 : Philips MRI Images with a wrong Huffman table)
3288 * still to be done : allow the reading of bugged LEONARDO Siemens images
3290 2003-10-03 Jean-Pierre Roux
3291 * Odd length strings are padded with '\0' (not with spaces,
3292 to remain compliant with already defined strings,
3293 like Transfert Syntax UID and others)
3295 2003-10-03 Jean-Pierre Roux
3296 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3297 to allow displaying RGB images (not only by affim ;-)
3299 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3300 * vtkGdcmReader is now able to read rgb dicom file.
3301 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3303 2003-10-03 Jean-Pierre Roux
3304 * A few nasty patches to allow the reading of a lot of nasty images
3305 ( e.g : well known GE images with a wrong elem length,
3306 : Philips MRI Images with a wrong Huffman table)
3307 * still to be done : allow the reading of bugged LEONARDO Siemens images
3309 2003-10-03 Jean-Pierre Roux
3310 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3312 2003-10-03 Jean-Pierre Roux
3313 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3314 to allow displaying RGB images (not only by affim ;-)
3316 2003-10-03 Jean-Pierre Roux
3317 * gdcmFile::GetImageDataIntoVector now
3318 - deals with MultiFrames MultiFragments Run Length Encoded files
3319 - deals with YcBcR (YBR_FULL) files
3320 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3321 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3323 (no sample found :-(
3325 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3326 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3327 Two reasons: - clear things
3328 - third parties acces gdcm through header files, so won't
3329 suffer anymore VC++ complains
3331 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3332 * add argv[1] in testvtkGdcmReader.cxx
3335 2003-09-24 Jean-Pierre Roux
3336 * The lines are now eigthy characters long for
3337 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3339 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3340 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3341 char* to std::string. Thus, the use of strdup becomes useless. (see
3342 previous commis of Malaterre)
3343 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3344 before the last Malaterre's commit.
3346 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3347 * This commit should fix the Debug building under VC++, the problem
3348 was mainly a mixture of debug and release lib being loaded at startup.
3349 * I also remove a depency to a specific C function: strdup. Because I had
3350 to force the link to msvcrtd (whereas strdup is in libc).
3352 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3353 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3354 located in the gdcmCommon.h file. All use of reference of tha has been
3355 changed to now use the variable GDCM_UNFOUND.
3357 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3359 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3360 Dicom dictionary. The test suite can now be run again. Note:
3361 I'm note very happy with the " (RET)" changes. I believe this
3362 RETAINED comment should be dropped when parsing the dictionary.
3363 - PACKAGER corrected
3365 - AUTHORS updated and now in alphabetical order
3366 * Makefile.am now exports gdcm.dsw for Windoze users.
3368 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3369 * cygwin complains about missing std:: in subdir Test/
3371 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3372 * remove some methods that are now in gdcmHeaderHelper
3374 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3375 * vtkGdcmReader set spacing and origin correctly
3377 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3378 * Fix a few delete/delete[] mismatch
3380 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3381 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3382 interpretation to data given by gdcmHeader. For instance there are
3383 heuristics to get informations (look at different places).
3384 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3385 sorting DICOM images based on different strategies.
3386 * modified Makefiles accordingly.
3388 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3389 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3390 when building in debug mode
3391 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3392 src/win32/gdcmdll.dsp
3393 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3395 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3396 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3399 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3400 * src/win32/libgdcmjpeg12.dsp was not dos format
3401 * src/win32/libgdcmjpeg12.dsp :
3402 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3403 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3405 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3406 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3408 * src/gdcmFile.cxx : bug fix in affectation type
3409 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3410 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3411 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3412 symbols... future problem ?
3414 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3415 * src/win32/libgdcmijpeg12.dsp was missing
3416 * modified gdcm.dsw accordingly
3418 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3419 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3421 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3422 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3423 commit of JPR (before his hollidays to facilitate our work).
3424 * setup.py : bug fix in code. Modifications made while the last commit
3425 of JPR. The code hasn't been tested before the commit... it's so
3426 useless to make that (for best programmer that is JPR) !!!
3428 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3429 * tagged the current version as Version0_3 (i.e. version 0.3)
3431 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3432 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3433 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3434 * *.dsp : modifications to use new libgdcmijpeg8 library
3435 * setup.py : bug fix on VTKPATH variable
3436 * PACKAGER : adding all concerning windows
3438 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3439 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3441 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3442 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3443 test suite reported error.
3444 * PACKAGER file added (describes what a packager must do when
3445 packaging a new release).
3446 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3447 * configure.in: upgraded version number to 0.3.0
3448 * fixing build of rpm (through rpm -ta):
3449 - Doc/Makefile.am exports proper doxygen files
3450 - src/jpeg/libijg8/Makefile.am exports the include files.
3452 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3453 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3454 * src/gdcmHeader.h : formatting code
3456 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3457 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3458 We were obtaining error message from vtk. Now, creation of file list
3459 is made in an internal list to prevent this problem.
3460 Bug fix when output is empty.
3461 Bug fix in update of progress value. Previous commit for this was a bad
3463 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3465 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3466 * src/gdcmHeader.h : added method to get the file name
3467 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3468 files. Added method to remove all files on the input
3469 Added FIXME comment concerning the bad parsing of header made by
3470 ExecuteInformation method (in ExecuteData method)
3472 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3473 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3474 when using make instal.
3475 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3476 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3478 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3479 * setup.py : adding include dir of jpeg lib to compile all sources
3480 * */Win32/*.dsp : JPR fix for windows compilation
3482 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3483 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3485 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3486 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3488 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3489 * setup.py is again effective on un*x (takes into account the
3490 addon of the jpeg library)
3491 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3492 * Doc/Doxy* updated (includes above enhancements)
3493 * INSTALL now points to web documentation
3495 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3496 * src/gdcmHeader.h doesn't make unnecessary reference to
3498 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3500 * src/gdcm*.[cxx|h] :
3501 - to allow compilation with gcc 3.x
3502 -- clean up of STL usage (added explicit usage of std::)
3503 -- small fixes on exceptions.
3504 Note: linking not tested !
3505 - clean of doxygen comments to avoid warnings at documentation
3507 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3508 dependent convertion).
3510 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3511 * Clean up of previous JPR garbage commit (not even commented in the
3513 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3514 - moved all jpeg related files from src to src/jpeg/libijg8, with
3515 addition/modification of Makefile.am and configure.in.
3516 - the testSuite is still brain damage (not guilty).
3518 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3519 * WrapVTK.py : modifications to get correctly vtk source files to
3521 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3522 (FileName -> Filename)
3524 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3525 * vtk/vtkGdcmReader.[cxx/h]:
3526 - UpdateProgress method should now be effective
3527 - removed the limitation on having only images loaded (as opposed
3529 - when building a stack of images/volume, a lesser number of
3530 gdcmHeader and gdcmFile instances should be used (hopefully
3531 accelerating things).
3532 - when building a stack of images/volumes, files which are not
3533 loadable (wrong path-filename, wrong permissions on existing file,
3534 or file not parsable by gdcm) are replaced with a black image
3535 in the stack (for the caller to notice the problem).
3537 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3538 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3540 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3541 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3542 between standard library (std) and vtk library (problems are found
3543 under Windows... thanks Windows !)
3545 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3546 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3548 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3550 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3551 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3553 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3554 * When compiling with distutils (see setup.py) the C++ compiler is
3555 called with different flags than the default ones (with automake).
3556 In order to fix all those warning, I compiled gdcm with the command
3557 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3558 and went for warning fixes:
3559 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3560 up from unused variables.
3561 - vtk/vtkGdcmReader.cxx: potential bug fix.
3562 * src/gdcmHeader.h: Doxygen warning cleanup
3564 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3565 * gdcmPython/gdcm.i:
3566 - typemaps correction to take into account the systematic replacement
3567 of "using namespace std" with std:: prefix e.g. std::list,
3568 std::string... (cf changes of 2003-05-21).
3569 - gdcmGlob global variable of type gdcmGlobal (defined in
3570 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3571 exported to Python a as cvar.
3572 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3573 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3574 gdcmDictSet.GetPubDictTagNames() and
3575 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3576 C++ static methods).
3577 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3578 with the above changes.
3580 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3581 * setup.py, manifest.in : bug fix under linux
3583 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3584 * Modification of setup.py to compile vtk part too. Then, we have 2
3585 wrappers which must work with same distutils. For that, we have a
3586 generic distutils in distusiltsWrapping.py ; with :
3587 - build_extWrap class to wrap generically all extensions,
3588 - ExtensionWrap base class for all wrapping extension that contains
3590 - Wrapper interface which wrap sources
3591 + In WrapSwig.py we have extension and wrapper for Swig
3592 + In WrapVTK.py we have extension and wrapper for VTK
3593 * MANIFEST.in : modifications to consider vtk directory and new python
3594 files for compilation
3596 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3597 * Added python wrappers of vtkGdcmReader vtk class (see the
3598 source in vtk/vtkGdcmReader.cxx) :
3599 - vtk/Makefile.am now builds a library
3600 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3601 python library (as opposed to _gdcm.so wich are the python
3602 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3603 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3605 - configure.in has an additional flag --enable-vtk that needs
3606 to be set to enable compilation of vtk related code, that is:
3607 + vtk/vtkGdcmReader.so and
3608 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3609 + gdcmPython/vtkgdcmPython.so (see above)
3610 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3611 be read when compressed or when HighBit + 1 != BitsStored),
3612 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3613 the usage of the python wrapper of vtkGdcmReader vtk class.
3614 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3615 * src/*.[h] all occurences of stl classes are now prefixed with
3616 std::, and all occurences of "using namespace std;" where removed.
3617 This is to avoid pollution of global namespace in included files.
3618 Apparently vtk does not avoid this pitfall: when using both
3619 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3620 collision of various stl members (principally cout...).
3621 * gdcmPython/testSuite.py now cleanly removes temprory generated
3623 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3624 comply with above changes)
3626 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3627 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3628 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3629 vtk data structure (an image Flip was required).
3630 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3631 * cosmetic changes in documentation.
3633 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3634 * src/gdcmHeader.cxx: the constructor no longer exits when an
3635 unexisting file is given as argument.
3636 * The subdirectory Data (containing all the images used for the
3637 test suite) is not part of this repository anymore. A new module
3638 containing those images is now available at
3639 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3640 with the name gdcmData.
3641 All the python scripts (including the package initialisation file
3642 gdcmPython/__init__.py) were adapated to take this change into
3643 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3645 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3646 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3647 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3648 demo of the usage of this class.
3649 Compilation of this vtk part is only done when using the --enable-vtk
3650 at configure (or autogen.sh) stage.
3652 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3653 * More memory link related corrections and documentation fixes.
3655 - maximum info is obtained with a command of the form:
3656 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3657 --show-reachable=yes PrintHeader
3658 - the remaining reachable blocks seem to come from the STL
3659 allocation scheme through the usage of map and list. It looks
3660 like this memory cannot be freed but it is not a memory leak
3661 (in fact further invocation to the STL would recollect the
3662 unused memory allthough it cannot explicitely be freed).
3663 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3664 of displaying an image parsed with gdcm and displayed with VTK.
3665 Note: some images don't seem to work e.g.
3666 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3667 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3668 Allthough this weakens the semantics, it is a ditch attempt to
3669 make gdcm more thread friendly.
3671 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3672 * Memory link hunt (by using valgrind through the command
3673 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3674 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3675 gdcmHeader::_dicom_vr.
3676 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3677 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3679 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3681 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3682 * src/Makefile.am now exports all the necessary include files at
3686 * UpdateGroupLength replaced by new one
3689 * UpdateGroupLength re-written using H-Table
3690 (named UpdateGroupLengthNew untill checks are over)
3692 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3693 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3694 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3696 - gdcmHeader::GetPubElValSet removed.
3697 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3698 UpdateGroupLength, WriteElements, Write.
3699 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3700 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3701 carried the same semantics.
3702 - src/gdcmHeaderIdo.cxx changed accordingly.
3703 - gdcmFile::WriteBase now regroups all the codes from previous
3704 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3705 - enum FileType moved to gdcmCommon.h
3706 * src/gdcmHeader.cxx AddDefault trashed
3707 * gdcmGetXSize added
3708 * getimageDataSize now calls gdcmGetXSize
3709 * Test/*.cxx changed to agree with above changes
3711 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3712 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3713 (to avoid double call by end user).
3714 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3715 by end user, since gdcmHeader::gdcmHeader now handles it.
3717 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3718 * gdcm/Doc many doxygen changes:
3719 - Doxyfile now has two different versions, DoxyfileUsers that generates
3720 the html.users end users oriented documentation and
3721 DoxyfileDeveloppers that generates the html.developper developper
3722 oriented documentation.
3723 - README changed accordingly
3724 - requirement.txt removed (old design info moved to TODO).
3725 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3726 DoxyMainPage.txt, DoxyPython.txt provide more information.
3727 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3728 be updated by simply regenerating the docs with doxygen and copying
3729 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3730 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3731 all the tests in the form "if (<map>.count() >1)" were removed.
3732 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3733 ill-formed documentation sections.
3734 * src/gdcmHeader.cxx: ditto
3736 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3737 * setup.py fixed for un*x (needed macro for stdint.h)
3738 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3739 un*ces with sh-utils test utility.
3740 * gdcmPython/demo/test.py renamed to PrintHeader.py
3741 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3742 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3743 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3744 * src/gdcm*.cxx JPR's bad inclusion fixed.
3746 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3747 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3748 * gdcmPython/demo/test.py changed accordingly.
3750 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3751 * gdcmPython/Makefile.am fixed linking against libstdc++
3752 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3753 * Swig subdir (historical tests of swig version 1.3.17++) removed
3754 * Test/testChangeEntete.cxx some lines commented out in order to make
3756 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3757 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3759 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3760 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3761 hence the user doesn't need this explicit call.
3762 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3763 i.e. LoadElements() call removed.
3764 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3765 - src/Makefile.am declares the proper flag for g++.
3766 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3767 for adding user defined new tags.
3768 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3769 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3770 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3772 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3773 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3774 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3775 src/Makefile.am : the project should properly compile and install
3776 with the autotools, included the python wrappers part.
3777 * gdcm.spec.in : added a spec file for RPM packaging.
3779 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3780 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3782 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3783 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3784 to exported to the environement (see gdcmPython/testSuite.py
3786 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3787 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3788 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3789 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3790 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3792 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3793 * gdcmPython/__init__.py doesn't crash anymore when running in
3794 in InstallMode or PreInstallMode but with an environment given
3795 value of GDCM_DICT_PATH.
3796 * src/gdcmDictSet.[cxx/h] coding style.
3798 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3799 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3800 * src/gdcm.h general comments moved to TODO, and README
3801 * src/gdcm.h should now be seen as a user commodity (including it
3802 should suffice to fully use gdcm). It is nowhere including within
3803 any of the kernel files src/*.cxx and src/*.h.
3805 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3806 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3807 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3809 * src/gdcm*.cxx only include their corresponding include file
3810 (as opposed to gdcm.h)
3811 * gdcmPython/gdcm.i changed accordingly
3812 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3813 the autogen.sh generated "make snapshot" command to work.
3814 * autogen.sh removed history related references to crea package.
3816 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3817 * distutilsSwigCPlusPlus.py work around some swig portability
3820 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3821 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3822 was done in a last ditch attempt to get setup.py _really_
3823 operationnal. The python/gdcmPython layaout add the advantage
3824 of hidding away the python related distutils specific files
3825 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3826 Alas, the src directory was out of scope (i.e. it's relative
3827 position to setup.py was ../src) which made things impossible to
3828 handle (see previous version of python/setup.py). Crossing fingers...
3830 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3831 * python/setup.py now works on Un*x. (harder than I thougth)
3832 * python/distutilsSwigCPlusPlus.py can now have include files
3833 among the list of sources.
3835 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3836 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3837 * modifications in MSVC projects
3839 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3840 * As stated by the first lines of Test/ExceptionAndPython/README, it
3841 looks like we can move back to original usage of exception within
3842 src/gdcm* and hence remove the errno stuff that was introduced
3843 as a quick and dirty fixture of this problem (added to the TODO).
3844 * Doc/Doxyfile configuration file for Doxygen and corresponding
3845 README file for usage added.
3846 * Test/testWrite.cxx added. This new test comes from a split of
3847 test.cxx that is now reverted to its original purpous i.e.
3848 testing the proper parsing of a Dicom related file.
3849 testWrite.cxx concentrates on testing the IO part of gdcm.
3850 * Test/bug1.cxx (containing a bug on WIn32) added.
3851 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3852 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3853 whose purpose is to publish the content of the TagNames of the
3854 Dicom public dictionary were not accessible without an
3855 instance of class gdcmHeader.
3856 - those methods are now static methods of gdcmDictSet and hence
3857 require no instances at all to be invocated.
3858 - within gdcmDictSet this change required to change some method
3859 to class methods (i.e. are now static) among which SetDictPath
3860 (renamed to BuildDictPath) and LoadDefaultPubDict.
3861 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3862 the above changes by calling the new method classes of gdcmDictSet.
3863 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3864 the above to be effective.
3865 * python/gdcmPython: in order to wrap properly the above changes
3866 for Python, swig version now needs to be > 1.3.17.
3867 * python/gdcmPython/Makefile fixed to adapt itself to new
3868 configure/make shema introduced by Johan Montagnat (thanks for the
3869 contribution). Alas this Makefile cannot be turned into a proper
3870 Makefile.am without some heavy changes in the configure.in
3871 (for python dectection).
3872 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3873 now avoids publishing the empty entries.
3875 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3876 * python/setup.py : bug fix concerning install under windows
3877 ExtraPath reused :-P
3878 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3880 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3881 * Dicts/dicomV3.dic : remove double spaces !!!
3882 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3883 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3886 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3887 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3888 method. Doxygenation.
3889 * src/gdcm.h clean up of JPR spurious comments.
3891 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3892 * python/distutilsSwigCPlusPlus.py now properly collects the
3893 shadow classes generated by "swig -c++" (gdcm.py in our case)
3894 when using "python setup.py install".
3895 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3896 reexports the working classes.
3897 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3898 by the classical C errno scheme. This is to prevent an obscure
3899 behavior of the python wrappers when importing wxPython.wx prior
3900 to gdcmPython (which ended up in an abort call). An illustration
3901 of this oddity can be found in the Test/ExceptionAndPython
3902 subdir (see the README file). This problem probably due to
3903 an combination of g++ and dynamic loading.
3904 * added Test/ExceptionAndPython (see above)
3906 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3907 * Changed the layout of the python part to avoid bloating main
3908 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3909 i.e. the distutils arsenal. All the python related stuff is
3910 again in a python subdir, but the package itself is now in
3912 * setup.py was cleaned up:
3913 - pythonIncludePath removed
3914 - python setup.py bdist target is now functional.
3915 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3916 collision with other packages). gdcmPython/demo/*.py changed
3919 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3920 * python subdir moved to gdcmPython (preparation of distutils packaging).
3921 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3922 distutils installer is operational.
3923 * - gdcmPython/__init__.py now properly loads the swig generated
3924 shadow classes (from gdcm.py).
3925 - gdcmPython/demo/*.py changed to import the package gdcmPython
3926 instead of gdcmPython/demo/load.py.
3927 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3929 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3930 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3931 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3932 entries within the associated public Dicom dictionary resp. the same
3933 information but sorted by the fourth field (PAT, IMG, DIR) of the
3935 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3936 are now in the "???" group.
3937 - python/gdcm.i changed accordingly,
3938 - python/demo/printGroupedPublicDict.py added, that gives an example
3939 of the above new functionalities in Python.
3941 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3942 * src/gdcm.h, gdcmHeader.cxx:
3943 - historic references to glib's g_malloc and g_free (#defined)
3944 were definitively removed.
3945 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3946 * src/gdcmElValSet.cxx:
3947 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3948 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3949 - GetElValue(string) renamed to GetElValueByName.
3950 - Added GetElementByName(string).
3951 * src/gdcmHeader.cxx: added
3952 - GetPubElValRepByNumber(guint16, guint16)
3953 - GetPubElValRepByName(string)
3954 - GetShaElValRepByNumber(guint16, guint16)
3955 - GetShaElValRepByName(string)
3956 - GetShaElValByNumber(guint16, guint16)
3957 - GetShaElValRepByName(string)
3958 - GetElValRepByNumber(guint16, guint16)
3959 - GetElValRepByName(string)
3960 - GetElValByNumber(guint16, guint16)
3961 - GetElValRepByName(string)
3962 * Doc/requirements.txt added.
3964 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3965 * Test/Makefile building now depends on the one of libgdcm.so
3966 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3967 pixel data) aware which enables finding the address (offset) of
3968 the pixel data of JPEG encoded DICOM files. This leaves only a single
3969 file in the testSuite whose pixel data address (offset) is unknown.
3970 * python/testSuite.py changed accordingly.
3972 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3973 * VC++ has some strong limitations when working with the STL, as stated
3974 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3975 "Also note that some STL containers (map, set, queue, list, deque)
3976 cannot be exported. [...]
3977 Some STL classes contain nested classes. These classes can not
3979 This is caused by a designed limitation that once a template
3980 class is instantiated, it can not be re-instantiated and
3982 Since our usage of map<> is ubiquitous in gdcm, this "designed
3983 limitation" of VC++ is a pitfall.
3984 Hence the Python wrappers of gdcm cannot be incrementally linked
3985 against the c++ dynamic library. The dirty but only workaround is
3986 to forget about incremental link of dynamic libraries and to generate
3987 the Python wrappers library with the inclusions of the underlying C++
3989 The following modifications concern this matter on Win32/VC++:
3990 - wrapping python correct with standalone wrapped dll (don't use separate
3991 dll under windows !!!!)
3992 - python21_d debug mode enabled (ask Frog how to use it :-)
3993 - NO problem with having an STL member of class for example string in C++
3994 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3995 - Python test of dcmlib in Python is ok under windows on a large set
3997 * removed glib references
3998 * typedef's inserted in gdcm.i for correct swig type management
4000 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4001 * python/demo/*.py load.py extracted from test.py. Added explore.py
4002 that only displays required tags and testAll.py that parses all
4003 the files of the testsuite without using unittest.
4004 * python/testSuite.py other additional test on new files added.
4005 * Data/* new test files added accordingly to the testSuite.
4006 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
4007 the vr in the file differs from the one of the dictionary.
4009 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4010 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
4011 values, but limits itself to values which are below a user specified
4012 size (by default 1024 bytes).
4013 * python/gdcm.i : elements not loaded (because their size is above the
4014 user specified treshold) are exported with their TagKey as key of the
4015 python dictionary. This enables the testsuite to make some checks
4016 on the unloaded elements (since we have their offset and size).
4017 * python/testSuite.py
4018 - now tests for the existence and proper value of the pixel data
4019 - two new examples added.
4020 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4022 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4023 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4024 aware. See the strategy comments in gdcmHeader::FindLength().
4025 * Test/test.cxx now accepts a filename as first argument.
4026 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4027 * python/testSuite.py changed to integrate test on above files.
4029 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4030 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4031 the vr was also RET.
4032 * python/testSuite.py more tests added.
4034 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4035 * python/testSuite.py unittest test suite added (uses Data)
4036 * Data/* dcm and acr files for the test suite.
4037 * glib dependance removed from un*x version. We now use ISO C99
4038 7.18 Integer types (see stdint.h)
4039 - python/Makefile, src/Makefile src/gdcm.h
4040 * src/ when an explicit vr (like dicom files) suddenly poped an
4041 implicit element we use to mark the underlying DictEntry of the
4042 concerned ElValue with "Implicit". This strategy was damageable
4043 too the public or provite dictionaries, since some of their vr
4044 would be changed. Since Header::FindLength heavily relies on the
4045 detection by Header::FindVR of falsely explicit elements, I
4046 added an extra ImplicitVr member to ElValue (boolean).
4047 The rest of the changes we the necessary adaptations.
4049 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4050 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4052 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4054 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4055 * Adaptation for porting to VC++:
4057 o forced to use std namespace (for string to be known)
4058 o all class use __declspec export style on WIN32
4059 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4060 (in stdlib.h on Win32 but in std:: for gcc)
4061 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4062 variable GDCM_DICT_PATH.
4063 * src/gdcmHeader.cxx verbose comments made discrete.
4065 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4066 * python/gdcm.i: added a typemap that converts a C++ hashing table
4067 to native Python dictionary.
4068 * python/demo/test.py:
4069 - now uses the native dictionary for exploration of gdcmHeader.
4070 - takes an optional filename argument (the file to parse).
4071 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4072 PubElVals hashing table.
4073 * Dicts/dicomV3.dic removed error prone trailing spaces.
4075 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4076 * Python wrapping process moved away from src/Makefile to
4077 newly created python/Makefile (as well as gdcm.i)
4078 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4079 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4080 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4081 from the environement variable GDCM_DICT_PATH (when existing).
4082 * src/gdcmDict::GetTag bug fix.
4084 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4085 * Straightforward temporary fixes for swig to build the python wrappers.
4086 src/Makefile now has a python working entry [by working we mean
4087 that we can import the shadow classes without errors].
4089 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4090 * hashtest.cxx removed (since already in Test)
4091 * src/gdcmlib.h renamed to src/gdcm.h
4092 * src/dcm.i renamed to src/gdcm.i
4093 * src/Makefile prepared for python wrapping
4095 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4096 * src/gdcmHeader.cxx :
4097 - Parsing of header is now separated from loading of element values
4098 (see gdcmHeader::LoadElements).
4099 - general clean up of hopefully all file access (creation of
4100 ReadInt16 and ReadInt32)
4102 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4103 * src/gdcmHeader.cxx :
4104 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4106 - SetLgrElem renamed to SetLength
4107 - GetLgrElem renamed to GetLength
4108 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4109 * src/gdcmElValSet.cxx fixed both GetElValue methods
4110 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4111 due to IdoDude was cleaned out.
4113 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4114 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4115 concentrates on finding the value representation (when it exists).
4116 RecupLgr now only finds the element value length, and it avoids
4117 returning the unecessary skL (skipped length).
4118 Also, offsetCourant was simply removed (with taille_fich) since
4119 it was redundant with the File position internals (by using
4120 ftell and fseek). This also made skL (see above in RecupLgr) usage
4122 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4123 on the libido specificities which are handled through class
4125 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4128 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4129 * Truckload of changes. Parsing of header is barely functional
4130 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4132 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4133 * src/gdcmHeader.cxx many addons of low level methods
4135 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4136 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4137 and _IdDcmSWAP_LONG.
4139 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4140 * This corresponds to all the changes decided at the meeting of
4141 May 23 2002. Needless to say we are running late...