1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
3 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
5 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
8 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
10 Remove all access to the hash-tables or lists in the objects.
12 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
14 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
15 be complient with all the gdcm source code
17 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
21 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
25 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Test/ : rename VTK tests to have a best name for the tests
27 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
28 GetFirstEntry/GetNextEntry use
30 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
32 test. Now it's on image content and not on the resulting visualisation...
33 might solve the problem on linux when using the OpenGL drivers
35 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
36 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
37 DicomDirSerie, DicomDirImage
38 Dict, DictSet classes :
39 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
40 -remove InitTraversal method.
41 * UPD Test programs + Example programs
43 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
44 remove useless and never updated keyword \ingroup
46 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
48 is no memory access violation
49 * gdcmPython/demo : add python demos using VTK
51 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
52 * FIX 'Dictionnary' is now spelt 'Dictionary'
53 'wether' is now spelt 'whether'
54 'archieve' is now spelt 'archive' ;-)
56 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
57 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
58 related methods, in order not to expose internal mechanisms
61 * REM methods that exposed internal mechanisms :
62 DicomDir::GetDicomDirPatients()
63 DicomDirPatient::GetDicomDirStudies()
64 DicomDirStudy::GetDicomDirSeries()
65 DicomDirSerie::GetDicomDirImages()
76 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
77 * Removed the Print/indent/default parameter mess. There is absolutely no
78 reason to have to methods, moreover with the second taking the ostream as
79 *SECOND* parameter. This was clearly a bad hack to get things compile.
81 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Complete rewrite of the GetMacAddress code. Now the code is *much*
83 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
84 Unfortunately the main code does not work on SunOS, thus provide a specific
85 code for this platform only (and Win32 of course). Since this seems to be
86 working, change CreateUniqueUID to use GetMACAddress instead of the
87 problematic GctestetIPAddress
89 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * Unfortunately to be able to test gdcmDirList I had to break the API
91 a little. Now the class is not a std::list anymore but has a member
92 std::vector (more ITK compatible). Allow unit testing on Win32 and
95 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Update SerieHeader to take into account a Serie Instance UID to properly
99 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
100 * ENH - Comment out Mathieu's (dangerous) Super Hack
101 for dealing with BIGENDIAN processors
102 - Move equivalent stuff to BinEntry::WriteContent
103 When necessary, 16 Bits Pixels are swapped in a small buffer
104 and then written. This avoid allocating a huge buffer, in
105 PixelWriteConvertor, and avoid modifying the Pixel Area.
107 Probabely, the same operation will have to be done when we want
108 to write image with Big Endian Transfert Syntax,
109 and we are working on Little Endian Processor
111 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
114 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
115 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
116 all the dict content.
117 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
119 * Test/TestDict.cxx : add a new test for the dict classes
121 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
123 file. Debug is yanked if compiled with NDEBUG
125 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmDictSet.h : set the default output to the os variable
127 * src/gdcmDictEntry.[h|cxx] : add the Print method
128 * gdcmPython/demo/ : add a new test
130 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
131 * merging of Test/PrintDicomDir and Test/TestDicomDir
132 * removal of now redundant Test/PrintDicomDir
133 * enhancement of Example/PrintDicomDir
135 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * Now, python test might work on systems
137 * Add the PrintDicomDir test
139 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
140 * FIX : First entry following group 0002 was lost for
141 Explicit Big Endian Transfer Syntax files
142 (group and elem not swaped)
144 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
145 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
146 Big Endian Transfer Syntax supposed the group following 0002
147 begins always by element 0000 (element 0000 is *optional*)
148 To avoid further troubles, let's be pessimistic, and use
149 Document::HandleOutOfGroup0002() method
150 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
151 (related pb not yet solved)
153 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * Bug fix for the python part use
155 * Now, PrintHeader.py pass... but outside the ctest use. shit !
157 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
160 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
162 a string and should ask the global TS dict what are the propreties of
165 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
166 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
167 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
168 to swap the Swap Code, at parsing time, when we come out of group 0002
169 and Transfer Syntax is Big Endian
170 We should be able to read now 'true DICOM" Big Endian coded images
171 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
172 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
174 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
175 * Hopefully fix the bug on MacOSX and static global initialization.
176 This is the only -minor- patch I found that both please MacOSX and VS6.
177 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
178 but this would require a lot of change. Another approach would be that Global
179 create those string and GDCM_UNFOUND becomes a pointer to a string (which
180 gdcm::Global would destroy at exit).
182 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Fix bug on MacOSX with static initialization in a multy threaded
184 environment. static const string in a header file used to be ill
185 initialized provoquing the freeze of any tests. patch should solve this
188 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
189 * According to Benoit's suggestion, and without any objection from anybody
190 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
191 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
192 - method gdcmDicomDirObject::GetEntry() renamed as
193 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
195 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
196 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
197 you debug/warning message just as c++ streams which make them very convinient
198 to use. Once this is stabilize I will change the ostringstrem to be
199 redirected to a file (ofstream).
200 * Properly support C99 extension: __FUNCTION__ which allow us to display
201 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
203 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * Removal of useless and dangerous methods :
205 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
206 GetDocEntryByName, GetEntryByName, GetDictEntryByName
207 * Removal of usless methods :
208 Dict::PrintByName, Dict::GetDictEntryByName
209 * Commenting out of probabely useless methods :
210 Dict::GetDictEntryNames()
211 Dict::GetDictEntryNamesByCategory()
212 DictSet::GetPubDictEntryNames()
213 DictSet::GetPubDictEntryNamesByCategory()
214 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
215 * ENH : Use dicomTS.dic as described in 2004 version
216 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
217 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
218 Add Accessors on VM (Value Multiplicity), and VM related methods
219 * ADD : Add a list of 'Dicom Attribute types', as found in
220 http://medical.nema.org/dicom/2004/04_15PU.PDF
222 * ADD : Add dicomGroupNameAbbreviations.dic
223 should be used to write a method to replace the former
224 Dict::GetDictEntryNamesByCategory()
226 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
228 to read in the file... and only it ! Length is the efective length of the
229 data in the DocEntry structure
231 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
233 And now use a static function call instead, with a global variable. i
234 This is much closer to the VTK approach. Hopefully should be bulletproof
235 and easier to use...hopefully
237 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
238 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
240 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
243 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
245 ValEntry, BinEntry, SeqEntry creation or replace
247 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
249 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
251 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
252 when specifying the VR
253 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
254 * src/gdcmDocEntry.cxx : amelioration of print
256 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
257 * ADD : Add the method Util::IsCurrentProcessorBigEndian
258 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
259 * ADD Method Document::ComputeGroupLength
260 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
261 in order to allow further VR modification by user
262 * REM : removal of once-called method File::WriteBase
263 integration of its code in formerly one-line method File::Write
265 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
267 replace the different values "??", "Unkn", "Unknown".
268 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
269 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
270 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
271 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
273 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
276 * Set the gdcm::Base class to some Printable classes
278 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmFile.[h|cxx] : add the Print method
280 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
281 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
282 * src/gdcmDocument.h : remove the PrintLevel informations
283 * Example/PrintFile.cxx : use the new gdcm::File::Print
285 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
287 problems when compiling with the python wrapping
289 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
291 writting in ImplicitVR
293 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
294 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
295 JPEG decompression, especially when dicom frames are split into several
296 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
297 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
299 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmHeader.cxx : change the initialisation of default header.
301 Now, this header is readable by gdm, e-film, DicomWorks
303 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
305 Rename Decompressed to Raw
306 * Use the API changes in gdcm::File.
307 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
310 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
312 each added entry in the header. Replace the 'Planes' field by the 'Number
315 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
317 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
319 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
321 At this time, this image isn't readable by e-film... waiting JPR help to
324 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
326 DocEntry. Now use methods of the Document !
328 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * Test/ShowDicomSeq.cxx : bug fix
331 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
333 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
334 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
335 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
337 * Test/TestCopyRescaleDicom.cxx : remove unused variable
338 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
339 containing found sequences
341 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
344 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
345 Some fields in BinEntry must be copied to not seg fault when making the :
346 gdcm::File *copy = new gdcm::File( copyH );
347 and tests are now made on good variables
349 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
351 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
353 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
354 * Add vtkGdcmWriter example and test
356 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * Test/TestUtil.cxx : reformat the source code
358 * vtk/vtkGdcmReader.cxx : remove and change prints
359 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
361 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
362 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
364 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
366 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
368 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
370 by an eof to prevent all bad read of the file... and in this case, the
373 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * Example/Volume2Dicom.cxx : comment unused variables
375 * Test/PrintDicomDir.cxx : comment unused variables
376 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
377 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
378 method that is redondant with AddEntry.
379 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
382 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * Bug fix due my last commit (compilation under Windows).
384 * Example/Volume2Dicom : bug fix in the file and reformatting source code
385 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
387 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 - Remove printf / sprintf
390 - include iostream AFTER gdcm so we don't get warnings
391 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
393 - Also remove tons of include from header files, hopefully this should
394 speeup the compilation time, since it was becoming a dog slow.
395 - Remove gdcm.h as it include way too many files and slow down compilation
396 (plus it is not up to date)
397 - remove 'using namespace std' this is BAD !
399 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * Remove memory leaks on the DicomDir
401 * Remove some useless data in DicomDirObject
402 * Add usefull methods in SQItem, to be complient withe the ElementSet
404 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
407 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
409 future, with convertion)
410 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
411 and ImageDataSize values. Remove the method to get the PixelReadConverter
412 from the output of the class
414 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
417 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
419 and vtkErrorMacro use.
420 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
422 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
425 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
426 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
427 The string leaves only in the fonction. So when we make a .c_str(), we
428 get the pointeur on the first element, element that will be destroyed
429 immediately after thee instruction.
430 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
431 file has been opened : the test must be made on the content of the
432 pointer and not directly on the pointer !
435 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
437 the python part recompiles
439 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
441 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
442 X session is killed (for my computer... it seems to not be identic on
445 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
447 avoid problems (otherwise, the difference test between the visible image
448 and the reference is incorrect. If the reference is greater than the
449 screen resolution, it's produce errors).
450 Can be used for only one image. Can be used with a visible flag.
451 * vtk/vtkGdcmReader.cxx : remove commented codes.
452 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
453 under windows at compilation
454 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
456 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
458 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
460 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
461 tests on the image size X, Y, Z
463 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
465 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
466 between the class name and the file name
468 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/ : fix compilation warnings for the Write method (2 different
470 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
471 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
472 variable... create a static method in gdcm::Document to access to
473 this variable content.
475 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
477 file, to be accessed by other files (like gdcmFile). Remove commented
478 code. Move the change of the header to the gdcmFile, using the
480 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
481 To be sure of that (and simplify calls), the Write of the header now
482 gets a file name and not a file pointer (std::ifstream).
483 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
484 DocEntryArchive. Remove all open of the written file
486 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
489 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
491 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
493 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
494 some corresponding methods. Write correctly the file and check before
496 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
497 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
498 is now on RGB data (as before my last commit
499 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
501 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
503 Add a print information of the type of the entry
504 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
505 It was in the gdcmFile, and all write have been regrouped
506 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
507 Write correctly all dicom files (in decompressed mode only at this time)
508 * Test/ : test on files are now made using Raw data and not color data if
510 * Example/PrintFile.cxx : add more printings
512 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * Amelioration of code, remove some code copy. For the loading of
514 BinEntry (in gdcmDocument), add the test to verify if the file is already
517 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
519 remove a DocEntry in the header (push an empty DocEntry)
520 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
521 lines. Bug fix in the initialization of the PixelConvert and the
523 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
524 use in TestCopyDicom (now this test can run under windows... but fails)
525 * Test/TestCopyDicom.cxx : amelioration of the test :
526 - test the pixels written
527 - add test points to quickly find where is the error
528 - can set a file name input and output in arguments
529 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
530 amelioration of the test output
532 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
534 all replaced DocEntry's
535 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
536 Now, each needed DocEntry to modify is duplicated, modified and inserted
537 to the header using DocEntryArchive. Thus, after save, we can restore the
538 header initial state.
540 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
543 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
545 correct to copy it. The DictEntry is specified at the DocEntry creation,
546 then, it musn't change in the time.
547 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
548 header correctly. At this time, the change is only made for the first
549 level of the Document. In the future, it might consider sequences.
550 The change is made by replacing a DocEntry by an other that is created
551 outside the class. The old value is kept. When we restore the header
552 status, the added DocEntry is deleted and replaced by the old value.
553 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
554 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
555 set the write type to explicit VR, implicit VR or ACR. Add methods to set
556 the write mode to native, decompressed or RGB (but not used at this time)
558 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
560 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
562 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
564 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
566 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
567 set because already copied when copying the BinEntry's of the header
568 * Test/TestAllReadCompareDicom.cxx : remove warnings
570 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
572 Two problems appear when doing it :
573 - with the gdcmFile : when the GetImageData method is called, the pixels
574 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
575 data (pixels). And each structure destruct the data when it's
576 destructed. So we have two destructions for the same data. To solve it,
577 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
578 data or not. If it doesn't own data, then they will not destroyed by
580 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
581 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
582 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
583 create a double destruction of the same DocEntry's. So, to solve it,
584 the TagHT is simply cleared and the DicomDir* elements are destroyed.
585 * TODO : add an entry concerning memory leaks in the DicomDir
587 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
589 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
592 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
594 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
595 after it have been deleted
597 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * FIX: src/* fix the doxygen warnings.
599 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
600 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
601 was erroneously defined with a size of 15 instead of 16. [many thanks
602 to Jean Michel Rouet for pointing out this bug].
604 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 1. Finish merging JMR patch for writting DICOM from scratch
606 2. Fix -hopefully- bug with MONOCHROME and space vs null character
607 3. Use const ref when possible
608 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
609 5. A few more comments
610 6. CreateUniqueUID can now be called without parameter"
612 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
613 * ENH: Slightly bigger patch:
614 1. Getting toward full integration of JMR patch for writting dicom from scratch
615 2. Update Test to test part of this patch: CreateUniqueUID
616 3. File was not close properly in gdcmDict
617 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
618 5. Use of const ref instead of copy (speed issue)
619 6. Remove temporary (duplicate) string in TranslateToKey
620 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
621 8. Do not repeat virtual in subclasses
622 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
624 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 * Apply first patch toward better string comparison when dealing with broken
626 DICOM files. Essentially the string could be padded with a space instead
627 of a null character as defined by standard
629 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
630 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
631 because never used... and in the same time, that's remove some memory leaks
633 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmFile.cxx : now delete the PixelConvert instance.
635 * In examples and tests : change the type of image data variables from void*
636 to uint8_t*. Remmove all delete on image data variables
638 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
640 Verify the file pointer value before open the file, and if it's not null,
641 a verbose message is generated.
642 Close correctly the file when the file isn't considered dicom-like. The
643 correctly close is a call to CloseFile.
644 When closing the file pointer, test if its not null to close the file.
645 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
646 file. For an uncompressed image, the copied data correspond in the least
647 case to the image size (calculated) or the image size specified in the
648 header. A verbose is generated if these two size mismatch
650 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
652 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
653 break under windows (with msvc6 compilation).
655 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
657 compiling with MSVC6)
659 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * Bugs fix for the Windows build with VC6
661 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
662 needed (only for projects required VTK). If the VTK is included in all
663 projects, there is conflicts with the jpeg lib of vtk when compiling the
664 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
665 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
666 when compiling the gdcm_wrap.cxx file (created by the compilation of the
668 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
669 (like it's already made for the cout use). Otherwise, conflict with the
672 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
675 - comments on the DicomDir::Method related usage added.
676 - now that we use the namespace gdcm, a lot of internal classes do
677 NOT need to be wrapped anymore.
678 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
679 DicomDir::Method) new example added.
681 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * Improve string manipulation. I now inforce the notion of 'DicomString'
683 A DicomString can contain as many \0 as they want
684 and it is *always* of even length.
685 We only support odd length for very rare case.
686 And in the near future this should be removed.
688 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
689 * /binary_write/ gdcm source. Now even on big endian we are writting
690 little endian. This should -heopfully- fix some tests
692 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
693 * Now the dictionary is compiled into gdcm lib. This is a default
694 behavior, thus any dic file specified is picked before failback to
695 the one comiled into lib
697 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
698 * Change internals for gdcmDict. Don't use any 'new' any more.
699 This should definitely solve any leak problem, and we should be
700 as fast as before, as long as don't modify too much the dictionary.
702 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
703 * STYLE: ivars should start with a capital letter.
704 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
705 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
707 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
708 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
709 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
710 new 2004 dictionaries added (thanks to JPR).
711 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
712 * CLEANUP_ROUND (15) for gdcmPixelConvert
713 - RLEFrame::NumberFragments is now of type unsigned int
714 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
715 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
718 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
719 * Initial work in gathering all transfer syntax accessors. clearly
720 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
721 ivars, but only one transfersyntax (class) ivar with equivalent method on
724 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
725 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
726 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
727 discussed (plus I didn't like having a 2000 lines patch not commited)
729 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
731 * CLEANUP_ROUND (14) for gdcmPixelConvert
732 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
733 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
734 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
736 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
737 anymore and hence avoids storing a copy of PixelConvert::Decompressed
738 into File::Pixel_Data.
740 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
742 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
743 * CLEANUP_ROUND (13) for gdcmPixelConvert
744 Substituted File::ParsePixelData() with PixelConvert::Print() new
746 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
747 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
748 method to those classes.
749 - src/gdcmFile.[cxx|h]:
750 -- Added a ::Print() method.
751 -- PixelConverter is now a reference instead of a member.
752 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
753 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
755 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
757 collaboration diagram and inheritance diagram should be generated with
759 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
760 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
761 pointlessly wrapped (see
762 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
763 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
764 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
765 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
766 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
767 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
768 -- File::Initialise: PixelConverter setup moved away to
769 PixelConverter::GrabInformationsFromHeader()
770 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
771 interpretation moved away to PixelConverter::BuildRGBImage()
773 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
774 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
775 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
777 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
779 displayed on Win32 when a brutal abort() occurs (because of uncatched
780 exception). See TODO new entry of this commit for more on this.
781 * TODO added new entry.
782 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
783 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
784 - HandleColor is no longer called from gdcmFile.cxx
785 - gdcmPixelConvert.cxx clean up on method arguments and internal
786 variable names for semantical coherence.
788 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
789 * Finished lossless transition, not only do we now read all lossless jpeg
790 images, without the need of the Cornwell lib, but we do read them properly now
791 * To reduce code (well to avoid code duplication), I defined a common place
792 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
793 redefine symbols. This is not perfect but this the best solution I found for a
794 compilation time jpeg option.
796 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
797 * Update jpeg ijg lib to support lossless jpeg implementation
798 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
800 * Also added a special copyright for dcmtk since we use their bugfixes.
803 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
805 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
806 matters, as stated in warning note at begining of %include section).
807 * src/gdcmDicomDir*.[cxx|h]: coding style
808 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
809 * src/gdcmJpeg8.cxx: doxygen fix.
810 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
811 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
812 from File:: to PixelConvert::.
814 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
816 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
817 - more code moved away from File:: to PixelConvert::
818 - fat setup of PixelConverter set in place in File::Initialise.
820 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
821 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
822 namespace at the file system level. So now you should convert your examples
824 gdcmHeader -> gdcm::Header
825 It would be nice if people keep in mind to no open the namespace, since it
826 allows compilation on broken plateform which were defining common symbol in
827 the standart namespace (like LP, Unknown ...)
829 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
831 The JPEG fragments are now parsed at the same stage than the RLE
832 information. All code related to JPEG is now in gdcmPixelConvert:
833 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
834 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
835 export a gdcmFile:: method. Those are simply global functions
836 (for the time being this is better than having them attach to
837 either gdcmFile:: or gdcmPixelConvert::).
838 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
839 and stores the result in a gdcmJPEGFragmentsInfo.
840 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
841 code (among other stuff) moved away from gdcmFile:; to
844 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
846 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
847 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
848 clean up of RLE related code.
849 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
850 - src/gdcmRLE.cxx removed
851 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
852 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
853 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
854 * CLEANUP_ROUND (9) for gdcmPixelConvert
855 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
856 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
857 away from gdcmFile:: to gdcmPixelConvert::.
859 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
861 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
862 This is because Parse7Fe0 used to parse the pixels to compute the
863 length. This task was passed over to FindDocEntryLengthOB() a long
864 time ago, EXCEPT I had forgotten the OW case...
865 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
866 we just recylce the code for parsing RLE fragments and computing
868 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
869 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
870 with the retired Parse7Fe0().
871 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
872 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
874 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
876 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
877 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
878 - src/CMakeLists.txt: alphabetic order reodering + new entries.
879 * CLEANUP_ROUND (4) for gdcmPixelConvert
880 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
881 to return an unused length.
883 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
884 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
885 this should be cleanner from the plane view. The iostream are erally a pain
886 to use to do simple stuff.
888 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * Redo the compilation of the ijg jpeg library. Now only one source is
890 necesseray. No need to rename file by hand what so ever. CMake handle the
891 copying of the file within different directory, configure header file to
892 modify some symbol. The only addition made to ijg wasd a mangle table so
893 that symbol are different whether we are within 8bits or 12bits.
895 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * Added documentation of vtkgdcmReader on Website:
897 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
898 with it's binary name).
899 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
900 the Website to be more complete.
901 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
902 doxygenated documentation.
903 - Doc/DoxyVtkGdcmReaderExamples.txt added
904 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
905 DoxyVtkGdmReaderExamples.html )
906 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
907 * CLEANUP_ROUND (3) for gdcmPixelConvert
908 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
910 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * CLEANUP_ROUND (2) for gdcmPixelConvert
912 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
914 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * CLEANUP_ROUND for gdcmPixelConvert:
916 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
917 - src/gdcmPixelStuff[h|cxx] removed
918 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
919 - src/CMakeLists.txt changed accordingly
921 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
922 gdcmVersion.py moved to newly created ATTIC related
923 gdcmPython/SetupOldies/ directory.
924 * Autotools clean up:
925 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
926 - autogen.sh configure.in acinclude.m4 python.m4 removed
928 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * src/*.cxx *.h Reference to License.htm fixed to License.html.
930 * Doc/CMakeLists.txt, doxygen.config.in: fix.
931 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
933 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * TODO updated with Mathieu suggestions. I proposed a template for
935 describing TODO entries and used it for new entries.
936 * Added Doc/Website/CodingStyle.html, Developpers.html,
937 DeveloppersPython.html, GdcmDataCvs.html and
938 DownloadVersion0_1.html, DownloadVersion0_3.html.
939 * Some Doc/*.txt Doxygen files (which do not really concern the
940 documentation itself, but the website) moved to html and
941 placed in directory Doc/Website:
942 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
943 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
944 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
945 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
946 * CMakeLists.txt changed accordingly.
947 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
948 DeveloppersPython.html
949 * INSTALL nows refers to Doc/Website/Installation.html
951 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * Added Doc/Website directory, that contains a first raw version
955 2004-09-23 Jean-Pierre Roux
956 * FIX In order not to be poluted any longer by casting problems,
957 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
958 we can now delete[] it safely
959 * VoidArea is now called BinArea (less confusing name),
960 and all the methods called ...VoidArea... are now ... BinArea...
961 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
963 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
965 clear) TagHT, which is an inherited member of gdcmElementSet. It is
966 up to the destructor of gdcmElementSet to clean up TagHt and it's
969 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * Test/CMakeLists.txt: update to follow gdcmData renamings.
971 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
973 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * ENH: added some utility method that builds a flat dictionary
975 holding all the Dicom entries contained in the recursive structure
976 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
978 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
979 BuildFlatHashTable() that build a flat dictionary.
980 - src/gdcmElementSet.h: added a new private GetTag() accessor.
981 gdcmDocument is now a friend of gdcmElementSet.
982 - src/gdcmElementSet.cxx: clean up.
983 - Example/FlatHashTablePrint.cxx added.
984 - Example/CmakeLists.txt changed accordingly
986 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
988 moved away from gdcmDocEntrySet (since this class is an abstract class
989 acting like an interface). SQDepthLevel and BaseTagKey are now
991 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
992 and associated accessors. Doxygenation of the class.
993 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
995 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
996 Use SQDepthLevel accessor instead. ::Print() adapted.
997 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
998 - src/gdcmDocument.cxx changed accordingly.
1000 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1001 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1002 - The following is the doxygen comment of the typedef declaration
1003 of gdcmTagKey in src/gdcmCommon.h:
1004 gdcmTagKey is made to old an "universal" (as in URL, Universal
1005 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1006 A dicom tag always has a group and an element, but a set of tags
1007 embeded in various (optionally nested) sequences and sharing
1008 the same group and element all share the same (group, element)
1009 "identifier". Hence the (group, element) cannot be used as an
1010 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1011 In order to construct a proper tag identifier (i.e. a key) we
1012 consider the following definition of a TagKey:
1013 - let Group, Element be the string representation of the
1014 group and element dicom tag members,
1015 - let ItemNumber be the string representation of the integer
1016 index of the considered item number of a sequence,
1017 Let the key of a tag embeded in a sequence, noted SeqTag, be
1019 /ItemNumber#Group|Element
1020 where "/", "#" and "|" are characters acting as separators.
1021 Then the general form of a gdcmTagKey is given by:
1022 Group|Element<SeqTag>
1023 where <SeqTag> means NO or many instances of SeqTag.
1024 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1027 but the gdcmTagKey of a tag "embeded" is the first item of
1028 a sequence, itself nested in the third item of a sequence is the
1030 0004|1220/2#0008|0082/0#0008|0090
1031 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1032 order to hold the new sequence compatible key. Previously, the
1033 GetKey() method would look in the underlying gdcmDictEntry.
1034 - src/gdcmDocEntry.cxx:
1035 -- constructor now copies the underlying DictEntry key, in the local
1037 -- ::Print: displays the member Key, instead of the (group, element).
1038 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1039 - src/gdcmDocEntrySet.h:xi
1040 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1041 -- now has a new BaseTagKey member.
1043 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1044 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1046 This poses the problem with the semantics of the following lines
1047 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1048 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1049 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1050 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1051 to the long FIXME note for what the problem is. Nevertheless in
1052 order to get things working the dicom dictionary was altered !
1053 Please fix things urgently...
1054 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1055 information), see above note on moving the member VoidArea. Nevertheless
1056 the following entries previously correctly set as US are now inproperly
1058 0028 1201 OW IMG Red Palette Color Lookup Table Data
1059 0028 1202 OW IMG Green Palette Color Lookup Table Data
1060 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1061 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1062 of gdcmDocEntry moved to gdcmSeqEntry.
1063 * src/gdcmSeqEntry.cxx: STYLE.
1065 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1068 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * gdcmPython/testSuite.py: all the test suite in python is now moved
1070 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1071 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1072 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1074 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1076 to avoid inclusion recursion until STL is reached.
1077 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1078 mecanism. errno.h is not included in gdcm anymore.
1079 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1080 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1082 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1083 gdcmData/TestAllEntryVerifyReference.txt
1084 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1085 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1086 exception_on_error parameter.
1087 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1088 - vtk/vtkGdcmReader.cxx changed accordingly,
1089 - Example/*.cxx and Test/*.cxx changed accordingly.
1091 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1092 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1093 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1094 enable_sequences removed from gdcmHeader constructor and dependencies.
1095 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1096 * gdcmPython/demo/PrintHeader.py: dummy fix.
1097 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1098 skip_shadow removed from gdcmHeader constructor and dependencies.
1099 * Example/*.cxx and Test/*.cxx changed accordingly.
1101 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1103 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1105 2004-07-21 Jean-Pierre Roux
1106 * FIX Now, Parsing and Printing a DICOMDIR do work!
1107 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1109 2004-07-20 Jean-Pierre Roux
1110 * FIX Some brain damaged headers have Zero-Lenght fields
1111 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1113 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1114 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1115 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1116 variable (instance of gdcmDebug) by a definition macro, and the instance
1117 is now in static in the gdcmDebug class
1118 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1119 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1121 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * WARNING: ctest now depends more tightly on gdcmData. You should
1123 check out gdcmData properly for things to run smoothly...
1124 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1125 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1126 we need the pixels not be loaded in order to use the ValEntry
1127 that displays position and size).
1128 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1129 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1130 be deprecated. If you have any doubts about the advantages of a
1131 modern scripting language (read Python) versus grass root C++ (i.e.
1132 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1133 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1134 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1135 Anyhow, consider documenting the gdcmData images in
1136 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1138 * Test/CMakeLists.txt:
1139 - now uses TestAllEntryVerify.cxx
1140 - specific comments on oldACR00001.ima (now renamed in gdcmData
1141 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1142 gdcmData/TestAllEntryVerifyReference.txt
1145 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1146 * src/*.[h|cxx] : typedef clean up
1147 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1148 - TagKey renamed to gdcmTagKey (for external usage)
1149 - VRKey renamed to gdcmVRKey (for external usage)
1150 - removal of typedef duplication.
1151 - Removed all unecessary inline keyword from class inline definitions.
1152 - Some method|function(void) declarations replaced with method|function().
1153 * src/jpeg/libijg12/jdhuff12.c:
1154 - printf polluting ctest removed.
1155 - TAB removal for comminting
1157 - TestAllReadCompareDicom.cxx: added a test that compares all the
1158 images in gdcmDataImages.h with corresponding images in
1159 gdcmData/BaselineDicom/. When baseline images are not present
1160 this test creates them.
1161 Note: we need to validate each reference image, but before that
1162 I'd like to rename them with a more explicit name...
1163 - CMakeLists.txt: changed accordingly.
1164 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1165 including each header needed).
1167 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1169 test suite to the Example directory. Are concerned:
1174 - TestWriteSimple.cxx
1175 * Test/CMakeLists.txt: added some comments on reasons for black listing
1176 image gdcmData/oldACR00001.ima
1178 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * Test/CmakeList.txt: removed the following from black list (to be coherent
1180 with removal from gdcmData):
1181 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1182 - gdcm-MR-PHILIPS-16.dcm
1184 Added the following because after last cvs update, they cause
1185 ctest -R TestReadWriteReadCompare
1187 - gdcm-MR-SIEMENS-16-1.acr
1189 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1190 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1191 new comments in this file) we temporarily (sigh) move to a weaker
1193 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1194 we don't need to black list the following images anymore:
1195 - 8BitsUncompressedColor.dcm
1197 - US-PAL-8-10x-echo.dcm
1198 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1199 fixes and the beautified code ;-)
1200 This fixes the bug introduced in version 1.42 (when beautifying)
1201 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1202 Note: ctest was blind to this bug (this means we need to still
1203 improve the test suite). The bug could be detected by using
1204 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1206 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1207 and by displaying the (garbage) produced file temp.XDCM...
1209 2004-06-29 Jean-Pierre Roux
1210 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1211 - replace by uggly but working old code :-(
1212 A lot of things should be OK again.
1213 It's really urgent to have a test suite that *tests*,
1214 to prevent Frog's beautifying sessions to break all the stuff
1215 (twice, withing a fortnigh ...)
1217 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1218 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1219 redundancy) to added Test/TestReadWriteReadCompare.cxx
1220 * Test/CmakeList.txt: because the compare test of
1221 Test/TestReadWriteReadCompare.cxx fails, the following images are
1222 black listed: - 8BitsUncompressedColor.dcm
1224 - US-PAL-8-10x-echo.dcm
1225 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1226 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1227 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1228 and ad-hoc kludge. This kludge is now removed, and on encountering
1229 such an image (OB field brain damaged) we set errno. Then in
1230 ::FindDocLength() we "fix" the length as being ALL what remains
1231 in the file (until EOF). We then proceed, hoping for the best...
1232 This fixes a SegFault in ShowDicom when trying to write such an
1234 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1235 (because TestWriteRead breaks on it, after a non conformal commit?).
1236 ctest now runs properly, except for MakeDicomDir (which was always
1237 broken) and the Python related stuff (still not fixed).
1239 2004-06-24 Jean-Pierre Roux
1240 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1241 FIX : Test/TestReadWrite now iterates on all the file names
1242 (instead of infinite loop)
1243 ENH : Test/TestWriteRead now iterates on all the file names
1245 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1248 2004-06-24 Jean-Pierre Roux
1249 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1250 when SamplesPerPixel =3
1251 - now Write is no longer confused by
1252 'BitsAllocated = 12" and 'BitsStored=12"
1253 - "UN" value representation Elements are now written correctly
1254 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1255 ENH : - now gdcmHeader has its own Write methods
1256 (in order to split the job that has not to be done
1259 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1261 loop on the same image until memory went out.
1262 Note: this means we still have gobs of memory loss in PrintDocument
1263 * src/gdcmDocument.cxx: fixes problem on parsing on file
1264 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1266 2004-06-24 Jean-Pierre Roux
1267 FIX : Write - All the Sequences and Sequence Item are now written
1268 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1269 is added a the end, when necessary.
1270 - A lot of brain-damaged images, that were read correctly are
1271 now written correctly
1272 - length compatible BinEntry are now loaded correctly
1273 (even for odd groups)
1274 Note : only Explicit Value Representation was checked.
1275 (question : is implicit VR really necessary for gdcm ?)
1277 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1278 * DEVELOPPER: added a proposition of coding style.
1279 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1282 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1284 Use the gdcmDocEntry::Print() and Write() instead.
1285 * src/gdcmDocument.cxx: bug fix.
1287 2004-06-22 Jean-Pierre Roux
1288 FIX : gdcmDocument.cxx
1289 - Now we do recognize the JpegLossLess format (there was a misstyping in
1290 code 'beautyfication' :-(
1291 - Now we automaticaticaly load the Luts, if any
1293 2004-06-22 Jean-Pierre Roux
1294 In order : to write Sequences, whatever their imbrication level,
1295 : to allow user to create his own Sequences
1296 a lot of modif where necessary (adding, moving, or virtualising methods)
1298 WARNING : save your own sources *before* cvs up !
1301 ADD virtual void Write(FILE *fp, FileType filetype);
1304 ADD virtual void Write(FILE *fp, FileType filetype);
1305 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1308 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1309 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1310 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1311 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1312 ADD std::string GetEntryByName(TagName name);
1313 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1315 std::string vr = "unkn",
1316 std::string fourth = "unkn",
1317 std::string name = "unkn");
1318 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1319 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1320 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1321 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1322 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1323 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1324 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1325 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1328 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1329 ADD virtual std::string GetEntryByName (TagName tagName);
1330 ADD virtual std::string GetEntryVRByName (TagName tagName);
1331 REM virtual bool Write(FILE *, FileType);
1332 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1333 FILE *_fp, FileType type);
1334 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1335 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1336 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1337 REM virtual std::string GetEntryByName (std::string tagName);
1338 REM virtual std::string GetEntryVRByName (std::string tagName);
1339 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1340 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1341 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1343 std::string vr = "unkn",
1344 std::string fourth = "unkn",
1345 std::string name = "unkn");
1346 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1347 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1348 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1349 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1352 ADD virtual void Write(FILE *fp, FileType filetype);
1355 ADD virtual void Write(FILE *fp,FileType filetype);
1358 ADD virtual void Write(FILE *fp, FileType filetype);
1359 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1360 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1361 REM std::string GetEntryByName(TagName name);
1364 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1366 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1368 The default constructor invoked by the line
1369 gdcmHeader *f1 = new gdcmHeader( header );
1370 was gdcmHeader::gdcmHeader(bool) instead of the expected
1371 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1372 Hence the parsing wasn't executed... See also below.
1373 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1374 as explicit constructor didn't do the trick to fix the above problem.
1375 Could anyone explain why ?
1376 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1377 properly calls gdcmValEntry::Print() (that was weed out from
1378 code related to gdcmBinEntry).
1380 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * In order to fix memory leaks:
1382 - Test/TestWriteSimple.cxx: added cleaning of free store through
1384 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1385 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1386 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1387 (through the call to ::AddDicomDirMeta()) or the destructor
1388 would crash when deleting uninitialized ::metaElems].
1389 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1390 - src/gdcmDocument.cxx:
1391 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1392 from dynamic stores.
1393 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1394 was causing memory leaks.
1395 - src/gdcmSQItem.cxx:
1396 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1397 cleanly handled with polymophism: sorry but my milage is low).
1398 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1399 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1400 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1401 This avoids SegFaulting.
1402 - src/gdcmSQItem.h: coding style.
1404 - Test/TestWriteSimple still severely sucks. The output image content
1405 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1406 damaged when displayed with vtkgdcmViewer.
1407 - on memory leaks: TestWriteSimple leaks really less (see entry
1408 of 2004-06-18 in Changelog file for the call to valgrind).
1409 - on segfaults: ctest now passes all the tests but one (no more
1411 * Erroneous leading white fix:
1412 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1413 white[s] (as opposed to from >> xxx, that removes it [them].
1414 - src/gdcmTS.cxx: ditto.
1415 - gdcmPython/testSuite.py: dirty related kludge removed.
1416 * src/*: remaining references to gdcmParser removed.
1417 * src/*[cxx|h]: added copy[way]left header.
1420 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * In order to fix writing of dicom files:
1422 - Test/TestWriteSimple.cxx: a simpler example of writing.
1423 - Test/CMakeLists.txt changed accordingly.
1424 - src/gdcmDocument.cxx:
1425 -- The destructor now recursilvely removes potential sequences.
1426 -- Bug fix in ::IsJPEG2000()
1427 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1428 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1430 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1431 to only declared) and build on top of
1432 ::GetDocEntryByNumber(guint16, guint16).
1433 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1434 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1435 for usage in destructor and treatement of promotion in
1436 ::ReplaceOrCreateByNumber().
1437 - src/gdcmSQItem.cxx: destructor should better handle his job.
1438 Test/TestWriteSimple now runs (or at least it DOES something).
1439 * We can now start hutting memory links. A good starting point is:
1440 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1441 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1442 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1444 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * Valgrind note: after Mathieu Malaterre teached me how to read
1446 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1448 Using gcc, you can force the STL to use malloc and to free memory as
1449 soon as possible by globally disabling memory caching.
1450 With 3.2.2 and later, you should export the environment variable
1451 GLIBCPP_FORCE_NEW before running your program.
1452 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1453 simply vanish (it is still not clear to me, whether this means that
1454 STL std::string leaks or if valgrind believes it leaks...).
1455 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1456 running bin/gdcmTests makeDicomDir):
1457 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1458 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1460 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1461 SegFaulting (I drowned in DicomDir related code when trying to
1462 understand why the list is empty...).
1463 * src/gdcmDocument.h: first BSD license header try.
1464 * Doc/License.txt added.
1466 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * src/gdcmDocument.[h|cxx]:
1468 - Clean up of the Transfer related predicates. They are now all based
1469 on new method isGivenTransferSyntax, that (should) handle properly
1470 the padding problem.
1471 - general clean up, simplification, and coding style.
1472 - Specific clean up of Parse7FE0() (umproperly named actually).
1473 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1475 2004-06-14 Jean-Pierre Roux
1477 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1478 - fix the display of SQItem ordinal number
1479 - add the GetSQItemByOrdinalNumber method
1480 - remove some useless never written private methods
1482 2004-06-14 Jean-Pierre Roux
1484 - adding a constructor taking a gdcmDocEntry as an input param
1485 - ReplaceOrCreateByNumber now returns :
1486 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1487 a gdcmValEntry * if a string value is passed as a param
1489 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1490 according to the param type (no longer sets a gdcmDocEntry)
1491 - GetValEntryByNumber, GetBinEntryByNumber added
1492 - NewValEntryByNumber and NewBinEntryByNumber added
1494 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1496 - GetSQItemNumber and SetSQItemNumber added, to provide
1497 a (relative) Item identier inside a given Sequence
1498 \warning : some pb remaining around this number
1500 - AddEntry now takes the Item Number as a param
1502 - adding a constructor taking a gdcmDocEntry as an input param
1504 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * Memory leak hunt with the following command:
1506 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1507 --show-reachable=yes gdcmTests PrintDocument
1508 It looks like many (all?) leaks are due to the STL (or a bad usage
1509 of the STL. The lines producing the leaks now have a comment with
1510 a "MEMORY LEAK" tag: you can retrieve them with
1511 grep "MEMORY LEAK" src/*
1512 Here are two typical examples which I can't help fixing:
1517 char * test = "babo";
1518 name = test; //// <--- valgrind detects 960 bytes lost in
1519 //// call to std::string::operator=(char const*)
1520 name.clear(); //// Doesn't help !
1528 std::cout << "Type a bunch of characters followed by RETURN: ";
1529 getline(std::cin, line); //// <--- valgrind dectects a loss
1530 //// of 1320 bytes in call to
1531 /// std::basic_istream<>& std::getline<>
1537 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1538 * src/gdcmHeader.[cxx|h]:
1539 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1540 and related, moved away to gdcmDocument.
1541 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1542 the corresponding protected accessors of inherited class
1543 gdcmDocument, removed ! As a consequence gdcmFile had to be
1544 declared friend of class gdcmDocument (see below).
1545 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1546 - Clean up of undefined or unused methods.
1547 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1548 account the changes to gdcmHeader.h).
1549 * src/gdcmDocument.h:
1550 - gdcmFile is now a friend class (in order to take into account the
1551 changes to gdcmHeader.h).
1552 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1553 (see changes to gdcmHeader.h).
1554 - Accessors (reading on the form GetEntry*) are now public.
1555 - Clean up of undefined or unused methods.
1556 * src/gdcmDocument.cxx:
1557 - adaptation to changes to gdcmDocument.h
1558 - ::OpenFile now writes a verbose message when file cannot be opened.
1559 - some std::string properly set to VRKey
1560 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1561 references to gdcmDocument.
1562 * Test/TestFindTags.cxx: changed accordingly to above changes.
1563 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1564 cvs repository gdcmData.
1566 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1568 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1569 conflicts with gdcmValEntry::voidArea.
1570 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1571 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1572 Value representation between StringRepresentable and BinaryRepresentable.
1573 * src/gdcmDocument.cxx:
1574 - method ParseDES: proper indentation restored and usage of
1575 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1576 - method LoadDocEntry: the fingerprint left in the SetValue() of
1577 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1578 removed. Reverting to previous code segment with the proper
1579 dynamic_cast< gdcmValEntry* >.
1580 Note: this was (partially) breaking the python test suite
1581 (gdcmPython/testSuite.py) that made usage of the above
1582 fingerprint to check presence of "Pixel Data".
1583 * src/gdcmDocEntry.h: coding style.
1584 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1585 now taken into account.
1586 * gdcmPython/gdcm.i: adaptation to the new internal representation
1587 of gdcm (exit gdcmParser, hello gdcmDocument).
1588 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1590 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1591 anymore, but instead prints the loaded Python dictionary.
1592 * .... alas, the python testSuite is still broken.
1594 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1595 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1597 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1598 * src/gdcmUtil.h : export methods
1600 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1601 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1603 * Initial addition of automatic python testing
1604 * Initial addition of automatic image comparison
1606 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1607 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1608 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1610 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1611 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1612 * Test/ShowDicom.cxx : bug fix for msvc compilation
1613 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1615 2004-05-04 Jean-Pierre Roux
1616 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1617 new concepts (and new classes) :
1618 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1619 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1620 - Sequence Doc Entries (gdcmSeqEntries)
1621 a Sequence is composed of Items.
1622 Each item is a set of Doc Entries (this is recursive)
1623 The non uniqueness of the 'Dicom tag' is due to this recursivity
1624 (never taken into account)
1625 Our unability to add a new 'entry' in the header
1626 at the proper location (neither in the H-Table (map or multimap),
1627 nor in the Chained List is also due to this recursivity.
1628 Don't try, right now, to use/modify/compile these new sources :
1629 nothing is finished.
1630 We just commit all the stuff, 'as is', in order not to loose it.
1632 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1633 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1635 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1636 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1637 file prefix (SetFilePrefix)
1639 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * Add a new test: ShowDicom, for now this is just the c++ version of
1641 checkRead.sh, later it will be able to compare the image read against a
1643 * Replace the DEBUG on the stack with a global entry in cmake interface:
1644 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1646 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1647 * Add an example subdir, with a real example on how to read + write a
1650 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1651 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1652 * Doc/CMakeLists.txt: the main page is now properly differentiated
1653 between the developper and user version.
1654 * Doc/doxygen.config.in: dropped search related obsolete flags
1655 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1657 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1658 * DEVELOPPER: added some helpfull comments for compile/test/install
1661 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1663 src directory, now generated in the build dir.
1664 2. Tests as mentionned smarter
1666 4. Add a new method in gdcmDict that return the PubDict by name
1667 this is interesting for 3rd party lib like ITK,
1668 where we could set the institution name / patient name...
1670 * ENH: 1. Now the test suite is working for real
1671 2. All binaries are now output in the gdcm-bin directory
1672 (this was not true before)
1674 2004-04-28 Jean-Pierre Roux
1675 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1676 SeQuence indented printing of Dicom Header.
1677 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1678 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1679 Computation of SQDepthLevel is now part of gdcmHeader constructor
1680 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1681 tree-like structure of a Dicom Header.
1682 * FIX Test code cleaning
1684 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * ENH: Adding automatic testing
1686 1. Need a DartConfig.cmake to submit to public
1687 2. Add a test driver gdcmTest.cxx
1688 3. gdcmTestMain, an helper for the main test driver gdcmTest
1689 4. Files in Test don't have a main anymore, this becomes interesting
1690 when we add more and more tests, thus dsw don't have to load
1692 * ENH: Adding a GDCM_DATA_ROOT for testing
1693 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1694 one file instead of seven + some small cleanup
1696 2004-04-22 Jean-Pierre Roux
1697 * ENH Minor changes to the Print() methods.
1698 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1699 Header printing. Example given with :
1700 > PrintHeader fileName 2 new
1701 (SQ based tree-like structure still to be done for the Header ...)
1703 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1704 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1705 1. I have added some unsigned where needed
1706 2. Some function parameter not used -> (void)
1707 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1708 4. g++ don't like character '\' in comment
1709 5. #define jpeg_create_decompress jCreaDecompress
1710 this really need to be fixed
1711 6. virtualize destructor of gdcmObject ... leakage
1712 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1713 this also really need to be fixed
1714 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1715 remove compression file
1716 (as we only do decompression, right ?)
1717 * ENH: Change malloc/calloc/free with c++ equivalent
1719 2004-04-21 Jean-Pierre Roux
1720 * FIX gdcmHeaderHelper::GetXSpacing
1721 when a single value is found (bug ?), xpacing is now
1722 defaulted to yspacing
1724 2004-04-19 Jean-Pierre Roux
1725 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1726 * ENH add parameters :
1727 bool exception_on_error = false,
1728 bool enable_sequences = false,
1729 bool ignore_shadow = false
1730 to the gdcmFile constructors to be full gdcmParser compliant
1731 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1732 to allow reading of PAPYRUS 3.0 files
1734 2004-04-06 Jean-Pierre Roux
1735 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1737 2004-04-02 Jean-Pierre Roux
1738 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1739 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1740 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1742 2004-03-30 Jean-Pierre Roux
1743 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1744 for ACR file, written out as DICOM files (hope so...)
1746 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1748 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1749 moved to base class gdcmParser and only the specialisation is kept
1751 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1752 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1753 already does the job.
1754 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1755 (to be consistent with gdcmParser::WriteEntries).
1757 2004-03-30 Benoit Regrain
1758 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1759 upate of the object's instance. It's passed to 2 in the unfavorable
1760 case : one in the ExecuteInformation, one in the ExecuteData
1762 2004-03-29 Jean-Pierre Roux
1763 * ENH : Check on file type to be written moved
1764 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1765 * FIX : gdcmObject::ResetBoundaries now stops properly
1766 when end-of-list is reached
1767 : gdcmVersion modified (as Benoit Regrain asked)
1769 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1771 * src/gdcmUtil.cxx: added forgotten iostream include.
1772 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1773 equivalent to ExplicitVR in existing code).
1775 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1777 now contains all the gdcmGlobal related code.
1778 * minor coding style and doxygenation changes.
1780 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1782 now contains all the Debug related code.
1783 * minor clean-up of includes in src/*.cxx
1784 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1785 CreateCleanString) removed.
1786 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1787 * Doc/DoxyMainPageUser.txt added.
1788 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1789 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1790 src/gdcmDirList.cxx)
1792 2004-03-24 Jean-Pierre Roux
1793 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1795 2004-03-23 Jean-Pierre Roux
1796 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1797 big endian made volumes
1798 * ENH Now gdcmParser constructor and destructor are protected to forbid
1799 end user to instanciate class gdcmParser
1800 (only gdcmHeader and gdcmDicomDir are meaningfull)
1802 2004-03-22 Benoit Regrain
1803 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1804 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1805 gdcmSerie to gdcmDicomDirSerie
1807 2004-03-19 Jean-Pierre Roux
1808 * ENH Now the tree-like structure describing a DICOMDIR comming from
1809 an already existing DICOMDIR file is consistent with
1810 the home-made tree-like structure build ex-nihilo
1811 or build from the files held (recursively) in a Directory
1812 functions gdcmDicomDir::CheckBoundaries()
1813 gdcmObject::SetBoundaries() added
1815 2004-03-17 Jean-Pierre Roux
1816 * REM (Eric Boix bug) : removal of meaningless
1817 gdcmDicomDirImage::NewImage function.
1818 * FIX now file names and directory name are written properly in the
1820 * FIX now gdcmDicomDir constructor may be call without any trick
1823 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1825 of gdcmDicomDirImage::NewImage as empty function.
1827 2004-02-28 Jean-Pierre Roux
1828 * ENH add gdcmDicomDir:NewPatient
1829 add gdcmDicomDirPatient:NewStudy
1830 add gdcmDicomDirStudy:NewSerie
1831 add gdcmDicomDirSerie:NewImage
1832 to allow making gdcDicomDir object.
1833 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1834 (as opposite to the gdcmHeader chained list)
1836 2004-02-11 Benoit Regrain
1837 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1838 when using from python
1840 2004-02-10 Benoit Regrain
1841 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1842 * FIX : in gdcmDicomDir when the directory is empty
1843 * ENH : add callback and methods to get the progression of dicomDir
1846 2004-02-06 Jean-Pierre Roux
1847 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1848 - GDCM_META added to gdcmDicomDirType
1849 - class gdcmMeta created
1850 * ENH : - A brief summary is now displayed at the beginning of
1851 'testDicomDir' to help disaster magnitude estimation
1852 * REM : Now useless Test/explDICOMDIR.cxx
1854 2004-02-05 Benoit Regrain
1855 * ENH : add methods in gdcmObject to get the hash table or the list of
1857 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1858 * FIX : wrapping python for TagHeaderEntryHT
1860 2004-02-04 Benoit Regrain
1861 * FIX : even length for some strings when writting the dicom dir
1862 * FIX : sort the images in the dicom dir
1863 * FIX : Bug fix for python use of dicom dir
1864 * ADD : a python demo
1866 2004-02-04 Jean-Pierre Roux
1867 * FIX : Final solution (?) for icone embedded images
1868 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1869 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1870 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1871 gdcmData/gdcm-MR-SIEMENS-16.acr1
1872 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1873 to make full checking easier
1875 2004-02-04 Benoit Regrain
1876 * FIX : WriteEntries : coding style & logic in parameters
1877 * FIX : Set the elements to create the DicomDir in a dictionary file
1879 2004-02-03 Benoit Regrain
1880 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1881 * gdcmDicomDir : add the load of directory
1882 * Bug fix and print add-on
1884 2004-02-03 Jean-Pierre Roux
1885 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1886 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1887 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1888 * FIX gdcmParser.cxx : 'group length' elements are now considered
1889 as integers, even for shadow groups, when file is Implicit VR
1891 2004-02-02 Jean-Pierre Roux
1892 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1894 of the last synonym :-(
1895 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1897 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1898 * FIX taking into account the possible 7fe0,0010 multiplicity
1899 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1900 to allow removal of references to 7fe0,0010, to deal with
1901 ACR-NEMA images, when 0028,0200 is meaningfull
1903 2004-01-31 Jean-Pierre Roux
1904 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1905 no longer writes 'Un' on disk
1906 * FIX SQ elements with actual length are now dealt with corectly
1907 * FIX gdcmFile::WriteBase make the difference, for color images, between
1908 the length (for Palette expanded images)
1909 and Raw Length (non expanded image + Palette)
1910 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1911 (that broke Write). Replaced by UL.
1912 Aware user will reload the field if he
1913 thinks it's necesssary
1915 2004-01-30 Jean-Pierre Roux
1916 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1917 when 'dirty Acr' is found, to be compliant with the new
1918 IsReadable() methods.
1920 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1921 (no DOUBLE images in kosher DICOM,
1922 but so usefull for people that miss them ;-)
1924 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1925 DICOMDIR related utilities (not checked as Windoze compliant)
1927 2004-01-28 Jean-Pierre Roux
1928 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1930 2004-01-27 Jean-Pierre Roux
1931 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1932 to allow skipping the shadow elements, to save memory space.
1933 The TRUE value for this param has to be used
1934 with a FALSE value for the 'enable_sequence' param.
1935 ('public elements' may be embedded in 'shadow Sequences')
1936 * gdcmHeader methods now deal with 'embedded icones images' in the header
1937 (even when an 'icone image sequence' is announced by the
1938 element (0x0088,0x0200), but there is NO icone at all ...
1940 * gdcmHeader sometimes Image Location value doesn't follow
1941 the supposed processor endianity (see gdcmData/cr172241.dcm).
1944 * gdcmHeader add the method
1945 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1946 to get *all* the Header Entries with the same tag.
1947 GetHeaderEntrySameName is probabely *useless*
1948 (no meaning : Name is *not* an identifier within the Dictionary)
1950 2004-01-26 Benoit Regrain
1951 * Bug fix in the print of hexadecimal representations. Remove long fields
1952 in the print and add a third level of print to print them
1954 2004-01-23 Benoit Regrain
1955 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1956 * Bug fix on test suite after remove the strip made on not string fields
1957 * Split the IsReadable method between gdcmParser which test that the file
1958 is dicom and gdcmHeader which test that it's an image file
1960 2004-01-22 Benoit Regrain
1961 * DicomDir : clean code, add methods, set variables in protected or private
1962 * gdcmUtil : bug fix for the clean string method
1964 2004-01-19 Benoit Regrain
1965 * Add the use of shadow dictionaries
1966 * bug fix and coding style
1968 2004-01-19 Benoit Regrain
1969 * src/gdcmFile.cxx : bug fix concerning the close of file
1970 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1971 * Add the update of header entries using the shadow library
1973 2004-01-19 Benoit Regrain
1974 * removal of file gdcmHeader2.cxx
1975 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1976 inheriting from gdcmParser. This split is to prepare the integration
1977 of dicom dir parsing
1978 * bug fix under python
1980 2004-01-16 Jean-Pierre Roux
1981 * REM removal of class gdcmHeaderEntrySet
1982 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1983 * ADD add file gdcmHeader2.cxx
1984 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1986 2004-01-15 Benoit Regrain
1987 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1988 entries created while parsing the header. Thus, they will be destroyed
1989 when the gdcmDictSet will be destroyed
1990 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1993 2004-01-15 Benoit Regrain
1994 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1995 made a fatal error because of the memory release at the end of program.
1996 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1997 some memory and vtk seems to have some problems with that.
1998 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2000 2004-01-14 Benoit Regrain
2001 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2002 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2003 * src/*.[h|cxx] : make changes due to class name changes
2004 * gdcmPython/demo/*.py : bug fix due to method names
2006 2004-01-13 Benoit Regrain
2007 * src/*.[h|cxx] : coding style
2008 * vtk/*.[h|cxx] : coding style
2010 2004-01-13 Benoit Regrain
2011 * gdcmPython/testSuite.py : test the readable flag of file for tests
2012 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2013 It's lied to the stl compilation by MSVC (windows, always windows...)
2014 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2016 2004-01-12 Benoit Regrain
2017 * src/*.h : add comments
2018 * src/gdcmDictSet.h : set the method BuildDictPath in public
2019 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2020 directly setted in the source code
2021 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2024 2004-01-09 Benoit Regrain
2025 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2026 * setup.py : use a reference to gdcmVERSION
2028 2004-01-07 Benoit Regrain
2029 * Modification to compile with the distutils.
2032 2003-12-10 Benoit Regrain
2033 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2034 can use a gdcmHeaderHelper to load data
2035 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2036 made in the source code
2038 2003-12-10 Benoit Regrain
2039 * Update Windows projects and .cvsignore files
2041 2003-11-12 Jean-Pierre Roux
2042 * ENH gdcmHeader constructor has one more parameter (default value : false)
2043 that allows the user to 'go inside' the SeQuences only
2045 gdcmElValSet:Print takes it into account
2047 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2048 * ENH: Update gdcmPython/CMakeLists
2049 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2050 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2052 2003-11-10 Jean-Pierre Roux
2053 * FIX : gdcmHeader::LoadElements is now based
2054 on the ListTag listElem member,
2055 not longer on the TagElValueHT tagHt member
2056 * ENH : PrintPubElVal shows (temporarily) both results,
2057 with the tagHt member and the listElem member.
2058 (it's easier to 'see' the problems when using Printheader)
2060 * FIX : old private member LgrElem is now splitted into
2061 ReadLength : Length actually found on disk (updated only
2062 if bug fixing is necessary), for internal
2064 UsableLength : Updated by FixFoundLength, to fix a bug
2065 or to allow Parser going on.
2066 Will allow to re-write a kosher header when a SeQuence
2067 with a length (not 0000) is found
2068 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2069 because gdcmElValSet::Add does not update ListElem
2072 2003-11-07 Jean-Pierre Roux
2073 * FIX misstyping in Transfert Syntax name table
2074 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2075 when they have an actual length (not 0000 nor FFFFF)
2076 (Nobody should care of it, but DICOMDIR explorers)
2078 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2081 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2082 * ENH: vtkGdcmReader now supports LUT !
2083 (vtkgdcmViewer for now is not able to use them though)
2085 2003-11-05 Jean-Pierre Roux
2086 * in testSuite.py : new files names for checking the package
2087 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2088 that returns the pixel area size to the *aware* (vtk) user
2089 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2091 2003-11-05 Benoit Regrain
2092 * in testSuite.py : Modify the rules for checking the paths
2093 : Explicit error messages
2094 * in __init__.py : Related modif
2096 2003-11-03 Jean-Pierre Roux
2097 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2098 to be used by aware (vtk) users that want to manage
2099 LUT (and no to turn the PALETTE image into an RGB pixels one)
2100 * GetPixelType now returns 8U for 24 Bits images
2101 (vtkGdcmReader compliant)
2103 2003-10-31 Jean-Pierre Roux
2104 * Removal of *all* gdcmData images and add them again
2105 in order to loose the 'history' of un-anonymised images
2107 2003-10-31 Jean-Pierre Roux
2108 * RMV : removal of useless jBitsInJsample.h
2109 for both 8 and 12 Bits JPEG Lossy Libraries
2111 2003-10-31 Jean-Pierre Roux
2112 * ENH : Add the functions gdcmFile::GetImageDataRaw
2113 gdcmFile::GetImageDataIntoVectorRaw
2114 that act as GetImageData and GetImageDataIntoVector
2115 except the making of an RGB Plane from Gray Plane + LUT
2116 Intended to aware (vtk) users who know how to manage
2119 GetLUTRGBA return a R,G,B,A LUT if any
2120 lgrTotaleRaw gives the 'Raw' length
2121 GetImageDataRaw returns the gray Plane
2122 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2123 (They stay Grey, just like with other Dicom viewers :-(
2125 2003-10-30 Jean-Pierre Roux
2126 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2128 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2129 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2130 being coherents dicom files.
2132 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2133 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2135 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2136 * ENH: Two steps is necessary to please VC++ compiler...
2137 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2138 * ENH: Add include dir to medcon lib
2139 * FIX: only one function is being exported for now !
2140 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2142 2003-10-29 Jean-Pierre Roux
2143 * adding gdcmHeader::GetLUTRGBA
2144 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2145 --> Mathieu, the modif u're waiting for is not yet committed
2146 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2148 2003-10-27 Jean-Pierre Roux
2149 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2150 00191113.dcm DermaColorLossLess.dcm
2151 MxTwinLossLess.dcm RadBWLossLess.dcm
2152 * ENH: For version prior to vtkImageViewer2 -r 1.19
2153 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2155 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2156 * Removal of ido stuff in CMakeLists.txt
2158 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2159 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2160 * FIX: remove a call to ->Modified ... see comments
2161 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2163 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2164 * FIX: Problem with path for libvtkgdcmPython
2165 * ENH: Try adding a search script for python site-package
2166 * RMV: Remove some file from medcon lib that are not necessary
2167 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2168 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2169 * FIX: More pragma disable fro VC++,
2170 I don't think I break something as it is also disable in VTK/ITK.
2171 But it fasten debug compilation time.
2173 2003-10-23 Jean-Pierre Roux
2174 * gdcm now deals with 16 Bits Run Length Encoded images
2175 (they are compressed as 2 planes images,
2176 one for the high Bytes, the other for low Bytes)
2178 2003-10-22 Jean-Pierre Roux
2179 * Now CheckRead takes into account :
2180 - the bugged 'Leonardo' Siemens images
2181 - the XA images, sent thru the burning VPRO station
2182 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2185 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * FIX: When copying a Makefile.am to CMakeLists.txt
2187 one should remove the '\'
2189 2003-10-22 Jean-Pierre Roux
2190 * in gdcmData adding a bugged 'Leonardo' Siemens image
2191 (wrong lengths in header)
2192 OK with gdcm, KO with the other viewers :-)
2193 * add a GE dlx XA image, thru the VEPRO burning station
2196 2003-10-21 Jean-Pierre Roux
2197 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2198 for a brutal checking of vtkgdcmViewer compliance
2200 2003-10-21 Jean-Pierre Roux
2201 * add the files for 'xmedcon' Jpeg Lossless library
2202 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2204 2003-10-21 Jean-Pierre Roux
2205 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2207 2003-10-21 Jean-Pierre Roux
2208 * garbage Siemens 'Leonardo' images dealt with
2209 (the patch is easy to remove)
2210 * cosmetic changes to avoid warnings
2212 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2213 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2214 no need to press 'r' now.
2216 2003-10-20 Jean-Pierre Roux
2217 * upgrade of checkRead.sh checkWrite.sh according
2218 to new Jpeg Lossless decompressor
2219 * add US.3405.1.dcm, a genuine RGB medical file ...
2220 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2221 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2223 2003-10-15 Jean-Pierre Roux
2224 * general anonymisation in gdcmData
2225 * adding the 'color files' from
2226 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2227 * adding some well knowed bugged-header images
2228 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2229 waiting for their inclusion in Python testsuite
2231 2003-10-15 Jean-Pierre Roux
2232 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2233 no longer seg faults when file is not found
2235 2003-10-14 Jean-Pierre Roux
2236 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2239 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * TODO: *.in file to genereate a UseGDCM later
2242 2003-10-14 Jean-Pierre Roux
2243 * Some supposed-to-be Dicom Images have no preamble.
2244 OpenFile takes it into account
2245 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2246 * Missing elements added in dicomV3.dic
2247 (just to be affraid : have a look at
2248 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2249 and do it again next year ;->
2251 2003-10-13 Jean-Pierre Roux
2252 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2253 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2254 But there are NOT. It's fixed !
2256 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2257 * FIX: "jpeglib.h" was not found on VC++
2258 * FIX: vtkgdcm was not being installed
2260 2003-10-10 Jean-Pierre Roux
2261 * ENH : OpenFile closes the file if it *really* doesn't look like
2262 an ACR-NEMA / DICOM one.
2263 * FIX : testWrite no longer writes an empty file if the source file
2264 is not gdcm Readable
2265 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2268 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2269 * FIX: CMake generate now documentation
2270 * ENH: out of source doc build !
2271 * ENH: Generate both user and dev documentation
2272 * ENH: Should work on windows too
2273 * ENH: Only one doxygen config.in file is needed
2274 * FIX: make install should be ok now on ùnix plateform
2275 * FIX: PATH to dictionary was wrong (missing /)
2276 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2278 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * vtkGdcmReader is now able to read rgb dicom file.
2280 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2281 * added a gdcmViewer to vtk test, use mouse to control
2282 window level & window width
2284 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2285 * CMake-ification of gdcm, we have now two build system
2286 * FIX: on cygwin Wsock32 doesn't exist
2287 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2289 2003-10-06 Emanuel Ollart
2290 * FIX : compilation process wad broken.
2291 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2293 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * change gdcmViewer -> vtkgdcmViewer
2295 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2297 2003-10-06 Jean-Pierre Roux
2298 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2299 ( e.g : well known GE images with a wrong elem length,
2300 : Philips MRI Images with a wrong Huffman table)
2301 * still to be done : allow the reading of bugged LEONARDO Siemens images
2303 2003-10-03 Jean-Pierre Roux
2304 * Odd length strings are padded with '\0' (not with spaces,
2305 to remain compliant with already defined strings,
2306 like Transfert Syntax UID and others)
2308 2003-10-03 Jean-Pierre Roux
2309 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2310 to allow displaying RGB images (not only by affim ;-)
2312 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2313 * vtkGdcmReader is now able to read rgb dicom file.
2314 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2316 2003-10-03 Jean-Pierre Roux
2317 * A few nasty patches to allow the reading of a lot of nasty images
2318 ( e.g : well known GE images with a wrong elem length,
2319 : Philips MRI Images with a wrong Huffman table)
2320 * still to be done : allow the reading of bugged LEONARDO Siemens images
2322 2003-10-03 Jean-Pierre Roux
2323 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2325 2003-10-03 Jean-Pierre Roux
2326 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2327 to allow displaying RGB images (not only by affim ;-)
2329 2003-10-03 Jean-Pierre Roux
2330 * gdcmFile::GetImageDataIntoVector now
2331 - deals with MultiFrames MultiFragments Run Length Encoded files
2332 - deals with YcBcR (YBR_FULL) files
2333 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2334 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2336 (no sample found :-(
2338 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2340 Two reasons: - clear things
2341 - third parties acces gdcm through header files, so won't
2342 suffer anymore VC++ complains
2344 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2345 * add argv[1] in testvtkGdcmReader.cxx
2348 2003-09-24 Jean-Pierre Roux
2349 * The lines are now eigthy characters long.for
2350 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2352 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2353 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2354 char* to std::string. Thus, the use of strdup becomes useless. (see
2355 previous commis of Malaterre)
2356 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2357 before the last Malaterre's commit.
2359 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2360 * This commit should fix the Debug building under VC++, the problem
2361 was mainly a mixture of debug and release lib being loaded at startup.
2362 * I also remove a depency to a specific C function: strdup. Because I had
2363 to force the link to msvcrtd (whereas strdup is in libc).
2365 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2366 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2367 located in the gdcmCommon.h file. All use of reference of tha has been
2368 changed to now use the variable GDCM_UNFOUND.
2370 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2372 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2373 Dicom dictionary. The test suite can now be run again. Note:
2374 I'm note very happy with the " (RET)" changes. I believe this
2375 RETAINED comment should be dropped when parsing the dictionary.
2376 - PACKAGER corrected
2378 - AUTHORS updated and now in alphabetical order
2379 * Makefile.am now exports gdcm.dsw for Windoze users.
2381 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * cygwin complains about missing std:: in subdir Test/
2384 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2385 * remove some methods that are now in gdcmHeaderHelper
2387 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * vtkGdcmReader set spacing and origin correctly
2390 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2391 * Fix a few delete/delete[] mismatch
2393 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2395 interpretation to data given by gdcmHeader. For instance there are
2396 heuristics to get informations (look at different places).
2397 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2398 sorting DICOM images based on different strategies.
2399 * modified Makefiles accordingly.
2401 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2403 when building in debug mode
2404 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2405 src/win32/gdcmdll.dsp
2406 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2408 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2412 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2413 * src/win32/libgdcmjpeg12.dsp was not dos format
2414 * src/win32/libgdcmjpeg12.dsp :
2415 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2416 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2418 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2419 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2421 * src/gdcmFile.cxx : bug fix in affectation type
2422 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2423 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2424 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2425 symbols... future problem ?
2427 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * src/win32/libgdcmijpeg12.dsp was missing
2429 * modified gdcm.dsw accordingly
2431 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2434 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2435 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2436 commit of JPR (before his hollidays to facilitate our work).
2437 * setup.py : bug fix in code. Modifications made while the last commit
2438 of JPR. The code hasn't been tested before the commit... it's so
2439 useless to make that (for best programmer that is JPR) !!!
2441 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2442 * tagged the current version as Version0_3 (i.e. version 0.3)
2444 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2445 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2446 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2447 * *.dsp : modifications to use new libgdcmijpeg8 library
2448 * setup.py : bug fix on VTKPATH variable
2449 * PACKAGER : adding all concerning windows
2451 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2454 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2455 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2456 test suite reported error.
2457 * PACKAGER file added (describes what a packager must do when
2458 packaging a new release).
2459 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2460 * configure.in: upgraded version number to 0.3.0
2461 * fixing build of rpm (through rpm -ta):
2462 - Doc/Makefile.am exports proper doxygen files
2463 - src/jpeg/libijg8/Makefile.am exports the include files.
2465 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2466 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2467 * src/gdcmHeader.h : formatting code
2469 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2470 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2471 We were obtaining error message from vtk. Now, creation of file list
2472 is made in an internal list to prevent this problem.
2473 Bug fix when output is empty.
2474 Bug fix in update of progress value. Previous commit for this was a bad
2476 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2478 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2479 * src/gdcmHeader.h : added method to get the file name
2480 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2481 files. Added method to remove all files on the input
2482 Added FIXME comment concerning the bad parsing of header made by
2483 ExecuteInformation method (in ExecuteData method)
2485 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2487 when using make instal.
2488 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2489 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2491 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2492 * setup.py : adding include dir of jpeg lib to compile all sources
2493 * */Win32/*.dsp : JPR fix for windows compilation
2495 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2496 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2498 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2499 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2501 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2502 * setup.py is again effective on un*x (takes into account the
2503 addon of the jpeg library)
2504 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2505 * Doc/Doxy* updated (includes above enhancements)
2506 * INSTALL now points to web documentation
2508 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * src/gdcmHeader.h doesn't make unnecessary reference to
2511 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2513 * src/gdcm*.[cxx|h] :
2514 - to allow compilation with gcc 3.x
2515 -- clean up of STL usage (added explicit usage of std::)
2516 -- small fixes on exceptions.
2517 Note: linking not tested !
2518 - clean of doxygen comments to avoid warnings at documentation
2520 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2521 dependent convertion).
2523 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * Clean up of previous JPR garbage commit (not even commented in the
2526 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2527 - moved all jpeg related files from src to src/jpeg/libijg8, with
2528 addition/modification of Makefile.am and configure.in.
2529 - the testSuite is still brain damage (not guilty).
2531 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2532 * WrapVTK.py : modifications to get correctly vtk source files to
2534 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2535 (FileName -> Filename)
2537 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * vtk/vtkGdcmReader.[cxx/h]:
2539 - UpdateProgress method should now be effective
2540 - removed the limitation on having only images loaded (as opposed
2542 - when building a stack of images/volume, a lesser number of
2543 gdcmHeader and gdcmFile instances should be used (hopefully
2544 accelerating things).
2545 - when building a stack of images/volumes, files which are not
2546 loadable (wrong path-filename, wrong permissions on existing file,
2547 or file not parsable by gdcm) are replaced with a black image
2548 in the stack (for the caller to notice the problem).
2550 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2553 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2555 between standard library (std) and vtk library (problems are found
2556 under Windows... thanks Windows !)
2558 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2559 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2561 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2563 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2566 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * When compiling with distutils (see setup.py) the C++ compiler is
2568 called with different flags than the default ones (with automake).
2569 In order to fix all those warning, I compiled gdcm with the command
2570 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2571 and went for warning fixes:
2572 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2573 up from unused variables.
2574 - vtk/vtkGdcmReader.cxx: potential bug fix.
2575 * src/gdcmHeader.h: Doxygen warning cleanup
2577 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * gdcmPython/gdcm.i:
2579 - typemaps correction to take into account the systematic replacement
2580 of "using namespace std" with std:: prefix e.g. std::list,
2581 std::string... (cf changes of 2003-05-21).
2582 - gdcmGlob global variable of type gdcmGlobal (defined in
2583 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2584 exported to Python a as cvar.
2585 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2586 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2587 gdcmDictSet.GetPubDictTagNames() and
2588 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2589 C++ static methods).
2590 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2591 with the above changes.
2593 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2594 * setup.py, manifest.in : bug fix under linux
2596 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2597 * Modification of setup.py to compile vtk part too. Then, we have 2
2598 wrappers which must work with same distutils. For that, we have a
2599 generic distutils in distusiltsWrapping.py ; with :
2600 - build_extWrap class to wrap generically all extensions,
2601 - ExtensionWrap base class for all wrapping extension that contains
2603 - Wrapper interface which wrap sources
2604 + In WrapSwig.py we have extension and wrapper for Swig
2605 + In WrapVTK.py we have extension and wrapper for VTK
2606 * MANIFEST.in : modifications to consider vtk directory and new python
2607 files for compilation
2609 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2610 * Added python wrappers of vtkGdcmReader vtk class (see the
2611 source in vtk/vtkGdcmReader.cxx) :
2612 - vtk/Makefile.am now builds a library
2613 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2614 python library (as opposed to _gdcm.so wich are the python
2615 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2616 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2618 - configure.in has an additional flag --enable-vtk that needs
2619 to be set to enable compilation of vtk related code, that is:
2620 + vtk/vtkGdcmReader.so and
2621 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2622 + gdcmPython/vtkgdcmPython.so (see above)
2623 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2624 be read when compressed or when HighBit + 1 != BitsStored),
2625 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2626 the usage of the python wrapper of vtkGdcmReader vtk class.
2627 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2628 * src/*.[h] all occurences of stl classes are now prefixed with
2629 std::, and all occurences of "using namespace std;" where removed.
2630 This is to avoid pollution of global namespace in included files.
2631 Apparently vtk does not avoid this pitfall: when using both
2632 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2633 collision of various stl members (principally cout...).
2634 * gdcmPython/testSuite.py now cleanly removes temprory generated
2636 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2637 comply with above changes)
2639 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2640 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2641 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2642 vtk data structure (an image Flip was required).
2643 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2644 * cosmetic changes in documentation.
2646 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2647 * src/gdcmHeader.cxx: the constructor no longer exits when an
2648 unexisting file is given as argument.
2649 * The subdirectory Data (containing all the images used for the
2650 test suite) is not part of this repository anymore. A new module
2651 containing those images is now available at
2652 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2653 with the name gdcmData.
2654 All the python scripts (including the package initialisation file
2655 gdcmPython/__init__.py) were adapated to take this change into
2656 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2658 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2659 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2660 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2661 demo of the usage of this class.
2662 Compilation of this vtk part is only done when using the --enable-vtk
2663 at configure (or autogen.sh) stage.
2665 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2666 * More memory link related corrections and documentation fixes.
2668 - maximum info is obtained with a command of the form:
2669 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2670 --show-reachable=yes PrintHeader
2671 - the remaining reachable blocks seem to come from the STL
2672 allocation scheme through the usage of map and list. It looks
2673 like this memory cannot be freed but it is not a memory leak
2674 (in fact further invocation to the STL would recollect the
2675 unused memory allthough it cannot explicitely be freed).
2676 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2677 of displaying an image parsed with gdcm and displayed with VTK.
2678 Note: some images don't seem to work e.g.
2679 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2680 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2681 Allthough this weakens the semantics, it is a ditch attempt to
2682 make gdcm more thread friendly.
2684 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2685 * Memory link hunt (by using valgrind through the command
2686 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2687 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2688 gdcmHeader::_dicom_vr.
2689 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2690 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2692 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2694 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2695 * src/Makefile.am now exports all the necessary include files at
2699 * UpdateGroupLength replaced by new one
2702 * UpdateGroupLength re-written using H-Table
2703 (named UpdateGroupLengthNew untill checks are over)
2705 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2706 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2707 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2709 - gdcmHeader::GetPubElValSet removed.
2710 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2711 UpdateGroupLength, WriteElements, Write.
2712 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2713 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2714 carried the same semantics.
2715 - src/gdcmHeaderIdo.cxx changed accordingly.
2716 - gdcmFile::WriteBase now regroups all the codes from previous
2717 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2718 - enum FileType moved to gdcmCommon.h
2719 * src/gdcmHeader.cxx AddDefault trashed
2720 * gdcmGetXSize added
2721 * getimageDataSize now calls gdcmGetXSize
2722 * Test/*.cxx changed to agree with above changes
2724 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2726 (to avoid double call by end user).
2727 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2728 by end user, since gdcmHeader::gdcmHeader now handles it.
2730 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * gdcm/Doc many doxygen changes:
2732 - Doxyfile now has two different versions, DoxyfileUsers that generates
2733 the html.users end users oriented documentation and
2734 DoxyfileDeveloppers that generates the html.developper developper
2735 oriented documentation.
2736 - README changed accordingly
2737 - requirement.txt removed (old design info moved to TODO).
2738 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2739 DoxyMainPage.txt, DoxyPython.txt provide more information.
2740 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2741 be updated by simply regenerating the docs with doxygen and copying
2742 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2743 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2744 all the tests in the form "if (<map>.count() >1)" were removed.
2745 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2746 ill-formed documentation sections.
2747 * src/gdcmHeader.cxx: ditto
2749 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * setup.py fixed for un*x (needed macro for stdint.h)
2751 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2752 un*ces with sh-utils test utility.
2753 * gdcmPython/demo/test.py renamed to PrintHeader.py
2754 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2755 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2756 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2757 * src/gdcm*.cxx JPR's bad inclusion fixed.
2759 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2761 * gdcmPython/demo/test.py changed accordingly.
2763 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * gdcmPython/Makefile.am fixed linking against libstdc++
2765 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2766 * Swig subdir (historical tests of swig version 1.3.17++) removed
2767 * Test/testChangeEntete.cxx some lines commented out in order to make
2769 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2770 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2772 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2773 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2774 hence the user doesn't need this explicit call.
2775 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2776 i.e. LoadElements() call removed.
2777 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2778 - src/Makefile.am declares the proper flag for g++.
2779 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2780 for adding user defined new tags.
2781 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2782 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2783 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2785 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2786 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2787 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2788 src/Makefile.am : the project should properly compile and install
2789 with the autotools, included the python wrappers part.
2790 * gdcm.spec.in : added a spec file for RPM packaging.
2792 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2793 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2795 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2797 to exported to the environement (see gdcmPython/testSuite.py
2799 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2800 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2801 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2802 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2803 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2805 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * gdcmPython/__init__.py doesn't crash anymore when running in
2807 in InstallMode or PreInstallMode but with an environment given
2808 value of GDCM_DICT_PATH.
2809 * src/gdcmDictSet.[cxx/h] coding style.
2811 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2813 * src/gdcm.h general comments moved to TODO, and README
2814 * src/gdcm.h should now be seen as a user commodity (including it
2815 should suffice to fully use gdcm). It is nowhere including within
2816 any of the kernel files src/*.cxx and src/*.h.
2818 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2820 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2822 * src/gdcm*.cxx only include their corresponding include file
2823 (as opposed to gdcm.h)
2824 * gdcmPython/gdcm.i changed accordingly
2825 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2826 the autogen.sh generated "make snapshot" command to work.
2827 * autogen.sh removed history related references to crea package.
2829 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * distutilsSwigCPlusPlus.py work around some swig portability
2833 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2835 was done in a last ditch attempt to get setup.py _really_
2836 operationnal. The python/gdcmPython layaout add the advantage
2837 of hidding away the python related distutils specific files
2838 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2839 Alas, the src directory was out of scope (i.e. it's relative
2840 position to setup.py was ../src) which made things impossible to
2841 handle (see previous version of python/setup.py). Crossing fingers...
2843 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * python/setup.py now works on Un*x. (harder than I thougth)
2845 * python/distutilsSwigCPlusPlus.py can now have include files
2846 among the list of sources.
2848 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2849 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2850 * modifications in MSVC projects
2852 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * As stated by the first lines of Test/ExceptionAndPython/README, it
2854 looks like we can move back to original usage of exception within
2855 src/gdcm* and hence remove the errno stuff that was introduced
2856 as a quick and dirty fixture of this problem (added to the TODO).
2857 * Doc/Doxyfile configuration file for Doxygen and corresponding
2858 README file for usage added.
2859 * Test/testWrite.cxx added. This new test comes from a split of
2860 test.cxx that is now reverted to its original purpous i.e.
2861 testing the proper parsing of a Dicom related file.
2862 testWrite.cxx concentrates on testing the IO part of gdcm.
2863 * Test/bug1.cxx (containing a bug on WIn32) added.
2864 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2865 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2866 whose purpose is to publish the content of the TagNames of the
2867 Dicom public dictionary were not accessible without an
2868 instance of class gdcmHeader.
2869 - those methods are now static methods of gdcmDictSet and hence
2870 require no instances at all to be invocated.
2871 - within gdcmDictSet this change required to change some method
2872 to class methods (i.e. are now static) among which SetDictPath
2873 (renamed to BuildDictPath) and LoadDefaultPubDict.
2874 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2875 the above changes by calling the new method classes of gdcmDictSet.
2876 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2877 the above to be effective.
2878 * python/gdcmPython: in order to wrap properly the above changes
2879 for Python, swig version now needs to be > 1.3.17.
2880 * python/gdcmPython/Makefile fixed to adapt itself to new
2881 configure/make shema introduced by Johan Montagnat (thanks for the
2882 contribution). Alas this Makefile cannot be turned into a proper
2883 Makefile.am without some heavy changes in the configure.in
2884 (for python dectection).
2885 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2886 now avoids publishing the empty entries.
2888 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2889 * python/setup.py : bug fix concerning install under windows
2890 ExtraPath reused :-P
2891 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2893 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2894 * Dicts/dicomV3.dic : remove double spaces !!!
2895 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2896 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2899 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2900 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2901 method. Doxygenation.
2902 * src/gdcm.h clean up of JPR spurious comments.
2904 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2905 * python/distutilsSwigCPlusPlus.py now properly collects the
2906 shadow classes generated by "swig -c++" (gdcm.py in our case)
2907 when using "python setup.py install".
2908 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2909 reexports the working classes.
2910 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2911 by the classical C errno scheme. This is to prevent an obscure
2912 behavior of the python wrappers when importing wxPython.wx prior
2913 to gdcmPython (which ended up in an abort call). An illustration
2914 of this oddity can be found in the Test/ExceptionAndPython
2915 subdir (see the README file). This problem probably due to
2916 an combination of g++ and dynamic loading.
2917 * added Test/ExceptionAndPython (see above)
2919 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * Changed the layout of the python part to avoid bloating main
2921 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2922 i.e. the distutils arsenal. All the python related stuff is
2923 again in a python subdir, but the package itself is now in
2925 * setup.py was cleaned up:
2926 - pythonIncludePath removed
2927 - python setup.py bdist target is now functional.
2928 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2929 collision with other packages). gdcmPython/demo/*.py changed
2932 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * python subdir moved to gdcmPython (preparation of distutils packaging).
2934 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2935 distutils installer is operational.
2936 * - gdcmPython/__init__.py now properly loads the swig generated
2937 shadow classes (from gdcm.py).
2938 - gdcmPython/demo/*.py changed to import the package gdcmPython
2939 instead of gdcmPython/demo/load.py.
2940 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2942 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2944 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2945 entries within the associated public Dicom dictionary resp. the same
2946 information but sorted by the fourth field (PAT, IMG, DIR) of the
2948 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2949 are now in the "???" group.
2950 - python/gdcm.i changed accordingly,
2951 - python/demo/printGroupedPublicDict.py added, that gives an example
2952 of the above new functionalities in Python.
2954 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * src/gdcm.h, gdcmHeader.cxx:
2956 - historic references to glib's g_malloc and g_free (#defined)
2957 were definitively removed.
2958 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2959 * src/gdcmElValSet.cxx:
2960 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2961 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2962 - GetElValue(string) renamed to GetElValueByName.
2963 - Added GetElementByName(string).
2964 * src/gdcmHeader.cxx: added
2965 - GetPubElValRepByNumber(guint16, guint16)
2966 - GetPubElValRepByName(string)
2967 - GetShaElValRepByNumber(guint16, guint16)
2968 - GetShaElValRepByName(string)
2969 - GetShaElValByNumber(guint16, guint16)
2970 - GetShaElValRepByName(string)
2971 - GetElValRepByNumber(guint16, guint16)
2972 - GetElValRepByName(string)
2973 - GetElValByNumber(guint16, guint16)
2974 - GetElValRepByName(string)
2975 * Doc/requirements.txt added.
2977 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * Test/Makefile building now depends on the one of libgdcm.so
2979 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2980 pixel data) aware which enables finding the address (offset) of
2981 the pixel data of JPEG encoded DICOM files. This leaves only a single
2982 file in the testSuite whose pixel data address (offset) is unknown.
2983 * python/testSuite.py changed accordingly.
2985 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2986 * VC++ has some strong limitations when working with the STL, as stated
2987 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2988 "Also note that some STL containers (map, set, queue, list, deque)
2989 cannot be exported. [...]
2990 Some STL classes contain nested classes. These classes can not
2992 This is caused by a designed limitation that once a template
2993 class is instantiated, it can not be re-instantiated and
2995 Since our usage of map<> is ubiquitous in gdcm, this "designed
2996 limitation" of VC++ is a pitfall.
2997 Hence the Python wrappers of gdcm cannot be incrementally linked
2998 against the c++ dynamic library. The dirty but only workaround is
2999 to forget about incremental link of dynamic libraries and to generate
3000 the Python wrappers library with the inclusions of the underlying C++
3002 The following modifications concern this matter on Win32/VC++:
3003 - wrapping python correct with standalone wrapped dll (don't use separate
3004 dll under windows !!!!)
3005 - python21_d debug mode enabled (ask Frog how to use it :-)
3006 - NO problem with having an STL member of class for example string in C++
3007 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3008 - Python test of dcmlib in Python is ok under windows on a large set
3010 * removed glib references
3011 * typedef's inserted in gdcm.i for correct swig type management
3013 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * python/demo/*.py load.py extracted from test.py. Added explore.py
3015 that only displays required tags and testAll.py that parses all
3016 the files of the testsuite without using unittest.
3017 * python/testSuite.py other additional test on new files added.
3018 * Data/* new test files added accordingly to the testSuite.
3019 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3020 the vr in the file differs from the one of the dictionary.
3022 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3024 values, but limits itself to values which are below a user specified
3025 size (by default 1024 bytes).
3026 * python/gdcm.i : elements not loaded (because their size is above the
3027 user specified treshold) are exported with their TagKey as key of the
3028 python dictionary. This enables the testsuite to make some checks
3029 on the unloaded elements (since we have their offset and size).
3030 * python/testSuite.py
3031 - now tests for the existence and proper value of the pixel data
3032 - two new examples added.
3033 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3035 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3037 aware. See the strategy comments in gdcmHeader::FindeLength().
3038 * Test/test.cxx now accepts a filename as first argument.
3039 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3040 * python/testSuite.py changed to integrate test on above files.
3042 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3044 the vr was also RET.
3045 * python/testSuite.py more tests added.
3047 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * python/testSuite.py unittest test suite added (uses Data)
3049 * Data/* dcm and acr files for the test suite.
3050 * glib dependance removed from un*x version. We now use ISO C99
3051 7.18 Integer types (see stdint.h)
3052 - python/Makefile, src/Makefile src/gdcm.h
3053 * src/ when an explicit vr (like dicom files) suddenly poped an
3054 implicit element we use to mark the underlying DictEntry of the
3055 concerned ElValue with "Implicit". This strategy was damageable
3056 too the public or provite dictionaries, since some of their vr
3057 would be changed. Since Header::FindLength heavily relies on the
3058 detection by Header::FindVR of falsely explicit elements, I
3059 added an extra ImplicitVr member to ElValue (boolean).
3060 The rest of the changes we the necessary adaptations.
3062 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3065 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3067 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * Adaptation for porting to VC++:
3070 o forced to use std namespace (for string to be known)
3071 o all class use __declspec export style on WIN32
3072 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3073 (in stdlib.h on Win32 but in std:: for gcc)
3074 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3075 variable GDCM_DICT_PATH.
3076 * src/gdcmHeader.cxx verbose comments made discrete.
3078 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3079 * python/gdcm.i: added a typemap that converts a C++ hashing table
3080 to native Python dictionary.
3081 * python/demo/test.py:
3082 - now uses the native dictionary for exploration of gdcmHeader.
3083 - takes an optional filename argument (the file to parse).
3084 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3085 PubElVals hashing table.
3086 * Dicts/dicomV3.dic removed error prone trailing spaces.
3088 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * Python wrapping process moved away from src/Makefile to
3090 newly created python/Makefile (as well as gdcm.i)
3091 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3092 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3093 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3094 from the environement variable GDCM_DICT_PATH (when existing).
3095 * src/gdcmDict::GetTag bug fix.
3097 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * Straightforward temporary fixes for swig to build the python wrappers.
3099 src/Makefile now has a python working entry [by working we mean
3100 that we can import de shadow classes without errors].
3102 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * hashtest.cxx removed (since already in Test)
3104 * src/gdcmlib.h renamed to src/gdcm.h
3105 * src/dcm.i renamed to src/gdcm.i
3106 * src/Makefile prepared for python wrapping
3108 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * src/gdcmHeader.cxx :
3110 - Parsing of header is now separated from loading of element values
3111 (see gdcmHeader::LoadElements).
3112 - general clean up of hopefully all file access (creation of
3113 ReadInt16 and ReadInt32)
3115 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * src/gdcmHeader.cxx :
3117 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3119 - SetLgrElem renamed to SetLength
3120 - GetLgrElem renamed to GetLength
3121 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3122 * src/gdcmElValSet.cxx fixed both GetElValue methods
3123 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3124 due to IdoDude was cleaned out.
3126 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3128 concentrates on finding the value representation (when it exists).
3129 RecupLgr now only finds the element value length, and it avoids
3130 returning the unecessary skL (skipped length).
3131 Also, offsetCourant was simply removed (with taille_fich) since
3132 it was redundant with the File position internals (by using
3133 ftell and fseek). This also made skL (see above in RecupLgr) usage
3135 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3136 on the libido specificities which are handled through class
3138 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3141 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * Truckload of changes. Parsing of header is barely functional
3143 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3145 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3146 * src/gdcmHeader.cxx many addons of low level methods
3148 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3149 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3150 and _IdDcmSWAP_LONG.
3152 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * This corresponds to all the changes decided at the meeting of
3154 May 23 2002. Needless to say we are running late...