1 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * Add construct and destructor to class gdcm::Debug to close the debug file
4 * Don't let uset to open twice the same file
5 * gdcm has now an official UID prefix,
6 supplied by http://www.medicalconnections.co.uk
7 1.2.826.0.1.3680043.2.1143
8 (Thx to Mathieu for providing URL)
9 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
10 to be able to perform some more tests
11 * gdcm::ContentEntry : Contructors and Destructor are now protected,
12 in order to be sure no user will try to use them.
13 (at user level, only the children classes are meaningfull)
15 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * move RLEInfo & JPEGInfo from Document to File
18 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * FIX : remove so many friend between classes
21 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
23 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
25 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
26 In order to avoid missbehaviour :
27 . gdcm::DocEntry is now specialized in
28 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
29 - gdcm::ContentEntry (Dicom entry with a 'content')
30 . gdcm::ContentEntry is specialized in
31 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
32 characters value, or integers)
33 - gdcm::BinEntry (Dicom entry with a non strig representable value
34 (user hasn't any longer to thing about the precedence of his dynamic_casts)
36 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/VTKTest*.cxx : bug fix under linux
39 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
41 use with python. Some methods are moved from Document to ElementSet or
42 DocEntrySet. The equivalent methods to ElementSet have been added to
43 SQItem and are virtual in DocEntrySet. Methods that may have the same code
44 in SQItem and ElementSet is directly placed in DocEntrySet
46 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Test/VTKTest*.cxx : remove the show variable in each test method because
48 it's useless (the viewer variable replace this variable)
50 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmDocument.cxx : bug fix on potential memory leak
52 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
53 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
54 Add ClearXxx methods to remove all the content of the list or map
55 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
57 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * methods ReplaceOrCreate renamed as Insert
59 (nobody will be any longer confused by 'CreateOrReplace')
61 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 * Grealty simplify the JPEg decompression, no need to differenciate based on
63 the JPEG possible type (with/without fragment, with/without multiple frame).
64 Everything is done throught the JPEG IO Suspension mechanism in IJG
66 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
67 * Stage 3 of normalization :
68 in order to avoid any missunderstanding while reading method names :
69 - All the methods xxxEntry now deal with dicom Entries
70 - Methods GetEntry splitted into
73 - Method SetEntry renamed as SetEntryValue
74 - Method SetEntryBinArea let as it was
76 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
77 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
78 - Position correctly the entry points for JPEG2000 and JPEG-LS
79 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
81 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
83 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
84 with other method names
85 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
86 * Test/TestDicomDirElement.cxx : add new test
88 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
90 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
91 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
92 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
93 So can't you use __int64 in ostream at all.
95 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * bug fix for compilation on MSVC6
97 * gdcmPython/gdcm.i : rename of classes missed
99 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
100 * Stage 2 of names normalization :
101 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
102 (easy to understand ...)
103 - gdcm::FileHelper replaces old class gdcm::File
105 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
107 type and not a string. So, there remove problems on the format of the
110 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * Add Example/TestPapyrus.cxx
112 - reads a Papyrus file (gdcm::Header compliant),
113 - gets the pixels of all the images, using low level iterators
114 - writes an multiframes Dicom image.
115 (Just to show it's *possible* to do that)
116 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
119 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
121 Thus, DicomDirXXX are created with a flad that indicates if the created
122 object is empty or not (when not empty, the DicomDirElement is used to
125 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
127 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
129 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
132 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
134 Remove all access to the hash-tables or lists in the objects.
136 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
138 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
139 be complient with all the gdcm source code
141 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
145 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
149 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * Test/ : rename VTK tests to have a best name for the tests
151 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
152 GetFirstEntry/GetNextEntry use
154 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * In SerieHeader::ImagePositionPatientOrdering()
156 // a Dicom 'Serie' may contain scout views
157 // and images may have differents directions.
158 // -> More than one may have the same 'pos'
159 // Sorting has then NO meaning !
160 Thx to Eduardo Davila for reporting bug.
162 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
164 test. Now it's on image content and not on the resulting visualisation...
165 might solve the problem on linux when using the OpenGL drivers
167 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
168 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
169 DicomDirSerie, DicomDirImage
170 Dict, DictSet classes :
171 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
172 -remove InitTraversal method.
173 * UPD Test programs + Example programs
175 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
176 * remove useless and never updated keyword \ingroup
177 * Solve pb when structure (list, map, ...) is empty.
178 Thx to Benoit for reporting bug
180 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 * Taking into account of 'Transfer Syntax' value
182 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
185 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
187 is no memory access violation
188 * gdcmPython/demo : add python demos using VTK
190 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
191 * FIX 'Dictionnary' is now spelt 'Dictionary'
192 'wether' is now spelt 'whether'
193 'archieve' is now spelt 'archive' ;-)
195 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
196 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
197 related methods, in order not to expose internal mechanisms
200 * REM methods that exposed internal mechanisms :
201 DicomDir::GetDicomDirPatients()
202 DicomDirPatient::GetDicomDirStudies()
203 DicomDirStudy::GetDicomDirSeries()
204 DicomDirSerie::GetDicomDirImages()
205 * UPD Test programs :
209 * UPD Example program
211 * ADD DictSet methods
215 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 * Removed the Print/indent/default parameter mess. There is absolutely no
217 reason to have to methods, moreover with the second taking the ostream as
218 *SECOND* parameter. This was clearly a bad hack to get things compile.
220 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Complete rewrite of the GetMacAddress code. Now the code is *much*
222 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
223 Unfortunately the main code does not work on SunOS, thus provide a specific
224 code for this platform only (and Win32 of course). Since this seems to be
225 working, change CreateUniqueUID to use GetMACAddress instead of the
226 problematic GctestetIPAddress
228 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
229 * Unfortunately to be able to test gdcmDirList I had to break the API
230 a little. Now the class is not a std::list anymore but has a member
231 std::vector (more ITK compatible). Allow unit testing on Win32 and
234 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Update SerieHeader to take into account a Serie Instance UID to properly
238 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
239 * ENH - Comment out Mathieu's (dangerous) Super Hack
240 for dealing with BIGENDIAN processors
241 - Move equivalent stuff to BinEntry::WriteContent
242 When necessary, 16 Bits Pixels are swapped in a small buffer
243 and then written. This avoid allocating a huge buffer, in
244 PixelWriteConvertor, and avoid modifying the Pixel Area.
246 Probabely, the same operation will have to be done when we want
247 to write image with Big Endian Transfert Syntax,
248 and we are working on Little Endian Processor
250 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
253 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
254 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
255 all the dict content.
256 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
258 * Test/TestDict.cxx : add a new test for the dict classes
260 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
262 file. Debug is yanked if compiled with NDEBUG
264 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * src/gdcmDictSet.h : set the default output to the os variable
266 * src/gdcmDictEntry.[h|cxx] : add the Print method
267 * gdcmPython/demo/ : add a new test
269 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
270 * merging of Test/PrintDicomDir and Test/TestDicomDir
271 * removal of now redundant Test/PrintDicomDir
272 * enhancement of Example/PrintDicomDir
274 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * Now, python test might work on systems
276 * Add the PrintDicomDir test
278 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * FIX : First entry following group 0002 was lost for
280 Explicit Big Endian Transfer Syntax files
281 (group and elem not swaped)
283 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
284 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
285 Big Endian Transfer Syntax supposed the group following 0002
286 begins always by element 0000 (element 0000 is *optional*)
287 To avoid further troubles, let's be pessimistic, and use
288 Document::HandleOutOfGroup0002() method
289 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
290 (related pb not yet solved)
292 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * Bug fix for the python part use
294 * Now, PrintHeader.py pass... but outside the ctest use. shit !
296 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
299 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
301 a string and should ask the global TS dict what are the propreties of
304 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
305 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
306 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
307 to swap the Swap Code, at parsing time, when we come out of group 0002
308 and Transfer Syntax is Big Endian
309 We should be able to read now 'true DICOM" Big Endian coded images
310 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
311 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
313 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
314 * Hopefully fix the bug on MacOSX and static global initialization.
315 This is the only -minor- patch I found that both please MacOSX and VS6.
316 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
317 but this would require a lot of change. Another approach would be that Global
318 create those string and GDCM_UNFOUND becomes a pointer to a string (which
319 gdcm::Global would destroy at exit).
321 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Fix bug on MacOSX with static initialization in a multy threaded
323 environment. static const string in a header file used to be ill
324 initialized provoquing the freeze of any tests. patch should solve this
327 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * According to Benoit's suggestion, and without any objection from anybody
329 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
330 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
331 - method gdcmDicomDirObject::GetEntry() renamed as
332 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
334 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
336 you debug/warning message just as c++ streams which make them very convinient
337 to use. Once this is stabilize I will change the ostringstrem to be
338 redirected to a file (ofstream).
339 * Properly support C99 extension: __FUNCTION__ which allow us to display
340 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
342 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
343 * Removal of useless and dangerous methods :
344 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
345 GetDocEntryByName, GetEntryByName, GetDictEntryByName
346 * Removal of usless methods :
347 Dict::PrintByName, Dict::GetDictEntryByName
348 * Commenting out of probabely useless methods :
349 Dict::GetDictEntryNames()
350 Dict::GetDictEntryNamesByCategory()
351 DictSet::GetPubDictEntryNames()
352 DictSet::GetPubDictEntryNamesByCategory()
353 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
354 * ENH : Use dicomTS.dic as described in 2004 version
355 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
356 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
357 Add Accessors on VM (Value Multiplicity), and VM related methods
358 * ADD : Add a list of 'Dicom Attribute types', as found in
359 http://medical.nema.org/dicom/2004/04_15PU.PDF
361 * ADD : Add dicomGroupNameAbbreviations.dic
362 should be used to write a method to replace the former
363 Dict::GetDictEntryNamesByCategory()
365 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
367 to read in the file... and only it ! Length is the efective length of the
368 data in the DocEntry structure
370 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
372 And now use a static function call instead, with a global variable. i
373 This is much closer to the VTK approach. Hopefully should be bulletproof
374 and easier to use...hopefully
376 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
379 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
382 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
384 ValEntry, BinEntry, SeqEntry creation or replace
386 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
388 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
390 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
391 when specifying the VR
392 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
393 * src/gdcmDocEntry.cxx : amelioration of print
395 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
396 * ADD : Add the method Util::IsCurrentProcessorBigEndian
397 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
398 * ADD Method Document::ComputeGroupLength
399 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
400 in order to allow further VR modification by user
401 * REM : removal of once-called method File::WriteBase
402 integration of its code in formerly one-line method File::Write
404 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
406 replace the different values "??", "Unkn", "Unknown".
407 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
408 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
409 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
410 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
412 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
415 * Set the gdcm::Base class to some Printable classes
417 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * src/gdcmFile.[h|cxx] : add the Print method
419 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
420 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
421 * src/gdcmDocument.h : remove the PrintLevel informations
422 * Example/PrintFile.cxx : use the new gdcm::File::Print
424 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
426 problems when compiling with the python wrapping
428 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
430 writting in ImplicitVR
432 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
433 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
434 JPEG decompression, especially when dicom frames are split into several
435 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
436 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
438 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmHeader.cxx : change the initialisation of default header.
440 Now, this header is readable by gdm, e-film, DicomWorks
442 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
444 Rename Decompressed to Raw
445 * Use the API changes in gdcm::File.
446 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
449 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
450 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
451 each added entry in the header. Replace the 'Planes' field by the 'Number
454 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
456 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
458 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
460 At this time, this image isn't readable by e-film... waiting JPR help to
463 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
465 DocEntry. Now use methods of the Document !
467 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * Test/ShowDicomSeq.cxx : bug fix
470 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
472 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
473 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
474 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
476 * Test/TestCopyRescaleDicom.cxx : remove unused variable
477 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
478 containing found sequences
480 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
483 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
484 Some fields in BinEntry must be copied to not seg fault when making the :
485 gdcm::File *copy = new gdcm::File( copyH );
486 and tests are now made on good variables
488 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
490 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
492 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
493 * Add vtkGdcmWriter example and test
495 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * Test/TestUtil.cxx : reformat the source code
497 * vtk/vtkGdcmReader.cxx : remove and change prints
498 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
500 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
501 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
503 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
505 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
507 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
509 by an eof to prevent all bad read of the file... and in this case, the
512 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * Example/Volume2Dicom.cxx : comment unused variables
514 * Test/PrintDicomDir.cxx : comment unused variables
515 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
516 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
517 method that is redondant with AddEntry.
518 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
521 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * Bug fix due my last commit (compilation under Windows).
523 * Example/Volume2Dicom : bug fix in the file and reformatting source code
524 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
526 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
528 - Remove printf / sprintf
529 - include iostream AFTER gdcm so we don't get warnings
530 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
532 - Also remove tons of include from header files, hopefully this should
533 speeup the compilation time, since it was becoming a dog slow.
534 - Remove gdcm.h as it include way too many files and slow down compilation
535 (plus it is not up to date)
536 - remove 'using namespace std' this is BAD !
538 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * Remove memory leaks on the DicomDir
540 * Remove some useless data in DicomDirObject
541 * Add usefull methods in SQItem, to be complient withe the ElementSet
543 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
546 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
548 future, with convertion)
549 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
550 and ImageDataSize values. Remove the method to get the PixelReadConverter
551 from the output of the class
553 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
556 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
558 and vtkErrorMacro use.
559 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
561 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
564 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
565 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
566 The string leaves only in the fonction. So when we make a .c_str(), we
567 get the pointeur on the first element, element that will be destroyed
568 immediately after thee instruction.
569 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
570 file has been opened : the test must be made on the content of the
571 pointer and not directly on the pointer !
574 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
576 the python part recompiles
578 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
580 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
581 X session is killed (for my computer... it seems to not be identic on
584 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
586 avoid problems (otherwise, the difference test between the visible image
587 and the reference is incorrect. If the reference is greater than the
588 screen resolution, it's produce errors).
589 Can be used for only one image. Can be used with a visible flag.
590 * vtk/vtkGdcmReader.cxx : remove commented codes.
591 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
592 under windows at compilation
593 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
595 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
597 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
599 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
600 tests on the image size X, Y, Z
602 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
604 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
605 between the class name and the file name
607 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/ : fix compilation warnings for the Write method (2 different
609 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
610 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
611 variable... create a static method in gdcm::Document to access to
612 this variable content.
614 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
616 file, to be accessed by other files (like gdcmFile). Remove commented
617 code. Move the change of the header to the gdcmFile, using the
619 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
620 To be sure of that (and simplify calls), the Write of the header now
621 gets a file name and not a file pointer (std::ifstream).
622 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
623 DocEntryArchive. Remove all open of the written file
625 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
628 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
630 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
632 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
633 some corresponding methods. Write correctly the file and check before
635 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
636 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
637 is now on RGB data (as before my last commit
638 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
640 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
642 Add a print information of the type of the entry
643 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
644 It was in the gdcmFile, and all write have been regrouped
645 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
646 Write correctly all dicom files (in decompressed mode only at this time)
647 * Test/ : test on files are now made using Raw data and not color data if
649 * Example/PrintFile.cxx : add more printings
651 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * Amelioration of code, remove some code copy. For the loading of
653 BinEntry (in gdcmDocument), add the test to verify if the file is already
656 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
658 remove a DocEntry in the header (push an empty DocEntry)
659 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
660 lines. Bug fix in the initialization of the PixelConvert and the
662 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
663 use in TestCopyDicom (now this test can run under windows... but fails)
664 * Test/TestCopyDicom.cxx : amelioration of the test :
665 - test the pixels written
666 - add test points to quickly find where is the error
667 - can set a file name input and output in arguments
668 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
669 amelioration of the test output
671 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
673 all replaced DocEntry's
674 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
675 Now, each needed DocEntry to modify is duplicated, modified and inserted
676 to the header using DocEntryArchive. Thus, after save, we can restore the
677 header initial state.
679 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
682 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
683 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
684 correct to copy it. The DictEntry is specified at the DocEntry creation,
685 then, it musn't change in the time.
686 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
687 header correctly. At this time, the change is only made for the first
688 level of the Document. In the future, it might consider sequences.
689 The change is made by replacing a DocEntry by an other that is created
690 outside the class. The old value is kept. When we restore the header
691 status, the added DocEntry is deleted and replaced by the old value.
692 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
693 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
694 set the write type to explicit VR, implicit VR or ACR. Add methods to set
695 the write mode to native, decompressed or RGB (but not used at this time)
697 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
699 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
701 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
703 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
705 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
706 set because already copied when copying the BinEntry's of the header
707 * Test/TestAllReadCompareDicom.cxx : remove warnings
709 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
711 Two problems appear when doing it :
712 - with the gdcmFile : when the GetImageData method is called, the pixels
713 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
714 data (pixels). And each structure destruct the data when it's
715 destructed. So we have two destructions for the same data. To solve it,
716 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
717 data or not. If it doesn't own data, then they will not destroyed by
719 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
720 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
721 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
722 create a double destruction of the same DocEntry's. So, to solve it,
723 the TagHT is simply cleared and the DicomDir* elements are destroyed.
724 * TODO : add an entry concerning memory leaks in the DicomDir
726 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
728 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
731 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
733 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
734 after it have been deleted
736 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * FIX: src/* fix the doxygen warnings.
738 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
739 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
740 was erroneously defined with a size of 15 instead of 16. [many thanks
741 to Jean Michel Rouet for pointing out this bug].
743 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
744 1. Finish merging JMR patch for writting DICOM from scratch
745 2. Fix -hopefully- bug with MONOCHROME and space vs null character
746 3. Use const ref when possible
747 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
748 5. A few more comments
749 6. CreateUniqueUID can now be called without parameter"
751 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
752 * ENH: Slightly bigger patch:
753 1. Getting toward full integration of JMR patch for writting dicom from scratch
754 2. Update Test to test part of this patch: CreateUniqueUID
755 3. File was not close properly in gdcmDict
756 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
757 5. Use of const ref instead of copy (speed issue)
758 6. Remove temporary (duplicate) string in TranslateToKey
759 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
760 8. Do not repeat virtual in subclasses
761 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
763 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
764 * Apply first patch toward better string comparison when dealing with broken
765 DICOM files. Essentially the string could be padded with a space instead
766 of a null character as defined by standard
768 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
769 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
770 because never used... and in the same time, that's remove some memory leaks
772 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/gdcmFile.cxx : now delete the PixelConvert instance.
774 * In examples and tests : change the type of image data variables from void*
775 to uint8_t*. Remmove all delete on image data variables
777 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
779 Verify the file pointer value before open the file, and if it's not null,
780 a verbose message is generated.
781 Close correctly the file when the file isn't considered dicom-like. The
782 correctly close is a call to CloseFile.
783 When closing the file pointer, test if its not null to close the file.
784 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
785 file. For an uncompressed image, the copied data correspond in the least
786 case to the image size (calculated) or the image size specified in the
787 header. A verbose is generated if these two size mismatch
789 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
790 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
791 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
792 break under windows (with msvc6 compilation).
794 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
795 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
796 compiling with MSVC6)
798 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * Bugs fix for the Windows build with VC6
800 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
801 needed (only for projects required VTK). If the VTK is included in all
802 projects, there is conflicts with the jpeg lib of vtk when compiling the
803 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
804 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
805 when compiling the gdcm_wrap.cxx file (created by the compilation of the
807 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
808 (like it's already made for the cout use). Otherwise, conflict with the
811 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
814 - comments on the DicomDir::Method related usage added.
815 - now that we use the namespace gdcm, a lot of internal classes do
816 NOT need to be wrapped anymore.
817 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
818 DicomDir::Method) new example added.
820 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
821 * Improve string manipulation. I now inforce the notion of 'DicomString'
822 A DicomString can contain as many \0 as they want
823 and it is *always* of even length.
824 We only support odd length for very rare case.
825 And in the near future this should be removed.
827 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
828 * /binary_write/ gdcm source. Now even on big endian we are writting
829 little endian. This should -heopfully- fix some tests
831 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
832 * Now the dictionary is compiled into gdcm lib. This is a default
833 behavior, thus any dic file specified is picked before failback to
834 the one comiled into lib
836 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
837 * Change internals for gdcmDict. Don't use any 'new' any more.
838 This should definitely solve any leak problem, and we should be
839 as fast as before, as long as don't modify too much the dictionary.
841 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * STYLE: ivars should start with a capital letter.
843 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
844 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
846 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
848 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
849 new 2004 dictionaries added (thanks to JPR).
850 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
851 * CLEANUP_ROUND (15) for gdcmPixelConvert
852 - RLEFrame::NumberFragments is now of type unsigned int
853 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
854 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
857 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
858 * Initial work in gathering all transfer syntax accessors. clearly
859 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
860 ivars, but only one transfersyntax (class) ivar with equivalent method on
863 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
864 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
865 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
866 discussed (plus I didn't like having a 2000 lines patch not commited)
868 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
869 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
870 * CLEANUP_ROUND (14) for gdcmPixelConvert
871 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
872 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
873 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
875 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
876 anymore and hence avoids storing a copy of PixelConvert::Decompressed
877 into File::Pixel_Data.
879 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
881 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
882 * CLEANUP_ROUND (13) for gdcmPixelConvert
883 Substituted File::ParsePixelData() with PixelConvert::Print() new
885 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
886 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
887 method to those classes.
888 - src/gdcmFile.[cxx|h]:
889 -- Added a ::Print() method.
890 -- PixelConverter is now a reference instead of a member.
891 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
892 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
894 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
896 collaboration diagram and inheritance diagram should be generated with
898 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
899 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
900 pointlessly wrapped (see
901 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
902 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
903 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
904 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
905 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
906 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
907 -- File::Initialise: PixelConverter setup moved away to
908 PixelConverter::GrabInformationsFromHeader()
909 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
910 interpretation moved away to PixelConverter::BuildRGBImage()
912 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
914 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
916 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
917 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
918 displayed on Win32 when a brutal abort() occurs (because of uncatched
919 exception). See TODO new entry of this commit for more on this.
920 * TODO added new entry.
921 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
922 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
923 - HandleColor is no longer called from gdcmFile.cxx
924 - gdcmPixelConvert.cxx clean up on method arguments and internal
925 variable names for semantical coherence.
927 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * Finished lossless transition, not only do we now read all lossless jpeg
929 images, without the need of the Cornwell lib, but we do read them properly now
930 * To reduce code (well to avoid code duplication), I defined a common place
931 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
932 redefine symbols. This is not perfect but this the best solution I found for a
933 compilation time jpeg option.
935 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * Update jpeg ijg lib to support lossless jpeg implementation
937 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
939 * Also added a special copyright for dcmtk since we use their bugfixes.
942 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
944 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
945 matters, as stated in warning note at begining of %include section).
946 * src/gdcmDicomDir*.[cxx|h]: coding style
947 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
948 * src/gdcmJpeg8.cxx: doxygen fix.
949 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
950 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
951 from File:: to PixelConvert::.
953 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
955 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
956 - more code moved away from File:: to PixelConvert::
957 - fat setup of PixelConverter set in place in File::Initialise.
959 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
960 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
961 namespace at the file system level. So now you should convert your examples
963 gdcmHeader -> gdcm::Header
964 It would be nice if people keep in mind to no open the namespace, since it
965 allows compilation on broken plateform which were defining common symbol in
966 the standart namespace (like LP, Unknown ...)
968 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
970 The JPEG fragments are now parsed at the same stage than the RLE
971 information. All code related to JPEG is now in gdcmPixelConvert:
972 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
973 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
974 export a gdcmFile:: method. Those are simply global functions
975 (for the time being this is better than having them attach to
976 either gdcmFile:: or gdcmPixelConvert::).
977 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
978 and stores the result in a gdcmJPEGFragmentsInfo.
979 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
980 code (among other stuff) moved away from gdcmFile:; to
983 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
984 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
985 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
986 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
987 clean up of RLE related code.
988 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
989 - src/gdcmRLE.cxx removed
990 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
991 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
992 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
993 * CLEANUP_ROUND (9) for gdcmPixelConvert
994 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
995 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
996 away from gdcmFile:: to gdcmPixelConvert::.
998 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1000 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1001 This is because Parse7Fe0 used to parse the pixels to compute the
1002 length. This task was passed over to FindDocEntryLengthOB() a long
1003 time ago, EXCEPT I had forgotten the OW case...
1004 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1005 we just recylce the code for parsing RLE fragments and computing
1007 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1008 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1009 with the retired Parse7Fe0().
1010 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1011 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1013 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1015 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1016 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1017 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1018 * CLEANUP_ROUND (4) for gdcmPixelConvert
1019 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1020 to return an unused length.
1022 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1023 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1024 this should be cleanner from the plane view. The iostream are erally a pain
1025 to use to do simple stuff.
1027 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1028 * Redo the compilation of the ijg jpeg library. Now only one source is
1029 necesseray. No need to rename file by hand what so ever. CMake handle the
1030 copying of the file within different directory, configure header file to
1031 modify some symbol. The only addition made to ijg wasd a mangle table so
1032 that symbol are different whether we are within 8bits or 12bits.
1034 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * Added documentation of vtkgdcmReader on Website:
1036 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1037 with it's binary name).
1038 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1039 the Website to be more complete.
1040 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1041 doxygenated documentation.
1042 - Doc/DoxyVtkGdcmReaderExamples.txt added
1043 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1044 DoxyVtkGdmReaderExamples.html )
1045 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1046 * CLEANUP_ROUND (3) for gdcmPixelConvert
1047 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1049 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * CLEANUP_ROUND (2) for gdcmPixelConvert
1051 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1053 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * CLEANUP_ROUND for gdcmPixelConvert:
1055 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1056 - src/gdcmPixelStuff[h|cxx] removed
1057 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1058 - src/CMakeLists.txt changed accordingly
1059 * GDCMHOME clean up:
1060 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1061 gdcmVersion.py moved to newly created ATTIC related
1062 gdcmPython/SetupOldies/ directory.
1063 * Autotools clean up:
1064 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1065 - autogen.sh configure.in acinclude.m4 python.m4 removed
1067 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1069 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1070 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1072 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * TODO updated with Mathieu suggestions. I proposed a template for
1074 describing TODO entries and used it for new entries.
1075 * Added Doc/Website/CodingStyle.html, Developpers.html,
1076 DeveloppersPython.html, GdcmDataCvs.html and
1077 DownloadVersion0_1.html, DownloadVersion0_3.html.
1078 * Some Doc/*.txt Doxygen files (which do not really concern the
1079 documentation itself, but the website) moved to html and
1080 placed in directory Doc/Website:
1081 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1082 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1083 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1084 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1085 * CMakeLists.txt changed accordingly.
1086 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1087 DeveloppersPython.html
1088 * INSTALL nows refers to Doc/Website/Installation.html
1090 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * Added Doc/Website directory, that contains a first raw version
1094 2004-09-23 Jean-Pierre Roux
1095 * FIX In order not to be poluted any longer by casting problems,
1096 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1097 we can now delete[] it safely
1098 * VoidArea is now called BinArea (less confusing name),
1099 and all the methods called ...VoidArea... are now ... BinArea...
1100 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1102 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1104 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1105 up to the destructor of gdcmElementSet to clean up TagHt and it's
1108 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1110 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1112 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1113 * ENH: added some utility method that builds a flat dictionary
1114 holding all the Dicom entries contained in the recursive structure
1115 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1116 an example of usage.
1117 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1118 BuildFlatHashTable() that build a flat dictionary.
1119 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1120 gdcmDocument is now a friend of gdcmElementSet.
1121 - src/gdcmElementSet.cxx: clean up.
1122 - Example/FlatHashTablePrint.cxx added.
1123 - Example/CmakeLists.txt changed accordingly
1125 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1127 moved away from gdcmDocEntrySet (since this class is an abstract class
1128 acting like an interface). SQDepthLevel and BaseTagKey are now
1130 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1131 and associated accessors. Doxygenation of the class.
1132 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1134 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1135 Use SQDepthLevel accessor instead. ::Print() adapted.
1136 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1137 - src/gdcmDocument.cxx changed accordingly.
1139 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1141 - The following is the doxygen comment of the typedef declaration
1142 of gdcmTagKey in src/gdcmCommon.h:
1143 gdcmTagKey is made to old an "universal" (as in URL, Universal
1144 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1145 A dicom tag always has a group and an element, but a set of tags
1146 embeded in various (optionally nested) sequences and sharing
1147 the same group and element all share the same (group, element)
1148 "identifier". Hence the (group, element) cannot be used as an
1149 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1150 In order to construct a proper tag identifier (i.e. a key) we
1151 consider the following definition of a TagKey:
1152 - let Group, Element be the string representation of the
1153 group and element dicom tag members,
1154 - let ItemNumber be the string representation of the integer
1155 index of the considered item number of a sequence,
1156 Let the key of a tag embeded in a sequence, noted SeqTag, be
1158 /ItemNumber#Group|Element
1159 where "/", "#" and "|" are characters acting as separators.
1160 Then the general form of a gdcmTagKey is given by:
1161 Group|Element<SeqTag>
1162 where <SeqTag> means NO or many instances of SeqTag.
1163 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1166 but the gdcmTagKey of a tag "embeded" is the first item of
1167 a sequence, itself nested in the third item of a sequence is the
1169 0004|1220/2#0008|0082/0#0008|0090
1170 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1171 order to hold the new sequence compatible key. Previously, the
1172 GetKey() method would look in the underlying gdcmDictEntry.
1173 - src/gdcmDocEntry.cxx:
1174 -- constructor now copies the underlying DictEntry key, in the local
1176 -- ::Print: displays the member Key, instead of the (group, element).
1177 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1178 - src/gdcmDocEntrySet.h:xi
1179 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1180 -- now has a new BaseTagKey member.
1182 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1183 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1185 This poses the problem with the semantics of the following lines
1186 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1187 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1188 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1189 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1190 to the long FIXME note for what the problem is. Nevertheless in
1191 order to get things working the dicom dictionary was altered !
1192 Please fix things urgently...
1193 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1194 information), see above note on moving the member VoidArea. Nevertheless
1195 the following entries previously correctly set as US are now inproperly
1197 0028 1201 OW IMG Red Palette Color Lookup Table Data
1198 0028 1202 OW IMG Green Palette Color Lookup Table Data
1199 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1200 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1201 of gdcmDocEntry moved to gdcmSeqEntry.
1202 * src/gdcmSeqEntry.cxx: STYLE.
1204 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1207 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * gdcmPython/testSuite.py: all the test suite in python is now moved
1209 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1210 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1211 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1213 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1215 to avoid inclusion recursion until STL is reached.
1216 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1217 mecanism. errno.h is not included in gdcm anymore.
1218 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1219 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1221 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1222 gdcmData/TestAllEntryVerifyReference.txt
1223 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1224 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1225 exception_on_error parameter.
1226 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1227 - vtk/vtkGdcmReader.cxx changed accordingly,
1228 - Example/*.cxx and Test/*.cxx changed accordingly.
1230 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1232 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1233 enable_sequences removed from gdcmHeader constructor and dependencies.
1234 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1235 * gdcmPython/demo/PrintHeader.py: dummy fix.
1236 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1237 skip_shadow removed from gdcmHeader constructor and dependencies.
1238 * Example/*.cxx and Test/*.cxx changed accordingly.
1240 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1241 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1242 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1244 2004-07-21 Jean-Pierre Roux
1245 * FIX Now, Parsing and Printing a DICOMDIR do work!
1246 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1248 2004-07-20 Jean-Pierre Roux
1249 * FIX Some brain damaged headers have Zero-Lenght fields
1250 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1252 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1253 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1254 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1255 variable (instance of gdcmDebug) by a definition macro, and the instance
1256 is now in static in the gdcmDebug class
1257 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1258 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1260 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * WARNING: ctest now depends more tightly on gdcmData. You should
1262 check out gdcmData properly for things to run smoothly...
1263 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1264 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1265 we need the pixels not be loaded in order to use the ValEntry
1266 that displays position and size).
1267 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1268 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1269 be deprecated. If you have any doubts about the advantages of a
1270 modern scripting language (read Python) versus grass root C++ (i.e.
1271 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1272 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1273 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1274 Anyhow, consider documenting the gdcmData images in
1275 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1277 * Test/CMakeLists.txt:
1278 - now uses TestAllEntryVerify.cxx
1279 - specific comments on oldACR00001.ima (now renamed in gdcmData
1280 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1281 gdcmData/TestAllEntryVerifyReference.txt
1284 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1285 * src/*.[h|cxx] : typedef clean up
1286 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1287 - TagKey renamed to gdcmTagKey (for external usage)
1288 - VRKey renamed to gdcmVRKey (for external usage)
1289 - removal of typedef duplication.
1290 - Removed all unecessary inline keyword from class inline definitions.
1291 - Some method|function(void) declarations replaced with method|function().
1292 * src/jpeg/libijg12/jdhuff12.c:
1293 - printf polluting ctest removed.
1294 - TAB removal for comminting
1296 - TestAllReadCompareDicom.cxx: added a test that compares all the
1297 images in gdcmDataImages.h with corresponding images in
1298 gdcmData/BaselineDicom/. When baseline images are not present
1299 this test creates them.
1300 Note: we need to validate each reference image, but before that
1301 I'd like to rename them with a more explicit name...
1302 - CMakeLists.txt: changed accordingly.
1303 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1304 including each header needed).
1306 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1307 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1308 test suite to the Example directory. Are concerned:
1313 - TestWriteSimple.cxx
1314 * Test/CMakeLists.txt: added some comments on reasons for black listing
1315 image gdcmData/oldACR00001.ima
1317 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1318 * Test/CmakeList.txt: removed the following from black list (to be coherent
1319 with removal from gdcmData):
1320 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1321 - gdcm-MR-PHILIPS-16.dcm
1323 Added the following because after last cvs update, they cause
1324 ctest -R TestReadWriteReadCompare
1326 - gdcm-MR-SIEMENS-16-1.acr
1328 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1329 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1330 new comments in this file) we temporarily (sigh) move to a weaker
1332 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1333 we don't need to black list the following images anymore:
1334 - 8BitsUncompressedColor.dcm
1336 - US-PAL-8-10x-echo.dcm
1337 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1338 fixes and the beautified code ;-)
1339 This fixes the bug introduced in version 1.42 (when beautifying)
1340 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1341 Note: ctest was blind to this bug (this means we need to still
1342 improve the test suite). The bug could be detected by using
1343 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1345 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1346 and by displaying the (garbage) produced file temp.XDCM...
1348 2004-06-29 Jean-Pierre Roux
1349 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1350 - replace by uggly but working old code :-(
1351 A lot of things should be OK again.
1352 It's really urgent to have a test suite that *tests*,
1353 to prevent Frog's beautifying sessions to break all the stuff
1354 (twice, withing a fortnigh ...)
1356 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1358 redundancy) to added Test/TestReadWriteReadCompare.cxx
1359 * Test/CmakeList.txt: because the compare test of
1360 Test/TestReadWriteReadCompare.cxx fails, the following images are
1361 black listed: - 8BitsUncompressedColor.dcm
1363 - US-PAL-8-10x-echo.dcm
1364 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1365 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1366 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1367 and ad-hoc kludge. This kludge is now removed, and on encountering
1368 such an image (OB field brain damaged) we set errno. Then in
1369 ::FindDocLength() we "fix" the length as being ALL what remains
1370 in the file (until EOF). We then proceed, hoping for the best...
1371 This fixes a SegFault in ShowDicom when trying to write such an
1373 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1374 (because TestWriteRead breaks on it, after a non conformal commit?).
1375 ctest now runs properly, except for MakeDicomDir (which was always
1376 broken) and the Python related stuff (still not fixed).
1378 2004-06-24 Jean-Pierre Roux
1379 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1380 FIX : Test/TestReadWrite now iterates on all the file names
1381 (instead of infinite loop)
1382 ENH : Test/TestWriteRead now iterates on all the file names
1384 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1387 2004-06-24 Jean-Pierre Roux
1388 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1389 when SamplesPerPixel =3
1390 - now Write is no longer confused by
1391 'BitsAllocated = 12" and 'BitsStored=12"
1392 - "UN" value representation Elements are now written correctly
1393 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1394 ENH : - now gdcmHeader has its own Write methods
1395 (in order to split the job that has not to be done
1398 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1399 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1400 loop on the same image until memory went out.
1401 Note: this means we still have gobs of memory loss in PrintDocument
1402 * src/gdcmDocument.cxx: fixes problem on parsing on file
1403 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1405 2004-06-24 Jean-Pierre Roux
1406 FIX : Write - All the Sequences and Sequence Item are now written
1407 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1408 is added a the end, when necessary.
1409 - A lot of brain-damaged images, that were read correctly are
1410 now written correctly
1411 - length compatible BinEntry are now loaded correctly
1412 (even for odd groups)
1413 Note : only Explicit Value Representation was checked.
1414 (question : is implicit VR really necessary for gdcm ?)
1416 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * DEVELOPPER: added a proposition of coding style.
1418 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1421 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1423 Use the gdcmDocEntry::Print() and Write() instead.
1424 * src/gdcmDocument.cxx: bug fix.
1426 2004-06-22 Jean-Pierre Roux
1427 FIX : gdcmDocument.cxx
1428 - Now we do recognize the JpegLossLess format (there was a misstyping in
1429 code 'beautyfication' :-(
1430 - Now we automaticaticaly load the Luts, if any
1432 2004-06-22 Jean-Pierre Roux
1433 In order : to write Sequences, whatever their imbrication level,
1434 : to allow user to create his own Sequences
1435 a lot of modif where necessary (adding, moving, or virtualising methods)
1437 WARNING : save your own sources *before* cvs up !
1440 ADD virtual void Write(FILE *fp, FileType filetype);
1443 ADD virtual void Write(FILE *fp, FileType filetype);
1444 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1447 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1448 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1449 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1450 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1451 ADD std::string GetEntryByName(TagName name);
1452 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1454 std::string vr = "unkn",
1455 std::string fourth = "unkn",
1456 std::string name = "unkn");
1457 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1458 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1459 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1460 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1461 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1462 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1463 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1464 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1467 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1468 ADD virtual std::string GetEntryByName (TagName tagName);
1469 ADD virtual std::string GetEntryVRByName (TagName tagName);
1470 REM virtual bool Write(FILE *, FileType);
1471 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1472 FILE *_fp, FileType type);
1473 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1474 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1475 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1476 REM virtual std::string GetEntryByName (std::string tagName);
1477 REM virtual std::string GetEntryVRByName (std::string tagName);
1478 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1479 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1480 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1482 std::string vr = "unkn",
1483 std::string fourth = "unkn",
1484 std::string name = "unkn");
1485 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1486 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1487 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1488 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1491 ADD virtual void Write(FILE *fp, FileType filetype);
1494 ADD virtual void Write(FILE *fp,FileType filetype);
1497 ADD virtual void Write(FILE *fp, FileType filetype);
1498 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1499 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1500 REM std::string GetEntryByName(TagName name);
1503 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1505 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1506 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1507 The default constructor invoked by the line
1508 gdcmHeader *f1 = new gdcmHeader( header );
1509 was gdcmHeader::gdcmHeader(bool) instead of the expected
1510 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1511 Hence the parsing wasn't executed... See also below.
1512 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1513 as explicit constructor didn't do the trick to fix the above problem.
1514 Could anyone explain why ?
1515 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1516 properly calls gdcmValEntry::Print() (that was weed out from
1517 code related to gdcmBinEntry).
1519 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * In order to fix memory leaks:
1521 - Test/TestWriteSimple.cxx: added cleaning of free store through
1523 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1524 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1525 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1526 (through the call to ::AddDicomDirMeta()) or the destructor
1527 would crash when deleting uninitialized ::metaElems].
1528 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1529 - src/gdcmDocument.cxx:
1530 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1531 from dynamic stores.
1532 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1533 was causing memory leaks.
1534 - src/gdcmSQItem.cxx:
1535 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1536 cleanly handled with polymophism: sorry but my milage is low).
1537 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1538 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1539 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1540 This avoids SegFaulting.
1541 - src/gdcmSQItem.h: coding style.
1543 - Test/TestWriteSimple still severely sucks. The output image content
1544 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1545 damaged when displayed with vtkgdcmViewer.
1546 - on memory leaks: TestWriteSimple leaks really less (see entry
1547 of 2004-06-18 in Changelog file for the call to valgrind).
1548 - on segfaults: ctest now passes all the tests but one (no more
1550 * Erroneous leading white fix:
1551 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1552 white[s] (as opposed to from >> xxx, that removes it [them].
1553 - src/gdcmTS.cxx: ditto.
1554 - gdcmPython/testSuite.py: dirty related kludge removed.
1555 * src/*: remaining references to gdcmParser removed.
1556 * src/*[cxx|h]: added copy[way]left header.
1559 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * In order to fix writing of dicom files:
1561 - Test/TestWriteSimple.cxx: a simpler example of writing.
1562 - Test/CMakeLists.txt changed accordingly.
1563 - src/gdcmDocument.cxx:
1564 -- The destructor now recursilvely removes potential sequences.
1565 -- Bug fix in ::IsJPEG2000()
1566 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1567 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1569 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1570 to only declared) and build on top of
1571 ::GetDocEntryByNumber(guint16, guint16).
1572 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1573 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1574 for usage in destructor and treatement of promotion in
1575 ::ReplaceOrCreateByNumber().
1576 - src/gdcmSQItem.cxx: destructor should better handle his job.
1577 Test/TestWriteSimple now runs (or at least it DOES something).
1578 * We can now start hutting memory links. A good starting point is:
1579 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1580 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1581 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1583 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1584 * Valgrind note: after Mathieu Malaterre teached me how to read
1585 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1587 Using gcc, you can force the STL to use malloc and to free memory as
1588 soon as possible by globally disabling memory caching.
1589 With 3.2.2 and later, you should export the environment variable
1590 GLIBCPP_FORCE_NEW before running your program.
1591 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1592 simply vanish (it is still not clear to me, whether this means that
1593 STL std::string leaks or if valgrind believes it leaks...).
1594 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1595 running bin/gdcmTests makeDicomDir):
1596 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1597 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1599 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1600 SegFaulting (I drowned in DicomDir related code when trying to
1601 understand why the list is empty...).
1602 * src/gdcmDocument.h: first BSD license header try.
1603 * Doc/License.txt added.
1605 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * src/gdcmDocument.[h|cxx]:
1607 - Clean up of the Transfer related predicates. They are now all based
1608 on new method isGivenTransferSyntax, that (should) handle properly
1609 the padding problem.
1610 - general clean up, simplification, and coding style.
1611 - Specific clean up of Parse7FE0() (umproperly named actually).
1612 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1614 2004-06-14 Jean-Pierre Roux
1616 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1617 - fix the display of SQItem ordinal number
1618 - add the GetSQItemByOrdinalNumber method
1619 - remove some useless never written private methods
1621 2004-06-14 Jean-Pierre Roux
1623 - adding a constructor taking a gdcmDocEntry as an input param
1624 - ReplaceOrCreateByNumber now returns :
1625 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1626 a gdcmValEntry * if a string value is passed as a param
1628 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1629 according to the param type (no longer sets a gdcmDocEntry)
1630 - GetValEntryByNumber, GetBinEntryByNumber added
1631 - NewValEntryByNumber and NewBinEntryByNumber added
1633 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1635 - GetSQItemNumber and SetSQItemNumber added, to provide
1636 a (relative) Item identier inside a given Sequence
1637 \warning : some pb remaining around this number
1639 - AddEntry now takes the Item Number as a param
1641 - adding a constructor taking a gdcmDocEntry as an input param
1643 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * Memory leak hunt with the following command:
1645 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1646 --show-reachable=yes gdcmTests PrintDocument
1647 It looks like many (all?) leaks are due to the STL (or a bad usage
1648 of the STL. The lines producing the leaks now have a comment with
1649 a "MEMORY LEAK" tag: you can retrieve them with
1650 grep "MEMORY LEAK" src/*
1651 Here are two typical examples which I can't help fixing:
1656 char * test = "babo";
1657 name = test; //// <--- valgrind detects 960 bytes lost in
1658 //// call to std::string::operator=(char const*)
1659 name.clear(); //// Doesn't help !
1667 std::cout << "Type a bunch of characters followed by RETURN: ";
1668 getline(std::cin, line); //// <--- valgrind dectects a loss
1669 //// of 1320 bytes in call to
1670 /// std::basic_istream<>& std::getline<>
1676 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1677 * src/gdcmHeader.[cxx|h]:
1678 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1679 and related, moved away to gdcmDocument.
1680 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1681 the corresponding protected accessors of inherited class
1682 gdcmDocument, removed ! As a consequence gdcmFile had to be
1683 declared friend of class gdcmDocument (see below).
1684 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1685 - Clean up of undefined or unused methods.
1686 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1687 account the changes to gdcmHeader.h).
1688 * src/gdcmDocument.h:
1689 - gdcmFile is now a friend class (in order to take into account the
1690 changes to gdcmHeader.h).
1691 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1692 (see changes to gdcmHeader.h).
1693 - Accessors (reading on the form GetEntry*) are now public.
1694 - Clean up of undefined or unused methods.
1695 * src/gdcmDocument.cxx:
1696 - adaptation to changes to gdcmDocument.h
1697 - ::OpenFile now writes a verbose message when file cannot be opened.
1698 - some std::string properly set to VRKey
1699 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1700 references to gdcmDocument.
1701 * Test/TestFindTags.cxx: changed accordingly to above changes.
1702 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1703 cvs repository gdcmData.
1705 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1707 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1708 conflicts with gdcmValEntry::voidArea.
1709 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1710 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1711 Value representation between StringRepresentable and BinaryRepresentable.
1712 * src/gdcmDocument.cxx:
1713 - method ParseDES: proper indentation restored and usage of
1714 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1715 - method LoadDocEntry: the fingerprint left in the SetValue() of
1716 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1717 removed. Reverting to previous code segment with the proper
1718 dynamic_cast< gdcmValEntry* >.
1719 Note: this was (partially) breaking the python test suite
1720 (gdcmPython/testSuite.py) that made usage of the above
1721 fingerprint to check presence of "Pixel Data".
1722 * src/gdcmDocEntry.h: coding style.
1723 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1724 now taken into account.
1725 * gdcmPython/gdcm.i: adaptation to the new internal representation
1726 of gdcm (exit gdcmParser, hello gdcmDocument).
1727 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1729 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1730 anymore, but instead prints the loaded Python dictionary.
1731 * .... alas, the python testSuite is still broken.
1733 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1734 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1736 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1737 * src/gdcmUtil.h : export methods
1739 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1742 * Initial addition of automatic python testing
1743 * Initial addition of automatic image comparison
1745 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1746 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1747 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1749 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1750 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1751 * Test/ShowDicom.cxx : bug fix for msvc compilation
1752 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1754 2004-05-04 Jean-Pierre Roux
1755 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1756 new concepts (and new classes) :
1757 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1758 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1759 - Sequence Doc Entries (gdcmSeqEntries)
1760 a Sequence is composed of Items.
1761 Each item is a set of Doc Entries (this is recursive)
1762 The non uniqueness of the 'Dicom tag' is due to this recursivity
1763 (never taken into account)
1764 Our unability to add a new 'entry' in the header
1765 at the proper location (neither in the H-Table (map or multimap),
1766 nor in the Chained List is also due to this recursivity.
1767 Don't try, right now, to use/modify/compile these new sources :
1768 nothing is finished.
1769 We just commit all the stuff, 'as is', in order not to loose it.
1771 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1772 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1774 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1775 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1776 file prefix (SetFilePrefix)
1778 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * Add a new test: ShowDicom, for now this is just the c++ version of
1780 checkRead.sh, later it will be able to compare the image read against a
1782 * Replace the DEBUG on the stack with a global entry in cmake interface:
1783 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1785 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1786 * Add an example subdir, with a real example on how to read + write a
1789 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1790 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1791 * Doc/CMakeLists.txt: the main page is now properly differentiated
1792 between the developper and user version.
1793 * Doc/doxygen.config.in: dropped search related obsolete flags
1794 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1796 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * DEVELOPPER: added some helpfull comments for compile/test/install
1800 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1801 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1802 src directory, now generated in the build dir.
1803 2. Tests as mentionned smarter
1805 4. Add a new method in gdcmDict that return the PubDict by name
1806 this is interesting for 3rd party lib like ITK,
1807 where we could set the institution name / patient name...
1809 * ENH: 1. Now the test suite is working for real
1810 2. All binaries are now output in the gdcm-bin directory
1811 (this was not true before)
1813 2004-04-28 Jean-Pierre Roux
1814 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1815 SeQuence indented printing of Dicom Header.
1816 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1817 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1818 Computation of SQDepthLevel is now part of gdcmHeader constructor
1819 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1820 tree-like structure of a Dicom Header.
1821 * FIX Test code cleaning
1823 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * ENH: Adding automatic testing
1825 1. Need a DartConfig.cmake to submit to public
1826 2. Add a test driver gdcmTest.cxx
1827 3. gdcmTestMain, an helper for the main test driver gdcmTest
1828 4. Files in Test don't have a main anymore, this becomes interesting
1829 when we add more and more tests, thus dsw don't have to load
1831 * ENH: Adding a GDCM_DATA_ROOT for testing
1832 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1833 one file instead of seven + some small cleanup
1835 2004-04-22 Jean-Pierre Roux
1836 * ENH Minor changes to the Print() methods.
1837 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1838 Header printing. Example given with :
1839 > PrintHeader fileName 2 new
1840 (SQ based tree-like structure still to be done for the Header ...)
1842 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1844 1. I have added some unsigned where needed
1845 2. Some function parameter not used -> (void)
1846 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1847 4. g++ don't like character '\' in comment
1848 5. #define jpeg_create_decompress jCreaDecompress
1849 this really need to be fixed
1850 6. virtualize destructor of gdcmObject ... leakage
1851 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1852 this also really need to be fixed
1853 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1854 remove compression file
1855 (as we only do decompression, right ?)
1856 * ENH: Change malloc/calloc/free with c++ equivalent
1858 2004-04-21 Jean-Pierre Roux
1859 * FIX gdcmHeaderHelper::GetXSpacing
1860 when a single value is found (bug ?), xpacing is now
1861 defaulted to yspacing
1863 2004-04-19 Jean-Pierre Roux
1864 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1865 * ENH add parameters :
1866 bool exception_on_error = false,
1867 bool enable_sequences = false,
1868 bool ignore_shadow = false
1869 to the gdcmFile constructors to be full gdcmParser compliant
1870 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1871 to allow reading of PAPYRUS 3.0 files
1873 2004-04-06 Jean-Pierre Roux
1874 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1876 2004-04-02 Jean-Pierre Roux
1877 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1878 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1879 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1881 2004-03-30 Jean-Pierre Roux
1882 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1883 for ACR file, written out as DICOM files (hope so...)
1885 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1886 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1887 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1888 moved to base class gdcmParser and only the specialisation is kept
1890 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1891 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1892 already does the job.
1893 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1894 (to be consistent with gdcmParser::WriteEntries).
1896 2004-03-30 Benoit Regrain
1897 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1898 upate of the object's instance. It's passed to 2 in the unfavorable
1899 case : one in the ExecuteInformation, one in the ExecuteData
1901 2004-03-29 Jean-Pierre Roux
1902 * ENH : Check on file type to be written moved
1903 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1904 * FIX : gdcmObject::ResetBoundaries now stops properly
1905 when end-of-list is reached
1906 : gdcmVersion modified (as Benoit Regrain asked)
1908 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1909 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1910 * src/gdcmUtil.cxx: added forgotten iostream include.
1911 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1912 equivalent to ExplicitVR in existing code).
1914 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1916 now contains all the gdcmGlobal related code.
1917 * minor coding style and doxygenation changes.
1919 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1920 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1921 now contains all the Debug related code.
1922 * minor clean-up of includes in src/*.cxx
1923 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1924 CreateCleanString) removed.
1925 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1926 * Doc/DoxyMainPageUser.txt added.
1927 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1928 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1929 src/gdcmDirList.cxx)
1931 2004-03-24 Jean-Pierre Roux
1932 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1934 2004-03-23 Jean-Pierre Roux
1935 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1936 big endian made volumes
1937 * ENH Now gdcmParser constructor and destructor are protected to forbid
1938 end user to instanciate class gdcmParser
1939 (only gdcmHeader and gdcmDicomDir are meaningfull)
1941 2004-03-22 Benoit Regrain
1942 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1943 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1944 gdcmSerie to gdcmDicomDirSerie
1946 2004-03-19 Jean-Pierre Roux
1947 * ENH Now the tree-like structure describing a DICOMDIR comming from
1948 an already existing DICOMDIR file is consistent with
1949 the home-made tree-like structure build ex-nihilo
1950 or build from the files held (recursively) in a Directory
1951 functions gdcmDicomDir::CheckBoundaries()
1952 gdcmObject::SetBoundaries() added
1954 2004-03-17 Jean-Pierre Roux
1955 * REM (Eric Boix bug) : removal of meaningless
1956 gdcmDicomDirImage::NewImage function.
1957 * FIX now file names and directory name are written properly in the
1959 * FIX now gdcmDicomDir constructor may be call without any trick
1962 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1964 of gdcmDicomDirImage::NewImage as empty function.
1966 2004-02-28 Jean-Pierre Roux
1967 * ENH add gdcmDicomDir:NewPatient
1968 add gdcmDicomDirPatient:NewStudy
1969 add gdcmDicomDirStudy:NewSerie
1970 add gdcmDicomDirSerie:NewImage
1971 to allow making gdcDicomDir object.
1972 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1973 (as opposite to the gdcmHeader chained list)
1975 2004-02-11 Benoit Regrain
1976 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1977 when using from python
1979 2004-02-10 Benoit Regrain
1980 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1981 * FIX : in gdcmDicomDir when the directory is empty
1982 * ENH : add callback and methods to get the progression of dicomDir
1985 2004-02-06 Jean-Pierre Roux
1986 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1987 - GDCM_META added to gdcmDicomDirType
1988 - class gdcmMeta created
1989 * ENH : - A brief summary is now displayed at the beginning of
1990 'testDicomDir' to help disaster magnitude estimation
1991 * REM : Now useless Test/explDICOMDIR.cxx
1993 2004-02-05 Benoit Regrain
1994 * ENH : add methods in gdcmObject to get the hash table or the list of
1996 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1997 * FIX : wrapping python for TagHeaderEntryHT
1999 2004-02-04 Benoit Regrain
2000 * FIX : even length for some strings when writting the dicom dir
2001 * FIX : sort the images in the dicom dir
2002 * FIX : Bug fix for python use of dicom dir
2003 * ADD : a python demo
2005 2004-02-04 Jean-Pierre Roux
2006 * FIX : Final solution (?) for icone embedded images
2007 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2008 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2009 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2010 gdcmData/gdcm-MR-SIEMENS-16.acr1
2011 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2012 to make full checking easier
2014 2004-02-04 Benoit Regrain
2015 * FIX : WriteEntries : coding style & logic in parameters
2016 * FIX : Set the elements to create the DicomDir in a dictionary file
2018 2004-02-03 Benoit Regrain
2019 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2020 * gdcmDicomDir : add the load of directory
2021 * Bug fix and print add-on
2023 2004-02-03 Jean-Pierre Roux
2024 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2025 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2026 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2027 * FIX gdcmParser.cxx : 'group length' elements are now considered
2028 as integers, even for shadow groups, when file is Implicit VR
2030 2004-02-02 Jean-Pierre Roux
2031 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2033 of the last synonym :-(
2034 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2036 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2037 * FIX taking into account the possible 7fe0,0010 multiplicity
2038 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2039 to allow removal of references to 7fe0,0010, to deal with
2040 ACR-NEMA images, when 0028,0200 is meaningfull
2042 2004-01-31 Jean-Pierre Roux
2043 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2044 no longer writes 'Un' on disk
2045 * FIX SQ elements with actual length are now dealt with corectly
2046 * FIX gdcmFile::WriteBase make the difference, for color images, between
2047 the length (for Palette expanded images)
2048 and Raw Length (non expanded image + Palette)
2049 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2050 (that broke Write). Replaced by UL.
2051 Aware user will reload the field if he
2052 thinks it's necesssary
2054 2004-01-30 Jean-Pierre Roux
2055 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2056 when 'dirty Acr' is found, to be compliant with the new
2057 IsReadable() methods.
2059 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2060 (no DOUBLE images in kosher DICOM,
2061 but so usefull for people that miss them ;-)
2063 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2064 DICOMDIR related utilities (not checked as Windoze compliant)
2066 2004-01-28 Jean-Pierre Roux
2067 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2069 2004-01-27 Jean-Pierre Roux
2070 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2071 to allow skipping the shadow elements, to save memory space.
2072 The TRUE value for this param has to be used
2073 with a FALSE value for the 'enable_sequence' param.
2074 ('public elements' may be embedded in 'shadow Sequences')
2075 * gdcmHeader methods now deal with 'embedded icones images' in the header
2076 (even when an 'icone image sequence' is announced by the
2077 element (0x0088,0x0200), but there is NO icone at all ...
2079 * gdcmHeader sometimes Image Location value doesn't follow
2080 the supposed processor endianity (see gdcmData/cr172241.dcm).
2083 * gdcmHeader add the method
2084 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2085 to get *all* the Header Entries with the same tag.
2086 GetHeaderEntrySameName is probabely *useless*
2087 (no meaning : Name is *not* an identifier within the Dictionary)
2089 2004-01-26 Benoit Regrain
2090 * Bug fix in the print of hexadecimal representations. Remove long fields
2091 in the print and add a third level of print to print them
2093 2004-01-23 Benoit Regrain
2094 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2095 * Bug fix on test suite after remove the strip made on not string fields
2096 * Split the IsReadable method between gdcmParser which test that the file
2097 is dicom and gdcmHeader which test that it's an image file
2099 2004-01-22 Benoit Regrain
2100 * DicomDir : clean code, add methods, set variables in protected or private
2101 * gdcmUtil : bug fix for the clean string method
2103 2004-01-19 Benoit Regrain
2104 * Add the use of shadow dictionaries
2105 * bug fix and coding style
2107 2004-01-19 Benoit Regrain
2108 * src/gdcmFile.cxx : bug fix concerning the close of file
2109 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2110 * Add the update of header entries using the shadow library
2112 2004-01-19 Benoit Regrain
2113 * removal of file gdcmHeader2.cxx
2114 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2115 inheriting from gdcmParser. This split is to prepare the integration
2116 of dicom dir parsing
2117 * bug fix under python
2119 2004-01-16 Jean-Pierre Roux
2120 * REM removal of class gdcmHeaderEntrySet
2121 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2122 * ADD add file gdcmHeader2.cxx
2123 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2125 2004-01-15 Benoit Regrain
2126 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2127 entries created while parsing the header. Thus, they will be destroyed
2128 when the gdcmDictSet will be destroyed
2129 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2132 2004-01-15 Benoit Regrain
2133 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2134 made a fatal error because of the memory release at the end of program.
2135 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2136 some memory and vtk seems to have some problems with that.
2137 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2139 2004-01-14 Benoit Regrain
2140 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2141 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2142 * src/*.[h|cxx] : make changes due to class name changes
2143 * gdcmPython/demo/*.py : bug fix due to method names
2145 2004-01-13 Benoit Regrain
2146 * src/*.[h|cxx] : coding style
2147 * vtk/*.[h|cxx] : coding style
2149 2004-01-13 Benoit Regrain
2150 * gdcmPython/testSuite.py : test the readable flag of file for tests
2151 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2152 It's lied to the stl compilation by MSVC (windows, always windows...)
2153 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2155 2004-01-12 Benoit Regrain
2156 * src/*.h : add comments
2157 * src/gdcmDictSet.h : set the method BuildDictPath in public
2158 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2159 directly setted in the source code
2160 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2163 2004-01-09 Benoit Regrain
2164 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2165 * setup.py : use a reference to gdcmVERSION
2167 2004-01-07 Benoit Regrain
2168 * Modification to compile with the distutils.
2171 2003-12-10 Benoit Regrain
2172 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2173 can use a gdcmHeaderHelper to load data
2174 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2175 made in the source code
2177 2003-12-10 Benoit Regrain
2178 * Update Windows projects and .cvsignore files
2180 2003-11-12 Jean-Pierre Roux
2181 * ENH gdcmHeader constructor has one more parameter (default value : false)
2182 that allows the user to 'go inside' the SeQuences only
2184 gdcmElValSet:Print takes it into account
2186 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2187 * ENH: Update gdcmPython/CMakeLists
2188 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2189 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2191 2003-11-10 Jean-Pierre Roux
2192 * FIX : gdcmHeader::LoadElements is now based
2193 on the ListTag listElem member,
2194 not longer on the TagElValueHT tagHt member
2195 * ENH : PrintPubElVal shows (temporarily) both results,
2196 with the tagHt member and the listElem member.
2197 (it's easier to 'see' the problems when using Printheader)
2199 * FIX : old private member LgrElem is now splitted into
2200 ReadLength : Length actually found on disk (updated only
2201 if bug fixing is necessary), for internal
2203 UsableLength : Updated by FixFoundLength, to fix a bug
2204 or to allow Parser going on.
2205 Will allow to re-write a kosher header when a SeQuence
2206 with a length (not 0000) is found
2207 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2208 because gdcmElValSet::Add does not update ListElem
2211 2003-11-07 Jean-Pierre Roux
2212 * FIX misstyping in Transfert Syntax name table
2213 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2214 when they have an actual length (not 0000 nor FFFFF)
2215 (Nobody should care of it, but DICOMDIR explorers)
2217 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2218 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2220 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2221 * ENH: vtkGdcmReader now supports LUT !
2222 (vtkgdcmViewer for now is not able to use them though)
2224 2003-11-05 Jean-Pierre Roux
2225 * in testSuite.py : new files names for checking the package
2226 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2227 that returns the pixel area size to the *aware* (vtk) user
2228 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2230 2003-11-05 Benoit Regrain
2231 * in testSuite.py : Modify the rules for checking the paths
2232 : Explicit error messages
2233 * in __init__.py : Related modif
2235 2003-11-03 Jean-Pierre Roux
2236 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2237 to be used by aware (vtk) users that want to manage
2238 LUT (and no to turn the PALETTE image into an RGB pixels one)
2239 * GetPixelType now returns 8U for 24 Bits images
2240 (vtkGdcmReader compliant)
2242 2003-10-31 Jean-Pierre Roux
2243 * Removal of *all* gdcmData images and add them again
2244 in order to loose the 'history' of un-anonymised images
2246 2003-10-31 Jean-Pierre Roux
2247 * RMV : removal of useless jBitsInJsample.h
2248 for both 8 and 12 Bits JPEG Lossy Libraries
2250 2003-10-31 Jean-Pierre Roux
2251 * ENH : Add the functions gdcmFile::GetImageDataRaw
2252 gdcmFile::GetImageDataIntoVectorRaw
2253 that act as GetImageData and GetImageDataIntoVector
2254 except the making of an RGB Plane from Gray Plane + LUT
2255 Intended to aware (vtk) users who know how to manage
2258 GetLUTRGBA return a R,G,B,A LUT if any
2259 lgrTotaleRaw gives the 'Raw' length
2260 GetImageDataRaw returns the gray Plane
2261 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2262 (They stay Grey, just like with other Dicom viewers :-(
2264 2003-10-30 Jean-Pierre Roux
2265 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2267 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2269 being coherents dicom files.
2271 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2274 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2275 * ENH: Two steps is necessary to please VC++ compiler...
2276 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2277 * ENH: Add include dir to medcon lib
2278 * FIX: only one function is being exported for now !
2279 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2281 2003-10-29 Jean-Pierre Roux
2282 * adding gdcmHeader::GetLUTRGBA
2283 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2284 --> Mathieu, the modif u're waiting for is not yet committed
2285 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2287 2003-10-27 Jean-Pierre Roux
2288 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2289 00191113.dcm DermaColorLossLess.dcm
2290 MxTwinLossLess.dcm RadBWLossLess.dcm
2291 * ENH: For version prior to vtkImageViewer2 -r 1.19
2292 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2294 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2295 * Removal of ido stuff in CMakeLists.txt
2297 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2299 * FIX: remove a call to ->Modified ... see comments
2300 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2302 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * FIX: Problem with path for libvtkgdcmPython
2304 * ENH: Try adding a search script for python site-package
2305 * RMV: Remove some file from medcon lib that are not necessary
2306 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2307 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2308 * FIX: More pragma disable fro VC++,
2309 I don't think I break something as it is also disable in VTK/ITK.
2310 But it fasten debug compilation time.
2312 2003-10-23 Jean-Pierre Roux
2313 * gdcm now deals with 16 Bits Run Length Encoded images
2314 (they are compressed as 2 planes images,
2315 one for the high Bytes, the other for low Bytes)
2317 2003-10-22 Jean-Pierre Roux
2318 * Now CheckRead takes into account :
2319 - the bugged 'Leonardo' Siemens images
2320 - the XA images, sent thru the burning VPRO station
2321 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2324 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2325 * FIX: When copying a Makefile.am to CMakeLists.txt
2326 one should remove the '\'
2328 2003-10-22 Jean-Pierre Roux
2329 * in gdcmData adding a bugged 'Leonardo' Siemens image
2330 (wrong lengths in header)
2331 OK with gdcm, KO with the other viewers :-)
2332 * add a GE dlx XA image, thru the VEPRO burning station
2335 2003-10-21 Jean-Pierre Roux
2336 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2337 for a brutal checking of vtkgdcmViewer compliance
2339 2003-10-21 Jean-Pierre Roux
2340 * add the files for 'xmedcon' Jpeg Lossless library
2341 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2343 2003-10-21 Jean-Pierre Roux
2344 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2346 2003-10-21 Jean-Pierre Roux
2347 * garbage Siemens 'Leonardo' images dealt with
2348 (the patch is easy to remove)
2349 * cosmetic changes to avoid warnings
2351 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2352 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2353 no need to press 'r' now.
2355 2003-10-20 Jean-Pierre Roux
2356 * upgrade of checkRead.sh checkWrite.sh according
2357 to new Jpeg Lossless decompressor
2358 * add US.3405.1.dcm, a genuine RGB medical file ...
2359 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2360 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2362 2003-10-15 Jean-Pierre Roux
2363 * general anonymisation in gdcmData
2364 * adding the 'color files' from
2365 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2366 * adding some well knowed bugged-header images
2367 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2368 waiting for their inclusion in Python testsuite
2370 2003-10-15 Jean-Pierre Roux
2371 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2372 no longer seg faults when file is not found
2374 2003-10-14 Jean-Pierre Roux
2375 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2378 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * TODO: *.in file to genereate a UseGDCM later
2381 2003-10-14 Jean-Pierre Roux
2382 * Some supposed-to-be Dicom Images have no preamble.
2383 OpenFile takes it into account
2384 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2385 * Missing elements added in dicomV3.dic
2386 (just to be affraid : have a look at
2387 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2388 and do it again next year ;->
2390 2003-10-13 Jean-Pierre Roux
2391 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2392 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2393 But there are NOT. It's fixed !
2395 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * FIX: "jpeglib.h" was not found on VC++
2397 * FIX: vtkgdcm was not being installed
2399 2003-10-10 Jean-Pierre Roux
2400 * ENH : OpenFile closes the file if it *really* doesn't look like
2401 an ACR-NEMA / DICOM one.
2402 * FIX : testWrite no longer writes an empty file if the source file
2403 is not gdcm Readable
2404 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2407 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2408 * FIX: CMake generate now documentation
2409 * ENH: out of source doc build !
2410 * ENH: Generate both user and dev documentation
2411 * ENH: Should work on windows too
2412 * ENH: Only one doxygen config.in file is needed
2413 * FIX: make install should be ok now on ùnix plateform
2414 * FIX: PATH to dictionary was wrong (missing /)
2415 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2417 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2418 * vtkGdcmReader is now able to read rgb dicom file.
2419 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2420 * added a gdcmViewer to vtk test, use mouse to control
2421 window level & window width
2423 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * CMake-ification of gdcm, we have now two build system
2425 * FIX: on cygwin Wsock32 doesn't exist
2426 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2428 2003-10-06 Emanuel Ollart
2429 * FIX : compilation process wad broken.
2430 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2432 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2433 * change gdcmViewer -> vtkgdcmViewer
2434 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2436 2003-10-06 Jean-Pierre Roux
2437 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2438 ( e.g : well known GE images with a wrong elem length,
2439 : Philips MRI Images with a wrong Huffman table)
2440 * still to be done : allow the reading of bugged LEONARDO Siemens images
2442 2003-10-03 Jean-Pierre Roux
2443 * Odd length strings are padded with '\0' (not with spaces,
2444 to remain compliant with already defined strings,
2445 like Transfert Syntax UID and others)
2447 2003-10-03 Jean-Pierre Roux
2448 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2449 to allow displaying RGB images (not only by affim ;-)
2451 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * vtkGdcmReader is now able to read rgb dicom file.
2453 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2455 2003-10-03 Jean-Pierre Roux
2456 * A few nasty patches to allow the reading of a lot of nasty images
2457 ( e.g : well known GE images with a wrong elem length,
2458 : Philips MRI Images with a wrong Huffman table)
2459 * still to be done : allow the reading of bugged LEONARDO Siemens images
2461 2003-10-03 Jean-Pierre Roux
2462 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2464 2003-10-03 Jean-Pierre Roux
2465 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2466 to allow displaying RGB images (not only by affim ;-)
2468 2003-10-03 Jean-Pierre Roux
2469 * gdcmFile::GetImageDataIntoVector now
2470 - deals with MultiFrames MultiFragments Run Length Encoded files
2471 - deals with YcBcR (YBR_FULL) files
2472 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2473 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2475 (no sample found :-(
2477 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2478 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2479 Two reasons: - clear things
2480 - third parties acces gdcm through header files, so won't
2481 suffer anymore VC++ complains
2483 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2484 * add argv[1] in testvtkGdcmReader.cxx
2487 2003-09-24 Jean-Pierre Roux
2488 * The lines are now eigthy characters long.for
2489 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2491 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2492 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2493 char* to std::string. Thus, the use of strdup becomes useless. (see
2494 previous commis of Malaterre)
2495 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2496 before the last Malaterre's commit.
2498 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2499 * This commit should fix the Debug building under VC++, the problem
2500 was mainly a mixture of debug and release lib being loaded at startup.
2501 * I also remove a depency to a specific C function: strdup. Because I had
2502 to force the link to msvcrtd (whereas strdup is in libc).
2504 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2505 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2506 located in the gdcmCommon.h file. All use of reference of tha has been
2507 changed to now use the variable GDCM_UNFOUND.
2509 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2511 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2512 Dicom dictionary. The test suite can now be run again. Note:
2513 I'm note very happy with the " (RET)" changes. I believe this
2514 RETAINED comment should be dropped when parsing the dictionary.
2515 - PACKAGER corrected
2517 - AUTHORS updated and now in alphabetical order
2518 * Makefile.am now exports gdcm.dsw for Windoze users.
2520 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * cygwin complains about missing std:: in subdir Test/
2523 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * remove some methods that are now in gdcmHeaderHelper
2526 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * vtkGdcmReader set spacing and origin correctly
2529 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2530 * Fix a few delete/delete[] mismatch
2532 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2533 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2534 interpretation to data given by gdcmHeader. For instance there are
2535 heuristics to get informations (look at different places).
2536 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2537 sorting DICOM images based on different strategies.
2538 * modified Makefiles accordingly.
2540 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2541 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2542 when building in debug mode
2543 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2544 src/win32/gdcmdll.dsp
2545 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2547 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2551 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2552 * src/win32/libgdcmjpeg12.dsp was not dos format
2553 * src/win32/libgdcmjpeg12.dsp :
2554 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2555 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2557 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2558 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2560 * src/gdcmFile.cxx : bug fix in affectation type
2561 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2562 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2563 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2564 symbols... future problem ?
2566 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * src/win32/libgdcmijpeg12.dsp was missing
2568 * modified gdcm.dsw accordingly
2570 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2571 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2573 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2574 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2575 commit of JPR (before his hollidays to facilitate our work).
2576 * setup.py : bug fix in code. Modifications made while the last commit
2577 of JPR. The code hasn't been tested before the commit... it's so
2578 useless to make that (for best programmer that is JPR) !!!
2580 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * tagged the current version as Version0_3 (i.e. version 0.3)
2583 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2584 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2585 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2586 * *.dsp : modifications to use new libgdcmijpeg8 library
2587 * setup.py : bug fix on VTKPATH variable
2588 * PACKAGER : adding all concerning windows
2590 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2593 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2594 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2595 test suite reported error.
2596 * PACKAGER file added (describes what a packager must do when
2597 packaging a new release).
2598 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2599 * configure.in: upgraded version number to 0.3.0
2600 * fixing build of rpm (through rpm -ta):
2601 - Doc/Makefile.am exports proper doxygen files
2602 - src/jpeg/libijg8/Makefile.am exports the include files.
2604 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2605 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2606 * src/gdcmHeader.h : formatting code
2608 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2609 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2610 We were obtaining error message from vtk. Now, creation of file list
2611 is made in an internal list to prevent this problem.
2612 Bug fix when output is empty.
2613 Bug fix in update of progress value. Previous commit for this was a bad
2615 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2617 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2618 * src/gdcmHeader.h : added method to get the file name
2619 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2620 files. Added method to remove all files on the input
2621 Added FIXME comment concerning the bad parsing of header made by
2622 ExecuteInformation method (in ExecuteData method)
2624 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2626 when using make instal.
2627 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2628 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2630 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2631 * setup.py : adding include dir of jpeg lib to compile all sources
2632 * */Win32/*.dsp : JPR fix for windows compilation
2634 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2635 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2637 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2638 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2640 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * setup.py is again effective on un*x (takes into account the
2642 addon of the jpeg library)
2643 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2644 * Doc/Doxy* updated (includes above enhancements)
2645 * INSTALL now points to web documentation
2647 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * src/gdcmHeader.h doesn't make unnecessary reference to
2650 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2652 * src/gdcm*.[cxx|h] :
2653 - to allow compilation with gcc 3.x
2654 -- clean up of STL usage (added explicit usage of std::)
2655 -- small fixes on exceptions.
2656 Note: linking not tested !
2657 - clean of doxygen comments to avoid warnings at documentation
2659 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2660 dependent convertion).
2662 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * Clean up of previous JPR garbage commit (not even commented in the
2665 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2666 - moved all jpeg related files from src to src/jpeg/libijg8, with
2667 addition/modification of Makefile.am and configure.in.
2668 - the testSuite is still brain damage (not guilty).
2670 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2671 * WrapVTK.py : modifications to get correctly vtk source files to
2673 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2674 (FileName -> Filename)
2676 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * vtk/vtkGdcmReader.[cxx/h]:
2678 - UpdateProgress method should now be effective
2679 - removed the limitation on having only images loaded (as opposed
2681 - when building a stack of images/volume, a lesser number of
2682 gdcmHeader and gdcmFile instances should be used (hopefully
2683 accelerating things).
2684 - when building a stack of images/volumes, files which are not
2685 loadable (wrong path-filename, wrong permissions on existing file,
2686 or file not parsable by gdcm) are replaced with a black image
2687 in the stack (for the caller to notice the problem).
2689 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2692 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2693 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2694 between standard library (std) and vtk library (problems are found
2695 under Windows... thanks Windows !)
2697 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2700 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2702 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2705 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * When compiling with distutils (see setup.py) the C++ compiler is
2707 called with different flags than the default ones (with automake).
2708 In order to fix all those warning, I compiled gdcm with the command
2709 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2710 and went for warning fixes:
2711 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2712 up from unused variables.
2713 - vtk/vtkGdcmReader.cxx: potential bug fix.
2714 * src/gdcmHeader.h: Doxygen warning cleanup
2716 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2717 * gdcmPython/gdcm.i:
2718 - typemaps correction to take into account the systematic replacement
2719 of "using namespace std" with std:: prefix e.g. std::list,
2720 std::string... (cf changes of 2003-05-21).
2721 - gdcmGlob global variable of type gdcmGlobal (defined in
2722 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2723 exported to Python a as cvar.
2724 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2725 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2726 gdcmDictSet.GetPubDictTagNames() and
2727 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2728 C++ static methods).
2729 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2730 with the above changes.
2732 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2733 * setup.py, manifest.in : bug fix under linux
2735 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2736 * Modification of setup.py to compile vtk part too. Then, we have 2
2737 wrappers which must work with same distutils. For that, we have a
2738 generic distutils in distusiltsWrapping.py ; with :
2739 - build_extWrap class to wrap generically all extensions,
2740 - ExtensionWrap base class for all wrapping extension that contains
2742 - Wrapper interface which wrap sources
2743 + In WrapSwig.py we have extension and wrapper for Swig
2744 + In WrapVTK.py we have extension and wrapper for VTK
2745 * MANIFEST.in : modifications to consider vtk directory and new python
2746 files for compilation
2748 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2749 * Added python wrappers of vtkGdcmReader vtk class (see the
2750 source in vtk/vtkGdcmReader.cxx) :
2751 - vtk/Makefile.am now builds a library
2752 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2753 python library (as opposed to _gdcm.so wich are the python
2754 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2755 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2757 - configure.in has an additional flag --enable-vtk that needs
2758 to be set to enable compilation of vtk related code, that is:
2759 + vtk/vtkGdcmReader.so and
2760 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2761 + gdcmPython/vtkgdcmPython.so (see above)
2762 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2763 be read when compressed or when HighBit + 1 != BitsStored),
2764 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2765 the usage of the python wrapper of vtkGdcmReader vtk class.
2766 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2767 * src/*.[h] all occurences of stl classes are now prefixed with
2768 std::, and all occurences of "using namespace std;" where removed.
2769 This is to avoid pollution of global namespace in included files.
2770 Apparently vtk does not avoid this pitfall: when using both
2771 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2772 collision of various stl members (principally cout...).
2773 * gdcmPython/testSuite.py now cleanly removes temprory generated
2775 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2776 comply with above changes)
2778 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2779 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2780 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2781 vtk data structure (an image Flip was required).
2782 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2783 * cosmetic changes in documentation.
2785 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2786 * src/gdcmHeader.cxx: the constructor no longer exits when an
2787 unexisting file is given as argument.
2788 * The subdirectory Data (containing all the images used for the
2789 test suite) is not part of this repository anymore. A new module
2790 containing those images is now available at
2791 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2792 with the name gdcmData.
2793 All the python scripts (including the package initialisation file
2794 gdcmPython/__init__.py) were adapated to take this change into
2795 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2797 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2798 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2799 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2800 demo of the usage of this class.
2801 Compilation of this vtk part is only done when using the --enable-vtk
2802 at configure (or autogen.sh) stage.
2804 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2805 * More memory link related corrections and documentation fixes.
2807 - maximum info is obtained with a command of the form:
2808 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2809 --show-reachable=yes PrintHeader
2810 - the remaining reachable blocks seem to come from the STL
2811 allocation scheme through the usage of map and list. It looks
2812 like this memory cannot be freed but it is not a memory leak
2813 (in fact further invocation to the STL would recollect the
2814 unused memory allthough it cannot explicitely be freed).
2815 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2816 of displaying an image parsed with gdcm and displayed with VTK.
2817 Note: some images don't seem to work e.g.
2818 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2819 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2820 Allthough this weakens the semantics, it is a ditch attempt to
2821 make gdcm more thread friendly.
2823 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2824 * Memory link hunt (by using valgrind through the command
2825 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2826 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2827 gdcmHeader::_dicom_vr.
2828 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2829 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2831 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2833 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2834 * src/Makefile.am now exports all the necessary include files at
2838 * UpdateGroupLength replaced by new one
2841 * UpdateGroupLength re-written using H-Table
2842 (named UpdateGroupLengthNew untill checks are over)
2844 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2845 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2846 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2848 - gdcmHeader::GetPubElValSet removed.
2849 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2850 UpdateGroupLength, WriteElements, Write.
2851 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2852 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2853 carried the same semantics.
2854 - src/gdcmHeaderIdo.cxx changed accordingly.
2855 - gdcmFile::WriteBase now regroups all the codes from previous
2856 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2857 - enum FileType moved to gdcmCommon.h
2858 * src/gdcmHeader.cxx AddDefault trashed
2859 * gdcmGetXSize added
2860 * getimageDataSize now calls gdcmGetXSize
2861 * Test/*.cxx changed to agree with above changes
2863 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2865 (to avoid double call by end user).
2866 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2867 by end user, since gdcmHeader::gdcmHeader now handles it.
2869 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * gdcm/Doc many doxygen changes:
2871 - Doxyfile now has two different versions, DoxyfileUsers that generates
2872 the html.users end users oriented documentation and
2873 DoxyfileDeveloppers that generates the html.developper developper
2874 oriented documentation.
2875 - README changed accordingly
2876 - requirement.txt removed (old design info moved to TODO).
2877 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2878 DoxyMainPage.txt, DoxyPython.txt provide more information.
2879 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2880 be updated by simply regenerating the docs with doxygen and copying
2881 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2882 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2883 all the tests in the form "if (<map>.count() >1)" were removed.
2884 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2885 ill-formed documentation sections.
2886 * src/gdcmHeader.cxx: ditto
2888 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * setup.py fixed for un*x (needed macro for stdint.h)
2890 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2891 un*ces with sh-utils test utility.
2892 * gdcmPython/demo/test.py renamed to PrintHeader.py
2893 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2894 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2895 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2896 * src/gdcm*.cxx JPR's bad inclusion fixed.
2898 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2899 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2900 * gdcmPython/demo/test.py changed accordingly.
2902 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2903 * gdcmPython/Makefile.am fixed linking against libstdc++
2904 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2905 * Swig subdir (historical tests of swig version 1.3.17++) removed
2906 * Test/testChangeEntete.cxx some lines commented out in order to make
2908 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2909 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2911 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2912 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2913 hence the user doesn't need this explicit call.
2914 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2915 i.e. LoadElements() call removed.
2916 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2917 - src/Makefile.am declares the proper flag for g++.
2918 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2919 for adding user defined new tags.
2920 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2921 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2922 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2924 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2925 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2926 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2927 src/Makefile.am : the project should properly compile and install
2928 with the autotools, included the python wrappers part.
2929 * gdcm.spec.in : added a spec file for RPM packaging.
2931 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2932 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2934 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2936 to exported to the environement (see gdcmPython/testSuite.py
2938 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2939 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2940 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2941 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2942 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2944 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * gdcmPython/__init__.py doesn't crash anymore when running in
2946 in InstallMode or PreInstallMode but with an environment given
2947 value of GDCM_DICT_PATH.
2948 * src/gdcmDictSet.[cxx/h] coding style.
2950 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2952 * src/gdcm.h general comments moved to TODO, and README
2953 * src/gdcm.h should now be seen as a user commodity (including it
2954 should suffice to fully use gdcm). It is nowhere including within
2955 any of the kernel files src/*.cxx and src/*.h.
2957 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2959 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2961 * src/gdcm*.cxx only include their corresponding include file
2962 (as opposed to gdcm.h)
2963 * gdcmPython/gdcm.i changed accordingly
2964 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2965 the autogen.sh generated "make snapshot" command to work.
2966 * autogen.sh removed history related references to crea package.
2968 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * distutilsSwigCPlusPlus.py work around some swig portability
2972 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2973 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2974 was done in a last ditch attempt to get setup.py _really_
2975 operationnal. The python/gdcmPython layaout add the advantage
2976 of hidding away the python related distutils specific files
2977 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2978 Alas, the src directory was out of scope (i.e. it's relative
2979 position to setup.py was ../src) which made things impossible to
2980 handle (see previous version of python/setup.py). Crossing fingers...
2982 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2983 * python/setup.py now works on Un*x. (harder than I thougth)
2984 * python/distutilsSwigCPlusPlus.py can now have include files
2985 among the list of sources.
2987 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2988 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2989 * modifications in MSVC projects
2991 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * As stated by the first lines of Test/ExceptionAndPython/README, it
2993 looks like we can move back to original usage of exception within
2994 src/gdcm* and hence remove the errno stuff that was introduced
2995 as a quick and dirty fixture of this problem (added to the TODO).
2996 * Doc/Doxyfile configuration file for Doxygen and corresponding
2997 README file for usage added.
2998 * Test/testWrite.cxx added. This new test comes from a split of
2999 test.cxx that is now reverted to its original purpous i.e.
3000 testing the proper parsing of a Dicom related file.
3001 testWrite.cxx concentrates on testing the IO part of gdcm.
3002 * Test/bug1.cxx (containing a bug on WIn32) added.
3003 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3004 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3005 whose purpose is to publish the content of the TagNames of the
3006 Dicom public dictionary were not accessible without an
3007 instance of class gdcmHeader.
3008 - those methods are now static methods of gdcmDictSet and hence
3009 require no instances at all to be invocated.
3010 - within gdcmDictSet this change required to change some method
3011 to class methods (i.e. are now static) among which SetDictPath
3012 (renamed to BuildDictPath) and LoadDefaultPubDict.
3013 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3014 the above changes by calling the new method classes of gdcmDictSet.
3015 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3016 the above to be effective.
3017 * python/gdcmPython: in order to wrap properly the above changes
3018 for Python, swig version now needs to be > 1.3.17.
3019 * python/gdcmPython/Makefile fixed to adapt itself to new
3020 configure/make shema introduced by Johan Montagnat (thanks for the
3021 contribution). Alas this Makefile cannot be turned into a proper
3022 Makefile.am without some heavy changes in the configure.in
3023 (for python dectection).
3024 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3025 now avoids publishing the empty entries.
3027 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3028 * python/setup.py : bug fix concerning install under windows
3029 ExtraPath reused :-P
3030 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3032 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3033 * Dicts/dicomV3.dic : remove double spaces !!!
3034 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3035 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3038 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3040 method. Doxygenation.
3041 * src/gdcm.h clean up of JPR spurious comments.
3043 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * python/distutilsSwigCPlusPlus.py now properly collects the
3045 shadow classes generated by "swig -c++" (gdcm.py in our case)
3046 when using "python setup.py install".
3047 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3048 reexports the working classes.
3049 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3050 by the classical C errno scheme. This is to prevent an obscure
3051 behavior of the python wrappers when importing wxPython.wx prior
3052 to gdcmPython (which ended up in an abort call). An illustration
3053 of this oddity can be found in the Test/ExceptionAndPython
3054 subdir (see the README file). This problem probably due to
3055 an combination of g++ and dynamic loading.
3056 * added Test/ExceptionAndPython (see above)
3058 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * Changed the layout of the python part to avoid bloating main
3060 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3061 i.e. the distutils arsenal. All the python related stuff is
3062 again in a python subdir, but the package itself is now in
3064 * setup.py was cleaned up:
3065 - pythonIncludePath removed
3066 - python setup.py bdist target is now functional.
3067 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3068 collision with other packages). gdcmPython/demo/*.py changed
3071 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * python subdir moved to gdcmPython (preparation of distutils packaging).
3073 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3074 distutils installer is operational.
3075 * - gdcmPython/__init__.py now properly loads the swig generated
3076 shadow classes (from gdcm.py).
3077 - gdcmPython/demo/*.py changed to import the package gdcmPython
3078 instead of gdcmPython/demo/load.py.
3079 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3081 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3083 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3084 entries within the associated public Dicom dictionary resp. the same
3085 information but sorted by the fourth field (PAT, IMG, DIR) of the
3087 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3088 are now in the "???" group.
3089 - python/gdcm.i changed accordingly,
3090 - python/demo/printGroupedPublicDict.py added, that gives an example
3091 of the above new functionalities in Python.
3093 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * src/gdcm.h, gdcmHeader.cxx:
3095 - historic references to glib's g_malloc and g_free (#defined)
3096 were definitively removed.
3097 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3098 * src/gdcmElValSet.cxx:
3099 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3100 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3101 - GetElValue(string) renamed to GetElValueByName.
3102 - Added GetElementByName(string).
3103 * src/gdcmHeader.cxx: added
3104 - GetPubElValRepByNumber(guint16, guint16)
3105 - GetPubElValRepByName(string)
3106 - GetShaElValRepByNumber(guint16, guint16)
3107 - GetShaElValRepByName(string)
3108 - GetShaElValByNumber(guint16, guint16)
3109 - GetShaElValRepByName(string)
3110 - GetElValRepByNumber(guint16, guint16)
3111 - GetElValRepByName(string)
3112 - GetElValByNumber(guint16, guint16)
3113 - GetElValRepByName(string)
3114 * Doc/requirements.txt added.
3116 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3117 * Test/Makefile building now depends on the one of libgdcm.so
3118 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3119 pixel data) aware which enables finding the address (offset) of
3120 the pixel data of JPEG encoded DICOM files. This leaves only a single
3121 file in the testSuite whose pixel data address (offset) is unknown.
3122 * python/testSuite.py changed accordingly.
3124 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3125 * VC++ has some strong limitations when working with the STL, as stated
3126 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3127 "Also note that some STL containers (map, set, queue, list, deque)
3128 cannot be exported. [...]
3129 Some STL classes contain nested classes. These classes can not
3131 This is caused by a designed limitation that once a template
3132 class is instantiated, it can not be re-instantiated and
3134 Since our usage of map<> is ubiquitous in gdcm, this "designed
3135 limitation" of VC++ is a pitfall.
3136 Hence the Python wrappers of gdcm cannot be incrementally linked
3137 against the c++ dynamic library. The dirty but only workaround is
3138 to forget about incremental link of dynamic libraries and to generate
3139 the Python wrappers library with the inclusions of the underlying C++
3141 The following modifications concern this matter on Win32/VC++:
3142 - wrapping python correct with standalone wrapped dll (don't use separate
3143 dll under windows !!!!)
3144 - python21_d debug mode enabled (ask Frog how to use it :-)
3145 - NO problem with having an STL member of class for example string in C++
3146 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3147 - Python test of dcmlib in Python is ok under windows on a large set
3149 * removed glib references
3150 * typedef's inserted in gdcm.i for correct swig type management
3152 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * python/demo/*.py load.py extracted from test.py. Added explore.py
3154 that only displays required tags and testAll.py that parses all
3155 the files of the testsuite without using unittest.
3156 * python/testSuite.py other additional test on new files added.
3157 * Data/* new test files added accordingly to the testSuite.
3158 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3159 the vr in the file differs from the one of the dictionary.
3161 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3162 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3163 values, but limits itself to values which are below a user specified
3164 size (by default 1024 bytes).
3165 * python/gdcm.i : elements not loaded (because their size is above the
3166 user specified treshold) are exported with their TagKey as key of the
3167 python dictionary. This enables the testsuite to make some checks
3168 on the unloaded elements (since we have their offset and size).
3169 * python/testSuite.py
3170 - now tests for the existence and proper value of the pixel data
3171 - two new examples added.
3172 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3174 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3175 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3176 aware. See the strategy comments in gdcmHeader::FindeLength().
3177 * Test/test.cxx now accepts a filename as first argument.
3178 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3179 * python/testSuite.py changed to integrate test on above files.
3181 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3183 the vr was also RET.
3184 * python/testSuite.py more tests added.
3186 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * python/testSuite.py unittest test suite added (uses Data)
3188 * Data/* dcm and acr files for the test suite.
3189 * glib dependance removed from un*x version. We now use ISO C99
3190 7.18 Integer types (see stdint.h)
3191 - python/Makefile, src/Makefile src/gdcm.h
3192 * src/ when an explicit vr (like dicom files) suddenly poped an
3193 implicit element we use to mark the underlying DictEntry of the
3194 concerned ElValue with "Implicit". This strategy was damageable
3195 too the public or provite dictionaries, since some of their vr
3196 would be changed. Since Header::FindLength heavily relies on the
3197 detection by Header::FindVR of falsely explicit elements, I
3198 added an extra ImplicitVr member to ElValue (boolean).
3199 The rest of the changes we the necessary adaptations.
3201 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3202 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3204 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3206 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3207 * Adaptation for porting to VC++:
3209 o forced to use std namespace (for string to be known)
3210 o all class use __declspec export style on WIN32
3211 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3212 (in stdlib.h on Win32 but in std:: for gcc)
3213 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3214 variable GDCM_DICT_PATH.
3215 * src/gdcmHeader.cxx verbose comments made discrete.
3217 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * python/gdcm.i: added a typemap that converts a C++ hashing table
3219 to native Python dictionary.
3220 * python/demo/test.py:
3221 - now uses the native dictionary for exploration of gdcmHeader.
3222 - takes an optional filename argument (the file to parse).
3223 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3224 PubElVals hashing table.
3225 * Dicts/dicomV3.dic removed error prone trailing spaces.
3227 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * Python wrapping process moved away from src/Makefile to
3229 newly created python/Makefile (as well as gdcm.i)
3230 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3231 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3232 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3233 from the environement variable GDCM_DICT_PATH (when existing).
3234 * src/gdcmDict::GetTag bug fix.
3236 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3237 * Straightforward temporary fixes for swig to build the python wrappers.
3238 src/Makefile now has a python working entry [by working we mean
3239 that we can import de shadow classes without errors].
3241 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3242 * hashtest.cxx removed (since already in Test)
3243 * src/gdcmlib.h renamed to src/gdcm.h
3244 * src/dcm.i renamed to src/gdcm.i
3245 * src/Makefile prepared for python wrapping
3247 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3248 * src/gdcmHeader.cxx :
3249 - Parsing of header is now separated from loading of element values
3250 (see gdcmHeader::LoadElements).
3251 - general clean up of hopefully all file access (creation of
3252 ReadInt16 and ReadInt32)
3254 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3255 * src/gdcmHeader.cxx :
3256 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3258 - SetLgrElem renamed to SetLength
3259 - GetLgrElem renamed to GetLength
3260 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3261 * src/gdcmElValSet.cxx fixed both GetElValue methods
3262 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3263 due to IdoDude was cleaned out.
3265 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3266 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3267 concentrates on finding the value representation (when it exists).
3268 RecupLgr now only finds the element value length, and it avoids
3269 returning the unecessary skL (skipped length).
3270 Also, offsetCourant was simply removed (with taille_fich) since
3271 it was redundant with the File position internals (by using
3272 ftell and fseek). This also made skL (see above in RecupLgr) usage
3274 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3275 on the libido specificities which are handled through class
3277 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3280 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * Truckload of changes. Parsing of header is barely functional
3282 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3284 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3285 * src/gdcmHeader.cxx many addons of low level methods
3287 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3288 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3289 and _IdDcmSWAP_LONG.
3291 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * This corresponds to all the changes decided at the meeting of
3293 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob