1 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx : bug fix on potential memory leak
3 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
4 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
5 Add ClearXxx methods to remove all the content of the list or map
6 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
8 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Grealty simplify the JPEg decompression, no need to differenciate based on
10 the JPEG possible type (with/without fragment, with/without multiple frame).
11 Everything is done throught the JPEG IO Suspension mechanism in IJG
13 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
15 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
16 with other method names
17 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
18 * Test/TestDicomDirElement.cxx : add new test
20 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
21 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
22 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
23 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
24 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
25 So can't you use __int64 in ostream at all.
27 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * bug fix for compilation on MSVC6
29 * gdcmPython/gdcm.i : rename of classes missed
31 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
33 type and not a string. So, there remove problems on the format of the
36 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
38 Thus, DicomDirXXX are created with a flad that indicates if the created
39 object is empty or not (when not empty, the DicomDirElement is used to
42 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
44 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
46 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
49 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
51 Remove all access to the hash-tables or lists in the objects.
53 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
55 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
56 be complient with all the gdcm source code
58 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
62 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
66 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * Test/ : rename VTK tests to have a best name for the tests
68 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
69 GetFirstEntry/GetNextEntry use
71 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
73 test. Now it's on image content and not on the resulting visualisation...
74 might solve the problem on linux when using the OpenGL drivers
76 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
77 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
78 DicomDirSerie, DicomDirImage
79 Dict, DictSet classes :
80 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
81 -remove InitTraversal method.
82 * UPD Test programs + Example programs
84 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
85 remove useless and never updated keyword \ingroup
87 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
89 is no memory access violation
90 * gdcmPython/demo : add python demos using VTK
92 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
93 * FIX 'Dictionnary' is now spelt 'Dictionary'
94 'wether' is now spelt 'whether'
95 'archieve' is now spelt 'archive' ;-)
97 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
98 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
99 related methods, in order not to expose internal mechanisms
102 * REM methods that exposed internal mechanisms :
103 DicomDir::GetDicomDirPatients()
104 DicomDirPatient::GetDicomDirStudies()
105 DicomDirStudy::GetDicomDirSeries()
106 DicomDirSerie::GetDicomDirImages()
107 * UPD Test programs :
111 * UPD Example program
113 * ADD DictSet methods
117 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * Removed the Print/indent/default parameter mess. There is absolutely no
119 reason to have to methods, moreover with the second taking the ostream as
120 *SECOND* parameter. This was clearly a bad hack to get things compile.
122 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
123 * Complete rewrite of the GetMacAddress code. Now the code is *much*
124 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
125 Unfortunately the main code does not work on SunOS, thus provide a specific
126 code for this platform only (and Win32 of course). Since this seems to be
127 working, change CreateUniqueUID to use GetMACAddress instead of the
128 problematic GctestetIPAddress
130 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
131 * Unfortunately to be able to test gdcmDirList I had to break the API
132 a little. Now the class is not a std::list anymore but has a member
133 std::vector (more ITK compatible). Allow unit testing on Win32 and
136 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * Update SerieHeader to take into account a Serie Instance UID to properly
140 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
141 * ENH - Comment out Mathieu's (dangerous) Super Hack
142 for dealing with BIGENDIAN processors
143 - Move equivalent stuff to BinEntry::WriteContent
144 When necessary, 16 Bits Pixels are swapped in a small buffer
145 and then written. This avoid allocating a huge buffer, in
146 PixelWriteConvertor, and avoid modifying the Pixel Area.
148 Probabely, the same operation will have to be done when we want
149 to write image with Big Endian Transfert Syntax,
150 and we are working on Little Endian Processor
152 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
155 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
156 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
157 all the dict content.
158 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
160 * Test/TestDict.cxx : add a new test for the dict classes
162 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
163 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
164 file. Debug is yanked if compiled with NDEBUG
166 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDictSet.h : set the default output to the os variable
168 * src/gdcmDictEntry.[h|cxx] : add the Print method
169 * gdcmPython/demo/ : add a new test
171 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
172 * merging of Test/PrintDicomDir and Test/TestDicomDir
173 * removal of now redundant Test/PrintDicomDir
174 * enhancement of Example/PrintDicomDir
176 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * Now, python test might work on systems
178 * Add the PrintDicomDir test
180 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 * FIX : First entry following group 0002 was lost for
182 Explicit Big Endian Transfer Syntax files
183 (group and elem not swaped)
185 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
186 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
187 Big Endian Transfer Syntax supposed the group following 0002
188 begins always by element 0000 (element 0000 is *optional*)
189 To avoid further troubles, let's be pessimistic, and use
190 Document::HandleOutOfGroup0002() method
191 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
192 (related pb not yet solved)
194 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * Bug fix for the python part use
196 * Now, PrintHeader.py pass... but outside the ctest use. shit !
198 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
201 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
203 a string and should ask the global TS dict what are the propreties of
206 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
207 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
208 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
209 to swap the Swap Code, at parsing time, when we come out of group 0002
210 and Transfer Syntax is Big Endian
211 We should be able to read now 'true DICOM" Big Endian coded images
212 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
213 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
215 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 * Hopefully fix the bug on MacOSX and static global initialization.
217 This is the only -minor- patch I found that both please MacOSX and VS6.
218 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
219 but this would require a lot of change. Another approach would be that Global
220 create those string and GDCM_UNFOUND becomes a pointer to a string (which
221 gdcm::Global would destroy at exit).
223 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * Fix bug on MacOSX with static initialization in a multy threaded
225 environment. static const string in a header file used to be ill
226 initialized provoquing the freeze of any tests. patch should solve this
229 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
230 * According to Benoit's suggestion, and without any objection from anybody
231 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
232 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
233 - method gdcmDicomDirObject::GetEntry() renamed as
234 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
236 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
237 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
238 you debug/warning message just as c++ streams which make them very convinient
239 to use. Once this is stabilize I will change the ostringstrem to be
240 redirected to a file (ofstream).
241 * Properly support C99 extension: __FUNCTION__ which allow us to display
242 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
244 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
245 * Removal of useless and dangerous methods :
246 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
247 GetDocEntryByName, GetEntryByName, GetDictEntryByName
248 * Removal of usless methods :
249 Dict::PrintByName, Dict::GetDictEntryByName
250 * Commenting out of probabely useless methods :
251 Dict::GetDictEntryNames()
252 Dict::GetDictEntryNamesByCategory()
253 DictSet::GetPubDictEntryNames()
254 DictSet::GetPubDictEntryNamesByCategory()
255 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
256 * ENH : Use dicomTS.dic as described in 2004 version
257 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
258 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
259 Add Accessors on VM (Value Multiplicity), and VM related methods
260 * ADD : Add a list of 'Dicom Attribute types', as found in
261 http://medical.nema.org/dicom/2004/04_15PU.PDF
263 * ADD : Add dicomGroupNameAbbreviations.dic
264 should be used to write a method to replace the former
265 Dict::GetDictEntryNamesByCategory()
267 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
268 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
269 to read in the file... and only it ! Length is the efective length of the
270 data in the DocEntry structure
272 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
274 And now use a static function call instead, with a global variable. i
275 This is much closer to the VTK approach. Hopefully should be bulletproof
276 and easier to use...hopefully
278 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
279 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
281 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
284 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
286 ValEntry, BinEntry, SeqEntry creation or replace
288 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
290 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
292 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
293 when specifying the VR
294 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
295 * src/gdcmDocEntry.cxx : amelioration of print
297 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
298 * ADD : Add the method Util::IsCurrentProcessorBigEndian
299 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
300 * ADD Method Document::ComputeGroupLength
301 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
302 in order to allow further VR modification by user
303 * REM : removal of once-called method File::WriteBase
304 integration of its code in formerly one-line method File::Write
306 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
308 replace the different values "??", "Unkn", "Unknown".
309 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
310 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
311 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
312 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
314 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
317 * Set the gdcm::Base class to some Printable classes
319 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmFile.[h|cxx] : add the Print method
321 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
322 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
323 * src/gdcmDocument.h : remove the PrintLevel informations
324 * Example/PrintFile.cxx : use the new gdcm::File::Print
326 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
328 problems when compiling with the python wrapping
330 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
332 writting in ImplicitVR
334 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
335 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
336 JPEG decompression, especially when dicom frames are split into several
337 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
338 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
340 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmHeader.cxx : change the initialisation of default header.
342 Now, this header is readable by gdm, e-film, DicomWorks
344 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
346 Rename Decompressed to Raw
347 * Use the API changes in gdcm::File.
348 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
351 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
353 each added entry in the header. Replace the 'Planes' field by the 'Number
356 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
358 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
360 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
362 At this time, this image isn't readable by e-film... waiting JPR help to
365 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
367 DocEntry. Now use methods of the Document !
369 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * Test/ShowDicomSeq.cxx : bug fix
372 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
373 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
374 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
375 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
376 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
378 * Test/TestCopyRescaleDicom.cxx : remove unused variable
379 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
380 containing found sequences
382 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
383 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
385 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
386 Some fields in BinEntry must be copied to not seg fault when making the :
387 gdcm::File *copy = new gdcm::File( copyH );
388 and tests are now made on good variables
390 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
392 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
394 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
395 * Add vtkGdcmWriter example and test
397 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * Test/TestUtil.cxx : reformat the source code
399 * vtk/vtkGdcmReader.cxx : remove and change prints
400 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
402 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
403 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
405 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
407 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
409 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
411 by an eof to prevent all bad read of the file... and in this case, the
414 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * Example/Volume2Dicom.cxx : comment unused variables
416 * Test/PrintDicomDir.cxx : comment unused variables
417 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
418 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
419 method that is redondant with AddEntry.
420 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
423 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * Bug fix due my last commit (compilation under Windows).
425 * Example/Volume2Dicom : bug fix in the file and reformatting source code
426 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
428 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 - Remove printf / sprintf
431 - include iostream AFTER gdcm so we don't get warnings
432 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
434 - Also remove tons of include from header files, hopefully this should
435 speeup the compilation time, since it was becoming a dog slow.
436 - Remove gdcm.h as it include way too many files and slow down compilation
437 (plus it is not up to date)
438 - remove 'using namespace std' this is BAD !
440 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * Remove memory leaks on the DicomDir
442 * Remove some useless data in DicomDirObject
443 * Add usefull methods in SQItem, to be complient withe the ElementSet
445 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
448 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
450 future, with convertion)
451 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
452 and ImageDataSize values. Remove the method to get the PixelReadConverter
453 from the output of the class
455 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
458 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
460 and vtkErrorMacro use.
461 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
463 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
466 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
467 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
468 The string leaves only in the fonction. So when we make a .c_str(), we
469 get the pointeur on the first element, element that will be destroyed
470 immediately after thee instruction.
471 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
472 file has been opened : the test must be made on the content of the
473 pointer and not directly on the pointer !
476 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
478 the python part recompiles
480 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
482 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
483 X session is killed (for my computer... it seems to not be identic on
486 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
488 avoid problems (otherwise, the difference test between the visible image
489 and the reference is incorrect. If the reference is greater than the
490 screen resolution, it's produce errors).
491 Can be used for only one image. Can be used with a visible flag.
492 * vtk/vtkGdcmReader.cxx : remove commented codes.
493 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
494 under windows at compilation
495 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
497 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
499 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
501 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
502 tests on the image size X, Y, Z
504 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
506 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
507 between the class name and the file name
509 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/ : fix compilation warnings for the Write method (2 different
511 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
512 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
513 variable... create a static method in gdcm::Document to access to
514 this variable content.
516 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
518 file, to be accessed by other files (like gdcmFile). Remove commented
519 code. Move the change of the header to the gdcmFile, using the
521 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
522 To be sure of that (and simplify calls), the Write of the header now
523 gets a file name and not a file pointer (std::ifstream).
524 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
525 DocEntryArchive. Remove all open of the written file
527 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
530 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
532 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
534 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
535 some corresponding methods. Write correctly the file and check before
537 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
538 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
539 is now on RGB data (as before my last commit
540 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
542 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
544 Add a print information of the type of the entry
545 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
546 It was in the gdcmFile, and all write have been regrouped
547 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
548 Write correctly all dicom files (in decompressed mode only at this time)
549 * Test/ : test on files are now made using Raw data and not color data if
551 * Example/PrintFile.cxx : add more printings
553 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * Amelioration of code, remove some code copy. For the loading of
555 BinEntry (in gdcmDocument), add the test to verify if the file is already
558 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
560 remove a DocEntry in the header (push an empty DocEntry)
561 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
562 lines. Bug fix in the initialization of the PixelConvert and the
564 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
565 use in TestCopyDicom (now this test can run under windows... but fails)
566 * Test/TestCopyDicom.cxx : amelioration of the test :
567 - test the pixels written
568 - add test points to quickly find where is the error
569 - can set a file name input and output in arguments
570 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
571 amelioration of the test output
573 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
575 all replaced DocEntry's
576 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
577 Now, each needed DocEntry to modify is duplicated, modified and inserted
578 to the header using DocEntryArchive. Thus, after save, we can restore the
579 header initial state.
581 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
584 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
586 correct to copy it. The DictEntry is specified at the DocEntry creation,
587 then, it musn't change in the time.
588 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
589 header correctly. At this time, the change is only made for the first
590 level of the Document. In the future, it might consider sequences.
591 The change is made by replacing a DocEntry by an other that is created
592 outside the class. The old value is kept. When we restore the header
593 status, the added DocEntry is deleted and replaced by the old value.
594 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
595 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
596 set the write type to explicit VR, implicit VR or ACR. Add methods to set
597 the write mode to native, decompressed or RGB (but not used at this time)
599 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
601 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
603 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
605 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
607 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
608 set because already copied when copying the BinEntry's of the header
609 * Test/TestAllReadCompareDicom.cxx : remove warnings
611 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
613 Two problems appear when doing it :
614 - with the gdcmFile : when the GetImageData method is called, the pixels
615 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
616 data (pixels). And each structure destruct the data when it's
617 destructed. So we have two destructions for the same data. To solve it,
618 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
619 data or not. If it doesn't own data, then they will not destroyed by
621 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
622 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
623 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
624 create a double destruction of the same DocEntry's. So, to solve it,
625 the TagHT is simply cleared and the DicomDir* elements are destroyed.
626 * TODO : add an entry concerning memory leaks in the DicomDir
628 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
630 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
633 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
635 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
636 after it have been deleted
638 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * FIX: src/* fix the doxygen warnings.
640 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
641 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
642 was erroneously defined with a size of 15 instead of 16. [many thanks
643 to Jean Michel Rouet for pointing out this bug].
645 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
646 1. Finish merging JMR patch for writting DICOM from scratch
647 2. Fix -hopefully- bug with MONOCHROME and space vs null character
648 3. Use const ref when possible
649 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
650 5. A few more comments
651 6. CreateUniqueUID can now be called without parameter"
653 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
654 * ENH: Slightly bigger patch:
655 1. Getting toward full integration of JMR patch for writting dicom from scratch
656 2. Update Test to test part of this patch: CreateUniqueUID
657 3. File was not close properly in gdcmDict
658 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
659 5. Use of const ref instead of copy (speed issue)
660 6. Remove temporary (duplicate) string in TranslateToKey
661 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
662 8. Do not repeat virtual in subclasses
663 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
665 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
666 * Apply first patch toward better string comparison when dealing with broken
667 DICOM files. Essentially the string could be padded with a space instead
668 of a null character as defined by standard
670 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
672 because never used... and in the same time, that's remove some memory leaks
674 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * src/gdcmFile.cxx : now delete the PixelConvert instance.
676 * In examples and tests : change the type of image data variables from void*
677 to uint8_t*. Remmove all delete on image data variables
679 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
681 Verify the file pointer value before open the file, and if it's not null,
682 a verbose message is generated.
683 Close correctly the file when the file isn't considered dicom-like. The
684 correctly close is a call to CloseFile.
685 When closing the file pointer, test if its not null to close the file.
686 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
687 file. For an uncompressed image, the copied data correspond in the least
688 case to the image size (calculated) or the image size specified in the
689 header. A verbose is generated if these two size mismatch
691 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
692 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
693 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
694 break under windows (with msvc6 compilation).
696 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
698 compiling with MSVC6)
700 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * Bugs fix for the Windows build with VC6
702 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
703 needed (only for projects required VTK). If the VTK is included in all
704 projects, there is conflicts with the jpeg lib of vtk when compiling the
705 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
706 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
707 when compiling the gdcm_wrap.cxx file (created by the compilation of the
709 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
710 (like it's already made for the cout use). Otherwise, conflict with the
713 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
716 - comments on the DicomDir::Method related usage added.
717 - now that we use the namespace gdcm, a lot of internal classes do
718 NOT need to be wrapped anymore.
719 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
720 DicomDir::Method) new example added.
722 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
723 * Improve string manipulation. I now inforce the notion of 'DicomString'
724 A DicomString can contain as many \0 as they want
725 and it is *always* of even length.
726 We only support odd length for very rare case.
727 And in the near future this should be removed.
729 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 * /binary_write/ gdcm source. Now even on big endian we are writting
731 little endian. This should -heopfully- fix some tests
733 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * Now the dictionary is compiled into gdcm lib. This is a default
735 behavior, thus any dic file specified is picked before failback to
736 the one comiled into lib
738 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
739 * Change internals for gdcmDict. Don't use any 'new' any more.
740 This should definitely solve any leak problem, and we should be
741 as fast as before, as long as don't modify too much the dictionary.
743 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
744 * STYLE: ivars should start with a capital letter.
745 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
746 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
748 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
750 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
751 new 2004 dictionaries added (thanks to JPR).
752 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
753 * CLEANUP_ROUND (15) for gdcmPixelConvert
754 - RLEFrame::NumberFragments is now of type unsigned int
755 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
756 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
759 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * Initial work in gathering all transfer syntax accessors. clearly
761 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
762 ivars, but only one transfersyntax (class) ivar with equivalent method on
765 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
766 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
767 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
768 discussed (plus I didn't like having a 2000 lines patch not commited)
770 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
772 * CLEANUP_ROUND (14) for gdcmPixelConvert
773 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
774 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
775 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
777 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
778 anymore and hence avoids storing a copy of PixelConvert::Decompressed
779 into File::Pixel_Data.
781 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
783 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
784 * CLEANUP_ROUND (13) for gdcmPixelConvert
785 Substituted File::ParsePixelData() with PixelConvert::Print() new
787 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
788 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
789 method to those classes.
790 - src/gdcmFile.[cxx|h]:
791 -- Added a ::Print() method.
792 -- PixelConverter is now a reference instead of a member.
793 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
794 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
796 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
798 collaboration diagram and inheritance diagram should be generated with
800 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
801 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
802 pointlessly wrapped (see
803 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
804 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
805 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
806 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
807 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
808 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
809 -- File::Initialise: PixelConverter setup moved away to
810 PixelConverter::GrabInformationsFromHeader()
811 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
812 interpretation moved away to PixelConverter::BuildRGBImage()
814 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
815 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
816 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
818 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
820 displayed on Win32 when a brutal abort() occurs (because of uncatched
821 exception). See TODO new entry of this commit for more on this.
822 * TODO added new entry.
823 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
824 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
825 - HandleColor is no longer called from gdcmFile.cxx
826 - gdcmPixelConvert.cxx clean up on method arguments and internal
827 variable names for semantical coherence.
829 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
830 * Finished lossless transition, not only do we now read all lossless jpeg
831 images, without the need of the Cornwell lib, but we do read them properly now
832 * To reduce code (well to avoid code duplication), I defined a common place
833 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
834 redefine symbols. This is not perfect but this the best solution I found for a
835 compilation time jpeg option.
837 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
838 * Update jpeg ijg lib to support lossless jpeg implementation
839 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
841 * Also added a special copyright for dcmtk since we use their bugfixes.
844 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
846 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
847 matters, as stated in warning note at begining of %include section).
848 * src/gdcmDicomDir*.[cxx|h]: coding style
849 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
850 * src/gdcmJpeg8.cxx: doxygen fix.
851 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
852 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
853 from File:: to PixelConvert::.
855 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
857 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
858 - more code moved away from File:: to PixelConvert::
859 - fat setup of PixelConverter set in place in File::Initialise.
861 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
862 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
863 namespace at the file system level. So now you should convert your examples
865 gdcmHeader -> gdcm::Header
866 It would be nice if people keep in mind to no open the namespace, since it
867 allows compilation on broken plateform which were defining common symbol in
868 the standart namespace (like LP, Unknown ...)
870 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
872 The JPEG fragments are now parsed at the same stage than the RLE
873 information. All code related to JPEG is now in gdcmPixelConvert:
874 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
875 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
876 export a gdcmFile:: method. Those are simply global functions
877 (for the time being this is better than having them attach to
878 either gdcmFile:: or gdcmPixelConvert::).
879 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
880 and stores the result in a gdcmJPEGFragmentsInfo.
881 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
882 code (among other stuff) moved away from gdcmFile:; to
885 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
886 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
887 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
888 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
889 clean up of RLE related code.
890 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
891 - src/gdcmRLE.cxx removed
892 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
893 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
894 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
895 * CLEANUP_ROUND (9) for gdcmPixelConvert
896 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
897 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
898 away from gdcmFile:: to gdcmPixelConvert::.
900 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
901 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
902 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
903 This is because Parse7Fe0 used to parse the pixels to compute the
904 length. This task was passed over to FindDocEntryLengthOB() a long
905 time ago, EXCEPT I had forgotten the OW case...
906 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
907 we just recylce the code for parsing RLE fragments and computing
909 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
910 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
911 with the retired Parse7Fe0().
912 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
913 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
915 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
917 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
918 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
919 - src/CMakeLists.txt: alphabetic order reodering + new entries.
920 * CLEANUP_ROUND (4) for gdcmPixelConvert
921 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
922 to return an unused length.
924 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
925 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
926 this should be cleanner from the plane view. The iostream are erally a pain
927 to use to do simple stuff.
929 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
930 * Redo the compilation of the ijg jpeg library. Now only one source is
931 necesseray. No need to rename file by hand what so ever. CMake handle the
932 copying of the file within different directory, configure header file to
933 modify some symbol. The only addition made to ijg wasd a mangle table so
934 that symbol are different whether we are within 8bits or 12bits.
936 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Added documentation of vtkgdcmReader on Website:
938 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
939 with it's binary name).
940 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
941 the Website to be more complete.
942 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
943 doxygenated documentation.
944 - Doc/DoxyVtkGdcmReaderExamples.txt added
945 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
946 DoxyVtkGdmReaderExamples.html )
947 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
948 * CLEANUP_ROUND (3) for gdcmPixelConvert
949 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
951 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * CLEANUP_ROUND (2) for gdcmPixelConvert
953 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
955 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * CLEANUP_ROUND for gdcmPixelConvert:
957 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
958 - src/gdcmPixelStuff[h|cxx] removed
959 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
960 - src/CMakeLists.txt changed accordingly
962 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
963 gdcmVersion.py moved to newly created ATTIC related
964 gdcmPython/SetupOldies/ directory.
965 * Autotools clean up:
966 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
967 - autogen.sh configure.in acinclude.m4 python.m4 removed
969 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/*.cxx *.h Reference to License.htm fixed to License.html.
971 * Doc/CMakeLists.txt, doxygen.config.in: fix.
972 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
974 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * TODO updated with Mathieu suggestions. I proposed a template for
976 describing TODO entries and used it for new entries.
977 * Added Doc/Website/CodingStyle.html, Developpers.html,
978 DeveloppersPython.html, GdcmDataCvs.html and
979 DownloadVersion0_1.html, DownloadVersion0_3.html.
980 * Some Doc/*.txt Doxygen files (which do not really concern the
981 documentation itself, but the website) moved to html and
982 placed in directory Doc/Website:
983 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
984 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
985 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
986 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
987 * CMakeLists.txt changed accordingly.
988 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
989 DeveloppersPython.html
990 * INSTALL nows refers to Doc/Website/Installation.html
992 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * Added Doc/Website directory, that contains a first raw version
996 2004-09-23 Jean-Pierre Roux
997 * FIX In order not to be poluted any longer by casting problems,
998 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
999 we can now delete[] it safely
1000 * VoidArea is now called BinArea (less confusing name),
1001 and all the methods called ...VoidArea... are now ... BinArea...
1002 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1004 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1006 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1007 up to the destructor of gdcmElementSet to clean up TagHt and it's
1010 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1012 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1014 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * ENH: added some utility method that builds a flat dictionary
1016 holding all the Dicom entries contained in the recursive structure
1017 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1018 an example of usage.
1019 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1020 BuildFlatHashTable() that build a flat dictionary.
1021 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1022 gdcmDocument is now a friend of gdcmElementSet.
1023 - src/gdcmElementSet.cxx: clean up.
1024 - Example/FlatHashTablePrint.cxx added.
1025 - Example/CmakeLists.txt changed accordingly
1027 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1029 moved away from gdcmDocEntrySet (since this class is an abstract class
1030 acting like an interface). SQDepthLevel and BaseTagKey are now
1032 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1033 and associated accessors. Doxygenation of the class.
1034 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1036 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1037 Use SQDepthLevel accessor instead. ::Print() adapted.
1038 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1039 - src/gdcmDocument.cxx changed accordingly.
1041 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1043 - The following is the doxygen comment of the typedef declaration
1044 of gdcmTagKey in src/gdcmCommon.h:
1045 gdcmTagKey is made to old an "universal" (as in URL, Universal
1046 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1047 A dicom tag always has a group and an element, but a set of tags
1048 embeded in various (optionally nested) sequences and sharing
1049 the same group and element all share the same (group, element)
1050 "identifier". Hence the (group, element) cannot be used as an
1051 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1052 In order to construct a proper tag identifier (i.e. a key) we
1053 consider the following definition of a TagKey:
1054 - let Group, Element be the string representation of the
1055 group and element dicom tag members,
1056 - let ItemNumber be the string representation of the integer
1057 index of the considered item number of a sequence,
1058 Let the key of a tag embeded in a sequence, noted SeqTag, be
1060 /ItemNumber#Group|Element
1061 where "/", "#" and "|" are characters acting as separators.
1062 Then the general form of a gdcmTagKey is given by:
1063 Group|Element<SeqTag>
1064 where <SeqTag> means NO or many instances of SeqTag.
1065 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1068 but the gdcmTagKey of a tag "embeded" is the first item of
1069 a sequence, itself nested in the third item of a sequence is the
1071 0004|1220/2#0008|0082/0#0008|0090
1072 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1073 order to hold the new sequence compatible key. Previously, the
1074 GetKey() method would look in the underlying gdcmDictEntry.
1075 - src/gdcmDocEntry.cxx:
1076 -- constructor now copies the underlying DictEntry key, in the local
1078 -- ::Print: displays the member Key, instead of the (group, element).
1079 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1080 - src/gdcmDocEntrySet.h:xi
1081 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1082 -- now has a new BaseTagKey member.
1084 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1085 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1087 This poses the problem with the semantics of the following lines
1088 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1089 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1090 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1091 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1092 to the long FIXME note for what the problem is. Nevertheless in
1093 order to get things working the dicom dictionary was altered !
1094 Please fix things urgently...
1095 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1096 information), see above note on moving the member VoidArea. Nevertheless
1097 the following entries previously correctly set as US are now inproperly
1099 0028 1201 OW IMG Red Palette Color Lookup Table Data
1100 0028 1202 OW IMG Green Palette Color Lookup Table Data
1101 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1102 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1103 of gdcmDocEntry moved to gdcmSeqEntry.
1104 * src/gdcmSeqEntry.cxx: STYLE.
1106 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1109 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * gdcmPython/testSuite.py: all the test suite in python is now moved
1111 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1112 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1113 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1115 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1117 to avoid inclusion recursion until STL is reached.
1118 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1119 mecanism. errno.h is not included in gdcm anymore.
1120 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1121 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1123 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1124 gdcmData/TestAllEntryVerifyReference.txt
1125 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1126 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1127 exception_on_error parameter.
1128 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1129 - vtk/vtkGdcmReader.cxx changed accordingly,
1130 - Example/*.cxx and Test/*.cxx changed accordingly.
1132 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1134 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1135 enable_sequences removed from gdcmHeader constructor and dependencies.
1136 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1137 * gdcmPython/demo/PrintHeader.py: dummy fix.
1138 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1139 skip_shadow removed from gdcmHeader constructor and dependencies.
1140 * Example/*.cxx and Test/*.cxx changed accordingly.
1142 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1143 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1144 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1146 2004-07-21 Jean-Pierre Roux
1147 * FIX Now, Parsing and Printing a DICOMDIR do work!
1148 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1150 2004-07-20 Jean-Pierre Roux
1151 * FIX Some brain damaged headers have Zero-Lenght fields
1152 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1154 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1155 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1156 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1157 variable (instance of gdcmDebug) by a definition macro, and the instance
1158 is now in static in the gdcmDebug class
1159 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1160 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1162 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * WARNING: ctest now depends more tightly on gdcmData. You should
1164 check out gdcmData properly for things to run smoothly...
1165 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1166 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1167 we need the pixels not be loaded in order to use the ValEntry
1168 that displays position and size).
1169 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1170 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1171 be deprecated. If you have any doubts about the advantages of a
1172 modern scripting language (read Python) versus grass root C++ (i.e.
1173 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1174 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1175 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1176 Anyhow, consider documenting the gdcmData images in
1177 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1179 * Test/CMakeLists.txt:
1180 - now uses TestAllEntryVerify.cxx
1181 - specific comments on oldACR00001.ima (now renamed in gdcmData
1182 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1183 gdcmData/TestAllEntryVerifyReference.txt
1186 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * src/*.[h|cxx] : typedef clean up
1188 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1189 - TagKey renamed to gdcmTagKey (for external usage)
1190 - VRKey renamed to gdcmVRKey (for external usage)
1191 - removal of typedef duplication.
1192 - Removed all unecessary inline keyword from class inline definitions.
1193 - Some method|function(void) declarations replaced with method|function().
1194 * src/jpeg/libijg12/jdhuff12.c:
1195 - printf polluting ctest removed.
1196 - TAB removal for comminting
1198 - TestAllReadCompareDicom.cxx: added a test that compares all the
1199 images in gdcmDataImages.h with corresponding images in
1200 gdcmData/BaselineDicom/. When baseline images are not present
1201 this test creates them.
1202 Note: we need to validate each reference image, but before that
1203 I'd like to rename them with a more explicit name...
1204 - CMakeLists.txt: changed accordingly.
1205 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1206 including each header needed).
1208 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1210 test suite to the Example directory. Are concerned:
1215 - TestWriteSimple.cxx
1216 * Test/CMakeLists.txt: added some comments on reasons for black listing
1217 image gdcmData/oldACR00001.ima
1219 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * Test/CmakeList.txt: removed the following from black list (to be coherent
1221 with removal from gdcmData):
1222 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1223 - gdcm-MR-PHILIPS-16.dcm
1225 Added the following because after last cvs update, they cause
1226 ctest -R TestReadWriteReadCompare
1228 - gdcm-MR-SIEMENS-16-1.acr
1230 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1231 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1232 new comments in this file) we temporarily (sigh) move to a weaker
1234 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1235 we don't need to black list the following images anymore:
1236 - 8BitsUncompressedColor.dcm
1238 - US-PAL-8-10x-echo.dcm
1239 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1240 fixes and the beautified code ;-)
1241 This fixes the bug introduced in version 1.42 (when beautifying)
1242 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1243 Note: ctest was blind to this bug (this means we need to still
1244 improve the test suite). The bug could be detected by using
1245 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1247 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1248 and by displaying the (garbage) produced file temp.XDCM...
1250 2004-06-29 Jean-Pierre Roux
1251 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1252 - replace by uggly but working old code :-(
1253 A lot of things should be OK again.
1254 It's really urgent to have a test suite that *tests*,
1255 to prevent Frog's beautifying sessions to break all the stuff
1256 (twice, withing a fortnigh ...)
1258 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1260 redundancy) to added Test/TestReadWriteReadCompare.cxx
1261 * Test/CmakeList.txt: because the compare test of
1262 Test/TestReadWriteReadCompare.cxx fails, the following images are
1263 black listed: - 8BitsUncompressedColor.dcm
1265 - US-PAL-8-10x-echo.dcm
1266 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1267 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1268 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1269 and ad-hoc kludge. This kludge is now removed, and on encountering
1270 such an image (OB field brain damaged) we set errno. Then in
1271 ::FindDocLength() we "fix" the length as being ALL what remains
1272 in the file (until EOF). We then proceed, hoping for the best...
1273 This fixes a SegFault in ShowDicom when trying to write such an
1275 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1276 (because TestWriteRead breaks on it, after a non conformal commit?).
1277 ctest now runs properly, except for MakeDicomDir (which was always
1278 broken) and the Python related stuff (still not fixed).
1280 2004-06-24 Jean-Pierre Roux
1281 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1282 FIX : Test/TestReadWrite now iterates on all the file names
1283 (instead of infinite loop)
1284 ENH : Test/TestWriteRead now iterates on all the file names
1286 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1289 2004-06-24 Jean-Pierre Roux
1290 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1291 when SamplesPerPixel =3
1292 - now Write is no longer confused by
1293 'BitsAllocated = 12" and 'BitsStored=12"
1294 - "UN" value representation Elements are now written correctly
1295 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1296 ENH : - now gdcmHeader has its own Write methods
1297 (in order to split the job that has not to be done
1300 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1302 loop on the same image until memory went out.
1303 Note: this means we still have gobs of memory loss in PrintDocument
1304 * src/gdcmDocument.cxx: fixes problem on parsing on file
1305 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1307 2004-06-24 Jean-Pierre Roux
1308 FIX : Write - All the Sequences and Sequence Item are now written
1309 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1310 is added a the end, when necessary.
1311 - A lot of brain-damaged images, that were read correctly are
1312 now written correctly
1313 - length compatible BinEntry are now loaded correctly
1314 (even for odd groups)
1315 Note : only Explicit Value Representation was checked.
1316 (question : is implicit VR really necessary for gdcm ?)
1318 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1319 * DEVELOPPER: added a proposition of coding style.
1320 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1323 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1325 Use the gdcmDocEntry::Print() and Write() instead.
1326 * src/gdcmDocument.cxx: bug fix.
1328 2004-06-22 Jean-Pierre Roux
1329 FIX : gdcmDocument.cxx
1330 - Now we do recognize the JpegLossLess format (there was a misstyping in
1331 code 'beautyfication' :-(
1332 - Now we automaticaticaly load the Luts, if any
1334 2004-06-22 Jean-Pierre Roux
1335 In order : to write Sequences, whatever their imbrication level,
1336 : to allow user to create his own Sequences
1337 a lot of modif where necessary (adding, moving, or virtualising methods)
1339 WARNING : save your own sources *before* cvs up !
1342 ADD virtual void Write(FILE *fp, FileType filetype);
1345 ADD virtual void Write(FILE *fp, FileType filetype);
1346 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1349 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1350 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1351 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1352 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1353 ADD std::string GetEntryByName(TagName name);
1354 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1356 std::string vr = "unkn",
1357 std::string fourth = "unkn",
1358 std::string name = "unkn");
1359 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1360 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1361 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1362 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1363 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1364 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1365 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1366 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1369 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1370 ADD virtual std::string GetEntryByName (TagName tagName);
1371 ADD virtual std::string GetEntryVRByName (TagName tagName);
1372 REM virtual bool Write(FILE *, FileType);
1373 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1374 FILE *_fp, FileType type);
1375 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1376 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1377 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1378 REM virtual std::string GetEntryByName (std::string tagName);
1379 REM virtual std::string GetEntryVRByName (std::string tagName);
1380 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1381 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1382 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1384 std::string vr = "unkn",
1385 std::string fourth = "unkn",
1386 std::string name = "unkn");
1387 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1388 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1389 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1390 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1393 ADD virtual void Write(FILE *fp, FileType filetype);
1396 ADD virtual void Write(FILE *fp,FileType filetype);
1399 ADD virtual void Write(FILE *fp, FileType filetype);
1400 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1401 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1402 REM std::string GetEntryByName(TagName name);
1405 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1407 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1409 The default constructor invoked by the line
1410 gdcmHeader *f1 = new gdcmHeader( header );
1411 was gdcmHeader::gdcmHeader(bool) instead of the expected
1412 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1413 Hence the parsing wasn't executed... See also below.
1414 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1415 as explicit constructor didn't do the trick to fix the above problem.
1416 Could anyone explain why ?
1417 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1418 properly calls gdcmValEntry::Print() (that was weed out from
1419 code related to gdcmBinEntry).
1421 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * In order to fix memory leaks:
1423 - Test/TestWriteSimple.cxx: added cleaning of free store through
1425 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1426 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1427 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1428 (through the call to ::AddDicomDirMeta()) or the destructor
1429 would crash when deleting uninitialized ::metaElems].
1430 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1431 - src/gdcmDocument.cxx:
1432 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1433 from dynamic stores.
1434 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1435 was causing memory leaks.
1436 - src/gdcmSQItem.cxx:
1437 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1438 cleanly handled with polymophism: sorry but my milage is low).
1439 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1440 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1441 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1442 This avoids SegFaulting.
1443 - src/gdcmSQItem.h: coding style.
1445 - Test/TestWriteSimple still severely sucks. The output image content
1446 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1447 damaged when displayed with vtkgdcmViewer.
1448 - on memory leaks: TestWriteSimple leaks really less (see entry
1449 of 2004-06-18 in Changelog file for the call to valgrind).
1450 - on segfaults: ctest now passes all the tests but one (no more
1452 * Erroneous leading white fix:
1453 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1454 white[s] (as opposed to from >> xxx, that removes it [them].
1455 - src/gdcmTS.cxx: ditto.
1456 - gdcmPython/testSuite.py: dirty related kludge removed.
1457 * src/*: remaining references to gdcmParser removed.
1458 * src/*[cxx|h]: added copy[way]left header.
1461 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1462 * In order to fix writing of dicom files:
1463 - Test/TestWriteSimple.cxx: a simpler example of writing.
1464 - Test/CMakeLists.txt changed accordingly.
1465 - src/gdcmDocument.cxx:
1466 -- The destructor now recursilvely removes potential sequences.
1467 -- Bug fix in ::IsJPEG2000()
1468 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1469 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1471 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1472 to only declared) and build on top of
1473 ::GetDocEntryByNumber(guint16, guint16).
1474 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1475 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1476 for usage in destructor and treatement of promotion in
1477 ::ReplaceOrCreateByNumber().
1478 - src/gdcmSQItem.cxx: destructor should better handle his job.
1479 Test/TestWriteSimple now runs (or at least it DOES something).
1480 * We can now start hutting memory links. A good starting point is:
1481 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1482 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1483 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1485 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * Valgrind note: after Mathieu Malaterre teached me how to read
1487 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1489 Using gcc, you can force the STL to use malloc and to free memory as
1490 soon as possible by globally disabling memory caching.
1491 With 3.2.2 and later, you should export the environment variable
1492 GLIBCPP_FORCE_NEW before running your program.
1493 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1494 simply vanish (it is still not clear to me, whether this means that
1495 STL std::string leaks or if valgrind believes it leaks...).
1496 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1497 running bin/gdcmTests makeDicomDir):
1498 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1499 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1501 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1502 SegFaulting (I drowned in DicomDir related code when trying to
1503 understand why the list is empty...).
1504 * src/gdcmDocument.h: first BSD license header try.
1505 * Doc/License.txt added.
1507 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1508 * src/gdcmDocument.[h|cxx]:
1509 - Clean up of the Transfer related predicates. They are now all based
1510 on new method isGivenTransferSyntax, that (should) handle properly
1511 the padding problem.
1512 - general clean up, simplification, and coding style.
1513 - Specific clean up of Parse7FE0() (umproperly named actually).
1514 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1516 2004-06-14 Jean-Pierre Roux
1518 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1519 - fix the display of SQItem ordinal number
1520 - add the GetSQItemByOrdinalNumber method
1521 - remove some useless never written private methods
1523 2004-06-14 Jean-Pierre Roux
1525 - adding a constructor taking a gdcmDocEntry as an input param
1526 - ReplaceOrCreateByNumber now returns :
1527 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1528 a gdcmValEntry * if a string value is passed as a param
1530 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1531 according to the param type (no longer sets a gdcmDocEntry)
1532 - GetValEntryByNumber, GetBinEntryByNumber added
1533 - NewValEntryByNumber and NewBinEntryByNumber added
1535 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1537 - GetSQItemNumber and SetSQItemNumber added, to provide
1538 a (relative) Item identier inside a given Sequence
1539 \warning : some pb remaining around this number
1541 - AddEntry now takes the Item Number as a param
1543 - adding a constructor taking a gdcmDocEntry as an input param
1545 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * Memory leak hunt with the following command:
1547 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1548 --show-reachable=yes gdcmTests PrintDocument
1549 It looks like many (all?) leaks are due to the STL (or a bad usage
1550 of the STL. The lines producing the leaks now have a comment with
1551 a "MEMORY LEAK" tag: you can retrieve them with
1552 grep "MEMORY LEAK" src/*
1553 Here are two typical examples which I can't help fixing:
1558 char * test = "babo";
1559 name = test; //// <--- valgrind detects 960 bytes lost in
1560 //// call to std::string::operator=(char const*)
1561 name.clear(); //// Doesn't help !
1569 std::cout << "Type a bunch of characters followed by RETURN: ";
1570 getline(std::cin, line); //// <--- valgrind dectects a loss
1571 //// of 1320 bytes in call to
1572 /// std::basic_istream<>& std::getline<>
1578 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * src/gdcmHeader.[cxx|h]:
1580 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1581 and related, moved away to gdcmDocument.
1582 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1583 the corresponding protected accessors of inherited class
1584 gdcmDocument, removed ! As a consequence gdcmFile had to be
1585 declared friend of class gdcmDocument (see below).
1586 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1587 - Clean up of undefined or unused methods.
1588 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1589 account the changes to gdcmHeader.h).
1590 * src/gdcmDocument.h:
1591 - gdcmFile is now a friend class (in order to take into account the
1592 changes to gdcmHeader.h).
1593 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1594 (see changes to gdcmHeader.h).
1595 - Accessors (reading on the form GetEntry*) are now public.
1596 - Clean up of undefined or unused methods.
1597 * src/gdcmDocument.cxx:
1598 - adaptation to changes to gdcmDocument.h
1599 - ::OpenFile now writes a verbose message when file cannot be opened.
1600 - some std::string properly set to VRKey
1601 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1602 references to gdcmDocument.
1603 * Test/TestFindTags.cxx: changed accordingly to above changes.
1604 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1605 cvs repository gdcmData.
1607 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1608 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1609 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1610 conflicts with gdcmValEntry::voidArea.
1611 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1612 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1613 Value representation between StringRepresentable and BinaryRepresentable.
1614 * src/gdcmDocument.cxx:
1615 - method ParseDES: proper indentation restored and usage of
1616 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1617 - method LoadDocEntry: the fingerprint left in the SetValue() of
1618 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1619 removed. Reverting to previous code segment with the proper
1620 dynamic_cast< gdcmValEntry* >.
1621 Note: this was (partially) breaking the python test suite
1622 (gdcmPython/testSuite.py) that made usage of the above
1623 fingerprint to check presence of "Pixel Data".
1624 * src/gdcmDocEntry.h: coding style.
1625 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1626 now taken into account.
1627 * gdcmPython/gdcm.i: adaptation to the new internal representation
1628 of gdcm (exit gdcmParser, hello gdcmDocument).
1629 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1631 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1632 anymore, but instead prints the loaded Python dictionary.
1633 * .... alas, the python testSuite is still broken.
1635 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1636 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1638 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1639 * src/gdcmUtil.h : export methods
1641 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1642 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1644 * Initial addition of automatic python testing
1645 * Initial addition of automatic image comparison
1647 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1648 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1649 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1651 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1652 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1653 * Test/ShowDicom.cxx : bug fix for msvc compilation
1654 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1656 2004-05-04 Jean-Pierre Roux
1657 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1658 new concepts (and new classes) :
1659 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1660 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1661 - Sequence Doc Entries (gdcmSeqEntries)
1662 a Sequence is composed of Items.
1663 Each item is a set of Doc Entries (this is recursive)
1664 The non uniqueness of the 'Dicom tag' is due to this recursivity
1665 (never taken into account)
1666 Our unability to add a new 'entry' in the header
1667 at the proper location (neither in the H-Table (map or multimap),
1668 nor in the Chained List is also due to this recursivity.
1669 Don't try, right now, to use/modify/compile these new sources :
1670 nothing is finished.
1671 We just commit all the stuff, 'as is', in order not to loose it.
1673 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1674 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1676 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1677 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1678 file prefix (SetFilePrefix)
1680 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * Add a new test: ShowDicom, for now this is just the c++ version of
1682 checkRead.sh, later it will be able to compare the image read against a
1684 * Replace the DEBUG on the stack with a global entry in cmake interface:
1685 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1687 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * Add an example subdir, with a real example on how to read + write a
1691 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1693 * Doc/CMakeLists.txt: the main page is now properly differentiated
1694 between the developper and user version.
1695 * Doc/doxygen.config.in: dropped search related obsolete flags
1696 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1698 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * DEVELOPPER: added some helpfull comments for compile/test/install
1702 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1703 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1704 src directory, now generated in the build dir.
1705 2. Tests as mentionned smarter
1707 4. Add a new method in gdcmDict that return the PubDict by name
1708 this is interesting for 3rd party lib like ITK,
1709 where we could set the institution name / patient name...
1711 * ENH: 1. Now the test suite is working for real
1712 2. All binaries are now output in the gdcm-bin directory
1713 (this was not true before)
1715 2004-04-28 Jean-Pierre Roux
1716 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1717 SeQuence indented printing of Dicom Header.
1718 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1719 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1720 Computation of SQDepthLevel is now part of gdcmHeader constructor
1721 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1722 tree-like structure of a Dicom Header.
1723 * FIX Test code cleaning
1725 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * ENH: Adding automatic testing
1727 1. Need a DartConfig.cmake to submit to public
1728 2. Add a test driver gdcmTest.cxx
1729 3. gdcmTestMain, an helper for the main test driver gdcmTest
1730 4. Files in Test don't have a main anymore, this becomes interesting
1731 when we add more and more tests, thus dsw don't have to load
1733 * ENH: Adding a GDCM_DATA_ROOT for testing
1734 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1735 one file instead of seven + some small cleanup
1737 2004-04-22 Jean-Pierre Roux
1738 * ENH Minor changes to the Print() methods.
1739 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1740 Header printing. Example given with :
1741 > PrintHeader fileName 2 new
1742 (SQ based tree-like structure still to be done for the Header ...)
1744 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1746 1. I have added some unsigned where needed
1747 2. Some function parameter not used -> (void)
1748 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1749 4. g++ don't like character '\' in comment
1750 5. #define jpeg_create_decompress jCreaDecompress
1751 this really need to be fixed
1752 6. virtualize destructor of gdcmObject ... leakage
1753 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1754 this also really need to be fixed
1755 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1756 remove compression file
1757 (as we only do decompression, right ?)
1758 * ENH: Change malloc/calloc/free with c++ equivalent
1760 2004-04-21 Jean-Pierre Roux
1761 * FIX gdcmHeaderHelper::GetXSpacing
1762 when a single value is found (bug ?), xpacing is now
1763 defaulted to yspacing
1765 2004-04-19 Jean-Pierre Roux
1766 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1767 * ENH add parameters :
1768 bool exception_on_error = false,
1769 bool enable_sequences = false,
1770 bool ignore_shadow = false
1771 to the gdcmFile constructors to be full gdcmParser compliant
1772 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1773 to allow reading of PAPYRUS 3.0 files
1775 2004-04-06 Jean-Pierre Roux
1776 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1778 2004-04-02 Jean-Pierre Roux
1779 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1780 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1781 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1783 2004-03-30 Jean-Pierre Roux
1784 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1785 for ACR file, written out as DICOM files (hope so...)
1787 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1789 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1790 moved to base class gdcmParser and only the specialisation is kept
1792 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1793 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1794 already does the job.
1795 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1796 (to be consistent with gdcmParser::WriteEntries).
1798 2004-03-30 Benoit Regrain
1799 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1800 upate of the object's instance. It's passed to 2 in the unfavorable
1801 case : one in the ExecuteInformation, one in the ExecuteData
1803 2004-03-29 Jean-Pierre Roux
1804 * ENH : Check on file type to be written moved
1805 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1806 * FIX : gdcmObject::ResetBoundaries now stops properly
1807 when end-of-list is reached
1808 : gdcmVersion modified (as Benoit Regrain asked)
1810 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1812 * src/gdcmUtil.cxx: added forgotten iostream include.
1813 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1814 equivalent to ExplicitVR in existing code).
1816 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1817 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1818 now contains all the gdcmGlobal related code.
1819 * minor coding style and doxygenation changes.
1821 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1823 now contains all the Debug related code.
1824 * minor clean-up of includes in src/*.cxx
1825 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1826 CreateCleanString) removed.
1827 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1828 * Doc/DoxyMainPageUser.txt added.
1829 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1830 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1831 src/gdcmDirList.cxx)
1833 2004-03-24 Jean-Pierre Roux
1834 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1836 2004-03-23 Jean-Pierre Roux
1837 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1838 big endian made volumes
1839 * ENH Now gdcmParser constructor and destructor are protected to forbid
1840 end user to instanciate class gdcmParser
1841 (only gdcmHeader and gdcmDicomDir are meaningfull)
1843 2004-03-22 Benoit Regrain
1844 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1845 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1846 gdcmSerie to gdcmDicomDirSerie
1848 2004-03-19 Jean-Pierre Roux
1849 * ENH Now the tree-like structure describing a DICOMDIR comming from
1850 an already existing DICOMDIR file is consistent with
1851 the home-made tree-like structure build ex-nihilo
1852 or build from the files held (recursively) in a Directory
1853 functions gdcmDicomDir::CheckBoundaries()
1854 gdcmObject::SetBoundaries() added
1856 2004-03-17 Jean-Pierre Roux
1857 * REM (Eric Boix bug) : removal of meaningless
1858 gdcmDicomDirImage::NewImage function.
1859 * FIX now file names and directory name are written properly in the
1861 * FIX now gdcmDicomDir constructor may be call without any trick
1864 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1866 of gdcmDicomDirImage::NewImage as empty function.
1868 2004-02-28 Jean-Pierre Roux
1869 * ENH add gdcmDicomDir:NewPatient
1870 add gdcmDicomDirPatient:NewStudy
1871 add gdcmDicomDirStudy:NewSerie
1872 add gdcmDicomDirSerie:NewImage
1873 to allow making gdcDicomDir object.
1874 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1875 (as opposite to the gdcmHeader chained list)
1877 2004-02-11 Benoit Regrain
1878 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1879 when using from python
1881 2004-02-10 Benoit Regrain
1882 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1883 * FIX : in gdcmDicomDir when the directory is empty
1884 * ENH : add callback and methods to get the progression of dicomDir
1887 2004-02-06 Jean-Pierre Roux
1888 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1889 - GDCM_META added to gdcmDicomDirType
1890 - class gdcmMeta created
1891 * ENH : - A brief summary is now displayed at the beginning of
1892 'testDicomDir' to help disaster magnitude estimation
1893 * REM : Now useless Test/explDICOMDIR.cxx
1895 2004-02-05 Benoit Regrain
1896 * ENH : add methods in gdcmObject to get the hash table or the list of
1898 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1899 * FIX : wrapping python for TagHeaderEntryHT
1901 2004-02-04 Benoit Regrain
1902 * FIX : even length for some strings when writting the dicom dir
1903 * FIX : sort the images in the dicom dir
1904 * FIX : Bug fix for python use of dicom dir
1905 * ADD : a python demo
1907 2004-02-04 Jean-Pierre Roux
1908 * FIX : Final solution (?) for icone embedded images
1909 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1910 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1911 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1912 gdcmData/gdcm-MR-SIEMENS-16.acr1
1913 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1914 to make full checking easier
1916 2004-02-04 Benoit Regrain
1917 * FIX : WriteEntries : coding style & logic in parameters
1918 * FIX : Set the elements to create the DicomDir in a dictionary file
1920 2004-02-03 Benoit Regrain
1921 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1922 * gdcmDicomDir : add the load of directory
1923 * Bug fix and print add-on
1925 2004-02-03 Jean-Pierre Roux
1926 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1927 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1928 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1929 * FIX gdcmParser.cxx : 'group length' elements are now considered
1930 as integers, even for shadow groups, when file is Implicit VR
1932 2004-02-02 Jean-Pierre Roux
1933 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1935 of the last synonym :-(
1936 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1938 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1939 * FIX taking into account the possible 7fe0,0010 multiplicity
1940 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1941 to allow removal of references to 7fe0,0010, to deal with
1942 ACR-NEMA images, when 0028,0200 is meaningfull
1944 2004-01-31 Jean-Pierre Roux
1945 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1946 no longer writes 'Un' on disk
1947 * FIX SQ elements with actual length are now dealt with corectly
1948 * FIX gdcmFile::WriteBase make the difference, for color images, between
1949 the length (for Palette expanded images)
1950 and Raw Length (non expanded image + Palette)
1951 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1952 (that broke Write). Replaced by UL.
1953 Aware user will reload the field if he
1954 thinks it's necesssary
1956 2004-01-30 Jean-Pierre Roux
1957 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1958 when 'dirty Acr' is found, to be compliant with the new
1959 IsReadable() methods.
1961 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1962 (no DOUBLE images in kosher DICOM,
1963 but so usefull for people that miss them ;-)
1965 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1966 DICOMDIR related utilities (not checked as Windoze compliant)
1968 2004-01-28 Jean-Pierre Roux
1969 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1971 2004-01-27 Jean-Pierre Roux
1972 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1973 to allow skipping the shadow elements, to save memory space.
1974 The TRUE value for this param has to be used
1975 with a FALSE value for the 'enable_sequence' param.
1976 ('public elements' may be embedded in 'shadow Sequences')
1977 * gdcmHeader methods now deal with 'embedded icones images' in the header
1978 (even when an 'icone image sequence' is announced by the
1979 element (0x0088,0x0200), but there is NO icone at all ...
1981 * gdcmHeader sometimes Image Location value doesn't follow
1982 the supposed processor endianity (see gdcmData/cr172241.dcm).
1985 * gdcmHeader add the method
1986 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1987 to get *all* the Header Entries with the same tag.
1988 GetHeaderEntrySameName is probabely *useless*
1989 (no meaning : Name is *not* an identifier within the Dictionary)
1991 2004-01-26 Benoit Regrain
1992 * Bug fix in the print of hexadecimal representations. Remove long fields
1993 in the print and add a third level of print to print them
1995 2004-01-23 Benoit Regrain
1996 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1997 * Bug fix on test suite after remove the strip made on not string fields
1998 * Split the IsReadable method between gdcmParser which test that the file
1999 is dicom and gdcmHeader which test that it's an image file
2001 2004-01-22 Benoit Regrain
2002 * DicomDir : clean code, add methods, set variables in protected or private
2003 * gdcmUtil : bug fix for the clean string method
2005 2004-01-19 Benoit Regrain
2006 * Add the use of shadow dictionaries
2007 * bug fix and coding style
2009 2004-01-19 Benoit Regrain
2010 * src/gdcmFile.cxx : bug fix concerning the close of file
2011 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2012 * Add the update of header entries using the shadow library
2014 2004-01-19 Benoit Regrain
2015 * removal of file gdcmHeader2.cxx
2016 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2017 inheriting from gdcmParser. This split is to prepare the integration
2018 of dicom dir parsing
2019 * bug fix under python
2021 2004-01-16 Jean-Pierre Roux
2022 * REM removal of class gdcmHeaderEntrySet
2023 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2024 * ADD add file gdcmHeader2.cxx
2025 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2027 2004-01-15 Benoit Regrain
2028 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2029 entries created while parsing the header. Thus, they will be destroyed
2030 when the gdcmDictSet will be destroyed
2031 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2034 2004-01-15 Benoit Regrain
2035 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2036 made a fatal error because of the memory release at the end of program.
2037 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2038 some memory and vtk seems to have some problems with that.
2039 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2041 2004-01-14 Benoit Regrain
2042 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2043 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2044 * src/*.[h|cxx] : make changes due to class name changes
2045 * gdcmPython/demo/*.py : bug fix due to method names
2047 2004-01-13 Benoit Regrain
2048 * src/*.[h|cxx] : coding style
2049 * vtk/*.[h|cxx] : coding style
2051 2004-01-13 Benoit Regrain
2052 * gdcmPython/testSuite.py : test the readable flag of file for tests
2053 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2054 It's lied to the stl compilation by MSVC (windows, always windows...)
2055 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2057 2004-01-12 Benoit Regrain
2058 * src/*.h : add comments
2059 * src/gdcmDictSet.h : set the method BuildDictPath in public
2060 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2061 directly setted in the source code
2062 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2065 2004-01-09 Benoit Regrain
2066 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2067 * setup.py : use a reference to gdcmVERSION
2069 2004-01-07 Benoit Regrain
2070 * Modification to compile with the distutils.
2073 2003-12-10 Benoit Regrain
2074 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2075 can use a gdcmHeaderHelper to load data
2076 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2077 made in the source code
2079 2003-12-10 Benoit Regrain
2080 * Update Windows projects and .cvsignore files
2082 2003-11-12 Jean-Pierre Roux
2083 * ENH gdcmHeader constructor has one more parameter (default value : false)
2084 that allows the user to 'go inside' the SeQuences only
2086 gdcmElValSet:Print takes it into account
2088 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2089 * ENH: Update gdcmPython/CMakeLists
2090 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2091 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2093 2003-11-10 Jean-Pierre Roux
2094 * FIX : gdcmHeader::LoadElements is now based
2095 on the ListTag listElem member,
2096 not longer on the TagElValueHT tagHt member
2097 * ENH : PrintPubElVal shows (temporarily) both results,
2098 with the tagHt member and the listElem member.
2099 (it's easier to 'see' the problems when using Printheader)
2101 * FIX : old private member LgrElem is now splitted into
2102 ReadLength : Length actually found on disk (updated only
2103 if bug fixing is necessary), for internal
2105 UsableLength : Updated by FixFoundLength, to fix a bug
2106 or to allow Parser going on.
2107 Will allow to re-write a kosher header when a SeQuence
2108 with a length (not 0000) is found
2109 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2110 because gdcmElValSet::Add does not update ListElem
2113 2003-11-07 Jean-Pierre Roux
2114 * FIX misstyping in Transfert Syntax name table
2115 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2116 when they have an actual length (not 0000 nor FFFFF)
2117 (Nobody should care of it, but DICOMDIR explorers)
2119 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2120 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2122 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2123 * ENH: vtkGdcmReader now supports LUT !
2124 (vtkgdcmViewer for now is not able to use them though)
2126 2003-11-05 Jean-Pierre Roux
2127 * in testSuite.py : new files names for checking the package
2128 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2129 that returns the pixel area size to the *aware* (vtk) user
2130 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2132 2003-11-05 Benoit Regrain
2133 * in testSuite.py : Modify the rules for checking the paths
2134 : Explicit error messages
2135 * in __init__.py : Related modif
2137 2003-11-03 Jean-Pierre Roux
2138 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2139 to be used by aware (vtk) users that want to manage
2140 LUT (and no to turn the PALETTE image into an RGB pixels one)
2141 * GetPixelType now returns 8U for 24 Bits images
2142 (vtkGdcmReader compliant)
2144 2003-10-31 Jean-Pierre Roux
2145 * Removal of *all* gdcmData images and add them again
2146 in order to loose the 'history' of un-anonymised images
2148 2003-10-31 Jean-Pierre Roux
2149 * RMV : removal of useless jBitsInJsample.h
2150 for both 8 and 12 Bits JPEG Lossy Libraries
2152 2003-10-31 Jean-Pierre Roux
2153 * ENH : Add the functions gdcmFile::GetImageDataRaw
2154 gdcmFile::GetImageDataIntoVectorRaw
2155 that act as GetImageData and GetImageDataIntoVector
2156 except the making of an RGB Plane from Gray Plane + LUT
2157 Intended to aware (vtk) users who know how to manage
2160 GetLUTRGBA return a R,G,B,A LUT if any
2161 lgrTotaleRaw gives the 'Raw' length
2162 GetImageDataRaw returns the gray Plane
2163 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2164 (They stay Grey, just like with other Dicom viewers :-(
2166 2003-10-30 Jean-Pierre Roux
2167 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2169 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2171 being coherents dicom files.
2173 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2174 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2176 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2177 * ENH: Two steps is necessary to please VC++ compiler...
2178 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2179 * ENH: Add include dir to medcon lib
2180 * FIX: only one function is being exported for now !
2181 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2183 2003-10-29 Jean-Pierre Roux
2184 * adding gdcmHeader::GetLUTRGBA
2185 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2186 --> Mathieu, the modif u're waiting for is not yet committed
2187 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2189 2003-10-27 Jean-Pierre Roux
2190 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2191 00191113.dcm DermaColorLossLess.dcm
2192 MxTwinLossLess.dcm RadBWLossLess.dcm
2193 * ENH: For version prior to vtkImageViewer2 -r 1.19
2194 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2196 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * Removal of ido stuff in CMakeLists.txt
2199 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2200 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2201 * FIX: remove a call to ->Modified ... see comments
2202 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2204 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2205 * FIX: Problem with path for libvtkgdcmPython
2206 * ENH: Try adding a search script for python site-package
2207 * RMV: Remove some file from medcon lib that are not necessary
2208 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2209 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2210 * FIX: More pragma disable fro VC++,
2211 I don't think I break something as it is also disable in VTK/ITK.
2212 But it fasten debug compilation time.
2214 2003-10-23 Jean-Pierre Roux
2215 * gdcm now deals with 16 Bits Run Length Encoded images
2216 (they are compressed as 2 planes images,
2217 one for the high Bytes, the other for low Bytes)
2219 2003-10-22 Jean-Pierre Roux
2220 * Now CheckRead takes into account :
2221 - the bugged 'Leonardo' Siemens images
2222 - the XA images, sent thru the burning VPRO station
2223 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2226 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2227 * FIX: When copying a Makefile.am to CMakeLists.txt
2228 one should remove the '\'
2230 2003-10-22 Jean-Pierre Roux
2231 * in gdcmData adding a bugged 'Leonardo' Siemens image
2232 (wrong lengths in header)
2233 OK with gdcm, KO with the other viewers :-)
2234 * add a GE dlx XA image, thru the VEPRO burning station
2237 2003-10-21 Jean-Pierre Roux
2238 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2239 for a brutal checking of vtkgdcmViewer compliance
2241 2003-10-21 Jean-Pierre Roux
2242 * add the files for 'xmedcon' Jpeg Lossless library
2243 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2245 2003-10-21 Jean-Pierre Roux
2246 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2248 2003-10-21 Jean-Pierre Roux
2249 * garbage Siemens 'Leonardo' images dealt with
2250 (the patch is easy to remove)
2251 * cosmetic changes to avoid warnings
2253 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2254 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2255 no need to press 'r' now.
2257 2003-10-20 Jean-Pierre Roux
2258 * upgrade of checkRead.sh checkWrite.sh according
2259 to new Jpeg Lossless decompressor
2260 * add US.3405.1.dcm, a genuine RGB medical file ...
2261 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2262 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2264 2003-10-15 Jean-Pierre Roux
2265 * general anonymisation in gdcmData
2266 * adding the 'color files' from
2267 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2268 * adding some well knowed bugged-header images
2269 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2270 waiting for their inclusion in Python testsuite
2272 2003-10-15 Jean-Pierre Roux
2273 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2274 no longer seg faults when file is not found
2276 2003-10-14 Jean-Pierre Roux
2277 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2280 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * TODO: *.in file to genereate a UseGDCM later
2283 2003-10-14 Jean-Pierre Roux
2284 * Some supposed-to-be Dicom Images have no preamble.
2285 OpenFile takes it into account
2286 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2287 * Missing elements added in dicomV3.dic
2288 (just to be affraid : have a look at
2289 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2290 and do it again next year ;->
2292 2003-10-13 Jean-Pierre Roux
2293 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2294 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2295 But there are NOT. It's fixed !
2297 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * FIX: "jpeglib.h" was not found on VC++
2299 * FIX: vtkgdcm was not being installed
2301 2003-10-10 Jean-Pierre Roux
2302 * ENH : OpenFile closes the file if it *really* doesn't look like
2303 an ACR-NEMA / DICOM one.
2304 * FIX : testWrite no longer writes an empty file if the source file
2305 is not gdcm Readable
2306 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2309 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2310 * FIX: CMake generate now documentation
2311 * ENH: out of source doc build !
2312 * ENH: Generate both user and dev documentation
2313 * ENH: Should work on windows too
2314 * ENH: Only one doxygen config.in file is needed
2315 * FIX: make install should be ok now on ùnix plateform
2316 * FIX: PATH to dictionary was wrong (missing /)
2317 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2319 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2320 * vtkGdcmReader is now able to read rgb dicom file.
2321 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2322 * added a gdcmViewer to vtk test, use mouse to control
2323 window level & window width
2325 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2326 * CMake-ification of gdcm, we have now two build system
2327 * FIX: on cygwin Wsock32 doesn't exist
2328 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2330 2003-10-06 Emanuel Ollart
2331 * FIX : compilation process wad broken.
2332 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2334 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2335 * change gdcmViewer -> vtkgdcmViewer
2336 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2338 2003-10-06 Jean-Pierre Roux
2339 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2340 ( e.g : well known GE images with a wrong elem length,
2341 : Philips MRI Images with a wrong Huffman table)
2342 * still to be done : allow the reading of bugged LEONARDO Siemens images
2344 2003-10-03 Jean-Pierre Roux
2345 * Odd length strings are padded with '\0' (not with spaces,
2346 to remain compliant with already defined strings,
2347 like Transfert Syntax UID and others)
2349 2003-10-03 Jean-Pierre Roux
2350 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2351 to allow displaying RGB images (not only by affim ;-)
2353 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * vtkGdcmReader is now able to read rgb dicom file.
2355 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2357 2003-10-03 Jean-Pierre Roux
2358 * A few nasty patches to allow the reading of a lot of nasty images
2359 ( e.g : well known GE images with a wrong elem length,
2360 : Philips MRI Images with a wrong Huffman table)
2361 * still to be done : allow the reading of bugged LEONARDO Siemens images
2363 2003-10-03 Jean-Pierre Roux
2364 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2366 2003-10-03 Jean-Pierre Roux
2367 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2368 to allow displaying RGB images (not only by affim ;-)
2370 2003-10-03 Jean-Pierre Roux
2371 * gdcmFile::GetImageDataIntoVector now
2372 - deals with MultiFrames MultiFragments Run Length Encoded files
2373 - deals with YcBcR (YBR_FULL) files
2374 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2375 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2377 (no sample found :-(
2379 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2380 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2381 Two reasons: - clear things
2382 - third parties acces gdcm through header files, so won't
2383 suffer anymore VC++ complains
2385 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2386 * add argv[1] in testvtkGdcmReader.cxx
2389 2003-09-24 Jean-Pierre Roux
2390 * The lines are now eigthy characters long.for
2391 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2393 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2394 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2395 char* to std::string. Thus, the use of strdup becomes useless. (see
2396 previous commis of Malaterre)
2397 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2398 before the last Malaterre's commit.
2400 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * This commit should fix the Debug building under VC++, the problem
2402 was mainly a mixture of debug and release lib being loaded at startup.
2403 * I also remove a depency to a specific C function: strdup. Because I had
2404 to force the link to msvcrtd (whereas strdup is in libc).
2406 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2407 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2408 located in the gdcmCommon.h file. All use of reference of tha has been
2409 changed to now use the variable GDCM_UNFOUND.
2411 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2413 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2414 Dicom dictionary. The test suite can now be run again. Note:
2415 I'm note very happy with the " (RET)" changes. I believe this
2416 RETAINED comment should be dropped when parsing the dictionary.
2417 - PACKAGER corrected
2419 - AUTHORS updated and now in alphabetical order
2420 * Makefile.am now exports gdcm.dsw for Windoze users.
2422 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * cygwin complains about missing std:: in subdir Test/
2425 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2426 * remove some methods that are now in gdcmHeaderHelper
2428 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2429 * vtkGdcmReader set spacing and origin correctly
2431 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * Fix a few delete/delete[] mismatch
2434 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2436 interpretation to data given by gdcmHeader. For instance there are
2437 heuristics to get informations (look at different places).
2438 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2439 sorting DICOM images based on different strategies.
2440 * modified Makefiles accordingly.
2442 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2444 when building in debug mode
2445 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2446 src/win32/gdcmdll.dsp
2447 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2449 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2453 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2454 * src/win32/libgdcmjpeg12.dsp was not dos format
2455 * src/win32/libgdcmjpeg12.dsp :
2456 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2457 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2459 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2462 * src/gdcmFile.cxx : bug fix in affectation type
2463 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2464 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2465 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2466 symbols... future problem ?
2468 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2469 * src/win32/libgdcmijpeg12.dsp was missing
2470 * modified gdcm.dsw accordingly
2472 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2473 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2475 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2476 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2477 commit of JPR (before his hollidays to facilitate our work).
2478 * setup.py : bug fix in code. Modifications made while the last commit
2479 of JPR. The code hasn't been tested before the commit... it's so
2480 useless to make that (for best programmer that is JPR) !!!
2482 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * tagged the current version as Version0_3 (i.e. version 0.3)
2485 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2486 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2487 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2488 * *.dsp : modifications to use new libgdcmijpeg8 library
2489 * setup.py : bug fix on VTKPATH variable
2490 * PACKAGER : adding all concerning windows
2492 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2495 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2496 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2497 test suite reported error.
2498 * PACKAGER file added (describes what a packager must do when
2499 packaging a new release).
2500 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2501 * configure.in: upgraded version number to 0.3.0
2502 * fixing build of rpm (through rpm -ta):
2503 - Doc/Makefile.am exports proper doxygen files
2504 - src/jpeg/libijg8/Makefile.am exports the include files.
2506 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2507 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2508 * src/gdcmHeader.h : formatting code
2510 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2511 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2512 We were obtaining error message from vtk. Now, creation of file list
2513 is made in an internal list to prevent this problem.
2514 Bug fix when output is empty.
2515 Bug fix in update of progress value. Previous commit for this was a bad
2517 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2519 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2520 * src/gdcmHeader.h : added method to get the file name
2521 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2522 files. Added method to remove all files on the input
2523 Added FIXME comment concerning the bad parsing of header made by
2524 ExecuteInformation method (in ExecuteData method)
2526 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2528 when using make instal.
2529 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2530 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2532 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2533 * setup.py : adding include dir of jpeg lib to compile all sources
2534 * */Win32/*.dsp : JPR fix for windows compilation
2536 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2537 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2539 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2540 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2542 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * setup.py is again effective on un*x (takes into account the
2544 addon of the jpeg library)
2545 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2546 * Doc/Doxy* updated (includes above enhancements)
2547 * INSTALL now points to web documentation
2549 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * src/gdcmHeader.h doesn't make unnecessary reference to
2552 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2554 * src/gdcm*.[cxx|h] :
2555 - to allow compilation with gcc 3.x
2556 -- clean up of STL usage (added explicit usage of std::)
2557 -- small fixes on exceptions.
2558 Note: linking not tested !
2559 - clean of doxygen comments to avoid warnings at documentation
2561 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2562 dependent convertion).
2564 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * Clean up of previous JPR garbage commit (not even commented in the
2567 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2568 - moved all jpeg related files from src to src/jpeg/libijg8, with
2569 addition/modification of Makefile.am and configure.in.
2570 - the testSuite is still brain damage (not guilty).
2572 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2573 * WrapVTK.py : modifications to get correctly vtk source files to
2575 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2576 (FileName -> Filename)
2578 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * vtk/vtkGdcmReader.[cxx/h]:
2580 - UpdateProgress method should now be effective
2581 - removed the limitation on having only images loaded (as opposed
2583 - when building a stack of images/volume, a lesser number of
2584 gdcmHeader and gdcmFile instances should be used (hopefully
2585 accelerating things).
2586 - when building a stack of images/volumes, files which are not
2587 loadable (wrong path-filename, wrong permissions on existing file,
2588 or file not parsable by gdcm) are replaced with a black image
2589 in the stack (for the caller to notice the problem).
2591 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2594 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2595 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2596 between standard library (std) and vtk library (problems are found
2597 under Windows... thanks Windows !)
2599 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2602 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2604 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2607 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * When compiling with distutils (see setup.py) the C++ compiler is
2609 called with different flags than the default ones (with automake).
2610 In order to fix all those warning, I compiled gdcm with the command
2611 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2612 and went for warning fixes:
2613 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2614 up from unused variables.
2615 - vtk/vtkGdcmReader.cxx: potential bug fix.
2616 * src/gdcmHeader.h: Doxygen warning cleanup
2618 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * gdcmPython/gdcm.i:
2620 - typemaps correction to take into account the systematic replacement
2621 of "using namespace std" with std:: prefix e.g. std::list,
2622 std::string... (cf changes of 2003-05-21).
2623 - gdcmGlob global variable of type gdcmGlobal (defined in
2624 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2625 exported to Python a as cvar.
2626 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2627 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2628 gdcmDictSet.GetPubDictTagNames() and
2629 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2630 C++ static methods).
2631 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2632 with the above changes.
2634 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2635 * setup.py, manifest.in : bug fix under linux
2637 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2638 * Modification of setup.py to compile vtk part too. Then, we have 2
2639 wrappers which must work with same distutils. For that, we have a
2640 generic distutils in distusiltsWrapping.py ; with :
2641 - build_extWrap class to wrap generically all extensions,
2642 - ExtensionWrap base class for all wrapping extension that contains
2644 - Wrapper interface which wrap sources
2645 + In WrapSwig.py we have extension and wrapper for Swig
2646 + In WrapVTK.py we have extension and wrapper for VTK
2647 * MANIFEST.in : modifications to consider vtk directory and new python
2648 files for compilation
2650 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2651 * Added python wrappers of vtkGdcmReader vtk class (see the
2652 source in vtk/vtkGdcmReader.cxx) :
2653 - vtk/Makefile.am now builds a library
2654 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2655 python library (as opposed to _gdcm.so wich are the python
2656 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2657 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2659 - configure.in has an additional flag --enable-vtk that needs
2660 to be set to enable compilation of vtk related code, that is:
2661 + vtk/vtkGdcmReader.so and
2662 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2663 + gdcmPython/vtkgdcmPython.so (see above)
2664 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2665 be read when compressed or when HighBit + 1 != BitsStored),
2666 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2667 the usage of the python wrapper of vtkGdcmReader vtk class.
2668 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2669 * src/*.[h] all occurences of stl classes are now prefixed with
2670 std::, and all occurences of "using namespace std;" where removed.
2671 This is to avoid pollution of global namespace in included files.
2672 Apparently vtk does not avoid this pitfall: when using both
2673 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2674 collision of various stl members (principally cout...).
2675 * gdcmPython/testSuite.py now cleanly removes temprory generated
2677 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2678 comply with above changes)
2680 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2681 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2682 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2683 vtk data structure (an image Flip was required).
2684 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2685 * cosmetic changes in documentation.
2687 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2688 * src/gdcmHeader.cxx: the constructor no longer exits when an
2689 unexisting file is given as argument.
2690 * The subdirectory Data (containing all the images used for the
2691 test suite) is not part of this repository anymore. A new module
2692 containing those images is now available at
2693 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2694 with the name gdcmData.
2695 All the python scripts (including the package initialisation file
2696 gdcmPython/__init__.py) were adapated to take this change into
2697 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2699 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2700 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2701 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2702 demo of the usage of this class.
2703 Compilation of this vtk part is only done when using the --enable-vtk
2704 at configure (or autogen.sh) stage.
2706 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2707 * More memory link related corrections and documentation fixes.
2709 - maximum info is obtained with a command of the form:
2710 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2711 --show-reachable=yes PrintHeader
2712 - the remaining reachable blocks seem to come from the STL
2713 allocation scheme through the usage of map and list. It looks
2714 like this memory cannot be freed but it is not a memory leak
2715 (in fact further invocation to the STL would recollect the
2716 unused memory allthough it cannot explicitely be freed).
2717 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2718 of displaying an image parsed with gdcm and displayed with VTK.
2719 Note: some images don't seem to work e.g.
2720 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2721 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2722 Allthough this weakens the semantics, it is a ditch attempt to
2723 make gdcm more thread friendly.
2725 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2726 * Memory link hunt (by using valgrind through the command
2727 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2728 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2729 gdcmHeader::_dicom_vr.
2730 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2731 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2733 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2735 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2736 * src/Makefile.am now exports all the necessary include files at
2740 * UpdateGroupLength replaced by new one
2743 * UpdateGroupLength re-written using H-Table
2744 (named UpdateGroupLengthNew untill checks are over)
2746 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2747 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2748 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2750 - gdcmHeader::GetPubElValSet removed.
2751 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2752 UpdateGroupLength, WriteElements, Write.
2753 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2754 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2755 carried the same semantics.
2756 - src/gdcmHeaderIdo.cxx changed accordingly.
2757 - gdcmFile::WriteBase now regroups all the codes from previous
2758 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2759 - enum FileType moved to gdcmCommon.h
2760 * src/gdcmHeader.cxx AddDefault trashed
2761 * gdcmGetXSize added
2762 * getimageDataSize now calls gdcmGetXSize
2763 * Test/*.cxx changed to agree with above changes
2765 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2767 (to avoid double call by end user).
2768 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2769 by end user, since gdcmHeader::gdcmHeader now handles it.
2771 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * gdcm/Doc many doxygen changes:
2773 - Doxyfile now has two different versions, DoxyfileUsers that generates
2774 the html.users end users oriented documentation and
2775 DoxyfileDeveloppers that generates the html.developper developper
2776 oriented documentation.
2777 - README changed accordingly
2778 - requirement.txt removed (old design info moved to TODO).
2779 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2780 DoxyMainPage.txt, DoxyPython.txt provide more information.
2781 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2782 be updated by simply regenerating the docs with doxygen and copying
2783 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2784 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2785 all the tests in the form "if (<map>.count() >1)" were removed.
2786 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2787 ill-formed documentation sections.
2788 * src/gdcmHeader.cxx: ditto
2790 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * setup.py fixed for un*x (needed macro for stdint.h)
2792 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2793 un*ces with sh-utils test utility.
2794 * gdcmPython/demo/test.py renamed to PrintHeader.py
2795 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2796 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2797 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2798 * src/gdcm*.cxx JPR's bad inclusion fixed.
2800 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2802 * gdcmPython/demo/test.py changed accordingly.
2804 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * gdcmPython/Makefile.am fixed linking against libstdc++
2806 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2807 * Swig subdir (historical tests of swig version 1.3.17++) removed
2808 * Test/testChangeEntete.cxx some lines commented out in order to make
2810 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2811 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2813 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2815 hence the user doesn't need this explicit call.
2816 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2817 i.e. LoadElements() call removed.
2818 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2819 - src/Makefile.am declares the proper flag for g++.
2820 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2821 for adding user defined new tags.
2822 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2823 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2824 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2826 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2827 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2828 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2829 src/Makefile.am : the project should properly compile and install
2830 with the autotools, included the python wrappers part.
2831 * gdcm.spec.in : added a spec file for RPM packaging.
2833 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2834 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2836 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2838 to exported to the environement (see gdcmPython/testSuite.py
2840 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2841 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2842 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2843 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2844 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2846 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * gdcmPython/__init__.py doesn't crash anymore when running in
2848 in InstallMode or PreInstallMode but with an environment given
2849 value of GDCM_DICT_PATH.
2850 * src/gdcmDictSet.[cxx/h] coding style.
2852 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2854 * src/gdcm.h general comments moved to TODO, and README
2855 * src/gdcm.h should now be seen as a user commodity (including it
2856 should suffice to fully use gdcm). It is nowhere including within
2857 any of the kernel files src/*.cxx and src/*.h.
2859 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2860 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2861 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2863 * src/gdcm*.cxx only include their corresponding include file
2864 (as opposed to gdcm.h)
2865 * gdcmPython/gdcm.i changed accordingly
2866 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2867 the autogen.sh generated "make snapshot" command to work.
2868 * autogen.sh removed history related references to crea package.
2870 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2871 * distutilsSwigCPlusPlus.py work around some swig portability
2874 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2876 was done in a last ditch attempt to get setup.py _really_
2877 operationnal. The python/gdcmPython layaout add the advantage
2878 of hidding away the python related distutils specific files
2879 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2880 Alas, the src directory was out of scope (i.e. it's relative
2881 position to setup.py was ../src) which made things impossible to
2882 handle (see previous version of python/setup.py). Crossing fingers...
2884 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * python/setup.py now works on Un*x. (harder than I thougth)
2886 * python/distutilsSwigCPlusPlus.py can now have include files
2887 among the list of sources.
2889 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2890 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2891 * modifications in MSVC projects
2893 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * As stated by the first lines of Test/ExceptionAndPython/README, it
2895 looks like we can move back to original usage of exception within
2896 src/gdcm* and hence remove the errno stuff that was introduced
2897 as a quick and dirty fixture of this problem (added to the TODO).
2898 * Doc/Doxyfile configuration file for Doxygen and corresponding
2899 README file for usage added.
2900 * Test/testWrite.cxx added. This new test comes from a split of
2901 test.cxx that is now reverted to its original purpous i.e.
2902 testing the proper parsing of a Dicom related file.
2903 testWrite.cxx concentrates on testing the IO part of gdcm.
2904 * Test/bug1.cxx (containing a bug on WIn32) added.
2905 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2906 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2907 whose purpose is to publish the content of the TagNames of the
2908 Dicom public dictionary were not accessible without an
2909 instance of class gdcmHeader.
2910 - those methods are now static methods of gdcmDictSet and hence
2911 require no instances at all to be invocated.
2912 - within gdcmDictSet this change required to change some method
2913 to class methods (i.e. are now static) among which SetDictPath
2914 (renamed to BuildDictPath) and LoadDefaultPubDict.
2915 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2916 the above changes by calling the new method classes of gdcmDictSet.
2917 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2918 the above to be effective.
2919 * python/gdcmPython: in order to wrap properly the above changes
2920 for Python, swig version now needs to be > 1.3.17.
2921 * python/gdcmPython/Makefile fixed to adapt itself to new
2922 configure/make shema introduced by Johan Montagnat (thanks for the
2923 contribution). Alas this Makefile cannot be turned into a proper
2924 Makefile.am without some heavy changes in the configure.in
2925 (for python dectection).
2926 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2927 now avoids publishing the empty entries.
2929 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2930 * python/setup.py : bug fix concerning install under windows
2931 ExtraPath reused :-P
2932 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2934 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2935 * Dicts/dicomV3.dic : remove double spaces !!!
2936 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2937 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2940 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2941 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2942 method. Doxygenation.
2943 * src/gdcm.h clean up of JPR spurious comments.
2945 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2946 * python/distutilsSwigCPlusPlus.py now properly collects the
2947 shadow classes generated by "swig -c++" (gdcm.py in our case)
2948 when using "python setup.py install".
2949 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2950 reexports the working classes.
2951 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2952 by the classical C errno scheme. This is to prevent an obscure
2953 behavior of the python wrappers when importing wxPython.wx prior
2954 to gdcmPython (which ended up in an abort call). An illustration
2955 of this oddity can be found in the Test/ExceptionAndPython
2956 subdir (see the README file). This problem probably due to
2957 an combination of g++ and dynamic loading.
2958 * added Test/ExceptionAndPython (see above)
2960 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * Changed the layout of the python part to avoid bloating main
2962 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2963 i.e. the distutils arsenal. All the python related stuff is
2964 again in a python subdir, but the package itself is now in
2966 * setup.py was cleaned up:
2967 - pythonIncludePath removed
2968 - python setup.py bdist target is now functional.
2969 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2970 collision with other packages). gdcmPython/demo/*.py changed
2973 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * python subdir moved to gdcmPython (preparation of distutils packaging).
2975 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2976 distutils installer is operational.
2977 * - gdcmPython/__init__.py now properly loads the swig generated
2978 shadow classes (from gdcm.py).
2979 - gdcmPython/demo/*.py changed to import the package gdcmPython
2980 instead of gdcmPython/demo/load.py.
2981 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2983 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2985 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2986 entries within the associated public Dicom dictionary resp. the same
2987 information but sorted by the fourth field (PAT, IMG, DIR) of the
2989 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2990 are now in the "???" group.
2991 - python/gdcm.i changed accordingly,
2992 - python/demo/printGroupedPublicDict.py added, that gives an example
2993 of the above new functionalities in Python.
2995 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2996 * src/gdcm.h, gdcmHeader.cxx:
2997 - historic references to glib's g_malloc and g_free (#defined)
2998 were definitively removed.
2999 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3000 * src/gdcmElValSet.cxx:
3001 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3002 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3003 - GetElValue(string) renamed to GetElValueByName.
3004 - Added GetElementByName(string).
3005 * src/gdcmHeader.cxx: added
3006 - GetPubElValRepByNumber(guint16, guint16)
3007 - GetPubElValRepByName(string)
3008 - GetShaElValRepByNumber(guint16, guint16)
3009 - GetShaElValRepByName(string)
3010 - GetShaElValByNumber(guint16, guint16)
3011 - GetShaElValRepByName(string)
3012 - GetElValRepByNumber(guint16, guint16)
3013 - GetElValRepByName(string)
3014 - GetElValByNumber(guint16, guint16)
3015 - GetElValRepByName(string)
3016 * Doc/requirements.txt added.
3018 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * Test/Makefile building now depends on the one of libgdcm.so
3020 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3021 pixel data) aware which enables finding the address (offset) of
3022 the pixel data of JPEG encoded DICOM files. This leaves only a single
3023 file in the testSuite whose pixel data address (offset) is unknown.
3024 * python/testSuite.py changed accordingly.
3026 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3027 * VC++ has some strong limitations when working with the STL, as stated
3028 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3029 "Also note that some STL containers (map, set, queue, list, deque)
3030 cannot be exported. [...]
3031 Some STL classes contain nested classes. These classes can not
3033 This is caused by a designed limitation that once a template
3034 class is instantiated, it can not be re-instantiated and
3036 Since our usage of map<> is ubiquitous in gdcm, this "designed
3037 limitation" of VC++ is a pitfall.
3038 Hence the Python wrappers of gdcm cannot be incrementally linked
3039 against the c++ dynamic library. The dirty but only workaround is
3040 to forget about incremental link of dynamic libraries and to generate
3041 the Python wrappers library with the inclusions of the underlying C++
3043 The following modifications concern this matter on Win32/VC++:
3044 - wrapping python correct with standalone wrapped dll (don't use separate
3045 dll under windows !!!!)
3046 - python21_d debug mode enabled (ask Frog how to use it :-)
3047 - NO problem with having an STL member of class for example string in C++
3048 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3049 - Python test of dcmlib in Python is ok under windows on a large set
3051 * removed glib references
3052 * typedef's inserted in gdcm.i for correct swig type management
3054 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * python/demo/*.py load.py extracted from test.py. Added explore.py
3056 that only displays required tags and testAll.py that parses all
3057 the files of the testsuite without using unittest.
3058 * python/testSuite.py other additional test on new files added.
3059 * Data/* new test files added accordingly to the testSuite.
3060 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3061 the vr in the file differs from the one of the dictionary.
3063 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3065 values, but limits itself to values which are below a user specified
3066 size (by default 1024 bytes).
3067 * python/gdcm.i : elements not loaded (because their size is above the
3068 user specified treshold) are exported with their TagKey as key of the
3069 python dictionary. This enables the testsuite to make some checks
3070 on the unloaded elements (since we have their offset and size).
3071 * python/testSuite.py
3072 - now tests for the existence and proper value of the pixel data
3073 - two new examples added.
3074 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3076 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3078 aware. See the strategy comments in gdcmHeader::FindeLength().
3079 * Test/test.cxx now accepts a filename as first argument.
3080 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3081 * python/testSuite.py changed to integrate test on above files.
3083 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3084 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3085 the vr was also RET.
3086 * python/testSuite.py more tests added.
3088 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * python/testSuite.py unittest test suite added (uses Data)
3090 * Data/* dcm and acr files for the test suite.
3091 * glib dependance removed from un*x version. We now use ISO C99
3092 7.18 Integer types (see stdint.h)
3093 - python/Makefile, src/Makefile src/gdcm.h
3094 * src/ when an explicit vr (like dicom files) suddenly poped an
3095 implicit element we use to mark the underlying DictEntry of the
3096 concerned ElValue with "Implicit". This strategy was damageable
3097 too the public or provite dictionaries, since some of their vr
3098 would be changed. Since Header::FindLength heavily relies on the
3099 detection by Header::FindVR of falsely explicit elements, I
3100 added an extra ImplicitVr member to ElValue (boolean).
3101 The rest of the changes we the necessary adaptations.
3103 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3106 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3108 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * Adaptation for porting to VC++:
3111 o forced to use std namespace (for string to be known)
3112 o all class use __declspec export style on WIN32
3113 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3114 (in stdlib.h on Win32 but in std:: for gcc)
3115 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3116 variable GDCM_DICT_PATH.
3117 * src/gdcmHeader.cxx verbose comments made discrete.
3119 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * python/gdcm.i: added a typemap that converts a C++ hashing table
3121 to native Python dictionary.
3122 * python/demo/test.py:
3123 - now uses the native dictionary for exploration of gdcmHeader.
3124 - takes an optional filename argument (the file to parse).
3125 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3126 PubElVals hashing table.
3127 * Dicts/dicomV3.dic removed error prone trailing spaces.
3129 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3130 * Python wrapping process moved away from src/Makefile to
3131 newly created python/Makefile (as well as gdcm.i)
3132 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3133 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3134 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3135 from the environement variable GDCM_DICT_PATH (when existing).
3136 * src/gdcmDict::GetTag bug fix.
3138 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3139 * Straightforward temporary fixes for swig to build the python wrappers.
3140 src/Makefile now has a python working entry [by working we mean
3141 that we can import de shadow classes without errors].
3143 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3144 * hashtest.cxx removed (since already in Test)
3145 * src/gdcmlib.h renamed to src/gdcm.h
3146 * src/dcm.i renamed to src/gdcm.i
3147 * src/Makefile prepared for python wrapping
3149 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * src/gdcmHeader.cxx :
3151 - Parsing of header is now separated from loading of element values
3152 (see gdcmHeader::LoadElements).
3153 - general clean up of hopefully all file access (creation of
3154 ReadInt16 and ReadInt32)
3156 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3157 * src/gdcmHeader.cxx :
3158 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3160 - SetLgrElem renamed to SetLength
3161 - GetLgrElem renamed to GetLength
3162 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3163 * src/gdcmElValSet.cxx fixed both GetElValue methods
3164 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3165 due to IdoDude was cleaned out.
3167 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3169 concentrates on finding the value representation (when it exists).
3170 RecupLgr now only finds the element value length, and it avoids
3171 returning the unecessary skL (skipped length).
3172 Also, offsetCourant was simply removed (with taille_fich) since
3173 it was redundant with the File position internals (by using
3174 ftell and fseek). This also made skL (see above in RecupLgr) usage
3176 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3177 on the libido specificities which are handled through class
3179 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3182 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * Truckload of changes. Parsing of header is barely functional
3184 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3186 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * src/gdcmHeader.cxx many addons of low level methods
3189 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3190 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3191 and _IdDcmSWAP_LONG.
3193 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * This corresponds to all the changes decided at the meeting of
3195 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob