1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmUtil.cxx : compilation fix on Win32
3 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
4 variable, to be easy found. Add methods to change the default UID.
5 Amelioration of the CreateUniqueUID to use the correct default UID.
6 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
9 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * Test/TestVR.cxx : fix memory leaks
12 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Rewrite the base 256 to base 10 conversion, using string operation only.
14 This allos us to get rid of the problematic 64bits integer type (does not
15 alwyas exist on target platform).
17 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
18 * Add construct and destructor to class gdcm::Debug to close the debug file
20 * Don't let uset to open twice the same file
21 * gdcm has now an official UID prefix,
22 supplied by http://www.medicalconnections.co.uk
23 1.2.826.0.1.3680043.2.1143
24 (Thx to Mathieu for providing URL)
25 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
26 to be able to perform some more tests
27 * gdcm::ContentEntry : Contructors and Destructor are now protected,
28 in order to be sure no user will try to use them.
29 (at user level, only the children classes are meaningfull)
31 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * move RLEInfo & JPEGInfo from Document to File
34 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * FIX : remove so many friend between classes
37 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
39 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
41 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
42 In order to avoid missbehaviour :
43 . gdcm::DocEntry is now specialized in
44 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
45 - gdcm::ContentEntry (Dicom entry with a 'content')
46 . gdcm::ContentEntry is specialized in
47 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
48 characters value, or integers)
49 - gdcm::BinEntry (Dicom entry with a non strig representable value
50 (user hasn't any longer to thing about the precedence of his dynamic_casts)
52 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * Test/VTKTest*.cxx : bug fix under linux
55 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
57 use with python. Some methods are moved from Document to ElementSet or
58 DocEntrySet. The equivalent methods to ElementSet have been added to
59 SQItem and are virtual in DocEntrySet. Methods that may have the same code
60 in SQItem and ElementSet is directly placed in DocEntrySet
62 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * Test/VTKTest*.cxx : remove the show variable in each test method because
64 it's useless (the viewer variable replace this variable)
66 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * src/gdcmDocument.cxx : bug fix on potential memory leak
68 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
69 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
70 Add ClearXxx methods to remove all the content of the list or map
71 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
73 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
74 * methods ReplaceOrCreate renamed as Insert
75 (nobody will be any longer confused by 'CreateOrReplace')
77 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
78 * Grealty simplify the JPEg decompression, no need to differenciate based on
79 the JPEG possible type (with/without fragment, with/without multiple frame).
80 Everything is done throught the JPEG IO Suspension mechanism in IJG
82 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
83 * Stage 3 of normalization :
84 in order to avoid any missunderstanding while reading method names :
85 - All the methods xxxEntry now deal with dicom Entries
86 - Methods GetEntry splitted into
89 - Method SetEntry renamed as SetEntryValue
90 - Method SetEntryBinArea let as it was
92 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
93 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
94 - Position correctly the entry points for JPEG2000 and JPEG-LS
95 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
97 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
99 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
100 with other method names
101 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
102 * Test/TestDicomDirElement.cxx : add new test
104 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
105 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
106 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
107 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
108 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
109 So can't you use __int64 in ostream at all.
111 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * bug fix for compilation on MSVC6
113 * gdcmPython/gdcm.i : rename of classes missed
115 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * Stage 2 of names normalization :
117 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
118 (easy to understand ...)
119 - gdcm::FileHelper replaces old class gdcm::File
121 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
123 type and not a string. So, there remove problems on the format of the
126 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
127 * Add Example/TestPapyrus.cxx
128 - reads a Papyrus file (gdcm::Header compliant),
129 - gets the pixels of all the images, using low level iterators
130 - writes an multiframes Dicom image.
131 (Just to show it's *possible* to do that)
132 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
135 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
137 Thus, DicomDirXXX are created with a flad that indicates if the created
138 object is empty or not (when not empty, the DicomDirElement is used to
141 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
143 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
145 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
148 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
150 Remove all access to the hash-tables or lists in the objects.
152 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
154 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
155 be complient with all the gdcm source code
157 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
161 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
165 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * Test/ : rename VTK tests to have a best name for the tests
167 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
168 GetFirstEntry/GetNextEntry use
170 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 * In SerieHeader::ImagePositionPatientOrdering()
172 // a Dicom 'Serie' may contain scout views
173 // and images may have differents directions.
174 // -> More than one may have the same 'pos'
175 // Sorting has then NO meaning !
176 Thx to Eduardo Davila for reporting bug.
178 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
180 test. Now it's on image content and not on the resulting visualisation...
181 might solve the problem on linux when using the OpenGL drivers
183 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
184 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
185 DicomDirSerie, DicomDirImage
186 Dict, DictSet classes :
187 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
188 -remove InitTraversal method.
189 * UPD Test programs + Example programs
191 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
192 * remove useless and never updated keyword \ingroup
193 * Solve pb when structure (list, map, ...) is empty.
194 Thx to Benoit for reporting bug
196 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 * Taking into account of 'Transfer Syntax' value
198 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
201 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
203 is no memory access violation
204 * gdcmPython/demo : add python demos using VTK
206 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
207 * FIX 'Dictionnary' is now spelt 'Dictionary'
208 'wether' is now spelt 'whether'
209 'archieve' is now spelt 'archive' ;-)
211 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
212 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
213 related methods, in order not to expose internal mechanisms
216 * REM methods that exposed internal mechanisms :
217 DicomDir::GetDicomDirPatients()
218 DicomDirPatient::GetDicomDirStudies()
219 DicomDirStudy::GetDicomDirSeries()
220 DicomDirSerie::GetDicomDirImages()
221 * UPD Test programs :
225 * UPD Example program
227 * ADD DictSet methods
231 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * Removed the Print/indent/default parameter mess. There is absolutely no
233 reason to have to methods, moreover with the second taking the ostream as
234 *SECOND* parameter. This was clearly a bad hack to get things compile.
236 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
237 * Complete rewrite of the GetMacAddress code. Now the code is *much*
238 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
239 Unfortunately the main code does not work on SunOS, thus provide a specific
240 code for this platform only (and Win32 of course). Since this seems to be
241 working, change CreateUniqueUID to use GetMACAddress instead of the
242 problematic GctestetIPAddress
244 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
245 * Unfortunately to be able to test gdcmDirList I had to break the API
246 a little. Now the class is not a std::list anymore but has a member
247 std::vector (more ITK compatible). Allow unit testing on Win32 and
250 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 * Update SerieHeader to take into account a Serie Instance UID to properly
254 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * ENH - Comment out Mathieu's (dangerous) Super Hack
256 for dealing with BIGENDIAN processors
257 - Move equivalent stuff to BinEntry::WriteContent
258 When necessary, 16 Bits Pixels are swapped in a small buffer
259 and then written. This avoid allocating a huge buffer, in
260 PixelWriteConvertor, and avoid modifying the Pixel Area.
262 Probabely, the same operation will have to be done when we want
263 to write image with Big Endian Transfert Syntax,
264 and we are working on Little Endian Processor
266 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
269 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
270 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
271 all the dict content.
272 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
274 * Test/TestDict.cxx : add a new test for the dict classes
276 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
278 file. Debug is yanked if compiled with NDEBUG
280 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * src/gdcmDictSet.h : set the default output to the os variable
282 * src/gdcmDictEntry.[h|cxx] : add the Print method
283 * gdcmPython/demo/ : add a new test
285 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
286 * merging of Test/PrintDicomDir and Test/TestDicomDir
287 * removal of now redundant Test/PrintDicomDir
288 * enhancement of Example/PrintDicomDir
290 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * Now, python test might work on systems
292 * Add the PrintDicomDir test
294 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
295 * FIX : First entry following group 0002 was lost for
296 Explicit Big Endian Transfer Syntax files
297 (group and elem not swaped)
299 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
300 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
301 Big Endian Transfer Syntax supposed the group following 0002
302 begins always by element 0000 (element 0000 is *optional*)
303 To avoid further troubles, let's be pessimistic, and use
304 Document::HandleOutOfGroup0002() method
305 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
306 (related pb not yet solved)
308 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * Bug fix for the python part use
310 * Now, PrintHeader.py pass... but outside the ctest use. shit !
312 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
315 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
317 a string and should ask the global TS dict what are the propreties of
320 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
321 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
322 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
323 to swap the Swap Code, at parsing time, when we come out of group 0002
324 and Transfer Syntax is Big Endian
325 We should be able to read now 'true DICOM" Big Endian coded images
326 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
327 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
329 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Hopefully fix the bug on MacOSX and static global initialization.
331 This is the only -minor- patch I found that both please MacOSX and VS6.
332 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
333 but this would require a lot of change. Another approach would be that Global
334 create those string and GDCM_UNFOUND becomes a pointer to a string (which
335 gdcm::Global would destroy at exit).
337 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * Fix bug on MacOSX with static initialization in a multy threaded
339 environment. static const string in a header file used to be ill
340 initialized provoquing the freeze of any tests. patch should solve this
343 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
344 * According to Benoit's suggestion, and without any objection from anybody
345 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
346 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
347 - method gdcmDicomDirObject::GetEntry() renamed as
348 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
350 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
352 you debug/warning message just as c++ streams which make them very convinient
353 to use. Once this is stabilize I will change the ostringstrem to be
354 redirected to a file (ofstream).
355 * Properly support C99 extension: __FUNCTION__ which allow us to display
356 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
358 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
359 * Removal of useless and dangerous methods :
360 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
361 GetDocEntryByName, GetEntryByName, GetDictEntryByName
362 * Removal of usless methods :
363 Dict::PrintByName, Dict::GetDictEntryByName
364 * Commenting out of probabely useless methods :
365 Dict::GetDictEntryNames()
366 Dict::GetDictEntryNamesByCategory()
367 DictSet::GetPubDictEntryNames()
368 DictSet::GetPubDictEntryNamesByCategory()
369 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
370 * ENH : Use dicomTS.dic as described in 2004 version
371 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
372 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
373 Add Accessors on VM (Value Multiplicity), and VM related methods
374 * ADD : Add a list of 'Dicom Attribute types', as found in
375 http://medical.nema.org/dicom/2004/04_15PU.PDF
377 * ADD : Add dicomGroupNameAbbreviations.dic
378 should be used to write a method to replace the former
379 Dict::GetDictEntryNamesByCategory()
381 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
382 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
383 to read in the file... and only it ! Length is the efective length of the
384 data in the DocEntry structure
386 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
388 And now use a static function call instead, with a global variable. i
389 This is much closer to the VTK approach. Hopefully should be bulletproof
390 and easier to use...hopefully
392 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
393 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
395 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
398 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
400 ValEntry, BinEntry, SeqEntry creation or replace
402 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
404 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
406 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
407 when specifying the VR
408 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
409 * src/gdcmDocEntry.cxx : amelioration of print
411 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
412 * ADD : Add the method Util::IsCurrentProcessorBigEndian
413 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
414 * ADD Method Document::ComputeGroupLength
415 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
416 in order to allow further VR modification by user
417 * REM : removal of once-called method File::WriteBase
418 integration of its code in formerly one-line method File::Write
420 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
422 replace the different values "??", "Unkn", "Unknown".
423 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
424 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
425 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
426 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
428 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
431 * Set the gdcm::Base class to some Printable classes
433 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmFile.[h|cxx] : add the Print method
435 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
436 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
437 * src/gdcmDocument.h : remove the PrintLevel informations
438 * Example/PrintFile.cxx : use the new gdcm::File::Print
440 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
442 problems when compiling with the python wrapping
444 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
446 writting in ImplicitVR
448 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
449 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
450 JPEG decompression, especially when dicom frames are split into several
451 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
452 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
454 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * src/gdcmHeader.cxx : change the initialisation of default header.
456 Now, this header is readable by gdm, e-film, DicomWorks
458 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
460 Rename Decompressed to Raw
461 * Use the API changes in gdcm::File.
462 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
465 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
467 each added entry in the header. Replace the 'Planes' field by the 'Number
470 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
472 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
474 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
476 At this time, this image isn't readable by e-film... waiting JPR help to
479 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
481 DocEntry. Now use methods of the Document !
483 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * Test/ShowDicomSeq.cxx : bug fix
486 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
488 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
489 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
490 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
492 * Test/TestCopyRescaleDicom.cxx : remove unused variable
493 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
494 containing found sequences
496 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
499 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
500 Some fields in BinEntry must be copied to not seg fault when making the :
501 gdcm::File *copy = new gdcm::File( copyH );
502 and tests are now made on good variables
504 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
506 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
508 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
509 * Add vtkGdcmWriter example and test
511 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * Test/TestUtil.cxx : reformat the source code
513 * vtk/vtkGdcmReader.cxx : remove and change prints
514 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
516 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
517 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
519 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
521 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
523 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
525 by an eof to prevent all bad read of the file... and in this case, the
528 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * Example/Volume2Dicom.cxx : comment unused variables
530 * Test/PrintDicomDir.cxx : comment unused variables
531 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
532 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
533 method that is redondant with AddEntry.
534 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
537 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * Bug fix due my last commit (compilation under Windows).
539 * Example/Volume2Dicom : bug fix in the file and reformatting source code
540 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
542 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 - Remove printf / sprintf
545 - include iostream AFTER gdcm so we don't get warnings
546 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
548 - Also remove tons of include from header files, hopefully this should
549 speeup the compilation time, since it was becoming a dog slow.
550 - Remove gdcm.h as it include way too many files and slow down compilation
551 (plus it is not up to date)
552 - remove 'using namespace std' this is BAD !
554 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * Remove memory leaks on the DicomDir
556 * Remove some useless data in DicomDirObject
557 * Add usefull methods in SQItem, to be complient withe the ElementSet
559 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
562 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
564 future, with convertion)
565 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
566 and ImageDataSize values. Remove the method to get the PixelReadConverter
567 from the output of the class
569 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
572 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
574 and vtkErrorMacro use.
575 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
577 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
580 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
581 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
582 The string leaves only in the fonction. So when we make a .c_str(), we
583 get the pointeur on the first element, element that will be destroyed
584 immediately after thee instruction.
585 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
586 file has been opened : the test must be made on the content of the
587 pointer and not directly on the pointer !
590 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
592 the python part recompiles
594 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
596 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
597 X session is killed (for my computer... it seems to not be identic on
600 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
602 avoid problems (otherwise, the difference test between the visible image
603 and the reference is incorrect. If the reference is greater than the
604 screen resolution, it's produce errors).
605 Can be used for only one image. Can be used with a visible flag.
606 * vtk/vtkGdcmReader.cxx : remove commented codes.
607 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
608 under windows at compilation
609 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
611 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
613 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
615 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
616 tests on the image size X, Y, Z
618 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
620 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
621 between the class name and the file name
623 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/ : fix compilation warnings for the Write method (2 different
625 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
626 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
627 variable... create a static method in gdcm::Document to access to
628 this variable content.
630 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
632 file, to be accessed by other files (like gdcmFile). Remove commented
633 code. Move the change of the header to the gdcmFile, using the
635 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
636 To be sure of that (and simplify calls), the Write of the header now
637 gets a file name and not a file pointer (std::ifstream).
638 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
639 DocEntryArchive. Remove all open of the written file
641 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
644 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
646 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
648 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
649 some corresponding methods. Write correctly the file and check before
651 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
652 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
653 is now on RGB data (as before my last commit
654 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
656 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
658 Add a print information of the type of the entry
659 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
660 It was in the gdcmFile, and all write have been regrouped
661 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
662 Write correctly all dicom files (in decompressed mode only at this time)
663 * Test/ : test on files are now made using Raw data and not color data if
665 * Example/PrintFile.cxx : add more printings
667 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * Amelioration of code, remove some code copy. For the loading of
669 BinEntry (in gdcmDocument), add the test to verify if the file is already
672 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
674 remove a DocEntry in the header (push an empty DocEntry)
675 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
676 lines. Bug fix in the initialization of the PixelConvert and the
678 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
679 use in TestCopyDicom (now this test can run under windows... but fails)
680 * Test/TestCopyDicom.cxx : amelioration of the test :
681 - test the pixels written
682 - add test points to quickly find where is the error
683 - can set a file name input and output in arguments
684 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
685 amelioration of the test output
687 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
689 all replaced DocEntry's
690 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
691 Now, each needed DocEntry to modify is duplicated, modified and inserted
692 to the header using DocEntryArchive. Thus, after save, we can restore the
693 header initial state.
695 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
698 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
700 correct to copy it. The DictEntry is specified at the DocEntry creation,
701 then, it musn't change in the time.
702 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
703 header correctly. At this time, the change is only made for the first
704 level of the Document. In the future, it might consider sequences.
705 The change is made by replacing a DocEntry by an other that is created
706 outside the class. The old value is kept. When we restore the header
707 status, the added DocEntry is deleted and replaced by the old value.
708 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
709 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
710 set the write type to explicit VR, implicit VR or ACR. Add methods to set
711 the write mode to native, decompressed or RGB (but not used at this time)
713 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
714 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
715 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
717 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
719 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
721 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
722 set because already copied when copying the BinEntry's of the header
723 * Test/TestAllReadCompareDicom.cxx : remove warnings
725 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
727 Two problems appear when doing it :
728 - with the gdcmFile : when the GetImageData method is called, the pixels
729 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
730 data (pixels). And each structure destruct the data when it's
731 destructed. So we have two destructions for the same data. To solve it,
732 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
733 data or not. If it doesn't own data, then they will not destroyed by
735 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
736 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
737 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
738 create a double destruction of the same DocEntry's. So, to solve it,
739 the TagHT is simply cleared and the DicomDir* elements are destroyed.
740 * TODO : add an entry concerning memory leaks in the DicomDir
742 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
743 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
744 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
747 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
748 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
749 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
750 after it have been deleted
752 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
753 * FIX: src/* fix the doxygen warnings.
754 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
755 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
756 was erroneously defined with a size of 15 instead of 16. [many thanks
757 to Jean Michel Rouet for pointing out this bug].
759 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 1. Finish merging JMR patch for writting DICOM from scratch
761 2. Fix -hopefully- bug with MONOCHROME and space vs null character
762 3. Use const ref when possible
763 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
764 5. A few more comments
765 6. CreateUniqueUID can now be called without parameter"
767 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
768 * ENH: Slightly bigger patch:
769 1. Getting toward full integration of JMR patch for writting dicom from scratch
770 2. Update Test to test part of this patch: CreateUniqueUID
771 3. File was not close properly in gdcmDict
772 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
773 5. Use of const ref instead of copy (speed issue)
774 6. Remove temporary (duplicate) string in TranslateToKey
775 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
776 8. Do not repeat virtual in subclasses
777 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
779 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
780 * Apply first patch toward better string comparison when dealing with broken
781 DICOM files. Essentially the string could be padded with a space instead
782 of a null character as defined by standard
784 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
786 because never used... and in the same time, that's remove some memory leaks
788 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * src/gdcmFile.cxx : now delete the PixelConvert instance.
790 * In examples and tests : change the type of image data variables from void*
791 to uint8_t*. Remmove all delete on image data variables
793 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
795 Verify the file pointer value before open the file, and if it's not null,
796 a verbose message is generated.
797 Close correctly the file when the file isn't considered dicom-like. The
798 correctly close is a call to CloseFile.
799 When closing the file pointer, test if its not null to close the file.
800 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
801 file. For an uncompressed image, the copied data correspond in the least
802 case to the image size (calculated) or the image size specified in the
803 header. A verbose is generated if these two size mismatch
805 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
806 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
807 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
808 break under windows (with msvc6 compilation).
810 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
811 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
812 compiling with MSVC6)
814 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
815 * Bugs fix for the Windows build with VC6
816 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
817 needed (only for projects required VTK). If the VTK is included in all
818 projects, there is conflicts with the jpeg lib of vtk when compiling the
819 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
820 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
821 when compiling the gdcm_wrap.cxx file (created by the compilation of the
823 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
824 (like it's already made for the cout use). Otherwise, conflict with the
827 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
830 - comments on the DicomDir::Method related usage added.
831 - now that we use the namespace gdcm, a lot of internal classes do
832 NOT need to be wrapped anymore.
833 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
834 DicomDir::Method) new example added.
836 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
837 * Improve string manipulation. I now inforce the notion of 'DicomString'
838 A DicomString can contain as many \0 as they want
839 and it is *always* of even length.
840 We only support odd length for very rare case.
841 And in the near future this should be removed.
843 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * /binary_write/ gdcm source. Now even on big endian we are writting
845 little endian. This should -heopfully- fix some tests
847 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
848 * Now the dictionary is compiled into gdcm lib. This is a default
849 behavior, thus any dic file specified is picked before failback to
850 the one comiled into lib
852 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
853 * Change internals for gdcmDict. Don't use any 'new' any more.
854 This should definitely solve any leak problem, and we should be
855 as fast as before, as long as don't modify too much the dictionary.
857 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
858 * STYLE: ivars should start with a capital letter.
859 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
860 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
862 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
864 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
865 new 2004 dictionaries added (thanks to JPR).
866 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
867 * CLEANUP_ROUND (15) for gdcmPixelConvert
868 - RLEFrame::NumberFragments is now of type unsigned int
869 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
870 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
873 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
874 * Initial work in gathering all transfer syntax accessors. clearly
875 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
876 ivars, but only one transfersyntax (class) ivar with equivalent method on
879 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
880 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
881 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
882 discussed (plus I didn't like having a 2000 lines patch not commited)
884 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
886 * CLEANUP_ROUND (14) for gdcmPixelConvert
887 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
888 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
889 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
891 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
892 anymore and hence avoids storing a copy of PixelConvert::Decompressed
893 into File::Pixel_Data.
895 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
897 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
898 * CLEANUP_ROUND (13) for gdcmPixelConvert
899 Substituted File::ParsePixelData() with PixelConvert::Print() new
901 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
902 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
903 method to those classes.
904 - src/gdcmFile.[cxx|h]:
905 -- Added a ::Print() method.
906 -- PixelConverter is now a reference instead of a member.
907 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
908 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
910 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
912 collaboration diagram and inheritance diagram should be generated with
914 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
915 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
916 pointlessly wrapped (see
917 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
918 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
919 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
920 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
921 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
922 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
923 -- File::Initialise: PixelConverter setup moved away to
924 PixelConverter::GrabInformationsFromHeader()
925 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
926 interpretation moved away to PixelConverter::BuildRGBImage()
928 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
930 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
932 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
934 displayed on Win32 when a brutal abort() occurs (because of uncatched
935 exception). See TODO new entry of this commit for more on this.
936 * TODO added new entry.
937 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
938 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
939 - HandleColor is no longer called from gdcmFile.cxx
940 - gdcmPixelConvert.cxx clean up on method arguments and internal
941 variable names for semantical coherence.
943 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * Finished lossless transition, not only do we now read all lossless jpeg
945 images, without the need of the Cornwell lib, but we do read them properly now
946 * To reduce code (well to avoid code duplication), I defined a common place
947 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
948 redefine symbols. This is not perfect but this the best solution I found for a
949 compilation time jpeg option.
951 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * Update jpeg ijg lib to support lossless jpeg implementation
953 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
955 * Also added a special copyright for dcmtk since we use their bugfixes.
958 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
960 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
961 matters, as stated in warning note at begining of %include section).
962 * src/gdcmDicomDir*.[cxx|h]: coding style
963 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
964 * src/gdcmJpeg8.cxx: doxygen fix.
965 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
966 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
967 from File:: to PixelConvert::.
969 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
971 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
972 - more code moved away from File:: to PixelConvert::
973 - fat setup of PixelConverter set in place in File::Initialise.
975 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
976 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
977 namespace at the file system level. So now you should convert your examples
979 gdcmHeader -> gdcm::Header
980 It would be nice if people keep in mind to no open the namespace, since it
981 allows compilation on broken plateform which were defining common symbol in
982 the standart namespace (like LP, Unknown ...)
984 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
986 The JPEG fragments are now parsed at the same stage than the RLE
987 information. All code related to JPEG is now in gdcmPixelConvert:
988 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
989 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
990 export a gdcmFile:: method. Those are simply global functions
991 (for the time being this is better than having them attach to
992 either gdcmFile:: or gdcmPixelConvert::).
993 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
994 and stores the result in a gdcmJPEGFragmentsInfo.
995 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
996 code (among other stuff) moved away from gdcmFile:; to
999 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1001 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1002 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1003 clean up of RLE related code.
1004 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1005 - src/gdcmRLE.cxx removed
1006 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1007 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1008 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1009 * CLEANUP_ROUND (9) for gdcmPixelConvert
1010 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1011 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1012 away from gdcmFile:: to gdcmPixelConvert::.
1014 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1016 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1017 This is because Parse7Fe0 used to parse the pixels to compute the
1018 length. This task was passed over to FindDocEntryLengthOB() a long
1019 time ago, EXCEPT I had forgotten the OW case...
1020 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1021 we just recylce the code for parsing RLE fragments and computing
1023 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1024 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1025 with the retired Parse7Fe0().
1026 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1027 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1029 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1031 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1032 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1033 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1034 * CLEANUP_ROUND (4) for gdcmPixelConvert
1035 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1036 to return an unused length.
1038 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1040 this should be cleanner from the plane view. The iostream are erally a pain
1041 to use to do simple stuff.
1043 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * Redo the compilation of the ijg jpeg library. Now only one source is
1045 necesseray. No need to rename file by hand what so ever. CMake handle the
1046 copying of the file within different directory, configure header file to
1047 modify some symbol. The only addition made to ijg wasd a mangle table so
1048 that symbol are different whether we are within 8bits or 12bits.
1050 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * Added documentation of vtkgdcmReader on Website:
1052 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1053 with it's binary name).
1054 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1055 the Website to be more complete.
1056 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1057 doxygenated documentation.
1058 - Doc/DoxyVtkGdcmReaderExamples.txt added
1059 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1060 DoxyVtkGdmReaderExamples.html )
1061 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1062 * CLEANUP_ROUND (3) for gdcmPixelConvert
1063 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1065 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * CLEANUP_ROUND (2) for gdcmPixelConvert
1067 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1069 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * CLEANUP_ROUND for gdcmPixelConvert:
1071 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1072 - src/gdcmPixelStuff[h|cxx] removed
1073 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1074 - src/CMakeLists.txt changed accordingly
1075 * GDCMHOME clean up:
1076 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1077 gdcmVersion.py moved to newly created ATTIC related
1078 gdcmPython/SetupOldies/ directory.
1079 * Autotools clean up:
1080 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1081 - autogen.sh configure.in acinclude.m4 python.m4 removed
1083 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1085 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1086 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1088 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * TODO updated with Mathieu suggestions. I proposed a template for
1090 describing TODO entries and used it for new entries.
1091 * Added Doc/Website/CodingStyle.html, Developpers.html,
1092 DeveloppersPython.html, GdcmDataCvs.html and
1093 DownloadVersion0_1.html, DownloadVersion0_3.html.
1094 * Some Doc/*.txt Doxygen files (which do not really concern the
1095 documentation itself, but the website) moved to html and
1096 placed in directory Doc/Website:
1097 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1098 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1099 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1100 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1101 * CMakeLists.txt changed accordingly.
1102 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1103 DeveloppersPython.html
1104 * INSTALL nows refers to Doc/Website/Installation.html
1106 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * Added Doc/Website directory, that contains a first raw version
1110 2004-09-23 Jean-Pierre Roux
1111 * FIX In order not to be poluted any longer by casting problems,
1112 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1113 we can now delete[] it safely
1114 * VoidArea is now called BinArea (less confusing name),
1115 and all the methods called ...VoidArea... are now ... BinArea...
1116 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1118 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1120 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1121 up to the destructor of gdcmElementSet to clean up TagHt and it's
1124 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1126 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1128 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * ENH: added some utility method that builds a flat dictionary
1130 holding all the Dicom entries contained in the recursive structure
1131 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1132 an example of usage.
1133 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1134 BuildFlatHashTable() that build a flat dictionary.
1135 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1136 gdcmDocument is now a friend of gdcmElementSet.
1137 - src/gdcmElementSet.cxx: clean up.
1138 - Example/FlatHashTablePrint.cxx added.
1139 - Example/CmakeLists.txt changed accordingly
1141 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1143 moved away from gdcmDocEntrySet (since this class is an abstract class
1144 acting like an interface). SQDepthLevel and BaseTagKey are now
1146 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1147 and associated accessors. Doxygenation of the class.
1148 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1150 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1151 Use SQDepthLevel accessor instead. ::Print() adapted.
1152 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1153 - src/gdcmDocument.cxx changed accordingly.
1155 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1157 - The following is the doxygen comment of the typedef declaration
1158 of gdcmTagKey in src/gdcmCommon.h:
1159 gdcmTagKey is made to old an "universal" (as in URL, Universal
1160 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1161 A dicom tag always has a group and an element, but a set of tags
1162 embeded in various (optionally nested) sequences and sharing
1163 the same group and element all share the same (group, element)
1164 "identifier". Hence the (group, element) cannot be used as an
1165 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1166 In order to construct a proper tag identifier (i.e. a key) we
1167 consider the following definition of a TagKey:
1168 - let Group, Element be the string representation of the
1169 group and element dicom tag members,
1170 - let ItemNumber be the string representation of the integer
1171 index of the considered item number of a sequence,
1172 Let the key of a tag embeded in a sequence, noted SeqTag, be
1174 /ItemNumber#Group|Element
1175 where "/", "#" and "|" are characters acting as separators.
1176 Then the general form of a gdcmTagKey is given by:
1177 Group|Element<SeqTag>
1178 where <SeqTag> means NO or many instances of SeqTag.
1179 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1182 but the gdcmTagKey of a tag "embeded" is the first item of
1183 a sequence, itself nested in the third item of a sequence is the
1185 0004|1220/2#0008|0082/0#0008|0090
1186 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1187 order to hold the new sequence compatible key. Previously, the
1188 GetKey() method would look in the underlying gdcmDictEntry.
1189 - src/gdcmDocEntry.cxx:
1190 -- constructor now copies the underlying DictEntry key, in the local
1192 -- ::Print: displays the member Key, instead of the (group, element).
1193 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1194 - src/gdcmDocEntrySet.h:xi
1195 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1196 -- now has a new BaseTagKey member.
1198 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1199 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1201 This poses the problem with the semantics of the following lines
1202 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1203 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1204 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1205 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1206 to the long FIXME note for what the problem is. Nevertheless in
1207 order to get things working the dicom dictionary was altered !
1208 Please fix things urgently...
1209 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1210 information), see above note on moving the member VoidArea. Nevertheless
1211 the following entries previously correctly set as US are now inproperly
1213 0028 1201 OW IMG Red Palette Color Lookup Table Data
1214 0028 1202 OW IMG Green Palette Color Lookup Table Data
1215 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1216 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1217 of gdcmDocEntry moved to gdcmSeqEntry.
1218 * src/gdcmSeqEntry.cxx: STYLE.
1220 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1223 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * gdcmPython/testSuite.py: all the test suite in python is now moved
1225 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1226 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1227 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1229 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1230 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1231 to avoid inclusion recursion until STL is reached.
1232 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1233 mecanism. errno.h is not included in gdcm anymore.
1234 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1235 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1237 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1238 gdcmData/TestAllEntryVerifyReference.txt
1239 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1240 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1241 exception_on_error parameter.
1242 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1243 - vtk/vtkGdcmReader.cxx changed accordingly,
1244 - Example/*.cxx and Test/*.cxx changed accordingly.
1246 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1248 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1249 enable_sequences removed from gdcmHeader constructor and dependencies.
1250 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1251 * gdcmPython/demo/PrintHeader.py: dummy fix.
1252 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1253 skip_shadow removed from gdcmHeader constructor and dependencies.
1254 * Example/*.cxx and Test/*.cxx changed accordingly.
1256 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1258 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1260 2004-07-21 Jean-Pierre Roux
1261 * FIX Now, Parsing and Printing a DICOMDIR do work!
1262 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1264 2004-07-20 Jean-Pierre Roux
1265 * FIX Some brain damaged headers have Zero-Lenght fields
1266 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1268 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1269 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1270 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1271 variable (instance of gdcmDebug) by a definition macro, and the instance
1272 is now in static in the gdcmDebug class
1273 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1274 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1276 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1277 * WARNING: ctest now depends more tightly on gdcmData. You should
1278 check out gdcmData properly for things to run smoothly...
1279 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1280 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1281 we need the pixels not be loaded in order to use the ValEntry
1282 that displays position and size).
1283 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1284 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1285 be deprecated. If you have any doubts about the advantages of a
1286 modern scripting language (read Python) versus grass root C++ (i.e.
1287 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1288 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1289 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1290 Anyhow, consider documenting the gdcmData images in
1291 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1293 * Test/CMakeLists.txt:
1294 - now uses TestAllEntryVerify.cxx
1295 - specific comments on oldACR00001.ima (now renamed in gdcmData
1296 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1297 gdcmData/TestAllEntryVerifyReference.txt
1300 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * src/*.[h|cxx] : typedef clean up
1302 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1303 - TagKey renamed to gdcmTagKey (for external usage)
1304 - VRKey renamed to gdcmVRKey (for external usage)
1305 - removal of typedef duplication.
1306 - Removed all unecessary inline keyword from class inline definitions.
1307 - Some method|function(void) declarations replaced with method|function().
1308 * src/jpeg/libijg12/jdhuff12.c:
1309 - printf polluting ctest removed.
1310 - TAB removal for comminting
1312 - TestAllReadCompareDicom.cxx: added a test that compares all the
1313 images in gdcmDataImages.h with corresponding images in
1314 gdcmData/BaselineDicom/. When baseline images are not present
1315 this test creates them.
1316 Note: we need to validate each reference image, but before that
1317 I'd like to rename them with a more explicit name...
1318 - CMakeLists.txt: changed accordingly.
1319 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1320 including each header needed).
1322 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1323 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1324 test suite to the Example directory. Are concerned:
1329 - TestWriteSimple.cxx
1330 * Test/CMakeLists.txt: added some comments on reasons for black listing
1331 image gdcmData/oldACR00001.ima
1333 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * Test/CmakeList.txt: removed the following from black list (to be coherent
1335 with removal from gdcmData):
1336 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1337 - gdcm-MR-PHILIPS-16.dcm
1339 Added the following because after last cvs update, they cause
1340 ctest -R TestReadWriteReadCompare
1342 - gdcm-MR-SIEMENS-16-1.acr
1344 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1345 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1346 new comments in this file) we temporarily (sigh) move to a weaker
1348 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1349 we don't need to black list the following images anymore:
1350 - 8BitsUncompressedColor.dcm
1352 - US-PAL-8-10x-echo.dcm
1353 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1354 fixes and the beautified code ;-)
1355 This fixes the bug introduced in version 1.42 (when beautifying)
1356 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1357 Note: ctest was blind to this bug (this means we need to still
1358 improve the test suite). The bug could be detected by using
1359 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1361 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1362 and by displaying the (garbage) produced file temp.XDCM...
1364 2004-06-29 Jean-Pierre Roux
1365 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1366 - replace by uggly but working old code :-(
1367 A lot of things should be OK again.
1368 It's really urgent to have a test suite that *tests*,
1369 to prevent Frog's beautifying sessions to break all the stuff
1370 (twice, withing a fortnigh ...)
1372 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1374 redundancy) to added Test/TestReadWriteReadCompare.cxx
1375 * Test/CmakeList.txt: because the compare test of
1376 Test/TestReadWriteReadCompare.cxx fails, the following images are
1377 black listed: - 8BitsUncompressedColor.dcm
1379 - US-PAL-8-10x-echo.dcm
1380 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1381 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1382 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1383 and ad-hoc kludge. This kludge is now removed, and on encountering
1384 such an image (OB field brain damaged) we set errno. Then in
1385 ::FindDocLength() we "fix" the length as being ALL what remains
1386 in the file (until EOF). We then proceed, hoping for the best...
1387 This fixes a SegFault in ShowDicom when trying to write such an
1389 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1390 (because TestWriteRead breaks on it, after a non conformal commit?).
1391 ctest now runs properly, except for MakeDicomDir (which was always
1392 broken) and the Python related stuff (still not fixed).
1394 2004-06-24 Jean-Pierre Roux
1395 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1396 FIX : Test/TestReadWrite now iterates on all the file names
1397 (instead of infinite loop)
1398 ENH : Test/TestWriteRead now iterates on all the file names
1400 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1403 2004-06-24 Jean-Pierre Roux
1404 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1405 when SamplesPerPixel =3
1406 - now Write is no longer confused by
1407 'BitsAllocated = 12" and 'BitsStored=12"
1408 - "UN" value representation Elements are now written correctly
1409 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1410 ENH : - now gdcmHeader has its own Write methods
1411 (in order to split the job that has not to be done
1414 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1416 loop on the same image until memory went out.
1417 Note: this means we still have gobs of memory loss in PrintDocument
1418 * src/gdcmDocument.cxx: fixes problem on parsing on file
1419 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1421 2004-06-24 Jean-Pierre Roux
1422 FIX : Write - All the Sequences and Sequence Item are now written
1423 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1424 is added a the end, when necessary.
1425 - A lot of brain-damaged images, that were read correctly are
1426 now written correctly
1427 - length compatible BinEntry are now loaded correctly
1428 (even for odd groups)
1429 Note : only Explicit Value Representation was checked.
1430 (question : is implicit VR really necessary for gdcm ?)
1432 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * DEVELOPPER: added a proposition of coding style.
1434 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1437 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1439 Use the gdcmDocEntry::Print() and Write() instead.
1440 * src/gdcmDocument.cxx: bug fix.
1442 2004-06-22 Jean-Pierre Roux
1443 FIX : gdcmDocument.cxx
1444 - Now we do recognize the JpegLossLess format (there was a misstyping in
1445 code 'beautyfication' :-(
1446 - Now we automaticaticaly load the Luts, if any
1448 2004-06-22 Jean-Pierre Roux
1449 In order : to write Sequences, whatever their imbrication level,
1450 : to allow user to create his own Sequences
1451 a lot of modif where necessary (adding, moving, or virtualising methods)
1453 WARNING : save your own sources *before* cvs up !
1456 ADD virtual void Write(FILE *fp, FileType filetype);
1459 ADD virtual void Write(FILE *fp, FileType filetype);
1460 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1463 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1464 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1465 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1466 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1467 ADD std::string GetEntryByName(TagName name);
1468 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1470 std::string vr = "unkn",
1471 std::string fourth = "unkn",
1472 std::string name = "unkn");
1473 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1474 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1475 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1476 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1477 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1478 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1479 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1480 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1483 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1484 ADD virtual std::string GetEntryByName (TagName tagName);
1485 ADD virtual std::string GetEntryVRByName (TagName tagName);
1486 REM virtual bool Write(FILE *, FileType);
1487 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1488 FILE *_fp, FileType type);
1489 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1490 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1491 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1492 REM virtual std::string GetEntryByName (std::string tagName);
1493 REM virtual std::string GetEntryVRByName (std::string tagName);
1494 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1495 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1496 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1498 std::string vr = "unkn",
1499 std::string fourth = "unkn",
1500 std::string name = "unkn");
1501 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1502 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1503 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1504 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1507 ADD virtual void Write(FILE *fp, FileType filetype);
1510 ADD virtual void Write(FILE *fp,FileType filetype);
1513 ADD virtual void Write(FILE *fp, FileType filetype);
1514 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1515 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1516 REM std::string GetEntryByName(TagName name);
1519 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1521 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1523 The default constructor invoked by the line
1524 gdcmHeader *f1 = new gdcmHeader( header );
1525 was gdcmHeader::gdcmHeader(bool) instead of the expected
1526 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1527 Hence the parsing wasn't executed... See also below.
1528 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1529 as explicit constructor didn't do the trick to fix the above problem.
1530 Could anyone explain why ?
1531 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1532 properly calls gdcmValEntry::Print() (that was weed out from
1533 code related to gdcmBinEntry).
1535 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * In order to fix memory leaks:
1537 - Test/TestWriteSimple.cxx: added cleaning of free store through
1539 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1540 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1541 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1542 (through the call to ::AddDicomDirMeta()) or the destructor
1543 would crash when deleting uninitialized ::metaElems].
1544 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1545 - src/gdcmDocument.cxx:
1546 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1547 from dynamic stores.
1548 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1549 was causing memory leaks.
1550 - src/gdcmSQItem.cxx:
1551 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1552 cleanly handled with polymophism: sorry but my milage is low).
1553 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1554 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1555 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1556 This avoids SegFaulting.
1557 - src/gdcmSQItem.h: coding style.
1559 - Test/TestWriteSimple still severely sucks. The output image content
1560 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1561 damaged when displayed with vtkgdcmViewer.
1562 - on memory leaks: TestWriteSimple leaks really less (see entry
1563 of 2004-06-18 in Changelog file for the call to valgrind).
1564 - on segfaults: ctest now passes all the tests but one (no more
1566 * Erroneous leading white fix:
1567 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1568 white[s] (as opposed to from >> xxx, that removes it [them].
1569 - src/gdcmTS.cxx: ditto.
1570 - gdcmPython/testSuite.py: dirty related kludge removed.
1571 * src/*: remaining references to gdcmParser removed.
1572 * src/*[cxx|h]: added copy[way]left header.
1575 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1576 * In order to fix writing of dicom files:
1577 - Test/TestWriteSimple.cxx: a simpler example of writing.
1578 - Test/CMakeLists.txt changed accordingly.
1579 - src/gdcmDocument.cxx:
1580 -- The destructor now recursilvely removes potential sequences.
1581 -- Bug fix in ::IsJPEG2000()
1582 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1583 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1585 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1586 to only declared) and build on top of
1587 ::GetDocEntryByNumber(guint16, guint16).
1588 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1589 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1590 for usage in destructor and treatement of promotion in
1591 ::ReplaceOrCreateByNumber().
1592 - src/gdcmSQItem.cxx: destructor should better handle his job.
1593 Test/TestWriteSimple now runs (or at least it DOES something).
1594 * We can now start hutting memory links. A good starting point is:
1595 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1596 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1597 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1599 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * Valgrind note: after Mathieu Malaterre teached me how to read
1601 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1603 Using gcc, you can force the STL to use malloc and to free memory as
1604 soon as possible by globally disabling memory caching.
1605 With 3.2.2 and later, you should export the environment variable
1606 GLIBCPP_FORCE_NEW before running your program.
1607 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1608 simply vanish (it is still not clear to me, whether this means that
1609 STL std::string leaks or if valgrind believes it leaks...).
1610 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1611 running bin/gdcmTests makeDicomDir):
1612 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1613 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1615 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1616 SegFaulting (I drowned in DicomDir related code when trying to
1617 understand why the list is empty...).
1618 * src/gdcmDocument.h: first BSD license header try.
1619 * Doc/License.txt added.
1621 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1622 * src/gdcmDocument.[h|cxx]:
1623 - Clean up of the Transfer related predicates. They are now all based
1624 on new method isGivenTransferSyntax, that (should) handle properly
1625 the padding problem.
1626 - general clean up, simplification, and coding style.
1627 - Specific clean up of Parse7FE0() (umproperly named actually).
1628 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1630 2004-06-14 Jean-Pierre Roux
1632 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1633 - fix the display of SQItem ordinal number
1634 - add the GetSQItemByOrdinalNumber method
1635 - remove some useless never written private methods
1637 2004-06-14 Jean-Pierre Roux
1639 - adding a constructor taking a gdcmDocEntry as an input param
1640 - ReplaceOrCreateByNumber now returns :
1641 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1642 a gdcmValEntry * if a string value is passed as a param
1644 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1645 according to the param type (no longer sets a gdcmDocEntry)
1646 - GetValEntryByNumber, GetBinEntryByNumber added
1647 - NewValEntryByNumber and NewBinEntryByNumber added
1649 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1651 - GetSQItemNumber and SetSQItemNumber added, to provide
1652 a (relative) Item identier inside a given Sequence
1653 \warning : some pb remaining around this number
1655 - AddEntry now takes the Item Number as a param
1657 - adding a constructor taking a gdcmDocEntry as an input param
1659 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * Memory leak hunt with the following command:
1661 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1662 --show-reachable=yes gdcmTests PrintDocument
1663 It looks like many (all?) leaks are due to the STL (or a bad usage
1664 of the STL. The lines producing the leaks now have a comment with
1665 a "MEMORY LEAK" tag: you can retrieve them with
1666 grep "MEMORY LEAK" src/*
1667 Here are two typical examples which I can't help fixing:
1672 char * test = "babo";
1673 name = test; //// <--- valgrind detects 960 bytes lost in
1674 //// call to std::string::operator=(char const*)
1675 name.clear(); //// Doesn't help !
1683 std::cout << "Type a bunch of characters followed by RETURN: ";
1684 getline(std::cin, line); //// <--- valgrind dectects a loss
1685 //// of 1320 bytes in call to
1686 /// std::basic_istream<>& std::getline<>
1692 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * src/gdcmHeader.[cxx|h]:
1694 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1695 and related, moved away to gdcmDocument.
1696 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1697 the corresponding protected accessors of inherited class
1698 gdcmDocument, removed ! As a consequence gdcmFile had to be
1699 declared friend of class gdcmDocument (see below).
1700 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1701 - Clean up of undefined or unused methods.
1702 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1703 account the changes to gdcmHeader.h).
1704 * src/gdcmDocument.h:
1705 - gdcmFile is now a friend class (in order to take into account the
1706 changes to gdcmHeader.h).
1707 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1708 (see changes to gdcmHeader.h).
1709 - Accessors (reading on the form GetEntry*) are now public.
1710 - Clean up of undefined or unused methods.
1711 * src/gdcmDocument.cxx:
1712 - adaptation to changes to gdcmDocument.h
1713 - ::OpenFile now writes a verbose message when file cannot be opened.
1714 - some std::string properly set to VRKey
1715 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1716 references to gdcmDocument.
1717 * Test/TestFindTags.cxx: changed accordingly to above changes.
1718 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1719 cvs repository gdcmData.
1721 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1723 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1724 conflicts with gdcmValEntry::voidArea.
1725 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1726 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1727 Value representation between StringRepresentable and BinaryRepresentable.
1728 * src/gdcmDocument.cxx:
1729 - method ParseDES: proper indentation restored and usage of
1730 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1731 - method LoadDocEntry: the fingerprint left in the SetValue() of
1732 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1733 removed. Reverting to previous code segment with the proper
1734 dynamic_cast< gdcmValEntry* >.
1735 Note: this was (partially) breaking the python test suite
1736 (gdcmPython/testSuite.py) that made usage of the above
1737 fingerprint to check presence of "Pixel Data".
1738 * src/gdcmDocEntry.h: coding style.
1739 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1740 now taken into account.
1741 * gdcmPython/gdcm.i: adaptation to the new internal representation
1742 of gdcm (exit gdcmParser, hello gdcmDocument).
1743 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1745 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1746 anymore, but instead prints the loaded Python dictionary.
1747 * .... alas, the python testSuite is still broken.
1749 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1750 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1752 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1753 * src/gdcmUtil.h : export methods
1755 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1758 * Initial addition of automatic python testing
1759 * Initial addition of automatic image comparison
1761 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1762 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1763 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1765 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1766 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1767 * Test/ShowDicom.cxx : bug fix for msvc compilation
1768 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1770 2004-05-04 Jean-Pierre Roux
1771 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1772 new concepts (and new classes) :
1773 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1774 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1775 - Sequence Doc Entries (gdcmSeqEntries)
1776 a Sequence is composed of Items.
1777 Each item is a set of Doc Entries (this is recursive)
1778 The non uniqueness of the 'Dicom tag' is due to this recursivity
1779 (never taken into account)
1780 Our unability to add a new 'entry' in the header
1781 at the proper location (neither in the H-Table (map or multimap),
1782 nor in the Chained List is also due to this recursivity.
1783 Don't try, right now, to use/modify/compile these new sources :
1784 nothing is finished.
1785 We just commit all the stuff, 'as is', in order not to loose it.
1787 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1788 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1790 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1791 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1792 file prefix (SetFilePrefix)
1794 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * Add a new test: ShowDicom, for now this is just the c++ version of
1796 checkRead.sh, later it will be able to compare the image read against a
1798 * Replace the DEBUG on the stack with a global entry in cmake interface:
1799 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1801 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * Add an example subdir, with a real example on how to read + write a
1805 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1807 * Doc/CMakeLists.txt: the main page is now properly differentiated
1808 between the developper and user version.
1809 * Doc/doxygen.config.in: dropped search related obsolete flags
1810 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1812 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * DEVELOPPER: added some helpfull comments for compile/test/install
1816 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1817 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1818 src directory, now generated in the build dir.
1819 2. Tests as mentionned smarter
1821 4. Add a new method in gdcmDict that return the PubDict by name
1822 this is interesting for 3rd party lib like ITK,
1823 where we could set the institution name / patient name...
1825 * ENH: 1. Now the test suite is working for real
1826 2. All binaries are now output in the gdcm-bin directory
1827 (this was not true before)
1829 2004-04-28 Jean-Pierre Roux
1830 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1831 SeQuence indented printing of Dicom Header.
1832 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1833 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1834 Computation of SQDepthLevel is now part of gdcmHeader constructor
1835 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1836 tree-like structure of a Dicom Header.
1837 * FIX Test code cleaning
1839 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * ENH: Adding automatic testing
1841 1. Need a DartConfig.cmake to submit to public
1842 2. Add a test driver gdcmTest.cxx
1843 3. gdcmTestMain, an helper for the main test driver gdcmTest
1844 4. Files in Test don't have a main anymore, this becomes interesting
1845 when we add more and more tests, thus dsw don't have to load
1847 * ENH: Adding a GDCM_DATA_ROOT for testing
1848 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1849 one file instead of seven + some small cleanup
1851 2004-04-22 Jean-Pierre Roux
1852 * ENH Minor changes to the Print() methods.
1853 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1854 Header printing. Example given with :
1855 > PrintHeader fileName 2 new
1856 (SQ based tree-like structure still to be done for the Header ...)
1858 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1859 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1860 1. I have added some unsigned where needed
1861 2. Some function parameter not used -> (void)
1862 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1863 4. g++ don't like character '\' in comment
1864 5. #define jpeg_create_decompress jCreaDecompress
1865 this really need to be fixed
1866 6. virtualize destructor of gdcmObject ... leakage
1867 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1868 this also really need to be fixed
1869 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1870 remove compression file
1871 (as we only do decompression, right ?)
1872 * ENH: Change malloc/calloc/free with c++ equivalent
1874 2004-04-21 Jean-Pierre Roux
1875 * FIX gdcmHeaderHelper::GetXSpacing
1876 when a single value is found (bug ?), xpacing is now
1877 defaulted to yspacing
1879 2004-04-19 Jean-Pierre Roux
1880 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1881 * ENH add parameters :
1882 bool exception_on_error = false,
1883 bool enable_sequences = false,
1884 bool ignore_shadow = false
1885 to the gdcmFile constructors to be full gdcmParser compliant
1886 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1887 to allow reading of PAPYRUS 3.0 files
1889 2004-04-06 Jean-Pierre Roux
1890 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1892 2004-04-02 Jean-Pierre Roux
1893 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1894 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1895 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1897 2004-03-30 Jean-Pierre Roux
1898 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1899 for ACR file, written out as DICOM files (hope so...)
1901 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1903 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1904 moved to base class gdcmParser and only the specialisation is kept
1906 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1907 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1908 already does the job.
1909 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1910 (to be consistent with gdcmParser::WriteEntries).
1912 2004-03-30 Benoit Regrain
1913 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1914 upate of the object's instance. It's passed to 2 in the unfavorable
1915 case : one in the ExecuteInformation, one in the ExecuteData
1917 2004-03-29 Jean-Pierre Roux
1918 * ENH : Check on file type to be written moved
1919 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1920 * FIX : gdcmObject::ResetBoundaries now stops properly
1921 when end-of-list is reached
1922 : gdcmVersion modified (as Benoit Regrain asked)
1924 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1926 * src/gdcmUtil.cxx: added forgotten iostream include.
1927 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1928 equivalent to ExplicitVR in existing code).
1930 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1932 now contains all the gdcmGlobal related code.
1933 * minor coding style and doxygenation changes.
1935 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1937 now contains all the Debug related code.
1938 * minor clean-up of includes in src/*.cxx
1939 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1940 CreateCleanString) removed.
1941 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1942 * Doc/DoxyMainPageUser.txt added.
1943 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1944 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1945 src/gdcmDirList.cxx)
1947 2004-03-24 Jean-Pierre Roux
1948 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1950 2004-03-23 Jean-Pierre Roux
1951 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1952 big endian made volumes
1953 * ENH Now gdcmParser constructor and destructor are protected to forbid
1954 end user to instanciate class gdcmParser
1955 (only gdcmHeader and gdcmDicomDir are meaningfull)
1957 2004-03-22 Benoit Regrain
1958 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1959 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1960 gdcmSerie to gdcmDicomDirSerie
1962 2004-03-19 Jean-Pierre Roux
1963 * ENH Now the tree-like structure describing a DICOMDIR comming from
1964 an already existing DICOMDIR file is consistent with
1965 the home-made tree-like structure build ex-nihilo
1966 or build from the files held (recursively) in a Directory
1967 functions gdcmDicomDir::CheckBoundaries()
1968 gdcmObject::SetBoundaries() added
1970 2004-03-17 Jean-Pierre Roux
1971 * REM (Eric Boix bug) : removal of meaningless
1972 gdcmDicomDirImage::NewImage function.
1973 * FIX now file names and directory name are written properly in the
1975 * FIX now gdcmDicomDir constructor may be call without any trick
1978 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1980 of gdcmDicomDirImage::NewImage as empty function.
1982 2004-02-28 Jean-Pierre Roux
1983 * ENH add gdcmDicomDir:NewPatient
1984 add gdcmDicomDirPatient:NewStudy
1985 add gdcmDicomDirStudy:NewSerie
1986 add gdcmDicomDirSerie:NewImage
1987 to allow making gdcDicomDir object.
1988 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1989 (as opposite to the gdcmHeader chained list)
1991 2004-02-11 Benoit Regrain
1992 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1993 when using from python
1995 2004-02-10 Benoit Regrain
1996 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1997 * FIX : in gdcmDicomDir when the directory is empty
1998 * ENH : add callback and methods to get the progression of dicomDir
2001 2004-02-06 Jean-Pierre Roux
2002 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2003 - GDCM_META added to gdcmDicomDirType
2004 - class gdcmMeta created
2005 * ENH : - A brief summary is now displayed at the beginning of
2006 'testDicomDir' to help disaster magnitude estimation
2007 * REM : Now useless Test/explDICOMDIR.cxx
2009 2004-02-05 Benoit Regrain
2010 * ENH : add methods in gdcmObject to get the hash table or the list of
2012 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2013 * FIX : wrapping python for TagHeaderEntryHT
2015 2004-02-04 Benoit Regrain
2016 * FIX : even length for some strings when writting the dicom dir
2017 * FIX : sort the images in the dicom dir
2018 * FIX : Bug fix for python use of dicom dir
2019 * ADD : a python demo
2021 2004-02-04 Jean-Pierre Roux
2022 * FIX : Final solution (?) for icone embedded images
2023 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2024 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2025 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2026 gdcmData/gdcm-MR-SIEMENS-16.acr1
2027 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2028 to make full checking easier
2030 2004-02-04 Benoit Regrain
2031 * FIX : WriteEntries : coding style & logic in parameters
2032 * FIX : Set the elements to create the DicomDir in a dictionary file
2034 2004-02-03 Benoit Regrain
2035 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2036 * gdcmDicomDir : add the load of directory
2037 * Bug fix and print add-on
2039 2004-02-03 Jean-Pierre Roux
2040 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2041 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2042 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2043 * FIX gdcmParser.cxx : 'group length' elements are now considered
2044 as integers, even for shadow groups, when file is Implicit VR
2046 2004-02-02 Jean-Pierre Roux
2047 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2049 of the last synonym :-(
2050 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2052 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2053 * FIX taking into account the possible 7fe0,0010 multiplicity
2054 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2055 to allow removal of references to 7fe0,0010, to deal with
2056 ACR-NEMA images, when 0028,0200 is meaningfull
2058 2004-01-31 Jean-Pierre Roux
2059 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2060 no longer writes 'Un' on disk
2061 * FIX SQ elements with actual length are now dealt with corectly
2062 * FIX gdcmFile::WriteBase make the difference, for color images, between
2063 the length (for Palette expanded images)
2064 and Raw Length (non expanded image + Palette)
2065 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2066 (that broke Write). Replaced by UL.
2067 Aware user will reload the field if he
2068 thinks it's necesssary
2070 2004-01-30 Jean-Pierre Roux
2071 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2072 when 'dirty Acr' is found, to be compliant with the new
2073 IsReadable() methods.
2075 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2076 (no DOUBLE images in kosher DICOM,
2077 but so usefull for people that miss them ;-)
2079 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2080 DICOMDIR related utilities (not checked as Windoze compliant)
2082 2004-01-28 Jean-Pierre Roux
2083 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2085 2004-01-27 Jean-Pierre Roux
2086 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2087 to allow skipping the shadow elements, to save memory space.
2088 The TRUE value for this param has to be used
2089 with a FALSE value for the 'enable_sequence' param.
2090 ('public elements' may be embedded in 'shadow Sequences')
2091 * gdcmHeader methods now deal with 'embedded icones images' in the header
2092 (even when an 'icone image sequence' is announced by the
2093 element (0x0088,0x0200), but there is NO icone at all ...
2095 * gdcmHeader sometimes Image Location value doesn't follow
2096 the supposed processor endianity (see gdcmData/cr172241.dcm).
2099 * gdcmHeader add the method
2100 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2101 to get *all* the Header Entries with the same tag.
2102 GetHeaderEntrySameName is probabely *useless*
2103 (no meaning : Name is *not* an identifier within the Dictionary)
2105 2004-01-26 Benoit Regrain
2106 * Bug fix in the print of hexadecimal representations. Remove long fields
2107 in the print and add a third level of print to print them
2109 2004-01-23 Benoit Regrain
2110 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2111 * Bug fix on test suite after remove the strip made on not string fields
2112 * Split the IsReadable method between gdcmParser which test that the file
2113 is dicom and gdcmHeader which test that it's an image file
2115 2004-01-22 Benoit Regrain
2116 * DicomDir : clean code, add methods, set variables in protected or private
2117 * gdcmUtil : bug fix for the clean string method
2119 2004-01-19 Benoit Regrain
2120 * Add the use of shadow dictionaries
2121 * bug fix and coding style
2123 2004-01-19 Benoit Regrain
2124 * src/gdcmFile.cxx : bug fix concerning the close of file
2125 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2126 * Add the update of header entries using the shadow library
2128 2004-01-19 Benoit Regrain
2129 * removal of file gdcmHeader2.cxx
2130 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2131 inheriting from gdcmParser. This split is to prepare the integration
2132 of dicom dir parsing
2133 * bug fix under python
2135 2004-01-16 Jean-Pierre Roux
2136 * REM removal of class gdcmHeaderEntrySet
2137 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2138 * ADD add file gdcmHeader2.cxx
2139 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2141 2004-01-15 Benoit Regrain
2142 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2143 entries created while parsing the header. Thus, they will be destroyed
2144 when the gdcmDictSet will be destroyed
2145 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2148 2004-01-15 Benoit Regrain
2149 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2150 made a fatal error because of the memory release at the end of program.
2151 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2152 some memory and vtk seems to have some problems with that.
2153 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2155 2004-01-14 Benoit Regrain
2156 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2157 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2158 * src/*.[h|cxx] : make changes due to class name changes
2159 * gdcmPython/demo/*.py : bug fix due to method names
2161 2004-01-13 Benoit Regrain
2162 * src/*.[h|cxx] : coding style
2163 * vtk/*.[h|cxx] : coding style
2165 2004-01-13 Benoit Regrain
2166 * gdcmPython/testSuite.py : test the readable flag of file for tests
2167 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2168 It's lied to the stl compilation by MSVC (windows, always windows...)
2169 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2171 2004-01-12 Benoit Regrain
2172 * src/*.h : add comments
2173 * src/gdcmDictSet.h : set the method BuildDictPath in public
2174 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2175 directly setted in the source code
2176 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2179 2004-01-09 Benoit Regrain
2180 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2181 * setup.py : use a reference to gdcmVERSION
2183 2004-01-07 Benoit Regrain
2184 * Modification to compile with the distutils.
2187 2003-12-10 Benoit Regrain
2188 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2189 can use a gdcmHeaderHelper to load data
2190 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2191 made in the source code
2193 2003-12-10 Benoit Regrain
2194 * Update Windows projects and .cvsignore files
2196 2003-11-12 Jean-Pierre Roux
2197 * ENH gdcmHeader constructor has one more parameter (default value : false)
2198 that allows the user to 'go inside' the SeQuences only
2200 gdcmElValSet:Print takes it into account
2202 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2203 * ENH: Update gdcmPython/CMakeLists
2204 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2205 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2207 2003-11-10 Jean-Pierre Roux
2208 * FIX : gdcmHeader::LoadElements is now based
2209 on the ListTag listElem member,
2210 not longer on the TagElValueHT tagHt member
2211 * ENH : PrintPubElVal shows (temporarily) both results,
2212 with the tagHt member and the listElem member.
2213 (it's easier to 'see' the problems when using Printheader)
2215 * FIX : old private member LgrElem is now splitted into
2216 ReadLength : Length actually found on disk (updated only
2217 if bug fixing is necessary), for internal
2219 UsableLength : Updated by FixFoundLength, to fix a bug
2220 or to allow Parser going on.
2221 Will allow to re-write a kosher header when a SeQuence
2222 with a length (not 0000) is found
2223 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2224 because gdcmElValSet::Add does not update ListElem
2227 2003-11-07 Jean-Pierre Roux
2228 * FIX misstyping in Transfert Syntax name table
2229 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2230 when they have an actual length (not 0000 nor FFFFF)
2231 (Nobody should care of it, but DICOMDIR explorers)
2233 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2234 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2236 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2237 * ENH: vtkGdcmReader now supports LUT !
2238 (vtkgdcmViewer for now is not able to use them though)
2240 2003-11-05 Jean-Pierre Roux
2241 * in testSuite.py : new files names for checking the package
2242 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2243 that returns the pixel area size to the *aware* (vtk) user
2244 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2246 2003-11-05 Benoit Regrain
2247 * in testSuite.py : Modify the rules for checking the paths
2248 : Explicit error messages
2249 * in __init__.py : Related modif
2251 2003-11-03 Jean-Pierre Roux
2252 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2253 to be used by aware (vtk) users that want to manage
2254 LUT (and no to turn the PALETTE image into an RGB pixels one)
2255 * GetPixelType now returns 8U for 24 Bits images
2256 (vtkGdcmReader compliant)
2258 2003-10-31 Jean-Pierre Roux
2259 * Removal of *all* gdcmData images and add them again
2260 in order to loose the 'history' of un-anonymised images
2262 2003-10-31 Jean-Pierre Roux
2263 * RMV : removal of useless jBitsInJsample.h
2264 for both 8 and 12 Bits JPEG Lossy Libraries
2266 2003-10-31 Jean-Pierre Roux
2267 * ENH : Add the functions gdcmFile::GetImageDataRaw
2268 gdcmFile::GetImageDataIntoVectorRaw
2269 that act as GetImageData and GetImageDataIntoVector
2270 except the making of an RGB Plane from Gray Plane + LUT
2271 Intended to aware (vtk) users who know how to manage
2274 GetLUTRGBA return a R,G,B,A LUT if any
2275 lgrTotaleRaw gives the 'Raw' length
2276 GetImageDataRaw returns the gray Plane
2277 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2278 (They stay Grey, just like with other Dicom viewers :-(
2280 2003-10-30 Jean-Pierre Roux
2281 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2283 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2285 being coherents dicom files.
2287 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2288 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2290 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2291 * ENH: Two steps is necessary to please VC++ compiler...
2292 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2293 * ENH: Add include dir to medcon lib
2294 * FIX: only one function is being exported for now !
2295 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2297 2003-10-29 Jean-Pierre Roux
2298 * adding gdcmHeader::GetLUTRGBA
2299 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2300 --> Mathieu, the modif u're waiting for is not yet committed
2301 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2303 2003-10-27 Jean-Pierre Roux
2304 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2305 00191113.dcm DermaColorLossLess.dcm
2306 MxTwinLossLess.dcm RadBWLossLess.dcm
2307 * ENH: For version prior to vtkImageViewer2 -r 1.19
2308 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2310 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * Removal of ido stuff in CMakeLists.txt
2313 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2314 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2315 * FIX: remove a call to ->Modified ... see comments
2316 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2318 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2319 * FIX: Problem with path for libvtkgdcmPython
2320 * ENH: Try adding a search script for python site-package
2321 * RMV: Remove some file from medcon lib that are not necessary
2322 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2323 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2324 * FIX: More pragma disable fro VC++,
2325 I don't think I break something as it is also disable in VTK/ITK.
2326 But it fasten debug compilation time.
2328 2003-10-23 Jean-Pierre Roux
2329 * gdcm now deals with 16 Bits Run Length Encoded images
2330 (they are compressed as 2 planes images,
2331 one for the high Bytes, the other for low Bytes)
2333 2003-10-22 Jean-Pierre Roux
2334 * Now CheckRead takes into account :
2335 - the bugged 'Leonardo' Siemens images
2336 - the XA images, sent thru the burning VPRO station
2337 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2340 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2341 * FIX: When copying a Makefile.am to CMakeLists.txt
2342 one should remove the '\'
2344 2003-10-22 Jean-Pierre Roux
2345 * in gdcmData adding a bugged 'Leonardo' Siemens image
2346 (wrong lengths in header)
2347 OK with gdcm, KO with the other viewers :-)
2348 * add a GE dlx XA image, thru the VEPRO burning station
2351 2003-10-21 Jean-Pierre Roux
2352 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2353 for a brutal checking of vtkgdcmViewer compliance
2355 2003-10-21 Jean-Pierre Roux
2356 * add the files for 'xmedcon' Jpeg Lossless library
2357 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2359 2003-10-21 Jean-Pierre Roux
2360 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2362 2003-10-21 Jean-Pierre Roux
2363 * garbage Siemens 'Leonardo' images dealt with
2364 (the patch is easy to remove)
2365 * cosmetic changes to avoid warnings
2367 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2369 no need to press 'r' now.
2371 2003-10-20 Jean-Pierre Roux
2372 * upgrade of checkRead.sh checkWrite.sh according
2373 to new Jpeg Lossless decompressor
2374 * add US.3405.1.dcm, a genuine RGB medical file ...
2375 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2376 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2378 2003-10-15 Jean-Pierre Roux
2379 * general anonymisation in gdcmData
2380 * adding the 'color files' from
2381 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2382 * adding some well knowed bugged-header images
2383 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2384 waiting for their inclusion in Python testsuite
2386 2003-10-15 Jean-Pierre Roux
2387 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2388 no longer seg faults when file is not found
2390 2003-10-14 Jean-Pierre Roux
2391 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2394 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2395 * TODO: *.in file to genereate a UseGDCM later
2397 2003-10-14 Jean-Pierre Roux
2398 * Some supposed-to-be Dicom Images have no preamble.
2399 OpenFile takes it into account
2400 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2401 * Missing elements added in dicomV3.dic
2402 (just to be affraid : have a look at
2403 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2404 and do it again next year ;->
2406 2003-10-13 Jean-Pierre Roux
2407 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2408 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2409 But there are NOT. It's fixed !
2411 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * FIX: "jpeglib.h" was not found on VC++
2413 * FIX: vtkgdcm was not being installed
2415 2003-10-10 Jean-Pierre Roux
2416 * ENH : OpenFile closes the file if it *really* doesn't look like
2417 an ACR-NEMA / DICOM one.
2418 * FIX : testWrite no longer writes an empty file if the source file
2419 is not gdcm Readable
2420 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2423 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * FIX: CMake generate now documentation
2425 * ENH: out of source doc build !
2426 * ENH: Generate both user and dev documentation
2427 * ENH: Should work on windows too
2428 * ENH: Only one doxygen config.in file is needed
2429 * FIX: make install should be ok now on ùnix plateform
2430 * FIX: PATH to dictionary was wrong (missing /)
2431 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2433 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2434 * vtkGdcmReader is now able to read rgb dicom file.
2435 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2436 * added a gdcmViewer to vtk test, use mouse to control
2437 window level & window width
2439 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * CMake-ification of gdcm, we have now two build system
2441 * FIX: on cygwin Wsock32 doesn't exist
2442 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2444 2003-10-06 Emanuel Ollart
2445 * FIX : compilation process wad broken.
2446 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2448 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * change gdcmViewer -> vtkgdcmViewer
2450 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2452 2003-10-06 Jean-Pierre Roux
2453 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2454 ( e.g : well known GE images with a wrong elem length,
2455 : Philips MRI Images with a wrong Huffman table)
2456 * still to be done : allow the reading of bugged LEONARDO Siemens images
2458 2003-10-03 Jean-Pierre Roux
2459 * Odd length strings are padded with '\0' (not with spaces,
2460 to remain compliant with already defined strings,
2461 like Transfert Syntax UID and others)
2463 2003-10-03 Jean-Pierre Roux
2464 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2465 to allow displaying RGB images (not only by affim ;-)
2467 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2468 * vtkGdcmReader is now able to read rgb dicom file.
2469 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2471 2003-10-03 Jean-Pierre Roux
2472 * A few nasty patches to allow the reading of a lot of nasty images
2473 ( e.g : well known GE images with a wrong elem length,
2474 : Philips MRI Images with a wrong Huffman table)
2475 * still to be done : allow the reading of bugged LEONARDO Siemens images
2477 2003-10-03 Jean-Pierre Roux
2478 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2480 2003-10-03 Jean-Pierre Roux
2481 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2482 to allow displaying RGB images (not only by affim ;-)
2484 2003-10-03 Jean-Pierre Roux
2485 * gdcmFile::GetImageDataIntoVector now
2486 - deals with MultiFrames MultiFragments Run Length Encoded files
2487 - deals with YcBcR (YBR_FULL) files
2488 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2489 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2491 (no sample found :-(
2493 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2494 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2495 Two reasons: - clear things
2496 - third parties acces gdcm through header files, so won't
2497 suffer anymore VC++ complains
2499 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2500 * add argv[1] in testvtkGdcmReader.cxx
2503 2003-09-24 Jean-Pierre Roux
2504 * The lines are now eigthy characters long.for
2505 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2507 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2508 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2509 char* to std::string. Thus, the use of strdup becomes useless. (see
2510 previous commis of Malaterre)
2511 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2512 before the last Malaterre's commit.
2514 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2515 * This commit should fix the Debug building under VC++, the problem
2516 was mainly a mixture of debug and release lib being loaded at startup.
2517 * I also remove a depency to a specific C function: strdup. Because I had
2518 to force the link to msvcrtd (whereas strdup is in libc).
2520 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2521 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2522 located in the gdcmCommon.h file. All use of reference of tha has been
2523 changed to now use the variable GDCM_UNFOUND.
2525 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2527 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2528 Dicom dictionary. The test suite can now be run again. Note:
2529 I'm note very happy with the " (RET)" changes. I believe this
2530 RETAINED comment should be dropped when parsing the dictionary.
2531 - PACKAGER corrected
2533 - AUTHORS updated and now in alphabetical order
2534 * Makefile.am now exports gdcm.dsw for Windoze users.
2536 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2537 * cygwin complains about missing std:: in subdir Test/
2539 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2540 * remove some methods that are now in gdcmHeaderHelper
2542 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2543 * vtkGdcmReader set spacing and origin correctly
2545 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2546 * Fix a few delete/delete[] mismatch
2548 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2550 interpretation to data given by gdcmHeader. For instance there are
2551 heuristics to get informations (look at different places).
2552 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2553 sorting DICOM images based on different strategies.
2554 * modified Makefiles accordingly.
2556 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2558 when building in debug mode
2559 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2560 src/win32/gdcmdll.dsp
2561 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2563 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2564 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2567 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2568 * src/win32/libgdcmjpeg12.dsp was not dos format
2569 * src/win32/libgdcmjpeg12.dsp :
2570 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2571 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2573 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2574 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2576 * src/gdcmFile.cxx : bug fix in affectation type
2577 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2578 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2579 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2580 symbols... future problem ?
2582 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2583 * src/win32/libgdcmijpeg12.dsp was missing
2584 * modified gdcm.dsw accordingly
2586 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2587 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2589 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2590 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2591 commit of JPR (before his hollidays to facilitate our work).
2592 * setup.py : bug fix in code. Modifications made while the last commit
2593 of JPR. The code hasn't been tested before the commit... it's so
2594 useless to make that (for best programmer that is JPR) !!!
2596 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2597 * tagged the current version as Version0_3 (i.e. version 0.3)
2599 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2600 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2601 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2602 * *.dsp : modifications to use new libgdcmijpeg8 library
2603 * setup.py : bug fix on VTKPATH variable
2604 * PACKAGER : adding all concerning windows
2606 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2609 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2610 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2611 test suite reported error.
2612 * PACKAGER file added (describes what a packager must do when
2613 packaging a new release).
2614 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2615 * configure.in: upgraded version number to 0.3.0
2616 * fixing build of rpm (through rpm -ta):
2617 - Doc/Makefile.am exports proper doxygen files
2618 - src/jpeg/libijg8/Makefile.am exports the include files.
2620 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2621 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2622 * src/gdcmHeader.h : formatting code
2624 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2625 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2626 We were obtaining error message from vtk. Now, creation of file list
2627 is made in an internal list to prevent this problem.
2628 Bug fix when output is empty.
2629 Bug fix in update of progress value. Previous commit for this was a bad
2631 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2633 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2634 * src/gdcmHeader.h : added method to get the file name
2635 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2636 files. Added method to remove all files on the input
2637 Added FIXME comment concerning the bad parsing of header made by
2638 ExecuteInformation method (in ExecuteData method)
2640 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2642 when using make instal.
2643 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2644 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2646 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * setup.py : adding include dir of jpeg lib to compile all sources
2648 * */Win32/*.dsp : JPR fix for windows compilation
2650 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2651 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2653 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2654 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2656 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * setup.py is again effective on un*x (takes into account the
2658 addon of the jpeg library)
2659 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2660 * Doc/Doxy* updated (includes above enhancements)
2661 * INSTALL now points to web documentation
2663 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * src/gdcmHeader.h doesn't make unnecessary reference to
2666 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2668 * src/gdcm*.[cxx|h] :
2669 - to allow compilation with gcc 3.x
2670 -- clean up of STL usage (added explicit usage of std::)
2671 -- small fixes on exceptions.
2672 Note: linking not tested !
2673 - clean of doxygen comments to avoid warnings at documentation
2675 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2676 dependent convertion).
2678 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * Clean up of previous JPR garbage commit (not even commented in the
2681 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2682 - moved all jpeg related files from src to src/jpeg/libijg8, with
2683 addition/modification of Makefile.am and configure.in.
2684 - the testSuite is still brain damage (not guilty).
2686 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2687 * WrapVTK.py : modifications to get correctly vtk source files to
2689 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2690 (FileName -> Filename)
2692 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * vtk/vtkGdcmReader.[cxx/h]:
2694 - UpdateProgress method should now be effective
2695 - removed the limitation on having only images loaded (as opposed
2697 - when building a stack of images/volume, a lesser number of
2698 gdcmHeader and gdcmFile instances should be used (hopefully
2699 accelerating things).
2700 - when building a stack of images/volumes, files which are not
2701 loadable (wrong path-filename, wrong permissions on existing file,
2702 or file not parsable by gdcm) are replaced with a black image
2703 in the stack (for the caller to notice the problem).
2705 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2708 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2709 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2710 between standard library (std) and vtk library (problems are found
2711 under Windows... thanks Windows !)
2713 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2716 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2718 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2721 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * When compiling with distutils (see setup.py) the C++ compiler is
2723 called with different flags than the default ones (with automake).
2724 In order to fix all those warning, I compiled gdcm with the command
2725 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2726 and went for warning fixes:
2727 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2728 up from unused variables.
2729 - vtk/vtkGdcmReader.cxx: potential bug fix.
2730 * src/gdcmHeader.h: Doxygen warning cleanup
2732 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * gdcmPython/gdcm.i:
2734 - typemaps correction to take into account the systematic replacement
2735 of "using namespace std" with std:: prefix e.g. std::list,
2736 std::string... (cf changes of 2003-05-21).
2737 - gdcmGlob global variable of type gdcmGlobal (defined in
2738 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2739 exported to Python a as cvar.
2740 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2741 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2742 gdcmDictSet.GetPubDictTagNames() and
2743 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2744 C++ static methods).
2745 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2746 with the above changes.
2748 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2749 * setup.py, manifest.in : bug fix under linux
2751 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2752 * Modification of setup.py to compile vtk part too. Then, we have 2
2753 wrappers which must work with same distutils. For that, we have a
2754 generic distutils in distusiltsWrapping.py ; with :
2755 - build_extWrap class to wrap generically all extensions,
2756 - ExtensionWrap base class for all wrapping extension that contains
2758 - Wrapper interface which wrap sources
2759 + In WrapSwig.py we have extension and wrapper for Swig
2760 + In WrapVTK.py we have extension and wrapper for VTK
2761 * MANIFEST.in : modifications to consider vtk directory and new python
2762 files for compilation
2764 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2765 * Added python wrappers of vtkGdcmReader vtk class (see the
2766 source in vtk/vtkGdcmReader.cxx) :
2767 - vtk/Makefile.am now builds a library
2768 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2769 python library (as opposed to _gdcm.so wich are the python
2770 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2771 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2773 - configure.in has an additional flag --enable-vtk that needs
2774 to be set to enable compilation of vtk related code, that is:
2775 + vtk/vtkGdcmReader.so and
2776 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2777 + gdcmPython/vtkgdcmPython.so (see above)
2778 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2779 be read when compressed or when HighBit + 1 != BitsStored),
2780 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2781 the usage of the python wrapper of vtkGdcmReader vtk class.
2782 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2783 * src/*.[h] all occurences of stl classes are now prefixed with
2784 std::, and all occurences of "using namespace std;" where removed.
2785 This is to avoid pollution of global namespace in included files.
2786 Apparently vtk does not avoid this pitfall: when using both
2787 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2788 collision of various stl members (principally cout...).
2789 * gdcmPython/testSuite.py now cleanly removes temprory generated
2791 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2792 comply with above changes)
2794 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2795 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2796 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2797 vtk data structure (an image Flip was required).
2798 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2799 * cosmetic changes in documentation.
2801 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2802 * src/gdcmHeader.cxx: the constructor no longer exits when an
2803 unexisting file is given as argument.
2804 * The subdirectory Data (containing all the images used for the
2805 test suite) is not part of this repository anymore. A new module
2806 containing those images is now available at
2807 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2808 with the name gdcmData.
2809 All the python scripts (including the package initialisation file
2810 gdcmPython/__init__.py) were adapated to take this change into
2811 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2813 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2814 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2815 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2816 demo of the usage of this class.
2817 Compilation of this vtk part is only done when using the --enable-vtk
2818 at configure (or autogen.sh) stage.
2820 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2821 * More memory link related corrections and documentation fixes.
2823 - maximum info is obtained with a command of the form:
2824 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2825 --show-reachable=yes PrintHeader
2826 - the remaining reachable blocks seem to come from the STL
2827 allocation scheme through the usage of map and list. It looks
2828 like this memory cannot be freed but it is not a memory leak
2829 (in fact further invocation to the STL would recollect the
2830 unused memory allthough it cannot explicitely be freed).
2831 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2832 of displaying an image parsed with gdcm and displayed with VTK.
2833 Note: some images don't seem to work e.g.
2834 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2835 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2836 Allthough this weakens the semantics, it is a ditch attempt to
2837 make gdcm more thread friendly.
2839 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2840 * Memory link hunt (by using valgrind through the command
2841 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2842 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2843 gdcmHeader::_dicom_vr.
2844 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2845 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2847 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2849 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2850 * src/Makefile.am now exports all the necessary include files at
2854 * UpdateGroupLength replaced by new one
2857 * UpdateGroupLength re-written using H-Table
2858 (named UpdateGroupLengthNew untill checks are over)
2860 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2861 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2862 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2864 - gdcmHeader::GetPubElValSet removed.
2865 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2866 UpdateGroupLength, WriteElements, Write.
2867 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2868 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2869 carried the same semantics.
2870 - src/gdcmHeaderIdo.cxx changed accordingly.
2871 - gdcmFile::WriteBase now regroups all the codes from previous
2872 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2873 - enum FileType moved to gdcmCommon.h
2874 * src/gdcmHeader.cxx AddDefault trashed
2875 * gdcmGetXSize added
2876 * getimageDataSize now calls gdcmGetXSize
2877 * Test/*.cxx changed to agree with above changes
2879 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2881 (to avoid double call by end user).
2882 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2883 by end user, since gdcmHeader::gdcmHeader now handles it.
2885 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * gdcm/Doc many doxygen changes:
2887 - Doxyfile now has two different versions, DoxyfileUsers that generates
2888 the html.users end users oriented documentation and
2889 DoxyfileDeveloppers that generates the html.developper developper
2890 oriented documentation.
2891 - README changed accordingly
2892 - requirement.txt removed (old design info moved to TODO).
2893 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2894 DoxyMainPage.txt, DoxyPython.txt provide more information.
2895 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2896 be updated by simply regenerating the docs with doxygen and copying
2897 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2898 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2899 all the tests in the form "if (<map>.count() >1)" were removed.
2900 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2901 ill-formed documentation sections.
2902 * src/gdcmHeader.cxx: ditto
2904 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2905 * setup.py fixed for un*x (needed macro for stdint.h)
2906 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2907 un*ces with sh-utils test utility.
2908 * gdcmPython/demo/test.py renamed to PrintHeader.py
2909 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2910 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2911 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2912 * src/gdcm*.cxx JPR's bad inclusion fixed.
2914 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2916 * gdcmPython/demo/test.py changed accordingly.
2918 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2919 * gdcmPython/Makefile.am fixed linking against libstdc++
2920 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2921 * Swig subdir (historical tests of swig version 1.3.17++) removed
2922 * Test/testChangeEntete.cxx some lines commented out in order to make
2924 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2925 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2927 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2929 hence the user doesn't need this explicit call.
2930 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2931 i.e. LoadElements() call removed.
2932 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2933 - src/Makefile.am declares the proper flag for g++.
2934 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2935 for adding user defined new tags.
2936 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2937 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2938 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2940 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2941 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2942 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2943 src/Makefile.am : the project should properly compile and install
2944 with the autotools, included the python wrappers part.
2945 * gdcm.spec.in : added a spec file for RPM packaging.
2947 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2948 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2950 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2952 to exported to the environement (see gdcmPython/testSuite.py
2954 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2955 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2956 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2957 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2958 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2960 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * gdcmPython/__init__.py doesn't crash anymore when running in
2962 in InstallMode or PreInstallMode but with an environment given
2963 value of GDCM_DICT_PATH.
2964 * src/gdcmDictSet.[cxx/h] coding style.
2966 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2968 * src/gdcm.h general comments moved to TODO, and README
2969 * src/gdcm.h should now be seen as a user commodity (including it
2970 should suffice to fully use gdcm). It is nowhere including within
2971 any of the kernel files src/*.cxx and src/*.h.
2973 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2975 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2977 * src/gdcm*.cxx only include their corresponding include file
2978 (as opposed to gdcm.h)
2979 * gdcmPython/gdcm.i changed accordingly
2980 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2981 the autogen.sh generated "make snapshot" command to work.
2982 * autogen.sh removed history related references to crea package.
2984 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * distutilsSwigCPlusPlus.py work around some swig portability
2988 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2990 was done in a last ditch attempt to get setup.py _really_
2991 operationnal. The python/gdcmPython layaout add the advantage
2992 of hidding away the python related distutils specific files
2993 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2994 Alas, the src directory was out of scope (i.e. it's relative
2995 position to setup.py was ../src) which made things impossible to
2996 handle (see previous version of python/setup.py). Crossing fingers...
2998 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * python/setup.py now works on Un*x. (harder than I thougth)
3000 * python/distutilsSwigCPlusPlus.py can now have include files
3001 among the list of sources.
3003 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3004 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3005 * modifications in MSVC projects
3007 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3008 * As stated by the first lines of Test/ExceptionAndPython/README, it
3009 looks like we can move back to original usage of exception within
3010 src/gdcm* and hence remove the errno stuff that was introduced
3011 as a quick and dirty fixture of this problem (added to the TODO).
3012 * Doc/Doxyfile configuration file for Doxygen and corresponding
3013 README file for usage added.
3014 * Test/testWrite.cxx added. This new test comes from a split of
3015 test.cxx that is now reverted to its original purpous i.e.
3016 testing the proper parsing of a Dicom related file.
3017 testWrite.cxx concentrates on testing the IO part of gdcm.
3018 * Test/bug1.cxx (containing a bug on WIn32) added.
3019 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3020 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3021 whose purpose is to publish the content of the TagNames of the
3022 Dicom public dictionary were not accessible without an
3023 instance of class gdcmHeader.
3024 - those methods are now static methods of gdcmDictSet and hence
3025 require no instances at all to be invocated.
3026 - within gdcmDictSet this change required to change some method
3027 to class methods (i.e. are now static) among which SetDictPath
3028 (renamed to BuildDictPath) and LoadDefaultPubDict.
3029 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3030 the above changes by calling the new method classes of gdcmDictSet.
3031 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3032 the above to be effective.
3033 * python/gdcmPython: in order to wrap properly the above changes
3034 for Python, swig version now needs to be > 1.3.17.
3035 * python/gdcmPython/Makefile fixed to adapt itself to new
3036 configure/make shema introduced by Johan Montagnat (thanks for the
3037 contribution). Alas this Makefile cannot be turned into a proper
3038 Makefile.am without some heavy changes in the configure.in
3039 (for python dectection).
3040 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3041 now avoids publishing the empty entries.
3043 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3044 * python/setup.py : bug fix concerning install under windows
3045 ExtraPath reused :-P
3046 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3048 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3049 * Dicts/dicomV3.dic : remove double spaces !!!
3050 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3051 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3054 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3056 method. Doxygenation.
3057 * src/gdcm.h clean up of JPR spurious comments.
3059 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3060 * python/distutilsSwigCPlusPlus.py now properly collects the
3061 shadow classes generated by "swig -c++" (gdcm.py in our case)
3062 when using "python setup.py install".
3063 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3064 reexports the working classes.
3065 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3066 by the classical C errno scheme. This is to prevent an obscure
3067 behavior of the python wrappers when importing wxPython.wx prior
3068 to gdcmPython (which ended up in an abort call). An illustration
3069 of this oddity can be found in the Test/ExceptionAndPython
3070 subdir (see the README file). This problem probably due to
3071 an combination of g++ and dynamic loading.
3072 * added Test/ExceptionAndPython (see above)
3074 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * Changed the layout of the python part to avoid bloating main
3076 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3077 i.e. the distutils arsenal. All the python related stuff is
3078 again in a python subdir, but the package itself is now in
3080 * setup.py was cleaned up:
3081 - pythonIncludePath removed
3082 - python setup.py bdist target is now functional.
3083 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3084 collision with other packages). gdcmPython/demo/*.py changed
3087 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * python subdir moved to gdcmPython (preparation of distutils packaging).
3089 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3090 distutils installer is operational.
3091 * - gdcmPython/__init__.py now properly loads the swig generated
3092 shadow classes (from gdcm.py).
3093 - gdcmPython/demo/*.py changed to import the package gdcmPython
3094 instead of gdcmPython/demo/load.py.
3095 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3097 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3099 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3100 entries within the associated public Dicom dictionary resp. the same
3101 information but sorted by the fourth field (PAT, IMG, DIR) of the
3103 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3104 are now in the "???" group.
3105 - python/gdcm.i changed accordingly,
3106 - python/demo/printGroupedPublicDict.py added, that gives an example
3107 of the above new functionalities in Python.
3109 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3110 * src/gdcm.h, gdcmHeader.cxx:
3111 - historic references to glib's g_malloc and g_free (#defined)
3112 were definitively removed.
3113 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3114 * src/gdcmElValSet.cxx:
3115 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3116 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3117 - GetElValue(string) renamed to GetElValueByName.
3118 - Added GetElementByName(string).
3119 * src/gdcmHeader.cxx: added
3120 - GetPubElValRepByNumber(guint16, guint16)
3121 - GetPubElValRepByName(string)
3122 - GetShaElValRepByNumber(guint16, guint16)
3123 - GetShaElValRepByName(string)
3124 - GetShaElValByNumber(guint16, guint16)
3125 - GetShaElValRepByName(string)
3126 - GetElValRepByNumber(guint16, guint16)
3127 - GetElValRepByName(string)
3128 - GetElValByNumber(guint16, guint16)
3129 - GetElValRepByName(string)
3130 * Doc/requirements.txt added.
3132 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * Test/Makefile building now depends on the one of libgdcm.so
3134 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3135 pixel data) aware which enables finding the address (offset) of
3136 the pixel data of JPEG encoded DICOM files. This leaves only a single
3137 file in the testSuite whose pixel data address (offset) is unknown.
3138 * python/testSuite.py changed accordingly.
3140 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3141 * VC++ has some strong limitations when working with the STL, as stated
3142 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3143 "Also note that some STL containers (map, set, queue, list, deque)
3144 cannot be exported. [...]
3145 Some STL classes contain nested classes. These classes can not
3147 This is caused by a designed limitation that once a template
3148 class is instantiated, it can not be re-instantiated and
3150 Since our usage of map<> is ubiquitous in gdcm, this "designed
3151 limitation" of VC++ is a pitfall.
3152 Hence the Python wrappers of gdcm cannot be incrementally linked
3153 against the c++ dynamic library. The dirty but only workaround is
3154 to forget about incremental link of dynamic libraries and to generate
3155 the Python wrappers library with the inclusions of the underlying C++
3157 The following modifications concern this matter on Win32/VC++:
3158 - wrapping python correct with standalone wrapped dll (don't use separate
3159 dll under windows !!!!)
3160 - python21_d debug mode enabled (ask Frog how to use it :-)
3161 - NO problem with having an STL member of class for example string in C++
3162 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3163 - Python test of dcmlib in Python is ok under windows on a large set
3165 * removed glib references
3166 * typedef's inserted in gdcm.i for correct swig type management
3168 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3169 * python/demo/*.py load.py extracted from test.py. Added explore.py
3170 that only displays required tags and testAll.py that parses all
3171 the files of the testsuite without using unittest.
3172 * python/testSuite.py other additional test on new files added.
3173 * Data/* new test files added accordingly to the testSuite.
3174 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3175 the vr in the file differs from the one of the dictionary.
3177 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3178 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3179 values, but limits itself to values which are below a user specified
3180 size (by default 1024 bytes).
3181 * python/gdcm.i : elements not loaded (because their size is above the
3182 user specified treshold) are exported with their TagKey as key of the
3183 python dictionary. This enables the testsuite to make some checks
3184 on the unloaded elements (since we have their offset and size).
3185 * python/testSuite.py
3186 - now tests for the existence and proper value of the pixel data
3187 - two new examples added.
3188 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3190 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3191 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3192 aware. See the strategy comments in gdcmHeader::FindeLength().
3193 * Test/test.cxx now accepts a filename as first argument.
3194 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3195 * python/testSuite.py changed to integrate test on above files.
3197 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3199 the vr was also RET.
3200 * python/testSuite.py more tests added.
3202 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3203 * python/testSuite.py unittest test suite added (uses Data)
3204 * Data/* dcm and acr files for the test suite.
3205 * glib dependance removed from un*x version. We now use ISO C99
3206 7.18 Integer types (see stdint.h)
3207 - python/Makefile, src/Makefile src/gdcm.h
3208 * src/ when an explicit vr (like dicom files) suddenly poped an
3209 implicit element we use to mark the underlying DictEntry of the
3210 concerned ElValue with "Implicit". This strategy was damageable
3211 too the public or provite dictionaries, since some of their vr
3212 would be changed. Since Header::FindLength heavily relies on the
3213 detection by Header::FindVR of falsely explicit elements, I
3214 added an extra ImplicitVr member to ElValue (boolean).
3215 The rest of the changes we the necessary adaptations.
3217 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3220 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3222 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3223 * Adaptation for porting to VC++:
3225 o forced to use std namespace (for string to be known)
3226 o all class use __declspec export style on WIN32
3227 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3228 (in stdlib.h on Win32 but in std:: for gcc)
3229 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3230 variable GDCM_DICT_PATH.
3231 * src/gdcmHeader.cxx verbose comments made discrete.
3233 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3234 * python/gdcm.i: added a typemap that converts a C++ hashing table
3235 to native Python dictionary.
3236 * python/demo/test.py:
3237 - now uses the native dictionary for exploration of gdcmHeader.
3238 - takes an optional filename argument (the file to parse).
3239 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3240 PubElVals hashing table.
3241 * Dicts/dicomV3.dic removed error prone trailing spaces.
3243 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3244 * Python wrapping process moved away from src/Makefile to
3245 newly created python/Makefile (as well as gdcm.i)
3246 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3247 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3248 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3249 from the environement variable GDCM_DICT_PATH (when existing).
3250 * src/gdcmDict::GetTag bug fix.
3252 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3253 * Straightforward temporary fixes for swig to build the python wrappers.
3254 src/Makefile now has a python working entry [by working we mean
3255 that we can import de shadow classes without errors].
3257 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3258 * hashtest.cxx removed (since already in Test)
3259 * src/gdcmlib.h renamed to src/gdcm.h
3260 * src/dcm.i renamed to src/gdcm.i
3261 * src/Makefile prepared for python wrapping
3263 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3264 * src/gdcmHeader.cxx :
3265 - Parsing of header is now separated from loading of element values
3266 (see gdcmHeader::LoadElements).
3267 - general clean up of hopefully all file access (creation of
3268 ReadInt16 and ReadInt32)
3270 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * src/gdcmHeader.cxx :
3272 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3274 - SetLgrElem renamed to SetLength
3275 - GetLgrElem renamed to GetLength
3276 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3277 * src/gdcmElValSet.cxx fixed both GetElValue methods
3278 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3279 due to IdoDude was cleaned out.
3281 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3282 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3283 concentrates on finding the value representation (when it exists).
3284 RecupLgr now only finds the element value length, and it avoids
3285 returning the unecessary skL (skipped length).
3286 Also, offsetCourant was simply removed (with taille_fich) since
3287 it was redundant with the File position internals (by using
3288 ftell and fseek). This also made skL (see above in RecupLgr) usage
3290 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3291 on the libido specificities which are handled through class
3293 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3296 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * Truckload of changes. Parsing of header is barely functional
3298 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3300 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3301 * src/gdcmHeader.cxx many addons of low level methods
3303 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3305 and _IdDcmSWAP_LONG.
3307 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * This corresponds to all the changes decided at the meeting of
3309 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob