1 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/VTKTest*.cxx : remove the show variable in each test method because
3 it's useless (the viewer variable replace this variable)
5 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDocument.cxx : bug fix on potential memory leak
7 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
8 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
9 Add ClearXxx methods to remove all the content of the list or map
10 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
12 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Grealty simplify the JPEg decompression, no need to differenciate based on
14 the JPEG possible type (with/without fragment, with/without multiple frame).
15 Everything is done throught the JPEG IO Suspension mechanism in IJG
17 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
19 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
20 with other method names
21 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
22 * Test/TestDicomDirElement.cxx : add new test
24 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
25 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
26 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
27 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
28 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
29 So can't you use __int64 in ostream at all.
31 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * bug fix for compilation on MSVC6
33 * gdcmPython/gdcm.i : rename of classes missed
35 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
37 type and not a string. So, there remove problems on the format of the
40 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
42 Thus, DicomDirXXX are created with a flad that indicates if the created
43 object is empty or not (when not empty, the DicomDirElement is used to
46 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
48 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
50 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
53 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
55 Remove all access to the hash-tables or lists in the objects.
57 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
59 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
60 be complient with all the gdcm source code
62 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
66 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
70 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * Test/ : rename VTK tests to have a best name for the tests
72 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
73 GetFirstEntry/GetNextEntry use
75 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
77 test. Now it's on image content and not on the resulting visualisation...
78 might solve the problem on linux when using the OpenGL drivers
80 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
81 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
82 DicomDirSerie, DicomDirImage
83 Dict, DictSet classes :
84 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
85 -remove InitTraversal method.
86 * UPD Test programs + Example programs
88 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
89 remove useless and never updated keyword \ingroup
91 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
93 is no memory access violation
94 * gdcmPython/demo : add python demos using VTK
96 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
97 * FIX 'Dictionnary' is now spelt 'Dictionary'
98 'wether' is now spelt 'whether'
99 'archieve' is now spelt 'archive' ;-)
101 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
102 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
103 related methods, in order not to expose internal mechanisms
106 * REM methods that exposed internal mechanisms :
107 DicomDir::GetDicomDirPatients()
108 DicomDirPatient::GetDicomDirStudies()
109 DicomDirStudy::GetDicomDirSeries()
110 DicomDirSerie::GetDicomDirImages()
111 * UPD Test programs :
115 * UPD Example program
117 * ADD DictSet methods
121 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Removed the Print/indent/default parameter mess. There is absolutely no
123 reason to have to methods, moreover with the second taking the ostream as
124 *SECOND* parameter. This was clearly a bad hack to get things compile.
126 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
127 * Complete rewrite of the GetMacAddress code. Now the code is *much*
128 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
129 Unfortunately the main code does not work on SunOS, thus provide a specific
130 code for this platform only (and Win32 of course). Since this seems to be
131 working, change CreateUniqueUID to use GetMACAddress instead of the
132 problematic GctestetIPAddress
134 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
135 * Unfortunately to be able to test gdcmDirList I had to break the API
136 a little. Now the class is not a std::list anymore but has a member
137 std::vector (more ITK compatible). Allow unit testing on Win32 and
140 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Update SerieHeader to take into account a Serie Instance UID to properly
144 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
145 * ENH - Comment out Mathieu's (dangerous) Super Hack
146 for dealing with BIGENDIAN processors
147 - Move equivalent stuff to BinEntry::WriteContent
148 When necessary, 16 Bits Pixels are swapped in a small buffer
149 and then written. This avoid allocating a huge buffer, in
150 PixelWriteConvertor, and avoid modifying the Pixel Area.
152 Probabely, the same operation will have to be done when we want
153 to write image with Big Endian Transfert Syntax,
154 and we are working on Little Endian Processor
156 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
159 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
160 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
161 all the dict content.
162 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
164 * Test/TestDict.cxx : add a new test for the dict classes
166 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
168 file. Debug is yanked if compiled with NDEBUG
170 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/gdcmDictSet.h : set the default output to the os variable
172 * src/gdcmDictEntry.[h|cxx] : add the Print method
173 * gdcmPython/demo/ : add a new test
175 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
176 * merging of Test/PrintDicomDir and Test/TestDicomDir
177 * removal of now redundant Test/PrintDicomDir
178 * enhancement of Example/PrintDicomDir
180 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * Now, python test might work on systems
182 * Add the PrintDicomDir test
184 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
185 * FIX : First entry following group 0002 was lost for
186 Explicit Big Endian Transfer Syntax files
187 (group and elem not swaped)
189 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
190 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
191 Big Endian Transfer Syntax supposed the group following 0002
192 begins always by element 0000 (element 0000 is *optional*)
193 To avoid further troubles, let's be pessimistic, and use
194 Document::HandleOutOfGroup0002() method
195 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
196 (related pb not yet solved)
198 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * Bug fix for the python part use
200 * Now, PrintHeader.py pass... but outside the ctest use. shit !
202 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
205 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
206 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
207 a string and should ask the global TS dict what are the propreties of
210 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
211 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
212 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
213 to swap the Swap Code, at parsing time, when we come out of group 0002
214 and Transfer Syntax is Big Endian
215 We should be able to read now 'true DICOM" Big Endian coded images
216 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
217 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
219 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
220 * Hopefully fix the bug on MacOSX and static global initialization.
221 This is the only -minor- patch I found that both please MacOSX and VS6.
222 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
223 but this would require a lot of change. Another approach would be that Global
224 create those string and GDCM_UNFOUND becomes a pointer to a string (which
225 gdcm::Global would destroy at exit).
227 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Fix bug on MacOSX with static initialization in a multy threaded
229 environment. static const string in a header file used to be ill
230 initialized provoquing the freeze of any tests. patch should solve this
233 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
234 * According to Benoit's suggestion, and without any objection from anybody
235 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
236 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
237 - method gdcmDicomDirObject::GetEntry() renamed as
238 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
240 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
242 you debug/warning message just as c++ streams which make them very convinient
243 to use. Once this is stabilize I will change the ostringstrem to be
244 redirected to a file (ofstream).
245 * Properly support C99 extension: __FUNCTION__ which allow us to display
246 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
248 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
249 * Removal of useless and dangerous methods :
250 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
251 GetDocEntryByName, GetEntryByName, GetDictEntryByName
252 * Removal of usless methods :
253 Dict::PrintByName, Dict::GetDictEntryByName
254 * Commenting out of probabely useless methods :
255 Dict::GetDictEntryNames()
256 Dict::GetDictEntryNamesByCategory()
257 DictSet::GetPubDictEntryNames()
258 DictSet::GetPubDictEntryNamesByCategory()
259 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
260 * ENH : Use dicomTS.dic as described in 2004 version
261 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
262 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
263 Add Accessors on VM (Value Multiplicity), and VM related methods
264 * ADD : Add a list of 'Dicom Attribute types', as found in
265 http://medical.nema.org/dicom/2004/04_15PU.PDF
267 * ADD : Add dicomGroupNameAbbreviations.dic
268 should be used to write a method to replace the former
269 Dict::GetDictEntryNamesByCategory()
271 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
273 to read in the file... and only it ! Length is the efective length of the
274 data in the DocEntry structure
276 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
278 And now use a static function call instead, with a global variable. i
279 This is much closer to the VTK approach. Hopefully should be bulletproof
280 and easier to use...hopefully
282 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
283 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
285 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
288 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
290 ValEntry, BinEntry, SeqEntry creation or replace
292 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
294 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
296 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
297 when specifying the VR
298 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
299 * src/gdcmDocEntry.cxx : amelioration of print
301 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
302 * ADD : Add the method Util::IsCurrentProcessorBigEndian
303 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
304 * ADD Method Document::ComputeGroupLength
305 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
306 in order to allow further VR modification by user
307 * REM : removal of once-called method File::WriteBase
308 integration of its code in formerly one-line method File::Write
310 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
312 replace the different values "??", "Unkn", "Unknown".
313 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
314 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
315 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
316 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
318 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
321 * Set the gdcm::Base class to some Printable classes
323 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmFile.[h|cxx] : add the Print method
325 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
326 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
327 * src/gdcmDocument.h : remove the PrintLevel informations
328 * Example/PrintFile.cxx : use the new gdcm::File::Print
330 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
332 problems when compiling with the python wrapping
334 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
336 writting in ImplicitVR
338 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
339 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
340 JPEG decompression, especially when dicom frames are split into several
341 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
342 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
344 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmHeader.cxx : change the initialisation of default header.
346 Now, this header is readable by gdm, e-film, DicomWorks
348 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
350 Rename Decompressed to Raw
351 * Use the API changes in gdcm::File.
352 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
355 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
357 each added entry in the header. Replace the 'Planes' field by the 'Number
360 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
362 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
364 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
366 At this time, this image isn't readable by e-film... waiting JPR help to
369 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
371 DocEntry. Now use methods of the Document !
373 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * Test/ShowDicomSeq.cxx : bug fix
376 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
378 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
379 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
380 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
382 * Test/TestCopyRescaleDicom.cxx : remove unused variable
383 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
384 containing found sequences
386 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
389 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
390 Some fields in BinEntry must be copied to not seg fault when making the :
391 gdcm::File *copy = new gdcm::File( copyH );
392 and tests are now made on good variables
394 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
396 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
398 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
399 * Add vtkGdcmWriter example and test
401 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * Test/TestUtil.cxx : reformat the source code
403 * vtk/vtkGdcmReader.cxx : remove and change prints
404 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
406 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
407 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
409 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
411 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
413 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
415 by an eof to prevent all bad read of the file... and in this case, the
418 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * Example/Volume2Dicom.cxx : comment unused variables
420 * Test/PrintDicomDir.cxx : comment unused variables
421 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
422 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
423 method that is redondant with AddEntry.
424 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
427 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
428 * Bug fix due my last commit (compilation under Windows).
429 * Example/Volume2Dicom : bug fix in the file and reformatting source code
430 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
432 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 - Remove printf / sprintf
435 - include iostream AFTER gdcm so we don't get warnings
436 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
438 - Also remove tons of include from header files, hopefully this should
439 speeup the compilation time, since it was becoming a dog slow.
440 - Remove gdcm.h as it include way too many files and slow down compilation
441 (plus it is not up to date)
442 - remove 'using namespace std' this is BAD !
444 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * Remove memory leaks on the DicomDir
446 * Remove some useless data in DicomDirObject
447 * Add usefull methods in SQItem, to be complient withe the ElementSet
449 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
450 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
452 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
454 future, with convertion)
455 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
456 and ImageDataSize values. Remove the method to get the PixelReadConverter
457 from the output of the class
459 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
462 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
464 and vtkErrorMacro use.
465 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
467 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
470 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
471 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
472 The string leaves only in the fonction. So when we make a .c_str(), we
473 get the pointeur on the first element, element that will be destroyed
474 immediately after thee instruction.
475 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
476 file has been opened : the test must be made on the content of the
477 pointer and not directly on the pointer !
480 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
482 the python part recompiles
484 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
485 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
486 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
487 X session is killed (for my computer... it seems to not be identic on
490 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
492 avoid problems (otherwise, the difference test between the visible image
493 and the reference is incorrect. If the reference is greater than the
494 screen resolution, it's produce errors).
495 Can be used for only one image. Can be used with a visible flag.
496 * vtk/vtkGdcmReader.cxx : remove commented codes.
497 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
498 under windows at compilation
499 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
501 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
503 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
505 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
506 tests on the image size X, Y, Z
508 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
510 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
511 between the class name and the file name
513 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/ : fix compilation warnings for the Write method (2 different
515 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
516 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
517 variable... create a static method in gdcm::Document to access to
518 this variable content.
520 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
522 file, to be accessed by other files (like gdcmFile). Remove commented
523 code. Move the change of the header to the gdcmFile, using the
525 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
526 To be sure of that (and simplify calls), the Write of the header now
527 gets a file name and not a file pointer (std::ifstream).
528 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
529 DocEntryArchive. Remove all open of the written file
531 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
534 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
536 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
538 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
539 some corresponding methods. Write correctly the file and check before
541 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
542 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
543 is now on RGB data (as before my last commit
544 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
546 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
548 Add a print information of the type of the entry
549 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
550 It was in the gdcmFile, and all write have been regrouped
551 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
552 Write correctly all dicom files (in decompressed mode only at this time)
553 * Test/ : test on files are now made using Raw data and not color data if
555 * Example/PrintFile.cxx : add more printings
557 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * Amelioration of code, remove some code copy. For the loading of
559 BinEntry (in gdcmDocument), add the test to verify if the file is already
562 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
564 remove a DocEntry in the header (push an empty DocEntry)
565 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
566 lines. Bug fix in the initialization of the PixelConvert and the
568 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
569 use in TestCopyDicom (now this test can run under windows... but fails)
570 * Test/TestCopyDicom.cxx : amelioration of the test :
571 - test the pixels written
572 - add test points to quickly find where is the error
573 - can set a file name input and output in arguments
574 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
575 amelioration of the test output
577 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
579 all replaced DocEntry's
580 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
581 Now, each needed DocEntry to modify is duplicated, modified and inserted
582 to the header using DocEntryArchive. Thus, after save, we can restore the
583 header initial state.
585 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
588 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
590 correct to copy it. The DictEntry is specified at the DocEntry creation,
591 then, it musn't change in the time.
592 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
593 header correctly. At this time, the change is only made for the first
594 level of the Document. In the future, it might consider sequences.
595 The change is made by replacing a DocEntry by an other that is created
596 outside the class. The old value is kept. When we restore the header
597 status, the added DocEntry is deleted and replaced by the old value.
598 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
599 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
600 set the write type to explicit VR, implicit VR or ACR. Add methods to set
601 the write mode to native, decompressed or RGB (but not used at this time)
603 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
605 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
607 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
609 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
611 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
612 set because already copied when copying the BinEntry's of the header
613 * Test/TestAllReadCompareDicom.cxx : remove warnings
615 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
617 Two problems appear when doing it :
618 - with the gdcmFile : when the GetImageData method is called, the pixels
619 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
620 data (pixels). And each structure destruct the data when it's
621 destructed. So we have two destructions for the same data. To solve it,
622 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
623 data or not. If it doesn't own data, then they will not destroyed by
625 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
626 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
627 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
628 create a double destruction of the same DocEntry's. So, to solve it,
629 the TagHT is simply cleared and the DicomDir* elements are destroyed.
630 * TODO : add an entry concerning memory leaks in the DicomDir
632 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
634 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
637 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
639 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
640 after it have been deleted
642 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * FIX: src/* fix the doxygen warnings.
644 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
645 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
646 was erroneously defined with a size of 15 instead of 16. [many thanks
647 to Jean Michel Rouet for pointing out this bug].
649 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
650 1. Finish merging JMR patch for writting DICOM from scratch
651 2. Fix -hopefully- bug with MONOCHROME and space vs null character
652 3. Use const ref when possible
653 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
654 5. A few more comments
655 6. CreateUniqueUID can now be called without parameter"
657 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
658 * ENH: Slightly bigger patch:
659 1. Getting toward full integration of JMR patch for writting dicom from scratch
660 2. Update Test to test part of this patch: CreateUniqueUID
661 3. File was not close properly in gdcmDict
662 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
663 5. Use of const ref instead of copy (speed issue)
664 6. Remove temporary (duplicate) string in TranslateToKey
665 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
666 8. Do not repeat virtual in subclasses
667 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
669 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
670 * Apply first patch toward better string comparison when dealing with broken
671 DICOM files. Essentially the string could be padded with a space instead
672 of a null character as defined by standard
674 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
676 because never used... and in the same time, that's remove some memory leaks
678 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * src/gdcmFile.cxx : now delete the PixelConvert instance.
680 * In examples and tests : change the type of image data variables from void*
681 to uint8_t*. Remmove all delete on image data variables
683 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
685 Verify the file pointer value before open the file, and if it's not null,
686 a verbose message is generated.
687 Close correctly the file when the file isn't considered dicom-like. The
688 correctly close is a call to CloseFile.
689 When closing the file pointer, test if its not null to close the file.
690 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
691 file. For an uncompressed image, the copied data correspond in the least
692 case to the image size (calculated) or the image size specified in the
693 header. A verbose is generated if these two size mismatch
695 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
697 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
698 break under windows (with msvc6 compilation).
700 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
702 compiling with MSVC6)
704 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * Bugs fix for the Windows build with VC6
706 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
707 needed (only for projects required VTK). If the VTK is included in all
708 projects, there is conflicts with the jpeg lib of vtk when compiling the
709 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
710 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
711 when compiling the gdcm_wrap.cxx file (created by the compilation of the
713 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
714 (like it's already made for the cout use). Otherwise, conflict with the
717 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
720 - comments on the DicomDir::Method related usage added.
721 - now that we use the namespace gdcm, a lot of internal classes do
722 NOT need to be wrapped anymore.
723 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
724 DicomDir::Method) new example added.
726 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 * Improve string manipulation. I now inforce the notion of 'DicomString'
728 A DicomString can contain as many \0 as they want
729 and it is *always* of even length.
730 We only support odd length for very rare case.
731 And in the near future this should be removed.
733 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * /binary_write/ gdcm source. Now even on big endian we are writting
735 little endian. This should -heopfully- fix some tests
737 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
738 * Now the dictionary is compiled into gdcm lib. This is a default
739 behavior, thus any dic file specified is picked before failback to
740 the one comiled into lib
742 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
743 * Change internals for gdcmDict. Don't use any 'new' any more.
744 This should definitely solve any leak problem, and we should be
745 as fast as before, as long as don't modify too much the dictionary.
747 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
748 * STYLE: ivars should start with a capital letter.
749 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
750 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
752 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
753 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
754 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
755 new 2004 dictionaries added (thanks to JPR).
756 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
757 * CLEANUP_ROUND (15) for gdcmPixelConvert
758 - RLEFrame::NumberFragments is now of type unsigned int
759 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
760 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
763 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
764 * Initial work in gathering all transfer syntax accessors. clearly
765 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
766 ivars, but only one transfersyntax (class) ivar with equivalent method on
769 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
770 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
771 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
772 discussed (plus I didn't like having a 2000 lines patch not commited)
774 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
776 * CLEANUP_ROUND (14) for gdcmPixelConvert
777 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
778 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
779 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
781 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
782 anymore and hence avoids storing a copy of PixelConvert::Decompressed
783 into File::Pixel_Data.
785 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
787 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
788 * CLEANUP_ROUND (13) for gdcmPixelConvert
789 Substituted File::ParsePixelData() with PixelConvert::Print() new
791 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
792 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
793 method to those classes.
794 - src/gdcmFile.[cxx|h]:
795 -- Added a ::Print() method.
796 -- PixelConverter is now a reference instead of a member.
797 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
798 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
800 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
802 collaboration diagram and inheritance diagram should be generated with
804 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
805 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
806 pointlessly wrapped (see
807 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
808 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
809 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
810 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
811 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
812 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
813 -- File::Initialise: PixelConverter setup moved away to
814 PixelConverter::GrabInformationsFromHeader()
815 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
816 interpretation moved away to PixelConverter::BuildRGBImage()
818 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
819 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
820 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
822 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
824 displayed on Win32 when a brutal abort() occurs (because of uncatched
825 exception). See TODO new entry of this commit for more on this.
826 * TODO added new entry.
827 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
828 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
829 - HandleColor is no longer called from gdcmFile.cxx
830 - gdcmPixelConvert.cxx clean up on method arguments and internal
831 variable names for semantical coherence.
833 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 * Finished lossless transition, not only do we now read all lossless jpeg
835 images, without the need of the Cornwell lib, but we do read them properly now
836 * To reduce code (well to avoid code duplication), I defined a common place
837 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
838 redefine symbols. This is not perfect but this the best solution I found for a
839 compilation time jpeg option.
841 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * Update jpeg ijg lib to support lossless jpeg implementation
843 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
845 * Also added a special copyright for dcmtk since we use their bugfixes.
848 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
850 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
851 matters, as stated in warning note at begining of %include section).
852 * src/gdcmDicomDir*.[cxx|h]: coding style
853 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
854 * src/gdcmJpeg8.cxx: doxygen fix.
855 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
856 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
857 from File:: to PixelConvert::.
859 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
861 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
862 - more code moved away from File:: to PixelConvert::
863 - fat setup of PixelConverter set in place in File::Initialise.
865 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
866 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
867 namespace at the file system level. So now you should convert your examples
869 gdcmHeader -> gdcm::Header
870 It would be nice if people keep in mind to no open the namespace, since it
871 allows compilation on broken plateform which were defining common symbol in
872 the standart namespace (like LP, Unknown ...)
874 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
876 The JPEG fragments are now parsed at the same stage than the RLE
877 information. All code related to JPEG is now in gdcmPixelConvert:
878 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
879 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
880 export a gdcmFile:: method. Those are simply global functions
881 (for the time being this is better than having them attach to
882 either gdcmFile:: or gdcmPixelConvert::).
883 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
884 and stores the result in a gdcmJPEGFragmentsInfo.
885 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
886 code (among other stuff) moved away from gdcmFile:; to
889 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
890 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
891 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
892 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
893 clean up of RLE related code.
894 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
895 - src/gdcmRLE.cxx removed
896 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
897 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
898 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
899 * CLEANUP_ROUND (9) for gdcmPixelConvert
900 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
901 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
902 away from gdcmFile:: to gdcmPixelConvert::.
904 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
906 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
907 This is because Parse7Fe0 used to parse the pixels to compute the
908 length. This task was passed over to FindDocEntryLengthOB() a long
909 time ago, EXCEPT I had forgotten the OW case...
910 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
911 we just recylce the code for parsing RLE fragments and computing
913 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
914 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
915 with the retired Parse7Fe0().
916 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
917 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
919 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
921 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
922 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
923 - src/CMakeLists.txt: alphabetic order reodering + new entries.
924 * CLEANUP_ROUND (4) for gdcmPixelConvert
925 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
926 to return an unused length.
928 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
930 this should be cleanner from the plane view. The iostream are erally a pain
931 to use to do simple stuff.
933 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * Redo the compilation of the ijg jpeg library. Now only one source is
935 necesseray. No need to rename file by hand what so ever. CMake handle the
936 copying of the file within different directory, configure header file to
937 modify some symbol. The only addition made to ijg wasd a mangle table so
938 that symbol are different whether we are within 8bits or 12bits.
940 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * Added documentation of vtkgdcmReader on Website:
942 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
943 with it's binary name).
944 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
945 the Website to be more complete.
946 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
947 doxygenated documentation.
948 - Doc/DoxyVtkGdcmReaderExamples.txt added
949 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
950 DoxyVtkGdmReaderExamples.html )
951 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
952 * CLEANUP_ROUND (3) for gdcmPixelConvert
953 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
955 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * CLEANUP_ROUND (2) for gdcmPixelConvert
957 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
959 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * CLEANUP_ROUND for gdcmPixelConvert:
961 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
962 - src/gdcmPixelStuff[h|cxx] removed
963 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
964 - src/CMakeLists.txt changed accordingly
966 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
967 gdcmVersion.py moved to newly created ATTIC related
968 gdcmPython/SetupOldies/ directory.
969 * Autotools clean up:
970 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
971 - autogen.sh configure.in acinclude.m4 python.m4 removed
973 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * src/*.cxx *.h Reference to License.htm fixed to License.html.
975 * Doc/CMakeLists.txt, doxygen.config.in: fix.
976 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
978 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
979 * TODO updated with Mathieu suggestions. I proposed a template for
980 describing TODO entries and used it for new entries.
981 * Added Doc/Website/CodingStyle.html, Developpers.html,
982 DeveloppersPython.html, GdcmDataCvs.html and
983 DownloadVersion0_1.html, DownloadVersion0_3.html.
984 * Some Doc/*.txt Doxygen files (which do not really concern the
985 documentation itself, but the website) moved to html and
986 placed in directory Doc/Website:
987 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
988 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
989 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
990 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
991 * CMakeLists.txt changed accordingly.
992 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
993 DeveloppersPython.html
994 * INSTALL nows refers to Doc/Website/Installation.html
996 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * Added Doc/Website directory, that contains a first raw version
1000 2004-09-23 Jean-Pierre Roux
1001 * FIX In order not to be poluted any longer by casting problems,
1002 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1003 we can now delete[] it safely
1004 * VoidArea is now called BinArea (less confusing name),
1005 and all the methods called ...VoidArea... are now ... BinArea...
1006 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1008 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1010 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1011 up to the destructor of gdcmElementSet to clean up TagHt and it's
1014 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1016 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1018 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * ENH: added some utility method that builds a flat dictionary
1020 holding all the Dicom entries contained in the recursive structure
1021 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1022 an example of usage.
1023 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1024 BuildFlatHashTable() that build a flat dictionary.
1025 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1026 gdcmDocument is now a friend of gdcmElementSet.
1027 - src/gdcmElementSet.cxx: clean up.
1028 - Example/FlatHashTablePrint.cxx added.
1029 - Example/CmakeLists.txt changed accordingly
1031 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1033 moved away from gdcmDocEntrySet (since this class is an abstract class
1034 acting like an interface). SQDepthLevel and BaseTagKey are now
1036 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1037 and associated accessors. Doxygenation of the class.
1038 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1040 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1041 Use SQDepthLevel accessor instead. ::Print() adapted.
1042 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1043 - src/gdcmDocument.cxx changed accordingly.
1045 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1046 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1047 - The following is the doxygen comment of the typedef declaration
1048 of gdcmTagKey in src/gdcmCommon.h:
1049 gdcmTagKey is made to old an "universal" (as in URL, Universal
1050 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1051 A dicom tag always has a group and an element, but a set of tags
1052 embeded in various (optionally nested) sequences and sharing
1053 the same group and element all share the same (group, element)
1054 "identifier". Hence the (group, element) cannot be used as an
1055 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1056 In order to construct a proper tag identifier (i.e. a key) we
1057 consider the following definition of a TagKey:
1058 - let Group, Element be the string representation of the
1059 group and element dicom tag members,
1060 - let ItemNumber be the string representation of the integer
1061 index of the considered item number of a sequence,
1062 Let the key of a tag embeded in a sequence, noted SeqTag, be
1064 /ItemNumber#Group|Element
1065 where "/", "#" and "|" are characters acting as separators.
1066 Then the general form of a gdcmTagKey is given by:
1067 Group|Element<SeqTag>
1068 where <SeqTag> means NO or many instances of SeqTag.
1069 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1072 but the gdcmTagKey of a tag "embeded" is the first item of
1073 a sequence, itself nested in the third item of a sequence is the
1075 0004|1220/2#0008|0082/0#0008|0090
1076 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1077 order to hold the new sequence compatible key. Previously, the
1078 GetKey() method would look in the underlying gdcmDictEntry.
1079 - src/gdcmDocEntry.cxx:
1080 -- constructor now copies the underlying DictEntry key, in the local
1082 -- ::Print: displays the member Key, instead of the (group, element).
1083 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1084 - src/gdcmDocEntrySet.h:xi
1085 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1086 -- now has a new BaseTagKey member.
1088 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1089 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1091 This poses the problem with the semantics of the following lines
1092 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1093 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1094 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1095 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1096 to the long FIXME note for what the problem is. Nevertheless in
1097 order to get things working the dicom dictionary was altered !
1098 Please fix things urgently...
1099 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1100 information), see above note on moving the member VoidArea. Nevertheless
1101 the following entries previously correctly set as US are now inproperly
1103 0028 1201 OW IMG Red Palette Color Lookup Table Data
1104 0028 1202 OW IMG Green Palette Color Lookup Table Data
1105 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1106 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1107 of gdcmDocEntry moved to gdcmSeqEntry.
1108 * src/gdcmSeqEntry.cxx: STYLE.
1110 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1113 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * gdcmPython/testSuite.py: all the test suite in python is now moved
1115 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1116 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1117 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1119 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1121 to avoid inclusion recursion until STL is reached.
1122 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1123 mecanism. errno.h is not included in gdcm anymore.
1124 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1125 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1127 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1128 gdcmData/TestAllEntryVerifyReference.txt
1129 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1130 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1131 exception_on_error parameter.
1132 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1133 - vtk/vtkGdcmReader.cxx changed accordingly,
1134 - Example/*.cxx and Test/*.cxx changed accordingly.
1136 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1138 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1139 enable_sequences removed from gdcmHeader constructor and dependencies.
1140 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1141 * gdcmPython/demo/PrintHeader.py: dummy fix.
1142 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1143 skip_shadow removed from gdcmHeader constructor and dependencies.
1144 * Example/*.cxx and Test/*.cxx changed accordingly.
1146 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1148 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1150 2004-07-21 Jean-Pierre Roux
1151 * FIX Now, Parsing and Printing a DICOMDIR do work!
1152 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1154 2004-07-20 Jean-Pierre Roux
1155 * FIX Some brain damaged headers have Zero-Lenght fields
1156 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1158 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1159 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1160 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1161 variable (instance of gdcmDebug) by a definition macro, and the instance
1162 is now in static in the gdcmDebug class
1163 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1164 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1166 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1167 * WARNING: ctest now depends more tightly on gdcmData. You should
1168 check out gdcmData properly for things to run smoothly...
1169 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1170 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1171 we need the pixels not be loaded in order to use the ValEntry
1172 that displays position and size).
1173 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1174 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1175 be deprecated. If you have any doubts about the advantages of a
1176 modern scripting language (read Python) versus grass root C++ (i.e.
1177 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1178 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1179 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1180 Anyhow, consider documenting the gdcmData images in
1181 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1183 * Test/CMakeLists.txt:
1184 - now uses TestAllEntryVerify.cxx
1185 - specific comments on oldACR00001.ima (now renamed in gdcmData
1186 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1187 gdcmData/TestAllEntryVerifyReference.txt
1190 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * src/*.[h|cxx] : typedef clean up
1192 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1193 - TagKey renamed to gdcmTagKey (for external usage)
1194 - VRKey renamed to gdcmVRKey (for external usage)
1195 - removal of typedef duplication.
1196 - Removed all unecessary inline keyword from class inline definitions.
1197 - Some method|function(void) declarations replaced with method|function().
1198 * src/jpeg/libijg12/jdhuff12.c:
1199 - printf polluting ctest removed.
1200 - TAB removal for comminting
1202 - TestAllReadCompareDicom.cxx: added a test that compares all the
1203 images in gdcmDataImages.h with corresponding images in
1204 gdcmData/BaselineDicom/. When baseline images are not present
1205 this test creates them.
1206 Note: we need to validate each reference image, but before that
1207 I'd like to rename them with a more explicit name...
1208 - CMakeLists.txt: changed accordingly.
1209 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1210 including each header needed).
1212 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1214 test suite to the Example directory. Are concerned:
1219 - TestWriteSimple.cxx
1220 * Test/CMakeLists.txt: added some comments on reasons for black listing
1221 image gdcmData/oldACR00001.ima
1223 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * Test/CmakeList.txt: removed the following from black list (to be coherent
1225 with removal from gdcmData):
1226 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1227 - gdcm-MR-PHILIPS-16.dcm
1229 Added the following because after last cvs update, they cause
1230 ctest -R TestReadWriteReadCompare
1232 - gdcm-MR-SIEMENS-16-1.acr
1234 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1235 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1236 new comments in this file) we temporarily (sigh) move to a weaker
1238 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1239 we don't need to black list the following images anymore:
1240 - 8BitsUncompressedColor.dcm
1242 - US-PAL-8-10x-echo.dcm
1243 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1244 fixes and the beautified code ;-)
1245 This fixes the bug introduced in version 1.42 (when beautifying)
1246 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1247 Note: ctest was blind to this bug (this means we need to still
1248 improve the test suite). The bug could be detected by using
1249 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1251 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1252 and by displaying the (garbage) produced file temp.XDCM...
1254 2004-06-29 Jean-Pierre Roux
1255 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1256 - replace by uggly but working old code :-(
1257 A lot of things should be OK again.
1258 It's really urgent to have a test suite that *tests*,
1259 to prevent Frog's beautifying sessions to break all the stuff
1260 (twice, withing a fortnigh ...)
1262 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1264 redundancy) to added Test/TestReadWriteReadCompare.cxx
1265 * Test/CmakeList.txt: because the compare test of
1266 Test/TestReadWriteReadCompare.cxx fails, the following images are
1267 black listed: - 8BitsUncompressedColor.dcm
1269 - US-PAL-8-10x-echo.dcm
1270 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1271 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1272 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1273 and ad-hoc kludge. This kludge is now removed, and on encountering
1274 such an image (OB field brain damaged) we set errno. Then in
1275 ::FindDocLength() we "fix" the length as being ALL what remains
1276 in the file (until EOF). We then proceed, hoping for the best...
1277 This fixes a SegFault in ShowDicom when trying to write such an
1279 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1280 (because TestWriteRead breaks on it, after a non conformal commit?).
1281 ctest now runs properly, except for MakeDicomDir (which was always
1282 broken) and the Python related stuff (still not fixed).
1284 2004-06-24 Jean-Pierre Roux
1285 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1286 FIX : Test/TestReadWrite now iterates on all the file names
1287 (instead of infinite loop)
1288 ENH : Test/TestWriteRead now iterates on all the file names
1290 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1291 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1293 2004-06-24 Jean-Pierre Roux
1294 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1295 when SamplesPerPixel =3
1296 - now Write is no longer confused by
1297 'BitsAllocated = 12" and 'BitsStored=12"
1298 - "UN" value representation Elements are now written correctly
1299 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1300 ENH : - now gdcmHeader has its own Write methods
1301 (in order to split the job that has not to be done
1304 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1306 loop on the same image until memory went out.
1307 Note: this means we still have gobs of memory loss in PrintDocument
1308 * src/gdcmDocument.cxx: fixes problem on parsing on file
1309 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1311 2004-06-24 Jean-Pierre Roux
1312 FIX : Write - All the Sequences and Sequence Item are now written
1313 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1314 is added a the end, when necessary.
1315 - A lot of brain-damaged images, that were read correctly are
1316 now written correctly
1317 - length compatible BinEntry are now loaded correctly
1318 (even for odd groups)
1319 Note : only Explicit Value Representation was checked.
1320 (question : is implicit VR really necessary for gdcm ?)
1322 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1323 * DEVELOPPER: added a proposition of coding style.
1324 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1327 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1329 Use the gdcmDocEntry::Print() and Write() instead.
1330 * src/gdcmDocument.cxx: bug fix.
1332 2004-06-22 Jean-Pierre Roux
1333 FIX : gdcmDocument.cxx
1334 - Now we do recognize the JpegLossLess format (there was a misstyping in
1335 code 'beautyfication' :-(
1336 - Now we automaticaticaly load the Luts, if any
1338 2004-06-22 Jean-Pierre Roux
1339 In order : to write Sequences, whatever their imbrication level,
1340 : to allow user to create his own Sequences
1341 a lot of modif where necessary (adding, moving, or virtualising methods)
1343 WARNING : save your own sources *before* cvs up !
1346 ADD virtual void Write(FILE *fp, FileType filetype);
1349 ADD virtual void Write(FILE *fp, FileType filetype);
1350 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1353 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1354 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1355 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1356 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1357 ADD std::string GetEntryByName(TagName name);
1358 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1360 std::string vr = "unkn",
1361 std::string fourth = "unkn",
1362 std::string name = "unkn");
1363 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1364 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1365 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1366 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1367 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1368 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1369 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1370 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1373 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1374 ADD virtual std::string GetEntryByName (TagName tagName);
1375 ADD virtual std::string GetEntryVRByName (TagName tagName);
1376 REM virtual bool Write(FILE *, FileType);
1377 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1378 FILE *_fp, FileType type);
1379 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1380 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1381 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1382 REM virtual std::string GetEntryByName (std::string tagName);
1383 REM virtual std::string GetEntryVRByName (std::string tagName);
1384 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1385 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1386 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1388 std::string vr = "unkn",
1389 std::string fourth = "unkn",
1390 std::string name = "unkn");
1391 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1392 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1393 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1394 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1397 ADD virtual void Write(FILE *fp, FileType filetype);
1400 ADD virtual void Write(FILE *fp,FileType filetype);
1403 ADD virtual void Write(FILE *fp, FileType filetype);
1404 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1405 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1406 REM std::string GetEntryByName(TagName name);
1409 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1411 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1413 The default constructor invoked by the line
1414 gdcmHeader *f1 = new gdcmHeader( header );
1415 was gdcmHeader::gdcmHeader(bool) instead of the expected
1416 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1417 Hence the parsing wasn't executed... See also below.
1418 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1419 as explicit constructor didn't do the trick to fix the above problem.
1420 Could anyone explain why ?
1421 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1422 properly calls gdcmValEntry::Print() (that was weed out from
1423 code related to gdcmBinEntry).
1425 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * In order to fix memory leaks:
1427 - Test/TestWriteSimple.cxx: added cleaning of free store through
1429 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1430 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1431 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1432 (through the call to ::AddDicomDirMeta()) or the destructor
1433 would crash when deleting uninitialized ::metaElems].
1434 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1435 - src/gdcmDocument.cxx:
1436 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1437 from dynamic stores.
1438 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1439 was causing memory leaks.
1440 - src/gdcmSQItem.cxx:
1441 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1442 cleanly handled with polymophism: sorry but my milage is low).
1443 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1444 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1445 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1446 This avoids SegFaulting.
1447 - src/gdcmSQItem.h: coding style.
1449 - Test/TestWriteSimple still severely sucks. The output image content
1450 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1451 damaged when displayed with vtkgdcmViewer.
1452 - on memory leaks: TestWriteSimple leaks really less (see entry
1453 of 2004-06-18 in Changelog file for the call to valgrind).
1454 - on segfaults: ctest now passes all the tests but one (no more
1456 * Erroneous leading white fix:
1457 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1458 white[s] (as opposed to from >> xxx, that removes it [them].
1459 - src/gdcmTS.cxx: ditto.
1460 - gdcmPython/testSuite.py: dirty related kludge removed.
1461 * src/*: remaining references to gdcmParser removed.
1462 * src/*[cxx|h]: added copy[way]left header.
1465 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * In order to fix writing of dicom files:
1467 - Test/TestWriteSimple.cxx: a simpler example of writing.
1468 - Test/CMakeLists.txt changed accordingly.
1469 - src/gdcmDocument.cxx:
1470 -- The destructor now recursilvely removes potential sequences.
1471 -- Bug fix in ::IsJPEG2000()
1472 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1473 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1475 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1476 to only declared) and build on top of
1477 ::GetDocEntryByNumber(guint16, guint16).
1478 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1479 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1480 for usage in destructor and treatement of promotion in
1481 ::ReplaceOrCreateByNumber().
1482 - src/gdcmSQItem.cxx: destructor should better handle his job.
1483 Test/TestWriteSimple now runs (or at least it DOES something).
1484 * We can now start hutting memory links. A good starting point is:
1485 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1486 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1487 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1489 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1490 * Valgrind note: after Mathieu Malaterre teached me how to read
1491 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1493 Using gcc, you can force the STL to use malloc and to free memory as
1494 soon as possible by globally disabling memory caching.
1495 With 3.2.2 and later, you should export the environment variable
1496 GLIBCPP_FORCE_NEW before running your program.
1497 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1498 simply vanish (it is still not clear to me, whether this means that
1499 STL std::string leaks or if valgrind believes it leaks...).
1500 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1501 running bin/gdcmTests makeDicomDir):
1502 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1503 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1505 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1506 SegFaulting (I drowned in DicomDir related code when trying to
1507 understand why the list is empty...).
1508 * src/gdcmDocument.h: first BSD license header try.
1509 * Doc/License.txt added.
1511 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * src/gdcmDocument.[h|cxx]:
1513 - Clean up of the Transfer related predicates. They are now all based
1514 on new method isGivenTransferSyntax, that (should) handle properly
1515 the padding problem.
1516 - general clean up, simplification, and coding style.
1517 - Specific clean up of Parse7FE0() (umproperly named actually).
1518 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1520 2004-06-14 Jean-Pierre Roux
1522 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1523 - fix the display of SQItem ordinal number
1524 - add the GetSQItemByOrdinalNumber method
1525 - remove some useless never written private methods
1527 2004-06-14 Jean-Pierre Roux
1529 - adding a constructor taking a gdcmDocEntry as an input param
1530 - ReplaceOrCreateByNumber now returns :
1531 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1532 a gdcmValEntry * if a string value is passed as a param
1534 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1535 according to the param type (no longer sets a gdcmDocEntry)
1536 - GetValEntryByNumber, GetBinEntryByNumber added
1537 - NewValEntryByNumber and NewBinEntryByNumber added
1539 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1541 - GetSQItemNumber and SetSQItemNumber added, to provide
1542 a (relative) Item identier inside a given Sequence
1543 \warning : some pb remaining around this number
1545 - AddEntry now takes the Item Number as a param
1547 - adding a constructor taking a gdcmDocEntry as an input param
1549 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1550 * Memory leak hunt with the following command:
1551 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1552 --show-reachable=yes gdcmTests PrintDocument
1553 It looks like many (all?) leaks are due to the STL (or a bad usage
1554 of the STL. The lines producing the leaks now have a comment with
1555 a "MEMORY LEAK" tag: you can retrieve them with
1556 grep "MEMORY LEAK" src/*
1557 Here are two typical examples which I can't help fixing:
1562 char * test = "babo";
1563 name = test; //// <--- valgrind detects 960 bytes lost in
1564 //// call to std::string::operator=(char const*)
1565 name.clear(); //// Doesn't help !
1573 std::cout << "Type a bunch of characters followed by RETURN: ";
1574 getline(std::cin, line); //// <--- valgrind dectects a loss
1575 //// of 1320 bytes in call to
1576 /// std::basic_istream<>& std::getline<>
1582 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * src/gdcmHeader.[cxx|h]:
1584 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1585 and related, moved away to gdcmDocument.
1586 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1587 the corresponding protected accessors of inherited class
1588 gdcmDocument, removed ! As a consequence gdcmFile had to be
1589 declared friend of class gdcmDocument (see below).
1590 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1591 - Clean up of undefined or unused methods.
1592 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1593 account the changes to gdcmHeader.h).
1594 * src/gdcmDocument.h:
1595 - gdcmFile is now a friend class (in order to take into account the
1596 changes to gdcmHeader.h).
1597 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1598 (see changes to gdcmHeader.h).
1599 - Accessors (reading on the form GetEntry*) are now public.
1600 - Clean up of undefined or unused methods.
1601 * src/gdcmDocument.cxx:
1602 - adaptation to changes to gdcmDocument.h
1603 - ::OpenFile now writes a verbose message when file cannot be opened.
1604 - some std::string properly set to VRKey
1605 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1606 references to gdcmDocument.
1607 * Test/TestFindTags.cxx: changed accordingly to above changes.
1608 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1609 cvs repository gdcmData.
1611 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1613 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1614 conflicts with gdcmValEntry::voidArea.
1615 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1616 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1617 Value representation between StringRepresentable and BinaryRepresentable.
1618 * src/gdcmDocument.cxx:
1619 - method ParseDES: proper indentation restored and usage of
1620 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1621 - method LoadDocEntry: the fingerprint left in the SetValue() of
1622 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1623 removed. Reverting to previous code segment with the proper
1624 dynamic_cast< gdcmValEntry* >.
1625 Note: this was (partially) breaking the python test suite
1626 (gdcmPython/testSuite.py) that made usage of the above
1627 fingerprint to check presence of "Pixel Data".
1628 * src/gdcmDocEntry.h: coding style.
1629 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1630 now taken into account.
1631 * gdcmPython/gdcm.i: adaptation to the new internal representation
1632 of gdcm (exit gdcmParser, hello gdcmDocument).
1633 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1635 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1636 anymore, but instead prints the loaded Python dictionary.
1637 * .... alas, the python testSuite is still broken.
1639 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1642 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1643 * src/gdcmUtil.h : export methods
1645 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1648 * Initial addition of automatic python testing
1649 * Initial addition of automatic image comparison
1651 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1652 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1653 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1655 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1656 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1657 * Test/ShowDicom.cxx : bug fix for msvc compilation
1658 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1660 2004-05-04 Jean-Pierre Roux
1661 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1662 new concepts (and new classes) :
1663 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1664 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1665 - Sequence Doc Entries (gdcmSeqEntries)
1666 a Sequence is composed of Items.
1667 Each item is a set of Doc Entries (this is recursive)
1668 The non uniqueness of the 'Dicom tag' is due to this recursivity
1669 (never taken into account)
1670 Our unability to add a new 'entry' in the header
1671 at the proper location (neither in the H-Table (map or multimap),
1672 nor in the Chained List is also due to this recursivity.
1673 Don't try, right now, to use/modify/compile these new sources :
1674 nothing is finished.
1675 We just commit all the stuff, 'as is', in order not to loose it.
1677 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1678 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1680 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1681 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1682 file prefix (SetFilePrefix)
1684 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * Add a new test: ShowDicom, for now this is just the c++ version of
1686 checkRead.sh, later it will be able to compare the image read against a
1688 * Replace the DEBUG on the stack with a global entry in cmake interface:
1689 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1691 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * Add an example subdir, with a real example on how to read + write a
1695 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1697 * Doc/CMakeLists.txt: the main page is now properly differentiated
1698 between the developper and user version.
1699 * Doc/doxygen.config.in: dropped search related obsolete flags
1700 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1702 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * DEVELOPPER: added some helpfull comments for compile/test/install
1706 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1708 src directory, now generated in the build dir.
1709 2. Tests as mentionned smarter
1711 4. Add a new method in gdcmDict that return the PubDict by name
1712 this is interesting for 3rd party lib like ITK,
1713 where we could set the institution name / patient name...
1715 * ENH: 1. Now the test suite is working for real
1716 2. All binaries are now output in the gdcm-bin directory
1717 (this was not true before)
1719 2004-04-28 Jean-Pierre Roux
1720 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1721 SeQuence indented printing of Dicom Header.
1722 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1723 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1724 Computation of SQDepthLevel is now part of gdcmHeader constructor
1725 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1726 tree-like structure of a Dicom Header.
1727 * FIX Test code cleaning
1729 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * ENH: Adding automatic testing
1731 1. Need a DartConfig.cmake to submit to public
1732 2. Add a test driver gdcmTest.cxx
1733 3. gdcmTestMain, an helper for the main test driver gdcmTest
1734 4. Files in Test don't have a main anymore, this becomes interesting
1735 when we add more and more tests, thus dsw don't have to load
1737 * ENH: Adding a GDCM_DATA_ROOT for testing
1738 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1739 one file instead of seven + some small cleanup
1741 2004-04-22 Jean-Pierre Roux
1742 * ENH Minor changes to the Print() methods.
1743 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1744 Header printing. Example given with :
1745 > PrintHeader fileName 2 new
1746 (SQ based tree-like structure still to be done for the Header ...)
1748 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1749 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1750 1. I have added some unsigned where needed
1751 2. Some function parameter not used -> (void)
1752 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1753 4. g++ don't like character '\' in comment
1754 5. #define jpeg_create_decompress jCreaDecompress
1755 this really need to be fixed
1756 6. virtualize destructor of gdcmObject ... leakage
1757 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1758 this also really need to be fixed
1759 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1760 remove compression file
1761 (as we only do decompression, right ?)
1762 * ENH: Change malloc/calloc/free with c++ equivalent
1764 2004-04-21 Jean-Pierre Roux
1765 * FIX gdcmHeaderHelper::GetXSpacing
1766 when a single value is found (bug ?), xpacing is now
1767 defaulted to yspacing
1769 2004-04-19 Jean-Pierre Roux
1770 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1771 * ENH add parameters :
1772 bool exception_on_error = false,
1773 bool enable_sequences = false,
1774 bool ignore_shadow = false
1775 to the gdcmFile constructors to be full gdcmParser compliant
1776 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1777 to allow reading of PAPYRUS 3.0 files
1779 2004-04-06 Jean-Pierre Roux
1780 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1782 2004-04-02 Jean-Pierre Roux
1783 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1784 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1785 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1787 2004-03-30 Jean-Pierre Roux
1788 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1789 for ACR file, written out as DICOM files (hope so...)
1791 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1793 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1794 moved to base class gdcmParser and only the specialisation is kept
1796 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1797 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1798 already does the job.
1799 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1800 (to be consistent with gdcmParser::WriteEntries).
1802 2004-03-30 Benoit Regrain
1803 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1804 upate of the object's instance. It's passed to 2 in the unfavorable
1805 case : one in the ExecuteInformation, one in the ExecuteData
1807 2004-03-29 Jean-Pierre Roux
1808 * ENH : Check on file type to be written moved
1809 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1810 * FIX : gdcmObject::ResetBoundaries now stops properly
1811 when end-of-list is reached
1812 : gdcmVersion modified (as Benoit Regrain asked)
1814 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1816 * src/gdcmUtil.cxx: added forgotten iostream include.
1817 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1818 equivalent to ExplicitVR in existing code).
1820 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1821 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1822 now contains all the gdcmGlobal related code.
1823 * minor coding style and doxygenation changes.
1825 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1826 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1827 now contains all the Debug related code.
1828 * minor clean-up of includes in src/*.cxx
1829 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1830 CreateCleanString) removed.
1831 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1832 * Doc/DoxyMainPageUser.txt added.
1833 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1834 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1835 src/gdcmDirList.cxx)
1837 2004-03-24 Jean-Pierre Roux
1838 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1840 2004-03-23 Jean-Pierre Roux
1841 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1842 big endian made volumes
1843 * ENH Now gdcmParser constructor and destructor are protected to forbid
1844 end user to instanciate class gdcmParser
1845 (only gdcmHeader and gdcmDicomDir are meaningfull)
1847 2004-03-22 Benoit Regrain
1848 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1849 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1850 gdcmSerie to gdcmDicomDirSerie
1852 2004-03-19 Jean-Pierre Roux
1853 * ENH Now the tree-like structure describing a DICOMDIR comming from
1854 an already existing DICOMDIR file is consistent with
1855 the home-made tree-like structure build ex-nihilo
1856 or build from the files held (recursively) in a Directory
1857 functions gdcmDicomDir::CheckBoundaries()
1858 gdcmObject::SetBoundaries() added
1860 2004-03-17 Jean-Pierre Roux
1861 * REM (Eric Boix bug) : removal of meaningless
1862 gdcmDicomDirImage::NewImage function.
1863 * FIX now file names and directory name are written properly in the
1865 * FIX now gdcmDicomDir constructor may be call without any trick
1868 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1870 of gdcmDicomDirImage::NewImage as empty function.
1872 2004-02-28 Jean-Pierre Roux
1873 * ENH add gdcmDicomDir:NewPatient
1874 add gdcmDicomDirPatient:NewStudy
1875 add gdcmDicomDirStudy:NewSerie
1876 add gdcmDicomDirSerie:NewImage
1877 to allow making gdcDicomDir object.
1878 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1879 (as opposite to the gdcmHeader chained list)
1881 2004-02-11 Benoit Regrain
1882 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1883 when using from python
1885 2004-02-10 Benoit Regrain
1886 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1887 * FIX : in gdcmDicomDir when the directory is empty
1888 * ENH : add callback and methods to get the progression of dicomDir
1891 2004-02-06 Jean-Pierre Roux
1892 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1893 - GDCM_META added to gdcmDicomDirType
1894 - class gdcmMeta created
1895 * ENH : - A brief summary is now displayed at the beginning of
1896 'testDicomDir' to help disaster magnitude estimation
1897 * REM : Now useless Test/explDICOMDIR.cxx
1899 2004-02-05 Benoit Regrain
1900 * ENH : add methods in gdcmObject to get the hash table or the list of
1902 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1903 * FIX : wrapping python for TagHeaderEntryHT
1905 2004-02-04 Benoit Regrain
1906 * FIX : even length for some strings when writting the dicom dir
1907 * FIX : sort the images in the dicom dir
1908 * FIX : Bug fix for python use of dicom dir
1909 * ADD : a python demo
1911 2004-02-04 Jean-Pierre Roux
1912 * FIX : Final solution (?) for icone embedded images
1913 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1914 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1915 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1916 gdcmData/gdcm-MR-SIEMENS-16.acr1
1917 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1918 to make full checking easier
1920 2004-02-04 Benoit Regrain
1921 * FIX : WriteEntries : coding style & logic in parameters
1922 * FIX : Set the elements to create the DicomDir in a dictionary file
1924 2004-02-03 Benoit Regrain
1925 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1926 * gdcmDicomDir : add the load of directory
1927 * Bug fix and print add-on
1929 2004-02-03 Jean-Pierre Roux
1930 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1931 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1932 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1933 * FIX gdcmParser.cxx : 'group length' elements are now considered
1934 as integers, even for shadow groups, when file is Implicit VR
1936 2004-02-02 Jean-Pierre Roux
1937 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1939 of the last synonym :-(
1940 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1942 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1943 * FIX taking into account the possible 7fe0,0010 multiplicity
1944 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1945 to allow removal of references to 7fe0,0010, to deal with
1946 ACR-NEMA images, when 0028,0200 is meaningfull
1948 2004-01-31 Jean-Pierre Roux
1949 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1950 no longer writes 'Un' on disk
1951 * FIX SQ elements with actual length are now dealt with corectly
1952 * FIX gdcmFile::WriteBase make the difference, for color images, between
1953 the length (for Palette expanded images)
1954 and Raw Length (non expanded image + Palette)
1955 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1956 (that broke Write). Replaced by UL.
1957 Aware user will reload the field if he
1958 thinks it's necesssary
1960 2004-01-30 Jean-Pierre Roux
1961 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1962 when 'dirty Acr' is found, to be compliant with the new
1963 IsReadable() methods.
1965 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1966 (no DOUBLE images in kosher DICOM,
1967 but so usefull for people that miss them ;-)
1969 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1970 DICOMDIR related utilities (not checked as Windoze compliant)
1972 2004-01-28 Jean-Pierre Roux
1973 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1975 2004-01-27 Jean-Pierre Roux
1976 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1977 to allow skipping the shadow elements, to save memory space.
1978 The TRUE value for this param has to be used
1979 with a FALSE value for the 'enable_sequence' param.
1980 ('public elements' may be embedded in 'shadow Sequences')
1981 * gdcmHeader methods now deal with 'embedded icones images' in the header
1982 (even when an 'icone image sequence' is announced by the
1983 element (0x0088,0x0200), but there is NO icone at all ...
1985 * gdcmHeader sometimes Image Location value doesn't follow
1986 the supposed processor endianity (see gdcmData/cr172241.dcm).
1989 * gdcmHeader add the method
1990 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1991 to get *all* the Header Entries with the same tag.
1992 GetHeaderEntrySameName is probabely *useless*
1993 (no meaning : Name is *not* an identifier within the Dictionary)
1995 2004-01-26 Benoit Regrain
1996 * Bug fix in the print of hexadecimal representations. Remove long fields
1997 in the print and add a third level of print to print them
1999 2004-01-23 Benoit Regrain
2000 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2001 * Bug fix on test suite after remove the strip made on not string fields
2002 * Split the IsReadable method between gdcmParser which test that the file
2003 is dicom and gdcmHeader which test that it's an image file
2005 2004-01-22 Benoit Regrain
2006 * DicomDir : clean code, add methods, set variables in protected or private
2007 * gdcmUtil : bug fix for the clean string method
2009 2004-01-19 Benoit Regrain
2010 * Add the use of shadow dictionaries
2011 * bug fix and coding style
2013 2004-01-19 Benoit Regrain
2014 * src/gdcmFile.cxx : bug fix concerning the close of file
2015 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2016 * Add the update of header entries using the shadow library
2018 2004-01-19 Benoit Regrain
2019 * removal of file gdcmHeader2.cxx
2020 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2021 inheriting from gdcmParser. This split is to prepare the integration
2022 of dicom dir parsing
2023 * bug fix under python
2025 2004-01-16 Jean-Pierre Roux
2026 * REM removal of class gdcmHeaderEntrySet
2027 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2028 * ADD add file gdcmHeader2.cxx
2029 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2031 2004-01-15 Benoit Regrain
2032 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2033 entries created while parsing the header. Thus, they will be destroyed
2034 when the gdcmDictSet will be destroyed
2035 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2038 2004-01-15 Benoit Regrain
2039 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2040 made a fatal error because of the memory release at the end of program.
2041 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2042 some memory and vtk seems to have some problems with that.
2043 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2045 2004-01-14 Benoit Regrain
2046 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2047 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2048 * src/*.[h|cxx] : make changes due to class name changes
2049 * gdcmPython/demo/*.py : bug fix due to method names
2051 2004-01-13 Benoit Regrain
2052 * src/*.[h|cxx] : coding style
2053 * vtk/*.[h|cxx] : coding style
2055 2004-01-13 Benoit Regrain
2056 * gdcmPython/testSuite.py : test the readable flag of file for tests
2057 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2058 It's lied to the stl compilation by MSVC (windows, always windows...)
2059 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2061 2004-01-12 Benoit Regrain
2062 * src/*.h : add comments
2063 * src/gdcmDictSet.h : set the method BuildDictPath in public
2064 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2065 directly setted in the source code
2066 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2069 2004-01-09 Benoit Regrain
2070 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2071 * setup.py : use a reference to gdcmVERSION
2073 2004-01-07 Benoit Regrain
2074 * Modification to compile with the distutils.
2077 2003-12-10 Benoit Regrain
2078 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2079 can use a gdcmHeaderHelper to load data
2080 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2081 made in the source code
2083 2003-12-10 Benoit Regrain
2084 * Update Windows projects and .cvsignore files
2086 2003-11-12 Jean-Pierre Roux
2087 * ENH gdcmHeader constructor has one more parameter (default value : false)
2088 that allows the user to 'go inside' the SeQuences only
2090 gdcmElValSet:Print takes it into account
2092 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * ENH: Update gdcmPython/CMakeLists
2094 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2095 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2097 2003-11-10 Jean-Pierre Roux
2098 * FIX : gdcmHeader::LoadElements is now based
2099 on the ListTag listElem member,
2100 not longer on the TagElValueHT tagHt member
2101 * ENH : PrintPubElVal shows (temporarily) both results,
2102 with the tagHt member and the listElem member.
2103 (it's easier to 'see' the problems when using Printheader)
2105 * FIX : old private member LgrElem is now splitted into
2106 ReadLength : Length actually found on disk (updated only
2107 if bug fixing is necessary), for internal
2109 UsableLength : Updated by FixFoundLength, to fix a bug
2110 or to allow Parser going on.
2111 Will allow to re-write a kosher header when a SeQuence
2112 with a length (not 0000) is found
2113 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2114 because gdcmElValSet::Add does not update ListElem
2117 2003-11-07 Jean-Pierre Roux
2118 * FIX misstyping in Transfert Syntax name table
2119 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2120 when they have an actual length (not 0000 nor FFFFF)
2121 (Nobody should care of it, but DICOMDIR explorers)
2123 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2124 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2126 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2127 * ENH: vtkGdcmReader now supports LUT !
2128 (vtkgdcmViewer for now is not able to use them though)
2130 2003-11-05 Jean-Pierre Roux
2131 * in testSuite.py : new files names for checking the package
2132 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2133 that returns the pixel area size to the *aware* (vtk) user
2134 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2136 2003-11-05 Benoit Regrain
2137 * in testSuite.py : Modify the rules for checking the paths
2138 : Explicit error messages
2139 * in __init__.py : Related modif
2141 2003-11-03 Jean-Pierre Roux
2142 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2143 to be used by aware (vtk) users that want to manage
2144 LUT (and no to turn the PALETTE image into an RGB pixels one)
2145 * GetPixelType now returns 8U for 24 Bits images
2146 (vtkGdcmReader compliant)
2148 2003-10-31 Jean-Pierre Roux
2149 * Removal of *all* gdcmData images and add them again
2150 in order to loose the 'history' of un-anonymised images
2152 2003-10-31 Jean-Pierre Roux
2153 * RMV : removal of useless jBitsInJsample.h
2154 for both 8 and 12 Bits JPEG Lossy Libraries
2156 2003-10-31 Jean-Pierre Roux
2157 * ENH : Add the functions gdcmFile::GetImageDataRaw
2158 gdcmFile::GetImageDataIntoVectorRaw
2159 that act as GetImageData and GetImageDataIntoVector
2160 except the making of an RGB Plane from Gray Plane + LUT
2161 Intended to aware (vtk) users who know how to manage
2164 GetLUTRGBA return a R,G,B,A LUT if any
2165 lgrTotaleRaw gives the 'Raw' length
2166 GetImageDataRaw returns the gray Plane
2167 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2168 (They stay Grey, just like with other Dicom viewers :-(
2170 2003-10-30 Jean-Pierre Roux
2171 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2173 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2174 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2175 being coherents dicom files.
2177 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2178 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2180 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2181 * ENH: Two steps is necessary to please VC++ compiler...
2182 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2183 * ENH: Add include dir to medcon lib
2184 * FIX: only one function is being exported for now !
2185 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2187 2003-10-29 Jean-Pierre Roux
2188 * adding gdcmHeader::GetLUTRGBA
2189 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2190 --> Mathieu, the modif u're waiting for is not yet committed
2191 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2193 2003-10-27 Jean-Pierre Roux
2194 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2195 00191113.dcm DermaColorLossLess.dcm
2196 MxTwinLossLess.dcm RadBWLossLess.dcm
2197 * ENH: For version prior to vtkImageViewer2 -r 1.19
2198 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2200 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * Removal of ido stuff in CMakeLists.txt
2203 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2205 * FIX: remove a call to ->Modified ... see comments
2206 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2208 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2209 * FIX: Problem with path for libvtkgdcmPython
2210 * ENH: Try adding a search script for python site-package
2211 * RMV: Remove some file from medcon lib that are not necessary
2212 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2213 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2214 * FIX: More pragma disable fro VC++,
2215 I don't think I break something as it is also disable in VTK/ITK.
2216 But it fasten debug compilation time.
2218 2003-10-23 Jean-Pierre Roux
2219 * gdcm now deals with 16 Bits Run Length Encoded images
2220 (they are compressed as 2 planes images,
2221 one for the high Bytes, the other for low Bytes)
2223 2003-10-22 Jean-Pierre Roux
2224 * Now CheckRead takes into account :
2225 - the bugged 'Leonardo' Siemens images
2226 - the XA images, sent thru the burning VPRO station
2227 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2230 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2231 * FIX: When copying a Makefile.am to CMakeLists.txt
2232 one should remove the '\'
2234 2003-10-22 Jean-Pierre Roux
2235 * in gdcmData adding a bugged 'Leonardo' Siemens image
2236 (wrong lengths in header)
2237 OK with gdcm, KO with the other viewers :-)
2238 * add a GE dlx XA image, thru the VEPRO burning station
2241 2003-10-21 Jean-Pierre Roux
2242 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2243 for a brutal checking of vtkgdcmViewer compliance
2245 2003-10-21 Jean-Pierre Roux
2246 * add the files for 'xmedcon' Jpeg Lossless library
2247 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2249 2003-10-21 Jean-Pierre Roux
2250 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2252 2003-10-21 Jean-Pierre Roux
2253 * garbage Siemens 'Leonardo' images dealt with
2254 (the patch is easy to remove)
2255 * cosmetic changes to avoid warnings
2257 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2259 no need to press 'r' now.
2261 2003-10-20 Jean-Pierre Roux
2262 * upgrade of checkRead.sh checkWrite.sh according
2263 to new Jpeg Lossless decompressor
2264 * add US.3405.1.dcm, a genuine RGB medical file ...
2265 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2266 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2268 2003-10-15 Jean-Pierre Roux
2269 * general anonymisation in gdcmData
2270 * adding the 'color files' from
2271 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2272 * adding some well knowed bugged-header images
2273 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2274 waiting for their inclusion in Python testsuite
2276 2003-10-15 Jean-Pierre Roux
2277 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2278 no longer seg faults when file is not found
2280 2003-10-14 Jean-Pierre Roux
2281 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2284 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2285 * TODO: *.in file to genereate a UseGDCM later
2287 2003-10-14 Jean-Pierre Roux
2288 * Some supposed-to-be Dicom Images have no preamble.
2289 OpenFile takes it into account
2290 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2291 * Missing elements added in dicomV3.dic
2292 (just to be affraid : have a look at
2293 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2294 and do it again next year ;->
2296 2003-10-13 Jean-Pierre Roux
2297 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2298 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2299 But there are NOT. It's fixed !
2301 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2302 * FIX: "jpeglib.h" was not found on VC++
2303 * FIX: vtkgdcm was not being installed
2305 2003-10-10 Jean-Pierre Roux
2306 * ENH : OpenFile closes the file if it *really* doesn't look like
2307 an ACR-NEMA / DICOM one.
2308 * FIX : testWrite no longer writes an empty file if the source file
2309 is not gdcm Readable
2310 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2313 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2314 * FIX: CMake generate now documentation
2315 * ENH: out of source doc build !
2316 * ENH: Generate both user and dev documentation
2317 * ENH: Should work on windows too
2318 * ENH: Only one doxygen config.in file is needed
2319 * FIX: make install should be ok now on ùnix plateform
2320 * FIX: PATH to dictionary was wrong (missing /)
2321 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2323 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * vtkGdcmReader is now able to read rgb dicom file.
2325 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2326 * added a gdcmViewer to vtk test, use mouse to control
2327 window level & window width
2329 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2330 * CMake-ification of gdcm, we have now two build system
2331 * FIX: on cygwin Wsock32 doesn't exist
2332 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2334 2003-10-06 Emanuel Ollart
2335 * FIX : compilation process wad broken.
2336 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2338 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * change gdcmViewer -> vtkgdcmViewer
2340 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2342 2003-10-06 Jean-Pierre Roux
2343 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2344 ( e.g : well known GE images with a wrong elem length,
2345 : Philips MRI Images with a wrong Huffman table)
2346 * still to be done : allow the reading of bugged LEONARDO Siemens images
2348 2003-10-03 Jean-Pierre Roux
2349 * Odd length strings are padded with '\0' (not with spaces,
2350 to remain compliant with already defined strings,
2351 like Transfert Syntax UID and others)
2353 2003-10-03 Jean-Pierre Roux
2354 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2355 to allow displaying RGB images (not only by affim ;-)
2357 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * vtkGdcmReader is now able to read rgb dicom file.
2359 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2361 2003-10-03 Jean-Pierre Roux
2362 * A few nasty patches to allow the reading of a lot of nasty images
2363 ( e.g : well known GE images with a wrong elem length,
2364 : Philips MRI Images with a wrong Huffman table)
2365 * still to be done : allow the reading of bugged LEONARDO Siemens images
2367 2003-10-03 Jean-Pierre Roux
2368 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2370 2003-10-03 Jean-Pierre Roux
2371 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2372 to allow displaying RGB images (not only by affim ;-)
2374 2003-10-03 Jean-Pierre Roux
2375 * gdcmFile::GetImageDataIntoVector now
2376 - deals with MultiFrames MultiFragments Run Length Encoded files
2377 - deals with YcBcR (YBR_FULL) files
2378 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2379 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2381 (no sample found :-(
2383 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2385 Two reasons: - clear things
2386 - third parties acces gdcm through header files, so won't
2387 suffer anymore VC++ complains
2389 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2390 * add argv[1] in testvtkGdcmReader.cxx
2393 2003-09-24 Jean-Pierre Roux
2394 * The lines are now eigthy characters long.for
2395 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2397 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2399 char* to std::string. Thus, the use of strdup becomes useless. (see
2400 previous commis of Malaterre)
2401 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2402 before the last Malaterre's commit.
2404 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * This commit should fix the Debug building under VC++, the problem
2406 was mainly a mixture of debug and release lib being loaded at startup.
2407 * I also remove a depency to a specific C function: strdup. Because I had
2408 to force the link to msvcrtd (whereas strdup is in libc).
2410 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2411 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2412 located in the gdcmCommon.h file. All use of reference of tha has been
2413 changed to now use the variable GDCM_UNFOUND.
2415 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2417 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2418 Dicom dictionary. The test suite can now be run again. Note:
2419 I'm note very happy with the " (RET)" changes. I believe this
2420 RETAINED comment should be dropped when parsing the dictionary.
2421 - PACKAGER corrected
2423 - AUTHORS updated and now in alphabetical order
2424 * Makefile.am now exports gdcm.dsw for Windoze users.
2426 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2427 * cygwin complains about missing std:: in subdir Test/
2429 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2430 * remove some methods that are now in gdcmHeaderHelper
2432 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2433 * vtkGdcmReader set spacing and origin correctly
2435 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2436 * Fix a few delete/delete[] mismatch
2438 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2439 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2440 interpretation to data given by gdcmHeader. For instance there are
2441 heuristics to get informations (look at different places).
2442 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2443 sorting DICOM images based on different strategies.
2444 * modified Makefiles accordingly.
2446 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2447 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2448 when building in debug mode
2449 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2450 src/win32/gdcmdll.dsp
2451 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2453 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2454 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2457 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * src/win32/libgdcmjpeg12.dsp was not dos format
2459 * src/win32/libgdcmjpeg12.dsp :
2460 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2461 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2463 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2464 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2466 * src/gdcmFile.cxx : bug fix in affectation type
2467 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2468 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2469 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2470 symbols... future problem ?
2472 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2473 * src/win32/libgdcmijpeg12.dsp was missing
2474 * modified gdcm.dsw accordingly
2476 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2477 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2479 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2480 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2481 commit of JPR (before his hollidays to facilitate our work).
2482 * setup.py : bug fix in code. Modifications made while the last commit
2483 of JPR. The code hasn't been tested before the commit... it's so
2484 useless to make that (for best programmer that is JPR) !!!
2486 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * tagged the current version as Version0_3 (i.e. version 0.3)
2489 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2490 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2491 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2492 * *.dsp : modifications to use new libgdcmijpeg8 library
2493 * setup.py : bug fix on VTKPATH variable
2494 * PACKAGER : adding all concerning windows
2496 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2499 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2500 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2501 test suite reported error.
2502 * PACKAGER file added (describes what a packager must do when
2503 packaging a new release).
2504 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2505 * configure.in: upgraded version number to 0.3.0
2506 * fixing build of rpm (through rpm -ta):
2507 - Doc/Makefile.am exports proper doxygen files
2508 - src/jpeg/libijg8/Makefile.am exports the include files.
2510 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2511 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2512 * src/gdcmHeader.h : formatting code
2514 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2515 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2516 We were obtaining error message from vtk. Now, creation of file list
2517 is made in an internal list to prevent this problem.
2518 Bug fix when output is empty.
2519 Bug fix in update of progress value. Previous commit for this was a bad
2521 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2523 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2524 * src/gdcmHeader.h : added method to get the file name
2525 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2526 files. Added method to remove all files on the input
2527 Added FIXME comment concerning the bad parsing of header made by
2528 ExecuteInformation method (in ExecuteData method)
2530 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2532 when using make instal.
2533 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2534 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2536 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2537 * setup.py : adding include dir of jpeg lib to compile all sources
2538 * */Win32/*.dsp : JPR fix for windows compilation
2540 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2541 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2543 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2544 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2546 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * setup.py is again effective on un*x (takes into account the
2548 addon of the jpeg library)
2549 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2550 * Doc/Doxy* updated (includes above enhancements)
2551 * INSTALL now points to web documentation
2553 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * src/gdcmHeader.h doesn't make unnecessary reference to
2556 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2558 * src/gdcm*.[cxx|h] :
2559 - to allow compilation with gcc 3.x
2560 -- clean up of STL usage (added explicit usage of std::)
2561 -- small fixes on exceptions.
2562 Note: linking not tested !
2563 - clean of doxygen comments to avoid warnings at documentation
2565 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2566 dependent convertion).
2568 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * Clean up of previous JPR garbage commit (not even commented in the
2571 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2572 - moved all jpeg related files from src to src/jpeg/libijg8, with
2573 addition/modification of Makefile.am and configure.in.
2574 - the testSuite is still brain damage (not guilty).
2576 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2577 * WrapVTK.py : modifications to get correctly vtk source files to
2579 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2580 (FileName -> Filename)
2582 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2583 * vtk/vtkGdcmReader.[cxx/h]:
2584 - UpdateProgress method should now be effective
2585 - removed the limitation on having only images loaded (as opposed
2587 - when building a stack of images/volume, a lesser number of
2588 gdcmHeader and gdcmFile instances should be used (hopefully
2589 accelerating things).
2590 - when building a stack of images/volumes, files which are not
2591 loadable (wrong path-filename, wrong permissions on existing file,
2592 or file not parsable by gdcm) are replaced with a black image
2593 in the stack (for the caller to notice the problem).
2595 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2598 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2599 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2600 between standard library (std) and vtk library (problems are found
2601 under Windows... thanks Windows !)
2603 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2606 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2608 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2611 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * When compiling with distutils (see setup.py) the C++ compiler is
2613 called with different flags than the default ones (with automake).
2614 In order to fix all those warning, I compiled gdcm with the command
2615 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2616 and went for warning fixes:
2617 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2618 up from unused variables.
2619 - vtk/vtkGdcmReader.cxx: potential bug fix.
2620 * src/gdcmHeader.h: Doxygen warning cleanup
2622 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * gdcmPython/gdcm.i:
2624 - typemaps correction to take into account the systematic replacement
2625 of "using namespace std" with std:: prefix e.g. std::list,
2626 std::string... (cf changes of 2003-05-21).
2627 - gdcmGlob global variable of type gdcmGlobal (defined in
2628 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2629 exported to Python a as cvar.
2630 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2631 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2632 gdcmDictSet.GetPubDictTagNames() and
2633 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2634 C++ static methods).
2635 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2636 with the above changes.
2638 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2639 * setup.py, manifest.in : bug fix under linux
2641 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2642 * Modification of setup.py to compile vtk part too. Then, we have 2
2643 wrappers which must work with same distutils. For that, we have a
2644 generic distutils in distusiltsWrapping.py ; with :
2645 - build_extWrap class to wrap generically all extensions,
2646 - ExtensionWrap base class for all wrapping extension that contains
2648 - Wrapper interface which wrap sources
2649 + In WrapSwig.py we have extension and wrapper for Swig
2650 + In WrapVTK.py we have extension and wrapper for VTK
2651 * MANIFEST.in : modifications to consider vtk directory and new python
2652 files for compilation
2654 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2655 * Added python wrappers of vtkGdcmReader vtk class (see the
2656 source in vtk/vtkGdcmReader.cxx) :
2657 - vtk/Makefile.am now builds a library
2658 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2659 python library (as opposed to _gdcm.so wich are the python
2660 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2661 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2663 - configure.in has an additional flag --enable-vtk that needs
2664 to be set to enable compilation of vtk related code, that is:
2665 + vtk/vtkGdcmReader.so and
2666 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2667 + gdcmPython/vtkgdcmPython.so (see above)
2668 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2669 be read when compressed or when HighBit + 1 != BitsStored),
2670 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2671 the usage of the python wrapper of vtkGdcmReader vtk class.
2672 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2673 * src/*.[h] all occurences of stl classes are now prefixed with
2674 std::, and all occurences of "using namespace std;" where removed.
2675 This is to avoid pollution of global namespace in included files.
2676 Apparently vtk does not avoid this pitfall: when using both
2677 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2678 collision of various stl members (principally cout...).
2679 * gdcmPython/testSuite.py now cleanly removes temprory generated
2681 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2682 comply with above changes)
2684 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2685 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2686 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2687 vtk data structure (an image Flip was required).
2688 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2689 * cosmetic changes in documentation.
2691 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2692 * src/gdcmHeader.cxx: the constructor no longer exits when an
2693 unexisting file is given as argument.
2694 * The subdirectory Data (containing all the images used for the
2695 test suite) is not part of this repository anymore. A new module
2696 containing those images is now available at
2697 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2698 with the name gdcmData.
2699 All the python scripts (including the package initialisation file
2700 gdcmPython/__init__.py) were adapated to take this change into
2701 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2703 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2704 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2705 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2706 demo of the usage of this class.
2707 Compilation of this vtk part is only done when using the --enable-vtk
2708 at configure (or autogen.sh) stage.
2710 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2711 * More memory link related corrections and documentation fixes.
2713 - maximum info is obtained with a command of the form:
2714 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2715 --show-reachable=yes PrintHeader
2716 - the remaining reachable blocks seem to come from the STL
2717 allocation scheme through the usage of map and list. It looks
2718 like this memory cannot be freed but it is not a memory leak
2719 (in fact further invocation to the STL would recollect the
2720 unused memory allthough it cannot explicitely be freed).
2721 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2722 of displaying an image parsed with gdcm and displayed with VTK.
2723 Note: some images don't seem to work e.g.
2724 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2725 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2726 Allthough this weakens the semantics, it is a ditch attempt to
2727 make gdcm more thread friendly.
2729 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2730 * Memory link hunt (by using valgrind through the command
2731 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2732 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2733 gdcmHeader::_dicom_vr.
2734 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2735 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2737 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2739 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2740 * src/Makefile.am now exports all the necessary include files at
2744 * UpdateGroupLength replaced by new one
2747 * UpdateGroupLength re-written using H-Table
2748 (named UpdateGroupLengthNew untill checks are over)
2750 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2751 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2752 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2754 - gdcmHeader::GetPubElValSet removed.
2755 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2756 UpdateGroupLength, WriteElements, Write.
2757 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2758 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2759 carried the same semantics.
2760 - src/gdcmHeaderIdo.cxx changed accordingly.
2761 - gdcmFile::WriteBase now regroups all the codes from previous
2762 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2763 - enum FileType moved to gdcmCommon.h
2764 * src/gdcmHeader.cxx AddDefault trashed
2765 * gdcmGetXSize added
2766 * getimageDataSize now calls gdcmGetXSize
2767 * Test/*.cxx changed to agree with above changes
2769 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2771 (to avoid double call by end user).
2772 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2773 by end user, since gdcmHeader::gdcmHeader now handles it.
2775 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * gdcm/Doc many doxygen changes:
2777 - Doxyfile now has two different versions, DoxyfileUsers that generates
2778 the html.users end users oriented documentation and
2779 DoxyfileDeveloppers that generates the html.developper developper
2780 oriented documentation.
2781 - README changed accordingly
2782 - requirement.txt removed (old design info moved to TODO).
2783 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2784 DoxyMainPage.txt, DoxyPython.txt provide more information.
2785 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2786 be updated by simply regenerating the docs with doxygen and copying
2787 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2788 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2789 all the tests in the form "if (<map>.count() >1)" were removed.
2790 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2791 ill-formed documentation sections.
2792 * src/gdcmHeader.cxx: ditto
2794 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * setup.py fixed for un*x (needed macro for stdint.h)
2796 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2797 un*ces with sh-utils test utility.
2798 * gdcmPython/demo/test.py renamed to PrintHeader.py
2799 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2800 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2801 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2802 * src/gdcm*.cxx JPR's bad inclusion fixed.
2804 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2806 * gdcmPython/demo/test.py changed accordingly.
2808 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * gdcmPython/Makefile.am fixed linking against libstdc++
2810 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2811 * Swig subdir (historical tests of swig version 1.3.17++) removed
2812 * Test/testChangeEntete.cxx some lines commented out in order to make
2814 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2815 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2817 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2819 hence the user doesn't need this explicit call.
2820 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2821 i.e. LoadElements() call removed.
2822 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2823 - src/Makefile.am declares the proper flag for g++.
2824 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2825 for adding user defined new tags.
2826 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2827 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2828 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2830 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2831 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2832 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2833 src/Makefile.am : the project should properly compile and install
2834 with the autotools, included the python wrappers part.
2835 * gdcm.spec.in : added a spec file for RPM packaging.
2837 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2838 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2840 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2842 to exported to the environement (see gdcmPython/testSuite.py
2844 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2845 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2846 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2847 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2848 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2850 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2851 * gdcmPython/__init__.py doesn't crash anymore when running in
2852 in InstallMode or PreInstallMode but with an environment given
2853 value of GDCM_DICT_PATH.
2854 * src/gdcmDictSet.[cxx/h] coding style.
2856 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2857 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2858 * src/gdcm.h general comments moved to TODO, and README
2859 * src/gdcm.h should now be seen as a user commodity (including it
2860 should suffice to fully use gdcm). It is nowhere including within
2861 any of the kernel files src/*.cxx and src/*.h.
2863 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2865 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2867 * src/gdcm*.cxx only include their corresponding include file
2868 (as opposed to gdcm.h)
2869 * gdcmPython/gdcm.i changed accordingly
2870 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2871 the autogen.sh generated "make snapshot" command to work.
2872 * autogen.sh removed history related references to crea package.
2874 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * distutilsSwigCPlusPlus.py work around some swig portability
2878 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2880 was done in a last ditch attempt to get setup.py _really_
2881 operationnal. The python/gdcmPython layaout add the advantage
2882 of hidding away the python related distutils specific files
2883 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2884 Alas, the src directory was out of scope (i.e. it's relative
2885 position to setup.py was ../src) which made things impossible to
2886 handle (see previous version of python/setup.py). Crossing fingers...
2888 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * python/setup.py now works on Un*x. (harder than I thougth)
2890 * python/distutilsSwigCPlusPlus.py can now have include files
2891 among the list of sources.
2893 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2894 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2895 * modifications in MSVC projects
2897 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * As stated by the first lines of Test/ExceptionAndPython/README, it
2899 looks like we can move back to original usage of exception within
2900 src/gdcm* and hence remove the errno stuff that was introduced
2901 as a quick and dirty fixture of this problem (added to the TODO).
2902 * Doc/Doxyfile configuration file for Doxygen and corresponding
2903 README file for usage added.
2904 * Test/testWrite.cxx added. This new test comes from a split of
2905 test.cxx that is now reverted to its original purpous i.e.
2906 testing the proper parsing of a Dicom related file.
2907 testWrite.cxx concentrates on testing the IO part of gdcm.
2908 * Test/bug1.cxx (containing a bug on WIn32) added.
2909 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2910 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2911 whose purpose is to publish the content of the TagNames of the
2912 Dicom public dictionary were not accessible without an
2913 instance of class gdcmHeader.
2914 - those methods are now static methods of gdcmDictSet and hence
2915 require no instances at all to be invocated.
2916 - within gdcmDictSet this change required to change some method
2917 to class methods (i.e. are now static) among which SetDictPath
2918 (renamed to BuildDictPath) and LoadDefaultPubDict.
2919 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2920 the above changes by calling the new method classes of gdcmDictSet.
2921 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2922 the above to be effective.
2923 * python/gdcmPython: in order to wrap properly the above changes
2924 for Python, swig version now needs to be > 1.3.17.
2925 * python/gdcmPython/Makefile fixed to adapt itself to new
2926 configure/make shema introduced by Johan Montagnat (thanks for the
2927 contribution). Alas this Makefile cannot be turned into a proper
2928 Makefile.am without some heavy changes in the configure.in
2929 (for python dectection).
2930 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2931 now avoids publishing the empty entries.
2933 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2934 * python/setup.py : bug fix concerning install under windows
2935 ExtraPath reused :-P
2936 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2938 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2939 * Dicts/dicomV3.dic : remove double spaces !!!
2940 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2941 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2944 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2946 method. Doxygenation.
2947 * src/gdcm.h clean up of JPR spurious comments.
2949 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * python/distutilsSwigCPlusPlus.py now properly collects the
2951 shadow classes generated by "swig -c++" (gdcm.py in our case)
2952 when using "python setup.py install".
2953 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2954 reexports the working classes.
2955 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2956 by the classical C errno scheme. This is to prevent an obscure
2957 behavior of the python wrappers when importing wxPython.wx prior
2958 to gdcmPython (which ended up in an abort call). An illustration
2959 of this oddity can be found in the Test/ExceptionAndPython
2960 subdir (see the README file). This problem probably due to
2961 an combination of g++ and dynamic loading.
2962 * added Test/ExceptionAndPython (see above)
2964 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * Changed the layout of the python part to avoid bloating main
2966 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2967 i.e. the distutils arsenal. All the python related stuff is
2968 again in a python subdir, but the package itself is now in
2970 * setup.py was cleaned up:
2971 - pythonIncludePath removed
2972 - python setup.py bdist target is now functional.
2973 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2974 collision with other packages). gdcmPython/demo/*.py changed
2977 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * python subdir moved to gdcmPython (preparation of distutils packaging).
2979 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2980 distutils installer is operational.
2981 * - gdcmPython/__init__.py now properly loads the swig generated
2982 shadow classes (from gdcm.py).
2983 - gdcmPython/demo/*.py changed to import the package gdcmPython
2984 instead of gdcmPython/demo/load.py.
2985 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2987 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2989 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2990 entries within the associated public Dicom dictionary resp. the same
2991 information but sorted by the fourth field (PAT, IMG, DIR) of the
2993 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2994 are now in the "???" group.
2995 - python/gdcm.i changed accordingly,
2996 - python/demo/printGroupedPublicDict.py added, that gives an example
2997 of the above new functionalities in Python.
2999 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * src/gdcm.h, gdcmHeader.cxx:
3001 - historic references to glib's g_malloc and g_free (#defined)
3002 were definitively removed.
3003 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3004 * src/gdcmElValSet.cxx:
3005 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3006 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3007 - GetElValue(string) renamed to GetElValueByName.
3008 - Added GetElementByName(string).
3009 * src/gdcmHeader.cxx: added
3010 - GetPubElValRepByNumber(guint16, guint16)
3011 - GetPubElValRepByName(string)
3012 - GetShaElValRepByNumber(guint16, guint16)
3013 - GetShaElValRepByName(string)
3014 - GetShaElValByNumber(guint16, guint16)
3015 - GetShaElValRepByName(string)
3016 - GetElValRepByNumber(guint16, guint16)
3017 - GetElValRepByName(string)
3018 - GetElValByNumber(guint16, guint16)
3019 - GetElValRepByName(string)
3020 * Doc/requirements.txt added.
3022 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3023 * Test/Makefile building now depends on the one of libgdcm.so
3024 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3025 pixel data) aware which enables finding the address (offset) of
3026 the pixel data of JPEG encoded DICOM files. This leaves only a single
3027 file in the testSuite whose pixel data address (offset) is unknown.
3028 * python/testSuite.py changed accordingly.
3030 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3031 * VC++ has some strong limitations when working with the STL, as stated
3032 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3033 "Also note that some STL containers (map, set, queue, list, deque)
3034 cannot be exported. [...]
3035 Some STL classes contain nested classes. These classes can not
3037 This is caused by a designed limitation that once a template
3038 class is instantiated, it can not be re-instantiated and
3040 Since our usage of map<> is ubiquitous in gdcm, this "designed
3041 limitation" of VC++ is a pitfall.
3042 Hence the Python wrappers of gdcm cannot be incrementally linked
3043 against the c++ dynamic library. The dirty but only workaround is
3044 to forget about incremental link of dynamic libraries and to generate
3045 the Python wrappers library with the inclusions of the underlying C++
3047 The following modifications concern this matter on Win32/VC++:
3048 - wrapping python correct with standalone wrapped dll (don't use separate
3049 dll under windows !!!!)
3050 - python21_d debug mode enabled (ask Frog how to use it :-)
3051 - NO problem with having an STL member of class for example string in C++
3052 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3053 - Python test of dcmlib in Python is ok under windows on a large set
3055 * removed glib references
3056 * typedef's inserted in gdcm.i for correct swig type management
3058 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * python/demo/*.py load.py extracted from test.py. Added explore.py
3060 that only displays required tags and testAll.py that parses all
3061 the files of the testsuite without using unittest.
3062 * python/testSuite.py other additional test on new files added.
3063 * Data/* new test files added accordingly to the testSuite.
3064 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3065 the vr in the file differs from the one of the dictionary.
3067 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3069 values, but limits itself to values which are below a user specified
3070 size (by default 1024 bytes).
3071 * python/gdcm.i : elements not loaded (because their size is above the
3072 user specified treshold) are exported with their TagKey as key of the
3073 python dictionary. This enables the testsuite to make some checks
3074 on the unloaded elements (since we have their offset and size).
3075 * python/testSuite.py
3076 - now tests for the existence and proper value of the pixel data
3077 - two new examples added.
3078 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3080 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3081 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3082 aware. See the strategy comments in gdcmHeader::FindeLength().
3083 * Test/test.cxx now accepts a filename as first argument.
3084 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3085 * python/testSuite.py changed to integrate test on above files.
3087 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3089 the vr was also RET.
3090 * python/testSuite.py more tests added.
3092 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * python/testSuite.py unittest test suite added (uses Data)
3094 * Data/* dcm and acr files for the test suite.
3095 * glib dependance removed from un*x version. We now use ISO C99
3096 7.18 Integer types (see stdint.h)
3097 - python/Makefile, src/Makefile src/gdcm.h
3098 * src/ when an explicit vr (like dicom files) suddenly poped an
3099 implicit element we use to mark the underlying DictEntry of the
3100 concerned ElValue with "Implicit". This strategy was damageable
3101 too the public or provite dictionaries, since some of their vr
3102 would be changed. Since Header::FindLength heavily relies on the
3103 detection by Header::FindVR of falsely explicit elements, I
3104 added an extra ImplicitVr member to ElValue (boolean).
3105 The rest of the changes we the necessary adaptations.
3107 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3110 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3112 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * Adaptation for porting to VC++:
3115 o forced to use std namespace (for string to be known)
3116 o all class use __declspec export style on WIN32
3117 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3118 (in stdlib.h on Win32 but in std:: for gcc)
3119 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3120 variable GDCM_DICT_PATH.
3121 * src/gdcmHeader.cxx verbose comments made discrete.
3123 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3124 * python/gdcm.i: added a typemap that converts a C++ hashing table
3125 to native Python dictionary.
3126 * python/demo/test.py:
3127 - now uses the native dictionary for exploration of gdcmHeader.
3128 - takes an optional filename argument (the file to parse).
3129 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3130 PubElVals hashing table.
3131 * Dicts/dicomV3.dic removed error prone trailing spaces.
3133 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3134 * Python wrapping process moved away from src/Makefile to
3135 newly created python/Makefile (as well as gdcm.i)
3136 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3137 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3138 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3139 from the environement variable GDCM_DICT_PATH (when existing).
3140 * src/gdcmDict::GetTag bug fix.
3142 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3143 * Straightforward temporary fixes for swig to build the python wrappers.
3144 src/Makefile now has a python working entry [by working we mean
3145 that we can import de shadow classes without errors].
3147 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3148 * hashtest.cxx removed (since already in Test)
3149 * src/gdcmlib.h renamed to src/gdcm.h
3150 * src/dcm.i renamed to src/gdcm.i
3151 * src/Makefile prepared for python wrapping
3153 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3154 * src/gdcmHeader.cxx :
3155 - Parsing of header is now separated from loading of element values
3156 (see gdcmHeader::LoadElements).
3157 - general clean up of hopefully all file access (creation of
3158 ReadInt16 and ReadInt32)
3160 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcmHeader.cxx :
3162 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3164 - SetLgrElem renamed to SetLength
3165 - GetLgrElem renamed to GetLength
3166 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3167 * src/gdcmElValSet.cxx fixed both GetElValue methods
3168 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3169 due to IdoDude was cleaned out.
3171 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3172 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3173 concentrates on finding the value representation (when it exists).
3174 RecupLgr now only finds the element value length, and it avoids
3175 returning the unecessary skL (skipped length).
3176 Also, offsetCourant was simply removed (with taille_fich) since
3177 it was redundant with the File position internals (by using
3178 ftell and fseek). This also made skL (see above in RecupLgr) usage
3180 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3181 on the libido specificities which are handled through class
3183 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3186 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * Truckload of changes. Parsing of header is barely functional
3188 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3190 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3191 * src/gdcmHeader.cxx many addons of low level methods
3193 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3195 and _IdDcmSWAP_LONG.
3197 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * This corresponds to all the changes decided at the meeting of
3199 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob