1 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
4 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
5 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
7 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
9 * Test/TestDict.cxx : add a new test for the dict classes
11 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
12 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
13 file. Debug is yanked if compiled with NDEBUG
15 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmDictSet.h : set the default output to the os variable
17 * src/gdcmDictEntry.[h|cxx] : add the Print method
18 * gdcmPython/demo/ : add a new test
20 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
21 * merging of Test/PrintDicomDir and Test/TestDicomDir
22 * removal of now redundant Test/PrintDicomDir
23 * enhancement of Example/PrintDicomDir
25 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Now, python test might work on systems
27 * Add the PrintDicomDir test
29 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
30 * FIX : First entry following group 0002 was lost for
31 Explicit Big Endian Transfer Syntax files
32 (group and elem not swaped)
34 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
35 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
36 Big Endian Transfer Syntax supposed the group following 0002
37 begins always by element 0000 (element 0000 is *optional*)
38 To avoid further troubles, let's be pessimistic, and use
39 Document::HandleOutOfGroup0002() method
40 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
41 (related pb not yet solved)
43 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * Bug fix for the python part use
45 * Now, PrintHeader.py pass... but outside the ctest use. shit !
47 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
50 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
52 a string and should ask the global TS dict what are the propreties of
55 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
56 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
57 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
58 to swap the Swap Code, at parsing time, when we come out of group 0002
59 and Transfer Syntax is Big Endian
60 We should be able to read now 'true DICOM" Big Endian coded images
61 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
62 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
64 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
65 * Hopefully fix the bug on MacOSX and static global initialization.
66 This is the only -minor- patch I found that both please MacOSX and VS6.
67 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
68 but this would require a lot of change. Another approach would be that Global
69 create those string and GDCM_UNFOUND becomes a pointer to a string (which
70 gdcm::Global would destroy at exit).
72 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Fix bug on MacOSX with static initialization in a multy threaded
74 environment. static const string in a header file used to be ill
75 initialized provoquing the freeze of any tests. patch should solve this
78 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
79 * According to Benoit's suggestion, and without any objection from anybody
80 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
81 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
82 - method gdcmDicomDirObject::GetEntry() renamed as
83 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
85 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
87 you debug/warning message just as c++ streams which make them very convinient
88 to use. Once this is stabilize I will change the ostringstrem to be
89 redirected to a file (ofstream).
90 * Properly support C99 extension: __FUNCTION__ which allow us to display
91 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
93 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
94 * Removal of useless and dangerous methods :
95 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
96 GetDocEntryByName, GetEntryByName, GetDictEntryByName
97 * Removal of usless methods :
98 Dict::PrintByName, Dict::GetDictEntryByName
99 * Commenting out of probabely useless methods :
100 Dict::GetDictEntryNames()
101 Dict::GetDictEntryNamesByCategory()
102 DictSet::GetPubDictEntryNames()
103 DictSet::GetPubDictEntryNamesByCategory()
104 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
105 * ENH : Use dicomTS.dic as described in 2004 version
106 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
107 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
108 Add Accessors on VM (Value Multiplicity), and VM related methods
109 * ADD : Add a list of 'Dicom Attribute types', as found in
110 http://medical.nema.org/dicom/2004/04_15PU.PDF
112 * ADD : Add dicomGroupNameAbbreviations.dic
113 should be used to write a method to replace the former
114 Dict::GetDictEntryNamesByCategory()
116 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
118 to read in the file... and only it ! Length is the efective length of the
119 data in the DocEntry structure
121 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
123 And now use a static function call instead, with a global variable. i
124 This is much closer to the VTK approach. Hopefully should be bulletproof
125 and easier to use...hopefully
127 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
128 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
130 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
133 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
135 ValEntry, BinEntry, SeqEntry creation or replace
137 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
139 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
141 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
142 when specifying the VR
143 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
144 * src/gdcmDocEntry.cxx : amelioration of print
146 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
147 * ADD : Add the method Util::IsCurrentProcessorBigEndian
148 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
149 * ADD Method Document::ComputeGroupLength
150 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
151 in order to allow further VR modification by user
152 * REM : removal of once-called method File::WriteBase
153 integration of its code in formerly one-line method File::Write
155 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
157 replace the different values "??", "Unkn", "Unknown".
158 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
159 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
160 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
161 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
163 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
166 * Set the gdcm::Base class to some Printable classes
168 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmFile.[h|cxx] : add the Print method
170 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
171 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
172 * src/gdcmDocument.h : remove the PrintLevel informations
173 * Example/PrintFile.cxx : use the new gdcm::File::Print
175 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
177 problems when compiling with the python wrapping
179 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
181 writting in ImplicitVR
183 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
184 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
185 JPEG decompression, especially when dicom frames are split into several
186 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
187 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
189 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmHeader.cxx : change the initialisation of default header.
191 Now, this header is readable by gdm, e-film, DicomWorks
193 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
195 Rename Decompressed to Raw
196 * Use the API changes in gdcm::File.
197 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
200 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
202 each added entry in the header. Replace the 'Planes' field by the 'Number
205 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
207 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
209 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
211 At this time, this image isn't readable by e-film... waiting JPR help to
214 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
216 DocEntry. Now use methods of the Document !
218 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Test/ShowDicomSeq.cxx : bug fix
221 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
223 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
224 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
225 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
227 * Test/TestCopyRescaleDicom.cxx : remove unused variable
228 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
229 containing found sequences
231 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
234 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
235 Some fields in BinEntry must be copied to not seg fault when making the :
236 gdcm::File *copy = new gdcm::File( copyH );
237 and tests are now made on good variables
239 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
241 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
243 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
244 * Add vtkGdcmWriter example and test
246 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * Test/TestUtil.cxx : reformat the source code
248 * vtk/vtkGdcmReader.cxx : remove and change prints
249 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
251 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
252 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
254 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
256 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
258 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
260 by an eof to prevent all bad read of the file... and in this case, the
263 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
264 * Example/Volume2Dicom.cxx : comment unused variables
265 * Test/PrintDicomDir.cxx : comment unused variables
266 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
267 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
268 method that is redondant with AddEntry.
269 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
272 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * Bug fix due my last commit (compilation under Windows).
274 * Example/Volume2Dicom : bug fix in the file and reformatting source code
275 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
277 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
279 - Remove printf / sprintf
280 - include iostream AFTER gdcm so we don't get warnings
281 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
283 - Also remove tons of include from header files, hopefully this should
284 speeup the compilation time, since it was becoming a dog slow.
285 - Remove gdcm.h as it include way too many files and slow down compilation
286 (plus it is not up to date)
287 - remove 'using namespace std' this is BAD !
289 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * Remove memory leaks on the DicomDir
291 * Remove some useless data in DicomDirObject
292 * Add usefull methods in SQItem, to be complient withe the ElementSet
294 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
297 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
299 future, with convertion)
300 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
301 and ImageDataSize values. Remove the method to get the PixelReadConverter
302 from the output of the class
304 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
307 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
309 and vtkErrorMacro use.
310 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
312 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
315 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
316 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
317 The string leaves only in the fonction. So when we make a .c_str(), we
318 get the pointeur on the first element, element that will be destroyed
319 immediately after thee instruction.
320 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
321 file has been opened : the test must be made on the content of the
322 pointer and not directly on the pointer !
325 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
327 the python part recompiles
329 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
331 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
332 X session is killed (for my computer... it seems to not be identic on
335 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
336 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
337 avoid problems (otherwise, the difference test between the visible image
338 and the reference is incorrect. If the reference is greater than the
339 screen resolution, it's produce errors).
340 Can be used for only one image. Can be used with a visible flag.
341 * vtk/vtkGdcmReader.cxx : remove commented codes.
342 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
343 under windows at compilation
344 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
346 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
348 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
350 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
351 tests on the image size X, Y, Z
353 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
355 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
356 between the class name and the file name
358 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/ : fix compilation warnings for the Write method (2 different
360 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
361 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
362 variable... create a static method in gdcm::Document to access to
363 this variable content.
365 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
367 file, to be accessed by other files (like gdcmFile). Remove commented
368 code. Move the change of the header to the gdcmFile, using the
370 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
371 To be sure of that (and simplify calls), the Write of the header now
372 gets a file name and not a file pointer (std::ifstream).
373 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
374 DocEntryArchive. Remove all open of the written file
376 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
379 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
381 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
383 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
384 some corresponding methods. Write correctly the file and check before
386 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
387 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
388 is now on RGB data (as before my last commit
389 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
391 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
393 Add a print information of the type of the entry
394 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
395 It was in the gdcmFile, and all write have been regrouped
396 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
397 Write correctly all dicom files (in decompressed mode only at this time)
398 * Test/ : test on files are now made using Raw data and not color data if
400 * Example/PrintFile.cxx : add more printings
402 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * Amelioration of code, remove some code copy. For the loading of
404 BinEntry (in gdcmDocument), add the test to verify if the file is already
407 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
409 remove a DocEntry in the header (push an empty DocEntry)
410 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
411 lines. Bug fix in the initialization of the PixelConvert and the
413 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
414 use in TestCopyDicom (now this test can run under windows... but fails)
415 * Test/TestCopyDicom.cxx : amelioration of the test :
416 - test the pixels written
417 - add test points to quickly find where is the error
418 - can set a file name input and output in arguments
419 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
420 amelioration of the test output
422 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
424 all replaced DocEntry's
425 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
426 Now, each needed DocEntry to modify is duplicated, modified and inserted
427 to the header using DocEntryArchive. Thus, after save, we can restore the
428 header initial state.
430 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
431 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
433 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
435 correct to copy it. The DictEntry is specified at the DocEntry creation,
436 then, it musn't change in the time.
437 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
438 header correctly. At this time, the change is only made for the first
439 level of the Document. In the future, it might consider sequences.
440 The change is made by replacing a DocEntry by an other that is created
441 outside the class. The old value is kept. When we restore the header
442 status, the added DocEntry is deleted and replaced by the old value.
443 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
444 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
445 set the write type to explicit VR, implicit VR or ACR. Add methods to set
446 the write mode to native, decompressed or RGB (but not used at this time)
448 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
450 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
452 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
454 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
456 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
457 set because already copied when copying the BinEntry's of the header
458 * Test/TestAllReadCompareDicom.cxx : remove warnings
460 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
462 Two problems appear when doing it :
463 - with the gdcmFile : when the GetImageData method is called, the pixels
464 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
465 data (pixels). And each structure destruct the data when it's
466 destructed. So we have two destructions for the same data. To solve it,
467 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
468 data or not. If it doesn't own data, then they will not destroyed by
470 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
471 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
472 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
473 create a double destruction of the same DocEntry's. So, to solve it,
474 the TagHT is simply cleared and the DicomDir* elements are destroyed.
475 * TODO : add an entry concerning memory leaks in the DicomDir
477 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
479 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
482 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
484 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
485 after it have been deleted
487 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * FIX: src/* fix the doxygen warnings.
489 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
490 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
491 was erroneously defined with a size of 15 instead of 16. [many thanks
492 to Jean Michel Rouet for pointing out this bug].
494 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 1. Finish merging JMR patch for writting DICOM from scratch
496 2. Fix -hopefully- bug with MONOCHROME and space vs null character
497 3. Use const ref when possible
498 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
499 5. A few more comments
500 6. CreateUniqueUID can now be called without parameter"
502 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
503 * ENH: Slightly bigger patch:
504 1. Getting toward full integration of JMR patch for writting dicom from scratch
505 2. Update Test to test part of this patch: CreateUniqueUID
506 3. File was not close properly in gdcmDict
507 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
508 5. Use of const ref instead of copy (speed issue)
509 6. Remove temporary (duplicate) string in TranslateToKey
510 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
511 8. Do not repeat virtual in subclasses
512 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
514 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
515 * Apply first patch toward better string comparison when dealing with broken
516 DICOM files. Essentially the string could be padded with a space instead
517 of a null character as defined by standard
519 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
521 because never used... and in the same time, that's remove some memory leaks
523 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmFile.cxx : now delete the PixelConvert instance.
525 * In examples and tests : change the type of image data variables from void*
526 to uint8_t*. Remmove all delete on image data variables
528 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
530 Verify the file pointer value before open the file, and if it's not null,
531 a verbose message is generated.
532 Close correctly the file when the file isn't considered dicom-like. The
533 correctly close is a call to CloseFile.
534 When closing the file pointer, test if its not null to close the file.
535 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
536 file. For an uncompressed image, the copied data correspond in the least
537 case to the image size (calculated) or the image size specified in the
538 header. A verbose is generated if these two size mismatch
540 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
542 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
543 break under windows (with msvc6 compilation).
545 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
547 compiling with MSVC6)
549 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * Bugs fix for the Windows build with VC6
551 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
552 needed (only for projects required VTK). If the VTK is included in all
553 projects, there is conflicts with the jpeg lib of vtk when compiling the
554 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
555 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
556 when compiling the gdcm_wrap.cxx file (created by the compilation of the
558 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
559 (like it's already made for the cout use). Otherwise, conflict with the
562 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
565 - comments on the DicomDir::Method related usage added.
566 - now that we use the namespace gdcm, a lot of internal classes do
567 NOT need to be wrapped anymore.
568 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
569 DicomDir::Method) new example added.
571 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * Improve string manipulation. I now inforce the notion of 'DicomString'
573 A DicomString can contain as many \0 as they want
574 and it is *always* of even length.
575 We only support odd length for very rare case.
576 And in the near future this should be removed.
578 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
579 * /binary_write/ gdcm source. Now even on big endian we are writting
580 little endian. This should -heopfully- fix some tests
582 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
583 * Now the dictionary is compiled into gdcm lib. This is a default
584 behavior, thus any dic file specified is picked before failback to
585 the one comiled into lib
587 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
588 * Change internals for gdcmDict. Don't use any 'new' any more.
589 This should definitely solve any leak problem, and we should be
590 as fast as before, as long as don't modify too much the dictionary.
592 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
593 * STYLE: ivars should start with a capital letter.
594 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
595 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
597 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
599 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
600 new 2004 dictionaries added (thanks to JPR).
601 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
602 * CLEANUP_ROUND (15) for gdcmPixelConvert
603 - RLEFrame::NumberFragments is now of type unsigned int
604 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
605 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
608 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
609 * Initial work in gathering all transfer syntax accessors. clearly
610 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
611 ivars, but only one transfersyntax (class) ivar with equivalent method on
614 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
615 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
616 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
617 discussed (plus I didn't like having a 2000 lines patch not commited)
619 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
621 * CLEANUP_ROUND (14) for gdcmPixelConvert
622 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
623 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
624 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
626 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
627 anymore and hence avoids storing a copy of PixelConvert::Decompressed
628 into File::Pixel_Data.
630 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
632 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
633 * CLEANUP_ROUND (13) for gdcmPixelConvert
634 Substituted File::ParsePixelData() with PixelConvert::Print() new
636 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
637 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
638 method to those classes.
639 - src/gdcmFile.[cxx|h]:
640 -- Added a ::Print() method.
641 -- PixelConverter is now a reference instead of a member.
642 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
643 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
645 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
647 collaboration diagram and inheritance diagram should be generated with
649 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
650 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
651 pointlessly wrapped (see
652 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
653 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
654 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
655 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
656 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
657 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
658 -- File::Initialise: PixelConverter setup moved away to
659 PixelConverter::GrabInformationsFromHeader()
660 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
661 interpretation moved away to PixelConverter::BuildRGBImage()
663 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
664 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
665 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
667 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
669 displayed on Win32 when a brutal abort() occurs (because of uncatched
670 exception). See TODO new entry of this commit for more on this.
671 * TODO added new entry.
672 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
673 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
674 - HandleColor is no longer called from gdcmFile.cxx
675 - gdcmPixelConvert.cxx clean up on method arguments and internal
676 variable names for semantical coherence.
678 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
679 * Finished lossless transition, not only do we now read all lossless jpeg
680 images, without the need of the Cornwell lib, but we do read them properly now
681 * To reduce code (well to avoid code duplication), I defined a common place
682 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
683 redefine symbols. This is not perfect but this the best solution I found for a
684 compilation time jpeg option.
686 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
687 * Update jpeg ijg lib to support lossless jpeg implementation
688 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
690 * Also added a special copyright for dcmtk since we use their bugfixes.
693 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
695 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
696 matters, as stated in warning note at begining of %include section).
697 * src/gdcmDicomDir*.[cxx|h]: coding style
698 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
699 * src/gdcmJpeg8.cxx: doxygen fix.
700 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
701 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
702 from File:: to PixelConvert::.
704 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
705 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
706 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
707 - more code moved away from File:: to PixelConvert::
708 - fat setup of PixelConverter set in place in File::Initialise.
710 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
711 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
712 namespace at the file system level. So now you should convert your examples
714 gdcmHeader -> gdcm::Header
715 It would be nice if people keep in mind to no open the namespace, since it
716 allows compilation on broken plateform which were defining common symbol in
717 the standart namespace (like LP, Unknown ...)
719 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
721 The JPEG fragments are now parsed at the same stage than the RLE
722 information. All code related to JPEG is now in gdcmPixelConvert:
723 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
724 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
725 export a gdcmFile:: method. Those are simply global functions
726 (for the time being this is better than having them attach to
727 either gdcmFile:: or gdcmPixelConvert::).
728 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
729 and stores the result in a gdcmJPEGFragmentsInfo.
730 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
731 code (among other stuff) moved away from gdcmFile:; to
734 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
736 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
737 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
738 clean up of RLE related code.
739 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
740 - src/gdcmRLE.cxx removed
741 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
742 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
743 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
744 * CLEANUP_ROUND (9) for gdcmPixelConvert
745 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
746 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
747 away from gdcmFile:: to gdcmPixelConvert::.
749 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
751 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
752 This is because Parse7Fe0 used to parse the pixels to compute the
753 length. This task was passed over to FindDocEntryLengthOB() a long
754 time ago, EXCEPT I had forgotten the OW case...
755 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
756 we just recylce the code for parsing RLE fragments and computing
758 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
759 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
760 with the retired Parse7Fe0().
761 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
762 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
764 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
766 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
767 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
768 - src/CMakeLists.txt: alphabetic order reodering + new entries.
769 * CLEANUP_ROUND (4) for gdcmPixelConvert
770 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
771 to return an unused length.
773 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
774 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
775 this should be cleanner from the plane view. The iostream are erally a pain
776 to use to do simple stuff.
778 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
779 * Redo the compilation of the ijg jpeg library. Now only one source is
780 necesseray. No need to rename file by hand what so ever. CMake handle the
781 copying of the file within different directory, configure header file to
782 modify some symbol. The only addition made to ijg wasd a mangle table so
783 that symbol are different wether we are within 8bits or 12bits.
785 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * Added documentation of vtkgdcmReader on Website:
787 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
788 with it's binary name).
789 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
790 the Website to be more complete.
791 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
792 doxygenated documentation.
793 - Doc/DoxyVtkGdcmReaderExamples.txt added
794 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
795 DoxyVtkGdmReaderExamples.html )
796 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
797 * CLEANUP_ROUND (3) for gdcmPixelConvert
798 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
800 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * CLEANUP_ROUND (2) for gdcmPixelConvert
802 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
804 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * CLEANUP_ROUND for gdcmPixelConvert:
806 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
807 - src/gdcmPixelStuff[h|cxx] removed
808 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
809 - src/CMakeLists.txt changed accordingly
811 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
812 gdcmVersion.py moved to newly created ATTIC related
813 gdcmPython/SetupOldies/ directory.
814 * Autotools clean up:
815 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
816 - autogen.sh configure.in acinclude.m4 python.m4 removed
818 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/*.cxx *.h Reference to License.htm fixed to License.html.
820 * Doc/CMakeLists.txt, doxygen.config.in: fix.
821 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
823 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * TODO updated with Mathieu suggestions. I proposed a template for
825 describing TODO entries and used it for new entries.
826 * Added Doc/Website/CodingStyle.html, Developpers.html,
827 DeveloppersPython.html, GdcmDataCvs.html and
828 DownloadVersion0_1.html, DownloadVersion0_3.html.
829 * Some Doc/*.txt Doxygen files (which do not really concern the
830 documentation itself, but the website) moved to html and
831 placed in directory Doc/Website:
832 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
833 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
834 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
835 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
836 * CMakeLists.txt changed accordingly.
837 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
838 DeveloppersPython.html
839 * INSTALL nows refers to Doc/Website/Installation.html
841 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * Added Doc/Website directory, that contains a first raw version
845 2004-09-23 Jean-Pierre Roux
846 * FIX In order not to be poluted any longer by casting problems,
847 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
848 we can now delete[] it safely
849 * VoidArea is now called BinArea (less confusing name),
850 and all the methods called ...VoidArea... are now ... BinArea...
851 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
853 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
855 clear) TagHT, which is an inherited member of gdcmElementSet. It is
856 up to the destructor of gdcmElementSet to clean up TagHt and it's
859 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * Test/CMakeLists.txt: update to follow gdcmData renamings.
861 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
863 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * ENH: added some utility method that builds a flat dictionnary
865 holding all the Dicom entries contained in the recursive structure
866 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
868 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
869 BuildFlatHashTable() that build a flat dictionary.
870 - src/gdcmElementSet.h: added a new private GetTag() accessor.
871 gdcmDocument is now a friend of gdcmElementSet.
872 - src/gdcmElementSet.cxx: clean up.
873 - Example/FlatHashTablePrint.cxx added.
874 - Example/CmakeLists.txt changed accordingly
876 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
878 moved away from gdcmDocEntrySet (since this class is an abstract class
879 acting like an interface). SQDepthLevel and BaseTagKey are now
881 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
882 and associated accessors. Doxygenation of the class.
883 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
885 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
886 Use SQDepthLevel accessor instead. ::Print() adapted.
887 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
888 - src/gdcmDocument.cxx changed accordingly.
890 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
892 - The following is the doxygen comment of the typedef declaration
893 of gdcmTagKey in src/gdcmCommon.h:
894 gdcmTagKey is made to old an "universal" (as in URL, Universal
895 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
896 A dicom tag always has a group and an element, but a set of tags
897 embeded in various (optionally nested) sequences and sharing
898 the same group and element all share the same (group, element)
899 "identifier". Hence the (group, element) cannot be used as an
900 identifier (in gdcm we shall refer to a "TagKey") of a tag.
901 In order to construct a proper tag identifier (i.e. a key) we
902 consider the following definition of a TagKey:
903 - let Group, Element be the string representation of the
904 group and element dicom tag members,
905 - let ItemNumber be the string representation of the integer
906 index of the considered item number of a sequence,
907 Let the key of a tag embeded in a sequence, noted SeqTag, be
909 /ItemNumber#Group|Element
910 where "/", "#" and "|" are characters acting as separators.
911 Then the general form of a gdcmTagKey is given by:
912 Group|Element<SeqTag>
913 where <SeqTag> means NO or many instances of SeqTag.
914 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
917 but the gdcmTagKey of a tag "embeded" is the first item of
918 a sequence, itself nested in the third item of a sequence is the
920 0004|1220/2#0008|0082/0#0008|0090
921 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
922 order to hold the new sequence compatible key. Previously, the
923 GetKey() method would look in the underlying gdcmDictEntry.
924 - src/gdcmDocEntry.cxx:
925 -- constructor now copies the underlying DictEntry key, in the local
927 -- ::Print: displays the member Key, instead of the (group, element).
928 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
929 - src/gdcmDocEntrySet.h:xi
930 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
931 -- now has a new BaseTagKey member.
933 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
934 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
936 This poses the problem with the semantics of the following lines
937 LoadEntryVoidArea(0x0028,0x1201); // R LUT
938 LoadEntryVoidArea(0x0028,0x1202); // G LUT
939 LoadEntryVoidArea(0x0028,0x1203); // B LUT
940 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
941 to the long FIXME note for what the problem is. Nevertheless in
942 order to get things working the dicom dictionary was altered !
943 Please fix things urgently...
944 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
945 information), see above note on moving the member VoidArea. Nevertheless
946 the following entries previously correctly set as US are now inproperly
948 0028 1201 OW IMG Red Palette Color Lookup Table Data
949 0028 1202 OW IMG Green Palette Color Lookup Table Data
950 0028 1203 OW IMG Blue Palette Color Lookup Table Data
951 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
952 of gdcmDocEntry moved to gdcmSeqEntry.
953 * src/gdcmSeqEntry.cxx: STYLE.
955 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * Test/TestAllEntryVerify.cxx minor fix and added comments.
958 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * gdcmPython/testSuite.py: all the test suite in python is now moved
960 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
961 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
962 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
964 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
965 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
966 to avoid inclusion recursion until STL is reached.
967 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
968 mecanism. errno.h is not included in gdcm anymore.
969 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
970 (gdcmFormatError now inherits from gdcmFormatUnexpected).
972 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
973 gdcmData/TestAllEntryVerifyReference.txt
974 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
975 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
976 exception_on_error parameter.
977 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
978 - vtk/vtkGdcmReader.cxx changed accordingly,
979 - Example/*.cxx and Test/*.cxx changed accordingly.
981 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
983 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
984 enable_sequences removed from gdcmHeader constructor and dependencies.
985 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
986 * gdcmPython/demo/PrintHeader.py: dummy fix.
987 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
988 skip_shadow removed from gdcmHeader constructor and dependencies.
989 * Example/*.cxx and Test/*.cxx changed accordingly.
991 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
993 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
995 2004-07-21 Jean-Pierre Roux
996 * FIX Now, Parsing and Printing a DICOMDIR do work!
997 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
999 2004-07-20 Jean-Pierre Roux
1000 * FIX Some brain damaged headers have Zero-Lenght fields
1001 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1003 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1004 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1005 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1006 variable (instance of gdcmDebug) by a definition macro, and the instance
1007 is now in static in the gdcmDebug class
1008 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1009 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1011 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * WARNING: ctest now depends more tightly on gdcmData. You should
1013 check out gdcmData properly for things to run smoothly...
1014 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1015 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1016 we need the pixels not be loaded in order to use the ValEntry
1017 that displays position and size).
1018 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1019 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1020 be deprecated. If you have any doubts about the advantages of a
1021 modern scripting language (read Python) versus grass root C++ (i.e.
1022 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1023 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1024 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1025 Anyhow, consider documenting the gdcmData images in
1026 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1028 * Test/CMakeLists.txt:
1029 - now uses TestAllEntryVerify.cxx
1030 - specific comments on oldACR00001.ima (now renamed in gdcmData
1031 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1032 gdcmData/TestAllEntryVerifyReference.txt
1035 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1036 * src/*.[h|cxx] : typedef clean up
1037 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1038 - TagKey renamed to gdcmTagKey (for external usage)
1039 - VRKey renamed to gdcmVRKey (for external usage)
1040 - removal of typedef duplication.
1041 - Removed all unecessary inline keyword from class inline definitions.
1042 - Some method|function(void) declarations replaced with method|function().
1043 * src/jpeg/libijg12/jdhuff12.c:
1044 - printf polluting ctest removed.
1045 - TAB removal for comminting
1047 - TestAllReadCompareDicom.cxx: added a test that compares all the
1048 images in gdcmDataImages.h with corresponding images in
1049 gdcmData/BaselineDicom/. When baseline images are not present
1050 this test creates them.
1051 Note: we need to validate each reference image, but before that
1052 I'd like to rename them with a more explicit name...
1053 - CMakeLists.txt: changed accordingly.
1054 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1055 including each header needed).
1057 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1059 test suite to the Example directory. Are concerned:
1064 - TestWriteSimple.cxx
1065 * Test/CMakeLists.txt: added some comments on reasons for black listing
1066 image gdcmData/oldACR00001.ima
1068 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * Test/CmakeList.txt: removed the following from black list (to be coherent
1070 with removal from gdcmData):
1071 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1072 - gdcm-MR-PHILIPS-16.dcm
1074 Added the following because after last cvs update, they cause
1075 ctest -R TestReadWriteReadCompare
1077 - gdcm-MR-SIEMENS-16-1.acr
1079 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1080 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1081 new comments in this file) we temporarily (sigh) move to a weaker
1083 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1084 we don't need to black list the following images anymore:
1085 - 8BitsUncompressedColor.dcm
1087 - US-PAL-8-10x-echo.dcm
1088 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1089 fixes and the beautified code ;-)
1090 This fixes the bug introduced in version 1.42 (when beautifying)
1091 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1092 Note: ctest was blind to this bug (this means we need to still
1093 improve the test suite). The bug could be detected by using
1094 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1096 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1097 and by displaying the (garbage) produced file temp.XDCM...
1099 2004-06-29 Jean-Pierre Roux
1100 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1101 - replace by uggly but working old code :-(
1102 A lot of things should be OK again.
1103 It's really urgent to have a test suite that *tests*,
1104 to prevent Frog's beautifying sessions to break all the stuff
1105 (twice, withing a fortnigh ...)
1107 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1109 redundancy) to added Test/TestReadWriteReadCompare.cxx
1110 * Test/CmakeList.txt: because the compare test of
1111 Test/TestReadWriteReadCompare.cxx fails, the following images are
1112 black listed: - 8BitsUncompressedColor.dcm
1114 - US-PAL-8-10x-echo.dcm
1115 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1116 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1117 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1118 and ad-hoc kludge. This kludge is now removed, and on encountering
1119 such an image (OB field brain damaged) we set errno. Then in
1120 ::FindDocLength() we "fix" the length as being ALL what remains
1121 in the file (until EOF). We then proceed, hoping for the best...
1122 This fixes a SegFault in ShowDicom when trying to write such an
1124 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1125 (because TestWriteRead breaks on it, after a non conformal commit?).
1126 ctest now runs properly, except for MakeDicomDir (which was always
1127 broken) and the Python related stuff (still not fixed).
1129 2004-06-24 Jean-Pierre Roux
1130 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1131 FIX : Test/TestReadWrite now iterates on all the file names
1132 (instead of infinite loop)
1133 ENH : Test/TestWriteRead now iterates on all the file names
1135 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1138 2004-06-24 Jean-Pierre Roux
1139 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1140 when SamplesPerPixel =3
1141 - now Write is no longer confused by
1142 'BitsAllocated = 12" and 'BitsStored=12"
1143 - "UN" value representation Elements are now written correctly
1144 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1145 ENH : - now gdcmHeader has its own Write methods
1146 (in order to split the job that has not to be done
1149 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1150 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1151 loop on the same image until memory went out.
1152 Note: this means we still have gobs of memory loss in PrintDocument
1153 * src/gdcmDocument.cxx: fixes problem on parsing on file
1154 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1156 2004-06-24 Jean-Pierre Roux
1157 FIX : Write - All the Sequences and Sequence Item are now written
1158 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1159 is added a the end, when necessary.
1160 - A lot of brain-damaged images, that were read correctly are
1161 now written correctly
1162 - length compatible BinEntry are now loaded correctly
1163 (even for odd groups)
1164 Note : only Explicit Value Representation was checked.
1165 (question : is implicit VR really necessary for gdcm ?)
1167 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * DEVELOPPER: added a proposition of coding style.
1169 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1172 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1174 Use the gdcmDocEntry::Print() and Write() instead.
1175 * src/gdcmDocument.cxx: bug fix.
1177 2004-06-22 Jean-Pierre Roux
1178 FIX : gdcmDocument.cxx
1179 - Now we do recognize the JpegLossLess format (there was a misstyping in
1180 code 'beautyfication' :-(
1181 - Now we automaticaticaly load the Luts, if any
1183 2004-06-22 Jean-Pierre Roux
1184 In order : to write Sequences, whatever their imbrication level,
1185 : to allow user to create his own Sequences
1186 a lot of modif where necessary (adding, moving, or virtualising methods)
1188 WARNING : save your own sources *before* cvs up !
1191 ADD virtual void Write(FILE *fp, FileType filetype);
1194 ADD virtual void Write(FILE *fp, FileType filetype);
1195 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1198 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1199 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1200 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1201 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1202 ADD std::string GetEntryByName(TagName name);
1203 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1205 std::string vr = "unkn",
1206 std::string fourth = "unkn",
1207 std::string name = "unkn");
1208 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1209 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1210 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1211 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1212 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1213 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1214 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1215 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1218 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1219 ADD virtual std::string GetEntryByName (TagName tagName);
1220 ADD virtual std::string GetEntryVRByName (TagName tagName);
1221 REM virtual bool Write(FILE *, FileType);
1222 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1223 FILE *_fp, FileType type);
1224 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1225 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1226 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1227 REM virtual std::string GetEntryByName (std::string tagName);
1228 REM virtual std::string GetEntryVRByName (std::string tagName);
1229 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1230 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1231 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1233 std::string vr = "unkn",
1234 std::string fourth = "unkn",
1235 std::string name = "unkn");
1236 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1237 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1238 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1239 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1242 ADD virtual void Write(FILE *fp, FileType filetype);
1245 ADD virtual void Write(FILE *fp,FileType filetype);
1248 ADD virtual void Write(FILE *fp, FileType filetype);
1249 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1250 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1251 REM std::string GetEntryByName(TagName name);
1254 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1256 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1258 The default constructor invoked by the line
1259 gdcmHeader *f1 = new gdcmHeader( header );
1260 was gdcmHeader::gdcmHeader(bool) instead of the expected
1261 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1262 Hence the parsing wasn't executed... See also below.
1263 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1264 as explicit constructor didn't do the trick to fix the above problem.
1265 Could anyone explain why ?
1266 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1267 properly calls gdcmValEntry::Print() (that was weed out from
1268 code related to gdcmBinEntry).
1270 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * In order to fix memory leaks:
1272 - Test/TestWriteSimple.cxx: added cleaning of free store through
1274 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1275 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1276 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1277 (through the call to ::AddDicomDirMeta()) or the destructor
1278 would crash when deleting uninitialized ::metaElems].
1279 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1280 - src/gdcmDocument.cxx:
1281 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1282 from dynamic stores.
1283 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1284 was causing memory leaks.
1285 - src/gdcmSQItem.cxx:
1286 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1287 cleanly handled with polymophism: sorry but my milage is low).
1288 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1289 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1290 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1291 This avoids SegFaulting.
1292 - src/gdcmSQItem.h: coding style.
1294 - Test/TestWriteSimple still severely sucks. The output image content
1295 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1296 damaged when displayed with vtkgdcmViewer.
1297 - on memory leaks: TestWriteSimple leaks really less (see entry
1298 of 2004-06-18 in Changelog file for the call to valgrind).
1299 - on segfaults: ctest now passes all the tests but one (no more
1301 * Erroneous leading white fix:
1302 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1303 white[s] (as opposed to from >> xxx, that removes it [them].
1304 - src/gdcmTS.cxx: ditto.
1305 - gdcmPython/testSuite.py: dirty related kludge removed.
1306 * src/*: remaining references to gdcmParser removed.
1307 * src/*[cxx|h]: added copy[way]left header.
1310 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * In order to fix writing of dicom files:
1312 - Test/TestWriteSimple.cxx: a simpler example of writing.
1313 - Test/CMakeLists.txt changed accordingly.
1314 - src/gdcmDocument.cxx:
1315 -- The destructor now recursilvely removes potential sequences.
1316 -- Bug fix in ::IsJPEG2000()
1317 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1318 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1320 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1321 to only declared) and build on top of
1322 ::GetDocEntryByNumber(guint16, guint16).
1323 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1324 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1325 for usage in destructor and treatement of promotion in
1326 ::ReplaceOrCreateByNumber().
1327 - src/gdcmSQItem.cxx: destructor should better handle his job.
1328 Test/TestWriteSimple now runs (or at least it DOES something).
1329 * We can now start hutting memory links. A good starting point is:
1330 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1331 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1332 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1334 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * Valgrind note: after Mathieu Malaterre teached me how to read
1336 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1338 Using gcc, you can force the STL to use malloc and to free memory as
1339 soon as possible by globally disabling memory caching.
1340 With 3.2.2 and later, you should export the environment variable
1341 GLIBCPP_FORCE_NEW before running your program.
1342 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1343 simply vanish (it is still not clear to me, whether this means that
1344 STL std::string leaks or if valgrind believes it leaks...).
1345 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1346 running bin/gdcmTests makeDicomDir):
1347 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1348 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1350 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1351 SegFaulting (I drowned in DicomDir related code when trying to
1352 understand why the list is empty...).
1353 * src/gdcmDocument.h: first BSD license header try.
1354 * Doc/License.txt added.
1356 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * src/gdcmDocument.[h|cxx]:
1358 - Clean up of the Transfer related predicates. They are now all based
1359 on new method isGivenTransferSyntax, that (should) handle properly
1360 the padding problem.
1361 - general clean up, simplification, and coding style.
1362 - Specific clean up of Parse7FE0() (umproperly named actually).
1363 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1365 2004-06-14 Jean-Pierre Roux
1367 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1368 - fix the display of SQItem ordinal number
1369 - add the GetSQItemByOrdinalNumber method
1370 - remove some useless never written private methods
1372 2004-06-14 Jean-Pierre Roux
1374 - adding a constructor taking a gdcmDocEntry as an input param
1375 - ReplaceOrCreateByNumber now returns :
1376 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1377 a gdcmValEntry * if a string value is passed as a param
1379 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1380 according to the param type (no longer sets a gdcmDocEntry)
1381 - GetValEntryByNumber, GetBinEntryByNumber added
1382 - NewValEntryByNumber and NewBinEntryByNumber added
1384 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1386 - GetSQItemNumber and SetSQItemNumber added, to provide
1387 a (relative) Item identier inside a given Sequence
1388 \warning : some pb remaining around this number
1390 - AddEntry now takes the Item Number as a param
1392 - adding a constructor taking a gdcmDocEntry as an input param
1394 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1395 * Memory leak hunt with the following command:
1396 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1397 --show-reachable=yes gdcmTests PrintDocument
1398 It looks like many (all?) leaks are due to the STL (or a bad usage
1399 of the STL. The lines producing the leaks now have a comment with
1400 a "MEMORY LEAK" tag: you can retrieve them with
1401 grep "MEMORY LEAK" src/*
1402 Here are two typical examples which I can't help fixing:
1407 char * test = "babo";
1408 name = test; //// <--- valgrind detects 960 bytes lost in
1409 //// call to std::string::operator=(char const*)
1410 name.clear(); //// Doesn't help !
1418 std::cout << "Type a bunch of characters followed by RETURN: ";
1419 getline(std::cin, line); //// <--- valgrind dectects a loss
1420 //// of 1320 bytes in call to
1421 /// std::basic_istream<>& std::getline<>
1427 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1428 * src/gdcmHeader.[cxx|h]:
1429 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1430 and related, moved away to gdcmDocument.
1431 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1432 the corresponding protected accessors of inherited class
1433 gdcmDocument, removed ! As a consequence gdcmFile had to be
1434 declared friend of class gdcmDocument (see below).
1435 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1436 - Clean up of undefined or unused methods.
1437 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1438 account the changes to gdcmHeader.h).
1439 * src/gdcmDocument.h:
1440 - gdcmFile is now a friend class (in order to take into account the
1441 changes to gdcmHeader.h).
1442 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1443 (see changes to gdcmHeader.h).
1444 - Accessors (reading on the form GetEntry*) are now public.
1445 - Clean up of undefined or unused methods.
1446 * src/gdcmDocument.cxx:
1447 - adaptation to changes to gdcmDocument.h
1448 - ::OpenFile now writes a verbose message when file cannot be opened.
1449 - some std::string properly set to VRKey
1450 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1451 references to gdcmDocument.
1452 * Test/TestFindTags.cxx: changed accordingly to above changes.
1453 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1454 cvs repository gdcmData.
1456 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1458 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1459 conflicts with gdcmValEntry::voidArea.
1460 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1461 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1462 Value representation between StringRepresentable and BinaryRepresentable.
1463 * src/gdcmDocument.cxx:
1464 - method ParseDES: proper indentation restored and usage of
1465 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1466 - method LoadDocEntry: the fingerprint left in the SetValue() of
1467 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1468 removed. Reverting to previous code segment with the proper
1469 dynamic_cast< gdcmValEntry* >.
1470 Note: this was (partially) breaking the python test suite
1471 (gdcmPython/testSuite.py) that made usage of the above
1472 fingerprint to check presence of "Pixel Data".
1473 * src/gdcmDocEntry.h: coding style.
1474 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1475 now taken into account.
1476 * gdcmPython/gdcm.i: adaptation to the new internal representation
1477 of gdcm (exit gdcmParser, hello gdcmDocument).
1478 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1480 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1481 anymore, but instead prints the loaded Python dictionary.
1482 * .... alas, the python testSuite is still broken.
1484 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1485 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1487 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1488 * src/gdcmUtil.h : export methods
1490 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1491 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1493 * Initial addition of automatic python testing
1494 * Initial addition of automatic image comparison
1496 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1497 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1498 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1500 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1502 * Test/ShowDicom.cxx : bug fix for msvc compilation
1503 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1505 2004-05-04 Jean-Pierre Roux
1506 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1507 new concepts (and new classes) :
1508 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1509 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1510 - Sequence Doc Entries (gdcmSeqEntries)
1511 a Sequence is composed of Items.
1512 Each item is a set of Doc Entries (this is recursive)
1513 The non uniqueness of the 'Dicom tag' is due to this recursivity
1514 (never taken into account)
1515 Our unability to add a new 'entry' in the header
1516 at the proper location (neither in the H-Table (map or multimap),
1517 nor in the Chained List is also due to this recursivity.
1518 Don't try, right now, to use/modify/compile these new sources :
1519 nothing is finished.
1520 We just commit all the stuff, 'as is', in order not to loose it.
1522 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1523 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1525 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1526 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1527 file prefix (SetFilePrefix)
1529 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1530 * Add a new test: ShowDicom, for now this is just the c++ version of
1531 checkRead.sh, later it will be able to compare the image read against a
1533 * Replace the DEBUG on the stack with a global entry in cmake interface:
1534 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1536 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * Add an example subdir, with a real example on how to read + write a
1540 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1541 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1542 * Doc/CMakeLists.txt: the main page is now properly differentiated
1543 between the developper and user version.
1544 * Doc/doxygen.config.in: dropped search related obsolete flags
1545 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1547 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1548 * DEVELOPPER: added some helpfull comments for compile/test/install
1551 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1552 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1553 src directory, now generated in the build dir.
1554 2. Tests as mentionned smarter
1556 4. Add a new method in gdcmDict that return the PubDict by name
1557 this is interesting for 3rd party lib like ITK,
1558 where we could set the institution name / patient name...
1560 * ENH: 1. Now the test suite is working for real
1561 2. All binaries are now output in the gdcm-bin directory
1562 (this was not true before)
1564 2004-04-28 Jean-Pierre Roux
1565 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1566 SeQuence indented printing of Dicom Header.
1567 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1568 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1569 Computation of SQDepthLevel is now part of gdcmHeader constructor
1570 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1571 tree-like structure of a Dicom Header.
1572 * FIX Test code cleaning
1574 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1575 * ENH: Adding automatic testing
1576 1. Need a DartConfig.cmake to submit to public
1577 2. Add a test driver gdcmTest.cxx
1578 3. gdcmTestMain, an helper for the main test driver gdcmTest
1579 4. Files in Test don't have a main anymore, this becomes interesting
1580 when we add more and more tests, thus dsw don't have to load
1582 * ENH: Adding a GDCM_DATA_ROOT for testing
1583 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1584 one file instead of seven + some small cleanup
1586 2004-04-22 Jean-Pierre Roux
1587 * ENH Minor changes to the Print() methods.
1588 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1589 Header printing. Example given with :
1590 > PrintHeader fileName 2 new
1591 (SQ based tree-like structure still to be done for the Header ...)
1593 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1594 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1595 1. I have added some unsigned where needed
1596 2. Some function parameter not used -> (void)
1597 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1598 4. g++ don't like character '\' in comment
1599 5. #define jpeg_create_decompress jCreaDecompress
1600 this really need to be fixed
1601 6. virtualize destructor of gdcmObject ... leakage
1602 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1603 this also really need to be fixed
1604 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1605 remove compression file
1606 (as we only do decompression, right ?)
1607 * ENH: Change malloc/calloc/free with c++ equivalent
1609 2004-04-21 Jean-Pierre Roux
1610 * FIX gdcmHeaderHelper::GetXSpacing
1611 when a single value is found (bug ?), xpacing is now
1612 defaulted to yspacing
1614 2004-04-19 Jean-Pierre Roux
1615 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1616 * ENH add parameters :
1617 bool exception_on_error = false,
1618 bool enable_sequences = false,
1619 bool ignore_shadow = false
1620 to the gdcmFile constructors to be full gdcmParser compliant
1621 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1622 to allow reading of PAPYRUS 3.0 files
1624 2004-04-06 Jean-Pierre Roux
1625 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1627 2004-04-02 Jean-Pierre Roux
1628 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1629 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1630 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1632 2004-03-30 Jean-Pierre Roux
1633 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1634 for ACR file, written out as DICOM files (hope so...)
1636 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1637 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1638 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1639 moved to base class gdcmParser and only the specialisation is kept
1641 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1642 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1643 already does the job.
1644 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1645 (to be consistent with gdcmParser::WriteEntries).
1647 2004-03-30 Benoit Regrain
1648 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1649 upate of the object's instance. It's passed to 2 in the unfavorable
1650 case : one in the ExecuteInformation, one in the ExecuteData
1652 2004-03-29 Jean-Pierre Roux
1653 * ENH : Check on file type to be written moved
1654 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1655 * FIX : gdcmObject::ResetBoundaries now stops properly
1656 when end-of-list is reached
1657 : gdcmVersion modified (as Benoit Regrain asked)
1659 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1661 * src/gdcmUtil.cxx: added forgotten iostream include.
1662 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1663 equivalent to ExplicitVR in existing code).
1665 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1667 now contains all the gdcmGlobal related code.
1668 * minor coding style and doxygenation changes.
1670 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1672 now contains all the Debug related code.
1673 * minor clean-up of includes in src/*.cxx
1674 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1675 CreateCleanString) removed.
1676 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1677 * Doc/DoxyMainPageUser.txt added.
1678 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1679 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1680 src/gdcmDirList.cxx)
1682 2004-03-24 Jean-Pierre Roux
1683 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1685 2004-03-23 Jean-Pierre Roux
1686 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1687 big endian made volumes
1688 * ENH Now gdcmParser constructor and destructor are protected to forbid
1689 end user to instanciate class gdcmParser
1690 (only gdcmHeader and gdcmDicomDir are meaningfull)
1692 2004-03-22 Benoit Regrain
1693 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1694 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1695 gdcmSerie to gdcmDicomDirSerie
1697 2004-03-19 Jean-Pierre Roux
1698 * ENH Now the tree-like structure describing a DICOMDIR comming from
1699 an already existing DICOMDIR file is consistent with
1700 the home-made tree-like structure build ex-nihilo
1701 or build from the files held (recursively) in a Directory
1702 functions gdcmDicomDir::CheckBoundaries()
1703 gdcmObject::SetBoundaries() added
1705 2004-03-17 Jean-Pierre Roux
1706 * REM (Eric Boix bug) : removal of meaningless
1707 gdcmDicomDirImage::NewImage function.
1708 * FIX now file names and directory name are written properly in the
1710 * FIX now gdcmDicomDir constructor may be call without any trick
1713 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1715 of gdcmDicomDirImage::NewImage as empty function.
1717 2004-02-28 Jean-Pierre Roux
1718 * ENH add gdcmDicomDir:NewPatient
1719 add gdcmDicomDirPatient:NewStudy
1720 add gdcmDicomDirStudy:NewSerie
1721 add gdcmDicomDirSerie:NewImage
1722 to allow making gdcDicomDir object.
1723 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1724 (as opposite to the gdcmHeader chained list)
1726 2004-02-11 Benoit Regrain
1727 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1728 when using from python
1730 2004-02-10 Benoit Regrain
1731 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1732 * FIX : in gdcmDicomDir when the directory is empty
1733 * ENH : add callback and methods to get the progression of dicomDir
1736 2004-02-06 Jean-Pierre Roux
1737 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1738 - GDCM_META added to gdcmDicomDirType
1739 - class gdcmMeta created
1740 * ENH : - A brief summary is now displayed at the beginning of
1741 'testDicomDir' to help disaster magnitude estimation
1742 * REM : Now useless Test/explDICOMDIR.cxx
1744 2004-02-05 Benoit Regrain
1745 * ENH : add methods in gdcmObject to get the hash table or the list of
1747 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1748 * FIX : wrapping python for TagHeaderEntryHT
1750 2004-02-04 Benoit Regrain
1751 * FIX : even length for some strings when writting the dicom dir
1752 * FIX : sort the images in the dicom dir
1753 * FIX : Bug fix for python use of dicom dir
1754 * ADD : a python demo
1756 2004-02-04 Jean-Pierre Roux
1757 * FIX : Final solution (?) for icone embedded images
1758 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1759 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1760 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1761 gdcmData/gdcm-MR-SIEMENS-16.acr1
1762 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1763 to make full checking easier
1765 2004-02-04 Benoit Regrain
1766 * FIX : WriteEntries : coding style & logic in parameters
1767 * FIX : Set the elements to create the DicomDir in a dictionary file
1769 2004-02-03 Benoit Regrain
1770 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1771 * gdcmDicomDir : add the load of directory
1772 * Bug fix and print add-on
1774 2004-02-03 Jean-Pierre Roux
1775 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1776 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1777 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1778 * FIX gdcmParser.cxx : 'group length' elements are now considered
1779 as integers, even for shadow groups, when file is Implicit VR
1781 2004-02-02 Jean-Pierre Roux
1782 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1784 of the last synonym :-(
1785 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1787 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1788 * FIX taking into account the possible 7fe0,0010 multiplicity
1789 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1790 to allow removal of references to 7fe0,0010, to deal with
1791 ACR-NEMA images, when 0028,0200 is meaningfull
1793 2004-01-31 Jean-Pierre Roux
1794 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1795 no longer writes 'Un' on disk
1796 * FIX SQ elements with actual length are now dealt with corectly
1797 * FIX gdcmFile::WriteBase make the difference, for color images, between
1798 the length (for Palette expanded images)
1799 and Raw Length (non expanded image + Palette)
1800 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1801 (that broke Write). Replaced by UL.
1802 Aware user will reload the field if he
1803 thinks it's necesssary
1805 2004-01-30 Jean-Pierre Roux
1806 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1807 when 'dirty Acr' is found, to be compliant with the new
1808 IsReadable() methods.
1810 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1811 (no DOUBLE images in kosher DICOM,
1812 but so usefull for people that miss them ;-)
1814 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1815 DICOMDIR related utilities (not checked as Windoze compliant)
1817 2004-01-28 Jean-Pierre Roux
1818 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1820 2004-01-27 Jean-Pierre Roux
1821 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1822 to allow skipping the shadow elements, to save memory space.
1823 The TRUE value for this param has to be used
1824 with a FALSE value for the 'enable_sequence' param.
1825 ('public elements' may be embedded in 'shadow Sequences')
1826 * gdcmHeader methods now deal with 'embedded icones images' in the header
1827 (even when an 'icone image sequence' is announced by the
1828 element (0x0088,0x0200), but there is NO icone at all ...
1830 * gdcmHeader sometimes Image Location value doesn't follow
1831 the supposed processor endianity (see gdcmData/cr172241.dcm).
1834 * gdcmHeader add the method
1835 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1836 to get *all* the Header Entries with the same tag.
1837 GetHeaderEntrySameName is probabely *useless*
1838 (no meaning : Name is *not* an identifier within the Dictionnary)
1840 2004-01-26 Benoit Regrain
1841 * Bug fix in the print of hexadecimal representations. Remove long fields
1842 in the print and add a third level of print to print them
1844 2004-01-23 Benoit Regrain
1845 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1846 * Bug fix on test suite after remove the strip made on not string fields
1847 * Split the IsReadable method between gdcmParser which test that the file
1848 is dicom and gdcmHeader which test that it's an image file
1850 2004-01-22 Benoit Regrain
1851 * DicomDir : clean code, add methods, set variables in protected or private
1852 * gdcmUtil : bug fix for the clean string method
1854 2004-01-19 Benoit Regrain
1855 * Add the use of shadow dictionaries
1856 * bug fix and coding style
1858 2004-01-19 Benoit Regrain
1859 * src/gdcmFile.cxx : bug fix concerning the close of file
1860 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1861 * Add the update of header entries using the shadow library
1863 2004-01-19 Benoit Regrain
1864 * removal of file gdcmHeader2.cxx
1865 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1866 inheriting from gdcmParser. This split is to prepare the integration
1867 of dicom dir parsing
1868 * bug fix under python
1870 2004-01-16 Jean-Pierre Roux
1871 * REM removal of class gdcmHeaderEntrySet
1872 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1873 * ADD add file gdcmHeader2.cxx
1874 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1876 2004-01-15 Benoit Regrain
1877 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1878 entries created while parsing the header. Thus, they will be destroyed
1879 when the gdcmDictSet will be destroyed
1880 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1883 2004-01-15 Benoit Regrain
1884 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1885 made a fatal error because of the memory release at the end of program.
1886 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1887 some memory and vtk seems to have some problems with that.
1888 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1890 2004-01-14 Benoit Regrain
1891 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1892 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1893 * src/*.[h|cxx] : make changes due to class name changes
1894 * gdcmPython/demo/*.py : bug fix due to method names
1896 2004-01-13 Benoit Regrain
1897 * src/*.[h|cxx] : coding style
1898 * vtk/*.[h|cxx] : coding style
1900 2004-01-13 Benoit Regrain
1901 * gdcmPython/testSuite.py : test the readable flag of file for tests
1902 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1903 It's lied to the stl compilation by MSVC (windows, always windows...)
1904 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1906 2004-01-12 Benoit Regrain
1907 * src/*.h : add comments
1908 * src/gdcmDictSet.h : set the method BuildDictPath in public
1909 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1910 directly setted in the source code
1911 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1914 2004-01-09 Benoit Regrain
1915 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1916 * setup.py : use a reference to gdcmVERSION
1918 2004-01-07 Benoit Regrain
1919 * Modification to compile with the distutils.
1922 2003-12-10 Benoit Regrain
1923 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1924 can use a gdcmHeaderHelper to load data
1925 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1926 made in the source code
1928 2003-12-10 Benoit Regrain
1929 * Update Windows projects and .cvsignore files
1931 2003-11-12 Jean-Pierre Roux
1932 * ENH gdcmHeader constructor has one more parameter (default value : false)
1933 that allows the user to 'go inside' the SeQuences only
1935 gdcmElValSet:Print takes it into account
1937 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1938 * ENH: Update gdcmPython/CMakeLists
1939 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1940 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1942 2003-11-10 Jean-Pierre Roux
1943 * FIX : gdcmHeader::LoadElements is now based
1944 on the ListTag listElem member,
1945 not longer on the TagElValueHT tagHt member
1946 * ENH : PrintPubElVal shows (temporarily) both results,
1947 with the tagHt member and the listElem member.
1948 (it's easier to 'see' the problems when using Printheader)
1950 * FIX : old private member LgrElem is now splitted into
1951 ReadLength : Length actually found on disk (updated only
1952 if bug fixing is necessary), for internal
1954 UsableLength : Updated by FixFoundLength, to fix a bug
1955 or to allow Parser going on.
1956 Will allow to re-write a kosher header when a SeQuence
1957 with a length (not 0000) is found
1958 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1959 because gdcmElValSet::Add does not update ListElem
1962 2003-11-07 Jean-Pierre Roux
1963 * FIX misstyping in Transfert Syntax name table
1964 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1965 when they have an actual length (not 0000 nor FFFFF)
1966 (Nobody should care of it, but DICOMDIR explorers)
1968 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1971 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1972 * ENH: vtkGdcmReader now supports LUT !
1973 (vtkgdcmViewer for now is not able to use them though)
1975 2003-11-05 Jean-Pierre Roux
1976 * in testSuite.py : new files names for checking the package
1977 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1978 that returns the pixel area size to the *aware* (vtk) user
1979 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1981 2003-11-05 Benoit Regrain
1982 * in testSuite.py : Modify the rules for checking the paths
1983 : Explicit error messages
1984 * in __init__.py : Related modif
1986 2003-11-03 Jean-Pierre Roux
1987 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1988 to be used by aware (vtk) users that want to manage
1989 LUT (and no to turn the PALETTE image into an RGB pixels one)
1990 * GetPixelType now returns 8U for 24 Bits images
1991 (vtkGdcmReader compliant)
1993 2003-10-31 Jean-Pierre Roux
1994 * Removal of *all* gdcmData images and add them again
1995 in order to loose the 'history' of un-anonymised images
1997 2003-10-31 Jean-Pierre Roux
1998 * RMV : removal of useless jBitsInJsample.h
1999 for both 8 and 12 Bits JPEG Lossy Libraries
2001 2003-10-31 Jean-Pierre Roux
2002 * ENH : Add the functions gdcmFile::GetImageDataRaw
2003 gdcmFile::GetImageDataIntoVectorRaw
2004 that act as GetImageData and GetImageDataIntoVector
2005 except the making of an RGB Plane from Gray Plane + LUT
2006 Intended to aware (vtk) users who know how to manage
2009 GetLUTRGBA return a R,G,B,A LUT if any
2010 lgrTotaleRaw gives the 'Raw' length
2011 GetImageDataRaw returns the gray Plane
2012 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2013 (They stay Grey, just like with other Dicom viewers :-(
2015 2003-10-30 Jean-Pierre Roux
2016 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2018 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2019 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2020 being coherents dicom files.
2022 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2023 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2025 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2026 * ENH: Two steps is necessary to please VC++ compiler...
2027 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2028 * ENH: Add include dir to medcon lib
2029 * FIX: only one function is being exported for now !
2030 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2032 2003-10-29 Jean-Pierre Roux
2033 * adding gdcmHeader::GetLUTRGBA
2034 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2035 --> Mathieu, the modif u're waiting for is not yet committed
2036 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2038 2003-10-27 Jean-Pierre Roux
2039 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2040 00191113.dcm DermaColorLossLess.dcm
2041 MxTwinLossLess.dcm RadBWLossLess.dcm
2042 * ENH: For version prior to vtkImageViewer2 -r 1.19
2043 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2045 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * Removal of ido stuff in CMakeLists.txt
2048 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2049 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2050 * FIX: remove a call to ->Modified ... see comments
2051 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2053 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * FIX: Problem with path for libvtkgdcmPython
2055 * ENH: Try adding a search script for python site-package
2056 * RMV: Remove some file from medcon lib that are not necessary
2057 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2058 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2059 * FIX: More pragma disable fro VC++,
2060 I don't think I break something as it is also disable in VTK/ITK.
2061 But it fasten debug compilation time.
2063 2003-10-23 Jean-Pierre Roux
2064 * gdcm now deals with 16 Bits Run Length Encoded images
2065 (they are compressed as 2 planes images,
2066 one for the high Bytes, the other for low Bytes)
2068 2003-10-22 Jean-Pierre Roux
2069 * Now CheckRead takes into account :
2070 - the bugged 'Leonardo' Siemens images
2071 - the XA images, sent thru the burning VPRO station
2072 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2075 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * FIX: When copying a Makefile.am to CMakeLists.txt
2077 one should remove the '\'
2079 2003-10-22 Jean-Pierre Roux
2080 * in gdcmData adding a bugged 'Leonardo' Siemens image
2081 (wrong lengths in header)
2082 OK with gdcm, KO with the other viewers :-)
2083 * add a GE dlx XA image, thru the VEPRO burning station
2086 2003-10-21 Jean-Pierre Roux
2087 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2088 for a brutal checking of vtkgdcmViewer compliance
2090 2003-10-21 Jean-Pierre Roux
2091 * add the files for 'xmedcon' Jpeg Lossless library
2092 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2094 2003-10-21 Jean-Pierre Roux
2095 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2097 2003-10-21 Jean-Pierre Roux
2098 * garbage Siemens 'Leonardo' images dealt with
2099 (the patch is easy to remove)
2100 * cosmetic changes to avoid warnings
2102 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2103 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2104 no need to press 'r' now.
2106 2003-10-20 Jean-Pierre Roux
2107 * upgrade of checkRead.sh checkWrite.sh according
2108 to new Jpeg Lossless decompressor
2109 * add US.3405.1.dcm, a genuine RGB medical file ...
2110 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2111 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2113 2003-10-15 Jean-Pierre Roux
2114 * general anonymisation in gdcmData
2115 * adding the 'color files' from
2116 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2117 * adding some well knowed bugged-header images
2118 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2119 waiting for their inclusion in Python testsuite
2121 2003-10-15 Jean-Pierre Roux
2122 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2123 no longer seg faults when file is not found
2125 2003-10-14 Jean-Pierre Roux
2126 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2129 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * TODO: *.in file to genereate a UseGDCM later
2132 2003-10-14 Jean-Pierre Roux
2133 * Some supposed-to-be Dicom Images have no preamble.
2134 OpenFile takes it into account
2135 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2136 * Missing elements added in dicomV3.dic
2137 (just to be affraid : have a look at
2138 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2139 and do it again next year ;->
2141 2003-10-13 Jean-Pierre Roux
2142 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2143 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2144 But there are NOT. It's fixed !
2146 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2147 * FIX: "jpeglib.h" was not found on VC++
2148 * FIX: vtkgdcm was not being installed
2150 2003-10-10 Jean-Pierre Roux
2151 * ENH : OpenFile closes the file if it *really* doesn't look like
2152 an ACR-NEMA / DICOM one.
2153 * FIX : testWrite no longer writes an empty file if the source file
2154 is not gdcm Readable
2155 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2158 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2159 * FIX: CMake generate now documentation
2160 * ENH: out of source doc build !
2161 * ENH: Generate both user and dev documentation
2162 * ENH: Should work on windows too
2163 * ENH: Only one doxygen config.in file is needed
2164 * FIX: make install should be ok now on ùnix plateform
2165 * FIX: PATH to dictionary was wrong (missing /)
2166 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2168 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2169 * vtkGdcmReader is now able to read rgb dicom file.
2170 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2171 * added a gdcmViewer to vtk test, use mouse to control
2172 window level & window width
2174 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * CMake-ification of gdcm, we have now two build system
2176 * FIX: on cygwin Wsock32 doesn't exist
2177 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2179 2003-10-06 Emanuel Ollart
2180 * FIX : compilation process wad broken.
2181 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2183 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2184 * change gdcmViewer -> vtkgdcmViewer
2185 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2187 2003-10-06 Jean-Pierre Roux
2188 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2189 ( e.g : well known GE images with a wrong elem length,
2190 : Philips MRI Images with a wrong Huffman table)
2191 * still to be done : allow the reading of bugged LEONARDO Siemens images
2193 2003-10-03 Jean-Pierre Roux
2194 * Odd length strings are padded with '\0' (not with spaces,
2195 to remain compliant with already defined strings,
2196 like Transfert Syntax UID and others)
2198 2003-10-03 Jean-Pierre Roux
2199 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2200 to allow displaying RGB images (not only by affim ;-)
2202 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2203 * vtkGdcmReader is now able to read rgb dicom file.
2204 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2206 2003-10-03 Jean-Pierre Roux
2207 * A few nasty patches to allow the reading of a lot of nasty images
2208 ( e.g : well known GE images with a wrong elem length,
2209 : Philips MRI Images with a wrong Huffman table)
2210 * still to be done : allow the reading of bugged LEONARDO Siemens images
2212 2003-10-03 Jean-Pierre Roux
2213 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2215 2003-10-03 Jean-Pierre Roux
2216 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2217 to allow displaying RGB images (not only by affim ;-)
2219 2003-10-03 Jean-Pierre Roux
2220 * gdcmFile::GetImageDataIntoVector now
2221 - deals with MultiFrames MultiFragments Run Length Encoded files
2222 - deals with YcBcR (YBR_FULL) files
2223 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2224 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2226 (no sample found :-(
2228 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2230 Two reasons: - clear things
2231 - third parties acces gdcm through header files, so won't
2232 suffer anymore VC++ complains
2234 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * add argv[1] in testvtkGdcmReader.cxx
2238 2003-09-24 Jean-Pierre Roux
2239 * The lines are now eigthy characters long.for
2240 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2242 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2243 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2244 char* to std::string. Thus, the use of strdup becomes useless. (see
2245 previous commis of Malaterre)
2246 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2247 before the last Malaterre's commit.
2249 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * This commit should fix the Debug building under VC++, the problem
2251 was mainly a mixture of debug and release lib being loaded at startup.
2252 * I also remove a depency to a specific C function: strdup. Because I had
2253 to force the link to msvcrtd (whereas strdup is in libc).
2255 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2256 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2257 located in the gdcmCommon.h file. All use of reference of tha has been
2258 changed to now use the variable GDCM_UNFOUND.
2260 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2262 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2263 Dicom dictionary. The test suite can now be run again. Note:
2264 I'm note very happy with the " (RET)" changes. I believe this
2265 RETAINED comment should be dropped when parsing the dictionary.
2266 - PACKAGER corrected
2268 - AUTHORS updated and now in alphabetical order
2269 * Makefile.am now exports gdcm.dsw for Windoze users.
2271 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * cygwin complains about missing std:: in subdir Test/
2274 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * remove some methods that are now in gdcmHeaderHelper
2277 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * vtkGdcmReader set spacing and origin correctly
2280 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * Fix a few delete/delete[] mismatch
2283 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2285 interpretation to data given by gdcmHeader. For instance there are
2286 heuristics to get informations (look at different places).
2287 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2288 sorting DICOM images based on different strategies.
2289 * modified Makefiles accordingly.
2291 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2292 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2293 when building in debug mode
2294 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2295 src/win32/gdcmdll.dsp
2296 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2298 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2299 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2302 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * src/win32/libgdcmjpeg12.dsp was not dos format
2304 * src/win32/libgdcmjpeg12.dsp :
2305 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2306 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2308 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2309 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2311 * src/gdcmFile.cxx : bug fix in affectation type
2312 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2313 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2314 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2315 symbols... future problem ?
2317 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2318 * src/win32/libgdcmijpeg12.dsp was missing
2319 * modified gdcm.dsw accordingly
2321 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2322 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2324 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2325 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2326 commit of JPR (before his hollidays to facilitate our work).
2327 * setup.py : bug fix in code. Modifications made while the last commit
2328 of JPR. The code hasn't been tested before the commit... it's so
2329 useless to make that (for best programmer that is JPR) !!!
2331 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * tagged the current version as Version0_3 (i.e. version 0.3)
2334 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2335 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2336 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2337 * *.dsp : modifications to use new libgdcmijpeg8 library
2338 * setup.py : bug fix on VTKPATH variable
2339 * PACKAGER : adding all concerning windows
2341 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2344 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2345 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2346 test suite reported error.
2347 * PACKAGER file added (describes what a packager must do when
2348 packaging a new release).
2349 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2350 * configure.in: upgraded version number to 0.3.0
2351 * fixing build of rpm (through rpm -ta):
2352 - Doc/Makefile.am exports proper doxygen files
2353 - src/jpeg/libijg8/Makefile.am exports the include files.
2355 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2356 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2357 * src/gdcmHeader.h : formatting code
2359 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2360 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2361 We were obtaining error message from vtk. Now, creation of file list
2362 is made in an internal list to prevent this problem.
2363 Bug fix when output is empty.
2364 Bug fix in update of progress value. Previous commit for this was a bad
2366 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2368 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2369 * src/gdcmHeader.h : added method to get the file name
2370 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2371 files. Added method to remove all files on the input
2372 Added FIXME comment concerning the bad parsing of header made by
2373 ExecuteInformation method (in ExecuteData method)
2375 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2376 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2377 when using make instal.
2378 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2379 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2381 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2382 * setup.py : adding include dir of jpeg lib to compile all sources
2383 * */Win32/*.dsp : JPR fix for windows compilation
2385 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2386 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2388 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2389 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2391 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * setup.py is again effective on un*x (takes into account the
2393 addon of the jpeg library)
2394 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2395 * Doc/Doxy* updated (includes above enhancements)
2396 * INSTALL now points to web documentation
2398 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * src/gdcmHeader.h doesn't make unnecessary reference to
2401 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2403 * src/gdcm*.[cxx|h] :
2404 - to allow compilation with gcc 3.x
2405 -- clean up of STL usage (added explicit usage of std::)
2406 -- small fixes on exceptions.
2407 Note: linking not tested !
2408 - clean of doxygen comments to avoid warnings at documentation
2410 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2411 dependent convertion).
2413 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * Clean up of previous JPR garbage commit (not even commented in the
2416 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2417 - moved all jpeg related files from src to src/jpeg/libijg8, with
2418 addition/modification of Makefile.am and configure.in.
2419 - the testSuite is still brain damage (not guilty).
2421 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2422 * WrapVTK.py : modifications to get correctly vtk source files to
2424 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2425 (FileName -> Filename)
2427 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2428 * vtk/vtkGdcmReader.[cxx/h]:
2429 - UpdateProgress method should now be effective
2430 - removed the limitation on having only images loaded (as opposed
2432 - when building a stack of images/volume, a lesser number of
2433 gdcmHeader and gdcmFile instances should be used (hopefully
2434 accelerating things).
2435 - when building a stack of images/volumes, files which are not
2436 loadable (wrong path-filename, wrong permissions on existing file,
2437 or file not parsable by gdcm) are replaced with a black image
2438 in the stack (for the caller to notice the problem).
2440 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2443 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2444 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2445 between standard library (std) and vtk library (problems are found
2446 under Windows... thanks Windows !)
2448 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2451 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2453 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2456 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * When compiling with distutils (see setup.py) the C++ compiler is
2458 called with different flags than the default ones (with automake).
2459 In order to fix all those warning, I compiled gdcm with the command
2460 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2461 and went for warning fixes:
2462 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2463 up from unused variables.
2464 - vtk/vtkGdcmReader.cxx: potential bug fix.
2465 * src/gdcmHeader.h: Doxygen warning cleanup
2467 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * gdcmPython/gdcm.i:
2469 - typemaps correction to take into account the systematic replacement
2470 of "using namespace std" with std:: prefix e.g. std::list,
2471 std::string... (cf changes of 2003-05-21).
2472 - gdcmGlob global variable of type gdcmGlobal (defined in
2473 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2474 exported to Python a as cvar.
2475 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2476 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2477 gdcmDictSet.GetPubDictTagNames() and
2478 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2479 C++ static methods).
2480 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2481 with the above changes.
2483 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2484 * setup.py, manifest.in : bug fix under linux
2486 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2487 * Modification of setup.py to compile vtk part too. Then, we have 2
2488 wrappers which must work with same distutils. For that, we have a
2489 generic distutils in distusiltsWrapping.py ; with :
2490 - build_extWrap class to wrap generically all extensions,
2491 - ExtensionWrap base class for all wrapping extension that contains
2493 - Wrapper interface which wrap sources
2494 + In WrapSwig.py we have extension and wrapper for Swig
2495 + In WrapVTK.py we have extension and wrapper for VTK
2496 * MANIFEST.in : modifications to consider vtk directory and new python
2497 files for compilation
2499 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2500 * Added python wrappers of vtkGdcmReader vtk class (see the
2501 source in vtk/vtkGdcmReader.cxx) :
2502 - vtk/Makefile.am now builds a library
2503 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2504 python library (as opposed to _gdcm.so wich are the python
2505 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2506 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2508 - configure.in has an additional flag --enable-vtk that needs
2509 to be set to enable compilation of vtk related code, that is:
2510 + vtk/vtkGdcmReader.so and
2511 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2512 + gdcmPython/vtkgdcmPython.so (see above)
2513 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2514 be read when compressed or when HighBit + 1 != BitsStored),
2515 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2516 the usage of the python wrapper of vtkGdcmReader vtk class.
2517 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2518 * src/*.[h] all occurences of stl classes are now prefixed with
2519 std::, and all occurences of "using namespace std;" where removed.
2520 This is to avoid pollution of global namespace in included files.
2521 Apparently vtk does not avoid this pitfall: when using both
2522 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2523 collision of various stl members (principally cout...).
2524 * gdcmPython/testSuite.py now cleanly removes temprory generated
2526 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2527 comply with above changes)
2529 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2530 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2531 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2532 vtk data structure (an image Flip was required).
2533 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2534 * cosmetic changes in documentation.
2536 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2537 * src/gdcmHeader.cxx: the constructor no longer exits when an
2538 unexisting file is given as argument.
2539 * The subdirectory Data (containing all the images used for the
2540 test suite) is not part of this repository anymore. A new module
2541 containing those images is now available at
2542 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2543 with the name gdcmData.
2544 All the python scripts (including the package initialisation file
2545 gdcmPython/__init__.py) were adapated to take this change into
2546 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2548 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2549 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2550 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2551 demo of the usage of this class.
2552 Compilation of this vtk part is only done when using the --enable-vtk
2553 at configure (or autogen.sh) stage.
2555 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2556 * More memory link related corrections and documentation fixes.
2558 - maximum info is obtained with a command of the form:
2559 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2560 --show-reachable=yes PrintHeader
2561 - the remaining reachable blocks seem to come from the STL
2562 allocation scheme through the usage of map and list. It looks
2563 like this memory cannot be freed but it is not a memory leak
2564 (in fact further invocation to the STL would recollect the
2565 unused memory allthough it cannot explicitely be freed).
2566 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2567 of displaying an image parsed with gdcm and displayed with VTK.
2568 Note: some images don't seem to work e.g.
2569 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2570 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2571 Allthough this weakens the semantics, it is a ditch attempt to
2572 make gdcm more thread friendly.
2574 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2575 * Memory link hunt (by using valgrind through the command
2576 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2577 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2578 gdcmHeader::_dicom_vr.
2579 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2580 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2582 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2584 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2585 * src/Makefile.am now exports all the necessary include files at
2589 * UpdateGroupLength replaced by new one
2592 * UpdateGroupLength re-written using H-Table
2593 (named UpdateGroupLengthNew untill checks are over)
2595 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2596 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2597 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2599 - gdcmHeader::GetPubElValSet removed.
2600 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2601 UpdateGroupLength, WriteElements, Write.
2602 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2603 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2604 carried the same semantics.
2605 - src/gdcmHeaderIdo.cxx changed accordingly.
2606 - gdcmFile::WriteBase now regroups all the codes from previous
2607 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2608 - enum FileType moved to gdcmCommon.h
2609 * src/gdcmHeader.cxx AddDefault trashed
2610 * gdcmGetXSize added
2611 * getimageDataSize now calls gdcmGetXSize
2612 * Test/*.cxx changed to agree with above changes
2614 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2616 (to avoid double call by end user).
2617 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2618 by end user, since gdcmHeader::gdcmHeader now handles it.
2620 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2621 * gdcm/Doc many doxygen changes:
2622 - Doxyfile now has two different versions, DoxyfileUsers that generates
2623 the html.users end users oriented documentation and
2624 DoxyfileDeveloppers that generates the html.developper developper
2625 oriented documentation.
2626 - README changed accordingly
2627 - requirement.txt removed (old design info moved to TODO).
2628 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2629 DoxyMainPage.txt, DoxyPython.txt provide more information.
2630 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2631 be updated by simply regenerating the docs with doxygen and copying
2632 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2633 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2634 all the tests in the form "if (<map>.count() >1)" were removed.
2635 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2636 ill-formed documentation sections.
2637 * src/gdcmHeader.cxx: ditto
2639 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * setup.py fixed for un*x (needed macro for stdint.h)
2641 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2642 un*ces with sh-utils test utility.
2643 * gdcmPython/demo/test.py renamed to PrintHeader.py
2644 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2645 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2646 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2647 * src/gdcm*.cxx JPR's bad inclusion fixed.
2649 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2651 * gdcmPython/demo/test.py changed accordingly.
2653 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * gdcmPython/Makefile.am fixed linking against libstdc++
2655 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2656 * Swig subdir (historical tests of swig version 1.3.17++) removed
2657 * Test/testChangeEntete.cxx some lines commented out in order to make
2659 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2660 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2662 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2664 hence the user doesn't need this explicit call.
2665 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2666 i.e. LoadElements() call removed.
2667 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2668 - src/Makefile.am declares the proper flag for g++.
2669 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2670 for adding user defined new tags.
2671 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2672 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2673 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2675 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2676 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2677 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2678 src/Makefile.am : the project should properly compile and install
2679 with the autotools, included the python wrappers part.
2680 * gdcm.spec.in : added a spec file for RPM packaging.
2682 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2683 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2685 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2687 to exported to the environement (see gdcmPython/testSuite.py
2689 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2690 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2691 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2692 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2693 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2695 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * gdcmPython/__init__.py doesn't crash anymore when running in
2697 in InstallMode or PreInstallMode but with an environement given
2698 value of GDCM_DICT_PATH.
2699 * src/gdcmDictSet.[cxx/h] coding style.
2701 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2702 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2703 * src/gdcm.h general comments moved to TODO, and README
2704 * src/gdcm.h should now be seen as a user commodity (including it
2705 should suffice to fully use gdcm). It is nowhere including within
2706 any of the kernel files src/*.cxx and src/*.h.
2708 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2710 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2712 * src/gdcm*.cxx only include their corresponding include file
2713 (as opposed to gdcm.h)
2714 * gdcmPython/gdcm.i changed accordingly
2715 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2716 the autogen.sh generated "make snapshot" command to work.
2717 * autogen.sh removed history related references to crea package.
2719 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * distutilsSwigCPlusPlus.py work around some swig portability
2723 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2725 was done in a last ditch attempt to get setup.py _really_
2726 operationnal. The python/gdcmPython layaout add the advantage
2727 of hidding away the python related distutils specific files
2728 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2729 Alas, the src directory was out of scope (i.e. it's relative
2730 position to setup.py was ../src) which made things impossible to
2731 handle (see previous version of python/setup.py). Crossing fingers...
2733 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * python/setup.py now works on Un*x. (harder than I thougth)
2735 * python/distutilsSwigCPlusPlus.py can now have include files
2736 among the list of sources.
2738 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2739 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2740 * modifications in MSVC projects
2742 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * As stated by the first lines of Test/ExceptionAndPython/README, it
2744 looks like we can move back to original usage of exception within
2745 src/gdcm* and hence remove the errno stuff that was introduced
2746 as a quick and dirty fixture of this problem (added to the TODO).
2747 * Doc/Doxyfile configuration file for Doxygen and corresponding
2748 README file for usage added.
2749 * Test/testWrite.cxx added. This new test comes from a split of
2750 test.cxx that is now reverted to its original purpous i.e.
2751 testing the proper parsing of a Dicom related file.
2752 testWrite.cxx concentrates on testing the IO part of gdcm.
2753 * Test/bug1.cxx (containing a bug on WIn32) added.
2754 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2755 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2756 whose purpose is to publish the content of the TagNames of the
2757 Dicom public dictionnary were not accessible without an
2758 instance of class gdcmHeader.
2759 - those methods are now static methods of gdcmDictSet and hence
2760 require no instances at all to be invocated.
2761 - within gdcmDictSet this change required to change some method
2762 to class methods (i.e. are now static) among which SetDictPath
2763 (renamed to BuildDictPath) and LoadDefaultPubDict.
2764 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2765 the above changes by calling the new method classes of gdcmDictSet.
2766 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2767 the above to be effective.
2768 * python/gdcmPython: in order to wrap properly the above changes
2769 for Python, swig version now needs to be > 1.3.17.
2770 * python/gdcmPython/Makefile fixed to adapt itself to new
2771 configure/make shema introduced by Johan Montagnat (thanks for the
2772 contribution). Alas this Makefile cannot be turned into a proper
2773 Makefile.am without some heavy changes in the configure.in
2774 (for python dectection).
2775 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2776 now avoids publishing the empty entries.
2778 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2779 * python/setup.py : bug fix concerning install under windows
2780 ExtraPath reused :-P
2781 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2783 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2784 * Dicts/dicomV3.dic : remove double spaces !!!
2785 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2786 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2789 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2791 method. Doxygenation.
2792 * src/gdcm.h clean up of JPR spurious comments.
2794 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * python/distutilsSwigCPlusPlus.py now properly collects the
2796 shadow classes generated by "swig -c++" (gdcm.py in our case)
2797 when using "python setup.py install".
2798 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2799 reexports the working classes.
2800 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2801 by the classical C errno scheme. This is to prevent an obscure
2802 behavior of the python wrappers when importing wxPython.wx prior
2803 to gdcmPython (which ended up in an abort call). An illustration
2804 of this oddity can be found in the Test/ExceptionAndPython
2805 subdir (see the README file). This problem probably due to
2806 an combination of g++ and dynamic loading.
2807 * added Test/ExceptionAndPython (see above)
2809 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * Changed the layout of the python part to avoid bloating main
2811 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2812 i.e. the distutils arsenal. All the python related stuff is
2813 again in a python subdir, but the package itself is now in
2815 * setup.py was cleaned up:
2816 - pythonIncludePath removed
2817 - python setup.py bdist target is now functional.
2818 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2819 collision with other packages). gdcmPython/demo/*.py changed
2822 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * python subdir moved to gdcmPython (preparation of distutils packaging).
2824 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2825 distutils installer is operational.
2826 * - gdcmPython/__init__.py now properly loads the swig generated
2827 shadow classes (from gdcm.py).
2828 - gdcmPython/demo/*.py changed to import the package gdcmPython
2829 instead of gdcmPython/demo/load.py.
2830 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2832 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2834 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2835 entries within the associated public Dicom dictionary resp. the same
2836 information but sorted by the fourth field (PAT, IMG, DIR) of the
2838 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2839 are now in the "???" group.
2840 - python/gdcm.i changed accordingly,
2841 - python/demo/printGroupedPublicDict.py added, that gives an example
2842 of the above new functionalities in Python.
2844 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * src/gdcm.h, gdcmHeader.cxx:
2846 - historic references to glib's g_malloc and g_free (#defined)
2847 were definitively removed.
2848 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2849 * src/gdcmElValSet.cxx:
2850 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2851 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2852 - GetElValue(string) renamed to GetElValueByName.
2853 - Added GetElementByName(string).
2854 * src/gdcmHeader.cxx: added
2855 - GetPubElValRepByNumber(guint16, guint16)
2856 - GetPubElValRepByName(string)
2857 - GetShaElValRepByNumber(guint16, guint16)
2858 - GetShaElValRepByName(string)
2859 - GetShaElValByNumber(guint16, guint16)
2860 - GetShaElValRepByName(string)
2861 - GetElValRepByNumber(guint16, guint16)
2862 - GetElValRepByName(string)
2863 - GetElValByNumber(guint16, guint16)
2864 - GetElValRepByName(string)
2865 * Doc/requirements.txt added.
2867 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * Test/Makefile building now depends on the one of libgdcm.so
2869 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2870 pixel data) aware which enables finding the address (offset) of
2871 the pixel data of JPEG encoded DICOM files. This leaves only a single
2872 file in the testSuite whose pixel data address (offset) is unknown.
2873 * python/testSuite.py changed accordingly.
2875 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2876 * VC++ has some strong limitations when working with the STL, as stated
2877 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2878 "Also note that some STL containers (map, set, queue, list, deque)
2879 cannot be exported. [...]
2880 Some STL classes contain nested classes. These classes can not
2882 This is caused by a designed limitation that once a template
2883 class is instantiated, it can not be re-instantiated and
2885 Since our usage of map<> is ubiquitous in gdcm, this "designed
2886 limitation" of VC++ is a pitfall.
2887 Hence the Python wrappers of gdcm cannot be incrementally linked
2888 against the c++ dynamic library. The dirty but only workaround is
2889 to forget about incremental link of dynamic libraries and to generate
2890 the Python wrappers library with the inclusions of the underlying C++
2892 The following modifications concern this matter on Win32/VC++:
2893 - wrapping python correct with standalone wrapped dll (don't use separate
2894 dll under windows !!!!)
2895 - python21_d debug mode enabled (ask Frog how to use it :-)
2896 - NO problem with having an STL member of class for example string in C++
2897 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2898 - Python test of dcmlib in Python is ok under windows on a large set
2900 * removed glib references
2901 * typedef's inserted in gdcm.i for correct swig type management
2903 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * python/demo/*.py load.py extracted from test.py. Added explore.py
2905 that only displays required tags and testAll.py that parses all
2906 the files of the testsuite without using unittest.
2907 * python/testSuite.py other additional test on new files added.
2908 * Data/* new test files added accordingly to the testSuite.
2909 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2910 the vr in the file differs from the one of the dictionary.
2912 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2914 values, but limits itself to values which are below a user specified
2915 size (by default 1024 bytes).
2916 * python/gdcm.i : elements not loaded (because their size is above the
2917 user specified treshold) are exported with their TagKey as key of the
2918 python dictionary. This enables the testsuite to make some checks
2919 on the unloaded elements (since we have their offset and size).
2920 * python/testSuite.py
2921 - now tests for the existence and proper value of the pixel data
2922 - two new examples added.
2923 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2925 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2927 aware. See the strategy comments in gdcmHeader::FindeLength().
2928 * Test/test.cxx now accepts a filename as first argument.
2929 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2930 * python/testSuite.py changed to integrate test on above files.
2932 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2934 the vr was also RET.
2935 * python/testSuite.py more tests added.
2937 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2938 * python/testSuite.py unittest test suite added (uses Data)
2939 * Data/* dcm and acr files for the test suite.
2940 * glib dependance removed from un*x version. We now use ISO C99
2941 7.18 Integer types (see stdint.h)
2942 - python/Makefile, src/Makefile src/gdcm.h
2943 * src/ when an explicit vr (like dicom files) suddenly poped an
2944 implicit element we use to mark the underlying DictEntry of the
2945 concerned ElValue with "Implicit". This strategy was damageable
2946 too the public or provite dictionaries, since some of their vr
2947 would be changed. Since Header::FindLength heavily relies on the
2948 detection by Header::FindVR of falsely explicit elements, I
2949 added an extra ImplicitVr member to ElValue (boolean).
2950 The rest of the changes we the necessary adaptations.
2952 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2955 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2957 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * Adaptation for porting to VC++:
2960 o forced to use std namespace (for string to be known)
2961 o all class use __declspec export style on WIN32
2962 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2963 (in stdlib.h on Win32 but in std:: for gcc)
2964 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2965 variable GDCM_DICT_PATH.
2966 * src/gdcmHeader.cxx verbose comments made discrete.
2968 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * python/gdcm.i: added a typemap that converts a C++ hashing table
2970 to native Python dictionary.
2971 * python/demo/test.py:
2972 - now uses the native dictionary for exploration of gdcmHeader.
2973 - takes an optional filename argument (the file to parse).
2974 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2975 PubElVals hashing table.
2976 * Dicts/dicomV3.dic removed error prone trailing spaces.
2978 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2979 * Python wrapping process moved away from src/Makefile to
2980 newly created python/Makefile (as well as gdcm.i)
2981 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2982 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2983 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2984 from the environement variable GDCM_DICT_PATH (when existing).
2985 * src/gdcmDict::GetTag bug fix.
2987 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * Straightforward temporary fixes for swig to build the python wrappers.
2989 src/Makefile now has a python working entry [by working we mean
2990 that we can import de shadow classes without errors].
2992 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * hashtest.cxx removed (since already in Test)
2994 * src/gdcmlib.h renamed to src/gdcm.h
2995 * src/dcm.i renamed to src/gdcm.i
2996 * src/Makefile prepared for python wrapping
2998 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * src/gdcmHeader.cxx :
3000 - Parsing of header is now separated from loading of element values
3001 (see gdcmHeader::LoadElements).
3002 - general clean up of hopefully all file access (creation of
3003 ReadInt16 and ReadInt32)
3005 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * src/gdcmHeader.cxx :
3007 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3009 - SetLgrElem renamed to SetLength
3010 - GetLgrElem renamed to GetLength
3011 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3012 * src/gdcmElValSet.cxx fixed both GetElValue methods
3013 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3014 due to IdoDude was cleaned out.
3016 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3017 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3018 concentrates on finding the value representation (when it exists).
3019 RecupLgr now only finds the element value length, and it avoids
3020 returning the unecessary skL (skipped length).
3021 Also, offsetCourant was simply removed (with taille_fich) since
3022 it was redundant with the File position internals (by using
3023 ftell and fseek). This also made skL (see above in RecupLgr) usage
3025 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3026 on the libido specificities which are handled through class
3028 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3031 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * Truckload of changes. Parsing of header is barely functional
3033 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3035 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * src/gdcmHeader.cxx many addons of low level methods
3038 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3040 and _IdDcmSWAP_LONG.
3042 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * This corresponds to all the changes decided at the meeting of
3044 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob