1 Thu Jul 21 06:55:50 2005 by jpr
2 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
5 Thu Jul 21 06:55:30 2005 by jpr
7 Add an example of use for SerieHelper
9 Thu Jul 21 07:00:15 2005 by jpr
11 Extend 'Restriction' syntax :
12 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
13 std::string const &value, int op)
15 /// \brief comparaison operators
25 Wed Jul 20 15:39:00 2005 by jpr
27 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
28 (e.g. Private entries when the TS is Implict VR)
29 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
30 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
32 Wed Jul 20 16:49:41 2005 by jpr
34 Use GDCM_LEGACY for DicomDir, as well
36 Wed Jul 20 15:31:01 2005 by jpr
38 We can now anonymize 'BinEntries' as well
40 Wed Jul 20 15:29:42 2005 by jpr
42 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
43 16, written in hexadecimal.
44 (usefull to allow terminal user to pass the (private) elements he wants to
47 Tue Jul 19 17:25:53 2005 by jpr
49 Add some comments on the 'Patient Position'
51 Tue Jul 19 11:04:58 2005 by jpr
53 Add SerieHelper::AddGdcmFile(File *header) method.
54 * \brief add a gdcm::File to the first (and supposed to be unique) list
55 * of the gdcm::SerieHelper.
56 * \warning : this method should be used by aware users only!
57 * User is supposed to know the files he want to deal with
58 * and consider them they belong to the same Serie
59 * (even if their Serie UID is different)
60 * user will probabely OrderFileList() this list (actually, ordering
61 * user choosen gdm::File is the sole interest of this method)
62 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
63 * vtkGdcmReader parsing twice the same files.
64 * *no* coherence check is performed, but those specified
65 * by SerieHelper::AddRestriction()
67 Mon Jul 18 12:20:20 2005 by jpr
69 In order to prepare the future extension of SerieHelper::AddRestriction (key,
71 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
73 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
75 Sun Jul 17 06:27:49 2005 by jpr
77 Use new style for Loading files
79 Tue Jul 12 19:08:12 2005 by jpr
80 gdcmCommon.cxx, gdcmSQItem.cxx
81 To speed up DicomDir, instead of copying -and removing the source afterwards-
82 each entry of the SQItem (found after gdcm::Document parsing) towards
83 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
84 the chained list itself.
86 Tue Jul 12 16:55:43 2005 by jpr
88 AnonymizeNoLoad has now one more option :
90 to give the (single Patient) directory name whose content we want to anonymize.
92 Mon Jul 11 10:20:25 2005 by jpr
96 Fri Jul 8 21:07:12 2005 by jpr
98 Add the VISIT object within DicomDir
100 Fri Jul 8 12:15:08 2005 by jpr
102 Use new style for DicomDir loading
104 Fri Jul 8 16:36:48 2005 by jpr
106 To remain unimpared, gdcm::FileHelper class needs also its
107 void FileHelper::SetLoadMode(int loadMode)
108 void FileHelper::SetFileName(std::string const &fileName)
109 bool FileHelper::Load()
111 Thu Jul 7 19:31:53 2005 by jpr
113 Begin of kosherization of Example
116 Thu Jul 7 18:37:40 2005 by jpr
118 On the way to gdcm2 ...
119 Now, the stand way to use a file is :
120 gdcm::File *f = new gdcm::File();
121 f->SetLoadMode ( user say here what he wants *not* to load );
122 f->SetFileName("myFile.gdcm");
124 Old styles are kept, not to break the C++ API.
125 - gdcm::File *f = new gdcm::File("myFile.gdcm");
126 - f->Load("myFile.gdcm");
127 Due to the syntaxic abilities of Python maybe some troubles will occur
130 Thu Jul 7 15:55:39 2005 by jpr
132 Comment out the time consuming, never used/useless
133 'Extended tag' stuff for Sequence embedded Entries
135 Thu Jul 7 15:11:38 2005 by jpr
137 Move code lines LTTG so save some CPU time.
140 Tue Jun 7 13:12:10 2005 CEST by jpr
142 Use Argument Manager in 'utilities'
144 Thu Jul 7 12:12:32 2005 by jpr
146 Due to something stupid in the gdcm::File constructor, the file was parsed
147 twice when we used old style, e.g :
148 gdcm::File *f = new gdcm::File(fileName);
149 instead of new style, e.g. :
150 gdcm::File *f = new gdcm::File( );
151 f->SetLoadMode ( choose what you want *not* to load here );
154 Wed Jul 6 11:53:43 2005 by jpr
155 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
156 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
157 param, in order not to have to recompile to gdcm::Debug::DebugOn().
159 Wed Jul 6 17:18:42 2005 by jpr
161 According to Mathieu's requirement, Load twice the same file keeps the rseult of
162 the first Load (instead of doing it twice)
164 Wed Jul 6 11:25:12 2005 by jpr
166 - Clean out the Entries if a Document is parsed more than once
167 - Uncomment (usefull) warning messages
169 Wed Jul 6 10:42:33 2005 by jpr
171 - Comment out a for the moment too much verbose warning message.
172 - Delay some statement as late as possible, to save some CPU time when they're
175 Wed Jul 6 13:01:08 2005 by jpr
177 Now gdcmFile::Load() returns false if file is not gdcm parsable
178 Only gdcmDocument::Load() did it, before.
179 Thx to Benoit for reporting bug
181 Sun Jul 3 14:42:04 2005 by jpr
183 Should avoid some troubles with 'no length' SQItems within 'true length'
185 Thx to Loic Boussel for providing data to fix the bug.
187 Sun Jul 3 14:42:04 2005 by jpr
189 Should avoid some troubles with 'no length' SQItems within 'true length'
191 Thx to Loic Boussel for providing data to fix the bug.
193 Sun Jul 3 14:47:23 2005 by jpr
197 Fri Jul 1 13:25:51 2005 by jpr
198 gdcmPixelReadConvert.cxx
199 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
200 (e.g. PrintFile on a DICOMDIR document)
202 Thu Jun 30 16:49:02 2005 by jpr
204 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
205 Boussel's Hall of Shame Dicom images
207 Wed Jun 29 17:58:33 2005 by jpr
209 Add the NO_SHADOWSEQ load mode
211 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Quite a few new dictionaries were added in gdcm. The file:
213 gdcm/Dict/README should always explain were the info was found
214 (in case of double check). Also some dict are still only
215 express as 'template' (they contain 'xx'), therefore
216 a python script should be run first to generate a full dict.
217 In the longer term this python script should be replaced by
220 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * dicomV3.dic is deprecated in favor of gdcm.dic
222 There is now a dictionary per family:
223 - dicomV3.dic -> DICOM V3
224 - Papyrus.dic -> Papyrus
225 - NIH.dic -> tags that were never allowed in the main standard
227 Fri Jun 24 12:50:20 2005 CEST by jpr
229 Pixel Spacing related problems : update comments.
230 Thx to D. Clunie for providing data to check the code
232 Fri Jun 24 12:55:58 2005 by jpr
233 Summer nights are really too hot to sleep.
234 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
236 Thu Jun 23 11:20:23 2005 by jpr
238 Extend warning message, for debugging purpose
240 Wed Jun 22 10:11:23 2005 by jpr
244 Wed Jun 22 10:00:29 2005 by jpr
245 gdcmPixelReadConvert.cxx
246 Fix misstyping, while removing spurious \t characters
248 Wed Jun 22 09:52:32 2005 by jpr
249 gdcmPixelReadConvert.cxx
250 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
252 That break at lot of viewers ...
253 We now *propagate the sign bit* upon the unused ones, better than masking them
255 Thx to Luca Picello for profiding data to fix the bug
257 Wed Jun 22 09:53:52 2005 by jpr
259 gdcm images are now "GDCM 1.1" built.
261 Mon Jun 20 19:10:17 2005 by jpr
263 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
265 Mon Jun 20 17:58:53 2005 by jpr
267 Preventive bug fix for LUT Data.
268 I said : LUT Date, *not* Palette Color
270 Sun Jun 19 17:57:29 2005 by jpr
272 To avoid warnings at compile time
274 Fri Jun 17 14:27:52 2005 by jpr
278 Fri Jun 17 14:36:07 2005 by jpr
282 Fri Jun 17 14:35:00 2005 by jpr
284 Add some accessors for debugging purpose
286 Tue Jun 14 15:56:41 2005 by jpr
287 gdcmPixelReadConvert.cxx
288 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
289 (3 * 65536 short int ...)
291 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
293 Mon Jun 13 17:43:48 2005 by jpr
294 gdcmPixelReadConvert.cxx
295 Some more oddities dealt with.
296 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
297 Still looking for accurate info on the web about it
299 Fri Jun 10 16:05:38 2005 by jpr
301 Bug fix in Load method.
302 Thx to Benoit for providing fix.
303 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
305 lantency with the Util::Format function
307 Tue Jun 7 15:48:35 2005 by jpr
309 The highy time consuming method GetMacAdress is now called just once
311 Tue Jun 7 11:58:29 2005 by jpr
312 gdcmDicomDirElement.cxx
313 Use TranslateToKey better than Format
315 Tue Jun 7 12:07:20 by jpr
317 Remove some spurious calls to Format
318 // according to 'Purify', TranslateToKey is one of the most
319 // time consuming methods.
320 // Let's try to shorten it !
322 Mon Jun 6 14:37:58 2005
323 class ArgMgr (for Arguments Manager) is designed for
324 command line arguments management
325 (to make programmer's live easier)
326 (could be used for any kind of 'command line program')
328 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
329 * Adding users file in CVSROOT for mail blaming
331 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Adding potential support for JPEG-LS DICOM files.
334 Fri Jun 3 18:05:23 2005 by jpr
336 Fix VR processing, to be CP-288 conform.
337 Now we can parse any kind of DICOM SR.
339 Fri Jun 3 11:05:15 2005 by jpr
343 Thu Jun 2 15:42:18 2005 by jpr
345 Add warning about Load Mode
347 Thu Jun 2 16:20:14 2005 by jpr
349 Harden gdcm::File::IsReadable(), in order not to be confused any longer
350 by lost of Pixel Element
352 Fri May 27 12:51:00 2005 by jpr
354 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
356 And avoid some memry leaks -hope so-
358 Wed May 25 14:54:17 2005 by jpr
360 Should avoid some memory leaks
362 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Adding potential support for mpeg and jpeg2000 through two new lin
364 - JasPer for JPEG2000
365 - libmpeg2 from the MPEG consortium
366 Also adding intial work to use this lib.
368 Fri May 20 10:27:55 2005 by jpr
371 (this time, it's wasn't dangerous at run time)
373 Thu May 19 17:31:21 2005 by jpr
375 FIX possible troubles when checking
376 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
377 Thx to Mathieu for reporting bug
379 Wed May 18 12:12:07 2005 by jpr
381 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
382 Thx to Dennis Hu for providing a sample image to fix the bug.
384 Tue May 17 14:44:09 2005 by jpr
386 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
387 before 'Pixel Spacing', when we want to get X or Y Spacing.
389 Tue May 17 19:10:49 2005 by jpr
391 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
392 at LTTG (Least Time To Go)
393 around Bits Allocated, Bits Stored, High Bit Position,
394 to avoid unaware user to mess up the stuff.
396 Tue May 3 11:43:04 2005 by jpr
398 Load returns now a bool (allow user not to call IsReadable() )
400 Tue May 3 11:51:06 2005by jpr
402 Now the gdcm::File remains unimpaired after writting, in any case
404 Fri Apr 29 17:10:55 2005by jpr
406 Don't abort the prog when File not open
408 Wed Apr 27 12:00:35 2005 by jpr
410 Removal of now useless lut-related stuff
412 Wed Apr 27 11:52:27 2005 by jpr
414 Pb of 'Bits Allocated = 12' is now dealt with in
415 FileHelper::CheckMandatoryElements, no longer in File::Write.
416 Thx to Mathieu for reporting bug.
418 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
422 Tue Apr 26 18:18:23 2005 by jpr
424 Should leave gdcm::Document constructor in a much quicker
425 and much cleaner way when anything wrong occurs.
427 Tue Apr 26 18:25:49 2005 by jpr
428 gdcmPixelReadConvert.cxx
429 Prepare MPEG Dicom encapsulated processing (within a loooong future)
431 Fri Apr 22 14:59:58 2005 by jpr
433 Modify Print() output
435 Fri Apr 22 15:37:57 2005 by jpr
437 Prepare (future) MPEG integration
439 Thu Apr 21 09:40:00 2005 by jpr
441 Taking into account Dicom MPEG
443 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
445 But this is a case where we should really signify the user there is
446 few chance the serie is really a serie...
448 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * FIX : on X, the python part is correctly installed. All files are
450 installed in gdcm sub-directory
452 Tue Apr 19 11:58:19 2005 by jpr
454 Should suppress some warnings from Borland compiler
456 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Builder/ : add something to facilitate the RPM creation of gdcm
459 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
462 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
464 Thu Apr 14 16:26:19 2005 by jpr
466 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
468 // Old style (still available) :
469 dcmdir = new gdcm::DicomDir(dirName, true);
471 // new style (user is allowed no to load Sequences an/or Shadow Groups)
472 dcmdir = new gdcm::DicomDir( );
473 dcmdir->SetParseDir(true);
474 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
475 dcmdir->Load(dirName);
477 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
478 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
480 * Fix compilation on gcc 2.96 (which does not have ios::failure)
482 Mon Apr 4 17:15:24 2005 by jpr
484 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
486 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
488 and it's representation name (for the NIH)
490 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
492 conversion of YBR to RGB pixels. So, now, the conversion is made using
495 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
497 format) to replace 'at-run' dicom files generated by the
498 TestAllReadCompareDicom test
500 Tue Mar 22 12:29:37 2005 by jpr
502 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
503 and it's VR is forced to UL
504 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
505 and/or with Shadow groups
506 use SetLoadMode (NO_SEQ | NO-SHADOW);
508 Tue Mar 22 12:40:13 2005 by jpr
510 *FIX Restore pushed out elements
512 Fri Mar 11 12:08:31 2005 by jpr
514 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
516 Fri Mar 11 12:12:13 2005 by jpr
518 Final removal of gdcmFileHelper::InitializeDefaultFile();
520 Wed Mar 9 20:29:38 2005 by jpr
522 Add Anonymize method (not yet fully checked)
524 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
527 Wed Mar 2 18:18:32 2005by jpr
529 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
532 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
535 Mon Feb 21 18:45:41 2005 by jpr
537 * Replace method CheckMetaElements by CheckManadatoryElements
538 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
539 (probabely some stuff still missing)
540 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
541 between a given call and the next one (to add images to a Serie he just
543 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
544 between a given call and the next one, or to reuse an already existing
545 Study UID (i he wants to add his own Series to an already existing Study)
547 Thu Feb 17 17:18:33 2005 by jpr
549 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
550 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
551 Thx to Benoit for reporting bug
553 Thu Feb 17 11:56:20 2005 by jpr
555 Prepare FileMetaInformationVersion (group 0002) management
557 Thu Feb 17 12:02:47 2005 by jpr
559 Group 0002 management
561 Thu Feb 17 12:03:32 2005 by jpr
562 gdcmDocEntryArchive.cxx
565 Wed Feb 16 11:19:19 2005 CET by jpr
566 gdcmPixelReadConvert.cxx
567 Taking into account MONOCHROME1 + Signed Pixels (?!)
569 Tue Feb 15 19:12:34 2005 by jpr
571 Taking into account the difference between MONOCHROME1 (low values = bright)
572 and MONOCHROME2 (low values = dark)
574 Mon Feb 14 11:45:04 2005by jpr
576 Remove some useless mask operations, to save CPU time
578 Mon Feb 14 15:51:10 2005 by jpr
580 *never* forget to re-compile just *before* committing!
582 Mon Feb 14 15:34:27 2005 by jpr
584 First commit on the post 1.0 (Version? / Tag? / Branch?) :
587 Mon Feb 14 11:45:47 2005 by jpr
589 remove useless comments
591 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Testing/TestMAkeIcon.cxx : complete the test
594 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
597 Fri Feb 11 16:22:18 2005 by jpr
599 Typo, comments, doxygenation
601 Thu Feb 10 11:55:26 2005 by jpr
603 AnonymizeNoLoad improvement
605 Thu Feb 10 10:07:19 2005 by jpr
607 Duplicate Matthieu's hack to prevent bombing in Anonymize
609 Thu Feb 10 12:20:34 2005by jpr
611 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
613 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
614 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
615 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
616 virtual bool SetValEntry(std::string const &content,
617 virtual bool SetBinEntry(uint8_t *content, int lgth,
618 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
619 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
620 virtual ValEntry *InsertValEntry(std::string const &value,
621 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
622 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
624 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
625 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
628 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
631 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * Test/ : accelerate tests (it's not very significant accelerations).
633 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
635 Mon Feb 7 15:48:34 2005 by jpr
637 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
640 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * Testing/TestSequence.cxx : add test for sequences of images... test that
642 we have the same serie or the same study UID
644 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
647 * src/gdcmDict.h : remove commented code
648 * src/gdcmDocument.cxx : initialize values
649 * src/gdcmFile.cxx : bug fix when reading values
650 * gdcmPython/demo/ : change file names. Remove useless files
652 Sun Feb 6 15:31:09 2005 by jpr
654 Update comments for DicomDir stuff
656 Sun Feb 6 15:39:35 2005 by jpr
658 * Add method File::AnonymizeNoLoad, to allow anomymizing files
659 even when the pixels are not gdcm Readable
660 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
661 to allow user to choose the elements whose value
662 he wants to white out / replace
664 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * src/gdcmFile.cxx : remove the default array of initialization.
666 The static array contained pointers to non-static values (comming from
667 strings). To have coherences, when creating files, these values can't be
668 static. So, the array can't be static, too ! To simplify, the array have
669 been replaced by repeted lines to insert values in the File
671 Fri Feb 4 15:49:01 2005 by jpr
673 * Add GetFirstValEntry + GetNextValEntry, for Python users
674 * Some more Doxygenation + typo fixing
676 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
678 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
680 Thu Feb 3 18:12:46 2005 by jpr
681 gdcmPixelReadConvert.cxx
684 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
685 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
686 (Dicom Element) into the Sequence Item
688 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
689 * src/*.cxx : first parss to normalize file organisation
691 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
692 * src/gdcmDirList.[h|cxx] : add method to find a directory
693 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
695 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
696 * Finish cleaning up my JPEG mess. Should be ok now.
697 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
698 contained within the RLE* class(doh!)
700 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
701 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
702 * SerieHeader::AddFileName() creates as many Coherent Files lists
703 (same Serie UID) as it founds different Serie UID
704 amongst the files instead of discarting any file
705 that doesn't match with the first one he found.
706 * SerieHeader::OrderGdcmFileList has now one parameter :
707 the Coherent Files list the user wants to sort
708 * SerieHeader::GetFirstCoherentFileList() |
709 * SerieHeader::GetLastCoherentFileList() | allow to parse
710 the set of Coherent Files lists
711 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
712 compatibility (it returns the *first* Coherent Files list,
713 since there was only one before)
714 * Test/TestSerieHeader gets gdcmData as a default root directory
716 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * Remove friend between DocEntry and File classes
718 * Remove friend between PixelReadConverter and RLEFramesInfo,
721 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
722 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
723 0002|0000. The value was incorrect.
725 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
728 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * src/gdcmUtil.cxx : compilation fix on Win32
730 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
731 variable, to be easy found. Add methods to change the default UID.
732 Amelioration of the CreateUniqueUID to use the correct default UID.
733 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
736 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * Test/TestVR.cxx : fix memory leaks
739 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
740 * Rewrite the base 256 to base 10 conversion, using string operation only.
741 This allows us to get rid of the problematic 64bits integer type (does not
742 always exist on target platform).
744 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
745 * Add construct and destructor to class gdcm::Debug to close the debug file
747 * Don't let uset to open twice the same file
748 * gdcm has now an official UID prefix,
749 supplied by http://www.medicalconnections.co.uk
750 1.2.826.0.1.3680043.2.1143
751 (Thx to Mathieu for providing URL)
752 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
753 to be able to perform some more tests
754 * gdcm::ContentEntry : Contructors and Destructor are now protected,
755 in order to be sure no user will try to use them.
756 (at user level, only the children classes are meaningfull)
758 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * move RLEInfo & JPEGInfo from Document to File
761 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * FIX : remove so many friend between classes
764 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
765 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
766 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
768 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
769 In order to avoid missbehaviour :
770 . gdcm::DocEntry is now specialized in
771 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
772 - gdcm::ContentEntry (Dicom entry with a 'content')
773 . gdcm::ContentEntry is specialized in
774 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
775 characters value, or integers)
776 - gdcm::BinEntry (Dicom entry with a non strig representable value
777 (user hasn't any longer to thing about the precedence of his dynamic_casts)
779 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
780 * Test/VTKTest*.cxx : bug fix under linux
782 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
784 use with python. Some methods are moved from Document to ElementSet or
785 DocEntrySet. The equivalent methods to ElementSet have been added to
786 SQItem and are virtual in DocEntrySet. Methods that may have the same code
787 in SQItem and ElementSet is directly placed in DocEntrySet
789 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
790 * Test/VTKTest*.cxx : remove the show variable in each test method because
791 it's useless (the viewer variable replace this variable)
793 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmDocument.cxx : bug fix on potential memory leak
795 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
796 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
797 Add ClearXxx methods to remove all the content of the list or map
798 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
800 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
801 * methods ReplaceOrCreate renamed as Insert
802 (nobody will be any longer confused by 'CreateOrReplace')
804 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
805 * Grealty simplify the JPEg decompression, no need to differenciate based on
806 the JPEG possible type (with/without fragment, with/without multiple frame).
807 Everything is done throught the JPEG IO Suspension mechanism in IJG
809 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
810 * Stage 3 of normalization :
811 in order to avoid any missunderstanding while reading method names :
812 - All the methods xxxEntry now deal with dicom Entries
813 - Methods GetEntry splitted into
816 - Method SetEntry renamed as SetEntryValue
817 - Method SetEntryBinArea let as it was
819 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
820 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
821 - Position correctly the entry points for JPEG2000 and JPEG-LS
822 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
824 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
825 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
826 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
827 with other method names
828 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
829 * Test/TestDicomDirElement.cxx : add new test
831 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
832 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
833 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
834 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
835 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
836 So can't you use __int64 in ostream at all.
838 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * bug fix for compilation on MSVC6
840 * gdcmPython/gdcm.i : rename of classes missed
842 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
843 * Stage 2 of names normalization :
844 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
845 (easy to understand ...)
846 - gdcm::FileHelper replaces old class gdcm::File
848 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
850 type and not a string. So, there remove problems on the format of the
853 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
854 * Add Example/TestPapyrus.cxx
855 - reads a Papyrus file (gdcm::Header compliant),
856 - gets the pixels of all the images, using low level iterators
857 - writes an multiframes Dicom image.
858 (Just to show it's *possible* to do that)
859 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
862 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
863 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
864 Thus, DicomDirXXX are created with a flad that indicates if the created
865 object is empty or not (when not empty, the DicomDirElement is used to
868 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
869 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
870 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
872 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
873 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
875 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
876 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
877 Remove all access to the hash-tables or lists in the objects.
879 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
880 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
881 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
882 be complient with all the gdcm source code
884 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
885 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
888 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
892 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * Test/ : rename VTK tests to have a best name for the tests
894 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
895 GetFirstEntry/GetNextEntry use
897 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
898 * In SerieHeader::ImagePositionPatientOrdering()
899 // a Dicom 'Serie' may contain scout views
900 // and images may have differents directions.
901 // -> More than one may have the same 'pos'
902 // Sorting has then NO meaning !
903 Thx to Eduardo Davila for reporting bug.
905 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
907 test. Now it's on image content and not on the resulting visualisation...
908 might solve the problem on linux when using the OpenGL drivers
910 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
911 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
912 DicomDirSerie, DicomDirImage
913 Dict, DictSet classes :
914 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
915 -remove InitTraversal method.
916 * UPD Test programs + Example programs
918 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
919 * remove useless and never updated keyword \ingroup
920 * Solve pb when structure (list, map, ...) is empty.
921 Thx to Benoit for reporting bug
923 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
924 * Taking into account of 'Transfer Syntax' value
925 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
928 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
929 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
930 is no memory access violation
931 * gdcmPython/demo : add python demos using VTK
933 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
934 * FIX 'Dictionnary' is now spelt 'Dictionary'
935 'wether' is now spelt 'whether'
936 'archieve' is now spelt 'archive' ;-)
938 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
939 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
940 related methods, in order not to expose internal mechanisms
943 * REM methods that exposed internal mechanisms :
944 DicomDir::GetDicomDirPatients()
945 DicomDirPatient::GetDicomDirStudies()
946 DicomDirStudy::GetDicomDirSeries()
947 DicomDirSerie::GetDicomDirImages()
948 * UPD Test programs :
952 * UPD Example program
954 * ADD DictSet methods
958 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
959 * Removed the Print/indent/default parameter mess. There is absolutely no
960 reason to have to methods, moreover with the second taking the ostream as
961 *SECOND* parameter. This was clearly a bad hack to get things compile.
963 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
964 * Complete rewrite of the GetMacAddress code. Now the code is *much*
965 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
966 Unfortunately the main code does not work on SunOS, thus provide a specific
967 code for this platform only (and Win32 of course). Since this seems to be
968 working, change CreateUniqueUID to use GetMACAddress instead of the
969 problematic GctestetIPAddress
971 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
972 * Unfortunately to be able to test gdcmDirList I had to break the API
973 a little. Now the class is not a std::list anymore but has a member
974 std::vector (more ITK compatible). Allow unit testing on Win32 and
977 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
978 * Update SerieHeader to take into account a Serie Instance UID to properly
981 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
982 * ENH - Comment out Mathieu's (dangerous) Super Hack
983 for dealing with BIGENDIAN processors
984 - Move equivalent stuff to BinEntry::WriteContent
985 When necessary, 16 Bits Pixels are swapped in a small buffer
986 and then written. This avoid allocating a huge buffer, in
987 PixelWriteConvertor, and avoid modifying the Pixel Area.
989 Probabely, the same operation will have to be done when we want
990 to write image with Big Endian Transfert Syntax,
991 and we are working on Little Endian Processor
993 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
994 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
996 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
997 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
998 all the dict content.
999 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1001 * Test/TestDict.cxx : add a new test for the dict classes
1003 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1005 file. Debug is yanked if compiled with NDEBUG
1007 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1008 * src/gdcmDictSet.h : set the default output to the os variable
1009 * src/gdcmDictEntry.[h|cxx] : add the Print method
1010 * gdcmPython/demo/ : add a new test
1012 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1013 * merging of Test/PrintDicomDir and Test/TestDicomDir
1014 * removal of now redundant Test/PrintDicomDir
1015 * enhancement of Example/PrintDicomDir
1017 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1018 * Now, python test might work on systems
1019 * Add the PrintDicomDir test
1021 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1022 * FIX : First entry following group 0002 was lost for
1023 Explicit Big Endian Transfer Syntax files
1024 (group and elem not swaped)
1026 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1027 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1028 Big Endian Transfer Syntax supposed the group following 0002
1029 begins always by element 0000 (element 0000 is *optional*)
1030 To avoid further troubles, let's be pessimistic, and use
1031 Document::HandleOutOfGroup0002() method
1032 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1033 (related pb not yet solved)
1035 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1036 * Bug fix for the python part use
1037 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1039 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1040 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1042 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1044 a string and should ask the global TS dict what are the propreties of
1047 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1048 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1049 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1050 to swap the Swap Code, at parsing time, when we come out of group 0002
1051 and Transfer Syntax is Big Endian
1052 We should be able to read now 'true DICOM" Big Endian coded images
1053 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1054 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1056 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1057 * Hopefully fix the bug on MacOSX and static global initialization.
1058 This is the only -minor- patch I found that both please MacOSX and VS6.
1059 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1060 but this would require a lot of change. Another approach would be that Global
1061 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1062 gdcm::Global would destroy at exit).
1064 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1065 * Fix bug on MacOSX with static initialization in a multy threaded
1066 environment. static const string in a header file used to be ill
1067 initialized provoquing the freeze of any tests. patch should solve this
1070 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1071 * According to Benoit's suggestion, and without any objection from anybody
1072 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1073 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1074 - method gdcmDicomDirObject::GetEntry() renamed as
1075 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1077 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1078 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1079 you debug/warning message just as c++ streams which make them very convinient
1080 to use. Once this is stabilize I will change the ostringstrem to be
1081 redirected to a file (ofstream).
1082 * Properly support C99 extension: __FUNCTION__ which allow us to display
1083 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1085 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1086 * Removal of useless and dangerous methods :
1087 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1088 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1089 * Removal of usless methods :
1090 Dict::PrintByName, Dict::GetDictEntryByName
1091 * Commenting out of probabely useless methods :
1092 Dict::GetDictEntryNames()
1093 Dict::GetDictEntryNamesByCategory()
1094 DictSet::GetPubDictEntryNames()
1095 DictSet::GetPubDictEntryNamesByCategory()
1096 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1097 * ENH : Use dicomTS.dic as described in 2004 version
1098 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1099 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1100 Add Accessors on VM (Value Multiplicity), and VM related methods
1101 * ADD : Add a list of 'Dicom Attribute types', as found in
1102 http://medical.nema.org/dicom/2004/04_15PU.PDF
1104 * ADD : Add dicomGroupNameAbbreviations.dic
1105 should be used to write a method to replace the former
1106 Dict::GetDictEntryNamesByCategory()
1108 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1109 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1110 to read in the file... and only it ! Length is the efective length of the
1111 data in the DocEntry structure
1113 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1114 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1115 And now use a static function call instead, with a global variable. i
1116 This is much closer to the VTK approach. Hopefully should be bulletproof
1117 and easier to use...hopefully
1119 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1122 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1123 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1125 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1126 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1127 ValEntry, BinEntry, SeqEntry creation or replace
1129 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1130 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1131 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1133 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1134 when specifying the VR
1135 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1136 * src/gdcmDocEntry.cxx : amelioration of print
1138 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1139 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1140 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1141 * ADD Method Document::ComputeGroupLength
1142 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1143 in order to allow further VR modification by user
1144 * REM : removal of once-called method File::WriteBase
1145 integration of its code in formerly one-line method File::Write
1147 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1148 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1149 replace the different values "??", "Unkn", "Unknown".
1150 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1151 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1152 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1153 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1155 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1156 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1158 * Set the gdcm::Base class to some Printable classes
1160 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1161 * src/gdcmFile.[h|cxx] : add the Print method
1162 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1163 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1164 * src/gdcmDocument.h : remove the PrintLevel informations
1165 * Example/PrintFile.cxx : use the new gdcm::File::Print
1167 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1168 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1169 problems when compiling with the python wrapping
1171 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1172 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1173 writting in ImplicitVR
1175 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1176 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1177 JPEG decompression, especially when dicom frames are split into several
1178 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1179 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1181 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1182 * src/gdcmHeader.cxx : change the initialisation of default header.
1183 Now, this header is readable by gdm, e-film, DicomWorks
1185 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1186 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1187 Rename Decompressed to Raw
1188 * Use the API changes in gdcm::File.
1189 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1192 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1193 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1194 each added entry in the header. Replace the 'Planes' field by the 'Number
1197 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1198 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1199 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1201 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1202 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1203 At this time, this image isn't readable by e-film... waiting JPR help to
1206 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1207 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1208 DocEntry. Now use methods of the Document !
1210 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1211 * Test/ShowDicomSeq.cxx : bug fix
1213 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1215 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1216 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1217 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1219 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1220 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1221 containing found sequences
1223 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1224 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1226 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1227 Some fields in BinEntry must be copied to not seg fault when making the :
1228 gdcm::File *copy = new gdcm::File( copyH );
1229 and tests are now made on good variables
1231 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1232 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1233 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1235 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1236 * Add vtkGdcmWriter example and test
1238 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1239 * Test/TestUtil.cxx : reformat the source code
1240 * vtk/vtkGdcmReader.cxx : remove and change prints
1241 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1243 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1244 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1246 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1248 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1250 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1251 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1252 by an eof to prevent all bad read of the file... and in this case, the
1253 file isn't readable.
1255 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1256 * Example/Volume2Dicom.cxx : comment unused variables
1257 * Test/PrintDicomDir.cxx : comment unused variables
1258 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1259 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1260 method that is redondant with AddEntry.
1261 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1264 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1265 * Bug fix due my last commit (compilation under Windows).
1266 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1267 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1269 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 - Remove printf / sprintf
1272 - include iostream AFTER gdcm so we don't get warnings
1273 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1275 - Also remove tons of include from header files, hopefully this should
1276 speeup the compilation time, since it was becoming a dog slow.
1277 - Remove gdcm.h as it include way too many files and slow down compilation
1278 (plus it is not up to date)
1279 - remove 'using namespace std' this is BAD !
1281 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1282 * Remove memory leaks on the DicomDir
1283 * Remove some useless data in DicomDirObject
1284 * Add usefull methods in SQItem, to be complient withe the ElementSet
1286 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1287 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1289 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1290 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1291 future, with convertion)
1292 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1293 and ImageDataSize values. Remove the method to get the PixelReadConverter
1294 from the output of the class
1296 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1297 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1299 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1300 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1301 and vtkErrorMacro use.
1302 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1304 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1305 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1307 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1308 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1309 The string leaves only in the fonction. So when we make a .c_str(), we
1310 get the pointeur on the first element, element that will be destroyed
1311 immediately after thee instruction.
1312 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1313 file has been opened : the test must be made on the content of the
1314 pointer and not directly on the pointer !
1317 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1318 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1319 the python part recompiles
1321 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1322 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1323 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1324 X session is killed (for my computer... it seems to not be identic on
1327 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1328 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1329 avoid problems (otherwise, the difference test between the visible image
1330 and the reference is incorrect. If the reference is greater than the
1331 screen resolution, it's produce errors).
1332 Can be used for only one image. Can be used with a visible flag.
1333 * vtk/vtkGdcmReader.cxx : remove commented codes.
1334 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1335 under windows at compilation
1336 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1337 for grayscale images
1338 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1340 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1341 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1342 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1343 tests on the image size X, Y, Z
1345 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1346 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1347 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1348 between the class name and the file name
1350 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1351 * src/ : fix compilation warnings for the Write method (2 different
1352 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1353 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1354 variable... create a static method in gdcm::Document to access to
1355 this variable content.
1357 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1358 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1359 file, to be accessed by other files (like gdcmFile). Remove commented
1360 code. Move the change of the header to the gdcmFile, using the
1362 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1363 To be sure of that (and simplify calls), the Write of the header now
1364 gets a file name and not a file pointer (std::ifstream).
1365 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1366 DocEntryArchive. Remove all open of the written file
1368 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1369 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1371 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1372 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1373 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1375 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1376 some corresponding methods. Write correctly the file and check before
1378 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1379 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1380 is now on RGB data (as before my last commit
1381 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1383 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1384 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1385 Add a print information of the type of the entry
1386 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1387 It was in the gdcmFile, and all write have been regrouped
1388 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1389 Write correctly all dicom files (in decompressed mode only at this time)
1390 * Test/ : test on files are now made using Raw data and not color data if
1392 * Example/PrintFile.cxx : add more printings
1394 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1395 * Amelioration of code, remove some code copy. For the loading of
1396 BinEntry (in gdcmDocument), add the test to verify if the file is already
1399 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1400 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1401 remove a DocEntry in the header (push an empty DocEntry)
1402 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1403 lines. Bug fix in the initialization of the PixelConvert and the
1405 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1406 use in TestCopyDicom (now this test can run under windows... but fails)
1407 * Test/TestCopyDicom.cxx : amelioration of the test :
1408 - test the pixels written
1409 - add test points to quickly find where is the error
1410 - can set a file name input and output in arguments
1411 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1412 amelioration of the test output
1414 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1415 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1416 all replaced DocEntry's
1417 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1418 Now, each needed DocEntry to modify is duplicated, modified and inserted
1419 to the header using DocEntryArchive. Thus, after save, we can restore the
1420 header initial state.
1422 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1423 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1425 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1426 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1427 correct to copy it. The DictEntry is specified at the DocEntry creation,
1428 then, it musn't change in the time.
1429 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1430 header correctly. At this time, the change is only made for the first
1431 level of the Document. In the future, it might consider sequences.
1432 The change is made by replacing a DocEntry by an other that is created
1433 outside the class. The old value is kept. When we restore the header
1434 status, the added DocEntry is deleted and replaced by the old value.
1435 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1436 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1437 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1438 the write mode to native, decompressed or RGB (but not used at this time)
1440 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1441 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1442 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1444 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1445 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1446 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1448 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1449 set because already copied when copying the BinEntry's of the header
1450 * Test/TestAllReadCompareDicom.cxx : remove warnings
1452 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1453 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1454 Two problems appear when doing it :
1455 - with the gdcmFile : when the GetImageData method is called, the pixels
1456 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1457 data (pixels). And each structure destruct the data when it's
1458 destructed. So we have two destructions for the same data. To solve it,
1459 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1460 data or not. If it doesn't own data, then they will not destroyed by
1462 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1463 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1464 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1465 create a double destruction of the same DocEntry's. So, to solve it,
1466 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1467 * TODO : add an entry concerning memory leaks in the DicomDir
1469 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1470 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1471 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1474 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1475 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1476 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1477 after it have been deleted
1479 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1480 * FIX: src/* fix the doxygen warnings.
1481 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1482 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1483 was erroneously defined with a size of 15 instead of 16. [many thanks
1484 to Jean Michel Rouet for pointing out this bug].
1486 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1487 1. Finish merging JMR patch for writting DICOM from scratch
1488 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1489 3. Use const ref when possible
1490 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1491 5. A few more comments
1492 6. CreateUniqueUID can now be called without parameter"
1494 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1495 * ENH: Slightly bigger patch:
1496 1. Getting toward full integration of JMR patch for writting dicom from scratch
1497 2. Update Test to test part of this patch: CreateUniqueUID
1498 3. File was not close properly in gdcmDict
1499 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1500 5. Use of const ref instead of copy (speed issue)
1501 6. Remove temporary (duplicate) string in TranslateToKey
1502 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1503 8. Do not repeat virtual in subclasses
1504 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1506 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * Apply first patch toward better string comparison when dealing with broken
1508 DICOM files. Essentially the string could be padded with a space instead
1509 of a null character as defined by standard
1511 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1512 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1513 because never used... and in the same time, that's remove some memory leaks
1515 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1516 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1517 * In examples and tests : change the type of image data variables from void*
1518 to uint8_t*. Remmove all delete on image data variables
1520 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1521 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1522 Verify the file pointer value before open the file, and if it's not null,
1523 a verbose message is generated.
1524 Close correctly the file when the file isn't considered dicom-like. The
1525 correctly close is a call to CloseFile.
1526 When closing the file pointer, test if its not null to close the file.
1527 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1528 file. For an uncompressed image, the copied data correspond in the least
1529 case to the image size (calculated) or the image size specified in the
1530 header. A verbose is generated if these two size mismatch
1532 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1533 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1534 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1535 break under windows (with msvc6 compilation).
1537 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1539 compiling with MSVC6)
1541 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1542 * Bugs fix for the Windows build with VC6
1543 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1544 needed (only for projects required VTK). If the VTK is included in all
1545 projects, there is conflicts with the jpeg lib of vtk when compiling the
1546 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1547 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1548 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1550 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1551 (like it's already made for the cout use). Otherwise, conflict with the
1554 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1555 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1556 * gdcmPython/gdcm.i:
1557 - comments on the DicomDir::Method related usage added.
1558 - now that we use the namespace gdcm, a lot of internal classes do
1559 NOT need to be wrapped anymore.
1560 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1561 DicomDir::Method) new example added.
1563 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * Improve string manipulation. I now inforce the notion of 'DicomString'
1565 A DicomString can contain as many \0 as they want
1566 and it is *always* of even length.
1567 We only support odd length for very rare case.
1568 And in the near future this should be removed.
1570 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1571 * /binary_write/ gdcm source. Now even on big endian we are writting
1572 little endian. This should -heopfully- fix some tests
1574 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1575 * Now the dictionary is compiled into gdcm lib. This is a default
1576 behavior, thus any dic file specified is picked before failback to
1577 the one comiled into lib
1579 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1580 * Change internals for gdcmDict. Don't use any 'new' any more.
1581 This should definitely solve any leak problem, and we should be
1582 as fast as before, as long as don't modify too much the dictionary.
1584 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * STYLE: ivars should start with a capital letter.
1586 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1587 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1589 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1590 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1591 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1592 new 2004 dictionaries added (thanks to JPR).
1593 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1594 * CLEANUP_ROUND (15) for gdcmPixelConvert
1595 - RLEFrame::NumberFragments is now of type unsigned int
1596 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1597 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1600 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1601 * Initial work in gathering all transfer syntax accessors. clearly
1602 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1603 ivars, but only one transfersyntax (class) ivar with equivalent method on
1606 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1608 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1609 discussed (plus I didn't like having a 2000 lines patch not commited)
1611 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1613 * CLEANUP_ROUND (14) for gdcmPixelConvert
1614 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1615 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1616 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1617 CloseFile() anymore.
1618 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1619 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1620 into File::Pixel_Data.
1622 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1624 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1625 * CLEANUP_ROUND (13) for gdcmPixelConvert
1626 Substituted File::ParsePixelData() with PixelConvert::Print() new
1628 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1629 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1630 method to those classes.
1631 - src/gdcmFile.[cxx|h]:
1632 -- Added a ::Print() method.
1633 -- PixelConverter is now a reference instead of a member.
1634 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1635 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1637 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1639 collaboration diagram and inheritance diagram should be generated with
1641 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1642 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1643 pointlessly wrapped (see
1644 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1645 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1646 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1647 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1648 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1649 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1650 -- File::Initialise: PixelConverter setup moved away to
1651 PixelConverter::GrabInformationsFromHeader()
1652 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1653 interpretation moved away to PixelConverter::BuildRGBImage()
1655 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1657 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1659 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1661 displayed on Win32 when a brutal abort() occurs (because of uncatched
1662 exception). See TODO new entry of this commit for more on this.
1663 * TODO added new entry.
1664 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1665 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1666 - HandleColor is no longer called from gdcmFile.cxx
1667 - gdcmPixelConvert.cxx clean up on method arguments and internal
1668 variable names for semantical coherence.
1670 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * Finished lossless transition, not only do we now read all lossless jpeg
1672 images, without the need of the Cornwell lib, but we do read them properly now
1673 * To reduce code (well to avoid code duplication), I defined a common place
1674 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1675 redefine symbols. This is not perfect but this the best solution I found for a
1676 compilation time jpeg option.
1678 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * Update jpeg ijg lib to support lossless jpeg implementation
1680 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1682 * Also added a special copyright for dcmtk since we use their bugfixes.
1685 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1686 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1687 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1688 matters, as stated in warning note at beginning of %include section).
1689 * src/gdcmDicomDir*.[cxx|h]: coding style
1690 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1691 * src/gdcmJpeg8.cxx: doxygen fix.
1692 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1693 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1694 from File:: to PixelConvert::.
1696 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1698 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1699 - more code moved away from File:: to PixelConvert::
1700 - fat setup of PixelConverter set in place in File::Initialise.
1702 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1703 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1704 namespace at the file system level. So now you should convert your examples
1706 gdcmHeader -> gdcm::Header
1707 It would be nice if people keep in mind to no open the namespace, since it
1708 allows compilation on broken plateform which were defining common symbol in
1709 the standard namespace (like LP, Unknown ...)
1711 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1712 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1713 The JPEG fragments are now parsed at the same stage than the RLE
1714 information. All code related to JPEG is now in gdcmPixelConvert:
1715 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1716 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1717 export a gdcmFile:: method. Those are simply global functions
1718 (for the time being this is better than having them attach to
1719 either gdcmFile:: or gdcmPixelConvert::).
1720 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1721 and stores the result in a gdcmJPEGFragmentsInfo.
1722 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1723 code (among other stuff) moved away from gdcmFile:; to
1726 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1727 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1728 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1729 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1730 clean up of RLE related code.
1731 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1732 - src/gdcmRLE.cxx removed
1733 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1734 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1735 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1736 * CLEANUP_ROUND (9) for gdcmPixelConvert
1737 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1738 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1739 away from gdcmFile:: to gdcmPixelConvert::.
1741 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1742 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1743 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1744 This is because Parse7Fe0 used to parse the pixels to compute the
1745 length. This task was passed over to FindDocEntryLengthOB() a long
1746 time ago, EXCEPT I forgot the OW case...
1747 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1748 we just recylce the code for parsing RLE fragments and computing
1750 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1751 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1752 with the retired Parse7Fe0().
1753 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1754 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1756 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1757 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1758 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1759 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1760 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1761 * CLEANUP_ROUND (4) for gdcmPixelConvert
1762 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1763 to return an unused length.
1765 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1767 this should be cleanner from the plane view. The iostream are erally a pain
1768 to use to do simple stuff.
1770 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1771 * Redo the compilation of the ijg jpeg library. Now only one source is
1772 necesseray. No need to rename file by hand what so ever. CMake handle the
1773 copying of the file within different directory, configure header file to
1774 modify some symbol. The only addition made to ijg wasd a mangle table so
1775 that symbol are different whether we are within 8bits or 12bits.
1777 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1778 * Added documentation of vtkgdcmReader on Website:
1779 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1780 with it's binary name).
1781 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1782 the Website to be more complete.
1783 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1784 doxygenated documentation.
1785 - Doc/DoxyVtkGdcmReaderExamples.txt added
1786 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1787 DoxyVtkGdmReaderExamples.html )
1788 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1789 * CLEANUP_ROUND (3) for gdcmPixelConvert
1790 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1792 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * CLEANUP_ROUND (2) for gdcmPixelConvert
1794 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1796 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * CLEANUP_ROUND for gdcmPixelConvert:
1798 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1799 - src/gdcmPixelStuff[h|cxx] removed
1800 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1801 - src/CMakeLists.txt changed accordingly
1802 * GDCMHOME clean up:
1803 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1804 gdcmVersion.py moved to newly created ATTIC related
1805 gdcmPython/SetupOldies/ directory.
1806 * Autotools clean up:
1807 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1808 - autogen.sh configure.in acinclude.m4 python.m4 removed
1810 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1812 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1813 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1815 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * TODO updated with Mathieu suggestions. I proposed a template for
1817 describing TODO entries and used it for new entries.
1818 * Added Doc/Website/CodingStyle.html, Developpers.html,
1819 DeveloppersPython.html, GdcmDataCvs.html and
1820 DownloadVersion0_1.html, DownloadVersion0_3.html.
1821 * Some Doc/*.txt Doxygen files (which do not really concern the
1822 documentation itself, but the website) moved to html and
1823 placed in directory Doc/Website:
1824 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1825 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1826 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1827 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1828 * CMakeLists.txt changed accordingly.
1829 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1830 DeveloppersPython.html
1831 * INSTALL nows refers to Doc/Website/Installation.html
1833 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * Added Doc/Website directory, that contains a first raw version
1837 2004-09-23 Jean-Pierre Roux
1838 * FIX In order not to be poluted any longer by casting problems,
1839 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1840 we can now delete[] it safely
1841 * VoidArea is now called BinArea (less confusing name),
1842 and all the methods called ...VoidArea... are now ... BinArea...
1843 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1845 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1847 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1848 up to the destructor of gdcmElementSet to clean up TagHt and it's
1851 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1853 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1855 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1856 * ENH: added some utility method that builds a flat dictionary
1857 holding all the Dicom entries contained in the recursive structure
1858 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1859 an example of usage.
1860 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1861 BuildFlatHashTable() that build a flat dictionary.
1862 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1863 gdcmDocument is now a friend of gdcmElementSet.
1864 - src/gdcmElementSet.cxx: clean up.
1865 - Example/FlatHashTablePrint.cxx added.
1866 - Example/CmakeLists.txt changed accordingly
1868 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1870 moved away from gdcmDocEntrySet (since this class is an abstract class
1871 acting like an interface). SQDepthLevel and BaseTagKey are now
1873 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1874 and associated accessors. Doxygenation of the class.
1875 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1877 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1878 Use SQDepthLevel accessor instead. ::Print() adapted.
1879 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1880 - src/gdcmDocument.cxx changed accordingly.
1882 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1883 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1884 - The following is the doxygen comment of the typedef declaration
1885 of gdcmTagKey in src/gdcmCommon.h:
1886 gdcmTagKey is made to old an "universal" (as in URL, Universal
1887 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1888 A dicom tag always has a group and an element, but a set of tags
1889 embeded in various (optionally nested) sequences and sharing
1890 the same group and element all share the same (group, element)
1891 "identifier". Hence the (group, element) cannot be used as an
1892 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1893 In order to construct a proper tag identifier (i.e. a key) we
1894 consider the following definition of a TagKey:
1895 - let Group, Element be the string representation of the
1896 group and element dicom tag members,
1897 - let ItemNumber be the string representation of the integer
1898 index of the considered item number of a sequence,
1899 Let the key of a tag embeded in a sequence, noted SeqTag, be
1901 /ItemNumber#Group|Element
1902 where "/", "#" and "|" are characters acting as separators.
1903 Then the general form of a gdcmTagKey is given by:
1904 Group|Element<SeqTag>
1905 where <SeqTag> means NO or many instances of SeqTag.
1906 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1909 but the gdcmTagKey of a tag "embeded" is the first item of
1910 a sequence, itself nested in the third item of a sequence is the
1912 0004|1220/2#0008|0082/0#0008|0090
1913 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1914 order to hold the new sequence compatible key. Previously, the
1915 GetKey() method would look in the underlying gdcmDictEntry.
1916 - src/gdcmDocEntry.cxx:
1917 -- constructor now copies the underlying DictEntry key, in the local
1919 -- ::Print: displays the member Key, instead of the (group, element).
1920 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1921 - src/gdcmDocEntrySet.h:xi
1922 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1923 -- now has a new BaseTagKey member.
1925 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1926 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1928 This poses the problem with the semantics of the following lines
1929 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1930 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1931 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1932 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1933 to the long FIXME note for what the problem is. Nevertheless in
1934 order to get things working the dicom dictionary was altered !
1935 Please fix things urgently...
1936 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1937 information), see above note on moving the member VoidArea. Nevertheless
1938 the following entries previously correctly set as US are now inproperly
1940 0028 1201 OW IMG Red Palette Color Lookup Table Data
1941 0028 1202 OW IMG Green Palette Color Lookup Table Data
1942 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1943 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1944 of gdcmDocEntry moved to gdcmSeqEntry.
1945 * src/gdcmSeqEntry.cxx: STYLE.
1947 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1950 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * gdcmPython/testSuite.py: all the test suite in python is now moved
1952 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1953 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1954 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1956 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1957 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1958 to avoid inclusion recursion until STL is reached.
1959 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1960 mecanism. errno.h is not included in gdcm anymore.
1961 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1962 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1964 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1965 gdcmData/TestAllEntryVerifyReference.txt
1966 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1967 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1968 exception_on_error parameter.
1969 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1970 - vtk/vtkGdcmReader.cxx changed accordingly,
1971 - Example/*.cxx and Test/*.cxx changed accordingly.
1973 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1975 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1976 enable_sequences removed from gdcmHeader constructor and dependencies.
1977 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1978 * gdcmPython/demo/PrintHeader.py: dummy fix.
1979 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1980 skip_shadow removed from gdcmHeader constructor and dependencies.
1981 * Example/*.cxx and Test/*.cxx changed accordingly.
1983 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1984 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1985 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1987 2004-07-21 Jean-Pierre Roux
1988 * FIX Now, Parsing and Printing a DICOMDIR do work!
1989 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1991 2004-07-20 Jean-Pierre Roux
1992 * FIX Some brain damaged headers have Zero-Lenght fields
1993 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1995 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1996 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1997 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1998 variable (instance of gdcmDebug) by a definition macro, and the instance
1999 is now in static in the gdcmDebug class
2000 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2001 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2003 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2004 * WARNING: ctest now depends more tightly on gdcmData. You should
2005 check out gdcmData properly for things to run smoothly...
2006 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2007 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2008 we need the pixels not be loaded in order to use the ValEntry
2009 that displays position and size).
2010 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2011 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2012 be deprecated. If you have any doubts about the advantages of a
2013 modern scripting language (read Python) versus grass root C++ (i.e.
2014 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2015 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2016 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2017 Anyhow, consider documenting the gdcmData images in
2018 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2020 * Test/CMakeLists.txt:
2021 - now uses TestAllEntryVerify.cxx
2022 - specific comments on oldACR00001.ima (now renamed in gdcmData
2023 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2024 gdcmData/TestAllEntryVerifyReference.txt
2027 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * src/*.[h|cxx] : typedef clean up
2029 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2030 - TagKey renamed to gdcmTagKey (for external usage)
2031 - VRKey renamed to gdcmVRKey (for external usage)
2032 - removal of typedef duplication.
2033 - Removed all unecessary inline keyword from class inline definitions.
2034 - Some method|function(void) declarations replaced with method|function().
2035 * src/jpeg/libijg12/jdhuff12.c:
2036 - printf polluting ctest removed.
2037 - TAB removal for comminting
2039 - TestAllReadCompareDicom.cxx: added a test that compares all the
2040 images in gdcmDataImages.h with corresponding images in
2041 gdcmData/BaselineDicom/. When baseline images are not present
2042 this test creates them.
2043 Note: we need to validate each reference image, but before that
2044 I'd like to rename them with a more explicit name...
2045 - CMakeLists.txt: changed accordingly.
2046 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2047 including each header needed).
2049 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2051 test suite to the Example directory. Are concerned:
2056 - TestWriteSimple.cxx
2057 * Test/CMakeLists.txt: added some comments on reasons for black listing
2058 image gdcmData/oldACR00001.ima
2060 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * Test/CmakeList.txt: removed the following from black list (to be coherent
2062 with removal from gdcmData):
2063 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2064 - gdcm-MR-PHILIPS-16.dcm
2066 Added the following because after last cvs update, they cause
2067 ctest -R TestReadWriteReadCompare
2069 - gdcm-MR-SIEMENS-16-1.acr
2071 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2072 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2073 new comments in this file) we temporarily (sigh) move to a weaker
2075 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2076 we don't need to black list the following images anymore:
2077 - 8BitsUncompressedColor.dcm
2079 - US-PAL-8-10x-echo.dcm
2080 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2081 fixes and the beautified code ;-)
2082 This fixes the bug introduced in version 1.42 (when beautifying)
2083 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2084 Note: ctest was blind to this bug (this means we need to still
2085 improve the test suite). The bug could be detected by using
2086 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2088 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2089 and by displaying the (garbage) produced file temp.XDCM...
2091 2004-06-29 Jean-Pierre Roux
2092 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2093 - replace by uggly but working old code :-(
2094 A lot of things should be OK again.
2095 It's really urgent to have a test suite that *tests*,
2096 to prevent Frog's beautifying sessions to break all the stuff
2097 (twice, withing a fortnigh ...)
2099 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2101 redundancy) to added Test/TestReadWriteReadCompare.cxx
2102 * Test/CmakeList.txt: because the compare test of
2103 Test/TestReadWriteReadCompare.cxx fails, the following images are
2104 black listed: - 8BitsUncompressedColor.dcm
2106 - US-PAL-8-10x-echo.dcm
2107 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2108 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2109 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2110 and ad-hoc kludge. This kludge is now removed, and on encountering
2111 such an image (OB field brain damaged) we set errno. Then in
2112 ::FindDocLength() we "fix" the length as being ALL what remains
2113 in the file (until EOF). We then proceed, hoping for the best...
2114 This fixes a SegFault in ShowDicom when trying to write such an
2116 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2117 (because TestWriteRead breaks on it, after a non conformal commit?).
2118 ctest now runs properly, except for MakeDicomDir (which was always
2119 broken) and the Python related stuff (still not fixed).
2121 2004-06-24 Jean-Pierre Roux
2122 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2123 FIX : Test/TestReadWrite now iterates on all the file names
2124 (instead of infinite loop)
2125 ENH : Test/TestWriteRead now iterates on all the file names
2127 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2130 2004-06-24 Jean-Pierre Roux
2131 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2132 when SamplesPerPixel =3
2133 - now Write is no longer confused by
2134 'BitsAllocated = 12" and 'BitsStored=12"
2135 - "UN" value representation Elements are now written correctly
2136 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2137 ENH : - now gdcmHeader has its own Write methods
2138 (in order to split the job that has not to be done
2141 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2143 loop on the same image until memory went out.
2144 Note: this means we still have gobs of memory loss in PrintDocument
2145 * src/gdcmDocument.cxx: fixes problem on parsing on file
2146 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2148 2004-06-24 Jean-Pierre Roux
2149 FIX : Write - All the Sequences and Sequence Item are now written
2150 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2151 is added a the end, when necessary.
2152 - A lot of brain-damaged images, that were read correctly are
2153 now written correctly
2154 - length compatible BinEntry are now loaded correctly
2155 (even for odd groups)
2156 Note : only Explicit Value Representation was checked.
2157 (question : is implicit VR really necessary for gdcm ?)
2159 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * DEVELOPPER: added a proposition of coding style.
2161 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2164 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2166 Use the gdcmDocEntry::Print() and Write() instead.
2167 * src/gdcmDocument.cxx: bug fix.
2169 2004-06-22 Jean-Pierre Roux
2170 FIX : gdcmDocument.cxx
2171 - Now we do recognize the JpegLossLess format (there was a misstyping in
2172 code 'beautyfication' :-(
2173 - Now we automaticaticaly load the Luts, if any
2175 2004-06-22 Jean-Pierre Roux
2176 In order : to write Sequences, whatever their imbrication level,
2177 : to allow user to create his own Sequences
2178 a lot of modif where necessary (adding, moving, or virtualising methods)
2180 WARNING : save your own sources *before* cvs up !
2183 ADD virtual void Write(FILE *fp, FileType filetype);
2186 ADD virtual void Write(FILE *fp, FileType filetype);
2187 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2190 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2191 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2192 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2193 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2194 ADD std::string GetEntryByName(TagName name);
2195 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2197 std::string vr = "unkn",
2198 std::string fourth = "unkn",
2199 std::string name = "unkn");
2200 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2201 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2202 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2203 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2204 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2205 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2206 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2207 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2210 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2211 ADD virtual std::string GetEntryByName (TagName tagName);
2212 ADD virtual std::string GetEntryVRByName (TagName tagName);
2213 REM virtual bool Write(FILE *, FileType);
2214 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2215 FILE *_fp, FileType type);
2216 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2217 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2218 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2219 REM virtual std::string GetEntryByName (std::string tagName);
2220 REM virtual std::string GetEntryVRByName (std::string tagName);
2221 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2222 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2223 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2225 std::string vr = "unkn",
2226 std::string fourth = "unkn",
2227 std::string name = "unkn");
2228 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2229 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2230 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2231 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2234 ADD virtual void Write(FILE *fp, FileType filetype);
2237 ADD virtual void Write(FILE *fp,FileType filetype);
2240 ADD virtual void Write(FILE *fp, FileType filetype);
2241 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2242 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2243 REM std::string GetEntryByName(TagName name);
2246 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2248 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2250 The default constructor invoked by the line
2251 gdcmHeader *f1 = new gdcmHeader( header );
2252 was gdcmHeader::gdcmHeader(bool) instead of the expected
2253 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2254 Hence the parsing wasn't executed... See also below.
2255 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2256 as explicit constructor didn't do the trick to fix the above problem.
2257 Could anyone explain why ?
2258 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2259 properly calls gdcmValEntry::Print() (that was weed out from
2260 code related to gdcmBinEntry).
2262 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * In order to fix memory leaks:
2264 - Test/TestWriteSimple.cxx: added cleaning of free store through
2266 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2267 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2268 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2269 (through the call to ::AddDicomDirMeta()) or the destructor
2270 would crash when deleting uninitialized ::metaElems].
2271 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2272 - src/gdcmDocument.cxx:
2273 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2274 from dynamic stores.
2275 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2276 was causing memory leaks.
2277 - src/gdcmSQItem.cxx:
2278 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2279 cleanly handled with polymophism: sorry but my milage is low).
2280 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2281 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2282 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2283 This avoids SegFaulting.
2284 - src/gdcmSQItem.h: coding style.
2286 - Test/TestWriteSimple still severely sucks. The output image content
2287 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2288 damaged when displayed with vtkgdcmViewer.
2289 - on memory leaks: TestWriteSimple leaks really less (see entry
2290 of 2004-06-18 in Changelog file for the call to valgrind).
2291 - on segfaults: ctest now passes all the tests but one (no more
2293 * Erroneous leading white fix:
2294 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2295 white[s] (as opposed to from >> xxx, that removes it [them].
2296 - src/gdcmTS.cxx: ditto.
2297 - gdcmPython/testSuite.py: dirty related kludge removed.
2298 * src/*: remaining references to gdcmParser removed.
2299 * src/*[cxx|h]: added copy[way]left header.
2302 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * In order to fix writing of dicom files:
2304 - Test/TestWriteSimple.cxx: a simpler example of writing.
2305 - Test/CMakeLists.txt changed accordingly.
2306 - src/gdcmDocument.cxx:
2307 -- The destructor now recursilvely removes potential sequences.
2308 -- Bug fix in ::IsJPEG2000()
2309 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2310 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2312 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2313 to only declared) and build on top of
2314 ::GetDocEntryByNumber(guint16, guint16).
2315 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2316 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2317 for usage in destructor and treatement of promotion in
2318 ::ReplaceOrCreateByNumber().
2319 - src/gdcmSQItem.cxx: destructor should better handle his job.
2320 Test/TestWriteSimple now runs (or at least it DOES something).
2321 * We can now start hutting memory links. A good starting point is:
2322 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2323 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2324 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2326 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * Valgrind note: after Mathieu Malaterre teached me how to read
2328 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2330 Using gcc, you can force the STL to use malloc and to free memory as
2331 soon as possible by globally disabling memory caching.
2332 With 3.2.2 and later, you should export the environment variable
2333 GLIBCPP_FORCE_NEW before running your program.
2334 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2335 simply vanish (it is still not clear to me, whether this means that
2336 STL std::string leaks or if valgrind believes it leaks...).
2337 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2338 running bin/gdcmTests makeDicomDir):
2339 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2340 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2342 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2343 SegFaulting (I drowned in DicomDir related code when trying to
2344 understand why the list is empty...).
2345 * src/gdcmDocument.h: first BSD license header try.
2346 * Doc/License.txt added.
2348 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * src/gdcmDocument.[h|cxx]:
2350 - Clean up of the Transfer related predicates. They are now all based
2351 on new method isGivenTransferSyntax, that (should) handle properly
2352 the padding problem.
2353 - general clean up, simplification, and coding style.
2354 - Specific clean up of Parse7FE0() (umproperly named actually).
2355 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2357 2004-06-14 Jean-Pierre Roux
2359 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2360 - fix the display of SQItem ordinal number
2361 - add the GetSQItemByOrdinalNumber method
2362 - remove some useless never written private methods
2364 2004-06-14 Jean-Pierre Roux
2366 - adding a constructor taking a gdcmDocEntry as an input param
2367 - ReplaceOrCreateByNumber now returns :
2368 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2369 a gdcmValEntry * if a string value is passed as a param
2371 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2372 according to the param type (no longer sets a gdcmDocEntry)
2373 - GetValEntryByNumber, GetBinEntryByNumber added
2374 - NewValEntryByNumber and NewBinEntryByNumber added
2376 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2378 - GetSQItemNumber and SetSQItemNumber added, to provide
2379 a (relative) Item identier inside a given Sequence
2380 \warning : some pb remaining around this number
2382 - AddEntry now takes the Item Number as a param
2384 - adding a constructor taking a gdcmDocEntry as an input param
2386 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * Memory leak hunt with the following command:
2388 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2389 --show-reachable=yes gdcmTests PrintDocument
2390 It looks like many (all?) leaks are due to the STL (or a bad usage
2391 of the STL. The lines producing the leaks now have a comment with
2392 a "MEMORY LEAK" tag: you can retrieve them with
2393 grep "MEMORY LEAK" src/*
2394 Here are two typical examples which I can't help fixing:
2399 char * test = "babo";
2400 name = test; //// <--- valgrind detects 960 bytes lost in
2401 //// call to std::string::operator=(char const*)
2402 name.clear(); //// Doesn't help !
2410 std::cout << "Type a bunch of characters followed by RETURN: ";
2411 getline(std::cin, line); //// <--- valgrind dectects a loss
2412 //// of 1320 bytes in call to
2413 /// std::basic_istream<>& std::getline<>
2419 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * src/gdcmHeader.[cxx|h]:
2421 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2422 and related, moved away to gdcmDocument.
2423 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2424 the corresponding protected accessors of inherited class
2425 gdcmDocument, removed ! As a consequence gdcmFile had to be
2426 declared friend of class gdcmDocument (see below).
2427 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2428 - Clean up of undefined or unused methods.
2429 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2430 account the changes to gdcmHeader.h).
2431 * src/gdcmDocument.h:
2432 - gdcmFile is now a friend class (in order to take into account the
2433 changes to gdcmHeader.h).
2434 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2435 (see changes to gdcmHeader.h).
2436 - Accessors (reading on the form GetEntry*) are now public.
2437 - Clean up of undefined or unused methods.
2438 * src/gdcmDocument.cxx:
2439 - adaptation to changes to gdcmDocument.h
2440 - ::OpenFile now writes a verbose message when file cannot be opened.
2441 - some std::string properly set to VRKey
2442 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2443 references to gdcmDocument.
2444 * Test/TestFindTags.cxx: changed accordingly to above changes.
2445 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2446 cvs repository gdcmData.
2448 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2450 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2451 conflicts with gdcmValEntry::voidArea.
2452 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2453 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2454 Value representation between StringRepresentable and BinaryRepresentable.
2455 * src/gdcmDocument.cxx:
2456 - method ParseDES: proper indentation restored and usage of
2457 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2458 - method LoadDocEntry: the fingerprint left in the SetValue() of
2459 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2460 removed. Reverting to previous code segment with the proper
2461 dynamic_cast< gdcmValEntry* >.
2462 Note: this was (partially) breaking the python test suite
2463 (gdcmPython/testSuite.py) that made usage of the above
2464 fingerprint to check presence of "Pixel Data".
2465 * src/gdcmDocEntry.h: coding style.
2466 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2467 now taken into account.
2468 * gdcmPython/gdcm.i: adaptation to the new internal representation
2469 of gdcm (exit gdcmParser, hello gdcmDocument).
2470 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2472 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2473 anymore, but instead prints the loaded Python dictionary.
2474 * .... alas, the python testSuite is still broken.
2476 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2477 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2479 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2480 * src/gdcmUtil.h : export methods
2482 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2483 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2485 * Initial addition of automatic python testing
2486 * Initial addition of automatic image comparison
2488 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2489 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2490 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2492 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2493 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2494 * Test/ShowDicom.cxx : bug fix for msvc compilation
2495 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2497 2004-05-04 Jean-Pierre Roux
2498 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2499 new concepts (and new classes) :
2500 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2501 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2502 - Sequence Doc Entries (gdcmSeqEntries)
2503 a Sequence is composed of Items.
2504 Each item is a set of Doc Entries (this is recursive)
2505 The non uniqueness of the 'Dicom tag' is due to this recursivity
2506 (never taken into account)
2507 Our unability to add a new 'entry' in the header
2508 at the proper location (neither in the H-Table (map or multimap),
2509 nor in the Chained List is also due to this recursivity.
2510 Don't try, right now, to use/modify/compile these new sources :
2511 nothing is finished.
2512 We just commit all the stuff, 'as is', in order not to loose it.
2514 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2515 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2517 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2518 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2519 file prefix (SetFilePrefix)
2521 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2522 * Add a new test: ShowDicom, for now this is just the c++ version of
2523 checkRead.sh, later it will be able to compare the image read against a
2525 * Replace the DEBUG on the stack with a global entry in cmake interface:
2526 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2528 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2529 * Add an example subdir, with a real example on how to read + write a
2532 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2533 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2534 * Doc/CMakeLists.txt: the main page is now properly differentiated
2535 between the developper and user version.
2536 * Doc/doxygen.config.in: dropped search related obsolete flags
2537 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2539 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * DEVELOPPER: added some helpfull comments for compile/test/install
2543 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2544 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2545 src directory, now generated in the build dir.
2546 2. Tests as mentionned smarter
2548 4. Add a new method in gdcmDict that return the PubDict by name
2549 this is interesting for 3rd party lib like ITK,
2550 where we could set the institution name / patient name...
2552 * ENH: 1. Now the test suite is working for real
2553 2. All binaries are now output in the gdcm-bin directory
2554 (this was not true before)
2556 2004-04-28 Jean-Pierre Roux
2557 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2558 SeQuence indented printing of Dicom Header.
2559 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2560 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2561 Computation of SQDepthLevel is now part of gdcmHeader constructor
2562 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2563 tree-like structure of a Dicom Header.
2564 * FIX Test code cleaning
2566 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * ENH: Adding automatic testing
2568 1. Need a DartConfig.cmake to submit to public
2569 2. Add a test driver gdcmTest.cxx
2570 3. gdcmTestMain, an helper for the main test driver gdcmTest
2571 4. Files in Test don't have a main anymore, this becomes interesting
2572 when we add more and more tests, thus dsw don't have to load
2574 * ENH: Adding a GDCM_DATA_ROOT for testing
2575 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2576 one file instead of seven + some small cleanup
2578 2004-04-22 Jean-Pierre Roux
2579 * ENH Minor changes to the Print() methods.
2580 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2581 Header printing. Example given with :
2582 > PrintHeader fileName 2 new
2583 (SQ based tree-like structure still to be done for the Header ...)
2585 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2587 1. I have added some unsigned where needed
2588 2. Some function parameter not used -> (void)
2589 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2590 4. g++ don't like character '\' in comment
2591 5. #define jpeg_create_decompress jCreaDecompress
2592 this really need to be fixed
2593 6. virtualize destructor of gdcmObject ... leakage
2594 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2595 this also really need to be fixed
2596 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2597 remove compression file
2598 (as we only do decompression, right ?)
2599 * ENH: Change malloc/calloc/free with c++ equivalent
2601 2004-04-21 Jean-Pierre Roux
2602 * FIX gdcmHeaderHelper::GetXSpacing
2603 when a single value is found (bug ?), xpacing is now
2604 defaulted to yspacing
2606 2004-04-19 Jean-Pierre Roux
2607 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2608 * ENH add parameters :
2609 bool exception_on_error = false,
2610 bool enable_sequences = false,
2611 bool ignore_shadow = false
2612 to the gdcmFile constructors to be full gdcmParser compliant
2613 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2614 to allow reading of PAPYRUS 3.0 files
2616 2004-04-06 Jean-Pierre Roux
2617 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2619 2004-04-02 Jean-Pierre Roux
2620 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2621 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2622 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2624 2004-03-30 Jean-Pierre Roux
2625 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2626 for ACR file, written out as DICOM files (hope so...)
2628 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2629 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2630 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2631 moved to base class gdcmParser and only the specialisation is kept
2633 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2634 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2635 already does the job.
2636 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2637 (to be consistent with gdcmParser::WriteEntries).
2639 2004-03-30 Benoit Regrain
2640 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2641 upate of the object's instance. It's passed to 2 in the unfavorable
2642 case : one in the ExecuteInformation, one in the ExecuteData
2644 2004-03-29 Jean-Pierre Roux
2645 * ENH : Check on file type to be written moved
2646 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2647 * FIX : gdcmObject::ResetBoundaries now stops properly
2648 when end-of-list is reached
2649 : gdcmVersion modified (as Benoit Regrain asked)
2651 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2653 * src/gdcmUtil.cxx: added forgotten iostream include.
2654 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2655 equivalent to ExplicitVR in existing code).
2657 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2658 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2659 now contains all the gdcmGlobal related code.
2660 * minor coding style and doxygenation changes.
2662 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2664 now contains all the Debug related code.
2665 * minor clean-up of includes in src/*.cxx
2666 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2667 CreateCleanString) removed.
2668 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2669 * Doc/DoxyMainPageUser.txt added.
2670 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2671 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2672 src/gdcmDirList.cxx)
2674 2004-03-24 Jean-Pierre Roux
2675 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2677 2004-03-23 Jean-Pierre Roux
2678 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2679 big endian made volumes
2680 * ENH Now gdcmParser constructor and destructor are protected to forbid
2681 end user to instanciate class gdcmParser
2682 (only gdcmHeader and gdcmDicomDir are meaningfull)
2684 2004-03-22 Benoit Regrain
2685 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2686 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2687 gdcmSerie to gdcmDicomDirSerie
2689 2004-03-19 Jean-Pierre Roux
2690 * ENH Now the tree-like structure describing a DICOMDIR comming from
2691 an already existing DICOMDIR file is consistent with
2692 the home-made tree-like structure build ex-nihilo
2693 or build from the files held (recursively) in a Directory
2694 functions gdcmDicomDir::CheckBoundaries()
2695 gdcmObject::SetBoundaries() added
2697 2004-03-17 Jean-Pierre Roux
2698 * REM (Eric Boix bug) : removal of meaningless
2699 gdcmDicomDirImage::NewImage function.
2700 * FIX now file names and directory name are written properly in the
2702 * FIX now gdcmDicomDir constructor may be call without any trick
2705 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2707 of gdcmDicomDirImage::NewImage as empty function.
2709 2004-02-28 Jean-Pierre Roux
2710 * ENH add gdcmDicomDir:NewPatient
2711 add gdcmDicomDirPatient:NewStudy
2712 add gdcmDicomDirStudy:NewSerie
2713 add gdcmDicomDirSerie:NewImage
2714 to allow making gdcDicomDir object.
2715 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2716 (as opposite to the gdcmHeader chained list)
2718 2004-02-11 Benoit Regrain
2719 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2720 when using from python
2722 2004-02-10 Benoit Regrain
2723 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2724 * FIX : in gdcmDicomDir when the directory is empty
2725 * ENH : add callback and methods to get the progression of dicomDir
2728 2004-02-06 Jean-Pierre Roux
2729 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2730 - GDCM_META added to gdcmDicomDirType
2731 - class gdcmMeta created
2732 * ENH : - A brief summary is now displayed at the beginning of
2733 'testDicomDir' to help disaster magnitude estimation
2734 * REM : Now useless Test/explDICOMDIR.cxx
2736 2004-02-05 Benoit Regrain
2737 * ENH : add methods in gdcmObject to get the hash table or the list of
2739 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2740 * FIX : wrapping python for TagHeaderEntryHT
2742 2004-02-04 Benoit Regrain
2743 * FIX : even length for some strings when writting the dicom dir
2744 * FIX : sort the images in the dicom dir
2745 * FIX : Bug fix for python use of dicom dir
2746 * ADD : a python demo
2748 2004-02-04 Jean-Pierre Roux
2749 * FIX : Final solution (?) for icone embedded images
2750 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2751 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2752 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2753 gdcmData/gdcm-MR-SIEMENS-16.acr1
2754 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2755 to make full checking easier
2757 2004-02-04 Benoit Regrain
2758 * FIX : WriteEntries : coding style & logic in parameters
2759 * FIX : Set the elements to create the DicomDir in a dictionary file
2761 2004-02-03 Benoit Regrain
2762 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2763 * gdcmDicomDir : add the load of directory
2764 * Bug fix and print add-on
2766 2004-02-03 Jean-Pierre Roux
2767 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2768 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2769 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2770 * FIX gdcmParser.cxx : 'group length' elements are now considered
2771 as integers, even for shadow groups, when file is Implicit VR
2773 2004-02-02 Jean-Pierre Roux
2774 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2776 of the last synonym :-(
2777 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2779 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2780 * FIX taking into account the possible 7fe0,0010 multiplicity
2781 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2782 to allow removal of references to 7fe0,0010, to deal with
2783 ACR-NEMA images, when 0028,0200 is meaningfull
2785 2004-01-31 Jean-Pierre Roux
2786 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2787 no longer writes 'Un' on disk
2788 * FIX SQ elements with actual length are now dealt with corectly
2789 * FIX gdcmFile::WriteBase make the difference, for color images, between
2790 the length (for Palette expanded images)
2791 and Raw Length (non expanded image + Palette)
2792 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2793 (that broke Write). Replaced by UL.
2794 Aware user will reload the field if he
2795 thinks it's necesssary
2797 2004-01-30 Jean-Pierre Roux
2798 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2799 when 'dirty Acr' is found, to be compliant with the new
2800 IsReadable() methods.
2802 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2803 (no DOUBLE images in kosher DICOM,
2804 but so usefull for people that miss them ;-)
2806 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2807 DICOMDIR related utilities (not checked as Windoze compliant)
2809 2004-01-28 Jean-Pierre Roux
2810 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2812 2004-01-27 Jean-Pierre Roux
2813 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2814 to allow skipping the shadow elements, to save memory space.
2815 The TRUE value for this param has to be used
2816 with a FALSE value for the 'enable_sequence' param.
2817 ('public elements' may be embedded in 'shadow Sequences')
2818 * gdcmHeader methods now deal with 'embedded icones images' in the header
2819 (even when an 'icone image sequence' is announced by the
2820 element (0x0088,0x0200), but there is NO icone at all ...
2822 * gdcmHeader sometimes Image Location value doesn't follow
2823 the supposed processor endianity (see gdcmData/cr172241.dcm).
2826 * gdcmHeader add the method
2827 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2828 to get *all* the Header Entries with the same tag.
2829 GetHeaderEntrySameName is probabely *useless*
2830 (no meaning : Name is *not* an identifier within the Dictionary)
2832 2004-01-26 Benoit Regrain
2833 * Bug fix in the print of hexadecimal representations. Remove long fields
2834 in the print and add a third level of print to print them
2836 2004-01-23 Benoit Regrain
2837 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2838 * Bug fix on test suite after remove the strip made on not string fields
2839 * Split the IsReadable method between gdcmParser which test that the file
2840 is dicom and gdcmHeader which test that it's an image file
2842 2004-01-22 Benoit Regrain
2843 * DicomDir : clean code, add methods, set variables in protected or private
2844 * gdcmUtil : bug fix for the clean string method
2846 2004-01-19 Benoit Regrain
2847 * Add the use of shadow dictionaries
2848 * bug fix and coding style
2850 2004-01-19 Benoit Regrain
2851 * src/gdcmFile.cxx : bug fix concerning the close of file
2852 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2853 * Add the update of header entries using the shadow library
2855 2004-01-19 Benoit Regrain
2856 * removal of file gdcmHeader2.cxx
2857 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2858 inheriting from gdcmParser. This split is to prepare the integration
2859 of dicom dir parsing
2860 * bug fix under python
2862 2004-01-16 Jean-Pierre Roux
2863 * REM removal of class gdcmHeaderEntrySet
2864 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2865 * ADD add file gdcmHeader2.cxx
2866 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2868 2004-01-15 Benoit Regrain
2869 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2870 entries created while parsing the header. Thus, they will be destroyed
2871 when the gdcmDictSet will be destroyed
2872 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2875 2004-01-15 Benoit Regrain
2876 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2877 made a fatal error because of the memory release at the end of program.
2878 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2879 some memory and vtk seems to have some problems with that.
2880 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2882 2004-01-14 Benoit Regrain
2883 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2884 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2885 * src/*.[h|cxx] : make changes due to class name changes
2886 * gdcmPython/demo/*.py : bug fix due to method names
2888 2004-01-13 Benoit Regrain
2889 * src/*.[h|cxx] : coding style
2890 * vtk/*.[h|cxx] : coding style
2892 2004-01-13 Benoit Regrain
2893 * gdcmPython/testSuite.py : test the readable flag of file for tests
2894 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2895 It's lied to the stl compilation by MSVC (windows, always windows...)
2896 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2898 2004-01-12 Benoit Regrain
2899 * src/*.h : add comments
2900 * src/gdcmDictSet.h : set the method BuildDictPath in public
2901 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2902 directly setted in the source code
2903 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2906 2004-01-09 Benoit Regrain
2907 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2908 * setup.py : use a reference to gdcmVERSION
2910 2004-01-07 Benoit Regrain
2911 * Modification to compile with the distutils.
2914 2003-12-10 Benoit Regrain
2915 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2916 can use a gdcmHeaderHelper to load data
2917 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2918 made in the source code
2920 2003-12-10 Benoit Regrain
2921 * Update Windows projects and .cvsignore files
2923 2003-11-12 Jean-Pierre Roux
2924 * ENH gdcmHeader constructor has one more parameter (default value : false)
2925 that allows the user to 'go inside' the SeQuences only
2927 gdcmElValSet:Print takes it into account
2929 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2930 * ENH: Update gdcmPython/CMakeLists
2931 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2932 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2934 2003-11-10 Jean-Pierre Roux
2935 * FIX : gdcmHeader::LoadElements is now based
2936 on the ListTag listElem member,
2937 not longer on the TagElValueHT tagHt member
2938 * ENH : PrintPubElVal shows (temporarily) both results,
2939 with the tagHt member and the listElem member.
2940 (it's easier to 'see' the problems when using Printheader)
2942 * FIX : old private member LgrElem is now splitted into
2943 ReadLength : Length actually found on disk (updated only
2944 if bug fixing is necessary), for internal
2946 UsableLength : Updated by FixFoundLength, to fix a bug
2947 or to allow Parser going on.
2948 Will allow to re-write a kosher header when a SeQuence
2949 with a length (not 0000) is found
2950 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2951 because gdcmElValSet::Add does not update ListElem
2954 2003-11-07 Jean-Pierre Roux
2955 * FIX misstyping in Transfert Syntax name table
2956 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2957 when they have an actual length (not 0000 nor FFFFF)
2958 (Nobody should care of it, but DICOMDIR explorers)
2960 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2961 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2963 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2964 * ENH: vtkGdcmReader now supports LUT !
2965 (vtkgdcmViewer for now is not able to use them though)
2967 2003-11-05 Jean-Pierre Roux
2968 * in testSuite.py : new files names for checking the package
2969 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2970 that returns the pixel area size to the *aware* (vtk) user
2971 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2973 2003-11-05 Benoit Regrain
2974 * in testSuite.py : Modify the rules for checking the paths
2975 : Explicit error messages
2976 * in __init__.py : Related modif
2978 2003-11-03 Jean-Pierre Roux
2979 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2980 to be used by aware (vtk) users that want to manage
2981 LUT (and no to turn the PALETTE image into an RGB pixels one)
2982 * GetPixelType now returns 8U for 24 Bits images
2983 (vtkGdcmReader compliant)
2985 2003-10-31 Jean-Pierre Roux
2986 * Removal of *all* gdcmData images and add them again
2987 in order to loose the 'history' of un-anonymised images
2989 2003-10-31 Jean-Pierre Roux
2990 * RMV : removal of useless jBitsInJsample.h
2991 for both 8 and 12 Bits JPEG Lossy Libraries
2993 2003-10-31 Jean-Pierre Roux
2994 * ENH : Add the functions gdcmFile::GetImageDataRaw
2995 gdcmFile::GetImageDataIntoVectorRaw
2996 that act as GetImageData and GetImageDataIntoVector
2997 except the making of an RGB Plane from Gray Plane + LUT
2998 Intended to aware (vtk) users who know how to manage
3001 GetLUTRGBA return a R,G,B,A LUT if any
3002 lgrTotaleRaw gives the 'Raw' length
3003 GetImageDataRaw returns the gray Plane
3004 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3005 (They stay Grey, just like with other Dicom viewers :-(
3007 2003-10-30 Jean-Pierre Roux
3008 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3010 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3011 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3012 being coherents dicom files.
3014 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3015 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3017 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3018 * ENH: Two steps is necessary to please VC++ compiler...
3019 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3020 * ENH: Add include dir to medcon lib
3021 * FIX: only one function is being exported for now !
3022 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3024 2003-10-29 Jean-Pierre Roux
3025 * adding gdcmHeader::GetLUTRGBA
3026 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3027 --> Mathieu, the modif u're waiting for is not yet committed
3028 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3030 2003-10-27 Jean-Pierre Roux
3031 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3032 00191113.dcm DermaColorLossLess.dcm
3033 MxTwinLossLess.dcm RadBWLossLess.dcm
3034 * ENH: For version prior to vtkImageViewer2 -r 1.19
3035 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3037 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3038 * Removal of ido stuff in CMakeLists.txt
3040 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3041 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3042 * FIX: remove a call to ->Modified ... see comments
3043 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3045 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3046 * FIX: Problem with path for libvtkgdcmPython
3047 * ENH: Try adding a search script for python site-package
3048 * RMV: Remove some file from medcon lib that are not necessary
3049 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3050 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3051 * FIX: More pragma disable fro VC++,
3052 I don't think I break something as it is also disable in VTK/ITK.
3053 But it fasten debug compilation time.
3055 2003-10-23 Jean-Pierre Roux
3056 * gdcm now deals with 16 Bits Run Length Encoded images
3057 (they are compressed as 2 planes images,
3058 one for the high Bytes, the other for low Bytes)
3060 2003-10-22 Jean-Pierre Roux
3061 * Now CheckRead takes into account :
3062 - the bugged 'Leonardo' Siemens images
3063 - the XA images, sent thru the burning VPRO station
3064 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3067 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3068 * FIX: When copying a Makefile.am to CMakeLists.txt
3069 one should remove the '\'
3071 2003-10-22 Jean-Pierre Roux
3072 * in gdcmData adding a bugged 'Leonardo' Siemens image
3073 (wrong lengths in header)
3074 OK with gdcm, KO with the other viewers :-)
3075 * add a GE dlx XA image, thru the VEPRO burning station
3078 2003-10-21 Jean-Pierre Roux
3079 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3080 for a brutal checking of vtkgdcmViewer compliance
3082 2003-10-21 Jean-Pierre Roux
3083 * add the files for 'xmedcon' Jpeg Lossless library
3084 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3086 2003-10-21 Jean-Pierre Roux
3087 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3089 2003-10-21 Jean-Pierre Roux
3090 * garbage Siemens 'Leonardo' images dealt with
3091 (the patch is easy to remove)
3092 * cosmetic changes to avoid warnings
3094 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3095 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3096 no need to press 'r' now.
3098 2003-10-20 Jean-Pierre Roux
3099 * upgrade of checkRead.sh checkWrite.sh according
3100 to new Jpeg Lossless decompressor
3101 * add US.3405.1.dcm, a genuine RGB medical file ...
3102 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3103 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3105 2003-10-15 Jean-Pierre Roux
3106 * general anonymisation in gdcmData
3107 * adding the 'color files' from
3108 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3109 * adding some well knowed bugged-header images
3110 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3111 waiting for their inclusion in Python testsuite
3113 2003-10-15 Jean-Pierre Roux
3114 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3115 no longer seg faults when file is not found
3117 2003-10-14 Jean-Pierre Roux
3118 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3121 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3122 * TODO: *.in file to genereate a UseGDCM later
3124 2003-10-14 Jean-Pierre Roux
3125 * Some supposed-to-be Dicom Images have no preamble.
3126 OpenFile takes it into account
3127 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3128 * Missing elements added in dicomV3.dic
3129 (just to be affraid : have a look at
3130 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3131 and do it again next year ;->
3133 2003-10-13 Jean-Pierre Roux
3134 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3135 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3136 But there are NOT. It's fixed !
3138 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3139 * FIX: "jpeglib.h" was not found on VC++
3140 * FIX: vtkgdcm was not being installed
3142 2003-10-10 Jean-Pierre Roux
3143 * ENH : OpenFile closes the file if it *really* doesn't look like
3144 an ACR-NEMA / DICOM one.
3145 * FIX : testWrite no longer writes an empty file if the source file
3146 is not gdcm Readable
3147 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3150 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3151 * FIX: CMake generate now documentation
3152 * ENH: out of source doc build !
3153 * ENH: Generate both user and dev documentation
3154 * ENH: Should work on windows too
3155 * ENH: Only one doxygen config.in file is needed
3156 * FIX: make install should be ok now on Unix plateform
3157 * FIX: PATH to dictionary was wrong (missing /)
3158 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3160 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3161 * vtkGdcmReader is now able to read rgb dicom file.
3162 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3163 * added a gdcmViewer to vtk test, use mouse to control
3164 window level & window width
3166 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3167 * CMake-ification of gdcm, we have now two build system
3168 * FIX: on cygwin Wsock32 doesn't exist
3169 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3171 2003-10-06 Emanuel Ollart
3172 * FIX : compilation process wad broken.
3173 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3175 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3176 * change gdcmViewer -> vtkgdcmViewer
3177 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3179 2003-10-06 Jean-Pierre Roux
3180 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3181 ( e.g : well known GE images with a wrong elem length,
3182 : Philips MRI Images with a wrong Huffman table)
3183 * still to be done : allow the reading of bugged LEONARDO Siemens images
3185 2003-10-03 Jean-Pierre Roux
3186 * Odd length strings are padded with '\0' (not with spaces,
3187 to remain compliant with already defined strings,
3188 like Transfert Syntax UID and others)
3190 2003-10-03 Jean-Pierre Roux
3191 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3192 to allow displaying RGB images (not only by affim ;-)
3194 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3195 * vtkGdcmReader is now able to read rgb dicom file.
3196 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3198 2003-10-03 Jean-Pierre Roux
3199 * A few nasty patches to allow the reading of a lot of nasty images
3200 ( e.g : well known GE images with a wrong elem length,
3201 : Philips MRI Images with a wrong Huffman table)
3202 * still to be done : allow the reading of bugged LEONARDO Siemens images
3204 2003-10-03 Jean-Pierre Roux
3205 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3207 2003-10-03 Jean-Pierre Roux
3208 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3209 to allow displaying RGB images (not only by affim ;-)
3211 2003-10-03 Jean-Pierre Roux
3212 * gdcmFile::GetImageDataIntoVector now
3213 - deals with MultiFrames MultiFragments Run Length Encoded files
3214 - deals with YcBcR (YBR_FULL) files
3215 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3216 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3218 (no sample found :-(
3220 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3221 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3222 Two reasons: - clear things
3223 - third parties acces gdcm through header files, so won't
3224 suffer anymore VC++ complains
3226 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3227 * add argv[1] in testvtkGdcmReader.cxx
3230 2003-09-24 Jean-Pierre Roux
3231 * The lines are now eigthy characters long for
3232 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3234 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3235 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3236 char* to std::string. Thus, the use of strdup becomes useless. (see
3237 previous commis of Malaterre)
3238 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3239 before the last Malaterre's commit.
3241 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3242 * This commit should fix the Debug building under VC++, the problem
3243 was mainly a mixture of debug and release lib being loaded at startup.
3244 * I also remove a depency to a specific C function: strdup. Because I had
3245 to force the link to msvcrtd (whereas strdup is in libc).
3247 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3248 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3249 located in the gdcmCommon.h file. All use of reference of tha has been
3250 changed to now use the variable GDCM_UNFOUND.
3252 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3254 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3255 Dicom dictionary. The test suite can now be run again. Note:
3256 I'm note very happy with the " (RET)" changes. I believe this
3257 RETAINED comment should be dropped when parsing the dictionary.
3258 - PACKAGER corrected
3260 - AUTHORS updated and now in alphabetical order
3261 * Makefile.am now exports gdcm.dsw for Windoze users.
3263 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3264 * cygwin complains about missing std:: in subdir Test/
3266 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3267 * remove some methods that are now in gdcmHeaderHelper
3269 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3270 * vtkGdcmReader set spacing and origin correctly
3272 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3273 * Fix a few delete/delete[] mismatch
3275 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3276 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3277 interpretation to data given by gdcmHeader. For instance there are
3278 heuristics to get informations (look at different places).
3279 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3280 sorting DICOM images based on different strategies.
3281 * modified Makefiles accordingly.
3283 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3284 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3285 when building in debug mode
3286 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3287 src/win32/gdcmdll.dsp
3288 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3290 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3291 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3294 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3295 * src/win32/libgdcmjpeg12.dsp was not dos format
3296 * src/win32/libgdcmjpeg12.dsp :
3297 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3298 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3300 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3301 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3303 * src/gdcmFile.cxx : bug fix in affectation type
3304 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3305 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3306 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3307 symbols... future problem ?
3309 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3310 * src/win32/libgdcmijpeg12.dsp was missing
3311 * modified gdcm.dsw accordingly
3313 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3314 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3316 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3317 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3318 commit of JPR (before his hollidays to facilitate our work).
3319 * setup.py : bug fix in code. Modifications made while the last commit
3320 of JPR. The code hasn't been tested before the commit... it's so
3321 useless to make that (for best programmer that is JPR) !!!
3323 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * tagged the current version as Version0_3 (i.e. version 0.3)
3326 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3327 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3328 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3329 * *.dsp : modifications to use new libgdcmijpeg8 library
3330 * setup.py : bug fix on VTKPATH variable
3331 * PACKAGER : adding all concerning windows
3333 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3336 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3337 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3338 test suite reported error.
3339 * PACKAGER file added (describes what a packager must do when
3340 packaging a new release).
3341 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3342 * configure.in: upgraded version number to 0.3.0
3343 * fixing build of rpm (through rpm -ta):
3344 - Doc/Makefile.am exports proper doxygen files
3345 - src/jpeg/libijg8/Makefile.am exports the include files.
3347 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3348 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3349 * src/gdcmHeader.h : formatting code
3351 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3352 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3353 We were obtaining error message from vtk. Now, creation of file list
3354 is made in an internal list to prevent this problem.
3355 Bug fix when output is empty.
3356 Bug fix in update of progress value. Previous commit for this was a bad
3358 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3360 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3361 * src/gdcmHeader.h : added method to get the file name
3362 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3363 files. Added method to remove all files on the input
3364 Added FIXME comment concerning the bad parsing of header made by
3365 ExecuteInformation method (in ExecuteData method)
3367 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3368 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3369 when using make instal.
3370 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3371 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3373 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3374 * setup.py : adding include dir of jpeg lib to compile all sources
3375 * */Win32/*.dsp : JPR fix for windows compilation
3377 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3378 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3380 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3381 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3383 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3384 * setup.py is again effective on un*x (takes into account the
3385 addon of the jpeg library)
3386 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3387 * Doc/Doxy* updated (includes above enhancements)
3388 * INSTALL now points to web documentation
3390 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3391 * src/gdcmHeader.h doesn't make unnecessary reference to
3393 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3395 * src/gdcm*.[cxx|h] :
3396 - to allow compilation with gcc 3.x
3397 -- clean up of STL usage (added explicit usage of std::)
3398 -- small fixes on exceptions.
3399 Note: linking not tested !
3400 - clean of doxygen comments to avoid warnings at documentation
3402 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3403 dependent convertion).
3405 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3406 * Clean up of previous JPR garbage commit (not even commented in the
3408 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3409 - moved all jpeg related files from src to src/jpeg/libijg8, with
3410 addition/modification of Makefile.am and configure.in.
3411 - the testSuite is still brain damage (not guilty).
3413 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3414 * WrapVTK.py : modifications to get correctly vtk source files to
3416 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3417 (FileName -> Filename)
3419 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3420 * vtk/vtkGdcmReader.[cxx/h]:
3421 - UpdateProgress method should now be effective
3422 - removed the limitation on having only images loaded (as opposed
3424 - when building a stack of images/volume, a lesser number of
3425 gdcmHeader and gdcmFile instances should be used (hopefully
3426 accelerating things).
3427 - when building a stack of images/volumes, files which are not
3428 loadable (wrong path-filename, wrong permissions on existing file,
3429 or file not parsable by gdcm) are replaced with a black image
3430 in the stack (for the caller to notice the problem).
3432 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3433 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3435 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3436 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3437 between standard library (std) and vtk library (problems are found
3438 under Windows... thanks Windows !)
3440 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3441 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3443 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3445 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3446 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3448 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3449 * When compiling with distutils (see setup.py) the C++ compiler is
3450 called with different flags than the default ones (with automake).
3451 In order to fix all those warning, I compiled gdcm with the command
3452 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3453 and went for warning fixes:
3454 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3455 up from unused variables.
3456 - vtk/vtkGdcmReader.cxx: potential bug fix.
3457 * src/gdcmHeader.h: Doxygen warning cleanup
3459 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3460 * gdcmPython/gdcm.i:
3461 - typemaps correction to take into account the systematic replacement
3462 of "using namespace std" with std:: prefix e.g. std::list,
3463 std::string... (cf changes of 2003-05-21).
3464 - gdcmGlob global variable of type gdcmGlobal (defined in
3465 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3466 exported to Python a as cvar.
3467 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3468 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3469 gdcmDictSet.GetPubDictTagNames() and
3470 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3471 C++ static methods).
3472 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3473 with the above changes.
3475 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3476 * setup.py, manifest.in : bug fix under linux
3478 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3479 * Modification of setup.py to compile vtk part too. Then, we have 2
3480 wrappers which must work with same distutils. For that, we have a
3481 generic distutils in distusiltsWrapping.py ; with :
3482 - build_extWrap class to wrap generically all extensions,
3483 - ExtensionWrap base class for all wrapping extension that contains
3485 - Wrapper interface which wrap sources
3486 + In WrapSwig.py we have extension and wrapper for Swig
3487 + In WrapVTK.py we have extension and wrapper for VTK
3488 * MANIFEST.in : modifications to consider vtk directory and new python
3489 files for compilation
3491 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3492 * Added python wrappers of vtkGdcmReader vtk class (see the
3493 source in vtk/vtkGdcmReader.cxx) :
3494 - vtk/Makefile.am now builds a library
3495 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3496 python library (as opposed to _gdcm.so wich are the python
3497 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3498 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3500 - configure.in has an additional flag --enable-vtk that needs
3501 to be set to enable compilation of vtk related code, that is:
3502 + vtk/vtkGdcmReader.so and
3503 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3504 + gdcmPython/vtkgdcmPython.so (see above)
3505 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3506 be read when compressed or when HighBit + 1 != BitsStored),
3507 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3508 the usage of the python wrapper of vtkGdcmReader vtk class.
3509 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3510 * src/*.[h] all occurences of stl classes are now prefixed with
3511 std::, and all occurences of "using namespace std;" where removed.
3512 This is to avoid pollution of global namespace in included files.
3513 Apparently vtk does not avoid this pitfall: when using both
3514 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3515 collision of various stl members (principally cout...).
3516 * gdcmPython/testSuite.py now cleanly removes temprory generated
3518 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3519 comply with above changes)
3521 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3522 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3523 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3524 vtk data structure (an image Flip was required).
3525 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3526 * cosmetic changes in documentation.
3528 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3529 * src/gdcmHeader.cxx: the constructor no longer exits when an
3530 unexisting file is given as argument.
3531 * The subdirectory Data (containing all the images used for the
3532 test suite) is not part of this repository anymore. A new module
3533 containing those images is now available at
3534 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3535 with the name gdcmData.
3536 All the python scripts (including the package initialisation file
3537 gdcmPython/__init__.py) were adapated to take this change into
3538 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3540 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3541 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3542 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3543 demo of the usage of this class.
3544 Compilation of this vtk part is only done when using the --enable-vtk
3545 at configure (or autogen.sh) stage.
3547 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3548 * More memory link related corrections and documentation fixes.
3550 - maximum info is obtained with a command of the form:
3551 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3552 --show-reachable=yes PrintHeader
3553 - the remaining reachable blocks seem to come from the STL
3554 allocation scheme through the usage of map and list. It looks
3555 like this memory cannot be freed but it is not a memory leak
3556 (in fact further invocation to the STL would recollect the
3557 unused memory allthough it cannot explicitely be freed).
3558 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3559 of displaying an image parsed with gdcm and displayed with VTK.
3560 Note: some images don't seem to work e.g.
3561 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3562 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3563 Allthough this weakens the semantics, it is a ditch attempt to
3564 make gdcm more thread friendly.
3566 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3567 * Memory link hunt (by using valgrind through the command
3568 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3569 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3570 gdcmHeader::_dicom_vr.
3571 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3572 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3574 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3576 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3577 * src/Makefile.am now exports all the necessary include files at
3581 * UpdateGroupLength replaced by new one
3584 * UpdateGroupLength re-written using H-Table
3585 (named UpdateGroupLengthNew untill checks are over)
3587 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3588 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3589 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3591 - gdcmHeader::GetPubElValSet removed.
3592 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3593 UpdateGroupLength, WriteElements, Write.
3594 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3595 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3596 carried the same semantics.
3597 - src/gdcmHeaderIdo.cxx changed accordingly.
3598 - gdcmFile::WriteBase now regroups all the codes from previous
3599 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3600 - enum FileType moved to gdcmCommon.h
3601 * src/gdcmHeader.cxx AddDefault trashed
3602 * gdcmGetXSize added
3603 * getimageDataSize now calls gdcmGetXSize
3604 * Test/*.cxx changed to agree with above changes
3606 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3607 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3608 (to avoid double call by end user).
3609 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3610 by end user, since gdcmHeader::gdcmHeader now handles it.
3612 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3613 * gdcm/Doc many doxygen changes:
3614 - Doxyfile now has two different versions, DoxyfileUsers that generates
3615 the html.users end users oriented documentation and
3616 DoxyfileDeveloppers that generates the html.developper developper
3617 oriented documentation.
3618 - README changed accordingly
3619 - requirement.txt removed (old design info moved to TODO).
3620 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3621 DoxyMainPage.txt, DoxyPython.txt provide more information.
3622 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3623 be updated by simply regenerating the docs with doxygen and copying
3624 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3625 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3626 all the tests in the form "if (<map>.count() >1)" were removed.
3627 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3628 ill-formed documentation sections.
3629 * src/gdcmHeader.cxx: ditto
3631 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3632 * setup.py fixed for un*x (needed macro for stdint.h)
3633 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3634 un*ces with sh-utils test utility.
3635 * gdcmPython/demo/test.py renamed to PrintHeader.py
3636 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3637 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3638 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3639 * src/gdcm*.cxx JPR's bad inclusion fixed.
3641 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3642 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3643 * gdcmPython/demo/test.py changed accordingly.
3645 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3646 * gdcmPython/Makefile.am fixed linking against libstdc++
3647 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3648 * Swig subdir (historical tests of swig version 1.3.17++) removed
3649 * Test/testChangeEntete.cxx some lines commented out in order to make
3651 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3652 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3654 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3655 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3656 hence the user doesn't need this explicit call.
3657 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3658 i.e. LoadElements() call removed.
3659 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3660 - src/Makefile.am declares the proper flag for g++.
3661 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3662 for adding user defined new tags.
3663 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3664 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3665 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3667 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3668 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3669 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3670 src/Makefile.am : the project should properly compile and install
3671 with the autotools, included the python wrappers part.
3672 * gdcm.spec.in : added a spec file for RPM packaging.
3674 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3675 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3677 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3678 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3679 to exported to the environement (see gdcmPython/testSuite.py
3681 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3682 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3683 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3684 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3685 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3687 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3688 * gdcmPython/__init__.py doesn't crash anymore when running in
3689 in InstallMode or PreInstallMode but with an environment given
3690 value of GDCM_DICT_PATH.
3691 * src/gdcmDictSet.[cxx/h] coding style.
3693 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3694 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3695 * src/gdcm.h general comments moved to TODO, and README
3696 * src/gdcm.h should now be seen as a user commodity (including it
3697 should suffice to fully use gdcm). It is nowhere including within
3698 any of the kernel files src/*.cxx and src/*.h.
3700 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3701 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3702 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3704 * src/gdcm*.cxx only include their corresponding include file
3705 (as opposed to gdcm.h)
3706 * gdcmPython/gdcm.i changed accordingly
3707 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3708 the autogen.sh generated "make snapshot" command to work.
3709 * autogen.sh removed history related references to crea package.
3711 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3712 * distutilsSwigCPlusPlus.py work around some swig portability
3715 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3716 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3717 was done in a last ditch attempt to get setup.py _really_
3718 operationnal. The python/gdcmPython layaout add the advantage
3719 of hidding away the python related distutils specific files
3720 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3721 Alas, the src directory was out of scope (i.e. it's relative
3722 position to setup.py was ../src) which made things impossible to
3723 handle (see previous version of python/setup.py). Crossing fingers...
3725 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3726 * python/setup.py now works on Un*x. (harder than I thougth)
3727 * python/distutilsSwigCPlusPlus.py can now have include files
3728 among the list of sources.
3730 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3731 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3732 * modifications in MSVC projects
3734 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3735 * As stated by the first lines of Test/ExceptionAndPython/README, it
3736 looks like we can move back to original usage of exception within
3737 src/gdcm* and hence remove the errno stuff that was introduced
3738 as a quick and dirty fixture of this problem (added to the TODO).
3739 * Doc/Doxyfile configuration file for Doxygen and corresponding
3740 README file for usage added.
3741 * Test/testWrite.cxx added. This new test comes from a split of
3742 test.cxx that is now reverted to its original purpous i.e.
3743 testing the proper parsing of a Dicom related file.
3744 testWrite.cxx concentrates on testing the IO part of gdcm.
3745 * Test/bug1.cxx (containing a bug on WIn32) added.
3746 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3747 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3748 whose purpose is to publish the content of the TagNames of the
3749 Dicom public dictionary were not accessible without an
3750 instance of class gdcmHeader.
3751 - those methods are now static methods of gdcmDictSet and hence
3752 require no instances at all to be invocated.
3753 - within gdcmDictSet this change required to change some method
3754 to class methods (i.e. are now static) among which SetDictPath
3755 (renamed to BuildDictPath) and LoadDefaultPubDict.
3756 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3757 the above changes by calling the new method classes of gdcmDictSet.
3758 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3759 the above to be effective.
3760 * python/gdcmPython: in order to wrap properly the above changes
3761 for Python, swig version now needs to be > 1.3.17.
3762 * python/gdcmPython/Makefile fixed to adapt itself to new
3763 configure/make shema introduced by Johan Montagnat (thanks for the
3764 contribution). Alas this Makefile cannot be turned into a proper
3765 Makefile.am without some heavy changes in the configure.in
3766 (for python dectection).
3767 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3768 now avoids publishing the empty entries.
3770 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3771 * python/setup.py : bug fix concerning install under windows
3772 ExtraPath reused :-P
3773 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3775 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3776 * Dicts/dicomV3.dic : remove double spaces !!!
3777 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3778 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3781 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3782 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3783 method. Doxygenation.
3784 * src/gdcm.h clean up of JPR spurious comments.
3786 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3787 * python/distutilsSwigCPlusPlus.py now properly collects the
3788 shadow classes generated by "swig -c++" (gdcm.py in our case)
3789 when using "python setup.py install".
3790 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3791 reexports the working classes.
3792 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3793 by the classical C errno scheme. This is to prevent an obscure
3794 behavior of the python wrappers when importing wxPython.wx prior
3795 to gdcmPython (which ended up in an abort call). An illustration
3796 of this oddity can be found in the Test/ExceptionAndPython
3797 subdir (see the README file). This problem probably due to
3798 an combination of g++ and dynamic loading.
3799 * added Test/ExceptionAndPython (see above)
3801 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3802 * Changed the layout of the python part to avoid bloating main
3803 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3804 i.e. the distutils arsenal. All the python related stuff is
3805 again in a python subdir, but the package itself is now in
3807 * setup.py was cleaned up:
3808 - pythonIncludePath removed
3809 - python setup.py bdist target is now functional.
3810 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3811 collision with other packages). gdcmPython/demo/*.py changed
3814 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3815 * python subdir moved to gdcmPython (preparation of distutils packaging).
3816 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3817 distutils installer is operational.
3818 * - gdcmPython/__init__.py now properly loads the swig generated
3819 shadow classes (from gdcm.py).
3820 - gdcmPython/demo/*.py changed to import the package gdcmPython
3821 instead of gdcmPython/demo/load.py.
3822 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3824 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3825 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3826 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3827 entries within the associated public Dicom dictionary resp. the same
3828 information but sorted by the fourth field (PAT, IMG, DIR) of the
3830 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3831 are now in the "???" group.
3832 - python/gdcm.i changed accordingly,
3833 - python/demo/printGroupedPublicDict.py added, that gives an example
3834 of the above new functionalities in Python.
3836 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3837 * src/gdcm.h, gdcmHeader.cxx:
3838 - historic references to glib's g_malloc and g_free (#defined)
3839 were definitively removed.
3840 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3841 * src/gdcmElValSet.cxx:
3842 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3843 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3844 - GetElValue(string) renamed to GetElValueByName.
3845 - Added GetElementByName(string).
3846 * src/gdcmHeader.cxx: added
3847 - GetPubElValRepByNumber(guint16, guint16)
3848 - GetPubElValRepByName(string)
3849 - GetShaElValRepByNumber(guint16, guint16)
3850 - GetShaElValRepByName(string)
3851 - GetShaElValByNumber(guint16, guint16)
3852 - GetShaElValRepByName(string)
3853 - GetElValRepByNumber(guint16, guint16)
3854 - GetElValRepByName(string)
3855 - GetElValByNumber(guint16, guint16)
3856 - GetElValRepByName(string)
3857 * Doc/requirements.txt added.
3859 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3860 * Test/Makefile building now depends on the one of libgdcm.so
3861 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3862 pixel data) aware which enables finding the address (offset) of
3863 the pixel data of JPEG encoded DICOM files. This leaves only a single
3864 file in the testSuite whose pixel data address (offset) is unknown.
3865 * python/testSuite.py changed accordingly.
3867 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3868 * VC++ has some strong limitations when working with the STL, as stated
3869 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3870 "Also note that some STL containers (map, set, queue, list, deque)
3871 cannot be exported. [...]
3872 Some STL classes contain nested classes. These classes can not
3874 This is caused by a designed limitation that once a template
3875 class is instantiated, it can not be re-instantiated and
3877 Since our usage of map<> is ubiquitous in gdcm, this "designed
3878 limitation" of VC++ is a pitfall.
3879 Hence the Python wrappers of gdcm cannot be incrementally linked
3880 against the c++ dynamic library. The dirty but only workaround is
3881 to forget about incremental link of dynamic libraries and to generate
3882 the Python wrappers library with the inclusions of the underlying C++
3884 The following modifications concern this matter on Win32/VC++:
3885 - wrapping python correct with standalone wrapped dll (don't use separate
3886 dll under windows !!!!)
3887 - python21_d debug mode enabled (ask Frog how to use it :-)
3888 - NO problem with having an STL member of class for example string in C++
3889 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3890 - Python test of dcmlib in Python is ok under windows on a large set
3892 * removed glib references
3893 * typedef's inserted in gdcm.i for correct swig type management
3895 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3896 * python/demo/*.py load.py extracted from test.py. Added explore.py
3897 that only displays required tags and testAll.py that parses all
3898 the files of the testsuite without using unittest.
3899 * python/testSuite.py other additional test on new files added.
3900 * Data/* new test files added accordingly to the testSuite.
3901 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3902 the vr in the file differs from the one of the dictionary.
3904 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3905 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3906 values, but limits itself to values which are below a user specified
3907 size (by default 1024 bytes).
3908 * python/gdcm.i : elements not loaded (because their size is above the
3909 user specified treshold) are exported with their TagKey as key of the
3910 python dictionary. This enables the testsuite to make some checks
3911 on the unloaded elements (since we have their offset and size).
3912 * python/testSuite.py
3913 - now tests for the existence and proper value of the pixel data
3914 - two new examples added.
3915 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3917 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3918 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3919 aware. See the strategy comments in gdcmHeader::FindLength().
3920 * Test/test.cxx now accepts a filename as first argument.
3921 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3922 * python/testSuite.py changed to integrate test on above files.
3924 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3925 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3926 the vr was also RET.
3927 * python/testSuite.py more tests added.
3929 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3930 * python/testSuite.py unittest test suite added (uses Data)
3931 * Data/* dcm and acr files for the test suite.
3932 * glib dependance removed from un*x version. We now use ISO C99
3933 7.18 Integer types (see stdint.h)
3934 - python/Makefile, src/Makefile src/gdcm.h
3935 * src/ when an explicit vr (like dicom files) suddenly poped an
3936 implicit element we use to mark the underlying DictEntry of the
3937 concerned ElValue with "Implicit". This strategy was damageable
3938 too the public or provite dictionaries, since some of their vr
3939 would be changed. Since Header::FindLength heavily relies on the
3940 detection by Header::FindVR of falsely explicit elements, I
3941 added an extra ImplicitVr member to ElValue (boolean).
3942 The rest of the changes we the necessary adaptations.
3944 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3945 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3947 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3949 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3950 * Adaptation for porting to VC++:
3952 o forced to use std namespace (for string to be known)
3953 o all class use __declspec export style on WIN32
3954 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3955 (in stdlib.h on Win32 but in std:: for gcc)
3956 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3957 variable GDCM_DICT_PATH.
3958 * src/gdcmHeader.cxx verbose comments made discrete.
3960 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3961 * python/gdcm.i: added a typemap that converts a C++ hashing table
3962 to native Python dictionary.
3963 * python/demo/test.py:
3964 - now uses the native dictionary for exploration of gdcmHeader.
3965 - takes an optional filename argument (the file to parse).
3966 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3967 PubElVals hashing table.
3968 * Dicts/dicomV3.dic removed error prone trailing spaces.
3970 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3971 * Python wrapping process moved away from src/Makefile to
3972 newly created python/Makefile (as well as gdcm.i)
3973 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3974 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3975 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3976 from the environement variable GDCM_DICT_PATH (when existing).
3977 * src/gdcmDict::GetTag bug fix.
3979 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3980 * Straightforward temporary fixes for swig to build the python wrappers.
3981 src/Makefile now has a python working entry [by working we mean
3982 that we can import the shadow classes without errors].
3984 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3985 * hashtest.cxx removed (since already in Test)
3986 * src/gdcmlib.h renamed to src/gdcm.h
3987 * src/dcm.i renamed to src/gdcm.i
3988 * src/Makefile prepared for python wrapping
3990 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3991 * src/gdcmHeader.cxx :
3992 - Parsing of header is now separated from loading of element values
3993 (see gdcmHeader::LoadElements).
3994 - general clean up of hopefully all file access (creation of
3995 ReadInt16 and ReadInt32)
3997 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3998 * src/gdcmHeader.cxx :
3999 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4001 - SetLgrElem renamed to SetLength
4002 - GetLgrElem renamed to GetLength
4003 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4004 * src/gdcmElValSet.cxx fixed both GetElValue methods
4005 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4006 due to IdoDude was cleaned out.
4008 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4009 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4010 concentrates on finding the value representation (when it exists).
4011 RecupLgr now only finds the element value length, and it avoids
4012 returning the unecessary skL (skipped length).
4013 Also, offsetCourant was simply removed (with taille_fich) since
4014 it was redundant with the File position internals (by using
4015 ftell and fseek). This also made skL (see above in RecupLgr) usage
4017 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4018 on the libido specificities which are handled through class
4020 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4023 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4024 * Truckload of changes. Parsing of header is barely functional
4025 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4027 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4028 * src/gdcmHeader.cxx many addons of low level methods
4030 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4031 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4032 and _IdDcmSWAP_LONG.
4034 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4035 * This corresponds to all the changes decided at the meeting of
4036 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob