1 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * merging of Test/PrintDicomDir and Test/TestDicomDir
3 * removal of now redundant Test/PrintDicomDir
4 * enhancement of Example/PrintDicomDir
6 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * Now, python test might work on systems
8 * Add the PrintDicomDir test
10 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
11 * FIX : First entry following group 0002 was lost for
12 Explicit Big Endian Transfer Syntax files
13 (group and elem not swaped)
15 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
16 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
17 Big Endian Transfer Syntax supposed the group following 0002
18 begins always by element 0000 (element 0000 is *optional*)
19 To avoid further troubles, let's be pessimistic, and use
20 Document::HandleOutOfGroup0002() method
21 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
22 (related pb not yet solved)
24 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Bug fix for the python part use
26 * Now, PrintHeader.py pass... but outside the ctest use. shit !
28 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
31 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
33 a string and should ask the global TS dict what are the propreties of
36 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
38 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
39 to swap the Swap Code, at parsing time, when we come out of group 0002
40 and Transfer Syntax is Big Endian
41 We should be able to read now 'true DICOM" Big Endian coded images
42 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
43 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
45 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * Hopefully fix the bug on MacOSX and static global initialization.
47 This is the only -minor- patch I found that both please MacOSX and VS6.
48 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
49 but this would require a lot of change. Another approach would be that Global
50 create those string and GDCM_UNFOUND becomes a pointer to a string (which
51 gdcm::Global would destroy at exit).
53 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * Fix bug on MacOSX with static initialization in a multy threaded
55 environment. static const string in a header file used to be ill
56 initialized provoquing the freeze of any tests. patch should solve this
59 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
60 * According to Benoit's suggestion, and without any objection from anybody
61 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
62 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
63 - method gdcmDicomDirObject::GetEntry() renamed as
64 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
66 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
68 you debug/warning message just as c++ streams which make them very convinient
69 to use. Once this is stabilize I will change the ostringstrem to be
70 redirected to a file (ofstream).
71 * Properly support C99 extension: __FUNCTION__ which allow us to display
72 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
74 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
75 * Removal of useless and dangerous methods :
76 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
77 GetDocEntryByName, GetEntryByName, GetDictEntryByName
78 * Removal of usless methods :
79 Dict::PrintByName, Dict::GetDictEntryByName
80 * Commenting out of probabely useless methods :
81 Dict::GetDictEntryNames()
82 Dict::GetDictEntryNamesByCategory()
83 DictSet::GetPubDictEntryNames()
84 DictSet::GetPubDictEntryNamesByCategory()
85 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
86 * ENH : Use dicomTS.dic as described in 2004 version
87 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
88 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
89 Add Accessors on VM (Value Multiplicity), and VM related methods
90 * ADD : Add a list of 'Dicom Attribute types', as found in
91 http://medical.nema.org/dicom/2004/04_15PU.PDF
93 * ADD : Add dicomGroupNameAbbreviations.dic
94 should be used to write a method to replace the former
95 Dict::GetDictEntryNamesByCategory()
97 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
99 to read in the file... and only it ! Length is the efective length of the
100 data in the DocEntry structure
102 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
104 And now use a static function call instead, with a global variable. i
105 This is much closer to the VTK approach. Hopefully should be bulletproof
106 and easier to use...hopefully
108 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
109 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
111 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
114 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
116 ValEntry, BinEntry, SeqEntry creation or replace
118 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
120 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
122 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
123 when specifying the VR
124 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
125 * src/gdcmDocEntry.cxx : amelioration of print
127 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
128 * ADD : Add the method Util::IsCurrentProcessorBigEndian
129 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
130 * ADD Method Document::ComputeGroupLength
131 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
132 in order to allow further VR modification by user
133 * REM : removal of once-called method File::WriteBase
134 integration of its code in formerly one-line method File::Write
136 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
138 replace the different values "??", "Unkn", "Unknown".
139 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
140 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
141 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
142 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
144 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
147 * Set the gdcm::Base class to some Printable classes
149 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmFile.[h|cxx] : add the Print method
151 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
152 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
153 * src/gdcmDocument.h : remove the PrintLevel informations
154 * Example/PrintFile.cxx : use the new gdcm::File::Print
156 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
158 problems when compiling with the python wrapping
160 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
162 writting in ImplicitVR
164 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
165 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
166 JPEG decompression, especially when dicom frames are split into several
167 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
168 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
170 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/gdcmHeader.cxx : change the initialisation of default header.
172 Now, this header is readable by gdm, e-film, DicomWorks
174 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
176 Rename Decompressed to Raw
177 * Use the API changes in gdcm::File.
178 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
181 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
183 each added entry in the header. Replace the 'Planes' field by the 'Number
186 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
188 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
190 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
192 At this time, this image isn't readable by e-film... waiting JPR help to
195 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
197 DocEntry. Now use methods of the Document !
199 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * Test/ShowDicomSeq.cxx : bug fix
202 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
204 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
205 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
206 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
208 * Test/TestCopyRescaleDicom.cxx : remove unused variable
209 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
210 containing found sequences
212 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
215 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
216 Some fields in BinEntry must be copied to not seg fault when making the :
217 gdcm::File *copy = new gdcm::File( copyH );
218 and tests are now made on good variables
220 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
222 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
224 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
225 * Add vtkGdcmWriter example and test
227 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * Test/TestUtil.cxx : reformat the source code
229 * vtk/vtkGdcmReader.cxx : remove and change prints
230 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
232 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
233 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
235 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
237 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
239 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
241 by an eof to prevent all bad read of the file... and in this case, the
244 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * Example/Volume2Dicom.cxx : comment unused variables
246 * Test/PrintDicomDir.cxx : comment unused variables
247 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
248 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
249 method that is redondant with AddEntry.
250 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
253 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * Bug fix due my last commit (compilation under Windows).
255 * Example/Volume2Dicom : bug fix in the file and reformatting source code
256 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
258 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 - Remove printf / sprintf
261 - include iostream AFTER gdcm so we don't get warnings
262 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
264 - Also remove tons of include from header files, hopefully this should
265 speeup the compilation time, since it was becoming a dog slow.
266 - Remove gdcm.h as it include way too many files and slow down compilation
267 (plus it is not up to date)
268 - remove 'using namespace std' this is BAD !
270 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * Remove memory leaks on the DicomDir
272 * Remove some useless data in DicomDirObject
273 * Add usefull methods in SQItem, to be complient withe the ElementSet
275 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
278 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
280 future, with convertion)
281 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
282 and ImageDataSize values. Remove the method to get the PixelReadConverter
283 from the output of the class
285 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
288 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
290 and vtkErrorMacro use.
291 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
293 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
296 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
297 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
298 The string leaves only in the fonction. So when we make a .c_str(), we
299 get the pointeur on the first element, element that will be destroyed
300 immediately after thee instruction.
301 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
302 file has been opened : the test must be made on the content of the
303 pointer and not directly on the pointer !
306 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
308 the python part recompiles
310 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
312 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
313 X session is killed (for my computer... it seems to not be identic on
316 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
318 avoid problems (otherwise, the difference test between the visible image
319 and the reference is incorrect. If the reference is greater than the
320 screen resolution, it's produce errors).
321 Can be used for only one image. Can be used with a visible flag.
322 * vtk/vtkGdcmReader.cxx : remove commented codes.
323 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
324 under windows at compilation
325 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
327 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
329 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
331 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
332 tests on the image size X, Y, Z
334 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
336 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
337 between the class name and the file name
339 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * src/ : fix compilation warnings for the Write method (2 different
341 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
342 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
343 variable... create a static method in gdcm::Document to access to
344 this variable content.
346 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
348 file, to be accessed by other files (like gdcmFile). Remove commented
349 code. Move the change of the header to the gdcmFile, using the
351 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
352 To be sure of that (and simplify calls), the Write of the header now
353 gets a file name and not a file pointer (std::ifstream).
354 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
355 DocEntryArchive. Remove all open of the written file
357 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
360 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
362 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
364 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
365 some corresponding methods. Write correctly the file and check before
367 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
368 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
369 is now on RGB data (as before my last commit
370 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
372 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
373 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
374 Add a print information of the type of the entry
375 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
376 It was in the gdcmFile, and all write have been regrouped
377 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
378 Write correctly all dicom files (in decompressed mode only at this time)
379 * Test/ : test on files are now made using Raw data and not color data if
381 * Example/PrintFile.cxx : add more printings
383 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * Amelioration of code, remove some code copy. For the loading of
385 BinEntry (in gdcmDocument), add the test to verify if the file is already
388 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
390 remove a DocEntry in the header (push an empty DocEntry)
391 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
392 lines. Bug fix in the initialization of the PixelConvert and the
394 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
395 use in TestCopyDicom (now this test can run under windows... but fails)
396 * Test/TestCopyDicom.cxx : amelioration of the test :
397 - test the pixels written
398 - add test points to quickly find where is the error
399 - can set a file name input and output in arguments
400 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
401 amelioration of the test output
403 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
405 all replaced DocEntry's
406 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
407 Now, each needed DocEntry to modify is duplicated, modified and inserted
408 to the header using DocEntryArchive. Thus, after save, we can restore the
409 header initial state.
411 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
414 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
416 correct to copy it. The DictEntry is specified at the DocEntry creation,
417 then, it musn't change in the time.
418 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
419 header correctly. At this time, the change is only made for the first
420 level of the Document. In the future, it might consider sequences.
421 The change is made by replacing a DocEntry by an other that is created
422 outside the class. The old value is kept. When we restore the header
423 status, the added DocEntry is deleted and replaced by the old value.
424 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
425 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
426 set the write type to explicit VR, implicit VR or ACR. Add methods to set
427 the write mode to native, decompressed or RGB (but not used at this time)
429 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
431 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
433 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
435 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
437 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
438 set because already copied when copying the BinEntry's of the header
439 * Test/TestAllReadCompareDicom.cxx : remove warnings
441 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
443 Two problems appear when doing it :
444 - with the gdcmFile : when the GetImageData method is called, the pixels
445 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
446 data (pixels). And each structure destruct the data when it's
447 destructed. So we have two destructions for the same data. To solve it,
448 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
449 data or not. If it doesn't own data, then they will not destroyed by
451 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
452 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
453 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
454 create a double destruction of the same DocEntry's. So, to solve it,
455 the TagHT is simply cleared and the DicomDir* elements are destroyed.
456 * TODO : add an entry concerning memory leaks in the DicomDir
458 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
460 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
463 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
465 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
466 after it have been deleted
468 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * FIX: src/* fix the doxygen warnings.
470 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
471 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
472 was erroneously defined with a size of 15 instead of 16. [many thanks
473 to Jean Michel Rouet for pointing out this bug].
475 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
476 1. Finish merging JMR patch for writting DICOM from scratch
477 2. Fix -hopefully- bug with MONOCHROME and space vs null character
478 3. Use const ref when possible
479 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
480 5. A few more comments
481 6. CreateUniqueUID can now be called without parameter"
483 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
484 * ENH: Slightly bigger patch:
485 1. Getting toward full integration of JMR patch for writting dicom from scratch
486 2. Update Test to test part of this patch: CreateUniqueUID
487 3. File was not close properly in gdcmDict
488 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
489 5. Use of const ref instead of copy (speed issue)
490 6. Remove temporary (duplicate) string in TranslateToKey
491 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
492 8. Do not repeat virtual in subclasses
493 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
495 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
496 * Apply first patch toward better string comparison when dealing with broken
497 DICOM files. Essentially the string could be padded with a space instead
498 of a null character as defined by standard
500 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
502 because never used... and in the same time, that's remove some memory leaks
504 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmFile.cxx : now delete the PixelConvert instance.
506 * In examples and tests : change the type of image data variables from void*
507 to uint8_t*. Remmove all delete on image data variables
509 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
511 Verify the file pointer value before open the file, and if it's not null,
512 a verbose message is generated.
513 Close correctly the file when the file isn't considered dicom-like. The
514 correctly close is a call to CloseFile.
515 When closing the file pointer, test if its not null to close the file.
516 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
517 file. For an uncompressed image, the copied data correspond in the least
518 case to the image size (calculated) or the image size specified in the
519 header. A verbose is generated if these two size mismatch
521 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
523 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
524 break under windows (with msvc6 compilation).
526 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
528 compiling with MSVC6)
530 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * Bugs fix for the Windows build with VC6
532 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
533 needed (only for projects required VTK). If the VTK is included in all
534 projects, there is conflicts with the jpeg lib of vtk when compiling the
535 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
536 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
537 when compiling the gdcm_wrap.cxx file (created by the compilation of the
539 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
540 (like it's already made for the cout use). Otherwise, conflict with the
543 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
546 - comments on the DicomDir::Method related usage added.
547 - now that we use the namespace gdcm, a lot of internal classes do
548 NOT need to be wrapped anymore.
549 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
550 DicomDir::Method) new example added.
552 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
553 * Improve string manipulation. I now inforce the notion of 'DicomString'
554 A DicomString can contain as many \0 as they want
555 and it is *always* of even length.
556 We only support odd length for very rare case.
557 And in the near future this should be removed.
559 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
560 * /binary_write/ gdcm source. Now even on big endian we are writting
561 little endian. This should -heopfully- fix some tests
563 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
564 * Now the dictionary is compiled into gdcm lib. This is a default
565 behavior, thus any dic file specified is picked before failback to
566 the one comiled into lib
568 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * Change internals for gdcmDict. Don't use any 'new' any more.
570 This should definitely solve any leak problem, and we should be
571 as fast as before, as long as don't modify too much the dictionary.
573 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
574 * STYLE: ivars should start with a capital letter.
575 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
576 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
578 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
580 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
581 new 2004 dictionaries added (thanks to JPR).
582 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
583 * CLEANUP_ROUND (15) for gdcmPixelConvert
584 - RLEFrame::NumberFragments is now of type unsigned int
585 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
586 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
589 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
590 * Initial work in gathering all transfer syntax accessors. clearly
591 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
592 ivars, but only one transfersyntax (class) ivar with equivalent method on
595 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
596 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
597 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
598 discussed (plus I didn't like having a 2000 lines patch not commited)
600 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
602 * CLEANUP_ROUND (14) for gdcmPixelConvert
603 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
604 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
605 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
607 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
608 anymore and hence avoids storing a copy of PixelConvert::Decompressed
609 into File::Pixel_Data.
611 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
613 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
614 * CLEANUP_ROUND (13) for gdcmPixelConvert
615 Substituted File::ParsePixelData() with PixelConvert::Print() new
617 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
618 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
619 method to those classes.
620 - src/gdcmFile.[cxx|h]:
621 -- Added a ::Print() method.
622 -- PixelConverter is now a reference instead of a member.
623 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
624 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
626 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
628 collaboration diagram and inheritance diagram should be generated with
630 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
631 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
632 pointlessly wrapped (see
633 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
634 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
635 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
636 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
637 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
638 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
639 -- File::Initialise: PixelConverter setup moved away to
640 PixelConverter::GrabInformationsFromHeader()
641 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
642 interpretation moved away to PixelConverter::BuildRGBImage()
644 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
645 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
646 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
648 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
650 displayed on Win32 when a brutal abort() occurs (because of uncatched
651 exception). See TODO new entry of this commit for more on this.
652 * TODO added new entry.
653 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
654 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
655 - HandleColor is no longer called from gdcmFile.cxx
656 - gdcmPixelConvert.cxx clean up on method arguments and internal
657 variable names for semantical coherence.
659 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
660 * Finished lossless transition, not only do we now read all lossless jpeg
661 images, without the need of the Cornwell lib, but we do read them properly now
662 * To reduce code (well to avoid code duplication), I defined a common place
663 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
664 redefine symbols. This is not perfect but this the best solution I found for a
665 compilation time jpeg option.
667 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
668 * Update jpeg ijg lib to support lossless jpeg implementation
669 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
671 * Also added a special copyright for dcmtk since we use their bugfixes.
674 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
676 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
677 matters, as stated in warning note at begining of %include section).
678 * src/gdcmDicomDir*.[cxx|h]: coding style
679 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
680 * src/gdcmJpeg8.cxx: doxygen fix.
681 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
682 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
683 from File:: to PixelConvert::.
685 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
687 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
688 - more code moved away from File:: to PixelConvert::
689 - fat setup of PixelConverter set in place in File::Initialise.
691 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
692 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
693 namespace at the file system level. So now you should convert your examples
695 gdcmHeader -> gdcm::Header
696 It would be nice if people keep in mind to no open the namespace, since it
697 allows compilation on broken plateform which were defining common symbol in
698 the standart namespace (like LP, Unknown ...)
700 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
702 The JPEG fragments are now parsed at the same stage than the RLE
703 information. All code related to JPEG is now in gdcmPixelConvert:
704 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
705 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
706 export a gdcmFile:: method. Those are simply global functions
707 (for the time being this is better than having them attach to
708 either gdcmFile:: or gdcmPixelConvert::).
709 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
710 and stores the result in a gdcmJPEGFragmentsInfo.
711 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
712 code (among other stuff) moved away from gdcmFile:; to
715 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
717 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
718 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
719 clean up of RLE related code.
720 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
721 - src/gdcmRLE.cxx removed
722 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
723 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
724 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
725 * CLEANUP_ROUND (9) for gdcmPixelConvert
726 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
727 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
728 away from gdcmFile:: to gdcmPixelConvert::.
730 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
731 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
732 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
733 This is because Parse7Fe0 used to parse the pixels to compute the
734 length. This task was passed over to FindDocEntryLengthOB() a long
735 time ago, EXCEPT I had forgotten the OW case...
736 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
737 we just recylce the code for parsing RLE fragments and computing
739 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
740 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
741 with the retired Parse7Fe0().
742 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
743 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
745 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
746 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
747 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
748 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
749 - src/CMakeLists.txt: alphabetic order reodering + new entries.
750 * CLEANUP_ROUND (4) for gdcmPixelConvert
751 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
752 to return an unused length.
754 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
755 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
756 this should be cleanner from the plane view. The iostream are erally a pain
757 to use to do simple stuff.
759 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * Redo the compilation of the ijg jpeg library. Now only one source is
761 necesseray. No need to rename file by hand what so ever. CMake handle the
762 copying of the file within different directory, configure header file to
763 modify some symbol. The only addition made to ijg wasd a mangle table so
764 that symbol are different wether we are within 8bits or 12bits.
766 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * Added documentation of vtkgdcmReader on Website:
768 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
769 with it's binary name).
770 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
771 the Website to be more complete.
772 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
773 doxygenated documentation.
774 - Doc/DoxyVtkGdcmReaderExamples.txt added
775 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
776 DoxyVtkGdmReaderExamples.html )
777 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
778 * CLEANUP_ROUND (3) for gdcmPixelConvert
779 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
781 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * CLEANUP_ROUND (2) for gdcmPixelConvert
783 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
785 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * CLEANUP_ROUND for gdcmPixelConvert:
787 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
788 - src/gdcmPixelStuff[h|cxx] removed
789 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
790 - src/CMakeLists.txt changed accordingly
792 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
793 gdcmVersion.py moved to newly created ATTIC related
794 gdcmPython/SetupOldies/ directory.
795 * Autotools clean up:
796 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
797 - autogen.sh configure.in acinclude.m4 python.m4 removed
799 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * src/*.cxx *.h Reference to License.htm fixed to License.html.
801 * Doc/CMakeLists.txt, doxygen.config.in: fix.
802 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
804 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * TODO updated with Mathieu suggestions. I proposed a template for
806 describing TODO entries and used it for new entries.
807 * Added Doc/Website/CodingStyle.html, Developpers.html,
808 DeveloppersPython.html, GdcmDataCvs.html and
809 DownloadVersion0_1.html, DownloadVersion0_3.html.
810 * Some Doc/*.txt Doxygen files (which do not really concern the
811 documentation itself, but the website) moved to html and
812 placed in directory Doc/Website:
813 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
814 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
815 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
816 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
817 * CMakeLists.txt changed accordingly.
818 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
819 DeveloppersPython.html
820 * INSTALL nows refers to Doc/Website/Installation.html
822 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * Added Doc/Website directory, that contains a first raw version
826 2004-09-23 Jean-Pierre Roux
827 * FIX In order not to be poluted any longer by casting problems,
828 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
829 we can now delete[] it safely
830 * VoidArea is now called BinArea (less confusing name),
831 and all the methods called ...VoidArea... are now ... BinArea...
832 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
834 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
836 clear) TagHT, which is an inherited member of gdcmElementSet. It is
837 up to the destructor of gdcmElementSet to clean up TagHt and it's
840 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * Test/CMakeLists.txt: update to follow gdcmData renamings.
842 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
844 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * ENH: added some utility method that builds a flat dictionnary
846 holding all the Dicom entries contained in the recursive structure
847 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
849 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
850 BuildFlatHashTable() that build a flat dictionary.
851 - src/gdcmElementSet.h: added a new private GetTag() accessor.
852 gdcmDocument is now a friend of gdcmElementSet.
853 - src/gdcmElementSet.cxx: clean up.
854 - Example/FlatHashTablePrint.cxx added.
855 - Example/CmakeLists.txt changed accordingly
857 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
858 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
859 moved away from gdcmDocEntrySet (since this class is an abstract class
860 acting like an interface). SQDepthLevel and BaseTagKey are now
862 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
863 and associated accessors. Doxygenation of the class.
864 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
866 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
867 Use SQDepthLevel accessor instead. ::Print() adapted.
868 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
869 - src/gdcmDocument.cxx changed accordingly.
871 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
873 - The following is the doxygen comment of the typedef declaration
874 of gdcmTagKey in src/gdcmCommon.h:
875 gdcmTagKey is made to old an "universal" (as in URL, Universal
876 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
877 A dicom tag always has a group and an element, but a set of tags
878 embeded in various (optionally nested) sequences and sharing
879 the same group and element all share the same (group, element)
880 "identifier". Hence the (group, element) cannot be used as an
881 identifier (in gdcm we shall refer to a "TagKey") of a tag.
882 In order to construct a proper tag identifier (i.e. a key) we
883 consider the following definition of a TagKey:
884 - let Group, Element be the string representation of the
885 group and element dicom tag members,
886 - let ItemNumber be the string representation of the integer
887 index of the considered item number of a sequence,
888 Let the key of a tag embeded in a sequence, noted SeqTag, be
890 /ItemNumber#Group|Element
891 where "/", "#" and "|" are characters acting as separators.
892 Then the general form of a gdcmTagKey is given by:
893 Group|Element<SeqTag>
894 where <SeqTag> means NO or many instances of SeqTag.
895 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
898 but the gdcmTagKey of a tag "embeded" is the first item of
899 a sequence, itself nested in the third item of a sequence is the
901 0004|1220/2#0008|0082/0#0008|0090
902 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
903 order to hold the new sequence compatible key. Previously, the
904 GetKey() method would look in the underlying gdcmDictEntry.
905 - src/gdcmDocEntry.cxx:
906 -- constructor now copies the underlying DictEntry key, in the local
908 -- ::Print: displays the member Key, instead of the (group, element).
909 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
910 - src/gdcmDocEntrySet.h:xi
911 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
912 -- now has a new BaseTagKey member.
914 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
915 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
917 This poses the problem with the semantics of the following lines
918 LoadEntryVoidArea(0x0028,0x1201); // R LUT
919 LoadEntryVoidArea(0x0028,0x1202); // G LUT
920 LoadEntryVoidArea(0x0028,0x1203); // B LUT
921 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
922 to the long FIXME note for what the problem is. Nevertheless in
923 order to get things working the dicom dictionary was altered !
924 Please fix things urgently...
925 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
926 information), see above note on moving the member VoidArea. Nevertheless
927 the following entries previously correctly set as US are now inproperly
929 0028 1201 OW IMG Red Palette Color Lookup Table Data
930 0028 1202 OW IMG Green Palette Color Lookup Table Data
931 0028 1203 OW IMG Blue Palette Color Lookup Table Data
932 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
933 of gdcmDocEntry moved to gdcmSeqEntry.
934 * src/gdcmSeqEntry.cxx: STYLE.
936 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Test/TestAllEntryVerify.cxx minor fix and added comments.
939 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * gdcmPython/testSuite.py: all the test suite in python is now moved
941 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
942 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
943 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
945 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
947 to avoid inclusion recursion until STL is reached.
948 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
949 mecanism. errno.h is not included in gdcm anymore.
950 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
951 (gdcmFormatError now inherits from gdcmFormatUnexpected).
953 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
954 gdcmData/TestAllEntryVerifyReference.txt
955 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
956 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
957 exception_on_error parameter.
958 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
959 - vtk/vtkGdcmReader.cxx changed accordingly,
960 - Example/*.cxx and Test/*.cxx changed accordingly.
962 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
964 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
965 enable_sequences removed from gdcmHeader constructor and dependencies.
966 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
967 * gdcmPython/demo/PrintHeader.py: dummy fix.
968 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
969 skip_shadow removed from gdcmHeader constructor and dependencies.
970 * Example/*.cxx and Test/*.cxx changed accordingly.
972 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
973 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
974 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
976 2004-07-21 Jean-Pierre Roux
977 * FIX Now, Parsing and Printing a DICOMDIR do work!
978 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
980 2004-07-20 Jean-Pierre Roux
981 * FIX Some brain damaged headers have Zero-Lenght fields
982 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
984 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
985 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
986 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
987 variable (instance of gdcmDebug) by a definition macro, and the instance
988 is now in static in the gdcmDebug class
989 * src/gdcmSQItem.h : (FIXME) remove an undefined method
990 * Test/PrintAllDocument.cxx : bug fix in the result of the test
992 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * WARNING: ctest now depends more tightly on gdcmData. You should
994 check out gdcmData properly for things to run smoothly...
995 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
996 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
997 we need the pixels not be loaded in order to use the ValEntry
998 that displays position and size).
999 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1000 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1001 be deprecated. If you have any doubts about the advantages of a
1002 modern scripting language (read Python) versus grass root C++ (i.e.
1003 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1004 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1005 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1006 Anyhow, consider documenting the gdcmData images in
1007 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1009 * Test/CMakeLists.txt:
1010 - now uses TestAllEntryVerify.cxx
1011 - specific comments on oldACR00001.ima (now renamed in gdcmData
1012 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1013 gdcmData/TestAllEntryVerifyReference.txt
1016 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1017 * src/*.[h|cxx] : typedef clean up
1018 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1019 - TagKey renamed to gdcmTagKey (for external usage)
1020 - VRKey renamed to gdcmVRKey (for external usage)
1021 - removal of typedef duplication.
1022 - Removed all unecessary inline keyword from class inline definitions.
1023 - Some method|function(void) declarations replaced with method|function().
1024 * src/jpeg/libijg12/jdhuff12.c:
1025 - printf polluting ctest removed.
1026 - TAB removal for comminting
1028 - TestAllReadCompareDicom.cxx: added a test that compares all the
1029 images in gdcmDataImages.h with corresponding images in
1030 gdcmData/BaselineDicom/. When baseline images are not present
1031 this test creates them.
1032 Note: we need to validate each reference image, but before that
1033 I'd like to rename them with a more explicit name...
1034 - CMakeLists.txt: changed accordingly.
1035 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1036 including each header needed).
1038 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1039 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1040 test suite to the Example directory. Are concerned:
1045 - TestWriteSimple.cxx
1046 * Test/CMakeLists.txt: added some comments on reasons for black listing
1047 image gdcmData/oldACR00001.ima
1049 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * Test/CmakeList.txt: removed the following from black list (to be coherent
1051 with removal from gdcmData):
1052 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1053 - gdcm-MR-PHILIPS-16.dcm
1055 Added the following because after last cvs update, they cause
1056 ctest -R TestReadWriteReadCompare
1058 - gdcm-MR-SIEMENS-16-1.acr
1060 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1061 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1062 new comments in this file) we temporarily (sigh) move to a weaker
1064 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1065 we don't need to black list the following images anymore:
1066 - 8BitsUncompressedColor.dcm
1068 - US-PAL-8-10x-echo.dcm
1069 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1070 fixes and the beautified code ;-)
1071 This fixes the bug introduced in version 1.42 (when beautifying)
1072 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1073 Note: ctest was blind to this bug (this means we need to still
1074 improve the test suite). The bug could be detected by using
1075 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1077 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1078 and by displaying the (garbage) produced file temp.XDCM...
1080 2004-06-29 Jean-Pierre Roux
1081 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1082 - replace by uggly but working old code :-(
1083 A lot of things should be OK again.
1084 It's really urgent to have a test suite that *tests*,
1085 to prevent Frog's beautifying sessions to break all the stuff
1086 (twice, withing a fortnigh ...)
1088 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1090 redundancy) to added Test/TestReadWriteReadCompare.cxx
1091 * Test/CmakeList.txt: because the compare test of
1092 Test/TestReadWriteReadCompare.cxx fails, the following images are
1093 black listed: - 8BitsUncompressedColor.dcm
1095 - US-PAL-8-10x-echo.dcm
1096 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1097 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1098 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1099 and ad-hoc kludge. This kludge is now removed, and on encountering
1100 such an image (OB field brain damaged) we set errno. Then in
1101 ::FindDocLength() we "fix" the length as being ALL what remains
1102 in the file (until EOF). We then proceed, hoping for the best...
1103 This fixes a SegFault in ShowDicom when trying to write such an
1105 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1106 (because TestWriteRead breaks on it, after a non conformal commit?).
1107 ctest now runs properly, except for MakeDicomDir (which was always
1108 broken) and the Python related stuff (still not fixed).
1110 2004-06-24 Jean-Pierre Roux
1111 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1112 FIX : Test/TestReadWrite now iterates on all the file names
1113 (instead of infinite loop)
1114 ENH : Test/TestWriteRead now iterates on all the file names
1116 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1119 2004-06-24 Jean-Pierre Roux
1120 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1121 when SamplesPerPixel =3
1122 - now Write is no longer confused by
1123 'BitsAllocated = 12" and 'BitsStored=12"
1124 - "UN" value representation Elements are now written correctly
1125 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1126 ENH : - now gdcmHeader has its own Write methods
1127 (in order to split the job that has not to be done
1130 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1132 loop on the same image until memory went out.
1133 Note: this means we still have gobs of memory loss in PrintDocument
1134 * src/gdcmDocument.cxx: fixes problem on parsing on file
1135 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1137 2004-06-24 Jean-Pierre Roux
1138 FIX : Write - All the Sequences and Sequence Item are now written
1139 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1140 is added a the end, when necessary.
1141 - A lot of brain-damaged images, that were read correctly are
1142 now written correctly
1143 - length compatible BinEntry are now loaded correctly
1144 (even for odd groups)
1145 Note : only Explicit Value Representation was checked.
1146 (question : is implicit VR really necessary for gdcm ?)
1148 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * DEVELOPPER: added a proposition of coding style.
1150 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1153 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1155 Use the gdcmDocEntry::Print() and Write() instead.
1156 * src/gdcmDocument.cxx: bug fix.
1158 2004-06-22 Jean-Pierre Roux
1159 FIX : gdcmDocument.cxx
1160 - Now we do recognize the JpegLossLess format (there was a misstyping in
1161 code 'beautyfication' :-(
1162 - Now we automaticaticaly load the Luts, if any
1164 2004-06-22 Jean-Pierre Roux
1165 In order : to write Sequences, whatever their imbrication level,
1166 : to allow user to create his own Sequences
1167 a lot of modif where necessary (adding, moving, or virtualising methods)
1169 WARNING : save your own sources *before* cvs up !
1172 ADD virtual void Write(FILE *fp, FileType filetype);
1175 ADD virtual void Write(FILE *fp, FileType filetype);
1176 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1179 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1180 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1181 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1182 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1183 ADD std::string GetEntryByName(TagName name);
1184 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1186 std::string vr = "unkn",
1187 std::string fourth = "unkn",
1188 std::string name = "unkn");
1189 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1190 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1191 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1192 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1193 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1194 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1195 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1196 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1199 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1200 ADD virtual std::string GetEntryByName (TagName tagName);
1201 ADD virtual std::string GetEntryVRByName (TagName tagName);
1202 REM virtual bool Write(FILE *, FileType);
1203 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1204 FILE *_fp, FileType type);
1205 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1206 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1207 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1208 REM virtual std::string GetEntryByName (std::string tagName);
1209 REM virtual std::string GetEntryVRByName (std::string tagName);
1210 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1211 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1212 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1214 std::string vr = "unkn",
1215 std::string fourth = "unkn",
1216 std::string name = "unkn");
1217 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1218 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1219 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1220 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1223 ADD virtual void Write(FILE *fp, FileType filetype);
1226 ADD virtual void Write(FILE *fp,FileType filetype);
1229 ADD virtual void Write(FILE *fp, FileType filetype);
1230 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1231 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1232 REM std::string GetEntryByName(TagName name);
1235 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1237 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1238 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1239 The default constructor invoked by the line
1240 gdcmHeader *f1 = new gdcmHeader( header );
1241 was gdcmHeader::gdcmHeader(bool) instead of the expected
1242 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1243 Hence the parsing wasn't executed... See also below.
1244 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1245 as explicit constructor didn't do the trick to fix the above problem.
1246 Could anyone explain why ?
1247 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1248 properly calls gdcmValEntry::Print() (that was weed out from
1249 code related to gdcmBinEntry).
1251 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1252 * In order to fix memory leaks:
1253 - Test/TestWriteSimple.cxx: added cleaning of free store through
1255 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1256 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1257 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1258 (through the call to ::AddDicomDirMeta()) or the destructor
1259 would crash when deleting uninitialized ::metaElems].
1260 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1261 - src/gdcmDocument.cxx:
1262 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1263 from dynamic stores.
1264 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1265 was causing memory leaks.
1266 - src/gdcmSQItem.cxx:
1267 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1268 cleanly handled with polymophism: sorry but my milage is low).
1269 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1270 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1271 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1272 This avoids SegFaulting.
1273 - src/gdcmSQItem.h: coding style.
1275 - Test/TestWriteSimple still severely sucks. The output image content
1276 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1277 damaged when displayed with vtkgdcmViewer.
1278 - on memory leaks: TestWriteSimple leaks really less (see entry
1279 of 2004-06-18 in Changelog file for the call to valgrind).
1280 - on segfaults: ctest now passes all the tests but one (no more
1282 * Erroneous leading white fix:
1283 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1284 white[s] (as opposed to from >> xxx, that removes it [them].
1285 - src/gdcmTS.cxx: ditto.
1286 - gdcmPython/testSuite.py: dirty related kludge removed.
1287 * src/*: remaining references to gdcmParser removed.
1288 * src/*[cxx|h]: added copy[way]left header.
1291 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1292 * In order to fix writing of dicom files:
1293 - Test/TestWriteSimple.cxx: a simpler example of writing.
1294 - Test/CMakeLists.txt changed accordingly.
1295 - src/gdcmDocument.cxx:
1296 -- The destructor now recursilvely removes potential sequences.
1297 -- Bug fix in ::IsJPEG2000()
1298 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1299 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1301 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1302 to only declared) and build on top of
1303 ::GetDocEntryByNumber(guint16, guint16).
1304 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1305 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1306 for usage in destructor and treatement of promotion in
1307 ::ReplaceOrCreateByNumber().
1308 - src/gdcmSQItem.cxx: destructor should better handle his job.
1309 Test/TestWriteSimple now runs (or at least it DOES something).
1310 * We can now start hutting memory links. A good starting point is:
1311 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1312 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1313 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1315 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1316 * Valgrind note: after Mathieu Malaterre teached me how to read
1317 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1319 Using gcc, you can force the STL to use malloc and to free memory as
1320 soon as possible by globally disabling memory caching.
1321 With 3.2.2 and later, you should export the environment variable
1322 GLIBCPP_FORCE_NEW before running your program.
1323 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1324 simply vanish (it is still not clear to me, whether this means that
1325 STL std::string leaks or if valgrind believes it leaks...).
1326 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1327 running bin/gdcmTests makeDicomDir):
1328 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1329 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1331 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1332 SegFaulting (I drowned in DicomDir related code when trying to
1333 understand why the list is empty...).
1334 * src/gdcmDocument.h: first BSD license header try.
1335 * Doc/License.txt added.
1337 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * src/gdcmDocument.[h|cxx]:
1339 - Clean up of the Transfer related predicates. They are now all based
1340 on new method isGivenTransferSyntax, that (should) handle properly
1341 the padding problem.
1342 - general clean up, simplification, and coding style.
1343 - Specific clean up of Parse7FE0() (umproperly named actually).
1344 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1346 2004-06-14 Jean-Pierre Roux
1348 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1349 - fix the display of SQItem ordinal number
1350 - add the GetSQItemByOrdinalNumber method
1351 - remove some useless never written private methods
1353 2004-06-14 Jean-Pierre Roux
1355 - adding a constructor taking a gdcmDocEntry as an input param
1356 - ReplaceOrCreateByNumber now returns :
1357 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1358 a gdcmValEntry * if a string value is passed as a param
1360 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1361 according to the param type (no longer sets a gdcmDocEntry)
1362 - GetValEntryByNumber, GetBinEntryByNumber added
1363 - NewValEntryByNumber and NewBinEntryByNumber added
1365 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1367 - GetSQItemNumber and SetSQItemNumber added, to provide
1368 a (relative) Item identier inside a given Sequence
1369 \warning : some pb remaining around this number
1371 - AddEntry now takes the Item Number as a param
1373 - adding a constructor taking a gdcmDocEntry as an input param
1375 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1376 * Memory leak hunt with the following command:
1377 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1378 --show-reachable=yes gdcmTests PrintDocument
1379 It looks like many (all?) leaks are due to the STL (or a bad usage
1380 of the STL. The lines producing the leaks now have a comment with
1381 a "MEMORY LEAK" tag: you can retrieve them with
1382 grep "MEMORY LEAK" src/*
1383 Here are two typical examples which I can't help fixing:
1388 char * test = "babo";
1389 name = test; //// <--- valgrind detects 960 bytes lost in
1390 //// call to std::string::operator=(char const*)
1391 name.clear(); //// Doesn't help !
1399 std::cout << "Type a bunch of characters followed by RETURN: ";
1400 getline(std::cin, line); //// <--- valgrind dectects a loss
1401 //// of 1320 bytes in call to
1402 /// std::basic_istream<>& std::getline<>
1408 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/gdcmHeader.[cxx|h]:
1410 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1411 and related, moved away to gdcmDocument.
1412 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1413 the corresponding protected accessors of inherited class
1414 gdcmDocument, removed ! As a consequence gdcmFile had to be
1415 declared friend of class gdcmDocument (see below).
1416 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1417 - Clean up of undefined or unused methods.
1418 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1419 account the changes to gdcmHeader.h).
1420 * src/gdcmDocument.h:
1421 - gdcmFile is now a friend class (in order to take into account the
1422 changes to gdcmHeader.h).
1423 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1424 (see changes to gdcmHeader.h).
1425 - Accessors (reading on the form GetEntry*) are now public.
1426 - Clean up of undefined or unused methods.
1427 * src/gdcmDocument.cxx:
1428 - adaptation to changes to gdcmDocument.h
1429 - ::OpenFile now writes a verbose message when file cannot be opened.
1430 - some std::string properly set to VRKey
1431 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1432 references to gdcmDocument.
1433 * Test/TestFindTags.cxx: changed accordingly to above changes.
1434 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1435 cvs repository gdcmData.
1437 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1439 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1440 conflicts with gdcmValEntry::voidArea.
1441 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1442 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1443 Value representation between StringRepresentable and BinaryRepresentable.
1444 * src/gdcmDocument.cxx:
1445 - method ParseDES: proper indentation restored and usage of
1446 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1447 - method LoadDocEntry: the fingerprint left in the SetValue() of
1448 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1449 removed. Reverting to previous code segment with the proper
1450 dynamic_cast< gdcmValEntry* >.
1451 Note: this was (partially) breaking the python test suite
1452 (gdcmPython/testSuite.py) that made usage of the above
1453 fingerprint to check presence of "Pixel Data".
1454 * src/gdcmDocEntry.h: coding style.
1455 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1456 now taken into account.
1457 * gdcmPython/gdcm.i: adaptation to the new internal representation
1458 of gdcm (exit gdcmParser, hello gdcmDocument).
1459 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1461 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1462 anymore, but instead prints the loaded Python dictionary.
1463 * .... alas, the python testSuite is still broken.
1465 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1466 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1468 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1469 * src/gdcmUtil.h : export methods
1471 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1472 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1474 * Initial addition of automatic python testing
1475 * Initial addition of automatic image comparison
1477 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1478 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1479 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1481 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1482 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1483 * Test/ShowDicom.cxx : bug fix for msvc compilation
1484 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1486 2004-05-04 Jean-Pierre Roux
1487 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1488 new concepts (and new classes) :
1489 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1490 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1491 - Sequence Doc Entries (gdcmSeqEntries)
1492 a Sequence is composed of Items.
1493 Each item is a set of Doc Entries (this is recursive)
1494 The non uniqueness of the 'Dicom tag' is due to this recursivity
1495 (never taken into account)
1496 Our unability to add a new 'entry' in the header
1497 at the proper location (neither in the H-Table (map or multimap),
1498 nor in the Chained List is also due to this recursivity.
1499 Don't try, right now, to use/modify/compile these new sources :
1500 nothing is finished.
1501 We just commit all the stuff, 'as is', in order not to loose it.
1503 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1504 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1506 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1508 file prefix (SetFilePrefix)
1510 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1511 * Add a new test: ShowDicom, for now this is just the c++ version of
1512 checkRead.sh, later it will be able to compare the image read against a
1514 * Replace the DEBUG on the stack with a global entry in cmake interface:
1515 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1517 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * Add an example subdir, with a real example on how to read + write a
1521 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1523 * Doc/CMakeLists.txt: the main page is now properly differentiated
1524 between the developper and user version.
1525 * Doc/doxygen.config.in: dropped search related obsolete flags
1526 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1528 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1529 * DEVELOPPER: added some helpfull comments for compile/test/install
1532 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1533 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1534 src directory, now generated in the build dir.
1535 2. Tests as mentionned smarter
1537 4. Add a new method in gdcmDict that return the PubDict by name
1538 this is interesting for 3rd party lib like ITK,
1539 where we could set the institution name / patient name...
1541 * ENH: 1. Now the test suite is working for real
1542 2. All binaries are now output in the gdcm-bin directory
1543 (this was not true before)
1545 2004-04-28 Jean-Pierre Roux
1546 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1547 SeQuence indented printing of Dicom Header.
1548 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1549 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1550 Computation of SQDepthLevel is now part of gdcmHeader constructor
1551 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1552 tree-like structure of a Dicom Header.
1553 * FIX Test code cleaning
1555 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1556 * ENH: Adding automatic testing
1557 1. Need a DartConfig.cmake to submit to public
1558 2. Add a test driver gdcmTest.cxx
1559 3. gdcmTestMain, an helper for the main test driver gdcmTest
1560 4. Files in Test don't have a main anymore, this becomes interesting
1561 when we add more and more tests, thus dsw don't have to load
1563 * ENH: Adding a GDCM_DATA_ROOT for testing
1564 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1565 one file instead of seven + some small cleanup
1567 2004-04-22 Jean-Pierre Roux
1568 * ENH Minor changes to the Print() methods.
1569 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1570 Header printing. Example given with :
1571 > PrintHeader fileName 2 new
1572 (SQ based tree-like structure still to be done for the Header ...)
1574 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1575 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1576 1. I have added some unsigned where needed
1577 2. Some function parameter not used -> (void)
1578 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1579 4. g++ don't like character '\' in comment
1580 5. #define jpeg_create_decompress jCreaDecompress
1581 this really need to be fixed
1582 6. virtualize destructor of gdcmObject ... leakage
1583 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1584 this also really need to be fixed
1585 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1586 remove compression file
1587 (as we only do decompression, right ?)
1588 * ENH: Change malloc/calloc/free with c++ equivalent
1590 2004-04-21 Jean-Pierre Roux
1591 * FIX gdcmHeaderHelper::GetXSpacing
1592 when a single value is found (bug ?), xpacing is now
1593 defaulted to yspacing
1595 2004-04-19 Jean-Pierre Roux
1596 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1597 * ENH add parameters :
1598 bool exception_on_error = false,
1599 bool enable_sequences = false,
1600 bool ignore_shadow = false
1601 to the gdcmFile constructors to be full gdcmParser compliant
1602 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1603 to allow reading of PAPYRUS 3.0 files
1605 2004-04-06 Jean-Pierre Roux
1606 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1608 2004-04-02 Jean-Pierre Roux
1609 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1610 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1611 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1613 2004-03-30 Jean-Pierre Roux
1614 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1615 for ACR file, written out as DICOM files (hope so...)
1617 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1618 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1619 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1620 moved to base class gdcmParser and only the specialisation is kept
1622 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1623 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1624 already does the job.
1625 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1626 (to be consistent with gdcmParser::WriteEntries).
1628 2004-03-30 Benoit Regrain
1629 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1630 upate of the object's instance. It's passed to 2 in the unfavorable
1631 case : one in the ExecuteInformation, one in the ExecuteData
1633 2004-03-29 Jean-Pierre Roux
1634 * ENH : Check on file type to be written moved
1635 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1636 * FIX : gdcmObject::ResetBoundaries now stops properly
1637 when end-of-list is reached
1638 : gdcmVersion modified (as Benoit Regrain asked)
1640 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1641 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1642 * src/gdcmUtil.cxx: added forgotten iostream include.
1643 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1644 equivalent to ExplicitVR in existing code).
1646 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1648 now contains all the gdcmGlobal related code.
1649 * minor coding style and doxygenation changes.
1651 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1653 now contains all the Debug related code.
1654 * minor clean-up of includes in src/*.cxx
1655 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1656 CreateCleanString) removed.
1657 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1658 * Doc/DoxyMainPageUser.txt added.
1659 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1660 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1661 src/gdcmDirList.cxx)
1663 2004-03-24 Jean-Pierre Roux
1664 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1666 2004-03-23 Jean-Pierre Roux
1667 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1668 big endian made volumes
1669 * ENH Now gdcmParser constructor and destructor are protected to forbid
1670 end user to instanciate class gdcmParser
1671 (only gdcmHeader and gdcmDicomDir are meaningfull)
1673 2004-03-22 Benoit Regrain
1674 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1675 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1676 gdcmSerie to gdcmDicomDirSerie
1678 2004-03-19 Jean-Pierre Roux
1679 * ENH Now the tree-like structure describing a DICOMDIR comming from
1680 an already existing DICOMDIR file is consistent with
1681 the home-made tree-like structure build ex-nihilo
1682 or build from the files held (recursively) in a Directory
1683 functions gdcmDicomDir::CheckBoundaries()
1684 gdcmObject::SetBoundaries() added
1686 2004-03-17 Jean-Pierre Roux
1687 * REM (Eric Boix bug) : removal of meaningless
1688 gdcmDicomDirImage::NewImage function.
1689 * FIX now file names and directory name are written properly in the
1691 * FIX now gdcmDicomDir constructor may be call without any trick
1694 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1695 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1696 of gdcmDicomDirImage::NewImage as empty function.
1698 2004-02-28 Jean-Pierre Roux
1699 * ENH add gdcmDicomDir:NewPatient
1700 add gdcmDicomDirPatient:NewStudy
1701 add gdcmDicomDirStudy:NewSerie
1702 add gdcmDicomDirSerie:NewImage
1703 to allow making gdcDicomDir object.
1704 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1705 (as opposite to the gdcmHeader chained list)
1707 2004-02-11 Benoit Regrain
1708 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1709 when using from python
1711 2004-02-10 Benoit Regrain
1712 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1713 * FIX : in gdcmDicomDir when the directory is empty
1714 * ENH : add callback and methods to get the progression of dicomDir
1717 2004-02-06 Jean-Pierre Roux
1718 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1719 - GDCM_META added to gdcmDicomDirType
1720 - class gdcmMeta created
1721 * ENH : - A brief summary is now displayed at the beginning of
1722 'testDicomDir' to help disaster magnitude estimation
1723 * REM : Now useless Test/explDICOMDIR.cxx
1725 2004-02-05 Benoit Regrain
1726 * ENH : add methods in gdcmObject to get the hash table or the list of
1728 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1729 * FIX : wrapping python for TagHeaderEntryHT
1731 2004-02-04 Benoit Regrain
1732 * FIX : even length for some strings when writting the dicom dir
1733 * FIX : sort the images in the dicom dir
1734 * FIX : Bug fix for python use of dicom dir
1735 * ADD : a python demo
1737 2004-02-04 Jean-Pierre Roux
1738 * FIX : Final solution (?) for icone embedded images
1739 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1740 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1741 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1742 gdcmData/gdcm-MR-SIEMENS-16.acr1
1743 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1744 to make full checking easier
1746 2004-02-04 Benoit Regrain
1747 * FIX : WriteEntries : coding style & logic in parameters
1748 * FIX : Set the elements to create the DicomDir in a dictionary file
1750 2004-02-03 Benoit Regrain
1751 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1752 * gdcmDicomDir : add the load of directory
1753 * Bug fix and print add-on
1755 2004-02-03 Jean-Pierre Roux
1756 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1757 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1758 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1759 * FIX gdcmParser.cxx : 'group length' elements are now considered
1760 as integers, even for shadow groups, when file is Implicit VR
1762 2004-02-02 Jean-Pierre Roux
1763 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1765 of the last synonym :-(
1766 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1768 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1769 * FIX taking into account the possible 7fe0,0010 multiplicity
1770 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1771 to allow removal of references to 7fe0,0010, to deal with
1772 ACR-NEMA images, when 0028,0200 is meaningfull
1774 2004-01-31 Jean-Pierre Roux
1775 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1776 no longer writes 'Un' on disk
1777 * FIX SQ elements with actual length are now dealt with corectly
1778 * FIX gdcmFile::WriteBase make the difference, for color images, between
1779 the length (for Palette expanded images)
1780 and Raw Length (non expanded image + Palette)
1781 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1782 (that broke Write). Replaced by UL.
1783 Aware user will reload the field if he
1784 thinks it's necesssary
1786 2004-01-30 Jean-Pierre Roux
1787 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1788 when 'dirty Acr' is found, to be compliant with the new
1789 IsReadable() methods.
1791 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1792 (no DOUBLE images in kosher DICOM,
1793 but so usefull for people that miss them ;-)
1795 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1796 DICOMDIR related utilities (not checked as Windoze compliant)
1798 2004-01-28 Jean-Pierre Roux
1799 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1801 2004-01-27 Jean-Pierre Roux
1802 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1803 to allow skipping the shadow elements, to save memory space.
1804 The TRUE value for this param has to be used
1805 with a FALSE value for the 'enable_sequence' param.
1806 ('public elements' may be embedded in 'shadow Sequences')
1807 * gdcmHeader methods now deal with 'embedded icones images' in the header
1808 (even when an 'icone image sequence' is announced by the
1809 element (0x0088,0x0200), but there is NO icone at all ...
1811 * gdcmHeader sometimes Image Location value doesn't follow
1812 the supposed processor endianity (see gdcmData/cr172241.dcm).
1815 * gdcmHeader add the method
1816 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1817 to get *all* the Header Entries with the same tag.
1818 GetHeaderEntrySameName is probabely *useless*
1819 (no meaning : Name is *not* an identifier within the Dictionnary)
1821 2004-01-26 Benoit Regrain
1822 * Bug fix in the print of hexadecimal representations. Remove long fields
1823 in the print and add a third level of print to print them
1825 2004-01-23 Benoit Regrain
1826 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1827 * Bug fix on test suite after remove the strip made on not string fields
1828 * Split the IsReadable method between gdcmParser which test that the file
1829 is dicom and gdcmHeader which test that it's an image file
1831 2004-01-22 Benoit Regrain
1832 * DicomDir : clean code, add methods, set variables in protected or private
1833 * gdcmUtil : bug fix for the clean string method
1835 2004-01-19 Benoit Regrain
1836 * Add the use of shadow dictionaries
1837 * bug fix and coding style
1839 2004-01-19 Benoit Regrain
1840 * src/gdcmFile.cxx : bug fix concerning the close of file
1841 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1842 * Add the update of header entries using the shadow library
1844 2004-01-19 Benoit Regrain
1845 * removal of file gdcmHeader2.cxx
1846 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1847 inheriting from gdcmParser. This split is to prepare the integration
1848 of dicom dir parsing
1849 * bug fix under python
1851 2004-01-16 Jean-Pierre Roux
1852 * REM removal of class gdcmHeaderEntrySet
1853 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1854 * ADD add file gdcmHeader2.cxx
1855 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1857 2004-01-15 Benoit Regrain
1858 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1859 entries created while parsing the header. Thus, they will be destroyed
1860 when the gdcmDictSet will be destroyed
1861 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1864 2004-01-15 Benoit Regrain
1865 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1866 made a fatal error because of the memory release at the end of program.
1867 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1868 some memory and vtk seems to have some problems with that.
1869 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1871 2004-01-14 Benoit Regrain
1872 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1873 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1874 * src/*.[h|cxx] : make changes due to class name changes
1875 * gdcmPython/demo/*.py : bug fix due to method names
1877 2004-01-13 Benoit Regrain
1878 * src/*.[h|cxx] : coding style
1879 * vtk/*.[h|cxx] : coding style
1881 2004-01-13 Benoit Regrain
1882 * gdcmPython/testSuite.py : test the readable flag of file for tests
1883 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1884 It's lied to the stl compilation by MSVC (windows, always windows...)
1885 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1887 2004-01-12 Benoit Regrain
1888 * src/*.h : add comments
1889 * src/gdcmDictSet.h : set the method BuildDictPath in public
1890 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1891 directly setted in the source code
1892 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1895 2004-01-09 Benoit Regrain
1896 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1897 * setup.py : use a reference to gdcmVERSION
1899 2004-01-07 Benoit Regrain
1900 * Modification to compile with the distutils.
1903 2003-12-10 Benoit Regrain
1904 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1905 can use a gdcmHeaderHelper to load data
1906 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1907 made in the source code
1909 2003-12-10 Benoit Regrain
1910 * Update Windows projects and .cvsignore files
1912 2003-11-12 Jean-Pierre Roux
1913 * ENH gdcmHeader constructor has one more parameter (default value : false)
1914 that allows the user to 'go inside' the SeQuences only
1916 gdcmElValSet:Print takes it into account
1918 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1919 * ENH: Update gdcmPython/CMakeLists
1920 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1921 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1923 2003-11-10 Jean-Pierre Roux
1924 * FIX : gdcmHeader::LoadElements is now based
1925 on the ListTag listElem member,
1926 not longer on the TagElValueHT tagHt member
1927 * ENH : PrintPubElVal shows (temporarily) both results,
1928 with the tagHt member and the listElem member.
1929 (it's easier to 'see' the problems when using Printheader)
1931 * FIX : old private member LgrElem is now splitted into
1932 ReadLength : Length actually found on disk (updated only
1933 if bug fixing is necessary), for internal
1935 UsableLength : Updated by FixFoundLength, to fix a bug
1936 or to allow Parser going on.
1937 Will allow to re-write a kosher header when a SeQuence
1938 with a length (not 0000) is found
1939 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1940 because gdcmElValSet::Add does not update ListElem
1943 2003-11-07 Jean-Pierre Roux
1944 * FIX misstyping in Transfert Syntax name table
1945 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1946 when they have an actual length (not 0000 nor FFFFF)
1947 (Nobody should care of it, but DICOMDIR explorers)
1949 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1952 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1953 * ENH: vtkGdcmReader now supports LUT !
1954 (vtkgdcmViewer for now is not able to use them though)
1956 2003-11-05 Jean-Pierre Roux
1957 * in testSuite.py : new files names for checking the package
1958 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1959 that returns the pixel area size to the *aware* (vtk) user
1960 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1962 2003-11-05 Benoit Regrain
1963 * in testSuite.py : Modify the rules for checking the paths
1964 : Explicit error messages
1965 * in __init__.py : Related modif
1967 2003-11-03 Jean-Pierre Roux
1968 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1969 to be used by aware (vtk) users that want to manage
1970 LUT (and no to turn the PALETTE image into an RGB pixels one)
1971 * GetPixelType now returns 8U for 24 Bits images
1972 (vtkGdcmReader compliant)
1974 2003-10-31 Jean-Pierre Roux
1975 * Removal of *all* gdcmData images and add them again
1976 in order to loose the 'history' of un-anonymised images
1978 2003-10-31 Jean-Pierre Roux
1979 * RMV : removal of useless jBitsInJsample.h
1980 for both 8 and 12 Bits JPEG Lossy Libraries
1982 2003-10-31 Jean-Pierre Roux
1983 * ENH : Add the functions gdcmFile::GetImageDataRaw
1984 gdcmFile::GetImageDataIntoVectorRaw
1985 that act as GetImageData and GetImageDataIntoVector
1986 except the making of an RGB Plane from Gray Plane + LUT
1987 Intended to aware (vtk) users who know how to manage
1990 GetLUTRGBA return a R,G,B,A LUT if any
1991 lgrTotaleRaw gives the 'Raw' length
1992 GetImageDataRaw returns the gray Plane
1993 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1994 (They stay Grey, just like with other Dicom viewers :-(
1996 2003-10-30 Jean-Pierre Roux
1997 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1999 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2001 being coherents dicom files.
2003 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2006 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2007 * ENH: Two steps is necessary to please VC++ compiler...
2008 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2009 * ENH: Add include dir to medcon lib
2010 * FIX: only one function is being exported for now !
2011 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2013 2003-10-29 Jean-Pierre Roux
2014 * adding gdcmHeader::GetLUTRGBA
2015 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2016 --> Mathieu, the modif u're waiting for is not yet committed
2017 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2019 2003-10-27 Jean-Pierre Roux
2020 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2021 00191113.dcm DermaColorLossLess.dcm
2022 MxTwinLossLess.dcm RadBWLossLess.dcm
2023 * ENH: For version prior to vtkImageViewer2 -r 1.19
2024 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2026 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * Removal of ido stuff in CMakeLists.txt
2029 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2031 * FIX: remove a call to ->Modified ... see comments
2032 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2034 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2035 * FIX: Problem with path for libvtkgdcmPython
2036 * ENH: Try adding a search script for python site-package
2037 * RMV: Remove some file from medcon lib that are not necessary
2038 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2039 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2040 * FIX: More pragma disable fro VC++,
2041 I don't think I break something as it is also disable in VTK/ITK.
2042 But it fasten debug compilation time.
2044 2003-10-23 Jean-Pierre Roux
2045 * gdcm now deals with 16 Bits Run Length Encoded images
2046 (they are compressed as 2 planes images,
2047 one for the high Bytes, the other for low Bytes)
2049 2003-10-22 Jean-Pierre Roux
2050 * Now CheckRead takes into account :
2051 - the bugged 'Leonardo' Siemens images
2052 - the XA images, sent thru the burning VPRO station
2053 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2056 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2057 * FIX: When copying a Makefile.am to CMakeLists.txt
2058 one should remove the '\'
2060 2003-10-22 Jean-Pierre Roux
2061 * in gdcmData adding a bugged 'Leonardo' Siemens image
2062 (wrong lengths in header)
2063 OK with gdcm, KO with the other viewers :-)
2064 * add a GE dlx XA image, thru the VEPRO burning station
2067 2003-10-21 Jean-Pierre Roux
2068 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2069 for a brutal checking of vtkgdcmViewer compliance
2071 2003-10-21 Jean-Pierre Roux
2072 * add the files for 'xmedcon' Jpeg Lossless library
2073 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2075 2003-10-21 Jean-Pierre Roux
2076 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2078 2003-10-21 Jean-Pierre Roux
2079 * garbage Siemens 'Leonardo' images dealt with
2080 (the patch is easy to remove)
2081 * cosmetic changes to avoid warnings
2083 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2085 no need to press 'r' now.
2087 2003-10-20 Jean-Pierre Roux
2088 * upgrade of checkRead.sh checkWrite.sh according
2089 to new Jpeg Lossless decompressor
2090 * add US.3405.1.dcm, a genuine RGB medical file ...
2091 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2092 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2094 2003-10-15 Jean-Pierre Roux
2095 * general anonymisation in gdcmData
2096 * adding the 'color files' from
2097 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2098 * adding some well knowed bugged-header images
2099 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2100 waiting for their inclusion in Python testsuite
2102 2003-10-15 Jean-Pierre Roux
2103 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2104 no longer seg faults when file is not found
2106 2003-10-14 Jean-Pierre Roux
2107 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2110 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * TODO: *.in file to genereate a UseGDCM later
2113 2003-10-14 Jean-Pierre Roux
2114 * Some supposed-to-be Dicom Images have no preamble.
2115 OpenFile takes it into account
2116 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2117 * Missing elements added in dicomV3.dic
2118 (just to be affraid : have a look at
2119 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2120 and do it again next year ;->
2122 2003-10-13 Jean-Pierre Roux
2123 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2124 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2125 But there are NOT. It's fixed !
2127 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2128 * FIX: "jpeglib.h" was not found on VC++
2129 * FIX: vtkgdcm was not being installed
2131 2003-10-10 Jean-Pierre Roux
2132 * ENH : OpenFile closes the file if it *really* doesn't look like
2133 an ACR-NEMA / DICOM one.
2134 * FIX : testWrite no longer writes an empty file if the source file
2135 is not gdcm Readable
2136 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2139 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * FIX: CMake generate now documentation
2141 * ENH: out of source doc build !
2142 * ENH: Generate both user and dev documentation
2143 * ENH: Should work on windows too
2144 * ENH: Only one doxygen config.in file is needed
2145 * FIX: make install should be ok now on ùnix plateform
2146 * FIX: PATH to dictionary was wrong (missing /)
2147 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2149 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2150 * vtkGdcmReader is now able to read rgb dicom file.
2151 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2152 * added a gdcmViewer to vtk test, use mouse to control
2153 window level & window width
2155 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2156 * CMake-ification of gdcm, we have now two build system
2157 * FIX: on cygwin Wsock32 doesn't exist
2158 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2160 2003-10-06 Emanuel Ollart
2161 * FIX : compilation process wad broken.
2162 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2164 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2165 * change gdcmViewer -> vtkgdcmViewer
2166 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2168 2003-10-06 Jean-Pierre Roux
2169 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2170 ( e.g : well known GE images with a wrong elem length,
2171 : Philips MRI Images with a wrong Huffman table)
2172 * still to be done : allow the reading of bugged LEONARDO Siemens images
2174 2003-10-03 Jean-Pierre Roux
2175 * Odd length strings are padded with '\0' (not with spaces,
2176 to remain compliant with already defined strings,
2177 like Transfert Syntax UID and others)
2179 2003-10-03 Jean-Pierre Roux
2180 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2181 to allow displaying RGB images (not only by affim ;-)
2183 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2184 * vtkGdcmReader is now able to read rgb dicom file.
2185 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2187 2003-10-03 Jean-Pierre Roux
2188 * A few nasty patches to allow the reading of a lot of nasty images
2189 ( e.g : well known GE images with a wrong elem length,
2190 : Philips MRI Images with a wrong Huffman table)
2191 * still to be done : allow the reading of bugged LEONARDO Siemens images
2193 2003-10-03 Jean-Pierre Roux
2194 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2196 2003-10-03 Jean-Pierre Roux
2197 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2198 to allow displaying RGB images (not only by affim ;-)
2200 2003-10-03 Jean-Pierre Roux
2201 * gdcmFile::GetImageDataIntoVector now
2202 - deals with MultiFrames MultiFragments Run Length Encoded files
2203 - deals with YcBcR (YBR_FULL) files
2204 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2205 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2207 (no sample found :-(
2209 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2210 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2211 Two reasons: - clear things
2212 - third parties acces gdcm through header files, so won't
2213 suffer anymore VC++ complains
2215 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2216 * add argv[1] in testvtkGdcmReader.cxx
2219 2003-09-24 Jean-Pierre Roux
2220 * The lines are now eigthy characters long.for
2221 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2223 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2225 char* to std::string. Thus, the use of strdup becomes useless. (see
2226 previous commis of Malaterre)
2227 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2228 before the last Malaterre's commit.
2230 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2231 * This commit should fix the Debug building under VC++, the problem
2232 was mainly a mixture of debug and release lib being loaded at startup.
2233 * I also remove a depency to a specific C function: strdup. Because I had
2234 to force the link to msvcrtd (whereas strdup is in libc).
2236 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2237 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2238 located in the gdcmCommon.h file. All use of reference of tha has been
2239 changed to now use the variable GDCM_UNFOUND.
2241 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2243 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2244 Dicom dictionary. The test suite can now be run again. Note:
2245 I'm note very happy with the " (RET)" changes. I believe this
2246 RETAINED comment should be dropped when parsing the dictionary.
2247 - PACKAGER corrected
2249 - AUTHORS updated and now in alphabetical order
2250 * Makefile.am now exports gdcm.dsw for Windoze users.
2252 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * cygwin complains about missing std:: in subdir Test/
2255 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2256 * remove some methods that are now in gdcmHeaderHelper
2258 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2259 * vtkGdcmReader set spacing and origin correctly
2261 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * Fix a few delete/delete[] mismatch
2264 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2266 interpretation to data given by gdcmHeader. For instance there are
2267 heuristics to get informations (look at different places).
2268 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2269 sorting DICOM images based on different strategies.
2270 * modified Makefiles accordingly.
2272 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2273 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2274 when building in debug mode
2275 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2276 src/win32/gdcmdll.dsp
2277 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2279 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2280 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2283 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * src/win32/libgdcmjpeg12.dsp was not dos format
2285 * src/win32/libgdcmjpeg12.dsp :
2286 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2287 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2289 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2290 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2292 * src/gdcmFile.cxx : bug fix in affectation type
2293 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2294 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2295 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2296 symbols... future problem ?
2298 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2299 * src/win32/libgdcmijpeg12.dsp was missing
2300 * modified gdcm.dsw accordingly
2302 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2305 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2306 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2307 commit of JPR (before his hollidays to facilitate our work).
2308 * setup.py : bug fix in code. Modifications made while the last commit
2309 of JPR. The code hasn't been tested before the commit... it's so
2310 useless to make that (for best programmer that is JPR) !!!
2312 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * tagged the current version as Version0_3 (i.e. version 0.3)
2315 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2316 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2317 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2318 * *.dsp : modifications to use new libgdcmijpeg8 library
2319 * setup.py : bug fix on VTKPATH variable
2320 * PACKAGER : adding all concerning windows
2322 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2325 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2326 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2327 test suite reported error.
2328 * PACKAGER file added (describes what a packager must do when
2329 packaging a new release).
2330 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2331 * configure.in: upgraded version number to 0.3.0
2332 * fixing build of rpm (through rpm -ta):
2333 - Doc/Makefile.am exports proper doxygen files
2334 - src/jpeg/libijg8/Makefile.am exports the include files.
2336 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2338 * src/gdcmHeader.h : formatting code
2340 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2341 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2342 We were obtaining error message from vtk. Now, creation of file list
2343 is made in an internal list to prevent this problem.
2344 Bug fix when output is empty.
2345 Bug fix in update of progress value. Previous commit for this was a bad
2347 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2349 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2350 * src/gdcmHeader.h : added method to get the file name
2351 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2352 files. Added method to remove all files on the input
2353 Added FIXME comment concerning the bad parsing of header made by
2354 ExecuteInformation method (in ExecuteData method)
2356 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2358 when using make instal.
2359 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2360 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2362 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2363 * setup.py : adding include dir of jpeg lib to compile all sources
2364 * */Win32/*.dsp : JPR fix for windows compilation
2366 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2367 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2369 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2370 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2372 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * setup.py is again effective on un*x (takes into account the
2374 addon of the jpeg library)
2375 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2376 * Doc/Doxy* updated (includes above enhancements)
2377 * INSTALL now points to web documentation
2379 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2380 * src/gdcmHeader.h doesn't make unnecessary reference to
2382 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2384 * src/gdcm*.[cxx|h] :
2385 - to allow compilation with gcc 3.x
2386 -- clean up of STL usage (added explicit usage of std::)
2387 -- small fixes on exceptions.
2388 Note: linking not tested !
2389 - clean of doxygen comments to avoid warnings at documentation
2391 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2392 dependent convertion).
2394 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * Clean up of previous JPR garbage commit (not even commented in the
2397 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2398 - moved all jpeg related files from src to src/jpeg/libijg8, with
2399 addition/modification of Makefile.am and configure.in.
2400 - the testSuite is still brain damage (not guilty).
2402 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2403 * WrapVTK.py : modifications to get correctly vtk source files to
2405 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2406 (FileName -> Filename)
2408 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * vtk/vtkGdcmReader.[cxx/h]:
2410 - UpdateProgress method should now be effective
2411 - removed the limitation on having only images loaded (as opposed
2413 - when building a stack of images/volume, a lesser number of
2414 gdcmHeader and gdcmFile instances should be used (hopefully
2415 accelerating things).
2416 - when building a stack of images/volumes, files which are not
2417 loadable (wrong path-filename, wrong permissions on existing file,
2418 or file not parsable by gdcm) are replaced with a black image
2419 in the stack (for the caller to notice the problem).
2421 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2424 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2425 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2426 between standard library (std) and vtk library (problems are found
2427 under Windows... thanks Windows !)
2429 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2432 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2434 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2437 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * When compiling with distutils (see setup.py) the C++ compiler is
2439 called with different flags than the default ones (with automake).
2440 In order to fix all those warning, I compiled gdcm with the command
2441 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2442 and went for warning fixes:
2443 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2444 up from unused variables.
2445 - vtk/vtkGdcmReader.cxx: potential bug fix.
2446 * src/gdcmHeader.h: Doxygen warning cleanup
2448 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * gdcmPython/gdcm.i:
2450 - typemaps correction to take into account the systematic replacement
2451 of "using namespace std" with std:: prefix e.g. std::list,
2452 std::string... (cf changes of 2003-05-21).
2453 - gdcmGlob global variable of type gdcmGlobal (defined in
2454 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2455 exported to Python a as cvar.
2456 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2457 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2458 gdcmDictSet.GetPubDictTagNames() and
2459 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2460 C++ static methods).
2461 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2462 with the above changes.
2464 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2465 * setup.py, manifest.in : bug fix under linux
2467 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2468 * Modification of setup.py to compile vtk part too. Then, we have 2
2469 wrappers which must work with same distutils. For that, we have a
2470 generic distutils in distusiltsWrapping.py ; with :
2471 - build_extWrap class to wrap generically all extensions,
2472 - ExtensionWrap base class for all wrapping extension that contains
2474 - Wrapper interface which wrap sources
2475 + In WrapSwig.py we have extension and wrapper for Swig
2476 + In WrapVTK.py we have extension and wrapper for VTK
2477 * MANIFEST.in : modifications to consider vtk directory and new python
2478 files for compilation
2480 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2481 * Added python wrappers of vtkGdcmReader vtk class (see the
2482 source in vtk/vtkGdcmReader.cxx) :
2483 - vtk/Makefile.am now builds a library
2484 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2485 python library (as opposed to _gdcm.so wich are the python
2486 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2487 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2489 - configure.in has an additional flag --enable-vtk that needs
2490 to be set to enable compilation of vtk related code, that is:
2491 + vtk/vtkGdcmReader.so and
2492 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2493 + gdcmPython/vtkgdcmPython.so (see above)
2494 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2495 be read when compressed or when HighBit + 1 != BitsStored),
2496 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2497 the usage of the python wrapper of vtkGdcmReader vtk class.
2498 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2499 * src/*.[h] all occurences of stl classes are now prefixed with
2500 std::, and all occurences of "using namespace std;" where removed.
2501 This is to avoid pollution of global namespace in included files.
2502 Apparently vtk does not avoid this pitfall: when using both
2503 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2504 collision of various stl members (principally cout...).
2505 * gdcmPython/testSuite.py now cleanly removes temprory generated
2507 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2508 comply with above changes)
2510 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2511 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2512 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2513 vtk data structure (an image Flip was required).
2514 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2515 * cosmetic changes in documentation.
2517 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2518 * src/gdcmHeader.cxx: the constructor no longer exits when an
2519 unexisting file is given as argument.
2520 * The subdirectory Data (containing all the images used for the
2521 test suite) is not part of this repository anymore. A new module
2522 containing those images is now available at
2523 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2524 with the name gdcmData.
2525 All the python scripts (including the package initialisation file
2526 gdcmPython/__init__.py) were adapated to take this change into
2527 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2529 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2530 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2531 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2532 demo of the usage of this class.
2533 Compilation of this vtk part is only done when using the --enable-vtk
2534 at configure (or autogen.sh) stage.
2536 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2537 * More memory link related corrections and documentation fixes.
2539 - maximum info is obtained with a command of the form:
2540 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2541 --show-reachable=yes PrintHeader
2542 - the remaining reachable blocks seem to come from the STL
2543 allocation scheme through the usage of map and list. It looks
2544 like this memory cannot be freed but it is not a memory leak
2545 (in fact further invocation to the STL would recollect the
2546 unused memory allthough it cannot explicitely be freed).
2547 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2548 of displaying an image parsed with gdcm and displayed with VTK.
2549 Note: some images don't seem to work e.g.
2550 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2551 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2552 Allthough this weakens the semantics, it is a ditch attempt to
2553 make gdcm more thread friendly.
2555 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2556 * Memory link hunt (by using valgrind through the command
2557 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2558 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2559 gdcmHeader::_dicom_vr.
2560 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2561 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2563 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2565 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2566 * src/Makefile.am now exports all the necessary include files at
2570 * UpdateGroupLength replaced by new one
2573 * UpdateGroupLength re-written using H-Table
2574 (named UpdateGroupLengthNew untill checks are over)
2576 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2577 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2578 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2580 - gdcmHeader::GetPubElValSet removed.
2581 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2582 UpdateGroupLength, WriteElements, Write.
2583 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2584 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2585 carried the same semantics.
2586 - src/gdcmHeaderIdo.cxx changed accordingly.
2587 - gdcmFile::WriteBase now regroups all the codes from previous
2588 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2589 - enum FileType moved to gdcmCommon.h
2590 * src/gdcmHeader.cxx AddDefault trashed
2591 * gdcmGetXSize added
2592 * getimageDataSize now calls gdcmGetXSize
2593 * Test/*.cxx changed to agree with above changes
2595 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2597 (to avoid double call by end user).
2598 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2599 by end user, since gdcmHeader::gdcmHeader now handles it.
2601 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * gdcm/Doc many doxygen changes:
2603 - Doxyfile now has two different versions, DoxyfileUsers that generates
2604 the html.users end users oriented documentation and
2605 DoxyfileDeveloppers that generates the html.developper developper
2606 oriented documentation.
2607 - README changed accordingly
2608 - requirement.txt removed (old design info moved to TODO).
2609 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2610 DoxyMainPage.txt, DoxyPython.txt provide more information.
2611 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2612 be updated by simply regenerating the docs with doxygen and copying
2613 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2614 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2615 all the tests in the form "if (<map>.count() >1)" were removed.
2616 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2617 ill-formed documentation sections.
2618 * src/gdcmHeader.cxx: ditto
2620 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2621 * setup.py fixed for un*x (needed macro for stdint.h)
2622 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2623 un*ces with sh-utils test utility.
2624 * gdcmPython/demo/test.py renamed to PrintHeader.py
2625 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2626 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2627 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2628 * src/gdcm*.cxx JPR's bad inclusion fixed.
2630 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2632 * gdcmPython/demo/test.py changed accordingly.
2634 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * gdcmPython/Makefile.am fixed linking against libstdc++
2636 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2637 * Swig subdir (historical tests of swig version 1.3.17++) removed
2638 * Test/testChangeEntete.cxx some lines commented out in order to make
2640 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2641 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2643 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2644 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2645 hence the user doesn't need this explicit call.
2646 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2647 i.e. LoadElements() call removed.
2648 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2649 - src/Makefile.am declares the proper flag for g++.
2650 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2651 for adding user defined new tags.
2652 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2653 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2654 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2656 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2657 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2658 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2659 src/Makefile.am : the project should properly compile and install
2660 with the autotools, included the python wrappers part.
2661 * gdcm.spec.in : added a spec file for RPM packaging.
2663 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2664 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2666 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2668 to exported to the environement (see gdcmPython/testSuite.py
2670 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2671 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2672 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2673 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2674 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2676 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * gdcmPython/__init__.py doesn't crash anymore when running in
2678 in InstallMode or PreInstallMode but with an environement given
2679 value of GDCM_DICT_PATH.
2680 * src/gdcmDictSet.[cxx/h] coding style.
2682 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2684 * src/gdcm.h general comments moved to TODO, and README
2685 * src/gdcm.h should now be seen as a user commodity (including it
2686 should suffice to fully use gdcm). It is nowhere including within
2687 any of the kernel files src/*.cxx and src/*.h.
2689 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2691 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2693 * src/gdcm*.cxx only include their corresponding include file
2694 (as opposed to gdcm.h)
2695 * gdcmPython/gdcm.i changed accordingly
2696 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2697 the autogen.sh generated "make snapshot" command to work.
2698 * autogen.sh removed history related references to crea package.
2700 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * distutilsSwigCPlusPlus.py work around some swig portability
2704 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2706 was done in a last ditch attempt to get setup.py _really_
2707 operationnal. The python/gdcmPython layaout add the advantage
2708 of hidding away the python related distutils specific files
2709 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2710 Alas, the src directory was out of scope (i.e. it's relative
2711 position to setup.py was ../src) which made things impossible to
2712 handle (see previous version of python/setup.py). Crossing fingers...
2714 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * python/setup.py now works on Un*x. (harder than I thougth)
2716 * python/distutilsSwigCPlusPlus.py can now have include files
2717 among the list of sources.
2719 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2720 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2721 * modifications in MSVC projects
2723 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * As stated by the first lines of Test/ExceptionAndPython/README, it
2725 looks like we can move back to original usage of exception within
2726 src/gdcm* and hence remove the errno stuff that was introduced
2727 as a quick and dirty fixture of this problem (added to the TODO).
2728 * Doc/Doxyfile configuration file for Doxygen and corresponding
2729 README file for usage added.
2730 * Test/testWrite.cxx added. This new test comes from a split of
2731 test.cxx that is now reverted to its original purpous i.e.
2732 testing the proper parsing of a Dicom related file.
2733 testWrite.cxx concentrates on testing the IO part of gdcm.
2734 * Test/bug1.cxx (containing a bug on WIn32) added.
2735 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2736 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2737 whose purpose is to publish the content of the TagNames of the
2738 Dicom public dictionnary were not accessible without an
2739 instance of class gdcmHeader.
2740 - those methods are now static methods of gdcmDictSet and hence
2741 require no instances at all to be invocated.
2742 - within gdcmDictSet this change required to change some method
2743 to class methods (i.e. are now static) among which SetDictPath
2744 (renamed to BuildDictPath) and LoadDefaultPubDict.
2745 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2746 the above changes by calling the new method classes of gdcmDictSet.
2747 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2748 the above to be effective.
2749 * python/gdcmPython: in order to wrap properly the above changes
2750 for Python, swig version now needs to be > 1.3.17.
2751 * python/gdcmPython/Makefile fixed to adapt itself to new
2752 configure/make shema introduced by Johan Montagnat (thanks for the
2753 contribution). Alas this Makefile cannot be turned into a proper
2754 Makefile.am without some heavy changes in the configure.in
2755 (for python dectection).
2756 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2757 now avoids publishing the empty entries.
2759 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2760 * python/setup.py : bug fix concerning install under windows
2761 ExtraPath reused :-P
2762 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2764 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2765 * Dicts/dicomV3.dic : remove double spaces !!!
2766 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2767 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2770 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2772 method. Doxygenation.
2773 * src/gdcm.h clean up of JPR spurious comments.
2775 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * python/distutilsSwigCPlusPlus.py now properly collects the
2777 shadow classes generated by "swig -c++" (gdcm.py in our case)
2778 when using "python setup.py install".
2779 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2780 reexports the working classes.
2781 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2782 by the classical C errno scheme. This is to prevent an obscure
2783 behavior of the python wrappers when importing wxPython.wx prior
2784 to gdcmPython (which ended up in an abort call). An illustration
2785 of this oddity can be found in the Test/ExceptionAndPython
2786 subdir (see the README file). This problem probably due to
2787 an combination of g++ and dynamic loading.
2788 * added Test/ExceptionAndPython (see above)
2790 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * Changed the layout of the python part to avoid bloating main
2792 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2793 i.e. the distutils arsenal. All the python related stuff is
2794 again in a python subdir, but the package itself is now in
2796 * setup.py was cleaned up:
2797 - pythonIncludePath removed
2798 - python setup.py bdist target is now functional.
2799 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2800 collision with other packages). gdcmPython/demo/*.py changed
2803 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * python subdir moved to gdcmPython (preparation of distutils packaging).
2805 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2806 distutils installer is operational.
2807 * - gdcmPython/__init__.py now properly loads the swig generated
2808 shadow classes (from gdcm.py).
2809 - gdcmPython/demo/*.py changed to import the package gdcmPython
2810 instead of gdcmPython/demo/load.py.
2811 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2813 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2815 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2816 entries within the associated public Dicom dictionary resp. the same
2817 information but sorted by the fourth field (PAT, IMG, DIR) of the
2819 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2820 are now in the "???" group.
2821 - python/gdcm.i changed accordingly,
2822 - python/demo/printGroupedPublicDict.py added, that gives an example
2823 of the above new functionalities in Python.
2825 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * src/gdcm.h, gdcmHeader.cxx:
2827 - historic references to glib's g_malloc and g_free (#defined)
2828 were definitively removed.
2829 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2830 * src/gdcmElValSet.cxx:
2831 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2832 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2833 - GetElValue(string) renamed to GetElValueByName.
2834 - Added GetElementByName(string).
2835 * src/gdcmHeader.cxx: added
2836 - GetPubElValRepByNumber(guint16, guint16)
2837 - GetPubElValRepByName(string)
2838 - GetShaElValRepByNumber(guint16, guint16)
2839 - GetShaElValRepByName(string)
2840 - GetShaElValByNumber(guint16, guint16)
2841 - GetShaElValRepByName(string)
2842 - GetElValRepByNumber(guint16, guint16)
2843 - GetElValRepByName(string)
2844 - GetElValByNumber(guint16, guint16)
2845 - GetElValRepByName(string)
2846 * Doc/requirements.txt added.
2848 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * Test/Makefile building now depends on the one of libgdcm.so
2850 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2851 pixel data) aware which enables finding the address (offset) of
2852 the pixel data of JPEG encoded DICOM files. This leaves only a single
2853 file in the testSuite whose pixel data address (offset) is unknown.
2854 * python/testSuite.py changed accordingly.
2856 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2857 * VC++ has some strong limitations when working with the STL, as stated
2858 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2859 "Also note that some STL containers (map, set, queue, list, deque)
2860 cannot be exported. [...]
2861 Some STL classes contain nested classes. These classes can not
2863 This is caused by a designed limitation that once a template
2864 class is instantiated, it can not be re-instantiated and
2866 Since our usage of map<> is ubiquitous in gdcm, this "designed
2867 limitation" of VC++ is a pitfall.
2868 Hence the Python wrappers of gdcm cannot be incrementally linked
2869 against the c++ dynamic library. The dirty but only workaround is
2870 to forget about incremental link of dynamic libraries and to generate
2871 the Python wrappers library with the inclusions of the underlying C++
2873 The following modifications concern this matter on Win32/VC++:
2874 - wrapping python correct with standalone wrapped dll (don't use separate
2875 dll under windows !!!!)
2876 - python21_d debug mode enabled (ask Frog how to use it :-)
2877 - NO problem with having an STL member of class for example string in C++
2878 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2879 - Python test of dcmlib in Python is ok under windows on a large set
2881 * removed glib references
2882 * typedef's inserted in gdcm.i for correct swig type management
2884 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * python/demo/*.py load.py extracted from test.py. Added explore.py
2886 that only displays required tags and testAll.py that parses all
2887 the files of the testsuite without using unittest.
2888 * python/testSuite.py other additional test on new files added.
2889 * Data/* new test files added accordingly to the testSuite.
2890 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2891 the vr in the file differs from the one of the dictionary.
2893 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2895 values, but limits itself to values which are below a user specified
2896 size (by default 1024 bytes).
2897 * python/gdcm.i : elements not loaded (because their size is above the
2898 user specified treshold) are exported with their TagKey as key of the
2899 python dictionary. This enables the testsuite to make some checks
2900 on the unloaded elements (since we have their offset and size).
2901 * python/testSuite.py
2902 - now tests for the existence and proper value of the pixel data
2903 - two new examples added.
2904 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2906 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2908 aware. See the strategy comments in gdcmHeader::FindeLength().
2909 * Test/test.cxx now accepts a filename as first argument.
2910 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2911 * python/testSuite.py changed to integrate test on above files.
2913 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2914 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2915 the vr was also RET.
2916 * python/testSuite.py more tests added.
2918 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2919 * python/testSuite.py unittest test suite added (uses Data)
2920 * Data/* dcm and acr files for the test suite.
2921 * glib dependance removed from un*x version. We now use ISO C99
2922 7.18 Integer types (see stdint.h)
2923 - python/Makefile, src/Makefile src/gdcm.h
2924 * src/ when an explicit vr (like dicom files) suddenly poped an
2925 implicit element we use to mark the underlying DictEntry of the
2926 concerned ElValue with "Implicit". This strategy was damageable
2927 too the public or provite dictionaries, since some of their vr
2928 would be changed. Since Header::FindLength heavily relies on the
2929 detection by Header::FindVR of falsely explicit elements, I
2930 added an extra ImplicitVr member to ElValue (boolean).
2931 The rest of the changes we the necessary adaptations.
2933 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2936 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2938 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * Adaptation for porting to VC++:
2941 o forced to use std namespace (for string to be known)
2942 o all class use __declspec export style on WIN32
2943 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2944 (in stdlib.h on Win32 but in std:: for gcc)
2945 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2946 variable GDCM_DICT_PATH.
2947 * src/gdcmHeader.cxx verbose comments made discrete.
2949 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * python/gdcm.i: added a typemap that converts a C++ hashing table
2951 to native Python dictionary.
2952 * python/demo/test.py:
2953 - now uses the native dictionary for exploration of gdcmHeader.
2954 - takes an optional filename argument (the file to parse).
2955 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2956 PubElVals hashing table.
2957 * Dicts/dicomV3.dic removed error prone trailing spaces.
2959 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * Python wrapping process moved away from src/Makefile to
2961 newly created python/Makefile (as well as gdcm.i)
2962 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2963 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2964 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2965 from the environement variable GDCM_DICT_PATH (when existing).
2966 * src/gdcmDict::GetTag bug fix.
2968 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * Straightforward temporary fixes for swig to build the python wrappers.
2970 src/Makefile now has a python working entry [by working we mean
2971 that we can import de shadow classes without errors].
2973 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * hashtest.cxx removed (since already in Test)
2975 * src/gdcmlib.h renamed to src/gdcm.h
2976 * src/dcm.i renamed to src/gdcm.i
2977 * src/Makefile prepared for python wrapping
2979 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2980 * src/gdcmHeader.cxx :
2981 - Parsing of header is now separated from loading of element values
2982 (see gdcmHeader::LoadElements).
2983 - general clean up of hopefully all file access (creation of
2984 ReadInt16 and ReadInt32)
2986 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2987 * src/gdcmHeader.cxx :
2988 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2990 - SetLgrElem renamed to SetLength
2991 - GetLgrElem renamed to GetLength
2992 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2993 * src/gdcmElValSet.cxx fixed both GetElValue methods
2994 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2995 due to IdoDude was cleaned out.
2997 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2998 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2999 concentrates on finding the value representation (when it exists).
3000 RecupLgr now only finds the element value length, and it avoids
3001 returning the unecessary skL (skipped length).
3002 Also, offsetCourant was simply removed (with taille_fich) since
3003 it was redundant with the File position internals (by using
3004 ftell and fseek). This also made skL (see above in RecupLgr) usage
3006 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3007 on the libido specificities which are handled through class
3009 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3012 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3013 * Truckload of changes. Parsing of header is barely functional
3014 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3016 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3017 * src/gdcmHeader.cxx many addons of low level methods
3019 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3020 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3021 and _IdDcmSWAP_LONG.
3023 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3024 * This corresponds to all the changes decided at the meeting of
3025 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob