1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
4 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
6 Remove all access to the hash-tables or lists in the objects.
8 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
10 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
11 be complient with all the gdcm source code
13 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
17 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
21 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * Test/ : rename VTK tests to have a best name for the tests
23 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
24 GetFirstEntry/GetNextEntry use
26 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
28 test. Now it's on image content and not on the resulting visualisation...
29 might solve the problem on linux when using the OpenGL drivers
31 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
32 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
33 DicomDirSerie, DicomDirImage
34 Dict, DictSet classes :
35 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
36 -remove InitTraversal method.
37 * UPD Test programs + Example programs
39 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
40 remove useless and never updated keyword \ingroup
42 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
44 is no memory access violation
45 * gdcmPython/demo : add python demos using VTK
47 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
48 * FIX 'Dictionnary' is now spelt 'Dictionary'
49 'wether' is now spelt 'whether'
50 'archieve' is now spelt 'archive' ;-)
52 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
53 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
54 related methods, in order not to expose internal mechanisms
57 * REM methods that exposed internal mechanisms :
58 DicomDir::GetDicomDirPatients()
59 DicomDirPatient::GetDicomDirStudies()
60 DicomDirStudy::GetDicomDirSeries()
61 DicomDirSerie::GetDicomDirImages()
72 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Removed the Print/indent/default parameter mess. There is absolutely no
74 reason to have to methods, moreover with the second taking the ostream as
75 *SECOND* parameter. This was clearly a bad hack to get things compile.
77 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
78 * Complete rewrite of the GetMacAddress code. Now the code is *much*
79 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
80 Unfortunately the main code does not work on SunOS, thus provide a specific
81 code for this platform only (and Win32 of course). Since this seems to be
82 working, change CreateUniqueUID to use GetMACAddress instead of the
83 problematic GctestetIPAddress
85 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * Unfortunately to be able to test gdcmDirList I had to break the API
87 a little. Now the class is not a std::list anymore but has a member
88 std::vector (more ITK compatible). Allow unit testing on Win32 and
91 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
92 * Update SerieHeader to take into account a Serie Instance UID to properly
95 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
96 * ENH - Comment out Mathieu's (dangerous) Super Hack
97 for dealing with BIGENDIAN processors
98 - Move equivalent stuff to BinEntry::WriteContent
99 When necessary, 16 Bits Pixels are swapped in a small buffer
100 and then written. This avoid allocating a huge buffer, in
101 PixelWriteConvertor, and avoid modifying the Pixel Area.
103 Probabely, the same operation will have to be done when we want
104 to write image with Big Endian Transfert Syntax,
105 and we are working on Little Endian Processor
107 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
110 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
111 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
112 all the dict content.
113 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
115 * Test/TestDict.cxx : add a new test for the dict classes
117 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
119 file. Debug is yanked if compiled with NDEBUG
121 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmDictSet.h : set the default output to the os variable
123 * src/gdcmDictEntry.[h|cxx] : add the Print method
124 * gdcmPython/demo/ : add a new test
126 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
127 * merging of Test/PrintDicomDir and Test/TestDicomDir
128 * removal of now redundant Test/PrintDicomDir
129 * enhancement of Example/PrintDicomDir
131 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Now, python test might work on systems
133 * Add the PrintDicomDir test
135 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
136 * FIX : First entry following group 0002 was lost for
137 Explicit Big Endian Transfer Syntax files
138 (group and elem not swaped)
140 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
141 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
142 Big Endian Transfer Syntax supposed the group following 0002
143 begins always by element 0000 (element 0000 is *optional*)
144 To avoid further troubles, let's be pessimistic, and use
145 Document::HandleOutOfGroup0002() method
146 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
147 (related pb not yet solved)
149 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * Bug fix for the python part use
151 * Now, PrintHeader.py pass... but outside the ctest use. shit !
153 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
156 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
157 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
158 a string and should ask the global TS dict what are the propreties of
161 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
162 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
163 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
164 to swap the Swap Code, at parsing time, when we come out of group 0002
165 and Transfer Syntax is Big Endian
166 We should be able to read now 'true DICOM" Big Endian coded images
167 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
168 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
170 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
171 * Hopefully fix the bug on MacOSX and static global initialization.
172 This is the only -minor- patch I found that both please MacOSX and VS6.
173 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
174 but this would require a lot of change. Another approach would be that Global
175 create those string and GDCM_UNFOUND becomes a pointer to a string (which
176 gdcm::Global would destroy at exit).
178 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
179 * Fix bug on MacOSX with static initialization in a multy threaded
180 environment. static const string in a header file used to be ill
181 initialized provoquing the freeze of any tests. patch should solve this
184 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
185 * According to Benoit's suggestion, and without any objection from anybody
186 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
187 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
188 - method gdcmDicomDirObject::GetEntry() renamed as
189 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
191 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
193 you debug/warning message just as c++ streams which make them very convinient
194 to use. Once this is stabilize I will change the ostringstrem to be
195 redirected to a file (ofstream).
196 * Properly support C99 extension: __FUNCTION__ which allow us to display
197 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
199 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * Removal of useless and dangerous methods :
201 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
202 GetDocEntryByName, GetEntryByName, GetDictEntryByName
203 * Removal of usless methods :
204 Dict::PrintByName, Dict::GetDictEntryByName
205 * Commenting out of probabely useless methods :
206 Dict::GetDictEntryNames()
207 Dict::GetDictEntryNamesByCategory()
208 DictSet::GetPubDictEntryNames()
209 DictSet::GetPubDictEntryNamesByCategory()
210 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
211 * ENH : Use dicomTS.dic as described in 2004 version
212 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
213 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
214 Add Accessors on VM (Value Multiplicity), and VM related methods
215 * ADD : Add a list of 'Dicom Attribute types', as found in
216 http://medical.nema.org/dicom/2004/04_15PU.PDF
218 * ADD : Add dicomGroupNameAbbreviations.dic
219 should be used to write a method to replace the former
220 Dict::GetDictEntryNamesByCategory()
222 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
224 to read in the file... and only it ! Length is the efective length of the
225 data in the DocEntry structure
227 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
229 And now use a static function call instead, with a global variable. i
230 This is much closer to the VTK approach. Hopefully should be bulletproof
231 and easier to use...hopefully
233 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
234 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
236 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
239 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
241 ValEntry, BinEntry, SeqEntry creation or replace
243 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
245 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
247 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
248 when specifying the VR
249 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
250 * src/gdcmDocEntry.cxx : amelioration of print
252 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
253 * ADD : Add the method Util::IsCurrentProcessorBigEndian
254 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
255 * ADD Method Document::ComputeGroupLength
256 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
257 in order to allow further VR modification by user
258 * REM : removal of once-called method File::WriteBase
259 integration of its code in formerly one-line method File::Write
261 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
263 replace the different values "??", "Unkn", "Unknown".
264 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
265 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
266 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
267 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
269 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
272 * Set the gdcm::Base class to some Printable classes
274 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmFile.[h|cxx] : add the Print method
276 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
277 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
278 * src/gdcmDocument.h : remove the PrintLevel informations
279 * Example/PrintFile.cxx : use the new gdcm::File::Print
281 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
283 problems when compiling with the python wrapping
285 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
287 writting in ImplicitVR
289 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
290 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
291 JPEG decompression, especially when dicom frames are split into several
292 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
293 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
295 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmHeader.cxx : change the initialisation of default header.
297 Now, this header is readable by gdm, e-film, DicomWorks
299 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
301 Rename Decompressed to Raw
302 * Use the API changes in gdcm::File.
303 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
306 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
308 each added entry in the header. Replace the 'Planes' field by the 'Number
311 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
313 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
315 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
317 At this time, this image isn't readable by e-film... waiting JPR help to
320 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
322 DocEntry. Now use methods of the Document !
324 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * Test/ShowDicomSeq.cxx : bug fix
327 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
329 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
330 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
331 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
333 * Test/TestCopyRescaleDicom.cxx : remove unused variable
334 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
335 containing found sequences
337 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
340 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
341 Some fields in BinEntry must be copied to not seg fault when making the :
342 gdcm::File *copy = new gdcm::File( copyH );
343 and tests are now made on good variables
345 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
347 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
349 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
350 * Add vtkGdcmWriter example and test
352 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * Test/TestUtil.cxx : reformat the source code
354 * vtk/vtkGdcmReader.cxx : remove and change prints
355 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
357 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
358 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
360 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
362 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
364 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
366 by an eof to prevent all bad read of the file... and in this case, the
369 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * Example/Volume2Dicom.cxx : comment unused variables
371 * Test/PrintDicomDir.cxx : comment unused variables
372 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
373 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
374 method that is redondant with AddEntry.
375 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
378 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * Bug fix due my last commit (compilation under Windows).
380 * Example/Volume2Dicom : bug fix in the file and reformatting source code
381 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
383 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 - Remove printf / sprintf
386 - include iostream AFTER gdcm so we don't get warnings
387 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
389 - Also remove tons of include from header files, hopefully this should
390 speeup the compilation time, since it was becoming a dog slow.
391 - Remove gdcm.h as it include way too many files and slow down compilation
392 (plus it is not up to date)
393 - remove 'using namespace std' this is BAD !
395 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Remove memory leaks on the DicomDir
397 * Remove some useless data in DicomDirObject
398 * Add usefull methods in SQItem, to be complient withe the ElementSet
400 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
403 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
405 future, with convertion)
406 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
407 and ImageDataSize values. Remove the method to get the PixelReadConverter
408 from the output of the class
410 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
413 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
415 and vtkErrorMacro use.
416 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
418 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
421 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
422 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
423 The string leaves only in the fonction. So when we make a .c_str(), we
424 get the pointeur on the first element, element that will be destroyed
425 immediately after thee instruction.
426 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
427 file has been opened : the test must be made on the content of the
428 pointer and not directly on the pointer !
431 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
433 the python part recompiles
435 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
437 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
438 X session is killed (for my computer... it seems to not be identic on
441 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
443 avoid problems (otherwise, the difference test between the visible image
444 and the reference is incorrect. If the reference is greater than the
445 screen resolution, it's produce errors).
446 Can be used for only one image. Can be used with a visible flag.
447 * vtk/vtkGdcmReader.cxx : remove commented codes.
448 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
449 under windows at compilation
450 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
452 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
454 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
456 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
457 tests on the image size X, Y, Z
459 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
461 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
462 between the class name and the file name
464 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/ : fix compilation warnings for the Write method (2 different
466 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
467 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
468 variable... create a static method in gdcm::Document to access to
469 this variable content.
471 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
472 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
473 file, to be accessed by other files (like gdcmFile). Remove commented
474 code. Move the change of the header to the gdcmFile, using the
476 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
477 To be sure of that (and simplify calls), the Write of the header now
478 gets a file name and not a file pointer (std::ifstream).
479 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
480 DocEntryArchive. Remove all open of the written file
482 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
485 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
487 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
489 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
490 some corresponding methods. Write correctly the file and check before
492 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
493 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
494 is now on RGB data (as before my last commit
495 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
497 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
499 Add a print information of the type of the entry
500 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
501 It was in the gdcmFile, and all write have been regrouped
502 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
503 Write correctly all dicom files (in decompressed mode only at this time)
504 * Test/ : test on files are now made using Raw data and not color data if
506 * Example/PrintFile.cxx : add more printings
508 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * Amelioration of code, remove some code copy. For the loading of
510 BinEntry (in gdcmDocument), add the test to verify if the file is already
513 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
515 remove a DocEntry in the header (push an empty DocEntry)
516 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
517 lines. Bug fix in the initialization of the PixelConvert and the
519 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
520 use in TestCopyDicom (now this test can run under windows... but fails)
521 * Test/TestCopyDicom.cxx : amelioration of the test :
522 - test the pixels written
523 - add test points to quickly find where is the error
524 - can set a file name input and output in arguments
525 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
526 amelioration of the test output
528 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
530 all replaced DocEntry's
531 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
532 Now, each needed DocEntry to modify is duplicated, modified and inserted
533 to the header using DocEntryArchive. Thus, after save, we can restore the
534 header initial state.
536 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
539 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
541 correct to copy it. The DictEntry is specified at the DocEntry creation,
542 then, it musn't change in the time.
543 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
544 header correctly. At this time, the change is only made for the first
545 level of the Document. In the future, it might consider sequences.
546 The change is made by replacing a DocEntry by an other that is created
547 outside the class. The old value is kept. When we restore the header
548 status, the added DocEntry is deleted and replaced by the old value.
549 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
550 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
551 set the write type to explicit VR, implicit VR or ACR. Add methods to set
552 the write mode to native, decompressed or RGB (but not used at this time)
554 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
556 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
558 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
560 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
562 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
563 set because already copied when copying the BinEntry's of the header
564 * Test/TestAllReadCompareDicom.cxx : remove warnings
566 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
568 Two problems appear when doing it :
569 - with the gdcmFile : when the GetImageData method is called, the pixels
570 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
571 data (pixels). And each structure destruct the data when it's
572 destructed. So we have two destructions for the same data. To solve it,
573 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
574 data or not. If it doesn't own data, then they will not destroyed by
576 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
577 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
578 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
579 create a double destruction of the same DocEntry's. So, to solve it,
580 the TagHT is simply cleared and the DicomDir* elements are destroyed.
581 * TODO : add an entry concerning memory leaks in the DicomDir
583 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
585 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
588 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
590 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
591 after it have been deleted
593 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * FIX: src/* fix the doxygen warnings.
595 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
596 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
597 was erroneously defined with a size of 15 instead of 16. [many thanks
598 to Jean Michel Rouet for pointing out this bug].
600 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 1. Finish merging JMR patch for writting DICOM from scratch
602 2. Fix -hopefully- bug with MONOCHROME and space vs null character
603 3. Use const ref when possible
604 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
605 5. A few more comments
606 6. CreateUniqueUID can now be called without parameter"
608 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
609 * ENH: Slightly bigger patch:
610 1. Getting toward full integration of JMR patch for writting dicom from scratch
611 2. Update Test to test part of this patch: CreateUniqueUID
612 3. File was not close properly in gdcmDict
613 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
614 5. Use of const ref instead of copy (speed issue)
615 6. Remove temporary (duplicate) string in TranslateToKey
616 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
617 8. Do not repeat virtual in subclasses
618 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
620 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
621 * Apply first patch toward better string comparison when dealing with broken
622 DICOM files. Essentially the string could be padded with a space instead
623 of a null character as defined by standard
625 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
627 because never used... and in the same time, that's remove some memory leaks
629 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
630 * src/gdcmFile.cxx : now delete the PixelConvert instance.
631 * In examples and tests : change the type of image data variables from void*
632 to uint8_t*. Remmove all delete on image data variables
634 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
636 Verify the file pointer value before open the file, and if it's not null,
637 a verbose message is generated.
638 Close correctly the file when the file isn't considered dicom-like. The
639 correctly close is a call to CloseFile.
640 When closing the file pointer, test if its not null to close the file.
641 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
642 file. For an uncompressed image, the copied data correspond in the least
643 case to the image size (calculated) or the image size specified in the
644 header. A verbose is generated if these two size mismatch
646 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
648 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
649 break under windows (with msvc6 compilation).
651 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
653 compiling with MSVC6)
655 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * Bugs fix for the Windows build with VC6
657 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
658 needed (only for projects required VTK). If the VTK is included in all
659 projects, there is conflicts with the jpeg lib of vtk when compiling the
660 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
661 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
662 when compiling the gdcm_wrap.cxx file (created by the compilation of the
664 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
665 (like it's already made for the cout use). Otherwise, conflict with the
668 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
671 - comments on the DicomDir::Method related usage added.
672 - now that we use the namespace gdcm, a lot of internal classes do
673 NOT need to be wrapped anymore.
674 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
675 DicomDir::Method) new example added.
677 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
678 * Improve string manipulation. I now inforce the notion of 'DicomString'
679 A DicomString can contain as many \0 as they want
680 and it is *always* of even length.
681 We only support odd length for very rare case.
682 And in the near future this should be removed.
684 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
685 * /binary_write/ gdcm source. Now even on big endian we are writting
686 little endian. This should -heopfully- fix some tests
688 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
689 * Now the dictionary is compiled into gdcm lib. This is a default
690 behavior, thus any dic file specified is picked before failback to
691 the one comiled into lib
693 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
694 * Change internals for gdcmDict. Don't use any 'new' any more.
695 This should definitely solve any leak problem, and we should be
696 as fast as before, as long as don't modify too much the dictionary.
698 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
699 * STYLE: ivars should start with a capital letter.
700 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
701 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
703 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
705 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
706 new 2004 dictionaries added (thanks to JPR).
707 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
708 * CLEANUP_ROUND (15) for gdcmPixelConvert
709 - RLEFrame::NumberFragments is now of type unsigned int
710 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
711 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
714 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
715 * Initial work in gathering all transfer syntax accessors. clearly
716 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
717 ivars, but only one transfersyntax (class) ivar with equivalent method on
720 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
721 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
722 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
723 discussed (plus I didn't like having a 2000 lines patch not commited)
725 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
727 * CLEANUP_ROUND (14) for gdcmPixelConvert
728 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
729 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
730 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
732 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
733 anymore and hence avoids storing a copy of PixelConvert::Decompressed
734 into File::Pixel_Data.
736 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
738 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
739 * CLEANUP_ROUND (13) for gdcmPixelConvert
740 Substituted File::ParsePixelData() with PixelConvert::Print() new
742 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
743 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
744 method to those classes.
745 - src/gdcmFile.[cxx|h]:
746 -- Added a ::Print() method.
747 -- PixelConverter is now a reference instead of a member.
748 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
749 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
751 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
753 collaboration diagram and inheritance diagram should be generated with
755 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
756 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
757 pointlessly wrapped (see
758 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
759 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
760 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
761 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
762 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
763 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
764 -- File::Initialise: PixelConverter setup moved away to
765 PixelConverter::GrabInformationsFromHeader()
766 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
767 interpretation moved away to PixelConverter::BuildRGBImage()
769 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
770 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
771 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
773 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
775 displayed on Win32 when a brutal abort() occurs (because of uncatched
776 exception). See TODO new entry of this commit for more on this.
777 * TODO added new entry.
778 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
779 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
780 - HandleColor is no longer called from gdcmFile.cxx
781 - gdcmPixelConvert.cxx clean up on method arguments and internal
782 variable names for semantical coherence.
784 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
785 * Finished lossless transition, not only do we now read all lossless jpeg
786 images, without the need of the Cornwell lib, but we do read them properly now
787 * To reduce code (well to avoid code duplication), I defined a common place
788 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
789 redefine symbols. This is not perfect but this the best solution I found for a
790 compilation time jpeg option.
792 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
793 * Update jpeg ijg lib to support lossless jpeg implementation
794 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
796 * Also added a special copyright for dcmtk since we use their bugfixes.
799 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
801 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
802 matters, as stated in warning note at begining of %include section).
803 * src/gdcmDicomDir*.[cxx|h]: coding style
804 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
805 * src/gdcmJpeg8.cxx: doxygen fix.
806 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
807 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
808 from File:: to PixelConvert::.
810 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
812 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
813 - more code moved away from File:: to PixelConvert::
814 - fat setup of PixelConverter set in place in File::Initialise.
816 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
817 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
818 namespace at the file system level. So now you should convert your examples
820 gdcmHeader -> gdcm::Header
821 It would be nice if people keep in mind to no open the namespace, since it
822 allows compilation on broken plateform which were defining common symbol in
823 the standart namespace (like LP, Unknown ...)
825 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
827 The JPEG fragments are now parsed at the same stage than the RLE
828 information. All code related to JPEG is now in gdcmPixelConvert:
829 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
830 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
831 export a gdcmFile:: method. Those are simply global functions
832 (for the time being this is better than having them attach to
833 either gdcmFile:: or gdcmPixelConvert::).
834 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
835 and stores the result in a gdcmJPEGFragmentsInfo.
836 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
837 code (among other stuff) moved away from gdcmFile:; to
840 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
842 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
843 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
844 clean up of RLE related code.
845 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
846 - src/gdcmRLE.cxx removed
847 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
848 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
849 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
850 * CLEANUP_ROUND (9) for gdcmPixelConvert
851 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
852 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
853 away from gdcmFile:: to gdcmPixelConvert::.
855 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
857 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
858 This is because Parse7Fe0 used to parse the pixels to compute the
859 length. This task was passed over to FindDocEntryLengthOB() a long
860 time ago, EXCEPT I had forgotten the OW case...
861 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
862 we just recylce the code for parsing RLE fragments and computing
864 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
865 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
866 with the retired Parse7Fe0().
867 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
868 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
870 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
872 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
873 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
874 - src/CMakeLists.txt: alphabetic order reodering + new entries.
875 * CLEANUP_ROUND (4) for gdcmPixelConvert
876 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
877 to return an unused length.
879 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
880 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
881 this should be cleanner from the plane view. The iostream are erally a pain
882 to use to do simple stuff.
884 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
885 * Redo the compilation of the ijg jpeg library. Now only one source is
886 necesseray. No need to rename file by hand what so ever. CMake handle the
887 copying of the file within different directory, configure header file to
888 modify some symbol. The only addition made to ijg wasd a mangle table so
889 that symbol are different whether we are within 8bits or 12bits.
891 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
892 * Added documentation of vtkgdcmReader on Website:
893 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
894 with it's binary name).
895 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
896 the Website to be more complete.
897 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
898 doxygenated documentation.
899 - Doc/DoxyVtkGdcmReaderExamples.txt added
900 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
901 DoxyVtkGdmReaderExamples.html )
902 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
903 * CLEANUP_ROUND (3) for gdcmPixelConvert
904 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
906 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * CLEANUP_ROUND (2) for gdcmPixelConvert
908 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
910 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * CLEANUP_ROUND for gdcmPixelConvert:
912 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
913 - src/gdcmPixelStuff[h|cxx] removed
914 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
915 - src/CMakeLists.txt changed accordingly
917 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
918 gdcmVersion.py moved to newly created ATTIC related
919 gdcmPython/SetupOldies/ directory.
920 * Autotools clean up:
921 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
922 - autogen.sh configure.in acinclude.m4 python.m4 removed
924 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
925 * src/*.cxx *.h Reference to License.htm fixed to License.html.
926 * Doc/CMakeLists.txt, doxygen.config.in: fix.
927 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
929 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * TODO updated with Mathieu suggestions. I proposed a template for
931 describing TODO entries and used it for new entries.
932 * Added Doc/Website/CodingStyle.html, Developpers.html,
933 DeveloppersPython.html, GdcmDataCvs.html and
934 DownloadVersion0_1.html, DownloadVersion0_3.html.
935 * Some Doc/*.txt Doxygen files (which do not really concern the
936 documentation itself, but the website) moved to html and
937 placed in directory Doc/Website:
938 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
939 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
940 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
941 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
942 * CMakeLists.txt changed accordingly.
943 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
944 DeveloppersPython.html
945 * INSTALL nows refers to Doc/Website/Installation.html
947 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Added Doc/Website directory, that contains a first raw version
951 2004-09-23 Jean-Pierre Roux
952 * FIX In order not to be poluted any longer by casting problems,
953 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
954 we can now delete[] it safely
955 * VoidArea is now called BinArea (less confusing name),
956 and all the methods called ...VoidArea... are now ... BinArea...
957 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
959 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
961 clear) TagHT, which is an inherited member of gdcmElementSet. It is
962 up to the destructor of gdcmElementSet to clean up TagHt and it's
965 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * Test/CMakeLists.txt: update to follow gdcmData renamings.
967 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
969 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * ENH: added some utility method that builds a flat dictionary
971 holding all the Dicom entries contained in the recursive structure
972 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
974 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
975 BuildFlatHashTable() that build a flat dictionary.
976 - src/gdcmElementSet.h: added a new private GetTag() accessor.
977 gdcmDocument is now a friend of gdcmElementSet.
978 - src/gdcmElementSet.cxx: clean up.
979 - Example/FlatHashTablePrint.cxx added.
980 - Example/CmakeLists.txt changed accordingly
982 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
984 moved away from gdcmDocEntrySet (since this class is an abstract class
985 acting like an interface). SQDepthLevel and BaseTagKey are now
987 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
988 and associated accessors. Doxygenation of the class.
989 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
991 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
992 Use SQDepthLevel accessor instead. ::Print() adapted.
993 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
994 - src/gdcmDocument.cxx changed accordingly.
996 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
998 - The following is the doxygen comment of the typedef declaration
999 of gdcmTagKey in src/gdcmCommon.h:
1000 gdcmTagKey is made to old an "universal" (as in URL, Universal
1001 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1002 A dicom tag always has a group and an element, but a set of tags
1003 embeded in various (optionally nested) sequences and sharing
1004 the same group and element all share the same (group, element)
1005 "identifier". Hence the (group, element) cannot be used as an
1006 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1007 In order to construct a proper tag identifier (i.e. a key) we
1008 consider the following definition of a TagKey:
1009 - let Group, Element be the string representation of the
1010 group and element dicom tag members,
1011 - let ItemNumber be the string representation of the integer
1012 index of the considered item number of a sequence,
1013 Let the key of a tag embeded in a sequence, noted SeqTag, be
1015 /ItemNumber#Group|Element
1016 where "/", "#" and "|" are characters acting as separators.
1017 Then the general form of a gdcmTagKey is given by:
1018 Group|Element<SeqTag>
1019 where <SeqTag> means NO or many instances of SeqTag.
1020 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1023 but the gdcmTagKey of a tag "embeded" is the first item of
1024 a sequence, itself nested in the third item of a sequence is the
1026 0004|1220/2#0008|0082/0#0008|0090
1027 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1028 order to hold the new sequence compatible key. Previously, the
1029 GetKey() method would look in the underlying gdcmDictEntry.
1030 - src/gdcmDocEntry.cxx:
1031 -- constructor now copies the underlying DictEntry key, in the local
1033 -- ::Print: displays the member Key, instead of the (group, element).
1034 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1035 - src/gdcmDocEntrySet.h:xi
1036 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1037 -- now has a new BaseTagKey member.
1039 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1040 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1042 This poses the problem with the semantics of the following lines
1043 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1044 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1045 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1046 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1047 to the long FIXME note for what the problem is. Nevertheless in
1048 order to get things working the dicom dictionary was altered !
1049 Please fix things urgently...
1050 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1051 information), see above note on moving the member VoidArea. Nevertheless
1052 the following entries previously correctly set as US are now inproperly
1054 0028 1201 OW IMG Red Palette Color Lookup Table Data
1055 0028 1202 OW IMG Green Palette Color Lookup Table Data
1056 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1057 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1058 of gdcmDocEntry moved to gdcmSeqEntry.
1059 * src/gdcmSeqEntry.cxx: STYLE.
1061 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1062 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1064 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * gdcmPython/testSuite.py: all the test suite in python is now moved
1066 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1067 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1068 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1070 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1072 to avoid inclusion recursion until STL is reached.
1073 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1074 mecanism. errno.h is not included in gdcm anymore.
1075 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1076 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1078 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1079 gdcmData/TestAllEntryVerifyReference.txt
1080 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1081 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1082 exception_on_error parameter.
1083 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1084 - vtk/vtkGdcmReader.cxx changed accordingly,
1085 - Example/*.cxx and Test/*.cxx changed accordingly.
1087 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1088 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1089 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1090 enable_sequences removed from gdcmHeader constructor and dependencies.
1091 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1092 * gdcmPython/demo/PrintHeader.py: dummy fix.
1093 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1094 skip_shadow removed from gdcmHeader constructor and dependencies.
1095 * Example/*.cxx and Test/*.cxx changed accordingly.
1097 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1099 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1101 2004-07-21 Jean-Pierre Roux
1102 * FIX Now, Parsing and Printing a DICOMDIR do work!
1103 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1105 2004-07-20 Jean-Pierre Roux
1106 * FIX Some brain damaged headers have Zero-Lenght fields
1107 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1109 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1110 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1111 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1112 variable (instance of gdcmDebug) by a definition macro, and the instance
1113 is now in static in the gdcmDebug class
1114 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1115 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1117 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * WARNING: ctest now depends more tightly on gdcmData. You should
1119 check out gdcmData properly for things to run smoothly...
1120 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1121 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1122 we need the pixels not be loaded in order to use the ValEntry
1123 that displays position and size).
1124 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1125 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1126 be deprecated. If you have any doubts about the advantages of a
1127 modern scripting language (read Python) versus grass root C++ (i.e.
1128 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1129 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1130 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1131 Anyhow, consider documenting the gdcmData images in
1132 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1134 * Test/CMakeLists.txt:
1135 - now uses TestAllEntryVerify.cxx
1136 - specific comments on oldACR00001.ima (now renamed in gdcmData
1137 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1138 gdcmData/TestAllEntryVerifyReference.txt
1141 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * src/*.[h|cxx] : typedef clean up
1143 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1144 - TagKey renamed to gdcmTagKey (for external usage)
1145 - VRKey renamed to gdcmVRKey (for external usage)
1146 - removal of typedef duplication.
1147 - Removed all unecessary inline keyword from class inline definitions.
1148 - Some method|function(void) declarations replaced with method|function().
1149 * src/jpeg/libijg12/jdhuff12.c:
1150 - printf polluting ctest removed.
1151 - TAB removal for comminting
1153 - TestAllReadCompareDicom.cxx: added a test that compares all the
1154 images in gdcmDataImages.h with corresponding images in
1155 gdcmData/BaselineDicom/. When baseline images are not present
1156 this test creates them.
1157 Note: we need to validate each reference image, but before that
1158 I'd like to rename them with a more explicit name...
1159 - CMakeLists.txt: changed accordingly.
1160 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1161 including each header needed).
1163 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1164 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1165 test suite to the Example directory. Are concerned:
1170 - TestWriteSimple.cxx
1171 * Test/CMakeLists.txt: added some comments on reasons for black listing
1172 image gdcmData/oldACR00001.ima
1174 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * Test/CmakeList.txt: removed the following from black list (to be coherent
1176 with removal from gdcmData):
1177 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1178 - gdcm-MR-PHILIPS-16.dcm
1180 Added the following because after last cvs update, they cause
1181 ctest -R TestReadWriteReadCompare
1183 - gdcm-MR-SIEMENS-16-1.acr
1185 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1186 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1187 new comments in this file) we temporarily (sigh) move to a weaker
1189 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1190 we don't need to black list the following images anymore:
1191 - 8BitsUncompressedColor.dcm
1193 - US-PAL-8-10x-echo.dcm
1194 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1195 fixes and the beautified code ;-)
1196 This fixes the bug introduced in version 1.42 (when beautifying)
1197 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1198 Note: ctest was blind to this bug (this means we need to still
1199 improve the test suite). The bug could be detected by using
1200 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1202 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1203 and by displaying the (garbage) produced file temp.XDCM...
1205 2004-06-29 Jean-Pierre Roux
1206 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1207 - replace by uggly but working old code :-(
1208 A lot of things should be OK again.
1209 It's really urgent to have a test suite that *tests*,
1210 to prevent Frog's beautifying sessions to break all the stuff
1211 (twice, withing a fortnigh ...)
1213 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1215 redundancy) to added Test/TestReadWriteReadCompare.cxx
1216 * Test/CmakeList.txt: because the compare test of
1217 Test/TestReadWriteReadCompare.cxx fails, the following images are
1218 black listed: - 8BitsUncompressedColor.dcm
1220 - US-PAL-8-10x-echo.dcm
1221 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1222 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1223 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1224 and ad-hoc kludge. This kludge is now removed, and on encountering
1225 such an image (OB field brain damaged) we set errno. Then in
1226 ::FindDocLength() we "fix" the length as being ALL what remains
1227 in the file (until EOF). We then proceed, hoping for the best...
1228 This fixes a SegFault in ShowDicom when trying to write such an
1230 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1231 (because TestWriteRead breaks on it, after a non conformal commit?).
1232 ctest now runs properly, except for MakeDicomDir (which was always
1233 broken) and the Python related stuff (still not fixed).
1235 2004-06-24 Jean-Pierre Roux
1236 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1237 FIX : Test/TestReadWrite now iterates on all the file names
1238 (instead of infinite loop)
1239 ENH : Test/TestWriteRead now iterates on all the file names
1241 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1244 2004-06-24 Jean-Pierre Roux
1245 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1246 when SamplesPerPixel =3
1247 - now Write is no longer confused by
1248 'BitsAllocated = 12" and 'BitsStored=12"
1249 - "UN" value representation Elements are now written correctly
1250 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1251 ENH : - now gdcmHeader has its own Write methods
1252 (in order to split the job that has not to be done
1255 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1256 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1257 loop on the same image until memory went out.
1258 Note: this means we still have gobs of memory loss in PrintDocument
1259 * src/gdcmDocument.cxx: fixes problem on parsing on file
1260 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1262 2004-06-24 Jean-Pierre Roux
1263 FIX : Write - All the Sequences and Sequence Item are now written
1264 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1265 is added a the end, when necessary.
1266 - A lot of brain-damaged images, that were read correctly are
1267 now written correctly
1268 - length compatible BinEntry are now loaded correctly
1269 (even for odd groups)
1270 Note : only Explicit Value Representation was checked.
1271 (question : is implicit VR really necessary for gdcm ?)
1273 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1274 * DEVELOPPER: added a proposition of coding style.
1275 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1278 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1280 Use the gdcmDocEntry::Print() and Write() instead.
1281 * src/gdcmDocument.cxx: bug fix.
1283 2004-06-22 Jean-Pierre Roux
1284 FIX : gdcmDocument.cxx
1285 - Now we do recognize the JpegLossLess format (there was a misstyping in
1286 code 'beautyfication' :-(
1287 - Now we automaticaticaly load the Luts, if any
1289 2004-06-22 Jean-Pierre Roux
1290 In order : to write Sequences, whatever their imbrication level,
1291 : to allow user to create his own Sequences
1292 a lot of modif where necessary (adding, moving, or virtualising methods)
1294 WARNING : save your own sources *before* cvs up !
1297 ADD virtual void Write(FILE *fp, FileType filetype);
1300 ADD virtual void Write(FILE *fp, FileType filetype);
1301 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1304 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1305 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1306 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1307 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1308 ADD std::string GetEntryByName(TagName name);
1309 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1311 std::string vr = "unkn",
1312 std::string fourth = "unkn",
1313 std::string name = "unkn");
1314 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1315 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1316 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1317 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1318 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1319 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1320 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1321 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1324 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1325 ADD virtual std::string GetEntryByName (TagName tagName);
1326 ADD virtual std::string GetEntryVRByName (TagName tagName);
1327 REM virtual bool Write(FILE *, FileType);
1328 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1329 FILE *_fp, FileType type);
1330 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1331 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1332 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1333 REM virtual std::string GetEntryByName (std::string tagName);
1334 REM virtual std::string GetEntryVRByName (std::string tagName);
1335 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1336 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1337 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1339 std::string vr = "unkn",
1340 std::string fourth = "unkn",
1341 std::string name = "unkn");
1342 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1343 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1344 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1345 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1348 ADD virtual void Write(FILE *fp, FileType filetype);
1351 ADD virtual void Write(FILE *fp,FileType filetype);
1354 ADD virtual void Write(FILE *fp, FileType filetype);
1355 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1356 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1357 REM std::string GetEntryByName(TagName name);
1360 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1362 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1364 The default constructor invoked by the line
1365 gdcmHeader *f1 = new gdcmHeader( header );
1366 was gdcmHeader::gdcmHeader(bool) instead of the expected
1367 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1368 Hence the parsing wasn't executed... See also below.
1369 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1370 as explicit constructor didn't do the trick to fix the above problem.
1371 Could anyone explain why ?
1372 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1373 properly calls gdcmValEntry::Print() (that was weed out from
1374 code related to gdcmBinEntry).
1376 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * In order to fix memory leaks:
1378 - Test/TestWriteSimple.cxx: added cleaning of free store through
1380 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1381 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1382 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1383 (through the call to ::AddDicomDirMeta()) or the destructor
1384 would crash when deleting uninitialized ::metaElems].
1385 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1386 - src/gdcmDocument.cxx:
1387 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1388 from dynamic stores.
1389 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1390 was causing memory leaks.
1391 - src/gdcmSQItem.cxx:
1392 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1393 cleanly handled with polymophism: sorry but my milage is low).
1394 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1395 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1396 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1397 This avoids SegFaulting.
1398 - src/gdcmSQItem.h: coding style.
1400 - Test/TestWriteSimple still severely sucks. The output image content
1401 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1402 damaged when displayed with vtkgdcmViewer.
1403 - on memory leaks: TestWriteSimple leaks really less (see entry
1404 of 2004-06-18 in Changelog file for the call to valgrind).
1405 - on segfaults: ctest now passes all the tests but one (no more
1407 * Erroneous leading white fix:
1408 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1409 white[s] (as opposed to from >> xxx, that removes it [them].
1410 - src/gdcmTS.cxx: ditto.
1411 - gdcmPython/testSuite.py: dirty related kludge removed.
1412 * src/*: remaining references to gdcmParser removed.
1413 * src/*[cxx|h]: added copy[way]left header.
1416 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * In order to fix writing of dicom files:
1418 - Test/TestWriteSimple.cxx: a simpler example of writing.
1419 - Test/CMakeLists.txt changed accordingly.
1420 - src/gdcmDocument.cxx:
1421 -- The destructor now recursilvely removes potential sequences.
1422 -- Bug fix in ::IsJPEG2000()
1423 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1424 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1426 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1427 to only declared) and build on top of
1428 ::GetDocEntryByNumber(guint16, guint16).
1429 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1430 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1431 for usage in destructor and treatement of promotion in
1432 ::ReplaceOrCreateByNumber().
1433 - src/gdcmSQItem.cxx: destructor should better handle his job.
1434 Test/TestWriteSimple now runs (or at least it DOES something).
1435 * We can now start hutting memory links. A good starting point is:
1436 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1437 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1438 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1440 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1441 * Valgrind note: after Mathieu Malaterre teached me how to read
1442 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1444 Using gcc, you can force the STL to use malloc and to free memory as
1445 soon as possible by globally disabling memory caching.
1446 With 3.2.2 and later, you should export the environment variable
1447 GLIBCPP_FORCE_NEW before running your program.
1448 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1449 simply vanish (it is still not clear to me, whether this means that
1450 STL std::string leaks or if valgrind believes it leaks...).
1451 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1452 running bin/gdcmTests makeDicomDir):
1453 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1454 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1456 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1457 SegFaulting (I drowned in DicomDir related code when trying to
1458 understand why the list is empty...).
1459 * src/gdcmDocument.h: first BSD license header try.
1460 * Doc/License.txt added.
1462 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * src/gdcmDocument.[h|cxx]:
1464 - Clean up of the Transfer related predicates. They are now all based
1465 on new method isGivenTransferSyntax, that (should) handle properly
1466 the padding problem.
1467 - general clean up, simplification, and coding style.
1468 - Specific clean up of Parse7FE0() (umproperly named actually).
1469 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1471 2004-06-14 Jean-Pierre Roux
1473 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1474 - fix the display of SQItem ordinal number
1475 - add the GetSQItemByOrdinalNumber method
1476 - remove some useless never written private methods
1478 2004-06-14 Jean-Pierre Roux
1480 - adding a constructor taking a gdcmDocEntry as an input param
1481 - ReplaceOrCreateByNumber now returns :
1482 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1483 a gdcmValEntry * if a string value is passed as a param
1485 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1486 according to the param type (no longer sets a gdcmDocEntry)
1487 - GetValEntryByNumber, GetBinEntryByNumber added
1488 - NewValEntryByNumber and NewBinEntryByNumber added
1490 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1492 - GetSQItemNumber and SetSQItemNumber added, to provide
1493 a (relative) Item identier inside a given Sequence
1494 \warning : some pb remaining around this number
1496 - AddEntry now takes the Item Number as a param
1498 - adding a constructor taking a gdcmDocEntry as an input param
1500 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * Memory leak hunt with the following command:
1502 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1503 --show-reachable=yes gdcmTests PrintDocument
1504 It looks like many (all?) leaks are due to the STL (or a bad usage
1505 of the STL. The lines producing the leaks now have a comment with
1506 a "MEMORY LEAK" tag: you can retrieve them with
1507 grep "MEMORY LEAK" src/*
1508 Here are two typical examples which I can't help fixing:
1513 char * test = "babo";
1514 name = test; //// <--- valgrind detects 960 bytes lost in
1515 //// call to std::string::operator=(char const*)
1516 name.clear(); //// Doesn't help !
1524 std::cout << "Type a bunch of characters followed by RETURN: ";
1525 getline(std::cin, line); //// <--- valgrind dectects a loss
1526 //// of 1320 bytes in call to
1527 /// std::basic_istream<>& std::getline<>
1533 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * src/gdcmHeader.[cxx|h]:
1535 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1536 and related, moved away to gdcmDocument.
1537 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1538 the corresponding protected accessors of inherited class
1539 gdcmDocument, removed ! As a consequence gdcmFile had to be
1540 declared friend of class gdcmDocument (see below).
1541 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1542 - Clean up of undefined or unused methods.
1543 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1544 account the changes to gdcmHeader.h).
1545 * src/gdcmDocument.h:
1546 - gdcmFile is now a friend class (in order to take into account the
1547 changes to gdcmHeader.h).
1548 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1549 (see changes to gdcmHeader.h).
1550 - Accessors (reading on the form GetEntry*) are now public.
1551 - Clean up of undefined or unused methods.
1552 * src/gdcmDocument.cxx:
1553 - adaptation to changes to gdcmDocument.h
1554 - ::OpenFile now writes a verbose message when file cannot be opened.
1555 - some std::string properly set to VRKey
1556 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1557 references to gdcmDocument.
1558 * Test/TestFindTags.cxx: changed accordingly to above changes.
1559 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1560 cvs repository gdcmData.
1562 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1564 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1565 conflicts with gdcmValEntry::voidArea.
1566 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1567 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1568 Value representation between StringRepresentable and BinaryRepresentable.
1569 * src/gdcmDocument.cxx:
1570 - method ParseDES: proper indentation restored and usage of
1571 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1572 - method LoadDocEntry: the fingerprint left in the SetValue() of
1573 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1574 removed. Reverting to previous code segment with the proper
1575 dynamic_cast< gdcmValEntry* >.
1576 Note: this was (partially) breaking the python test suite
1577 (gdcmPython/testSuite.py) that made usage of the above
1578 fingerprint to check presence of "Pixel Data".
1579 * src/gdcmDocEntry.h: coding style.
1580 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1581 now taken into account.
1582 * gdcmPython/gdcm.i: adaptation to the new internal representation
1583 of gdcm (exit gdcmParser, hello gdcmDocument).
1584 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1586 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1587 anymore, but instead prints the loaded Python dictionary.
1588 * .... alas, the python testSuite is still broken.
1590 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1591 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1593 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1594 * src/gdcmUtil.h : export methods
1596 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1597 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1599 * Initial addition of automatic python testing
1600 * Initial addition of automatic image comparison
1602 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1603 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1604 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1606 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1607 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1608 * Test/ShowDicom.cxx : bug fix for msvc compilation
1609 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1611 2004-05-04 Jean-Pierre Roux
1612 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1613 new concepts (and new classes) :
1614 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1615 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1616 - Sequence Doc Entries (gdcmSeqEntries)
1617 a Sequence is composed of Items.
1618 Each item is a set of Doc Entries (this is recursive)
1619 The non uniqueness of the 'Dicom tag' is due to this recursivity
1620 (never taken into account)
1621 Our unability to add a new 'entry' in the header
1622 at the proper location (neither in the H-Table (map or multimap),
1623 nor in the Chained List is also due to this recursivity.
1624 Don't try, right now, to use/modify/compile these new sources :
1625 nothing is finished.
1626 We just commit all the stuff, 'as is', in order not to loose it.
1628 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1631 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1632 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1633 file prefix (SetFilePrefix)
1635 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1636 * Add a new test: ShowDicom, for now this is just the c++ version of
1637 checkRead.sh, later it will be able to compare the image read against a
1639 * Replace the DEBUG on the stack with a global entry in cmake interface:
1640 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1642 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1643 * Add an example subdir, with a real example on how to read + write a
1646 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1648 * Doc/CMakeLists.txt: the main page is now properly differentiated
1649 between the developper and user version.
1650 * Doc/doxygen.config.in: dropped search related obsolete flags
1651 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1653 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1654 * DEVELOPPER: added some helpfull comments for compile/test/install
1657 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1658 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1659 src directory, now generated in the build dir.
1660 2. Tests as mentionned smarter
1662 4. Add a new method in gdcmDict that return the PubDict by name
1663 this is interesting for 3rd party lib like ITK,
1664 where we could set the institution name / patient name...
1666 * ENH: 1. Now the test suite is working for real
1667 2. All binaries are now output in the gdcm-bin directory
1668 (this was not true before)
1670 2004-04-28 Jean-Pierre Roux
1671 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1672 SeQuence indented printing of Dicom Header.
1673 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1674 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1675 Computation of SQDepthLevel is now part of gdcmHeader constructor
1676 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1677 tree-like structure of a Dicom Header.
1678 * FIX Test code cleaning
1680 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * ENH: Adding automatic testing
1682 1. Need a DartConfig.cmake to submit to public
1683 2. Add a test driver gdcmTest.cxx
1684 3. gdcmTestMain, an helper for the main test driver gdcmTest
1685 4. Files in Test don't have a main anymore, this becomes interesting
1686 when we add more and more tests, thus dsw don't have to load
1688 * ENH: Adding a GDCM_DATA_ROOT for testing
1689 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1690 one file instead of seven + some small cleanup
1692 2004-04-22 Jean-Pierre Roux
1693 * ENH Minor changes to the Print() methods.
1694 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1695 Header printing. Example given with :
1696 > PrintHeader fileName 2 new
1697 (SQ based tree-like structure still to be done for the Header ...)
1699 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1701 1. I have added some unsigned where needed
1702 2. Some function parameter not used -> (void)
1703 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1704 4. g++ don't like character '\' in comment
1705 5. #define jpeg_create_decompress jCreaDecompress
1706 this really need to be fixed
1707 6. virtualize destructor of gdcmObject ... leakage
1708 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1709 this also really need to be fixed
1710 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1711 remove compression file
1712 (as we only do decompression, right ?)
1713 * ENH: Change malloc/calloc/free with c++ equivalent
1715 2004-04-21 Jean-Pierre Roux
1716 * FIX gdcmHeaderHelper::GetXSpacing
1717 when a single value is found (bug ?), xpacing is now
1718 defaulted to yspacing
1720 2004-04-19 Jean-Pierre Roux
1721 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1722 * ENH add parameters :
1723 bool exception_on_error = false,
1724 bool enable_sequences = false,
1725 bool ignore_shadow = false
1726 to the gdcmFile constructors to be full gdcmParser compliant
1727 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1728 to allow reading of PAPYRUS 3.0 files
1730 2004-04-06 Jean-Pierre Roux
1731 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1733 2004-04-02 Jean-Pierre Roux
1734 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1735 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1736 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1738 2004-03-30 Jean-Pierre Roux
1739 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1740 for ACR file, written out as DICOM files (hope so...)
1742 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1743 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1744 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1745 moved to base class gdcmParser and only the specialisation is kept
1747 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1748 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1749 already does the job.
1750 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1751 (to be consistent with gdcmParser::WriteEntries).
1753 2004-03-30 Benoit Regrain
1754 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1755 upate of the object's instance. It's passed to 2 in the unfavorable
1756 case : one in the ExecuteInformation, one in the ExecuteData
1758 2004-03-29 Jean-Pierre Roux
1759 * ENH : Check on file type to be written moved
1760 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1761 * FIX : gdcmObject::ResetBoundaries now stops properly
1762 when end-of-list is reached
1763 : gdcmVersion modified (as Benoit Regrain asked)
1765 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1767 * src/gdcmUtil.cxx: added forgotten iostream include.
1768 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1769 equivalent to ExplicitVR in existing code).
1771 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1773 now contains all the gdcmGlobal related code.
1774 * minor coding style and doxygenation changes.
1776 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1778 now contains all the Debug related code.
1779 * minor clean-up of includes in src/*.cxx
1780 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1781 CreateCleanString) removed.
1782 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1783 * Doc/DoxyMainPageUser.txt added.
1784 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1785 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1786 src/gdcmDirList.cxx)
1788 2004-03-24 Jean-Pierre Roux
1789 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1791 2004-03-23 Jean-Pierre Roux
1792 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1793 big endian made volumes
1794 * ENH Now gdcmParser constructor and destructor are protected to forbid
1795 end user to instanciate class gdcmParser
1796 (only gdcmHeader and gdcmDicomDir are meaningfull)
1798 2004-03-22 Benoit Regrain
1799 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1800 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1801 gdcmSerie to gdcmDicomDirSerie
1803 2004-03-19 Jean-Pierre Roux
1804 * ENH Now the tree-like structure describing a DICOMDIR comming from
1805 an already existing DICOMDIR file is consistent with
1806 the home-made tree-like structure build ex-nihilo
1807 or build from the files held (recursively) in a Directory
1808 functions gdcmDicomDir::CheckBoundaries()
1809 gdcmObject::SetBoundaries() added
1811 2004-03-17 Jean-Pierre Roux
1812 * REM (Eric Boix bug) : removal of meaningless
1813 gdcmDicomDirImage::NewImage function.
1814 * FIX now file names and directory name are written properly in the
1816 * FIX now gdcmDicomDir constructor may be call without any trick
1819 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1820 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1821 of gdcmDicomDirImage::NewImage as empty function.
1823 2004-02-28 Jean-Pierre Roux
1824 * ENH add gdcmDicomDir:NewPatient
1825 add gdcmDicomDirPatient:NewStudy
1826 add gdcmDicomDirStudy:NewSerie
1827 add gdcmDicomDirSerie:NewImage
1828 to allow making gdcDicomDir object.
1829 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1830 (as opposite to the gdcmHeader chained list)
1832 2004-02-11 Benoit Regrain
1833 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1834 when using from python
1836 2004-02-10 Benoit Regrain
1837 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1838 * FIX : in gdcmDicomDir when the directory is empty
1839 * ENH : add callback and methods to get the progression of dicomDir
1842 2004-02-06 Jean-Pierre Roux
1843 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1844 - GDCM_META added to gdcmDicomDirType
1845 - class gdcmMeta created
1846 * ENH : - A brief summary is now displayed at the beginning of
1847 'testDicomDir' to help disaster magnitude estimation
1848 * REM : Now useless Test/explDICOMDIR.cxx
1850 2004-02-05 Benoit Regrain
1851 * ENH : add methods in gdcmObject to get the hash table or the list of
1853 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1854 * FIX : wrapping python for TagHeaderEntryHT
1856 2004-02-04 Benoit Regrain
1857 * FIX : even length for some strings when writting the dicom dir
1858 * FIX : sort the images in the dicom dir
1859 * FIX : Bug fix for python use of dicom dir
1860 * ADD : a python demo
1862 2004-02-04 Jean-Pierre Roux
1863 * FIX : Final solution (?) for icone embedded images
1864 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1865 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1866 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1867 gdcmData/gdcm-MR-SIEMENS-16.acr1
1868 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1869 to make full checking easier
1871 2004-02-04 Benoit Regrain
1872 * FIX : WriteEntries : coding style & logic in parameters
1873 * FIX : Set the elements to create the DicomDir in a dictionary file
1875 2004-02-03 Benoit Regrain
1876 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1877 * gdcmDicomDir : add the load of directory
1878 * Bug fix and print add-on
1880 2004-02-03 Jean-Pierre Roux
1881 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1882 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1883 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1884 * FIX gdcmParser.cxx : 'group length' elements are now considered
1885 as integers, even for shadow groups, when file is Implicit VR
1887 2004-02-02 Jean-Pierre Roux
1888 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1890 of the last synonym :-(
1891 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1893 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1894 * FIX taking into account the possible 7fe0,0010 multiplicity
1895 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1896 to allow removal of references to 7fe0,0010, to deal with
1897 ACR-NEMA images, when 0028,0200 is meaningfull
1899 2004-01-31 Jean-Pierre Roux
1900 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1901 no longer writes 'Un' on disk
1902 * FIX SQ elements with actual length are now dealt with corectly
1903 * FIX gdcmFile::WriteBase make the difference, for color images, between
1904 the length (for Palette expanded images)
1905 and Raw Length (non expanded image + Palette)
1906 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1907 (that broke Write). Replaced by UL.
1908 Aware user will reload the field if he
1909 thinks it's necesssary
1911 2004-01-30 Jean-Pierre Roux
1912 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1913 when 'dirty Acr' is found, to be compliant with the new
1914 IsReadable() methods.
1916 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1917 (no DOUBLE images in kosher DICOM,
1918 but so usefull for people that miss them ;-)
1920 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1921 DICOMDIR related utilities (not checked as Windoze compliant)
1923 2004-01-28 Jean-Pierre Roux
1924 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1926 2004-01-27 Jean-Pierre Roux
1927 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1928 to allow skipping the shadow elements, to save memory space.
1929 The TRUE value for this param has to be used
1930 with a FALSE value for the 'enable_sequence' param.
1931 ('public elements' may be embedded in 'shadow Sequences')
1932 * gdcmHeader methods now deal with 'embedded icones images' in the header
1933 (even when an 'icone image sequence' is announced by the
1934 element (0x0088,0x0200), but there is NO icone at all ...
1936 * gdcmHeader sometimes Image Location value doesn't follow
1937 the supposed processor endianity (see gdcmData/cr172241.dcm).
1940 * gdcmHeader add the method
1941 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1942 to get *all* the Header Entries with the same tag.
1943 GetHeaderEntrySameName is probabely *useless*
1944 (no meaning : Name is *not* an identifier within the Dictionary)
1946 2004-01-26 Benoit Regrain
1947 * Bug fix in the print of hexadecimal representations. Remove long fields
1948 in the print and add a third level of print to print them
1950 2004-01-23 Benoit Regrain
1951 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1952 * Bug fix on test suite after remove the strip made on not string fields
1953 * Split the IsReadable method between gdcmParser which test that the file
1954 is dicom and gdcmHeader which test that it's an image file
1956 2004-01-22 Benoit Regrain
1957 * DicomDir : clean code, add methods, set variables in protected or private
1958 * gdcmUtil : bug fix for the clean string method
1960 2004-01-19 Benoit Regrain
1961 * Add the use of shadow dictionaries
1962 * bug fix and coding style
1964 2004-01-19 Benoit Regrain
1965 * src/gdcmFile.cxx : bug fix concerning the close of file
1966 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1967 * Add the update of header entries using the shadow library
1969 2004-01-19 Benoit Regrain
1970 * removal of file gdcmHeader2.cxx
1971 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1972 inheriting from gdcmParser. This split is to prepare the integration
1973 of dicom dir parsing
1974 * bug fix under python
1976 2004-01-16 Jean-Pierre Roux
1977 * REM removal of class gdcmHeaderEntrySet
1978 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1979 * ADD add file gdcmHeader2.cxx
1980 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1982 2004-01-15 Benoit Regrain
1983 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1984 entries created while parsing the header. Thus, they will be destroyed
1985 when the gdcmDictSet will be destroyed
1986 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1989 2004-01-15 Benoit Regrain
1990 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1991 made a fatal error because of the memory release at the end of program.
1992 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1993 some memory and vtk seems to have some problems with that.
1994 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1996 2004-01-14 Benoit Regrain
1997 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1998 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1999 * src/*.[h|cxx] : make changes due to class name changes
2000 * gdcmPython/demo/*.py : bug fix due to method names
2002 2004-01-13 Benoit Regrain
2003 * src/*.[h|cxx] : coding style
2004 * vtk/*.[h|cxx] : coding style
2006 2004-01-13 Benoit Regrain
2007 * gdcmPython/testSuite.py : test the readable flag of file for tests
2008 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2009 It's lied to the stl compilation by MSVC (windows, always windows...)
2010 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2012 2004-01-12 Benoit Regrain
2013 * src/*.h : add comments
2014 * src/gdcmDictSet.h : set the method BuildDictPath in public
2015 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2016 directly setted in the source code
2017 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2020 2004-01-09 Benoit Regrain
2021 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2022 * setup.py : use a reference to gdcmVERSION
2024 2004-01-07 Benoit Regrain
2025 * Modification to compile with the distutils.
2028 2003-12-10 Benoit Regrain
2029 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2030 can use a gdcmHeaderHelper to load data
2031 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2032 made in the source code
2034 2003-12-10 Benoit Regrain
2035 * Update Windows projects and .cvsignore files
2037 2003-11-12 Jean-Pierre Roux
2038 * ENH gdcmHeader constructor has one more parameter (default value : false)
2039 that allows the user to 'go inside' the SeQuences only
2041 gdcmElValSet:Print takes it into account
2043 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2044 * ENH: Update gdcmPython/CMakeLists
2045 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2046 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2048 2003-11-10 Jean-Pierre Roux
2049 * FIX : gdcmHeader::LoadElements is now based
2050 on the ListTag listElem member,
2051 not longer on the TagElValueHT tagHt member
2052 * ENH : PrintPubElVal shows (temporarily) both results,
2053 with the tagHt member and the listElem member.
2054 (it's easier to 'see' the problems when using Printheader)
2056 * FIX : old private member LgrElem is now splitted into
2057 ReadLength : Length actually found on disk (updated only
2058 if bug fixing is necessary), for internal
2060 UsableLength : Updated by FixFoundLength, to fix a bug
2061 or to allow Parser going on.
2062 Will allow to re-write a kosher header when a SeQuence
2063 with a length (not 0000) is found
2064 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2065 because gdcmElValSet::Add does not update ListElem
2068 2003-11-07 Jean-Pierre Roux
2069 * FIX misstyping in Transfert Syntax name table
2070 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2071 when they have an actual length (not 0000 nor FFFFF)
2072 (Nobody should care of it, but DICOMDIR explorers)
2074 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2077 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2078 * ENH: vtkGdcmReader now supports LUT !
2079 (vtkgdcmViewer for now is not able to use them though)
2081 2003-11-05 Jean-Pierre Roux
2082 * in testSuite.py : new files names for checking the package
2083 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2084 that returns the pixel area size to the *aware* (vtk) user
2085 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2087 2003-11-05 Benoit Regrain
2088 * in testSuite.py : Modify the rules for checking the paths
2089 : Explicit error messages
2090 * in __init__.py : Related modif
2092 2003-11-03 Jean-Pierre Roux
2093 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2094 to be used by aware (vtk) users that want to manage
2095 LUT (and no to turn the PALETTE image into an RGB pixels one)
2096 * GetPixelType now returns 8U for 24 Bits images
2097 (vtkGdcmReader compliant)
2099 2003-10-31 Jean-Pierre Roux
2100 * Removal of *all* gdcmData images and add them again
2101 in order to loose the 'history' of un-anonymised images
2103 2003-10-31 Jean-Pierre Roux
2104 * RMV : removal of useless jBitsInJsample.h
2105 for both 8 and 12 Bits JPEG Lossy Libraries
2107 2003-10-31 Jean-Pierre Roux
2108 * ENH : Add the functions gdcmFile::GetImageDataRaw
2109 gdcmFile::GetImageDataIntoVectorRaw
2110 that act as GetImageData and GetImageDataIntoVector
2111 except the making of an RGB Plane from Gray Plane + LUT
2112 Intended to aware (vtk) users who know how to manage
2115 GetLUTRGBA return a R,G,B,A LUT if any
2116 lgrTotaleRaw gives the 'Raw' length
2117 GetImageDataRaw returns the gray Plane
2118 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2119 (They stay Grey, just like with other Dicom viewers :-(
2121 2003-10-30 Jean-Pierre Roux
2122 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2124 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2126 being coherents dicom files.
2128 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2129 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2131 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2132 * ENH: Two steps is necessary to please VC++ compiler...
2133 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2134 * ENH: Add include dir to medcon lib
2135 * FIX: only one function is being exported for now !
2136 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2138 2003-10-29 Jean-Pierre Roux
2139 * adding gdcmHeader::GetLUTRGBA
2140 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2141 --> Mathieu, the modif u're waiting for is not yet committed
2142 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2144 2003-10-27 Jean-Pierre Roux
2145 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2146 00191113.dcm DermaColorLossLess.dcm
2147 MxTwinLossLess.dcm RadBWLossLess.dcm
2148 * ENH: For version prior to vtkImageViewer2 -r 1.19
2149 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2151 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * Removal of ido stuff in CMakeLists.txt
2154 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2156 * FIX: remove a call to ->Modified ... see comments
2157 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2159 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * FIX: Problem with path for libvtkgdcmPython
2161 * ENH: Try adding a search script for python site-package
2162 * RMV: Remove some file from medcon lib that are not necessary
2163 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2164 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2165 * FIX: More pragma disable fro VC++,
2166 I don't think I break something as it is also disable in VTK/ITK.
2167 But it fasten debug compilation time.
2169 2003-10-23 Jean-Pierre Roux
2170 * gdcm now deals with 16 Bits Run Length Encoded images
2171 (they are compressed as 2 planes images,
2172 one for the high Bytes, the other for low Bytes)
2174 2003-10-22 Jean-Pierre Roux
2175 * Now CheckRead takes into account :
2176 - the bugged 'Leonardo' Siemens images
2177 - the XA images, sent thru the burning VPRO station
2178 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2181 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2182 * FIX: When copying a Makefile.am to CMakeLists.txt
2183 one should remove the '\'
2185 2003-10-22 Jean-Pierre Roux
2186 * in gdcmData adding a bugged 'Leonardo' Siemens image
2187 (wrong lengths in header)
2188 OK with gdcm, KO with the other viewers :-)
2189 * add a GE dlx XA image, thru the VEPRO burning station
2192 2003-10-21 Jean-Pierre Roux
2193 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2194 for a brutal checking of vtkgdcmViewer compliance
2196 2003-10-21 Jean-Pierre Roux
2197 * add the files for 'xmedcon' Jpeg Lossless library
2198 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2200 2003-10-21 Jean-Pierre Roux
2201 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2203 2003-10-21 Jean-Pierre Roux
2204 * garbage Siemens 'Leonardo' images dealt with
2205 (the patch is easy to remove)
2206 * cosmetic changes to avoid warnings
2208 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2209 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2210 no need to press 'r' now.
2212 2003-10-20 Jean-Pierre Roux
2213 * upgrade of checkRead.sh checkWrite.sh according
2214 to new Jpeg Lossless decompressor
2215 * add US.3405.1.dcm, a genuine RGB medical file ...
2216 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2217 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2219 2003-10-15 Jean-Pierre Roux
2220 * general anonymisation in gdcmData
2221 * adding the 'color files' from
2222 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2223 * adding some well knowed bugged-header images
2224 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2225 waiting for their inclusion in Python testsuite
2227 2003-10-15 Jean-Pierre Roux
2228 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2229 no longer seg faults when file is not found
2231 2003-10-14 Jean-Pierre Roux
2232 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2235 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * TODO: *.in file to genereate a UseGDCM later
2238 2003-10-14 Jean-Pierre Roux
2239 * Some supposed-to-be Dicom Images have no preamble.
2240 OpenFile takes it into account
2241 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2242 * Missing elements added in dicomV3.dic
2243 (just to be affraid : have a look at
2244 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2245 and do it again next year ;->
2247 2003-10-13 Jean-Pierre Roux
2248 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2249 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2250 But there are NOT. It's fixed !
2252 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * FIX: "jpeglib.h" was not found on VC++
2254 * FIX: vtkgdcm was not being installed
2256 2003-10-10 Jean-Pierre Roux
2257 * ENH : OpenFile closes the file if it *really* doesn't look like
2258 an ACR-NEMA / DICOM one.
2259 * FIX : testWrite no longer writes an empty file if the source file
2260 is not gdcm Readable
2261 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2264 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * FIX: CMake generate now documentation
2266 * ENH: out of source doc build !
2267 * ENH: Generate both user and dev documentation
2268 * ENH: Should work on windows too
2269 * ENH: Only one doxygen config.in file is needed
2270 * FIX: make install should be ok now on ùnix plateform
2271 * FIX: PATH to dictionary was wrong (missing /)
2272 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2274 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * vtkGdcmReader is now able to read rgb dicom file.
2276 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2277 * added a gdcmViewer to vtk test, use mouse to control
2278 window level & window width
2280 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * CMake-ification of gdcm, we have now two build system
2282 * FIX: on cygwin Wsock32 doesn't exist
2283 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2285 2003-10-06 Emanuel Ollart
2286 * FIX : compilation process wad broken.
2287 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2289 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * change gdcmViewer -> vtkgdcmViewer
2291 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2293 2003-10-06 Jean-Pierre Roux
2294 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2295 ( e.g : well known GE images with a wrong elem length,
2296 : Philips MRI Images with a wrong Huffman table)
2297 * still to be done : allow the reading of bugged LEONARDO Siemens images
2299 2003-10-03 Jean-Pierre Roux
2300 * Odd length strings are padded with '\0' (not with spaces,
2301 to remain compliant with already defined strings,
2302 like Transfert Syntax UID and others)
2304 2003-10-03 Jean-Pierre Roux
2305 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2306 to allow displaying RGB images (not only by affim ;-)
2308 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2309 * vtkGdcmReader is now able to read rgb dicom file.
2310 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2312 2003-10-03 Jean-Pierre Roux
2313 * A few nasty patches to allow the reading of a lot of nasty images
2314 ( e.g : well known GE images with a wrong elem length,
2315 : Philips MRI Images with a wrong Huffman table)
2316 * still to be done : allow the reading of bugged LEONARDO Siemens images
2318 2003-10-03 Jean-Pierre Roux
2319 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2321 2003-10-03 Jean-Pierre Roux
2322 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2323 to allow displaying RGB images (not only by affim ;-)
2325 2003-10-03 Jean-Pierre Roux
2326 * gdcmFile::GetImageDataIntoVector now
2327 - deals with MultiFrames MultiFragments Run Length Encoded files
2328 - deals with YcBcR (YBR_FULL) files
2329 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2330 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2332 (no sample found :-(
2334 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2335 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2336 Two reasons: - clear things
2337 - third parties acces gdcm through header files, so won't
2338 suffer anymore VC++ complains
2340 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2341 * add argv[1] in testvtkGdcmReader.cxx
2344 2003-09-24 Jean-Pierre Roux
2345 * The lines are now eigthy characters long.for
2346 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2348 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2349 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2350 char* to std::string. Thus, the use of strdup becomes useless. (see
2351 previous commis of Malaterre)
2352 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2353 before the last Malaterre's commit.
2355 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2356 * This commit should fix the Debug building under VC++, the problem
2357 was mainly a mixture of debug and release lib being loaded at startup.
2358 * I also remove a depency to a specific C function: strdup. Because I had
2359 to force the link to msvcrtd (whereas strdup is in libc).
2361 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2362 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2363 located in the gdcmCommon.h file. All use of reference of tha has been
2364 changed to now use the variable GDCM_UNFOUND.
2366 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2368 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2369 Dicom dictionary. The test suite can now be run again. Note:
2370 I'm note very happy with the " (RET)" changes. I believe this
2371 RETAINED comment should be dropped when parsing the dictionary.
2372 - PACKAGER corrected
2374 - AUTHORS updated and now in alphabetical order
2375 * Makefile.am now exports gdcm.dsw for Windoze users.
2377 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * cygwin complains about missing std:: in subdir Test/
2380 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2381 * remove some methods that are now in gdcmHeaderHelper
2383 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * vtkGdcmReader set spacing and origin correctly
2386 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2387 * Fix a few delete/delete[] mismatch
2389 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2390 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2391 interpretation to data given by gdcmHeader. For instance there are
2392 heuristics to get informations (look at different places).
2393 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2394 sorting DICOM images based on different strategies.
2395 * modified Makefiles accordingly.
2397 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2399 when building in debug mode
2400 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2401 src/win32/gdcmdll.dsp
2402 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2404 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2408 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * src/win32/libgdcmjpeg12.dsp was not dos format
2410 * src/win32/libgdcmjpeg12.dsp :
2411 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2412 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2414 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2415 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2417 * src/gdcmFile.cxx : bug fix in affectation type
2418 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2419 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2420 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2421 symbols... future problem ?
2423 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * src/win32/libgdcmijpeg12.dsp was missing
2425 * modified gdcm.dsw accordingly
2427 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2430 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2431 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2432 commit of JPR (before his hollidays to facilitate our work).
2433 * setup.py : bug fix in code. Modifications made while the last commit
2434 of JPR. The code hasn't been tested before the commit... it's so
2435 useless to make that (for best programmer that is JPR) !!!
2437 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * tagged the current version as Version0_3 (i.e. version 0.3)
2440 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2442 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2443 * *.dsp : modifications to use new libgdcmijpeg8 library
2444 * setup.py : bug fix on VTKPATH variable
2445 * PACKAGER : adding all concerning windows
2447 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2450 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2451 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2452 test suite reported error.
2453 * PACKAGER file added (describes what a packager must do when
2454 packaging a new release).
2455 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2456 * configure.in: upgraded version number to 0.3.0
2457 * fixing build of rpm (through rpm -ta):
2458 - Doc/Makefile.am exports proper doxygen files
2459 - src/jpeg/libijg8/Makefile.am exports the include files.
2461 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2462 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2463 * src/gdcmHeader.h : formatting code
2465 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2466 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2467 We were obtaining error message from vtk. Now, creation of file list
2468 is made in an internal list to prevent this problem.
2469 Bug fix when output is empty.
2470 Bug fix in update of progress value. Previous commit for this was a bad
2472 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2474 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2475 * src/gdcmHeader.h : added method to get the file name
2476 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2477 files. Added method to remove all files on the input
2478 Added FIXME comment concerning the bad parsing of header made by
2479 ExecuteInformation method (in ExecuteData method)
2481 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2483 when using make instal.
2484 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2485 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2487 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2488 * setup.py : adding include dir of jpeg lib to compile all sources
2489 * */Win32/*.dsp : JPR fix for windows compilation
2491 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2492 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2494 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2495 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2497 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * setup.py is again effective on un*x (takes into account the
2499 addon of the jpeg library)
2500 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2501 * Doc/Doxy* updated (includes above enhancements)
2502 * INSTALL now points to web documentation
2504 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcmHeader.h doesn't make unnecessary reference to
2507 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2509 * src/gdcm*.[cxx|h] :
2510 - to allow compilation with gcc 3.x
2511 -- clean up of STL usage (added explicit usage of std::)
2512 -- small fixes on exceptions.
2513 Note: linking not tested !
2514 - clean of doxygen comments to avoid warnings at documentation
2516 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2517 dependent convertion).
2519 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * Clean up of previous JPR garbage commit (not even commented in the
2522 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2523 - moved all jpeg related files from src to src/jpeg/libijg8, with
2524 addition/modification of Makefile.am and configure.in.
2525 - the testSuite is still brain damage (not guilty).
2527 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2528 * WrapVTK.py : modifications to get correctly vtk source files to
2530 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2531 (FileName -> Filename)
2533 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * vtk/vtkGdcmReader.[cxx/h]:
2535 - UpdateProgress method should now be effective
2536 - removed the limitation on having only images loaded (as opposed
2538 - when building a stack of images/volume, a lesser number of
2539 gdcmHeader and gdcmFile instances should be used (hopefully
2540 accelerating things).
2541 - when building a stack of images/volumes, files which are not
2542 loadable (wrong path-filename, wrong permissions on existing file,
2543 or file not parsable by gdcm) are replaced with a black image
2544 in the stack (for the caller to notice the problem).
2546 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2549 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2550 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2551 between standard library (std) and vtk library (problems are found
2552 under Windows... thanks Windows !)
2554 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2555 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2557 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2559 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2562 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * When compiling with distutils (see setup.py) the C++ compiler is
2564 called with different flags than the default ones (with automake).
2565 In order to fix all those warning, I compiled gdcm with the command
2566 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2567 and went for warning fixes:
2568 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2569 up from unused variables.
2570 - vtk/vtkGdcmReader.cxx: potential bug fix.
2571 * src/gdcmHeader.h: Doxygen warning cleanup
2573 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * gdcmPython/gdcm.i:
2575 - typemaps correction to take into account the systematic replacement
2576 of "using namespace std" with std:: prefix e.g. std::list,
2577 std::string... (cf changes of 2003-05-21).
2578 - gdcmGlob global variable of type gdcmGlobal (defined in
2579 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2580 exported to Python a as cvar.
2581 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2582 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2583 gdcmDictSet.GetPubDictTagNames() and
2584 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2585 C++ static methods).
2586 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2587 with the above changes.
2589 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2590 * setup.py, manifest.in : bug fix under linux
2592 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2593 * Modification of setup.py to compile vtk part too. Then, we have 2
2594 wrappers which must work with same distutils. For that, we have a
2595 generic distutils in distusiltsWrapping.py ; with :
2596 - build_extWrap class to wrap generically all extensions,
2597 - ExtensionWrap base class for all wrapping extension that contains
2599 - Wrapper interface which wrap sources
2600 + In WrapSwig.py we have extension and wrapper for Swig
2601 + In WrapVTK.py we have extension and wrapper for VTK
2602 * MANIFEST.in : modifications to consider vtk directory and new python
2603 files for compilation
2605 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2606 * Added python wrappers of vtkGdcmReader vtk class (see the
2607 source in vtk/vtkGdcmReader.cxx) :
2608 - vtk/Makefile.am now builds a library
2609 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2610 python library (as opposed to _gdcm.so wich are the python
2611 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2612 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2614 - configure.in has an additional flag --enable-vtk that needs
2615 to be set to enable compilation of vtk related code, that is:
2616 + vtk/vtkGdcmReader.so and
2617 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2618 + gdcmPython/vtkgdcmPython.so (see above)
2619 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2620 be read when compressed or when HighBit + 1 != BitsStored),
2621 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2622 the usage of the python wrapper of vtkGdcmReader vtk class.
2623 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2624 * src/*.[h] all occurences of stl classes are now prefixed with
2625 std::, and all occurences of "using namespace std;" where removed.
2626 This is to avoid pollution of global namespace in included files.
2627 Apparently vtk does not avoid this pitfall: when using both
2628 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2629 collision of various stl members (principally cout...).
2630 * gdcmPython/testSuite.py now cleanly removes temprory generated
2632 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2633 comply with above changes)
2635 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2636 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2637 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2638 vtk data structure (an image Flip was required).
2639 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2640 * cosmetic changes in documentation.
2642 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2643 * src/gdcmHeader.cxx: the constructor no longer exits when an
2644 unexisting file is given as argument.
2645 * The subdirectory Data (containing all the images used for the
2646 test suite) is not part of this repository anymore. A new module
2647 containing those images is now available at
2648 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2649 with the name gdcmData.
2650 All the python scripts (including the package initialisation file
2651 gdcmPython/__init__.py) were adapated to take this change into
2652 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2654 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2655 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2656 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2657 demo of the usage of this class.
2658 Compilation of this vtk part is only done when using the --enable-vtk
2659 at configure (or autogen.sh) stage.
2661 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2662 * More memory link related corrections and documentation fixes.
2664 - maximum info is obtained with a command of the form:
2665 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2666 --show-reachable=yes PrintHeader
2667 - the remaining reachable blocks seem to come from the STL
2668 allocation scheme through the usage of map and list. It looks
2669 like this memory cannot be freed but it is not a memory leak
2670 (in fact further invocation to the STL would recollect the
2671 unused memory allthough it cannot explicitely be freed).
2672 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2673 of displaying an image parsed with gdcm and displayed with VTK.
2674 Note: some images don't seem to work e.g.
2675 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2676 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2677 Allthough this weakens the semantics, it is a ditch attempt to
2678 make gdcm more thread friendly.
2680 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2681 * Memory link hunt (by using valgrind through the command
2682 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2683 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2684 gdcmHeader::_dicom_vr.
2685 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2686 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2688 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2690 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2691 * src/Makefile.am now exports all the necessary include files at
2695 * UpdateGroupLength replaced by new one
2698 * UpdateGroupLength re-written using H-Table
2699 (named UpdateGroupLengthNew untill checks are over)
2701 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2702 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2703 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2705 - gdcmHeader::GetPubElValSet removed.
2706 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2707 UpdateGroupLength, WriteElements, Write.
2708 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2709 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2710 carried the same semantics.
2711 - src/gdcmHeaderIdo.cxx changed accordingly.
2712 - gdcmFile::WriteBase now regroups all the codes from previous
2713 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2714 - enum FileType moved to gdcmCommon.h
2715 * src/gdcmHeader.cxx AddDefault trashed
2716 * gdcmGetXSize added
2717 * getimageDataSize now calls gdcmGetXSize
2718 * Test/*.cxx changed to agree with above changes
2720 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2722 (to avoid double call by end user).
2723 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2724 by end user, since gdcmHeader::gdcmHeader now handles it.
2726 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * gdcm/Doc many doxygen changes:
2728 - Doxyfile now has two different versions, DoxyfileUsers that generates
2729 the html.users end users oriented documentation and
2730 DoxyfileDeveloppers that generates the html.developper developper
2731 oriented documentation.
2732 - README changed accordingly
2733 - requirement.txt removed (old design info moved to TODO).
2734 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2735 DoxyMainPage.txt, DoxyPython.txt provide more information.
2736 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2737 be updated by simply regenerating the docs with doxygen and copying
2738 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2739 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2740 all the tests in the form "if (<map>.count() >1)" were removed.
2741 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2742 ill-formed documentation sections.
2743 * src/gdcmHeader.cxx: ditto
2745 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * setup.py fixed for un*x (needed macro for stdint.h)
2747 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2748 un*ces with sh-utils test utility.
2749 * gdcmPython/demo/test.py renamed to PrintHeader.py
2750 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2751 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2752 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2753 * src/gdcm*.cxx JPR's bad inclusion fixed.
2755 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2757 * gdcmPython/demo/test.py changed accordingly.
2759 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * gdcmPython/Makefile.am fixed linking against libstdc++
2761 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2762 * Swig subdir (historical tests of swig version 1.3.17++) removed
2763 * Test/testChangeEntete.cxx some lines commented out in order to make
2765 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2766 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2768 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2770 hence the user doesn't need this explicit call.
2771 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2772 i.e. LoadElements() call removed.
2773 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2774 - src/Makefile.am declares the proper flag for g++.
2775 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2776 for adding user defined new tags.
2777 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2778 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2779 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2781 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2782 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2783 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2784 src/Makefile.am : the project should properly compile and install
2785 with the autotools, included the python wrappers part.
2786 * gdcm.spec.in : added a spec file for RPM packaging.
2788 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2789 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2791 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2792 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2793 to exported to the environement (see gdcmPython/testSuite.py
2795 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2796 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2797 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2798 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2799 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2801 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * gdcmPython/__init__.py doesn't crash anymore when running in
2803 in InstallMode or PreInstallMode but with an environment given
2804 value of GDCM_DICT_PATH.
2805 * src/gdcmDictSet.[cxx/h] coding style.
2807 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2808 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2809 * src/gdcm.h general comments moved to TODO, and README
2810 * src/gdcm.h should now be seen as a user commodity (including it
2811 should suffice to fully use gdcm). It is nowhere including within
2812 any of the kernel files src/*.cxx and src/*.h.
2814 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2816 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2818 * src/gdcm*.cxx only include their corresponding include file
2819 (as opposed to gdcm.h)
2820 * gdcmPython/gdcm.i changed accordingly
2821 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2822 the autogen.sh generated "make snapshot" command to work.
2823 * autogen.sh removed history related references to crea package.
2825 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * distutilsSwigCPlusPlus.py work around some swig portability
2829 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2831 was done in a last ditch attempt to get setup.py _really_
2832 operationnal. The python/gdcmPython layaout add the advantage
2833 of hidding away the python related distutils specific files
2834 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2835 Alas, the src directory was out of scope (i.e. it's relative
2836 position to setup.py was ../src) which made things impossible to
2837 handle (see previous version of python/setup.py). Crossing fingers...
2839 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * python/setup.py now works on Un*x. (harder than I thougth)
2841 * python/distutilsSwigCPlusPlus.py can now have include files
2842 among the list of sources.
2844 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2845 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2846 * modifications in MSVC projects
2848 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * As stated by the first lines of Test/ExceptionAndPython/README, it
2850 looks like we can move back to original usage of exception within
2851 src/gdcm* and hence remove the errno stuff that was introduced
2852 as a quick and dirty fixture of this problem (added to the TODO).
2853 * Doc/Doxyfile configuration file for Doxygen and corresponding
2854 README file for usage added.
2855 * Test/testWrite.cxx added. This new test comes from a split of
2856 test.cxx that is now reverted to its original purpous i.e.
2857 testing the proper parsing of a Dicom related file.
2858 testWrite.cxx concentrates on testing the IO part of gdcm.
2859 * Test/bug1.cxx (containing a bug on WIn32) added.
2860 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2861 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2862 whose purpose is to publish the content of the TagNames of the
2863 Dicom public dictionary were not accessible without an
2864 instance of class gdcmHeader.
2865 - those methods are now static methods of gdcmDictSet and hence
2866 require no instances at all to be invocated.
2867 - within gdcmDictSet this change required to change some method
2868 to class methods (i.e. are now static) among which SetDictPath
2869 (renamed to BuildDictPath) and LoadDefaultPubDict.
2870 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2871 the above changes by calling the new method classes of gdcmDictSet.
2872 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2873 the above to be effective.
2874 * python/gdcmPython: in order to wrap properly the above changes
2875 for Python, swig version now needs to be > 1.3.17.
2876 * python/gdcmPython/Makefile fixed to adapt itself to new
2877 configure/make shema introduced by Johan Montagnat (thanks for the
2878 contribution). Alas this Makefile cannot be turned into a proper
2879 Makefile.am without some heavy changes in the configure.in
2880 (for python dectection).
2881 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2882 now avoids publishing the empty entries.
2884 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2885 * python/setup.py : bug fix concerning install under windows
2886 ExtraPath reused :-P
2887 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2889 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2890 * Dicts/dicomV3.dic : remove double spaces !!!
2891 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2892 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2895 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2897 method. Doxygenation.
2898 * src/gdcm.h clean up of JPR spurious comments.
2900 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2901 * python/distutilsSwigCPlusPlus.py now properly collects the
2902 shadow classes generated by "swig -c++" (gdcm.py in our case)
2903 when using "python setup.py install".
2904 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2905 reexports the working classes.
2906 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2907 by the classical C errno scheme. This is to prevent an obscure
2908 behavior of the python wrappers when importing wxPython.wx prior
2909 to gdcmPython (which ended up in an abort call). An illustration
2910 of this oddity can be found in the Test/ExceptionAndPython
2911 subdir (see the README file). This problem probably due to
2912 an combination of g++ and dynamic loading.
2913 * added Test/ExceptionAndPython (see above)
2915 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * Changed the layout of the python part to avoid bloating main
2917 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2918 i.e. the distutils arsenal. All the python related stuff is
2919 again in a python subdir, but the package itself is now in
2921 * setup.py was cleaned up:
2922 - pythonIncludePath removed
2923 - python setup.py bdist target is now functional.
2924 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2925 collision with other packages). gdcmPython/demo/*.py changed
2928 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * python subdir moved to gdcmPython (preparation of distutils packaging).
2930 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2931 distutils installer is operational.
2932 * - gdcmPython/__init__.py now properly loads the swig generated
2933 shadow classes (from gdcm.py).
2934 - gdcmPython/demo/*.py changed to import the package gdcmPython
2935 instead of gdcmPython/demo/load.py.
2936 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2938 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2940 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2941 entries within the associated public Dicom dictionary resp. the same
2942 information but sorted by the fourth field (PAT, IMG, DIR) of the
2944 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2945 are now in the "???" group.
2946 - python/gdcm.i changed accordingly,
2947 - python/demo/printGroupedPublicDict.py added, that gives an example
2948 of the above new functionalities in Python.
2950 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * src/gdcm.h, gdcmHeader.cxx:
2952 - historic references to glib's g_malloc and g_free (#defined)
2953 were definitively removed.
2954 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2955 * src/gdcmElValSet.cxx:
2956 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2957 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2958 - GetElValue(string) renamed to GetElValueByName.
2959 - Added GetElementByName(string).
2960 * src/gdcmHeader.cxx: added
2961 - GetPubElValRepByNumber(guint16, guint16)
2962 - GetPubElValRepByName(string)
2963 - GetShaElValRepByNumber(guint16, guint16)
2964 - GetShaElValRepByName(string)
2965 - GetShaElValByNumber(guint16, guint16)
2966 - GetShaElValRepByName(string)
2967 - GetElValRepByNumber(guint16, guint16)
2968 - GetElValRepByName(string)
2969 - GetElValByNumber(guint16, guint16)
2970 - GetElValRepByName(string)
2971 * Doc/requirements.txt added.
2973 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * Test/Makefile building now depends on the one of libgdcm.so
2975 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2976 pixel data) aware which enables finding the address (offset) of
2977 the pixel data of JPEG encoded DICOM files. This leaves only a single
2978 file in the testSuite whose pixel data address (offset) is unknown.
2979 * python/testSuite.py changed accordingly.
2981 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2982 * VC++ has some strong limitations when working with the STL, as stated
2983 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2984 "Also note that some STL containers (map, set, queue, list, deque)
2985 cannot be exported. [...]
2986 Some STL classes contain nested classes. These classes can not
2988 This is caused by a designed limitation that once a template
2989 class is instantiated, it can not be re-instantiated and
2991 Since our usage of map<> is ubiquitous in gdcm, this "designed
2992 limitation" of VC++ is a pitfall.
2993 Hence the Python wrappers of gdcm cannot be incrementally linked
2994 against the c++ dynamic library. The dirty but only workaround is
2995 to forget about incremental link of dynamic libraries and to generate
2996 the Python wrappers library with the inclusions of the underlying C++
2998 The following modifications concern this matter on Win32/VC++:
2999 - wrapping python correct with standalone wrapped dll (don't use separate
3000 dll under windows !!!!)
3001 - python21_d debug mode enabled (ask Frog how to use it :-)
3002 - NO problem with having an STL member of class for example string in C++
3003 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3004 - Python test of dcmlib in Python is ok under windows on a large set
3006 * removed glib references
3007 * typedef's inserted in gdcm.i for correct swig type management
3009 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3010 * python/demo/*.py load.py extracted from test.py. Added explore.py
3011 that only displays required tags and testAll.py that parses all
3012 the files of the testsuite without using unittest.
3013 * python/testSuite.py other additional test on new files added.
3014 * Data/* new test files added accordingly to the testSuite.
3015 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3016 the vr in the file differs from the one of the dictionary.
3018 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3020 values, but limits itself to values which are below a user specified
3021 size (by default 1024 bytes).
3022 * python/gdcm.i : elements not loaded (because their size is above the
3023 user specified treshold) are exported with their TagKey as key of the
3024 python dictionary. This enables the testsuite to make some checks
3025 on the unloaded elements (since we have their offset and size).
3026 * python/testSuite.py
3027 - now tests for the existence and proper value of the pixel data
3028 - two new examples added.
3029 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3031 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3033 aware. See the strategy comments in gdcmHeader::FindeLength().
3034 * Test/test.cxx now accepts a filename as first argument.
3035 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3036 * python/testSuite.py changed to integrate test on above files.
3038 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3040 the vr was also RET.
3041 * python/testSuite.py more tests added.
3043 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * python/testSuite.py unittest test suite added (uses Data)
3045 * Data/* dcm and acr files for the test suite.
3046 * glib dependance removed from un*x version. We now use ISO C99
3047 7.18 Integer types (see stdint.h)
3048 - python/Makefile, src/Makefile src/gdcm.h
3049 * src/ when an explicit vr (like dicom files) suddenly poped an
3050 implicit element we use to mark the underlying DictEntry of the
3051 concerned ElValue with "Implicit". This strategy was damageable
3052 too the public or provite dictionaries, since some of their vr
3053 would be changed. Since Header::FindLength heavily relies on the
3054 detection by Header::FindVR of falsely explicit elements, I
3055 added an extra ImplicitVr member to ElValue (boolean).
3056 The rest of the changes we the necessary adaptations.
3058 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3061 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3063 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * Adaptation for porting to VC++:
3066 o forced to use std namespace (for string to be known)
3067 o all class use __declspec export style on WIN32
3068 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3069 (in stdlib.h on Win32 but in std:: for gcc)
3070 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3071 variable GDCM_DICT_PATH.
3072 * src/gdcmHeader.cxx verbose comments made discrete.
3074 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * python/gdcm.i: added a typemap that converts a C++ hashing table
3076 to native Python dictionary.
3077 * python/demo/test.py:
3078 - now uses the native dictionary for exploration of gdcmHeader.
3079 - takes an optional filename argument (the file to parse).
3080 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3081 PubElVals hashing table.
3082 * Dicts/dicomV3.dic removed error prone trailing spaces.
3084 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3085 * Python wrapping process moved away from src/Makefile to
3086 newly created python/Makefile (as well as gdcm.i)
3087 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3088 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3089 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3090 from the environement variable GDCM_DICT_PATH (when existing).
3091 * src/gdcmDict::GetTag bug fix.
3093 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * Straightforward temporary fixes for swig to build the python wrappers.
3095 src/Makefile now has a python working entry [by working we mean
3096 that we can import de shadow classes without errors].
3098 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * hashtest.cxx removed (since already in Test)
3100 * src/gdcmlib.h renamed to src/gdcm.h
3101 * src/dcm.i renamed to src/gdcm.i
3102 * src/Makefile prepared for python wrapping
3104 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3105 * src/gdcmHeader.cxx :
3106 - Parsing of header is now separated from loading of element values
3107 (see gdcmHeader::LoadElements).
3108 - general clean up of hopefully all file access (creation of
3109 ReadInt16 and ReadInt32)
3111 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3112 * src/gdcmHeader.cxx :
3113 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3115 - SetLgrElem renamed to SetLength
3116 - GetLgrElem renamed to GetLength
3117 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3118 * src/gdcmElValSet.cxx fixed both GetElValue methods
3119 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3120 due to IdoDude was cleaned out.
3122 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3124 concentrates on finding the value representation (when it exists).
3125 RecupLgr now only finds the element value length, and it avoids
3126 returning the unecessary skL (skipped length).
3127 Also, offsetCourant was simply removed (with taille_fich) since
3128 it was redundant with the File position internals (by using
3129 ftell and fseek). This also made skL (see above in RecupLgr) usage
3131 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3132 on the libido specificities which are handled through class
3134 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3137 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * Truckload of changes. Parsing of header is barely functional
3139 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3141 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcmHeader.cxx many addons of low level methods
3144 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3146 and _IdDcmSWAP_LONG.
3148 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3149 * This corresponds to all the changes decided at the meeting of
3150 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob