1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Remove friend classes between DocEntry and File
4 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
6 0002|0000. The value was incorrect.
8 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
11 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmUtil.cxx : compilation fix on Win32
13 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
14 variable, to be easy found. Add methods to change the default UID.
15 Amelioration of the CreateUniqueUID to use the correct default UID.
16 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
19 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Test/TestVR.cxx : fix memory leaks
22 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Rewrite the base 256 to base 10 conversion, using string operation only.
24 This allos us to get rid of the problematic 64bits integer type (does not
25 alwyas exist on target platform).
27 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
28 * Add construct and destructor to class gdcm::Debug to close the debug file
30 * Don't let uset to open twice the same file
31 * gdcm has now an official UID prefix,
32 supplied by http://www.medicalconnections.co.uk
33 1.2.826.0.1.3680043.2.1143
34 (Thx to Mathieu for providing URL)
35 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
36 to be able to perform some more tests
37 * gdcm::ContentEntry : Contructors and Destructor are now protected,
38 in order to be sure no user will try to use them.
39 (at user level, only the children classes are meaningfull)
41 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * move RLEInfo & JPEGInfo from Document to File
44 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * FIX : remove so many friend between classes
47 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
49 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
51 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
52 In order to avoid missbehaviour :
53 . gdcm::DocEntry is now specialized in
54 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
55 - gdcm::ContentEntry (Dicom entry with a 'content')
56 . gdcm::ContentEntry is specialized in
57 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
58 characters value, or integers)
59 - gdcm::BinEntry (Dicom entry with a non strig representable value
60 (user hasn't any longer to thing about the precedence of his dynamic_casts)
62 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * Test/VTKTest*.cxx : bug fix under linux
65 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
67 use with python. Some methods are moved from Document to ElementSet or
68 DocEntrySet. The equivalent methods to ElementSet have been added to
69 SQItem and are virtual in DocEntrySet. Methods that may have the same code
70 in SQItem and ElementSet is directly placed in DocEntrySet
72 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Test/VTKTest*.cxx : remove the show variable in each test method because
74 it's useless (the viewer variable replace this variable)
76 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmDocument.cxx : bug fix on potential memory leak
78 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
79 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
80 Add ClearXxx methods to remove all the content of the list or map
81 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
83 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
84 * methods ReplaceOrCreate renamed as Insert
85 (nobody will be any longer confused by 'CreateOrReplace')
87 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * Grealty simplify the JPEg decompression, no need to differenciate based on
89 the JPEG possible type (with/without fragment, with/without multiple frame).
90 Everything is done throught the JPEG IO Suspension mechanism in IJG
92 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
93 * Stage 3 of normalization :
94 in order to avoid any missunderstanding while reading method names :
95 - All the methods xxxEntry now deal with dicom Entries
96 - Methods GetEntry splitted into
99 - Method SetEntry renamed as SetEntryValue
100 - Method SetEntryBinArea let as it was
102 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
103 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
104 - Position correctly the entry points for JPEG2000 and JPEG-LS
105 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
107 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
109 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
110 with other method names
111 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
112 * Test/TestDicomDirElement.cxx : add new test
114 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
115 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
116 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
117 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
118 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
119 So can't you use __int64 in ostream at all.
121 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * bug fix for compilation on MSVC6
123 * gdcmPython/gdcm.i : rename of classes missed
125 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
126 * Stage 2 of names normalization :
127 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
128 (easy to understand ...)
129 - gdcm::FileHelper replaces old class gdcm::File
131 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
133 type and not a string. So, there remove problems on the format of the
136 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 * Add Example/TestPapyrus.cxx
138 - reads a Papyrus file (gdcm::Header compliant),
139 - gets the pixels of all the images, using low level iterators
140 - writes an multiframes Dicom image.
141 (Just to show it's *possible* to do that)
142 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
145 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
147 Thus, DicomDirXXX are created with a flad that indicates if the created
148 object is empty or not (when not empty, the DicomDirElement is used to
151 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
153 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
155 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
158 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
160 Remove all access to the hash-tables or lists in the objects.
162 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
164 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
165 be complient with all the gdcm source code
167 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
171 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
175 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Test/ : rename VTK tests to have a best name for the tests
177 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
178 GetFirstEntry/GetNextEntry use
180 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 * In SerieHeader::ImagePositionPatientOrdering()
182 // a Dicom 'Serie' may contain scout views
183 // and images may have differents directions.
184 // -> More than one may have the same 'pos'
185 // Sorting has then NO meaning !
186 Thx to Eduardo Davila for reporting bug.
188 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
190 test. Now it's on image content and not on the resulting visualisation...
191 might solve the problem on linux when using the OpenGL drivers
193 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
194 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
195 DicomDirSerie, DicomDirImage
196 Dict, DictSet classes :
197 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
198 -remove InitTraversal method.
199 * UPD Test programs + Example programs
201 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
202 * remove useless and never updated keyword \ingroup
203 * Solve pb when structure (list, map, ...) is empty.
204 Thx to Benoit for reporting bug
206 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
207 * Taking into account of 'Transfer Syntax' value
208 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
211 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
213 is no memory access violation
214 * gdcmPython/demo : add python demos using VTK
216 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
217 * FIX 'Dictionnary' is now spelt 'Dictionary'
218 'wether' is now spelt 'whether'
219 'archieve' is now spelt 'archive' ;-)
221 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
222 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
223 related methods, in order not to expose internal mechanisms
226 * REM methods that exposed internal mechanisms :
227 DicomDir::GetDicomDirPatients()
228 DicomDirPatient::GetDicomDirStudies()
229 DicomDirStudy::GetDicomDirSeries()
230 DicomDirSerie::GetDicomDirImages()
231 * UPD Test programs :
235 * UPD Example program
237 * ADD DictSet methods
241 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
242 * Removed the Print/indent/default parameter mess. There is absolutely no
243 reason to have to methods, moreover with the second taking the ostream as
244 *SECOND* parameter. This was clearly a bad hack to get things compile.
246 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * Complete rewrite of the GetMacAddress code. Now the code is *much*
248 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
249 Unfortunately the main code does not work on SunOS, thus provide a specific
250 code for this platform only (and Win32 of course). Since this seems to be
251 working, change CreateUniqueUID to use GetMACAddress instead of the
252 problematic GctestetIPAddress
254 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 * Unfortunately to be able to test gdcmDirList I had to break the API
256 a little. Now the class is not a std::list anymore but has a member
257 std::vector (more ITK compatible). Allow unit testing on Win32 and
260 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * Update SerieHeader to take into account a Serie Instance UID to properly
264 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
265 * ENH - Comment out Mathieu's (dangerous) Super Hack
266 for dealing with BIGENDIAN processors
267 - Move equivalent stuff to BinEntry::WriteContent
268 When necessary, 16 Bits Pixels are swapped in a small buffer
269 and then written. This avoid allocating a huge buffer, in
270 PixelWriteConvertor, and avoid modifying the Pixel Area.
272 Probabely, the same operation will have to be done when we want
273 to write image with Big Endian Transfert Syntax,
274 and we are working on Little Endian Processor
276 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
279 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
280 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
281 all the dict content.
282 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
284 * Test/TestDict.cxx : add a new test for the dict classes
286 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
288 file. Debug is yanked if compiled with NDEBUG
290 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmDictSet.h : set the default output to the os variable
292 * src/gdcmDictEntry.[h|cxx] : add the Print method
293 * gdcmPython/demo/ : add a new test
295 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
296 * merging of Test/PrintDicomDir and Test/TestDicomDir
297 * removal of now redundant Test/PrintDicomDir
298 * enhancement of Example/PrintDicomDir
300 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * Now, python test might work on systems
302 * Add the PrintDicomDir test
304 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
305 * FIX : First entry following group 0002 was lost for
306 Explicit Big Endian Transfer Syntax files
307 (group and elem not swaped)
309 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
310 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
311 Big Endian Transfer Syntax supposed the group following 0002
312 begins always by element 0000 (element 0000 is *optional*)
313 To avoid further troubles, let's be pessimistic, and use
314 Document::HandleOutOfGroup0002() method
315 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
316 (related pb not yet solved)
318 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * Bug fix for the python part use
320 * Now, PrintHeader.py pass... but outside the ctest use. shit !
322 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
325 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
327 a string and should ask the global TS dict what are the propreties of
330 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
331 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
332 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
333 to swap the Swap Code, at parsing time, when we come out of group 0002
334 and Transfer Syntax is Big Endian
335 We should be able to read now 'true DICOM" Big Endian coded images
336 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
337 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
339 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Hopefully fix the bug on MacOSX and static global initialization.
341 This is the only -minor- patch I found that both please MacOSX and VS6.
342 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
343 but this would require a lot of change. Another approach would be that Global
344 create those string and GDCM_UNFOUND becomes a pointer to a string (which
345 gdcm::Global would destroy at exit).
347 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
348 * Fix bug on MacOSX with static initialization in a multy threaded
349 environment. static const string in a header file used to be ill
350 initialized provoquing the freeze of any tests. patch should solve this
353 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
354 * According to Benoit's suggestion, and without any objection from anybody
355 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
356 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
357 - method gdcmDicomDirObject::GetEntry() renamed as
358 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
360 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
361 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
362 you debug/warning message just as c++ streams which make them very convinient
363 to use. Once this is stabilize I will change the ostringstrem to be
364 redirected to a file (ofstream).
365 * Properly support C99 extension: __FUNCTION__ which allow us to display
366 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
368 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
369 * Removal of useless and dangerous methods :
370 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
371 GetDocEntryByName, GetEntryByName, GetDictEntryByName
372 * Removal of usless methods :
373 Dict::PrintByName, Dict::GetDictEntryByName
374 * Commenting out of probabely useless methods :
375 Dict::GetDictEntryNames()
376 Dict::GetDictEntryNamesByCategory()
377 DictSet::GetPubDictEntryNames()
378 DictSet::GetPubDictEntryNamesByCategory()
379 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
380 * ENH : Use dicomTS.dic as described in 2004 version
381 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
382 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
383 Add Accessors on VM (Value Multiplicity), and VM related methods
384 * ADD : Add a list of 'Dicom Attribute types', as found in
385 http://medical.nema.org/dicom/2004/04_15PU.PDF
387 * ADD : Add dicomGroupNameAbbreviations.dic
388 should be used to write a method to replace the former
389 Dict::GetDictEntryNamesByCategory()
391 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
393 to read in the file... and only it ! Length is the efective length of the
394 data in the DocEntry structure
396 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
397 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
398 And now use a static function call instead, with a global variable. i
399 This is much closer to the VTK approach. Hopefully should be bulletproof
400 and easier to use...hopefully
402 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
403 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
405 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
408 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
410 ValEntry, BinEntry, SeqEntry creation or replace
412 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
414 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
416 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
417 when specifying the VR
418 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
419 * src/gdcmDocEntry.cxx : amelioration of print
421 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
422 * ADD : Add the method Util::IsCurrentProcessorBigEndian
423 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
424 * ADD Method Document::ComputeGroupLength
425 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
426 in order to allow further VR modification by user
427 * REM : removal of once-called method File::WriteBase
428 integration of its code in formerly one-line method File::Write
430 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
431 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
432 replace the different values "??", "Unkn", "Unknown".
433 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
434 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
435 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
436 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
438 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
441 * Set the gdcm::Base class to some Printable classes
443 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * src/gdcmFile.[h|cxx] : add the Print method
445 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
446 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
447 * src/gdcmDocument.h : remove the PrintLevel informations
448 * Example/PrintFile.cxx : use the new gdcm::File::Print
450 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
452 problems when compiling with the python wrapping
454 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
456 writting in ImplicitVR
458 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
459 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
460 JPEG decompression, especially when dicom frames are split into several
461 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
462 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
464 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmHeader.cxx : change the initialisation of default header.
466 Now, this header is readable by gdm, e-film, DicomWorks
468 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
470 Rename Decompressed to Raw
471 * Use the API changes in gdcm::File.
472 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
475 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
477 each added entry in the header. Replace the 'Planes' field by the 'Number
480 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
482 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
484 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
485 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
486 At this time, this image isn't readable by e-film... waiting JPR help to
489 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
491 DocEntry. Now use methods of the Document !
493 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * Test/ShowDicomSeq.cxx : bug fix
496 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
498 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
499 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
500 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
502 * Test/TestCopyRescaleDicom.cxx : remove unused variable
503 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
504 containing found sequences
506 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
509 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
510 Some fields in BinEntry must be copied to not seg fault when making the :
511 gdcm::File *copy = new gdcm::File( copyH );
512 and tests are now made on good variables
514 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
516 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
518 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
519 * Add vtkGdcmWriter example and test
521 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * Test/TestUtil.cxx : reformat the source code
523 * vtk/vtkGdcmReader.cxx : remove and change prints
524 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
526 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
527 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
529 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
531 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
533 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
535 by an eof to prevent all bad read of the file... and in this case, the
538 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * Example/Volume2Dicom.cxx : comment unused variables
540 * Test/PrintDicomDir.cxx : comment unused variables
541 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
542 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
543 method that is redondant with AddEntry.
544 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
547 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * Bug fix due my last commit (compilation under Windows).
549 * Example/Volume2Dicom : bug fix in the file and reformatting source code
550 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
552 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 - Remove printf / sprintf
555 - include iostream AFTER gdcm so we don't get warnings
556 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
558 - Also remove tons of include from header files, hopefully this should
559 speeup the compilation time, since it was becoming a dog slow.
560 - Remove gdcm.h as it include way too many files and slow down compilation
561 (plus it is not up to date)
562 - remove 'using namespace std' this is BAD !
564 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Remove memory leaks on the DicomDir
566 * Remove some useless data in DicomDirObject
567 * Add usefull methods in SQItem, to be complient withe the ElementSet
569 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
572 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
574 future, with convertion)
575 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
576 and ImageDataSize values. Remove the method to get the PixelReadConverter
577 from the output of the class
579 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
582 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
584 and vtkErrorMacro use.
585 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
587 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
590 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
591 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
592 The string leaves only in the fonction. So when we make a .c_str(), we
593 get the pointeur on the first element, element that will be destroyed
594 immediately after thee instruction.
595 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
596 file has been opened : the test must be made on the content of the
597 pointer and not directly on the pointer !
600 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
602 the python part recompiles
604 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
606 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
607 X session is killed (for my computer... it seems to not be identic on
610 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
612 avoid problems (otherwise, the difference test between the visible image
613 and the reference is incorrect. If the reference is greater than the
614 screen resolution, it's produce errors).
615 Can be used for only one image. Can be used with a visible flag.
616 * vtk/vtkGdcmReader.cxx : remove commented codes.
617 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
618 under windows at compilation
619 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
621 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
623 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
625 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
626 tests on the image size X, Y, Z
628 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
630 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
631 between the class name and the file name
633 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/ : fix compilation warnings for the Write method (2 different
635 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
636 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
637 variable... create a static method in gdcm::Document to access to
638 this variable content.
640 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
642 file, to be accessed by other files (like gdcmFile). Remove commented
643 code. Move the change of the header to the gdcmFile, using the
645 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
646 To be sure of that (and simplify calls), the Write of the header now
647 gets a file name and not a file pointer (std::ifstream).
648 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
649 DocEntryArchive. Remove all open of the written file
651 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
654 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
656 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
658 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
659 some corresponding methods. Write correctly the file and check before
661 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
662 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
663 is now on RGB data (as before my last commit
664 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
666 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
668 Add a print information of the type of the entry
669 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
670 It was in the gdcmFile, and all write have been regrouped
671 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
672 Write correctly all dicom files (in decompressed mode only at this time)
673 * Test/ : test on files are now made using Raw data and not color data if
675 * Example/PrintFile.cxx : add more printings
677 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * Amelioration of code, remove some code copy. For the loading of
679 BinEntry (in gdcmDocument), add the test to verify if the file is already
682 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
683 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
684 remove a DocEntry in the header (push an empty DocEntry)
685 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
686 lines. Bug fix in the initialization of the PixelConvert and the
688 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
689 use in TestCopyDicom (now this test can run under windows... but fails)
690 * Test/TestCopyDicom.cxx : amelioration of the test :
691 - test the pixels written
692 - add test points to quickly find where is the error
693 - can set a file name input and output in arguments
694 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
695 amelioration of the test output
697 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
699 all replaced DocEntry's
700 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
701 Now, each needed DocEntry to modify is duplicated, modified and inserted
702 to the header using DocEntryArchive. Thus, after save, we can restore the
703 header initial state.
705 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
708 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
710 correct to copy it. The DictEntry is specified at the DocEntry creation,
711 then, it musn't change in the time.
712 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
713 header correctly. At this time, the change is only made for the first
714 level of the Document. In the future, it might consider sequences.
715 The change is made by replacing a DocEntry by an other that is created
716 outside the class. The old value is kept. When we restore the header
717 status, the added DocEntry is deleted and replaced by the old value.
718 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
719 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
720 set the write type to explicit VR, implicit VR or ACR. Add methods to set
721 the write mode to native, decompressed or RGB (but not used at this time)
723 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
725 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
727 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
729 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
731 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
732 set because already copied when copying the BinEntry's of the header
733 * Test/TestAllReadCompareDicom.cxx : remove warnings
735 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
737 Two problems appear when doing it :
738 - with the gdcmFile : when the GetImageData method is called, the pixels
739 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
740 data (pixels). And each structure destruct the data when it's
741 destructed. So we have two destructions for the same data. To solve it,
742 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
743 data or not. If it doesn't own data, then they will not destroyed by
745 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
746 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
747 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
748 create a double destruction of the same DocEntry's. So, to solve it,
749 the TagHT is simply cleared and the DicomDir* elements are destroyed.
750 * TODO : add an entry concerning memory leaks in the DicomDir
752 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
754 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
757 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
759 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
760 after it have been deleted
762 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * FIX: src/* fix the doxygen warnings.
764 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
765 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
766 was erroneously defined with a size of 15 instead of 16. [many thanks
767 to Jean Michel Rouet for pointing out this bug].
769 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
770 1. Finish merging JMR patch for writting DICOM from scratch
771 2. Fix -hopefully- bug with MONOCHROME and space vs null character
772 3. Use const ref when possible
773 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
774 5. A few more comments
775 6. CreateUniqueUID can now be called without parameter"
777 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
778 * ENH: Slightly bigger patch:
779 1. Getting toward full integration of JMR patch for writting dicom from scratch
780 2. Update Test to test part of this patch: CreateUniqueUID
781 3. File was not close properly in gdcmDict
782 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
783 5. Use of const ref instead of copy (speed issue)
784 6. Remove temporary (duplicate) string in TranslateToKey
785 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
786 8. Do not repeat virtual in subclasses
787 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
789 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
790 * Apply first patch toward better string comparison when dealing with broken
791 DICOM files. Essentially the string could be padded with a space instead
792 of a null character as defined by standard
794 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
795 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
796 because never used... and in the same time, that's remove some memory leaks
798 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * src/gdcmFile.cxx : now delete the PixelConvert instance.
800 * In examples and tests : change the type of image data variables from void*
801 to uint8_t*. Remmove all delete on image data variables
803 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
805 Verify the file pointer value before open the file, and if it's not null,
806 a verbose message is generated.
807 Close correctly the file when the file isn't considered dicom-like. The
808 correctly close is a call to CloseFile.
809 When closing the file pointer, test if its not null to close the file.
810 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
811 file. For an uncompressed image, the copied data correspond in the least
812 case to the image size (calculated) or the image size specified in the
813 header. A verbose is generated if these two size mismatch
815 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
817 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
818 break under windows (with msvc6 compilation).
820 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
822 compiling with MSVC6)
824 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
825 * Bugs fix for the Windows build with VC6
826 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
827 needed (only for projects required VTK). If the VTK is included in all
828 projects, there is conflicts with the jpeg lib of vtk when compiling the
829 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
830 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
831 when compiling the gdcm_wrap.cxx file (created by the compilation of the
833 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
834 (like it's already made for the cout use). Otherwise, conflict with the
837 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
840 - comments on the DicomDir::Method related usage added.
841 - now that we use the namespace gdcm, a lot of internal classes do
842 NOT need to be wrapped anymore.
843 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
844 DicomDir::Method) new example added.
846 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * Improve string manipulation. I now inforce the notion of 'DicomString'
848 A DicomString can contain as many \0 as they want
849 and it is *always* of even length.
850 We only support odd length for very rare case.
851 And in the near future this should be removed.
853 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
854 * /binary_write/ gdcm source. Now even on big endian we are writting
855 little endian. This should -heopfully- fix some tests
857 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
858 * Now the dictionary is compiled into gdcm lib. This is a default
859 behavior, thus any dic file specified is picked before failback to
860 the one comiled into lib
862 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
863 * Change internals for gdcmDict. Don't use any 'new' any more.
864 This should definitely solve any leak problem, and we should be
865 as fast as before, as long as don't modify too much the dictionary.
867 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
868 * STYLE: ivars should start with a capital letter.
869 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
870 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
872 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
873 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
874 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
875 new 2004 dictionaries added (thanks to JPR).
876 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
877 * CLEANUP_ROUND (15) for gdcmPixelConvert
878 - RLEFrame::NumberFragments is now of type unsigned int
879 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
880 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
883 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
884 * Initial work in gathering all transfer syntax accessors. clearly
885 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
886 ivars, but only one transfersyntax (class) ivar with equivalent method on
889 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
891 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
892 discussed (plus I didn't like having a 2000 lines patch not commited)
894 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
896 * CLEANUP_ROUND (14) for gdcmPixelConvert
897 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
898 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
899 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
901 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
902 anymore and hence avoids storing a copy of PixelConvert::Decompressed
903 into File::Pixel_Data.
905 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
907 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
908 * CLEANUP_ROUND (13) for gdcmPixelConvert
909 Substituted File::ParsePixelData() with PixelConvert::Print() new
911 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
912 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
913 method to those classes.
914 - src/gdcmFile.[cxx|h]:
915 -- Added a ::Print() method.
916 -- PixelConverter is now a reference instead of a member.
917 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
918 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
920 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
921 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
922 collaboration diagram and inheritance diagram should be generated with
924 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
925 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
926 pointlessly wrapped (see
927 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
928 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
929 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
930 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
931 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
932 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
933 -- File::Initialise: PixelConverter setup moved away to
934 PixelConverter::GrabInformationsFromHeader()
935 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
936 interpretation moved away to PixelConverter::BuildRGBImage()
938 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
940 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
942 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
944 displayed on Win32 when a brutal abort() occurs (because of uncatched
945 exception). See TODO new entry of this commit for more on this.
946 * TODO added new entry.
947 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
948 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
949 - HandleColor is no longer called from gdcmFile.cxx
950 - gdcmPixelConvert.cxx clean up on method arguments and internal
951 variable names for semantical coherence.
953 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
954 * Finished lossless transition, not only do we now read all lossless jpeg
955 images, without the need of the Cornwell lib, but we do read them properly now
956 * To reduce code (well to avoid code duplication), I defined a common place
957 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
958 redefine symbols. This is not perfect but this the best solution I found for a
959 compilation time jpeg option.
961 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * Update jpeg ijg lib to support lossless jpeg implementation
963 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
965 * Also added a special copyright for dcmtk since we use their bugfixes.
968 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
970 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
971 matters, as stated in warning note at begining of %include section).
972 * src/gdcmDicomDir*.[cxx|h]: coding style
973 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
974 * src/gdcmJpeg8.cxx: doxygen fix.
975 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
976 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
977 from File:: to PixelConvert::.
979 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
981 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
982 - more code moved away from File:: to PixelConvert::
983 - fat setup of PixelConverter set in place in File::Initialise.
985 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
986 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
987 namespace at the file system level. So now you should convert your examples
989 gdcmHeader -> gdcm::Header
990 It would be nice if people keep in mind to no open the namespace, since it
991 allows compilation on broken plateform which were defining common symbol in
992 the standart namespace (like LP, Unknown ...)
994 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
995 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
996 The JPEG fragments are now parsed at the same stage than the RLE
997 information. All code related to JPEG is now in gdcmPixelConvert:
998 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
999 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1000 export a gdcmFile:: method. Those are simply global functions
1001 (for the time being this is better than having them attach to
1002 either gdcmFile:: or gdcmPixelConvert::).
1003 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1004 and stores the result in a gdcmJPEGFragmentsInfo.
1005 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1006 code (among other stuff) moved away from gdcmFile:; to
1009 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1011 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1012 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1013 clean up of RLE related code.
1014 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1015 - src/gdcmRLE.cxx removed
1016 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1017 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1018 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1019 * CLEANUP_ROUND (9) for gdcmPixelConvert
1020 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1021 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1022 away from gdcmFile:: to gdcmPixelConvert::.
1024 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1026 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1027 This is because Parse7Fe0 used to parse the pixels to compute the
1028 length. This task was passed over to FindDocEntryLengthOB() a long
1029 time ago, EXCEPT I had forgotten the OW case...
1030 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1031 we just recylce the code for parsing RLE fragments and computing
1033 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1034 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1035 with the retired Parse7Fe0().
1036 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1037 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1039 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1041 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1042 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1043 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1044 * CLEANUP_ROUND (4) for gdcmPixelConvert
1045 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1046 to return an unused length.
1048 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1049 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1050 this should be cleanner from the plane view. The iostream are erally a pain
1051 to use to do simple stuff.
1053 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1054 * Redo the compilation of the ijg jpeg library. Now only one source is
1055 necesseray. No need to rename file by hand what so ever. CMake handle the
1056 copying of the file within different directory, configure header file to
1057 modify some symbol. The only addition made to ijg wasd a mangle table so
1058 that symbol are different whether we are within 8bits or 12bits.
1060 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1061 * Added documentation of vtkgdcmReader on Website:
1062 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1063 with it's binary name).
1064 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1065 the Website to be more complete.
1066 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1067 doxygenated documentation.
1068 - Doc/DoxyVtkGdcmReaderExamples.txt added
1069 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1070 DoxyVtkGdmReaderExamples.html )
1071 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1072 * CLEANUP_ROUND (3) for gdcmPixelConvert
1073 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1075 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * CLEANUP_ROUND (2) for gdcmPixelConvert
1077 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1079 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * CLEANUP_ROUND for gdcmPixelConvert:
1081 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1082 - src/gdcmPixelStuff[h|cxx] removed
1083 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1084 - src/CMakeLists.txt changed accordingly
1085 * GDCMHOME clean up:
1086 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1087 gdcmVersion.py moved to newly created ATTIC related
1088 gdcmPython/SetupOldies/ directory.
1089 * Autotools clean up:
1090 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1091 - autogen.sh configure.in acinclude.m4 python.m4 removed
1093 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1095 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1096 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1098 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * TODO updated with Mathieu suggestions. I proposed a template for
1100 describing TODO entries and used it for new entries.
1101 * Added Doc/Website/CodingStyle.html, Developpers.html,
1102 DeveloppersPython.html, GdcmDataCvs.html and
1103 DownloadVersion0_1.html, DownloadVersion0_3.html.
1104 * Some Doc/*.txt Doxygen files (which do not really concern the
1105 documentation itself, but the website) moved to html and
1106 placed in directory Doc/Website:
1107 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1108 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1109 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1110 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1111 * CMakeLists.txt changed accordingly.
1112 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1113 DeveloppersPython.html
1114 * INSTALL nows refers to Doc/Website/Installation.html
1116 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * Added Doc/Website directory, that contains a first raw version
1120 2004-09-23 Jean-Pierre Roux
1121 * FIX In order not to be poluted any longer by casting problems,
1122 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1123 we can now delete[] it safely
1124 * VoidArea is now called BinArea (less confusing name),
1125 and all the methods called ...VoidArea... are now ... BinArea...
1126 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1128 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1130 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1131 up to the destructor of gdcmElementSet to clean up TagHt and it's
1134 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1136 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1138 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * ENH: added some utility method that builds a flat dictionary
1140 holding all the Dicom entries contained in the recursive structure
1141 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1142 an example of usage.
1143 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1144 BuildFlatHashTable() that build a flat dictionary.
1145 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1146 gdcmDocument is now a friend of gdcmElementSet.
1147 - src/gdcmElementSet.cxx: clean up.
1148 - Example/FlatHashTablePrint.cxx added.
1149 - Example/CmakeLists.txt changed accordingly
1151 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1153 moved away from gdcmDocEntrySet (since this class is an abstract class
1154 acting like an interface). SQDepthLevel and BaseTagKey are now
1156 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1157 and associated accessors. Doxygenation of the class.
1158 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1160 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1161 Use SQDepthLevel accessor instead. ::Print() adapted.
1162 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1163 - src/gdcmDocument.cxx changed accordingly.
1165 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1167 - The following is the doxygen comment of the typedef declaration
1168 of gdcmTagKey in src/gdcmCommon.h:
1169 gdcmTagKey is made to old an "universal" (as in URL, Universal
1170 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1171 A dicom tag always has a group and an element, but a set of tags
1172 embeded in various (optionally nested) sequences and sharing
1173 the same group and element all share the same (group, element)
1174 "identifier". Hence the (group, element) cannot be used as an
1175 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1176 In order to construct a proper tag identifier (i.e. a key) we
1177 consider the following definition of a TagKey:
1178 - let Group, Element be the string representation of the
1179 group and element dicom tag members,
1180 - let ItemNumber be the string representation of the integer
1181 index of the considered item number of a sequence,
1182 Let the key of a tag embeded in a sequence, noted SeqTag, be
1184 /ItemNumber#Group|Element
1185 where "/", "#" and "|" are characters acting as separators.
1186 Then the general form of a gdcmTagKey is given by:
1187 Group|Element<SeqTag>
1188 where <SeqTag> means NO or many instances of SeqTag.
1189 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1192 but the gdcmTagKey of a tag "embeded" is the first item of
1193 a sequence, itself nested in the third item of a sequence is the
1195 0004|1220/2#0008|0082/0#0008|0090
1196 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1197 order to hold the new sequence compatible key. Previously, the
1198 GetKey() method would look in the underlying gdcmDictEntry.
1199 - src/gdcmDocEntry.cxx:
1200 -- constructor now copies the underlying DictEntry key, in the local
1202 -- ::Print: displays the member Key, instead of the (group, element).
1203 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1204 - src/gdcmDocEntrySet.h:xi
1205 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1206 -- now has a new BaseTagKey member.
1208 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1209 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1211 This poses the problem with the semantics of the following lines
1212 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1213 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1214 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1215 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1216 to the long FIXME note for what the problem is. Nevertheless in
1217 order to get things working the dicom dictionary was altered !
1218 Please fix things urgently...
1219 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1220 information), see above note on moving the member VoidArea. Nevertheless
1221 the following entries previously correctly set as US are now inproperly
1223 0028 1201 OW IMG Red Palette Color Lookup Table Data
1224 0028 1202 OW IMG Green Palette Color Lookup Table Data
1225 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1226 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1227 of gdcmDocEntry moved to gdcmSeqEntry.
1228 * src/gdcmSeqEntry.cxx: STYLE.
1230 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1233 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * gdcmPython/testSuite.py: all the test suite in python is now moved
1235 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1236 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1237 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1239 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1241 to avoid inclusion recursion until STL is reached.
1242 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1243 mecanism. errno.h is not included in gdcm anymore.
1244 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1245 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1247 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1248 gdcmData/TestAllEntryVerifyReference.txt
1249 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1250 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1251 exception_on_error parameter.
1252 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1253 - vtk/vtkGdcmReader.cxx changed accordingly,
1254 - Example/*.cxx and Test/*.cxx changed accordingly.
1256 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1258 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1259 enable_sequences removed from gdcmHeader constructor and dependencies.
1260 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1261 * gdcmPython/demo/PrintHeader.py: dummy fix.
1262 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1263 skip_shadow removed from gdcmHeader constructor and dependencies.
1264 * Example/*.cxx and Test/*.cxx changed accordingly.
1266 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1268 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1270 2004-07-21 Jean-Pierre Roux
1271 * FIX Now, Parsing and Printing a DICOMDIR do work!
1272 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1274 2004-07-20 Jean-Pierre Roux
1275 * FIX Some brain damaged headers have Zero-Lenght fields
1276 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1278 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1279 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1280 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1281 variable (instance of gdcmDebug) by a definition macro, and the instance
1282 is now in static in the gdcmDebug class
1283 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1284 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1286 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * WARNING: ctest now depends more tightly on gdcmData. You should
1288 check out gdcmData properly for things to run smoothly...
1289 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1290 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1291 we need the pixels not be loaded in order to use the ValEntry
1292 that displays position and size).
1293 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1294 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1295 be deprecated. If you have any doubts about the advantages of a
1296 modern scripting language (read Python) versus grass root C++ (i.e.
1297 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1298 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1299 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1300 Anyhow, consider documenting the gdcmData images in
1301 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1303 * Test/CMakeLists.txt:
1304 - now uses TestAllEntryVerify.cxx
1305 - specific comments on oldACR00001.ima (now renamed in gdcmData
1306 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1307 gdcmData/TestAllEntryVerifyReference.txt
1310 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * src/*.[h|cxx] : typedef clean up
1312 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1313 - TagKey renamed to gdcmTagKey (for external usage)
1314 - VRKey renamed to gdcmVRKey (for external usage)
1315 - removal of typedef duplication.
1316 - Removed all unecessary inline keyword from class inline definitions.
1317 - Some method|function(void) declarations replaced with method|function().
1318 * src/jpeg/libijg12/jdhuff12.c:
1319 - printf polluting ctest removed.
1320 - TAB removal for comminting
1322 - TestAllReadCompareDicom.cxx: added a test that compares all the
1323 images in gdcmDataImages.h with corresponding images in
1324 gdcmData/BaselineDicom/. When baseline images are not present
1325 this test creates them.
1326 Note: we need to validate each reference image, but before that
1327 I'd like to rename them with a more explicit name...
1328 - CMakeLists.txt: changed accordingly.
1329 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1330 including each header needed).
1332 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1334 test suite to the Example directory. Are concerned:
1339 - TestWriteSimple.cxx
1340 * Test/CMakeLists.txt: added some comments on reasons for black listing
1341 image gdcmData/oldACR00001.ima
1343 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * Test/CmakeList.txt: removed the following from black list (to be coherent
1345 with removal from gdcmData):
1346 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1347 - gdcm-MR-PHILIPS-16.dcm
1349 Added the following because after last cvs update, they cause
1350 ctest -R TestReadWriteReadCompare
1352 - gdcm-MR-SIEMENS-16-1.acr
1354 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1355 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1356 new comments in this file) we temporarily (sigh) move to a weaker
1358 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1359 we don't need to black list the following images anymore:
1360 - 8BitsUncompressedColor.dcm
1362 - US-PAL-8-10x-echo.dcm
1363 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1364 fixes and the beautified code ;-)
1365 This fixes the bug introduced in version 1.42 (when beautifying)
1366 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1367 Note: ctest was blind to this bug (this means we need to still
1368 improve the test suite). The bug could be detected by using
1369 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1371 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1372 and by displaying the (garbage) produced file temp.XDCM...
1374 2004-06-29 Jean-Pierre Roux
1375 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1376 - replace by uggly but working old code :-(
1377 A lot of things should be OK again.
1378 It's really urgent to have a test suite that *tests*,
1379 to prevent Frog's beautifying sessions to break all the stuff
1380 (twice, withing a fortnigh ...)
1382 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1384 redundancy) to added Test/TestReadWriteReadCompare.cxx
1385 * Test/CmakeList.txt: because the compare test of
1386 Test/TestReadWriteReadCompare.cxx fails, the following images are
1387 black listed: - 8BitsUncompressedColor.dcm
1389 - US-PAL-8-10x-echo.dcm
1390 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1391 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1392 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1393 and ad-hoc kludge. This kludge is now removed, and on encountering
1394 such an image (OB field brain damaged) we set errno. Then in
1395 ::FindDocLength() we "fix" the length as being ALL what remains
1396 in the file (until EOF). We then proceed, hoping for the best...
1397 This fixes a SegFault in ShowDicom when trying to write such an
1399 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1400 (because TestWriteRead breaks on it, after a non conformal commit?).
1401 ctest now runs properly, except for MakeDicomDir (which was always
1402 broken) and the Python related stuff (still not fixed).
1404 2004-06-24 Jean-Pierre Roux
1405 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1406 FIX : Test/TestReadWrite now iterates on all the file names
1407 (instead of infinite loop)
1408 ENH : Test/TestWriteRead now iterates on all the file names
1410 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1413 2004-06-24 Jean-Pierre Roux
1414 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1415 when SamplesPerPixel =3
1416 - now Write is no longer confused by
1417 'BitsAllocated = 12" and 'BitsStored=12"
1418 - "UN" value representation Elements are now written correctly
1419 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1420 ENH : - now gdcmHeader has its own Write methods
1421 (in order to split the job that has not to be done
1424 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1426 loop on the same image until memory went out.
1427 Note: this means we still have gobs of memory loss in PrintDocument
1428 * src/gdcmDocument.cxx: fixes problem on parsing on file
1429 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1431 2004-06-24 Jean-Pierre Roux
1432 FIX : Write - All the Sequences and Sequence Item are now written
1433 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1434 is added a the end, when necessary.
1435 - A lot of brain-damaged images, that were read correctly are
1436 now written correctly
1437 - length compatible BinEntry are now loaded correctly
1438 (even for odd groups)
1439 Note : only Explicit Value Representation was checked.
1440 (question : is implicit VR really necessary for gdcm ?)
1442 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * DEVELOPPER: added a proposition of coding style.
1444 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1447 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1448 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1449 Use the gdcmDocEntry::Print() and Write() instead.
1450 * src/gdcmDocument.cxx: bug fix.
1452 2004-06-22 Jean-Pierre Roux
1453 FIX : gdcmDocument.cxx
1454 - Now we do recognize the JpegLossLess format (there was a misstyping in
1455 code 'beautyfication' :-(
1456 - Now we automaticaticaly load the Luts, if any
1458 2004-06-22 Jean-Pierre Roux
1459 In order : to write Sequences, whatever their imbrication level,
1460 : to allow user to create his own Sequences
1461 a lot of modif where necessary (adding, moving, or virtualising methods)
1463 WARNING : save your own sources *before* cvs up !
1466 ADD virtual void Write(FILE *fp, FileType filetype);
1469 ADD virtual void Write(FILE *fp, FileType filetype);
1470 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1473 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1474 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1475 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1476 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1477 ADD std::string GetEntryByName(TagName name);
1478 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1480 std::string vr = "unkn",
1481 std::string fourth = "unkn",
1482 std::string name = "unkn");
1483 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1484 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1485 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1486 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1487 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1488 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1489 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1490 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1493 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1494 ADD virtual std::string GetEntryByName (TagName tagName);
1495 ADD virtual std::string GetEntryVRByName (TagName tagName);
1496 REM virtual bool Write(FILE *, FileType);
1497 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1498 FILE *_fp, FileType type);
1499 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1500 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1501 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1502 REM virtual std::string GetEntryByName (std::string tagName);
1503 REM virtual std::string GetEntryVRByName (std::string tagName);
1504 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1505 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1506 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1508 std::string vr = "unkn",
1509 std::string fourth = "unkn",
1510 std::string name = "unkn");
1511 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1512 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1513 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1514 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1517 ADD virtual void Write(FILE *fp, FileType filetype);
1520 ADD virtual void Write(FILE *fp,FileType filetype);
1523 ADD virtual void Write(FILE *fp, FileType filetype);
1524 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1525 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1526 REM std::string GetEntryByName(TagName name);
1529 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1531 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1532 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1533 The default constructor invoked by the line
1534 gdcmHeader *f1 = new gdcmHeader( header );
1535 was gdcmHeader::gdcmHeader(bool) instead of the expected
1536 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1537 Hence the parsing wasn't executed... See also below.
1538 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1539 as explicit constructor didn't do the trick to fix the above problem.
1540 Could anyone explain why ?
1541 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1542 properly calls gdcmValEntry::Print() (that was weed out from
1543 code related to gdcmBinEntry).
1545 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * In order to fix memory leaks:
1547 - Test/TestWriteSimple.cxx: added cleaning of free store through
1549 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1550 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1551 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1552 (through the call to ::AddDicomDirMeta()) or the destructor
1553 would crash when deleting uninitialized ::metaElems].
1554 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1555 - src/gdcmDocument.cxx:
1556 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1557 from dynamic stores.
1558 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1559 was causing memory leaks.
1560 - src/gdcmSQItem.cxx:
1561 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1562 cleanly handled with polymophism: sorry but my milage is low).
1563 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1564 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1565 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1566 This avoids SegFaulting.
1567 - src/gdcmSQItem.h: coding style.
1569 - Test/TestWriteSimple still severely sucks. The output image content
1570 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1571 damaged when displayed with vtkgdcmViewer.
1572 - on memory leaks: TestWriteSimple leaks really less (see entry
1573 of 2004-06-18 in Changelog file for the call to valgrind).
1574 - on segfaults: ctest now passes all the tests but one (no more
1576 * Erroneous leading white fix:
1577 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1578 white[s] (as opposed to from >> xxx, that removes it [them].
1579 - src/gdcmTS.cxx: ditto.
1580 - gdcmPython/testSuite.py: dirty related kludge removed.
1581 * src/*: remaining references to gdcmParser removed.
1582 * src/*[cxx|h]: added copy[way]left header.
1585 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1586 * In order to fix writing of dicom files:
1587 - Test/TestWriteSimple.cxx: a simpler example of writing.
1588 - Test/CMakeLists.txt changed accordingly.
1589 - src/gdcmDocument.cxx:
1590 -- The destructor now recursilvely removes potential sequences.
1591 -- Bug fix in ::IsJPEG2000()
1592 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1593 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1595 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1596 to only declared) and build on top of
1597 ::GetDocEntryByNumber(guint16, guint16).
1598 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1599 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1600 for usage in destructor and treatement of promotion in
1601 ::ReplaceOrCreateByNumber().
1602 - src/gdcmSQItem.cxx: destructor should better handle his job.
1603 Test/TestWriteSimple now runs (or at least it DOES something).
1604 * We can now start hutting memory links. A good starting point is:
1605 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1606 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1607 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1609 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * Valgrind note: after Mathieu Malaterre teached me how to read
1611 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1613 Using gcc, you can force the STL to use malloc and to free memory as
1614 soon as possible by globally disabling memory caching.
1615 With 3.2.2 and later, you should export the environment variable
1616 GLIBCPP_FORCE_NEW before running your program.
1617 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1618 simply vanish (it is still not clear to me, whether this means that
1619 STL std::string leaks or if valgrind believes it leaks...).
1620 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1621 running bin/gdcmTests makeDicomDir):
1622 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1623 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1625 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1626 SegFaulting (I drowned in DicomDir related code when trying to
1627 understand why the list is empty...).
1628 * src/gdcmDocument.h: first BSD license header try.
1629 * Doc/License.txt added.
1631 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1632 * src/gdcmDocument.[h|cxx]:
1633 - Clean up of the Transfer related predicates. They are now all based
1634 on new method isGivenTransferSyntax, that (should) handle properly
1635 the padding problem.
1636 - general clean up, simplification, and coding style.
1637 - Specific clean up of Parse7FE0() (umproperly named actually).
1638 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1640 2004-06-14 Jean-Pierre Roux
1642 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1643 - fix the display of SQItem ordinal number
1644 - add the GetSQItemByOrdinalNumber method
1645 - remove some useless never written private methods
1647 2004-06-14 Jean-Pierre Roux
1649 - adding a constructor taking a gdcmDocEntry as an input param
1650 - ReplaceOrCreateByNumber now returns :
1651 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1652 a gdcmValEntry * if a string value is passed as a param
1654 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1655 according to the param type (no longer sets a gdcmDocEntry)
1656 - GetValEntryByNumber, GetBinEntryByNumber added
1657 - NewValEntryByNumber and NewBinEntryByNumber added
1659 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1661 - GetSQItemNumber and SetSQItemNumber added, to provide
1662 a (relative) Item identier inside a given Sequence
1663 \warning : some pb remaining around this number
1665 - AddEntry now takes the Item Number as a param
1667 - adding a constructor taking a gdcmDocEntry as an input param
1669 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * Memory leak hunt with the following command:
1671 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1672 --show-reachable=yes gdcmTests PrintDocument
1673 It looks like many (all?) leaks are due to the STL (or a bad usage
1674 of the STL. The lines producing the leaks now have a comment with
1675 a "MEMORY LEAK" tag: you can retrieve them with
1676 grep "MEMORY LEAK" src/*
1677 Here are two typical examples which I can't help fixing:
1682 char * test = "babo";
1683 name = test; //// <--- valgrind detects 960 bytes lost in
1684 //// call to std::string::operator=(char const*)
1685 name.clear(); //// Doesn't help !
1693 std::cout << "Type a bunch of characters followed by RETURN: ";
1694 getline(std::cin, line); //// <--- valgrind dectects a loss
1695 //// of 1320 bytes in call to
1696 /// std::basic_istream<>& std::getline<>
1702 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * src/gdcmHeader.[cxx|h]:
1704 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1705 and related, moved away to gdcmDocument.
1706 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1707 the corresponding protected accessors of inherited class
1708 gdcmDocument, removed ! As a consequence gdcmFile had to be
1709 declared friend of class gdcmDocument (see below).
1710 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1711 - Clean up of undefined or unused methods.
1712 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1713 account the changes to gdcmHeader.h).
1714 * src/gdcmDocument.h:
1715 - gdcmFile is now a friend class (in order to take into account the
1716 changes to gdcmHeader.h).
1717 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1718 (see changes to gdcmHeader.h).
1719 - Accessors (reading on the form GetEntry*) are now public.
1720 - Clean up of undefined or unused methods.
1721 * src/gdcmDocument.cxx:
1722 - adaptation to changes to gdcmDocument.h
1723 - ::OpenFile now writes a verbose message when file cannot be opened.
1724 - some std::string properly set to VRKey
1725 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1726 references to gdcmDocument.
1727 * Test/TestFindTags.cxx: changed accordingly to above changes.
1728 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1729 cvs repository gdcmData.
1731 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1732 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1733 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1734 conflicts with gdcmValEntry::voidArea.
1735 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1736 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1737 Value representation between StringRepresentable and BinaryRepresentable.
1738 * src/gdcmDocument.cxx:
1739 - method ParseDES: proper indentation restored and usage of
1740 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1741 - method LoadDocEntry: the fingerprint left in the SetValue() of
1742 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1743 removed. Reverting to previous code segment with the proper
1744 dynamic_cast< gdcmValEntry* >.
1745 Note: this was (partially) breaking the python test suite
1746 (gdcmPython/testSuite.py) that made usage of the above
1747 fingerprint to check presence of "Pixel Data".
1748 * src/gdcmDocEntry.h: coding style.
1749 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1750 now taken into account.
1751 * gdcmPython/gdcm.i: adaptation to the new internal representation
1752 of gdcm (exit gdcmParser, hello gdcmDocument).
1753 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1755 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1756 anymore, but instead prints the loaded Python dictionary.
1757 * .... alas, the python testSuite is still broken.
1759 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1760 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1762 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1763 * src/gdcmUtil.h : export methods
1765 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1768 * Initial addition of automatic python testing
1769 * Initial addition of automatic image comparison
1771 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1772 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1773 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1775 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1776 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1777 * Test/ShowDicom.cxx : bug fix for msvc compilation
1778 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1780 2004-05-04 Jean-Pierre Roux
1781 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1782 new concepts (and new classes) :
1783 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1784 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1785 - Sequence Doc Entries (gdcmSeqEntries)
1786 a Sequence is composed of Items.
1787 Each item is a set of Doc Entries (this is recursive)
1788 The non uniqueness of the 'Dicom tag' is due to this recursivity
1789 (never taken into account)
1790 Our unability to add a new 'entry' in the header
1791 at the proper location (neither in the H-Table (map or multimap),
1792 nor in the Chained List is also due to this recursivity.
1793 Don't try, right now, to use/modify/compile these new sources :
1794 nothing is finished.
1795 We just commit all the stuff, 'as is', in order not to loose it.
1797 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1798 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1800 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1801 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1802 file prefix (SetFilePrefix)
1804 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * Add a new test: ShowDicom, for now this is just the c++ version of
1806 checkRead.sh, later it will be able to compare the image read against a
1808 * Replace the DEBUG on the stack with a global entry in cmake interface:
1809 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1811 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1812 * Add an example subdir, with a real example on how to read + write a
1815 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1817 * Doc/CMakeLists.txt: the main page is now properly differentiated
1818 between the developper and user version.
1819 * Doc/doxygen.config.in: dropped search related obsolete flags
1820 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1822 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * DEVELOPPER: added some helpfull comments for compile/test/install
1826 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1828 src directory, now generated in the build dir.
1829 2. Tests as mentionned smarter
1831 4. Add a new method in gdcmDict that return the PubDict by name
1832 this is interesting for 3rd party lib like ITK,
1833 where we could set the institution name / patient name...
1835 * ENH: 1. Now the test suite is working for real
1836 2. All binaries are now output in the gdcm-bin directory
1837 (this was not true before)
1839 2004-04-28 Jean-Pierre Roux
1840 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1841 SeQuence indented printing of Dicom Header.
1842 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1843 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1844 Computation of SQDepthLevel is now part of gdcmHeader constructor
1845 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1846 tree-like structure of a Dicom Header.
1847 * FIX Test code cleaning
1849 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * ENH: Adding automatic testing
1851 1. Need a DartConfig.cmake to submit to public
1852 2. Add a test driver gdcmTest.cxx
1853 3. gdcmTestMain, an helper for the main test driver gdcmTest
1854 4. Files in Test don't have a main anymore, this becomes interesting
1855 when we add more and more tests, thus dsw don't have to load
1857 * ENH: Adding a GDCM_DATA_ROOT for testing
1858 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1859 one file instead of seven + some small cleanup
1861 2004-04-22 Jean-Pierre Roux
1862 * ENH Minor changes to the Print() methods.
1863 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1864 Header printing. Example given with :
1865 > PrintHeader fileName 2 new
1866 (SQ based tree-like structure still to be done for the Header ...)
1868 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1870 1. I have added some unsigned where needed
1871 2. Some function parameter not used -> (void)
1872 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1873 4. g++ don't like character '\' in comment
1874 5. #define jpeg_create_decompress jCreaDecompress
1875 this really need to be fixed
1876 6. virtualize destructor of gdcmObject ... leakage
1877 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1878 this also really need to be fixed
1879 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1880 remove compression file
1881 (as we only do decompression, right ?)
1882 * ENH: Change malloc/calloc/free with c++ equivalent
1884 2004-04-21 Jean-Pierre Roux
1885 * FIX gdcmHeaderHelper::GetXSpacing
1886 when a single value is found (bug ?), xpacing is now
1887 defaulted to yspacing
1889 2004-04-19 Jean-Pierre Roux
1890 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1891 * ENH add parameters :
1892 bool exception_on_error = false,
1893 bool enable_sequences = false,
1894 bool ignore_shadow = false
1895 to the gdcmFile constructors to be full gdcmParser compliant
1896 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1897 to allow reading of PAPYRUS 3.0 files
1899 2004-04-06 Jean-Pierre Roux
1900 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1902 2004-04-02 Jean-Pierre Roux
1903 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1904 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1905 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1907 2004-03-30 Jean-Pierre Roux
1908 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1909 for ACR file, written out as DICOM files (hope so...)
1911 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1912 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1913 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1914 moved to base class gdcmParser and only the specialisation is kept
1916 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1917 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1918 already does the job.
1919 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1920 (to be consistent with gdcmParser::WriteEntries).
1922 2004-03-30 Benoit Regrain
1923 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1924 upate of the object's instance. It's passed to 2 in the unfavorable
1925 case : one in the ExecuteInformation, one in the ExecuteData
1927 2004-03-29 Jean-Pierre Roux
1928 * ENH : Check on file type to be written moved
1929 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1930 * FIX : gdcmObject::ResetBoundaries now stops properly
1931 when end-of-list is reached
1932 : gdcmVersion modified (as Benoit Regrain asked)
1934 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1936 * src/gdcmUtil.cxx: added forgotten iostream include.
1937 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1938 equivalent to ExplicitVR in existing code).
1940 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1942 now contains all the gdcmGlobal related code.
1943 * minor coding style and doxygenation changes.
1945 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1947 now contains all the Debug related code.
1948 * minor clean-up of includes in src/*.cxx
1949 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1950 CreateCleanString) removed.
1951 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1952 * Doc/DoxyMainPageUser.txt added.
1953 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1954 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1955 src/gdcmDirList.cxx)
1957 2004-03-24 Jean-Pierre Roux
1958 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1960 2004-03-23 Jean-Pierre Roux
1961 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1962 big endian made volumes
1963 * ENH Now gdcmParser constructor and destructor are protected to forbid
1964 end user to instanciate class gdcmParser
1965 (only gdcmHeader and gdcmDicomDir are meaningfull)
1967 2004-03-22 Benoit Regrain
1968 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1969 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1970 gdcmSerie to gdcmDicomDirSerie
1972 2004-03-19 Jean-Pierre Roux
1973 * ENH Now the tree-like structure describing a DICOMDIR comming from
1974 an already existing DICOMDIR file is consistent with
1975 the home-made tree-like structure build ex-nihilo
1976 or build from the files held (recursively) in a Directory
1977 functions gdcmDicomDir::CheckBoundaries()
1978 gdcmObject::SetBoundaries() added
1980 2004-03-17 Jean-Pierre Roux
1981 * REM (Eric Boix bug) : removal of meaningless
1982 gdcmDicomDirImage::NewImage function.
1983 * FIX now file names and directory name are written properly in the
1985 * FIX now gdcmDicomDir constructor may be call without any trick
1988 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1990 of gdcmDicomDirImage::NewImage as empty function.
1992 2004-02-28 Jean-Pierre Roux
1993 * ENH add gdcmDicomDir:NewPatient
1994 add gdcmDicomDirPatient:NewStudy
1995 add gdcmDicomDirStudy:NewSerie
1996 add gdcmDicomDirSerie:NewImage
1997 to allow making gdcDicomDir object.
1998 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1999 (as opposite to the gdcmHeader chained list)
2001 2004-02-11 Benoit Regrain
2002 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2003 when using from python
2005 2004-02-10 Benoit Regrain
2006 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2007 * FIX : in gdcmDicomDir when the directory is empty
2008 * ENH : add callback and methods to get the progression of dicomDir
2011 2004-02-06 Jean-Pierre Roux
2012 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2013 - GDCM_META added to gdcmDicomDirType
2014 - class gdcmMeta created
2015 * ENH : - A brief summary is now displayed at the beginning of
2016 'testDicomDir' to help disaster magnitude estimation
2017 * REM : Now useless Test/explDICOMDIR.cxx
2019 2004-02-05 Benoit Regrain
2020 * ENH : add methods in gdcmObject to get the hash table or the list of
2022 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2023 * FIX : wrapping python for TagHeaderEntryHT
2025 2004-02-04 Benoit Regrain
2026 * FIX : even length for some strings when writting the dicom dir
2027 * FIX : sort the images in the dicom dir
2028 * FIX : Bug fix for python use of dicom dir
2029 * ADD : a python demo
2031 2004-02-04 Jean-Pierre Roux
2032 * FIX : Final solution (?) for icone embedded images
2033 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2034 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2035 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2036 gdcmData/gdcm-MR-SIEMENS-16.acr1
2037 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2038 to make full checking easier
2040 2004-02-04 Benoit Regrain
2041 * FIX : WriteEntries : coding style & logic in parameters
2042 * FIX : Set the elements to create the DicomDir in a dictionary file
2044 2004-02-03 Benoit Regrain
2045 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2046 * gdcmDicomDir : add the load of directory
2047 * Bug fix and print add-on
2049 2004-02-03 Jean-Pierre Roux
2050 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2051 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2052 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2053 * FIX gdcmParser.cxx : 'group length' elements are now considered
2054 as integers, even for shadow groups, when file is Implicit VR
2056 2004-02-02 Jean-Pierre Roux
2057 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2059 of the last synonym :-(
2060 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2062 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2063 * FIX taking into account the possible 7fe0,0010 multiplicity
2064 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2065 to allow removal of references to 7fe0,0010, to deal with
2066 ACR-NEMA images, when 0028,0200 is meaningfull
2068 2004-01-31 Jean-Pierre Roux
2069 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2070 no longer writes 'Un' on disk
2071 * FIX SQ elements with actual length are now dealt with corectly
2072 * FIX gdcmFile::WriteBase make the difference, for color images, between
2073 the length (for Palette expanded images)
2074 and Raw Length (non expanded image + Palette)
2075 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2076 (that broke Write). Replaced by UL.
2077 Aware user will reload the field if he
2078 thinks it's necesssary
2080 2004-01-30 Jean-Pierre Roux
2081 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2082 when 'dirty Acr' is found, to be compliant with the new
2083 IsReadable() methods.
2085 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2086 (no DOUBLE images in kosher DICOM,
2087 but so usefull for people that miss them ;-)
2089 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2090 DICOMDIR related utilities (not checked as Windoze compliant)
2092 2004-01-28 Jean-Pierre Roux
2093 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2095 2004-01-27 Jean-Pierre Roux
2096 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2097 to allow skipping the shadow elements, to save memory space.
2098 The TRUE value for this param has to be used
2099 with a FALSE value for the 'enable_sequence' param.
2100 ('public elements' may be embedded in 'shadow Sequences')
2101 * gdcmHeader methods now deal with 'embedded icones images' in the header
2102 (even when an 'icone image sequence' is announced by the
2103 element (0x0088,0x0200), but there is NO icone at all ...
2105 * gdcmHeader sometimes Image Location value doesn't follow
2106 the supposed processor endianity (see gdcmData/cr172241.dcm).
2109 * gdcmHeader add the method
2110 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2111 to get *all* the Header Entries with the same tag.
2112 GetHeaderEntrySameName is probabely *useless*
2113 (no meaning : Name is *not* an identifier within the Dictionary)
2115 2004-01-26 Benoit Regrain
2116 * Bug fix in the print of hexadecimal representations. Remove long fields
2117 in the print and add a third level of print to print them
2119 2004-01-23 Benoit Regrain
2120 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2121 * Bug fix on test suite after remove the strip made on not string fields
2122 * Split the IsReadable method between gdcmParser which test that the file
2123 is dicom and gdcmHeader which test that it's an image file
2125 2004-01-22 Benoit Regrain
2126 * DicomDir : clean code, add methods, set variables in protected or private
2127 * gdcmUtil : bug fix for the clean string method
2129 2004-01-19 Benoit Regrain
2130 * Add the use of shadow dictionaries
2131 * bug fix and coding style
2133 2004-01-19 Benoit Regrain
2134 * src/gdcmFile.cxx : bug fix concerning the close of file
2135 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2136 * Add the update of header entries using the shadow library
2138 2004-01-19 Benoit Regrain
2139 * removal of file gdcmHeader2.cxx
2140 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2141 inheriting from gdcmParser. This split is to prepare the integration
2142 of dicom dir parsing
2143 * bug fix under python
2145 2004-01-16 Jean-Pierre Roux
2146 * REM removal of class gdcmHeaderEntrySet
2147 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2148 * ADD add file gdcmHeader2.cxx
2149 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2151 2004-01-15 Benoit Regrain
2152 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2153 entries created while parsing the header. Thus, they will be destroyed
2154 when the gdcmDictSet will be destroyed
2155 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2158 2004-01-15 Benoit Regrain
2159 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2160 made a fatal error because of the memory release at the end of program.
2161 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2162 some memory and vtk seems to have some problems with that.
2163 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2165 2004-01-14 Benoit Regrain
2166 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2167 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2168 * src/*.[h|cxx] : make changes due to class name changes
2169 * gdcmPython/demo/*.py : bug fix due to method names
2171 2004-01-13 Benoit Regrain
2172 * src/*.[h|cxx] : coding style
2173 * vtk/*.[h|cxx] : coding style
2175 2004-01-13 Benoit Regrain
2176 * gdcmPython/testSuite.py : test the readable flag of file for tests
2177 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2178 It's lied to the stl compilation by MSVC (windows, always windows...)
2179 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2181 2004-01-12 Benoit Regrain
2182 * src/*.h : add comments
2183 * src/gdcmDictSet.h : set the method BuildDictPath in public
2184 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2185 directly setted in the source code
2186 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2189 2004-01-09 Benoit Regrain
2190 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2191 * setup.py : use a reference to gdcmVERSION
2193 2004-01-07 Benoit Regrain
2194 * Modification to compile with the distutils.
2197 2003-12-10 Benoit Regrain
2198 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2199 can use a gdcmHeaderHelper to load data
2200 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2201 made in the source code
2203 2003-12-10 Benoit Regrain
2204 * Update Windows projects and .cvsignore files
2206 2003-11-12 Jean-Pierre Roux
2207 * ENH gdcmHeader constructor has one more parameter (default value : false)
2208 that allows the user to 'go inside' the SeQuences only
2210 gdcmElValSet:Print takes it into account
2212 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2213 * ENH: Update gdcmPython/CMakeLists
2214 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2215 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2217 2003-11-10 Jean-Pierre Roux
2218 * FIX : gdcmHeader::LoadElements is now based
2219 on the ListTag listElem member,
2220 not longer on the TagElValueHT tagHt member
2221 * ENH : PrintPubElVal shows (temporarily) both results,
2222 with the tagHt member and the listElem member.
2223 (it's easier to 'see' the problems when using Printheader)
2225 * FIX : old private member LgrElem is now splitted into
2226 ReadLength : Length actually found on disk (updated only
2227 if bug fixing is necessary), for internal
2229 UsableLength : Updated by FixFoundLength, to fix a bug
2230 or to allow Parser going on.
2231 Will allow to re-write a kosher header when a SeQuence
2232 with a length (not 0000) is found
2233 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2234 because gdcmElValSet::Add does not update ListElem
2237 2003-11-07 Jean-Pierre Roux
2238 * FIX misstyping in Transfert Syntax name table
2239 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2240 when they have an actual length (not 0000 nor FFFFF)
2241 (Nobody should care of it, but DICOMDIR explorers)
2243 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2244 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2246 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * ENH: vtkGdcmReader now supports LUT !
2248 (vtkgdcmViewer for now is not able to use them though)
2250 2003-11-05 Jean-Pierre Roux
2251 * in testSuite.py : new files names for checking the package
2252 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2253 that returns the pixel area size to the *aware* (vtk) user
2254 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2256 2003-11-05 Benoit Regrain
2257 * in testSuite.py : Modify the rules for checking the paths
2258 : Explicit error messages
2259 * in __init__.py : Related modif
2261 2003-11-03 Jean-Pierre Roux
2262 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2263 to be used by aware (vtk) users that want to manage
2264 LUT (and no to turn the PALETTE image into an RGB pixels one)
2265 * GetPixelType now returns 8U for 24 Bits images
2266 (vtkGdcmReader compliant)
2268 2003-10-31 Jean-Pierre Roux
2269 * Removal of *all* gdcmData images and add them again
2270 in order to loose the 'history' of un-anonymised images
2272 2003-10-31 Jean-Pierre Roux
2273 * RMV : removal of useless jBitsInJsample.h
2274 for both 8 and 12 Bits JPEG Lossy Libraries
2276 2003-10-31 Jean-Pierre Roux
2277 * ENH : Add the functions gdcmFile::GetImageDataRaw
2278 gdcmFile::GetImageDataIntoVectorRaw
2279 that act as GetImageData and GetImageDataIntoVector
2280 except the making of an RGB Plane from Gray Plane + LUT
2281 Intended to aware (vtk) users who know how to manage
2284 GetLUTRGBA return a R,G,B,A LUT if any
2285 lgrTotaleRaw gives the 'Raw' length
2286 GetImageDataRaw returns the gray Plane
2287 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2288 (They stay Grey, just like with other Dicom viewers :-(
2290 2003-10-30 Jean-Pierre Roux
2291 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2293 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2295 being coherents dicom files.
2297 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2300 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2301 * ENH: Two steps is necessary to please VC++ compiler...
2302 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2303 * ENH: Add include dir to medcon lib
2304 * FIX: only one function is being exported for now !
2305 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2307 2003-10-29 Jean-Pierre Roux
2308 * adding gdcmHeader::GetLUTRGBA
2309 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2310 --> Mathieu, the modif u're waiting for is not yet committed
2311 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2313 2003-10-27 Jean-Pierre Roux
2314 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2315 00191113.dcm DermaColorLossLess.dcm
2316 MxTwinLossLess.dcm RadBWLossLess.dcm
2317 * ENH: For version prior to vtkImageViewer2 -r 1.19
2318 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2320 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * Removal of ido stuff in CMakeLists.txt
2323 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2325 * FIX: remove a call to ->Modified ... see comments
2326 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2328 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2329 * FIX: Problem with path for libvtkgdcmPython
2330 * ENH: Try adding a search script for python site-package
2331 * RMV: Remove some file from medcon lib that are not necessary
2332 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2333 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2334 * FIX: More pragma disable fro VC++,
2335 I don't think I break something as it is also disable in VTK/ITK.
2336 But it fasten debug compilation time.
2338 2003-10-23 Jean-Pierre Roux
2339 * gdcm now deals with 16 Bits Run Length Encoded images
2340 (they are compressed as 2 planes images,
2341 one for the high Bytes, the other for low Bytes)
2343 2003-10-22 Jean-Pierre Roux
2344 * Now CheckRead takes into account :
2345 - the bugged 'Leonardo' Siemens images
2346 - the XA images, sent thru the burning VPRO station
2347 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2350 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * FIX: When copying a Makefile.am to CMakeLists.txt
2352 one should remove the '\'
2354 2003-10-22 Jean-Pierre Roux
2355 * in gdcmData adding a bugged 'Leonardo' Siemens image
2356 (wrong lengths in header)
2357 OK with gdcm, KO with the other viewers :-)
2358 * add a GE dlx XA image, thru the VEPRO burning station
2361 2003-10-21 Jean-Pierre Roux
2362 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2363 for a brutal checking of vtkgdcmViewer compliance
2365 2003-10-21 Jean-Pierre Roux
2366 * add the files for 'xmedcon' Jpeg Lossless library
2367 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2369 2003-10-21 Jean-Pierre Roux
2370 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2372 2003-10-21 Jean-Pierre Roux
2373 * garbage Siemens 'Leonardo' images dealt with
2374 (the patch is easy to remove)
2375 * cosmetic changes to avoid warnings
2377 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2379 no need to press 'r' now.
2381 2003-10-20 Jean-Pierre Roux
2382 * upgrade of checkRead.sh checkWrite.sh according
2383 to new Jpeg Lossless decompressor
2384 * add US.3405.1.dcm, a genuine RGB medical file ...
2385 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2386 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2388 2003-10-15 Jean-Pierre Roux
2389 * general anonymisation in gdcmData
2390 * adding the 'color files' from
2391 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2392 * adding some well knowed bugged-header images
2393 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2394 waiting for their inclusion in Python testsuite
2396 2003-10-15 Jean-Pierre Roux
2397 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2398 no longer seg faults when file is not found
2400 2003-10-14 Jean-Pierre Roux
2401 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2404 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * TODO: *.in file to genereate a UseGDCM later
2407 2003-10-14 Jean-Pierre Roux
2408 * Some supposed-to-be Dicom Images have no preamble.
2409 OpenFile takes it into account
2410 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2411 * Missing elements added in dicomV3.dic
2412 (just to be affraid : have a look at
2413 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2414 and do it again next year ;->
2416 2003-10-13 Jean-Pierre Roux
2417 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2418 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2419 But there are NOT. It's fixed !
2421 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2422 * FIX: "jpeglib.h" was not found on VC++
2423 * FIX: vtkgdcm was not being installed
2425 2003-10-10 Jean-Pierre Roux
2426 * ENH : OpenFile closes the file if it *really* doesn't look like
2427 an ACR-NEMA / DICOM one.
2428 * FIX : testWrite no longer writes an empty file if the source file
2429 is not gdcm Readable
2430 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2433 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2434 * FIX: CMake generate now documentation
2435 * ENH: out of source doc build !
2436 * ENH: Generate both user and dev documentation
2437 * ENH: Should work on windows too
2438 * ENH: Only one doxygen config.in file is needed
2439 * FIX: make install should be ok now on ùnix plateform
2440 * FIX: PATH to dictionary was wrong (missing /)
2441 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2443 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2444 * vtkGdcmReader is now able to read rgb dicom file.
2445 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2446 * added a gdcmViewer to vtk test, use mouse to control
2447 window level & window width
2449 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * CMake-ification of gdcm, we have now two build system
2451 * FIX: on cygwin Wsock32 doesn't exist
2452 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2454 2003-10-06 Emanuel Ollart
2455 * FIX : compilation process wad broken.
2456 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2458 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2459 * change gdcmViewer -> vtkgdcmViewer
2460 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2462 2003-10-06 Jean-Pierre Roux
2463 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2464 ( e.g : well known GE images with a wrong elem length,
2465 : Philips MRI Images with a wrong Huffman table)
2466 * still to be done : allow the reading of bugged LEONARDO Siemens images
2468 2003-10-03 Jean-Pierre Roux
2469 * Odd length strings are padded with '\0' (not with spaces,
2470 to remain compliant with already defined strings,
2471 like Transfert Syntax UID and others)
2473 2003-10-03 Jean-Pierre Roux
2474 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2475 to allow displaying RGB images (not only by affim ;-)
2477 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2478 * vtkGdcmReader is now able to read rgb dicom file.
2479 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2481 2003-10-03 Jean-Pierre Roux
2482 * A few nasty patches to allow the reading of a lot of nasty images
2483 ( e.g : well known GE images with a wrong elem length,
2484 : Philips MRI Images with a wrong Huffman table)
2485 * still to be done : allow the reading of bugged LEONARDO Siemens images
2487 2003-10-03 Jean-Pierre Roux
2488 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2490 2003-10-03 Jean-Pierre Roux
2491 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2492 to allow displaying RGB images (not only by affim ;-)
2494 2003-10-03 Jean-Pierre Roux
2495 * gdcmFile::GetImageDataIntoVector now
2496 - deals with MultiFrames MultiFragments Run Length Encoded files
2497 - deals with YcBcR (YBR_FULL) files
2498 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2499 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2501 (no sample found :-(
2503 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2505 Two reasons: - clear things
2506 - third parties acces gdcm through header files, so won't
2507 suffer anymore VC++ complains
2509 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2510 * add argv[1] in testvtkGdcmReader.cxx
2513 2003-09-24 Jean-Pierre Roux
2514 * The lines are now eigthy characters long.for
2515 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2517 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2518 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2519 char* to std::string. Thus, the use of strdup becomes useless. (see
2520 previous commis of Malaterre)
2521 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2522 before the last Malaterre's commit.
2524 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2525 * This commit should fix the Debug building under VC++, the problem
2526 was mainly a mixture of debug and release lib being loaded at startup.
2527 * I also remove a depency to a specific C function: strdup. Because I had
2528 to force the link to msvcrtd (whereas strdup is in libc).
2530 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2531 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2532 located in the gdcmCommon.h file. All use of reference of tha has been
2533 changed to now use the variable GDCM_UNFOUND.
2535 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2537 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2538 Dicom dictionary. The test suite can now be run again. Note:
2539 I'm note very happy with the " (RET)" changes. I believe this
2540 RETAINED comment should be dropped when parsing the dictionary.
2541 - PACKAGER corrected
2543 - AUTHORS updated and now in alphabetical order
2544 * Makefile.am now exports gdcm.dsw for Windoze users.
2546 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2547 * cygwin complains about missing std:: in subdir Test/
2549 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2550 * remove some methods that are now in gdcmHeaderHelper
2552 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2553 * vtkGdcmReader set spacing and origin correctly
2555 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2556 * Fix a few delete/delete[] mismatch
2558 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2559 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2560 interpretation to data given by gdcmHeader. For instance there are
2561 heuristics to get informations (look at different places).
2562 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2563 sorting DICOM images based on different strategies.
2564 * modified Makefiles accordingly.
2566 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2567 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2568 when building in debug mode
2569 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2570 src/win32/gdcmdll.dsp
2571 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2573 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2574 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2577 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2578 * src/win32/libgdcmjpeg12.dsp was not dos format
2579 * src/win32/libgdcmjpeg12.dsp :
2580 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2581 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2583 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2584 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2586 * src/gdcmFile.cxx : bug fix in affectation type
2587 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2588 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2589 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2590 symbols... future problem ?
2592 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2593 * src/win32/libgdcmijpeg12.dsp was missing
2594 * modified gdcm.dsw accordingly
2596 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2597 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2599 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2600 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2601 commit of JPR (before his hollidays to facilitate our work).
2602 * setup.py : bug fix in code. Modifications made while the last commit
2603 of JPR. The code hasn't been tested before the commit... it's so
2604 useless to make that (for best programmer that is JPR) !!!
2606 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * tagged the current version as Version0_3 (i.e. version 0.3)
2609 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2610 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2611 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2612 * *.dsp : modifications to use new libgdcmijpeg8 library
2613 * setup.py : bug fix on VTKPATH variable
2614 * PACKAGER : adding all concerning windows
2616 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2619 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2620 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2621 test suite reported error.
2622 * PACKAGER file added (describes what a packager must do when
2623 packaging a new release).
2624 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2625 * configure.in: upgraded version number to 0.3.0
2626 * fixing build of rpm (through rpm -ta):
2627 - Doc/Makefile.am exports proper doxygen files
2628 - src/jpeg/libijg8/Makefile.am exports the include files.
2630 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2631 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2632 * src/gdcmHeader.h : formatting code
2634 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2635 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2636 We were obtaining error message from vtk. Now, creation of file list
2637 is made in an internal list to prevent this problem.
2638 Bug fix when output is empty.
2639 Bug fix in update of progress value. Previous commit for this was a bad
2641 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2643 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2644 * src/gdcmHeader.h : added method to get the file name
2645 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2646 files. Added method to remove all files on the input
2647 Added FIXME comment concerning the bad parsing of header made by
2648 ExecuteInformation method (in ExecuteData method)
2650 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2652 when using make instal.
2653 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2654 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2656 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2657 * setup.py : adding include dir of jpeg lib to compile all sources
2658 * */Win32/*.dsp : JPR fix for windows compilation
2660 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2661 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2663 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2664 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2666 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * setup.py is again effective on un*x (takes into account the
2668 addon of the jpeg library)
2669 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2670 * Doc/Doxy* updated (includes above enhancements)
2671 * INSTALL now points to web documentation
2673 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * src/gdcmHeader.h doesn't make unnecessary reference to
2676 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2678 * src/gdcm*.[cxx|h] :
2679 - to allow compilation with gcc 3.x
2680 -- clean up of STL usage (added explicit usage of std::)
2681 -- small fixes on exceptions.
2682 Note: linking not tested !
2683 - clean of doxygen comments to avoid warnings at documentation
2685 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2686 dependent convertion).
2688 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * Clean up of previous JPR garbage commit (not even commented in the
2691 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2692 - moved all jpeg related files from src to src/jpeg/libijg8, with
2693 addition/modification of Makefile.am and configure.in.
2694 - the testSuite is still brain damage (not guilty).
2696 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2697 * WrapVTK.py : modifications to get correctly vtk source files to
2699 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2700 (FileName -> Filename)
2702 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * vtk/vtkGdcmReader.[cxx/h]:
2704 - UpdateProgress method should now be effective
2705 - removed the limitation on having only images loaded (as opposed
2707 - when building a stack of images/volume, a lesser number of
2708 gdcmHeader and gdcmFile instances should be used (hopefully
2709 accelerating things).
2710 - when building a stack of images/volumes, files which are not
2711 loadable (wrong path-filename, wrong permissions on existing file,
2712 or file not parsable by gdcm) are replaced with a black image
2713 in the stack (for the caller to notice the problem).
2715 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2718 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2719 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2720 between standard library (std) and vtk library (problems are found
2721 under Windows... thanks Windows !)
2723 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2726 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2728 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2731 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2732 * When compiling with distutils (see setup.py) the C++ compiler is
2733 called with different flags than the default ones (with automake).
2734 In order to fix all those warning, I compiled gdcm with the command
2735 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2736 and went for warning fixes:
2737 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2738 up from unused variables.
2739 - vtk/vtkGdcmReader.cxx: potential bug fix.
2740 * src/gdcmHeader.h: Doxygen warning cleanup
2742 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * gdcmPython/gdcm.i:
2744 - typemaps correction to take into account the systematic replacement
2745 of "using namespace std" with std:: prefix e.g. std::list,
2746 std::string... (cf changes of 2003-05-21).
2747 - gdcmGlob global variable of type gdcmGlobal (defined in
2748 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2749 exported to Python a as cvar.
2750 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2751 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2752 gdcmDictSet.GetPubDictTagNames() and
2753 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2754 C++ static methods).
2755 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2756 with the above changes.
2758 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2759 * setup.py, manifest.in : bug fix under linux
2761 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2762 * Modification of setup.py to compile vtk part too. Then, we have 2
2763 wrappers which must work with same distutils. For that, we have a
2764 generic distutils in distusiltsWrapping.py ; with :
2765 - build_extWrap class to wrap generically all extensions,
2766 - ExtensionWrap base class for all wrapping extension that contains
2768 - Wrapper interface which wrap sources
2769 + In WrapSwig.py we have extension and wrapper for Swig
2770 + In WrapVTK.py we have extension and wrapper for VTK
2771 * MANIFEST.in : modifications to consider vtk directory and new python
2772 files for compilation
2774 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2775 * Added python wrappers of vtkGdcmReader vtk class (see the
2776 source in vtk/vtkGdcmReader.cxx) :
2777 - vtk/Makefile.am now builds a library
2778 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2779 python library (as opposed to _gdcm.so wich are the python
2780 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2781 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2783 - configure.in has an additional flag --enable-vtk that needs
2784 to be set to enable compilation of vtk related code, that is:
2785 + vtk/vtkGdcmReader.so and
2786 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2787 + gdcmPython/vtkgdcmPython.so (see above)
2788 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2789 be read when compressed or when HighBit + 1 != BitsStored),
2790 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2791 the usage of the python wrapper of vtkGdcmReader vtk class.
2792 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2793 * src/*.[h] all occurences of stl classes are now prefixed with
2794 std::, and all occurences of "using namespace std;" where removed.
2795 This is to avoid pollution of global namespace in included files.
2796 Apparently vtk does not avoid this pitfall: when using both
2797 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2798 collision of various stl members (principally cout...).
2799 * gdcmPython/testSuite.py now cleanly removes temprory generated
2801 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2802 comply with above changes)
2804 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2805 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2806 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2807 vtk data structure (an image Flip was required).
2808 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2809 * cosmetic changes in documentation.
2811 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2812 * src/gdcmHeader.cxx: the constructor no longer exits when an
2813 unexisting file is given as argument.
2814 * The subdirectory Data (containing all the images used for the
2815 test suite) is not part of this repository anymore. A new module
2816 containing those images is now available at
2817 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2818 with the name gdcmData.
2819 All the python scripts (including the package initialisation file
2820 gdcmPython/__init__.py) were adapated to take this change into
2821 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2823 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2824 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2825 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2826 demo of the usage of this class.
2827 Compilation of this vtk part is only done when using the --enable-vtk
2828 at configure (or autogen.sh) stage.
2830 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2831 * More memory link related corrections and documentation fixes.
2833 - maximum info is obtained with a command of the form:
2834 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2835 --show-reachable=yes PrintHeader
2836 - the remaining reachable blocks seem to come from the STL
2837 allocation scheme through the usage of map and list. It looks
2838 like this memory cannot be freed but it is not a memory leak
2839 (in fact further invocation to the STL would recollect the
2840 unused memory allthough it cannot explicitely be freed).
2841 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2842 of displaying an image parsed with gdcm and displayed with VTK.
2843 Note: some images don't seem to work e.g.
2844 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2845 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2846 Allthough this weakens the semantics, it is a ditch attempt to
2847 make gdcm more thread friendly.
2849 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2850 * Memory link hunt (by using valgrind through the command
2851 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2852 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2853 gdcmHeader::_dicom_vr.
2854 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2855 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2857 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2859 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2860 * src/Makefile.am now exports all the necessary include files at
2864 * UpdateGroupLength replaced by new one
2867 * UpdateGroupLength re-written using H-Table
2868 (named UpdateGroupLengthNew untill checks are over)
2870 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2871 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2872 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2874 - gdcmHeader::GetPubElValSet removed.
2875 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2876 UpdateGroupLength, WriteElements, Write.
2877 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2878 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2879 carried the same semantics.
2880 - src/gdcmHeaderIdo.cxx changed accordingly.
2881 - gdcmFile::WriteBase now regroups all the codes from previous
2882 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2883 - enum FileType moved to gdcmCommon.h
2884 * src/gdcmHeader.cxx AddDefault trashed
2885 * gdcmGetXSize added
2886 * getimageDataSize now calls gdcmGetXSize
2887 * Test/*.cxx changed to agree with above changes
2889 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2890 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2891 (to avoid double call by end user).
2892 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2893 by end user, since gdcmHeader::gdcmHeader now handles it.
2895 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * gdcm/Doc many doxygen changes:
2897 - Doxyfile now has two different versions, DoxyfileUsers that generates
2898 the html.users end users oriented documentation and
2899 DoxyfileDeveloppers that generates the html.developper developper
2900 oriented documentation.
2901 - README changed accordingly
2902 - requirement.txt removed (old design info moved to TODO).
2903 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2904 DoxyMainPage.txt, DoxyPython.txt provide more information.
2905 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2906 be updated by simply regenerating the docs with doxygen and copying
2907 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2908 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2909 all the tests in the form "if (<map>.count() >1)" were removed.
2910 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2911 ill-formed documentation sections.
2912 * src/gdcmHeader.cxx: ditto
2914 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * setup.py fixed for un*x (needed macro for stdint.h)
2916 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2917 un*ces with sh-utils test utility.
2918 * gdcmPython/demo/test.py renamed to PrintHeader.py
2919 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2920 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2921 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2922 * src/gdcm*.cxx JPR's bad inclusion fixed.
2924 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2926 * gdcmPython/demo/test.py changed accordingly.
2928 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * gdcmPython/Makefile.am fixed linking against libstdc++
2930 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2931 * Swig subdir (historical tests of swig version 1.3.17++) removed
2932 * Test/testChangeEntete.cxx some lines commented out in order to make
2934 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2935 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2937 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2938 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2939 hence the user doesn't need this explicit call.
2940 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2941 i.e. LoadElements() call removed.
2942 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2943 - src/Makefile.am declares the proper flag for g++.
2944 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2945 for adding user defined new tags.
2946 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2947 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2948 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2950 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2951 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2952 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2953 src/Makefile.am : the project should properly compile and install
2954 with the autotools, included the python wrappers part.
2955 * gdcm.spec.in : added a spec file for RPM packaging.
2957 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2958 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2960 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2962 to exported to the environement (see gdcmPython/testSuite.py
2964 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2965 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2966 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2967 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2968 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2970 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2971 * gdcmPython/__init__.py doesn't crash anymore when running in
2972 in InstallMode or PreInstallMode but with an environment given
2973 value of GDCM_DICT_PATH.
2974 * src/gdcmDictSet.[cxx/h] coding style.
2976 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2977 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2978 * src/gdcm.h general comments moved to TODO, and README
2979 * src/gdcm.h should now be seen as a user commodity (including it
2980 should suffice to fully use gdcm). It is nowhere including within
2981 any of the kernel files src/*.cxx and src/*.h.
2983 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2985 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2987 * src/gdcm*.cxx only include their corresponding include file
2988 (as opposed to gdcm.h)
2989 * gdcmPython/gdcm.i changed accordingly
2990 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2991 the autogen.sh generated "make snapshot" command to work.
2992 * autogen.sh removed history related references to crea package.
2994 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * distutilsSwigCPlusPlus.py work around some swig portability
2998 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3000 was done in a last ditch attempt to get setup.py _really_
3001 operationnal. The python/gdcmPython layaout add the advantage
3002 of hidding away the python related distutils specific files
3003 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3004 Alas, the src directory was out of scope (i.e. it's relative
3005 position to setup.py was ../src) which made things impossible to
3006 handle (see previous version of python/setup.py). Crossing fingers...
3008 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * python/setup.py now works on Un*x. (harder than I thougth)
3010 * python/distutilsSwigCPlusPlus.py can now have include files
3011 among the list of sources.
3013 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3014 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3015 * modifications in MSVC projects
3017 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * As stated by the first lines of Test/ExceptionAndPython/README, it
3019 looks like we can move back to original usage of exception within
3020 src/gdcm* and hence remove the errno stuff that was introduced
3021 as a quick and dirty fixture of this problem (added to the TODO).
3022 * Doc/Doxyfile configuration file for Doxygen and corresponding
3023 README file for usage added.
3024 * Test/testWrite.cxx added. This new test comes from a split of
3025 test.cxx that is now reverted to its original purpous i.e.
3026 testing the proper parsing of a Dicom related file.
3027 testWrite.cxx concentrates on testing the IO part of gdcm.
3028 * Test/bug1.cxx (containing a bug on WIn32) added.
3029 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3030 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3031 whose purpose is to publish the content of the TagNames of the
3032 Dicom public dictionary were not accessible without an
3033 instance of class gdcmHeader.
3034 - those methods are now static methods of gdcmDictSet and hence
3035 require no instances at all to be invocated.
3036 - within gdcmDictSet this change required to change some method
3037 to class methods (i.e. are now static) among which SetDictPath
3038 (renamed to BuildDictPath) and LoadDefaultPubDict.
3039 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3040 the above changes by calling the new method classes of gdcmDictSet.
3041 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3042 the above to be effective.
3043 * python/gdcmPython: in order to wrap properly the above changes
3044 for Python, swig version now needs to be > 1.3.17.
3045 * python/gdcmPython/Makefile fixed to adapt itself to new
3046 configure/make shema introduced by Johan Montagnat (thanks for the
3047 contribution). Alas this Makefile cannot be turned into a proper
3048 Makefile.am without some heavy changes in the configure.in
3049 (for python dectection).
3050 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3051 now avoids publishing the empty entries.
3053 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3054 * python/setup.py : bug fix concerning install under windows
3055 ExtraPath reused :-P
3056 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3058 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3059 * Dicts/dicomV3.dic : remove double spaces !!!
3060 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3061 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3064 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3066 method. Doxygenation.
3067 * src/gdcm.h clean up of JPR spurious comments.
3069 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * python/distutilsSwigCPlusPlus.py now properly collects the
3071 shadow classes generated by "swig -c++" (gdcm.py in our case)
3072 when using "python setup.py install".
3073 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3074 reexports the working classes.
3075 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3076 by the classical C errno scheme. This is to prevent an obscure
3077 behavior of the python wrappers when importing wxPython.wx prior
3078 to gdcmPython (which ended up in an abort call). An illustration
3079 of this oddity can be found in the Test/ExceptionAndPython
3080 subdir (see the README file). This problem probably due to
3081 an combination of g++ and dynamic loading.
3082 * added Test/ExceptionAndPython (see above)
3084 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3085 * Changed the layout of the python part to avoid bloating main
3086 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3087 i.e. the distutils arsenal. All the python related stuff is
3088 again in a python subdir, but the package itself is now in
3090 * setup.py was cleaned up:
3091 - pythonIncludePath removed
3092 - python setup.py bdist target is now functional.
3093 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3094 collision with other packages). gdcmPython/demo/*.py changed
3097 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * python subdir moved to gdcmPython (preparation of distutils packaging).
3099 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3100 distutils installer is operational.
3101 * - gdcmPython/__init__.py now properly loads the swig generated
3102 shadow classes (from gdcm.py).
3103 - gdcmPython/demo/*.py changed to import the package gdcmPython
3104 instead of gdcmPython/demo/load.py.
3105 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3107 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3109 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3110 entries within the associated public Dicom dictionary resp. the same
3111 information but sorted by the fourth field (PAT, IMG, DIR) of the
3113 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3114 are now in the "???" group.
3115 - python/gdcm.i changed accordingly,
3116 - python/demo/printGroupedPublicDict.py added, that gives an example
3117 of the above new functionalities in Python.
3119 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * src/gdcm.h, gdcmHeader.cxx:
3121 - historic references to glib's g_malloc and g_free (#defined)
3122 were definitively removed.
3123 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3124 * src/gdcmElValSet.cxx:
3125 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3126 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3127 - GetElValue(string) renamed to GetElValueByName.
3128 - Added GetElementByName(string).
3129 * src/gdcmHeader.cxx: added
3130 - GetPubElValRepByNumber(guint16, guint16)
3131 - GetPubElValRepByName(string)
3132 - GetShaElValRepByNumber(guint16, guint16)
3133 - GetShaElValRepByName(string)
3134 - GetShaElValByNumber(guint16, guint16)
3135 - GetShaElValRepByName(string)
3136 - GetElValRepByNumber(guint16, guint16)
3137 - GetElValRepByName(string)
3138 - GetElValByNumber(guint16, guint16)
3139 - GetElValRepByName(string)
3140 * Doc/requirements.txt added.
3142 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3143 * Test/Makefile building now depends on the one of libgdcm.so
3144 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3145 pixel data) aware which enables finding the address (offset) of
3146 the pixel data of JPEG encoded DICOM files. This leaves only a single
3147 file in the testSuite whose pixel data address (offset) is unknown.
3148 * python/testSuite.py changed accordingly.
3150 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3151 * VC++ has some strong limitations when working with the STL, as stated
3152 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3153 "Also note that some STL containers (map, set, queue, list, deque)
3154 cannot be exported. [...]
3155 Some STL classes contain nested classes. These classes can not
3157 This is caused by a designed limitation that once a template
3158 class is instantiated, it can not be re-instantiated and
3160 Since our usage of map<> is ubiquitous in gdcm, this "designed
3161 limitation" of VC++ is a pitfall.
3162 Hence the Python wrappers of gdcm cannot be incrementally linked
3163 against the c++ dynamic library. The dirty but only workaround is
3164 to forget about incremental link of dynamic libraries and to generate
3165 the Python wrappers library with the inclusions of the underlying C++
3167 The following modifications concern this matter on Win32/VC++:
3168 - wrapping python correct with standalone wrapped dll (don't use separate
3169 dll under windows !!!!)
3170 - python21_d debug mode enabled (ask Frog how to use it :-)
3171 - NO problem with having an STL member of class for example string in C++
3172 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3173 - Python test of dcmlib in Python is ok under windows on a large set
3175 * removed glib references
3176 * typedef's inserted in gdcm.i for correct swig type management
3178 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3179 * python/demo/*.py load.py extracted from test.py. Added explore.py
3180 that only displays required tags and testAll.py that parses all
3181 the files of the testsuite without using unittest.
3182 * python/testSuite.py other additional test on new files added.
3183 * Data/* new test files added accordingly to the testSuite.
3184 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3185 the vr in the file differs from the one of the dictionary.
3187 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3189 values, but limits itself to values which are below a user specified
3190 size (by default 1024 bytes).
3191 * python/gdcm.i : elements not loaded (because their size is above the
3192 user specified treshold) are exported with their TagKey as key of the
3193 python dictionary. This enables the testsuite to make some checks
3194 on the unloaded elements (since we have their offset and size).
3195 * python/testSuite.py
3196 - now tests for the existence and proper value of the pixel data
3197 - two new examples added.
3198 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3200 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3202 aware. See the strategy comments in gdcmHeader::FindeLength().
3203 * Test/test.cxx now accepts a filename as first argument.
3204 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3205 * python/testSuite.py changed to integrate test on above files.
3207 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3208 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3209 the vr was also RET.
3210 * python/testSuite.py more tests added.
3212 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3213 * python/testSuite.py unittest test suite added (uses Data)
3214 * Data/* dcm and acr files for the test suite.
3215 * glib dependance removed from un*x version. We now use ISO C99
3216 7.18 Integer types (see stdint.h)
3217 - python/Makefile, src/Makefile src/gdcm.h
3218 * src/ when an explicit vr (like dicom files) suddenly poped an
3219 implicit element we use to mark the underlying DictEntry of the
3220 concerned ElValue with "Implicit". This strategy was damageable
3221 too the public or provite dictionaries, since some of their vr
3222 would be changed. Since Header::FindLength heavily relies on the
3223 detection by Header::FindVR of falsely explicit elements, I
3224 added an extra ImplicitVr member to ElValue (boolean).
3225 The rest of the changes we the necessary adaptations.
3227 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3230 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3232 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3233 * Adaptation for porting to VC++:
3235 o forced to use std namespace (for string to be known)
3236 o all class use __declspec export style on WIN32
3237 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3238 (in stdlib.h on Win32 but in std:: for gcc)
3239 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3240 variable GDCM_DICT_PATH.
3241 * src/gdcmHeader.cxx verbose comments made discrete.
3243 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3244 * python/gdcm.i: added a typemap that converts a C++ hashing table
3245 to native Python dictionary.
3246 * python/demo/test.py:
3247 - now uses the native dictionary for exploration of gdcmHeader.
3248 - takes an optional filename argument (the file to parse).
3249 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3250 PubElVals hashing table.
3251 * Dicts/dicomV3.dic removed error prone trailing spaces.
3253 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3254 * Python wrapping process moved away from src/Makefile to
3255 newly created python/Makefile (as well as gdcm.i)
3256 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3257 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3258 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3259 from the environement variable GDCM_DICT_PATH (when existing).
3260 * src/gdcmDict::GetTag bug fix.
3262 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * Straightforward temporary fixes for swig to build the python wrappers.
3264 src/Makefile now has a python working entry [by working we mean
3265 that we can import de shadow classes without errors].
3267 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3268 * hashtest.cxx removed (since already in Test)
3269 * src/gdcmlib.h renamed to src/gdcm.h
3270 * src/dcm.i renamed to src/gdcm.i
3271 * src/Makefile prepared for python wrapping
3273 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * src/gdcmHeader.cxx :
3275 - Parsing of header is now separated from loading of element values
3276 (see gdcmHeader::LoadElements).
3277 - general clean up of hopefully all file access (creation of
3278 ReadInt16 and ReadInt32)
3280 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * src/gdcmHeader.cxx :
3282 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3284 - SetLgrElem renamed to SetLength
3285 - GetLgrElem renamed to GetLength
3286 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3287 * src/gdcmElValSet.cxx fixed both GetElValue methods
3288 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3289 due to IdoDude was cleaned out.
3291 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3293 concentrates on finding the value representation (when it exists).
3294 RecupLgr now only finds the element value length, and it avoids
3295 returning the unecessary skL (skipped length).
3296 Also, offsetCourant was simply removed (with taille_fich) since
3297 it was redundant with the File position internals (by using
3298 ftell and fseek). This also made skL (see above in RecupLgr) usage
3300 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3301 on the libido specificities which are handled through class
3303 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3306 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3307 * Truckload of changes. Parsing of header is barely functional
3308 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3310 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * src/gdcmHeader.cxx many addons of low level methods
3313 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3314 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3315 and _IdDcmSWAP_LONG.
3317 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3318 * This corresponds to all the changes decided at the meeting of
3319 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob