1 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/ : accelerate tests (it's not very significant accelerations).
3 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
5 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Testing/TestSequence.cxx : add test for sequences of images... test that
7 we have the same serie or the same study UID
9 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
12 * src/gdcmDict.h : remove commented code
13 * src/gdcmDocument.cxx : initialize values
14 * src/gdcmFile.cxx : bug fix when reading values
15 * gdcmPython/demo/ : change file names. Remove useless files
17 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmFile.cxx : remove the default array of initialization.
19 The static array contained pointers to non-static values (comming from
20 strings). To have coherences, when creating files, these values can't be
21 static. So, the array can't be static, too ! To simplify, the array have
22 been replaced by repeted lines to insert values in the File
24 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
26 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
28 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
29 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
30 (Dicom Element) into the Sequence Item
32 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/*.cxx : first parss to normalize file organisation
35 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmDirList.[h|cxx] : add method to find a directory
37 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
39 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Finish cleaning up my JPEG mess. Should be ok now.
41 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
42 contained within the RLE* class(doh!)
44 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
46 * SerieHeader::AddFileName() creates as many Coherent Files lists
47 (same Serie UID) as it founds different Serie UID
48 amongst the files instead of discarting any file
49 that doesn't match with the first one he found.
50 * SerieHeader::OrderGdcmFileList has now one parameter :
51 the Coherent Files list the user wants to sort
52 * SerieHeader::GetFirstCoherentFileList() |
53 * SerieHeader::GetLastCoherentFileList() | allow to parse
54 the set of Coherent Files lists
55 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
56 compatibility (it returns the *first* Coherent Files list,
57 since there was only one before)
58 * Test/TestSerieHeader gets gdcmData as a default root directory
60 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * Remove friend between DocEntry and File classes
62 * Remove friend between PixelReadConverter and RLEFramesInfo,
65 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
67 0002|0000. The value was incorrect.
69 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
72 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmUtil.cxx : compilation fix on Win32
74 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
75 variable, to be easy found. Add methods to change the default UID.
76 Amelioration of the CreateUniqueUID to use the correct default UID.
77 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
80 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Test/TestVR.cxx : fix memory leaks
83 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
84 * Rewrite the base 256 to base 10 conversion, using string operation only.
85 This allows us to get rid of the problematic 64bits integer type (does not
86 always exist on target platform).
88 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
89 * Add construct and destructor to class gdcm::Debug to close the debug file
91 * Don't let uset to open twice the same file
92 * gdcm has now an official UID prefix,
93 supplied by http://www.medicalconnections.co.uk
94 1.2.826.0.1.3680043.2.1143
95 (Thx to Mathieu for providing URL)
96 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
97 to be able to perform some more tests
98 * gdcm::ContentEntry : Contructors and Destructor are now protected,
99 in order to be sure no user will try to use them.
100 (at user level, only the children classes are meaningfull)
102 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * move RLEInfo & JPEGInfo from Document to File
105 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * FIX : remove so many friend between classes
108 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
110 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
112 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
113 In order to avoid missbehaviour :
114 . gdcm::DocEntry is now specialized in
115 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
116 - gdcm::ContentEntry (Dicom entry with a 'content')
117 . gdcm::ContentEntry is specialized in
118 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
119 characters value, or integers)
120 - gdcm::BinEntry (Dicom entry with a non strig representable value
121 (user hasn't any longer to thing about the precedence of his dynamic_casts)
123 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * Test/VTKTest*.cxx : bug fix under linux
126 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
128 use with python. Some methods are moved from Document to ElementSet or
129 DocEntrySet. The equivalent methods to ElementSet have been added to
130 SQItem and are virtual in DocEntrySet. Methods that may have the same code
131 in SQItem and ElementSet is directly placed in DocEntrySet
133 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * Test/VTKTest*.cxx : remove the show variable in each test method because
135 it's useless (the viewer variable replace this variable)
137 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDocument.cxx : bug fix on potential memory leak
139 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
140 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
141 Add ClearXxx methods to remove all the content of the list or map
142 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
144 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
145 * methods ReplaceOrCreate renamed as Insert
146 (nobody will be any longer confused by 'CreateOrReplace')
148 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
149 * Grealty simplify the JPEg decompression, no need to differenciate based on
150 the JPEG possible type (with/without fragment, with/without multiple frame).
151 Everything is done throught the JPEG IO Suspension mechanism in IJG
153 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
154 * Stage 3 of normalization :
155 in order to avoid any missunderstanding while reading method names :
156 - All the methods xxxEntry now deal with dicom Entries
157 - Methods GetEntry splitted into
160 - Method SetEntry renamed as SetEntryValue
161 - Method SetEntryBinArea let as it was
163 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
165 - Position correctly the entry points for JPEG2000 and JPEG-LS
166 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
168 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
170 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
171 with other method names
172 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
173 * Test/TestDicomDirElement.cxx : add new test
175 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
176 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
177 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
178 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
179 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
180 So can't you use __int64 in ostream at all.
182 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * bug fix for compilation on MSVC6
184 * gdcmPython/gdcm.i : rename of classes missed
186 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
187 * Stage 2 of names normalization :
188 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
189 (easy to understand ...)
190 - gdcm::FileHelper replaces old class gdcm::File
192 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
194 type and not a string. So, there remove problems on the format of the
197 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
198 * Add Example/TestPapyrus.cxx
199 - reads a Papyrus file (gdcm::Header compliant),
200 - gets the pixels of all the images, using low level iterators
201 - writes an multiframes Dicom image.
202 (Just to show it's *possible* to do that)
203 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
206 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
208 Thus, DicomDirXXX are created with a flad that indicates if the created
209 object is empty or not (when not empty, the DicomDirElement is used to
212 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
214 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
216 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
219 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
221 Remove all access to the hash-tables or lists in the objects.
223 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
225 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
226 be complient with all the gdcm source code
228 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
232 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
236 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * Test/ : rename VTK tests to have a best name for the tests
238 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
239 GetFirstEntry/GetNextEntry use
241 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
242 * In SerieHeader::ImagePositionPatientOrdering()
243 // a Dicom 'Serie' may contain scout views
244 // and images may have differents directions.
245 // -> More than one may have the same 'pos'
246 // Sorting has then NO meaning !
247 Thx to Eduardo Davila for reporting bug.
249 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
251 test. Now it's on image content and not on the resulting visualisation...
252 might solve the problem on linux when using the OpenGL drivers
254 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
256 DicomDirSerie, DicomDirImage
257 Dict, DictSet classes :
258 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
259 -remove InitTraversal method.
260 * UPD Test programs + Example programs
262 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
263 * remove useless and never updated keyword \ingroup
264 * Solve pb when structure (list, map, ...) is empty.
265 Thx to Benoit for reporting bug
267 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
268 * Taking into account of 'Transfer Syntax' value
269 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
272 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
274 is no memory access violation
275 * gdcmPython/demo : add python demos using VTK
277 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
278 * FIX 'Dictionnary' is now spelt 'Dictionary'
279 'wether' is now spelt 'whether'
280 'archieve' is now spelt 'archive' ;-)
282 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
283 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
284 related methods, in order not to expose internal mechanisms
287 * REM methods that exposed internal mechanisms :
288 DicomDir::GetDicomDirPatients()
289 DicomDirPatient::GetDicomDirStudies()
290 DicomDirStudy::GetDicomDirSeries()
291 DicomDirSerie::GetDicomDirImages()
292 * UPD Test programs :
296 * UPD Example program
298 * ADD DictSet methods
302 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
303 * Removed the Print/indent/default parameter mess. There is absolutely no
304 reason to have to methods, moreover with the second taking the ostream as
305 *SECOND* parameter. This was clearly a bad hack to get things compile.
307 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
308 * Complete rewrite of the GetMacAddress code. Now the code is *much*
309 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
310 Unfortunately the main code does not work on SunOS, thus provide a specific
311 code for this platform only (and Win32 of course). Since this seems to be
312 working, change CreateUniqueUID to use GetMACAddress instead of the
313 problematic GctestetIPAddress
315 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Unfortunately to be able to test gdcmDirList I had to break the API
317 a little. Now the class is not a std::list anymore but has a member
318 std::vector (more ITK compatible). Allow unit testing on Win32 and
321 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Update SerieHeader to take into account a Serie Instance UID to properly
325 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
326 * ENH - Comment out Mathieu's (dangerous) Super Hack
327 for dealing with BIGENDIAN processors
328 - Move equivalent stuff to BinEntry::WriteContent
329 When necessary, 16 Bits Pixels are swapped in a small buffer
330 and then written. This avoid allocating a huge buffer, in
331 PixelWriteConvertor, and avoid modifying the Pixel Area.
333 Probabely, the same operation will have to be done when we want
334 to write image with Big Endian Transfert Syntax,
335 and we are working on Little Endian Processor
337 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
340 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
341 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
342 all the dict content.
343 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
345 * Test/TestDict.cxx : add a new test for the dict classes
347 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
348 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
349 file. Debug is yanked if compiled with NDEBUG
351 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmDictSet.h : set the default output to the os variable
353 * src/gdcmDictEntry.[h|cxx] : add the Print method
354 * gdcmPython/demo/ : add a new test
356 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
357 * merging of Test/PrintDicomDir and Test/TestDicomDir
358 * removal of now redundant Test/PrintDicomDir
359 * enhancement of Example/PrintDicomDir
361 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * Now, python test might work on systems
363 * Add the PrintDicomDir test
365 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
366 * FIX : First entry following group 0002 was lost for
367 Explicit Big Endian Transfer Syntax files
368 (group and elem not swaped)
370 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
371 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
372 Big Endian Transfer Syntax supposed the group following 0002
373 begins always by element 0000 (element 0000 is *optional*)
374 To avoid further troubles, let's be pessimistic, and use
375 Document::HandleOutOfGroup0002() method
376 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
377 (related pb not yet solved)
379 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * Bug fix for the python part use
381 * Now, PrintHeader.py pass... but outside the ctest use. shit !
383 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
386 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
388 a string and should ask the global TS dict what are the propreties of
391 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
392 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
393 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
394 to swap the Swap Code, at parsing time, when we come out of group 0002
395 and Transfer Syntax is Big Endian
396 We should be able to read now 'true DICOM" Big Endian coded images
397 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
398 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
400 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * Hopefully fix the bug on MacOSX and static global initialization.
402 This is the only -minor- patch I found that both please MacOSX and VS6.
403 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
404 but this would require a lot of change. Another approach would be that Global
405 create those string and GDCM_UNFOUND becomes a pointer to a string (which
406 gdcm::Global would destroy at exit).
408 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
409 * Fix bug on MacOSX with static initialization in a multy threaded
410 environment. static const string in a header file used to be ill
411 initialized provoquing the freeze of any tests. patch should solve this
414 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
415 * According to Benoit's suggestion, and without any objection from anybody
416 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
417 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
418 - method gdcmDicomDirObject::GetEntry() renamed as
419 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
421 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
422 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
423 you debug/warning message just as c++ streams which make them very convinient
424 to use. Once this is stabilize I will change the ostringstrem to be
425 redirected to a file (ofstream).
426 * Properly support C99 extension: __FUNCTION__ which allow us to display
427 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
429 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
430 * Removal of useless and dangerous methods :
431 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
432 GetDocEntryByName, GetEntryByName, GetDictEntryByName
433 * Removal of usless methods :
434 Dict::PrintByName, Dict::GetDictEntryByName
435 * Commenting out of probabely useless methods :
436 Dict::GetDictEntryNames()
437 Dict::GetDictEntryNamesByCategory()
438 DictSet::GetPubDictEntryNames()
439 DictSet::GetPubDictEntryNamesByCategory()
440 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
441 * ENH : Use dicomTS.dic as described in 2004 version
442 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
443 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
444 Add Accessors on VM (Value Multiplicity), and VM related methods
445 * ADD : Add a list of 'Dicom Attribute types', as found in
446 http://medical.nema.org/dicom/2004/04_15PU.PDF
448 * ADD : Add dicomGroupNameAbbreviations.dic
449 should be used to write a method to replace the former
450 Dict::GetDictEntryNamesByCategory()
452 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
454 to read in the file... and only it ! Length is the efective length of the
455 data in the DocEntry structure
457 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
458 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
459 And now use a static function call instead, with a global variable. i
460 This is much closer to the VTK approach. Hopefully should be bulletproof
461 and easier to use...hopefully
463 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
464 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
466 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
469 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
471 ValEntry, BinEntry, SeqEntry creation or replace
473 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
475 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
477 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
478 when specifying the VR
479 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
480 * src/gdcmDocEntry.cxx : amelioration of print
482 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
483 * ADD : Add the method Util::IsCurrentProcessorBigEndian
484 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
485 * ADD Method Document::ComputeGroupLength
486 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
487 in order to allow further VR modification by user
488 * REM : removal of once-called method File::WriteBase
489 integration of its code in formerly one-line method File::Write
491 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
493 replace the different values "??", "Unkn", "Unknown".
494 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
495 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
496 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
497 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
499 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
502 * Set the gdcm::Base class to some Printable classes
504 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmFile.[h|cxx] : add the Print method
506 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
507 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
508 * src/gdcmDocument.h : remove the PrintLevel informations
509 * Example/PrintFile.cxx : use the new gdcm::File::Print
511 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
513 problems when compiling with the python wrapping
515 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
517 writting in ImplicitVR
519 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
520 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
521 JPEG decompression, especially when dicom frames are split into several
522 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
523 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
525 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmHeader.cxx : change the initialisation of default header.
527 Now, this header is readable by gdm, e-film, DicomWorks
529 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
531 Rename Decompressed to Raw
532 * Use the API changes in gdcm::File.
533 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
536 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
538 each added entry in the header. Replace the 'Planes' field by the 'Number
541 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
543 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
545 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
547 At this time, this image isn't readable by e-film... waiting JPR help to
550 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
552 DocEntry. Now use methods of the Document !
554 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * Test/ShowDicomSeq.cxx : bug fix
557 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
559 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
560 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
561 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
563 * Test/TestCopyRescaleDicom.cxx : remove unused variable
564 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
565 containing found sequences
567 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
570 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
571 Some fields in BinEntry must be copied to not seg fault when making the :
572 gdcm::File *copy = new gdcm::File( copyH );
573 and tests are now made on good variables
575 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
577 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
579 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
580 * Add vtkGdcmWriter example and test
582 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * Test/TestUtil.cxx : reformat the source code
584 * vtk/vtkGdcmReader.cxx : remove and change prints
585 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
587 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
588 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
590 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
592 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
594 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
596 by an eof to prevent all bad read of the file... and in this case, the
599 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * Example/Volume2Dicom.cxx : comment unused variables
601 * Test/PrintDicomDir.cxx : comment unused variables
602 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
603 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
604 method that is redondant with AddEntry.
605 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
608 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
609 * Bug fix due my last commit (compilation under Windows).
610 * Example/Volume2Dicom : bug fix in the file and reformatting source code
611 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
613 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
615 - Remove printf / sprintf
616 - include iostream AFTER gdcm so we don't get warnings
617 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
619 - Also remove tons of include from header files, hopefully this should
620 speeup the compilation time, since it was becoming a dog slow.
621 - Remove gdcm.h as it include way too many files and slow down compilation
622 (plus it is not up to date)
623 - remove 'using namespace std' this is BAD !
625 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Remove memory leaks on the DicomDir
627 * Remove some useless data in DicomDirObject
628 * Add usefull methods in SQItem, to be complient withe the ElementSet
630 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
633 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
635 future, with convertion)
636 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
637 and ImageDataSize values. Remove the method to get the PixelReadConverter
638 from the output of the class
640 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
643 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
645 and vtkErrorMacro use.
646 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
648 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
651 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
652 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
653 The string leaves only in the fonction. So when we make a .c_str(), we
654 get the pointeur on the first element, element that will be destroyed
655 immediately after thee instruction.
656 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
657 file has been opened : the test must be made on the content of the
658 pointer and not directly on the pointer !
661 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
663 the python part recompiles
665 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
667 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
668 X session is killed (for my computer... it seems to not be identic on
671 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
673 avoid problems (otherwise, the difference test between the visible image
674 and the reference is incorrect. If the reference is greater than the
675 screen resolution, it's produce errors).
676 Can be used for only one image. Can be used with a visible flag.
677 * vtk/vtkGdcmReader.cxx : remove commented codes.
678 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
679 under windows at compilation
680 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
682 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
684 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
686 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
687 tests on the image size X, Y, Z
689 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
691 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
692 between the class name and the file name
694 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * src/ : fix compilation warnings for the Write method (2 different
696 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
697 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
698 variable... create a static method in gdcm::Document to access to
699 this variable content.
701 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
703 file, to be accessed by other files (like gdcmFile). Remove commented
704 code. Move the change of the header to the gdcmFile, using the
706 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
707 To be sure of that (and simplify calls), the Write of the header now
708 gets a file name and not a file pointer (std::ifstream).
709 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
710 DocEntryArchive. Remove all open of the written file
712 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
715 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
717 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
719 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
720 some corresponding methods. Write correctly the file and check before
722 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
723 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
724 is now on RGB data (as before my last commit
725 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
727 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
729 Add a print information of the type of the entry
730 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
731 It was in the gdcmFile, and all write have been regrouped
732 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
733 Write correctly all dicom files (in decompressed mode only at this time)
734 * Test/ : test on files are now made using Raw data and not color data if
736 * Example/PrintFile.cxx : add more printings
738 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
739 * Amelioration of code, remove some code copy. For the loading of
740 BinEntry (in gdcmDocument), add the test to verify if the file is already
743 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
745 remove a DocEntry in the header (push an empty DocEntry)
746 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
747 lines. Bug fix in the initialization of the PixelConvert and the
749 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
750 use in TestCopyDicom (now this test can run under windows... but fails)
751 * Test/TestCopyDicom.cxx : amelioration of the test :
752 - test the pixels written
753 - add test points to quickly find where is the error
754 - can set a file name input and output in arguments
755 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
756 amelioration of the test output
758 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
760 all replaced DocEntry's
761 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
762 Now, each needed DocEntry to modify is duplicated, modified and inserted
763 to the header using DocEntryArchive. Thus, after save, we can restore the
764 header initial state.
766 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
767 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
769 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
771 correct to copy it. The DictEntry is specified at the DocEntry creation,
772 then, it musn't change in the time.
773 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
774 header correctly. At this time, the change is only made for the first
775 level of the Document. In the future, it might consider sequences.
776 The change is made by replacing a DocEntry by an other that is created
777 outside the class. The old value is kept. When we restore the header
778 status, the added DocEntry is deleted and replaced by the old value.
779 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
780 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
781 set the write type to explicit VR, implicit VR or ACR. Add methods to set
782 the write mode to native, decompressed or RGB (but not used at this time)
784 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
786 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
788 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
789 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
790 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
792 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
793 set because already copied when copying the BinEntry's of the header
794 * Test/TestAllReadCompareDicom.cxx : remove warnings
796 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
797 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
798 Two problems appear when doing it :
799 - with the gdcmFile : when the GetImageData method is called, the pixels
800 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
801 data (pixels). And each structure destruct the data when it's
802 destructed. So we have two destructions for the same data. To solve it,
803 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
804 data or not. If it doesn't own data, then they will not destroyed by
806 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
807 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
808 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
809 create a double destruction of the same DocEntry's. So, to solve it,
810 the TagHT is simply cleared and the DicomDir* elements are destroyed.
811 * TODO : add an entry concerning memory leaks in the DicomDir
813 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
814 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
815 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
818 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
819 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
820 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
821 after it have been deleted
823 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * FIX: src/* fix the doxygen warnings.
825 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
826 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
827 was erroneously defined with a size of 15 instead of 16. [many thanks
828 to Jean Michel Rouet for pointing out this bug].
830 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
831 1. Finish merging JMR patch for writting DICOM from scratch
832 2. Fix -hopefully- bug with MONOCHROME and space vs null character
833 3. Use const ref when possible
834 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
835 5. A few more comments
836 6. CreateUniqueUID can now be called without parameter"
838 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
839 * ENH: Slightly bigger patch:
840 1. Getting toward full integration of JMR patch for writting dicom from scratch
841 2. Update Test to test part of this patch: CreateUniqueUID
842 3. File was not close properly in gdcmDict
843 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
844 5. Use of const ref instead of copy (speed issue)
845 6. Remove temporary (duplicate) string in TranslateToKey
846 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
847 8. Do not repeat virtual in subclasses
848 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
850 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
851 * Apply first patch toward better string comparison when dealing with broken
852 DICOM files. Essentially the string could be padded with a space instead
853 of a null character as defined by standard
855 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
857 because never used... and in the same time, that's remove some memory leaks
859 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
860 * src/gdcmFile.cxx : now delete the PixelConvert instance.
861 * In examples and tests : change the type of image data variables from void*
862 to uint8_t*. Remmove all delete on image data variables
864 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
865 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
866 Verify the file pointer value before open the file, and if it's not null,
867 a verbose message is generated.
868 Close correctly the file when the file isn't considered dicom-like. The
869 correctly close is a call to CloseFile.
870 When closing the file pointer, test if its not null to close the file.
871 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
872 file. For an uncompressed image, the copied data correspond in the least
873 case to the image size (calculated) or the image size specified in the
874 header. A verbose is generated if these two size mismatch
876 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
877 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
878 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
879 break under windows (with msvc6 compilation).
881 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
883 compiling with MSVC6)
885 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
886 * Bugs fix for the Windows build with VC6
887 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
888 needed (only for projects required VTK). If the VTK is included in all
889 projects, there is conflicts with the jpeg lib of vtk when compiling the
890 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
891 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
892 when compiling the gdcm_wrap.cxx file (created by the compilation of the
894 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
895 (like it's already made for the cout use). Otherwise, conflict with the
898 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
899 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
901 - comments on the DicomDir::Method related usage added.
902 - now that we use the namespace gdcm, a lot of internal classes do
903 NOT need to be wrapped anymore.
904 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
905 DicomDir::Method) new example added.
907 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * Improve string manipulation. I now inforce the notion of 'DicomString'
909 A DicomString can contain as many \0 as they want
910 and it is *always* of even length.
911 We only support odd length for very rare case.
912 And in the near future this should be removed.
914 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
915 * /binary_write/ gdcm source. Now even on big endian we are writting
916 little endian. This should -heopfully- fix some tests
918 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
919 * Now the dictionary is compiled into gdcm lib. This is a default
920 behavior, thus any dic file specified is picked before failback to
921 the one comiled into lib
923 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
924 * Change internals for gdcmDict. Don't use any 'new' any more.
925 This should definitely solve any leak problem, and we should be
926 as fast as before, as long as don't modify too much the dictionary.
928 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * STYLE: ivars should start with a capital letter.
930 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
931 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
933 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
935 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
936 new 2004 dictionaries added (thanks to JPR).
937 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
938 * CLEANUP_ROUND (15) for gdcmPixelConvert
939 - RLEFrame::NumberFragments is now of type unsigned int
940 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
941 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
944 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
945 * Initial work in gathering all transfer syntax accessors. clearly
946 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
947 ivars, but only one transfersyntax (class) ivar with equivalent method on
950 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
951 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
952 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
953 discussed (plus I didn't like having a 2000 lines patch not commited)
955 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
957 * CLEANUP_ROUND (14) for gdcmPixelConvert
958 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
959 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
960 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
962 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
963 anymore and hence avoids storing a copy of PixelConvert::Decompressed
964 into File::Pixel_Data.
966 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
968 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
969 * CLEANUP_ROUND (13) for gdcmPixelConvert
970 Substituted File::ParsePixelData() with PixelConvert::Print() new
972 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
973 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
974 method to those classes.
975 - src/gdcmFile.[cxx|h]:
976 -- Added a ::Print() method.
977 -- PixelConverter is now a reference instead of a member.
978 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
979 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
981 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
983 collaboration diagram and inheritance diagram should be generated with
985 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
986 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
987 pointlessly wrapped (see
988 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
989 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
990 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
991 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
992 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
993 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
994 -- File::Initialise: PixelConverter setup moved away to
995 PixelConverter::GrabInformationsFromHeader()
996 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
997 interpretation moved away to PixelConverter::BuildRGBImage()
999 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1000 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1001 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1003 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1005 displayed on Win32 when a brutal abort() occurs (because of uncatched
1006 exception). See TODO new entry of this commit for more on this.
1007 * TODO added new entry.
1008 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1009 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1010 - HandleColor is no longer called from gdcmFile.cxx
1011 - gdcmPixelConvert.cxx clean up on method arguments and internal
1012 variable names for semantical coherence.
1014 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * Finished lossless transition, not only do we now read all lossless jpeg
1016 images, without the need of the Cornwell lib, but we do read them properly now
1017 * To reduce code (well to avoid code duplication), I defined a common place
1018 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1019 redefine symbols. This is not perfect but this the best solution I found for a
1020 compilation time jpeg option.
1022 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1023 * Update jpeg ijg lib to support lossless jpeg implementation
1024 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1026 * Also added a special copyright for dcmtk since we use their bugfixes.
1029 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1031 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1032 matters, as stated in warning note at beginning of %include section).
1033 * src/gdcmDicomDir*.[cxx|h]: coding style
1034 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1035 * src/gdcmJpeg8.cxx: doxygen fix.
1036 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1037 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1038 from File:: to PixelConvert::.
1040 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1042 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1043 - more code moved away from File:: to PixelConvert::
1044 - fat setup of PixelConverter set in place in File::Initialise.
1046 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1048 namespace at the file system level. So now you should convert your examples
1050 gdcmHeader -> gdcm::Header
1051 It would be nice if people keep in mind to no open the namespace, since it
1052 allows compilation on broken plateform which were defining common symbol in
1053 the standart namespace (like LP, Unknown ...)
1055 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1057 The JPEG fragments are now parsed at the same stage than the RLE
1058 information. All code related to JPEG is now in gdcmPixelConvert:
1059 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1060 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1061 export a gdcmFile:: method. Those are simply global functions
1062 (for the time being this is better than having them attach to
1063 either gdcmFile:: or gdcmPixelConvert::).
1064 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1065 and stores the result in a gdcmJPEGFragmentsInfo.
1066 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1067 code (among other stuff) moved away from gdcmFile:; to
1070 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1072 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1073 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1074 clean up of RLE related code.
1075 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1076 - src/gdcmRLE.cxx removed
1077 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1078 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1079 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1080 * CLEANUP_ROUND (9) for gdcmPixelConvert
1081 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1082 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1083 away from gdcmFile:: to gdcmPixelConvert::.
1085 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1087 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1088 This is because Parse7Fe0 used to parse the pixels to compute the
1089 length. This task was passed over to FindDocEntryLengthOB() a long
1090 time ago, EXCEPT I had forgotten the OW case...
1091 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1092 we just recylce the code for parsing RLE fragments and computing
1094 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1095 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1096 with the retired Parse7Fe0().
1097 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1098 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1100 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1102 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1103 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1104 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1105 * CLEANUP_ROUND (4) for gdcmPixelConvert
1106 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1107 to return an unused length.
1109 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1110 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1111 this should be cleanner from the plane view. The iostream are erally a pain
1112 to use to do simple stuff.
1114 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1115 * Redo the compilation of the ijg jpeg library. Now only one source is
1116 necesseray. No need to rename file by hand what so ever. CMake handle the
1117 copying of the file within different directory, configure header file to
1118 modify some symbol. The only addition made to ijg wasd a mangle table so
1119 that symbol are different whether we are within 8bits or 12bits.
1121 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * Added documentation of vtkgdcmReader on Website:
1123 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1124 with it's binary name).
1125 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1126 the Website to be more complete.
1127 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1128 doxygenated documentation.
1129 - Doc/DoxyVtkGdcmReaderExamples.txt added
1130 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1131 DoxyVtkGdmReaderExamples.html )
1132 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1133 * CLEANUP_ROUND (3) for gdcmPixelConvert
1134 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1136 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * CLEANUP_ROUND (2) for gdcmPixelConvert
1138 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1140 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1141 * CLEANUP_ROUND for gdcmPixelConvert:
1142 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1143 - src/gdcmPixelStuff[h|cxx] removed
1144 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1145 - src/CMakeLists.txt changed accordingly
1146 * GDCMHOME clean up:
1147 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1148 gdcmVersion.py moved to newly created ATTIC related
1149 gdcmPython/SetupOldies/ directory.
1150 * Autotools clean up:
1151 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1152 - autogen.sh configure.in acinclude.m4 python.m4 removed
1154 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1155 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1156 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1157 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1159 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1160 * TODO updated with Mathieu suggestions. I proposed a template for
1161 describing TODO entries and used it for new entries.
1162 * Added Doc/Website/CodingStyle.html, Developpers.html,
1163 DeveloppersPython.html, GdcmDataCvs.html and
1164 DownloadVersion0_1.html, DownloadVersion0_3.html.
1165 * Some Doc/*.txt Doxygen files (which do not really concern the
1166 documentation itself, but the website) moved to html and
1167 placed in directory Doc/Website:
1168 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1169 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1170 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1171 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1172 * CMakeLists.txt changed accordingly.
1173 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1174 DeveloppersPython.html
1175 * INSTALL nows refers to Doc/Website/Installation.html
1177 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * Added Doc/Website directory, that contains a first raw version
1181 2004-09-23 Jean-Pierre Roux
1182 * FIX In order not to be poluted any longer by casting problems,
1183 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1184 we can now delete[] it safely
1185 * VoidArea is now called BinArea (less confusing name),
1186 and all the methods called ...VoidArea... are now ... BinArea...
1187 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1189 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1191 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1192 up to the destructor of gdcmElementSet to clean up TagHt and it's
1195 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1197 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1199 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * ENH: added some utility method that builds a flat dictionary
1201 holding all the Dicom entries contained in the recursive structure
1202 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1203 an example of usage.
1204 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1205 BuildFlatHashTable() that build a flat dictionary.
1206 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1207 gdcmDocument is now a friend of gdcmElementSet.
1208 - src/gdcmElementSet.cxx: clean up.
1209 - Example/FlatHashTablePrint.cxx added.
1210 - Example/CmakeLists.txt changed accordingly
1212 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1214 moved away from gdcmDocEntrySet (since this class is an abstract class
1215 acting like an interface). SQDepthLevel and BaseTagKey are now
1217 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1218 and associated accessors. Doxygenation of the class.
1219 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1221 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1222 Use SQDepthLevel accessor instead. ::Print() adapted.
1223 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1224 - src/gdcmDocument.cxx changed accordingly.
1226 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1228 - The following is the doxygen comment of the typedef declaration
1229 of gdcmTagKey in src/gdcmCommon.h:
1230 gdcmTagKey is made to old an "universal" (as in URL, Universal
1231 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1232 A dicom tag always has a group and an element, but a set of tags
1233 embeded in various (optionally nested) sequences and sharing
1234 the same group and element all share the same (group, element)
1235 "identifier". Hence the (group, element) cannot be used as an
1236 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1237 In order to construct a proper tag identifier (i.e. a key) we
1238 consider the following definition of a TagKey:
1239 - let Group, Element be the string representation of the
1240 group and element dicom tag members,
1241 - let ItemNumber be the string representation of the integer
1242 index of the considered item number of a sequence,
1243 Let the key of a tag embeded in a sequence, noted SeqTag, be
1245 /ItemNumber#Group|Element
1246 where "/", "#" and "|" are characters acting as separators.
1247 Then the general form of a gdcmTagKey is given by:
1248 Group|Element<SeqTag>
1249 where <SeqTag> means NO or many instances of SeqTag.
1250 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1253 but the gdcmTagKey of a tag "embeded" is the first item of
1254 a sequence, itself nested in the third item of a sequence is the
1256 0004|1220/2#0008|0082/0#0008|0090
1257 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1258 order to hold the new sequence compatible key. Previously, the
1259 GetKey() method would look in the underlying gdcmDictEntry.
1260 - src/gdcmDocEntry.cxx:
1261 -- constructor now copies the underlying DictEntry key, in the local
1263 -- ::Print: displays the member Key, instead of the (group, element).
1264 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1265 - src/gdcmDocEntrySet.h:xi
1266 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1267 -- now has a new BaseTagKey member.
1269 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1270 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1272 This poses the problem with the semantics of the following lines
1273 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1274 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1275 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1276 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1277 to the long FIXME note for what the problem is. Nevertheless in
1278 order to get things working the dicom dictionary was altered !
1279 Please fix things urgently...
1280 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1281 information), see above note on moving the member VoidArea. Nevertheless
1282 the following entries previously correctly set as US are now inproperly
1284 0028 1201 OW IMG Red Palette Color Lookup Table Data
1285 0028 1202 OW IMG Green Palette Color Lookup Table Data
1286 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1287 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1288 of gdcmDocEntry moved to gdcmSeqEntry.
1289 * src/gdcmSeqEntry.cxx: STYLE.
1291 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1292 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1294 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * gdcmPython/testSuite.py: all the test suite in python is now moved
1296 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1297 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1298 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1300 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1302 to avoid inclusion recursion until STL is reached.
1303 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1304 mecanism. errno.h is not included in gdcm anymore.
1305 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1306 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1308 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1309 gdcmData/TestAllEntryVerifyReference.txt
1310 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1311 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1312 exception_on_error parameter.
1313 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1314 - vtk/vtkGdcmReader.cxx changed accordingly,
1315 - Example/*.cxx and Test/*.cxx changed accordingly.
1317 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1318 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1319 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1320 enable_sequences removed from gdcmHeader constructor and dependencies.
1321 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1322 * gdcmPython/demo/PrintHeader.py: dummy fix.
1323 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1324 skip_shadow removed from gdcmHeader constructor and dependencies.
1325 * Example/*.cxx and Test/*.cxx changed accordingly.
1327 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1329 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1331 2004-07-21 Jean-Pierre Roux
1332 * FIX Now, Parsing and Printing a DICOMDIR do work!
1333 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1335 2004-07-20 Jean-Pierre Roux
1336 * FIX Some brain damaged headers have Zero-Lenght fields
1337 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1339 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1340 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1341 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1342 variable (instance of gdcmDebug) by a definition macro, and the instance
1343 is now in static in the gdcmDebug class
1344 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1345 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1347 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1348 * WARNING: ctest now depends more tightly on gdcmData. You should
1349 check out gdcmData properly for things to run smoothly...
1350 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1351 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1352 we need the pixels not be loaded in order to use the ValEntry
1353 that displays position and size).
1354 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1355 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1356 be deprecated. If you have any doubts about the advantages of a
1357 modern scripting language (read Python) versus grass root C++ (i.e.
1358 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1359 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1360 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1361 Anyhow, consider documenting the gdcmData images in
1362 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1364 * Test/CMakeLists.txt:
1365 - now uses TestAllEntryVerify.cxx
1366 - specific comments on oldACR00001.ima (now renamed in gdcmData
1367 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1368 gdcmData/TestAllEntryVerifyReference.txt
1371 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1372 * src/*.[h|cxx] : typedef clean up
1373 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1374 - TagKey renamed to gdcmTagKey (for external usage)
1375 - VRKey renamed to gdcmVRKey (for external usage)
1376 - removal of typedef duplication.
1377 - Removed all unecessary inline keyword from class inline definitions.
1378 - Some method|function(void) declarations replaced with method|function().
1379 * src/jpeg/libijg12/jdhuff12.c:
1380 - printf polluting ctest removed.
1381 - TAB removal for comminting
1383 - TestAllReadCompareDicom.cxx: added a test that compares all the
1384 images in gdcmDataImages.h with corresponding images in
1385 gdcmData/BaselineDicom/. When baseline images are not present
1386 this test creates them.
1387 Note: we need to validate each reference image, but before that
1388 I'd like to rename them with a more explicit name...
1389 - CMakeLists.txt: changed accordingly.
1390 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1391 including each header needed).
1393 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1395 test suite to the Example directory. Are concerned:
1400 - TestWriteSimple.cxx
1401 * Test/CMakeLists.txt: added some comments on reasons for black listing
1402 image gdcmData/oldACR00001.ima
1404 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * Test/CmakeList.txt: removed the following from black list (to be coherent
1406 with removal from gdcmData):
1407 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1408 - gdcm-MR-PHILIPS-16.dcm
1410 Added the following because after last cvs update, they cause
1411 ctest -R TestReadWriteReadCompare
1413 - gdcm-MR-SIEMENS-16-1.acr
1415 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1416 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1417 new comments in this file) we temporarily (sigh) move to a weaker
1419 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1420 we don't need to black list the following images anymore:
1421 - 8BitsUncompressedColor.dcm
1423 - US-PAL-8-10x-echo.dcm
1424 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1425 fixes and the beautified code ;-)
1426 This fixes the bug introduced in version 1.42 (when beautifying)
1427 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1428 Note: ctest was blind to this bug (this means we need to still
1429 improve the test suite). The bug could be detected by using
1430 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1432 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1433 and by displaying the (garbage) produced file temp.XDCM...
1435 2004-06-29 Jean-Pierre Roux
1436 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1437 - replace by uggly but working old code :-(
1438 A lot of things should be OK again.
1439 It's really urgent to have a test suite that *tests*,
1440 to prevent Frog's beautifying sessions to break all the stuff
1441 (twice, withing a fortnigh ...)
1443 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1444 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1445 redundancy) to added Test/TestReadWriteReadCompare.cxx
1446 * Test/CmakeList.txt: because the compare test of
1447 Test/TestReadWriteReadCompare.cxx fails, the following images are
1448 black listed: - 8BitsUncompressedColor.dcm
1450 - US-PAL-8-10x-echo.dcm
1451 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1452 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1453 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1454 and ad-hoc kludge. This kludge is now removed, and on encountering
1455 such an image (OB field brain damaged) we set errno. Then in
1456 ::FindDocLength() we "fix" the length as being ALL what remains
1457 in the file (until EOF). We then proceed, hoping for the best...
1458 This fixes a SegFault in ShowDicom when trying to write such an
1460 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1461 (because TestWriteRead breaks on it, after a non conformal commit?).
1462 ctest now runs properly, except for MakeDicomDir (which was always
1463 broken) and the Python related stuff (still not fixed).
1465 2004-06-24 Jean-Pierre Roux
1466 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1467 FIX : Test/TestReadWrite now iterates on all the file names
1468 (instead of infinite loop)
1469 ENH : Test/TestWriteRead now iterates on all the file names
1471 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1472 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1474 2004-06-24 Jean-Pierre Roux
1475 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1476 when SamplesPerPixel =3
1477 - now Write is no longer confused by
1478 'BitsAllocated = 12" and 'BitsStored=12"
1479 - "UN" value representation Elements are now written correctly
1480 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1481 ENH : - now gdcmHeader has its own Write methods
1482 (in order to split the job that has not to be done
1485 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1487 loop on the same image until memory went out.
1488 Note: this means we still have gobs of memory loss in PrintDocument
1489 * src/gdcmDocument.cxx: fixes problem on parsing on file
1490 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1492 2004-06-24 Jean-Pierre Roux
1493 FIX : Write - All the Sequences and Sequence Item are now written
1494 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1495 is added a the end, when necessary.
1496 - A lot of brain-damaged images, that were read correctly are
1497 now written correctly
1498 - length compatible BinEntry are now loaded correctly
1499 (even for odd groups)
1500 Note : only Explicit Value Representation was checked.
1501 (question : is implicit VR really necessary for gdcm ?)
1503 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1504 * DEVELOPPER: added a proposition of coding style.
1505 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1508 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1509 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1510 Use the gdcmDocEntry::Print() and Write() instead.
1511 * src/gdcmDocument.cxx: bug fix.
1513 2004-06-22 Jean-Pierre Roux
1514 FIX : gdcmDocument.cxx
1515 - Now we do recognize the JpegLossLess format (there was a misstyping in
1516 code 'beautyfication' :-(
1517 - Now we automaticaticaly load the Luts, if any
1519 2004-06-22 Jean-Pierre Roux
1520 In order : to write Sequences, whatever their imbrication level,
1521 : to allow user to create his own Sequences
1522 a lot of modif where necessary (adding, moving, or virtualising methods)
1524 WARNING : save your own sources *before* cvs up !
1527 ADD virtual void Write(FILE *fp, FileType filetype);
1530 ADD virtual void Write(FILE *fp, FileType filetype);
1531 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1534 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1535 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1536 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1537 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1538 ADD std::string GetEntryByName(TagName name);
1539 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1541 std::string vr = "unkn",
1542 std::string fourth = "unkn",
1543 std::string name = "unkn");
1544 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1545 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1546 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1547 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1548 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1549 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1550 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1551 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1554 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1555 ADD virtual std::string GetEntryByName (TagName tagName);
1556 ADD virtual std::string GetEntryVRByName (TagName tagName);
1557 REM virtual bool Write(FILE *, FileType);
1558 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1559 FILE *_fp, FileType type);
1560 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1561 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1562 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1563 REM virtual std::string GetEntryByName (std::string tagName);
1564 REM virtual std::string GetEntryVRByName (std::string tagName);
1565 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1566 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1567 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1569 std::string vr = "unkn",
1570 std::string fourth = "unkn",
1571 std::string name = "unkn");
1572 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1573 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1574 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1575 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1578 ADD virtual void Write(FILE *fp, FileType filetype);
1581 ADD virtual void Write(FILE *fp,FileType filetype);
1584 ADD virtual void Write(FILE *fp, FileType filetype);
1585 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1586 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1587 REM std::string GetEntryByName(TagName name);
1590 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1592 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1593 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1594 The default constructor invoked by the line
1595 gdcmHeader *f1 = new gdcmHeader( header );
1596 was gdcmHeader::gdcmHeader(bool) instead of the expected
1597 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1598 Hence the parsing wasn't executed... See also below.
1599 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1600 as explicit constructor didn't do the trick to fix the above problem.
1601 Could anyone explain why ?
1602 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1603 properly calls gdcmValEntry::Print() (that was weed out from
1604 code related to gdcmBinEntry).
1606 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1607 * In order to fix memory leaks:
1608 - Test/TestWriteSimple.cxx: added cleaning of free store through
1610 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1611 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1612 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1613 (through the call to ::AddDicomDirMeta()) or the destructor
1614 would crash when deleting uninitialized ::metaElems].
1615 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1616 - src/gdcmDocument.cxx:
1617 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1618 from dynamic stores.
1619 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1620 was causing memory leaks.
1621 - src/gdcmSQItem.cxx:
1622 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1623 cleanly handled with polymophism: sorry but my milage is low).
1624 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1625 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1626 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1627 This avoids SegFaulting.
1628 - src/gdcmSQItem.h: coding style.
1630 - Test/TestWriteSimple still severely sucks. The output image content
1631 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1632 damaged when displayed with vtkgdcmViewer.
1633 - on memory leaks: TestWriteSimple leaks really less (see entry
1634 of 2004-06-18 in Changelog file for the call to valgrind).
1635 - on segfaults: ctest now passes all the tests but one (no more
1637 * Erroneous leading white fix:
1638 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1639 white[s] (as opposed to from >> xxx, that removes it [them].
1640 - src/gdcmTS.cxx: ditto.
1641 - gdcmPython/testSuite.py: dirty related kludge removed.
1642 * src/*: remaining references to gdcmParser removed.
1643 * src/*[cxx|h]: added copy[way]left header.
1646 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * In order to fix writing of dicom files:
1648 - Test/TestWriteSimple.cxx: a simpler example of writing.
1649 - Test/CMakeLists.txt changed accordingly.
1650 - src/gdcmDocument.cxx:
1651 -- The destructor now recursilvely removes potential sequences.
1652 -- Bug fix in ::IsJPEG2000()
1653 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1654 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1656 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1657 to only declared) and build on top of
1658 ::GetDocEntryByNumber(guint16, guint16).
1659 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1660 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1661 for usage in destructor and treatement of promotion in
1662 ::ReplaceOrCreateByNumber().
1663 - src/gdcmSQItem.cxx: destructor should better handle his job.
1664 Test/TestWriteSimple now runs (or at least it DOES something).
1665 * We can now start hutting memory links. A good starting point is:
1666 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1667 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1668 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1670 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * Valgrind note: after Mathieu Malaterre teached me how to read
1672 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1674 Using gcc, you can force the STL to use malloc and to free memory as
1675 soon as possible by globally disabling memory caching.
1676 With 3.2.2 and later, you should export the environment variable
1677 GLIBCPP_FORCE_NEW before running your program.
1678 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1679 simply vanish (it is still not clear to me, whether this means that
1680 STL std::string leaks or if valgrind believes it leaks...).
1681 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1682 running bin/gdcmTests makeDicomDir):
1683 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1684 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1686 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1687 SegFaulting (I drowned in DicomDir related code when trying to
1688 understand why the list is empty...).
1689 * src/gdcmDocument.h: first BSD license header try.
1690 * Doc/License.txt added.
1692 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * src/gdcmDocument.[h|cxx]:
1694 - Clean up of the Transfer related predicates. They are now all based
1695 on new method isGivenTransferSyntax, that (should) handle properly
1696 the padding problem.
1697 - general clean up, simplification, and coding style.
1698 - Specific clean up of Parse7FE0() (umproperly named actually).
1699 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1701 2004-06-14 Jean-Pierre Roux
1703 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1704 - fix the display of SQItem ordinal number
1705 - add the GetSQItemByOrdinalNumber method
1706 - remove some useless never written private methods
1708 2004-06-14 Jean-Pierre Roux
1710 - adding a constructor taking a gdcmDocEntry as an input param
1711 - ReplaceOrCreateByNumber now returns :
1712 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1713 a gdcmValEntry * if a string value is passed as a param
1715 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1716 according to the param type (no longer sets a gdcmDocEntry)
1717 - GetValEntryByNumber, GetBinEntryByNumber added
1718 - NewValEntryByNumber and NewBinEntryByNumber added
1720 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1722 - GetSQItemNumber and SetSQItemNumber added, to provide
1723 a (relative) Item identier inside a given Sequence
1724 \warning : some pb remaining around this number
1726 - AddEntry now takes the Item Number as a param
1728 - adding a constructor taking a gdcmDocEntry as an input param
1730 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1731 * Memory leak hunt with the following command:
1732 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1733 --show-reachable=yes gdcmTests PrintDocument
1734 It looks like many (all?) leaks are due to the STL (or a bad usage
1735 of the STL. The lines producing the leaks now have a comment with
1736 a "MEMORY LEAK" tag: you can retrieve them with
1737 grep "MEMORY LEAK" src/*
1738 Here are two typical examples which I can't help fixing:
1743 char * test = "babo";
1744 name = test; //// <--- valgrind detects 960 bytes lost in
1745 //// call to std::string::operator=(char const*)
1746 name.clear(); //// Doesn't help !
1754 std::cout << "Type a bunch of characters followed by RETURN: ";
1755 getline(std::cin, line); //// <--- valgrind dectects a loss
1756 //// of 1320 bytes in call to
1757 /// std::basic_istream<>& std::getline<>
1763 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1764 * src/gdcmHeader.[cxx|h]:
1765 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1766 and related, moved away to gdcmDocument.
1767 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1768 the corresponding protected accessors of inherited class
1769 gdcmDocument, removed ! As a consequence gdcmFile had to be
1770 declared friend of class gdcmDocument (see below).
1771 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1772 - Clean up of undefined or unused methods.
1773 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1774 account the changes to gdcmHeader.h).
1775 * src/gdcmDocument.h:
1776 - gdcmFile is now a friend class (in order to take into account the
1777 changes to gdcmHeader.h).
1778 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1779 (see changes to gdcmHeader.h).
1780 - Accessors (reading on the form GetEntry*) are now public.
1781 - Clean up of undefined or unused methods.
1782 * src/gdcmDocument.cxx:
1783 - adaptation to changes to gdcmDocument.h
1784 - ::OpenFile now writes a verbose message when file cannot be opened.
1785 - some std::string properly set to VRKey
1786 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1787 references to gdcmDocument.
1788 * Test/TestFindTags.cxx: changed accordingly to above changes.
1789 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1790 cvs repository gdcmData.
1792 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1794 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1795 conflicts with gdcmValEntry::voidArea.
1796 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1797 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1798 Value representation between StringRepresentable and BinaryRepresentable.
1799 * src/gdcmDocument.cxx:
1800 - method ParseDES: proper indentation restored and usage of
1801 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1802 - method LoadDocEntry: the fingerprint left in the SetValue() of
1803 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1804 removed. Reverting to previous code segment with the proper
1805 dynamic_cast< gdcmValEntry* >.
1806 Note: this was (partially) breaking the python test suite
1807 (gdcmPython/testSuite.py) that made usage of the above
1808 fingerprint to check presence of "Pixel Data".
1809 * src/gdcmDocEntry.h: coding style.
1810 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1811 now taken into account.
1812 * gdcmPython/gdcm.i: adaptation to the new internal representation
1813 of gdcm (exit gdcmParser, hello gdcmDocument).
1814 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1816 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1817 anymore, but instead prints the loaded Python dictionary.
1818 * .... alas, the python testSuite is still broken.
1820 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1823 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1824 * src/gdcmUtil.h : export methods
1826 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1829 * Initial addition of automatic python testing
1830 * Initial addition of automatic image comparison
1832 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1833 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1834 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1836 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1837 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1838 * Test/ShowDicom.cxx : bug fix for msvc compilation
1839 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1841 2004-05-04 Jean-Pierre Roux
1842 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1843 new concepts (and new classes) :
1844 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1845 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1846 - Sequence Doc Entries (gdcmSeqEntries)
1847 a Sequence is composed of Items.
1848 Each item is a set of Doc Entries (this is recursive)
1849 The non uniqueness of the 'Dicom tag' is due to this recursivity
1850 (never taken into account)
1851 Our unability to add a new 'entry' in the header
1852 at the proper location (neither in the H-Table (map or multimap),
1853 nor in the Chained List is also due to this recursivity.
1854 Don't try, right now, to use/modify/compile these new sources :
1855 nothing is finished.
1856 We just commit all the stuff, 'as is', in order not to loose it.
1858 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1861 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1862 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1863 file prefix (SetFilePrefix)
1865 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * Add a new test: ShowDicom, for now this is just the c++ version of
1867 checkRead.sh, later it will be able to compare the image read against a
1869 * Replace the DEBUG on the stack with a global entry in cmake interface:
1870 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1872 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * Add an example subdir, with a real example on how to read + write a
1876 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1878 * Doc/CMakeLists.txt: the main page is now properly differentiated
1879 between the developper and user version.
1880 * Doc/doxygen.config.in: dropped search related obsolete flags
1881 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1883 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * DEVELOPPER: added some helpfull comments for compile/test/install
1887 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1889 src directory, now generated in the build dir.
1890 2. Tests as mentionned smarter
1892 4. Add a new method in gdcmDict that return the PubDict by name
1893 this is interesting for 3rd party lib like ITK,
1894 where we could set the institution name / patient name...
1896 * ENH: 1. Now the test suite is working for real
1897 2. All binaries are now output in the gdcm-bin directory
1898 (this was not true before)
1900 2004-04-28 Jean-Pierre Roux
1901 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1902 SeQuence indented printing of Dicom Header.
1903 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1904 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1905 Computation of SQDepthLevel is now part of gdcmHeader constructor
1906 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1907 tree-like structure of a Dicom Header.
1908 * FIX Test code cleaning
1910 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1911 * ENH: Adding automatic testing
1912 1. Need a DartConfig.cmake to submit to public
1913 2. Add a test driver gdcmTest.cxx
1914 3. gdcmTestMain, an helper for the main test driver gdcmTest
1915 4. Files in Test don't have a main anymore, this becomes interesting
1916 when we add more and more tests, thus dsw don't have to load
1918 * ENH: Adding a GDCM_DATA_ROOT for testing
1919 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1920 one file instead of seven + some small cleanup
1922 2004-04-22 Jean-Pierre Roux
1923 * ENH Minor changes to the Print() methods.
1924 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1925 Header printing. Example given with :
1926 > PrintHeader fileName 2 new
1927 (SQ based tree-like structure still to be done for the Header ...)
1929 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1930 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1931 1. I have added some unsigned where needed
1932 2. Some function parameter not used -> (void)
1933 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1934 4. g++ don't like character '\' in comment
1935 5. #define jpeg_create_decompress jCreaDecompress
1936 this really need to be fixed
1937 6. virtualize destructor of gdcmObject ... leakage
1938 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1939 this also really need to be fixed
1940 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1941 remove compression file
1942 (as we only do decompression, right ?)
1943 * ENH: Change malloc/calloc/free with c++ equivalent
1945 2004-04-21 Jean-Pierre Roux
1946 * FIX gdcmHeaderHelper::GetXSpacing
1947 when a single value is found (bug ?), xpacing is now
1948 defaulted to yspacing
1950 2004-04-19 Jean-Pierre Roux
1951 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1952 * ENH add parameters :
1953 bool exception_on_error = false,
1954 bool enable_sequences = false,
1955 bool ignore_shadow = false
1956 to the gdcmFile constructors to be full gdcmParser compliant
1957 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1958 to allow reading of PAPYRUS 3.0 files
1960 2004-04-06 Jean-Pierre Roux
1961 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1963 2004-04-02 Jean-Pierre Roux
1964 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1965 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1966 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1968 2004-03-30 Jean-Pierre Roux
1969 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1970 for ACR file, written out as DICOM files (hope so...)
1972 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1974 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1975 moved to base class gdcmParser and only the specialisation is kept
1977 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1978 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1979 already does the job.
1980 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1981 (to be consistent with gdcmParser::WriteEntries).
1983 2004-03-30 Benoit Regrain
1984 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1985 upate of the object's instance. It's passed to 2 in the unfavorable
1986 case : one in the ExecuteInformation, one in the ExecuteData
1988 2004-03-29 Jean-Pierre Roux
1989 * ENH : Check on file type to be written moved
1990 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1991 * FIX : gdcmObject::ResetBoundaries now stops properly
1992 when end-of-list is reached
1993 : gdcmVersion modified (as Benoit Regrain asked)
1995 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1997 * src/gdcmUtil.cxx: added forgotten iostream include.
1998 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1999 equivalent to ExplicitVR in existing code).
2001 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2002 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2003 now contains all the gdcmGlobal related code.
2004 * minor coding style and doxygenation changes.
2006 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2008 now contains all the Debug related code.
2009 * minor clean-up of includes in src/*.cxx
2010 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2011 CreateCleanString) removed.
2012 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2013 * Doc/DoxyMainPageUser.txt added.
2014 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2015 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2016 src/gdcmDirList.cxx)
2018 2004-03-24 Jean-Pierre Roux
2019 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2021 2004-03-23 Jean-Pierre Roux
2022 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2023 big endian made volumes
2024 * ENH Now gdcmParser constructor and destructor are protected to forbid
2025 end user to instanciate class gdcmParser
2026 (only gdcmHeader and gdcmDicomDir are meaningfull)
2028 2004-03-22 Benoit Regrain
2029 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2030 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2031 gdcmSerie to gdcmDicomDirSerie
2033 2004-03-19 Jean-Pierre Roux
2034 * ENH Now the tree-like structure describing a DICOMDIR comming from
2035 an already existing DICOMDIR file is consistent with
2036 the home-made tree-like structure build ex-nihilo
2037 or build from the files held (recursively) in a Directory
2038 functions gdcmDicomDir::CheckBoundaries()
2039 gdcmObject::SetBoundaries() added
2041 2004-03-17 Jean-Pierre Roux
2042 * REM (Eric Boix bug) : removal of meaningless
2043 gdcmDicomDirImage::NewImage function.
2044 * FIX now file names and directory name are written properly in the
2046 * FIX now gdcmDicomDir constructor may be call without any trick
2049 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2051 of gdcmDicomDirImage::NewImage as empty function.
2053 2004-02-28 Jean-Pierre Roux
2054 * ENH add gdcmDicomDir:NewPatient
2055 add gdcmDicomDirPatient:NewStudy
2056 add gdcmDicomDirStudy:NewSerie
2057 add gdcmDicomDirSerie:NewImage
2058 to allow making gdcDicomDir object.
2059 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2060 (as opposite to the gdcmHeader chained list)
2062 2004-02-11 Benoit Regrain
2063 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2064 when using from python
2066 2004-02-10 Benoit Regrain
2067 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2068 * FIX : in gdcmDicomDir when the directory is empty
2069 * ENH : add callback and methods to get the progression of dicomDir
2072 2004-02-06 Jean-Pierre Roux
2073 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2074 - GDCM_META added to gdcmDicomDirType
2075 - class gdcmMeta created
2076 * ENH : - A brief summary is now displayed at the beginning of
2077 'testDicomDir' to help disaster magnitude estimation
2078 * REM : Now useless Test/explDICOMDIR.cxx
2080 2004-02-05 Benoit Regrain
2081 * ENH : add methods in gdcmObject to get the hash table or the list of
2083 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2084 * FIX : wrapping python for TagHeaderEntryHT
2086 2004-02-04 Benoit Regrain
2087 * FIX : even length for some strings when writting the dicom dir
2088 * FIX : sort the images in the dicom dir
2089 * FIX : Bug fix for python use of dicom dir
2090 * ADD : a python demo
2092 2004-02-04 Jean-Pierre Roux
2093 * FIX : Final solution (?) for icone embedded images
2094 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2095 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2096 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2097 gdcmData/gdcm-MR-SIEMENS-16.acr1
2098 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2099 to make full checking easier
2101 2004-02-04 Benoit Regrain
2102 * FIX : WriteEntries : coding style & logic in parameters
2103 * FIX : Set the elements to create the DicomDir in a dictionary file
2105 2004-02-03 Benoit Regrain
2106 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2107 * gdcmDicomDir : add the load of directory
2108 * Bug fix and print add-on
2110 2004-02-03 Jean-Pierre Roux
2111 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2112 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2113 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2114 * FIX gdcmParser.cxx : 'group length' elements are now considered
2115 as integers, even for shadow groups, when file is Implicit VR
2117 2004-02-02 Jean-Pierre Roux
2118 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2120 of the last synonym :-(
2121 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2123 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2124 * FIX taking into account the possible 7fe0,0010 multiplicity
2125 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2126 to allow removal of references to 7fe0,0010, to deal with
2127 ACR-NEMA images, when 0028,0200 is meaningfull
2129 2004-01-31 Jean-Pierre Roux
2130 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2131 no longer writes 'Un' on disk
2132 * FIX SQ elements with actual length are now dealt with corectly
2133 * FIX gdcmFile::WriteBase make the difference, for color images, between
2134 the length (for Palette expanded images)
2135 and Raw Length (non expanded image + Palette)
2136 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2137 (that broke Write). Replaced by UL.
2138 Aware user will reload the field if he
2139 thinks it's necesssary
2141 2004-01-30 Jean-Pierre Roux
2142 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2143 when 'dirty Acr' is found, to be compliant with the new
2144 IsReadable() methods.
2146 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2147 (no DOUBLE images in kosher DICOM,
2148 but so usefull for people that miss them ;-)
2150 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2151 DICOMDIR related utilities (not checked as Windoze compliant)
2153 2004-01-28 Jean-Pierre Roux
2154 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2156 2004-01-27 Jean-Pierre Roux
2157 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2158 to allow skipping the shadow elements, to save memory space.
2159 The TRUE value for this param has to be used
2160 with a FALSE value for the 'enable_sequence' param.
2161 ('public elements' may be embedded in 'shadow Sequences')
2162 * gdcmHeader methods now deal with 'embedded icones images' in the header
2163 (even when an 'icone image sequence' is announced by the
2164 element (0x0088,0x0200), but there is NO icone at all ...
2166 * gdcmHeader sometimes Image Location value doesn't follow
2167 the supposed processor endianity (see gdcmData/cr172241.dcm).
2170 * gdcmHeader add the method
2171 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2172 to get *all* the Header Entries with the same tag.
2173 GetHeaderEntrySameName is probabely *useless*
2174 (no meaning : Name is *not* an identifier within the Dictionary)
2176 2004-01-26 Benoit Regrain
2177 * Bug fix in the print of hexadecimal representations. Remove long fields
2178 in the print and add a third level of print to print them
2180 2004-01-23 Benoit Regrain
2181 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2182 * Bug fix on test suite after remove the strip made on not string fields
2183 * Split the IsReadable method between gdcmParser which test that the file
2184 is dicom and gdcmHeader which test that it's an image file
2186 2004-01-22 Benoit Regrain
2187 * DicomDir : clean code, add methods, set variables in protected or private
2188 * gdcmUtil : bug fix for the clean string method
2190 2004-01-19 Benoit Regrain
2191 * Add the use of shadow dictionaries
2192 * bug fix and coding style
2194 2004-01-19 Benoit Regrain
2195 * src/gdcmFile.cxx : bug fix concerning the close of file
2196 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2197 * Add the update of header entries using the shadow library
2199 2004-01-19 Benoit Regrain
2200 * removal of file gdcmHeader2.cxx
2201 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2202 inheriting from gdcmParser. This split is to prepare the integration
2203 of dicom dir parsing
2204 * bug fix under python
2206 2004-01-16 Jean-Pierre Roux
2207 * REM removal of class gdcmHeaderEntrySet
2208 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2209 * ADD add file gdcmHeader2.cxx
2210 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2212 2004-01-15 Benoit Regrain
2213 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2214 entries created while parsing the header. Thus, they will be destroyed
2215 when the gdcmDictSet will be destroyed
2216 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2219 2004-01-15 Benoit Regrain
2220 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2221 made a fatal error because of the memory release at the end of program.
2222 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2223 some memory and vtk seems to have some problems with that.
2224 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2226 2004-01-14 Benoit Regrain
2227 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2228 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2229 * src/*.[h|cxx] : make changes due to class name changes
2230 * gdcmPython/demo/*.py : bug fix due to method names
2232 2004-01-13 Benoit Regrain
2233 * src/*.[h|cxx] : coding style
2234 * vtk/*.[h|cxx] : coding style
2236 2004-01-13 Benoit Regrain
2237 * gdcmPython/testSuite.py : test the readable flag of file for tests
2238 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2239 It's lied to the stl compilation by MSVC (windows, always windows...)
2240 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2242 2004-01-12 Benoit Regrain
2243 * src/*.h : add comments
2244 * src/gdcmDictSet.h : set the method BuildDictPath in public
2245 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2246 directly setted in the source code
2247 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2250 2004-01-09 Benoit Regrain
2251 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2252 * setup.py : use a reference to gdcmVERSION
2254 2004-01-07 Benoit Regrain
2255 * Modification to compile with the distutils.
2258 2003-12-10 Benoit Regrain
2259 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2260 can use a gdcmHeaderHelper to load data
2261 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2262 made in the source code
2264 2003-12-10 Benoit Regrain
2265 * Update Windows projects and .cvsignore files
2267 2003-11-12 Jean-Pierre Roux
2268 * ENH gdcmHeader constructor has one more parameter (default value : false)
2269 that allows the user to 'go inside' the SeQuences only
2271 gdcmElValSet:Print takes it into account
2273 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * ENH: Update gdcmPython/CMakeLists
2275 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2276 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2278 2003-11-10 Jean-Pierre Roux
2279 * FIX : gdcmHeader::LoadElements is now based
2280 on the ListTag listElem member,
2281 not longer on the TagElValueHT tagHt member
2282 * ENH : PrintPubElVal shows (temporarily) both results,
2283 with the tagHt member and the listElem member.
2284 (it's easier to 'see' the problems when using Printheader)
2286 * FIX : old private member LgrElem is now splitted into
2287 ReadLength : Length actually found on disk (updated only
2288 if bug fixing is necessary), for internal
2290 UsableLength : Updated by FixFoundLength, to fix a bug
2291 or to allow Parser going on.
2292 Will allow to re-write a kosher header when a SeQuence
2293 with a length (not 0000) is found
2294 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2295 because gdcmElValSet::Add does not update ListElem
2298 2003-11-07 Jean-Pierre Roux
2299 * FIX misstyping in Transfert Syntax name table
2300 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2301 when they have an actual length (not 0000 nor FFFFF)
2302 (Nobody should care of it, but DICOMDIR explorers)
2304 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2305 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2307 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * ENH: vtkGdcmReader now supports LUT !
2309 (vtkgdcmViewer for now is not able to use them though)
2311 2003-11-05 Jean-Pierre Roux
2312 * in testSuite.py : new files names for checking the package
2313 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2314 that returns the pixel area size to the *aware* (vtk) user
2315 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2317 2003-11-05 Benoit Regrain
2318 * in testSuite.py : Modify the rules for checking the paths
2319 : Explicit error messages
2320 * in __init__.py : Related modif
2322 2003-11-03 Jean-Pierre Roux
2323 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2324 to be used by aware (vtk) users that want to manage
2325 LUT (and no to turn the PALETTE image into an RGB pixels one)
2326 * GetPixelType now returns 8U for 24 Bits images
2327 (vtkGdcmReader compliant)
2329 2003-10-31 Jean-Pierre Roux
2330 * Removal of *all* gdcmData images and add them again
2331 in order to loose the 'history' of un-anonymised images
2333 2003-10-31 Jean-Pierre Roux
2334 * RMV : removal of useless jBitsInJsample.h
2335 for both 8 and 12 Bits JPEG Lossy Libraries
2337 2003-10-31 Jean-Pierre Roux
2338 * ENH : Add the functions gdcmFile::GetImageDataRaw
2339 gdcmFile::GetImageDataIntoVectorRaw
2340 that act as GetImageData and GetImageDataIntoVector
2341 except the making of an RGB Plane from Gray Plane + LUT
2342 Intended to aware (vtk) users who know how to manage
2345 GetLUTRGBA return a R,G,B,A LUT if any
2346 lgrTotaleRaw gives the 'Raw' length
2347 GetImageDataRaw returns the gray Plane
2348 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2349 (They stay Grey, just like with other Dicom viewers :-(
2351 2003-10-30 Jean-Pierre Roux
2352 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2354 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2355 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2356 being coherents dicom files.
2358 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2359 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2361 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2362 * ENH: Two steps is necessary to please VC++ compiler...
2363 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2364 * ENH: Add include dir to medcon lib
2365 * FIX: only one function is being exported for now !
2366 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2368 2003-10-29 Jean-Pierre Roux
2369 * adding gdcmHeader::GetLUTRGBA
2370 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2371 --> Mathieu, the modif u're waiting for is not yet committed
2372 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2374 2003-10-27 Jean-Pierre Roux
2375 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2376 00191113.dcm DermaColorLossLess.dcm
2377 MxTwinLossLess.dcm RadBWLossLess.dcm
2378 * ENH: For version prior to vtkImageViewer2 -r 1.19
2379 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2381 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * Removal of ido stuff in CMakeLists.txt
2384 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2385 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2386 * FIX: remove a call to ->Modified ... see comments
2387 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2389 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2390 * FIX: Problem with path for libvtkgdcmPython
2391 * ENH: Try adding a search script for python site-package
2392 * RMV: Remove some file from medcon lib that are not necessary
2393 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2394 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2395 * FIX: More pragma disable fro VC++,
2396 I don't think I break something as it is also disable in VTK/ITK.
2397 But it fasten debug compilation time.
2399 2003-10-23 Jean-Pierre Roux
2400 * gdcm now deals with 16 Bits Run Length Encoded images
2401 (they are compressed as 2 planes images,
2402 one for the high Bytes, the other for low Bytes)
2404 2003-10-22 Jean-Pierre Roux
2405 * Now CheckRead takes into account :
2406 - the bugged 'Leonardo' Siemens images
2407 - the XA images, sent thru the burning VPRO station
2408 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2411 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * FIX: When copying a Makefile.am to CMakeLists.txt
2413 one should remove the '\'
2415 2003-10-22 Jean-Pierre Roux
2416 * in gdcmData adding a bugged 'Leonardo' Siemens image
2417 (wrong lengths in header)
2418 OK with gdcm, KO with the other viewers :-)
2419 * add a GE dlx XA image, thru the VEPRO burning station
2422 2003-10-21 Jean-Pierre Roux
2423 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2424 for a brutal checking of vtkgdcmViewer compliance
2426 2003-10-21 Jean-Pierre Roux
2427 * add the files for 'xmedcon' Jpeg Lossless library
2428 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2430 2003-10-21 Jean-Pierre Roux
2431 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2433 2003-10-21 Jean-Pierre Roux
2434 * garbage Siemens 'Leonardo' images dealt with
2435 (the patch is easy to remove)
2436 * cosmetic changes to avoid warnings
2438 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2439 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2440 no need to press 'r' now.
2442 2003-10-20 Jean-Pierre Roux
2443 * upgrade of checkRead.sh checkWrite.sh according
2444 to new Jpeg Lossless decompressor
2445 * add US.3405.1.dcm, a genuine RGB medical file ...
2446 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2447 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2449 2003-10-15 Jean-Pierre Roux
2450 * general anonymisation in gdcmData
2451 * adding the 'color files' from
2452 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2453 * adding some well knowed bugged-header images
2454 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2455 waiting for their inclusion in Python testsuite
2457 2003-10-15 Jean-Pierre Roux
2458 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2459 no longer seg faults when file is not found
2461 2003-10-14 Jean-Pierre Roux
2462 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2465 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2466 * TODO: *.in file to genereate a UseGDCM later
2468 2003-10-14 Jean-Pierre Roux
2469 * Some supposed-to-be Dicom Images have no preamble.
2470 OpenFile takes it into account
2471 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2472 * Missing elements added in dicomV3.dic
2473 (just to be affraid : have a look at
2474 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2475 and do it again next year ;->
2477 2003-10-13 Jean-Pierre Roux
2478 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2479 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2480 But there are NOT. It's fixed !
2482 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2483 * FIX: "jpeglib.h" was not found on VC++
2484 * FIX: vtkgdcm was not being installed
2486 2003-10-10 Jean-Pierre Roux
2487 * ENH : OpenFile closes the file if it *really* doesn't look like
2488 an ACR-NEMA / DICOM one.
2489 * FIX : testWrite no longer writes an empty file if the source file
2490 is not gdcm Readable
2491 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2494 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2495 * FIX: CMake generate now documentation
2496 * ENH: out of source doc build !
2497 * ENH: Generate both user and dev documentation
2498 * ENH: Should work on windows too
2499 * ENH: Only one doxygen config.in file is needed
2500 * FIX: make install should be ok now on ùnix plateform
2501 * FIX: PATH to dictionary was wrong (missing /)
2502 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2504 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2505 * vtkGdcmReader is now able to read rgb dicom file.
2506 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2507 * added a gdcmViewer to vtk test, use mouse to control
2508 window level & window width
2510 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2511 * CMake-ification of gdcm, we have now two build system
2512 * FIX: on cygwin Wsock32 doesn't exist
2513 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2515 2003-10-06 Emanuel Ollart
2516 * FIX : compilation process wad broken.
2517 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2519 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2520 * change gdcmViewer -> vtkgdcmViewer
2521 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2523 2003-10-06 Jean-Pierre Roux
2524 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2525 ( e.g : well known GE images with a wrong elem length,
2526 : Philips MRI Images with a wrong Huffman table)
2527 * still to be done : allow the reading of bugged LEONARDO Siemens images
2529 2003-10-03 Jean-Pierre Roux
2530 * Odd length strings are padded with '\0' (not with spaces,
2531 to remain compliant with already defined strings,
2532 like Transfert Syntax UID and others)
2534 2003-10-03 Jean-Pierre Roux
2535 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2536 to allow displaying RGB images (not only by affim ;-)
2538 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2539 * vtkGdcmReader is now able to read rgb dicom file.
2540 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2542 2003-10-03 Jean-Pierre Roux
2543 * A few nasty patches to allow the reading of a lot of nasty images
2544 ( e.g : well known GE images with a wrong elem length,
2545 : Philips MRI Images with a wrong Huffman table)
2546 * still to be done : allow the reading of bugged LEONARDO Siemens images
2548 2003-10-03 Jean-Pierre Roux
2549 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2551 2003-10-03 Jean-Pierre Roux
2552 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2553 to allow displaying RGB images (not only by affim ;-)
2555 2003-10-03 Jean-Pierre Roux
2556 * gdcmFile::GetImageDataIntoVector now
2557 - deals with MultiFrames MultiFragments Run Length Encoded files
2558 - deals with YcBcR (YBR_FULL) files
2559 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2560 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2562 (no sample found :-(
2564 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2565 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2566 Two reasons: - clear things
2567 - third parties acces gdcm through header files, so won't
2568 suffer anymore VC++ complains
2570 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2571 * add argv[1] in testvtkGdcmReader.cxx
2574 2003-09-24 Jean-Pierre Roux
2575 * The lines are now eigthy characters long.for
2576 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2578 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2579 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2580 char* to std::string. Thus, the use of strdup becomes useless. (see
2581 previous commis of Malaterre)
2582 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2583 before the last Malaterre's commit.
2585 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * This commit should fix the Debug building under VC++, the problem
2587 was mainly a mixture of debug and release lib being loaded at startup.
2588 * I also remove a depency to a specific C function: strdup. Because I had
2589 to force the link to msvcrtd (whereas strdup is in libc).
2591 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2593 located in the gdcmCommon.h file. All use of reference of tha has been
2594 changed to now use the variable GDCM_UNFOUND.
2596 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2598 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2599 Dicom dictionary. The test suite can now be run again. Note:
2600 I'm note very happy with the " (RET)" changes. I believe this
2601 RETAINED comment should be dropped when parsing the dictionary.
2602 - PACKAGER corrected
2604 - AUTHORS updated and now in alphabetical order
2605 * Makefile.am now exports gdcm.dsw for Windoze users.
2607 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2608 * cygwin complains about missing std:: in subdir Test/
2610 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2611 * remove some methods that are now in gdcmHeaderHelper
2613 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2614 * vtkGdcmReader set spacing and origin correctly
2616 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2617 * Fix a few delete/delete[] mismatch
2619 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2621 interpretation to data given by gdcmHeader. For instance there are
2622 heuristics to get informations (look at different places).
2623 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2624 sorting DICOM images based on different strategies.
2625 * modified Makefiles accordingly.
2627 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2628 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2629 when building in debug mode
2630 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2631 src/win32/gdcmdll.dsp
2632 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2634 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2635 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2638 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2639 * src/win32/libgdcmjpeg12.dsp was not dos format
2640 * src/win32/libgdcmjpeg12.dsp :
2641 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2642 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2644 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2645 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2647 * src/gdcmFile.cxx : bug fix in affectation type
2648 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2649 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2650 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2651 symbols... future problem ?
2653 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * src/win32/libgdcmijpeg12.dsp was missing
2655 * modified gdcm.dsw accordingly
2657 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2658 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2660 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2661 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2662 commit of JPR (before his hollidays to facilitate our work).
2663 * setup.py : bug fix in code. Modifications made while the last commit
2664 of JPR. The code hasn't been tested before the commit... it's so
2665 useless to make that (for best programmer that is JPR) !!!
2667 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * tagged the current version as Version0_3 (i.e. version 0.3)
2670 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2671 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2672 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2673 * *.dsp : modifications to use new libgdcmijpeg8 library
2674 * setup.py : bug fix on VTKPATH variable
2675 * PACKAGER : adding all concerning windows
2677 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2680 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2681 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2682 test suite reported error.
2683 * PACKAGER file added (describes what a packager must do when
2684 packaging a new release).
2685 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2686 * configure.in: upgraded version number to 0.3.0
2687 * fixing build of rpm (through rpm -ta):
2688 - Doc/Makefile.am exports proper doxygen files
2689 - src/jpeg/libijg8/Makefile.am exports the include files.
2691 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2692 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2693 * src/gdcmHeader.h : formatting code
2695 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2696 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2697 We were obtaining error message from vtk. Now, creation of file list
2698 is made in an internal list to prevent this problem.
2699 Bug fix when output is empty.
2700 Bug fix in update of progress value. Previous commit for this was a bad
2702 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2704 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2705 * src/gdcmHeader.h : added method to get the file name
2706 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2707 files. Added method to remove all files on the input
2708 Added FIXME comment concerning the bad parsing of header made by
2709 ExecuteInformation method (in ExecuteData method)
2711 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2713 when using make instal.
2714 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2715 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2717 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2718 * setup.py : adding include dir of jpeg lib to compile all sources
2719 * */Win32/*.dsp : JPR fix for windows compilation
2721 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2722 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2724 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2725 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2727 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * setup.py is again effective on un*x (takes into account the
2729 addon of the jpeg library)
2730 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2731 * Doc/Doxy* updated (includes above enhancements)
2732 * INSTALL now points to web documentation
2734 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2735 * src/gdcmHeader.h doesn't make unnecessary reference to
2737 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2739 * src/gdcm*.[cxx|h] :
2740 - to allow compilation with gcc 3.x
2741 -- clean up of STL usage (added explicit usage of std::)
2742 -- small fixes on exceptions.
2743 Note: linking not tested !
2744 - clean of doxygen comments to avoid warnings at documentation
2746 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2747 dependent convertion).
2749 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * Clean up of previous JPR garbage commit (not even commented in the
2752 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2753 - moved all jpeg related files from src to src/jpeg/libijg8, with
2754 addition/modification of Makefile.am and configure.in.
2755 - the testSuite is still brain damage (not guilty).
2757 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2758 * WrapVTK.py : modifications to get correctly vtk source files to
2760 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2761 (FileName -> Filename)
2763 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * vtk/vtkGdcmReader.[cxx/h]:
2765 - UpdateProgress method should now be effective
2766 - removed the limitation on having only images loaded (as opposed
2768 - when building a stack of images/volume, a lesser number of
2769 gdcmHeader and gdcmFile instances should be used (hopefully
2770 accelerating things).
2771 - when building a stack of images/volumes, files which are not
2772 loadable (wrong path-filename, wrong permissions on existing file,
2773 or file not parsable by gdcm) are replaced with a black image
2774 in the stack (for the caller to notice the problem).
2776 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2779 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2780 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2781 between standard library (std) and vtk library (problems are found
2782 under Windows... thanks Windows !)
2784 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2787 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2789 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2792 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * When compiling with distutils (see setup.py) the C++ compiler is
2794 called with different flags than the default ones (with automake).
2795 In order to fix all those warning, I compiled gdcm with the command
2796 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2797 and went for warning fixes:
2798 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2799 up from unused variables.
2800 - vtk/vtkGdcmReader.cxx: potential bug fix.
2801 * src/gdcmHeader.h: Doxygen warning cleanup
2803 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * gdcmPython/gdcm.i:
2805 - typemaps correction to take into account the systematic replacement
2806 of "using namespace std" with std:: prefix e.g. std::list,
2807 std::string... (cf changes of 2003-05-21).
2808 - gdcmGlob global variable of type gdcmGlobal (defined in
2809 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2810 exported to Python a as cvar.
2811 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2812 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2813 gdcmDictSet.GetPubDictTagNames() and
2814 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2815 C++ static methods).
2816 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2817 with the above changes.
2819 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2820 * setup.py, manifest.in : bug fix under linux
2822 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2823 * Modification of setup.py to compile vtk part too. Then, we have 2
2824 wrappers which must work with same distutils. For that, we have a
2825 generic distutils in distusiltsWrapping.py ; with :
2826 - build_extWrap class to wrap generically all extensions,
2827 - ExtensionWrap base class for all wrapping extension that contains
2829 - Wrapper interface which wrap sources
2830 + In WrapSwig.py we have extension and wrapper for Swig
2831 + In WrapVTK.py we have extension and wrapper for VTK
2832 * MANIFEST.in : modifications to consider vtk directory and new python
2833 files for compilation
2835 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2836 * Added python wrappers of vtkGdcmReader vtk class (see the
2837 source in vtk/vtkGdcmReader.cxx) :
2838 - vtk/Makefile.am now builds a library
2839 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2840 python library (as opposed to _gdcm.so wich are the python
2841 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2842 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2844 - configure.in has an additional flag --enable-vtk that needs
2845 to be set to enable compilation of vtk related code, that is:
2846 + vtk/vtkGdcmReader.so and
2847 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2848 + gdcmPython/vtkgdcmPython.so (see above)
2849 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2850 be read when compressed or when HighBit + 1 != BitsStored),
2851 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2852 the usage of the python wrapper of vtkGdcmReader vtk class.
2853 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2854 * src/*.[h] all occurences of stl classes are now prefixed with
2855 std::, and all occurences of "using namespace std;" where removed.
2856 This is to avoid pollution of global namespace in included files.
2857 Apparently vtk does not avoid this pitfall: when using both
2858 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2859 collision of various stl members (principally cout...).
2860 * gdcmPython/testSuite.py now cleanly removes temprory generated
2862 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2863 comply with above changes)
2865 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2866 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2867 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2868 vtk data structure (an image Flip was required).
2869 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2870 * cosmetic changes in documentation.
2872 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2873 * src/gdcmHeader.cxx: the constructor no longer exits when an
2874 unexisting file is given as argument.
2875 * The subdirectory Data (containing all the images used for the
2876 test suite) is not part of this repository anymore. A new module
2877 containing those images is now available at
2878 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2879 with the name gdcmData.
2880 All the python scripts (including the package initialisation file
2881 gdcmPython/__init__.py) were adapated to take this change into
2882 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2884 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2885 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2886 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2887 demo of the usage of this class.
2888 Compilation of this vtk part is only done when using the --enable-vtk
2889 at configure (or autogen.sh) stage.
2891 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2892 * More memory link related corrections and documentation fixes.
2894 - maximum info is obtained with a command of the form:
2895 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2896 --show-reachable=yes PrintHeader
2897 - the remaining reachable blocks seem to come from the STL
2898 allocation scheme through the usage of map and list. It looks
2899 like this memory cannot be freed but it is not a memory leak
2900 (in fact further invocation to the STL would recollect the
2901 unused memory allthough it cannot explicitely be freed).
2902 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2903 of displaying an image parsed with gdcm and displayed with VTK.
2904 Note: some images don't seem to work e.g.
2905 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2906 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2907 Allthough this weakens the semantics, it is a ditch attempt to
2908 make gdcm more thread friendly.
2910 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2911 * Memory link hunt (by using valgrind through the command
2912 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2913 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2914 gdcmHeader::_dicom_vr.
2915 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2916 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2918 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2920 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2921 * src/Makefile.am now exports all the necessary include files at
2925 * UpdateGroupLength replaced by new one
2928 * UpdateGroupLength re-written using H-Table
2929 (named UpdateGroupLengthNew untill checks are over)
2931 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2932 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2933 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2935 - gdcmHeader::GetPubElValSet removed.
2936 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2937 UpdateGroupLength, WriteElements, Write.
2938 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2939 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2940 carried the same semantics.
2941 - src/gdcmHeaderIdo.cxx changed accordingly.
2942 - gdcmFile::WriteBase now regroups all the codes from previous
2943 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2944 - enum FileType moved to gdcmCommon.h
2945 * src/gdcmHeader.cxx AddDefault trashed
2946 * gdcmGetXSize added
2947 * getimageDataSize now calls gdcmGetXSize
2948 * Test/*.cxx changed to agree with above changes
2950 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2952 (to avoid double call by end user).
2953 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2954 by end user, since gdcmHeader::gdcmHeader now handles it.
2956 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2957 * gdcm/Doc many doxygen changes:
2958 - Doxyfile now has two different versions, DoxyfileUsers that generates
2959 the html.users end users oriented documentation and
2960 DoxyfileDeveloppers that generates the html.developper developper
2961 oriented documentation.
2962 - README changed accordingly
2963 - requirement.txt removed (old design info moved to TODO).
2964 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2965 DoxyMainPage.txt, DoxyPython.txt provide more information.
2966 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2967 be updated by simply regenerating the docs with doxygen and copying
2968 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2969 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2970 all the tests in the form "if (<map>.count() >1)" were removed.
2971 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2972 ill-formed documentation sections.
2973 * src/gdcmHeader.cxx: ditto
2975 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2976 * setup.py fixed for un*x (needed macro for stdint.h)
2977 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2978 un*ces with sh-utils test utility.
2979 * gdcmPython/demo/test.py renamed to PrintHeader.py
2980 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2981 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2982 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2983 * src/gdcm*.cxx JPR's bad inclusion fixed.
2985 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2987 * gdcmPython/demo/test.py changed accordingly.
2989 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2990 * gdcmPython/Makefile.am fixed linking against libstdc++
2991 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2992 * Swig subdir (historical tests of swig version 1.3.17++) removed
2993 * Test/testChangeEntete.cxx some lines commented out in order to make
2995 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2996 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2998 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2999 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3000 hence the user doesn't need this explicit call.
3001 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3002 i.e. LoadElements() call removed.
3003 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3004 - src/Makefile.am declares the proper flag for g++.
3005 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3006 for adding user defined new tags.
3007 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3008 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3009 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3011 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3012 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3013 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3014 src/Makefile.am : the project should properly compile and install
3015 with the autotools, included the python wrappers part.
3016 * gdcm.spec.in : added a spec file for RPM packaging.
3018 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3019 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3021 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3023 to exported to the environement (see gdcmPython/testSuite.py
3025 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3026 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3027 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3028 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3029 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3031 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * gdcmPython/__init__.py doesn't crash anymore when running in
3033 in InstallMode or PreInstallMode but with an environment given
3034 value of GDCM_DICT_PATH.
3035 * src/gdcmDictSet.[cxx/h] coding style.
3037 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3038 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3039 * src/gdcm.h general comments moved to TODO, and README
3040 * src/gdcm.h should now be seen as a user commodity (including it
3041 should suffice to fully use gdcm). It is nowhere including within
3042 any of the kernel files src/*.cxx and src/*.h.
3044 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3046 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3048 * src/gdcm*.cxx only include their corresponding include file
3049 (as opposed to gdcm.h)
3050 * gdcmPython/gdcm.i changed accordingly
3051 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3052 the autogen.sh generated "make snapshot" command to work.
3053 * autogen.sh removed history related references to crea package.
3055 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3056 * distutilsSwigCPlusPlus.py work around some swig portability
3059 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3060 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3061 was done in a last ditch attempt to get setup.py _really_
3062 operationnal. The python/gdcmPython layaout add the advantage
3063 of hidding away the python related distutils specific files
3064 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3065 Alas, the src directory was out of scope (i.e. it's relative
3066 position to setup.py was ../src) which made things impossible to
3067 handle (see previous version of python/setup.py). Crossing fingers...
3069 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * python/setup.py now works on Un*x. (harder than I thougth)
3071 * python/distutilsSwigCPlusPlus.py can now have include files
3072 among the list of sources.
3074 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3075 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3076 * modifications in MSVC projects
3078 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3079 * As stated by the first lines of Test/ExceptionAndPython/README, it
3080 looks like we can move back to original usage of exception within
3081 src/gdcm* and hence remove the errno stuff that was introduced
3082 as a quick and dirty fixture of this problem (added to the TODO).
3083 * Doc/Doxyfile configuration file for Doxygen and corresponding
3084 README file for usage added.
3085 * Test/testWrite.cxx added. This new test comes from a split of
3086 test.cxx that is now reverted to its original purpous i.e.
3087 testing the proper parsing of a Dicom related file.
3088 testWrite.cxx concentrates on testing the IO part of gdcm.
3089 * Test/bug1.cxx (containing a bug on WIn32) added.
3090 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3091 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3092 whose purpose is to publish the content of the TagNames of the
3093 Dicom public dictionary were not accessible without an
3094 instance of class gdcmHeader.
3095 - those methods are now static methods of gdcmDictSet and hence
3096 require no instances at all to be invocated.
3097 - within gdcmDictSet this change required to change some method
3098 to class methods (i.e. are now static) among which SetDictPath
3099 (renamed to BuildDictPath) and LoadDefaultPubDict.
3100 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3101 the above changes by calling the new method classes of gdcmDictSet.
3102 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3103 the above to be effective.
3104 * python/gdcmPython: in order to wrap properly the above changes
3105 for Python, swig version now needs to be > 1.3.17.
3106 * python/gdcmPython/Makefile fixed to adapt itself to new
3107 configure/make shema introduced by Johan Montagnat (thanks for the
3108 contribution). Alas this Makefile cannot be turned into a proper
3109 Makefile.am without some heavy changes in the configure.in
3110 (for python dectection).
3111 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3112 now avoids publishing the empty entries.
3114 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3115 * python/setup.py : bug fix concerning install under windows
3116 ExtraPath reused :-P
3117 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3119 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3120 * Dicts/dicomV3.dic : remove double spaces !!!
3121 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3122 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3125 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3126 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3127 method. Doxygenation.
3128 * src/gdcm.h clean up of JPR spurious comments.
3130 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * python/distutilsSwigCPlusPlus.py now properly collects the
3132 shadow classes generated by "swig -c++" (gdcm.py in our case)
3133 when using "python setup.py install".
3134 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3135 reexports the working classes.
3136 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3137 by the classical C errno scheme. This is to prevent an obscure
3138 behavior of the python wrappers when importing wxPython.wx prior
3139 to gdcmPython (which ended up in an abort call). An illustration
3140 of this oddity can be found in the Test/ExceptionAndPython
3141 subdir (see the README file). This problem probably due to
3142 an combination of g++ and dynamic loading.
3143 * added Test/ExceptionAndPython (see above)
3145 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3146 * Changed the layout of the python part to avoid bloating main
3147 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3148 i.e. the distutils arsenal. All the python related stuff is
3149 again in a python subdir, but the package itself is now in
3151 * setup.py was cleaned up:
3152 - pythonIncludePath removed
3153 - python setup.py bdist target is now functional.
3154 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3155 collision with other packages). gdcmPython/demo/*.py changed
3158 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3159 * python subdir moved to gdcmPython (preparation of distutils packaging).
3160 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3161 distutils installer is operational.
3162 * - gdcmPython/__init__.py now properly loads the swig generated
3163 shadow classes (from gdcm.py).
3164 - gdcmPython/demo/*.py changed to import the package gdcmPython
3165 instead of gdcmPython/demo/load.py.
3166 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3168 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3169 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3170 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3171 entries within the associated public Dicom dictionary resp. the same
3172 information but sorted by the fourth field (PAT, IMG, DIR) of the
3174 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3175 are now in the "???" group.
3176 - python/gdcm.i changed accordingly,
3177 - python/demo/printGroupedPublicDict.py added, that gives an example
3178 of the above new functionalities in Python.
3180 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3181 * src/gdcm.h, gdcmHeader.cxx:
3182 - historic references to glib's g_malloc and g_free (#defined)
3183 were definitively removed.
3184 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3185 * src/gdcmElValSet.cxx:
3186 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3187 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3188 - GetElValue(string) renamed to GetElValueByName.
3189 - Added GetElementByName(string).
3190 * src/gdcmHeader.cxx: added
3191 - GetPubElValRepByNumber(guint16, guint16)
3192 - GetPubElValRepByName(string)
3193 - GetShaElValRepByNumber(guint16, guint16)
3194 - GetShaElValRepByName(string)
3195 - GetShaElValByNumber(guint16, guint16)
3196 - GetShaElValRepByName(string)
3197 - GetElValRepByNumber(guint16, guint16)
3198 - GetElValRepByName(string)
3199 - GetElValByNumber(guint16, guint16)
3200 - GetElValRepByName(string)
3201 * Doc/requirements.txt added.
3203 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3204 * Test/Makefile building now depends on the one of libgdcm.so
3205 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3206 pixel data) aware which enables finding the address (offset) of
3207 the pixel data of JPEG encoded DICOM files. This leaves only a single
3208 file in the testSuite whose pixel data address (offset) is unknown.
3209 * python/testSuite.py changed accordingly.
3211 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3212 * VC++ has some strong limitations when working with the STL, as stated
3213 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3214 "Also note that some STL containers (map, set, queue, list, deque)
3215 cannot be exported. [...]
3216 Some STL classes contain nested classes. These classes can not
3218 This is caused by a designed limitation that once a template
3219 class is instantiated, it can not be re-instantiated and
3221 Since our usage of map<> is ubiquitous in gdcm, this "designed
3222 limitation" of VC++ is a pitfall.
3223 Hence the Python wrappers of gdcm cannot be incrementally linked
3224 against the c++ dynamic library. The dirty but only workaround is
3225 to forget about incremental link of dynamic libraries and to generate
3226 the Python wrappers library with the inclusions of the underlying C++
3228 The following modifications concern this matter on Win32/VC++:
3229 - wrapping python correct with standalone wrapped dll (don't use separate
3230 dll under windows !!!!)
3231 - python21_d debug mode enabled (ask Frog how to use it :-)
3232 - NO problem with having an STL member of class for example string in C++
3233 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3234 - Python test of dcmlib in Python is ok under windows on a large set
3236 * removed glib references
3237 * typedef's inserted in gdcm.i for correct swig type management
3239 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3240 * python/demo/*.py load.py extracted from test.py. Added explore.py
3241 that only displays required tags and testAll.py that parses all
3242 the files of the testsuite without using unittest.
3243 * python/testSuite.py other additional test on new files added.
3244 * Data/* new test files added accordingly to the testSuite.
3245 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3246 the vr in the file differs from the one of the dictionary.
3248 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3249 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3250 values, but limits itself to values which are below a user specified
3251 size (by default 1024 bytes).
3252 * python/gdcm.i : elements not loaded (because their size is above the
3253 user specified treshold) are exported with their TagKey as key of the
3254 python dictionary. This enables the testsuite to make some checks
3255 on the unloaded elements (since we have their offset and size).
3256 * python/testSuite.py
3257 - now tests for the existence and proper value of the pixel data
3258 - two new examples added.
3259 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3261 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3262 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3263 aware. See the strategy comments in gdcmHeader::FindLength().
3264 * Test/test.cxx now accepts a filename as first argument.
3265 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3266 * python/testSuite.py changed to integrate test on above files.
3268 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3269 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3270 the vr was also RET.
3271 * python/testSuite.py more tests added.
3273 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * python/testSuite.py unittest test suite added (uses Data)
3275 * Data/* dcm and acr files for the test suite.
3276 * glib dependance removed from un*x version. We now use ISO C99
3277 7.18 Integer types (see stdint.h)
3278 - python/Makefile, src/Makefile src/gdcm.h
3279 * src/ when an explicit vr (like dicom files) suddenly poped an
3280 implicit element we use to mark the underlying DictEntry of the
3281 concerned ElValue with "Implicit". This strategy was damageable
3282 too the public or provite dictionaries, since some of their vr
3283 would be changed. Since Header::FindLength heavily relies on the
3284 detection by Header::FindVR of falsely explicit elements, I
3285 added an extra ImplicitVr member to ElValue (boolean).
3286 The rest of the changes we the necessary adaptations.
3288 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3289 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3291 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3293 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3294 * Adaptation for porting to VC++:
3296 o forced to use std namespace (for string to be known)
3297 o all class use __declspec export style on WIN32
3298 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3299 (in stdlib.h on Win32 but in std:: for gcc)
3300 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3301 variable GDCM_DICT_PATH.
3302 * src/gdcmHeader.cxx verbose comments made discrete.
3304 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3305 * python/gdcm.i: added a typemap that converts a C++ hashing table
3306 to native Python dictionary.
3307 * python/demo/test.py:
3308 - now uses the native dictionary for exploration of gdcmHeader.
3309 - takes an optional filename argument (the file to parse).
3310 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3311 PubElVals hashing table.
3312 * Dicts/dicomV3.dic removed error prone trailing spaces.
3314 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * Python wrapping process moved away from src/Makefile to
3316 newly created python/Makefile (as well as gdcm.i)
3317 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3318 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3319 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3320 from the environement variable GDCM_DICT_PATH (when existing).
3321 * src/gdcmDict::GetTag bug fix.
3323 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * Straightforward temporary fixes for swig to build the python wrappers.
3325 src/Makefile now has a python working entry [by working we mean
3326 that we can import the shadow classes without errors].
3328 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3329 * hashtest.cxx removed (since already in Test)
3330 * src/gdcmlib.h renamed to src/gdcm.h
3331 * src/dcm.i renamed to src/gdcm.i
3332 * src/Makefile prepared for python wrapping
3334 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3335 * src/gdcmHeader.cxx :
3336 - Parsing of header is now separated from loading of element values
3337 (see gdcmHeader::LoadElements).
3338 - general clean up of hopefully all file access (creation of
3339 ReadInt16 and ReadInt32)
3341 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3342 * src/gdcmHeader.cxx :
3343 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3345 - SetLgrElem renamed to SetLength
3346 - GetLgrElem renamed to GetLength
3347 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3348 * src/gdcmElValSet.cxx fixed both GetElValue methods
3349 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3350 due to IdoDude was cleaned out.
3352 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3354 concentrates on finding the value representation (when it exists).
3355 RecupLgr now only finds the element value length, and it avoids
3356 returning the unecessary skL (skipped length).
3357 Also, offsetCourant was simply removed (with taille_fich) since
3358 it was redundant with the File position internals (by using
3359 ftell and fseek). This also made skL (see above in RecupLgr) usage
3361 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3362 on the libido specificities which are handled through class
3364 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3367 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3368 * Truckload of changes. Parsing of header is barely functional
3369 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3371 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3372 * src/gdcmHeader.cxx many addons of low level methods
3374 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3376 and _IdDcmSWAP_LONG.
3378 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3379 * This corresponds to all the changes decided at the meeting of
3380 May 23 2002. Needless to say we are running late...