1 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Fix bug on MacOSX with static initialization in a multui threaded
3 environement. static const string in a header file used to be ill
4 initialized provoquing the freeze of any tests. patch should solve this
7 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
8 * According to Benoit's suggestion, and without any objection from anybody
9 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
10 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
11 - method gdcmDicomDirObject::GetEntry() renamed as
12 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
14 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
15 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
16 you debug/warning message just as c++ streams which make them very convinient
17 to use. Once this is stabilize I will change the ostringstrem to be
18 redirected to a file (ofstream).
19 * Properly support C99 extension: __FUNCTION__ which allow us to display
20 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
22 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
23 * Removal of useless and dangerous methods :
24 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
25 GetDocEntryByName, GetEntryByName, GetDictEntryByName
26 * Removal of usless methods :
27 Dict::PrintByName, Dict::GetDictEntryByName
28 * Commenting out of probabely useless methods :
29 Dict::GetDictEntryNames()
30 Dict::GetDictEntryNamesByCategory()
31 DictSet::GetPubDictEntryNames()
32 DictSet::GetPubDictEntryNamesByCategory()
33 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
34 * ENH : Use dicomTS.dic as described in 2004 version
35 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
36 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
37 Add Accessors on VM (Value Multiplicity), and VM related methods
38 * ADD : Add a list of 'Dicom Attribute types', as found in
39 http://medical.nema.org/dicom/2004/04_15PU.PDF
41 * ADD : Add dicomGroupNameAbbreviations.dic
42 should be used to write a method to replace the former
43 Dict::GetDictEntryNamesByCategory()
45 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
47 to read in the file... and only it ! Length is the efective length of the
48 data in the DocEntry structure
50 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
52 And now use a static function call instead, with a global variable. i
53 This is much closer to the VTK approach. Hopefully should be bulletproof
54 and easier to use...hopefully
56 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
57 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
59 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
62 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
64 ValEntry, BinEntry, SeqEntry creation or replace
66 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
68 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
70 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
71 when specifying the VR
72 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
73 * src/gdcmDocEntry.cxx : amelioration of print
75 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
76 * ADD : Add the method Util::IsCurrentProcessorBigEndian
77 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
78 * ADD Method Document::ComputeGroupLength
79 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
80 in order to allow further VR modification by user
81 * REM : removal of once-called method File::WriteBase
82 integration of its code in formerly one-line method File::Write
84 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
86 replace the different values "??", "Unkn", "Unknown".
87 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
88 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
89 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
90 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
92 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
95 * Set the gdcm::Base class to some Printable classes
97 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * src/gdcmFile.[h|cxx] : add the Print method
99 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
100 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
101 * src/gdcmDocument.h : remove the PrintLevel informations
102 * Example/PrintFile.cxx : use the new gdcm::File::Print
104 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
106 problems when compiling with the python wrapping
108 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
110 writting in ImplicitVR
112 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
113 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
114 JPEG decompression, especially when dicom frames are split into several
115 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
116 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
118 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmHeader.cxx : change the initialisation of default header.
120 Now, this header is readable by gdm, e-film, DicomWorks
122 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
124 Rename Decompressed to Raw
125 * Use the API changes in gdcm::File.
126 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
129 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
131 each added entry in the header. Replace the 'Planes' field by the 'Number
134 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
136 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
138 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
140 At this time, this image isn't readable by e-film... waiting JPR help to
143 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
145 DocEntry. Now use methods of the Document !
147 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * Test/ShowDicomSeq.cxx : bug fix
150 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
152 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
153 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
154 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
156 * Test/TestCopyRescaleDicom.cxx : remove unused variable
157 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
158 containing found sequences
160 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
163 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
164 Some fields in BinEntry must be copied to not seg fault when making the :
165 gdcm::File *copy = new gdcm::File( copyH );
166 and tests are now made on good variables
168 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
170 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
172 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
173 * Add vtkGdcmWriter example and test
175 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Test/TestUtil.cxx : reformat the source code
177 * vtk/vtkGdcmReader.cxx : remove and change prints
178 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
180 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
181 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
183 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
185 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
187 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
189 by an eof to prevent all bad read of the file... and in this case, the
192 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * Example/Volume2Dicom.cxx : comment unused variables
194 * Test/PrintDicomDir.cxx : comment unused variables
195 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
196 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
197 method that is redondant with AddEntry.
198 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
201 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * Bug fix due my last commit (compilation under Windows).
203 * Example/Volume2Dicom : bug fix in the file and reformatting source code
204 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
206 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
208 - Remove printf / sprintf
209 - include iostream AFTER gdcm so we don't get warnings
210 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
212 - Also remove tons of include from header files, hopefully this should
213 speeup the compilation time, since it was becoming a dog slow.
214 - Remove gdcm.h as it include way too many files and slow down compilation
215 (plus it is not up to date)
216 - remove 'using namespace std' this is BAD !
218 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Remove memory leaks on the DicomDir
220 * Remove some useless data in DicomDirObject
221 * Add usefull methods in SQItem, to be complient withe the ElementSet
223 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
226 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
228 future, with convertion)
229 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
230 and ImageDataSize values. Remove the method to get the PixelReadConverter
231 from the output of the class
233 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
236 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
238 and vtkErrorMacro use.
239 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
241 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
244 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
245 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
246 The string leaves only in the fonction. So when we make a .c_str(), we
247 get the pointeur on the first element, element that will be destroyed
248 immediately after thee instruction.
249 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
250 file has been opened : the test must be made on the content of the
251 pointer and not directly on the pointer !
254 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
256 the python part recompiles
258 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
260 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
261 X session is killed (for my computer... it seems to not be identic on
264 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
266 avoid problems (otherwise, the difference test between the visible image
267 and the reference is incorrect. If the reference is greater than the
268 screen resolution, it's produce errors).
269 Can be used for only one image. Can be used with a visible flag.
270 * vtk/vtkGdcmReader.cxx : remove commented codes.
271 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
272 under windows at compilation
273 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
275 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
277 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
279 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
280 tests on the image size X, Y, Z
282 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
284 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
285 between the class name and the file name
287 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/ : fix compilation warnings for the Write method (2 different
289 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
290 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
291 variable... create a static method in gdcm::Document to access to
292 this variable content.
294 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
296 file, to be accessed by other files (like gdcmFile). Remove commented
297 code. Move the change of the header to the gdcmFile, using the
299 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
300 To be sure of that (and simplify calls), the Write of the header now
301 gets a file name and not a file pointer (std::ifstream).
302 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
303 DocEntryArchive. Remove all open of the written file
305 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
308 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
310 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
312 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
313 some corresponding methods. Write correctly the file and check before
315 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
316 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
317 is now on RGB data (as before my last commit
318 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
320 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
322 Add a print information of the type of the entry
323 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
324 It was in the gdcmFile, and all write have been regrouped
325 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
326 Write correctly all dicom files (in decompressed mode only at this time)
327 * Test/ : test on files are now made using Raw data and not color data if
329 * Example/PrintFile.cxx : add more printings
331 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * Amelioration of code, remove some code copy. For the loading of
333 BinEntry (in gdcmDocument), add the test to verify if the file is already
336 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
338 remove a DocEntry in the header (push an empty DocEntry)
339 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
340 lines. Bug fix in the initialization of the PixelConvert and the
342 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
343 use in TestCopyDicom (now this test can run under windows... but fails)
344 * Test/TestCopyDicom.cxx : amelioration of the test :
345 - test the pixels written
346 - add test points to quickly find where is the error
347 - can set a file name input and output in arguments
348 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
349 amelioration of the test output
351 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
353 all replaced DocEntry's
354 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
355 Now, each needed DocEntry to modify is duplicated, modified and inserted
356 to the header using DocEntryArchive. Thus, after save, we can restore the
357 header initial state.
359 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
362 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
364 correct to copy it. The DictEntry is specified at the DocEntry creation,
365 then, it musn't change in the time.
366 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
367 header correctly. At this time, the change is only made for the first
368 level of the Document. In the future, it might consider sequences.
369 The change is made by replacing a DocEntry by an other that is created
370 outside the class. The old value is kept. When we restore the header
371 status, the added DocEntry is deleted and replaced by the old value.
372 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
373 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
374 set the write type to explicit VR, implicit VR or ACR. Add methods to set
375 the write mode to native, decompressed or RGB (but not used at this time)
377 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
378 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
379 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
381 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
382 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
383 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
385 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
386 set because already copied when copying the BinEntry's of the header
387 * Test/TestAllReadCompareDicom.cxx : remove warnings
389 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
390 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
391 Two problems appear when doing it :
392 - with the gdcmFile : when the GetImageData method is called, the pixels
393 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
394 data (pixels). And each structure destruct the data when it's
395 destructed. So we have two destructions for the same data. To solve it,
396 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
397 data or not. If it doesn't own data, then they will not destroyed by
399 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
400 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
401 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
402 create a double destruction of the same DocEntry's. So, to solve it,
403 the TagHT is simply cleared and the DicomDir* elements are destroyed.
404 * TODO : add an entry concerning memory leaks in the DicomDir
406 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
408 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
411 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
413 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
414 after it have been deleted
416 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * FIX: src/* fix the doxygen warnings.
418 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
419 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
420 was erroneously defined with a size of 15 instead of 16. [many thanks
421 to Jean Michel Rouet for pointing out this bug].
423 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
424 1. Finish merging JMR patch for writting DICOM from scratch
425 2. Fix -hopefully- bug with MONOCHROME and space vs null character
426 3. Use const ref when possible
427 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
428 5. A few more comments
429 6. CreateUniqueUID can now be called without parameter"
431 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
432 * ENH: Slightly bigger patch:
433 1. Getting toward full integration of JMR patch for writting dicom from scratch
434 2. Update Test to test part of this patch: CreateUniqueUID
435 3. File was not close properly in gdcmDict
436 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
437 5. Use of const ref instead of copy (speed issue)
438 6. Remove temporary (duplicate) string in TranslateToKey
439 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
440 8. Do not repeat virtual in subclasses
441 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
443 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 * Apply first patch toward better string comparison when dealing with broken
445 DICOM files. Essentially the string could be padded with a space instead
446 of a null character as defined by standard
448 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
450 because never used... and in the same time, that's remove some memory leaks
452 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/gdcmFile.cxx : now delete the PixelConvert instance.
454 * In examples and tests : change the type of image data variables from void*
455 to uint8_t*. Remmove all delete on image data variables
457 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
459 Verify the file pointer value before open the file, and if it's not null,
460 a verbose message is generated.
461 Close correctly the file when the file isn't considered dicom-like. The
462 correctly close is a call to CloseFile.
463 When closing the file pointer, test if its not null to close the file.
464 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
465 file. For an uncompressed image, the copied data correspond in the least
466 case to the image size (calculated) or the image size specified in the
467 header. A verbose is generated if these two size mismatch
469 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
471 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
472 break under windows (with msvc6 compilation).
474 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
476 compiling with MSVC6)
478 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * Bugs fix for the Windows build with VC6
480 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
481 needed (only for projects required VTK). If the VTK is included in all
482 projects, there is conflicts with the jpeg lib of vtk when compiling the
483 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
484 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
485 when compiling the gdcm_wrap.cxx file (created by the compilation of the
487 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
488 (like it's already made for the cout use). Otherwise, conflict with the
491 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
494 - comments on the DicomDir::Method related usage added.
495 - now that we use the namespace gdcm, a lot of internal classes do
496 NOT need to be wrapped anymore.
497 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
498 DicomDir::Method) new example added.
500 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Improve string manipulation. I now inforce the notion of 'DicomString'
502 A DicomString can contain as many \0 as they want
503 and it is *always* of even length.
504 We only support odd length for very rare case.
505 And in the near future this should be removed.
507 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
508 * /binary_write/ gdcm source. Now even on big endian we are writting
509 little endian. This should -heopfully- fix some tests
511 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
512 * Now the dictionary is compiled into gdcm lib. This is a default
513 behavior, thus any dic file specified is picked before failback to
514 the one comiled into lib
516 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Change internals for gdcmDict. Don't use any 'new' any more.
518 This should definitely solve any leak problem, and we should be
519 as fast as before, as long as don't modify too much the dictionary.
521 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
522 * STYLE: ivars should start with a capital letter.
523 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
524 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
526 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
528 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
529 new 2004 dictionaries added (thanks to JPR).
530 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
531 * CLEANUP_ROUND (15) for gdcmPixelConvert
532 - RLEFrame::NumberFragments is now of type unsigned int
533 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
534 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
537 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
538 * Initial work in gathering all transfer syntax accessors. clearly
539 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
540 ivars, but only one transfersyntax (class) ivar with equivalent method on
543 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
545 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
546 discussed (plus I didn't like having a 2000 lines patch not commited)
548 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
550 * CLEANUP_ROUND (14) for gdcmPixelConvert
551 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
552 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
553 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
555 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
556 anymore and hence avoids storing a copy of PixelConvert::Decompressed
557 into File::Pixel_Data.
559 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
561 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
562 * CLEANUP_ROUND (13) for gdcmPixelConvert
563 Substituted File::ParsePixelData() with PixelConvert::Print() new
565 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
566 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
567 method to those classes.
568 - src/gdcmFile.[cxx|h]:
569 -- Added a ::Print() method.
570 -- PixelConverter is now a reference instead of a member.
571 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
572 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
574 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
576 collaboration diagram and inheritance diagram should be generated with
578 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
579 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
580 pointlessly wrapped (see
581 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
582 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
583 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
584 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
585 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
586 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
587 -- File::Initialise: PixelConverter setup moved away to
588 PixelConverter::GrabInformationsFromHeader()
589 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
590 interpretation moved away to PixelConverter::BuildRGBImage()
592 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
593 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
594 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
596 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
598 displayed on Win32 when a brutal abort() occurs (because of uncatched
599 exception). See TODO new entry of this commit for more on this.
600 * TODO added new entry.
601 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
602 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
603 - HandleColor is no longer called from gdcmFile.cxx
604 - gdcmPixelConvert.cxx clean up on method arguments and internal
605 variable names for semantical coherence.
607 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
608 * Finished lossless transition, not only do we now read all lossless jpeg
609 images, without the need of the Cornwell lib, but we do read them properly now
610 * To reduce code (well to avoid code duplication), I defined a common place
611 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
612 redefine symbols. This is not prefect but this the best solution I found for a
613 compilation time jpeg option.
615 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
616 * Update jpeg ijg lib to support lossless jpeg implementation
617 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
619 * Also added a special copyright for dcmtk since we use their bugfixes.
622 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
624 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
625 matters, as stated in warning note at begining of %include section).
626 * src/gdcmDicomDir*.[cxx|h]: coding style
627 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
628 * src/gdcmJpeg8.cxx: doxygen fix.
629 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
630 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
631 from File:: to PixelConvert::.
633 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
635 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
636 - more code moved away from File:: to PixelConvert::
637 - fat setup of PixelConverter set in place in File::Initialise.
639 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
640 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
641 namespace at the file system level. So now you should convert your examples
643 gdcmHeader -> gdcm::Header
644 It would be nice if people keep in mind to no open the namespace, since it
645 allows compilation on broken plateform which were defining common symbol in
646 the standart namespace (like LP, Unknown ...)
648 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
650 The JPEG fragments are now parsed at the same stage than the RLE
651 information. All code related to JPEG is now in gdcmPixelConvert:
652 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
653 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
654 export a gdcmFile:: method. Those are simply global functions
655 (for the time being this is better than having them attach to
656 either gdcmFile:: or gdcmPixelConvert::).
657 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
658 and stores the result in a gdcmJPEGFragmentsInfo.
659 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
660 code (among other stuff) moved away from gdcmFile:; to
663 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
665 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
666 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
667 clean up of RLE related code.
668 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
669 - src/gdcmRLE.cxx removed
670 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
671 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
672 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
673 * CLEANUP_ROUND (9) for gdcmPixelConvert
674 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
675 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
676 away from gdcmFile:: to gdcmPixelConvert::.
678 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
680 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
681 This is because Parse7Fe0 used to parse the pixels to compute the
682 length. This task was passed over to FindDocEntryLengthOB() a long
683 time ago, EXCEPT I had forgotten the OW case...
684 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
685 we just recylce the code for parsing RLE fragments and computing
687 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
688 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
689 with the retired Parse7Fe0().
690 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
691 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
693 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
695 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
696 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
697 - src/CMakeLists.txt: alphabetic order reodering + new entries.
698 * CLEANUP_ROUND (4) for gdcmPixelConvert
699 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
700 to return an unused length.
702 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
703 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
704 this should be cleanner from the plane view. The iostream are erally a pain
705 to use to do simple stuff.
707 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
708 * Redo the compilation of the ijg jpeg library. Now only one source is
709 necesseray. No need to rename file by hand what so ever. CMake handle the
710 copying of the file within different directory, configure header file to
711 modify some symbol. The only addition made to ijg wasd a mangle table so
712 that symbol are different wether we are within 8bits or 12bits.
714 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * Added documentation of vtkgdcmReader on Website:
716 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
717 with it's binary name).
718 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
719 the Website to be more complete.
720 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
721 doxygenated documentation.
722 - Doc/DoxyVtkGdcmReaderExamples.txt added
723 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
724 DoxyVtkGdmReaderExamples.html )
725 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
726 * CLEANUP_ROUND (3) for gdcmPixelConvert
727 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
729 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * CLEANUP_ROUND (2) for gdcmPixelConvert
731 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
733 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * CLEANUP_ROUND for gdcmPixelConvert:
735 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
736 - src/gdcmPixelStuff[h|cxx] removed
737 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
738 - src/CMakeLists.txt changed accordingly
740 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
741 gdcmVersion.py moved to newly created ATTIC related
742 gdcmPython/SetupOldies/ directory.
743 * Autotools clean up:
744 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
745 - autogen.sh configure.in acinclude.m4 python.m4 removed
747 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * src/*.cxx *.h Reference to License.htm fixed to License.html.
749 * Doc/CMakeLists.txt, doxygen.config.in: fix.
750 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
752 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
753 * TODO updated with Mathieu suggestions. I proposed a template for
754 describing TODO entries and used it for new entries.
755 * Added Doc/Website/CodingStyle.html, Developpers.html,
756 DeveloppersPython.html, GdcmDataCvs.html and
757 DownloadVersion0_1.html, DownloadVersion0_3.html.
758 * Some Doc/*.txt Doxygen files (which do not really concern the
759 documentation itself, but the website) moved to html and
760 placed in directory Doc/Website:
761 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
762 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
763 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
764 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
765 * CMakeLists.txt changed accordingly.
766 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
767 DeveloppersPython.html
768 * INSTALL nows refers to Doc/Website/Installation.html
770 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * Added Doc/Website directory, that contains a first raw version
774 2004-09-23 Jean-Pierre Roux
775 * FIX In order not to be poluted any longer by casting problems,
776 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
777 we can now delete[] it safely
778 * VoidArea is now called BinArea (less confusing name),
779 and all the methods called ...VoidArea... are now ... BinArea...
780 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
782 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
784 clear) TagHT, which is an inherited member of gdcmElementSet. It is
785 up to the destructor of gdcmElementSet to clean up TagHt and it's
788 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * Test/CMakeLists.txt: update to follow gdcmData renamings.
790 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
792 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * ENH: added some utility method that builds a flat dictionnary
794 holding all the Dicom entries contained in the recursive structure
795 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
797 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
798 BuildFlatHashTable() that build a flat dictionary.
799 - src/gdcmElementSet.h: added a new private GetTag() accessor.
800 gdcmDocument is now a friend of gdcmElementSet.
801 - src/gdcmElementSet.cxx: clean up.
802 - Example/FlatHashTablePrint.cxx added.
803 - Example/CmakeLists.txt changed accordingly
805 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
806 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
807 moved away from gdcmDocEntrySet (since this class is an abstract class
808 acting like an interface). SQDepthLevel and BaseTagKey are now
810 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
811 and associated accessors. Doxygenation of the class.
812 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
814 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
815 Use SQDepthLevel accessor instead. ::Print() adapted.
816 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
817 - src/gdcmDocument.cxx changed accordingly.
819 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
821 - The following is the doxygen comment of the typedef declaration
822 of gdcmagKey in src/gdcmCommon.h:
823 gdcmTagKey is made to old an "universal" (as in URL, Universal
824 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
825 A dicom tag allways has a group and an element, but a set of tags
826 embeded in various (optionally nested) sequences and sharing
827 the same group and element all share the same (group, element)
828 "identifier". Hence the (group, element) cannot be used as an
829 identifier (in gdcm we shall refer to a "TagKey") of a tag.
830 In order to construct a proper tag identifier (i.e. a key) we
831 consider the following definition of a TagKey:
832 - let Group, Element be the string representation of the
833 group and element dicom tag members,
834 - let ItemNumber be the string representation of the integer
835 index of the considered item number of a sequence,
836 Let the key of a tag embeded in a sequence, noted SeqTag, be
838 /ItemNumber#Group|Element
839 where "/", "#" and "|" are characters acting as separators.
840 Then the general form of a gdcmTagKey is given by:
841 Group|Element<SeqTag>
842 where <SeqTag> means NO or many instances of SeqTag.
843 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
846 but the gdcmTagKey of a tag "embeded" is the first item of
847 a sequence, itself nested in the third item of a sequence is the
849 0004|1220/2#0008|0082/0#0008|0090
850 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
851 order to hold the new sequence compatible key. Previously, the
852 GetKey() method would look in the underlying gdcmDictEntry.
853 - src/gdcmDocEntry.cxx:
854 -- constructor now copies the underlying DictEntry key, in the local
856 -- ::Print: displays the member Key, instead of the (group, element).
857 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
858 - src/gdcmDocEntrySet.h:xi
859 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
860 -- now has a new BaseTagKey member.
862 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
863 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
865 This poses the problem with the semantics of the following lines
866 LoadEntryVoidArea(0x0028,0x1201); // R LUT
867 LoadEntryVoidArea(0x0028,0x1202); // G LUT
868 LoadEntryVoidArea(0x0028,0x1203); // B LUT
869 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
870 to the long FIXME note for what the problem is. Nevertheless in
871 order to get things working the dicom dictionary was altered !
872 Please fix things urgently...
873 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
874 information), see above note on moving the member VoidArea. Nevertheless
875 the following entries previously correctly set as US are now inproperly
877 0028 1201 OW IMG Red Palette Color Lookup Table Data
878 0028 1202 OW IMG Green Palette Color Lookup Table Data
879 0028 1203 OW IMG Blue Palette Color Lookup Table Data
880 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
881 of gdcmDocEntry moved to gdcmSeqEntry.
882 * src/gdcmSeqEntry.cxx: STYLE.
884 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * Test/TestAllEntryVerify.cxx minor fix and added comments.
887 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * gdcmPython/testSuite.py: all the test suite in python is now moved
889 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
890 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
891 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
893 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
894 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
895 to avoid inclusion recursion until STL is reached.
896 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
897 mecanism. errno.h is not included in gdcm anymore.
898 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
899 (gdcmFormatError now inherits from gdcmFormatUnexpected).
901 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
902 gdcmData/TestAllEntryVerifyReference.txt
903 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
904 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
905 exception_on_error parameter.
906 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
907 - vtk/vtkGdcmReader.cxx changed accordingly,
908 - Example/*.cxx and Test/*.cxx changed accordingly.
910 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
912 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
913 enable_sequences removed from gdcmHeader constructor and dependencies.
914 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
915 * gdcmPython/demo/PrintHeader.py: dummy fix.
916 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
917 skip_shadow removed from gdcmHeader constructor and dependencies.
918 * Example/*.cxx and Test/*.cxx changed accordingly.
920 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
921 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
922 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
924 2004-07-21 Jean-Pierre Roux
925 * FIX Now, Parsing and Printing a DICOMDIR do work!
926 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
928 2004-07-20 Jean-Pierre Roux
929 * FIX Some brain damaged headers have Zero-Lenght fields
930 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
932 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
933 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
934 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
935 variable (instance of gdcmDebug) by a definition macro, and the instance
936 is now in static in the gdcmDebug class
937 * src/gdcmSQItem.h : (FIXME) remove an undefined method
938 * Test/PrintAllDocument.cxx : bug fix in the result of the test
940 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * WARNING: ctest now depends more tightly on gdcmData. You should
942 check out gdcmData properly for things to run smoothly...
943 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
944 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
945 we need the pixels not be loaded in order to use the ValEntry
946 that displays position and size).
947 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
948 This is a C++ based equivalent of gdcmPython/testSuite.py that should
949 be deprecated. If you have any doubts about the advantages of a
950 modern scripting language (read Python) versus grass root C++ (i.e.
951 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
952 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
953 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
954 Anyhow, consider documenting the gdcmData images in
955 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
957 * Test/CMakeLists.txt:
958 - now uses TestAllEntryVerify.cxx
959 - specific comments on oldACR00001.ima (now renamed in gdcmData
960 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
961 gdcmData/TestAllEntryVerifyReference.txt
964 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
965 * src/*.[h|cxx] : typedef clean up
966 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
967 - TagKey renamed to gdcmTagKey (for external usage)
968 - VRKey renamed to gdcmVRKey (for external usage)
969 - removal of typedef duplication.
970 - Removed all unecessary inline keyword from class inline definitions.
971 - Some method|function(void) declarations replaced with method|function().
972 * src/jpeg/libijg12/jdhuff12.c:
973 - printf polluting ctest removed.
974 - TAB removal for comminting
976 - TestAllReadCompareDicom.cxx: added a test that compares all the
977 images in gdcmDataImages.h with corresponding images in
978 gdcmData/BaselineDicom/. When baseline images are not present
979 this test creates them.
980 Note: we need to validate each reference image, but before that
981 I'd like to rename them with a more explicit name...
982 - CMakeLists.txt: changed accordingly.
983 * Example/*.cxx: examples now only include gdcm.h (as opposed to
984 including each header needed).
986 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * Test/*.cxx and Example/*.cxx: moved some examples away from the
988 test suite to the Example directory. Are concerned:
993 - TestWriteSimple.cxx
994 * Test/CMakeLists.txt: added some comments on reasons for black listing
995 image gdcmData/oldACR00001.ima
997 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * Test/CmakeList.txt: removed the following from black list (to be coherent
999 with removal from gdcmData):
1000 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1001 - gdcm-MR-PHILIPS-16.dcm
1003 Added the following because after last cvs update, they cause
1004 ctest -R TestReadWriteReadCompare
1006 - gdcm-MR-SIEMENS-16-1.acr
1008 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1009 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1010 new comments in this file) we temporarily (sigh) move to a weaker
1012 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1013 we don't need to black list the following images anymore:
1014 - 8BitsUncompressedColor.dcm
1016 - US-PAL-8-10x-echo.dcm
1017 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1018 fixes and the beautified code ;-)
1019 This fixes the bug introduced in version 1.42 (when beautifying)
1020 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1021 Note: ctest was blind to this bug (this means we need to still
1022 improve the test suite). The bug could be detected by using
1023 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1025 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1026 and by displaying the (garbage) produced file temp.XDCM...
1028 2004-06-29 Jean-Pierre Roux
1029 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1030 - replace by uggly but working old code :-(
1031 A lot of things should be OK again.
1032 It's really urgent to have a test suite that *tests*,
1033 to prevent Frog's beautifying sessions to break all the stuff
1034 (twice, withing a fortnigh ...)
1036 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1038 redundancy) to added Test/TestReadWriteReadCompare.cxx
1039 * Test/CmakeList.txt: because the compare test of
1040 Test/TestReadWriteReadCompare.cxx fails, the following images are
1041 black listed: - 8BitsUncompressedColor.dcm
1043 - US-PAL-8-10x-echo.dcm
1044 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1045 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1046 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1047 and ad-hoc kludge. This kludge is now removed, and on encountering
1048 such an image (OB field brain damaged) we set errno. Then in
1049 ::FindDocLength() we "fix" the length as being ALL what remains
1050 in the file (until EOF). We then proceed, hoping for the best...
1051 This fixes a SegFault in ShowDicom when trying to write such an
1053 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1054 (because TestWriteRead breaks on it, after a non conformal commit?).
1055 ctest now runs properly, except for MakeDicomDir (which was allways
1056 broken) and the Python related stuff (still not fixed).
1058 2004-06-24 Jean-Pierre Roux
1059 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1060 FIX : Test/TestReadWrite now iterates on all the file names
1061 (instead of infinite loop)
1062 ENH : Test/TestWriteRead now iterates on all the file names
1064 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1067 2004-06-24 Jean-Pierre Roux
1068 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1069 when SamplesPerPixel =3
1070 - now Write is no longer confused by
1071 'BitsAllocated = 12" and 'BitsStored=12"
1072 - "UN" value representation Elements are now written correctly
1073 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1074 ENH : - now gdcmHeader has its own Write methods
1075 (in order to split the job that has not to be done
1078 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1080 loop on the same image until memory went out.
1081 Note: this means we still have gobs of memory loss in PrintDocument
1082 * src/gdcmDocument.cxx: fixes problem on parsing on file
1083 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1085 2004-06-24 Jean-Pierre Roux
1086 FIX : Write - All the Sequences and Sequence Item are now written
1087 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1088 is added a the end, when necessary.
1089 - A lot of brain-damaged images, that were read correctly are
1090 now written correctly
1091 - length compatible BinEntry are now loaded correctly
1092 (even for odd groups)
1093 Note : only Explicit Value Representation was checked.
1094 (question : is implicit VR really necessary for gdcm ?)
1096 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * DEVELOPPER: added a proposition of coding style.
1098 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1101 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1103 Use the gdcmDocEntry::Print() and Write() instead.
1104 * src/gdcmDocument.cxx: bug fix.
1106 2004-06-22 Jean-Pierre Roux
1107 FIX : gdcmDocument.cxx
1108 - Now we do recognize the JpegLossLess format (there was a misstyping in
1109 code 'beautyfication' :-(
1110 - Now we automaticaticaly load the Luts, if any
1112 2004-06-22 Jean-Pierre Roux
1113 In order : to write Sequences, whatever their imbrication level,
1114 : to allow user to create his own Sequences
1115 a lot of modif where necessary (adding, moving, or virtualising methods)
1117 WARNING : save your own sources *before* cvs up !
1120 ADD virtual void Write(FILE *fp, FileType filetype);
1123 ADD virtual void Write(FILE *fp, FileType filetype);
1124 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1127 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1128 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1129 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1130 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1131 ADD std::string GetEntryByName(TagName name);
1132 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1134 std::string vr = "unkn",
1135 std::string fourth = "unkn",
1136 std::string name = "unkn");
1137 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1138 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1139 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1140 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1141 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1142 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1143 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1144 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1147 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1148 ADD virtual std::string GetEntryByName (TagName tagName);
1149 ADD virtual std::string GetEntryVRByName (TagName tagName);
1150 REM virtual bool Write(FILE *, FileType);
1151 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1152 FILE *_fp, FileType type);
1153 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1154 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1155 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1156 REM virtual std::string GetEntryByName (std::string tagName);
1157 REM virtual std::string GetEntryVRByName (std::string tagName);
1158 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1159 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1160 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1162 std::string vr = "unkn",
1163 std::string fourth = "unkn",
1164 std::string name = "unkn");
1165 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1166 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1167 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1168 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1171 ADD virtual void Write(FILE *fp, FileType filetype);
1174 ADD virtual void Write(FILE *fp,FileType filetype);
1177 ADD virtual void Write(FILE *fp, FileType filetype);
1178 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1179 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1180 REM std::string GetEntryByName(TagName name);
1183 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1185 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1187 The default constructor invoked by the line
1188 gdcmHeader *f1 = new gdcmHeader( header );
1189 was gdcmHeader::gdcmHeader(bool) instead of the expected
1190 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1191 Hence the parsing wasn't executed... See also below.
1192 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1193 as explicit constructor didn't do the trick to fix the above problem.
1194 Could anyone explain why ?
1195 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1196 properly calls gdcmValEntry::Print() (that was weed out from
1197 code related to gdcmBinEntry).
1199 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * In order to fix memory leaks:
1201 - Test/TestWriteSimple.cxx: added cleaning of free store through
1203 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1204 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1205 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1206 (through the call to ::AddDicomDirMeta()) or the destructor
1207 would crash when deleting uninitialized ::metaElems].
1208 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1209 - src/gdcmDocument.cxx:
1210 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1211 from dynamic stores.
1212 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1213 was causing memory leaks.
1214 - src/gdcmSQItem.cxx:
1215 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1216 cleanly handled with polymophism: sorry but my milage is low).
1217 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1218 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1219 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1220 This avoids SegFaulting.
1221 - src/gdcmSQItem.h: coding style.
1223 - Test/TestWriteSimple still severely sucks. The output image content
1224 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1225 damaged when displayed with vtkgdcmViewer.
1226 - on memory leaks: TestWriteSimple leaks really less (see entry
1227 of 2004-06-18 in Changelog file for the call to valgrind).
1228 - on segfaults: ctest now passes all the tests but one (no more
1230 * Erroneous leading white fix:
1231 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1232 white[s] (as opposed to from >> xxx, that removes it [them].
1233 - src/gdcmTS.cxx: ditto.
1234 - gdcmPython/testSuite.py: dirty related kludge removed.
1235 * src/*: remaining references to gdcmParser removed.
1236 * src/*[cxx|h]: added copy[way]left header.
1239 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * In order to fix writing of dicom files:
1241 - Test/TestWriteSimple.cxx: a simpler example of writing.
1242 - Test/CMakeLists.txt changed accordingly.
1243 - src/gdcmDocument.cxx:
1244 -- The destructor now recursilvely removes potential sequences.
1245 -- Bug fix in ::IsJPEG2000()
1246 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1247 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1249 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1250 to only declared) and build on top of
1251 ::GetDocEntryByNumber(guint16, guint16).
1252 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1253 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1254 for usage in destructor and treatement of promotion in
1255 ::ReplaceOrCreateByNumber().
1256 - src/gdcmSQItem.cxx: destructor should better handle his job.
1257 Test/TestWriteSimple now runs (or at least it DOES something).
1258 * We can now start hutting memory links. A good starting point is:
1259 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1260 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1261 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1263 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1264 * Valgrind note: after Mathieu Malaterre teached me how to read
1265 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1267 Using gcc, you can force the STL to use malloc and to free memory as
1268 soon as possible by globally disabling memory caching.
1269 With 3.2.2 and later, you should export the environment variable
1270 GLIBCPP_FORCE_NEW before running your program.
1271 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1272 simply vanish (it is still not clear to me, whether this means that
1273 STL std::string leaks or if valgrind believes it leaks...).
1274 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1275 running bin/gdcmTests makeDicomDir):
1276 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1277 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1279 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1280 SegFaulting (I drowned in DicomDir related code when trying to
1281 understand why the list is empty...).
1282 * src/gdcmDocument.h: first BSD license header try.
1283 * Doc/License.txt added.
1285 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1286 * src/gdcmDocument.[h|cxx]:
1287 - Clean up of the Transfer related predicates. They are now all based
1288 on new method isGivenTransferSyntax, that (should) handle properly
1289 the padding problem.
1290 - general clean up, simplification, and coding style.
1291 - Specific clean up of Parse7FE0() (umproperly named actually).
1292 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1294 2004-06-14 Jean-Pierre Roux
1296 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1297 - fix the display of SQItem ordinal number
1298 - add the GetSQItemByOrdinalNumber method
1299 - remove some useless never written private methods
1301 2004-06-14 Jean-Pierre Roux
1303 - adding a constructor taking a gdcmDocEntry as an input param
1304 - ReplaceOrCreateByNumber now returns :
1305 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1306 a gdcmValEntry * if a string value is passed as a param
1308 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1309 according to the param type (no longer sets a gdcmDocEntry)
1310 - GetValEntryByNumber, GetBinEntryByNumber added
1311 - NewValEntryByNumber and NewBinEntryByNumber added
1313 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1315 - GetSQItemNumber and SetSQItemNumber added, to provide
1316 a (relative) Item identier inside a given Sequence
1317 \warning : some pb remaining around this number
1319 - AddEntry now takes the Item Number as a param
1321 - adding a constructor taking a gdcmDocEntry as an input param
1323 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * Memory leak hunt with the following command:
1325 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1326 --show-reachable=yes gdcmTests PrintDocument
1327 It looks like many (all?) leaks are due to the STL (or a bad usage
1328 of the STL. The lines producing the leaks now have a comment with
1329 a "MEMORY LEAK" tag: you can retrieve them with
1330 grep "MEMORY LEAK" src/*
1331 Here are two typical examples which I can't help fixing:
1336 char * test = "babo";
1337 name = test; //// <--- valgrind detects 960 bytes lost in
1338 //// call to std::string::operator=(char const*)
1339 name.clear(); //// Doesn't help !
1347 std::cout << "Type a bunch of characters followed by RETURN: ";
1348 getline(std::cin, line); //// <--- valgrind dectects a loss
1349 //// of 1320 bytes in call to
1350 /// std::basic_istream<>& std::getline<>
1356 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * src/gdcmHeader.[cxx|h]:
1358 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1359 and related, moved away to gdcmDocument.
1360 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1361 the corresponding protected accessors of inherited class
1362 gdcmDocument, removed ! As a consequence gdcmFile had to be
1363 declared friend of class gdcmDocument (see below).
1364 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1365 - Clean up of undefined or unused methods.
1366 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1367 account the changes to gdcmHeader.h).
1368 * src/gdcmDocument.h:
1369 - gdcmFile is now a friend class (in order to take into account the
1370 changes to gdcmHeader.h).
1371 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1372 (see changes to gdcmHeader.h).
1373 - Accessors (reading on the form GetEntry*) are now public.
1374 - Clean up of undefined or unused methods.
1375 * src/gdcmDocument.cxx:
1376 - adaptation to changes to gdcmDocument.h
1377 - ::OpenFile now writes a verbose message when file cannot be opened.
1378 - some std::string properly set to VRKey
1379 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1380 references to gdcmDocument.
1381 * Test/TestFindTags.cxx: changed accordingly to above changes.
1382 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1383 cvs repository gdcmData.
1385 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1387 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1388 conflicts with gdcmValEntry::voidArea.
1389 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1390 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1391 Value representation between StringRepresentable and BinaryRepresentable.
1392 * src/gdcmDocument.cxx:
1393 - method ParseDES: proper indentation restored and usage of
1394 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1395 - method LoadDocEntry: the fingerprint left in the SetValue() of
1396 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1397 removed. Reverting to previous code segment with the proper
1398 dynamic_cast< gdcmValEntry* >.
1399 Note: this was (partially) breaking the python test suite
1400 (gdcmPython/testSuite.py) that made usage of the above
1401 fingerprint to check presence of "Pixel Data".
1402 * src/gdcmDocEntry.h: coding style.
1403 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1404 now taken into account.
1405 * gdcmPython/gdcm.i: adaptation to the new internal representation
1406 of gdcm (exit gdcmParser, hello gdcmDocument).
1407 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1409 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1410 anymore, but instead prints the loaded Python dictionary.
1411 * .... alas, the python testSuite is still broken.
1413 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1414 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1416 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1417 * src/gdcmUtil.h : export methods
1419 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1422 * Initial addition of automatic python testing
1423 * Initial addition of automatic image comparison
1425 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1426 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1427 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1429 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1430 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1431 * Test/ShowDicom.cxx : bug fix for msvc compilation
1432 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1434 2004-05-04 Jean-Pierre Roux
1435 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1436 new concepts (and new classes) :
1437 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1438 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1439 - Sequence Doc Entries (gdcmSeqEntries)
1440 a Sequence is composed of Items.
1441 Each item is a set of Doc Entries (this is recursive)
1442 The non uniqueness of the 'Dicom tag' is due to this recursivity
1443 (never taken into account)
1444 Our unability to add a new 'entry' in the header
1445 at the proper location (neither in the H-Table (map or multimap),
1446 nor in the Chained List is also due to this recursivity.
1447 Don't try, right now, to use/modify/compile these new sources :
1448 nothing is finished.
1449 We just commit all the stuff, 'as is', in order not to loose it.
1451 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1452 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1454 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1455 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1456 file prefix (SetFilePrefix)
1458 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * Add a new test: ShowDicom, for now this is just the c++ version of
1460 checkRead.sh, later it will be able to compare the image read against a
1462 * Replace the DEBUG on the stack with a global entry in cmake interface:
1463 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1465 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * Add an example subdir, with a real example on how to read + write a
1469 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1471 * Doc/CMakeLists.txt: the main page is now properly differentiated
1472 between the developper and user version.
1473 * Doc/doxygen.config.in: dropped search related obsolete flags
1474 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1476 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1477 * DEVELOPPER: added some helpfull comments for compile/test/install
1480 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1482 src directory, now generated in the build dir.
1483 2. Tests as mentionned smarter
1485 4. Add a new method in gdcmDict that return the PubDict by name
1486 this is interesting for 3rd party lib like ITK,
1487 where we could set the institution name / patient name...
1489 * ENH: 1. Now the test suite is working for real
1490 2. All binaries are now output in the gdcm-bin directory
1491 (this was not true before)
1493 2004-04-28 Jean-Pierre Roux
1494 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1495 SeQuence indented printing of Dicom Header.
1496 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1497 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1498 Computation of SQDepthLevel is now part of gdcmHeader constructor
1499 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1500 tree-like structure of a Dicom Header.
1501 * FIX Test code cleaning
1503 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1504 * ENH: Adding automatic testing
1505 1. Need a DartConfig.cmake to submit to public
1506 2. Add a test driver gdcmTest.cxx
1507 3. gdcmTestMain, an helper for the main test driver gdcmTest
1508 4. Files in Test don't have a main anymore, this becomes interesting
1509 when we add more and more tests, thus dsw don't have to load
1511 * ENH: Adding a GDCM_DATA_ROOT for testing
1512 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1513 one file instead of seven + some small cleanup
1515 2004-04-22 Jean-Pierre Roux
1516 * ENH Minor changes to the Print() methods.
1517 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1518 Header printing. Example given with :
1519 > PrintHeader fileName 2 new
1520 (SQ based tree-like structure still to be done for the Header ...)
1522 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1523 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1524 1. I have added some unsigned where needed
1525 2. Some function parameter not used -> (void)
1526 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1527 4. g++ don't like character '\' in comment
1528 5. #define jpeg_create_decompress jCreaDecompress
1529 this really need to be fixed
1530 6. virtualize destructor of gdcmObject ... leakage
1531 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1532 this also really need to be fixed
1533 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1534 remove compression file
1535 (as we only do decompression, right ?)
1536 * ENH: Change malloc/calloc/free with c++ equivalent
1538 2004-04-21 Jean-Pierre Roux
1539 * FIX gdcmHeaderHelper::GetXSpacing
1540 when a single value is found (bug ?), xpacing is now
1541 defaulted to yspacing
1543 2004-04-19 Jean-Pierre Roux
1544 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1545 * ENH add parameters :
1546 bool exception_on_error = false,
1547 bool enable_sequences = false,
1548 bool ignore_shadow = false
1549 to the gdcmFile constructors to be full gdcmParser compliant
1550 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1551 to allow reading of PAPYRUS 3.0 files
1553 2004-04-06 Jean-Pierre Roux
1554 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1556 2004-04-02 Jean-Pierre Roux
1557 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1558 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1559 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1561 2004-03-30 Jean-Pierre Roux
1562 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1563 for ACR file, written out as DICOM files (hope so...)
1565 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1566 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1567 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1568 moved to base class gdcmParser and only the specialisation is kept
1570 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1571 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1572 already does the job.
1573 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1574 (to be consistent with gdcmParser::WriteEntries).
1576 2004-03-30 Benoit Regrain
1577 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1578 upate of the object's instance. It's passed to 2 in the unfavorable
1579 case : one in the ExecuteInformation, one in the ExecuteData
1581 2004-03-29 Jean-Pierre Roux
1582 * ENH : Check on file type to be written moved
1583 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1584 * FIX : gdcmObject::ResetBoundaries now stops properly
1585 when end-of-list is reached
1586 : gdcmVersion modified (as Benoit Regrain asked)
1588 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1590 * src/gdcmUtil.cxx: added forgotten iostream include.
1591 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1592 equivalent to ExplicitVR in existing code).
1594 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1596 now contains all the gdcmGlobal related code.
1597 * minor coding style and doxygenation changes.
1599 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1601 now contains all the Debug related code.
1602 * minor clean-up of includes in src/*.cxx
1603 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1604 CreateCleanString) removed.
1605 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1606 * Doc/DoxyMainPageUser.txt added.
1607 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1608 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1609 src/gdcmDirList.cxx)
1611 2004-03-24 Jean-Pierre Roux
1612 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1614 2004-03-23 Jean-Pierre Roux
1615 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1616 big endian made volumes
1617 * ENH Now gdcmParser constructor and destructor are protected to forbid
1618 end user to instanciate class gdcmParser
1619 (only gdcmHeader and gdcmDicomDir are meaningfull)
1621 2004-03-22 Benoit Regrain
1622 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1623 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1624 gdcmSerie to gdcmDicomDirSerie
1626 2004-03-19 Jean-Pierre Roux
1627 * ENH Now the tree-like structure describing a DICOMDIR comming from
1628 an already existing DICOMDIR file is consistent with
1629 the home-made tree-like structure build ex-nihilo
1630 or build from the files held (recursively) in a Directory
1631 functions gdcmDicomDir::CheckBoundaries()
1632 gdcmObject::SetBoundaries() added
1634 2004-03-17 Jean-Pierre Roux
1635 * REM (Eric Boix bug) : removal of meaningless
1636 gdcmDicomDirImage::NewImage function.
1637 * FIX now file names and directory name are written properly in the
1639 * FIX now gdcmDicomDir constructor may be call without any trick
1642 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1644 of gdcmDicomDirImage::NewImage as empty function.
1646 2004-02-28 Jean-Pierre Roux
1647 * ENH add gdcmDicomDir:NewPatient
1648 add gdcmDicomDirPatient:NewStudy
1649 add gdcmDicomDirStudy:NewSerie
1650 add gdcmDicomDirSerie:NewImage
1651 to allow making gdcDicomDir object.
1652 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1653 (as opposite to the gdcmHeader chained list)
1655 2004-02-11 Benoit Regrain
1656 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1657 when using from python
1659 2004-02-10 Benoit Regrain
1660 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1661 * FIX : in gdcmDicomDir when the directory is empty
1662 * ENH : add callback and methods to get the progression of dicomDir
1665 2004-02-06 Jean-Pierre Roux
1666 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1667 - GDCM_META added to gdcmDicomDirType
1668 - class gdcmMeta created
1669 * ENH : - A brief summary is now displayed at the beginning of
1670 'testDicomDir' to help disaster magnitude estimation
1671 * REM : Now useless Test/explDICOMDIR.cxx
1673 2004-02-05 Benoit Regrain
1674 * ENH : add methods in gdcmObject to get the hash table or the list of
1676 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1677 * FIX : wrapping python for TagHeaderEntryHT
1679 2004-02-04 Benoit Regrain
1680 * FIX : even length for some strings when writting the dicom dir
1681 * FIX : sort the images in the dicom dir
1682 * FIX : Bug fix for python use of dicom dir
1683 * ADD : a python demo
1685 2004-02-04 Jean-Pierre Roux
1686 * FIX : Final solution (?) for icone embedded images
1687 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1688 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1689 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1690 gdcmData/gdcm-MR-SIEMENS-16.acr1
1691 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1692 to make full checking easier
1694 2004-02-04 Benoit Regrain
1695 * FIX : WriteEntries : coding style & logic in parameters
1696 * FIX : Set the elements to create the DicomDir in a dictionary file
1698 2004-02-03 Benoit Regrain
1699 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1700 * gdcmDicomDir : add the load of directory
1701 * Bug fix and print add-on
1703 2004-02-03 Jean-Pierre Roux
1704 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1705 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1706 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1707 * FIX gdcmParser.cxx : 'group length' elements are now considered
1708 as integers, even for shadow groups, when file is Implicit VR
1710 2004-02-02 Jean-Pierre Roux
1711 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1713 of the last synonym :-(
1714 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1716 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1717 * FIX taking into account the possible 7fe0,0010 multiplicity
1718 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1719 to allow removal of references to 7fe0,0010, to deal with
1720 ACR-NEMA images, when 0028,0200 is meaningfull
1722 2004-01-31 Jean-Pierre Roux
1723 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1724 no longer writes 'Un' on disk
1725 * FIX SQ elements with actual length are now dealt with corectly
1726 * FIX gdcmFile::WriteBase make the difference, for color images, between
1727 the length (for Palette expanded images)
1728 and Raw Length (non expanded image + Palette)
1729 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1730 (that broke Write). Replaced by UL.
1731 Aware user will reload the field if he
1732 thinks it's necesssary
1734 2004-01-30 Jean-Pierre Roux
1735 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1736 when 'dirty Acr' is found, to be compliant with the new
1737 IsReadable() methods.
1739 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1740 (no DOUBLE images in kosher DICOM,
1741 but so usefull for people that miss them ;-)
1743 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1744 DICOMDIR related utilities (not checked as Windoze compliant)
1746 2004-01-28 Jean-Pierre Roux
1747 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1749 2004-01-27 Jean-Pierre Roux
1750 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1751 to allow skipping the shadow elements, to save memory space.
1752 The TRUE value for this param has to be used
1753 with a FALSE value for the 'enable_sequence' param.
1754 ('public elements' may be embedded in 'shadow Sequences')
1755 * gdcmHeader methods now deal with 'embedded icones images' in the header
1756 (even when an 'icone image sequence' is announced by the
1757 element (0x0088,0x0200), but there is NO icone at all ...
1759 * gdcmHeader sometimes Image Location value doesn't follow
1760 the supposed processor endianity (see gdcmData/cr172241.dcm).
1763 * gdcmHeader add the method
1764 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1765 to get *all* the Header Entries with the same tag.
1766 GetHeaderEntrySameName is probabely *useless*
1767 (no meaning : Name is *not* an identifier within the Dictionnary)
1769 2004-01-26 Benoit Regrain
1770 * Bug fix in the print of hexadecimal representations. Remove long fields
1771 in the print and add a third level of print to print them
1773 2004-01-23 Benoit Regrain
1774 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1775 * Bug fix on test suite after remove the strip made on not string fields
1776 * Split the IsReadable method between gdcmParser which test that the file
1777 is dicom and gdcmHeader which test that it's an image file
1779 2004-01-22 Benoit Regrain
1780 * DicomDir : clean code, add methods, set variables in protected or private
1781 * gdcmUtil : bug fix for the clean string method
1783 2004-01-19 Benoit Regrain
1784 * Add the use of shadow dictionaries
1785 * bug fix and coding style
1787 2004-01-19 Benoit Regrain
1788 * src/gdcmFile.cxx : bug fix concerning the close of file
1789 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1790 * Add the update of header entries using the shadow library
1792 2004-01-19 Benoit Regrain
1793 * removal of file gdcmHeader2.cxx
1794 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1795 inheriting from gdcmParser. This split is to prepare the integration
1796 of dicom dir parsing
1797 * bug fix under python
1799 2004-01-16 Jean-Pierre Roux
1800 * REM removal of class gdcmHeaderEntrySet
1801 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1802 * ADD add file gdcmHeader2.cxx
1803 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1805 2004-01-15 Benoit Regrain
1806 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1807 entries created while parsing the header. Thus, they will be destroyed
1808 when the gdcmDictSet will be destroyed
1809 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1812 2004-01-15 Benoit Regrain
1813 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1814 made a fatal error because of the memory release at the end of program.
1815 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1816 some memory and vtk seems to have some problems with that.
1817 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1819 2004-01-14 Benoit Regrain
1820 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1821 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1822 * src/*.[h|cxx] : make changes due to class name changes
1823 * gdcmPython/demo/*.py : bug fix due to method names
1825 2004-01-13 Benoit Regrain
1826 * src/*.[h|cxx] : coding style
1827 * vtk/*.[h|cxx] : coding style
1829 2004-01-13 Benoit Regrain
1830 * gdcmPython/testSuite.py : test the readable flag of file for tests
1831 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1832 It's lied to the stl compilation by MSVC (windows, always windows...)
1833 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1835 2004-01-12 Benoit Regrain
1836 * src/*.h : add comments
1837 * src/gdcmDictSet.h : set the method BuildDictPath in public
1838 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1839 directly setted in the source code
1840 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1843 2004-01-09 Benoit Regrain
1844 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1845 * setup.py : use a reference to gdcmVERSION
1847 2004-01-07 Benoit Regrain
1848 * Modification to compile with the distutils.
1851 2003-12-10 Benoit Regrain
1852 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1853 can use a gdcmHeaderHelper to load data
1854 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1855 made in the source code
1857 2003-12-10 Benoit Regrain
1858 * Update Windows projects and .cvsignore files
1860 2003-11-12 Jean-Pierre Roux
1861 * ENH gdcmHeader constructor has one more parameter (default value : false)
1862 that allows the user to 'go inside' the SeQuences only
1864 gdcmElValSet:Print takes it into account
1866 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1867 * ENH: Update gdcmPython/CMakeLists
1868 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1869 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1871 2003-11-10 Jean-Pierre Roux
1872 * FIX : gdcmHeader::LoadElements is now based
1873 on the ListTag listElem member,
1874 not longer on the TagElValueHT tagHt member
1875 * ENH : PrintPubElVal shows (temporarily) both results,
1876 with the tagHt member and the listElem member.
1877 (it's easier to 'see' the problems when using Printheader)
1879 * FIX : old private member LgrElem is now splitted into
1880 ReadLength : Length actually found on disk (updated only
1881 if bug fixing is necessary), for internal
1883 UsableLength : Updated by FixFoundLength, to fix a bug
1884 or to allow Parser going on.
1885 Will allow to re-write a kosher header when a SeQuence
1886 with a length (not 0000) is found
1887 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1888 because gdcmElValSet::Add does not update ListElem
1891 2003-11-07 Jean-Pierre Roux
1892 * FIX misstyping in Transfert Syntax name table
1893 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1894 when they have an actual length (not 0000 nor FFFFF)
1895 (Nobody should care of it, but DICOMDIR explorers)
1897 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1900 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * ENH: vtkGdcmReader now supports LUT !
1902 (vtkgdcmViewer for now is not able to use them though)
1904 2003-11-05 Jean-Pierre Roux
1905 * in testSuite.py : new files names for checking the package
1906 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1907 that returns the pixel area size to the *aware* (vtk) user
1908 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1910 2003-11-05 Benoit Regrain
1911 * in testSuite.py : Modify the rules for checking the paths
1912 : Explicit error messages
1913 * in __init__.py : Related modif
1915 2003-11-03 Jean-Pierre Roux
1916 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1917 to be used by aware (vtk) users that want to manage
1918 LUT (and no to turn the PALETTE image into an RGB pixels one)
1919 * GetPixelType now returns 8U for 24 Bits images
1920 (vtkGdcmReader compliant)
1922 2003-10-31 Jean-Pierre Roux
1923 * Removal of *all* gdcmData images and add them again
1924 in order to loose the 'history' of un-anonymised images
1926 2003-10-31 Jean-Pierre Roux
1927 * RMV : removal of useless jBitsInJsample.h
1928 for both 8 and 12 Bits JPEG Lossy Libraries
1930 2003-10-31 Jean-Pierre Roux
1931 * ENH : Add the functions gdcmFile::GetImageDataRaw
1932 gdcmFile::GetImageDataIntoVectorRaw
1933 that act as GetImageData and GetImageDataIntoVector
1934 except the making of an RGB Plane from Gray Plane + LUT
1935 Intended to aware (vtk) users who know how to manage
1938 GetLUTRGBA return a R,G,B,A LUT if any
1939 lgrTotaleRaw gives the 'Raw' length
1940 GetImageDataRaw returns the gray Plane
1941 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1942 (They stay Grey, just like with other Dicom viewers :-(
1944 2003-10-30 Jean-Pierre Roux
1945 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1947 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1949 being coherents dicom files.
1951 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1952 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1954 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1955 * ENH: Two steps is necessary to please VC++ compiler...
1956 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1957 * ENH: Add include dir to medcon lib
1958 * FIX: only one function is being exported for now !
1959 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1961 2003-10-29 Jean-Pierre Roux
1962 * adding gdcmHeader::GetLUTRGBA
1963 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1964 --> Mathieu, the modif u're waiting for is not yet committed
1965 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1967 2003-10-27 Jean-Pierre Roux
1968 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1969 00191113.dcm DermaColorLossLess.dcm
1970 MxTwinLossLess.dcm RadBWLossLess.dcm
1971 * ENH: For version prior to vtkImageViewer2 -r 1.19
1972 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1974 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * Removal of ido stuff in CMakeLists.txt
1977 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1978 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1979 * FIX: remove a call to ->Modified ... see comments
1980 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1982 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1983 * FIX: Problem with path for libvtkgdcmPython
1984 * ENH: Try adding a search script for python site-package
1985 * RMV: Remove some file from medcon lib that are not necessary
1986 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1987 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1988 * FIX: More pragma disable fro VC++,
1989 I don't think I break something as it is also disable in VTK/ITK.
1990 But it fasten debug compilation time.
1992 2003-10-23 Jean-Pierre Roux
1993 * gdcm now deals with 16 Bits Run Length Encoded images
1994 (they are compressed as 2 planes images,
1995 one for the high Bytes, the other for low Bytes)
1997 2003-10-22 Jean-Pierre Roux
1998 * Now CheckRead takes into account :
1999 - the bugged 'Leonardo' Siemens images
2000 - the XA images, sent thru the burning VPRO station
2001 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2004 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * FIX: When copying a Makefile.am to CMakeLists.txt
2006 one should remove the '\'
2008 2003-10-22 Jean-Pierre Roux
2009 * in gdcmData adding a bugged 'Leonardo' Siemens image
2010 (wrong lengths in header)
2011 OK with gdcm, KO with the other viewers :-)
2012 * add a GE dlx XA image, thru the VEPRO burning station
2015 2003-10-21 Jean-Pierre Roux
2016 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2017 for a brutal checking of vtkgdcmViewer compliance
2019 2003-10-21 Jean-Pierre Roux
2020 * add the files for 'xmedcon' Jpeg Lossless library
2021 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2023 2003-10-21 Jean-Pierre Roux
2024 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2026 2003-10-21 Jean-Pierre Roux
2027 * garbage Siemens 'Leonardo' images dealt with
2028 (the patch is easy to remove)
2029 * cosmetic changes to avoid warnings
2031 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2033 no need to press 'r' now.
2035 2003-10-20 Jean-Pierre Roux
2036 * upgrade of checkRead.sh checkWrite.sh according
2037 to new Jpeg Lossless decompressor
2038 * add US.3405.1.dcm, a genuine RGB medical file ...
2039 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2040 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2042 2003-10-15 Jean-Pierre Roux
2043 * general anonymisation in gdcmData
2044 * adding the 'color files' from
2045 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2046 * adding some well knowed bugged-header images
2047 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2048 waiting for their inclusion in Python testsuite
2050 2003-10-15 Jean-Pierre Roux
2051 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2052 no longer seg faults when file is not found
2054 2003-10-14 Jean-Pierre Roux
2055 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2058 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2059 * TODO: *.in file to genereate a UseGDCM later
2061 2003-10-14 Jean-Pierre Roux
2062 * Some supposed-to-be Dicom Images have no preamble.
2063 OpenFile takes it into account
2064 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2065 * Missing elements added in dicomV3.dic
2066 (just to be affraid : have a look at
2067 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2068 and do it again next year ;->
2070 2003-10-13 Jean-Pierre Roux
2071 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2072 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2073 But there are NOT. It's fixed !
2075 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * FIX: "jpeglib.h" was not found on VC++
2077 * FIX: vtkgdcm was not being installed
2079 2003-10-10 Jean-Pierre Roux
2080 * ENH : OpenFile closes the file if it *really* doesn't look like
2081 an ACR-NEMA / DICOM one.
2082 * FIX : testWrite no longer writes an empty file if the source file
2083 is not gdcm Readable
2084 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2087 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * FIX: CMake generate now documentation
2089 * ENH: out of source doc build !
2090 * ENH: Generate both user and dev documentation
2091 * ENH: Should work on windows too
2092 * ENH: Only one doxygen config.in file is needed
2093 * FIX: make install should be ok now on ùnix plateform
2094 * FIX: PATH to dictionary was wrong (missing /)
2095 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2097 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * vtkGdcmReader is now able to read rgb dicom file.
2099 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2100 * added a gdcmViewer to vtk test, use mouse to control
2101 window level & window width
2103 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * CMake-ification of gdcm, we have now two build system
2105 * FIX: on cygwin Wsock32 doesn't exist
2106 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2108 2003-10-06 Emanuel Ollart
2109 * FIX : compilation process wad broken.
2110 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2112 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * change gdcmViewer -> vtkgdcmViewer
2114 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2116 2003-10-06 Jean-Pierre Roux
2117 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2118 ( e.g : well known GE images with a wrong elem length,
2119 : Philips MRI Images with a wrong Huffman table)
2120 * still to be done : allow the reading of bugged LEONARDO Siemens images
2122 2003-10-03 Jean-Pierre Roux
2123 * Odd length strings are padded with '\0' (not with spaces,
2124 to remain compliant with already defined strings,
2125 like Transfert Syntax UID and others)
2127 2003-10-03 Jean-Pierre Roux
2128 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2129 to allow displaying RGB images (not only by affim ;-)
2131 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2132 * vtkGdcmReader is now able to read rgb dicom file.
2133 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2135 2003-10-03 Jean-Pierre Roux
2136 * A few nasty patches to allow the reading of a lot of nasty images
2137 ( e.g : well known GE images with a wrong elem length,
2138 : Philips MRI Images with a wrong Huffman table)
2139 * still to be done : allow the reading of bugged LEONARDO Siemens images
2141 2003-10-03 Jean-Pierre Roux
2142 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2144 2003-10-03 Jean-Pierre Roux
2145 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2146 to allow displaying RGB images (not only by affim ;-)
2148 2003-10-03 Jean-Pierre Roux
2149 * gdcmFile::GetImageDataIntoVector now
2150 - deals with MultiFrames MultiFragments Run Length Encoded files
2151 - deals with YcBcR (YBR_FULL) files
2152 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2153 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2155 (no sample found :-(
2157 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2159 Two reasons: - clear things
2160 - third parties acces gdcm through header files, so won't
2161 suffer anymore VC++ complains
2163 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2164 * add argv[1] in testvtkGdcmReader.cxx
2167 2003-09-24 Jean-Pierre Roux
2168 * The lines are now eigthy characters long.for
2169 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2171 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2172 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2173 char* to std::string. Thus, the use of strdup becomes useless. (see
2174 previous commis of Malaterre)
2175 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2176 before the last Malaterre's commit.
2178 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * This commit should fix the Debug building under VC++, the problem
2180 was mainly a mixture of debug and release lib being loaded at startup.
2181 * I also remove a depency to a specific C function: strdup. Because I had
2182 to force the link to msvcrtd (whereas strdup is in libc).
2184 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2185 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2186 located in the gdcmCommon.h file. All use of reference of tha has been
2187 changed to now use the variable GDCM_UNFOUND.
2189 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2191 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2192 Dicom dictionary. The test suite can now be run again. Note:
2193 I'm note very happy with the " (RET)" changes. I believe this
2194 RETAINED comment should be dropped when parsing the dictionary.
2195 - PACKAGER corrected
2197 - AUTHORS updated and now in alphabetical order
2198 * Makefile.am now exports gdcm.dsw for Windoze users.
2200 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * cygwin complains about missing std:: in subdir Test/
2203 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * remove some methods that are now in gdcmHeaderHelper
2206 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * vtkGdcmReader set spacing and origin correctly
2209 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2210 * Fix a few delete/delete[] mismatch
2212 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2213 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2214 interpretation to data given by gdcmHeader. For instance there are
2215 heuristics to get informations (look at different places).
2216 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2217 sorting DICOM images based on different strategies.
2218 * modified Makefiles accordingly.
2220 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2221 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2222 when building in debug mode
2223 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2224 src/win32/gdcmdll.dsp
2225 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2227 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2228 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2231 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2232 * src/win32/libgdcmjpeg12.dsp was not dos format
2233 * src/win32/libgdcmjpeg12.dsp :
2234 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2235 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2237 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2238 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2240 * src/gdcmFile.cxx : bug fix in affectation type
2241 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2242 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2243 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2244 symbols... future problem ?
2246 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * src/win32/libgdcmijpeg12.dsp was missing
2248 * modified gdcm.dsw accordingly
2250 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2253 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2255 commit of JPR (before his hollidays to facilitate our work).
2256 * setup.py : bug fix in code. Modifications made while the last commit
2257 of JPR. The code hasn't been tested before the commit... it's so
2258 useless to make that (for best programmer that is JPR) !!!
2260 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * tagged the current version as Version0_3 (i.e. version 0.3)
2263 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2264 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2265 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2266 * *.dsp : modifications to use new libgdcmijpeg8 library
2267 * setup.py : bug fix on VTKPATH variable
2268 * PACKAGER : adding all concerning windows
2270 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2271 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2273 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2274 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2275 test suite reported error.
2276 * PACKAGER file added (describes what a packager must do when
2277 packaging a new release).
2278 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2279 * configure.in: upgraded version number to 0.3.0
2280 * fixing build of rpm (through rpm -ta):
2281 - Doc/Makefile.am exports proper doxygen files
2282 - src/jpeg/libijg8/Makefile.am exports the include files.
2284 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2285 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2286 * src/gdcmHeader.h : formatting code
2288 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2289 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2290 We were obtaining error message from vtk. Now, creation of file list
2291 is made in an internal list to prevent this problem.
2292 Bug fix when output is empty.
2293 Bug fix in update of progress value. Previous commit for this was a bad
2295 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2297 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2298 * src/gdcmHeader.h : added method to get the file name
2299 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2300 files. Added method to remove all files on the input
2301 Added FIXME comment concerning the bad parsing of header made by
2302 ExecuteInformation method (in ExecuteData method)
2304 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2306 when using make instal.
2307 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2308 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2310 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2311 * setup.py : adding include dir of jpeg lib to compile all sources
2312 * */Win32/*.dsp : JPR fix for windows compilation
2314 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2315 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2317 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2318 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2320 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2321 * setup.py is again effective on un*x (takes into account the
2322 addon of the jpeg library)
2323 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2324 * Doc/Doxy* updated (includes above enhancements)
2325 * INSTALL now points to web documentation
2327 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * src/gdcmHeader.h doesn't make unnecessary reference to
2330 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2332 * src/gdcm*.[cxx|h] :
2333 - to allow compilation with gcc 3.x
2334 -- clean up of STL usage (added explicit usage of std::)
2335 -- small fixes on exceptions.
2336 Note: linking not tested !
2337 - clean of doxygen comments to avoid warnings at documentation
2339 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2340 dependent convertion).
2342 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * Clean up of previous JPR garbage commit (not even commented in the
2345 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2346 - moved all jpeg related files from src to src/jpeg/libijg8, with
2347 addition/modification of Makefile.am and configure.in.
2348 - the testSuite is still brain damage (not guilty).
2350 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2351 * WrapVTK.py : modifications to get correctly vtk source files to
2353 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2354 (FileName -> Filename)
2356 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * vtk/vtkGdcmReader.[cxx/h]:
2358 - UpdateProgress method should now be effective
2359 - removed the limitation on having only images loaded (as opposed
2361 - when building a stack of images/volume, a lesser number of
2362 gdcmHeader and gdcmFile instances should be used (hopefully
2363 accelerating things).
2364 - when building a stack of images/volumes, files which are not
2365 loadable (wrong path-filename, wrong permissions on existing file,
2366 or file not parsable by gdcm) are replaced with a black image
2367 in the stack (for the caller to notice the problem).
2369 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2372 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2373 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2374 between standard library (std) and vtk library (problems are found
2375 under Windows... thanks Windows !)
2377 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2380 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2382 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2385 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * When compiling with distutils (see setup.py) the C++ compiler is
2387 called with different flags than the default ones (with automake).
2388 In order to fix all those warning, I compiled gdcm with the command
2389 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2390 and went for warning fixes:
2391 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2392 up from unused variables.
2393 - vtk/vtkGdcmReader.cxx: potential bug fix.
2394 * src/gdcmHeader.h: Doxygen warning cleanup
2396 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * gdcmPython/gdcm.i:
2398 - typemaps correction to take into account the systematic replacement
2399 of "using namespace std" with std:: prefix e.g. std::list,
2400 std::string... (cf changes of 2003-05-21).
2401 - gdcmGlob global variable of type gdcmGlobal (defined in
2402 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2403 exported to Python a as cvar.
2404 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2405 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2406 gdcmDictSet.GetPubDictTagNames() and
2407 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2408 C++ static methods).
2409 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2410 with the above changes.
2412 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2413 * setup.py, manifest.in : bug fix under linux
2415 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2416 * Modification of setup.py to compile vtk part too. Then, we have 2
2417 wrappers which must work with same distutils. For that, we have a
2418 generic distutils in distusiltsWrapping.py ; with :
2419 - build_extWrap class to wrap generically all extensions,
2420 - ExtensionWrap base class for all wrapping extension that contains
2422 - Wrapper interface which wrap sources
2423 + In WrapSwig.py we have extension and wrapper for Swig
2424 + In WrapVTK.py we have extension and wrapper for VTK
2425 * MANIFEST.in : modifications to consider vtk directory and new python
2426 files for compilation
2428 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2429 * Added python wrappers of vtkGdcmReader vtk class (see the
2430 source in vtk/vtkGdcmReader.cxx) :
2431 - vtk/Makefile.am now builds a library
2432 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2433 python library (as opposed to _gdcm.so wich are the python
2434 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2435 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2437 - configure.in has an additional flag --enable-vtk that needs
2438 to be set to enable compilation of vtk related code, that is:
2439 + vtk/vtkGdcmReader.so and
2440 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2441 + gdcmPython/vtkgdcmPython.so (see above)
2442 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2443 be read when compressed or when HighBit + 1 != BitsStored),
2444 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2445 the usage of the python wrapper of vtkGdcmReader vtk class.
2446 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2447 * src/*.[h] all occurences of stl classes are now prefixed with
2448 std::, and all occurences of "using namespace std;" where removed.
2449 This is to avoid pollution of global namespace in included files.
2450 Apparently vtk does not avoid this pitfall: when using both
2451 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2452 collision of various stl members (principally cout...).
2453 * gdcmPython/testSuite.py now cleanly removes temprory generated
2455 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2456 comply with above changes)
2458 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2459 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2460 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2461 vtk data structure (an image Flip was required).
2462 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2463 * cosmetic changes in documentation.
2465 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2466 * src/gdcmHeader.cxx: the constructor no longer exits when an
2467 unexisting file is given as argument.
2468 * The subdirectory Data (containing all the images used for the
2469 test suite) is not part of this repository anymore. A new module
2470 containing those images is now available at
2471 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2472 with the name gdcmData.
2473 All the python scripts (including the package initialisation file
2474 gdcmPython/__init__.py) were adapated to take this change into
2475 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2477 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2478 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2479 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2480 demo of the usage of this class.
2481 Compilation of this vtk part is only done when using the --enable-vtk
2482 at configure (or autogen.sh) stage.
2484 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2485 * More memory link related corrections and documentation fixes.
2487 - maximum info is obtained with a command of the form:
2488 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2489 --show-reachable=yes PrintHeader
2490 - the remaining reachable blocks seem to come from the STL
2491 allocation scheme through the usage of map and list. It looks
2492 like this memory cannot be freed but it is not a memory leak
2493 (in fact further invocation to the STL would recollect the
2494 unused memory allthough it cannot explicitely be freed).
2495 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2496 of displaying an image parsed with gdcm and displayed with VTK.
2497 Note: some images don't seem to work e.g.
2498 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2499 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2500 Allthough this weakens the semantics, it is a ditch attempt to
2501 make gdcm more thread friendly.
2503 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2504 * Memory link hunt (by using valgrind through the command
2505 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2506 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2507 gdcmHeader::_dicom_vr.
2508 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2509 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2511 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2513 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2514 * src/Makefile.am now exports all the necessary include files at
2518 * UpdateGroupLength replaced by new one
2521 * UpdateGroupLength re-written using H-Table
2522 (named UpdateGroupLengthNew untill checks are over)
2524 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2525 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2526 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2528 - gdcmHeader::GetPubElValSet removed.
2529 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2530 UpdateGroupLength, WriteElements, Write.
2531 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2532 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2533 carried the same semantics.
2534 - src/gdcmHeaderIdo.cxx changed accordingly.
2535 - gdcmFile::WriteBase now regroups all the codes from previous
2536 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2537 - enum FileType moved to gdcmCommon.h
2538 * src/gdcmHeader.cxx AddDefault trashed
2539 * gdcmGetXSize added
2540 * getimageDataSize now calls gdcmGetXSize
2541 * Test/*.cxx changed to agree with above changes
2543 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2545 (to avoid double call by end user).
2546 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2547 by end user, since gdcmHeader::gdcmHeader now handles it.
2549 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * gdcm/Doc many doxygen changes:
2551 - Doxyfile now has two different versions, DoxyfileUsers that generates
2552 the html.users end users oriented documentation and
2553 DoxyfileDeveloppers that generates the html.developper developper
2554 oriented documentation.
2555 - README changed accordingly
2556 - requirement.txt removed (old design info moved to TODO).
2557 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2558 DoxyMainPage.txt, DoxyPython.txt provide more information.
2559 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2560 be updated by simply regenerating the docs with doxygen and copying
2561 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2562 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2563 all the tests in the form "if (<map>.count() >1)" were removed.
2564 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2565 ill-formed documentation sections.
2566 * src/gdcmHeader.cxx: ditto
2568 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * setup.py fixed for un*x (needed macro for stdint.h)
2570 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2571 un*ces with sh-utils test utility.
2572 * gdcmPython/demo/test.py renamed to PrintHeader.py
2573 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2574 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2575 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2576 * src/gdcm*.cxx JPR's bad inclusion fixed.
2578 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2580 * gdcmPython/demo/test.py changed accordingly.
2582 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2583 * gdcmPython/Makefile.am fixed linking against libstdc++
2584 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2585 * Swig subdir (historical tests of swig version 1.3.17++) removed
2586 * Test/testChangeEntete.cxx some lines commented out in order to make
2588 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2589 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2591 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2593 hence the user doesn't need this explicit call.
2594 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2595 i.e. LoadElements() call removed.
2596 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2597 - src/Makefile.am declares the proper flag for g++.
2598 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2599 for adding user defined new tags.
2600 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2601 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2602 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2604 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2605 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2606 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2607 src/Makefile.am : the project should properly compile and install
2608 with the autotools, included the python wrappers part.
2609 * gdcm.spec.in : added a spec file for RPM packaging.
2611 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2612 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2614 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2616 to exported to the environement (see gdcmPython/testSuite.py
2618 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2619 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2620 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2621 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2622 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2624 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * gdcmPython/__init__.py doesn't crash anymore when running in
2626 in InstallMode or PreInstallMode but with an environement given
2627 value of GDCM_DICT_PATH.
2628 * src/gdcmDictSet.[cxx/h] coding style.
2630 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2632 * src/gdcm.h general comments moved to TODO, and README
2633 * src/gdcm.h should now be seen as a user commodity (including it
2634 should suffice to fully use gdcm). It is nowhere including within
2635 any of the kernel files src/*.cxx and src/*.h.
2637 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2639 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2641 * src/gdcm*.cxx only include their corresponding include file
2642 (as opposed to gdcm.h)
2643 * gdcmPython/gdcm.i changed accordingly
2644 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2645 the autogen.sh generated "make snapshot" command to work.
2646 * autogen.sh removed history related references to crea package.
2648 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * distutilsSwigCPlusPlus.py work around some swig portability
2652 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2654 was done in a last ditch attempt to get setup.py _really_
2655 operationnal. The python/gdcmPython layaout add the advantage
2656 of hidding away the python related distutils specific files
2657 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2658 Alas, the src directory was out of scope (i.e. it's relative
2659 position to setup.py was ../src) which made things impossible to
2660 handle (see previous version of python/setup.py). Crossing fingers...
2662 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * python/setup.py now works on Un*x. (harder than I thougth)
2664 * python/distutilsSwigCPlusPlus.py can now have include files
2665 among the list of sources.
2667 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2668 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2669 * modifications in MSVC projects
2671 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * As stated by the first lines of Test/ExceptionAndPython/README, it
2673 looks like we can move back to original usage of exception within
2674 src/gdcm* and hence remove the errno stuff that was introduced
2675 as a quick and dirty fixture of this problem (added to the TODO).
2676 * Doc/Doxyfile configuration file for Doxygen and corresponding
2677 README file for usage added.
2678 * Test/testWrite.cxx added. This new test comes from a split of
2679 test.cxx that is now reverted to its original purpous i.e.
2680 testing the proper parsing of a Dicom related file.
2681 testWrite.cxx concentrates on testing the IO part of gdcm.
2682 * Test/bug1.cxx (containing a bug on WIn32) added.
2683 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2684 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2685 whose purpose is to publish the content of the TagNames of the
2686 Dicom public dictionnary were not accessible without an
2687 instance of class gdcmHeader.
2688 - those methods are now static methods of gdcmDictSet and hence
2689 require no instances at all to be invocated.
2690 - within gdcmDictSet this change required to change some method
2691 to class methods (i.e. are now static) among which SetDictPath
2692 (renamed to BuildDictPath) and LoadDefaultPubDict.
2693 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2694 the above changes by calling the new method classes of gdcmDictSet.
2695 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2696 the above to be effective.
2697 * python/gdcmPython: in order to wrap properly the above changes
2698 for Python, swig version now needs to be > 1.3.17.
2699 * python/gdcmPython/Makefile fixed to adapt itself to new
2700 configure/make shema introduced by Johan Montagnat (thanks for the
2701 contribution). Alas this Makefile cannot be turned into a proper
2702 Makefile.am without some heavy changes in the configure.in
2703 (for python dectection).
2704 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2705 now avoids publishing the empty entries.
2707 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2708 * python/setup.py : bug fix concerning install under windows
2709 ExtraPath reused :-P
2710 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2712 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2713 * Dicts/dicomV3.dic : remove double spaces !!!
2714 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2715 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2718 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2720 method. Doxygenation.
2721 * src/gdcm.h clean up of JPR spurious comments.
2723 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * python/distutilsSwigCPlusPlus.py now properly collects the
2725 shadow classes generated by "swig -c++" (gdcm.py in our case)
2726 when using "python setup.py install".
2727 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2728 reexports the working classes.
2729 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2730 by the classical C errno scheme. This is to prevent an obscure
2731 behavior of the python wrappers when importing wxPython.wx prior
2732 to gdcmPython (which ended up in an abort call). An illustration
2733 of this oddity can be found in the Test/ExceptionAndPython
2734 subdir (see the README file). This problem probably due to
2735 an combination of g++ and dynamic loading.
2736 * added Test/ExceptionAndPython (see above)
2738 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * Changed the layout of the python part to avoid bloating main
2740 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2741 i.e. the distutils arsenal. All the python related stuff is
2742 again in a python subdir, but the package itself is now in
2744 * setup.py was cleaned up:
2745 - pythonIncludePath removed
2746 - python setup.py bdist target is now functional.
2747 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2748 collision with other packages). gdcmPython/demo/*.py changed
2751 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * python subdir moved to gdcmPython (preparation of distutils packaging).
2753 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2754 distutils installer is operational.
2755 * - gdcmPython/__init__.py now properly loads the swig generated
2756 shadow classes (from gdcm.py).
2757 - gdcmPython/demo/*.py changed to import the package gdcmPython
2758 instead of gdcmPython/demo/load.py.
2759 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2761 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2763 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2764 entries within the associated public Dicom dictionary resp. the same
2765 information but sorted by the fourth field (PAT, IMG, DIR) of the
2767 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2768 are now in the "???" group.
2769 - python/gdcm.i changed accordingly,
2770 - python/demo/printGroupedPublicDict.py added, that gives an example
2771 of the above new functionalities in Python.
2773 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * src/gdcm.h, gdcmHeader.cxx:
2775 - historic references to glib's g_malloc and g_free (#defined)
2776 were definitively removed.
2777 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2778 * src/gdcmElValSet.cxx:
2779 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2780 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2781 - GetElValue(string) renamed to GetElValueByName.
2782 - Added GetElementByName(string).
2783 * src/gdcmHeader.cxx: added
2784 - GetPubElValRepByNumber(guint16, guint16)
2785 - GetPubElValRepByName(string)
2786 - GetShaElValRepByNumber(guint16, guint16)
2787 - GetShaElValRepByName(string)
2788 - GetShaElValByNumber(guint16, guint16)
2789 - GetShaElValRepByName(string)
2790 - GetElValRepByNumber(guint16, guint16)
2791 - GetElValRepByName(string)
2792 - GetElValByNumber(guint16, guint16)
2793 - GetElValRepByName(string)
2794 * Doc/requirements.txt added.
2796 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * Test/Makefile building now depends on the one of libgdcm.so
2798 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2799 pixel data) aware which enables finding the address (offset) of
2800 the pixel data of JPEG encoded DICOM files. This leaves only a single
2801 file in the testSuite whose pixel data address (offset) is unknown.
2802 * python/testSuite.py changed accordingly.
2804 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2805 * VC++ has some strong limitations when working with the STL, as stated
2806 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2807 "Also note that some STL containers (map, set, queue, list, deque)
2808 cannot be exported. [...]
2809 Some STL classes contain nested classes. These classes can not
2811 This is caused by a designed limitation that once a template
2812 class is instantiated, it can not be re-instantiated and
2814 Since our usage of map<> is ubiquitous in gdcm, this "designed
2815 limitation" of VC++ is a pitfall.
2816 Hence the Python wrappers of gdcm cannot be incrementally linked
2817 against the c++ dynamic library. The dirty but only workaround is
2818 to forget about incremental link of dynamic libraries and to generate
2819 the Python wrappers library with the inclusions of the underlying C++
2821 The following modifications concern this matter on Win32/VC++:
2822 - wrapping python correct with standalone wrapped dll (don't use separate
2823 dll under windows !!!!)
2824 - python21_d debug mode enabled (ask Frog how to use it :-)
2825 - NO problem with having an STL member of class for example string in C++
2826 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2827 - Python test of dcmlib in Python is ok under windows on a large set
2829 * removed glib references
2830 * typedef's inserted in gdcm.i for correct swig type management
2832 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * python/demo/*.py load.py extracted from test.py. Added explore.py
2834 that only displays required tags and testAll.py that parses all
2835 the files of the testsuite without using unittest.
2836 * python/testSuite.py other additional test on new files added.
2837 * Data/* new test files added accordingly to the testSuite.
2838 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2839 the vr in the file differs from the one of the dictionary.
2841 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2842 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2843 values, but limits itself to values which are below a user specified
2844 size (by default 1024 bytes).
2845 * python/gdcm.i : elements not loaded (because their size is above the
2846 user specified treshold) are exported with their TagKey as key of the
2847 python dictionary. This enables the testsuite to make some checks
2848 on the unloaded elements (since we have their offset and size).
2849 * python/testSuite.py
2850 - now tests for the existence and proper value of the pixel data
2851 - two new examples added.
2852 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2854 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2856 aware. See the strategy comments in gdcmHeader::FindeLength().
2857 * Test/test.cxx now accepts a filename as first argument.
2858 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2859 * python/testSuite.py changed to integrate test on above files.
2861 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2862 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2863 the vr was also RET.
2864 * python/testSuite.py more tests added.
2866 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * python/testSuite.py unittest test suite added (uses Data)
2868 * Data/* dcm and acr files for the test suite.
2869 * glib dependance removed from un*x version. We now use ISO C99
2870 7.18 Integer types (see stdint.h)
2871 - python/Makefile, src/Makefile src/gdcm.h
2872 * src/ when an explicit vr (like dicom files) suddenly poped an
2873 implicit element we use to mark the underlying DictEntry of the
2874 concerned ElValue with "Implicit". This strategy was damageable
2875 too the public or provite dictionaries, since some of their vr
2876 would be changed. Since Header::FindLength heavily relies on the
2877 detection by Header::FindVR of falsely explicit elements, I
2878 added an extra ImplicitVr member to ElValue (boolean).
2879 The rest of the changes we the necessary adaptations.
2881 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2882 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2884 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2886 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * Adaptation for porting to VC++:
2889 o forced to use std namespace (for string to be known)
2890 o all class use __declspec export style on WIN32
2891 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2892 (in stdlib.h on Win32 but in std:: for gcc)
2893 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2894 variable GDCM_DICT_PATH.
2895 * src/gdcmHeader.cxx verbose comments made discrete.
2897 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * python/gdcm.i: added a typemap that converts a C++ hashing table
2899 to native Python dictionary.
2900 * python/demo/test.py:
2901 - now uses the native dictionary for exploration of gdcmHeader.
2902 - takes an optional filename argument (the file to parse).
2903 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2904 PubElVals hashing table.
2905 * Dicts/dicomV3.dic removed error prone trailing spaces.
2907 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * Python wrapping process moved away from src/Makefile to
2909 newly created python/Makefile (as well as gdcm.i)
2910 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2911 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2912 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2913 from the environement variable GDCM_DICT_PATH (when existing).
2914 * src/gdcmDict::GetTag bug fix.
2916 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * Straightforward temporary fixes for swig to build the python wrappers.
2918 src/Makefile now has a python working entry [by working we mean
2919 that we can import de shadow classes without errors].
2921 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * hashtest.cxx removed (since allready in Test)
2923 * src/gdcmlib.h renamed to src/gdcm.h
2924 * src/dcm.i renamed to src/gdcm.i
2925 * src/Makefile prepared for python wrapping
2927 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * src/gdcmHeader.cxx :
2929 - Parsing of header is now separated from loading of element values
2930 (see gdcmHeader::LoadElements).
2931 - general clean up of hopefully all file access (creation of
2932 ReadInt16 and ReadInt32)
2934 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * src/gdcmHeader.cxx :
2936 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2938 - SetLgrElem renamed to SetLength
2939 - GetLgrElem renamed to GetLength
2940 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2941 * src/gdcmElValSet.cxx fixed both GetElValue methods
2942 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2943 due to IdoDude was cleaned out.
2945 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2946 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2947 concentrates on finding the value representation (when it exists).
2948 RecupLgr now only finds the element value length, and it avoids
2949 returning the unecessary skL (skipped length).
2950 Also, offsetCourant was simply removed (with taille_fich) since
2951 it was redundant with the File position internals (by using
2952 ftell and fseek). This also made skL (see above in RecupLgr) usage
2954 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2955 on the libido specificities which are handled through class
2957 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2960 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * Truckload of changes. Parsing of header is barely functional
2962 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2964 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * src/gdcmHeader.cxx many addons of low level methods
2967 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2969 and _IdDcmSWAP_LONG.
2971 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * This corresponds to all the changes decided at the meeting of
2973 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob