1 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * bug fix for compilation on MSVC6
3 * gdcmPython/gdcm.i : rename of classes missed
5 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
7 type and not a string. So, there remove problems on the format of the
10 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
12 Thus, DicomDirXXX are created with a flad that indicates if the created
13 object is empty or not (when not empty, the DicomDirElement is used to
16 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
18 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
20 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
23 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
25 Remove all access to the hash-tables or lists in the objects.
27 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
29 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
30 be complient with all the gdcm source code
32 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
36 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
40 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * Test/ : rename VTK tests to have a best name for the tests
42 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
43 GetFirstEntry/GetNextEntry use
45 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
47 test. Now it's on image content and not on the resulting visualisation...
48 might solve the problem on linux when using the OpenGL drivers
50 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
51 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
52 DicomDirSerie, DicomDirImage
53 Dict, DictSet classes :
54 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
55 -remove InitTraversal method.
56 * UPD Test programs + Example programs
58 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
59 remove useless and never updated keyword \ingroup
61 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
63 is no memory access violation
64 * gdcmPython/demo : add python demos using VTK
66 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
67 * FIX 'Dictionnary' is now spelt 'Dictionary'
68 'wether' is now spelt 'whether'
69 'archieve' is now spelt 'archive' ;-)
71 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
72 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
73 related methods, in order not to expose internal mechanisms
76 * REM methods that exposed internal mechanisms :
77 DicomDir::GetDicomDirPatients()
78 DicomDirPatient::GetDicomDirStudies()
79 DicomDirStudy::GetDicomDirSeries()
80 DicomDirSerie::GetDicomDirImages()
91 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
92 * Removed the Print/indent/default parameter mess. There is absolutely no
93 reason to have to methods, moreover with the second taking the ostream as
94 *SECOND* parameter. This was clearly a bad hack to get things compile.
96 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Complete rewrite of the GetMacAddress code. Now the code is *much*
98 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
99 Unfortunately the main code does not work on SunOS, thus provide a specific
100 code for this platform only (and Win32 of course). Since this seems to be
101 working, change CreateUniqueUID to use GetMACAddress instead of the
102 problematic GctestetIPAddress
104 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
105 * Unfortunately to be able to test gdcmDirList I had to break the API
106 a little. Now the class is not a std::list anymore but has a member
107 std::vector (more ITK compatible). Allow unit testing on Win32 and
110 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Update SerieHeader to take into account a Serie Instance UID to properly
114 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
115 * ENH - Comment out Mathieu's (dangerous) Super Hack
116 for dealing with BIGENDIAN processors
117 - Move equivalent stuff to BinEntry::WriteContent
118 When necessary, 16 Bits Pixels are swapped in a small buffer
119 and then written. This avoid allocating a huge buffer, in
120 PixelWriteConvertor, and avoid modifying the Pixel Area.
122 Probabely, the same operation will have to be done when we want
123 to write image with Big Endian Transfert Syntax,
124 and we are working on Little Endian Processor
126 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
129 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
130 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
131 all the dict content.
132 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
134 * Test/TestDict.cxx : add a new test for the dict classes
136 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
138 file. Debug is yanked if compiled with NDEBUG
140 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmDictSet.h : set the default output to the os variable
142 * src/gdcmDictEntry.[h|cxx] : add the Print method
143 * gdcmPython/demo/ : add a new test
145 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
146 * merging of Test/PrintDicomDir and Test/TestDicomDir
147 * removal of now redundant Test/PrintDicomDir
148 * enhancement of Example/PrintDicomDir
150 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * Now, python test might work on systems
152 * Add the PrintDicomDir test
154 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * FIX : First entry following group 0002 was lost for
156 Explicit Big Endian Transfer Syntax files
157 (group and elem not swaped)
159 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
161 Big Endian Transfer Syntax supposed the group following 0002
162 begins always by element 0000 (element 0000 is *optional*)
163 To avoid further troubles, let's be pessimistic, and use
164 Document::HandleOutOfGroup0002() method
165 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
166 (related pb not yet solved)
168 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * Bug fix for the python part use
170 * Now, PrintHeader.py pass... but outside the ctest use. shit !
172 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
175 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
176 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
177 a string and should ask the global TS dict what are the propreties of
180 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
182 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
183 to swap the Swap Code, at parsing time, when we come out of group 0002
184 and Transfer Syntax is Big Endian
185 We should be able to read now 'true DICOM" Big Endian coded images
186 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
187 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
189 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
190 * Hopefully fix the bug on MacOSX and static global initialization.
191 This is the only -minor- patch I found that both please MacOSX and VS6.
192 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
193 but this would require a lot of change. Another approach would be that Global
194 create those string and GDCM_UNFOUND becomes a pointer to a string (which
195 gdcm::Global would destroy at exit).
197 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
198 * Fix bug on MacOSX with static initialization in a multy threaded
199 environment. static const string in a header file used to be ill
200 initialized provoquing the freeze of any tests. patch should solve this
203 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * According to Benoit's suggestion, and without any objection from anybody
205 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
206 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
207 - method gdcmDicomDirObject::GetEntry() renamed as
208 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
210 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
211 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
212 you debug/warning message just as c++ streams which make them very convinient
213 to use. Once this is stabilize I will change the ostringstrem to be
214 redirected to a file (ofstream).
215 * Properly support C99 extension: __FUNCTION__ which allow us to display
216 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
218 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * Removal of useless and dangerous methods :
220 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
221 GetDocEntryByName, GetEntryByName, GetDictEntryByName
222 * Removal of usless methods :
223 Dict::PrintByName, Dict::GetDictEntryByName
224 * Commenting out of probabely useless methods :
225 Dict::GetDictEntryNames()
226 Dict::GetDictEntryNamesByCategory()
227 DictSet::GetPubDictEntryNames()
228 DictSet::GetPubDictEntryNamesByCategory()
229 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
230 * ENH : Use dicomTS.dic as described in 2004 version
231 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
232 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
233 Add Accessors on VM (Value Multiplicity), and VM related methods
234 * ADD : Add a list of 'Dicom Attribute types', as found in
235 http://medical.nema.org/dicom/2004/04_15PU.PDF
237 * ADD : Add dicomGroupNameAbbreviations.dic
238 should be used to write a method to replace the former
239 Dict::GetDictEntryNamesByCategory()
241 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
243 to read in the file... and only it ! Length is the efective length of the
244 data in the DocEntry structure
246 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
248 And now use a static function call instead, with a global variable. i
249 This is much closer to the VTK approach. Hopefully should be bulletproof
250 and easier to use...hopefully
252 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
253 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
255 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
258 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
260 ValEntry, BinEntry, SeqEntry creation or replace
262 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
264 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
266 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
267 when specifying the VR
268 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
269 * src/gdcmDocEntry.cxx : amelioration of print
271 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
272 * ADD : Add the method Util::IsCurrentProcessorBigEndian
273 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
274 * ADD Method Document::ComputeGroupLength
275 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
276 in order to allow further VR modification by user
277 * REM : removal of once-called method File::WriteBase
278 integration of its code in formerly one-line method File::Write
280 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
282 replace the different values "??", "Unkn", "Unknown".
283 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
284 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
285 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
286 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
288 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
291 * Set the gdcm::Base class to some Printable classes
293 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * src/gdcmFile.[h|cxx] : add the Print method
295 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
296 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
297 * src/gdcmDocument.h : remove the PrintLevel informations
298 * Example/PrintFile.cxx : use the new gdcm::File::Print
300 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
302 problems when compiling with the python wrapping
304 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
306 writting in ImplicitVR
308 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
309 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
310 JPEG decompression, especially when dicom frames are split into several
311 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
312 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
314 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmHeader.cxx : change the initialisation of default header.
316 Now, this header is readable by gdm, e-film, DicomWorks
318 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
320 Rename Decompressed to Raw
321 * Use the API changes in gdcm::File.
322 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
325 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
327 each added entry in the header. Replace the 'Planes' field by the 'Number
330 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
332 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
334 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
336 At this time, this image isn't readable by e-film... waiting JPR help to
339 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
341 DocEntry. Now use methods of the Document !
343 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
344 * Test/ShowDicomSeq.cxx : bug fix
346 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
348 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
349 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
350 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
352 * Test/TestCopyRescaleDicom.cxx : remove unused variable
353 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
354 containing found sequences
356 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
359 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
360 Some fields in BinEntry must be copied to not seg fault when making the :
361 gdcm::File *copy = new gdcm::File( copyH );
362 and tests are now made on good variables
364 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
366 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
368 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
369 * Add vtkGdcmWriter example and test
371 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Test/TestUtil.cxx : reformat the source code
373 * vtk/vtkGdcmReader.cxx : remove and change prints
374 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
376 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
377 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
379 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
381 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
383 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
385 by an eof to prevent all bad read of the file... and in this case, the
388 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * Example/Volume2Dicom.cxx : comment unused variables
390 * Test/PrintDicomDir.cxx : comment unused variables
391 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
392 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
393 method that is redondant with AddEntry.
394 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
397 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * Bug fix due my last commit (compilation under Windows).
399 * Example/Volume2Dicom : bug fix in the file and reformatting source code
400 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
402 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
404 - Remove printf / sprintf
405 - include iostream AFTER gdcm so we don't get warnings
406 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
408 - Also remove tons of include from header files, hopefully this should
409 speeup the compilation time, since it was becoming a dog slow.
410 - Remove gdcm.h as it include way too many files and slow down compilation
411 (plus it is not up to date)
412 - remove 'using namespace std' this is BAD !
414 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * Remove memory leaks on the DicomDir
416 * Remove some useless data in DicomDirObject
417 * Add usefull methods in SQItem, to be complient withe the ElementSet
419 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
422 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
424 future, with convertion)
425 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
426 and ImageDataSize values. Remove the method to get the PixelReadConverter
427 from the output of the class
429 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
432 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
434 and vtkErrorMacro use.
435 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
437 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
438 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
440 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
441 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
442 The string leaves only in the fonction. So when we make a .c_str(), we
443 get the pointeur on the first element, element that will be destroyed
444 immediately after thee instruction.
445 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
446 file has been opened : the test must be made on the content of the
447 pointer and not directly on the pointer !
450 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
452 the python part recompiles
454 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
456 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
457 X session is killed (for my computer... it seems to not be identic on
460 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
462 avoid problems (otherwise, the difference test between the visible image
463 and the reference is incorrect. If the reference is greater than the
464 screen resolution, it's produce errors).
465 Can be used for only one image. Can be used with a visible flag.
466 * vtk/vtkGdcmReader.cxx : remove commented codes.
467 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
468 under windows at compilation
469 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
471 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
473 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
475 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
476 tests on the image size X, Y, Z
478 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
480 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
481 between the class name and the file name
483 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/ : fix compilation warnings for the Write method (2 different
485 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
486 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
487 variable... create a static method in gdcm::Document to access to
488 this variable content.
490 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
492 file, to be accessed by other files (like gdcmFile). Remove commented
493 code. Move the change of the header to the gdcmFile, using the
495 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
496 To be sure of that (and simplify calls), the Write of the header now
497 gets a file name and not a file pointer (std::ifstream).
498 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
499 DocEntryArchive. Remove all open of the written file
501 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
504 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
506 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
508 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
509 some corresponding methods. Write correctly the file and check before
511 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
512 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
513 is now on RGB data (as before my last commit
514 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
516 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
518 Add a print information of the type of the entry
519 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
520 It was in the gdcmFile, and all write have been regrouped
521 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
522 Write correctly all dicom files (in decompressed mode only at this time)
523 * Test/ : test on files are now made using Raw data and not color data if
525 * Example/PrintFile.cxx : add more printings
527 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * Amelioration of code, remove some code copy. For the loading of
529 BinEntry (in gdcmDocument), add the test to verify if the file is already
532 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
534 remove a DocEntry in the header (push an empty DocEntry)
535 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
536 lines. Bug fix in the initialization of the PixelConvert and the
538 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
539 use in TestCopyDicom (now this test can run under windows... but fails)
540 * Test/TestCopyDicom.cxx : amelioration of the test :
541 - test the pixels written
542 - add test points to quickly find where is the error
543 - can set a file name input and output in arguments
544 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
545 amelioration of the test output
547 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
549 all replaced DocEntry's
550 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
551 Now, each needed DocEntry to modify is duplicated, modified and inserted
552 to the header using DocEntryArchive. Thus, after save, we can restore the
553 header initial state.
555 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
558 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
560 correct to copy it. The DictEntry is specified at the DocEntry creation,
561 then, it musn't change in the time.
562 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
563 header correctly. At this time, the change is only made for the first
564 level of the Document. In the future, it might consider sequences.
565 The change is made by replacing a DocEntry by an other that is created
566 outside the class. The old value is kept. When we restore the header
567 status, the added DocEntry is deleted and replaced by the old value.
568 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
569 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
570 set the write type to explicit VR, implicit VR or ACR. Add methods to set
571 the write mode to native, decompressed or RGB (but not used at this time)
573 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
575 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
577 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
579 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
581 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
582 set because already copied when copying the BinEntry's of the header
583 * Test/TestAllReadCompareDicom.cxx : remove warnings
585 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
587 Two problems appear when doing it :
588 - with the gdcmFile : when the GetImageData method is called, the pixels
589 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
590 data (pixels). And each structure destruct the data when it's
591 destructed. So we have two destructions for the same data. To solve it,
592 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
593 data or not. If it doesn't own data, then they will not destroyed by
595 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
596 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
597 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
598 create a double destruction of the same DocEntry's. So, to solve it,
599 the TagHT is simply cleared and the DicomDir* elements are destroyed.
600 * TODO : add an entry concerning memory leaks in the DicomDir
602 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
604 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
607 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
609 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
610 after it have been deleted
612 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * FIX: src/* fix the doxygen warnings.
614 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
615 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
616 was erroneously defined with a size of 15 instead of 16. [many thanks
617 to Jean Michel Rouet for pointing out this bug].
619 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
620 1. Finish merging JMR patch for writting DICOM from scratch
621 2. Fix -hopefully- bug with MONOCHROME and space vs null character
622 3. Use const ref when possible
623 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
624 5. A few more comments
625 6. CreateUniqueUID can now be called without parameter"
627 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
628 * ENH: Slightly bigger patch:
629 1. Getting toward full integration of JMR patch for writting dicom from scratch
630 2. Update Test to test part of this patch: CreateUniqueUID
631 3. File was not close properly in gdcmDict
632 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
633 5. Use of const ref instead of copy (speed issue)
634 6. Remove temporary (duplicate) string in TranslateToKey
635 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
636 8. Do not repeat virtual in subclasses
637 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
639 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
640 * Apply first patch toward better string comparison when dealing with broken
641 DICOM files. Essentially the string could be padded with a space instead
642 of a null character as defined by standard
644 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
646 because never used... and in the same time, that's remove some memory leaks
648 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * src/gdcmFile.cxx : now delete the PixelConvert instance.
650 * In examples and tests : change the type of image data variables from void*
651 to uint8_t*. Remmove all delete on image data variables
653 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
655 Verify the file pointer value before open the file, and if it's not null,
656 a verbose message is generated.
657 Close correctly the file when the file isn't considered dicom-like. The
658 correctly close is a call to CloseFile.
659 When closing the file pointer, test if its not null to close the file.
660 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
661 file. For an uncompressed image, the copied data correspond in the least
662 case to the image size (calculated) or the image size specified in the
663 header. A verbose is generated if these two size mismatch
665 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
667 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
668 break under windows (with msvc6 compilation).
670 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
672 compiling with MSVC6)
674 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * Bugs fix for the Windows build with VC6
676 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
677 needed (only for projects required VTK). If the VTK is included in all
678 projects, there is conflicts with the jpeg lib of vtk when compiling the
679 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
680 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
681 when compiling the gdcm_wrap.cxx file (created by the compilation of the
683 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
684 (like it's already made for the cout use). Otherwise, conflict with the
687 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
690 - comments on the DicomDir::Method related usage added.
691 - now that we use the namespace gdcm, a lot of internal classes do
692 NOT need to be wrapped anymore.
693 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
694 DicomDir::Method) new example added.
696 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
697 * Improve string manipulation. I now inforce the notion of 'DicomString'
698 A DicomString can contain as many \0 as they want
699 and it is *always* of even length.
700 We only support odd length for very rare case.
701 And in the near future this should be removed.
703 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
704 * /binary_write/ gdcm source. Now even on big endian we are writting
705 little endian. This should -heopfully- fix some tests
707 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
708 * Now the dictionary is compiled into gdcm lib. This is a default
709 behavior, thus any dic file specified is picked before failback to
710 the one comiled into lib
712 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * Change internals for gdcmDict. Don't use any 'new' any more.
714 This should definitely solve any leak problem, and we should be
715 as fast as before, as long as don't modify too much the dictionary.
717 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
718 * STYLE: ivars should start with a capital letter.
719 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
720 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
722 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
724 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
725 new 2004 dictionaries added (thanks to JPR).
726 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
727 * CLEANUP_ROUND (15) for gdcmPixelConvert
728 - RLEFrame::NumberFragments is now of type unsigned int
729 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
730 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
733 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * Initial work in gathering all transfer syntax accessors. clearly
735 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
736 ivars, but only one transfersyntax (class) ivar with equivalent method on
739 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
740 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
741 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
742 discussed (plus I didn't like having a 2000 lines patch not commited)
744 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
746 * CLEANUP_ROUND (14) for gdcmPixelConvert
747 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
748 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
749 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
751 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
752 anymore and hence avoids storing a copy of PixelConvert::Decompressed
753 into File::Pixel_Data.
755 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
757 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
758 * CLEANUP_ROUND (13) for gdcmPixelConvert
759 Substituted File::ParsePixelData() with PixelConvert::Print() new
761 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
762 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
763 method to those classes.
764 - src/gdcmFile.[cxx|h]:
765 -- Added a ::Print() method.
766 -- PixelConverter is now a reference instead of a member.
767 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
768 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
770 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
772 collaboration diagram and inheritance diagram should be generated with
774 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
775 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
776 pointlessly wrapped (see
777 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
778 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
779 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
780 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
781 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
782 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
783 -- File::Initialise: PixelConverter setup moved away to
784 PixelConverter::GrabInformationsFromHeader()
785 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
786 interpretation moved away to PixelConverter::BuildRGBImage()
788 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
789 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
790 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
792 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
794 displayed on Win32 when a brutal abort() occurs (because of uncatched
795 exception). See TODO new entry of this commit for more on this.
796 * TODO added new entry.
797 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
798 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
799 - HandleColor is no longer called from gdcmFile.cxx
800 - gdcmPixelConvert.cxx clean up on method arguments and internal
801 variable names for semantical coherence.
803 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
804 * Finished lossless transition, not only do we now read all lossless jpeg
805 images, without the need of the Cornwell lib, but we do read them properly now
806 * To reduce code (well to avoid code duplication), I defined a common place
807 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
808 redefine symbols. This is not perfect but this the best solution I found for a
809 compilation time jpeg option.
811 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
812 * Update jpeg ijg lib to support lossless jpeg implementation
813 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
815 * Also added a special copyright for dcmtk since we use their bugfixes.
818 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
820 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
821 matters, as stated in warning note at begining of %include section).
822 * src/gdcmDicomDir*.[cxx|h]: coding style
823 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
824 * src/gdcmJpeg8.cxx: doxygen fix.
825 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
826 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
827 from File:: to PixelConvert::.
829 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
831 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
832 - more code moved away from File:: to PixelConvert::
833 - fat setup of PixelConverter set in place in File::Initialise.
835 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
836 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
837 namespace at the file system level. So now you should convert your examples
839 gdcmHeader -> gdcm::Header
840 It would be nice if people keep in mind to no open the namespace, since it
841 allows compilation on broken plateform which were defining common symbol in
842 the standart namespace (like LP, Unknown ...)
844 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
846 The JPEG fragments are now parsed at the same stage than the RLE
847 information. All code related to JPEG is now in gdcmPixelConvert:
848 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
849 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
850 export a gdcmFile:: method. Those are simply global functions
851 (for the time being this is better than having them attach to
852 either gdcmFile:: or gdcmPixelConvert::).
853 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
854 and stores the result in a gdcmJPEGFragmentsInfo.
855 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
856 code (among other stuff) moved away from gdcmFile:; to
859 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
861 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
862 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
863 clean up of RLE related code.
864 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
865 - src/gdcmRLE.cxx removed
866 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
867 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
868 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
869 * CLEANUP_ROUND (9) for gdcmPixelConvert
870 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
871 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
872 away from gdcmFile:: to gdcmPixelConvert::.
874 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
876 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
877 This is because Parse7Fe0 used to parse the pixels to compute the
878 length. This task was passed over to FindDocEntryLengthOB() a long
879 time ago, EXCEPT I had forgotten the OW case...
880 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
881 we just recylce the code for parsing RLE fragments and computing
883 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
884 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
885 with the retired Parse7Fe0().
886 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
887 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
889 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
890 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
891 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
892 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
893 - src/CMakeLists.txt: alphabetic order reodering + new entries.
894 * CLEANUP_ROUND (4) for gdcmPixelConvert
895 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
896 to return an unused length.
898 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
900 this should be cleanner from the plane view. The iostream are erally a pain
901 to use to do simple stuff.
903 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
904 * Redo the compilation of the ijg jpeg library. Now only one source is
905 necesseray. No need to rename file by hand what so ever. CMake handle the
906 copying of the file within different directory, configure header file to
907 modify some symbol. The only addition made to ijg wasd a mangle table so
908 that symbol are different whether we are within 8bits or 12bits.
910 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * Added documentation of vtkgdcmReader on Website:
912 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
913 with it's binary name).
914 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
915 the Website to be more complete.
916 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
917 doxygenated documentation.
918 - Doc/DoxyVtkGdcmReaderExamples.txt added
919 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
920 DoxyVtkGdmReaderExamples.html )
921 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
922 * CLEANUP_ROUND (3) for gdcmPixelConvert
923 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
925 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * CLEANUP_ROUND (2) for gdcmPixelConvert
927 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
929 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * CLEANUP_ROUND for gdcmPixelConvert:
931 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
932 - src/gdcmPixelStuff[h|cxx] removed
933 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
934 - src/CMakeLists.txt changed accordingly
936 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
937 gdcmVersion.py moved to newly created ATTIC related
938 gdcmPython/SetupOldies/ directory.
939 * Autotools clean up:
940 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
941 - autogen.sh configure.in acinclude.m4 python.m4 removed
943 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * src/*.cxx *.h Reference to License.htm fixed to License.html.
945 * Doc/CMakeLists.txt, doxygen.config.in: fix.
946 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
948 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * TODO updated with Mathieu suggestions. I proposed a template for
950 describing TODO entries and used it for new entries.
951 * Added Doc/Website/CodingStyle.html, Developpers.html,
952 DeveloppersPython.html, GdcmDataCvs.html and
953 DownloadVersion0_1.html, DownloadVersion0_3.html.
954 * Some Doc/*.txt Doxygen files (which do not really concern the
955 documentation itself, but the website) moved to html and
956 placed in directory Doc/Website:
957 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
958 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
959 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
960 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
961 * CMakeLists.txt changed accordingly.
962 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
963 DeveloppersPython.html
964 * INSTALL nows refers to Doc/Website/Installation.html
966 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * Added Doc/Website directory, that contains a first raw version
970 2004-09-23 Jean-Pierre Roux
971 * FIX In order not to be poluted any longer by casting problems,
972 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
973 we can now delete[] it safely
974 * VoidArea is now called BinArea (less confusing name),
975 and all the methods called ...VoidArea... are now ... BinArea...
976 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
978 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
979 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
980 clear) TagHT, which is an inherited member of gdcmElementSet. It is
981 up to the destructor of gdcmElementSet to clean up TagHt and it's
984 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * Test/CMakeLists.txt: update to follow gdcmData renamings.
986 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
988 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * ENH: added some utility method that builds a flat dictionary
990 holding all the Dicom entries contained in the recursive structure
991 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
993 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
994 BuildFlatHashTable() that build a flat dictionary.
995 - src/gdcmElementSet.h: added a new private GetTag() accessor.
996 gdcmDocument is now a friend of gdcmElementSet.
997 - src/gdcmElementSet.cxx: clean up.
998 - Example/FlatHashTablePrint.cxx added.
999 - Example/CmakeLists.txt changed accordingly
1001 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1002 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1003 moved away from gdcmDocEntrySet (since this class is an abstract class
1004 acting like an interface). SQDepthLevel and BaseTagKey are now
1006 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1007 and associated accessors. Doxygenation of the class.
1008 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1010 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1011 Use SQDepthLevel accessor instead. ::Print() adapted.
1012 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1013 - src/gdcmDocument.cxx changed accordingly.
1015 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1017 - The following is the doxygen comment of the typedef declaration
1018 of gdcmTagKey in src/gdcmCommon.h:
1019 gdcmTagKey is made to old an "universal" (as in URL, Universal
1020 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1021 A dicom tag always has a group and an element, but a set of tags
1022 embeded in various (optionally nested) sequences and sharing
1023 the same group and element all share the same (group, element)
1024 "identifier". Hence the (group, element) cannot be used as an
1025 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1026 In order to construct a proper tag identifier (i.e. a key) we
1027 consider the following definition of a TagKey:
1028 - let Group, Element be the string representation of the
1029 group and element dicom tag members,
1030 - let ItemNumber be the string representation of the integer
1031 index of the considered item number of a sequence,
1032 Let the key of a tag embeded in a sequence, noted SeqTag, be
1034 /ItemNumber#Group|Element
1035 where "/", "#" and "|" are characters acting as separators.
1036 Then the general form of a gdcmTagKey is given by:
1037 Group|Element<SeqTag>
1038 where <SeqTag> means NO or many instances of SeqTag.
1039 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1042 but the gdcmTagKey of a tag "embeded" is the first item of
1043 a sequence, itself nested in the third item of a sequence is the
1045 0004|1220/2#0008|0082/0#0008|0090
1046 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1047 order to hold the new sequence compatible key. Previously, the
1048 GetKey() method would look in the underlying gdcmDictEntry.
1049 - src/gdcmDocEntry.cxx:
1050 -- constructor now copies the underlying DictEntry key, in the local
1052 -- ::Print: displays the member Key, instead of the (group, element).
1053 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1054 - src/gdcmDocEntrySet.h:xi
1055 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1056 -- now has a new BaseTagKey member.
1058 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1059 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1061 This poses the problem with the semantics of the following lines
1062 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1063 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1064 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1065 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1066 to the long FIXME note for what the problem is. Nevertheless in
1067 order to get things working the dicom dictionary was altered !
1068 Please fix things urgently...
1069 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1070 information), see above note on moving the member VoidArea. Nevertheless
1071 the following entries previously correctly set as US are now inproperly
1073 0028 1201 OW IMG Red Palette Color Lookup Table Data
1074 0028 1202 OW IMG Green Palette Color Lookup Table Data
1075 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1076 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1077 of gdcmDocEntry moved to gdcmSeqEntry.
1078 * src/gdcmSeqEntry.cxx: STYLE.
1080 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1083 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * gdcmPython/testSuite.py: all the test suite in python is now moved
1085 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1086 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1087 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1089 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1091 to avoid inclusion recursion until STL is reached.
1092 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1093 mecanism. errno.h is not included in gdcm anymore.
1094 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1095 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1097 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1098 gdcmData/TestAllEntryVerifyReference.txt
1099 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1100 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1101 exception_on_error parameter.
1102 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1103 - vtk/vtkGdcmReader.cxx changed accordingly,
1104 - Example/*.cxx and Test/*.cxx changed accordingly.
1106 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1108 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1109 enable_sequences removed from gdcmHeader constructor and dependencies.
1110 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1111 * gdcmPython/demo/PrintHeader.py: dummy fix.
1112 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1113 skip_shadow removed from gdcmHeader constructor and dependencies.
1114 * Example/*.cxx and Test/*.cxx changed accordingly.
1116 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1118 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1120 2004-07-21 Jean-Pierre Roux
1121 * FIX Now, Parsing and Printing a DICOMDIR do work!
1122 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1124 2004-07-20 Jean-Pierre Roux
1125 * FIX Some brain damaged headers have Zero-Lenght fields
1126 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1128 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1129 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1130 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1131 variable (instance of gdcmDebug) by a definition macro, and the instance
1132 is now in static in the gdcmDebug class
1133 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1134 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1136 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * WARNING: ctest now depends more tightly on gdcmData. You should
1138 check out gdcmData properly for things to run smoothly...
1139 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1140 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1141 we need the pixels not be loaded in order to use the ValEntry
1142 that displays position and size).
1143 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1144 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1145 be deprecated. If you have any doubts about the advantages of a
1146 modern scripting language (read Python) versus grass root C++ (i.e.
1147 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1148 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1149 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1150 Anyhow, consider documenting the gdcmData images in
1151 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1153 * Test/CMakeLists.txt:
1154 - now uses TestAllEntryVerify.cxx
1155 - specific comments on oldACR00001.ima (now renamed in gdcmData
1156 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1157 gdcmData/TestAllEntryVerifyReference.txt
1160 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * src/*.[h|cxx] : typedef clean up
1162 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1163 - TagKey renamed to gdcmTagKey (for external usage)
1164 - VRKey renamed to gdcmVRKey (for external usage)
1165 - removal of typedef duplication.
1166 - Removed all unecessary inline keyword from class inline definitions.
1167 - Some method|function(void) declarations replaced with method|function().
1168 * src/jpeg/libijg12/jdhuff12.c:
1169 - printf polluting ctest removed.
1170 - TAB removal for comminting
1172 - TestAllReadCompareDicom.cxx: added a test that compares all the
1173 images in gdcmDataImages.h with corresponding images in
1174 gdcmData/BaselineDicom/. When baseline images are not present
1175 this test creates them.
1176 Note: we need to validate each reference image, but before that
1177 I'd like to rename them with a more explicit name...
1178 - CMakeLists.txt: changed accordingly.
1179 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1180 including each header needed).
1182 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1183 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1184 test suite to the Example directory. Are concerned:
1189 - TestWriteSimple.cxx
1190 * Test/CMakeLists.txt: added some comments on reasons for black listing
1191 image gdcmData/oldACR00001.ima
1193 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * Test/CmakeList.txt: removed the following from black list (to be coherent
1195 with removal from gdcmData):
1196 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1197 - gdcm-MR-PHILIPS-16.dcm
1199 Added the following because after last cvs update, they cause
1200 ctest -R TestReadWriteReadCompare
1202 - gdcm-MR-SIEMENS-16-1.acr
1204 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1205 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1206 new comments in this file) we temporarily (sigh) move to a weaker
1208 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1209 we don't need to black list the following images anymore:
1210 - 8BitsUncompressedColor.dcm
1212 - US-PAL-8-10x-echo.dcm
1213 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1214 fixes and the beautified code ;-)
1215 This fixes the bug introduced in version 1.42 (when beautifying)
1216 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1217 Note: ctest was blind to this bug (this means we need to still
1218 improve the test suite). The bug could be detected by using
1219 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1221 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1222 and by displaying the (garbage) produced file temp.XDCM...
1224 2004-06-29 Jean-Pierre Roux
1225 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1226 - replace by uggly but working old code :-(
1227 A lot of things should be OK again.
1228 It's really urgent to have a test suite that *tests*,
1229 to prevent Frog's beautifying sessions to break all the stuff
1230 (twice, withing a fortnigh ...)
1232 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1234 redundancy) to added Test/TestReadWriteReadCompare.cxx
1235 * Test/CmakeList.txt: because the compare test of
1236 Test/TestReadWriteReadCompare.cxx fails, the following images are
1237 black listed: - 8BitsUncompressedColor.dcm
1239 - US-PAL-8-10x-echo.dcm
1240 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1241 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1242 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1243 and ad-hoc kludge. This kludge is now removed, and on encountering
1244 such an image (OB field brain damaged) we set errno. Then in
1245 ::FindDocLength() we "fix" the length as being ALL what remains
1246 in the file (until EOF). We then proceed, hoping for the best...
1247 This fixes a SegFault in ShowDicom when trying to write such an
1249 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1250 (because TestWriteRead breaks on it, after a non conformal commit?).
1251 ctest now runs properly, except for MakeDicomDir (which was always
1252 broken) and the Python related stuff (still not fixed).
1254 2004-06-24 Jean-Pierre Roux
1255 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1256 FIX : Test/TestReadWrite now iterates on all the file names
1257 (instead of infinite loop)
1258 ENH : Test/TestWriteRead now iterates on all the file names
1260 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1263 2004-06-24 Jean-Pierre Roux
1264 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1265 when SamplesPerPixel =3
1266 - now Write is no longer confused by
1267 'BitsAllocated = 12" and 'BitsStored=12"
1268 - "UN" value representation Elements are now written correctly
1269 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1270 ENH : - now gdcmHeader has its own Write methods
1271 (in order to split the job that has not to be done
1274 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1276 loop on the same image until memory went out.
1277 Note: this means we still have gobs of memory loss in PrintDocument
1278 * src/gdcmDocument.cxx: fixes problem on parsing on file
1279 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1281 2004-06-24 Jean-Pierre Roux
1282 FIX : Write - All the Sequences and Sequence Item are now written
1283 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1284 is added a the end, when necessary.
1285 - A lot of brain-damaged images, that were read correctly are
1286 now written correctly
1287 - length compatible BinEntry are now loaded correctly
1288 (even for odd groups)
1289 Note : only Explicit Value Representation was checked.
1290 (question : is implicit VR really necessary for gdcm ?)
1292 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * DEVELOPPER: added a proposition of coding style.
1294 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1297 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1298 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1299 Use the gdcmDocEntry::Print() and Write() instead.
1300 * src/gdcmDocument.cxx: bug fix.
1302 2004-06-22 Jean-Pierre Roux
1303 FIX : gdcmDocument.cxx
1304 - Now we do recognize the JpegLossLess format (there was a misstyping in
1305 code 'beautyfication' :-(
1306 - Now we automaticaticaly load the Luts, if any
1308 2004-06-22 Jean-Pierre Roux
1309 In order : to write Sequences, whatever their imbrication level,
1310 : to allow user to create his own Sequences
1311 a lot of modif where necessary (adding, moving, or virtualising methods)
1313 WARNING : save your own sources *before* cvs up !
1316 ADD virtual void Write(FILE *fp, FileType filetype);
1319 ADD virtual void Write(FILE *fp, FileType filetype);
1320 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1323 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1324 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1325 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1326 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1327 ADD std::string GetEntryByName(TagName name);
1328 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1330 std::string vr = "unkn",
1331 std::string fourth = "unkn",
1332 std::string name = "unkn");
1333 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1334 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1335 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1336 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1337 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1338 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1339 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1340 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1343 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1344 ADD virtual std::string GetEntryByName (TagName tagName);
1345 ADD virtual std::string GetEntryVRByName (TagName tagName);
1346 REM virtual bool Write(FILE *, FileType);
1347 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1348 FILE *_fp, FileType type);
1349 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1350 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1351 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1352 REM virtual std::string GetEntryByName (std::string tagName);
1353 REM virtual std::string GetEntryVRByName (std::string tagName);
1354 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1355 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1356 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1358 std::string vr = "unkn",
1359 std::string fourth = "unkn",
1360 std::string name = "unkn");
1361 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1362 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1363 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1364 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1367 ADD virtual void Write(FILE *fp, FileType filetype);
1370 ADD virtual void Write(FILE *fp,FileType filetype);
1373 ADD virtual void Write(FILE *fp, FileType filetype);
1374 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1375 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1376 REM std::string GetEntryByName(TagName name);
1379 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1381 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1383 The default constructor invoked by the line
1384 gdcmHeader *f1 = new gdcmHeader( header );
1385 was gdcmHeader::gdcmHeader(bool) instead of the expected
1386 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1387 Hence the parsing wasn't executed... See also below.
1388 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1389 as explicit constructor didn't do the trick to fix the above problem.
1390 Could anyone explain why ?
1391 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1392 properly calls gdcmValEntry::Print() (that was weed out from
1393 code related to gdcmBinEntry).
1395 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1396 * In order to fix memory leaks:
1397 - Test/TestWriteSimple.cxx: added cleaning of free store through
1399 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1400 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1401 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1402 (through the call to ::AddDicomDirMeta()) or the destructor
1403 would crash when deleting uninitialized ::metaElems].
1404 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1405 - src/gdcmDocument.cxx:
1406 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1407 from dynamic stores.
1408 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1409 was causing memory leaks.
1410 - src/gdcmSQItem.cxx:
1411 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1412 cleanly handled with polymophism: sorry but my milage is low).
1413 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1414 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1415 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1416 This avoids SegFaulting.
1417 - src/gdcmSQItem.h: coding style.
1419 - Test/TestWriteSimple still severely sucks. The output image content
1420 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1421 damaged when displayed with vtkgdcmViewer.
1422 - on memory leaks: TestWriteSimple leaks really less (see entry
1423 of 2004-06-18 in Changelog file for the call to valgrind).
1424 - on segfaults: ctest now passes all the tests but one (no more
1426 * Erroneous leading white fix:
1427 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1428 white[s] (as opposed to from >> xxx, that removes it [them].
1429 - src/gdcmTS.cxx: ditto.
1430 - gdcmPython/testSuite.py: dirty related kludge removed.
1431 * src/*: remaining references to gdcmParser removed.
1432 * src/*[cxx|h]: added copy[way]left header.
1435 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * In order to fix writing of dicom files:
1437 - Test/TestWriteSimple.cxx: a simpler example of writing.
1438 - Test/CMakeLists.txt changed accordingly.
1439 - src/gdcmDocument.cxx:
1440 -- The destructor now recursilvely removes potential sequences.
1441 -- Bug fix in ::IsJPEG2000()
1442 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1443 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1445 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1446 to only declared) and build on top of
1447 ::GetDocEntryByNumber(guint16, guint16).
1448 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1449 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1450 for usage in destructor and treatement of promotion in
1451 ::ReplaceOrCreateByNumber().
1452 - src/gdcmSQItem.cxx: destructor should better handle his job.
1453 Test/TestWriteSimple now runs (or at least it DOES something).
1454 * We can now start hutting memory links. A good starting point is:
1455 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1456 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1457 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1459 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1460 * Valgrind note: after Mathieu Malaterre teached me how to read
1461 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1463 Using gcc, you can force the STL to use malloc and to free memory as
1464 soon as possible by globally disabling memory caching.
1465 With 3.2.2 and later, you should export the environment variable
1466 GLIBCPP_FORCE_NEW before running your program.
1467 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1468 simply vanish (it is still not clear to me, whether this means that
1469 STL std::string leaks or if valgrind believes it leaks...).
1470 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1471 running bin/gdcmTests makeDicomDir):
1472 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1473 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1475 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1476 SegFaulting (I drowned in DicomDir related code when trying to
1477 understand why the list is empty...).
1478 * src/gdcmDocument.h: first BSD license header try.
1479 * Doc/License.txt added.
1481 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * src/gdcmDocument.[h|cxx]:
1483 - Clean up of the Transfer related predicates. They are now all based
1484 on new method isGivenTransferSyntax, that (should) handle properly
1485 the padding problem.
1486 - general clean up, simplification, and coding style.
1487 - Specific clean up of Parse7FE0() (umproperly named actually).
1488 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1490 2004-06-14 Jean-Pierre Roux
1492 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1493 - fix the display of SQItem ordinal number
1494 - add the GetSQItemByOrdinalNumber method
1495 - remove some useless never written private methods
1497 2004-06-14 Jean-Pierre Roux
1499 - adding a constructor taking a gdcmDocEntry as an input param
1500 - ReplaceOrCreateByNumber now returns :
1501 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1502 a gdcmValEntry * if a string value is passed as a param
1504 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1505 according to the param type (no longer sets a gdcmDocEntry)
1506 - GetValEntryByNumber, GetBinEntryByNumber added
1507 - NewValEntryByNumber and NewBinEntryByNumber added
1509 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1511 - GetSQItemNumber and SetSQItemNumber added, to provide
1512 a (relative) Item identier inside a given Sequence
1513 \warning : some pb remaining around this number
1515 - AddEntry now takes the Item Number as a param
1517 - adding a constructor taking a gdcmDocEntry as an input param
1519 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * Memory leak hunt with the following command:
1521 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1522 --show-reachable=yes gdcmTests PrintDocument
1523 It looks like many (all?) leaks are due to the STL (or a bad usage
1524 of the STL. The lines producing the leaks now have a comment with
1525 a "MEMORY LEAK" tag: you can retrieve them with
1526 grep "MEMORY LEAK" src/*
1527 Here are two typical examples which I can't help fixing:
1532 char * test = "babo";
1533 name = test; //// <--- valgrind detects 960 bytes lost in
1534 //// call to std::string::operator=(char const*)
1535 name.clear(); //// Doesn't help !
1543 std::cout << "Type a bunch of characters followed by RETURN: ";
1544 getline(std::cin, line); //// <--- valgrind dectects a loss
1545 //// of 1320 bytes in call to
1546 /// std::basic_istream<>& std::getline<>
1552 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1553 * src/gdcmHeader.[cxx|h]:
1554 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1555 and related, moved away to gdcmDocument.
1556 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1557 the corresponding protected accessors of inherited class
1558 gdcmDocument, removed ! As a consequence gdcmFile had to be
1559 declared friend of class gdcmDocument (see below).
1560 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1561 - Clean up of undefined or unused methods.
1562 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1563 account the changes to gdcmHeader.h).
1564 * src/gdcmDocument.h:
1565 - gdcmFile is now a friend class (in order to take into account the
1566 changes to gdcmHeader.h).
1567 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1568 (see changes to gdcmHeader.h).
1569 - Accessors (reading on the form GetEntry*) are now public.
1570 - Clean up of undefined or unused methods.
1571 * src/gdcmDocument.cxx:
1572 - adaptation to changes to gdcmDocument.h
1573 - ::OpenFile now writes a verbose message when file cannot be opened.
1574 - some std::string properly set to VRKey
1575 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1576 references to gdcmDocument.
1577 * Test/TestFindTags.cxx: changed accordingly to above changes.
1578 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1579 cvs repository gdcmData.
1581 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1583 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1584 conflicts with gdcmValEntry::voidArea.
1585 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1586 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1587 Value representation between StringRepresentable and BinaryRepresentable.
1588 * src/gdcmDocument.cxx:
1589 - method ParseDES: proper indentation restored and usage of
1590 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1591 - method LoadDocEntry: the fingerprint left in the SetValue() of
1592 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1593 removed. Reverting to previous code segment with the proper
1594 dynamic_cast< gdcmValEntry* >.
1595 Note: this was (partially) breaking the python test suite
1596 (gdcmPython/testSuite.py) that made usage of the above
1597 fingerprint to check presence of "Pixel Data".
1598 * src/gdcmDocEntry.h: coding style.
1599 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1600 now taken into account.
1601 * gdcmPython/gdcm.i: adaptation to the new internal representation
1602 of gdcm (exit gdcmParser, hello gdcmDocument).
1603 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1605 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1606 anymore, but instead prints the loaded Python dictionary.
1607 * .... alas, the python testSuite is still broken.
1609 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1610 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1612 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1613 * src/gdcmUtil.h : export methods
1615 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1616 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1618 * Initial addition of automatic python testing
1619 * Initial addition of automatic image comparison
1621 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1623 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1625 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1627 * Test/ShowDicom.cxx : bug fix for msvc compilation
1628 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1630 2004-05-04 Jean-Pierre Roux
1631 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1632 new concepts (and new classes) :
1633 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1634 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1635 - Sequence Doc Entries (gdcmSeqEntries)
1636 a Sequence is composed of Items.
1637 Each item is a set of Doc Entries (this is recursive)
1638 The non uniqueness of the 'Dicom tag' is due to this recursivity
1639 (never taken into account)
1640 Our unability to add a new 'entry' in the header
1641 at the proper location (neither in the H-Table (map or multimap),
1642 nor in the Chained List is also due to this recursivity.
1643 Don't try, right now, to use/modify/compile these new sources :
1644 nothing is finished.
1645 We just commit all the stuff, 'as is', in order not to loose it.
1647 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1648 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1650 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1651 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1652 file prefix (SetFilePrefix)
1654 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * Add a new test: ShowDicom, for now this is just the c++ version of
1656 checkRead.sh, later it will be able to compare the image read against a
1658 * Replace the DEBUG on the stack with a global entry in cmake interface:
1659 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1661 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * Add an example subdir, with a real example on how to read + write a
1665 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1667 * Doc/CMakeLists.txt: the main page is now properly differentiated
1668 between the developper and user version.
1669 * Doc/doxygen.config.in: dropped search related obsolete flags
1670 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1672 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * DEVELOPPER: added some helpfull comments for compile/test/install
1676 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1677 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1678 src directory, now generated in the build dir.
1679 2. Tests as mentionned smarter
1681 4. Add a new method in gdcmDict that return the PubDict by name
1682 this is interesting for 3rd party lib like ITK,
1683 where we could set the institution name / patient name...
1685 * ENH: 1. Now the test suite is working for real
1686 2. All binaries are now output in the gdcm-bin directory
1687 (this was not true before)
1689 2004-04-28 Jean-Pierre Roux
1690 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1691 SeQuence indented printing of Dicom Header.
1692 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1693 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1694 Computation of SQDepthLevel is now part of gdcmHeader constructor
1695 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1696 tree-like structure of a Dicom Header.
1697 * FIX Test code cleaning
1699 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * ENH: Adding automatic testing
1701 1. Need a DartConfig.cmake to submit to public
1702 2. Add a test driver gdcmTest.cxx
1703 3. gdcmTestMain, an helper for the main test driver gdcmTest
1704 4. Files in Test don't have a main anymore, this becomes interesting
1705 when we add more and more tests, thus dsw don't have to load
1707 * ENH: Adding a GDCM_DATA_ROOT for testing
1708 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1709 one file instead of seven + some small cleanup
1711 2004-04-22 Jean-Pierre Roux
1712 * ENH Minor changes to the Print() methods.
1713 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1714 Header printing. Example given with :
1715 > PrintHeader fileName 2 new
1716 (SQ based tree-like structure still to be done for the Header ...)
1718 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1719 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1720 1. I have added some unsigned where needed
1721 2. Some function parameter not used -> (void)
1722 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1723 4. g++ don't like character '\' in comment
1724 5. #define jpeg_create_decompress jCreaDecompress
1725 this really need to be fixed
1726 6. virtualize destructor of gdcmObject ... leakage
1727 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1728 this also really need to be fixed
1729 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1730 remove compression file
1731 (as we only do decompression, right ?)
1732 * ENH: Change malloc/calloc/free with c++ equivalent
1734 2004-04-21 Jean-Pierre Roux
1735 * FIX gdcmHeaderHelper::GetXSpacing
1736 when a single value is found (bug ?), xpacing is now
1737 defaulted to yspacing
1739 2004-04-19 Jean-Pierre Roux
1740 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1741 * ENH add parameters :
1742 bool exception_on_error = false,
1743 bool enable_sequences = false,
1744 bool ignore_shadow = false
1745 to the gdcmFile constructors to be full gdcmParser compliant
1746 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1747 to allow reading of PAPYRUS 3.0 files
1749 2004-04-06 Jean-Pierre Roux
1750 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1752 2004-04-02 Jean-Pierre Roux
1753 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1754 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1755 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1757 2004-03-30 Jean-Pierre Roux
1758 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1759 for ACR file, written out as DICOM files (hope so...)
1761 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1763 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1764 moved to base class gdcmParser and only the specialisation is kept
1766 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1767 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1768 already does the job.
1769 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1770 (to be consistent with gdcmParser::WriteEntries).
1772 2004-03-30 Benoit Regrain
1773 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1774 upate of the object's instance. It's passed to 2 in the unfavorable
1775 case : one in the ExecuteInformation, one in the ExecuteData
1777 2004-03-29 Jean-Pierre Roux
1778 * ENH : Check on file type to be written moved
1779 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1780 * FIX : gdcmObject::ResetBoundaries now stops properly
1781 when end-of-list is reached
1782 : gdcmVersion modified (as Benoit Regrain asked)
1784 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1786 * src/gdcmUtil.cxx: added forgotten iostream include.
1787 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1788 equivalent to ExplicitVR in existing code).
1790 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1792 now contains all the gdcmGlobal related code.
1793 * minor coding style and doxygenation changes.
1795 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1797 now contains all the Debug related code.
1798 * minor clean-up of includes in src/*.cxx
1799 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1800 CreateCleanString) removed.
1801 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1802 * Doc/DoxyMainPageUser.txt added.
1803 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1804 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1805 src/gdcmDirList.cxx)
1807 2004-03-24 Jean-Pierre Roux
1808 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1810 2004-03-23 Jean-Pierre Roux
1811 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1812 big endian made volumes
1813 * ENH Now gdcmParser constructor and destructor are protected to forbid
1814 end user to instanciate class gdcmParser
1815 (only gdcmHeader and gdcmDicomDir are meaningfull)
1817 2004-03-22 Benoit Regrain
1818 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1819 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1820 gdcmSerie to gdcmDicomDirSerie
1822 2004-03-19 Jean-Pierre Roux
1823 * ENH Now the tree-like structure describing a DICOMDIR comming from
1824 an already existing DICOMDIR file is consistent with
1825 the home-made tree-like structure build ex-nihilo
1826 or build from the files held (recursively) in a Directory
1827 functions gdcmDicomDir::CheckBoundaries()
1828 gdcmObject::SetBoundaries() added
1830 2004-03-17 Jean-Pierre Roux
1831 * REM (Eric Boix bug) : removal of meaningless
1832 gdcmDicomDirImage::NewImage function.
1833 * FIX now file names and directory name are written properly in the
1835 * FIX now gdcmDicomDir constructor may be call without any trick
1838 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1840 of gdcmDicomDirImage::NewImage as empty function.
1842 2004-02-28 Jean-Pierre Roux
1843 * ENH add gdcmDicomDir:NewPatient
1844 add gdcmDicomDirPatient:NewStudy
1845 add gdcmDicomDirStudy:NewSerie
1846 add gdcmDicomDirSerie:NewImage
1847 to allow making gdcDicomDir object.
1848 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1849 (as opposite to the gdcmHeader chained list)
1851 2004-02-11 Benoit Regrain
1852 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1853 when using from python
1855 2004-02-10 Benoit Regrain
1856 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1857 * FIX : in gdcmDicomDir when the directory is empty
1858 * ENH : add callback and methods to get the progression of dicomDir
1861 2004-02-06 Jean-Pierre Roux
1862 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1863 - GDCM_META added to gdcmDicomDirType
1864 - class gdcmMeta created
1865 * ENH : - A brief summary is now displayed at the beginning of
1866 'testDicomDir' to help disaster magnitude estimation
1867 * REM : Now useless Test/explDICOMDIR.cxx
1869 2004-02-05 Benoit Regrain
1870 * ENH : add methods in gdcmObject to get the hash table or the list of
1872 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1873 * FIX : wrapping python for TagHeaderEntryHT
1875 2004-02-04 Benoit Regrain
1876 * FIX : even length for some strings when writting the dicom dir
1877 * FIX : sort the images in the dicom dir
1878 * FIX : Bug fix for python use of dicom dir
1879 * ADD : a python demo
1881 2004-02-04 Jean-Pierre Roux
1882 * FIX : Final solution (?) for icone embedded images
1883 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1884 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1885 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1886 gdcmData/gdcm-MR-SIEMENS-16.acr1
1887 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1888 to make full checking easier
1890 2004-02-04 Benoit Regrain
1891 * FIX : WriteEntries : coding style & logic in parameters
1892 * FIX : Set the elements to create the DicomDir in a dictionary file
1894 2004-02-03 Benoit Regrain
1895 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1896 * gdcmDicomDir : add the load of directory
1897 * Bug fix and print add-on
1899 2004-02-03 Jean-Pierre Roux
1900 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1901 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1902 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1903 * FIX gdcmParser.cxx : 'group length' elements are now considered
1904 as integers, even for shadow groups, when file is Implicit VR
1906 2004-02-02 Jean-Pierre Roux
1907 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1909 of the last synonym :-(
1910 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1912 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1913 * FIX taking into account the possible 7fe0,0010 multiplicity
1914 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1915 to allow removal of references to 7fe0,0010, to deal with
1916 ACR-NEMA images, when 0028,0200 is meaningfull
1918 2004-01-31 Jean-Pierre Roux
1919 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1920 no longer writes 'Un' on disk
1921 * FIX SQ elements with actual length are now dealt with corectly
1922 * FIX gdcmFile::WriteBase make the difference, for color images, between
1923 the length (for Palette expanded images)
1924 and Raw Length (non expanded image + Palette)
1925 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1926 (that broke Write). Replaced by UL.
1927 Aware user will reload the field if he
1928 thinks it's necesssary
1930 2004-01-30 Jean-Pierre Roux
1931 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1932 when 'dirty Acr' is found, to be compliant with the new
1933 IsReadable() methods.
1935 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1936 (no DOUBLE images in kosher DICOM,
1937 but so usefull for people that miss them ;-)
1939 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1940 DICOMDIR related utilities (not checked as Windoze compliant)
1942 2004-01-28 Jean-Pierre Roux
1943 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1945 2004-01-27 Jean-Pierre Roux
1946 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1947 to allow skipping the shadow elements, to save memory space.
1948 The TRUE value for this param has to be used
1949 with a FALSE value for the 'enable_sequence' param.
1950 ('public elements' may be embedded in 'shadow Sequences')
1951 * gdcmHeader methods now deal with 'embedded icones images' in the header
1952 (even when an 'icone image sequence' is announced by the
1953 element (0x0088,0x0200), but there is NO icone at all ...
1955 * gdcmHeader sometimes Image Location value doesn't follow
1956 the supposed processor endianity (see gdcmData/cr172241.dcm).
1959 * gdcmHeader add the method
1960 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1961 to get *all* the Header Entries with the same tag.
1962 GetHeaderEntrySameName is probabely *useless*
1963 (no meaning : Name is *not* an identifier within the Dictionary)
1965 2004-01-26 Benoit Regrain
1966 * Bug fix in the print of hexadecimal representations. Remove long fields
1967 in the print and add a third level of print to print them
1969 2004-01-23 Benoit Regrain
1970 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1971 * Bug fix on test suite after remove the strip made on not string fields
1972 * Split the IsReadable method between gdcmParser which test that the file
1973 is dicom and gdcmHeader which test that it's an image file
1975 2004-01-22 Benoit Regrain
1976 * DicomDir : clean code, add methods, set variables in protected or private
1977 * gdcmUtil : bug fix for the clean string method
1979 2004-01-19 Benoit Regrain
1980 * Add the use of shadow dictionaries
1981 * bug fix and coding style
1983 2004-01-19 Benoit Regrain
1984 * src/gdcmFile.cxx : bug fix concerning the close of file
1985 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1986 * Add the update of header entries using the shadow library
1988 2004-01-19 Benoit Regrain
1989 * removal of file gdcmHeader2.cxx
1990 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1991 inheriting from gdcmParser. This split is to prepare the integration
1992 of dicom dir parsing
1993 * bug fix under python
1995 2004-01-16 Jean-Pierre Roux
1996 * REM removal of class gdcmHeaderEntrySet
1997 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1998 * ADD add file gdcmHeader2.cxx
1999 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2001 2004-01-15 Benoit Regrain
2002 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2003 entries created while parsing the header. Thus, they will be destroyed
2004 when the gdcmDictSet will be destroyed
2005 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2008 2004-01-15 Benoit Regrain
2009 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2010 made a fatal error because of the memory release at the end of program.
2011 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2012 some memory and vtk seems to have some problems with that.
2013 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2015 2004-01-14 Benoit Regrain
2016 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2017 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2018 * src/*.[h|cxx] : make changes due to class name changes
2019 * gdcmPython/demo/*.py : bug fix due to method names
2021 2004-01-13 Benoit Regrain
2022 * src/*.[h|cxx] : coding style
2023 * vtk/*.[h|cxx] : coding style
2025 2004-01-13 Benoit Regrain
2026 * gdcmPython/testSuite.py : test the readable flag of file for tests
2027 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2028 It's lied to the stl compilation by MSVC (windows, always windows...)
2029 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2031 2004-01-12 Benoit Regrain
2032 * src/*.h : add comments
2033 * src/gdcmDictSet.h : set the method BuildDictPath in public
2034 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2035 directly setted in the source code
2036 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2039 2004-01-09 Benoit Regrain
2040 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2041 * setup.py : use a reference to gdcmVERSION
2043 2004-01-07 Benoit Regrain
2044 * Modification to compile with the distutils.
2047 2003-12-10 Benoit Regrain
2048 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2049 can use a gdcmHeaderHelper to load data
2050 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2051 made in the source code
2053 2003-12-10 Benoit Regrain
2054 * Update Windows projects and .cvsignore files
2056 2003-11-12 Jean-Pierre Roux
2057 * ENH gdcmHeader constructor has one more parameter (default value : false)
2058 that allows the user to 'go inside' the SeQuences only
2060 gdcmElValSet:Print takes it into account
2062 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2063 * ENH: Update gdcmPython/CMakeLists
2064 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2065 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2067 2003-11-10 Jean-Pierre Roux
2068 * FIX : gdcmHeader::LoadElements is now based
2069 on the ListTag listElem member,
2070 not longer on the TagElValueHT tagHt member
2071 * ENH : PrintPubElVal shows (temporarily) both results,
2072 with the tagHt member and the listElem member.
2073 (it's easier to 'see' the problems when using Printheader)
2075 * FIX : old private member LgrElem is now splitted into
2076 ReadLength : Length actually found on disk (updated only
2077 if bug fixing is necessary), for internal
2079 UsableLength : Updated by FixFoundLength, to fix a bug
2080 or to allow Parser going on.
2081 Will allow to re-write a kosher header when a SeQuence
2082 with a length (not 0000) is found
2083 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2084 because gdcmElValSet::Add does not update ListElem
2087 2003-11-07 Jean-Pierre Roux
2088 * FIX misstyping in Transfert Syntax name table
2089 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2090 when they have an actual length (not 0000 nor FFFFF)
2091 (Nobody should care of it, but DICOMDIR explorers)
2093 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2094 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2096 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2097 * ENH: vtkGdcmReader now supports LUT !
2098 (vtkgdcmViewer for now is not able to use them though)
2100 2003-11-05 Jean-Pierre Roux
2101 * in testSuite.py : new files names for checking the package
2102 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2103 that returns the pixel area size to the *aware* (vtk) user
2104 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2106 2003-11-05 Benoit Regrain
2107 * in testSuite.py : Modify the rules for checking the paths
2108 : Explicit error messages
2109 * in __init__.py : Related modif
2111 2003-11-03 Jean-Pierre Roux
2112 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2113 to be used by aware (vtk) users that want to manage
2114 LUT (and no to turn the PALETTE image into an RGB pixels one)
2115 * GetPixelType now returns 8U for 24 Bits images
2116 (vtkGdcmReader compliant)
2118 2003-10-31 Jean-Pierre Roux
2119 * Removal of *all* gdcmData images and add them again
2120 in order to loose the 'history' of un-anonymised images
2122 2003-10-31 Jean-Pierre Roux
2123 * RMV : removal of useless jBitsInJsample.h
2124 for both 8 and 12 Bits JPEG Lossy Libraries
2126 2003-10-31 Jean-Pierre Roux
2127 * ENH : Add the functions gdcmFile::GetImageDataRaw
2128 gdcmFile::GetImageDataIntoVectorRaw
2129 that act as GetImageData and GetImageDataIntoVector
2130 except the making of an RGB Plane from Gray Plane + LUT
2131 Intended to aware (vtk) users who know how to manage
2134 GetLUTRGBA return a R,G,B,A LUT if any
2135 lgrTotaleRaw gives the 'Raw' length
2136 GetImageDataRaw returns the gray Plane
2137 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2138 (They stay Grey, just like with other Dicom viewers :-(
2140 2003-10-30 Jean-Pierre Roux
2141 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2143 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2145 being coherents dicom files.
2147 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2148 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2150 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2151 * ENH: Two steps is necessary to please VC++ compiler...
2152 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2153 * ENH: Add include dir to medcon lib
2154 * FIX: only one function is being exported for now !
2155 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2157 2003-10-29 Jean-Pierre Roux
2158 * adding gdcmHeader::GetLUTRGBA
2159 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2160 --> Mathieu, the modif u're waiting for is not yet committed
2161 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2163 2003-10-27 Jean-Pierre Roux
2164 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2165 00191113.dcm DermaColorLossLess.dcm
2166 MxTwinLossLess.dcm RadBWLossLess.dcm
2167 * ENH: For version prior to vtkImageViewer2 -r 1.19
2168 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2170 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2171 * Removal of ido stuff in CMakeLists.txt
2173 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2174 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2175 * FIX: remove a call to ->Modified ... see comments
2176 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2178 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * FIX: Problem with path for libvtkgdcmPython
2180 * ENH: Try adding a search script for python site-package
2181 * RMV: Remove some file from medcon lib that are not necessary
2182 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2183 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2184 * FIX: More pragma disable fro VC++,
2185 I don't think I break something as it is also disable in VTK/ITK.
2186 But it fasten debug compilation time.
2188 2003-10-23 Jean-Pierre Roux
2189 * gdcm now deals with 16 Bits Run Length Encoded images
2190 (they are compressed as 2 planes images,
2191 one for the high Bytes, the other for low Bytes)
2193 2003-10-22 Jean-Pierre Roux
2194 * Now CheckRead takes into account :
2195 - the bugged 'Leonardo' Siemens images
2196 - the XA images, sent thru the burning VPRO station
2197 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2200 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * FIX: When copying a Makefile.am to CMakeLists.txt
2202 one should remove the '\'
2204 2003-10-22 Jean-Pierre Roux
2205 * in gdcmData adding a bugged 'Leonardo' Siemens image
2206 (wrong lengths in header)
2207 OK with gdcm, KO with the other viewers :-)
2208 * add a GE dlx XA image, thru the VEPRO burning station
2211 2003-10-21 Jean-Pierre Roux
2212 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2213 for a brutal checking of vtkgdcmViewer compliance
2215 2003-10-21 Jean-Pierre Roux
2216 * add the files for 'xmedcon' Jpeg Lossless library
2217 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2219 2003-10-21 Jean-Pierre Roux
2220 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2222 2003-10-21 Jean-Pierre Roux
2223 * garbage Siemens 'Leonardo' images dealt with
2224 (the patch is easy to remove)
2225 * cosmetic changes to avoid warnings
2227 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2228 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2229 no need to press 'r' now.
2231 2003-10-20 Jean-Pierre Roux
2232 * upgrade of checkRead.sh checkWrite.sh according
2233 to new Jpeg Lossless decompressor
2234 * add US.3405.1.dcm, a genuine RGB medical file ...
2235 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2236 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2238 2003-10-15 Jean-Pierre Roux
2239 * general anonymisation in gdcmData
2240 * adding the 'color files' from
2241 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2242 * adding some well knowed bugged-header images
2243 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2244 waiting for their inclusion in Python testsuite
2246 2003-10-15 Jean-Pierre Roux
2247 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2248 no longer seg faults when file is not found
2250 2003-10-14 Jean-Pierre Roux
2251 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2254 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2255 * TODO: *.in file to genereate a UseGDCM later
2257 2003-10-14 Jean-Pierre Roux
2258 * Some supposed-to-be Dicom Images have no preamble.
2259 OpenFile takes it into account
2260 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2261 * Missing elements added in dicomV3.dic
2262 (just to be affraid : have a look at
2263 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2264 and do it again next year ;->
2266 2003-10-13 Jean-Pierre Roux
2267 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2268 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2269 But there are NOT. It's fixed !
2271 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2272 * FIX: "jpeglib.h" was not found on VC++
2273 * FIX: vtkgdcm was not being installed
2275 2003-10-10 Jean-Pierre Roux
2276 * ENH : OpenFile closes the file if it *really* doesn't look like
2277 an ACR-NEMA / DICOM one.
2278 * FIX : testWrite no longer writes an empty file if the source file
2279 is not gdcm Readable
2280 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2283 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * FIX: CMake generate now documentation
2285 * ENH: out of source doc build !
2286 * ENH: Generate both user and dev documentation
2287 * ENH: Should work on windows too
2288 * ENH: Only one doxygen config.in file is needed
2289 * FIX: make install should be ok now on ùnix plateform
2290 * FIX: PATH to dictionary was wrong (missing /)
2291 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2293 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * vtkGdcmReader is now able to read rgb dicom file.
2295 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2296 * added a gdcmViewer to vtk test, use mouse to control
2297 window level & window width
2299 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * CMake-ification of gdcm, we have now two build system
2301 * FIX: on cygwin Wsock32 doesn't exist
2302 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2304 2003-10-06 Emanuel Ollart
2305 * FIX : compilation process wad broken.
2306 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2308 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2309 * change gdcmViewer -> vtkgdcmViewer
2310 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2312 2003-10-06 Jean-Pierre Roux
2313 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2314 ( e.g : well known GE images with a wrong elem length,
2315 : Philips MRI Images with a wrong Huffman table)
2316 * still to be done : allow the reading of bugged LEONARDO Siemens images
2318 2003-10-03 Jean-Pierre Roux
2319 * Odd length strings are padded with '\0' (not with spaces,
2320 to remain compliant with already defined strings,
2321 like Transfert Syntax UID and others)
2323 2003-10-03 Jean-Pierre Roux
2324 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2325 to allow displaying RGB images (not only by affim ;-)
2327 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * vtkGdcmReader is now able to read rgb dicom file.
2329 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2331 2003-10-03 Jean-Pierre Roux
2332 * A few nasty patches to allow the reading of a lot of nasty images
2333 ( e.g : well known GE images with a wrong elem length,
2334 : Philips MRI Images with a wrong Huffman table)
2335 * still to be done : allow the reading of bugged LEONARDO Siemens images
2337 2003-10-03 Jean-Pierre Roux
2338 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2340 2003-10-03 Jean-Pierre Roux
2341 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2342 to allow displaying RGB images (not only by affim ;-)
2344 2003-10-03 Jean-Pierre Roux
2345 * gdcmFile::GetImageDataIntoVector now
2346 - deals with MultiFrames MultiFragments Run Length Encoded files
2347 - deals with YcBcR (YBR_FULL) files
2348 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2349 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2351 (no sample found :-(
2353 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2355 Two reasons: - clear things
2356 - third parties acces gdcm through header files, so won't
2357 suffer anymore VC++ complains
2359 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2360 * add argv[1] in testvtkGdcmReader.cxx
2363 2003-09-24 Jean-Pierre Roux
2364 * The lines are now eigthy characters long.for
2365 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2367 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2368 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2369 char* to std::string. Thus, the use of strdup becomes useless. (see
2370 previous commis of Malaterre)
2371 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2372 before the last Malaterre's commit.
2374 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * This commit should fix the Debug building under VC++, the problem
2376 was mainly a mixture of debug and release lib being loaded at startup.
2377 * I also remove a depency to a specific C function: strdup. Because I had
2378 to force the link to msvcrtd (whereas strdup is in libc).
2380 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2381 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2382 located in the gdcmCommon.h file. All use of reference of tha has been
2383 changed to now use the variable GDCM_UNFOUND.
2385 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2387 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2388 Dicom dictionary. The test suite can now be run again. Note:
2389 I'm note very happy with the " (RET)" changes. I believe this
2390 RETAINED comment should be dropped when parsing the dictionary.
2391 - PACKAGER corrected
2393 - AUTHORS updated and now in alphabetical order
2394 * Makefile.am now exports gdcm.dsw for Windoze users.
2396 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * cygwin complains about missing std:: in subdir Test/
2399 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * remove some methods that are now in gdcmHeaderHelper
2402 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2403 * vtkGdcmReader set spacing and origin correctly
2405 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2406 * Fix a few delete/delete[] mismatch
2408 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2409 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2410 interpretation to data given by gdcmHeader. For instance there are
2411 heuristics to get informations (look at different places).
2412 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2413 sorting DICOM images based on different strategies.
2414 * modified Makefiles accordingly.
2416 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2417 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2418 when building in debug mode
2419 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2420 src/win32/gdcmdll.dsp
2421 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2423 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2427 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * src/win32/libgdcmjpeg12.dsp was not dos format
2429 * src/win32/libgdcmjpeg12.dsp :
2430 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2431 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2433 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2434 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2436 * src/gdcmFile.cxx : bug fix in affectation type
2437 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2438 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2439 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2440 symbols... future problem ?
2442 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * src/win32/libgdcmijpeg12.dsp was missing
2444 * modified gdcm.dsw accordingly
2446 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2447 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2449 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2450 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2451 commit of JPR (before his hollidays to facilitate our work).
2452 * setup.py : bug fix in code. Modifications made while the last commit
2453 of JPR. The code hasn't been tested before the commit... it's so
2454 useless to make that (for best programmer that is JPR) !!!
2456 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * tagged the current version as Version0_3 (i.e. version 0.3)
2459 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2461 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2462 * *.dsp : modifications to use new libgdcmijpeg8 library
2463 * setup.py : bug fix on VTKPATH variable
2464 * PACKAGER : adding all concerning windows
2466 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2469 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2470 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2471 test suite reported error.
2472 * PACKAGER file added (describes what a packager must do when
2473 packaging a new release).
2474 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2475 * configure.in: upgraded version number to 0.3.0
2476 * fixing build of rpm (through rpm -ta):
2477 - Doc/Makefile.am exports proper doxygen files
2478 - src/jpeg/libijg8/Makefile.am exports the include files.
2480 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2481 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2482 * src/gdcmHeader.h : formatting code
2484 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2485 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2486 We were obtaining error message from vtk. Now, creation of file list
2487 is made in an internal list to prevent this problem.
2488 Bug fix when output is empty.
2489 Bug fix in update of progress value. Previous commit for this was a bad
2491 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2493 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2494 * src/gdcmHeader.h : added method to get the file name
2495 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2496 files. Added method to remove all files on the input
2497 Added FIXME comment concerning the bad parsing of header made by
2498 ExecuteInformation method (in ExecuteData method)
2500 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2502 when using make instal.
2503 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2504 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2506 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2507 * setup.py : adding include dir of jpeg lib to compile all sources
2508 * */Win32/*.dsp : JPR fix for windows compilation
2510 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2511 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2513 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2514 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2516 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * setup.py is again effective on un*x (takes into account the
2518 addon of the jpeg library)
2519 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2520 * Doc/Doxy* updated (includes above enhancements)
2521 * INSTALL now points to web documentation
2523 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * src/gdcmHeader.h doesn't make unnecessary reference to
2526 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2528 * src/gdcm*.[cxx|h] :
2529 - to allow compilation with gcc 3.x
2530 -- clean up of STL usage (added explicit usage of std::)
2531 -- small fixes on exceptions.
2532 Note: linking not tested !
2533 - clean of doxygen comments to avoid warnings at documentation
2535 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2536 dependent convertion).
2538 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * Clean up of previous JPR garbage commit (not even commented in the
2541 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2542 - moved all jpeg related files from src to src/jpeg/libijg8, with
2543 addition/modification of Makefile.am and configure.in.
2544 - the testSuite is still brain damage (not guilty).
2546 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * WrapVTK.py : modifications to get correctly vtk source files to
2549 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2550 (FileName -> Filename)
2552 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * vtk/vtkGdcmReader.[cxx/h]:
2554 - UpdateProgress method should now be effective
2555 - removed the limitation on having only images loaded (as opposed
2557 - when building a stack of images/volume, a lesser number of
2558 gdcmHeader and gdcmFile instances should be used (hopefully
2559 accelerating things).
2560 - when building a stack of images/volumes, files which are not
2561 loadable (wrong path-filename, wrong permissions on existing file,
2562 or file not parsable by gdcm) are replaced with a black image
2563 in the stack (for the caller to notice the problem).
2565 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2568 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2569 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2570 between standard library (std) and vtk library (problems are found
2571 under Windows... thanks Windows !)
2573 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2576 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2578 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2581 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2582 * When compiling with distutils (see setup.py) the C++ compiler is
2583 called with different flags than the default ones (with automake).
2584 In order to fix all those warning, I compiled gdcm with the command
2585 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2586 and went for warning fixes:
2587 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2588 up from unused variables.
2589 - vtk/vtkGdcmReader.cxx: potential bug fix.
2590 * src/gdcmHeader.h: Doxygen warning cleanup
2592 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * gdcmPython/gdcm.i:
2594 - typemaps correction to take into account the systematic replacement
2595 of "using namespace std" with std:: prefix e.g. std::list,
2596 std::string... (cf changes of 2003-05-21).
2597 - gdcmGlob global variable of type gdcmGlobal (defined in
2598 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2599 exported to Python a as cvar.
2600 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2601 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2602 gdcmDictSet.GetPubDictTagNames() and
2603 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2604 C++ static methods).
2605 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2606 with the above changes.
2608 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2609 * setup.py, manifest.in : bug fix under linux
2611 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2612 * Modification of setup.py to compile vtk part too. Then, we have 2
2613 wrappers which must work with same distutils. For that, we have a
2614 generic distutils in distusiltsWrapping.py ; with :
2615 - build_extWrap class to wrap generically all extensions,
2616 - ExtensionWrap base class for all wrapping extension that contains
2618 - Wrapper interface which wrap sources
2619 + In WrapSwig.py we have extension and wrapper for Swig
2620 + In WrapVTK.py we have extension and wrapper for VTK
2621 * MANIFEST.in : modifications to consider vtk directory and new python
2622 files for compilation
2624 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2625 * Added python wrappers of vtkGdcmReader vtk class (see the
2626 source in vtk/vtkGdcmReader.cxx) :
2627 - vtk/Makefile.am now builds a library
2628 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2629 python library (as opposed to _gdcm.so wich are the python
2630 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2631 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2633 - configure.in has an additional flag --enable-vtk that needs
2634 to be set to enable compilation of vtk related code, that is:
2635 + vtk/vtkGdcmReader.so and
2636 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2637 + gdcmPython/vtkgdcmPython.so (see above)
2638 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2639 be read when compressed or when HighBit + 1 != BitsStored),
2640 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2641 the usage of the python wrapper of vtkGdcmReader vtk class.
2642 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2643 * src/*.[h] all occurences of stl classes are now prefixed with
2644 std::, and all occurences of "using namespace std;" where removed.
2645 This is to avoid pollution of global namespace in included files.
2646 Apparently vtk does not avoid this pitfall: when using both
2647 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2648 collision of various stl members (principally cout...).
2649 * gdcmPython/testSuite.py now cleanly removes temprory generated
2651 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2652 comply with above changes)
2654 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2655 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2656 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2657 vtk data structure (an image Flip was required).
2658 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2659 * cosmetic changes in documentation.
2661 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2662 * src/gdcmHeader.cxx: the constructor no longer exits when an
2663 unexisting file is given as argument.
2664 * The subdirectory Data (containing all the images used for the
2665 test suite) is not part of this repository anymore. A new module
2666 containing those images is now available at
2667 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2668 with the name gdcmData.
2669 All the python scripts (including the package initialisation file
2670 gdcmPython/__init__.py) were adapated to take this change into
2671 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2673 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2674 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2675 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2676 demo of the usage of this class.
2677 Compilation of this vtk part is only done when using the --enable-vtk
2678 at configure (or autogen.sh) stage.
2680 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2681 * More memory link related corrections and documentation fixes.
2683 - maximum info is obtained with a command of the form:
2684 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2685 --show-reachable=yes PrintHeader
2686 - the remaining reachable blocks seem to come from the STL
2687 allocation scheme through the usage of map and list. It looks
2688 like this memory cannot be freed but it is not a memory leak
2689 (in fact further invocation to the STL would recollect the
2690 unused memory allthough it cannot explicitely be freed).
2691 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2692 of displaying an image parsed with gdcm and displayed with VTK.
2693 Note: some images don't seem to work e.g.
2694 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2695 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2696 Allthough this weakens the semantics, it is a ditch attempt to
2697 make gdcm more thread friendly.
2699 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2700 * Memory link hunt (by using valgrind through the command
2701 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2702 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2703 gdcmHeader::_dicom_vr.
2704 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2705 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2707 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2709 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2710 * src/Makefile.am now exports all the necessary include files at
2714 * UpdateGroupLength replaced by new one
2717 * UpdateGroupLength re-written using H-Table
2718 (named UpdateGroupLengthNew untill checks are over)
2720 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2721 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2722 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2724 - gdcmHeader::GetPubElValSet removed.
2725 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2726 UpdateGroupLength, WriteElements, Write.
2727 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2728 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2729 carried the same semantics.
2730 - src/gdcmHeaderIdo.cxx changed accordingly.
2731 - gdcmFile::WriteBase now regroups all the codes from previous
2732 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2733 - enum FileType moved to gdcmCommon.h
2734 * src/gdcmHeader.cxx AddDefault trashed
2735 * gdcmGetXSize added
2736 * getimageDataSize now calls gdcmGetXSize
2737 * Test/*.cxx changed to agree with above changes
2739 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2741 (to avoid double call by end user).
2742 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2743 by end user, since gdcmHeader::gdcmHeader now handles it.
2745 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * gdcm/Doc many doxygen changes:
2747 - Doxyfile now has two different versions, DoxyfileUsers that generates
2748 the html.users end users oriented documentation and
2749 DoxyfileDeveloppers that generates the html.developper developper
2750 oriented documentation.
2751 - README changed accordingly
2752 - requirement.txt removed (old design info moved to TODO).
2753 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2754 DoxyMainPage.txt, DoxyPython.txt provide more information.
2755 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2756 be updated by simply regenerating the docs with doxygen and copying
2757 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2758 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2759 all the tests in the form "if (<map>.count() >1)" were removed.
2760 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2761 ill-formed documentation sections.
2762 * src/gdcmHeader.cxx: ditto
2764 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * setup.py fixed for un*x (needed macro for stdint.h)
2766 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2767 un*ces with sh-utils test utility.
2768 * gdcmPython/demo/test.py renamed to PrintHeader.py
2769 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2770 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2771 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2772 * src/gdcm*.cxx JPR's bad inclusion fixed.
2774 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2776 * gdcmPython/demo/test.py changed accordingly.
2778 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * gdcmPython/Makefile.am fixed linking against libstdc++
2780 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2781 * Swig subdir (historical tests of swig version 1.3.17++) removed
2782 * Test/testChangeEntete.cxx some lines commented out in order to make
2784 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2785 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2787 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2789 hence the user doesn't need this explicit call.
2790 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2791 i.e. LoadElements() call removed.
2792 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2793 - src/Makefile.am declares the proper flag for g++.
2794 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2795 for adding user defined new tags.
2796 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2797 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2798 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2800 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2801 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2802 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2803 src/Makefile.am : the project should properly compile and install
2804 with the autotools, included the python wrappers part.
2805 * gdcm.spec.in : added a spec file for RPM packaging.
2807 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2808 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2810 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2812 to exported to the environement (see gdcmPython/testSuite.py
2814 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2815 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2816 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2817 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2818 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2820 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * gdcmPython/__init__.py doesn't crash anymore when running in
2822 in InstallMode or PreInstallMode but with an environment given
2823 value of GDCM_DICT_PATH.
2824 * src/gdcmDictSet.[cxx/h] coding style.
2826 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2828 * src/gdcm.h general comments moved to TODO, and README
2829 * src/gdcm.h should now be seen as a user commodity (including it
2830 should suffice to fully use gdcm). It is nowhere including within
2831 any of the kernel files src/*.cxx and src/*.h.
2833 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2835 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2837 * src/gdcm*.cxx only include their corresponding include file
2838 (as opposed to gdcm.h)
2839 * gdcmPython/gdcm.i changed accordingly
2840 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2841 the autogen.sh generated "make snapshot" command to work.
2842 * autogen.sh removed history related references to crea package.
2844 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * distutilsSwigCPlusPlus.py work around some swig portability
2848 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2850 was done in a last ditch attempt to get setup.py _really_
2851 operationnal. The python/gdcmPython layaout add the advantage
2852 of hidding away the python related distutils specific files
2853 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2854 Alas, the src directory was out of scope (i.e. it's relative
2855 position to setup.py was ../src) which made things impossible to
2856 handle (see previous version of python/setup.py). Crossing fingers...
2858 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * python/setup.py now works on Un*x. (harder than I thougth)
2860 * python/distutilsSwigCPlusPlus.py can now have include files
2861 among the list of sources.
2863 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2864 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2865 * modifications in MSVC projects
2867 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * As stated by the first lines of Test/ExceptionAndPython/README, it
2869 looks like we can move back to original usage of exception within
2870 src/gdcm* and hence remove the errno stuff that was introduced
2871 as a quick and dirty fixture of this problem (added to the TODO).
2872 * Doc/Doxyfile configuration file for Doxygen and corresponding
2873 README file for usage added.
2874 * Test/testWrite.cxx added. This new test comes from a split of
2875 test.cxx that is now reverted to its original purpous i.e.
2876 testing the proper parsing of a Dicom related file.
2877 testWrite.cxx concentrates on testing the IO part of gdcm.
2878 * Test/bug1.cxx (containing a bug on WIn32) added.
2879 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2880 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2881 whose purpose is to publish the content of the TagNames of the
2882 Dicom public dictionary were not accessible without an
2883 instance of class gdcmHeader.
2884 - those methods are now static methods of gdcmDictSet and hence
2885 require no instances at all to be invocated.
2886 - within gdcmDictSet this change required to change some method
2887 to class methods (i.e. are now static) among which SetDictPath
2888 (renamed to BuildDictPath) and LoadDefaultPubDict.
2889 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2890 the above changes by calling the new method classes of gdcmDictSet.
2891 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2892 the above to be effective.
2893 * python/gdcmPython: in order to wrap properly the above changes
2894 for Python, swig version now needs to be > 1.3.17.
2895 * python/gdcmPython/Makefile fixed to adapt itself to new
2896 configure/make shema introduced by Johan Montagnat (thanks for the
2897 contribution). Alas this Makefile cannot be turned into a proper
2898 Makefile.am without some heavy changes in the configure.in
2899 (for python dectection).
2900 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2901 now avoids publishing the empty entries.
2903 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2904 * python/setup.py : bug fix concerning install under windows
2905 ExtraPath reused :-P
2906 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2908 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2909 * Dicts/dicomV3.dic : remove double spaces !!!
2910 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2911 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2914 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2916 method. Doxygenation.
2917 * src/gdcm.h clean up of JPR spurious comments.
2919 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * python/distutilsSwigCPlusPlus.py now properly collects the
2921 shadow classes generated by "swig -c++" (gdcm.py in our case)
2922 when using "python setup.py install".
2923 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2924 reexports the working classes.
2925 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2926 by the classical C errno scheme. This is to prevent an obscure
2927 behavior of the python wrappers when importing wxPython.wx prior
2928 to gdcmPython (which ended up in an abort call). An illustration
2929 of this oddity can be found in the Test/ExceptionAndPython
2930 subdir (see the README file). This problem probably due to
2931 an combination of g++ and dynamic loading.
2932 * added Test/ExceptionAndPython (see above)
2934 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * Changed the layout of the python part to avoid bloating main
2936 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2937 i.e. the distutils arsenal. All the python related stuff is
2938 again in a python subdir, but the package itself is now in
2940 * setup.py was cleaned up:
2941 - pythonIncludePath removed
2942 - python setup.py bdist target is now functional.
2943 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2944 collision with other packages). gdcmPython/demo/*.py changed
2947 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * python subdir moved to gdcmPython (preparation of distutils packaging).
2949 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2950 distutils installer is operational.
2951 * - gdcmPython/__init__.py now properly loads the swig generated
2952 shadow classes (from gdcm.py).
2953 - gdcmPython/demo/*.py changed to import the package gdcmPython
2954 instead of gdcmPython/demo/load.py.
2955 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2957 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2959 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2960 entries within the associated public Dicom dictionary resp. the same
2961 information but sorted by the fourth field (PAT, IMG, DIR) of the
2963 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2964 are now in the "???" group.
2965 - python/gdcm.i changed accordingly,
2966 - python/demo/printGroupedPublicDict.py added, that gives an example
2967 of the above new functionalities in Python.
2969 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * src/gdcm.h, gdcmHeader.cxx:
2971 - historic references to glib's g_malloc and g_free (#defined)
2972 were definitively removed.
2973 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2974 * src/gdcmElValSet.cxx:
2975 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2976 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2977 - GetElValue(string) renamed to GetElValueByName.
2978 - Added GetElementByName(string).
2979 * src/gdcmHeader.cxx: added
2980 - GetPubElValRepByNumber(guint16, guint16)
2981 - GetPubElValRepByName(string)
2982 - GetShaElValRepByNumber(guint16, guint16)
2983 - GetShaElValRepByName(string)
2984 - GetShaElValByNumber(guint16, guint16)
2985 - GetShaElValRepByName(string)
2986 - GetElValRepByNumber(guint16, guint16)
2987 - GetElValRepByName(string)
2988 - GetElValByNumber(guint16, guint16)
2989 - GetElValRepByName(string)
2990 * Doc/requirements.txt added.
2992 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * Test/Makefile building now depends on the one of libgdcm.so
2994 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2995 pixel data) aware which enables finding the address (offset) of
2996 the pixel data of JPEG encoded DICOM files. This leaves only a single
2997 file in the testSuite whose pixel data address (offset) is unknown.
2998 * python/testSuite.py changed accordingly.
3000 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3001 * VC++ has some strong limitations when working with the STL, as stated
3002 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3003 "Also note that some STL containers (map, set, queue, list, deque)
3004 cannot be exported. [...]
3005 Some STL classes contain nested classes. These classes can not
3007 This is caused by a designed limitation that once a template
3008 class is instantiated, it can not be re-instantiated and
3010 Since our usage of map<> is ubiquitous in gdcm, this "designed
3011 limitation" of VC++ is a pitfall.
3012 Hence the Python wrappers of gdcm cannot be incrementally linked
3013 against the c++ dynamic library. The dirty but only workaround is
3014 to forget about incremental link of dynamic libraries and to generate
3015 the Python wrappers library with the inclusions of the underlying C++
3017 The following modifications concern this matter on Win32/VC++:
3018 - wrapping python correct with standalone wrapped dll (don't use separate
3019 dll under windows !!!!)
3020 - python21_d debug mode enabled (ask Frog how to use it :-)
3021 - NO problem with having an STL member of class for example string in C++
3022 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3023 - Python test of dcmlib in Python is ok under windows on a large set
3025 * removed glib references
3026 * typedef's inserted in gdcm.i for correct swig type management
3028 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * python/demo/*.py load.py extracted from test.py. Added explore.py
3030 that only displays required tags and testAll.py that parses all
3031 the files of the testsuite without using unittest.
3032 * python/testSuite.py other additional test on new files added.
3033 * Data/* new test files added accordingly to the testSuite.
3034 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3035 the vr in the file differs from the one of the dictionary.
3037 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3038 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3039 values, but limits itself to values which are below a user specified
3040 size (by default 1024 bytes).
3041 * python/gdcm.i : elements not loaded (because their size is above the
3042 user specified treshold) are exported with their TagKey as key of the
3043 python dictionary. This enables the testsuite to make some checks
3044 on the unloaded elements (since we have their offset and size).
3045 * python/testSuite.py
3046 - now tests for the existence and proper value of the pixel data
3047 - two new examples added.
3048 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3050 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3052 aware. See the strategy comments in gdcmHeader::FindeLength().
3053 * Test/test.cxx now accepts a filename as first argument.
3054 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3055 * python/testSuite.py changed to integrate test on above files.
3057 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3059 the vr was also RET.
3060 * python/testSuite.py more tests added.
3062 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * python/testSuite.py unittest test suite added (uses Data)
3064 * Data/* dcm and acr files for the test suite.
3065 * glib dependance removed from un*x version. We now use ISO C99
3066 7.18 Integer types (see stdint.h)
3067 - python/Makefile, src/Makefile src/gdcm.h
3068 * src/ when an explicit vr (like dicom files) suddenly poped an
3069 implicit element we use to mark the underlying DictEntry of the
3070 concerned ElValue with "Implicit". This strategy was damageable
3071 too the public or provite dictionaries, since some of their vr
3072 would be changed. Since Header::FindLength heavily relies on the
3073 detection by Header::FindVR of falsely explicit elements, I
3074 added an extra ImplicitVr member to ElValue (boolean).
3075 The rest of the changes we the necessary adaptations.
3077 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3080 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3082 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3083 * Adaptation for porting to VC++:
3085 o forced to use std namespace (for string to be known)
3086 o all class use __declspec export style on WIN32
3087 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3088 (in stdlib.h on Win32 but in std:: for gcc)
3089 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3090 variable GDCM_DICT_PATH.
3091 * src/gdcmHeader.cxx verbose comments made discrete.
3093 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3094 * python/gdcm.i: added a typemap that converts a C++ hashing table
3095 to native Python dictionary.
3096 * python/demo/test.py:
3097 - now uses the native dictionary for exploration of gdcmHeader.
3098 - takes an optional filename argument (the file to parse).
3099 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3100 PubElVals hashing table.
3101 * Dicts/dicomV3.dic removed error prone trailing spaces.
3103 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * Python wrapping process moved away from src/Makefile to
3105 newly created python/Makefile (as well as gdcm.i)
3106 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3107 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3108 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3109 from the environement variable GDCM_DICT_PATH (when existing).
3110 * src/gdcmDict::GetTag bug fix.
3112 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * Straightforward temporary fixes for swig to build the python wrappers.
3114 src/Makefile now has a python working entry [by working we mean
3115 that we can import de shadow classes without errors].
3117 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3118 * hashtest.cxx removed (since already in Test)
3119 * src/gdcmlib.h renamed to src/gdcm.h
3120 * src/dcm.i renamed to src/gdcm.i
3121 * src/Makefile prepared for python wrapping
3123 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3124 * src/gdcmHeader.cxx :
3125 - Parsing of header is now separated from loading of element values
3126 (see gdcmHeader::LoadElements).
3127 - general clean up of hopefully all file access (creation of
3128 ReadInt16 and ReadInt32)
3130 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * src/gdcmHeader.cxx :
3132 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3134 - SetLgrElem renamed to SetLength
3135 - GetLgrElem renamed to GetLength
3136 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3137 * src/gdcmElValSet.cxx fixed both GetElValue methods
3138 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3139 due to IdoDude was cleaned out.
3141 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3143 concentrates on finding the value representation (when it exists).
3144 RecupLgr now only finds the element value length, and it avoids
3145 returning the unecessary skL (skipped length).
3146 Also, offsetCourant was simply removed (with taille_fich) since
3147 it was redundant with the File position internals (by using
3148 ftell and fseek). This also made skL (see above in RecupLgr) usage
3150 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3151 on the libido specificities which are handled through class
3153 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3156 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3157 * Truckload of changes. Parsing of header is barely functional
3158 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3160 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcmHeader.cxx many addons of low level methods
3163 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3165 and _IdDcmSWAP_LONG.
3167 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * This corresponds to all the changes decided at the meeting of
3169 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob