1 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Grealty simplify the JPEg decompression, no need to differenciate based on
3 the JPEG possible type (with/without fragment, with/without multiple frame).
4 Everything is done throught the JPEG IO Suspension mechanism in IJG
6 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
8 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
9 with other method names
10 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
11 * Test/TestDicomDirElement.cxx : add new test
13 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
14 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
15 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
16 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
17 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
18 So can't you use __int64 in ostream at all.
20 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * bug fix for compilation on MSVC6
22 * gdcmPython/gdcm.i : rename of classes missed
24 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
26 type and not a string. So, there remove problems on the format of the
29 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
31 Thus, DicomDirXXX are created with a flad that indicates if the created
32 object is empty or not (when not empty, the DicomDirElement is used to
35 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
37 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
39 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
42 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
44 Remove all access to the hash-tables or lists in the objects.
46 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
48 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
49 be complient with all the gdcm source code
51 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
55 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
59 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Test/ : rename VTK tests to have a best name for the tests
61 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
62 GetFirstEntry/GetNextEntry use
64 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
66 test. Now it's on image content and not on the resulting visualisation...
67 might solve the problem on linux when using the OpenGL drivers
69 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
70 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
71 DicomDirSerie, DicomDirImage
72 Dict, DictSet classes :
73 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
74 -remove InitTraversal method.
75 * UPD Test programs + Example programs
77 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
78 remove useless and never updated keyword \ingroup
80 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
82 is no memory access violation
83 * gdcmPython/demo : add python demos using VTK
85 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 * FIX 'Dictionnary' is now spelt 'Dictionary'
87 'wether' is now spelt 'whether'
88 'archieve' is now spelt 'archive' ;-)
90 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
91 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
92 related methods, in order not to expose internal mechanisms
95 * REM methods that exposed internal mechanisms :
96 DicomDir::GetDicomDirPatients()
97 DicomDirPatient::GetDicomDirStudies()
98 DicomDirStudy::GetDicomDirSeries()
99 DicomDirSerie::GetDicomDirImages()
100 * UPD Test programs :
104 * UPD Example program
106 * ADD DictSet methods
110 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Removed the Print/indent/default parameter mess. There is absolutely no
112 reason to have to methods, moreover with the second taking the ostream as
113 *SECOND* parameter. This was clearly a bad hack to get things compile.
115 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
116 * Complete rewrite of the GetMacAddress code. Now the code is *much*
117 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
118 Unfortunately the main code does not work on SunOS, thus provide a specific
119 code for this platform only (and Win32 of course). Since this seems to be
120 working, change CreateUniqueUID to use GetMACAddress instead of the
121 problematic GctestetIPAddress
123 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
124 * Unfortunately to be able to test gdcmDirList I had to break the API
125 a little. Now the class is not a std::list anymore but has a member
126 std::vector (more ITK compatible). Allow unit testing on Win32 and
129 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
130 * Update SerieHeader to take into account a Serie Instance UID to properly
133 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
134 * ENH - Comment out Mathieu's (dangerous) Super Hack
135 for dealing with BIGENDIAN processors
136 - Move equivalent stuff to BinEntry::WriteContent
137 When necessary, 16 Bits Pixels are swapped in a small buffer
138 and then written. This avoid allocating a huge buffer, in
139 PixelWriteConvertor, and avoid modifying the Pixel Area.
141 Probabely, the same operation will have to be done when we want
142 to write image with Big Endian Transfert Syntax,
143 and we are working on Little Endian Processor
145 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
148 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
149 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
150 all the dict content.
151 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
153 * Test/TestDict.cxx : add a new test for the dict classes
155 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
157 file. Debug is yanked if compiled with NDEBUG
159 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDictSet.h : set the default output to the os variable
161 * src/gdcmDictEntry.[h|cxx] : add the Print method
162 * gdcmPython/demo/ : add a new test
164 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
165 * merging of Test/PrintDicomDir and Test/TestDicomDir
166 * removal of now redundant Test/PrintDicomDir
167 * enhancement of Example/PrintDicomDir
169 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * Now, python test might work on systems
171 * Add the PrintDicomDir test
173 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 * FIX : First entry following group 0002 was lost for
175 Explicit Big Endian Transfer Syntax files
176 (group and elem not swaped)
178 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
179 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
180 Big Endian Transfer Syntax supposed the group following 0002
181 begins always by element 0000 (element 0000 is *optional*)
182 To avoid further troubles, let's be pessimistic, and use
183 Document::HandleOutOfGroup0002() method
184 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
185 (related pb not yet solved)
187 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * Bug fix for the python part use
189 * Now, PrintHeader.py pass... but outside the ctest use. shit !
191 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
194 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
195 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
196 a string and should ask the global TS dict what are the propreties of
199 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
201 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
202 to swap the Swap Code, at parsing time, when we come out of group 0002
203 and Transfer Syntax is Big Endian
204 We should be able to read now 'true DICOM" Big Endian coded images
205 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
206 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
208 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Hopefully fix the bug on MacOSX and static global initialization.
210 This is the only -minor- patch I found that both please MacOSX and VS6.
211 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
212 but this would require a lot of change. Another approach would be that Global
213 create those string and GDCM_UNFOUND becomes a pointer to a string (which
214 gdcm::Global would destroy at exit).
216 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
217 * Fix bug on MacOSX with static initialization in a multy threaded
218 environment. static const string in a header file used to be ill
219 initialized provoquing the freeze of any tests. patch should solve this
222 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
223 * According to Benoit's suggestion, and without any objection from anybody
224 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
225 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
226 - method gdcmDicomDirObject::GetEntry() renamed as
227 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
229 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
230 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
231 you debug/warning message just as c++ streams which make them very convinient
232 to use. Once this is stabilize I will change the ostringstrem to be
233 redirected to a file (ofstream).
234 * Properly support C99 extension: __FUNCTION__ which allow us to display
235 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
237 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
238 * Removal of useless and dangerous methods :
239 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
240 GetDocEntryByName, GetEntryByName, GetDictEntryByName
241 * Removal of usless methods :
242 Dict::PrintByName, Dict::GetDictEntryByName
243 * Commenting out of probabely useless methods :
244 Dict::GetDictEntryNames()
245 Dict::GetDictEntryNamesByCategory()
246 DictSet::GetPubDictEntryNames()
247 DictSet::GetPubDictEntryNamesByCategory()
248 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
249 * ENH : Use dicomTS.dic as described in 2004 version
250 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
251 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
252 Add Accessors on VM (Value Multiplicity), and VM related methods
253 * ADD : Add a list of 'Dicom Attribute types', as found in
254 http://medical.nema.org/dicom/2004/04_15PU.PDF
256 * ADD : Add dicomGroupNameAbbreviations.dic
257 should be used to write a method to replace the former
258 Dict::GetDictEntryNamesByCategory()
260 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
262 to read in the file... and only it ! Length is the efective length of the
263 data in the DocEntry structure
265 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
267 And now use a static function call instead, with a global variable. i
268 This is much closer to the VTK approach. Hopefully should be bulletproof
269 and easier to use...hopefully
271 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
272 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
274 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
277 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
279 ValEntry, BinEntry, SeqEntry creation or replace
281 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
283 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
285 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
286 when specifying the VR
287 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
288 * src/gdcmDocEntry.cxx : amelioration of print
290 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
291 * ADD : Add the method Util::IsCurrentProcessorBigEndian
292 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
293 * ADD Method Document::ComputeGroupLength
294 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
295 in order to allow further VR modification by user
296 * REM : removal of once-called method File::WriteBase
297 integration of its code in formerly one-line method File::Write
299 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
301 replace the different values "??", "Unkn", "Unknown".
302 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
303 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
304 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
305 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
307 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
310 * Set the gdcm::Base class to some Printable classes
312 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * src/gdcmFile.[h|cxx] : add the Print method
314 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
315 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
316 * src/gdcmDocument.h : remove the PrintLevel informations
317 * Example/PrintFile.cxx : use the new gdcm::File::Print
319 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
321 problems when compiling with the python wrapping
323 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
325 writting in ImplicitVR
327 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
328 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
329 JPEG decompression, especially when dicom frames are split into several
330 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
331 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
333 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmHeader.cxx : change the initialisation of default header.
335 Now, this header is readable by gdm, e-film, DicomWorks
337 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
339 Rename Decompressed to Raw
340 * Use the API changes in gdcm::File.
341 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
344 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
346 each added entry in the header. Replace the 'Planes' field by the 'Number
349 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
351 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
353 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
355 At this time, this image isn't readable by e-film... waiting JPR help to
358 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
360 DocEntry. Now use methods of the Document !
362 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * Test/ShowDicomSeq.cxx : bug fix
365 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
367 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
368 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
369 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
371 * Test/TestCopyRescaleDicom.cxx : remove unused variable
372 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
373 containing found sequences
375 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
378 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
379 Some fields in BinEntry must be copied to not seg fault when making the :
380 gdcm::File *copy = new gdcm::File( copyH );
381 and tests are now made on good variables
383 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
385 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
387 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
388 * Add vtkGdcmWriter example and test
390 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * Test/TestUtil.cxx : reformat the source code
392 * vtk/vtkGdcmReader.cxx : remove and change prints
393 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
395 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
396 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
398 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
400 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
402 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
404 by an eof to prevent all bad read of the file... and in this case, the
407 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * Example/Volume2Dicom.cxx : comment unused variables
409 * Test/PrintDicomDir.cxx : comment unused variables
410 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
411 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
412 method that is redondant with AddEntry.
413 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
416 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * Bug fix due my last commit (compilation under Windows).
418 * Example/Volume2Dicom : bug fix in the file and reformatting source code
419 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
421 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
423 - Remove printf / sprintf
424 - include iostream AFTER gdcm so we don't get warnings
425 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
427 - Also remove tons of include from header files, hopefully this should
428 speeup the compilation time, since it was becoming a dog slow.
429 - Remove gdcm.h as it include way too many files and slow down compilation
430 (plus it is not up to date)
431 - remove 'using namespace std' this is BAD !
433 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * Remove memory leaks on the DicomDir
435 * Remove some useless data in DicomDirObject
436 * Add usefull methods in SQItem, to be complient withe the ElementSet
438 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
441 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
443 future, with convertion)
444 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
445 and ImageDataSize values. Remove the method to get the PixelReadConverter
446 from the output of the class
448 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
451 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
453 and vtkErrorMacro use.
454 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
456 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
459 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
460 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
461 The string leaves only in the fonction. So when we make a .c_str(), we
462 get the pointeur on the first element, element that will be destroyed
463 immediately after thee instruction.
464 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
465 file has been opened : the test must be made on the content of the
466 pointer and not directly on the pointer !
469 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
471 the python part recompiles
473 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
475 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
476 X session is killed (for my computer... it seems to not be identic on
479 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
481 avoid problems (otherwise, the difference test between the visible image
482 and the reference is incorrect. If the reference is greater than the
483 screen resolution, it's produce errors).
484 Can be used for only one image. Can be used with a visible flag.
485 * vtk/vtkGdcmReader.cxx : remove commented codes.
486 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
487 under windows at compilation
488 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
490 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
492 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
494 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
495 tests on the image size X, Y, Z
497 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
499 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
500 between the class name and the file name
502 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/ : fix compilation warnings for the Write method (2 different
504 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
505 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
506 variable... create a static method in gdcm::Document to access to
507 this variable content.
509 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
511 file, to be accessed by other files (like gdcmFile). Remove commented
512 code. Move the change of the header to the gdcmFile, using the
514 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
515 To be sure of that (and simplify calls), the Write of the header now
516 gets a file name and not a file pointer (std::ifstream).
517 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
518 DocEntryArchive. Remove all open of the written file
520 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
523 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
525 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
527 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
528 some corresponding methods. Write correctly the file and check before
530 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
531 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
532 is now on RGB data (as before my last commit
533 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
535 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
537 Add a print information of the type of the entry
538 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
539 It was in the gdcmFile, and all write have been regrouped
540 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
541 Write correctly all dicom files (in decompressed mode only at this time)
542 * Test/ : test on files are now made using Raw data and not color data if
544 * Example/PrintFile.cxx : add more printings
546 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * Amelioration of code, remove some code copy. For the loading of
548 BinEntry (in gdcmDocument), add the test to verify if the file is already
551 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
553 remove a DocEntry in the header (push an empty DocEntry)
554 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
555 lines. Bug fix in the initialization of the PixelConvert and the
557 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
558 use in TestCopyDicom (now this test can run under windows... but fails)
559 * Test/TestCopyDicom.cxx : amelioration of the test :
560 - test the pixels written
561 - add test points to quickly find where is the error
562 - can set a file name input and output in arguments
563 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
564 amelioration of the test output
566 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
568 all replaced DocEntry's
569 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
570 Now, each needed DocEntry to modify is duplicated, modified and inserted
571 to the header using DocEntryArchive. Thus, after save, we can restore the
572 header initial state.
574 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
577 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
579 correct to copy it. The DictEntry is specified at the DocEntry creation,
580 then, it musn't change in the time.
581 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
582 header correctly. At this time, the change is only made for the first
583 level of the Document. In the future, it might consider sequences.
584 The change is made by replacing a DocEntry by an other that is created
585 outside the class. The old value is kept. When we restore the header
586 status, the added DocEntry is deleted and replaced by the old value.
587 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
588 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
589 set the write type to explicit VR, implicit VR or ACR. Add methods to set
590 the write mode to native, decompressed or RGB (but not used at this time)
592 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
594 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
596 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
598 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
600 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
601 set because already copied when copying the BinEntry's of the header
602 * Test/TestAllReadCompareDicom.cxx : remove warnings
604 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
606 Two problems appear when doing it :
607 - with the gdcmFile : when the GetImageData method is called, the pixels
608 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
609 data (pixels). And each structure destruct the data when it's
610 destructed. So we have two destructions for the same data. To solve it,
611 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
612 data or not. If it doesn't own data, then they will not destroyed by
614 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
615 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
616 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
617 create a double destruction of the same DocEntry's. So, to solve it,
618 the TagHT is simply cleared and the DicomDir* elements are destroyed.
619 * TODO : add an entry concerning memory leaks in the DicomDir
621 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
623 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
626 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
628 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
629 after it have been deleted
631 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * FIX: src/* fix the doxygen warnings.
633 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
634 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
635 was erroneously defined with a size of 15 instead of 16. [many thanks
636 to Jean Michel Rouet for pointing out this bug].
638 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 1. Finish merging JMR patch for writting DICOM from scratch
640 2. Fix -hopefully- bug with MONOCHROME and space vs null character
641 3. Use const ref when possible
642 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
643 5. A few more comments
644 6. CreateUniqueUID can now be called without parameter"
646 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
647 * ENH: Slightly bigger patch:
648 1. Getting toward full integration of JMR patch for writting dicom from scratch
649 2. Update Test to test part of this patch: CreateUniqueUID
650 3. File was not close properly in gdcmDict
651 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
652 5. Use of const ref instead of copy (speed issue)
653 6. Remove temporary (duplicate) string in TranslateToKey
654 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
655 8. Do not repeat virtual in subclasses
656 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
658 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
659 * Apply first patch toward better string comparison when dealing with broken
660 DICOM files. Essentially the string could be padded with a space instead
661 of a null character as defined by standard
663 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
665 because never used... and in the same time, that's remove some memory leaks
667 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * src/gdcmFile.cxx : now delete the PixelConvert instance.
669 * In examples and tests : change the type of image data variables from void*
670 to uint8_t*. Remmove all delete on image data variables
672 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
674 Verify the file pointer value before open the file, and if it's not null,
675 a verbose message is generated.
676 Close correctly the file when the file isn't considered dicom-like. The
677 correctly close is a call to CloseFile.
678 When closing the file pointer, test if its not null to close the file.
679 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
680 file. For an uncompressed image, the copied data correspond in the least
681 case to the image size (calculated) or the image size specified in the
682 header. A verbose is generated if these two size mismatch
684 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
686 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
687 break under windows (with msvc6 compilation).
689 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
691 compiling with MSVC6)
693 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * Bugs fix for the Windows build with VC6
695 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
696 needed (only for projects required VTK). If the VTK is included in all
697 projects, there is conflicts with the jpeg lib of vtk when compiling the
698 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
699 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
700 when compiling the gdcm_wrap.cxx file (created by the compilation of the
702 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
703 (like it's already made for the cout use). Otherwise, conflict with the
706 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
709 - comments on the DicomDir::Method related usage added.
710 - now that we use the namespace gdcm, a lot of internal classes do
711 NOT need to be wrapped anymore.
712 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
713 DicomDir::Method) new example added.
715 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * Improve string manipulation. I now inforce the notion of 'DicomString'
717 A DicomString can contain as many \0 as they want
718 and it is *always* of even length.
719 We only support odd length for very rare case.
720 And in the near future this should be removed.
722 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
723 * /binary_write/ gdcm source. Now even on big endian we are writting
724 little endian. This should -heopfully- fix some tests
726 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 * Now the dictionary is compiled into gdcm lib. This is a default
728 behavior, thus any dic file specified is picked before failback to
729 the one comiled into lib
731 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
732 * Change internals for gdcmDict. Don't use any 'new' any more.
733 This should definitely solve any leak problem, and we should be
734 as fast as before, as long as don't modify too much the dictionary.
736 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
737 * STYLE: ivars should start with a capital letter.
738 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
739 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
741 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
743 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
744 new 2004 dictionaries added (thanks to JPR).
745 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
746 * CLEANUP_ROUND (15) for gdcmPixelConvert
747 - RLEFrame::NumberFragments is now of type unsigned int
748 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
749 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
752 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * Initial work in gathering all transfer syntax accessors. clearly
754 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
755 ivars, but only one transfersyntax (class) ivar with equivalent method on
758 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
759 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
760 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
761 discussed (plus I didn't like having a 2000 lines patch not commited)
763 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
764 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
765 * CLEANUP_ROUND (14) for gdcmPixelConvert
766 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
767 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
768 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
770 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
771 anymore and hence avoids storing a copy of PixelConvert::Decompressed
772 into File::Pixel_Data.
774 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
776 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
777 * CLEANUP_ROUND (13) for gdcmPixelConvert
778 Substituted File::ParsePixelData() with PixelConvert::Print() new
780 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
781 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
782 method to those classes.
783 - src/gdcmFile.[cxx|h]:
784 -- Added a ::Print() method.
785 -- PixelConverter is now a reference instead of a member.
786 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
787 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
789 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
791 collaboration diagram and inheritance diagram should be generated with
793 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
794 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
795 pointlessly wrapped (see
796 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
797 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
798 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
799 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
800 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
801 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
802 -- File::Initialise: PixelConverter setup moved away to
803 PixelConverter::GrabInformationsFromHeader()
804 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
805 interpretation moved away to PixelConverter::BuildRGBImage()
807 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
809 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
811 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
813 displayed on Win32 when a brutal abort() occurs (because of uncatched
814 exception). See TODO new entry of this commit for more on this.
815 * TODO added new entry.
816 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
817 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
818 - HandleColor is no longer called from gdcmFile.cxx
819 - gdcmPixelConvert.cxx clean up on method arguments and internal
820 variable names for semantical coherence.
822 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
823 * Finished lossless transition, not only do we now read all lossless jpeg
824 images, without the need of the Cornwell lib, but we do read them properly now
825 * To reduce code (well to avoid code duplication), I defined a common place
826 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
827 redefine symbols. This is not perfect but this the best solution I found for a
828 compilation time jpeg option.
830 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
831 * Update jpeg ijg lib to support lossless jpeg implementation
832 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
834 * Also added a special copyright for dcmtk since we use their bugfixes.
837 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
839 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
840 matters, as stated in warning note at begining of %include section).
841 * src/gdcmDicomDir*.[cxx|h]: coding style
842 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
843 * src/gdcmJpeg8.cxx: doxygen fix.
844 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
845 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
846 from File:: to PixelConvert::.
848 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
850 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
851 - more code moved away from File:: to PixelConvert::
852 - fat setup of PixelConverter set in place in File::Initialise.
854 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
855 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
856 namespace at the file system level. So now you should convert your examples
858 gdcmHeader -> gdcm::Header
859 It would be nice if people keep in mind to no open the namespace, since it
860 allows compilation on broken plateform which were defining common symbol in
861 the standart namespace (like LP, Unknown ...)
863 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
865 The JPEG fragments are now parsed at the same stage than the RLE
866 information. All code related to JPEG is now in gdcmPixelConvert:
867 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
868 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
869 export a gdcmFile:: method. Those are simply global functions
870 (for the time being this is better than having them attach to
871 either gdcmFile:: or gdcmPixelConvert::).
872 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
873 and stores the result in a gdcmJPEGFragmentsInfo.
874 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
875 code (among other stuff) moved away from gdcmFile:; to
878 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
880 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
881 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
882 clean up of RLE related code.
883 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
884 - src/gdcmRLE.cxx removed
885 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
886 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
887 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
888 * CLEANUP_ROUND (9) for gdcmPixelConvert
889 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
890 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
891 away from gdcmFile:: to gdcmPixelConvert::.
893 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
894 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
895 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
896 This is because Parse7Fe0 used to parse the pixels to compute the
897 length. This task was passed over to FindDocEntryLengthOB() a long
898 time ago, EXCEPT I had forgotten the OW case...
899 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
900 we just recylce the code for parsing RLE fragments and computing
902 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
903 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
904 with the retired Parse7Fe0().
905 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
906 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
908 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
910 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
911 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
912 - src/CMakeLists.txt: alphabetic order reodering + new entries.
913 * CLEANUP_ROUND (4) for gdcmPixelConvert
914 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
915 to return an unused length.
917 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
919 this should be cleanner from the plane view. The iostream are erally a pain
920 to use to do simple stuff.
922 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
923 * Redo the compilation of the ijg jpeg library. Now only one source is
924 necesseray. No need to rename file by hand what so ever. CMake handle the
925 copying of the file within different directory, configure header file to
926 modify some symbol. The only addition made to ijg wasd a mangle table so
927 that symbol are different whether we are within 8bits or 12bits.
929 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * Added documentation of vtkgdcmReader on Website:
931 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
932 with it's binary name).
933 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
934 the Website to be more complete.
935 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
936 doxygenated documentation.
937 - Doc/DoxyVtkGdcmReaderExamples.txt added
938 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
939 DoxyVtkGdmReaderExamples.html )
940 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
941 * CLEANUP_ROUND (3) for gdcmPixelConvert
942 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
944 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * CLEANUP_ROUND (2) for gdcmPixelConvert
946 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
948 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * CLEANUP_ROUND for gdcmPixelConvert:
950 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
951 - src/gdcmPixelStuff[h|cxx] removed
952 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
953 - src/CMakeLists.txt changed accordingly
955 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
956 gdcmVersion.py moved to newly created ATTIC related
957 gdcmPython/SetupOldies/ directory.
958 * Autotools clean up:
959 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
960 - autogen.sh configure.in acinclude.m4 python.m4 removed
962 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * src/*.cxx *.h Reference to License.htm fixed to License.html.
964 * Doc/CMakeLists.txt, doxygen.config.in: fix.
965 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
967 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * TODO updated with Mathieu suggestions. I proposed a template for
969 describing TODO entries and used it for new entries.
970 * Added Doc/Website/CodingStyle.html, Developpers.html,
971 DeveloppersPython.html, GdcmDataCvs.html and
972 DownloadVersion0_1.html, DownloadVersion0_3.html.
973 * Some Doc/*.txt Doxygen files (which do not really concern the
974 documentation itself, but the website) moved to html and
975 placed in directory Doc/Website:
976 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
977 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
978 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
979 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
980 * CMakeLists.txt changed accordingly.
981 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
982 DeveloppersPython.html
983 * INSTALL nows refers to Doc/Website/Installation.html
985 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * Added Doc/Website directory, that contains a first raw version
989 2004-09-23 Jean-Pierre Roux
990 * FIX In order not to be poluted any longer by casting problems,
991 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
992 we can now delete[] it safely
993 * VoidArea is now called BinArea (less confusing name),
994 and all the methods called ...VoidArea... are now ... BinArea...
995 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
997 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
999 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1000 up to the destructor of gdcmElementSet to clean up TagHt and it's
1003 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1005 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1007 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1008 * ENH: added some utility method that builds a flat dictionary
1009 holding all the Dicom entries contained in the recursive structure
1010 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1011 an example of usage.
1012 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1013 BuildFlatHashTable() that build a flat dictionary.
1014 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1015 gdcmDocument is now a friend of gdcmElementSet.
1016 - src/gdcmElementSet.cxx: clean up.
1017 - Example/FlatHashTablePrint.cxx added.
1018 - Example/CmakeLists.txt changed accordingly
1020 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1022 moved away from gdcmDocEntrySet (since this class is an abstract class
1023 acting like an interface). SQDepthLevel and BaseTagKey are now
1025 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1026 and associated accessors. Doxygenation of the class.
1027 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1029 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1030 Use SQDepthLevel accessor instead. ::Print() adapted.
1031 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1032 - src/gdcmDocument.cxx changed accordingly.
1034 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1036 - The following is the doxygen comment of the typedef declaration
1037 of gdcmTagKey in src/gdcmCommon.h:
1038 gdcmTagKey is made to old an "universal" (as in URL, Universal
1039 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1040 A dicom tag always has a group and an element, but a set of tags
1041 embeded in various (optionally nested) sequences and sharing
1042 the same group and element all share the same (group, element)
1043 "identifier". Hence the (group, element) cannot be used as an
1044 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1045 In order to construct a proper tag identifier (i.e. a key) we
1046 consider the following definition of a TagKey:
1047 - let Group, Element be the string representation of the
1048 group and element dicom tag members,
1049 - let ItemNumber be the string representation of the integer
1050 index of the considered item number of a sequence,
1051 Let the key of a tag embeded in a sequence, noted SeqTag, be
1053 /ItemNumber#Group|Element
1054 where "/", "#" and "|" are characters acting as separators.
1055 Then the general form of a gdcmTagKey is given by:
1056 Group|Element<SeqTag>
1057 where <SeqTag> means NO or many instances of SeqTag.
1058 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1061 but the gdcmTagKey of a tag "embeded" is the first item of
1062 a sequence, itself nested in the third item of a sequence is the
1064 0004|1220/2#0008|0082/0#0008|0090
1065 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1066 order to hold the new sequence compatible key. Previously, the
1067 GetKey() method would look in the underlying gdcmDictEntry.
1068 - src/gdcmDocEntry.cxx:
1069 -- constructor now copies the underlying DictEntry key, in the local
1071 -- ::Print: displays the member Key, instead of the (group, element).
1072 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1073 - src/gdcmDocEntrySet.h:xi
1074 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1075 -- now has a new BaseTagKey member.
1077 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1078 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1080 This poses the problem with the semantics of the following lines
1081 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1082 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1083 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1084 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1085 to the long FIXME note for what the problem is. Nevertheless in
1086 order to get things working the dicom dictionary was altered !
1087 Please fix things urgently...
1088 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1089 information), see above note on moving the member VoidArea. Nevertheless
1090 the following entries previously correctly set as US are now inproperly
1092 0028 1201 OW IMG Red Palette Color Lookup Table Data
1093 0028 1202 OW IMG Green Palette Color Lookup Table Data
1094 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1095 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1096 of gdcmDocEntry moved to gdcmSeqEntry.
1097 * src/gdcmSeqEntry.cxx: STYLE.
1099 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1102 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * gdcmPython/testSuite.py: all the test suite in python is now moved
1104 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1105 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1106 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1108 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1110 to avoid inclusion recursion until STL is reached.
1111 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1112 mecanism. errno.h is not included in gdcm anymore.
1113 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1114 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1116 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1117 gdcmData/TestAllEntryVerifyReference.txt
1118 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1119 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1120 exception_on_error parameter.
1121 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1122 - vtk/vtkGdcmReader.cxx changed accordingly,
1123 - Example/*.cxx and Test/*.cxx changed accordingly.
1125 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1127 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1128 enable_sequences removed from gdcmHeader constructor and dependencies.
1129 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1130 * gdcmPython/demo/PrintHeader.py: dummy fix.
1131 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1132 skip_shadow removed from gdcmHeader constructor and dependencies.
1133 * Example/*.cxx and Test/*.cxx changed accordingly.
1135 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1137 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1139 2004-07-21 Jean-Pierre Roux
1140 * FIX Now, Parsing and Printing a DICOMDIR do work!
1141 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1143 2004-07-20 Jean-Pierre Roux
1144 * FIX Some brain damaged headers have Zero-Lenght fields
1145 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1147 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1148 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1149 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1150 variable (instance of gdcmDebug) by a definition macro, and the instance
1151 is now in static in the gdcmDebug class
1152 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1153 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1155 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * WARNING: ctest now depends more tightly on gdcmData. You should
1157 check out gdcmData properly for things to run smoothly...
1158 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1159 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1160 we need the pixels not be loaded in order to use the ValEntry
1161 that displays position and size).
1162 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1163 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1164 be deprecated. If you have any doubts about the advantages of a
1165 modern scripting language (read Python) versus grass root C++ (i.e.
1166 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1167 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1168 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1169 Anyhow, consider documenting the gdcmData images in
1170 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1172 * Test/CMakeLists.txt:
1173 - now uses TestAllEntryVerify.cxx
1174 - specific comments on oldACR00001.ima (now renamed in gdcmData
1175 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1176 gdcmData/TestAllEntryVerifyReference.txt
1179 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * src/*.[h|cxx] : typedef clean up
1181 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1182 - TagKey renamed to gdcmTagKey (for external usage)
1183 - VRKey renamed to gdcmVRKey (for external usage)
1184 - removal of typedef duplication.
1185 - Removed all unecessary inline keyword from class inline definitions.
1186 - Some method|function(void) declarations replaced with method|function().
1187 * src/jpeg/libijg12/jdhuff12.c:
1188 - printf polluting ctest removed.
1189 - TAB removal for comminting
1191 - TestAllReadCompareDicom.cxx: added a test that compares all the
1192 images in gdcmDataImages.h with corresponding images in
1193 gdcmData/BaselineDicom/. When baseline images are not present
1194 this test creates them.
1195 Note: we need to validate each reference image, but before that
1196 I'd like to rename them with a more explicit name...
1197 - CMakeLists.txt: changed accordingly.
1198 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1199 including each header needed).
1201 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1202 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1203 test suite to the Example directory. Are concerned:
1208 - TestWriteSimple.cxx
1209 * Test/CMakeLists.txt: added some comments on reasons for black listing
1210 image gdcmData/oldACR00001.ima
1212 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Test/CmakeList.txt: removed the following from black list (to be coherent
1214 with removal from gdcmData):
1215 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1216 - gdcm-MR-PHILIPS-16.dcm
1218 Added the following because after last cvs update, they cause
1219 ctest -R TestReadWriteReadCompare
1221 - gdcm-MR-SIEMENS-16-1.acr
1223 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1224 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1225 new comments in this file) we temporarily (sigh) move to a weaker
1227 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1228 we don't need to black list the following images anymore:
1229 - 8BitsUncompressedColor.dcm
1231 - US-PAL-8-10x-echo.dcm
1232 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1233 fixes and the beautified code ;-)
1234 This fixes the bug introduced in version 1.42 (when beautifying)
1235 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1236 Note: ctest was blind to this bug (this means we need to still
1237 improve the test suite). The bug could be detected by using
1238 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1240 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1241 and by displaying the (garbage) produced file temp.XDCM...
1243 2004-06-29 Jean-Pierre Roux
1244 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1245 - replace by uggly but working old code :-(
1246 A lot of things should be OK again.
1247 It's really urgent to have a test suite that *tests*,
1248 to prevent Frog's beautifying sessions to break all the stuff
1249 (twice, withing a fortnigh ...)
1251 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1252 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1253 redundancy) to added Test/TestReadWriteReadCompare.cxx
1254 * Test/CmakeList.txt: because the compare test of
1255 Test/TestReadWriteReadCompare.cxx fails, the following images are
1256 black listed: - 8BitsUncompressedColor.dcm
1258 - US-PAL-8-10x-echo.dcm
1259 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1260 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1261 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1262 and ad-hoc kludge. This kludge is now removed, and on encountering
1263 such an image (OB field brain damaged) we set errno. Then in
1264 ::FindDocLength() we "fix" the length as being ALL what remains
1265 in the file (until EOF). We then proceed, hoping for the best...
1266 This fixes a SegFault in ShowDicom when trying to write such an
1268 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1269 (because TestWriteRead breaks on it, after a non conformal commit?).
1270 ctest now runs properly, except for MakeDicomDir (which was always
1271 broken) and the Python related stuff (still not fixed).
1273 2004-06-24 Jean-Pierre Roux
1274 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1275 FIX : Test/TestReadWrite now iterates on all the file names
1276 (instead of infinite loop)
1277 ENH : Test/TestWriteRead now iterates on all the file names
1279 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1282 2004-06-24 Jean-Pierre Roux
1283 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1284 when SamplesPerPixel =3
1285 - now Write is no longer confused by
1286 'BitsAllocated = 12" and 'BitsStored=12"
1287 - "UN" value representation Elements are now written correctly
1288 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1289 ENH : - now gdcmHeader has its own Write methods
1290 (in order to split the job that has not to be done
1293 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1295 loop on the same image until memory went out.
1296 Note: this means we still have gobs of memory loss in PrintDocument
1297 * src/gdcmDocument.cxx: fixes problem on parsing on file
1298 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1300 2004-06-24 Jean-Pierre Roux
1301 FIX : Write - All the Sequences and Sequence Item are now written
1302 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1303 is added a the end, when necessary.
1304 - A lot of brain-damaged images, that were read correctly are
1305 now written correctly
1306 - length compatible BinEntry are now loaded correctly
1307 (even for odd groups)
1308 Note : only Explicit Value Representation was checked.
1309 (question : is implicit VR really necessary for gdcm ?)
1311 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * DEVELOPPER: added a proposition of coding style.
1313 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1316 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1317 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1318 Use the gdcmDocEntry::Print() and Write() instead.
1319 * src/gdcmDocument.cxx: bug fix.
1321 2004-06-22 Jean-Pierre Roux
1322 FIX : gdcmDocument.cxx
1323 - Now we do recognize the JpegLossLess format (there was a misstyping in
1324 code 'beautyfication' :-(
1325 - Now we automaticaticaly load the Luts, if any
1327 2004-06-22 Jean-Pierre Roux
1328 In order : to write Sequences, whatever their imbrication level,
1329 : to allow user to create his own Sequences
1330 a lot of modif where necessary (adding, moving, or virtualising methods)
1332 WARNING : save your own sources *before* cvs up !
1335 ADD virtual void Write(FILE *fp, FileType filetype);
1338 ADD virtual void Write(FILE *fp, FileType filetype);
1339 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1342 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1343 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1344 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1345 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1346 ADD std::string GetEntryByName(TagName name);
1347 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1349 std::string vr = "unkn",
1350 std::string fourth = "unkn",
1351 std::string name = "unkn");
1352 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1353 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1354 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1355 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1356 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1357 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1358 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1359 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1362 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1363 ADD virtual std::string GetEntryByName (TagName tagName);
1364 ADD virtual std::string GetEntryVRByName (TagName tagName);
1365 REM virtual bool Write(FILE *, FileType);
1366 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1367 FILE *_fp, FileType type);
1368 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1369 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1370 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1371 REM virtual std::string GetEntryByName (std::string tagName);
1372 REM virtual std::string GetEntryVRByName (std::string tagName);
1373 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1374 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1375 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1377 std::string vr = "unkn",
1378 std::string fourth = "unkn",
1379 std::string name = "unkn");
1380 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1381 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1382 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1383 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1386 ADD virtual void Write(FILE *fp, FileType filetype);
1389 ADD virtual void Write(FILE *fp,FileType filetype);
1392 ADD virtual void Write(FILE *fp, FileType filetype);
1393 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1394 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1395 REM std::string GetEntryByName(TagName name);
1398 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1400 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1402 The default constructor invoked by the line
1403 gdcmHeader *f1 = new gdcmHeader( header );
1404 was gdcmHeader::gdcmHeader(bool) instead of the expected
1405 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1406 Hence the parsing wasn't executed... See also below.
1407 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1408 as explicit constructor didn't do the trick to fix the above problem.
1409 Could anyone explain why ?
1410 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1411 properly calls gdcmValEntry::Print() (that was weed out from
1412 code related to gdcmBinEntry).
1414 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * In order to fix memory leaks:
1416 - Test/TestWriteSimple.cxx: added cleaning of free store through
1418 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1419 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1420 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1421 (through the call to ::AddDicomDirMeta()) or the destructor
1422 would crash when deleting uninitialized ::metaElems].
1423 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1424 - src/gdcmDocument.cxx:
1425 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1426 from dynamic stores.
1427 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1428 was causing memory leaks.
1429 - src/gdcmSQItem.cxx:
1430 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1431 cleanly handled with polymophism: sorry but my milage is low).
1432 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1433 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1434 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1435 This avoids SegFaulting.
1436 - src/gdcmSQItem.h: coding style.
1438 - Test/TestWriteSimple still severely sucks. The output image content
1439 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1440 damaged when displayed with vtkgdcmViewer.
1441 - on memory leaks: TestWriteSimple leaks really less (see entry
1442 of 2004-06-18 in Changelog file for the call to valgrind).
1443 - on segfaults: ctest now passes all the tests but one (no more
1445 * Erroneous leading white fix:
1446 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1447 white[s] (as opposed to from >> xxx, that removes it [them].
1448 - src/gdcmTS.cxx: ditto.
1449 - gdcmPython/testSuite.py: dirty related kludge removed.
1450 * src/*: remaining references to gdcmParser removed.
1451 * src/*[cxx|h]: added copy[way]left header.
1454 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * In order to fix writing of dicom files:
1456 - Test/TestWriteSimple.cxx: a simpler example of writing.
1457 - Test/CMakeLists.txt changed accordingly.
1458 - src/gdcmDocument.cxx:
1459 -- The destructor now recursilvely removes potential sequences.
1460 -- Bug fix in ::IsJPEG2000()
1461 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1462 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1464 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1465 to only declared) and build on top of
1466 ::GetDocEntryByNumber(guint16, guint16).
1467 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1468 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1469 for usage in destructor and treatement of promotion in
1470 ::ReplaceOrCreateByNumber().
1471 - src/gdcmSQItem.cxx: destructor should better handle his job.
1472 Test/TestWriteSimple now runs (or at least it DOES something).
1473 * We can now start hutting memory links. A good starting point is:
1474 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1475 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1476 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1478 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1479 * Valgrind note: after Mathieu Malaterre teached me how to read
1480 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1482 Using gcc, you can force the STL to use malloc and to free memory as
1483 soon as possible by globally disabling memory caching.
1484 With 3.2.2 and later, you should export the environment variable
1485 GLIBCPP_FORCE_NEW before running your program.
1486 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1487 simply vanish (it is still not clear to me, whether this means that
1488 STL std::string leaks or if valgrind believes it leaks...).
1489 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1490 running bin/gdcmTests makeDicomDir):
1491 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1492 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1494 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1495 SegFaulting (I drowned in DicomDir related code when trying to
1496 understand why the list is empty...).
1497 * src/gdcmDocument.h: first BSD license header try.
1498 * Doc/License.txt added.
1500 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * src/gdcmDocument.[h|cxx]:
1502 - Clean up of the Transfer related predicates. They are now all based
1503 on new method isGivenTransferSyntax, that (should) handle properly
1504 the padding problem.
1505 - general clean up, simplification, and coding style.
1506 - Specific clean up of Parse7FE0() (umproperly named actually).
1507 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1509 2004-06-14 Jean-Pierre Roux
1511 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1512 - fix the display of SQItem ordinal number
1513 - add the GetSQItemByOrdinalNumber method
1514 - remove some useless never written private methods
1516 2004-06-14 Jean-Pierre Roux
1518 - adding a constructor taking a gdcmDocEntry as an input param
1519 - ReplaceOrCreateByNumber now returns :
1520 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1521 a gdcmValEntry * if a string value is passed as a param
1523 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1524 according to the param type (no longer sets a gdcmDocEntry)
1525 - GetValEntryByNumber, GetBinEntryByNumber added
1526 - NewValEntryByNumber and NewBinEntryByNumber added
1528 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1530 - GetSQItemNumber and SetSQItemNumber added, to provide
1531 a (relative) Item identier inside a given Sequence
1532 \warning : some pb remaining around this number
1534 - AddEntry now takes the Item Number as a param
1536 - adding a constructor taking a gdcmDocEntry as an input param
1538 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * Memory leak hunt with the following command:
1540 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1541 --show-reachable=yes gdcmTests PrintDocument
1542 It looks like many (all?) leaks are due to the STL (or a bad usage
1543 of the STL. The lines producing the leaks now have a comment with
1544 a "MEMORY LEAK" tag: you can retrieve them with
1545 grep "MEMORY LEAK" src/*
1546 Here are two typical examples which I can't help fixing:
1551 char * test = "babo";
1552 name = test; //// <--- valgrind detects 960 bytes lost in
1553 //// call to std::string::operator=(char const*)
1554 name.clear(); //// Doesn't help !
1562 std::cout << "Type a bunch of characters followed by RETURN: ";
1563 getline(std::cin, line); //// <--- valgrind dectects a loss
1564 //// of 1320 bytes in call to
1565 /// std::basic_istream<>& std::getline<>
1571 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1572 * src/gdcmHeader.[cxx|h]:
1573 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1574 and related, moved away to gdcmDocument.
1575 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1576 the corresponding protected accessors of inherited class
1577 gdcmDocument, removed ! As a consequence gdcmFile had to be
1578 declared friend of class gdcmDocument (see below).
1579 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1580 - Clean up of undefined or unused methods.
1581 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1582 account the changes to gdcmHeader.h).
1583 * src/gdcmDocument.h:
1584 - gdcmFile is now a friend class (in order to take into account the
1585 changes to gdcmHeader.h).
1586 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1587 (see changes to gdcmHeader.h).
1588 - Accessors (reading on the form GetEntry*) are now public.
1589 - Clean up of undefined or unused methods.
1590 * src/gdcmDocument.cxx:
1591 - adaptation to changes to gdcmDocument.h
1592 - ::OpenFile now writes a verbose message when file cannot be opened.
1593 - some std::string properly set to VRKey
1594 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1595 references to gdcmDocument.
1596 * Test/TestFindTags.cxx: changed accordingly to above changes.
1597 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1598 cvs repository gdcmData.
1600 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1601 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1602 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1603 conflicts with gdcmValEntry::voidArea.
1604 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1605 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1606 Value representation between StringRepresentable and BinaryRepresentable.
1607 * src/gdcmDocument.cxx:
1608 - method ParseDES: proper indentation restored and usage of
1609 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1610 - method LoadDocEntry: the fingerprint left in the SetValue() of
1611 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1612 removed. Reverting to previous code segment with the proper
1613 dynamic_cast< gdcmValEntry* >.
1614 Note: this was (partially) breaking the python test suite
1615 (gdcmPython/testSuite.py) that made usage of the above
1616 fingerprint to check presence of "Pixel Data".
1617 * src/gdcmDocEntry.h: coding style.
1618 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1619 now taken into account.
1620 * gdcmPython/gdcm.i: adaptation to the new internal representation
1621 of gdcm (exit gdcmParser, hello gdcmDocument).
1622 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1624 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1625 anymore, but instead prints the loaded Python dictionary.
1626 * .... alas, the python testSuite is still broken.
1628 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1631 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1632 * src/gdcmUtil.h : export methods
1634 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1635 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1637 * Initial addition of automatic python testing
1638 * Initial addition of automatic image comparison
1640 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1641 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1642 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1644 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1645 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1646 * Test/ShowDicom.cxx : bug fix for msvc compilation
1647 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1649 2004-05-04 Jean-Pierre Roux
1650 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1651 new concepts (and new classes) :
1652 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1653 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1654 - Sequence Doc Entries (gdcmSeqEntries)
1655 a Sequence is composed of Items.
1656 Each item is a set of Doc Entries (this is recursive)
1657 The non uniqueness of the 'Dicom tag' is due to this recursivity
1658 (never taken into account)
1659 Our unability to add a new 'entry' in the header
1660 at the proper location (neither in the H-Table (map or multimap),
1661 nor in the Chained List is also due to this recursivity.
1662 Don't try, right now, to use/modify/compile these new sources :
1663 nothing is finished.
1664 We just commit all the stuff, 'as is', in order not to loose it.
1666 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1667 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1669 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1670 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1671 file prefix (SetFilePrefix)
1673 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * Add a new test: ShowDicom, for now this is just the c++ version of
1675 checkRead.sh, later it will be able to compare the image read against a
1677 * Replace the DEBUG on the stack with a global entry in cmake interface:
1678 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1680 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * Add an example subdir, with a real example on how to read + write a
1684 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1685 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1686 * Doc/CMakeLists.txt: the main page is now properly differentiated
1687 between the developper and user version.
1688 * Doc/doxygen.config.in: dropped search related obsolete flags
1689 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1691 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * DEVELOPPER: added some helpfull comments for compile/test/install
1695 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1697 src directory, now generated in the build dir.
1698 2. Tests as mentionned smarter
1700 4. Add a new method in gdcmDict that return the PubDict by name
1701 this is interesting for 3rd party lib like ITK,
1702 where we could set the institution name / patient name...
1704 * ENH: 1. Now the test suite is working for real
1705 2. All binaries are now output in the gdcm-bin directory
1706 (this was not true before)
1708 2004-04-28 Jean-Pierre Roux
1709 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1710 SeQuence indented printing of Dicom Header.
1711 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1712 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1713 Computation of SQDepthLevel is now part of gdcmHeader constructor
1714 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1715 tree-like structure of a Dicom Header.
1716 * FIX Test code cleaning
1718 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1719 * ENH: Adding automatic testing
1720 1. Need a DartConfig.cmake to submit to public
1721 2. Add a test driver gdcmTest.cxx
1722 3. gdcmTestMain, an helper for the main test driver gdcmTest
1723 4. Files in Test don't have a main anymore, this becomes interesting
1724 when we add more and more tests, thus dsw don't have to load
1726 * ENH: Adding a GDCM_DATA_ROOT for testing
1727 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1728 one file instead of seven + some small cleanup
1730 2004-04-22 Jean-Pierre Roux
1731 * ENH Minor changes to the Print() methods.
1732 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1733 Header printing. Example given with :
1734 > PrintHeader fileName 2 new
1735 (SQ based tree-like structure still to be done for the Header ...)
1737 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1738 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1739 1. I have added some unsigned where needed
1740 2. Some function parameter not used -> (void)
1741 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1742 4. g++ don't like character '\' in comment
1743 5. #define jpeg_create_decompress jCreaDecompress
1744 this really need to be fixed
1745 6. virtualize destructor of gdcmObject ... leakage
1746 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1747 this also really need to be fixed
1748 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1749 remove compression file
1750 (as we only do decompression, right ?)
1751 * ENH: Change malloc/calloc/free with c++ equivalent
1753 2004-04-21 Jean-Pierre Roux
1754 * FIX gdcmHeaderHelper::GetXSpacing
1755 when a single value is found (bug ?), xpacing is now
1756 defaulted to yspacing
1758 2004-04-19 Jean-Pierre Roux
1759 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1760 * ENH add parameters :
1761 bool exception_on_error = false,
1762 bool enable_sequences = false,
1763 bool ignore_shadow = false
1764 to the gdcmFile constructors to be full gdcmParser compliant
1765 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1766 to allow reading of PAPYRUS 3.0 files
1768 2004-04-06 Jean-Pierre Roux
1769 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1771 2004-04-02 Jean-Pierre Roux
1772 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1773 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1774 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1776 2004-03-30 Jean-Pierre Roux
1777 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1778 for ACR file, written out as DICOM files (hope so...)
1780 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1782 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1783 moved to base class gdcmParser and only the specialisation is kept
1785 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1786 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1787 already does the job.
1788 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1789 (to be consistent with gdcmParser::WriteEntries).
1791 2004-03-30 Benoit Regrain
1792 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1793 upate of the object's instance. It's passed to 2 in the unfavorable
1794 case : one in the ExecuteInformation, one in the ExecuteData
1796 2004-03-29 Jean-Pierre Roux
1797 * ENH : Check on file type to be written moved
1798 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1799 * FIX : gdcmObject::ResetBoundaries now stops properly
1800 when end-of-list is reached
1801 : gdcmVersion modified (as Benoit Regrain asked)
1803 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1804 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1805 * src/gdcmUtil.cxx: added forgotten iostream include.
1806 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1807 equivalent to ExplicitVR in existing code).
1809 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1811 now contains all the gdcmGlobal related code.
1812 * minor coding style and doxygenation changes.
1814 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1816 now contains all the Debug related code.
1817 * minor clean-up of includes in src/*.cxx
1818 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1819 CreateCleanString) removed.
1820 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1821 * Doc/DoxyMainPageUser.txt added.
1822 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1823 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1824 src/gdcmDirList.cxx)
1826 2004-03-24 Jean-Pierre Roux
1827 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1829 2004-03-23 Jean-Pierre Roux
1830 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1831 big endian made volumes
1832 * ENH Now gdcmParser constructor and destructor are protected to forbid
1833 end user to instanciate class gdcmParser
1834 (only gdcmHeader and gdcmDicomDir are meaningfull)
1836 2004-03-22 Benoit Regrain
1837 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1838 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1839 gdcmSerie to gdcmDicomDirSerie
1841 2004-03-19 Jean-Pierre Roux
1842 * ENH Now the tree-like structure describing a DICOMDIR comming from
1843 an already existing DICOMDIR file is consistent with
1844 the home-made tree-like structure build ex-nihilo
1845 or build from the files held (recursively) in a Directory
1846 functions gdcmDicomDir::CheckBoundaries()
1847 gdcmObject::SetBoundaries() added
1849 2004-03-17 Jean-Pierre Roux
1850 * REM (Eric Boix bug) : removal of meaningless
1851 gdcmDicomDirImage::NewImage function.
1852 * FIX now file names and directory name are written properly in the
1854 * FIX now gdcmDicomDir constructor may be call without any trick
1857 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1859 of gdcmDicomDirImage::NewImage as empty function.
1861 2004-02-28 Jean-Pierre Roux
1862 * ENH add gdcmDicomDir:NewPatient
1863 add gdcmDicomDirPatient:NewStudy
1864 add gdcmDicomDirStudy:NewSerie
1865 add gdcmDicomDirSerie:NewImage
1866 to allow making gdcDicomDir object.
1867 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1868 (as opposite to the gdcmHeader chained list)
1870 2004-02-11 Benoit Regrain
1871 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1872 when using from python
1874 2004-02-10 Benoit Regrain
1875 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1876 * FIX : in gdcmDicomDir when the directory is empty
1877 * ENH : add callback and methods to get the progression of dicomDir
1880 2004-02-06 Jean-Pierre Roux
1881 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1882 - GDCM_META added to gdcmDicomDirType
1883 - class gdcmMeta created
1884 * ENH : - A brief summary is now displayed at the beginning of
1885 'testDicomDir' to help disaster magnitude estimation
1886 * REM : Now useless Test/explDICOMDIR.cxx
1888 2004-02-05 Benoit Regrain
1889 * ENH : add methods in gdcmObject to get the hash table or the list of
1891 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1892 * FIX : wrapping python for TagHeaderEntryHT
1894 2004-02-04 Benoit Regrain
1895 * FIX : even length for some strings when writting the dicom dir
1896 * FIX : sort the images in the dicom dir
1897 * FIX : Bug fix for python use of dicom dir
1898 * ADD : a python demo
1900 2004-02-04 Jean-Pierre Roux
1901 * FIX : Final solution (?) for icone embedded images
1902 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1903 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1904 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1905 gdcmData/gdcm-MR-SIEMENS-16.acr1
1906 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1907 to make full checking easier
1909 2004-02-04 Benoit Regrain
1910 * FIX : WriteEntries : coding style & logic in parameters
1911 * FIX : Set the elements to create the DicomDir in a dictionary file
1913 2004-02-03 Benoit Regrain
1914 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1915 * gdcmDicomDir : add the load of directory
1916 * Bug fix and print add-on
1918 2004-02-03 Jean-Pierre Roux
1919 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1920 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1921 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1922 * FIX gdcmParser.cxx : 'group length' elements are now considered
1923 as integers, even for shadow groups, when file is Implicit VR
1925 2004-02-02 Jean-Pierre Roux
1926 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1928 of the last synonym :-(
1929 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1931 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1932 * FIX taking into account the possible 7fe0,0010 multiplicity
1933 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1934 to allow removal of references to 7fe0,0010, to deal with
1935 ACR-NEMA images, when 0028,0200 is meaningfull
1937 2004-01-31 Jean-Pierre Roux
1938 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1939 no longer writes 'Un' on disk
1940 * FIX SQ elements with actual length are now dealt with corectly
1941 * FIX gdcmFile::WriteBase make the difference, for color images, between
1942 the length (for Palette expanded images)
1943 and Raw Length (non expanded image + Palette)
1944 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1945 (that broke Write). Replaced by UL.
1946 Aware user will reload the field if he
1947 thinks it's necesssary
1949 2004-01-30 Jean-Pierre Roux
1950 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1951 when 'dirty Acr' is found, to be compliant with the new
1952 IsReadable() methods.
1954 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1955 (no DOUBLE images in kosher DICOM,
1956 but so usefull for people that miss them ;-)
1958 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1959 DICOMDIR related utilities (not checked as Windoze compliant)
1961 2004-01-28 Jean-Pierre Roux
1962 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1964 2004-01-27 Jean-Pierre Roux
1965 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1966 to allow skipping the shadow elements, to save memory space.
1967 The TRUE value for this param has to be used
1968 with a FALSE value for the 'enable_sequence' param.
1969 ('public elements' may be embedded in 'shadow Sequences')
1970 * gdcmHeader methods now deal with 'embedded icones images' in the header
1971 (even when an 'icone image sequence' is announced by the
1972 element (0x0088,0x0200), but there is NO icone at all ...
1974 * gdcmHeader sometimes Image Location value doesn't follow
1975 the supposed processor endianity (see gdcmData/cr172241.dcm).
1978 * gdcmHeader add the method
1979 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1980 to get *all* the Header Entries with the same tag.
1981 GetHeaderEntrySameName is probabely *useless*
1982 (no meaning : Name is *not* an identifier within the Dictionary)
1984 2004-01-26 Benoit Regrain
1985 * Bug fix in the print of hexadecimal representations. Remove long fields
1986 in the print and add a third level of print to print them
1988 2004-01-23 Benoit Regrain
1989 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1990 * Bug fix on test suite after remove the strip made on not string fields
1991 * Split the IsReadable method between gdcmParser which test that the file
1992 is dicom and gdcmHeader which test that it's an image file
1994 2004-01-22 Benoit Regrain
1995 * DicomDir : clean code, add methods, set variables in protected or private
1996 * gdcmUtil : bug fix for the clean string method
1998 2004-01-19 Benoit Regrain
1999 * Add the use of shadow dictionaries
2000 * bug fix and coding style
2002 2004-01-19 Benoit Regrain
2003 * src/gdcmFile.cxx : bug fix concerning the close of file
2004 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2005 * Add the update of header entries using the shadow library
2007 2004-01-19 Benoit Regrain
2008 * removal of file gdcmHeader2.cxx
2009 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2010 inheriting from gdcmParser. This split is to prepare the integration
2011 of dicom dir parsing
2012 * bug fix under python
2014 2004-01-16 Jean-Pierre Roux
2015 * REM removal of class gdcmHeaderEntrySet
2016 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2017 * ADD add file gdcmHeader2.cxx
2018 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2020 2004-01-15 Benoit Regrain
2021 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2022 entries created while parsing the header. Thus, they will be destroyed
2023 when the gdcmDictSet will be destroyed
2024 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2027 2004-01-15 Benoit Regrain
2028 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2029 made a fatal error because of the memory release at the end of program.
2030 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2031 some memory and vtk seems to have some problems with that.
2032 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2034 2004-01-14 Benoit Regrain
2035 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2036 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2037 * src/*.[h|cxx] : make changes due to class name changes
2038 * gdcmPython/demo/*.py : bug fix due to method names
2040 2004-01-13 Benoit Regrain
2041 * src/*.[h|cxx] : coding style
2042 * vtk/*.[h|cxx] : coding style
2044 2004-01-13 Benoit Regrain
2045 * gdcmPython/testSuite.py : test the readable flag of file for tests
2046 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2047 It's lied to the stl compilation by MSVC (windows, always windows...)
2048 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2050 2004-01-12 Benoit Regrain
2051 * src/*.h : add comments
2052 * src/gdcmDictSet.h : set the method BuildDictPath in public
2053 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2054 directly setted in the source code
2055 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2058 2004-01-09 Benoit Regrain
2059 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2060 * setup.py : use a reference to gdcmVERSION
2062 2004-01-07 Benoit Regrain
2063 * Modification to compile with the distutils.
2066 2003-12-10 Benoit Regrain
2067 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2068 can use a gdcmHeaderHelper to load data
2069 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2070 made in the source code
2072 2003-12-10 Benoit Regrain
2073 * Update Windows projects and .cvsignore files
2075 2003-11-12 Jean-Pierre Roux
2076 * ENH gdcmHeader constructor has one more parameter (default value : false)
2077 that allows the user to 'go inside' the SeQuences only
2079 gdcmElValSet:Print takes it into account
2081 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2082 * ENH: Update gdcmPython/CMakeLists
2083 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2084 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2086 2003-11-10 Jean-Pierre Roux
2087 * FIX : gdcmHeader::LoadElements is now based
2088 on the ListTag listElem member,
2089 not longer on the TagElValueHT tagHt member
2090 * ENH : PrintPubElVal shows (temporarily) both results,
2091 with the tagHt member and the listElem member.
2092 (it's easier to 'see' the problems when using Printheader)
2094 * FIX : old private member LgrElem is now splitted into
2095 ReadLength : Length actually found on disk (updated only
2096 if bug fixing is necessary), for internal
2098 UsableLength : Updated by FixFoundLength, to fix a bug
2099 or to allow Parser going on.
2100 Will allow to re-write a kosher header when a SeQuence
2101 with a length (not 0000) is found
2102 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2103 because gdcmElValSet::Add does not update ListElem
2106 2003-11-07 Jean-Pierre Roux
2107 * FIX misstyping in Transfert Syntax name table
2108 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2109 when they have an actual length (not 0000 nor FFFFF)
2110 (Nobody should care of it, but DICOMDIR explorers)
2112 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2115 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2116 * ENH: vtkGdcmReader now supports LUT !
2117 (vtkgdcmViewer for now is not able to use them though)
2119 2003-11-05 Jean-Pierre Roux
2120 * in testSuite.py : new files names for checking the package
2121 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2122 that returns the pixel area size to the *aware* (vtk) user
2123 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2125 2003-11-05 Benoit Regrain
2126 * in testSuite.py : Modify the rules for checking the paths
2127 : Explicit error messages
2128 * in __init__.py : Related modif
2130 2003-11-03 Jean-Pierre Roux
2131 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2132 to be used by aware (vtk) users that want to manage
2133 LUT (and no to turn the PALETTE image into an RGB pixels one)
2134 * GetPixelType now returns 8U for 24 Bits images
2135 (vtkGdcmReader compliant)
2137 2003-10-31 Jean-Pierre Roux
2138 * Removal of *all* gdcmData images and add them again
2139 in order to loose the 'history' of un-anonymised images
2141 2003-10-31 Jean-Pierre Roux
2142 * RMV : removal of useless jBitsInJsample.h
2143 for both 8 and 12 Bits JPEG Lossy Libraries
2145 2003-10-31 Jean-Pierre Roux
2146 * ENH : Add the functions gdcmFile::GetImageDataRaw
2147 gdcmFile::GetImageDataIntoVectorRaw
2148 that act as GetImageData and GetImageDataIntoVector
2149 except the making of an RGB Plane from Gray Plane + LUT
2150 Intended to aware (vtk) users who know how to manage
2153 GetLUTRGBA return a R,G,B,A LUT if any
2154 lgrTotaleRaw gives the 'Raw' length
2155 GetImageDataRaw returns the gray Plane
2156 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2157 (They stay Grey, just like with other Dicom viewers :-(
2159 2003-10-30 Jean-Pierre Roux
2160 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2162 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2164 being coherents dicom files.
2166 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2167 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2169 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2170 * ENH: Two steps is necessary to please VC++ compiler...
2171 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2172 * ENH: Add include dir to medcon lib
2173 * FIX: only one function is being exported for now !
2174 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2176 2003-10-29 Jean-Pierre Roux
2177 * adding gdcmHeader::GetLUTRGBA
2178 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2179 --> Mathieu, the modif u're waiting for is not yet committed
2180 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2182 2003-10-27 Jean-Pierre Roux
2183 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2184 00191113.dcm DermaColorLossLess.dcm
2185 MxTwinLossLess.dcm RadBWLossLess.dcm
2186 * ENH: For version prior to vtkImageViewer2 -r 1.19
2187 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2189 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2190 * Removal of ido stuff in CMakeLists.txt
2192 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2194 * FIX: remove a call to ->Modified ... see comments
2195 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2197 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2198 * FIX: Problem with path for libvtkgdcmPython
2199 * ENH: Try adding a search script for python site-package
2200 * RMV: Remove some file from medcon lib that are not necessary
2201 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2202 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2203 * FIX: More pragma disable fro VC++,
2204 I don't think I break something as it is also disable in VTK/ITK.
2205 But it fasten debug compilation time.
2207 2003-10-23 Jean-Pierre Roux
2208 * gdcm now deals with 16 Bits Run Length Encoded images
2209 (they are compressed as 2 planes images,
2210 one for the high Bytes, the other for low Bytes)
2212 2003-10-22 Jean-Pierre Roux
2213 * Now CheckRead takes into account :
2214 - the bugged 'Leonardo' Siemens images
2215 - the XA images, sent thru the burning VPRO station
2216 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2219 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2220 * FIX: When copying a Makefile.am to CMakeLists.txt
2221 one should remove the '\'
2223 2003-10-22 Jean-Pierre Roux
2224 * in gdcmData adding a bugged 'Leonardo' Siemens image
2225 (wrong lengths in header)
2226 OK with gdcm, KO with the other viewers :-)
2227 * add a GE dlx XA image, thru the VEPRO burning station
2230 2003-10-21 Jean-Pierre Roux
2231 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2232 for a brutal checking of vtkgdcmViewer compliance
2234 2003-10-21 Jean-Pierre Roux
2235 * add the files for 'xmedcon' Jpeg Lossless library
2236 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2238 2003-10-21 Jean-Pierre Roux
2239 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2241 2003-10-21 Jean-Pierre Roux
2242 * garbage Siemens 'Leonardo' images dealt with
2243 (the patch is easy to remove)
2244 * cosmetic changes to avoid warnings
2246 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2248 no need to press 'r' now.
2250 2003-10-20 Jean-Pierre Roux
2251 * upgrade of checkRead.sh checkWrite.sh according
2252 to new Jpeg Lossless decompressor
2253 * add US.3405.1.dcm, a genuine RGB medical file ...
2254 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2255 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2257 2003-10-15 Jean-Pierre Roux
2258 * general anonymisation in gdcmData
2259 * adding the 'color files' from
2260 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2261 * adding some well knowed bugged-header images
2262 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2263 waiting for their inclusion in Python testsuite
2265 2003-10-15 Jean-Pierre Roux
2266 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2267 no longer seg faults when file is not found
2269 2003-10-14 Jean-Pierre Roux
2270 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2273 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * TODO: *.in file to genereate a UseGDCM later
2276 2003-10-14 Jean-Pierre Roux
2277 * Some supposed-to-be Dicom Images have no preamble.
2278 OpenFile takes it into account
2279 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2280 * Missing elements added in dicomV3.dic
2281 (just to be affraid : have a look at
2282 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2283 and do it again next year ;->
2285 2003-10-13 Jean-Pierre Roux
2286 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2287 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2288 But there are NOT. It's fixed !
2290 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * FIX: "jpeglib.h" was not found on VC++
2292 * FIX: vtkgdcm was not being installed
2294 2003-10-10 Jean-Pierre Roux
2295 * ENH : OpenFile closes the file if it *really* doesn't look like
2296 an ACR-NEMA / DICOM one.
2297 * FIX : testWrite no longer writes an empty file if the source file
2298 is not gdcm Readable
2299 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2302 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * FIX: CMake generate now documentation
2304 * ENH: out of source doc build !
2305 * ENH: Generate both user and dev documentation
2306 * ENH: Should work on windows too
2307 * ENH: Only one doxygen config.in file is needed
2308 * FIX: make install should be ok now on ùnix plateform
2309 * FIX: PATH to dictionary was wrong (missing /)
2310 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2312 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2313 * vtkGdcmReader is now able to read rgb dicom file.
2314 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2315 * added a gdcmViewer to vtk test, use mouse to control
2316 window level & window width
2318 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2319 * CMake-ification of gdcm, we have now two build system
2320 * FIX: on cygwin Wsock32 doesn't exist
2321 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2323 2003-10-06 Emanuel Ollart
2324 * FIX : compilation process wad broken.
2325 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2327 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * change gdcmViewer -> vtkgdcmViewer
2329 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2331 2003-10-06 Jean-Pierre Roux
2332 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2333 ( e.g : well known GE images with a wrong elem length,
2334 : Philips MRI Images with a wrong Huffman table)
2335 * still to be done : allow the reading of bugged LEONARDO Siemens images
2337 2003-10-03 Jean-Pierre Roux
2338 * Odd length strings are padded with '\0' (not with spaces,
2339 to remain compliant with already defined strings,
2340 like Transfert Syntax UID and others)
2342 2003-10-03 Jean-Pierre Roux
2343 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2344 to allow displaying RGB images (not only by affim ;-)
2346 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2347 * vtkGdcmReader is now able to read rgb dicom file.
2348 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2350 2003-10-03 Jean-Pierre Roux
2351 * A few nasty patches to allow the reading of a lot of nasty images
2352 ( e.g : well known GE images with a wrong elem length,
2353 : Philips MRI Images with a wrong Huffman table)
2354 * still to be done : allow the reading of bugged LEONARDO Siemens images
2356 2003-10-03 Jean-Pierre Roux
2357 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2359 2003-10-03 Jean-Pierre Roux
2360 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2361 to allow displaying RGB images (not only by affim ;-)
2363 2003-10-03 Jean-Pierre Roux
2364 * gdcmFile::GetImageDataIntoVector now
2365 - deals with MultiFrames MultiFragments Run Length Encoded files
2366 - deals with YcBcR (YBR_FULL) files
2367 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2368 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2370 (no sample found :-(
2372 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2373 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2374 Two reasons: - clear things
2375 - third parties acces gdcm through header files, so won't
2376 suffer anymore VC++ complains
2378 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * add argv[1] in testvtkGdcmReader.cxx
2382 2003-09-24 Jean-Pierre Roux
2383 * The lines are now eigthy characters long.for
2384 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2386 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2387 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2388 char* to std::string. Thus, the use of strdup becomes useless. (see
2389 previous commis of Malaterre)
2390 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2391 before the last Malaterre's commit.
2393 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * This commit should fix the Debug building under VC++, the problem
2395 was mainly a mixture of debug and release lib being loaded at startup.
2396 * I also remove a depency to a specific C function: strdup. Because I had
2397 to force the link to msvcrtd (whereas strdup is in libc).
2399 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2400 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2401 located in the gdcmCommon.h file. All use of reference of tha has been
2402 changed to now use the variable GDCM_UNFOUND.
2404 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2406 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2407 Dicom dictionary. The test suite can now be run again. Note:
2408 I'm note very happy with the " (RET)" changes. I believe this
2409 RETAINED comment should be dropped when parsing the dictionary.
2410 - PACKAGER corrected
2412 - AUTHORS updated and now in alphabetical order
2413 * Makefile.am now exports gdcm.dsw for Windoze users.
2415 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * cygwin complains about missing std:: in subdir Test/
2418 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * remove some methods that are now in gdcmHeaderHelper
2421 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2422 * vtkGdcmReader set spacing and origin correctly
2424 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2425 * Fix a few delete/delete[] mismatch
2427 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2429 interpretation to data given by gdcmHeader. For instance there are
2430 heuristics to get informations (look at different places).
2431 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2432 sorting DICOM images based on different strategies.
2433 * modified Makefiles accordingly.
2435 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2436 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2437 when building in debug mode
2438 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2439 src/win32/gdcmdll.dsp
2440 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2442 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2446 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2447 * src/win32/libgdcmjpeg12.dsp was not dos format
2448 * src/win32/libgdcmjpeg12.dsp :
2449 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2450 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2452 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2453 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2455 * src/gdcmFile.cxx : bug fix in affectation type
2456 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2457 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2458 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2459 symbols... future problem ?
2461 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2462 * src/win32/libgdcmijpeg12.dsp was missing
2463 * modified gdcm.dsw accordingly
2465 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2466 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2468 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2469 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2470 commit of JPR (before his hollidays to facilitate our work).
2471 * setup.py : bug fix in code. Modifications made while the last commit
2472 of JPR. The code hasn't been tested before the commit... it's so
2473 useless to make that (for best programmer that is JPR) !!!
2475 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * tagged the current version as Version0_3 (i.e. version 0.3)
2478 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2479 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2480 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2481 * *.dsp : modifications to use new libgdcmijpeg8 library
2482 * setup.py : bug fix on VTKPATH variable
2483 * PACKAGER : adding all concerning windows
2485 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2488 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2489 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2490 test suite reported error.
2491 * PACKAGER file added (describes what a packager must do when
2492 packaging a new release).
2493 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2494 * configure.in: upgraded version number to 0.3.0
2495 * fixing build of rpm (through rpm -ta):
2496 - Doc/Makefile.am exports proper doxygen files
2497 - src/jpeg/libijg8/Makefile.am exports the include files.
2499 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2500 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2501 * src/gdcmHeader.h : formatting code
2503 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2504 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2505 We were obtaining error message from vtk. Now, creation of file list
2506 is made in an internal list to prevent this problem.
2507 Bug fix when output is empty.
2508 Bug fix in update of progress value. Previous commit for this was a bad
2510 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2512 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2513 * src/gdcmHeader.h : added method to get the file name
2514 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2515 files. Added method to remove all files on the input
2516 Added FIXME comment concerning the bad parsing of header made by
2517 ExecuteInformation method (in ExecuteData method)
2519 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2521 when using make instal.
2522 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2523 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2525 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2526 * setup.py : adding include dir of jpeg lib to compile all sources
2527 * */Win32/*.dsp : JPR fix for windows compilation
2529 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2530 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2532 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2533 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2535 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2536 * setup.py is again effective on un*x (takes into account the
2537 addon of the jpeg library)
2538 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2539 * Doc/Doxy* updated (includes above enhancements)
2540 * INSTALL now points to web documentation
2542 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * src/gdcmHeader.h doesn't make unnecessary reference to
2545 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2547 * src/gdcm*.[cxx|h] :
2548 - to allow compilation with gcc 3.x
2549 -- clean up of STL usage (added explicit usage of std::)
2550 -- small fixes on exceptions.
2551 Note: linking not tested !
2552 - clean of doxygen comments to avoid warnings at documentation
2554 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2555 dependent convertion).
2557 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * Clean up of previous JPR garbage commit (not even commented in the
2560 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2561 - moved all jpeg related files from src to src/jpeg/libijg8, with
2562 addition/modification of Makefile.am and configure.in.
2563 - the testSuite is still brain damage (not guilty).
2565 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2566 * WrapVTK.py : modifications to get correctly vtk source files to
2568 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2569 (FileName -> Filename)
2571 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * vtk/vtkGdcmReader.[cxx/h]:
2573 - UpdateProgress method should now be effective
2574 - removed the limitation on having only images loaded (as opposed
2576 - when building a stack of images/volume, a lesser number of
2577 gdcmHeader and gdcmFile instances should be used (hopefully
2578 accelerating things).
2579 - when building a stack of images/volumes, files which are not
2580 loadable (wrong path-filename, wrong permissions on existing file,
2581 or file not parsable by gdcm) are replaced with a black image
2582 in the stack (for the caller to notice the problem).
2584 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2587 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2588 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2589 between standard library (std) and vtk library (problems are found
2590 under Windows... thanks Windows !)
2592 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2595 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2597 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2600 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * When compiling with distutils (see setup.py) the C++ compiler is
2602 called with different flags than the default ones (with automake).
2603 In order to fix all those warning, I compiled gdcm with the command
2604 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2605 and went for warning fixes:
2606 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2607 up from unused variables.
2608 - vtk/vtkGdcmReader.cxx: potential bug fix.
2609 * src/gdcmHeader.h: Doxygen warning cleanup
2611 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * gdcmPython/gdcm.i:
2613 - typemaps correction to take into account the systematic replacement
2614 of "using namespace std" with std:: prefix e.g. std::list,
2615 std::string... (cf changes of 2003-05-21).
2616 - gdcmGlob global variable of type gdcmGlobal (defined in
2617 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2618 exported to Python a as cvar.
2619 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2620 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2621 gdcmDictSet.GetPubDictTagNames() and
2622 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2623 C++ static methods).
2624 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2625 with the above changes.
2627 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2628 * setup.py, manifest.in : bug fix under linux
2630 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2631 * Modification of setup.py to compile vtk part too. Then, we have 2
2632 wrappers which must work with same distutils. For that, we have a
2633 generic distutils in distusiltsWrapping.py ; with :
2634 - build_extWrap class to wrap generically all extensions,
2635 - ExtensionWrap base class for all wrapping extension that contains
2637 - Wrapper interface which wrap sources
2638 + In WrapSwig.py we have extension and wrapper for Swig
2639 + In WrapVTK.py we have extension and wrapper for VTK
2640 * MANIFEST.in : modifications to consider vtk directory and new python
2641 files for compilation
2643 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2644 * Added python wrappers of vtkGdcmReader vtk class (see the
2645 source in vtk/vtkGdcmReader.cxx) :
2646 - vtk/Makefile.am now builds a library
2647 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2648 python library (as opposed to _gdcm.so wich are the python
2649 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2650 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2652 - configure.in has an additional flag --enable-vtk that needs
2653 to be set to enable compilation of vtk related code, that is:
2654 + vtk/vtkGdcmReader.so and
2655 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2656 + gdcmPython/vtkgdcmPython.so (see above)
2657 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2658 be read when compressed or when HighBit + 1 != BitsStored),
2659 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2660 the usage of the python wrapper of vtkGdcmReader vtk class.
2661 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2662 * src/*.[h] all occurences of stl classes are now prefixed with
2663 std::, and all occurences of "using namespace std;" where removed.
2664 This is to avoid pollution of global namespace in included files.
2665 Apparently vtk does not avoid this pitfall: when using both
2666 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2667 collision of various stl members (principally cout...).
2668 * gdcmPython/testSuite.py now cleanly removes temprory generated
2670 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2671 comply with above changes)
2673 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2674 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2675 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2676 vtk data structure (an image Flip was required).
2677 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2678 * cosmetic changes in documentation.
2680 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2681 * src/gdcmHeader.cxx: the constructor no longer exits when an
2682 unexisting file is given as argument.
2683 * The subdirectory Data (containing all the images used for the
2684 test suite) is not part of this repository anymore. A new module
2685 containing those images is now available at
2686 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2687 with the name gdcmData.
2688 All the python scripts (including the package initialisation file
2689 gdcmPython/__init__.py) were adapated to take this change into
2690 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2692 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2693 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2694 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2695 demo of the usage of this class.
2696 Compilation of this vtk part is only done when using the --enable-vtk
2697 at configure (or autogen.sh) stage.
2699 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2700 * More memory link related corrections and documentation fixes.
2702 - maximum info is obtained with a command of the form:
2703 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2704 --show-reachable=yes PrintHeader
2705 - the remaining reachable blocks seem to come from the STL
2706 allocation scheme through the usage of map and list. It looks
2707 like this memory cannot be freed but it is not a memory leak
2708 (in fact further invocation to the STL would recollect the
2709 unused memory allthough it cannot explicitely be freed).
2710 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2711 of displaying an image parsed with gdcm and displayed with VTK.
2712 Note: some images don't seem to work e.g.
2713 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2714 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2715 Allthough this weakens the semantics, it is a ditch attempt to
2716 make gdcm more thread friendly.
2718 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2719 * Memory link hunt (by using valgrind through the command
2720 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2721 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2722 gdcmHeader::_dicom_vr.
2723 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2724 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2726 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2728 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2729 * src/Makefile.am now exports all the necessary include files at
2733 * UpdateGroupLength replaced by new one
2736 * UpdateGroupLength re-written using H-Table
2737 (named UpdateGroupLengthNew untill checks are over)
2739 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2740 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2741 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2743 - gdcmHeader::GetPubElValSet removed.
2744 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2745 UpdateGroupLength, WriteElements, Write.
2746 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2747 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2748 carried the same semantics.
2749 - src/gdcmHeaderIdo.cxx changed accordingly.
2750 - gdcmFile::WriteBase now regroups all the codes from previous
2751 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2752 - enum FileType moved to gdcmCommon.h
2753 * src/gdcmHeader.cxx AddDefault trashed
2754 * gdcmGetXSize added
2755 * getimageDataSize now calls gdcmGetXSize
2756 * Test/*.cxx changed to agree with above changes
2758 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2760 (to avoid double call by end user).
2761 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2762 by end user, since gdcmHeader::gdcmHeader now handles it.
2764 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * gdcm/Doc many doxygen changes:
2766 - Doxyfile now has two different versions, DoxyfileUsers that generates
2767 the html.users end users oriented documentation and
2768 DoxyfileDeveloppers that generates the html.developper developper
2769 oriented documentation.
2770 - README changed accordingly
2771 - requirement.txt removed (old design info moved to TODO).
2772 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2773 DoxyMainPage.txt, DoxyPython.txt provide more information.
2774 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2775 be updated by simply regenerating the docs with doxygen and copying
2776 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2777 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2778 all the tests in the form "if (<map>.count() >1)" were removed.
2779 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2780 ill-formed documentation sections.
2781 * src/gdcmHeader.cxx: ditto
2783 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * setup.py fixed for un*x (needed macro for stdint.h)
2785 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2786 un*ces with sh-utils test utility.
2787 * gdcmPython/demo/test.py renamed to PrintHeader.py
2788 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2789 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2790 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2791 * src/gdcm*.cxx JPR's bad inclusion fixed.
2793 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2795 * gdcmPython/demo/test.py changed accordingly.
2797 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * gdcmPython/Makefile.am fixed linking against libstdc++
2799 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2800 * Swig subdir (historical tests of swig version 1.3.17++) removed
2801 * Test/testChangeEntete.cxx some lines commented out in order to make
2803 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2804 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2806 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2808 hence the user doesn't need this explicit call.
2809 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2810 i.e. LoadElements() call removed.
2811 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2812 - src/Makefile.am declares the proper flag for g++.
2813 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2814 for adding user defined new tags.
2815 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2816 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2817 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2819 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2820 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2821 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2822 src/Makefile.am : the project should properly compile and install
2823 with the autotools, included the python wrappers part.
2824 * gdcm.spec.in : added a spec file for RPM packaging.
2826 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2827 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2829 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2831 to exported to the environement (see gdcmPython/testSuite.py
2833 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2834 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2835 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2836 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2837 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2839 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * gdcmPython/__init__.py doesn't crash anymore when running in
2841 in InstallMode or PreInstallMode but with an environment given
2842 value of GDCM_DICT_PATH.
2843 * src/gdcmDictSet.[cxx/h] coding style.
2845 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2846 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2847 * src/gdcm.h general comments moved to TODO, and README
2848 * src/gdcm.h should now be seen as a user commodity (including it
2849 should suffice to fully use gdcm). It is nowhere including within
2850 any of the kernel files src/*.cxx and src/*.h.
2852 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2854 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2856 * src/gdcm*.cxx only include their corresponding include file
2857 (as opposed to gdcm.h)
2858 * gdcmPython/gdcm.i changed accordingly
2859 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2860 the autogen.sh generated "make snapshot" command to work.
2861 * autogen.sh removed history related references to crea package.
2863 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * distutilsSwigCPlusPlus.py work around some swig portability
2867 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2869 was done in a last ditch attempt to get setup.py _really_
2870 operationnal. The python/gdcmPython layaout add the advantage
2871 of hidding away the python related distutils specific files
2872 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2873 Alas, the src directory was out of scope (i.e. it's relative
2874 position to setup.py was ../src) which made things impossible to
2875 handle (see previous version of python/setup.py). Crossing fingers...
2877 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2878 * python/setup.py now works on Un*x. (harder than I thougth)
2879 * python/distutilsSwigCPlusPlus.py can now have include files
2880 among the list of sources.
2882 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2883 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2884 * modifications in MSVC projects
2886 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * As stated by the first lines of Test/ExceptionAndPython/README, it
2888 looks like we can move back to original usage of exception within
2889 src/gdcm* and hence remove the errno stuff that was introduced
2890 as a quick and dirty fixture of this problem (added to the TODO).
2891 * Doc/Doxyfile configuration file for Doxygen and corresponding
2892 README file for usage added.
2893 * Test/testWrite.cxx added. This new test comes from a split of
2894 test.cxx that is now reverted to its original purpous i.e.
2895 testing the proper parsing of a Dicom related file.
2896 testWrite.cxx concentrates on testing the IO part of gdcm.
2897 * Test/bug1.cxx (containing a bug on WIn32) added.
2898 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2899 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2900 whose purpose is to publish the content of the TagNames of the
2901 Dicom public dictionary were not accessible without an
2902 instance of class gdcmHeader.
2903 - those methods are now static methods of gdcmDictSet and hence
2904 require no instances at all to be invocated.
2905 - within gdcmDictSet this change required to change some method
2906 to class methods (i.e. are now static) among which SetDictPath
2907 (renamed to BuildDictPath) and LoadDefaultPubDict.
2908 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2909 the above changes by calling the new method classes of gdcmDictSet.
2910 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2911 the above to be effective.
2912 * python/gdcmPython: in order to wrap properly the above changes
2913 for Python, swig version now needs to be > 1.3.17.
2914 * python/gdcmPython/Makefile fixed to adapt itself to new
2915 configure/make shema introduced by Johan Montagnat (thanks for the
2916 contribution). Alas this Makefile cannot be turned into a proper
2917 Makefile.am without some heavy changes in the configure.in
2918 (for python dectection).
2919 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2920 now avoids publishing the empty entries.
2922 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2923 * python/setup.py : bug fix concerning install under windows
2924 ExtraPath reused :-P
2925 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2927 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2928 * Dicts/dicomV3.dic : remove double spaces !!!
2929 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2930 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2933 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2935 method. Doxygenation.
2936 * src/gdcm.h clean up of JPR spurious comments.
2938 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * python/distutilsSwigCPlusPlus.py now properly collects the
2940 shadow classes generated by "swig -c++" (gdcm.py in our case)
2941 when using "python setup.py install".
2942 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2943 reexports the working classes.
2944 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2945 by the classical C errno scheme. This is to prevent an obscure
2946 behavior of the python wrappers when importing wxPython.wx prior
2947 to gdcmPython (which ended up in an abort call). An illustration
2948 of this oddity can be found in the Test/ExceptionAndPython
2949 subdir (see the README file). This problem probably due to
2950 an combination of g++ and dynamic loading.
2951 * added Test/ExceptionAndPython (see above)
2953 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * Changed the layout of the python part to avoid bloating main
2955 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2956 i.e. the distutils arsenal. All the python related stuff is
2957 again in a python subdir, but the package itself is now in
2959 * setup.py was cleaned up:
2960 - pythonIncludePath removed
2961 - python setup.py bdist target is now functional.
2962 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2963 collision with other packages). gdcmPython/demo/*.py changed
2966 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * python subdir moved to gdcmPython (preparation of distutils packaging).
2968 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2969 distutils installer is operational.
2970 * - gdcmPython/__init__.py now properly loads the swig generated
2971 shadow classes (from gdcm.py).
2972 - gdcmPython/demo/*.py changed to import the package gdcmPython
2973 instead of gdcmPython/demo/load.py.
2974 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2976 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2977 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2978 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2979 entries within the associated public Dicom dictionary resp. the same
2980 information but sorted by the fourth field (PAT, IMG, DIR) of the
2982 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2983 are now in the "???" group.
2984 - python/gdcm.i changed accordingly,
2985 - python/demo/printGroupedPublicDict.py added, that gives an example
2986 of the above new functionalities in Python.
2988 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcm.h, gdcmHeader.cxx:
2990 - historic references to glib's g_malloc and g_free (#defined)
2991 were definitively removed.
2992 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2993 * src/gdcmElValSet.cxx:
2994 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2995 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2996 - GetElValue(string) renamed to GetElValueByName.
2997 - Added GetElementByName(string).
2998 * src/gdcmHeader.cxx: added
2999 - GetPubElValRepByNumber(guint16, guint16)
3000 - GetPubElValRepByName(string)
3001 - GetShaElValRepByNumber(guint16, guint16)
3002 - GetShaElValRepByName(string)
3003 - GetShaElValByNumber(guint16, guint16)
3004 - GetShaElValRepByName(string)
3005 - GetElValRepByNumber(guint16, guint16)
3006 - GetElValRepByName(string)
3007 - GetElValByNumber(guint16, guint16)
3008 - GetElValRepByName(string)
3009 * Doc/requirements.txt added.
3011 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3012 * Test/Makefile building now depends on the one of libgdcm.so
3013 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3014 pixel data) aware which enables finding the address (offset) of
3015 the pixel data of JPEG encoded DICOM files. This leaves only a single
3016 file in the testSuite whose pixel data address (offset) is unknown.
3017 * python/testSuite.py changed accordingly.
3019 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3020 * VC++ has some strong limitations when working with the STL, as stated
3021 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3022 "Also note that some STL containers (map, set, queue, list, deque)
3023 cannot be exported. [...]
3024 Some STL classes contain nested classes. These classes can not
3026 This is caused by a designed limitation that once a template
3027 class is instantiated, it can not be re-instantiated and
3029 Since our usage of map<> is ubiquitous in gdcm, this "designed
3030 limitation" of VC++ is a pitfall.
3031 Hence the Python wrappers of gdcm cannot be incrementally linked
3032 against the c++ dynamic library. The dirty but only workaround is
3033 to forget about incremental link of dynamic libraries and to generate
3034 the Python wrappers library with the inclusions of the underlying C++
3036 The following modifications concern this matter on Win32/VC++:
3037 - wrapping python correct with standalone wrapped dll (don't use separate
3038 dll under windows !!!!)
3039 - python21_d debug mode enabled (ask Frog how to use it :-)
3040 - NO problem with having an STL member of class for example string in C++
3041 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3042 - Python test of dcmlib in Python is ok under windows on a large set
3044 * removed glib references
3045 * typedef's inserted in gdcm.i for correct swig type management
3047 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * python/demo/*.py load.py extracted from test.py. Added explore.py
3049 that only displays required tags and testAll.py that parses all
3050 the files of the testsuite without using unittest.
3051 * python/testSuite.py other additional test on new files added.
3052 * Data/* new test files added accordingly to the testSuite.
3053 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3054 the vr in the file differs from the one of the dictionary.
3056 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3057 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3058 values, but limits itself to values which are below a user specified
3059 size (by default 1024 bytes).
3060 * python/gdcm.i : elements not loaded (because their size is above the
3061 user specified treshold) are exported with their TagKey as key of the
3062 python dictionary. This enables the testsuite to make some checks
3063 on the unloaded elements (since we have their offset and size).
3064 * python/testSuite.py
3065 - now tests for the existence and proper value of the pixel data
3066 - two new examples added.
3067 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3069 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3071 aware. See the strategy comments in gdcmHeader::FindeLength().
3072 * Test/test.cxx now accepts a filename as first argument.
3073 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3074 * python/testSuite.py changed to integrate test on above files.
3076 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3078 the vr was also RET.
3079 * python/testSuite.py more tests added.
3081 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * python/testSuite.py unittest test suite added (uses Data)
3083 * Data/* dcm and acr files for the test suite.
3084 * glib dependance removed from un*x version. We now use ISO C99
3085 7.18 Integer types (see stdint.h)
3086 - python/Makefile, src/Makefile src/gdcm.h
3087 * src/ when an explicit vr (like dicom files) suddenly poped an
3088 implicit element we use to mark the underlying DictEntry of the
3089 concerned ElValue with "Implicit". This strategy was damageable
3090 too the public or provite dictionaries, since some of their vr
3091 would be changed. Since Header::FindLength heavily relies on the
3092 detection by Header::FindVR of falsely explicit elements, I
3093 added an extra ImplicitVr member to ElValue (boolean).
3094 The rest of the changes we the necessary adaptations.
3096 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3099 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3101 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3102 * Adaptation for porting to VC++:
3104 o forced to use std namespace (for string to be known)
3105 o all class use __declspec export style on WIN32
3106 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3107 (in stdlib.h on Win32 but in std:: for gcc)
3108 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3109 variable GDCM_DICT_PATH.
3110 * src/gdcmHeader.cxx verbose comments made discrete.
3112 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * python/gdcm.i: added a typemap that converts a C++ hashing table
3114 to native Python dictionary.
3115 * python/demo/test.py:
3116 - now uses the native dictionary for exploration of gdcmHeader.
3117 - takes an optional filename argument (the file to parse).
3118 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3119 PubElVals hashing table.
3120 * Dicts/dicomV3.dic removed error prone trailing spaces.
3122 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * Python wrapping process moved away from src/Makefile to
3124 newly created python/Makefile (as well as gdcm.i)
3125 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3126 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3127 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3128 from the environement variable GDCM_DICT_PATH (when existing).
3129 * src/gdcmDict::GetTag bug fix.
3131 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3132 * Straightforward temporary fixes for swig to build the python wrappers.
3133 src/Makefile now has a python working entry [by working we mean
3134 that we can import de shadow classes without errors].
3136 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3137 * hashtest.cxx removed (since already in Test)
3138 * src/gdcmlib.h renamed to src/gdcm.h
3139 * src/dcm.i renamed to src/gdcm.i
3140 * src/Makefile prepared for python wrapping
3142 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3143 * src/gdcmHeader.cxx :
3144 - Parsing of header is now separated from loading of element values
3145 (see gdcmHeader::LoadElements).
3146 - general clean up of hopefully all file access (creation of
3147 ReadInt16 and ReadInt32)
3149 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * src/gdcmHeader.cxx :
3151 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3153 - SetLgrElem renamed to SetLength
3154 - GetLgrElem renamed to GetLength
3155 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3156 * src/gdcmElValSet.cxx fixed both GetElValue methods
3157 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3158 due to IdoDude was cleaned out.
3160 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3162 concentrates on finding the value representation (when it exists).
3163 RecupLgr now only finds the element value length, and it avoids
3164 returning the unecessary skL (skipped length).
3165 Also, offsetCourant was simply removed (with taille_fich) since
3166 it was redundant with the File position internals (by using
3167 ftell and fseek). This also made skL (see above in RecupLgr) usage
3169 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3170 on the libido specificities which are handled through class
3172 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3175 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3176 * Truckload of changes. Parsing of header is barely functional
3177 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3179 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3180 * src/gdcmHeader.cxx many addons of low level methods
3182 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3184 and _IdDcmSWAP_LONG.
3186 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * This corresponds to all the changes decided at the meeting of
3188 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob