1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/TestVR.cxx : fix memory leaks
4 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 * Rewrite the base 256 to base 10 conversion, using string operation only.
6 This allos us to get rid of the problematic 64bits integer type (does not
7 alwyas exist on target platform).
9 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
10 * Add construct and destructor to class gdcm::Debug to close the debug file
12 * Don't let uset to open twice the same file
13 * gdcm has now an official UID prefix,
14 supplied by http://www.medicalconnections.co.uk
15 1.2.826.0.1.3680043.2.1143
16 (Thx to Mathieu for providing URL)
17 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
18 to be able to perform some more tests
19 * gdcm::ContentEntry : Contructors and Destructor are now protected,
20 in order to be sure no user will try to use them.
21 (at user level, only the children classes are meaningfull)
23 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * move RLEInfo & JPEGInfo from Document to File
26 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * FIX : remove so many friend between classes
29 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
31 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
33 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
34 In order to avoid missbehaviour :
35 . gdcm::DocEntry is now specialized in
36 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
37 - gdcm::ContentEntry (Dicom entry with a 'content')
38 . gdcm::ContentEntry is specialized in
39 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
40 characters value, or integers)
41 - gdcm::BinEntry (Dicom entry with a non strig representable value
42 (user hasn't any longer to thing about the precedence of his dynamic_casts)
44 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Test/VTKTest*.cxx : bug fix under linux
47 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
49 use with python. Some methods are moved from Document to ElementSet or
50 DocEntrySet. The equivalent methods to ElementSet have been added to
51 SQItem and are virtual in DocEntrySet. Methods that may have the same code
52 in SQItem and ElementSet is directly placed in DocEntrySet
54 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * Test/VTKTest*.cxx : remove the show variable in each test method because
56 it's useless (the viewer variable replace this variable)
58 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * src/gdcmDocument.cxx : bug fix on potential memory leak
60 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
61 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
62 Add ClearXxx methods to remove all the content of the list or map
63 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
65 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 * methods ReplaceOrCreate renamed as Insert
67 (nobody will be any longer confused by 'CreateOrReplace')
69 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Grealty simplify the JPEg decompression, no need to differenciate based on
71 the JPEG possible type (with/without fragment, with/without multiple frame).
72 Everything is done throught the JPEG IO Suspension mechanism in IJG
74 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
75 * Stage 3 of normalization :
76 in order to avoid any missunderstanding while reading method names :
77 - All the methods xxxEntry now deal with dicom Entries
78 - Methods GetEntry splitted into
81 - Method SetEntry renamed as SetEntryValue
82 - Method SetEntryBinArea let as it was
84 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
85 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
86 - Position correctly the entry points for JPEG2000 and JPEG-LS
87 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
89 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
91 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
92 with other method names
93 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
94 * Test/TestDicomDirElement.cxx : add new test
96 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
98 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
99 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
100 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
101 So can't you use __int64 in ostream at all.
103 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * bug fix for compilation on MSVC6
105 * gdcmPython/gdcm.i : rename of classes missed
107 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
108 * Stage 2 of names normalization :
109 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
110 (easy to understand ...)
111 - gdcm::FileHelper replaces old class gdcm::File
113 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
115 type and not a string. So, there remove problems on the format of the
118 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
119 * Add Example/TestPapyrus.cxx
120 - reads a Papyrus file (gdcm::Header compliant),
121 - gets the pixels of all the images, using low level iterators
122 - writes an multiframes Dicom image.
123 (Just to show it's *possible* to do that)
124 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
127 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
129 Thus, DicomDirXXX are created with a flad that indicates if the created
130 object is empty or not (when not empty, the DicomDirElement is used to
133 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
135 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
137 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
140 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
142 Remove all access to the hash-tables or lists in the objects.
144 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
146 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
147 be complient with all the gdcm source code
149 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
153 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
157 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Test/ : rename VTK tests to have a best name for the tests
159 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
160 GetFirstEntry/GetNextEntry use
162 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
163 * In SerieHeader::ImagePositionPatientOrdering()
164 // a Dicom 'Serie' may contain scout views
165 // and images may have differents directions.
166 // -> More than one may have the same 'pos'
167 // Sorting has then NO meaning !
168 Thx to Eduardo Davila for reporting bug.
170 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
172 test. Now it's on image content and not on the resulting visualisation...
173 might solve the problem on linux when using the OpenGL drivers
175 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
176 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
177 DicomDirSerie, DicomDirImage
178 Dict, DictSet classes :
179 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
180 -remove InitTraversal method.
181 * UPD Test programs + Example programs
183 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
184 * remove useless and never updated keyword \ingroup
185 * Solve pb when structure (list, map, ...) is empty.
186 Thx to Benoit for reporting bug
188 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
189 * Taking into account of 'Transfer Syntax' value
190 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
193 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
195 is no memory access violation
196 * gdcmPython/demo : add python demos using VTK
198 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
199 * FIX 'Dictionnary' is now spelt 'Dictionary'
200 'wether' is now spelt 'whether'
201 'archieve' is now spelt 'archive' ;-)
203 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
205 related methods, in order not to expose internal mechanisms
208 * REM methods that exposed internal mechanisms :
209 DicomDir::GetDicomDirPatients()
210 DicomDirPatient::GetDicomDirStudies()
211 DicomDirStudy::GetDicomDirSeries()
212 DicomDirSerie::GetDicomDirImages()
213 * UPD Test programs :
217 * UPD Example program
219 * ADD DictSet methods
223 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * Removed the Print/indent/default parameter mess. There is absolutely no
225 reason to have to methods, moreover with the second taking the ostream as
226 *SECOND* parameter. This was clearly a bad hack to get things compile.
228 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
229 * Complete rewrite of the GetMacAddress code. Now the code is *much*
230 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
231 Unfortunately the main code does not work on SunOS, thus provide a specific
232 code for this platform only (and Win32 of course). Since this seems to be
233 working, change CreateUniqueUID to use GetMACAddress instead of the
234 problematic GctestetIPAddress
236 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
237 * Unfortunately to be able to test gdcmDirList I had to break the API
238 a little. Now the class is not a std::list anymore but has a member
239 std::vector (more ITK compatible). Allow unit testing on Win32 and
242 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
243 * Update SerieHeader to take into account a Serie Instance UID to properly
246 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
247 * ENH - Comment out Mathieu's (dangerous) Super Hack
248 for dealing with BIGENDIAN processors
249 - Move equivalent stuff to BinEntry::WriteContent
250 When necessary, 16 Bits Pixels are swapped in a small buffer
251 and then written. This avoid allocating a huge buffer, in
252 PixelWriteConvertor, and avoid modifying the Pixel Area.
254 Probabely, the same operation will have to be done when we want
255 to write image with Big Endian Transfert Syntax,
256 and we are working on Little Endian Processor
258 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
261 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
262 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
263 all the dict content.
264 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
266 * Test/TestDict.cxx : add a new test for the dict classes
268 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
269 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
270 file. Debug is yanked if compiled with NDEBUG
272 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * src/gdcmDictSet.h : set the default output to the os variable
274 * src/gdcmDictEntry.[h|cxx] : add the Print method
275 * gdcmPython/demo/ : add a new test
277 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
278 * merging of Test/PrintDicomDir and Test/TestDicomDir
279 * removal of now redundant Test/PrintDicomDir
280 * enhancement of Example/PrintDicomDir
282 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * Now, python test might work on systems
284 * Add the PrintDicomDir test
286 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
287 * FIX : First entry following group 0002 was lost for
288 Explicit Big Endian Transfer Syntax files
289 (group and elem not swaped)
291 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
293 Big Endian Transfer Syntax supposed the group following 0002
294 begins always by element 0000 (element 0000 is *optional*)
295 To avoid further troubles, let's be pessimistic, and use
296 Document::HandleOutOfGroup0002() method
297 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
298 (related pb not yet solved)
300 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * Bug fix for the python part use
302 * Now, PrintHeader.py pass... but outside the ctest use. shit !
304 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
307 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
308 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
309 a string and should ask the global TS dict what are the propreties of
312 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
313 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
314 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
315 to swap the Swap Code, at parsing time, when we come out of group 0002
316 and Transfer Syntax is Big Endian
317 We should be able to read now 'true DICOM" Big Endian coded images
318 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
319 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
321 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Hopefully fix the bug on MacOSX and static global initialization.
323 This is the only -minor- patch I found that both please MacOSX and VS6.
324 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
325 but this would require a lot of change. Another approach would be that Global
326 create those string and GDCM_UNFOUND becomes a pointer to a string (which
327 gdcm::Global would destroy at exit).
329 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Fix bug on MacOSX with static initialization in a multy threaded
331 environment. static const string in a header file used to be ill
332 initialized provoquing the freeze of any tests. patch should solve this
335 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
336 * According to Benoit's suggestion, and without any objection from anybody
337 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
338 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
339 - method gdcmDicomDirObject::GetEntry() renamed as
340 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
342 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
343 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
344 you debug/warning message just as c++ streams which make them very convinient
345 to use. Once this is stabilize I will change the ostringstrem to be
346 redirected to a file (ofstream).
347 * Properly support C99 extension: __FUNCTION__ which allow us to display
348 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
350 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
351 * Removal of useless and dangerous methods :
352 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
353 GetDocEntryByName, GetEntryByName, GetDictEntryByName
354 * Removal of usless methods :
355 Dict::PrintByName, Dict::GetDictEntryByName
356 * Commenting out of probabely useless methods :
357 Dict::GetDictEntryNames()
358 Dict::GetDictEntryNamesByCategory()
359 DictSet::GetPubDictEntryNames()
360 DictSet::GetPubDictEntryNamesByCategory()
361 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
362 * ENH : Use dicomTS.dic as described in 2004 version
363 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
364 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
365 Add Accessors on VM (Value Multiplicity), and VM related methods
366 * ADD : Add a list of 'Dicom Attribute types', as found in
367 http://medical.nema.org/dicom/2004/04_15PU.PDF
369 * ADD : Add dicomGroupNameAbbreviations.dic
370 should be used to write a method to replace the former
371 Dict::GetDictEntryNamesByCategory()
373 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
375 to read in the file... and only it ! Length is the efective length of the
376 data in the DocEntry structure
378 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
380 And now use a static function call instead, with a global variable. i
381 This is much closer to the VTK approach. Hopefully should be bulletproof
382 and easier to use...hopefully
384 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
387 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
390 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
392 ValEntry, BinEntry, SeqEntry creation or replace
394 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
396 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
398 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
399 when specifying the VR
400 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
401 * src/gdcmDocEntry.cxx : amelioration of print
403 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
404 * ADD : Add the method Util::IsCurrentProcessorBigEndian
405 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
406 * ADD Method Document::ComputeGroupLength
407 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
408 in order to allow further VR modification by user
409 * REM : removal of once-called method File::WriteBase
410 integration of its code in formerly one-line method File::Write
412 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
414 replace the different values "??", "Unkn", "Unknown".
415 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
416 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
417 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
418 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
420 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
423 * Set the gdcm::Base class to some Printable classes
425 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * src/gdcmFile.[h|cxx] : add the Print method
427 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
428 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
429 * src/gdcmDocument.h : remove the PrintLevel informations
430 * Example/PrintFile.cxx : use the new gdcm::File::Print
432 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
434 problems when compiling with the python wrapping
436 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
438 writting in ImplicitVR
440 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
441 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
442 JPEG decompression, especially when dicom frames are split into several
443 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
444 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
446 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmHeader.cxx : change the initialisation of default header.
448 Now, this header is readable by gdm, e-film, DicomWorks
450 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
452 Rename Decompressed to Raw
453 * Use the API changes in gdcm::File.
454 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
457 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
459 each added entry in the header. Replace the 'Planes' field by the 'Number
462 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
464 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
466 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
468 At this time, this image isn't readable by e-film... waiting JPR help to
471 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
472 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
473 DocEntry. Now use methods of the Document !
475 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * Test/ShowDicomSeq.cxx : bug fix
478 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
480 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
481 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
482 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
484 * Test/TestCopyRescaleDicom.cxx : remove unused variable
485 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
486 containing found sequences
488 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
491 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
492 Some fields in BinEntry must be copied to not seg fault when making the :
493 gdcm::File *copy = new gdcm::File( copyH );
494 and tests are now made on good variables
496 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
498 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
500 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
501 * Add vtkGdcmWriter example and test
503 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * Test/TestUtil.cxx : reformat the source code
505 * vtk/vtkGdcmReader.cxx : remove and change prints
506 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
508 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
509 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
511 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
513 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
515 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
517 by an eof to prevent all bad read of the file... and in this case, the
520 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * Example/Volume2Dicom.cxx : comment unused variables
522 * Test/PrintDicomDir.cxx : comment unused variables
523 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
524 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
525 method that is redondant with AddEntry.
526 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
529 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * Bug fix due my last commit (compilation under Windows).
531 * Example/Volume2Dicom : bug fix in the file and reformatting source code
532 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
534 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
536 - Remove printf / sprintf
537 - include iostream AFTER gdcm so we don't get warnings
538 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
540 - Also remove tons of include from header files, hopefully this should
541 speeup the compilation time, since it was becoming a dog slow.
542 - Remove gdcm.h as it include way too many files and slow down compilation
543 (plus it is not up to date)
544 - remove 'using namespace std' this is BAD !
546 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * Remove memory leaks on the DicomDir
548 * Remove some useless data in DicomDirObject
549 * Add usefull methods in SQItem, to be complient withe the ElementSet
551 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
554 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
556 future, with convertion)
557 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
558 and ImageDataSize values. Remove the method to get the PixelReadConverter
559 from the output of the class
561 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
564 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
566 and vtkErrorMacro use.
567 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
569 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
572 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
573 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
574 The string leaves only in the fonction. So when we make a .c_str(), we
575 get the pointeur on the first element, element that will be destroyed
576 immediately after thee instruction.
577 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
578 file has been opened : the test must be made on the content of the
579 pointer and not directly on the pointer !
582 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
584 the python part recompiles
586 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
588 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
589 X session is killed (for my computer... it seems to not be identic on
592 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
594 avoid problems (otherwise, the difference test between the visible image
595 and the reference is incorrect. If the reference is greater than the
596 screen resolution, it's produce errors).
597 Can be used for only one image. Can be used with a visible flag.
598 * vtk/vtkGdcmReader.cxx : remove commented codes.
599 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
600 under windows at compilation
601 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
603 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
605 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
607 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
608 tests on the image size X, Y, Z
610 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
612 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
613 between the class name and the file name
615 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * src/ : fix compilation warnings for the Write method (2 different
617 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
618 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
619 variable... create a static method in gdcm::Document to access to
620 this variable content.
622 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
624 file, to be accessed by other files (like gdcmFile). Remove commented
625 code. Move the change of the header to the gdcmFile, using the
627 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
628 To be sure of that (and simplify calls), the Write of the header now
629 gets a file name and not a file pointer (std::ifstream).
630 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
631 DocEntryArchive. Remove all open of the written file
633 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
636 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
638 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
640 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
641 some corresponding methods. Write correctly the file and check before
643 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
644 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
645 is now on RGB data (as before my last commit
646 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
648 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
650 Add a print information of the type of the entry
651 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
652 It was in the gdcmFile, and all write have been regrouped
653 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
654 Write correctly all dicom files (in decompressed mode only at this time)
655 * Test/ : test on files are now made using Raw data and not color data if
657 * Example/PrintFile.cxx : add more printings
659 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * Amelioration of code, remove some code copy. For the loading of
661 BinEntry (in gdcmDocument), add the test to verify if the file is already
664 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
666 remove a DocEntry in the header (push an empty DocEntry)
667 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
668 lines. Bug fix in the initialization of the PixelConvert and the
670 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
671 use in TestCopyDicom (now this test can run under windows... but fails)
672 * Test/TestCopyDicom.cxx : amelioration of the test :
673 - test the pixels written
674 - add test points to quickly find where is the error
675 - can set a file name input and output in arguments
676 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
677 amelioration of the test output
679 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
681 all replaced DocEntry's
682 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
683 Now, each needed DocEntry to modify is duplicated, modified and inserted
684 to the header using DocEntryArchive. Thus, after save, we can restore the
685 header initial state.
687 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
690 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
692 correct to copy it. The DictEntry is specified at the DocEntry creation,
693 then, it musn't change in the time.
694 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
695 header correctly. At this time, the change is only made for the first
696 level of the Document. In the future, it might consider sequences.
697 The change is made by replacing a DocEntry by an other that is created
698 outside the class. The old value is kept. When we restore the header
699 status, the added DocEntry is deleted and replaced by the old value.
700 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
701 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
702 set the write type to explicit VR, implicit VR or ACR. Add methods to set
703 the write mode to native, decompressed or RGB (but not used at this time)
705 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
707 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
709 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
711 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
713 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
714 set because already copied when copying the BinEntry's of the header
715 * Test/TestAllReadCompareDicom.cxx : remove warnings
717 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
719 Two problems appear when doing it :
720 - with the gdcmFile : when the GetImageData method is called, the pixels
721 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
722 data (pixels). And each structure destruct the data when it's
723 destructed. So we have two destructions for the same data. To solve it,
724 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
725 data or not. If it doesn't own data, then they will not destroyed by
727 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
728 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
729 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
730 create a double destruction of the same DocEntry's. So, to solve it,
731 the TagHT is simply cleared and the DicomDir* elements are destroyed.
732 * TODO : add an entry concerning memory leaks in the DicomDir
734 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
736 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
739 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
741 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
742 after it have been deleted
744 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * FIX: src/* fix the doxygen warnings.
746 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
747 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
748 was erroneously defined with a size of 15 instead of 16. [many thanks
749 to Jean Michel Rouet for pointing out this bug].
751 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
752 1. Finish merging JMR patch for writting DICOM from scratch
753 2. Fix -hopefully- bug with MONOCHROME and space vs null character
754 3. Use const ref when possible
755 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
756 5. A few more comments
757 6. CreateUniqueUID can now be called without parameter"
759 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * ENH: Slightly bigger patch:
761 1. Getting toward full integration of JMR patch for writting dicom from scratch
762 2. Update Test to test part of this patch: CreateUniqueUID
763 3. File was not close properly in gdcmDict
764 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
765 5. Use of const ref instead of copy (speed issue)
766 6. Remove temporary (duplicate) string in TranslateToKey
767 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
768 8. Do not repeat virtual in subclasses
769 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
771 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
772 * Apply first patch toward better string comparison when dealing with broken
773 DICOM files. Essentially the string could be padded with a space instead
774 of a null character as defined by standard
776 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
778 because never used... and in the same time, that's remove some memory leaks
780 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmFile.cxx : now delete the PixelConvert instance.
782 * In examples and tests : change the type of image data variables from void*
783 to uint8_t*. Remmove all delete on image data variables
785 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
786 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
787 Verify the file pointer value before open the file, and if it's not null,
788 a verbose message is generated.
789 Close correctly the file when the file isn't considered dicom-like. The
790 correctly close is a call to CloseFile.
791 When closing the file pointer, test if its not null to close the file.
792 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
793 file. For an uncompressed image, the copied data correspond in the least
794 case to the image size (calculated) or the image size specified in the
795 header. A verbose is generated if these two size mismatch
797 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
799 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
800 break under windows (with msvc6 compilation).
802 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
803 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
804 compiling with MSVC6)
806 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
807 * Bugs fix for the Windows build with VC6
808 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
809 needed (only for projects required VTK). If the VTK is included in all
810 projects, there is conflicts with the jpeg lib of vtk when compiling the
811 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
812 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
813 when compiling the gdcm_wrap.cxx file (created by the compilation of the
815 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
816 (like it's already made for the cout use). Otherwise, conflict with the
819 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
822 - comments on the DicomDir::Method related usage added.
823 - now that we use the namespace gdcm, a lot of internal classes do
824 NOT need to be wrapped anymore.
825 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
826 DicomDir::Method) new example added.
828 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
829 * Improve string manipulation. I now inforce the notion of 'DicomString'
830 A DicomString can contain as many \0 as they want
831 and it is *always* of even length.
832 We only support odd length for very rare case.
833 And in the near future this should be removed.
835 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
836 * /binary_write/ gdcm source. Now even on big endian we are writting
837 little endian. This should -heopfully- fix some tests
839 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
840 * Now the dictionary is compiled into gdcm lib. This is a default
841 behavior, thus any dic file specified is picked before failback to
842 the one comiled into lib
844 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
845 * Change internals for gdcmDict. Don't use any 'new' any more.
846 This should definitely solve any leak problem, and we should be
847 as fast as before, as long as don't modify too much the dictionary.
849 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 * STYLE: ivars should start with a capital letter.
851 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
852 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
854 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
856 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
857 new 2004 dictionaries added (thanks to JPR).
858 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
859 * CLEANUP_ROUND (15) for gdcmPixelConvert
860 - RLEFrame::NumberFragments is now of type unsigned int
861 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
862 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
865 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
866 * Initial work in gathering all transfer syntax accessors. clearly
867 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
868 ivars, but only one transfersyntax (class) ivar with equivalent method on
871 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
872 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
873 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
874 discussed (plus I didn't like having a 2000 lines patch not commited)
876 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
878 * CLEANUP_ROUND (14) for gdcmPixelConvert
879 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
880 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
881 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
883 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
884 anymore and hence avoids storing a copy of PixelConvert::Decompressed
885 into File::Pixel_Data.
887 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
889 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
890 * CLEANUP_ROUND (13) for gdcmPixelConvert
891 Substituted File::ParsePixelData() with PixelConvert::Print() new
893 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
894 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
895 method to those classes.
896 - src/gdcmFile.[cxx|h]:
897 -- Added a ::Print() method.
898 -- PixelConverter is now a reference instead of a member.
899 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
900 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
902 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
904 collaboration diagram and inheritance diagram should be generated with
906 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
907 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
908 pointlessly wrapped (see
909 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
910 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
911 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
912 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
913 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
914 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
915 -- File::Initialise: PixelConverter setup moved away to
916 PixelConverter::GrabInformationsFromHeader()
917 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
918 interpretation moved away to PixelConverter::BuildRGBImage()
920 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
921 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
922 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
924 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
925 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
926 displayed on Win32 when a brutal abort() occurs (because of uncatched
927 exception). See TODO new entry of this commit for more on this.
928 * TODO added new entry.
929 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
930 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
931 - HandleColor is no longer called from gdcmFile.cxx
932 - gdcmPixelConvert.cxx clean up on method arguments and internal
933 variable names for semantical coherence.
935 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * Finished lossless transition, not only do we now read all lossless jpeg
937 images, without the need of the Cornwell lib, but we do read them properly now
938 * To reduce code (well to avoid code duplication), I defined a common place
939 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
940 redefine symbols. This is not perfect but this the best solution I found for a
941 compilation time jpeg option.
943 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * Update jpeg ijg lib to support lossless jpeg implementation
945 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
947 * Also added a special copyright for dcmtk since we use their bugfixes.
950 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
952 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
953 matters, as stated in warning note at begining of %include section).
954 * src/gdcmDicomDir*.[cxx|h]: coding style
955 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
956 * src/gdcmJpeg8.cxx: doxygen fix.
957 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
958 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
959 from File:: to PixelConvert::.
961 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
963 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
964 - more code moved away from File:: to PixelConvert::
965 - fat setup of PixelConverter set in place in File::Initialise.
967 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
968 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
969 namespace at the file system level. So now you should convert your examples
971 gdcmHeader -> gdcm::Header
972 It would be nice if people keep in mind to no open the namespace, since it
973 allows compilation on broken plateform which were defining common symbol in
974 the standart namespace (like LP, Unknown ...)
976 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
978 The JPEG fragments are now parsed at the same stage than the RLE
979 information. All code related to JPEG is now in gdcmPixelConvert:
980 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
981 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
982 export a gdcmFile:: method. Those are simply global functions
983 (for the time being this is better than having them attach to
984 either gdcmFile:: or gdcmPixelConvert::).
985 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
986 and stores the result in a gdcmJPEGFragmentsInfo.
987 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
988 code (among other stuff) moved away from gdcmFile:; to
991 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
993 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
994 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
995 clean up of RLE related code.
996 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
997 - src/gdcmRLE.cxx removed
998 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
999 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1000 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1001 * CLEANUP_ROUND (9) for gdcmPixelConvert
1002 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1003 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1004 away from gdcmFile:: to gdcmPixelConvert::.
1006 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1008 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1009 This is because Parse7Fe0 used to parse the pixels to compute the
1010 length. This task was passed over to FindDocEntryLengthOB() a long
1011 time ago, EXCEPT I had forgotten the OW case...
1012 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1013 we just recylce the code for parsing RLE fragments and computing
1015 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1016 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1017 with the retired Parse7Fe0().
1018 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1019 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1021 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1023 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1024 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1025 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1026 * CLEANUP_ROUND (4) for gdcmPixelConvert
1027 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1028 to return an unused length.
1030 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1031 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1032 this should be cleanner from the plane view. The iostream are erally a pain
1033 to use to do simple stuff.
1035 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * Redo the compilation of the ijg jpeg library. Now only one source is
1037 necesseray. No need to rename file by hand what so ever. CMake handle the
1038 copying of the file within different directory, configure header file to
1039 modify some symbol. The only addition made to ijg wasd a mangle table so
1040 that symbol are different whether we are within 8bits or 12bits.
1042 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1043 * Added documentation of vtkgdcmReader on Website:
1044 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1045 with it's binary name).
1046 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1047 the Website to be more complete.
1048 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1049 doxygenated documentation.
1050 - Doc/DoxyVtkGdcmReaderExamples.txt added
1051 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1052 DoxyVtkGdmReaderExamples.html )
1053 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1054 * CLEANUP_ROUND (3) for gdcmPixelConvert
1055 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1057 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * CLEANUP_ROUND (2) for gdcmPixelConvert
1059 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1061 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1062 * CLEANUP_ROUND for gdcmPixelConvert:
1063 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1064 - src/gdcmPixelStuff[h|cxx] removed
1065 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1066 - src/CMakeLists.txt changed accordingly
1067 * GDCMHOME clean up:
1068 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1069 gdcmVersion.py moved to newly created ATTIC related
1070 gdcmPython/SetupOldies/ directory.
1071 * Autotools clean up:
1072 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1073 - autogen.sh configure.in acinclude.m4 python.m4 removed
1075 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1077 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1078 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1080 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * TODO updated with Mathieu suggestions. I proposed a template for
1082 describing TODO entries and used it for new entries.
1083 * Added Doc/Website/CodingStyle.html, Developpers.html,
1084 DeveloppersPython.html, GdcmDataCvs.html and
1085 DownloadVersion0_1.html, DownloadVersion0_3.html.
1086 * Some Doc/*.txt Doxygen files (which do not really concern the
1087 documentation itself, but the website) moved to html and
1088 placed in directory Doc/Website:
1089 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1090 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1091 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1092 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1093 * CMakeLists.txt changed accordingly.
1094 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1095 DeveloppersPython.html
1096 * INSTALL nows refers to Doc/Website/Installation.html
1098 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * Added Doc/Website directory, that contains a first raw version
1102 2004-09-23 Jean-Pierre Roux
1103 * FIX In order not to be poluted any longer by casting problems,
1104 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1105 we can now delete[] it safely
1106 * VoidArea is now called BinArea (less confusing name),
1107 and all the methods called ...VoidArea... are now ... BinArea...
1108 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1110 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1112 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1113 up to the destructor of gdcmElementSet to clean up TagHt and it's
1116 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1118 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1120 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * ENH: added some utility method that builds a flat dictionary
1122 holding all the Dicom entries contained in the recursive structure
1123 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1124 an example of usage.
1125 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1126 BuildFlatHashTable() that build a flat dictionary.
1127 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1128 gdcmDocument is now a friend of gdcmElementSet.
1129 - src/gdcmElementSet.cxx: clean up.
1130 - Example/FlatHashTablePrint.cxx added.
1131 - Example/CmakeLists.txt changed accordingly
1133 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1134 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1135 moved away from gdcmDocEntrySet (since this class is an abstract class
1136 acting like an interface). SQDepthLevel and BaseTagKey are now
1138 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1139 and associated accessors. Doxygenation of the class.
1140 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1142 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1143 Use SQDepthLevel accessor instead. ::Print() adapted.
1144 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1145 - src/gdcmDocument.cxx changed accordingly.
1147 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1149 - The following is the doxygen comment of the typedef declaration
1150 of gdcmTagKey in src/gdcmCommon.h:
1151 gdcmTagKey is made to old an "universal" (as in URL, Universal
1152 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1153 A dicom tag always has a group and an element, but a set of tags
1154 embeded in various (optionally nested) sequences and sharing
1155 the same group and element all share the same (group, element)
1156 "identifier". Hence the (group, element) cannot be used as an
1157 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1158 In order to construct a proper tag identifier (i.e. a key) we
1159 consider the following definition of a TagKey:
1160 - let Group, Element be the string representation of the
1161 group and element dicom tag members,
1162 - let ItemNumber be the string representation of the integer
1163 index of the considered item number of a sequence,
1164 Let the key of a tag embeded in a sequence, noted SeqTag, be
1166 /ItemNumber#Group|Element
1167 where "/", "#" and "|" are characters acting as separators.
1168 Then the general form of a gdcmTagKey is given by:
1169 Group|Element<SeqTag>
1170 where <SeqTag> means NO or many instances of SeqTag.
1171 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1174 but the gdcmTagKey of a tag "embeded" is the first item of
1175 a sequence, itself nested in the third item of a sequence is the
1177 0004|1220/2#0008|0082/0#0008|0090
1178 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1179 order to hold the new sequence compatible key. Previously, the
1180 GetKey() method would look in the underlying gdcmDictEntry.
1181 - src/gdcmDocEntry.cxx:
1182 -- constructor now copies the underlying DictEntry key, in the local
1184 -- ::Print: displays the member Key, instead of the (group, element).
1185 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1186 - src/gdcmDocEntrySet.h:xi
1187 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1188 -- now has a new BaseTagKey member.
1190 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1191 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1193 This poses the problem with the semantics of the following lines
1194 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1195 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1196 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1197 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1198 to the long FIXME note for what the problem is. Nevertheless in
1199 order to get things working the dicom dictionary was altered !
1200 Please fix things urgently...
1201 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1202 information), see above note on moving the member VoidArea. Nevertheless
1203 the following entries previously correctly set as US are now inproperly
1205 0028 1201 OW IMG Red Palette Color Lookup Table Data
1206 0028 1202 OW IMG Green Palette Color Lookup Table Data
1207 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1208 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1209 of gdcmDocEntry moved to gdcmSeqEntry.
1210 * src/gdcmSeqEntry.cxx: STYLE.
1212 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1215 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * gdcmPython/testSuite.py: all the test suite in python is now moved
1217 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1218 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1219 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1221 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1222 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1223 to avoid inclusion recursion until STL is reached.
1224 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1225 mecanism. errno.h is not included in gdcm anymore.
1226 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1227 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1229 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1230 gdcmData/TestAllEntryVerifyReference.txt
1231 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1232 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1233 exception_on_error parameter.
1234 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1235 - vtk/vtkGdcmReader.cxx changed accordingly,
1236 - Example/*.cxx and Test/*.cxx changed accordingly.
1238 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1240 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1241 enable_sequences removed from gdcmHeader constructor and dependencies.
1242 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1243 * gdcmPython/demo/PrintHeader.py: dummy fix.
1244 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1245 skip_shadow removed from gdcmHeader constructor and dependencies.
1246 * Example/*.cxx and Test/*.cxx changed accordingly.
1248 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1250 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1252 2004-07-21 Jean-Pierre Roux
1253 * FIX Now, Parsing and Printing a DICOMDIR do work!
1254 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1256 2004-07-20 Jean-Pierre Roux
1257 * FIX Some brain damaged headers have Zero-Lenght fields
1258 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1260 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1261 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1262 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1263 variable (instance of gdcmDebug) by a definition macro, and the instance
1264 is now in static in the gdcmDebug class
1265 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1266 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1268 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * WARNING: ctest now depends more tightly on gdcmData. You should
1270 check out gdcmData properly for things to run smoothly...
1271 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1272 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1273 we need the pixels not be loaded in order to use the ValEntry
1274 that displays position and size).
1275 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1276 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1277 be deprecated. If you have any doubts about the advantages of a
1278 modern scripting language (read Python) versus grass root C++ (i.e.
1279 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1280 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1281 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1282 Anyhow, consider documenting the gdcmData images in
1283 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1285 * Test/CMakeLists.txt:
1286 - now uses TestAllEntryVerify.cxx
1287 - specific comments on oldACR00001.ima (now renamed in gdcmData
1288 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1289 gdcmData/TestAllEntryVerifyReference.txt
1292 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * src/*.[h|cxx] : typedef clean up
1294 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1295 - TagKey renamed to gdcmTagKey (for external usage)
1296 - VRKey renamed to gdcmVRKey (for external usage)
1297 - removal of typedef duplication.
1298 - Removed all unecessary inline keyword from class inline definitions.
1299 - Some method|function(void) declarations replaced with method|function().
1300 * src/jpeg/libijg12/jdhuff12.c:
1301 - printf polluting ctest removed.
1302 - TAB removal for comminting
1304 - TestAllReadCompareDicom.cxx: added a test that compares all the
1305 images in gdcmDataImages.h with corresponding images in
1306 gdcmData/BaselineDicom/. When baseline images are not present
1307 this test creates them.
1308 Note: we need to validate each reference image, but before that
1309 I'd like to rename them with a more explicit name...
1310 - CMakeLists.txt: changed accordingly.
1311 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1312 including each header needed).
1314 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1315 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1316 test suite to the Example directory. Are concerned:
1321 - TestWriteSimple.cxx
1322 * Test/CMakeLists.txt: added some comments on reasons for black listing
1323 image gdcmData/oldACR00001.ima
1325 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * Test/CmakeList.txt: removed the following from black list (to be coherent
1327 with removal from gdcmData):
1328 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1329 - gdcm-MR-PHILIPS-16.dcm
1331 Added the following because after last cvs update, they cause
1332 ctest -R TestReadWriteReadCompare
1334 - gdcm-MR-SIEMENS-16-1.acr
1336 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1337 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1338 new comments in this file) we temporarily (sigh) move to a weaker
1340 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1341 we don't need to black list the following images anymore:
1342 - 8BitsUncompressedColor.dcm
1344 - US-PAL-8-10x-echo.dcm
1345 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1346 fixes and the beautified code ;-)
1347 This fixes the bug introduced in version 1.42 (when beautifying)
1348 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1349 Note: ctest was blind to this bug (this means we need to still
1350 improve the test suite). The bug could be detected by using
1351 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1353 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1354 and by displaying the (garbage) produced file temp.XDCM...
1356 2004-06-29 Jean-Pierre Roux
1357 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1358 - replace by uggly but working old code :-(
1359 A lot of things should be OK again.
1360 It's really urgent to have a test suite that *tests*,
1361 to prevent Frog's beautifying sessions to break all the stuff
1362 (twice, withing a fortnigh ...)
1364 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1366 redundancy) to added Test/TestReadWriteReadCompare.cxx
1367 * Test/CmakeList.txt: because the compare test of
1368 Test/TestReadWriteReadCompare.cxx fails, the following images are
1369 black listed: - 8BitsUncompressedColor.dcm
1371 - US-PAL-8-10x-echo.dcm
1372 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1373 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1374 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1375 and ad-hoc kludge. This kludge is now removed, and on encountering
1376 such an image (OB field brain damaged) we set errno. Then in
1377 ::FindDocLength() we "fix" the length as being ALL what remains
1378 in the file (until EOF). We then proceed, hoping for the best...
1379 This fixes a SegFault in ShowDicom when trying to write such an
1381 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1382 (because TestWriteRead breaks on it, after a non conformal commit?).
1383 ctest now runs properly, except for MakeDicomDir (which was always
1384 broken) and the Python related stuff (still not fixed).
1386 2004-06-24 Jean-Pierre Roux
1387 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1388 FIX : Test/TestReadWrite now iterates on all the file names
1389 (instead of infinite loop)
1390 ENH : Test/TestWriteRead now iterates on all the file names
1392 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1395 2004-06-24 Jean-Pierre Roux
1396 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1397 when SamplesPerPixel =3
1398 - now Write is no longer confused by
1399 'BitsAllocated = 12" and 'BitsStored=12"
1400 - "UN" value representation Elements are now written correctly
1401 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1402 ENH : - now gdcmHeader has its own Write methods
1403 (in order to split the job that has not to be done
1406 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1408 loop on the same image until memory went out.
1409 Note: this means we still have gobs of memory loss in PrintDocument
1410 * src/gdcmDocument.cxx: fixes problem on parsing on file
1411 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1413 2004-06-24 Jean-Pierre Roux
1414 FIX : Write - All the Sequences and Sequence Item are now written
1415 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1416 is added a the end, when necessary.
1417 - A lot of brain-damaged images, that were read correctly are
1418 now written correctly
1419 - length compatible BinEntry are now loaded correctly
1420 (even for odd groups)
1421 Note : only Explicit Value Representation was checked.
1422 (question : is implicit VR really necessary for gdcm ?)
1424 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * DEVELOPPER: added a proposition of coding style.
1426 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1429 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1431 Use the gdcmDocEntry::Print() and Write() instead.
1432 * src/gdcmDocument.cxx: bug fix.
1434 2004-06-22 Jean-Pierre Roux
1435 FIX : gdcmDocument.cxx
1436 - Now we do recognize the JpegLossLess format (there was a misstyping in
1437 code 'beautyfication' :-(
1438 - Now we automaticaticaly load the Luts, if any
1440 2004-06-22 Jean-Pierre Roux
1441 In order : to write Sequences, whatever their imbrication level,
1442 : to allow user to create his own Sequences
1443 a lot of modif where necessary (adding, moving, or virtualising methods)
1445 WARNING : save your own sources *before* cvs up !
1448 ADD virtual void Write(FILE *fp, FileType filetype);
1451 ADD virtual void Write(FILE *fp, FileType filetype);
1452 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1455 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1456 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1457 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1458 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1459 ADD std::string GetEntryByName(TagName name);
1460 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1462 std::string vr = "unkn",
1463 std::string fourth = "unkn",
1464 std::string name = "unkn");
1465 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1466 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1467 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1468 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1469 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1470 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1471 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1472 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1475 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1476 ADD virtual std::string GetEntryByName (TagName tagName);
1477 ADD virtual std::string GetEntryVRByName (TagName tagName);
1478 REM virtual bool Write(FILE *, FileType);
1479 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1480 FILE *_fp, FileType type);
1481 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1482 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1483 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1484 REM virtual std::string GetEntryByName (std::string tagName);
1485 REM virtual std::string GetEntryVRByName (std::string tagName);
1486 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1487 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1488 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1490 std::string vr = "unkn",
1491 std::string fourth = "unkn",
1492 std::string name = "unkn");
1493 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1494 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1495 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1496 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1499 ADD virtual void Write(FILE *fp, FileType filetype);
1502 ADD virtual void Write(FILE *fp,FileType filetype);
1505 ADD virtual void Write(FILE *fp, FileType filetype);
1506 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1507 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1508 REM std::string GetEntryByName(TagName name);
1511 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1513 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1515 The default constructor invoked by the line
1516 gdcmHeader *f1 = new gdcmHeader( header );
1517 was gdcmHeader::gdcmHeader(bool) instead of the expected
1518 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1519 Hence the parsing wasn't executed... See also below.
1520 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1521 as explicit constructor didn't do the trick to fix the above problem.
1522 Could anyone explain why ?
1523 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1524 properly calls gdcmValEntry::Print() (that was weed out from
1525 code related to gdcmBinEntry).
1527 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1528 * In order to fix memory leaks:
1529 - Test/TestWriteSimple.cxx: added cleaning of free store through
1531 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1532 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1533 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1534 (through the call to ::AddDicomDirMeta()) or the destructor
1535 would crash when deleting uninitialized ::metaElems].
1536 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1537 - src/gdcmDocument.cxx:
1538 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1539 from dynamic stores.
1540 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1541 was causing memory leaks.
1542 - src/gdcmSQItem.cxx:
1543 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1544 cleanly handled with polymophism: sorry but my milage is low).
1545 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1546 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1547 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1548 This avoids SegFaulting.
1549 - src/gdcmSQItem.h: coding style.
1551 - Test/TestWriteSimple still severely sucks. The output image content
1552 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1553 damaged when displayed with vtkgdcmViewer.
1554 - on memory leaks: TestWriteSimple leaks really less (see entry
1555 of 2004-06-18 in Changelog file for the call to valgrind).
1556 - on segfaults: ctest now passes all the tests but one (no more
1558 * Erroneous leading white fix:
1559 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1560 white[s] (as opposed to from >> xxx, that removes it [them].
1561 - src/gdcmTS.cxx: ditto.
1562 - gdcmPython/testSuite.py: dirty related kludge removed.
1563 * src/*: remaining references to gdcmParser removed.
1564 * src/*[cxx|h]: added copy[way]left header.
1567 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * In order to fix writing of dicom files:
1569 - Test/TestWriteSimple.cxx: a simpler example of writing.
1570 - Test/CMakeLists.txt changed accordingly.
1571 - src/gdcmDocument.cxx:
1572 -- The destructor now recursilvely removes potential sequences.
1573 -- Bug fix in ::IsJPEG2000()
1574 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1575 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1577 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1578 to only declared) and build on top of
1579 ::GetDocEntryByNumber(guint16, guint16).
1580 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1581 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1582 for usage in destructor and treatement of promotion in
1583 ::ReplaceOrCreateByNumber().
1584 - src/gdcmSQItem.cxx: destructor should better handle his job.
1585 Test/TestWriteSimple now runs (or at least it DOES something).
1586 * We can now start hutting memory links. A good starting point is:
1587 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1588 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1589 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1591 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * Valgrind note: after Mathieu Malaterre teached me how to read
1593 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1595 Using gcc, you can force the STL to use malloc and to free memory as
1596 soon as possible by globally disabling memory caching.
1597 With 3.2.2 and later, you should export the environment variable
1598 GLIBCPP_FORCE_NEW before running your program.
1599 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1600 simply vanish (it is still not clear to me, whether this means that
1601 STL std::string leaks or if valgrind believes it leaks...).
1602 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1603 running bin/gdcmTests makeDicomDir):
1604 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1605 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1607 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1608 SegFaulting (I drowned in DicomDir related code when trying to
1609 understand why the list is empty...).
1610 * src/gdcmDocument.h: first BSD license header try.
1611 * Doc/License.txt added.
1613 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1614 * src/gdcmDocument.[h|cxx]:
1615 - Clean up of the Transfer related predicates. They are now all based
1616 on new method isGivenTransferSyntax, that (should) handle properly
1617 the padding problem.
1618 - general clean up, simplification, and coding style.
1619 - Specific clean up of Parse7FE0() (umproperly named actually).
1620 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1622 2004-06-14 Jean-Pierre Roux
1624 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1625 - fix the display of SQItem ordinal number
1626 - add the GetSQItemByOrdinalNumber method
1627 - remove some useless never written private methods
1629 2004-06-14 Jean-Pierre Roux
1631 - adding a constructor taking a gdcmDocEntry as an input param
1632 - ReplaceOrCreateByNumber now returns :
1633 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1634 a gdcmValEntry * if a string value is passed as a param
1636 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1637 according to the param type (no longer sets a gdcmDocEntry)
1638 - GetValEntryByNumber, GetBinEntryByNumber added
1639 - NewValEntryByNumber and NewBinEntryByNumber added
1641 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1643 - GetSQItemNumber and SetSQItemNumber added, to provide
1644 a (relative) Item identier inside a given Sequence
1645 \warning : some pb remaining around this number
1647 - AddEntry now takes the Item Number as a param
1649 - adding a constructor taking a gdcmDocEntry as an input param
1651 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * Memory leak hunt with the following command:
1653 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1654 --show-reachable=yes gdcmTests PrintDocument
1655 It looks like many (all?) leaks are due to the STL (or a bad usage
1656 of the STL. The lines producing the leaks now have a comment with
1657 a "MEMORY LEAK" tag: you can retrieve them with
1658 grep "MEMORY LEAK" src/*
1659 Here are two typical examples which I can't help fixing:
1664 char * test = "babo";
1665 name = test; //// <--- valgrind detects 960 bytes lost in
1666 //// call to std::string::operator=(char const*)
1667 name.clear(); //// Doesn't help !
1675 std::cout << "Type a bunch of characters followed by RETURN: ";
1676 getline(std::cin, line); //// <--- valgrind dectects a loss
1677 //// of 1320 bytes in call to
1678 /// std::basic_istream<>& std::getline<>
1684 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1685 * src/gdcmHeader.[cxx|h]:
1686 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1687 and related, moved away to gdcmDocument.
1688 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1689 the corresponding protected accessors of inherited class
1690 gdcmDocument, removed ! As a consequence gdcmFile had to be
1691 declared friend of class gdcmDocument (see below).
1692 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1693 - Clean up of undefined or unused methods.
1694 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1695 account the changes to gdcmHeader.h).
1696 * src/gdcmDocument.h:
1697 - gdcmFile is now a friend class (in order to take into account the
1698 changes to gdcmHeader.h).
1699 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1700 (see changes to gdcmHeader.h).
1701 - Accessors (reading on the form GetEntry*) are now public.
1702 - Clean up of undefined or unused methods.
1703 * src/gdcmDocument.cxx:
1704 - adaptation to changes to gdcmDocument.h
1705 - ::OpenFile now writes a verbose message when file cannot be opened.
1706 - some std::string properly set to VRKey
1707 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1708 references to gdcmDocument.
1709 * Test/TestFindTags.cxx: changed accordingly to above changes.
1710 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1711 cvs repository gdcmData.
1713 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1715 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1716 conflicts with gdcmValEntry::voidArea.
1717 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1718 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1719 Value representation between StringRepresentable and BinaryRepresentable.
1720 * src/gdcmDocument.cxx:
1721 - method ParseDES: proper indentation restored and usage of
1722 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1723 - method LoadDocEntry: the fingerprint left in the SetValue() of
1724 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1725 removed. Reverting to previous code segment with the proper
1726 dynamic_cast< gdcmValEntry* >.
1727 Note: this was (partially) breaking the python test suite
1728 (gdcmPython/testSuite.py) that made usage of the above
1729 fingerprint to check presence of "Pixel Data".
1730 * src/gdcmDocEntry.h: coding style.
1731 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1732 now taken into account.
1733 * gdcmPython/gdcm.i: adaptation to the new internal representation
1734 of gdcm (exit gdcmParser, hello gdcmDocument).
1735 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1737 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1738 anymore, but instead prints the loaded Python dictionary.
1739 * .... alas, the python testSuite is still broken.
1741 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1742 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1744 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1745 * src/gdcmUtil.h : export methods
1747 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1750 * Initial addition of automatic python testing
1751 * Initial addition of automatic image comparison
1753 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1754 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1755 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1757 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1758 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1759 * Test/ShowDicom.cxx : bug fix for msvc compilation
1760 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1762 2004-05-04 Jean-Pierre Roux
1763 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1764 new concepts (and new classes) :
1765 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1766 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1767 - Sequence Doc Entries (gdcmSeqEntries)
1768 a Sequence is composed of Items.
1769 Each item is a set of Doc Entries (this is recursive)
1770 The non uniqueness of the 'Dicom tag' is due to this recursivity
1771 (never taken into account)
1772 Our unability to add a new 'entry' in the header
1773 at the proper location (neither in the H-Table (map or multimap),
1774 nor in the Chained List is also due to this recursivity.
1775 Don't try, right now, to use/modify/compile these new sources :
1776 nothing is finished.
1777 We just commit all the stuff, 'as is', in order not to loose it.
1779 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1780 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1782 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1783 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1784 file prefix (SetFilePrefix)
1786 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * Add a new test: ShowDicom, for now this is just the c++ version of
1788 checkRead.sh, later it will be able to compare the image read against a
1790 * Replace the DEBUG on the stack with a global entry in cmake interface:
1791 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1793 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1794 * Add an example subdir, with a real example on how to read + write a
1797 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1799 * Doc/CMakeLists.txt: the main page is now properly differentiated
1800 between the developper and user version.
1801 * Doc/doxygen.config.in: dropped search related obsolete flags
1802 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1804 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * DEVELOPPER: added some helpfull comments for compile/test/install
1808 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1810 src directory, now generated in the build dir.
1811 2. Tests as mentionned smarter
1813 4. Add a new method in gdcmDict that return the PubDict by name
1814 this is interesting for 3rd party lib like ITK,
1815 where we could set the institution name / patient name...
1817 * ENH: 1. Now the test suite is working for real
1818 2. All binaries are now output in the gdcm-bin directory
1819 (this was not true before)
1821 2004-04-28 Jean-Pierre Roux
1822 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1823 SeQuence indented printing of Dicom Header.
1824 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1825 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1826 Computation of SQDepthLevel is now part of gdcmHeader constructor
1827 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1828 tree-like structure of a Dicom Header.
1829 * FIX Test code cleaning
1831 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * ENH: Adding automatic testing
1833 1. Need a DartConfig.cmake to submit to public
1834 2. Add a test driver gdcmTest.cxx
1835 3. gdcmTestMain, an helper for the main test driver gdcmTest
1836 4. Files in Test don't have a main anymore, this becomes interesting
1837 when we add more and more tests, thus dsw don't have to load
1839 * ENH: Adding a GDCM_DATA_ROOT for testing
1840 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1841 one file instead of seven + some small cleanup
1843 2004-04-22 Jean-Pierre Roux
1844 * ENH Minor changes to the Print() methods.
1845 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1846 Header printing. Example given with :
1847 > PrintHeader fileName 2 new
1848 (SQ based tree-like structure still to be done for the Header ...)
1850 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1852 1. I have added some unsigned where needed
1853 2. Some function parameter not used -> (void)
1854 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1855 4. g++ don't like character '\' in comment
1856 5. #define jpeg_create_decompress jCreaDecompress
1857 this really need to be fixed
1858 6. virtualize destructor of gdcmObject ... leakage
1859 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1860 this also really need to be fixed
1861 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1862 remove compression file
1863 (as we only do decompression, right ?)
1864 * ENH: Change malloc/calloc/free with c++ equivalent
1866 2004-04-21 Jean-Pierre Roux
1867 * FIX gdcmHeaderHelper::GetXSpacing
1868 when a single value is found (bug ?), xpacing is now
1869 defaulted to yspacing
1871 2004-04-19 Jean-Pierre Roux
1872 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1873 * ENH add parameters :
1874 bool exception_on_error = false,
1875 bool enable_sequences = false,
1876 bool ignore_shadow = false
1877 to the gdcmFile constructors to be full gdcmParser compliant
1878 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1879 to allow reading of PAPYRUS 3.0 files
1881 2004-04-06 Jean-Pierre Roux
1882 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1884 2004-04-02 Jean-Pierre Roux
1885 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1886 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1887 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1889 2004-03-30 Jean-Pierre Roux
1890 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1891 for ACR file, written out as DICOM files (hope so...)
1893 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1894 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1895 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1896 moved to base class gdcmParser and only the specialisation is kept
1898 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1899 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1900 already does the job.
1901 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1902 (to be consistent with gdcmParser::WriteEntries).
1904 2004-03-30 Benoit Regrain
1905 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1906 upate of the object's instance. It's passed to 2 in the unfavorable
1907 case : one in the ExecuteInformation, one in the ExecuteData
1909 2004-03-29 Jean-Pierre Roux
1910 * ENH : Check on file type to be written moved
1911 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1912 * FIX : gdcmObject::ResetBoundaries now stops properly
1913 when end-of-list is reached
1914 : gdcmVersion modified (as Benoit Regrain asked)
1916 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1918 * src/gdcmUtil.cxx: added forgotten iostream include.
1919 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1920 equivalent to ExplicitVR in existing code).
1922 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1924 now contains all the gdcmGlobal related code.
1925 * minor coding style and doxygenation changes.
1927 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1929 now contains all the Debug related code.
1930 * minor clean-up of includes in src/*.cxx
1931 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1932 CreateCleanString) removed.
1933 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1934 * Doc/DoxyMainPageUser.txt added.
1935 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1936 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1937 src/gdcmDirList.cxx)
1939 2004-03-24 Jean-Pierre Roux
1940 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1942 2004-03-23 Jean-Pierre Roux
1943 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1944 big endian made volumes
1945 * ENH Now gdcmParser constructor and destructor are protected to forbid
1946 end user to instanciate class gdcmParser
1947 (only gdcmHeader and gdcmDicomDir are meaningfull)
1949 2004-03-22 Benoit Regrain
1950 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1951 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1952 gdcmSerie to gdcmDicomDirSerie
1954 2004-03-19 Jean-Pierre Roux
1955 * ENH Now the tree-like structure describing a DICOMDIR comming from
1956 an already existing DICOMDIR file is consistent with
1957 the home-made tree-like structure build ex-nihilo
1958 or build from the files held (recursively) in a Directory
1959 functions gdcmDicomDir::CheckBoundaries()
1960 gdcmObject::SetBoundaries() added
1962 2004-03-17 Jean-Pierre Roux
1963 * REM (Eric Boix bug) : removal of meaningless
1964 gdcmDicomDirImage::NewImage function.
1965 * FIX now file names and directory name are written properly in the
1967 * FIX now gdcmDicomDir constructor may be call without any trick
1970 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1972 of gdcmDicomDirImage::NewImage as empty function.
1974 2004-02-28 Jean-Pierre Roux
1975 * ENH add gdcmDicomDir:NewPatient
1976 add gdcmDicomDirPatient:NewStudy
1977 add gdcmDicomDirStudy:NewSerie
1978 add gdcmDicomDirSerie:NewImage
1979 to allow making gdcDicomDir object.
1980 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1981 (as opposite to the gdcmHeader chained list)
1983 2004-02-11 Benoit Regrain
1984 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1985 when using from python
1987 2004-02-10 Benoit Regrain
1988 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1989 * FIX : in gdcmDicomDir when the directory is empty
1990 * ENH : add callback and methods to get the progression of dicomDir
1993 2004-02-06 Jean-Pierre Roux
1994 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1995 - GDCM_META added to gdcmDicomDirType
1996 - class gdcmMeta created
1997 * ENH : - A brief summary is now displayed at the beginning of
1998 'testDicomDir' to help disaster magnitude estimation
1999 * REM : Now useless Test/explDICOMDIR.cxx
2001 2004-02-05 Benoit Regrain
2002 * ENH : add methods in gdcmObject to get the hash table or the list of
2004 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2005 * FIX : wrapping python for TagHeaderEntryHT
2007 2004-02-04 Benoit Regrain
2008 * FIX : even length for some strings when writting the dicom dir
2009 * FIX : sort the images in the dicom dir
2010 * FIX : Bug fix for python use of dicom dir
2011 * ADD : a python demo
2013 2004-02-04 Jean-Pierre Roux
2014 * FIX : Final solution (?) for icone embedded images
2015 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2016 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2017 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2018 gdcmData/gdcm-MR-SIEMENS-16.acr1
2019 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2020 to make full checking easier
2022 2004-02-04 Benoit Regrain
2023 * FIX : WriteEntries : coding style & logic in parameters
2024 * FIX : Set the elements to create the DicomDir in a dictionary file
2026 2004-02-03 Benoit Regrain
2027 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2028 * gdcmDicomDir : add the load of directory
2029 * Bug fix and print add-on
2031 2004-02-03 Jean-Pierre Roux
2032 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2033 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2034 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2035 * FIX gdcmParser.cxx : 'group length' elements are now considered
2036 as integers, even for shadow groups, when file is Implicit VR
2038 2004-02-02 Jean-Pierre Roux
2039 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2041 of the last synonym :-(
2042 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2044 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2045 * FIX taking into account the possible 7fe0,0010 multiplicity
2046 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2047 to allow removal of references to 7fe0,0010, to deal with
2048 ACR-NEMA images, when 0028,0200 is meaningfull
2050 2004-01-31 Jean-Pierre Roux
2051 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2052 no longer writes 'Un' on disk
2053 * FIX SQ elements with actual length are now dealt with corectly
2054 * FIX gdcmFile::WriteBase make the difference, for color images, between
2055 the length (for Palette expanded images)
2056 and Raw Length (non expanded image + Palette)
2057 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2058 (that broke Write). Replaced by UL.
2059 Aware user will reload the field if he
2060 thinks it's necesssary
2062 2004-01-30 Jean-Pierre Roux
2063 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2064 when 'dirty Acr' is found, to be compliant with the new
2065 IsReadable() methods.
2067 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2068 (no DOUBLE images in kosher DICOM,
2069 but so usefull for people that miss them ;-)
2071 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2072 DICOMDIR related utilities (not checked as Windoze compliant)
2074 2004-01-28 Jean-Pierre Roux
2075 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2077 2004-01-27 Jean-Pierre Roux
2078 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2079 to allow skipping the shadow elements, to save memory space.
2080 The TRUE value for this param has to be used
2081 with a FALSE value for the 'enable_sequence' param.
2082 ('public elements' may be embedded in 'shadow Sequences')
2083 * gdcmHeader methods now deal with 'embedded icones images' in the header
2084 (even when an 'icone image sequence' is announced by the
2085 element (0x0088,0x0200), but there is NO icone at all ...
2087 * gdcmHeader sometimes Image Location value doesn't follow
2088 the supposed processor endianity (see gdcmData/cr172241.dcm).
2091 * gdcmHeader add the method
2092 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2093 to get *all* the Header Entries with the same tag.
2094 GetHeaderEntrySameName is probabely *useless*
2095 (no meaning : Name is *not* an identifier within the Dictionary)
2097 2004-01-26 Benoit Regrain
2098 * Bug fix in the print of hexadecimal representations. Remove long fields
2099 in the print and add a third level of print to print them
2101 2004-01-23 Benoit Regrain
2102 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2103 * Bug fix on test suite after remove the strip made on not string fields
2104 * Split the IsReadable method between gdcmParser which test that the file
2105 is dicom and gdcmHeader which test that it's an image file
2107 2004-01-22 Benoit Regrain
2108 * DicomDir : clean code, add methods, set variables in protected or private
2109 * gdcmUtil : bug fix for the clean string method
2111 2004-01-19 Benoit Regrain
2112 * Add the use of shadow dictionaries
2113 * bug fix and coding style
2115 2004-01-19 Benoit Regrain
2116 * src/gdcmFile.cxx : bug fix concerning the close of file
2117 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2118 * Add the update of header entries using the shadow library
2120 2004-01-19 Benoit Regrain
2121 * removal of file gdcmHeader2.cxx
2122 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2123 inheriting from gdcmParser. This split is to prepare the integration
2124 of dicom dir parsing
2125 * bug fix under python
2127 2004-01-16 Jean-Pierre Roux
2128 * REM removal of class gdcmHeaderEntrySet
2129 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2130 * ADD add file gdcmHeader2.cxx
2131 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2133 2004-01-15 Benoit Regrain
2134 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2135 entries created while parsing the header. Thus, they will be destroyed
2136 when the gdcmDictSet will be destroyed
2137 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2140 2004-01-15 Benoit Regrain
2141 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2142 made a fatal error because of the memory release at the end of program.
2143 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2144 some memory and vtk seems to have some problems with that.
2145 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2147 2004-01-14 Benoit Regrain
2148 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2149 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2150 * src/*.[h|cxx] : make changes due to class name changes
2151 * gdcmPython/demo/*.py : bug fix due to method names
2153 2004-01-13 Benoit Regrain
2154 * src/*.[h|cxx] : coding style
2155 * vtk/*.[h|cxx] : coding style
2157 2004-01-13 Benoit Regrain
2158 * gdcmPython/testSuite.py : test the readable flag of file for tests
2159 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2160 It's lied to the stl compilation by MSVC (windows, always windows...)
2161 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2163 2004-01-12 Benoit Regrain
2164 * src/*.h : add comments
2165 * src/gdcmDictSet.h : set the method BuildDictPath in public
2166 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2167 directly setted in the source code
2168 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2171 2004-01-09 Benoit Regrain
2172 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2173 * setup.py : use a reference to gdcmVERSION
2175 2004-01-07 Benoit Regrain
2176 * Modification to compile with the distutils.
2179 2003-12-10 Benoit Regrain
2180 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2181 can use a gdcmHeaderHelper to load data
2182 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2183 made in the source code
2185 2003-12-10 Benoit Regrain
2186 * Update Windows projects and .cvsignore files
2188 2003-11-12 Jean-Pierre Roux
2189 * ENH gdcmHeader constructor has one more parameter (default value : false)
2190 that allows the user to 'go inside' the SeQuences only
2192 gdcmElValSet:Print takes it into account
2194 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2195 * ENH: Update gdcmPython/CMakeLists
2196 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2197 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2199 2003-11-10 Jean-Pierre Roux
2200 * FIX : gdcmHeader::LoadElements is now based
2201 on the ListTag listElem member,
2202 not longer on the TagElValueHT tagHt member
2203 * ENH : PrintPubElVal shows (temporarily) both results,
2204 with the tagHt member and the listElem member.
2205 (it's easier to 'see' the problems when using Printheader)
2207 * FIX : old private member LgrElem is now splitted into
2208 ReadLength : Length actually found on disk (updated only
2209 if bug fixing is necessary), for internal
2211 UsableLength : Updated by FixFoundLength, to fix a bug
2212 or to allow Parser going on.
2213 Will allow to re-write a kosher header when a SeQuence
2214 with a length (not 0000) is found
2215 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2216 because gdcmElValSet::Add does not update ListElem
2219 2003-11-07 Jean-Pierre Roux
2220 * FIX misstyping in Transfert Syntax name table
2221 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2222 when they have an actual length (not 0000 nor FFFFF)
2223 (Nobody should care of it, but DICOMDIR explorers)
2225 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2228 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * ENH: vtkGdcmReader now supports LUT !
2230 (vtkgdcmViewer for now is not able to use them though)
2232 2003-11-05 Jean-Pierre Roux
2233 * in testSuite.py : new files names for checking the package
2234 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2235 that returns the pixel area size to the *aware* (vtk) user
2236 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2238 2003-11-05 Benoit Regrain
2239 * in testSuite.py : Modify the rules for checking the paths
2240 : Explicit error messages
2241 * in __init__.py : Related modif
2243 2003-11-03 Jean-Pierre Roux
2244 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2245 to be used by aware (vtk) users that want to manage
2246 LUT (and no to turn the PALETTE image into an RGB pixels one)
2247 * GetPixelType now returns 8U for 24 Bits images
2248 (vtkGdcmReader compliant)
2250 2003-10-31 Jean-Pierre Roux
2251 * Removal of *all* gdcmData images and add them again
2252 in order to loose the 'history' of un-anonymised images
2254 2003-10-31 Jean-Pierre Roux
2255 * RMV : removal of useless jBitsInJsample.h
2256 for both 8 and 12 Bits JPEG Lossy Libraries
2258 2003-10-31 Jean-Pierre Roux
2259 * ENH : Add the functions gdcmFile::GetImageDataRaw
2260 gdcmFile::GetImageDataIntoVectorRaw
2261 that act as GetImageData and GetImageDataIntoVector
2262 except the making of an RGB Plane from Gray Plane + LUT
2263 Intended to aware (vtk) users who know how to manage
2266 GetLUTRGBA return a R,G,B,A LUT if any
2267 lgrTotaleRaw gives the 'Raw' length
2268 GetImageDataRaw returns the gray Plane
2269 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2270 (They stay Grey, just like with other Dicom viewers :-(
2272 2003-10-30 Jean-Pierre Roux
2273 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2275 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2276 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2277 being coherents dicom files.
2279 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2280 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2282 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2283 * ENH: Two steps is necessary to please VC++ compiler...
2284 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2285 * ENH: Add include dir to medcon lib
2286 * FIX: only one function is being exported for now !
2287 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2289 2003-10-29 Jean-Pierre Roux
2290 * adding gdcmHeader::GetLUTRGBA
2291 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2292 --> Mathieu, the modif u're waiting for is not yet committed
2293 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2295 2003-10-27 Jean-Pierre Roux
2296 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2297 00191113.dcm DermaColorLossLess.dcm
2298 MxTwinLossLess.dcm RadBWLossLess.dcm
2299 * ENH: For version prior to vtkImageViewer2 -r 1.19
2300 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2302 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * Removal of ido stuff in CMakeLists.txt
2305 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2306 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2307 * FIX: remove a call to ->Modified ... see comments
2308 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2310 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * FIX: Problem with path for libvtkgdcmPython
2312 * ENH: Try adding a search script for python site-package
2313 * RMV: Remove some file from medcon lib that are not necessary
2314 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2315 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2316 * FIX: More pragma disable fro VC++,
2317 I don't think I break something as it is also disable in VTK/ITK.
2318 But it fasten debug compilation time.
2320 2003-10-23 Jean-Pierre Roux
2321 * gdcm now deals with 16 Bits Run Length Encoded images
2322 (they are compressed as 2 planes images,
2323 one for the high Bytes, the other for low Bytes)
2325 2003-10-22 Jean-Pierre Roux
2326 * Now CheckRead takes into account :
2327 - the bugged 'Leonardo' Siemens images
2328 - the XA images, sent thru the burning VPRO station
2329 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2332 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2333 * FIX: When copying a Makefile.am to CMakeLists.txt
2334 one should remove the '\'
2336 2003-10-22 Jean-Pierre Roux
2337 * in gdcmData adding a bugged 'Leonardo' Siemens image
2338 (wrong lengths in header)
2339 OK with gdcm, KO with the other viewers :-)
2340 * add a GE dlx XA image, thru the VEPRO burning station
2343 2003-10-21 Jean-Pierre Roux
2344 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2345 for a brutal checking of vtkgdcmViewer compliance
2347 2003-10-21 Jean-Pierre Roux
2348 * add the files for 'xmedcon' Jpeg Lossless library
2349 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2351 2003-10-21 Jean-Pierre Roux
2352 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2354 2003-10-21 Jean-Pierre Roux
2355 * garbage Siemens 'Leonardo' images dealt with
2356 (the patch is easy to remove)
2357 * cosmetic changes to avoid warnings
2359 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2360 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2361 no need to press 'r' now.
2363 2003-10-20 Jean-Pierre Roux
2364 * upgrade of checkRead.sh checkWrite.sh according
2365 to new Jpeg Lossless decompressor
2366 * add US.3405.1.dcm, a genuine RGB medical file ...
2367 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2368 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2370 2003-10-15 Jean-Pierre Roux
2371 * general anonymisation in gdcmData
2372 * adding the 'color files' from
2373 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2374 * adding some well knowed bugged-header images
2375 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2376 waiting for their inclusion in Python testsuite
2378 2003-10-15 Jean-Pierre Roux
2379 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2380 no longer seg faults when file is not found
2382 2003-10-14 Jean-Pierre Roux
2383 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2386 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2387 * TODO: *.in file to genereate a UseGDCM later
2389 2003-10-14 Jean-Pierre Roux
2390 * Some supposed-to-be Dicom Images have no preamble.
2391 OpenFile takes it into account
2392 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2393 * Missing elements added in dicomV3.dic
2394 (just to be affraid : have a look at
2395 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2396 and do it again next year ;->
2398 2003-10-13 Jean-Pierre Roux
2399 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2400 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2401 But there are NOT. It's fixed !
2403 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * FIX: "jpeglib.h" was not found on VC++
2405 * FIX: vtkgdcm was not being installed
2407 2003-10-10 Jean-Pierre Roux
2408 * ENH : OpenFile closes the file if it *really* doesn't look like
2409 an ACR-NEMA / DICOM one.
2410 * FIX : testWrite no longer writes an empty file if the source file
2411 is not gdcm Readable
2412 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2415 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * FIX: CMake generate now documentation
2417 * ENH: out of source doc build !
2418 * ENH: Generate both user and dev documentation
2419 * ENH: Should work on windows too
2420 * ENH: Only one doxygen config.in file is needed
2421 * FIX: make install should be ok now on ùnix plateform
2422 * FIX: PATH to dictionary was wrong (missing /)
2423 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2425 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2426 * vtkGdcmReader is now able to read rgb dicom file.
2427 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2428 * added a gdcmViewer to vtk test, use mouse to control
2429 window level & window width
2431 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * CMake-ification of gdcm, we have now two build system
2433 * FIX: on cygwin Wsock32 doesn't exist
2434 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2436 2003-10-06 Emanuel Ollart
2437 * FIX : compilation process wad broken.
2438 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2440 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2441 * change gdcmViewer -> vtkgdcmViewer
2442 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2444 2003-10-06 Jean-Pierre Roux
2445 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2446 ( e.g : well known GE images with a wrong elem length,
2447 : Philips MRI Images with a wrong Huffman table)
2448 * still to be done : allow the reading of bugged LEONARDO Siemens images
2450 2003-10-03 Jean-Pierre Roux
2451 * Odd length strings are padded with '\0' (not with spaces,
2452 to remain compliant with already defined strings,
2453 like Transfert Syntax UID and others)
2455 2003-10-03 Jean-Pierre Roux
2456 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2457 to allow displaying RGB images (not only by affim ;-)
2459 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2460 * vtkGdcmReader is now able to read rgb dicom file.
2461 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2463 2003-10-03 Jean-Pierre Roux
2464 * A few nasty patches to allow the reading of a lot of nasty images
2465 ( e.g : well known GE images with a wrong elem length,
2466 : Philips MRI Images with a wrong Huffman table)
2467 * still to be done : allow the reading of bugged LEONARDO Siemens images
2469 2003-10-03 Jean-Pierre Roux
2470 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2472 2003-10-03 Jean-Pierre Roux
2473 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2474 to allow displaying RGB images (not only by affim ;-)
2476 2003-10-03 Jean-Pierre Roux
2477 * gdcmFile::GetImageDataIntoVector now
2478 - deals with MultiFrames MultiFragments Run Length Encoded files
2479 - deals with YcBcR (YBR_FULL) files
2480 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2481 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2483 (no sample found :-(
2485 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2486 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2487 Two reasons: - clear things
2488 - third parties acces gdcm through header files, so won't
2489 suffer anymore VC++ complains
2491 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2492 * add argv[1] in testvtkGdcmReader.cxx
2495 2003-09-24 Jean-Pierre Roux
2496 * The lines are now eigthy characters long.for
2497 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2499 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2500 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2501 char* to std::string. Thus, the use of strdup becomes useless. (see
2502 previous commis of Malaterre)
2503 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2504 before the last Malaterre's commit.
2506 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * This commit should fix the Debug building under VC++, the problem
2508 was mainly a mixture of debug and release lib being loaded at startup.
2509 * I also remove a depency to a specific C function: strdup. Because I had
2510 to force the link to msvcrtd (whereas strdup is in libc).
2512 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2513 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2514 located in the gdcmCommon.h file. All use of reference of tha has been
2515 changed to now use the variable GDCM_UNFOUND.
2517 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2519 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2520 Dicom dictionary. The test suite can now be run again. Note:
2521 I'm note very happy with the " (RET)" changes. I believe this
2522 RETAINED comment should be dropped when parsing the dictionary.
2523 - PACKAGER corrected
2525 - AUTHORS updated and now in alphabetical order
2526 * Makefile.am now exports gdcm.dsw for Windoze users.
2528 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2529 * cygwin complains about missing std:: in subdir Test/
2531 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2532 * remove some methods that are now in gdcmHeaderHelper
2534 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2535 * vtkGdcmReader set spacing and origin correctly
2537 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * Fix a few delete/delete[] mismatch
2540 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2541 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2542 interpretation to data given by gdcmHeader. For instance there are
2543 heuristics to get informations (look at different places).
2544 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2545 sorting DICOM images based on different strategies.
2546 * modified Makefiles accordingly.
2548 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2550 when building in debug mode
2551 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2552 src/win32/gdcmdll.dsp
2553 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2555 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2556 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2559 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2560 * src/win32/libgdcmjpeg12.dsp was not dos format
2561 * src/win32/libgdcmjpeg12.dsp :
2562 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2563 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2565 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2566 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2568 * src/gdcmFile.cxx : bug fix in affectation type
2569 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2570 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2571 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2572 symbols... future problem ?
2574 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2575 * src/win32/libgdcmijpeg12.dsp was missing
2576 * modified gdcm.dsw accordingly
2578 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2579 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2581 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2582 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2583 commit of JPR (before his hollidays to facilitate our work).
2584 * setup.py : bug fix in code. Modifications made while the last commit
2585 of JPR. The code hasn't been tested before the commit... it's so
2586 useless to make that (for best programmer that is JPR) !!!
2588 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * tagged the current version as Version0_3 (i.e. version 0.3)
2591 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2593 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2594 * *.dsp : modifications to use new libgdcmijpeg8 library
2595 * setup.py : bug fix on VTKPATH variable
2596 * PACKAGER : adding all concerning windows
2598 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2599 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2601 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2602 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2603 test suite reported error.
2604 * PACKAGER file added (describes what a packager must do when
2605 packaging a new release).
2606 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2607 * configure.in: upgraded version number to 0.3.0
2608 * fixing build of rpm (through rpm -ta):
2609 - Doc/Makefile.am exports proper doxygen files
2610 - src/jpeg/libijg8/Makefile.am exports the include files.
2612 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2613 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2614 * src/gdcmHeader.h : formatting code
2616 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2618 We were obtaining error message from vtk. Now, creation of file list
2619 is made in an internal list to prevent this problem.
2620 Bug fix when output is empty.
2621 Bug fix in update of progress value. Previous commit for this was a bad
2623 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2625 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2626 * src/gdcmHeader.h : added method to get the file name
2627 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2628 files. Added method to remove all files on the input
2629 Added FIXME comment concerning the bad parsing of header made by
2630 ExecuteInformation method (in ExecuteData method)
2632 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2634 when using make instal.
2635 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2636 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2638 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2639 * setup.py : adding include dir of jpeg lib to compile all sources
2640 * */Win32/*.dsp : JPR fix for windows compilation
2642 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2643 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2645 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2646 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2648 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * setup.py is again effective on un*x (takes into account the
2650 addon of the jpeg library)
2651 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2652 * Doc/Doxy* updated (includes above enhancements)
2653 * INSTALL now points to web documentation
2655 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * src/gdcmHeader.h doesn't make unnecessary reference to
2658 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2660 * src/gdcm*.[cxx|h] :
2661 - to allow compilation with gcc 3.x
2662 -- clean up of STL usage (added explicit usage of std::)
2663 -- small fixes on exceptions.
2664 Note: linking not tested !
2665 - clean of doxygen comments to avoid warnings at documentation
2667 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2668 dependent convertion).
2670 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * Clean up of previous JPR garbage commit (not even commented in the
2673 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2674 - moved all jpeg related files from src to src/jpeg/libijg8, with
2675 addition/modification of Makefile.am and configure.in.
2676 - the testSuite is still brain damage (not guilty).
2678 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2679 * WrapVTK.py : modifications to get correctly vtk source files to
2681 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2682 (FileName -> Filename)
2684 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * vtk/vtkGdcmReader.[cxx/h]:
2686 - UpdateProgress method should now be effective
2687 - removed the limitation on having only images loaded (as opposed
2689 - when building a stack of images/volume, a lesser number of
2690 gdcmHeader and gdcmFile instances should be used (hopefully
2691 accelerating things).
2692 - when building a stack of images/volumes, files which are not
2693 loadable (wrong path-filename, wrong permissions on existing file,
2694 or file not parsable by gdcm) are replaced with a black image
2695 in the stack (for the caller to notice the problem).
2697 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2700 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2701 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2702 between standard library (std) and vtk library (problems are found
2703 under Windows... thanks Windows !)
2705 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2708 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2710 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2713 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * When compiling with distutils (see setup.py) the C++ compiler is
2715 called with different flags than the default ones (with automake).
2716 In order to fix all those warning, I compiled gdcm with the command
2717 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2718 and went for warning fixes:
2719 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2720 up from unused variables.
2721 - vtk/vtkGdcmReader.cxx: potential bug fix.
2722 * src/gdcmHeader.h: Doxygen warning cleanup
2724 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * gdcmPython/gdcm.i:
2726 - typemaps correction to take into account the systematic replacement
2727 of "using namespace std" with std:: prefix e.g. std::list,
2728 std::string... (cf changes of 2003-05-21).
2729 - gdcmGlob global variable of type gdcmGlobal (defined in
2730 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2731 exported to Python a as cvar.
2732 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2733 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2734 gdcmDictSet.GetPubDictTagNames() and
2735 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2736 C++ static methods).
2737 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2738 with the above changes.
2740 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2741 * setup.py, manifest.in : bug fix under linux
2743 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2744 * Modification of setup.py to compile vtk part too. Then, we have 2
2745 wrappers which must work with same distutils. For that, we have a
2746 generic distutils in distusiltsWrapping.py ; with :
2747 - build_extWrap class to wrap generically all extensions,
2748 - ExtensionWrap base class for all wrapping extension that contains
2750 - Wrapper interface which wrap sources
2751 + In WrapSwig.py we have extension and wrapper for Swig
2752 + In WrapVTK.py we have extension and wrapper for VTK
2753 * MANIFEST.in : modifications to consider vtk directory and new python
2754 files for compilation
2756 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2757 * Added python wrappers of vtkGdcmReader vtk class (see the
2758 source in vtk/vtkGdcmReader.cxx) :
2759 - vtk/Makefile.am now builds a library
2760 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2761 python library (as opposed to _gdcm.so wich are the python
2762 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2763 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2765 - configure.in has an additional flag --enable-vtk that needs
2766 to be set to enable compilation of vtk related code, that is:
2767 + vtk/vtkGdcmReader.so and
2768 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2769 + gdcmPython/vtkgdcmPython.so (see above)
2770 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2771 be read when compressed or when HighBit + 1 != BitsStored),
2772 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2773 the usage of the python wrapper of vtkGdcmReader vtk class.
2774 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2775 * src/*.[h] all occurences of stl classes are now prefixed with
2776 std::, and all occurences of "using namespace std;" where removed.
2777 This is to avoid pollution of global namespace in included files.
2778 Apparently vtk does not avoid this pitfall: when using both
2779 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2780 collision of various stl members (principally cout...).
2781 * gdcmPython/testSuite.py now cleanly removes temprory generated
2783 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2784 comply with above changes)
2786 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2787 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2788 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2789 vtk data structure (an image Flip was required).
2790 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2791 * cosmetic changes in documentation.
2793 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2794 * src/gdcmHeader.cxx: the constructor no longer exits when an
2795 unexisting file is given as argument.
2796 * The subdirectory Data (containing all the images used for the
2797 test suite) is not part of this repository anymore. A new module
2798 containing those images is now available at
2799 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2800 with the name gdcmData.
2801 All the python scripts (including the package initialisation file
2802 gdcmPython/__init__.py) were adapated to take this change into
2803 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2805 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2806 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2807 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2808 demo of the usage of this class.
2809 Compilation of this vtk part is only done when using the --enable-vtk
2810 at configure (or autogen.sh) stage.
2812 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2813 * More memory link related corrections and documentation fixes.
2815 - maximum info is obtained with a command of the form:
2816 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2817 --show-reachable=yes PrintHeader
2818 - the remaining reachable blocks seem to come from the STL
2819 allocation scheme through the usage of map and list. It looks
2820 like this memory cannot be freed but it is not a memory leak
2821 (in fact further invocation to the STL would recollect the
2822 unused memory allthough it cannot explicitely be freed).
2823 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2824 of displaying an image parsed with gdcm and displayed with VTK.
2825 Note: some images don't seem to work e.g.
2826 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2827 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2828 Allthough this weakens the semantics, it is a ditch attempt to
2829 make gdcm more thread friendly.
2831 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2832 * Memory link hunt (by using valgrind through the command
2833 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2834 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2835 gdcmHeader::_dicom_vr.
2836 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2837 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2839 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2841 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2842 * src/Makefile.am now exports all the necessary include files at
2846 * UpdateGroupLength replaced by new one
2849 * UpdateGroupLength re-written using H-Table
2850 (named UpdateGroupLengthNew untill checks are over)
2852 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2853 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2854 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2856 - gdcmHeader::GetPubElValSet removed.
2857 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2858 UpdateGroupLength, WriteElements, Write.
2859 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2860 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2861 carried the same semantics.
2862 - src/gdcmHeaderIdo.cxx changed accordingly.
2863 - gdcmFile::WriteBase now regroups all the codes from previous
2864 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2865 - enum FileType moved to gdcmCommon.h
2866 * src/gdcmHeader.cxx AddDefault trashed
2867 * gdcmGetXSize added
2868 * getimageDataSize now calls gdcmGetXSize
2869 * Test/*.cxx changed to agree with above changes
2871 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2873 (to avoid double call by end user).
2874 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2875 by end user, since gdcmHeader::gdcmHeader now handles it.
2877 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2878 * gdcm/Doc many doxygen changes:
2879 - Doxyfile now has two different versions, DoxyfileUsers that generates
2880 the html.users end users oriented documentation and
2881 DoxyfileDeveloppers that generates the html.developper developper
2882 oriented documentation.
2883 - README changed accordingly
2884 - requirement.txt removed (old design info moved to TODO).
2885 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2886 DoxyMainPage.txt, DoxyPython.txt provide more information.
2887 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2888 be updated by simply regenerating the docs with doxygen and copying
2889 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2890 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2891 all the tests in the form "if (<map>.count() >1)" were removed.
2892 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2893 ill-formed documentation sections.
2894 * src/gdcmHeader.cxx: ditto
2896 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2897 * setup.py fixed for un*x (needed macro for stdint.h)
2898 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2899 un*ces with sh-utils test utility.
2900 * gdcmPython/demo/test.py renamed to PrintHeader.py
2901 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2902 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2903 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2904 * src/gdcm*.cxx JPR's bad inclusion fixed.
2906 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2908 * gdcmPython/demo/test.py changed accordingly.
2910 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * gdcmPython/Makefile.am fixed linking against libstdc++
2912 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2913 * Swig subdir (historical tests of swig version 1.3.17++) removed
2914 * Test/testChangeEntete.cxx some lines commented out in order to make
2916 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2917 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2919 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2921 hence the user doesn't need this explicit call.
2922 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2923 i.e. LoadElements() call removed.
2924 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2925 - src/Makefile.am declares the proper flag for g++.
2926 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2927 for adding user defined new tags.
2928 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2929 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2930 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2932 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2933 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2934 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2935 src/Makefile.am : the project should properly compile and install
2936 with the autotools, included the python wrappers part.
2937 * gdcm.spec.in : added a spec file for RPM packaging.
2939 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2940 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2942 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2944 to exported to the environement (see gdcmPython/testSuite.py
2946 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2947 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2948 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2949 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2950 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2952 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * gdcmPython/__init__.py doesn't crash anymore when running in
2954 in InstallMode or PreInstallMode but with an environment given
2955 value of GDCM_DICT_PATH.
2956 * src/gdcmDictSet.[cxx/h] coding style.
2958 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2960 * src/gdcm.h general comments moved to TODO, and README
2961 * src/gdcm.h should now be seen as a user commodity (including it
2962 should suffice to fully use gdcm). It is nowhere including within
2963 any of the kernel files src/*.cxx and src/*.h.
2965 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2966 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2967 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2969 * src/gdcm*.cxx only include their corresponding include file
2970 (as opposed to gdcm.h)
2971 * gdcmPython/gdcm.i changed accordingly
2972 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2973 the autogen.sh generated "make snapshot" command to work.
2974 * autogen.sh removed history related references to crea package.
2976 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2977 * distutilsSwigCPlusPlus.py work around some swig portability
2980 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2982 was done in a last ditch attempt to get setup.py _really_
2983 operationnal. The python/gdcmPython layaout add the advantage
2984 of hidding away the python related distutils specific files
2985 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2986 Alas, the src directory was out of scope (i.e. it's relative
2987 position to setup.py was ../src) which made things impossible to
2988 handle (see previous version of python/setup.py). Crossing fingers...
2990 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2991 * python/setup.py now works on Un*x. (harder than I thougth)
2992 * python/distutilsSwigCPlusPlus.py can now have include files
2993 among the list of sources.
2995 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2996 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2997 * modifications in MSVC projects
2999 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * As stated by the first lines of Test/ExceptionAndPython/README, it
3001 looks like we can move back to original usage of exception within
3002 src/gdcm* and hence remove the errno stuff that was introduced
3003 as a quick and dirty fixture of this problem (added to the TODO).
3004 * Doc/Doxyfile configuration file for Doxygen and corresponding
3005 README file for usage added.
3006 * Test/testWrite.cxx added. This new test comes from a split of
3007 test.cxx that is now reverted to its original purpous i.e.
3008 testing the proper parsing of a Dicom related file.
3009 testWrite.cxx concentrates on testing the IO part of gdcm.
3010 * Test/bug1.cxx (containing a bug on WIn32) added.
3011 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3012 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3013 whose purpose is to publish the content of the TagNames of the
3014 Dicom public dictionary were not accessible without an
3015 instance of class gdcmHeader.
3016 - those methods are now static methods of gdcmDictSet and hence
3017 require no instances at all to be invocated.
3018 - within gdcmDictSet this change required to change some method
3019 to class methods (i.e. are now static) among which SetDictPath
3020 (renamed to BuildDictPath) and LoadDefaultPubDict.
3021 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3022 the above changes by calling the new method classes of gdcmDictSet.
3023 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3024 the above to be effective.
3025 * python/gdcmPython: in order to wrap properly the above changes
3026 for Python, swig version now needs to be > 1.3.17.
3027 * python/gdcmPython/Makefile fixed to adapt itself to new
3028 configure/make shema introduced by Johan Montagnat (thanks for the
3029 contribution). Alas this Makefile cannot be turned into a proper
3030 Makefile.am without some heavy changes in the configure.in
3031 (for python dectection).
3032 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3033 now avoids publishing the empty entries.
3035 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3036 * python/setup.py : bug fix concerning install under windows
3037 ExtraPath reused :-P
3038 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3040 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3041 * Dicts/dicomV3.dic : remove double spaces !!!
3042 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3043 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3046 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3047 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3048 method. Doxygenation.
3049 * src/gdcm.h clean up of JPR spurious comments.
3051 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * python/distutilsSwigCPlusPlus.py now properly collects the
3053 shadow classes generated by "swig -c++" (gdcm.py in our case)
3054 when using "python setup.py install".
3055 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3056 reexports the working classes.
3057 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3058 by the classical C errno scheme. This is to prevent an obscure
3059 behavior of the python wrappers when importing wxPython.wx prior
3060 to gdcmPython (which ended up in an abort call). An illustration
3061 of this oddity can be found in the Test/ExceptionAndPython
3062 subdir (see the README file). This problem probably due to
3063 an combination of g++ and dynamic loading.
3064 * added Test/ExceptionAndPython (see above)
3066 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * Changed the layout of the python part to avoid bloating main
3068 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3069 i.e. the distutils arsenal. All the python related stuff is
3070 again in a python subdir, but the package itself is now in
3072 * setup.py was cleaned up:
3073 - pythonIncludePath removed
3074 - python setup.py bdist target is now functional.
3075 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3076 collision with other packages). gdcmPython/demo/*.py changed
3079 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3080 * python subdir moved to gdcmPython (preparation of distutils packaging).
3081 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3082 distutils installer is operational.
3083 * - gdcmPython/__init__.py now properly loads the swig generated
3084 shadow classes (from gdcm.py).
3085 - gdcmPython/demo/*.py changed to import the package gdcmPython
3086 instead of gdcmPython/demo/load.py.
3087 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3089 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3090 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3091 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3092 entries within the associated public Dicom dictionary resp. the same
3093 information but sorted by the fourth field (PAT, IMG, DIR) of the
3095 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3096 are now in the "???" group.
3097 - python/gdcm.i changed accordingly,
3098 - python/demo/printGroupedPublicDict.py added, that gives an example
3099 of the above new functionalities in Python.
3101 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3102 * src/gdcm.h, gdcmHeader.cxx:
3103 - historic references to glib's g_malloc and g_free (#defined)
3104 were definitively removed.
3105 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3106 * src/gdcmElValSet.cxx:
3107 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3108 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3109 - GetElValue(string) renamed to GetElValueByName.
3110 - Added GetElementByName(string).
3111 * src/gdcmHeader.cxx: added
3112 - GetPubElValRepByNumber(guint16, guint16)
3113 - GetPubElValRepByName(string)
3114 - GetShaElValRepByNumber(guint16, guint16)
3115 - GetShaElValRepByName(string)
3116 - GetShaElValByNumber(guint16, guint16)
3117 - GetShaElValRepByName(string)
3118 - GetElValRepByNumber(guint16, guint16)
3119 - GetElValRepByName(string)
3120 - GetElValByNumber(guint16, guint16)
3121 - GetElValRepByName(string)
3122 * Doc/requirements.txt added.
3124 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * Test/Makefile building now depends on the one of libgdcm.so
3126 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3127 pixel data) aware which enables finding the address (offset) of
3128 the pixel data of JPEG encoded DICOM files. This leaves only a single
3129 file in the testSuite whose pixel data address (offset) is unknown.
3130 * python/testSuite.py changed accordingly.
3132 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3133 * VC++ has some strong limitations when working with the STL, as stated
3134 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3135 "Also note that some STL containers (map, set, queue, list, deque)
3136 cannot be exported. [...]
3137 Some STL classes contain nested classes. These classes can not
3139 This is caused by a designed limitation that once a template
3140 class is instantiated, it can not be re-instantiated and
3142 Since our usage of map<> is ubiquitous in gdcm, this "designed
3143 limitation" of VC++ is a pitfall.
3144 Hence the Python wrappers of gdcm cannot be incrementally linked
3145 against the c++ dynamic library. The dirty but only workaround is
3146 to forget about incremental link of dynamic libraries and to generate
3147 the Python wrappers library with the inclusions of the underlying C++
3149 The following modifications concern this matter on Win32/VC++:
3150 - wrapping python correct with standalone wrapped dll (don't use separate
3151 dll under windows !!!!)
3152 - python21_d debug mode enabled (ask Frog how to use it :-)
3153 - NO problem with having an STL member of class for example string in C++
3154 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3155 - Python test of dcmlib in Python is ok under windows on a large set
3157 * removed glib references
3158 * typedef's inserted in gdcm.i for correct swig type management
3160 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * python/demo/*.py load.py extracted from test.py. Added explore.py
3162 that only displays required tags and testAll.py that parses all
3163 the files of the testsuite without using unittest.
3164 * python/testSuite.py other additional test on new files added.
3165 * Data/* new test files added accordingly to the testSuite.
3166 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3167 the vr in the file differs from the one of the dictionary.
3169 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3170 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3171 values, but limits itself to values which are below a user specified
3172 size (by default 1024 bytes).
3173 * python/gdcm.i : elements not loaded (because their size is above the
3174 user specified treshold) are exported with their TagKey as key of the
3175 python dictionary. This enables the testsuite to make some checks
3176 on the unloaded elements (since we have their offset and size).
3177 * python/testSuite.py
3178 - now tests for the existence and proper value of the pixel data
3179 - two new examples added.
3180 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3182 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3183 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3184 aware. See the strategy comments in gdcmHeader::FindeLength().
3185 * Test/test.cxx now accepts a filename as first argument.
3186 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3187 * python/testSuite.py changed to integrate test on above files.
3189 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3190 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3191 the vr was also RET.
3192 * python/testSuite.py more tests added.
3194 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3195 * python/testSuite.py unittest test suite added (uses Data)
3196 * Data/* dcm and acr files for the test suite.
3197 * glib dependance removed from un*x version. We now use ISO C99
3198 7.18 Integer types (see stdint.h)
3199 - python/Makefile, src/Makefile src/gdcm.h
3200 * src/ when an explicit vr (like dicom files) suddenly poped an
3201 implicit element we use to mark the underlying DictEntry of the
3202 concerned ElValue with "Implicit". This strategy was damageable
3203 too the public or provite dictionaries, since some of their vr
3204 would be changed. Since Header::FindLength heavily relies on the
3205 detection by Header::FindVR of falsely explicit elements, I
3206 added an extra ImplicitVr member to ElValue (boolean).
3207 The rest of the changes we the necessary adaptations.
3209 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3210 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3212 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3214 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3215 * Adaptation for porting to VC++:
3217 o forced to use std namespace (for string to be known)
3218 o all class use __declspec export style on WIN32
3219 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3220 (in stdlib.h on Win32 but in std:: for gcc)
3221 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3222 variable GDCM_DICT_PATH.
3223 * src/gdcmHeader.cxx verbose comments made discrete.
3225 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3226 * python/gdcm.i: added a typemap that converts a C++ hashing table
3227 to native Python dictionary.
3228 * python/demo/test.py:
3229 - now uses the native dictionary for exploration of gdcmHeader.
3230 - takes an optional filename argument (the file to parse).
3231 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3232 PubElVals hashing table.
3233 * Dicts/dicomV3.dic removed error prone trailing spaces.
3235 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3236 * Python wrapping process moved away from src/Makefile to
3237 newly created python/Makefile (as well as gdcm.i)
3238 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3239 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3240 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3241 from the environement variable GDCM_DICT_PATH (when existing).
3242 * src/gdcmDict::GetTag bug fix.
3244 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3245 * Straightforward temporary fixes for swig to build the python wrappers.
3246 src/Makefile now has a python working entry [by working we mean
3247 that we can import de shadow classes without errors].
3249 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3250 * hashtest.cxx removed (since already in Test)
3251 * src/gdcmlib.h renamed to src/gdcm.h
3252 * src/dcm.i renamed to src/gdcm.i
3253 * src/Makefile prepared for python wrapping
3255 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * src/gdcmHeader.cxx :
3257 - Parsing of header is now separated from loading of element values
3258 (see gdcmHeader::LoadElements).
3259 - general clean up of hopefully all file access (creation of
3260 ReadInt16 and ReadInt32)
3262 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * src/gdcmHeader.cxx :
3264 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3266 - SetLgrElem renamed to SetLength
3267 - GetLgrElem renamed to GetLength
3268 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3269 * src/gdcmElValSet.cxx fixed both GetElValue methods
3270 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3271 due to IdoDude was cleaned out.
3273 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3275 concentrates on finding the value representation (when it exists).
3276 RecupLgr now only finds the element value length, and it avoids
3277 returning the unecessary skL (skipped length).
3278 Also, offsetCourant was simply removed (with taille_fich) since
3279 it was redundant with the File position internals (by using
3280 ftell and fseek). This also made skL (see above in RecupLgr) usage
3282 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3283 on the libido specificities which are handled through class
3285 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3288 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3289 * Truckload of changes. Parsing of header is barely functional
3290 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3292 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3293 * src/gdcmHeader.cxx many addons of low level methods
3295 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3296 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3297 and _IdDcmSWAP_LONG.
3299 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3300 * This corresponds to all the changes decided at the meeting of
3301 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob