1 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 *FIX SQItem::AddEntry inserts now *in the right place* any Entry
3 (Dicom Element) into the Sequence Item
5 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/*.cxx : first parss to normalize file organisation
8 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmDirList.[h|cxx] : add method to find a directory
10 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
12 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Finish cleaning up my JPEG mess. Should be ok now.
14 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
15 contained within the RLE* class(doh!)
17 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
18 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
19 * SerieHeader::AddFileName() creates as many Coherent Files lists
20 (same Serie UID) as it founds different Serie UID
21 amongst the files instead of discarting any file
22 that doesn't match with the first one he found.
23 * SerieHeader::OrderGdcmFileList has now one parameter :
24 the Coherent Files list the user wants to sort
25 * SerieHeader::GetFirstCoherentFileList() |
26 * SerieHeader::GetLastCoherentFileList() | allow to parse
27 the set of Coherent Files lists
28 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
29 compatibility (it returns the *first* Coherent Files list,
30 since there was only one before)
31 * Test/TestSerieHeader gets gdcmData as a default root directory
33 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Remove friend between DocEntry and File classes
35 * Remove friend between PixelReadConverter and RLEFramesInfo,
38 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
40 0002|0000. The value was incorrect.
42 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
45 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmUtil.cxx : compilation fix on Win32
47 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
48 variable, to be easy found. Add methods to change the default UID.
49 Amelioration of the CreateUniqueUID to use the correct default UID.
50 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
53 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * Test/TestVR.cxx : fix memory leaks
56 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
57 * Rewrite the base 256 to base 10 conversion, using string operation only.
58 This allows us to get rid of the problematic 64bits integer type (does not
59 always exist on target platform).
61 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
62 * Add construct and destructor to class gdcm::Debug to close the debug file
64 * Don't let uset to open twice the same file
65 * gdcm has now an official UID prefix,
66 supplied by http://www.medicalconnections.co.uk
67 1.2.826.0.1.3680043.2.1143
68 (Thx to Mathieu for providing URL)
69 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
70 to be able to perform some more tests
71 * gdcm::ContentEntry : Contructors and Destructor are now protected,
72 in order to be sure no user will try to use them.
73 (at user level, only the children classes are meaningfull)
75 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * move RLEInfo & JPEGInfo from Document to File
78 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * FIX : remove so many friend between classes
81 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
83 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
85 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 In order to avoid missbehaviour :
87 . gdcm::DocEntry is now specialized in
88 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
89 - gdcm::ContentEntry (Dicom entry with a 'content')
90 . gdcm::ContentEntry is specialized in
91 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
92 characters value, or integers)
93 - gdcm::BinEntry (Dicom entry with a non strig representable value
94 (user hasn't any longer to thing about the precedence of his dynamic_casts)
96 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Test/VTKTest*.cxx : bug fix under linux
99 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
101 use with python. Some methods are moved from Document to ElementSet or
102 DocEntrySet. The equivalent methods to ElementSet have been added to
103 SQItem and are virtual in DocEntrySet. Methods that may have the same code
104 in SQItem and ElementSet is directly placed in DocEntrySet
106 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * Test/VTKTest*.cxx : remove the show variable in each test method because
108 it's useless (the viewer variable replace this variable)
110 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * src/gdcmDocument.cxx : bug fix on potential memory leak
112 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
113 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
114 Add ClearXxx methods to remove all the content of the list or map
115 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
117 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
118 * methods ReplaceOrCreate renamed as Insert
119 (nobody will be any longer confused by 'CreateOrReplace')
121 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Grealty simplify the JPEg decompression, no need to differenciate based on
123 the JPEG possible type (with/without fragment, with/without multiple frame).
124 Everything is done throught the JPEG IO Suspension mechanism in IJG
126 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
127 * Stage 3 of normalization :
128 in order to avoid any missunderstanding while reading method names :
129 - All the methods xxxEntry now deal with dicom Entries
130 - Methods GetEntry splitted into
133 - Method SetEntry renamed as SetEntryValue
134 - Method SetEntryBinArea let as it was
136 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
138 - Position correctly the entry points for JPEG2000 and JPEG-LS
139 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
141 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
143 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
144 with other method names
145 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
146 * Test/TestDicomDirElement.cxx : add new test
148 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
149 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
150 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
151 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
152 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
153 So can't you use __int64 in ostream at all.
155 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * bug fix for compilation on MSVC6
157 * gdcmPython/gdcm.i : rename of classes missed
159 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * Stage 2 of names normalization :
161 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
162 (easy to understand ...)
163 - gdcm::FileHelper replaces old class gdcm::File
165 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
167 type and not a string. So, there remove problems on the format of the
170 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 * Add Example/TestPapyrus.cxx
172 - reads a Papyrus file (gdcm::Header compliant),
173 - gets the pixels of all the images, using low level iterators
174 - writes an multiframes Dicom image.
175 (Just to show it's *possible* to do that)
176 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
179 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
181 Thus, DicomDirXXX are created with a flad that indicates if the created
182 object is empty or not (when not empty, the DicomDirElement is used to
185 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
187 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
189 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
192 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
194 Remove all access to the hash-tables or lists in the objects.
196 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
198 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
199 be complient with all the gdcm source code
201 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
205 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
209 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Test/ : rename VTK tests to have a best name for the tests
211 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
212 GetFirstEntry/GetNextEntry use
214 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
215 * In SerieHeader::ImagePositionPatientOrdering()
216 // a Dicom 'Serie' may contain scout views
217 // and images may have differents directions.
218 // -> More than one may have the same 'pos'
219 // Sorting has then NO meaning !
220 Thx to Eduardo Davila for reporting bug.
222 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
224 test. Now it's on image content and not on the resulting visualisation...
225 might solve the problem on linux when using the OpenGL drivers
227 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
228 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
229 DicomDirSerie, DicomDirImage
230 Dict, DictSet classes :
231 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
232 -remove InitTraversal method.
233 * UPD Test programs + Example programs
235 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
236 * remove useless and never updated keyword \ingroup
237 * Solve pb when structure (list, map, ...) is empty.
238 Thx to Benoit for reporting bug
240 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
241 * Taking into account of 'Transfer Syntax' value
242 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
245 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
247 is no memory access violation
248 * gdcmPython/demo : add python demos using VTK
250 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
251 * FIX 'Dictionnary' is now spelt 'Dictionary'
252 'wether' is now spelt 'whether'
253 'archieve' is now spelt 'archive' ;-)
255 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
256 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
257 related methods, in order not to expose internal mechanisms
260 * REM methods that exposed internal mechanisms :
261 DicomDir::GetDicomDirPatients()
262 DicomDirPatient::GetDicomDirStudies()
263 DicomDirStudy::GetDicomDirSeries()
264 DicomDirSerie::GetDicomDirImages()
265 * UPD Test programs :
269 * UPD Example program
271 * ADD DictSet methods
275 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
276 * Removed the Print/indent/default parameter mess. There is absolutely no
277 reason to have to methods, moreover with the second taking the ostream as
278 *SECOND* parameter. This was clearly a bad hack to get things compile.
280 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Complete rewrite of the GetMacAddress code. Now the code is *much*
282 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
283 Unfortunately the main code does not work on SunOS, thus provide a specific
284 code for this platform only (and Win32 of course). Since this seems to be
285 working, change CreateUniqueUID to use GetMACAddress instead of the
286 problematic GctestetIPAddress
288 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
289 * Unfortunately to be able to test gdcmDirList I had to break the API
290 a little. Now the class is not a std::list anymore but has a member
291 std::vector (more ITK compatible). Allow unit testing on Win32 and
294 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * Update SerieHeader to take into account a Serie Instance UID to properly
298 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
299 * ENH - Comment out Mathieu's (dangerous) Super Hack
300 for dealing with BIGENDIAN processors
301 - Move equivalent stuff to BinEntry::WriteContent
302 When necessary, 16 Bits Pixels are swapped in a small buffer
303 and then written. This avoid allocating a huge buffer, in
304 PixelWriteConvertor, and avoid modifying the Pixel Area.
306 Probabely, the same operation will have to be done when we want
307 to write image with Big Endian Transfert Syntax,
308 and we are working on Little Endian Processor
310 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
313 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
314 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
315 all the dict content.
316 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
318 * Test/TestDict.cxx : add a new test for the dict classes
320 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
322 file. Debug is yanked if compiled with NDEBUG
324 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * src/gdcmDictSet.h : set the default output to the os variable
326 * src/gdcmDictEntry.[h|cxx] : add the Print method
327 * gdcmPython/demo/ : add a new test
329 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
330 * merging of Test/PrintDicomDir and Test/TestDicomDir
331 * removal of now redundant Test/PrintDicomDir
332 * enhancement of Example/PrintDicomDir
334 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Now, python test might work on systems
336 * Add the PrintDicomDir test
338 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
339 * FIX : First entry following group 0002 was lost for
340 Explicit Big Endian Transfer Syntax files
341 (group and elem not swaped)
343 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
344 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
345 Big Endian Transfer Syntax supposed the group following 0002
346 begins always by element 0000 (element 0000 is *optional*)
347 To avoid further troubles, let's be pessimistic, and use
348 Document::HandleOutOfGroup0002() method
349 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
350 (related pb not yet solved)
352 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * Bug fix for the python part use
354 * Now, PrintHeader.py pass... but outside the ctest use. shit !
356 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
359 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
360 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
361 a string and should ask the global TS dict what are the propreties of
364 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
365 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
366 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
367 to swap the Swap Code, at parsing time, when we come out of group 0002
368 and Transfer Syntax is Big Endian
369 We should be able to read now 'true DICOM" Big Endian coded images
370 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
371 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
373 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
374 * Hopefully fix the bug on MacOSX and static global initialization.
375 This is the only -minor- patch I found that both please MacOSX and VS6.
376 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
377 but this would require a lot of change. Another approach would be that Global
378 create those string and GDCM_UNFOUND becomes a pointer to a string (which
379 gdcm::Global would destroy at exit).
381 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
382 * Fix bug on MacOSX with static initialization in a multy threaded
383 environment. static const string in a header file used to be ill
384 initialized provoquing the freeze of any tests. patch should solve this
387 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
388 * According to Benoit's suggestion, and without any objection from anybody
389 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
390 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
391 - method gdcmDicomDirObject::GetEntry() renamed as
392 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
394 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
395 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
396 you debug/warning message just as c++ streams which make them very convinient
397 to use. Once this is stabilize I will change the ostringstrem to be
398 redirected to a file (ofstream).
399 * Properly support C99 extension: __FUNCTION__ which allow us to display
400 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
402 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
403 * Removal of useless and dangerous methods :
404 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
405 GetDocEntryByName, GetEntryByName, GetDictEntryByName
406 * Removal of usless methods :
407 Dict::PrintByName, Dict::GetDictEntryByName
408 * Commenting out of probabely useless methods :
409 Dict::GetDictEntryNames()
410 Dict::GetDictEntryNamesByCategory()
411 DictSet::GetPubDictEntryNames()
412 DictSet::GetPubDictEntryNamesByCategory()
413 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
414 * ENH : Use dicomTS.dic as described in 2004 version
415 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
416 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
417 Add Accessors on VM (Value Multiplicity), and VM related methods
418 * ADD : Add a list of 'Dicom Attribute types', as found in
419 http://medical.nema.org/dicom/2004/04_15PU.PDF
421 * ADD : Add dicomGroupNameAbbreviations.dic
422 should be used to write a method to replace the former
423 Dict::GetDictEntryNamesByCategory()
425 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
427 to read in the file... and only it ! Length is the efective length of the
428 data in the DocEntry structure
430 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
431 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
432 And now use a static function call instead, with a global variable. i
433 This is much closer to the VTK approach. Hopefully should be bulletproof
434 and easier to use...hopefully
436 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
437 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
439 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
442 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
444 ValEntry, BinEntry, SeqEntry creation or replace
446 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
448 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
450 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
451 when specifying the VR
452 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
453 * src/gdcmDocEntry.cxx : amelioration of print
455 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
456 * ADD : Add the method Util::IsCurrentProcessorBigEndian
457 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
458 * ADD Method Document::ComputeGroupLength
459 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
460 in order to allow further VR modification by user
461 * REM : removal of once-called method File::WriteBase
462 integration of its code in formerly one-line method File::Write
464 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
466 replace the different values "??", "Unkn", "Unknown".
467 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
468 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
469 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
470 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
472 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
475 * Set the gdcm::Base class to some Printable classes
477 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmFile.[h|cxx] : add the Print method
479 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
480 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
481 * src/gdcmDocument.h : remove the PrintLevel informations
482 * Example/PrintFile.cxx : use the new gdcm::File::Print
484 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
485 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
486 problems when compiling with the python wrapping
488 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
490 writting in ImplicitVR
492 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
493 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
494 JPEG decompression, especially when dicom frames are split into several
495 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
496 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
498 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmHeader.cxx : change the initialisation of default header.
500 Now, this header is readable by gdm, e-film, DicomWorks
502 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
504 Rename Decompressed to Raw
505 * Use the API changes in gdcm::File.
506 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
509 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
511 each added entry in the header. Replace the 'Planes' field by the 'Number
514 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
516 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
518 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
520 At this time, this image isn't readable by e-film... waiting JPR help to
523 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
525 DocEntry. Now use methods of the Document !
527 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * Test/ShowDicomSeq.cxx : bug fix
530 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
532 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
533 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
534 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
536 * Test/TestCopyRescaleDicom.cxx : remove unused variable
537 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
538 containing found sequences
540 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
543 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
544 Some fields in BinEntry must be copied to not seg fault when making the :
545 gdcm::File *copy = new gdcm::File( copyH );
546 and tests are now made on good variables
548 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
550 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
552 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
553 * Add vtkGdcmWriter example and test
555 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * Test/TestUtil.cxx : reformat the source code
557 * vtk/vtkGdcmReader.cxx : remove and change prints
558 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
560 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
561 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
563 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
565 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
567 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
569 by an eof to prevent all bad read of the file... and in this case, the
572 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * Example/Volume2Dicom.cxx : comment unused variables
574 * Test/PrintDicomDir.cxx : comment unused variables
575 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
576 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
577 method that is redondant with AddEntry.
578 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
581 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * Bug fix due my last commit (compilation under Windows).
583 * Example/Volume2Dicom : bug fix in the file and reformatting source code
584 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
586 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
588 - Remove printf / sprintf
589 - include iostream AFTER gdcm so we don't get warnings
590 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
592 - Also remove tons of include from header files, hopefully this should
593 speeup the compilation time, since it was becoming a dog slow.
594 - Remove gdcm.h as it include way too many files and slow down compilation
595 (plus it is not up to date)
596 - remove 'using namespace std' this is BAD !
598 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * Remove memory leaks on the DicomDir
600 * Remove some useless data in DicomDirObject
601 * Add usefull methods in SQItem, to be complient withe the ElementSet
603 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
606 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
608 future, with convertion)
609 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
610 and ImageDataSize values. Remove the method to get the PixelReadConverter
611 from the output of the class
613 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
616 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
618 and vtkErrorMacro use.
619 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
621 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
624 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
625 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
626 The string leaves only in the fonction. So when we make a .c_str(), we
627 get the pointeur on the first element, element that will be destroyed
628 immediately after thee instruction.
629 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
630 file has been opened : the test must be made on the content of the
631 pointer and not directly on the pointer !
634 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
636 the python part recompiles
638 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
640 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
641 X session is killed (for my computer... it seems to not be identic on
644 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
646 avoid problems (otherwise, the difference test between the visible image
647 and the reference is incorrect. If the reference is greater than the
648 screen resolution, it's produce errors).
649 Can be used for only one image. Can be used with a visible flag.
650 * vtk/vtkGdcmReader.cxx : remove commented codes.
651 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
652 under windows at compilation
653 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
655 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
657 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
659 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
660 tests on the image size X, Y, Z
662 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
664 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
665 between the class name and the file name
667 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * src/ : fix compilation warnings for the Write method (2 different
669 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
670 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
671 variable... create a static method in gdcm::Document to access to
672 this variable content.
674 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
676 file, to be accessed by other files (like gdcmFile). Remove commented
677 code. Move the change of the header to the gdcmFile, using the
679 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
680 To be sure of that (and simplify calls), the Write of the header now
681 gets a file name and not a file pointer (std::ifstream).
682 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
683 DocEntryArchive. Remove all open of the written file
685 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
688 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
689 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
690 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
692 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
693 some corresponding methods. Write correctly the file and check before
695 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
696 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
697 is now on RGB data (as before my last commit
698 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
700 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
702 Add a print information of the type of the entry
703 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
704 It was in the gdcmFile, and all write have been regrouped
705 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
706 Write correctly all dicom files (in decompressed mode only at this time)
707 * Test/ : test on files are now made using Raw data and not color data if
709 * Example/PrintFile.cxx : add more printings
711 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * Amelioration of code, remove some code copy. For the loading of
713 BinEntry (in gdcmDocument), add the test to verify if the file is already
716 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
718 remove a DocEntry in the header (push an empty DocEntry)
719 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
720 lines. Bug fix in the initialization of the PixelConvert and the
722 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
723 use in TestCopyDicom (now this test can run under windows... but fails)
724 * Test/TestCopyDicom.cxx : amelioration of the test :
725 - test the pixels written
726 - add test points to quickly find where is the error
727 - can set a file name input and output in arguments
728 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
729 amelioration of the test output
731 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
733 all replaced DocEntry's
734 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
735 Now, each needed DocEntry to modify is duplicated, modified and inserted
736 to the header using DocEntryArchive. Thus, after save, we can restore the
737 header initial state.
739 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
742 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
743 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
744 correct to copy it. The DictEntry is specified at the DocEntry creation,
745 then, it musn't change in the time.
746 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
747 header correctly. At this time, the change is only made for the first
748 level of the Document. In the future, it might consider sequences.
749 The change is made by replacing a DocEntry by an other that is created
750 outside the class. The old value is kept. When we restore the header
751 status, the added DocEntry is deleted and replaced by the old value.
752 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
753 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
754 set the write type to explicit VR, implicit VR or ACR. Add methods to set
755 the write mode to native, decompressed or RGB (but not used at this time)
757 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
759 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
761 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
763 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
765 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
766 set because already copied when copying the BinEntry's of the header
767 * Test/TestAllReadCompareDicom.cxx : remove warnings
769 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
771 Two problems appear when doing it :
772 - with the gdcmFile : when the GetImageData method is called, the pixels
773 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
774 data (pixels). And each structure destruct the data when it's
775 destructed. So we have two destructions for the same data. To solve it,
776 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
777 data or not. If it doesn't own data, then they will not destroyed by
779 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
780 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
781 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
782 create a double destruction of the same DocEntry's. So, to solve it,
783 the TagHT is simply cleared and the DicomDir* elements are destroyed.
784 * TODO : add an entry concerning memory leaks in the DicomDir
786 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
787 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
788 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
791 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
793 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
794 after it have been deleted
796 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * FIX: src/* fix the doxygen warnings.
798 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
799 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
800 was erroneously defined with a size of 15 instead of 16. [many thanks
801 to Jean Michel Rouet for pointing out this bug].
803 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
804 1. Finish merging JMR patch for writting DICOM from scratch
805 2. Fix -hopefully- bug with MONOCHROME and space vs null character
806 3. Use const ref when possible
807 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
808 5. A few more comments
809 6. CreateUniqueUID can now be called without parameter"
811 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
812 * ENH: Slightly bigger patch:
813 1. Getting toward full integration of JMR patch for writting dicom from scratch
814 2. Update Test to test part of this patch: CreateUniqueUID
815 3. File was not close properly in gdcmDict
816 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
817 5. Use of const ref instead of copy (speed issue)
818 6. Remove temporary (duplicate) string in TranslateToKey
819 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
820 8. Do not repeat virtual in subclasses
821 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
823 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
824 * Apply first patch toward better string comparison when dealing with broken
825 DICOM files. Essentially the string could be padded with a space instead
826 of a null character as defined by standard
828 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
829 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
830 because never used... and in the same time, that's remove some memory leaks
832 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
833 * src/gdcmFile.cxx : now delete the PixelConvert instance.
834 * In examples and tests : change the type of image data variables from void*
835 to uint8_t*. Remmove all delete on image data variables
837 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
839 Verify the file pointer value before open the file, and if it's not null,
840 a verbose message is generated.
841 Close correctly the file when the file isn't considered dicom-like. The
842 correctly close is a call to CloseFile.
843 When closing the file pointer, test if its not null to close the file.
844 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
845 file. For an uncompressed image, the copied data correspond in the least
846 case to the image size (calculated) or the image size specified in the
847 header. A verbose is generated if these two size mismatch
849 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
851 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
852 break under windows (with msvc6 compilation).
854 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
855 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
856 compiling with MSVC6)
858 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
859 * Bugs fix for the Windows build with VC6
860 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
861 needed (only for projects required VTK). If the VTK is included in all
862 projects, there is conflicts with the jpeg lib of vtk when compiling the
863 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
864 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
865 when compiling the gdcm_wrap.cxx file (created by the compilation of the
867 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
868 (like it's already made for the cout use). Otherwise, conflict with the
871 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
874 - comments on the DicomDir::Method related usage added.
875 - now that we use the namespace gdcm, a lot of internal classes do
876 NOT need to be wrapped anymore.
877 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
878 DicomDir::Method) new example added.
880 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 * Improve string manipulation. I now inforce the notion of 'DicomString'
882 A DicomString can contain as many \0 as they want
883 and it is *always* of even length.
884 We only support odd length for very rare case.
885 And in the near future this should be removed.
887 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
888 * /binary_write/ gdcm source. Now even on big endian we are writting
889 little endian. This should -heopfully- fix some tests
891 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * Now the dictionary is compiled into gdcm lib. This is a default
893 behavior, thus any dic file specified is picked before failback to
894 the one comiled into lib
896 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
897 * Change internals for gdcmDict. Don't use any 'new' any more.
898 This should definitely solve any leak problem, and we should be
899 as fast as before, as long as don't modify too much the dictionary.
901 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 * STYLE: ivars should start with a capital letter.
903 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
904 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
906 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
908 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
909 new 2004 dictionaries added (thanks to JPR).
910 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
911 * CLEANUP_ROUND (15) for gdcmPixelConvert
912 - RLEFrame::NumberFragments is now of type unsigned int
913 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
914 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
917 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * Initial work in gathering all transfer syntax accessors. clearly
919 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
920 ivars, but only one transfersyntax (class) ivar with equivalent method on
923 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
924 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
925 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
926 discussed (plus I didn't like having a 2000 lines patch not commited)
928 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
930 * CLEANUP_ROUND (14) for gdcmPixelConvert
931 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
932 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
933 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
935 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
936 anymore and hence avoids storing a copy of PixelConvert::Decompressed
937 into File::Pixel_Data.
939 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
941 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
942 * CLEANUP_ROUND (13) for gdcmPixelConvert
943 Substituted File::ParsePixelData() with PixelConvert::Print() new
945 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
946 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
947 method to those classes.
948 - src/gdcmFile.[cxx|h]:
949 -- Added a ::Print() method.
950 -- PixelConverter is now a reference instead of a member.
951 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
952 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
954 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
955 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
956 collaboration diagram and inheritance diagram should be generated with
958 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
959 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
960 pointlessly wrapped (see
961 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
962 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
963 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
964 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
965 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
966 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
967 -- File::Initialise: PixelConverter setup moved away to
968 PixelConverter::GrabInformationsFromHeader()
969 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
970 interpretation moved away to PixelConverter::BuildRGBImage()
972 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
973 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
974 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
976 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
978 displayed on Win32 when a brutal abort() occurs (because of uncatched
979 exception). See TODO new entry of this commit for more on this.
980 * TODO added new entry.
981 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
982 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
983 - HandleColor is no longer called from gdcmFile.cxx
984 - gdcmPixelConvert.cxx clean up on method arguments and internal
985 variable names for semantical coherence.
987 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
988 * Finished lossless transition, not only do we now read all lossless jpeg
989 images, without the need of the Cornwell lib, but we do read them properly now
990 * To reduce code (well to avoid code duplication), I defined a common place
991 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
992 redefine symbols. This is not perfect but this the best solution I found for a
993 compilation time jpeg option.
995 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
996 * Update jpeg ijg lib to support lossless jpeg implementation
997 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
999 * Also added a special copyright for dcmtk since we use their bugfixes.
1002 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1003 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1004 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1005 matters, as stated in warning note at beginning of %include section).
1006 * src/gdcmDicomDir*.[cxx|h]: coding style
1007 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1008 * src/gdcmJpeg8.cxx: doxygen fix.
1009 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1010 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1011 from File:: to PixelConvert::.
1013 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1015 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1016 - more code moved away from File:: to PixelConvert::
1017 - fat setup of PixelConverter set in place in File::Initialise.
1019 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1020 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1021 namespace at the file system level. So now you should convert your examples
1023 gdcmHeader -> gdcm::Header
1024 It would be nice if people keep in mind to no open the namespace, since it
1025 allows compilation on broken plateform which were defining common symbol in
1026 the standart namespace (like LP, Unknown ...)
1028 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1030 The JPEG fragments are now parsed at the same stage than the RLE
1031 information. All code related to JPEG is now in gdcmPixelConvert:
1032 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1033 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1034 export a gdcmFile:: method. Those are simply global functions
1035 (for the time being this is better than having them attach to
1036 either gdcmFile:: or gdcmPixelConvert::).
1037 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1038 and stores the result in a gdcmJPEGFragmentsInfo.
1039 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1040 code (among other stuff) moved away from gdcmFile:; to
1043 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1045 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1046 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1047 clean up of RLE related code.
1048 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1049 - src/gdcmRLE.cxx removed
1050 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1051 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1052 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1053 * CLEANUP_ROUND (9) for gdcmPixelConvert
1054 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1055 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1056 away from gdcmFile:: to gdcmPixelConvert::.
1058 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1060 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1061 This is because Parse7Fe0 used to parse the pixels to compute the
1062 length. This task was passed over to FindDocEntryLengthOB() a long
1063 time ago, EXCEPT I had forgotten the OW case...
1064 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1065 we just recylce the code for parsing RLE fragments and computing
1067 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1068 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1069 with the retired Parse7Fe0().
1070 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1071 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1073 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1075 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1076 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1077 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1078 * CLEANUP_ROUND (4) for gdcmPixelConvert
1079 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1080 to return an unused length.
1082 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1084 this should be cleanner from the plane view. The iostream are erally a pain
1085 to use to do simple stuff.
1087 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1088 * Redo the compilation of the ijg jpeg library. Now only one source is
1089 necesseray. No need to rename file by hand what so ever. CMake handle the
1090 copying of the file within different directory, configure header file to
1091 modify some symbol. The only addition made to ijg wasd a mangle table so
1092 that symbol are different whether we are within 8bits or 12bits.
1094 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Added documentation of vtkgdcmReader on Website:
1096 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1097 with it's binary name).
1098 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1099 the Website to be more complete.
1100 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1101 doxygenated documentation.
1102 - Doc/DoxyVtkGdcmReaderExamples.txt added
1103 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1104 DoxyVtkGdmReaderExamples.html )
1105 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1106 * CLEANUP_ROUND (3) for gdcmPixelConvert
1107 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1109 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * CLEANUP_ROUND (2) for gdcmPixelConvert
1111 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1113 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * CLEANUP_ROUND for gdcmPixelConvert:
1115 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1116 - src/gdcmPixelStuff[h|cxx] removed
1117 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1118 - src/CMakeLists.txt changed accordingly
1119 * GDCMHOME clean up:
1120 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1121 gdcmVersion.py moved to newly created ATTIC related
1122 gdcmPython/SetupOldies/ directory.
1123 * Autotools clean up:
1124 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1125 - autogen.sh configure.in acinclude.m4 python.m4 removed
1127 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1128 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1129 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1130 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1132 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * TODO updated with Mathieu suggestions. I proposed a template for
1134 describing TODO entries and used it for new entries.
1135 * Added Doc/Website/CodingStyle.html, Developpers.html,
1136 DeveloppersPython.html, GdcmDataCvs.html and
1137 DownloadVersion0_1.html, DownloadVersion0_3.html.
1138 * Some Doc/*.txt Doxygen files (which do not really concern the
1139 documentation itself, but the website) moved to html and
1140 placed in directory Doc/Website:
1141 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1142 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1143 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1144 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1145 * CMakeLists.txt changed accordingly.
1146 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1147 DeveloppersPython.html
1148 * INSTALL nows refers to Doc/Website/Installation.html
1150 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * Added Doc/Website directory, that contains a first raw version
1154 2004-09-23 Jean-Pierre Roux
1155 * FIX In order not to be poluted any longer by casting problems,
1156 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1157 we can now delete[] it safely
1158 * VoidArea is now called BinArea (less confusing name),
1159 and all the methods called ...VoidArea... are now ... BinArea...
1160 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1162 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1164 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1165 up to the destructor of gdcmElementSet to clean up TagHt and it's
1168 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1170 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1172 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * ENH: added some utility method that builds a flat dictionary
1174 holding all the Dicom entries contained in the recursive structure
1175 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1176 an example of usage.
1177 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1178 BuildFlatHashTable() that build a flat dictionary.
1179 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1180 gdcmDocument is now a friend of gdcmElementSet.
1181 - src/gdcmElementSet.cxx: clean up.
1182 - Example/FlatHashTablePrint.cxx added.
1183 - Example/CmakeLists.txt changed accordingly
1185 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1187 moved away from gdcmDocEntrySet (since this class is an abstract class
1188 acting like an interface). SQDepthLevel and BaseTagKey are now
1190 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1191 and associated accessors. Doxygenation of the class.
1192 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1194 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1195 Use SQDepthLevel accessor instead. ::Print() adapted.
1196 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1197 - src/gdcmDocument.cxx changed accordingly.
1199 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1201 - The following is the doxygen comment of the typedef declaration
1202 of gdcmTagKey in src/gdcmCommon.h:
1203 gdcmTagKey is made to old an "universal" (as in URL, Universal
1204 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1205 A dicom tag always has a group and an element, but a set of tags
1206 embeded in various (optionally nested) sequences and sharing
1207 the same group and element all share the same (group, element)
1208 "identifier". Hence the (group, element) cannot be used as an
1209 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1210 In order to construct a proper tag identifier (i.e. a key) we
1211 consider the following definition of a TagKey:
1212 - let Group, Element be the string representation of the
1213 group and element dicom tag members,
1214 - let ItemNumber be the string representation of the integer
1215 index of the considered item number of a sequence,
1216 Let the key of a tag embeded in a sequence, noted SeqTag, be
1218 /ItemNumber#Group|Element
1219 where "/", "#" and "|" are characters acting as separators.
1220 Then the general form of a gdcmTagKey is given by:
1221 Group|Element<SeqTag>
1222 where <SeqTag> means NO or many instances of SeqTag.
1223 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1226 but the gdcmTagKey of a tag "embeded" is the first item of
1227 a sequence, itself nested in the third item of a sequence is the
1229 0004|1220/2#0008|0082/0#0008|0090
1230 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1231 order to hold the new sequence compatible key. Previously, the
1232 GetKey() method would look in the underlying gdcmDictEntry.
1233 - src/gdcmDocEntry.cxx:
1234 -- constructor now copies the underlying DictEntry key, in the local
1236 -- ::Print: displays the member Key, instead of the (group, element).
1237 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1238 - src/gdcmDocEntrySet.h:xi
1239 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1240 -- now has a new BaseTagKey member.
1242 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1243 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1245 This poses the problem with the semantics of the following lines
1246 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1247 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1248 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1249 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1250 to the long FIXME note for what the problem is. Nevertheless in
1251 order to get things working the dicom dictionary was altered !
1252 Please fix things urgently...
1253 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1254 information), see above note on moving the member VoidArea. Nevertheless
1255 the following entries previously correctly set as US are now inproperly
1257 0028 1201 OW IMG Red Palette Color Lookup Table Data
1258 0028 1202 OW IMG Green Palette Color Lookup Table Data
1259 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1260 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1261 of gdcmDocEntry moved to gdcmSeqEntry.
1262 * src/gdcmSeqEntry.cxx: STYLE.
1264 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1267 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * gdcmPython/testSuite.py: all the test suite in python is now moved
1269 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1270 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1271 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1273 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1274 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1275 to avoid inclusion recursion until STL is reached.
1276 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1277 mecanism. errno.h is not included in gdcm anymore.
1278 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1279 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1281 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1282 gdcmData/TestAllEntryVerifyReference.txt
1283 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1284 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1285 exception_on_error parameter.
1286 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1287 - vtk/vtkGdcmReader.cxx changed accordingly,
1288 - Example/*.cxx and Test/*.cxx changed accordingly.
1290 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1291 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1292 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1293 enable_sequences removed from gdcmHeader constructor and dependencies.
1294 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1295 * gdcmPython/demo/PrintHeader.py: dummy fix.
1296 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1297 skip_shadow removed from gdcmHeader constructor and dependencies.
1298 * Example/*.cxx and Test/*.cxx changed accordingly.
1300 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1302 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1304 2004-07-21 Jean-Pierre Roux
1305 * FIX Now, Parsing and Printing a DICOMDIR do work!
1306 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1308 2004-07-20 Jean-Pierre Roux
1309 * FIX Some brain damaged headers have Zero-Lenght fields
1310 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1312 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1313 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1314 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1315 variable (instance of gdcmDebug) by a definition macro, and the instance
1316 is now in static in the gdcmDebug class
1317 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1318 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1320 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * WARNING: ctest now depends more tightly on gdcmData. You should
1322 check out gdcmData properly for things to run smoothly...
1323 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1324 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1325 we need the pixels not be loaded in order to use the ValEntry
1326 that displays position and size).
1327 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1328 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1329 be deprecated. If you have any doubts about the advantages of a
1330 modern scripting language (read Python) versus grass root C++ (i.e.
1331 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1332 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1333 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1334 Anyhow, consider documenting the gdcmData images in
1335 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1337 * Test/CMakeLists.txt:
1338 - now uses TestAllEntryVerify.cxx
1339 - specific comments on oldACR00001.ima (now renamed in gdcmData
1340 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1341 gdcmData/TestAllEntryVerifyReference.txt
1344 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1345 * src/*.[h|cxx] : typedef clean up
1346 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1347 - TagKey renamed to gdcmTagKey (for external usage)
1348 - VRKey renamed to gdcmVRKey (for external usage)
1349 - removal of typedef duplication.
1350 - Removed all unecessary inline keyword from class inline definitions.
1351 - Some method|function(void) declarations replaced with method|function().
1352 * src/jpeg/libijg12/jdhuff12.c:
1353 - printf polluting ctest removed.
1354 - TAB removal for comminting
1356 - TestAllReadCompareDicom.cxx: added a test that compares all the
1357 images in gdcmDataImages.h with corresponding images in
1358 gdcmData/BaselineDicom/. When baseline images are not present
1359 this test creates them.
1360 Note: we need to validate each reference image, but before that
1361 I'd like to rename them with a more explicit name...
1362 - CMakeLists.txt: changed accordingly.
1363 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1364 including each header needed).
1366 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1368 test suite to the Example directory. Are concerned:
1373 - TestWriteSimple.cxx
1374 * Test/CMakeLists.txt: added some comments on reasons for black listing
1375 image gdcmData/oldACR00001.ima
1377 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * Test/CmakeList.txt: removed the following from black list (to be coherent
1379 with removal from gdcmData):
1380 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1381 - gdcm-MR-PHILIPS-16.dcm
1383 Added the following because after last cvs update, they cause
1384 ctest -R TestReadWriteReadCompare
1386 - gdcm-MR-SIEMENS-16-1.acr
1388 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1389 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1390 new comments in this file) we temporarily (sigh) move to a weaker
1392 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1393 we don't need to black list the following images anymore:
1394 - 8BitsUncompressedColor.dcm
1396 - US-PAL-8-10x-echo.dcm
1397 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1398 fixes and the beautified code ;-)
1399 This fixes the bug introduced in version 1.42 (when beautifying)
1400 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1401 Note: ctest was blind to this bug (this means we need to still
1402 improve the test suite). The bug could be detected by using
1403 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1405 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1406 and by displaying the (garbage) produced file temp.XDCM...
1408 2004-06-29 Jean-Pierre Roux
1409 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1410 - replace by uggly but working old code :-(
1411 A lot of things should be OK again.
1412 It's really urgent to have a test suite that *tests*,
1413 to prevent Frog's beautifying sessions to break all the stuff
1414 (twice, withing a fortnigh ...)
1416 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1418 redundancy) to added Test/TestReadWriteReadCompare.cxx
1419 * Test/CmakeList.txt: because the compare test of
1420 Test/TestReadWriteReadCompare.cxx fails, the following images are
1421 black listed: - 8BitsUncompressedColor.dcm
1423 - US-PAL-8-10x-echo.dcm
1424 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1425 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1426 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1427 and ad-hoc kludge. This kludge is now removed, and on encountering
1428 such an image (OB field brain damaged) we set errno. Then in
1429 ::FindDocLength() we "fix" the length as being ALL what remains
1430 in the file (until EOF). We then proceed, hoping for the best...
1431 This fixes a SegFault in ShowDicom when trying to write such an
1433 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1434 (because TestWriteRead breaks on it, after a non conformal commit?).
1435 ctest now runs properly, except for MakeDicomDir (which was always
1436 broken) and the Python related stuff (still not fixed).
1438 2004-06-24 Jean-Pierre Roux
1439 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1440 FIX : Test/TestReadWrite now iterates on all the file names
1441 (instead of infinite loop)
1442 ENH : Test/TestWriteRead now iterates on all the file names
1444 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1447 2004-06-24 Jean-Pierre Roux
1448 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1449 when SamplesPerPixel =3
1450 - now Write is no longer confused by
1451 'BitsAllocated = 12" and 'BitsStored=12"
1452 - "UN" value representation Elements are now written correctly
1453 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1454 ENH : - now gdcmHeader has its own Write methods
1455 (in order to split the job that has not to be done
1458 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1459 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1460 loop on the same image until memory went out.
1461 Note: this means we still have gobs of memory loss in PrintDocument
1462 * src/gdcmDocument.cxx: fixes problem on parsing on file
1463 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1465 2004-06-24 Jean-Pierre Roux
1466 FIX : Write - All the Sequences and Sequence Item are now written
1467 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1468 is added a the end, when necessary.
1469 - A lot of brain-damaged images, that were read correctly are
1470 now written correctly
1471 - length compatible BinEntry are now loaded correctly
1472 (even for odd groups)
1473 Note : only Explicit Value Representation was checked.
1474 (question : is implicit VR really necessary for gdcm ?)
1476 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1477 * DEVELOPPER: added a proposition of coding style.
1478 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1481 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1483 Use the gdcmDocEntry::Print() and Write() instead.
1484 * src/gdcmDocument.cxx: bug fix.
1486 2004-06-22 Jean-Pierre Roux
1487 FIX : gdcmDocument.cxx
1488 - Now we do recognize the JpegLossLess format (there was a misstyping in
1489 code 'beautyfication' :-(
1490 - Now we automaticaticaly load the Luts, if any
1492 2004-06-22 Jean-Pierre Roux
1493 In order : to write Sequences, whatever their imbrication level,
1494 : to allow user to create his own Sequences
1495 a lot of modif where necessary (adding, moving, or virtualising methods)
1497 WARNING : save your own sources *before* cvs up !
1500 ADD virtual void Write(FILE *fp, FileType filetype);
1503 ADD virtual void Write(FILE *fp, FileType filetype);
1504 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1507 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1508 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1509 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1510 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1511 ADD std::string GetEntryByName(TagName name);
1512 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1514 std::string vr = "unkn",
1515 std::string fourth = "unkn",
1516 std::string name = "unkn");
1517 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1518 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1519 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1520 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1521 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1522 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1523 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1524 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1527 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1528 ADD virtual std::string GetEntryByName (TagName tagName);
1529 ADD virtual std::string GetEntryVRByName (TagName tagName);
1530 REM virtual bool Write(FILE *, FileType);
1531 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1532 FILE *_fp, FileType type);
1533 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1534 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1535 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1536 REM virtual std::string GetEntryByName (std::string tagName);
1537 REM virtual std::string GetEntryVRByName (std::string tagName);
1538 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1539 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1540 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1542 std::string vr = "unkn",
1543 std::string fourth = "unkn",
1544 std::string name = "unkn");
1545 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1546 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1547 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1548 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1551 ADD virtual void Write(FILE *fp, FileType filetype);
1554 ADD virtual void Write(FILE *fp,FileType filetype);
1557 ADD virtual void Write(FILE *fp, FileType filetype);
1558 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1559 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1560 REM std::string GetEntryByName(TagName name);
1563 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1565 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1566 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1567 The default constructor invoked by the line
1568 gdcmHeader *f1 = new gdcmHeader( header );
1569 was gdcmHeader::gdcmHeader(bool) instead of the expected
1570 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1571 Hence the parsing wasn't executed... See also below.
1572 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1573 as explicit constructor didn't do the trick to fix the above problem.
1574 Could anyone explain why ?
1575 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1576 properly calls gdcmValEntry::Print() (that was weed out from
1577 code related to gdcmBinEntry).
1579 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1580 * In order to fix memory leaks:
1581 - Test/TestWriteSimple.cxx: added cleaning of free store through
1583 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1584 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1585 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1586 (through the call to ::AddDicomDirMeta()) or the destructor
1587 would crash when deleting uninitialized ::metaElems].
1588 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1589 - src/gdcmDocument.cxx:
1590 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1591 from dynamic stores.
1592 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1593 was causing memory leaks.
1594 - src/gdcmSQItem.cxx:
1595 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1596 cleanly handled with polymophism: sorry but my milage is low).
1597 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1598 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1599 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1600 This avoids SegFaulting.
1601 - src/gdcmSQItem.h: coding style.
1603 - Test/TestWriteSimple still severely sucks. The output image content
1604 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1605 damaged when displayed with vtkgdcmViewer.
1606 - on memory leaks: TestWriteSimple leaks really less (see entry
1607 of 2004-06-18 in Changelog file for the call to valgrind).
1608 - on segfaults: ctest now passes all the tests but one (no more
1610 * Erroneous leading white fix:
1611 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1612 white[s] (as opposed to from >> xxx, that removes it [them].
1613 - src/gdcmTS.cxx: ditto.
1614 - gdcmPython/testSuite.py: dirty related kludge removed.
1615 * src/*: remaining references to gdcmParser removed.
1616 * src/*[cxx|h]: added copy[way]left header.
1619 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1620 * In order to fix writing of dicom files:
1621 - Test/TestWriteSimple.cxx: a simpler example of writing.
1622 - Test/CMakeLists.txt changed accordingly.
1623 - src/gdcmDocument.cxx:
1624 -- The destructor now recursilvely removes potential sequences.
1625 -- Bug fix in ::IsJPEG2000()
1626 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1627 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1629 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1630 to only declared) and build on top of
1631 ::GetDocEntryByNumber(guint16, guint16).
1632 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1633 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1634 for usage in destructor and treatement of promotion in
1635 ::ReplaceOrCreateByNumber().
1636 - src/gdcmSQItem.cxx: destructor should better handle his job.
1637 Test/TestWriteSimple now runs (or at least it DOES something).
1638 * We can now start hutting memory links. A good starting point is:
1639 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1640 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1641 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1643 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * Valgrind note: after Mathieu Malaterre teached me how to read
1645 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1647 Using gcc, you can force the STL to use malloc and to free memory as
1648 soon as possible by globally disabling memory caching.
1649 With 3.2.2 and later, you should export the environment variable
1650 GLIBCPP_FORCE_NEW before running your program.
1651 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1652 simply vanish (it is still not clear to me, whether this means that
1653 STL std::string leaks or if valgrind believes it leaks...).
1654 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1655 running bin/gdcmTests makeDicomDir):
1656 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1657 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1659 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1660 SegFaulting (I drowned in DicomDir related code when trying to
1661 understand why the list is empty...).
1662 * src/gdcmDocument.h: first BSD license header try.
1663 * Doc/License.txt added.
1665 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * src/gdcmDocument.[h|cxx]:
1667 - Clean up of the Transfer related predicates. They are now all based
1668 on new method isGivenTransferSyntax, that (should) handle properly
1669 the padding problem.
1670 - general clean up, simplification, and coding style.
1671 - Specific clean up of Parse7FE0() (umproperly named actually).
1672 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1674 2004-06-14 Jean-Pierre Roux
1676 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1677 - fix the display of SQItem ordinal number
1678 - add the GetSQItemByOrdinalNumber method
1679 - remove some useless never written private methods
1681 2004-06-14 Jean-Pierre Roux
1683 - adding a constructor taking a gdcmDocEntry as an input param
1684 - ReplaceOrCreateByNumber now returns :
1685 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1686 a gdcmValEntry * if a string value is passed as a param
1688 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1689 according to the param type (no longer sets a gdcmDocEntry)
1690 - GetValEntryByNumber, GetBinEntryByNumber added
1691 - NewValEntryByNumber and NewBinEntryByNumber added
1693 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1695 - GetSQItemNumber and SetSQItemNumber added, to provide
1696 a (relative) Item identier inside a given Sequence
1697 \warning : some pb remaining around this number
1699 - AddEntry now takes the Item Number as a param
1701 - adding a constructor taking a gdcmDocEntry as an input param
1703 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1704 * Memory leak hunt with the following command:
1705 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1706 --show-reachable=yes gdcmTests PrintDocument
1707 It looks like many (all?) leaks are due to the STL (or a bad usage
1708 of the STL. The lines producing the leaks now have a comment with
1709 a "MEMORY LEAK" tag: you can retrieve them with
1710 grep "MEMORY LEAK" src/*
1711 Here are two typical examples which I can't help fixing:
1716 char * test = "babo";
1717 name = test; //// <--- valgrind detects 960 bytes lost in
1718 //// call to std::string::operator=(char const*)
1719 name.clear(); //// Doesn't help !
1727 std::cout << "Type a bunch of characters followed by RETURN: ";
1728 getline(std::cin, line); //// <--- valgrind dectects a loss
1729 //// of 1320 bytes in call to
1730 /// std::basic_istream<>& std::getline<>
1736 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * src/gdcmHeader.[cxx|h]:
1738 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1739 and related, moved away to gdcmDocument.
1740 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1741 the corresponding protected accessors of inherited class
1742 gdcmDocument, removed ! As a consequence gdcmFile had to be
1743 declared friend of class gdcmDocument (see below).
1744 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1745 - Clean up of undefined or unused methods.
1746 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1747 account the changes to gdcmHeader.h).
1748 * src/gdcmDocument.h:
1749 - gdcmFile is now a friend class (in order to take into account the
1750 changes to gdcmHeader.h).
1751 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1752 (see changes to gdcmHeader.h).
1753 - Accessors (reading on the form GetEntry*) are now public.
1754 - Clean up of undefined or unused methods.
1755 * src/gdcmDocument.cxx:
1756 - adaptation to changes to gdcmDocument.h
1757 - ::OpenFile now writes a verbose message when file cannot be opened.
1758 - some std::string properly set to VRKey
1759 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1760 references to gdcmDocument.
1761 * Test/TestFindTags.cxx: changed accordingly to above changes.
1762 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1763 cvs repository gdcmData.
1765 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1767 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1768 conflicts with gdcmValEntry::voidArea.
1769 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1770 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1771 Value representation between StringRepresentable and BinaryRepresentable.
1772 * src/gdcmDocument.cxx:
1773 - method ParseDES: proper indentation restored and usage of
1774 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1775 - method LoadDocEntry: the fingerprint left in the SetValue() of
1776 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1777 removed. Reverting to previous code segment with the proper
1778 dynamic_cast< gdcmValEntry* >.
1779 Note: this was (partially) breaking the python test suite
1780 (gdcmPython/testSuite.py) that made usage of the above
1781 fingerprint to check presence of "Pixel Data".
1782 * src/gdcmDocEntry.h: coding style.
1783 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1784 now taken into account.
1785 * gdcmPython/gdcm.i: adaptation to the new internal representation
1786 of gdcm (exit gdcmParser, hello gdcmDocument).
1787 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1789 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1790 anymore, but instead prints the loaded Python dictionary.
1791 * .... alas, the python testSuite is still broken.
1793 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1794 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1796 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1797 * src/gdcmUtil.h : export methods
1799 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1802 * Initial addition of automatic python testing
1803 * Initial addition of automatic image comparison
1805 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1806 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1807 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1809 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1810 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1811 * Test/ShowDicom.cxx : bug fix for msvc compilation
1812 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1814 2004-05-04 Jean-Pierre Roux
1815 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1816 new concepts (and new classes) :
1817 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1818 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1819 - Sequence Doc Entries (gdcmSeqEntries)
1820 a Sequence is composed of Items.
1821 Each item is a set of Doc Entries (this is recursive)
1822 The non uniqueness of the 'Dicom tag' is due to this recursivity
1823 (never taken into account)
1824 Our unability to add a new 'entry' in the header
1825 at the proper location (neither in the H-Table (map or multimap),
1826 nor in the Chained List is also due to this recursivity.
1827 Don't try, right now, to use/modify/compile these new sources :
1828 nothing is finished.
1829 We just commit all the stuff, 'as is', in order not to loose it.
1831 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1832 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1834 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1835 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1836 file prefix (SetFilePrefix)
1838 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1839 * Add a new test: ShowDicom, for now this is just the c++ version of
1840 checkRead.sh, later it will be able to compare the image read against a
1842 * Replace the DEBUG on the stack with a global entry in cmake interface:
1843 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1845 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * Add an example subdir, with a real example on how to read + write a
1849 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1851 * Doc/CMakeLists.txt: the main page is now properly differentiated
1852 between the developper and user version.
1853 * Doc/doxygen.config.in: dropped search related obsolete flags
1854 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1856 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1857 * DEVELOPPER: added some helpfull comments for compile/test/install
1860 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1861 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1862 src directory, now generated in the build dir.
1863 2. Tests as mentionned smarter
1865 4. Add a new method in gdcmDict that return the PubDict by name
1866 this is interesting for 3rd party lib like ITK,
1867 where we could set the institution name / patient name...
1869 * ENH: 1. Now the test suite is working for real
1870 2. All binaries are now output in the gdcm-bin directory
1871 (this was not true before)
1873 2004-04-28 Jean-Pierre Roux
1874 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1875 SeQuence indented printing of Dicom Header.
1876 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1877 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1878 Computation of SQDepthLevel is now part of gdcmHeader constructor
1879 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1880 tree-like structure of a Dicom Header.
1881 * FIX Test code cleaning
1883 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1884 * ENH: Adding automatic testing
1885 1. Need a DartConfig.cmake to submit to public
1886 2. Add a test driver gdcmTest.cxx
1887 3. gdcmTestMain, an helper for the main test driver gdcmTest
1888 4. Files in Test don't have a main anymore, this becomes interesting
1889 when we add more and more tests, thus dsw don't have to load
1891 * ENH: Adding a GDCM_DATA_ROOT for testing
1892 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1893 one file instead of seven + some small cleanup
1895 2004-04-22 Jean-Pierre Roux
1896 * ENH Minor changes to the Print() methods.
1897 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1898 Header printing. Example given with :
1899 > PrintHeader fileName 2 new
1900 (SQ based tree-like structure still to be done for the Header ...)
1902 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1904 1. I have added some unsigned where needed
1905 2. Some function parameter not used -> (void)
1906 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1907 4. g++ don't like character '\' in comment
1908 5. #define jpeg_create_decompress jCreaDecompress
1909 this really need to be fixed
1910 6. virtualize destructor of gdcmObject ... leakage
1911 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1912 this also really need to be fixed
1913 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1914 remove compression file
1915 (as we only do decompression, right ?)
1916 * ENH: Change malloc/calloc/free with c++ equivalent
1918 2004-04-21 Jean-Pierre Roux
1919 * FIX gdcmHeaderHelper::GetXSpacing
1920 when a single value is found (bug ?), xpacing is now
1921 defaulted to yspacing
1923 2004-04-19 Jean-Pierre Roux
1924 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1925 * ENH add parameters :
1926 bool exception_on_error = false,
1927 bool enable_sequences = false,
1928 bool ignore_shadow = false
1929 to the gdcmFile constructors to be full gdcmParser compliant
1930 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1931 to allow reading of PAPYRUS 3.0 files
1933 2004-04-06 Jean-Pierre Roux
1934 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1936 2004-04-02 Jean-Pierre Roux
1937 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1938 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1939 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1941 2004-03-30 Jean-Pierre Roux
1942 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1943 for ACR file, written out as DICOM files (hope so...)
1945 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1947 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1948 moved to base class gdcmParser and only the specialisation is kept
1950 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1951 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1952 already does the job.
1953 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1954 (to be consistent with gdcmParser::WriteEntries).
1956 2004-03-30 Benoit Regrain
1957 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1958 upate of the object's instance. It's passed to 2 in the unfavorable
1959 case : one in the ExecuteInformation, one in the ExecuteData
1961 2004-03-29 Jean-Pierre Roux
1962 * ENH : Check on file type to be written moved
1963 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1964 * FIX : gdcmObject::ResetBoundaries now stops properly
1965 when end-of-list is reached
1966 : gdcmVersion modified (as Benoit Regrain asked)
1968 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1970 * src/gdcmUtil.cxx: added forgotten iostream include.
1971 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1972 equivalent to ExplicitVR in existing code).
1974 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1976 now contains all the gdcmGlobal related code.
1977 * minor coding style and doxygenation changes.
1979 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1980 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1981 now contains all the Debug related code.
1982 * minor clean-up of includes in src/*.cxx
1983 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1984 CreateCleanString) removed.
1985 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1986 * Doc/DoxyMainPageUser.txt added.
1987 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1988 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1989 src/gdcmDirList.cxx)
1991 2004-03-24 Jean-Pierre Roux
1992 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1994 2004-03-23 Jean-Pierre Roux
1995 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1996 big endian made volumes
1997 * ENH Now gdcmParser constructor and destructor are protected to forbid
1998 end user to instanciate class gdcmParser
1999 (only gdcmHeader and gdcmDicomDir are meaningfull)
2001 2004-03-22 Benoit Regrain
2002 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2003 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2004 gdcmSerie to gdcmDicomDirSerie
2006 2004-03-19 Jean-Pierre Roux
2007 * ENH Now the tree-like structure describing a DICOMDIR comming from
2008 an already existing DICOMDIR file is consistent with
2009 the home-made tree-like structure build ex-nihilo
2010 or build from the files held (recursively) in a Directory
2011 functions gdcmDicomDir::CheckBoundaries()
2012 gdcmObject::SetBoundaries() added
2014 2004-03-17 Jean-Pierre Roux
2015 * REM (Eric Boix bug) : removal of meaningless
2016 gdcmDicomDirImage::NewImage function.
2017 * FIX now file names and directory name are written properly in the
2019 * FIX now gdcmDicomDir constructor may be call without any trick
2022 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2024 of gdcmDicomDirImage::NewImage as empty function.
2026 2004-02-28 Jean-Pierre Roux
2027 * ENH add gdcmDicomDir:NewPatient
2028 add gdcmDicomDirPatient:NewStudy
2029 add gdcmDicomDirStudy:NewSerie
2030 add gdcmDicomDirSerie:NewImage
2031 to allow making gdcDicomDir object.
2032 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2033 (as opposite to the gdcmHeader chained list)
2035 2004-02-11 Benoit Regrain
2036 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2037 when using from python
2039 2004-02-10 Benoit Regrain
2040 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2041 * FIX : in gdcmDicomDir when the directory is empty
2042 * ENH : add callback and methods to get the progression of dicomDir
2045 2004-02-06 Jean-Pierre Roux
2046 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2047 - GDCM_META added to gdcmDicomDirType
2048 - class gdcmMeta created
2049 * ENH : - A brief summary is now displayed at the beginning of
2050 'testDicomDir' to help disaster magnitude estimation
2051 * REM : Now useless Test/explDICOMDIR.cxx
2053 2004-02-05 Benoit Regrain
2054 * ENH : add methods in gdcmObject to get the hash table or the list of
2056 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2057 * FIX : wrapping python for TagHeaderEntryHT
2059 2004-02-04 Benoit Regrain
2060 * FIX : even length for some strings when writting the dicom dir
2061 * FIX : sort the images in the dicom dir
2062 * FIX : Bug fix for python use of dicom dir
2063 * ADD : a python demo
2065 2004-02-04 Jean-Pierre Roux
2066 * FIX : Final solution (?) for icone embedded images
2067 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2068 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2069 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2070 gdcmData/gdcm-MR-SIEMENS-16.acr1
2071 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2072 to make full checking easier
2074 2004-02-04 Benoit Regrain
2075 * FIX : WriteEntries : coding style & logic in parameters
2076 * FIX : Set the elements to create the DicomDir in a dictionary file
2078 2004-02-03 Benoit Regrain
2079 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2080 * gdcmDicomDir : add the load of directory
2081 * Bug fix and print add-on
2083 2004-02-03 Jean-Pierre Roux
2084 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2085 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2086 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2087 * FIX gdcmParser.cxx : 'group length' elements are now considered
2088 as integers, even for shadow groups, when file is Implicit VR
2090 2004-02-02 Jean-Pierre Roux
2091 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2093 of the last synonym :-(
2094 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2096 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2097 * FIX taking into account the possible 7fe0,0010 multiplicity
2098 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2099 to allow removal of references to 7fe0,0010, to deal with
2100 ACR-NEMA images, when 0028,0200 is meaningfull
2102 2004-01-31 Jean-Pierre Roux
2103 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2104 no longer writes 'Un' on disk
2105 * FIX SQ elements with actual length are now dealt with corectly
2106 * FIX gdcmFile::WriteBase make the difference, for color images, between
2107 the length (for Palette expanded images)
2108 and Raw Length (non expanded image + Palette)
2109 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2110 (that broke Write). Replaced by UL.
2111 Aware user will reload the field if he
2112 thinks it's necesssary
2114 2004-01-30 Jean-Pierre Roux
2115 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2116 when 'dirty Acr' is found, to be compliant with the new
2117 IsReadable() methods.
2119 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2120 (no DOUBLE images in kosher DICOM,
2121 but so usefull for people that miss them ;-)
2123 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2124 DICOMDIR related utilities (not checked as Windoze compliant)
2126 2004-01-28 Jean-Pierre Roux
2127 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2129 2004-01-27 Jean-Pierre Roux
2130 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2131 to allow skipping the shadow elements, to save memory space.
2132 The TRUE value for this param has to be used
2133 with a FALSE value for the 'enable_sequence' param.
2134 ('public elements' may be embedded in 'shadow Sequences')
2135 * gdcmHeader methods now deal with 'embedded icones images' in the header
2136 (even when an 'icone image sequence' is announced by the
2137 element (0x0088,0x0200), but there is NO icone at all ...
2139 * gdcmHeader sometimes Image Location value doesn't follow
2140 the supposed processor endianity (see gdcmData/cr172241.dcm).
2143 * gdcmHeader add the method
2144 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2145 to get *all* the Header Entries with the same tag.
2146 GetHeaderEntrySameName is probabely *useless*
2147 (no meaning : Name is *not* an identifier within the Dictionary)
2149 2004-01-26 Benoit Regrain
2150 * Bug fix in the print of hexadecimal representations. Remove long fields
2151 in the print and add a third level of print to print them
2153 2004-01-23 Benoit Regrain
2154 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2155 * Bug fix on test suite after remove the strip made on not string fields
2156 * Split the IsReadable method between gdcmParser which test that the file
2157 is dicom and gdcmHeader which test that it's an image file
2159 2004-01-22 Benoit Regrain
2160 * DicomDir : clean code, add methods, set variables in protected or private
2161 * gdcmUtil : bug fix for the clean string method
2163 2004-01-19 Benoit Regrain
2164 * Add the use of shadow dictionaries
2165 * bug fix and coding style
2167 2004-01-19 Benoit Regrain
2168 * src/gdcmFile.cxx : bug fix concerning the close of file
2169 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2170 * Add the update of header entries using the shadow library
2172 2004-01-19 Benoit Regrain
2173 * removal of file gdcmHeader2.cxx
2174 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2175 inheriting from gdcmParser. This split is to prepare the integration
2176 of dicom dir parsing
2177 * bug fix under python
2179 2004-01-16 Jean-Pierre Roux
2180 * REM removal of class gdcmHeaderEntrySet
2181 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2182 * ADD add file gdcmHeader2.cxx
2183 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2185 2004-01-15 Benoit Regrain
2186 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2187 entries created while parsing the header. Thus, they will be destroyed
2188 when the gdcmDictSet will be destroyed
2189 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2192 2004-01-15 Benoit Regrain
2193 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2194 made a fatal error because of the memory release at the end of program.
2195 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2196 some memory and vtk seems to have some problems with that.
2197 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2199 2004-01-14 Benoit Regrain
2200 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2201 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2202 * src/*.[h|cxx] : make changes due to class name changes
2203 * gdcmPython/demo/*.py : bug fix due to method names
2205 2004-01-13 Benoit Regrain
2206 * src/*.[h|cxx] : coding style
2207 * vtk/*.[h|cxx] : coding style
2209 2004-01-13 Benoit Regrain
2210 * gdcmPython/testSuite.py : test the readable flag of file for tests
2211 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2212 It's lied to the stl compilation by MSVC (windows, always windows...)
2213 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2215 2004-01-12 Benoit Regrain
2216 * src/*.h : add comments
2217 * src/gdcmDictSet.h : set the method BuildDictPath in public
2218 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2219 directly setted in the source code
2220 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2223 2004-01-09 Benoit Regrain
2224 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2225 * setup.py : use a reference to gdcmVERSION
2227 2004-01-07 Benoit Regrain
2228 * Modification to compile with the distutils.
2231 2003-12-10 Benoit Regrain
2232 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2233 can use a gdcmHeaderHelper to load data
2234 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2235 made in the source code
2237 2003-12-10 Benoit Regrain
2238 * Update Windows projects and .cvsignore files
2240 2003-11-12 Jean-Pierre Roux
2241 * ENH gdcmHeader constructor has one more parameter (default value : false)
2242 that allows the user to 'go inside' the SeQuences only
2244 gdcmElValSet:Print takes it into account
2246 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * ENH: Update gdcmPython/CMakeLists
2248 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2249 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2251 2003-11-10 Jean-Pierre Roux
2252 * FIX : gdcmHeader::LoadElements is now based
2253 on the ListTag listElem member,
2254 not longer on the TagElValueHT tagHt member
2255 * ENH : PrintPubElVal shows (temporarily) both results,
2256 with the tagHt member and the listElem member.
2257 (it's easier to 'see' the problems when using Printheader)
2259 * FIX : old private member LgrElem is now splitted into
2260 ReadLength : Length actually found on disk (updated only
2261 if bug fixing is necessary), for internal
2263 UsableLength : Updated by FixFoundLength, to fix a bug
2264 or to allow Parser going on.
2265 Will allow to re-write a kosher header when a SeQuence
2266 with a length (not 0000) is found
2267 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2268 because gdcmElValSet::Add does not update ListElem
2271 2003-11-07 Jean-Pierre Roux
2272 * FIX misstyping in Transfert Syntax name table
2273 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2274 when they have an actual length (not 0000 nor FFFFF)
2275 (Nobody should care of it, but DICOMDIR explorers)
2277 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2280 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * ENH: vtkGdcmReader now supports LUT !
2282 (vtkgdcmViewer for now is not able to use them though)
2284 2003-11-05 Jean-Pierre Roux
2285 * in testSuite.py : new files names for checking the package
2286 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2287 that returns the pixel area size to the *aware* (vtk) user
2288 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2290 2003-11-05 Benoit Regrain
2291 * in testSuite.py : Modify the rules for checking the paths
2292 : Explicit error messages
2293 * in __init__.py : Related modif
2295 2003-11-03 Jean-Pierre Roux
2296 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2297 to be used by aware (vtk) users that want to manage
2298 LUT (and no to turn the PALETTE image into an RGB pixels one)
2299 * GetPixelType now returns 8U for 24 Bits images
2300 (vtkGdcmReader compliant)
2302 2003-10-31 Jean-Pierre Roux
2303 * Removal of *all* gdcmData images and add them again
2304 in order to loose the 'history' of un-anonymised images
2306 2003-10-31 Jean-Pierre Roux
2307 * RMV : removal of useless jBitsInJsample.h
2308 for both 8 and 12 Bits JPEG Lossy Libraries
2310 2003-10-31 Jean-Pierre Roux
2311 * ENH : Add the functions gdcmFile::GetImageDataRaw
2312 gdcmFile::GetImageDataIntoVectorRaw
2313 that act as GetImageData and GetImageDataIntoVector
2314 except the making of an RGB Plane from Gray Plane + LUT
2315 Intended to aware (vtk) users who know how to manage
2318 GetLUTRGBA return a R,G,B,A LUT if any
2319 lgrTotaleRaw gives the 'Raw' length
2320 GetImageDataRaw returns the gray Plane
2321 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2322 (They stay Grey, just like with other Dicom viewers :-(
2324 2003-10-30 Jean-Pierre Roux
2325 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2327 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2329 being coherents dicom files.
2331 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2334 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2335 * ENH: Two steps is necessary to please VC++ compiler...
2336 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2337 * ENH: Add include dir to medcon lib
2338 * FIX: only one function is being exported for now !
2339 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2341 2003-10-29 Jean-Pierre Roux
2342 * adding gdcmHeader::GetLUTRGBA
2343 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2344 --> Mathieu, the modif u're waiting for is not yet committed
2345 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2347 2003-10-27 Jean-Pierre Roux
2348 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2349 00191113.dcm DermaColorLossLess.dcm
2350 MxTwinLossLess.dcm RadBWLossLess.dcm
2351 * ENH: For version prior to vtkImageViewer2 -r 1.19
2352 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2354 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2355 * Removal of ido stuff in CMakeLists.txt
2357 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2359 * FIX: remove a call to ->Modified ... see comments
2360 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2362 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2363 * FIX: Problem with path for libvtkgdcmPython
2364 * ENH: Try adding a search script for python site-package
2365 * RMV: Remove some file from medcon lib that are not necessary
2366 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2367 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2368 * FIX: More pragma disable fro VC++,
2369 I don't think I break something as it is also disable in VTK/ITK.
2370 But it fasten debug compilation time.
2372 2003-10-23 Jean-Pierre Roux
2373 * gdcm now deals with 16 Bits Run Length Encoded images
2374 (they are compressed as 2 planes images,
2375 one for the high Bytes, the other for low Bytes)
2377 2003-10-22 Jean-Pierre Roux
2378 * Now CheckRead takes into account :
2379 - the bugged 'Leonardo' Siemens images
2380 - the XA images, sent thru the burning VPRO station
2381 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2384 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2385 * FIX: When copying a Makefile.am to CMakeLists.txt
2386 one should remove the '\'
2388 2003-10-22 Jean-Pierre Roux
2389 * in gdcmData adding a bugged 'Leonardo' Siemens image
2390 (wrong lengths in header)
2391 OK with gdcm, KO with the other viewers :-)
2392 * add a GE dlx XA image, thru the VEPRO burning station
2395 2003-10-21 Jean-Pierre Roux
2396 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2397 for a brutal checking of vtkgdcmViewer compliance
2399 2003-10-21 Jean-Pierre Roux
2400 * add the files for 'xmedcon' Jpeg Lossless library
2401 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2403 2003-10-21 Jean-Pierre Roux
2404 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2406 2003-10-21 Jean-Pierre Roux
2407 * garbage Siemens 'Leonardo' images dealt with
2408 (the patch is easy to remove)
2409 * cosmetic changes to avoid warnings
2411 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2413 no need to press 'r' now.
2415 2003-10-20 Jean-Pierre Roux
2416 * upgrade of checkRead.sh checkWrite.sh according
2417 to new Jpeg Lossless decompressor
2418 * add US.3405.1.dcm, a genuine RGB medical file ...
2419 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2420 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2422 2003-10-15 Jean-Pierre Roux
2423 * general anonymisation in gdcmData
2424 * adding the 'color files' from
2425 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2426 * adding some well knowed bugged-header images
2427 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2428 waiting for their inclusion in Python testsuite
2430 2003-10-15 Jean-Pierre Roux
2431 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2432 no longer seg faults when file is not found
2434 2003-10-14 Jean-Pierre Roux
2435 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2438 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2439 * TODO: *.in file to genereate a UseGDCM later
2441 2003-10-14 Jean-Pierre Roux
2442 * Some supposed-to-be Dicom Images have no preamble.
2443 OpenFile takes it into account
2444 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2445 * Missing elements added in dicomV3.dic
2446 (just to be affraid : have a look at
2447 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2448 and do it again next year ;->
2450 2003-10-13 Jean-Pierre Roux
2451 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2452 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2453 But there are NOT. It's fixed !
2455 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2456 * FIX: "jpeglib.h" was not found on VC++
2457 * FIX: vtkgdcm was not being installed
2459 2003-10-10 Jean-Pierre Roux
2460 * ENH : OpenFile closes the file if it *really* doesn't look like
2461 an ACR-NEMA / DICOM one.
2462 * FIX : testWrite no longer writes an empty file if the source file
2463 is not gdcm Readable
2464 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2467 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2468 * FIX: CMake generate now documentation
2469 * ENH: out of source doc build !
2470 * ENH: Generate both user and dev documentation
2471 * ENH: Should work on windows too
2472 * ENH: Only one doxygen config.in file is needed
2473 * FIX: make install should be ok now on ùnix plateform
2474 * FIX: PATH to dictionary was wrong (missing /)
2475 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2477 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2478 * vtkGdcmReader is now able to read rgb dicom file.
2479 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2480 * added a gdcmViewer to vtk test, use mouse to control
2481 window level & window width
2483 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2484 * CMake-ification of gdcm, we have now two build system
2485 * FIX: on cygwin Wsock32 doesn't exist
2486 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2488 2003-10-06 Emanuel Ollart
2489 * FIX : compilation process wad broken.
2490 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2492 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2493 * change gdcmViewer -> vtkgdcmViewer
2494 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2496 2003-10-06 Jean-Pierre Roux
2497 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2498 ( e.g : well known GE images with a wrong elem length,
2499 : Philips MRI Images with a wrong Huffman table)
2500 * still to be done : allow the reading of bugged LEONARDO Siemens images
2502 2003-10-03 Jean-Pierre Roux
2503 * Odd length strings are padded with '\0' (not with spaces,
2504 to remain compliant with already defined strings,
2505 like Transfert Syntax UID and others)
2507 2003-10-03 Jean-Pierre Roux
2508 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2509 to allow displaying RGB images (not only by affim ;-)
2511 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * vtkGdcmReader is now able to read rgb dicom file.
2513 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2515 2003-10-03 Jean-Pierre Roux
2516 * A few nasty patches to allow the reading of a lot of nasty images
2517 ( e.g : well known GE images with a wrong elem length,
2518 : Philips MRI Images with a wrong Huffman table)
2519 * still to be done : allow the reading of bugged LEONARDO Siemens images
2521 2003-10-03 Jean-Pierre Roux
2522 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2524 2003-10-03 Jean-Pierre Roux
2525 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2526 to allow displaying RGB images (not only by affim ;-)
2528 2003-10-03 Jean-Pierre Roux
2529 * gdcmFile::GetImageDataIntoVector now
2530 - deals with MultiFrames MultiFragments Run Length Encoded files
2531 - deals with YcBcR (YBR_FULL) files
2532 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2533 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2535 (no sample found :-(
2537 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2539 Two reasons: - clear things
2540 - third parties acces gdcm through header files, so won't
2541 suffer anymore VC++ complains
2543 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2544 * add argv[1] in testvtkGdcmReader.cxx
2547 2003-09-24 Jean-Pierre Roux
2548 * The lines are now eigthy characters long.for
2549 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2551 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2552 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2553 char* to std::string. Thus, the use of strdup becomes useless. (see
2554 previous commis of Malaterre)
2555 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2556 before the last Malaterre's commit.
2558 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2559 * This commit should fix the Debug building under VC++, the problem
2560 was mainly a mixture of debug and release lib being loaded at startup.
2561 * I also remove a depency to a specific C function: strdup. Because I had
2562 to force the link to msvcrtd (whereas strdup is in libc).
2564 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2565 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2566 located in the gdcmCommon.h file. All use of reference of tha has been
2567 changed to now use the variable GDCM_UNFOUND.
2569 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2571 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2572 Dicom dictionary. The test suite can now be run again. Note:
2573 I'm note very happy with the " (RET)" changes. I believe this
2574 RETAINED comment should be dropped when parsing the dictionary.
2575 - PACKAGER corrected
2577 - AUTHORS updated and now in alphabetical order
2578 * Makefile.am now exports gdcm.dsw for Windoze users.
2580 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2581 * cygwin complains about missing std:: in subdir Test/
2583 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2584 * remove some methods that are now in gdcmHeaderHelper
2586 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2587 * vtkGdcmReader set spacing and origin correctly
2589 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2590 * Fix a few delete/delete[] mismatch
2592 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2593 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2594 interpretation to data given by gdcmHeader. For instance there are
2595 heuristics to get informations (look at different places).
2596 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2597 sorting DICOM images based on different strategies.
2598 * modified Makefiles accordingly.
2600 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2601 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2602 when building in debug mode
2603 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2604 src/win32/gdcmdll.dsp
2605 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2607 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2608 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2611 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2612 * src/win32/libgdcmjpeg12.dsp was not dos format
2613 * src/win32/libgdcmjpeg12.dsp :
2614 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2615 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2617 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2618 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2620 * src/gdcmFile.cxx : bug fix in affectation type
2621 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2622 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2623 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2624 symbols... future problem ?
2626 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * src/win32/libgdcmijpeg12.dsp was missing
2628 * modified gdcm.dsw accordingly
2630 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2631 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2633 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2634 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2635 commit of JPR (before his hollidays to facilitate our work).
2636 * setup.py : bug fix in code. Modifications made while the last commit
2637 of JPR. The code hasn't been tested before the commit... it's so
2638 useless to make that (for best programmer that is JPR) !!!
2640 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * tagged the current version as Version0_3 (i.e. version 0.3)
2643 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2644 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2645 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2646 * *.dsp : modifications to use new libgdcmijpeg8 library
2647 * setup.py : bug fix on VTKPATH variable
2648 * PACKAGER : adding all concerning windows
2650 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2653 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2654 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2655 test suite reported error.
2656 * PACKAGER file added (describes what a packager must do when
2657 packaging a new release).
2658 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2659 * configure.in: upgraded version number to 0.3.0
2660 * fixing build of rpm (through rpm -ta):
2661 - Doc/Makefile.am exports proper doxygen files
2662 - src/jpeg/libijg8/Makefile.am exports the include files.
2664 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2665 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2666 * src/gdcmHeader.h : formatting code
2668 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2670 We were obtaining error message from vtk. Now, creation of file list
2671 is made in an internal list to prevent this problem.
2672 Bug fix when output is empty.
2673 Bug fix in update of progress value. Previous commit for this was a bad
2675 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2677 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2678 * src/gdcmHeader.h : added method to get the file name
2679 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2680 files. Added method to remove all files on the input
2681 Added FIXME comment concerning the bad parsing of header made by
2682 ExecuteInformation method (in ExecuteData method)
2684 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2686 when using make instal.
2687 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2688 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2690 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2691 * setup.py : adding include dir of jpeg lib to compile all sources
2692 * */Win32/*.dsp : JPR fix for windows compilation
2694 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2697 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2698 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2700 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * setup.py is again effective on un*x (takes into account the
2702 addon of the jpeg library)
2703 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2704 * Doc/Doxy* updated (includes above enhancements)
2705 * INSTALL now points to web documentation
2707 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * src/gdcmHeader.h doesn't make unnecessary reference to
2710 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2712 * src/gdcm*.[cxx|h] :
2713 - to allow compilation with gcc 3.x
2714 -- clean up of STL usage (added explicit usage of std::)
2715 -- small fixes on exceptions.
2716 Note: linking not tested !
2717 - clean of doxygen comments to avoid warnings at documentation
2719 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2720 dependent convertion).
2722 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2723 * Clean up of previous JPR garbage commit (not even commented in the
2725 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2726 - moved all jpeg related files from src to src/jpeg/libijg8, with
2727 addition/modification of Makefile.am and configure.in.
2728 - the testSuite is still brain damage (not guilty).
2730 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2731 * WrapVTK.py : modifications to get correctly vtk source files to
2733 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2734 (FileName -> Filename)
2736 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * vtk/vtkGdcmReader.[cxx/h]:
2738 - UpdateProgress method should now be effective
2739 - removed the limitation on having only images loaded (as opposed
2741 - when building a stack of images/volume, a lesser number of
2742 gdcmHeader and gdcmFile instances should be used (hopefully
2743 accelerating things).
2744 - when building a stack of images/volumes, files which are not
2745 loadable (wrong path-filename, wrong permissions on existing file,
2746 or file not parsable by gdcm) are replaced with a black image
2747 in the stack (for the caller to notice the problem).
2749 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2752 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2753 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2754 between standard library (std) and vtk library (problems are found
2755 under Windows... thanks Windows !)
2757 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2758 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2760 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2762 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2763 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2765 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * When compiling with distutils (see setup.py) the C++ compiler is
2767 called with different flags than the default ones (with automake).
2768 In order to fix all those warning, I compiled gdcm with the command
2769 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2770 and went for warning fixes:
2771 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2772 up from unused variables.
2773 - vtk/vtkGdcmReader.cxx: potential bug fix.
2774 * src/gdcmHeader.h: Doxygen warning cleanup
2776 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * gdcmPython/gdcm.i:
2778 - typemaps correction to take into account the systematic replacement
2779 of "using namespace std" with std:: prefix e.g. std::list,
2780 std::string... (cf changes of 2003-05-21).
2781 - gdcmGlob global variable of type gdcmGlobal (defined in
2782 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2783 exported to Python a as cvar.
2784 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2785 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2786 gdcmDictSet.GetPubDictTagNames() and
2787 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2788 C++ static methods).
2789 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2790 with the above changes.
2792 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2793 * setup.py, manifest.in : bug fix under linux
2795 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2796 * Modification of setup.py to compile vtk part too. Then, we have 2
2797 wrappers which must work with same distutils. For that, we have a
2798 generic distutils in distusiltsWrapping.py ; with :
2799 - build_extWrap class to wrap generically all extensions,
2800 - ExtensionWrap base class for all wrapping extension that contains
2802 - Wrapper interface which wrap sources
2803 + In WrapSwig.py we have extension and wrapper for Swig
2804 + In WrapVTK.py we have extension and wrapper for VTK
2805 * MANIFEST.in : modifications to consider vtk directory and new python
2806 files for compilation
2808 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2809 * Added python wrappers of vtkGdcmReader vtk class (see the
2810 source in vtk/vtkGdcmReader.cxx) :
2811 - vtk/Makefile.am now builds a library
2812 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2813 python library (as opposed to _gdcm.so wich are the python
2814 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2815 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2817 - configure.in has an additional flag --enable-vtk that needs
2818 to be set to enable compilation of vtk related code, that is:
2819 + vtk/vtkGdcmReader.so and
2820 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2821 + gdcmPython/vtkgdcmPython.so (see above)
2822 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2823 be read when compressed or when HighBit + 1 != BitsStored),
2824 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2825 the usage of the python wrapper of vtkGdcmReader vtk class.
2826 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2827 * src/*.[h] all occurences of stl classes are now prefixed with
2828 std::, and all occurences of "using namespace std;" where removed.
2829 This is to avoid pollution of global namespace in included files.
2830 Apparently vtk does not avoid this pitfall: when using both
2831 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2832 collision of various stl members (principally cout...).
2833 * gdcmPython/testSuite.py now cleanly removes temprory generated
2835 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2836 comply with above changes)
2838 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2839 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2840 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2841 vtk data structure (an image Flip was required).
2842 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2843 * cosmetic changes in documentation.
2845 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2846 * src/gdcmHeader.cxx: the constructor no longer exits when an
2847 unexisting file is given as argument.
2848 * The subdirectory Data (containing all the images used for the
2849 test suite) is not part of this repository anymore. A new module
2850 containing those images is now available at
2851 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2852 with the name gdcmData.
2853 All the python scripts (including the package initialisation file
2854 gdcmPython/__init__.py) were adapated to take this change into
2855 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2857 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2858 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2859 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2860 demo of the usage of this class.
2861 Compilation of this vtk part is only done when using the --enable-vtk
2862 at configure (or autogen.sh) stage.
2864 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2865 * More memory link related corrections and documentation fixes.
2867 - maximum info is obtained with a command of the form:
2868 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2869 --show-reachable=yes PrintHeader
2870 - the remaining reachable blocks seem to come from the STL
2871 allocation scheme through the usage of map and list. It looks
2872 like this memory cannot be freed but it is not a memory leak
2873 (in fact further invocation to the STL would recollect the
2874 unused memory allthough it cannot explicitely be freed).
2875 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2876 of displaying an image parsed with gdcm and displayed with VTK.
2877 Note: some images don't seem to work e.g.
2878 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2879 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2880 Allthough this weakens the semantics, it is a ditch attempt to
2881 make gdcm more thread friendly.
2883 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2884 * Memory link hunt (by using valgrind through the command
2885 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2886 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2887 gdcmHeader::_dicom_vr.
2888 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2889 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2891 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2893 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2894 * src/Makefile.am now exports all the necessary include files at
2898 * UpdateGroupLength replaced by new one
2901 * UpdateGroupLength re-written using H-Table
2902 (named UpdateGroupLengthNew untill checks are over)
2904 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2905 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2906 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2908 - gdcmHeader::GetPubElValSet removed.
2909 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2910 UpdateGroupLength, WriteElements, Write.
2911 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2912 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2913 carried the same semantics.
2914 - src/gdcmHeaderIdo.cxx changed accordingly.
2915 - gdcmFile::WriteBase now regroups all the codes from previous
2916 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2917 - enum FileType moved to gdcmCommon.h
2918 * src/gdcmHeader.cxx AddDefault trashed
2919 * gdcmGetXSize added
2920 * getimageDataSize now calls gdcmGetXSize
2921 * Test/*.cxx changed to agree with above changes
2923 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2924 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2925 (to avoid double call by end user).
2926 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2927 by end user, since gdcmHeader::gdcmHeader now handles it.
2929 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2930 * gdcm/Doc many doxygen changes:
2931 - Doxyfile now has two different versions, DoxyfileUsers that generates
2932 the html.users end users oriented documentation and
2933 DoxyfileDeveloppers that generates the html.developper developper
2934 oriented documentation.
2935 - README changed accordingly
2936 - requirement.txt removed (old design info moved to TODO).
2937 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2938 DoxyMainPage.txt, DoxyPython.txt provide more information.
2939 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2940 be updated by simply regenerating the docs with doxygen and copying
2941 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2942 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2943 all the tests in the form "if (<map>.count() >1)" were removed.
2944 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2945 ill-formed documentation sections.
2946 * src/gdcmHeader.cxx: ditto
2948 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * setup.py fixed for un*x (needed macro for stdint.h)
2950 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2951 un*ces with sh-utils test utility.
2952 * gdcmPython/demo/test.py renamed to PrintHeader.py
2953 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2954 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2955 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2956 * src/gdcm*.cxx JPR's bad inclusion fixed.
2958 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2960 * gdcmPython/demo/test.py changed accordingly.
2962 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * gdcmPython/Makefile.am fixed linking against libstdc++
2964 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2965 * Swig subdir (historical tests of swig version 1.3.17++) removed
2966 * Test/testChangeEntete.cxx some lines commented out in order to make
2968 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2969 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2971 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2973 hence the user doesn't need this explicit call.
2974 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2975 i.e. LoadElements() call removed.
2976 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2977 - src/Makefile.am declares the proper flag for g++.
2978 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2979 for adding user defined new tags.
2980 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2981 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2982 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2984 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2985 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2986 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2987 src/Makefile.am : the project should properly compile and install
2988 with the autotools, included the python wrappers part.
2989 * gdcm.spec.in : added a spec file for RPM packaging.
2991 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2992 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2994 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2996 to exported to the environement (see gdcmPython/testSuite.py
2998 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2999 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3000 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3001 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3002 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3004 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3005 * gdcmPython/__init__.py doesn't crash anymore when running in
3006 in InstallMode or PreInstallMode but with an environment given
3007 value of GDCM_DICT_PATH.
3008 * src/gdcmDictSet.[cxx/h] coding style.
3010 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3012 * src/gdcm.h general comments moved to TODO, and README
3013 * src/gdcm.h should now be seen as a user commodity (including it
3014 should suffice to fully use gdcm). It is nowhere including within
3015 any of the kernel files src/*.cxx and src/*.h.
3017 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3019 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3021 * src/gdcm*.cxx only include their corresponding include file
3022 (as opposed to gdcm.h)
3023 * gdcmPython/gdcm.i changed accordingly
3024 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3025 the autogen.sh generated "make snapshot" command to work.
3026 * autogen.sh removed history related references to crea package.
3028 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * distutilsSwigCPlusPlus.py work around some swig portability
3032 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3034 was done in a last ditch attempt to get setup.py _really_
3035 operationnal. The python/gdcmPython layaout add the advantage
3036 of hidding away the python related distutils specific files
3037 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3038 Alas, the src directory was out of scope (i.e. it's relative
3039 position to setup.py was ../src) which made things impossible to
3040 handle (see previous version of python/setup.py). Crossing fingers...
3042 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3043 * python/setup.py now works on Un*x. (harder than I thougth)
3044 * python/distutilsSwigCPlusPlus.py can now have include files
3045 among the list of sources.
3047 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3048 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3049 * modifications in MSVC projects
3051 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * As stated by the first lines of Test/ExceptionAndPython/README, it
3053 looks like we can move back to original usage of exception within
3054 src/gdcm* and hence remove the errno stuff that was introduced
3055 as a quick and dirty fixture of this problem (added to the TODO).
3056 * Doc/Doxyfile configuration file for Doxygen and corresponding
3057 README file for usage added.
3058 * Test/testWrite.cxx added. This new test comes from a split of
3059 test.cxx that is now reverted to its original purpous i.e.
3060 testing the proper parsing of a Dicom related file.
3061 testWrite.cxx concentrates on testing the IO part of gdcm.
3062 * Test/bug1.cxx (containing a bug on WIn32) added.
3063 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3064 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3065 whose purpose is to publish the content of the TagNames of the
3066 Dicom public dictionary were not accessible without an
3067 instance of class gdcmHeader.
3068 - those methods are now static methods of gdcmDictSet and hence
3069 require no instances at all to be invocated.
3070 - within gdcmDictSet this change required to change some method
3071 to class methods (i.e. are now static) among which SetDictPath
3072 (renamed to BuildDictPath) and LoadDefaultPubDict.
3073 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3074 the above changes by calling the new method classes of gdcmDictSet.
3075 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3076 the above to be effective.
3077 * python/gdcmPython: in order to wrap properly the above changes
3078 for Python, swig version now needs to be > 1.3.17.
3079 * python/gdcmPython/Makefile fixed to adapt itself to new
3080 configure/make shema introduced by Johan Montagnat (thanks for the
3081 contribution). Alas this Makefile cannot be turned into a proper
3082 Makefile.am without some heavy changes in the configure.in
3083 (for python dectection).
3084 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3085 now avoids publishing the empty entries.
3087 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3088 * python/setup.py : bug fix concerning install under windows
3089 ExtraPath reused :-P
3090 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3092 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3093 * Dicts/dicomV3.dic : remove double spaces !!!
3094 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3095 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3098 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3100 method. Doxygenation.
3101 * src/gdcm.h clean up of JPR spurious comments.
3103 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * python/distutilsSwigCPlusPlus.py now properly collects the
3105 shadow classes generated by "swig -c++" (gdcm.py in our case)
3106 when using "python setup.py install".
3107 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3108 reexports the working classes.
3109 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3110 by the classical C errno scheme. This is to prevent an obscure
3111 behavior of the python wrappers when importing wxPython.wx prior
3112 to gdcmPython (which ended up in an abort call). An illustration
3113 of this oddity can be found in the Test/ExceptionAndPython
3114 subdir (see the README file). This problem probably due to
3115 an combination of g++ and dynamic loading.
3116 * added Test/ExceptionAndPython (see above)
3118 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3119 * Changed the layout of the python part to avoid bloating main
3120 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3121 i.e. the distutils arsenal. All the python related stuff is
3122 again in a python subdir, but the package itself is now in
3124 * setup.py was cleaned up:
3125 - pythonIncludePath removed
3126 - python setup.py bdist target is now functional.
3127 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3128 collision with other packages). gdcmPython/demo/*.py changed
3131 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3132 * python subdir moved to gdcmPython (preparation of distutils packaging).
3133 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3134 distutils installer is operational.
3135 * - gdcmPython/__init__.py now properly loads the swig generated
3136 shadow classes (from gdcm.py).
3137 - gdcmPython/demo/*.py changed to import the package gdcmPython
3138 instead of gdcmPython/demo/load.py.
3139 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3141 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3143 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3144 entries within the associated public Dicom dictionary resp. the same
3145 information but sorted by the fourth field (PAT, IMG, DIR) of the
3147 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3148 are now in the "???" group.
3149 - python/gdcm.i changed accordingly,
3150 - python/demo/printGroupedPublicDict.py added, that gives an example
3151 of the above new functionalities in Python.
3153 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3154 * src/gdcm.h, gdcmHeader.cxx:
3155 - historic references to glib's g_malloc and g_free (#defined)
3156 were definitively removed.
3157 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3158 * src/gdcmElValSet.cxx:
3159 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3160 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3161 - GetElValue(string) renamed to GetElValueByName.
3162 - Added GetElementByName(string).
3163 * src/gdcmHeader.cxx: added
3164 - GetPubElValRepByNumber(guint16, guint16)
3165 - GetPubElValRepByName(string)
3166 - GetShaElValRepByNumber(guint16, guint16)
3167 - GetShaElValRepByName(string)
3168 - GetShaElValByNumber(guint16, guint16)
3169 - GetShaElValRepByName(string)
3170 - GetElValRepByNumber(guint16, guint16)
3171 - GetElValRepByName(string)
3172 - GetElValByNumber(guint16, guint16)
3173 - GetElValRepByName(string)
3174 * Doc/requirements.txt added.
3176 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3177 * Test/Makefile building now depends on the one of libgdcm.so
3178 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3179 pixel data) aware which enables finding the address (offset) of
3180 the pixel data of JPEG encoded DICOM files. This leaves only a single
3181 file in the testSuite whose pixel data address (offset) is unknown.
3182 * python/testSuite.py changed accordingly.
3184 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3185 * VC++ has some strong limitations when working with the STL, as stated
3186 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3187 "Also note that some STL containers (map, set, queue, list, deque)
3188 cannot be exported. [...]
3189 Some STL classes contain nested classes. These classes can not
3191 This is caused by a designed limitation that once a template
3192 class is instantiated, it can not be re-instantiated and
3194 Since our usage of map<> is ubiquitous in gdcm, this "designed
3195 limitation" of VC++ is a pitfall.
3196 Hence the Python wrappers of gdcm cannot be incrementally linked
3197 against the c++ dynamic library. The dirty but only workaround is
3198 to forget about incremental link of dynamic libraries and to generate
3199 the Python wrappers library with the inclusions of the underlying C++
3201 The following modifications concern this matter on Win32/VC++:
3202 - wrapping python correct with standalone wrapped dll (don't use separate
3203 dll under windows !!!!)
3204 - python21_d debug mode enabled (ask Frog how to use it :-)
3205 - NO problem with having an STL member of class for example string in C++
3206 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3207 - Python test of dcmlib in Python is ok under windows on a large set
3209 * removed glib references
3210 * typedef's inserted in gdcm.i for correct swig type management
3212 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3213 * python/demo/*.py load.py extracted from test.py. Added explore.py
3214 that only displays required tags and testAll.py that parses all
3215 the files of the testsuite without using unittest.
3216 * python/testSuite.py other additional test on new files added.
3217 * Data/* new test files added accordingly to the testSuite.
3218 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3219 the vr in the file differs from the one of the dictionary.
3221 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3222 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3223 values, but limits itself to values which are below a user specified
3224 size (by default 1024 bytes).
3225 * python/gdcm.i : elements not loaded (because their size is above the
3226 user specified treshold) are exported with their TagKey as key of the
3227 python dictionary. This enables the testsuite to make some checks
3228 on the unloaded elements (since we have their offset and size).
3229 * python/testSuite.py
3230 - now tests for the existence and proper value of the pixel data
3231 - two new examples added.
3232 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3234 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3235 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3236 aware. See the strategy comments in gdcmHeader::FindLength().
3237 * Test/test.cxx now accepts a filename as first argument.
3238 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3239 * python/testSuite.py changed to integrate test on above files.
3241 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3242 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3243 the vr was also RET.
3244 * python/testSuite.py more tests added.
3246 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * python/testSuite.py unittest test suite added (uses Data)
3248 * Data/* dcm and acr files for the test suite.
3249 * glib dependance removed from un*x version. We now use ISO C99
3250 7.18 Integer types (see stdint.h)
3251 - python/Makefile, src/Makefile src/gdcm.h
3252 * src/ when an explicit vr (like dicom files) suddenly poped an
3253 implicit element we use to mark the underlying DictEntry of the
3254 concerned ElValue with "Implicit". This strategy was damageable
3255 too the public or provite dictionaries, since some of their vr
3256 would be changed. Since Header::FindLength heavily relies on the
3257 detection by Header::FindVR of falsely explicit elements, I
3258 added an extra ImplicitVr member to ElValue (boolean).
3259 The rest of the changes we the necessary adaptations.
3261 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3262 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3264 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3266 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3267 * Adaptation for porting to VC++:
3269 o forced to use std namespace (for string to be known)
3270 o all class use __declspec export style on WIN32
3271 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3272 (in stdlib.h on Win32 but in std:: for gcc)
3273 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3274 variable GDCM_DICT_PATH.
3275 * src/gdcmHeader.cxx verbose comments made discrete.
3277 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * python/gdcm.i: added a typemap that converts a C++ hashing table
3279 to native Python dictionary.
3280 * python/demo/test.py:
3281 - now uses the native dictionary for exploration of gdcmHeader.
3282 - takes an optional filename argument (the file to parse).
3283 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3284 PubElVals hashing table.
3285 * Dicts/dicomV3.dic removed error prone trailing spaces.
3287 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3288 * Python wrapping process moved away from src/Makefile to
3289 newly created python/Makefile (as well as gdcm.i)
3290 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3291 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3292 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3293 from the environement variable GDCM_DICT_PATH (when existing).
3294 * src/gdcmDict::GetTag bug fix.
3296 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * Straightforward temporary fixes for swig to build the python wrappers.
3298 src/Makefile now has a python working entry [by working we mean
3299 that we can import the shadow classes without errors].
3301 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3302 * hashtest.cxx removed (since already in Test)
3303 * src/gdcmlib.h renamed to src/gdcm.h
3304 * src/dcm.i renamed to src/gdcm.i
3305 * src/Makefile prepared for python wrapping
3307 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcmHeader.cxx :
3309 - Parsing of header is now separated from loading of element values
3310 (see gdcmHeader::LoadElements).
3311 - general clean up of hopefully all file access (creation of
3312 ReadInt16 and ReadInt32)
3314 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * src/gdcmHeader.cxx :
3316 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3318 - SetLgrElem renamed to SetLength
3319 - GetLgrElem renamed to GetLength
3320 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3321 * src/gdcmElValSet.cxx fixed both GetElValue methods
3322 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3323 due to IdoDude was cleaned out.
3325 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3326 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3327 concentrates on finding the value representation (when it exists).
3328 RecupLgr now only finds the element value length, and it avoids
3329 returning the unecessary skL (skipped length).
3330 Also, offsetCourant was simply removed (with taille_fich) since
3331 it was redundant with the File position internals (by using
3332 ftell and fseek). This also made skL (see above in RecupLgr) usage
3334 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3335 on the libido specificities which are handled through class
3337 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3340 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3341 * Truckload of changes. Parsing of header is barely functional
3342 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3344 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * src/gdcmHeader.cxx many addons of low level methods
3347 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3349 and _IdDcmSWAP_LONG.
3351 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3352 * This corresponds to all the changes decided at the meeting of
3353 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob