1 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * FIX 'Dictionnary' is now spelt 'Dictionary'
3 'wether' is now spelt 'whether'
4 'archieve' is now spelt 'archive' ;-)
6 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
8 related methods, in order not to expose internal mechanisms
11 * REM methods that exposed internal mechanisms :
12 DicomDir::GetDicomDirPatients()
13 DicomDirPatient::GetDicomDirStudies()
14 DicomDirStudy::GetDicomDirSeries()
15 DicomDirSerie::GetDicomDirImages()
26 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Removed the Print/indent/default parameter mess. There is absolutely no
28 reason to have to methods, moreover with the second takeing the ostream as
29 *SECOND* parameter. This was clearly a bad hack to get things compile.
31 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Complete rewrite of the GetMacAddress code. Now the code is *much*
33 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
34 Unfortunately the main code does not work on SunOS, thus provide a specific
35 code for this platform only (and Win32 of course). Since this seems to be
36 working, change CreateUniqueUID to use GetMACAddress instead of the
37 problematic getIPAddress
39 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Unfortunately to be able to test gdcmDirList I had to break the API
41 a little. Now the class is not a std::list anymore but has a member
42 std::vector (more ITK compatible). Allow unit testing on Win32 and
45 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * Update SerieHeader to take into account a Serie Instance UID to properly
49 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
50 * ENH - Comment out Mathieu's (dangerous) Super Hack
51 for dealing with BIGENDIAN processors
52 - Move equivalent stuff to BinEntry::WriteContent
53 When necessary, 16 Bits Pixels are swapped in a small buffer
54 and then written. This avoid allocating a huge buffer, in
55 PixelWriteConveror, and avoid modifying the Pixel Area.
57 Probabely, the same operation will have to be done when we want
58 to write image with Big Endian Transfert Syntax,
59 and we are working onj Little Endian Processor
61 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
64 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
65 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
67 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
69 * Test/TestDict.cxx : add a new test for the dict classes
71 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
72 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
73 file. Debug is yanked if compiled with NDEBUG
75 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/gdcmDictSet.h : set the default output to the os variable
77 * src/gdcmDictEntry.[h|cxx] : add the Print method
78 * gdcmPython/demo/ : add a new test
80 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
81 * merging of Test/PrintDicomDir and Test/TestDicomDir
82 * removal of now redundant Test/PrintDicomDir
83 * enhancement of Example/PrintDicomDir
85 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * Now, python test might work on systems
87 * Add the PrintDicomDir test
89 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
90 * FIX : First entry following group 0002 was lost for
91 Explicit Big Endian Transfer Syntax files
92 (group and elem not swaped)
94 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
95 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
96 Big Endian Transfer Syntax supposed the group following 0002
97 begins always by element 0000 (element 0000 is *optional*)
98 To avoid further troubles, let's be pessimistic, and use
99 Document::HandleOutOfGroup0002() method
100 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
101 (related pb not yet solved)
103 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * Bug fix for the python part use
105 * Now, PrintHeader.py pass... but outside the ctest use. shit !
107 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
110 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
112 a string and should ask the global TS dict what are the propreties of
115 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
117 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
118 to swap the Swap Code, at parsing time, when we come out of group 0002
119 and Transfer Syntax is Big Endian
120 We should be able to read now 'true DICOM" Big Endian coded images
121 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
122 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
124 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Hopefully fix the bug on MacOSX and static global initialization.
126 This is the only -minor- patch I found that both please MacOSX and VS6.
127 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
128 but this would require a lot of change. Another approach would be that Global
129 create those string and GDCM_UNFOUND becomes a pointer to a string (which
130 gdcm::Global would destroy at exit).
132 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
133 * Fix bug on MacOSX with static initialization in a multy threaded
134 environment. static const string in a header file used to be ill
135 initialized provoquing the freeze of any tests. patch should solve this
138 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
139 * According to Benoit's suggestion, and without any objection from anybody
140 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
141 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
142 - method gdcmDicomDirObject::GetEntry() renamed as
143 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
145 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
146 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
147 you debug/warning message just as c++ streams which make them very convinient
148 to use. Once this is stabilize I will change the ostringstrem to be
149 redirected to a file (ofstream).
150 * Properly support C99 extension: __FUNCTION__ which allow us to display
151 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
153 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
154 * Removal of useless and dangerous methods :
155 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
156 GetDocEntryByName, GetEntryByName, GetDictEntryByName
157 * Removal of usless methods :
158 Dict::PrintByName, Dict::GetDictEntryByName
159 * Commenting out of probabely useless methods :
160 Dict::GetDictEntryNames()
161 Dict::GetDictEntryNamesByCategory()
162 DictSet::GetPubDictEntryNames()
163 DictSet::GetPubDictEntryNamesByCategory()
164 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
165 * ENH : Use dicomTS.dic as described in 2004 version
166 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
167 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
168 Add Accessors on VM (Value Multiplicity), and VM related methods
169 * ADD : Add a list of 'Dicom Attribute types', as found in
170 http://medical.nema.org/dicom/2004/04_15PU.PDF
172 * ADD : Add dicomGroupNameAbbreviations.dic
173 should be used to write a method to replace the former
174 Dict::GetDictEntryNamesByCategory()
176 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
178 to read in the file... and only it ! Length is the efective length of the
179 data in the DocEntry structure
181 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
183 And now use a static function call instead, with a global variable. i
184 This is much closer to the VTK approach. Hopefully should be bulletproof
185 and easier to use...hopefully
187 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
188 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
190 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
193 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
195 ValEntry, BinEntry, SeqEntry creation or replace
197 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
199 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
201 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
202 when specifying the VR
203 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
204 * src/gdcmDocEntry.cxx : amelioration of print
206 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
207 * ADD : Add the method Util::IsCurrentProcessorBigEndian
208 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
209 * ADD Method Document::ComputeGroupLength
210 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
211 in order to allow further VR modification by user
212 * REM : removal of once-called method File::WriteBase
213 integration of its code in formerly one-line method File::Write
215 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
217 replace the different values "??", "Unkn", "Unknown".
218 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
219 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
220 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
221 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
223 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
226 * Set the gdcm::Base class to some Printable classes
228 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmFile.[h|cxx] : add the Print method
230 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
231 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
232 * src/gdcmDocument.h : remove the PrintLevel informations
233 * Example/PrintFile.cxx : use the new gdcm::File::Print
235 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
237 problems when compiling with the python wrapping
239 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
241 writting in ImplicitVR
243 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
244 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
245 JPEG decompression, especially when dicom frames are split into several
246 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
247 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
249 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmHeader.cxx : change the initialisation of default header.
251 Now, this header is readable by gdm, e-film, DicomWorks
253 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
255 Rename Decompressed to Raw
256 * Use the API changes in gdcm::File.
257 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
260 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
262 each added entry in the header. Replace the 'Planes' field by the 'Number
265 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
267 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
269 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
271 At this time, this image isn't readable by e-film... waiting JPR help to
274 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
276 DocEntry. Now use methods of the Document !
278 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * Test/ShowDicomSeq.cxx : bug fix
281 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
283 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
284 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
285 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
287 * Test/TestCopyRescaleDicom.cxx : remove unused variable
288 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
289 containing found sequences
291 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
294 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
295 Some fields in BinEntry must be copied to not seg fault when making the :
296 gdcm::File *copy = new gdcm::File( copyH );
297 and tests are now made on good variables
299 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
301 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
303 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
304 * Add vtkGdcmWriter example and test
306 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * Test/TestUtil.cxx : reformat the source code
308 * vtk/vtkGdcmReader.cxx : remove and change prints
309 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
311 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
312 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
314 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
316 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
318 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
320 by an eof to prevent all bad read of the file... and in this case, the
323 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * Example/Volume2Dicom.cxx : comment unused variables
325 * Test/PrintDicomDir.cxx : comment unused variables
326 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
327 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
328 method that is redondant with AddEntry.
329 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
332 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * Bug fix due my last commit (compilation under Windows).
334 * Example/Volume2Dicom : bug fix in the file and reformatting source code
335 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
337 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
339 - Remove printf / sprintf
340 - include iostream AFTER gdcm so we don't get warnings
341 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
343 - Also remove tons of include from header files, hopefully this should
344 speeup the compilation time, since it was becoming a dog slow.
345 - Remove gdcm.h as it include way too many files and slow down compilation
346 (plus it is not up to date)
347 - remove 'using namespace std' this is BAD !
349 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * Remove memory leaks on the DicomDir
351 * Remove some useless data in DicomDirObject
352 * Add usefull methods in SQItem, to be complient withe the ElementSet
354 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
357 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
359 future, with convertion)
360 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
361 and ImageDataSize values. Remove the method to get the PixelReadConverter
362 from the output of the class
364 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
367 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
369 and vtkErrorMacro use.
370 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
372 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
373 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
375 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
376 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
377 The string leaves only in the fonction. So when we make a .c_str(), we
378 get the pointeur on the first element, element that will be destroyed
379 immediately after thee instruction.
380 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
381 file has been opened : the test must be made on the content of the
382 pointer and not directly on the pointer !
385 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
387 the python part recompiles
389 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
390 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
391 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
392 X session is killed (for my computer... it seems to not be identic on
395 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
397 avoid problems (otherwise, the difference test between the visible image
398 and the reference is incorrect. If the reference is greater than the
399 screen resolution, it's produce errors).
400 Can be used for only one image. Can be used with a visible flag.
401 * vtk/vtkGdcmReader.cxx : remove commented codes.
402 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
403 under windows at compilation
404 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
406 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
408 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
410 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
411 tests on the image size X, Y, Z
413 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
415 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
416 between the class name and the file name
418 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/ : fix compilation warnings for the Write method (2 different
420 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
421 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
422 variable... create a static method in gdcm::Document to access to
423 this variable content.
425 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
427 file, to be accessed by other files (like gdcmFile). Remove commented
428 code. Move the change of the header to the gdcmFile, using the
430 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
431 To be sure of that (and simplify calls), the Write of the header now
432 gets a file name and not a file pointer (std::ifstream).
433 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
434 DocEntryArchive. Remove all open of the written file
436 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
439 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
441 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
443 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
444 some corresponding methods. Write correctly the file and check before
446 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
447 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
448 is now on RGB data (as before my last commit
449 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
451 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
453 Add a print information of the type of the entry
454 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
455 It was in the gdcmFile, and all write have been regrouped
456 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
457 Write correctly all dicom files (in decompressed mode only at this time)
458 * Test/ : test on files are now made using Raw data and not color data if
460 * Example/PrintFile.cxx : add more printings
462 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * Amelioration of code, remove some code copy. For the loading of
464 BinEntry (in gdcmDocument), add the test to verify if the file is already
467 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
469 remove a DocEntry in the header (push an empty DocEntry)
470 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
471 lines. Bug fix in the initialization of the PixelConvert and the
473 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
474 use in TestCopyDicom (now this test can run under windows... but fails)
475 * Test/TestCopyDicom.cxx : amelioration of the test :
476 - test the pixels written
477 - add test points to quickly find where is the error
478 - can set a file name input and output in arguments
479 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
480 amelioration of the test output
482 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
484 all replaced DocEntry's
485 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
486 Now, each needed DocEntry to modify is duplicated, modified and inserted
487 to the header using DocEntryArchive. Thus, after save, we can restore the
488 header initial state.
490 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
493 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
495 correct to copy it. The DictEntry is specified at the DocEntry creation,
496 then, it musn't change in the time.
497 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
498 header correctly. At this time, the change is only made for the first
499 level of the Document. In the future, it might consider sequences.
500 The change is made by replacing a DocEntry by an other that is created
501 outside the class. The old value is kept. When we restore the header
502 status, the added DocEntry is deleted and replaced by the old value.
503 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
504 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
505 set the write type to explicit VR, implicit VR or ACR. Add methods to set
506 the write mode to native, decompressed or RGB (but not used at this time)
508 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
510 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
512 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
514 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
516 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
517 set because already copied when copying the BinEntry's of the header
518 * Test/TestAllReadCompareDicom.cxx : remove warnings
520 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
522 Two problems appear when doing it :
523 - with the gdcmFile : when the GetImageData method is called, the pixels
524 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
525 data (pixels). And each structure destruct the data when it's
526 destructed. So we have two destructions for the same data. To solve it,
527 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
528 data or not. If it doesn't own data, then they will not destroyed by
530 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
531 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
532 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
533 create a double destruction of the same DocEntry's. So, to solve it,
534 the TagHT is simply cleared and the DicomDir* elements are destroyed.
535 * TODO : add an entry concerning memory leaks in the DicomDir
537 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
539 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
542 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
544 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
545 after it have been deleted
547 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * FIX: src/* fix the doxygen warnings.
549 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
550 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
551 was erroneously defined with a size of 15 instead of 16. [many thanks
552 to Jean Michel Rouet for pointing out this bug].
554 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 1. Finish merging JMR patch for writting DICOM from scratch
556 2. Fix -hopefully- bug with MONOCHROME and space vs null character
557 3. Use const ref when possible
558 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
559 5. A few more comments
560 6. CreateUniqueUID can now be called without parameter"
562 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
563 * ENH: Slightly bigger patch:
564 1. Getting toward full integration of JMR patch for writting dicom from scratch
565 2. Update Test to test part of this patch: CreateUniqueUID
566 3. File was not close properly in gdcmDict
567 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
568 5. Use of const ref instead of copy (speed issue)
569 6. Remove temporary (duplicate) string in TranslateToKey
570 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
571 8. Do not repeat virtual in subclasses
572 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
574 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
575 * Apply first patch toward better string comparison when dealing with broken
576 DICOM files. Essentially the string could be padded with a space instead
577 of a null character as defined by standard
579 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
581 because never used... and in the same time, that's remove some memory leaks
583 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/gdcmFile.cxx : now delete the PixelConvert instance.
585 * In examples and tests : change the type of image data variables from void*
586 to uint8_t*. Remmove all delete on image data variables
588 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
590 Verify the file pointer value before open the file, and if it's not null,
591 a verbose message is generated.
592 Close correctly the file when the file isn't considered dicom-like. The
593 correctly close is a call to CloseFile.
594 When closing the file pointer, test if its not null to close the file.
595 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
596 file. For an uncompressed image, the copied data correspond in the least
597 case to the image size (calculated) or the image size specified in the
598 header. A verbose is generated if these two size mismatch
600 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
602 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
603 break under windows (with msvc6 compilation).
605 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
607 compiling with MSVC6)
609 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * Bugs fix for the Windows build with VC6
611 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
612 needed (only for projects required VTK). If the VTK is included in all
613 projects, there is conflicts with the jpeg lib of vtk when compiling the
614 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
615 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
616 when compiling the gdcm_wrap.cxx file (created by the compilation of the
618 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
619 (like it's already made for the cout use). Otherwise, conflict with the
622 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
625 - comments on the DicomDir::Method related usage added.
626 - now that we use the namespace gdcm, a lot of internal classes do
627 NOT need to be wrapped anymore.
628 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
629 DicomDir::Method) new example added.
631 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
632 * Improve string manipulation. I now inforce the notion of 'DicomString'
633 A DicomString can contain as many \0 as they want
634 and it is *always* of even length.
635 We only support odd length for very rare case.
636 And in the near future this should be removed.
638 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 * /binary_write/ gdcm source. Now even on big endian we are writting
640 little endian. This should -heopfully- fix some tests
642 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
643 * Now the dictionary is compiled into gdcm lib. This is a default
644 behavior, thus any dic file specified is picked before failback to
645 the one comiled into lib
647 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 * Change internals for gdcmDict. Don't use any 'new' any more.
649 This should definitely solve any leak problem, and we should be
650 as fast as before, as long as don't modify too much the dictionary.
652 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
653 * STYLE: ivars should start with a capital letter.
654 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
655 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
657 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
659 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
660 new 2004 dictionaries added (thanks to JPR).
661 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
662 * CLEANUP_ROUND (15) for gdcmPixelConvert
663 - RLEFrame::NumberFragments is now of type unsigned int
664 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
665 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
668 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * Initial work in gathering all transfer syntax accessors. clearly
670 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
671 ivars, but only one transfersyntax (class) ivar with equivalent method on
674 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
675 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
676 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
677 discussed (plus I didn't like having a 2000 lines patch not commited)
679 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
681 * CLEANUP_ROUND (14) for gdcmPixelConvert
682 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
683 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
684 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
686 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
687 anymore and hence avoids storing a copy of PixelConvert::Decompressed
688 into File::Pixel_Data.
690 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
691 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
692 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
693 * CLEANUP_ROUND (13) for gdcmPixelConvert
694 Substituted File::ParsePixelData() with PixelConvert::Print() new
696 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
697 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
698 method to those classes.
699 - src/gdcmFile.[cxx|h]:
700 -- Added a ::Print() method.
701 -- PixelConverter is now a reference instead of a member.
702 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
703 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
705 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
707 collaboration diagram and inheritance diagram should be generated with
709 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
710 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
711 pointlessly wrapped (see
712 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
713 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
714 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
715 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
716 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
717 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
718 -- File::Initialise: PixelConverter setup moved away to
719 PixelConverter::GrabInformationsFromHeader()
720 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
721 interpretation moved away to PixelConverter::BuildRGBImage()
723 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
724 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
725 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
727 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
729 displayed on Win32 when a brutal abort() occurs (because of uncatched
730 exception). See TODO new entry of this commit for more on this.
731 * TODO added new entry.
732 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
733 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
734 - HandleColor is no longer called from gdcmFile.cxx
735 - gdcmPixelConvert.cxx clean up on method arguments and internal
736 variable names for semantical coherence.
738 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
739 * Finished lossless transition, not only do we now read all lossless jpeg
740 images, without the need of the Cornwell lib, but we do read them properly now
741 * To reduce code (well to avoid code duplication), I defined a common place
742 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
743 redefine symbols. This is not perfect but this the best solution I found for a
744 compilation time jpeg option.
746 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
747 * Update jpeg ijg lib to support lossless jpeg implementation
748 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
750 * Also added a special copyright for dcmtk since we use their bugfixes.
753 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
754 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
755 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
756 matters, as stated in warning note at begining of %include section).
757 * src/gdcmDicomDir*.[cxx|h]: coding style
758 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
759 * src/gdcmJpeg8.cxx: doxygen fix.
760 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
761 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
762 from File:: to PixelConvert::.
764 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
766 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
767 - more code moved away from File:: to PixelConvert::
768 - fat setup of PixelConverter set in place in File::Initialise.
770 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
771 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
772 namespace at the file system level. So now you should convert your examples
774 gdcmHeader -> gdcm::Header
775 It would be nice if people keep in mind to no open the namespace, since it
776 allows compilation on broken plateform which were defining common symbol in
777 the standart namespace (like LP, Unknown ...)
779 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
781 The JPEG fragments are now parsed at the same stage than the RLE
782 information. All code related to JPEG is now in gdcmPixelConvert:
783 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
784 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
785 export a gdcmFile:: method. Those are simply global functions
786 (for the time being this is better than having them attach to
787 either gdcmFile:: or gdcmPixelConvert::).
788 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
789 and stores the result in a gdcmJPEGFragmentsInfo.
790 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
791 code (among other stuff) moved away from gdcmFile:; to
794 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
796 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
797 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
798 clean up of RLE related code.
799 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
800 - src/gdcmRLE.cxx removed
801 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
802 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
803 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
804 * CLEANUP_ROUND (9) for gdcmPixelConvert
805 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
806 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
807 away from gdcmFile:: to gdcmPixelConvert::.
809 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
811 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
812 This is because Parse7Fe0 used to parse the pixels to compute the
813 length. This task was passed over to FindDocEntryLengthOB() a long
814 time ago, EXCEPT I had forgotten the OW case...
815 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
816 we just recylce the code for parsing RLE fragments and computing
818 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
819 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
820 with the retired Parse7Fe0().
821 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
822 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
824 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
826 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
827 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
828 - src/CMakeLists.txt: alphabetic order reodering + new entries.
829 * CLEANUP_ROUND (4) for gdcmPixelConvert
830 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
831 to return an unused length.
833 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
834 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
835 this should be cleanner from the plane view. The iostream are erally a pain
836 to use to do simple stuff.
838 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
839 * Redo the compilation of the ijg jpeg library. Now only one source is
840 necesseray. No need to rename file by hand what so ever. CMake handle the
841 copying of the file within different directory, configure header file to
842 modify some symbol. The only addition made to ijg wasd a mangle table so
843 that symbol are different whether we are within 8bits or 12bits.
845 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
846 * Added documentation of vtkgdcmReader on Website:
847 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
848 with it's binary name).
849 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
850 the Website to be more complete.
851 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
852 doxygenated documentation.
853 - Doc/DoxyVtkGdcmReaderExamples.txt added
854 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
855 DoxyVtkGdmReaderExamples.html )
856 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
857 * CLEANUP_ROUND (3) for gdcmPixelConvert
858 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
860 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * CLEANUP_ROUND (2) for gdcmPixelConvert
862 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
864 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * CLEANUP_ROUND for gdcmPixelConvert:
866 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
867 - src/gdcmPixelStuff[h|cxx] removed
868 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
869 - src/CMakeLists.txt changed accordingly
871 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
872 gdcmVersion.py moved to newly created ATTIC related
873 gdcmPython/SetupOldies/ directory.
874 * Autotools clean up:
875 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
876 - autogen.sh configure.in acinclude.m4 python.m4 removed
878 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * src/*.cxx *.h Reference to License.htm fixed to License.html.
880 * Doc/CMakeLists.txt, doxygen.config.in: fix.
881 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
883 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
884 * TODO updated with Mathieu suggestions. I proposed a template for
885 describing TODO entries and used it for new entries.
886 * Added Doc/Website/CodingStyle.html, Developpers.html,
887 DeveloppersPython.html, GdcmDataCvs.html and
888 DownloadVersion0_1.html, DownloadVersion0_3.html.
889 * Some Doc/*.txt Doxygen files (which do not really concern the
890 documentation itself, but the website) moved to html and
891 placed in directory Doc/Website:
892 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
893 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
894 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
895 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
896 * CMakeLists.txt changed accordingly.
897 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
898 DeveloppersPython.html
899 * INSTALL nows refers to Doc/Website/Installation.html
901 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * Added Doc/Website directory, that contains a first raw version
905 2004-09-23 Jean-Pierre Roux
906 * FIX In order not to be poluted any longer by casting problems,
907 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
908 we can now delete[] it safely
909 * VoidArea is now called BinArea (less confusing name),
910 and all the methods called ...VoidArea... are now ... BinArea...
911 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
913 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
915 clear) TagHT, which is an inherited member of gdcmElementSet. It is
916 up to the destructor of gdcmElementSet to clean up TagHt and it's
919 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * Test/CMakeLists.txt: update to follow gdcmData renamings.
921 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
923 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
924 * ENH: added some utility method that builds a flat dictionary
925 holding all the Dicom entries contained in the recursive structure
926 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
928 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
929 BuildFlatHashTable() that build a flat dictionary.
930 - src/gdcmElementSet.h: added a new private GetTag() accessor.
931 gdcmDocument is now a friend of gdcmElementSet.
932 - src/gdcmElementSet.cxx: clean up.
933 - Example/FlatHashTablePrint.cxx added.
934 - Example/CmakeLists.txt changed accordingly
936 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
938 moved away from gdcmDocEntrySet (since this class is an abstract class
939 acting like an interface). SQDepthLevel and BaseTagKey are now
941 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
942 and associated accessors. Doxygenation of the class.
943 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
945 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
946 Use SQDepthLevel accessor instead. ::Print() adapted.
947 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
948 - src/gdcmDocument.cxx changed accordingly.
950 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
952 - The following is the doxygen comment of the typedef declaration
953 of gdcmTagKey in src/gdcmCommon.h:
954 gdcmTagKey is made to old an "universal" (as in URL, Universal
955 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
956 A dicom tag always has a group and an element, but a set of tags
957 embeded in various (optionally nested) sequences and sharing
958 the same group and element all share the same (group, element)
959 "identifier". Hence the (group, element) cannot be used as an
960 identifier (in gdcm we shall refer to a "TagKey") of a tag.
961 In order to construct a proper tag identifier (i.e. a key) we
962 consider the following definition of a TagKey:
963 - let Group, Element be the string representation of the
964 group and element dicom tag members,
965 - let ItemNumber be the string representation of the integer
966 index of the considered item number of a sequence,
967 Let the key of a tag embeded in a sequence, noted SeqTag, be
969 /ItemNumber#Group|Element
970 where "/", "#" and "|" are characters acting as separators.
971 Then the general form of a gdcmTagKey is given by:
972 Group|Element<SeqTag>
973 where <SeqTag> means NO or many instances of SeqTag.
974 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
977 but the gdcmTagKey of a tag "embeded" is the first item of
978 a sequence, itself nested in the third item of a sequence is the
980 0004|1220/2#0008|0082/0#0008|0090
981 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
982 order to hold the new sequence compatible key. Previously, the
983 GetKey() method would look in the underlying gdcmDictEntry.
984 - src/gdcmDocEntry.cxx:
985 -- constructor now copies the underlying DictEntry key, in the local
987 -- ::Print: displays the member Key, instead of the (group, element).
988 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
989 - src/gdcmDocEntrySet.h:xi
990 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
991 -- now has a new BaseTagKey member.
993 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
994 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
996 This poses the problem with the semantics of the following lines
997 LoadEntryVoidArea(0x0028,0x1201); // R LUT
998 LoadEntryVoidArea(0x0028,0x1202); // G LUT
999 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1000 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1001 to the long FIXME note for what the problem is. Nevertheless in
1002 order to get things working the dicom dictionary was altered !
1003 Please fix things urgently...
1004 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1005 information), see above note on moving the member VoidArea. Nevertheless
1006 the following entries previously correctly set as US are now inproperly
1008 0028 1201 OW IMG Red Palette Color Lookup Table Data
1009 0028 1202 OW IMG Green Palette Color Lookup Table Data
1010 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1011 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1012 of gdcmDocEntry moved to gdcmSeqEntry.
1013 * src/gdcmSeqEntry.cxx: STYLE.
1015 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1018 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * gdcmPython/testSuite.py: all the test suite in python is now moved
1020 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1021 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1022 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1024 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1026 to avoid inclusion recursion until STL is reached.
1027 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1028 mecanism. errno.h is not included in gdcm anymore.
1029 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1030 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1032 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1033 gdcmData/TestAllEntryVerifyReference.txt
1034 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1035 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1036 exception_on_error parameter.
1037 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1038 - vtk/vtkGdcmReader.cxx changed accordingly,
1039 - Example/*.cxx and Test/*.cxx changed accordingly.
1041 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1043 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1044 enable_sequences removed from gdcmHeader constructor and dependencies.
1045 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1046 * gdcmPython/demo/PrintHeader.py: dummy fix.
1047 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1048 skip_shadow removed from gdcmHeader constructor and dependencies.
1049 * Example/*.cxx and Test/*.cxx changed accordingly.
1051 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1053 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1055 2004-07-21 Jean-Pierre Roux
1056 * FIX Now, Parsing and Printing a DICOMDIR do work!
1057 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1059 2004-07-20 Jean-Pierre Roux
1060 * FIX Some brain damaged headers have Zero-Lenght fields
1061 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1063 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1064 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1065 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1066 variable (instance of gdcmDebug) by a definition macro, and the instance
1067 is now in static in the gdcmDebug class
1068 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1069 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1071 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * WARNING: ctest now depends more tightly on gdcmData. You should
1073 check out gdcmData properly for things to run smoothly...
1074 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1075 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1076 we need the pixels not be loaded in order to use the ValEntry
1077 that displays position and size).
1078 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1079 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1080 be deprecated. If you have any doubts about the advantages of a
1081 modern scripting language (read Python) versus grass root C++ (i.e.
1082 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1083 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1084 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1085 Anyhow, consider documenting the gdcmData images in
1086 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1088 * Test/CMakeLists.txt:
1089 - now uses TestAllEntryVerify.cxx
1090 - specific comments on oldACR00001.ima (now renamed in gdcmData
1091 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1092 gdcmData/TestAllEntryVerifyReference.txt
1095 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * src/*.[h|cxx] : typedef clean up
1097 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1098 - TagKey renamed to gdcmTagKey (for external usage)
1099 - VRKey renamed to gdcmVRKey (for external usage)
1100 - removal of typedef duplication.
1101 - Removed all unecessary inline keyword from class inline definitions.
1102 - Some method|function(void) declarations replaced with method|function().
1103 * src/jpeg/libijg12/jdhuff12.c:
1104 - printf polluting ctest removed.
1105 - TAB removal for comminting
1107 - TestAllReadCompareDicom.cxx: added a test that compares all the
1108 images in gdcmDataImages.h with corresponding images in
1109 gdcmData/BaselineDicom/. When baseline images are not present
1110 this test creates them.
1111 Note: we need to validate each reference image, but before that
1112 I'd like to rename them with a more explicit name...
1113 - CMakeLists.txt: changed accordingly.
1114 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1115 including each header needed).
1117 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1119 test suite to the Example directory. Are concerned:
1124 - TestWriteSimple.cxx
1125 * Test/CMakeLists.txt: added some comments on reasons for black listing
1126 image gdcmData/oldACR00001.ima
1128 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * Test/CmakeList.txt: removed the following from black list (to be coherent
1130 with removal from gdcmData):
1131 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1132 - gdcm-MR-PHILIPS-16.dcm
1134 Added the following because after last cvs update, they cause
1135 ctest -R TestReadWriteReadCompare
1137 - gdcm-MR-SIEMENS-16-1.acr
1139 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1140 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1141 new comments in this file) we temporarily (sigh) move to a weaker
1143 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1144 we don't need to black list the following images anymore:
1145 - 8BitsUncompressedColor.dcm
1147 - US-PAL-8-10x-echo.dcm
1148 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1149 fixes and the beautified code ;-)
1150 This fixes the bug introduced in version 1.42 (when beautifying)
1151 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1152 Note: ctest was blind to this bug (this means we need to still
1153 improve the test suite). The bug could be detected by using
1154 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1156 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1157 and by displaying the (garbage) produced file temp.XDCM...
1159 2004-06-29 Jean-Pierre Roux
1160 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1161 - replace by uggly but working old code :-(
1162 A lot of things should be OK again.
1163 It's really urgent to have a test suite that *tests*,
1164 to prevent Frog's beautifying sessions to break all the stuff
1165 (twice, withing a fortnigh ...)
1167 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1169 redundancy) to added Test/TestReadWriteReadCompare.cxx
1170 * Test/CmakeList.txt: because the compare test of
1171 Test/TestReadWriteReadCompare.cxx fails, the following images are
1172 black listed: - 8BitsUncompressedColor.dcm
1174 - US-PAL-8-10x-echo.dcm
1175 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1176 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1177 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1178 and ad-hoc kludge. This kludge is now removed, and on encountering
1179 such an image (OB field brain damaged) we set errno. Then in
1180 ::FindDocLength() we "fix" the length as being ALL what remains
1181 in the file (until EOF). We then proceed, hoping for the best...
1182 This fixes a SegFault in ShowDicom when trying to write such an
1184 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1185 (because TestWriteRead breaks on it, after a non conformal commit?).
1186 ctest now runs properly, except for MakeDicomDir (which was always
1187 broken) and the Python related stuff (still not fixed).
1189 2004-06-24 Jean-Pierre Roux
1190 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1191 FIX : Test/TestReadWrite now iterates on all the file names
1192 (instead of infinite loop)
1193 ENH : Test/TestWriteRead now iterates on all the file names
1195 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1198 2004-06-24 Jean-Pierre Roux
1199 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1200 when SamplesPerPixel =3
1201 - now Write is no longer confused by
1202 'BitsAllocated = 12" and 'BitsStored=12"
1203 - "UN" value representation Elements are now written correctly
1204 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1205 ENH : - now gdcmHeader has its own Write methods
1206 (in order to split the job that has not to be done
1209 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1210 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1211 loop on the same image until memory went out.
1212 Note: this means we still have gobs of memory loss in PrintDocument
1213 * src/gdcmDocument.cxx: fixes problem on parsing on file
1214 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1216 2004-06-24 Jean-Pierre Roux
1217 FIX : Write - All the Sequences and Sequence Item are now written
1218 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1219 is added a the end, when necessary.
1220 - A lot of brain-damaged images, that were read correctly are
1221 now written correctly
1222 - length compatible BinEntry are now loaded correctly
1223 (even for odd groups)
1224 Note : only Explicit Value Representation was checked.
1225 (question : is implicit VR really necessary for gdcm ?)
1227 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * DEVELOPPER: added a proposition of coding style.
1229 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1232 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1234 Use the gdcmDocEntry::Print() and Write() instead.
1235 * src/gdcmDocument.cxx: bug fix.
1237 2004-06-22 Jean-Pierre Roux
1238 FIX : gdcmDocument.cxx
1239 - Now we do recognize the JpegLossLess format (there was a misstyping in
1240 code 'beautyfication' :-(
1241 - Now we automaticaticaly load the Luts, if any
1243 2004-06-22 Jean-Pierre Roux
1244 In order : to write Sequences, whatever their imbrication level,
1245 : to allow user to create his own Sequences
1246 a lot of modif where necessary (adding, moving, or virtualising methods)
1248 WARNING : save your own sources *before* cvs up !
1251 ADD virtual void Write(FILE *fp, FileType filetype);
1254 ADD virtual void Write(FILE *fp, FileType filetype);
1255 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1258 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1259 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1260 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1261 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1262 ADD std::string GetEntryByName(TagName name);
1263 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1265 std::string vr = "unkn",
1266 std::string fourth = "unkn",
1267 std::string name = "unkn");
1268 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1269 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1270 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1271 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1272 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1273 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1274 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1275 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1278 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1279 ADD virtual std::string GetEntryByName (TagName tagName);
1280 ADD virtual std::string GetEntryVRByName (TagName tagName);
1281 REM virtual bool Write(FILE *, FileType);
1282 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1283 FILE *_fp, FileType type);
1284 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1285 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1286 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1287 REM virtual std::string GetEntryByName (std::string tagName);
1288 REM virtual std::string GetEntryVRByName (std::string tagName);
1289 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1290 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1291 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1293 std::string vr = "unkn",
1294 std::string fourth = "unkn",
1295 std::string name = "unkn");
1296 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1297 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1298 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1299 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1302 ADD virtual void Write(FILE *fp, FileType filetype);
1305 ADD virtual void Write(FILE *fp,FileType filetype);
1308 ADD virtual void Write(FILE *fp, FileType filetype);
1309 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1310 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1311 REM std::string GetEntryByName(TagName name);
1314 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1316 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1317 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1318 The default constructor invoked by the line
1319 gdcmHeader *f1 = new gdcmHeader( header );
1320 was gdcmHeader::gdcmHeader(bool) instead of the expected
1321 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1322 Hence the parsing wasn't executed... See also below.
1323 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1324 as explicit constructor didn't do the trick to fix the above problem.
1325 Could anyone explain why ?
1326 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1327 properly calls gdcmValEntry::Print() (that was weed out from
1328 code related to gdcmBinEntry).
1330 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * In order to fix memory leaks:
1332 - Test/TestWriteSimple.cxx: added cleaning of free store through
1334 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1335 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1336 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1337 (through the call to ::AddDicomDirMeta()) or the destructor
1338 would crash when deleting uninitialized ::metaElems].
1339 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1340 - src/gdcmDocument.cxx:
1341 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1342 from dynamic stores.
1343 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1344 was causing memory leaks.
1345 - src/gdcmSQItem.cxx:
1346 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1347 cleanly handled with polymophism: sorry but my milage is low).
1348 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1349 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1350 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1351 This avoids SegFaulting.
1352 - src/gdcmSQItem.h: coding style.
1354 - Test/TestWriteSimple still severely sucks. The output image content
1355 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1356 damaged when displayed with vtkgdcmViewer.
1357 - on memory leaks: TestWriteSimple leaks really less (see entry
1358 of 2004-06-18 in Changelog file for the call to valgrind).
1359 - on segfaults: ctest now passes all the tests but one (no more
1361 * Erroneous leading white fix:
1362 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1363 white[s] (as opposed to from >> xxx, that removes it [them].
1364 - src/gdcmTS.cxx: ditto.
1365 - gdcmPython/testSuite.py: dirty related kludge removed.
1366 * src/*: remaining references to gdcmParser removed.
1367 * src/*[cxx|h]: added copy[way]left header.
1370 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * In order to fix writing of dicom files:
1372 - Test/TestWriteSimple.cxx: a simpler example of writing.
1373 - Test/CMakeLists.txt changed accordingly.
1374 - src/gdcmDocument.cxx:
1375 -- The destructor now recursilvely removes potential sequences.
1376 -- Bug fix in ::IsJPEG2000()
1377 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1378 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1380 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1381 to only declared) and build on top of
1382 ::GetDocEntryByNumber(guint16, guint16).
1383 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1384 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1385 for usage in destructor and treatement of promotion in
1386 ::ReplaceOrCreateByNumber().
1387 - src/gdcmSQItem.cxx: destructor should better handle his job.
1388 Test/TestWriteSimple now runs (or at least it DOES something).
1389 * We can now start hutting memory links. A good starting point is:
1390 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1391 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1392 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1394 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1395 * Valgrind note: after Mathieu Malaterre teached me how to read
1396 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1398 Using gcc, you can force the STL to use malloc and to free memory as
1399 soon as possible by globally disabling memory caching.
1400 With 3.2.2 and later, you should export the environment variable
1401 GLIBCPP_FORCE_NEW before running your program.
1402 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1403 simply vanish (it is still not clear to me, whether this means that
1404 STL std::string leaks or if valgrind believes it leaks...).
1405 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1406 running bin/gdcmTests makeDicomDir):
1407 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1408 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1410 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1411 SegFaulting (I drowned in DicomDir related code when trying to
1412 understand why the list is empty...).
1413 * src/gdcmDocument.h: first BSD license header try.
1414 * Doc/License.txt added.
1416 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * src/gdcmDocument.[h|cxx]:
1418 - Clean up of the Transfer related predicates. They are now all based
1419 on new method isGivenTransferSyntax, that (should) handle properly
1420 the padding problem.
1421 - general clean up, simplification, and coding style.
1422 - Specific clean up of Parse7FE0() (umproperly named actually).
1423 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1425 2004-06-14 Jean-Pierre Roux
1427 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1428 - fix the display of SQItem ordinal number
1429 - add the GetSQItemByOrdinalNumber method
1430 - remove some useless never written private methods
1432 2004-06-14 Jean-Pierre Roux
1434 - adding a constructor taking a gdcmDocEntry as an input param
1435 - ReplaceOrCreateByNumber now returns :
1436 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1437 a gdcmValEntry * if a string value is passed as a param
1439 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1440 according to the param type (no longer sets a gdcmDocEntry)
1441 - GetValEntryByNumber, GetBinEntryByNumber added
1442 - NewValEntryByNumber and NewBinEntryByNumber added
1444 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1446 - GetSQItemNumber and SetSQItemNumber added, to provide
1447 a (relative) Item identier inside a given Sequence
1448 \warning : some pb remaining around this number
1450 - AddEntry now takes the Item Number as a param
1452 - adding a constructor taking a gdcmDocEntry as an input param
1454 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * Memory leak hunt with the following command:
1456 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1457 --show-reachable=yes gdcmTests PrintDocument
1458 It looks like many (all?) leaks are due to the STL (or a bad usage
1459 of the STL. The lines producing the leaks now have a comment with
1460 a "MEMORY LEAK" tag: you can retrieve them with
1461 grep "MEMORY LEAK" src/*
1462 Here are two typical examples which I can't help fixing:
1467 char * test = "babo";
1468 name = test; //// <--- valgrind detects 960 bytes lost in
1469 //// call to std::string::operator=(char const*)
1470 name.clear(); //// Doesn't help !
1478 std::cout << "Type a bunch of characters followed by RETURN: ";
1479 getline(std::cin, line); //// <--- valgrind dectects a loss
1480 //// of 1320 bytes in call to
1481 /// std::basic_istream<>& std::getline<>
1487 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * src/gdcmHeader.[cxx|h]:
1489 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1490 and related, moved away to gdcmDocument.
1491 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1492 the corresponding protected accessors of inherited class
1493 gdcmDocument, removed ! As a consequence gdcmFile had to be
1494 declared friend of class gdcmDocument (see below).
1495 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1496 - Clean up of undefined or unused methods.
1497 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1498 account the changes to gdcmHeader.h).
1499 * src/gdcmDocument.h:
1500 - gdcmFile is now a friend class (in order to take into account the
1501 changes to gdcmHeader.h).
1502 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1503 (see changes to gdcmHeader.h).
1504 - Accessors (reading on the form GetEntry*) are now public.
1505 - Clean up of undefined or unused methods.
1506 * src/gdcmDocument.cxx:
1507 - adaptation to changes to gdcmDocument.h
1508 - ::OpenFile now writes a verbose message when file cannot be opened.
1509 - some std::string properly set to VRKey
1510 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1511 references to gdcmDocument.
1512 * Test/TestFindTags.cxx: changed accordingly to above changes.
1513 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1514 cvs repository gdcmData.
1516 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1518 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1519 conflicts with gdcmValEntry::voidArea.
1520 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1521 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1522 Value representation between StringRepresentable and BinaryRepresentable.
1523 * src/gdcmDocument.cxx:
1524 - method ParseDES: proper indentation restored and usage of
1525 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1526 - method LoadDocEntry: the fingerprint left in the SetValue() of
1527 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1528 removed. Reverting to previous code segment with the proper
1529 dynamic_cast< gdcmValEntry* >.
1530 Note: this was (partially) breaking the python test suite
1531 (gdcmPython/testSuite.py) that made usage of the above
1532 fingerprint to check presence of "Pixel Data".
1533 * src/gdcmDocEntry.h: coding style.
1534 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1535 now taken into account.
1536 * gdcmPython/gdcm.i: adaptation to the new internal representation
1537 of gdcm (exit gdcmParser, hello gdcmDocument).
1538 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1540 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1541 anymore, but instead prints the loaded Python dictionary.
1542 * .... alas, the python testSuite is still broken.
1544 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1545 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1547 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1548 * src/gdcmUtil.h : export methods
1550 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1553 * Initial addition of automatic python testing
1554 * Initial addition of automatic image comparison
1556 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1557 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1558 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1560 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1561 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1562 * Test/ShowDicom.cxx : bug fix for msvc compilation
1563 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1565 2004-05-04 Jean-Pierre Roux
1566 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1567 new concepts (and new classes) :
1568 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1569 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1570 - Sequence Doc Entries (gdcmSeqEntries)
1571 a Sequence is composed of Items.
1572 Each item is a set of Doc Entries (this is recursive)
1573 The non uniqueness of the 'Dicom tag' is due to this recursivity
1574 (never taken into account)
1575 Our unability to add a new 'entry' in the header
1576 at the proper location (neither in the H-Table (map or multimap),
1577 nor in the Chained List is also due to this recursivity.
1578 Don't try, right now, to use/modify/compile these new sources :
1579 nothing is finished.
1580 We just commit all the stuff, 'as is', in order not to loose it.
1582 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1583 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1585 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1586 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1587 file prefix (SetFilePrefix)
1589 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * Add a new test: ShowDicom, for now this is just the c++ version of
1591 checkRead.sh, later it will be able to compare the image read against a
1593 * Replace the DEBUG on the stack with a global entry in cmake interface:
1594 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1596 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1597 * Add an example subdir, with a real example on how to read + write a
1600 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1601 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1602 * Doc/CMakeLists.txt: the main page is now properly differentiated
1603 between the developper and user version.
1604 * Doc/doxygen.config.in: dropped search related obsolete flags
1605 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1607 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1608 * DEVELOPPER: added some helpfull comments for compile/test/install
1611 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1613 src directory, now generated in the build dir.
1614 2. Tests as mentionned smarter
1616 4. Add a new method in gdcmDict that return the PubDict by name
1617 this is interesting for 3rd party lib like ITK,
1618 where we could set the institution name / patient name...
1620 * ENH: 1. Now the test suite is working for real
1621 2. All binaries are now output in the gdcm-bin directory
1622 (this was not true before)
1624 2004-04-28 Jean-Pierre Roux
1625 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1626 SeQuence indented printing of Dicom Header.
1627 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1628 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1629 Computation of SQDepthLevel is now part of gdcmHeader constructor
1630 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1631 tree-like structure of a Dicom Header.
1632 * FIX Test code cleaning
1634 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1635 * ENH: Adding automatic testing
1636 1. Need a DartConfig.cmake to submit to public
1637 2. Add a test driver gdcmTest.cxx
1638 3. gdcmTestMain, an helper for the main test driver gdcmTest
1639 4. Files in Test don't have a main anymore, this becomes interesting
1640 when we add more and more tests, thus dsw don't have to load
1642 * ENH: Adding a GDCM_DATA_ROOT for testing
1643 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1644 one file instead of seven + some small cleanup
1646 2004-04-22 Jean-Pierre Roux
1647 * ENH Minor changes to the Print() methods.
1648 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1649 Header printing. Example given with :
1650 > PrintHeader fileName 2 new
1651 (SQ based tree-like structure still to be done for the Header ...)
1653 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1655 1. I have added some unsigned where needed
1656 2. Some function parameter not used -> (void)
1657 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1658 4. g++ don't like character '\' in comment
1659 5. #define jpeg_create_decompress jCreaDecompress
1660 this really need to be fixed
1661 6. virtualize destructor of gdcmObject ... leakage
1662 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1663 this also really need to be fixed
1664 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1665 remove compression file
1666 (as we only do decompression, right ?)
1667 * ENH: Change malloc/calloc/free with c++ equivalent
1669 2004-04-21 Jean-Pierre Roux
1670 * FIX gdcmHeaderHelper::GetXSpacing
1671 when a single value is found (bug ?), xpacing is now
1672 defaulted to yspacing
1674 2004-04-19 Jean-Pierre Roux
1675 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1676 * ENH add parameters :
1677 bool exception_on_error = false,
1678 bool enable_sequences = false,
1679 bool ignore_shadow = false
1680 to the gdcmFile constructors to be full gdcmParser compliant
1681 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1682 to allow reading of PAPYRUS 3.0 files
1684 2004-04-06 Jean-Pierre Roux
1685 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1687 2004-04-02 Jean-Pierre Roux
1688 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1689 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1690 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1692 2004-03-30 Jean-Pierre Roux
1693 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1694 for ACR file, written out as DICOM files (hope so...)
1696 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1698 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1699 moved to base class gdcmParser and only the specialisation is kept
1701 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1702 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1703 already does the job.
1704 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1705 (to be consistent with gdcmParser::WriteEntries).
1707 2004-03-30 Benoit Regrain
1708 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1709 upate of the object's instance. It's passed to 2 in the unfavorable
1710 case : one in the ExecuteInformation, one in the ExecuteData
1712 2004-03-29 Jean-Pierre Roux
1713 * ENH : Check on file type to be written moved
1714 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1715 * FIX : gdcmObject::ResetBoundaries now stops properly
1716 when end-of-list is reached
1717 : gdcmVersion modified (as Benoit Regrain asked)
1719 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1720 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1721 * src/gdcmUtil.cxx: added forgotten iostream include.
1722 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1723 equivalent to ExplicitVR in existing code).
1725 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1727 now contains all the gdcmGlobal related code.
1728 * minor coding style and doxygenation changes.
1730 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1731 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1732 now contains all the Debug related code.
1733 * minor clean-up of includes in src/*.cxx
1734 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1735 CreateCleanString) removed.
1736 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1737 * Doc/DoxyMainPageUser.txt added.
1738 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1739 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1740 src/gdcmDirList.cxx)
1742 2004-03-24 Jean-Pierre Roux
1743 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1745 2004-03-23 Jean-Pierre Roux
1746 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1747 big endian made volumes
1748 * ENH Now gdcmParser constructor and destructor are protected to forbid
1749 end user to instanciate class gdcmParser
1750 (only gdcmHeader and gdcmDicomDir are meaningfull)
1752 2004-03-22 Benoit Regrain
1753 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1754 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1755 gdcmSerie to gdcmDicomDirSerie
1757 2004-03-19 Jean-Pierre Roux
1758 * ENH Now the tree-like structure describing a DICOMDIR comming from
1759 an already existing DICOMDIR file is consistent with
1760 the home-made tree-like structure build ex-nihilo
1761 or build from the files held (recursively) in a Directory
1762 functions gdcmDicomDir::CheckBoundaries()
1763 gdcmObject::SetBoundaries() added
1765 2004-03-17 Jean-Pierre Roux
1766 * REM (Eric Boix bug) : removal of meaningless
1767 gdcmDicomDirImage::NewImage function.
1768 * FIX now file names and directory name are written properly in the
1770 * FIX now gdcmDicomDir constructor may be call without any trick
1773 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1775 of gdcmDicomDirImage::NewImage as empty function.
1777 2004-02-28 Jean-Pierre Roux
1778 * ENH add gdcmDicomDir:NewPatient
1779 add gdcmDicomDirPatient:NewStudy
1780 add gdcmDicomDirStudy:NewSerie
1781 add gdcmDicomDirSerie:NewImage
1782 to allow making gdcDicomDir object.
1783 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1784 (as opposite to the gdcmHeader chained list)
1786 2004-02-11 Benoit Regrain
1787 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1788 when using from python
1790 2004-02-10 Benoit Regrain
1791 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1792 * FIX : in gdcmDicomDir when the directory is empty
1793 * ENH : add callback and methods to get the progression of dicomDir
1796 2004-02-06 Jean-Pierre Roux
1797 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1798 - GDCM_META added to gdcmDicomDirType
1799 - class gdcmMeta created
1800 * ENH : - A brief summary is now displayed at the beginning of
1801 'testDicomDir' to help disaster magnitude estimation
1802 * REM : Now useless Test/explDICOMDIR.cxx
1804 2004-02-05 Benoit Regrain
1805 * ENH : add methods in gdcmObject to get the hash table or the list of
1807 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1808 * FIX : wrapping python for TagHeaderEntryHT
1810 2004-02-04 Benoit Regrain
1811 * FIX : even length for some strings when writting the dicom dir
1812 * FIX : sort the images in the dicom dir
1813 * FIX : Bug fix for python use of dicom dir
1814 * ADD : a python demo
1816 2004-02-04 Jean-Pierre Roux
1817 * FIX : Final solution (?) for icone embedded images
1818 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1819 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1820 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1821 gdcmData/gdcm-MR-SIEMENS-16.acr1
1822 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1823 to make full checking easier
1825 2004-02-04 Benoit Regrain
1826 * FIX : WriteEntries : coding style & logic in parameters
1827 * FIX : Set the elements to create the DicomDir in a dictionary file
1829 2004-02-03 Benoit Regrain
1830 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1831 * gdcmDicomDir : add the load of directory
1832 * Bug fix and print add-on
1834 2004-02-03 Jean-Pierre Roux
1835 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1836 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1837 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1838 * FIX gdcmParser.cxx : 'group length' elements are now considered
1839 as integers, even for shadow groups, when file is Implicit VR
1841 2004-02-02 Jean-Pierre Roux
1842 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1844 of the last synonym :-(
1845 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1847 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1848 * FIX taking into account the possible 7fe0,0010 multiplicity
1849 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1850 to allow removal of references to 7fe0,0010, to deal with
1851 ACR-NEMA images, when 0028,0200 is meaningfull
1853 2004-01-31 Jean-Pierre Roux
1854 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1855 no longer writes 'Un' on disk
1856 * FIX SQ elements with actual length are now dealt with corectly
1857 * FIX gdcmFile::WriteBase make the difference, for color images, between
1858 the length (for Palette expanded images)
1859 and Raw Length (non expanded image + Palette)
1860 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1861 (that broke Write). Replaced by UL.
1862 Aware user will reload the field if he
1863 thinks it's necesssary
1865 2004-01-30 Jean-Pierre Roux
1866 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1867 when 'dirty Acr' is found, to be compliant with the new
1868 IsReadable() methods.
1870 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1871 (no DOUBLE images in kosher DICOM,
1872 but so usefull for people that miss them ;-)
1874 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1875 DICOMDIR related utilities (not checked as Windoze compliant)
1877 2004-01-28 Jean-Pierre Roux
1878 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1880 2004-01-27 Jean-Pierre Roux
1881 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1882 to allow skipping the shadow elements, to save memory space.
1883 The TRUE value for this param has to be used
1884 with a FALSE value for the 'enable_sequence' param.
1885 ('public elements' may be embedded in 'shadow Sequences')
1886 * gdcmHeader methods now deal with 'embedded icones images' in the header
1887 (even when an 'icone image sequence' is announced by the
1888 element (0x0088,0x0200), but there is NO icone at all ...
1890 * gdcmHeader sometimes Image Location value doesn't follow
1891 the supposed processor endianity (see gdcmData/cr172241.dcm).
1894 * gdcmHeader add the method
1895 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1896 to get *all* the Header Entries with the same tag.
1897 GetHeaderEntrySameName is probabely *useless*
1898 (no meaning : Name is *not* an identifier within the Dictionary)
1900 2004-01-26 Benoit Regrain
1901 * Bug fix in the print of hexadecimal representations. Remove long fields
1902 in the print and add a third level of print to print them
1904 2004-01-23 Benoit Regrain
1905 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1906 * Bug fix on test suite after remove the strip made on not string fields
1907 * Split the IsReadable method between gdcmParser which test that the file
1908 is dicom and gdcmHeader which test that it's an image file
1910 2004-01-22 Benoit Regrain
1911 * DicomDir : clean code, add methods, set variables in protected or private
1912 * gdcmUtil : bug fix for the clean string method
1914 2004-01-19 Benoit Regrain
1915 * Add the use of shadow dictionaries
1916 * bug fix and coding style
1918 2004-01-19 Benoit Regrain
1919 * src/gdcmFile.cxx : bug fix concerning the close of file
1920 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1921 * Add the update of header entries using the shadow library
1923 2004-01-19 Benoit Regrain
1924 * removal of file gdcmHeader2.cxx
1925 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1926 inheriting from gdcmParser. This split is to prepare the integration
1927 of dicom dir parsing
1928 * bug fix under python
1930 2004-01-16 Jean-Pierre Roux
1931 * REM removal of class gdcmHeaderEntrySet
1932 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1933 * ADD add file gdcmHeader2.cxx
1934 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1936 2004-01-15 Benoit Regrain
1937 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1938 entries created while parsing the header. Thus, they will be destroyed
1939 when the gdcmDictSet will be destroyed
1940 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1943 2004-01-15 Benoit Regrain
1944 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1945 made a fatal error because of the memory release at the end of program.
1946 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1947 some memory and vtk seems to have some problems with that.
1948 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1950 2004-01-14 Benoit Regrain
1951 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1952 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1953 * src/*.[h|cxx] : make changes due to class name changes
1954 * gdcmPython/demo/*.py : bug fix due to method names
1956 2004-01-13 Benoit Regrain
1957 * src/*.[h|cxx] : coding style
1958 * vtk/*.[h|cxx] : coding style
1960 2004-01-13 Benoit Regrain
1961 * gdcmPython/testSuite.py : test the readable flag of file for tests
1962 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1963 It's lied to the stl compilation by MSVC (windows, always windows...)
1964 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1966 2004-01-12 Benoit Regrain
1967 * src/*.h : add comments
1968 * src/gdcmDictSet.h : set the method BuildDictPath in public
1969 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
1970 directly setted in the source code
1971 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
1974 2004-01-09 Benoit Regrain
1975 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1976 * setup.py : use a reference to gdcmVERSION
1978 2004-01-07 Benoit Regrain
1979 * Modification to compile with the distutils.
1982 2003-12-10 Benoit Regrain
1983 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1984 can use a gdcmHeaderHelper to load data
1985 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1986 made in the source code
1988 2003-12-10 Benoit Regrain
1989 * Update Windows projects and .cvsignore files
1991 2003-11-12 Jean-Pierre Roux
1992 * ENH gdcmHeader constructor has one more parameter (default value : false)
1993 that allows the user to 'go inside' the SeQuences only
1995 gdcmElValSet:Print takes it into account
1997 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1998 * ENH: Update gdcmPython/CMakeLists
1999 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2000 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2002 2003-11-10 Jean-Pierre Roux
2003 * FIX : gdcmHeader::LoadElements is now based
2004 on the ListTag listElem member,
2005 not longer on the TagElValueHT tagHt member
2006 * ENH : PrintPubElVal shows (temporarily) both results,
2007 with the tagHt member and the listElem member.
2008 (it's easier to 'see' the problems when using Printheader)
2010 * FIX : old private member LgrElem is now splitted into
2011 ReadLength : Length actually found on disk (updated only
2012 if bug fixing is necessary), for internal
2014 UsableLength : Updated by FixFoundLength, to fix a bug
2015 or to allow Parser going on.
2016 Will allow to re-write a kosher header when a SeQuence
2017 with a length (not 0000) is found
2018 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2019 because gdcmElValSet::Add does not update ListElem
2022 2003-11-07 Jean-Pierre Roux
2023 * FIX misstyping in Transfert Syntax name table
2024 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2025 when they have an actual length (not 0000 nor FFFFF)
2026 (Nobody should care of it, but DICOMDIR explorers)
2028 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2029 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2031 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * ENH: vtkGdcmReader now supports LUT !
2033 (vtkgdcmViewer for now is not able to use them though)
2035 2003-11-05 Jean-Pierre Roux
2036 * in testSuite.py : new files names for checking the package
2037 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2038 that returns the pixel area size to the *aware* (vtk) user
2039 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2041 2003-11-05 Benoit Regrain
2042 * in testSuite.py : Modify the rules for checking the paths
2043 : Explicit error messages
2044 * in __init__.py : Related modif
2046 2003-11-03 Jean-Pierre Roux
2047 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2048 to be used by aware (vtk) users that want to manage
2049 LUT (and no to turn the PALETTE image into an RGB pixels one)
2050 * GetPixelType now returns 8U for 24 Bits images
2051 (vtkGdcmReader compliant)
2053 2003-10-31 Jean-Pierre Roux
2054 * Removal of *all* gdcmData images and add them again
2055 in order to loose the 'history' of un-anonymised images
2057 2003-10-31 Jean-Pierre Roux
2058 * RMV : removal of useless jBitsInJsample.h
2059 for both 8 and 12 Bits JPEG Lossy Libraries
2061 2003-10-31 Jean-Pierre Roux
2062 * ENH : Add the functions gdcmFile::GetImageDataRaw
2063 gdcmFile::GetImageDataIntoVectorRaw
2064 that act as GetImageData and GetImageDataIntoVector
2065 except the making of an RGB Plane from Gray Plane + LUT
2066 Intended to aware (vtk) users who know how to manage
2069 GetLUTRGBA return a R,G,B,A LUT if any
2070 lgrTotaleRaw gives the 'Raw' length
2071 GetImageDataRaw returns the gray Plane
2072 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2073 (They stay Grey, just like with other Dicom viewers :-(
2075 2003-10-30 Jean-Pierre Roux
2076 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2078 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2080 being coherents dicom files.
2082 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2085 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2086 * ENH: Two steps is necessary to please VC++ compiler...
2087 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2088 * ENH: Add include dir to medcon lib
2089 * FIX: only one function is being exported for now !
2090 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2092 2003-10-29 Jean-Pierre Roux
2093 * adding gdcmHeader::GetLUTRGBA
2094 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2095 --> Mathieu, the modif u're waiting for is not yet committed
2096 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2098 2003-10-27 Jean-Pierre Roux
2099 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2100 00191113.dcm DermaColorLossLess.dcm
2101 MxTwinLossLess.dcm RadBWLossLess.dcm
2102 * ENH: For version prior to vtkImageViewer2 -r 1.19
2103 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2105 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2106 * Removal of ido stuff in CMakeLists.txt
2108 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2110 * FIX: remove a call to ->Modified ... see comments
2111 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2113 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * FIX: Problem with path for libvtkgdcmPython
2115 * ENH: Try adding a search script for python site-package
2116 * RMV: Remove some file from medcon lib that are not necessary
2117 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2118 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2119 * FIX: More pragma disable fro VC++,
2120 I don't think I break something as it is also disable in VTK/ITK.
2121 But it fasten debug compilation time.
2123 2003-10-23 Jean-Pierre Roux
2124 * gdcm now deals with 16 Bits Run Length Encoded images
2125 (they are compressed as 2 planes images,
2126 one for the high Bytes, the other for low Bytes)
2128 2003-10-22 Jean-Pierre Roux
2129 * Now CheckRead takes into account :
2130 - the bugged 'Leonardo' Siemens images
2131 - the XA images, sent thru the burning VPRO station
2132 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2135 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * FIX: When copying a Makefile.am to CMakeLists.txt
2137 one should remove the '\'
2139 2003-10-22 Jean-Pierre Roux
2140 * in gdcmData adding a bugged 'Leonardo' Siemens image
2141 (wrong lengths in header)
2142 OK with gdcm, KO with the other viewers :-)
2143 * add a GE dlx XA image, thru the VEPRO burning station
2146 2003-10-21 Jean-Pierre Roux
2147 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2148 for a brutal checking of vtkgdcmViewer compliance
2150 2003-10-21 Jean-Pierre Roux
2151 * add the files for 'xmedcon' Jpeg Lossless library
2152 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2154 2003-10-21 Jean-Pierre Roux
2155 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2157 2003-10-21 Jean-Pierre Roux
2158 * garbage Siemens 'Leonardo' images dealt with
2159 (the patch is easy to remove)
2160 * cosmetic changes to avoid warnings
2162 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2164 no need to press 'r' now.
2166 2003-10-20 Jean-Pierre Roux
2167 * upgrade of checkRead.sh checkWrite.sh according
2168 to new Jpeg Lossless decompressor
2169 * add US.3405.1.dcm, a genuine RGB medical file ...
2170 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2171 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2173 2003-10-15 Jean-Pierre Roux
2174 * general anonymisation in gdcmData
2175 * adding the 'color files' from
2176 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2177 * adding some well knowed bugged-header images
2178 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2179 waiting for their inclusion in Python testsuite
2181 2003-10-15 Jean-Pierre Roux
2182 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2183 no longer seg faults when file is not found
2185 2003-10-14 Jean-Pierre Roux
2186 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2189 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2190 * TODO: *.in file to genereate a UseGDCM later
2192 2003-10-14 Jean-Pierre Roux
2193 * Some supposed-to-be Dicom Images have no preamble.
2194 OpenFile takes it into account
2195 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2196 * Missing elements added in dicomV3.dic
2197 (just to be affraid : have a look at
2198 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2199 and do it again next year ;->
2201 2003-10-13 Jean-Pierre Roux
2202 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2203 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2204 But there are NOT. It's fixed !
2206 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * FIX: "jpeglib.h" was not found on VC++
2208 * FIX: vtkgdcm was not being installed
2210 2003-10-10 Jean-Pierre Roux
2211 * ENH : OpenFile closes the file if it *really* doesn't look like
2212 an ACR-NEMA / DICOM one.
2213 * FIX : testWrite no longer writes an empty file if the source file
2214 is not gdcm Readable
2215 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2218 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * FIX: CMake generate now documentation
2220 * ENH: out of source doc build !
2221 * ENH: Generate both user and dev documentation
2222 * ENH: Should work on windows too
2223 * ENH: Only one doxygen config.in file is needed
2224 * FIX: make install should be ok now on ùnix plateform
2225 * FIX: PATH to dictionary was wrong (missing /)
2226 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2228 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * vtkGdcmReader is now able to read rgb dicom file.
2230 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2231 * added a gdcmViewer to vtk test, use mouse to control
2232 window level & window width
2234 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * CMake-ification of gdcm, we have now two build system
2236 * FIX: on cygwin Wsock32 doesn't exist
2237 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2239 2003-10-06 Emanuel Ollart
2240 * FIX : compilation process wad broken.
2241 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2243 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2244 * change gdcmViewer -> vtkgdcmViewer
2245 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2247 2003-10-06 Jean-Pierre Roux
2248 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2249 ( e.g : well known GE images with a wrong elem length,
2250 : Philips MRI Images with a wrong Huffman table)
2251 * still to be done : allow the reading of bugged LEONARDO Siemens images
2253 2003-10-03 Jean-Pierre Roux
2254 * Odd length strings are padded with '\0' (not with spaces,
2255 to remain compliant with already defined strings,
2256 like Transfert Syntax UID and others)
2258 2003-10-03 Jean-Pierre Roux
2259 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2260 to allow displaying RGB images (not only by affim ;-)
2262 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2263 * vtkGdcmReader is now able to read rgb dicom file.
2264 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2266 2003-10-03 Jean-Pierre Roux
2267 * A few nasty patches to allow the reading of a lot of nasty images
2268 ( e.g : well known GE images with a wrong elem length,
2269 : Philips MRI Images with a wrong Huffman table)
2270 * still to be done : allow the reading of bugged LEONARDO Siemens images
2272 2003-10-03 Jean-Pierre Roux
2273 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2275 2003-10-03 Jean-Pierre Roux
2276 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2277 to allow displaying RGB images (not only by affim ;-)
2279 2003-10-03 Jean-Pierre Roux
2280 * gdcmFile::GetImageDataIntoVector now
2281 - deals with MultiFrames MultiFragments Run Length Encoded files
2282 - deals with YcBcR (YBR_FULL) files
2283 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2284 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2286 (no sample found :-(
2288 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2289 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2290 Two reasons: - clear things
2291 - third parties acces gdcm through header files, so won't
2292 suffer anymore VC++ complains
2294 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2295 * add argv[1] in testvtkGdcmReader.cxx
2298 2003-09-24 Jean-Pierre Roux
2299 * The lines are now eigthy characters long.for
2300 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2302 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2303 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2304 char* to std::string. Thus, the use of strdup becomes useless. (see
2305 previous commis of Malaterre)
2306 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2307 before the last Malaterre's commit.
2309 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2310 * This commit should fix the Debug building under VC++, the problem
2311 was mainly a mixture of debug and release lib being loaded at startup.
2312 * I also remove a depency to a specific C function: strdup. Because I had
2313 to force the link to msvcrtd (whereas strdup is in libc).
2315 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2316 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2317 located in the gdcmCommon.h file. All use of reference of tha has been
2318 changed to now use the variable GDCM_UNFOUND.
2320 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2322 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2323 Dicom dictionary. The test suite can now be run again. Note:
2324 I'm note very happy with the " (RET)" changes. I believe this
2325 RETAINED comment should be dropped when parsing the dictionary.
2326 - PACKAGER corrected
2328 - AUTHORS updated and now in alphabetical order
2329 * Makefile.am now exports gdcm.dsw for Windoze users.
2331 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2332 * cygwin complains about missing std:: in subdir Test/
2334 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2335 * remove some methods that are now in gdcmHeaderHelper
2337 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2338 * vtkGdcmReader set spacing and origin correctly
2340 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2341 * Fix a few delete/delete[] mismatch
2343 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2344 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2345 interpretation to data given by gdcmHeader. For instance there are
2346 heuristics to get informations (look at different places).
2347 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2348 sorting DICOM images based on different strategies.
2349 * modified Makefiles accordingly.
2351 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2352 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2353 when building in debug mode
2354 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2355 src/win32/gdcmdll.dsp
2356 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2358 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2359 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2362 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2363 * src/win32/libgdcmjpeg12.dsp was not dos format
2364 * src/win32/libgdcmjpeg12.dsp :
2365 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2366 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2368 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2369 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2371 * src/gdcmFile.cxx : bug fix in affectation type
2372 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2373 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2374 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2375 symbols... future problem ?
2377 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * src/win32/libgdcmijpeg12.dsp was missing
2379 * modified gdcm.dsw accordingly
2381 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2384 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2385 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2386 commit of JPR (before his hollidays to facilitate our work).
2387 * setup.py : bug fix in code. Modifications made while the last commit
2388 of JPR. The code hasn't been tested before the commit... it's so
2389 useless to make that (for best programmer that is JPR) !!!
2391 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * tagged the current version as Version0_3 (i.e. version 0.3)
2394 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2395 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2396 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2397 * *.dsp : modifications to use new libgdcmijpeg8 library
2398 * setup.py : bug fix on VTKPATH variable
2399 * PACKAGER : adding all concerning windows
2401 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2404 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2405 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2406 test suite reported error.
2407 * PACKAGER file added (describes what a packager must do when
2408 packaging a new release).
2409 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2410 * configure.in: upgraded version number to 0.3.0
2411 * fixing build of rpm (through rpm -ta):
2412 - Doc/Makefile.am exports proper doxygen files
2413 - src/jpeg/libijg8/Makefile.am exports the include files.
2415 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2416 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2417 * src/gdcmHeader.h : formatting code
2419 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2420 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2421 We were obtaining error message from vtk. Now, creation of file list
2422 is made in an internal list to prevent this problem.
2423 Bug fix when output is empty.
2424 Bug fix in update of progress value. Previous commit for this was a bad
2426 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2428 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2429 * src/gdcmHeader.h : added method to get the file name
2430 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2431 files. Added method to remove all files on the input
2432 Added FIXME comment concerning the bad parsing of header made by
2433 ExecuteInformation method (in ExecuteData method)
2435 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2437 when using make instal.
2438 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2439 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2441 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2442 * setup.py : adding include dir of jpeg lib to compile all sources
2443 * */Win32/*.dsp : JPR fix for windows compilation
2445 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2446 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2448 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2449 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2451 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * setup.py is again effective on un*x (takes into account the
2453 addon of the jpeg library)
2454 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2455 * Doc/Doxy* updated (includes above enhancements)
2456 * INSTALL now points to web documentation
2458 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2459 * src/gdcmHeader.h doesn't make unnecessary reference to
2461 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2463 * src/gdcm*.[cxx|h] :
2464 - to allow compilation with gcc 3.x
2465 -- clean up of STL usage (added explicit usage of std::)
2466 -- small fixes on exceptions.
2467 Note: linking not tested !
2468 - clean of doxygen comments to avoid warnings at documentation
2470 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2471 dependent convertion).
2473 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2474 * Clean up of previous JPR garbage commit (not even commented in the
2476 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2477 - moved all jpeg related files from src to src/jpeg/libijg8, with
2478 addition/modification of Makefile.am and configure.in.
2479 - the testSuite is still brain damage (not guilty).
2481 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2482 * WrapVTK.py : modifications to get correctly vtk source files to
2484 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2485 (FileName -> Filename)
2487 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * vtk/vtkGdcmReader.[cxx/h]:
2489 - UpdateProgress method should now be effective
2490 - removed the limitation on having only images loaded (as opposed
2492 - when building a stack of images/volume, a lesser number of
2493 gdcmHeader and gdcmFile instances should be used (hopefully
2494 accelerating things).
2495 - when building a stack of images/volumes, files which are not
2496 loadable (wrong path-filename, wrong permissions on existing file,
2497 or file not parsable by gdcm) are replaced with a black image
2498 in the stack (for the caller to notice the problem).
2500 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2503 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2504 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2505 between standard library (std) and vtk library (problems are found
2506 under Windows... thanks Windows !)
2508 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2511 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2513 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2516 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * When compiling with distutils (see setup.py) the C++ compiler is
2518 called with different flags than the default ones (with automake).
2519 In order to fix all those warning, I compiled gdcm with the command
2520 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2521 and went for warning fixes:
2522 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2523 up from unused variables.
2524 - vtk/vtkGdcmReader.cxx: potential bug fix.
2525 * src/gdcmHeader.h: Doxygen warning cleanup
2527 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * gdcmPython/gdcm.i:
2529 - typemaps correction to take into account the systematic replacement
2530 of "using namespace std" with std:: prefix e.g. std::list,
2531 std::string... (cf changes of 2003-05-21).
2532 - gdcmGlob global variable of type gdcmGlobal (defined in
2533 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2534 exported to Python a as cvar.
2535 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2536 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2537 gdcmDictSet.GetPubDictTagNames() and
2538 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2539 C++ static methods).
2540 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2541 with the above changes.
2543 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2544 * setup.py, manifest.in : bug fix under linux
2546 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * Modification of setup.py to compile vtk part too. Then, we have 2
2548 wrappers which must work with same distutils. For that, we have a
2549 generic distutils in distusiltsWrapping.py ; with :
2550 - build_extWrap class to wrap generically all extensions,
2551 - ExtensionWrap base class for all wrapping extension that contains
2553 - Wrapper interface which wrap sources
2554 + In WrapSwig.py we have extension and wrapper for Swig
2555 + In WrapVTK.py we have extension and wrapper for VTK
2556 * MANIFEST.in : modifications to consider vtk directory and new python
2557 files for compilation
2559 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2560 * Added python wrappers of vtkGdcmReader vtk class (see the
2561 source in vtk/vtkGdcmReader.cxx) :
2562 - vtk/Makefile.am now builds a library
2563 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2564 python library (as opposed to _gdcm.so wich are the python
2565 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2566 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2568 - configure.in has an additional flag --enable-vtk that needs
2569 to be set to enable compilation of vtk related code, that is:
2570 + vtk/vtkGdcmReader.so and
2571 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2572 + gdcmPython/vtkgdcmPython.so (see above)
2573 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2574 be read when compressed or when HighBit + 1 != BitsStored),
2575 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2576 the usage of the python wrapper of vtkGdcmReader vtk class.
2577 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2578 * src/*.[h] all occurences of stl classes are now prefixed with
2579 std::, and all occurences of "using namespace std;" where removed.
2580 This is to avoid pollution of global namespace in included files.
2581 Apparently vtk does not avoid this pitfall: when using both
2582 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2583 collision of various stl members (principally cout...).
2584 * gdcmPython/testSuite.py now cleanly removes temprory generated
2586 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2587 comply with above changes)
2589 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2590 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2591 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2592 vtk data structure (an image Flip was required).
2593 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2594 * cosmetic changes in documentation.
2596 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2597 * src/gdcmHeader.cxx: the constructor no longer exits when an
2598 unexisting file is given as argument.
2599 * The subdirectory Data (containing all the images used for the
2600 test suite) is not part of this repository anymore. A new module
2601 containing those images is now available at
2602 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2603 with the name gdcmData.
2604 All the python scripts (including the package initialisation file
2605 gdcmPython/__init__.py) were adapated to take this change into
2606 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2608 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2609 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2610 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2611 demo of the usage of this class.
2612 Compilation of this vtk part is only done when using the --enable-vtk
2613 at configure (or autogen.sh) stage.
2615 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2616 * More memory link related corrections and documentation fixes.
2618 - maximum info is obtained with a command of the form:
2619 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2620 --show-reachable=yes PrintHeader
2621 - the remaining reachable blocks seem to come from the STL
2622 allocation scheme through the usage of map and list. It looks
2623 like this memory cannot be freed but it is not a memory leak
2624 (in fact further invocation to the STL would recollect the
2625 unused memory allthough it cannot explicitely be freed).
2626 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2627 of displaying an image parsed with gdcm and displayed with VTK.
2628 Note: some images don't seem to work e.g.
2629 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2630 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2631 Allthough this weakens the semantics, it is a ditch attempt to
2632 make gdcm more thread friendly.
2634 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2635 * Memory link hunt (by using valgrind through the command
2636 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2637 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2638 gdcmHeader::_dicom_vr.
2639 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2640 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2642 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2644 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2645 * src/Makefile.am now exports all the necessary include files at
2649 * UpdateGroupLength replaced by new one
2652 * UpdateGroupLength re-written using H-Table
2653 (named UpdateGroupLengthNew untill checks are over)
2655 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2656 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2657 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2659 - gdcmHeader::GetPubElValSet removed.
2660 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2661 UpdateGroupLength, WriteElements, Write.
2662 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2663 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2664 carried the same semantics.
2665 - src/gdcmHeaderIdo.cxx changed accordingly.
2666 - gdcmFile::WriteBase now regroups all the codes from previous
2667 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2668 - enum FileType moved to gdcmCommon.h
2669 * src/gdcmHeader.cxx AddDefault trashed
2670 * gdcmGetXSize added
2671 * getimageDataSize now calls gdcmGetXSize
2672 * Test/*.cxx changed to agree with above changes
2674 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2676 (to avoid double call by end user).
2677 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2678 by end user, since gdcmHeader::gdcmHeader now handles it.
2680 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * gdcm/Doc many doxygen changes:
2682 - Doxyfile now has two different versions, DoxyfileUsers that generates
2683 the html.users end users oriented documentation and
2684 DoxyfileDeveloppers that generates the html.developper developper
2685 oriented documentation.
2686 - README changed accordingly
2687 - requirement.txt removed (old design info moved to TODO).
2688 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2689 DoxyMainPage.txt, DoxyPython.txt provide more information.
2690 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2691 be updated by simply regenerating the docs with doxygen and copying
2692 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2693 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2694 all the tests in the form "if (<map>.count() >1)" were removed.
2695 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2696 ill-formed documentation sections.
2697 * src/gdcmHeader.cxx: ditto
2699 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * setup.py fixed for un*x (needed macro for stdint.h)
2701 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2702 un*ces with sh-utils test utility.
2703 * gdcmPython/demo/test.py renamed to PrintHeader.py
2704 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2705 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2706 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2707 * src/gdcm*.cxx JPR's bad inclusion fixed.
2709 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2710 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2711 * gdcmPython/demo/test.py changed accordingly.
2713 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * gdcmPython/Makefile.am fixed linking against libstdc++
2715 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2716 * Swig subdir (historical tests of swig version 1.3.17++) removed
2717 * Test/testChangeEntete.cxx some lines commented out in order to make
2719 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2720 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2722 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2723 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2724 hence the user doesn't need this explicit call.
2725 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2726 i.e. LoadElements() call removed.
2727 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2728 - src/Makefile.am declares the proper flag for g++.
2729 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2730 for adding user defined new tags.
2731 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2732 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2733 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2735 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2736 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2737 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2738 src/Makefile.am : the project should properly compile and install
2739 with the autotools, included the python wrappers part.
2740 * gdcm.spec.in : added a spec file for RPM packaging.
2742 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2743 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2745 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2747 to exported to the environement (see gdcmPython/testSuite.py
2749 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2750 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2751 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2752 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2753 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2755 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * gdcmPython/__init__.py doesn't crash anymore when running in
2757 in InstallMode or PreInstallMode but with an environement given
2758 value of GDCM_DICT_PATH.
2759 * src/gdcmDictSet.[cxx/h] coding style.
2761 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2763 * src/gdcm.h general comments moved to TODO, and README
2764 * src/gdcm.h should now be seen as a user commodity (including it
2765 should suffice to fully use gdcm). It is nowhere including within
2766 any of the kernel files src/*.cxx and src/*.h.
2768 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2770 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2772 * src/gdcm*.cxx only include their corresponding include file
2773 (as opposed to gdcm.h)
2774 * gdcmPython/gdcm.i changed accordingly
2775 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2776 the autogen.sh generated "make snapshot" command to work.
2777 * autogen.sh removed history related references to crea package.
2779 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * distutilsSwigCPlusPlus.py work around some swig portability
2783 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2785 was done in a last ditch attempt to get setup.py _really_
2786 operationnal. The python/gdcmPython layaout add the advantage
2787 of hidding away the python related distutils specific files
2788 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2789 Alas, the src directory was out of scope (i.e. it's relative
2790 position to setup.py was ../src) which made things impossible to
2791 handle (see previous version of python/setup.py). Crossing fingers...
2793 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * python/setup.py now works on Un*x. (harder than I thougth)
2795 * python/distutilsSwigCPlusPlus.py can now have include files
2796 among the list of sources.
2798 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2799 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2800 * modifications in MSVC projects
2802 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * As stated by the first lines of Test/ExceptionAndPython/README, it
2804 looks like we can move back to original usage of exception within
2805 src/gdcm* and hence remove the errno stuff that was introduced
2806 as a quick and dirty fixture of this problem (added to the TODO).
2807 * Doc/Doxyfile configuration file for Doxygen and corresponding
2808 README file for usage added.
2809 * Test/testWrite.cxx added. This new test comes from a split of
2810 test.cxx that is now reverted to its original purpous i.e.
2811 testing the proper parsing of a Dicom related file.
2812 testWrite.cxx concentrates on testing the IO part of gdcm.
2813 * Test/bug1.cxx (containing a bug on WIn32) added.
2814 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2815 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2816 whose purpose is to publish the content of the TagNames of the
2817 Dicom public dictionary were not accessible without an
2818 instance of class gdcmHeader.
2819 - those methods are now static methods of gdcmDictSet and hence
2820 require no instances at all to be invocated.
2821 - within gdcmDictSet this change required to change some method
2822 to class methods (i.e. are now static) among which SetDictPath
2823 (renamed to BuildDictPath) and LoadDefaultPubDict.
2824 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2825 the above changes by calling the new method classes of gdcmDictSet.
2826 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2827 the above to be effective.
2828 * python/gdcmPython: in order to wrap properly the above changes
2829 for Python, swig version now needs to be > 1.3.17.
2830 * python/gdcmPython/Makefile fixed to adapt itself to new
2831 configure/make shema introduced by Johan Montagnat (thanks for the
2832 contribution). Alas this Makefile cannot be turned into a proper
2833 Makefile.am without some heavy changes in the configure.in
2834 (for python dectection).
2835 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2836 now avoids publishing the empty entries.
2838 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2839 * python/setup.py : bug fix concerning install under windows
2840 ExtraPath reused :-P
2841 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2843 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2844 * Dicts/dicomV3.dic : remove double spaces !!!
2845 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2846 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2849 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2851 method. Doxygenation.
2852 * src/gdcm.h clean up of JPR spurious comments.
2854 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * python/distutilsSwigCPlusPlus.py now properly collects the
2856 shadow classes generated by "swig -c++" (gdcm.py in our case)
2857 when using "python setup.py install".
2858 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2859 reexports the working classes.
2860 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2861 by the classical C errno scheme. This is to prevent an obscure
2862 behavior of the python wrappers when importing wxPython.wx prior
2863 to gdcmPython (which ended up in an abort call). An illustration
2864 of this oddity can be found in the Test/ExceptionAndPython
2865 subdir (see the README file). This problem probably due to
2866 an combination of g++ and dynamic loading.
2867 * added Test/ExceptionAndPython (see above)
2869 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * Changed the layout of the python part to avoid bloating main
2871 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2872 i.e. the distutils arsenal. All the python related stuff is
2873 again in a python subdir, but the package itself is now in
2875 * setup.py was cleaned up:
2876 - pythonIncludePath removed
2877 - python setup.py bdist target is now functional.
2878 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2879 collision with other packages). gdcmPython/demo/*.py changed
2882 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2883 * python subdir moved to gdcmPython (preparation of distutils packaging).
2884 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2885 distutils installer is operational.
2886 * - gdcmPython/__init__.py now properly loads the swig generated
2887 shadow classes (from gdcm.py).
2888 - gdcmPython/demo/*.py changed to import the package gdcmPython
2889 instead of gdcmPython/demo/load.py.
2890 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2892 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2893 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2894 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2895 entries within the associated public Dicom dictionary resp. the same
2896 information but sorted by the fourth field (PAT, IMG, DIR) of the
2898 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2899 are now in the "???" group.
2900 - python/gdcm.i changed accordingly,
2901 - python/demo/printGroupedPublicDict.py added, that gives an example
2902 of the above new functionalities in Python.
2904 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2905 * src/gdcm.h, gdcmHeader.cxx:
2906 - historic references to glib's g_malloc and g_free (#defined)
2907 were definitively removed.
2908 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2909 * src/gdcmElValSet.cxx:
2910 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2911 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2912 - GetElValue(string) renamed to GetElValueByName.
2913 - Added GetElementByName(string).
2914 * src/gdcmHeader.cxx: added
2915 - GetPubElValRepByNumber(guint16, guint16)
2916 - GetPubElValRepByName(string)
2917 - GetShaElValRepByNumber(guint16, guint16)
2918 - GetShaElValRepByName(string)
2919 - GetShaElValByNumber(guint16, guint16)
2920 - GetShaElValRepByName(string)
2921 - GetElValRepByNumber(guint16, guint16)
2922 - GetElValRepByName(string)
2923 - GetElValByNumber(guint16, guint16)
2924 - GetElValRepByName(string)
2925 * Doc/requirements.txt added.
2927 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * Test/Makefile building now depends on the one of libgdcm.so
2929 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2930 pixel data) aware which enables finding the address (offset) of
2931 the pixel data of JPEG encoded DICOM files. This leaves only a single
2932 file in the testSuite whose pixel data address (offset) is unknown.
2933 * python/testSuite.py changed accordingly.
2935 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2936 * VC++ has some strong limitations when working with the STL, as stated
2937 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2938 "Also note that some STL containers (map, set, queue, list, deque)
2939 cannot be exported. [...]
2940 Some STL classes contain nested classes. These classes can not
2942 This is caused by a designed limitation that once a template
2943 class is instantiated, it can not be re-instantiated and
2945 Since our usage of map<> is ubiquitous in gdcm, this "designed
2946 limitation" of VC++ is a pitfall.
2947 Hence the Python wrappers of gdcm cannot be incrementally linked
2948 against the c++ dynamic library. The dirty but only workaround is
2949 to forget about incremental link of dynamic libraries and to generate
2950 the Python wrappers library with the inclusions of the underlying C++
2952 The following modifications concern this matter on Win32/VC++:
2953 - wrapping python correct with standalone wrapped dll (don't use separate
2954 dll under windows !!!!)
2955 - python21_d debug mode enabled (ask Frog how to use it :-)
2956 - NO problem with having an STL member of class for example string in C++
2957 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2958 - Python test of dcmlib in Python is ok under windows on a large set
2960 * removed glib references
2961 * typedef's inserted in gdcm.i for correct swig type management
2963 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * python/demo/*.py load.py extracted from test.py. Added explore.py
2965 that only displays required tags and testAll.py that parses all
2966 the files of the testsuite without using unittest.
2967 * python/testSuite.py other additional test on new files added.
2968 * Data/* new test files added accordingly to the testSuite.
2969 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2970 the vr in the file differs from the one of the dictionary.
2972 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2973 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2974 values, but limits itself to values which are below a user specified
2975 size (by default 1024 bytes).
2976 * python/gdcm.i : elements not loaded (because their size is above the
2977 user specified treshold) are exported with their TagKey as key of the
2978 python dictionary. This enables the testsuite to make some checks
2979 on the unloaded elements (since we have their offset and size).
2980 * python/testSuite.py
2981 - now tests for the existence and proper value of the pixel data
2982 - two new examples added.
2983 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2985 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2987 aware. See the strategy comments in gdcmHeader::FindeLength().
2988 * Test/test.cxx now accepts a filename as first argument.
2989 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2990 * python/testSuite.py changed to integrate test on above files.
2992 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2994 the vr was also RET.
2995 * python/testSuite.py more tests added.
2997 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2998 * python/testSuite.py unittest test suite added (uses Data)
2999 * Data/* dcm and acr files for the test suite.
3000 * glib dependance removed from un*x version. We now use ISO C99
3001 7.18 Integer types (see stdint.h)
3002 - python/Makefile, src/Makefile src/gdcm.h
3003 * src/ when an explicit vr (like dicom files) suddenly poped an
3004 implicit element we use to mark the underlying DictEntry of the
3005 concerned ElValue with "Implicit". This strategy was damageable
3006 too the public or provite dictionaries, since some of their vr
3007 would be changed. Since Header::FindLength heavily relies on the
3008 detection by Header::FindVR of falsely explicit elements, I
3009 added an extra ImplicitVr member to ElValue (boolean).
3010 The rest of the changes we the necessary adaptations.
3012 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3013 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3015 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3017 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3018 * Adaptation for porting to VC++:
3020 o forced to use std namespace (for string to be known)
3021 o all class use __declspec export style on WIN32
3022 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3023 (in stdlib.h on Win32 but in std:: for gcc)
3024 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3025 variable GDCM_DICT_PATH.
3026 * src/gdcmHeader.cxx verbose comments made discrete.
3028 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * python/gdcm.i: added a typemap that converts a C++ hashing table
3030 to native Python dictionary.
3031 * python/demo/test.py:
3032 - now uses the native dictionary for exploration of gdcmHeader.
3033 - takes an optional filename argument (the file to parse).
3034 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3035 PubElVals hashing table.
3036 * Dicts/dicomV3.dic removed error prone trailing spaces.
3038 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * Python wrapping process moved away from src/Makefile to
3040 newly created python/Makefile (as well as gdcm.i)
3041 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3042 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3043 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3044 from the environement variable GDCM_DICT_PATH (when existing).
3045 * src/gdcmDict::GetTag bug fix.
3047 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * Straightforward temporary fixes for swig to build the python wrappers.
3049 src/Makefile now has a python working entry [by working we mean
3050 that we can import de shadow classes without errors].
3052 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3053 * hashtest.cxx removed (since already in Test)
3054 * src/gdcmlib.h renamed to src/gdcm.h
3055 * src/dcm.i renamed to src/gdcm.i
3056 * src/Makefile prepared for python wrapping
3058 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * src/gdcmHeader.cxx :
3060 - Parsing of header is now separated from loading of element values
3061 (see gdcmHeader::LoadElements).
3062 - general clean up of hopefully all file access (creation of
3063 ReadInt16 and ReadInt32)
3065 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3066 * src/gdcmHeader.cxx :
3067 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3069 - SetLgrElem renamed to SetLength
3070 - GetLgrElem renamed to GetLength
3071 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3072 * src/gdcmElValSet.cxx fixed both GetElValue methods
3073 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3074 due to IdoDude was cleaned out.
3076 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3078 concentrates on finding the value representation (when it exists).
3079 RecupLgr now only finds the element value length, and it avoids
3080 returning the unecessary skL (skipped length).
3081 Also, offsetCourant was simply removed (with taille_fich) since
3082 it was redundant with the File position internals (by using
3083 ftell and fseek). This also made skL (see above in RecupLgr) usage
3085 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3086 on the libido specificities which are handled through class
3088 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3091 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3092 * Truckload of changes. Parsing of header is barely functional
3093 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3095 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3096 * src/gdcmHeader.cxx many addons of low level methods
3098 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3100 and _IdDcmSWAP_LONG.
3102 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * This corresponds to all the changes decided at the meeting of
3104 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob