1 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * move RLEInfo & JPEGInfo from Document to File
4 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * FIX : remove so many friend between classes
7 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
9 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
11 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
12 In ordrer to avoid missbehaviour :
13 . gdcm::DocEntry is now specialized in
14 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
15 - gdcm::ContentEntry (Dicom entry with a 'content')
16 . gdcm::ContentEntry is specialized in
17 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
18 characters value, or integers)
19 - gdcm::BinEntry (Dicom entry with a non strig representable value
20 (user hasn't any longer to thing about the precedence of his dynamic_casts)
22 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Test/VTKTest*.cxx : bug fix under linux
25 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
27 use with python. Some methods are moved from Document to ElementSet or
28 DocEntrySet. The equivalent methods to ElementSet have been added to
29 SQItem and are virtual in DocEntrySet. Methods that may have the same code
30 in SQItem and ElementSet is directly placed in DocEntrySet
32 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Test/VTKTest*.cxx : remove the show variable in each test method because
34 it's useless (the viewer variable replace this variable)
36 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmDocument.cxx : bug fix on potential memory leak
38 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
39 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
40 Add ClearXxx methods to remove all the content of the list or map
41 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
43 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
44 * methods ReplaceOrCreate renamed as Insert
45 (nobody will be any longer confused by 'CreateOrReplace')
47 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 * Grealty simplify the JPEg decompression, no need to differenciate based on
49 the JPEG possible type (with/without fragment, with/without multiple frame).
50 Everything is done throught the JPEG IO Suspension mechanism in IJG
52 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
53 * Stage 3 of normalization :
54 in order to avoid any missunderstanding while reading method names :
55 - All the methods xxxEntry now deal with dicom Entries
56 - Methods GetEntry splitted into
59 - Method SetEntry renamed as SetEntryValue
60 - Method SetEntryBinArea let as it was
62 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
63 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
64 - Position correctly the entry points for JPEG2000 and JPEG-LS
65 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
67 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
69 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
70 with other method names
71 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
72 * Test/TestDicomDirElement.cxx : add new test
74 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
76 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
77 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
78 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
79 So can't you use __int64 in ostream at all.
81 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * bug fix for compilation on MSVC6
83 * gdcmPython/gdcm.i : rename of classes missed
85 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
86 * Stage 2 of names normalization :
87 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
88 (easy to understand ...)
89 - gdcm::FileHelper replaces old class gdcm::File
91 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
93 type and not a string. So, there remove problems on the format of the
96 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
97 * Add Example/TestPapyrus.cxx
98 - reads a Papyrus file (gdcm::Header compliant),
99 - gets the pixels of all the images, using low level iterators
100 - writes an multiframes Dicom image.
101 (Just to show it's *possible* to do that)
102 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
105 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
107 Thus, DicomDirXXX are created with a flad that indicates if the created
108 object is empty or not (when not empty, the DicomDirElement is used to
111 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
113 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
115 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
118 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
120 Remove all access to the hash-tables or lists in the objects.
122 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
124 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
125 be complient with all the gdcm source code
127 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
131 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
135 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * Test/ : rename VTK tests to have a best name for the tests
137 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
138 GetFirstEntry/GetNextEntry use
140 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
141 * In SerieHeader::ImagePositionPatientOrdering()
142 // a Dicom 'Serie' may contain scout views
143 // and images may have differents directions.
144 // -> More than one may have the same 'pos'
145 // Sorting has then NO meaning !
146 Thx to Eduardo Davila for reporting bug.
148 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
150 test. Now it's on image content and not on the resulting visualisation...
151 might solve the problem on linux when using the OpenGL drivers
153 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
154 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
155 DicomDirSerie, DicomDirImage
156 Dict, DictSet classes :
157 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
158 -remove InitTraversal method.
159 * UPD Test programs + Example programs
161 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
162 * remove useless and never updated keyword \ingroup
163 * Solve pb when structure (list, map, ...) is empty.
164 Thx to Benoit for reporting bug
166 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 * Taking into account of 'Transfer Syntax' value
168 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
171 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
173 is no memory access violation
174 * gdcmPython/demo : add python demos using VTK
176 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
177 * FIX 'Dictionnary' is now spelt 'Dictionary'
178 'wether' is now spelt 'whether'
179 'archieve' is now spelt 'archive' ;-)
181 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
182 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
183 related methods, in order not to expose internal mechanisms
186 * REM methods that exposed internal mechanisms :
187 DicomDir::GetDicomDirPatients()
188 DicomDirPatient::GetDicomDirStudies()
189 DicomDirStudy::GetDicomDirSeries()
190 DicomDirSerie::GetDicomDirImages()
191 * UPD Test programs :
195 * UPD Example program
197 * ADD DictSet methods
201 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 * Removed the Print/indent/default parameter mess. There is absolutely no
203 reason to have to methods, moreover with the second taking the ostream as
204 *SECOND* parameter. This was clearly a bad hack to get things compile.
206 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
207 * Complete rewrite of the GetMacAddress code. Now the code is *much*
208 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
209 Unfortunately the main code does not work on SunOS, thus provide a specific
210 code for this platform only (and Win32 of course). Since this seems to be
211 working, change CreateUniqueUID to use GetMACAddress instead of the
212 problematic GctestetIPAddress
214 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
215 * Unfortunately to be able to test gdcmDirList I had to break the API
216 a little. Now the class is not a std::list anymore but has a member
217 std::vector (more ITK compatible). Allow unit testing on Win32 and
220 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Update SerieHeader to take into account a Serie Instance UID to properly
224 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
225 * ENH - Comment out Mathieu's (dangerous) Super Hack
226 for dealing with BIGENDIAN processors
227 - Move equivalent stuff to BinEntry::WriteContent
228 When necessary, 16 Bits Pixels are swapped in a small buffer
229 and then written. This avoid allocating a huge buffer, in
230 PixelWriteConvertor, and avoid modifying the Pixel Area.
232 Probabely, the same operation will have to be done when we want
233 to write image with Big Endian Transfert Syntax,
234 and we are working on Little Endian Processor
236 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
239 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
240 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
241 all the dict content.
242 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
244 * Test/TestDict.cxx : add a new test for the dict classes
246 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
248 file. Debug is yanked if compiled with NDEBUG
250 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDictSet.h : set the default output to the os variable
252 * src/gdcmDictEntry.[h|cxx] : add the Print method
253 * gdcmPython/demo/ : add a new test
255 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
256 * merging of Test/PrintDicomDir and Test/TestDicomDir
257 * removal of now redundant Test/PrintDicomDir
258 * enhancement of Example/PrintDicomDir
260 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * Now, python test might work on systems
262 * Add the PrintDicomDir test
264 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
265 * FIX : First entry following group 0002 was lost for
266 Explicit Big Endian Transfer Syntax files
267 (group and elem not swaped)
269 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
270 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
271 Big Endian Transfer Syntax supposed the group following 0002
272 begins always by element 0000 (element 0000 is *optional*)
273 To avoid further troubles, let's be pessimistic, and use
274 Document::HandleOutOfGroup0002() method
275 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
276 (related pb not yet solved)
278 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * Bug fix for the python part use
280 * Now, PrintHeader.py pass... but outside the ctest use. shit !
282 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
285 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
286 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
287 a string and should ask the global TS dict what are the propreties of
290 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
291 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
292 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
293 to swap the Swap Code, at parsing time, when we come out of group 0002
294 and Transfer Syntax is Big Endian
295 We should be able to read now 'true DICOM" Big Endian coded images
296 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
297 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
299 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Hopefully fix the bug on MacOSX and static global initialization.
301 This is the only -minor- patch I found that both please MacOSX and VS6.
302 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
303 but this would require a lot of change. Another approach would be that Global
304 create those string and GDCM_UNFOUND becomes a pointer to a string (which
305 gdcm::Global would destroy at exit).
307 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
308 * Fix bug on MacOSX with static initialization in a multy threaded
309 environment. static const string in a header file used to be ill
310 initialized provoquing the freeze of any tests. patch should solve this
313 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
314 * According to Benoit's suggestion, and without any objection from anybody
315 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
316 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
317 - method gdcmDicomDirObject::GetEntry() renamed as
318 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
320 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
322 you debug/warning message just as c++ streams which make them very convinient
323 to use. Once this is stabilize I will change the ostringstrem to be
324 redirected to a file (ofstream).
325 * Properly support C99 extension: __FUNCTION__ which allow us to display
326 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
328 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
329 * Removal of useless and dangerous methods :
330 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
331 GetDocEntryByName, GetEntryByName, GetDictEntryByName
332 * Removal of usless methods :
333 Dict::PrintByName, Dict::GetDictEntryByName
334 * Commenting out of probabely useless methods :
335 Dict::GetDictEntryNames()
336 Dict::GetDictEntryNamesByCategory()
337 DictSet::GetPubDictEntryNames()
338 DictSet::GetPubDictEntryNamesByCategory()
339 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
340 * ENH : Use dicomTS.dic as described in 2004 version
341 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
342 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
343 Add Accessors on VM (Value Multiplicity), and VM related methods
344 * ADD : Add a list of 'Dicom Attribute types', as found in
345 http://medical.nema.org/dicom/2004/04_15PU.PDF
347 * ADD : Add dicomGroupNameAbbreviations.dic
348 should be used to write a method to replace the former
349 Dict::GetDictEntryNamesByCategory()
351 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
353 to read in the file... and only it ! Length is the efective length of the
354 data in the DocEntry structure
356 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
357 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
358 And now use a static function call instead, with a global variable. i
359 This is much closer to the VTK approach. Hopefully should be bulletproof
360 and easier to use...hopefully
362 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
365 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
368 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
370 ValEntry, BinEntry, SeqEntry creation or replace
372 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
373 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
374 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
376 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
377 when specifying the VR
378 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
379 * src/gdcmDocEntry.cxx : amelioration of print
381 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
382 * ADD : Add the method Util::IsCurrentProcessorBigEndian
383 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
384 * ADD Method Document::ComputeGroupLength
385 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
386 in order to allow further VR modification by user
387 * REM : removal of once-called method File::WriteBase
388 integration of its code in formerly one-line method File::Write
390 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
392 replace the different values "??", "Unkn", "Unknown".
393 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
394 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
395 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
396 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
398 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
401 * Set the gdcm::Base class to some Printable classes
403 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmFile.[h|cxx] : add the Print method
405 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
406 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
407 * src/gdcmDocument.h : remove the PrintLevel informations
408 * Example/PrintFile.cxx : use the new gdcm::File::Print
410 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
412 problems when compiling with the python wrapping
414 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
416 writting in ImplicitVR
418 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
419 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
420 JPEG decompression, especially when dicom frames are split into several
421 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
422 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
424 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * src/gdcmHeader.cxx : change the initialisation of default header.
426 Now, this header is readable by gdm, e-film, DicomWorks
428 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
430 Rename Decompressed to Raw
431 * Use the API changes in gdcm::File.
432 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
435 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
437 each added entry in the header. Replace the 'Planes' field by the 'Number
440 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
442 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
444 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
446 At this time, this image isn't readable by e-film... waiting JPR help to
449 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
450 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
451 DocEntry. Now use methods of the Document !
453 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * Test/ShowDicomSeq.cxx : bug fix
456 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
458 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
459 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
460 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
462 * Test/TestCopyRescaleDicom.cxx : remove unused variable
463 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
464 containing found sequences
466 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
469 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
470 Some fields in BinEntry must be copied to not seg fault when making the :
471 gdcm::File *copy = new gdcm::File( copyH );
472 and tests are now made on good variables
474 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
476 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
478 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
479 * Add vtkGdcmWriter example and test
481 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * Test/TestUtil.cxx : reformat the source code
483 * vtk/vtkGdcmReader.cxx : remove and change prints
484 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
486 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
487 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
489 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
491 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
493 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
495 by an eof to prevent all bad read of the file... and in this case, the
498 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * Example/Volume2Dicom.cxx : comment unused variables
500 * Test/PrintDicomDir.cxx : comment unused variables
501 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
502 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
503 method that is redondant with AddEntry.
504 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
507 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * Bug fix due my last commit (compilation under Windows).
509 * Example/Volume2Dicom : bug fix in the file and reformatting source code
510 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
512 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
514 - Remove printf / sprintf
515 - include iostream AFTER gdcm so we don't get warnings
516 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
518 - Also remove tons of include from header files, hopefully this should
519 speeup the compilation time, since it was becoming a dog slow.
520 - Remove gdcm.h as it include way too many files and slow down compilation
521 (plus it is not up to date)
522 - remove 'using namespace std' this is BAD !
524 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * Remove memory leaks on the DicomDir
526 * Remove some useless data in DicomDirObject
527 * Add usefull methods in SQItem, to be complient withe the ElementSet
529 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
532 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
534 future, with convertion)
535 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
536 and ImageDataSize values. Remove the method to get the PixelReadConverter
537 from the output of the class
539 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
542 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
544 and vtkErrorMacro use.
545 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
547 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
550 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
551 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
552 The string leaves only in the fonction. So when we make a .c_str(), we
553 get the pointeur on the first element, element that will be destroyed
554 immediately after thee instruction.
555 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
556 file has been opened : the test must be made on the content of the
557 pointer and not directly on the pointer !
560 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
562 the python part recompiles
564 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
566 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
567 X session is killed (for my computer... it seems to not be identic on
570 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
572 avoid problems (otherwise, the difference test between the visible image
573 and the reference is incorrect. If the reference is greater than the
574 screen resolution, it's produce errors).
575 Can be used for only one image. Can be used with a visible flag.
576 * vtk/vtkGdcmReader.cxx : remove commented codes.
577 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
578 under windows at compilation
579 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
581 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
583 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
585 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
586 tests on the image size X, Y, Z
588 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
589 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
590 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
591 between the class name and the file name
593 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * src/ : fix compilation warnings for the Write method (2 different
595 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
596 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
597 variable... create a static method in gdcm::Document to access to
598 this variable content.
600 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
602 file, to be accessed by other files (like gdcmFile). Remove commented
603 code. Move the change of the header to the gdcmFile, using the
605 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
606 To be sure of that (and simplify calls), the Write of the header now
607 gets a file name and not a file pointer (std::ifstream).
608 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
609 DocEntryArchive. Remove all open of the written file
611 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
614 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
616 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
618 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
619 some corresponding methods. Write correctly the file and check before
621 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
622 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
623 is now on RGB data (as before my last commit
624 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
626 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
628 Add a print information of the type of the entry
629 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
630 It was in the gdcmFile, and all write have been regrouped
631 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
632 Write correctly all dicom files (in decompressed mode only at this time)
633 * Test/ : test on files are now made using Raw data and not color data if
635 * Example/PrintFile.cxx : add more printings
637 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * Amelioration of code, remove some code copy. For the loading of
639 BinEntry (in gdcmDocument), add the test to verify if the file is already
642 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
644 remove a DocEntry in the header (push an empty DocEntry)
645 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
646 lines. Bug fix in the initialization of the PixelConvert and the
648 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
649 use in TestCopyDicom (now this test can run under windows... but fails)
650 * Test/TestCopyDicom.cxx : amelioration of the test :
651 - test the pixels written
652 - add test points to quickly find where is the error
653 - can set a file name input and output in arguments
654 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
655 amelioration of the test output
657 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
659 all replaced DocEntry's
660 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
661 Now, each needed DocEntry to modify is duplicated, modified and inserted
662 to the header using DocEntryArchive. Thus, after save, we can restore the
663 header initial state.
665 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
668 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
670 correct to copy it. The DictEntry is specified at the DocEntry creation,
671 then, it musn't change in the time.
672 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
673 header correctly. At this time, the change is only made for the first
674 level of the Document. In the future, it might consider sequences.
675 The change is made by replacing a DocEntry by an other that is created
676 outside the class. The old value is kept. When we restore the header
677 status, the added DocEntry is deleted and replaced by the old value.
678 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
679 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
680 set the write type to explicit VR, implicit VR or ACR. Add methods to set
681 the write mode to native, decompressed or RGB (but not used at this time)
683 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
685 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
687 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
689 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
691 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
692 set because already copied when copying the BinEntry's of the header
693 * Test/TestAllReadCompareDicom.cxx : remove warnings
695 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
697 Two problems appear when doing it :
698 - with the gdcmFile : when the GetImageData method is called, the pixels
699 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
700 data (pixels). And each structure destruct the data when it's
701 destructed. So we have two destructions for the same data. To solve it,
702 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
703 data or not. If it doesn't own data, then they will not destroyed by
705 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
706 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
707 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
708 create a double destruction of the same DocEntry's. So, to solve it,
709 the TagHT is simply cleared and the DicomDir* elements are destroyed.
710 * TODO : add an entry concerning memory leaks in the DicomDir
712 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
714 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
717 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
719 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
720 after it have been deleted
722 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * FIX: src/* fix the doxygen warnings.
724 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
725 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
726 was erroneously defined with a size of 15 instead of 16. [many thanks
727 to Jean Michel Rouet for pointing out this bug].
729 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 1. Finish merging JMR patch for writting DICOM from scratch
731 2. Fix -hopefully- bug with MONOCHROME and space vs null character
732 3. Use const ref when possible
733 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
734 5. A few more comments
735 6. CreateUniqueUID can now be called without parameter"
737 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
738 * ENH: Slightly bigger patch:
739 1. Getting toward full integration of JMR patch for writting dicom from scratch
740 2. Update Test to test part of this patch: CreateUniqueUID
741 3. File was not close properly in gdcmDict
742 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
743 5. Use of const ref instead of copy (speed issue)
744 6. Remove temporary (duplicate) string in TranslateToKey
745 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
746 8. Do not repeat virtual in subclasses
747 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
749 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
750 * Apply first patch toward better string comparison when dealing with broken
751 DICOM files. Essentially the string could be padded with a space instead
752 of a null character as defined by standard
754 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
756 because never used... and in the same time, that's remove some memory leaks
758 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * src/gdcmFile.cxx : now delete the PixelConvert instance.
760 * In examples and tests : change the type of image data variables from void*
761 to uint8_t*. Remmove all delete on image data variables
763 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
764 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
765 Verify the file pointer value before open the file, and if it's not null,
766 a verbose message is generated.
767 Close correctly the file when the file isn't considered dicom-like. The
768 correctly close is a call to CloseFile.
769 When closing the file pointer, test if its not null to close the file.
770 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
771 file. For an uncompressed image, the copied data correspond in the least
772 case to the image size (calculated) or the image size specified in the
773 header. A verbose is generated if these two size mismatch
775 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
777 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
778 break under windows (with msvc6 compilation).
780 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
782 compiling with MSVC6)
784 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * Bugs fix for the Windows build with VC6
786 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
787 needed (only for projects required VTK). If the VTK is included in all
788 projects, there is conflicts with the jpeg lib of vtk when compiling the
789 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
790 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
791 when compiling the gdcm_wrap.cxx file (created by the compilation of the
793 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
794 (like it's already made for the cout use). Otherwise, conflict with the
797 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
800 - comments on the DicomDir::Method related usage added.
801 - now that we use the namespace gdcm, a lot of internal classes do
802 NOT need to be wrapped anymore.
803 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
804 DicomDir::Method) new example added.
806 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
807 * Improve string manipulation. I now inforce the notion of 'DicomString'
808 A DicomString can contain as many \0 as they want
809 and it is *always* of even length.
810 We only support odd length for very rare case.
811 And in the near future this should be removed.
813 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
814 * /binary_write/ gdcm source. Now even on big endian we are writting
815 little endian. This should -heopfully- fix some tests
817 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
818 * Now the dictionary is compiled into gdcm lib. This is a default
819 behavior, thus any dic file specified is picked before failback to
820 the one comiled into lib
822 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
823 * Change internals for gdcmDict. Don't use any 'new' any more.
824 This should definitely solve any leak problem, and we should be
825 as fast as before, as long as don't modify too much the dictionary.
827 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
828 * STYLE: ivars should start with a capital letter.
829 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
830 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
832 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
834 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
835 new 2004 dictionaries added (thanks to JPR).
836 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
837 * CLEANUP_ROUND (15) for gdcmPixelConvert
838 - RLEFrame::NumberFragments is now of type unsigned int
839 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
840 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
843 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * Initial work in gathering all transfer syntax accessors. clearly
845 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
846 ivars, but only one transfersyntax (class) ivar with equivalent method on
849 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
851 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
852 discussed (plus I didn't like having a 2000 lines patch not commited)
854 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
856 * CLEANUP_ROUND (14) for gdcmPixelConvert
857 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
858 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
859 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
861 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
862 anymore and hence avoids storing a copy of PixelConvert::Decompressed
863 into File::Pixel_Data.
865 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
867 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
868 * CLEANUP_ROUND (13) for gdcmPixelConvert
869 Substituted File::ParsePixelData() with PixelConvert::Print() new
871 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
872 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
873 method to those classes.
874 - src/gdcmFile.[cxx|h]:
875 -- Added a ::Print() method.
876 -- PixelConverter is now a reference instead of a member.
877 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
878 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
880 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
882 collaboration diagram and inheritance diagram should be generated with
884 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
885 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
886 pointlessly wrapped (see
887 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
888 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
889 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
890 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
891 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
892 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
893 -- File::Initialise: PixelConverter setup moved away to
894 PixelConverter::GrabInformationsFromHeader()
895 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
896 interpretation moved away to PixelConverter::BuildRGBImage()
898 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
900 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
902 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
904 displayed on Win32 when a brutal abort() occurs (because of uncatched
905 exception). See TODO new entry of this commit for more on this.
906 * TODO added new entry.
907 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
908 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
909 - HandleColor is no longer called from gdcmFile.cxx
910 - gdcmPixelConvert.cxx clean up on method arguments and internal
911 variable names for semantical coherence.
913 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * Finished lossless transition, not only do we now read all lossless jpeg
915 images, without the need of the Cornwell lib, but we do read them properly now
916 * To reduce code (well to avoid code duplication), I defined a common place
917 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
918 redefine symbols. This is not perfect but this the best solution I found for a
919 compilation time jpeg option.
921 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * Update jpeg ijg lib to support lossless jpeg implementation
923 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
925 * Also added a special copyright for dcmtk since we use their bugfixes.
928 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
930 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
931 matters, as stated in warning note at begining of %include section).
932 * src/gdcmDicomDir*.[cxx|h]: coding style
933 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
934 * src/gdcmJpeg8.cxx: doxygen fix.
935 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
936 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
937 from File:: to PixelConvert::.
939 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
941 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
942 - more code moved away from File:: to PixelConvert::
943 - fat setup of PixelConverter set in place in File::Initialise.
945 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
946 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
947 namespace at the file system level. So now you should convert your examples
949 gdcmHeader -> gdcm::Header
950 It would be nice if people keep in mind to no open the namespace, since it
951 allows compilation on broken plateform which were defining common symbol in
952 the standart namespace (like LP, Unknown ...)
954 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
955 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
956 The JPEG fragments are now parsed at the same stage than the RLE
957 information. All code related to JPEG is now in gdcmPixelConvert:
958 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
959 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
960 export a gdcmFile:: method. Those are simply global functions
961 (for the time being this is better than having them attach to
962 either gdcmFile:: or gdcmPixelConvert::).
963 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
964 and stores the result in a gdcmJPEGFragmentsInfo.
965 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
966 code (among other stuff) moved away from gdcmFile:; to
969 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
971 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
972 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
973 clean up of RLE related code.
974 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
975 - src/gdcmRLE.cxx removed
976 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
977 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
978 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
979 * CLEANUP_ROUND (9) for gdcmPixelConvert
980 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
981 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
982 away from gdcmFile:: to gdcmPixelConvert::.
984 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
986 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
987 This is because Parse7Fe0 used to parse the pixels to compute the
988 length. This task was passed over to FindDocEntryLengthOB() a long
989 time ago, EXCEPT I had forgotten the OW case...
990 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
991 we just recylce the code for parsing RLE fragments and computing
993 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
994 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
995 with the retired Parse7Fe0().
996 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
997 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
999 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1001 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1002 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1003 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1004 * CLEANUP_ROUND (4) for gdcmPixelConvert
1005 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1006 to return an unused length.
1008 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1009 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1010 this should be cleanner from the plane view. The iostream are erally a pain
1011 to use to do simple stuff.
1013 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1014 * Redo the compilation of the ijg jpeg library. Now only one source is
1015 necesseray. No need to rename file by hand what so ever. CMake handle the
1016 copying of the file within different directory, configure header file to
1017 modify some symbol. The only addition made to ijg wasd a mangle table so
1018 that symbol are different whether we are within 8bits or 12bits.
1020 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * Added documentation of vtkgdcmReader on Website:
1022 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1023 with it's binary name).
1024 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1025 the Website to be more complete.
1026 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1027 doxygenated documentation.
1028 - Doc/DoxyVtkGdcmReaderExamples.txt added
1029 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1030 DoxyVtkGdmReaderExamples.html )
1031 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1032 * CLEANUP_ROUND (3) for gdcmPixelConvert
1033 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1035 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1036 * CLEANUP_ROUND (2) for gdcmPixelConvert
1037 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1039 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * CLEANUP_ROUND for gdcmPixelConvert:
1041 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1042 - src/gdcmPixelStuff[h|cxx] removed
1043 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1044 - src/CMakeLists.txt changed accordingly
1045 * GDCMHOME clean up:
1046 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1047 gdcmVersion.py moved to newly created ATTIC related
1048 gdcmPython/SetupOldies/ directory.
1049 * Autotools clean up:
1050 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1051 - autogen.sh configure.in acinclude.m4 python.m4 removed
1053 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1055 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1056 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1058 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * TODO updated with Mathieu suggestions. I proposed a template for
1060 describing TODO entries and used it for new entries.
1061 * Added Doc/Website/CodingStyle.html, Developpers.html,
1062 DeveloppersPython.html, GdcmDataCvs.html and
1063 DownloadVersion0_1.html, DownloadVersion0_3.html.
1064 * Some Doc/*.txt Doxygen files (which do not really concern the
1065 documentation itself, but the website) moved to html and
1066 placed in directory Doc/Website:
1067 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1068 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1069 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1070 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1071 * CMakeLists.txt changed accordingly.
1072 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1073 DeveloppersPython.html
1074 * INSTALL nows refers to Doc/Website/Installation.html
1076 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1077 * Added Doc/Website directory, that contains a first raw version
1080 2004-09-23 Jean-Pierre Roux
1081 * FIX In order not to be poluted any longer by casting problems,
1082 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1083 we can now delete[] it safely
1084 * VoidArea is now called BinArea (less confusing name),
1085 and all the methods called ...VoidArea... are now ... BinArea...
1086 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1088 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1090 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1091 up to the destructor of gdcmElementSet to clean up TagHt and it's
1094 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1096 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1098 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * ENH: added some utility method that builds a flat dictionary
1100 holding all the Dicom entries contained in the recursive structure
1101 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1102 an example of usage.
1103 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1104 BuildFlatHashTable() that build a flat dictionary.
1105 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1106 gdcmDocument is now a friend of gdcmElementSet.
1107 - src/gdcmElementSet.cxx: clean up.
1108 - Example/FlatHashTablePrint.cxx added.
1109 - Example/CmakeLists.txt changed accordingly
1111 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1113 moved away from gdcmDocEntrySet (since this class is an abstract class
1114 acting like an interface). SQDepthLevel and BaseTagKey are now
1116 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1117 and associated accessors. Doxygenation of the class.
1118 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1120 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1121 Use SQDepthLevel accessor instead. ::Print() adapted.
1122 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1123 - src/gdcmDocument.cxx changed accordingly.
1125 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1127 - The following is the doxygen comment of the typedef declaration
1128 of gdcmTagKey in src/gdcmCommon.h:
1129 gdcmTagKey is made to old an "universal" (as in URL, Universal
1130 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1131 A dicom tag always has a group and an element, but a set of tags
1132 embeded in various (optionally nested) sequences and sharing
1133 the same group and element all share the same (group, element)
1134 "identifier". Hence the (group, element) cannot be used as an
1135 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1136 In order to construct a proper tag identifier (i.e. a key) we
1137 consider the following definition of a TagKey:
1138 - let Group, Element be the string representation of the
1139 group and element dicom tag members,
1140 - let ItemNumber be the string representation of the integer
1141 index of the considered item number of a sequence,
1142 Let the key of a tag embeded in a sequence, noted SeqTag, be
1144 /ItemNumber#Group|Element
1145 where "/", "#" and "|" are characters acting as separators.
1146 Then the general form of a gdcmTagKey is given by:
1147 Group|Element<SeqTag>
1148 where <SeqTag> means NO or many instances of SeqTag.
1149 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1152 but the gdcmTagKey of a tag "embeded" is the first item of
1153 a sequence, itself nested in the third item of a sequence is the
1155 0004|1220/2#0008|0082/0#0008|0090
1156 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1157 order to hold the new sequence compatible key. Previously, the
1158 GetKey() method would look in the underlying gdcmDictEntry.
1159 - src/gdcmDocEntry.cxx:
1160 -- constructor now copies the underlying DictEntry key, in the local
1162 -- ::Print: displays the member Key, instead of the (group, element).
1163 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1164 - src/gdcmDocEntrySet.h:xi
1165 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1166 -- now has a new BaseTagKey member.
1168 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1169 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1171 This poses the problem with the semantics of the following lines
1172 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1173 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1174 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1175 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1176 to the long FIXME note for what the problem is. Nevertheless in
1177 order to get things working the dicom dictionary was altered !
1178 Please fix things urgently...
1179 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1180 information), see above note on moving the member VoidArea. Nevertheless
1181 the following entries previously correctly set as US are now inproperly
1183 0028 1201 OW IMG Red Palette Color Lookup Table Data
1184 0028 1202 OW IMG Green Palette Color Lookup Table Data
1185 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1186 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1187 of gdcmDocEntry moved to gdcmSeqEntry.
1188 * src/gdcmSeqEntry.cxx: STYLE.
1190 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1193 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * gdcmPython/testSuite.py: all the test suite in python is now moved
1195 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1196 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1197 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1199 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1201 to avoid inclusion recursion until STL is reached.
1202 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1203 mecanism. errno.h is not included in gdcm anymore.
1204 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1205 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1207 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1208 gdcmData/TestAllEntryVerifyReference.txt
1209 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1210 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1211 exception_on_error parameter.
1212 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1213 - vtk/vtkGdcmReader.cxx changed accordingly,
1214 - Example/*.cxx and Test/*.cxx changed accordingly.
1216 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1217 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1218 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1219 enable_sequences removed from gdcmHeader constructor and dependencies.
1220 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1221 * gdcmPython/demo/PrintHeader.py: dummy fix.
1222 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1223 skip_shadow removed from gdcmHeader constructor and dependencies.
1224 * Example/*.cxx and Test/*.cxx changed accordingly.
1226 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1228 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1230 2004-07-21 Jean-Pierre Roux
1231 * FIX Now, Parsing and Printing a DICOMDIR do work!
1232 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1234 2004-07-20 Jean-Pierre Roux
1235 * FIX Some brain damaged headers have Zero-Lenght fields
1236 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1238 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1239 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1240 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1241 variable (instance of gdcmDebug) by a definition macro, and the instance
1242 is now in static in the gdcmDebug class
1243 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1244 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1246 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * WARNING: ctest now depends more tightly on gdcmData. You should
1248 check out gdcmData properly for things to run smoothly...
1249 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1250 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1251 we need the pixels not be loaded in order to use the ValEntry
1252 that displays position and size).
1253 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1254 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1255 be deprecated. If you have any doubts about the advantages of a
1256 modern scripting language (read Python) versus grass root C++ (i.e.
1257 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1258 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1259 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1260 Anyhow, consider documenting the gdcmData images in
1261 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1263 * Test/CMakeLists.txt:
1264 - now uses TestAllEntryVerify.cxx
1265 - specific comments on oldACR00001.ima (now renamed in gdcmData
1266 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1267 gdcmData/TestAllEntryVerifyReference.txt
1270 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * src/*.[h|cxx] : typedef clean up
1272 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1273 - TagKey renamed to gdcmTagKey (for external usage)
1274 - VRKey renamed to gdcmVRKey (for external usage)
1275 - removal of typedef duplication.
1276 - Removed all unecessary inline keyword from class inline definitions.
1277 - Some method|function(void) declarations replaced with method|function().
1278 * src/jpeg/libijg12/jdhuff12.c:
1279 - printf polluting ctest removed.
1280 - TAB removal for comminting
1282 - TestAllReadCompareDicom.cxx: added a test that compares all the
1283 images in gdcmDataImages.h with corresponding images in
1284 gdcmData/BaselineDicom/. When baseline images are not present
1285 this test creates them.
1286 Note: we need to validate each reference image, but before that
1287 I'd like to rename them with a more explicit name...
1288 - CMakeLists.txt: changed accordingly.
1289 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1290 including each header needed).
1292 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1294 test suite to the Example directory. Are concerned:
1299 - TestWriteSimple.cxx
1300 * Test/CMakeLists.txt: added some comments on reasons for black listing
1301 image gdcmData/oldACR00001.ima
1303 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1304 * Test/CmakeList.txt: removed the following from black list (to be coherent
1305 with removal from gdcmData):
1306 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1307 - gdcm-MR-PHILIPS-16.dcm
1309 Added the following because after last cvs update, they cause
1310 ctest -R TestReadWriteReadCompare
1312 - gdcm-MR-SIEMENS-16-1.acr
1314 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1315 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1316 new comments in this file) we temporarily (sigh) move to a weaker
1318 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1319 we don't need to black list the following images anymore:
1320 - 8BitsUncompressedColor.dcm
1322 - US-PAL-8-10x-echo.dcm
1323 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1324 fixes and the beautified code ;-)
1325 This fixes the bug introduced in version 1.42 (when beautifying)
1326 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1327 Note: ctest was blind to this bug (this means we need to still
1328 improve the test suite). The bug could be detected by using
1329 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1331 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1332 and by displaying the (garbage) produced file temp.XDCM...
1334 2004-06-29 Jean-Pierre Roux
1335 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1336 - replace by uggly but working old code :-(
1337 A lot of things should be OK again.
1338 It's really urgent to have a test suite that *tests*,
1339 to prevent Frog's beautifying sessions to break all the stuff
1340 (twice, withing a fortnigh ...)
1342 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1343 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1344 redundancy) to added Test/TestReadWriteReadCompare.cxx
1345 * Test/CmakeList.txt: because the compare test of
1346 Test/TestReadWriteReadCompare.cxx fails, the following images are
1347 black listed: - 8BitsUncompressedColor.dcm
1349 - US-PAL-8-10x-echo.dcm
1350 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1351 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1352 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1353 and ad-hoc kludge. This kludge is now removed, and on encountering
1354 such an image (OB field brain damaged) we set errno. Then in
1355 ::FindDocLength() we "fix" the length as being ALL what remains
1356 in the file (until EOF). We then proceed, hoping for the best...
1357 This fixes a SegFault in ShowDicom when trying to write such an
1359 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1360 (because TestWriteRead breaks on it, after a non conformal commit?).
1361 ctest now runs properly, except for MakeDicomDir (which was always
1362 broken) and the Python related stuff (still not fixed).
1364 2004-06-24 Jean-Pierre Roux
1365 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1366 FIX : Test/TestReadWrite now iterates on all the file names
1367 (instead of infinite loop)
1368 ENH : Test/TestWriteRead now iterates on all the file names
1370 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1373 2004-06-24 Jean-Pierre Roux
1374 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1375 when SamplesPerPixel =3
1376 - now Write is no longer confused by
1377 'BitsAllocated = 12" and 'BitsStored=12"
1378 - "UN" value representation Elements are now written correctly
1379 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1380 ENH : - now gdcmHeader has its own Write methods
1381 (in order to split the job that has not to be done
1384 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1386 loop on the same image until memory went out.
1387 Note: this means we still have gobs of memory loss in PrintDocument
1388 * src/gdcmDocument.cxx: fixes problem on parsing on file
1389 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1391 2004-06-24 Jean-Pierre Roux
1392 FIX : Write - All the Sequences and Sequence Item are now written
1393 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1394 is added a the end, when necessary.
1395 - A lot of brain-damaged images, that were read correctly are
1396 now written correctly
1397 - length compatible BinEntry are now loaded correctly
1398 (even for odd groups)
1399 Note : only Explicit Value Representation was checked.
1400 (question : is implicit VR really necessary for gdcm ?)
1402 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * DEVELOPPER: added a proposition of coding style.
1404 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1407 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1409 Use the gdcmDocEntry::Print() and Write() instead.
1410 * src/gdcmDocument.cxx: bug fix.
1412 2004-06-22 Jean-Pierre Roux
1413 FIX : gdcmDocument.cxx
1414 - Now we do recognize the JpegLossLess format (there was a misstyping in
1415 code 'beautyfication' :-(
1416 - Now we automaticaticaly load the Luts, if any
1418 2004-06-22 Jean-Pierre Roux
1419 In order : to write Sequences, whatever their imbrication level,
1420 : to allow user to create his own Sequences
1421 a lot of modif where necessary (adding, moving, or virtualising methods)
1423 WARNING : save your own sources *before* cvs up !
1426 ADD virtual void Write(FILE *fp, FileType filetype);
1429 ADD virtual void Write(FILE *fp, FileType filetype);
1430 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1433 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1434 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1435 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1436 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1437 ADD std::string GetEntryByName(TagName name);
1438 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1440 std::string vr = "unkn",
1441 std::string fourth = "unkn",
1442 std::string name = "unkn");
1443 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1444 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1445 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1446 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1447 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1448 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1449 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1450 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1453 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1454 ADD virtual std::string GetEntryByName (TagName tagName);
1455 ADD virtual std::string GetEntryVRByName (TagName tagName);
1456 REM virtual bool Write(FILE *, FileType);
1457 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1458 FILE *_fp, FileType type);
1459 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1460 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1461 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1462 REM virtual std::string GetEntryByName (std::string tagName);
1463 REM virtual std::string GetEntryVRByName (std::string tagName);
1464 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1465 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1466 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1468 std::string vr = "unkn",
1469 std::string fourth = "unkn",
1470 std::string name = "unkn");
1471 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1472 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1473 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1474 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1477 ADD virtual void Write(FILE *fp, FileType filetype);
1480 ADD virtual void Write(FILE *fp,FileType filetype);
1483 ADD virtual void Write(FILE *fp, FileType filetype);
1484 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1485 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1486 REM std::string GetEntryByName(TagName name);
1489 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1491 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1492 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1493 The default constructor invoked by the line
1494 gdcmHeader *f1 = new gdcmHeader( header );
1495 was gdcmHeader::gdcmHeader(bool) instead of the expected
1496 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1497 Hence the parsing wasn't executed... See also below.
1498 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1499 as explicit constructor didn't do the trick to fix the above problem.
1500 Could anyone explain why ?
1501 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1502 properly calls gdcmValEntry::Print() (that was weed out from
1503 code related to gdcmBinEntry).
1505 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1506 * In order to fix memory leaks:
1507 - Test/TestWriteSimple.cxx: added cleaning of free store through
1509 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1510 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1511 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1512 (through the call to ::AddDicomDirMeta()) or the destructor
1513 would crash when deleting uninitialized ::metaElems].
1514 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1515 - src/gdcmDocument.cxx:
1516 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1517 from dynamic stores.
1518 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1519 was causing memory leaks.
1520 - src/gdcmSQItem.cxx:
1521 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1522 cleanly handled with polymophism: sorry but my milage is low).
1523 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1524 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1525 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1526 This avoids SegFaulting.
1527 - src/gdcmSQItem.h: coding style.
1529 - Test/TestWriteSimple still severely sucks. The output image content
1530 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1531 damaged when displayed with vtkgdcmViewer.
1532 - on memory leaks: TestWriteSimple leaks really less (see entry
1533 of 2004-06-18 in Changelog file for the call to valgrind).
1534 - on segfaults: ctest now passes all the tests but one (no more
1536 * Erroneous leading white fix:
1537 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1538 white[s] (as opposed to from >> xxx, that removes it [them].
1539 - src/gdcmTS.cxx: ditto.
1540 - gdcmPython/testSuite.py: dirty related kludge removed.
1541 * src/*: remaining references to gdcmParser removed.
1542 * src/*[cxx|h]: added copy[way]left header.
1545 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * In order to fix writing of dicom files:
1547 - Test/TestWriteSimple.cxx: a simpler example of writing.
1548 - Test/CMakeLists.txt changed accordingly.
1549 - src/gdcmDocument.cxx:
1550 -- The destructor now recursilvely removes potential sequences.
1551 -- Bug fix in ::IsJPEG2000()
1552 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1553 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1555 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1556 to only declared) and build on top of
1557 ::GetDocEntryByNumber(guint16, guint16).
1558 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1559 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1560 for usage in destructor and treatement of promotion in
1561 ::ReplaceOrCreateByNumber().
1562 - src/gdcmSQItem.cxx: destructor should better handle his job.
1563 Test/TestWriteSimple now runs (or at least it DOES something).
1564 * We can now start hutting memory links. A good starting point is:
1565 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1566 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1567 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1569 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * Valgrind note: after Mathieu Malaterre teached me how to read
1571 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1573 Using gcc, you can force the STL to use malloc and to free memory as
1574 soon as possible by globally disabling memory caching.
1575 With 3.2.2 and later, you should export the environment variable
1576 GLIBCPP_FORCE_NEW before running your program.
1577 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1578 simply vanish (it is still not clear to me, whether this means that
1579 STL std::string leaks or if valgrind believes it leaks...).
1580 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1581 running bin/gdcmTests makeDicomDir):
1582 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1583 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1585 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1586 SegFaulting (I drowned in DicomDir related code when trying to
1587 understand why the list is empty...).
1588 * src/gdcmDocument.h: first BSD license header try.
1589 * Doc/License.txt added.
1591 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * src/gdcmDocument.[h|cxx]:
1593 - Clean up of the Transfer related predicates. They are now all based
1594 on new method isGivenTransferSyntax, that (should) handle properly
1595 the padding problem.
1596 - general clean up, simplification, and coding style.
1597 - Specific clean up of Parse7FE0() (umproperly named actually).
1598 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1600 2004-06-14 Jean-Pierre Roux
1602 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1603 - fix the display of SQItem ordinal number
1604 - add the GetSQItemByOrdinalNumber method
1605 - remove some useless never written private methods
1607 2004-06-14 Jean-Pierre Roux
1609 - adding a constructor taking a gdcmDocEntry as an input param
1610 - ReplaceOrCreateByNumber now returns :
1611 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1612 a gdcmValEntry * if a string value is passed as a param
1614 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1615 according to the param type (no longer sets a gdcmDocEntry)
1616 - GetValEntryByNumber, GetBinEntryByNumber added
1617 - NewValEntryByNumber and NewBinEntryByNumber added
1619 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1621 - GetSQItemNumber and SetSQItemNumber added, to provide
1622 a (relative) Item identier inside a given Sequence
1623 \warning : some pb remaining around this number
1625 - AddEntry now takes the Item Number as a param
1627 - adding a constructor taking a gdcmDocEntry as an input param
1629 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * Memory leak hunt with the following command:
1631 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1632 --show-reachable=yes gdcmTests PrintDocument
1633 It looks like many (all?) leaks are due to the STL (or a bad usage
1634 of the STL. The lines producing the leaks now have a comment with
1635 a "MEMORY LEAK" tag: you can retrieve them with
1636 grep "MEMORY LEAK" src/*
1637 Here are two typical examples which I can't help fixing:
1642 char * test = "babo";
1643 name = test; //// <--- valgrind detects 960 bytes lost in
1644 //// call to std::string::operator=(char const*)
1645 name.clear(); //// Doesn't help !
1653 std::cout << "Type a bunch of characters followed by RETURN: ";
1654 getline(std::cin, line); //// <--- valgrind dectects a loss
1655 //// of 1320 bytes in call to
1656 /// std::basic_istream<>& std::getline<>
1662 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * src/gdcmHeader.[cxx|h]:
1664 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1665 and related, moved away to gdcmDocument.
1666 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1667 the corresponding protected accessors of inherited class
1668 gdcmDocument, removed ! As a consequence gdcmFile had to be
1669 declared friend of class gdcmDocument (see below).
1670 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1671 - Clean up of undefined or unused methods.
1672 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1673 account the changes to gdcmHeader.h).
1674 * src/gdcmDocument.h:
1675 - gdcmFile is now a friend class (in order to take into account the
1676 changes to gdcmHeader.h).
1677 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1678 (see changes to gdcmHeader.h).
1679 - Accessors (reading on the form GetEntry*) are now public.
1680 - Clean up of undefined or unused methods.
1681 * src/gdcmDocument.cxx:
1682 - adaptation to changes to gdcmDocument.h
1683 - ::OpenFile now writes a verbose message when file cannot be opened.
1684 - some std::string properly set to VRKey
1685 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1686 references to gdcmDocument.
1687 * Test/TestFindTags.cxx: changed accordingly to above changes.
1688 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1689 cvs repository gdcmData.
1691 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1693 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1694 conflicts with gdcmValEntry::voidArea.
1695 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1696 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1697 Value representation between StringRepresentable and BinaryRepresentable.
1698 * src/gdcmDocument.cxx:
1699 - method ParseDES: proper indentation restored and usage of
1700 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1701 - method LoadDocEntry: the fingerprint left in the SetValue() of
1702 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1703 removed. Reverting to previous code segment with the proper
1704 dynamic_cast< gdcmValEntry* >.
1705 Note: this was (partially) breaking the python test suite
1706 (gdcmPython/testSuite.py) that made usage of the above
1707 fingerprint to check presence of "Pixel Data".
1708 * src/gdcmDocEntry.h: coding style.
1709 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1710 now taken into account.
1711 * gdcmPython/gdcm.i: adaptation to the new internal representation
1712 of gdcm (exit gdcmParser, hello gdcmDocument).
1713 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1715 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1716 anymore, but instead prints the loaded Python dictionary.
1717 * .... alas, the python testSuite is still broken.
1719 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1720 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1722 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1723 * src/gdcmUtil.h : export methods
1725 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1728 * Initial addition of automatic python testing
1729 * Initial addition of automatic image comparison
1731 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1732 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1733 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1735 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1736 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1737 * Test/ShowDicom.cxx : bug fix for msvc compilation
1738 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1740 2004-05-04 Jean-Pierre Roux
1741 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1742 new concepts (and new classes) :
1743 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1744 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1745 - Sequence Doc Entries (gdcmSeqEntries)
1746 a Sequence is composed of Items.
1747 Each item is a set of Doc Entries (this is recursive)
1748 The non uniqueness of the 'Dicom tag' is due to this recursivity
1749 (never taken into account)
1750 Our unability to add a new 'entry' in the header
1751 at the proper location (neither in the H-Table (map or multimap),
1752 nor in the Chained List is also due to this recursivity.
1753 Don't try, right now, to use/modify/compile these new sources :
1754 nothing is finished.
1755 We just commit all the stuff, 'as is', in order not to loose it.
1757 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1758 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1760 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1761 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1762 file prefix (SetFilePrefix)
1764 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * Add a new test: ShowDicom, for now this is just the c++ version of
1766 checkRead.sh, later it will be able to compare the image read against a
1768 * Replace the DEBUG on the stack with a global entry in cmake interface:
1769 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1771 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1772 * Add an example subdir, with a real example on how to read + write a
1775 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1777 * Doc/CMakeLists.txt: the main page is now properly differentiated
1778 between the developper and user version.
1779 * Doc/doxygen.config.in: dropped search related obsolete flags
1780 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1782 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1783 * DEVELOPPER: added some helpfull comments for compile/test/install
1786 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1788 src directory, now generated in the build dir.
1789 2. Tests as mentionned smarter
1791 4. Add a new method in gdcmDict that return the PubDict by name
1792 this is interesting for 3rd party lib like ITK,
1793 where we could set the institution name / patient name...
1795 * ENH: 1. Now the test suite is working for real
1796 2. All binaries are now output in the gdcm-bin directory
1797 (this was not true before)
1799 2004-04-28 Jean-Pierre Roux
1800 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1801 SeQuence indented printing of Dicom Header.
1802 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1803 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1804 Computation of SQDepthLevel is now part of gdcmHeader constructor
1805 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1806 tree-like structure of a Dicom Header.
1807 * FIX Test code cleaning
1809 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1810 * ENH: Adding automatic testing
1811 1. Need a DartConfig.cmake to submit to public
1812 2. Add a test driver gdcmTest.cxx
1813 3. gdcmTestMain, an helper for the main test driver gdcmTest
1814 4. Files in Test don't have a main anymore, this becomes interesting
1815 when we add more and more tests, thus dsw don't have to load
1817 * ENH: Adding a GDCM_DATA_ROOT for testing
1818 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1819 one file instead of seven + some small cleanup
1821 2004-04-22 Jean-Pierre Roux
1822 * ENH Minor changes to the Print() methods.
1823 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1824 Header printing. Example given with :
1825 > PrintHeader fileName 2 new
1826 (SQ based tree-like structure still to be done for the Header ...)
1828 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1830 1. I have added some unsigned where needed
1831 2. Some function parameter not used -> (void)
1832 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1833 4. g++ don't like character '\' in comment
1834 5. #define jpeg_create_decompress jCreaDecompress
1835 this really need to be fixed
1836 6. virtualize destructor of gdcmObject ... leakage
1837 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1838 this also really need to be fixed
1839 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1840 remove compression file
1841 (as we only do decompression, right ?)
1842 * ENH: Change malloc/calloc/free with c++ equivalent
1844 2004-04-21 Jean-Pierre Roux
1845 * FIX gdcmHeaderHelper::GetXSpacing
1846 when a single value is found (bug ?), xpacing is now
1847 defaulted to yspacing
1849 2004-04-19 Jean-Pierre Roux
1850 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1851 * ENH add parameters :
1852 bool exception_on_error = false,
1853 bool enable_sequences = false,
1854 bool ignore_shadow = false
1855 to the gdcmFile constructors to be full gdcmParser compliant
1856 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1857 to allow reading of PAPYRUS 3.0 files
1859 2004-04-06 Jean-Pierre Roux
1860 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1862 2004-04-02 Jean-Pierre Roux
1863 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1864 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1865 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1867 2004-03-30 Jean-Pierre Roux
1868 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1869 for ACR file, written out as DICOM files (hope so...)
1871 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1873 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1874 moved to base class gdcmParser and only the specialisation is kept
1876 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1877 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1878 already does the job.
1879 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1880 (to be consistent with gdcmParser::WriteEntries).
1882 2004-03-30 Benoit Regrain
1883 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1884 upate of the object's instance. It's passed to 2 in the unfavorable
1885 case : one in the ExecuteInformation, one in the ExecuteData
1887 2004-03-29 Jean-Pierre Roux
1888 * ENH : Check on file type to be written moved
1889 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1890 * FIX : gdcmObject::ResetBoundaries now stops properly
1891 when end-of-list is reached
1892 : gdcmVersion modified (as Benoit Regrain asked)
1894 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1895 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1896 * src/gdcmUtil.cxx: added forgotten iostream include.
1897 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1898 equivalent to ExplicitVR in existing code).
1900 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1901 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1902 now contains all the gdcmGlobal related code.
1903 * minor coding style and doxygenation changes.
1905 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1907 now contains all the Debug related code.
1908 * minor clean-up of includes in src/*.cxx
1909 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1910 CreateCleanString) removed.
1911 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1912 * Doc/DoxyMainPageUser.txt added.
1913 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1914 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1915 src/gdcmDirList.cxx)
1917 2004-03-24 Jean-Pierre Roux
1918 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1920 2004-03-23 Jean-Pierre Roux
1921 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1922 big endian made volumes
1923 * ENH Now gdcmParser constructor and destructor are protected to forbid
1924 end user to instanciate class gdcmParser
1925 (only gdcmHeader and gdcmDicomDir are meaningfull)
1927 2004-03-22 Benoit Regrain
1928 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1929 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1930 gdcmSerie to gdcmDicomDirSerie
1932 2004-03-19 Jean-Pierre Roux
1933 * ENH Now the tree-like structure describing a DICOMDIR comming from
1934 an already existing DICOMDIR file is consistent with
1935 the home-made tree-like structure build ex-nihilo
1936 or build from the files held (recursively) in a Directory
1937 functions gdcmDicomDir::CheckBoundaries()
1938 gdcmObject::SetBoundaries() added
1940 2004-03-17 Jean-Pierre Roux
1941 * REM (Eric Boix bug) : removal of meaningless
1942 gdcmDicomDirImage::NewImage function.
1943 * FIX now file names and directory name are written properly in the
1945 * FIX now gdcmDicomDir constructor may be call without any trick
1948 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1949 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1950 of gdcmDicomDirImage::NewImage as empty function.
1952 2004-02-28 Jean-Pierre Roux
1953 * ENH add gdcmDicomDir:NewPatient
1954 add gdcmDicomDirPatient:NewStudy
1955 add gdcmDicomDirStudy:NewSerie
1956 add gdcmDicomDirSerie:NewImage
1957 to allow making gdcDicomDir object.
1958 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1959 (as opposite to the gdcmHeader chained list)
1961 2004-02-11 Benoit Regrain
1962 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1963 when using from python
1965 2004-02-10 Benoit Regrain
1966 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1967 * FIX : in gdcmDicomDir when the directory is empty
1968 * ENH : add callback and methods to get the progression of dicomDir
1971 2004-02-06 Jean-Pierre Roux
1972 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1973 - GDCM_META added to gdcmDicomDirType
1974 - class gdcmMeta created
1975 * ENH : - A brief summary is now displayed at the beginning of
1976 'testDicomDir' to help disaster magnitude estimation
1977 * REM : Now useless Test/explDICOMDIR.cxx
1979 2004-02-05 Benoit Regrain
1980 * ENH : add methods in gdcmObject to get the hash table or the list of
1982 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1983 * FIX : wrapping python for TagHeaderEntryHT
1985 2004-02-04 Benoit Regrain
1986 * FIX : even length for some strings when writting the dicom dir
1987 * FIX : sort the images in the dicom dir
1988 * FIX : Bug fix for python use of dicom dir
1989 * ADD : a python demo
1991 2004-02-04 Jean-Pierre Roux
1992 * FIX : Final solution (?) for icone embedded images
1993 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1994 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1995 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1996 gdcmData/gdcm-MR-SIEMENS-16.acr1
1997 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1998 to make full checking easier
2000 2004-02-04 Benoit Regrain
2001 * FIX : WriteEntries : coding style & logic in parameters
2002 * FIX : Set the elements to create the DicomDir in a dictionary file
2004 2004-02-03 Benoit Regrain
2005 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2006 * gdcmDicomDir : add the load of directory
2007 * Bug fix and print add-on
2009 2004-02-03 Jean-Pierre Roux
2010 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2011 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2012 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2013 * FIX gdcmParser.cxx : 'group length' elements are now considered
2014 as integers, even for shadow groups, when file is Implicit VR
2016 2004-02-02 Jean-Pierre Roux
2017 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2019 of the last synonym :-(
2020 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2022 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2023 * FIX taking into account the possible 7fe0,0010 multiplicity
2024 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2025 to allow removal of references to 7fe0,0010, to deal with
2026 ACR-NEMA images, when 0028,0200 is meaningfull
2028 2004-01-31 Jean-Pierre Roux
2029 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2030 no longer writes 'Un' on disk
2031 * FIX SQ elements with actual length are now dealt with corectly
2032 * FIX gdcmFile::WriteBase make the difference, for color images, between
2033 the length (for Palette expanded images)
2034 and Raw Length (non expanded image + Palette)
2035 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2036 (that broke Write). Replaced by UL.
2037 Aware user will reload the field if he
2038 thinks it's necesssary
2040 2004-01-30 Jean-Pierre Roux
2041 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2042 when 'dirty Acr' is found, to be compliant with the new
2043 IsReadable() methods.
2045 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2046 (no DOUBLE images in kosher DICOM,
2047 but so usefull for people that miss them ;-)
2049 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2050 DICOMDIR related utilities (not checked as Windoze compliant)
2052 2004-01-28 Jean-Pierre Roux
2053 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2055 2004-01-27 Jean-Pierre Roux
2056 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2057 to allow skipping the shadow elements, to save memory space.
2058 The TRUE value for this param has to be used
2059 with a FALSE value for the 'enable_sequence' param.
2060 ('public elements' may be embedded in 'shadow Sequences')
2061 * gdcmHeader methods now deal with 'embedded icones images' in the header
2062 (even when an 'icone image sequence' is announced by the
2063 element (0x0088,0x0200), but there is NO icone at all ...
2065 * gdcmHeader sometimes Image Location value doesn't follow
2066 the supposed processor endianity (see gdcmData/cr172241.dcm).
2069 * gdcmHeader add the method
2070 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2071 to get *all* the Header Entries with the same tag.
2072 GetHeaderEntrySameName is probabely *useless*
2073 (no meaning : Name is *not* an identifier within the Dictionary)
2075 2004-01-26 Benoit Regrain
2076 * Bug fix in the print of hexadecimal representations. Remove long fields
2077 in the print and add a third level of print to print them
2079 2004-01-23 Benoit Regrain
2080 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2081 * Bug fix on test suite after remove the strip made on not string fields
2082 * Split the IsReadable method between gdcmParser which test that the file
2083 is dicom and gdcmHeader which test that it's an image file
2085 2004-01-22 Benoit Regrain
2086 * DicomDir : clean code, add methods, set variables in protected or private
2087 * gdcmUtil : bug fix for the clean string method
2089 2004-01-19 Benoit Regrain
2090 * Add the use of shadow dictionaries
2091 * bug fix and coding style
2093 2004-01-19 Benoit Regrain
2094 * src/gdcmFile.cxx : bug fix concerning the close of file
2095 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2096 * Add the update of header entries using the shadow library
2098 2004-01-19 Benoit Regrain
2099 * removal of file gdcmHeader2.cxx
2100 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2101 inheriting from gdcmParser. This split is to prepare the integration
2102 of dicom dir parsing
2103 * bug fix under python
2105 2004-01-16 Jean-Pierre Roux
2106 * REM removal of class gdcmHeaderEntrySet
2107 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2108 * ADD add file gdcmHeader2.cxx
2109 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2111 2004-01-15 Benoit Regrain
2112 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2113 entries created while parsing the header. Thus, they will be destroyed
2114 when the gdcmDictSet will be destroyed
2115 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2118 2004-01-15 Benoit Regrain
2119 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2120 made a fatal error because of the memory release at the end of program.
2121 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2122 some memory and vtk seems to have some problems with that.
2123 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2125 2004-01-14 Benoit Regrain
2126 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2127 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2128 * src/*.[h|cxx] : make changes due to class name changes
2129 * gdcmPython/demo/*.py : bug fix due to method names
2131 2004-01-13 Benoit Regrain
2132 * src/*.[h|cxx] : coding style
2133 * vtk/*.[h|cxx] : coding style
2135 2004-01-13 Benoit Regrain
2136 * gdcmPython/testSuite.py : test the readable flag of file for tests
2137 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2138 It's lied to the stl compilation by MSVC (windows, always windows...)
2139 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2141 2004-01-12 Benoit Regrain
2142 * src/*.h : add comments
2143 * src/gdcmDictSet.h : set the method BuildDictPath in public
2144 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2145 directly setted in the source code
2146 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2149 2004-01-09 Benoit Regrain
2150 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2151 * setup.py : use a reference to gdcmVERSION
2153 2004-01-07 Benoit Regrain
2154 * Modification to compile with the distutils.
2157 2003-12-10 Benoit Regrain
2158 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2159 can use a gdcmHeaderHelper to load data
2160 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2161 made in the source code
2163 2003-12-10 Benoit Regrain
2164 * Update Windows projects and .cvsignore files
2166 2003-11-12 Jean-Pierre Roux
2167 * ENH gdcmHeader constructor has one more parameter (default value : false)
2168 that allows the user to 'go inside' the SeQuences only
2170 gdcmElValSet:Print takes it into account
2172 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2173 * ENH: Update gdcmPython/CMakeLists
2174 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2175 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2177 2003-11-10 Jean-Pierre Roux
2178 * FIX : gdcmHeader::LoadElements is now based
2179 on the ListTag listElem member,
2180 not longer on the TagElValueHT tagHt member
2181 * ENH : PrintPubElVal shows (temporarily) both results,
2182 with the tagHt member and the listElem member.
2183 (it's easier to 'see' the problems when using Printheader)
2185 * FIX : old private member LgrElem is now splitted into
2186 ReadLength : Length actually found on disk (updated only
2187 if bug fixing is necessary), for internal
2189 UsableLength : Updated by FixFoundLength, to fix a bug
2190 or to allow Parser going on.
2191 Will allow to re-write a kosher header when a SeQuence
2192 with a length (not 0000) is found
2193 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2194 because gdcmElValSet::Add does not update ListElem
2197 2003-11-07 Jean-Pierre Roux
2198 * FIX misstyping in Transfert Syntax name table
2199 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2200 when they have an actual length (not 0000 nor FFFFF)
2201 (Nobody should care of it, but DICOMDIR explorers)
2203 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2206 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * ENH: vtkGdcmReader now supports LUT !
2208 (vtkgdcmViewer for now is not able to use them though)
2210 2003-11-05 Jean-Pierre Roux
2211 * in testSuite.py : new files names for checking the package
2212 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2213 that returns the pixel area size to the *aware* (vtk) user
2214 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2216 2003-11-05 Benoit Regrain
2217 * in testSuite.py : Modify the rules for checking the paths
2218 : Explicit error messages
2219 * in __init__.py : Related modif
2221 2003-11-03 Jean-Pierre Roux
2222 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2223 to be used by aware (vtk) users that want to manage
2224 LUT (and no to turn the PALETTE image into an RGB pixels one)
2225 * GetPixelType now returns 8U for 24 Bits images
2226 (vtkGdcmReader compliant)
2228 2003-10-31 Jean-Pierre Roux
2229 * Removal of *all* gdcmData images and add them again
2230 in order to loose the 'history' of un-anonymised images
2232 2003-10-31 Jean-Pierre Roux
2233 * RMV : removal of useless jBitsInJsample.h
2234 for both 8 and 12 Bits JPEG Lossy Libraries
2236 2003-10-31 Jean-Pierre Roux
2237 * ENH : Add the functions gdcmFile::GetImageDataRaw
2238 gdcmFile::GetImageDataIntoVectorRaw
2239 that act as GetImageData and GetImageDataIntoVector
2240 except the making of an RGB Plane from Gray Plane + LUT
2241 Intended to aware (vtk) users who know how to manage
2244 GetLUTRGBA return a R,G,B,A LUT if any
2245 lgrTotaleRaw gives the 'Raw' length
2246 GetImageDataRaw returns the gray Plane
2247 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2248 (They stay Grey, just like with other Dicom viewers :-(
2250 2003-10-30 Jean-Pierre Roux
2251 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2253 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2254 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2255 being coherents dicom files.
2257 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2260 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2261 * ENH: Two steps is necessary to please VC++ compiler...
2262 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2263 * ENH: Add include dir to medcon lib
2264 * FIX: only one function is being exported for now !
2265 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2267 2003-10-29 Jean-Pierre Roux
2268 * adding gdcmHeader::GetLUTRGBA
2269 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2270 --> Mathieu, the modif u're waiting for is not yet committed
2271 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2273 2003-10-27 Jean-Pierre Roux
2274 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2275 00191113.dcm DermaColorLossLess.dcm
2276 MxTwinLossLess.dcm RadBWLossLess.dcm
2277 * ENH: For version prior to vtkImageViewer2 -r 1.19
2278 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2280 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * Removal of ido stuff in CMakeLists.txt
2283 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2285 * FIX: remove a call to ->Modified ... see comments
2286 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2288 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2289 * FIX: Problem with path for libvtkgdcmPython
2290 * ENH: Try adding a search script for python site-package
2291 * RMV: Remove some file from medcon lib that are not necessary
2292 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2293 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2294 * FIX: More pragma disable fro VC++,
2295 I don't think I break something as it is also disable in VTK/ITK.
2296 But it fasten debug compilation time.
2298 2003-10-23 Jean-Pierre Roux
2299 * gdcm now deals with 16 Bits Run Length Encoded images
2300 (they are compressed as 2 planes images,
2301 one for the high Bytes, the other for low Bytes)
2303 2003-10-22 Jean-Pierre Roux
2304 * Now CheckRead takes into account :
2305 - the bugged 'Leonardo' Siemens images
2306 - the XA images, sent thru the burning VPRO station
2307 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2310 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * FIX: When copying a Makefile.am to CMakeLists.txt
2312 one should remove the '\'
2314 2003-10-22 Jean-Pierre Roux
2315 * in gdcmData adding a bugged 'Leonardo' Siemens image
2316 (wrong lengths in header)
2317 OK with gdcm, KO with the other viewers :-)
2318 * add a GE dlx XA image, thru the VEPRO burning station
2321 2003-10-21 Jean-Pierre Roux
2322 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2323 for a brutal checking of vtkgdcmViewer compliance
2325 2003-10-21 Jean-Pierre Roux
2326 * add the files for 'xmedcon' Jpeg Lossless library
2327 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2329 2003-10-21 Jean-Pierre Roux
2330 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2332 2003-10-21 Jean-Pierre Roux
2333 * garbage Siemens 'Leonardo' images dealt with
2334 (the patch is easy to remove)
2335 * cosmetic changes to avoid warnings
2337 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2338 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2339 no need to press 'r' now.
2341 2003-10-20 Jean-Pierre Roux
2342 * upgrade of checkRead.sh checkWrite.sh according
2343 to new Jpeg Lossless decompressor
2344 * add US.3405.1.dcm, a genuine RGB medical file ...
2345 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2346 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2348 2003-10-15 Jean-Pierre Roux
2349 * general anonymisation in gdcmData
2350 * adding the 'color files' from
2351 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2352 * adding some well knowed bugged-header images
2353 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2354 waiting for their inclusion in Python testsuite
2356 2003-10-15 Jean-Pierre Roux
2357 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2358 no longer seg faults when file is not found
2360 2003-10-14 Jean-Pierre Roux
2361 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2364 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2365 * TODO: *.in file to genereate a UseGDCM later
2367 2003-10-14 Jean-Pierre Roux
2368 * Some supposed-to-be Dicom Images have no preamble.
2369 OpenFile takes it into account
2370 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2371 * Missing elements added in dicomV3.dic
2372 (just to be affraid : have a look at
2373 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2374 and do it again next year ;->
2376 2003-10-13 Jean-Pierre Roux
2377 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2378 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2379 But there are NOT. It's fixed !
2381 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2382 * FIX: "jpeglib.h" was not found on VC++
2383 * FIX: vtkgdcm was not being installed
2385 2003-10-10 Jean-Pierre Roux
2386 * ENH : OpenFile closes the file if it *really* doesn't look like
2387 an ACR-NEMA / DICOM one.
2388 * FIX : testWrite no longer writes an empty file if the source file
2389 is not gdcm Readable
2390 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2393 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * FIX: CMake generate now documentation
2395 * ENH: out of source doc build !
2396 * ENH: Generate both user and dev documentation
2397 * ENH: Should work on windows too
2398 * ENH: Only one doxygen config.in file is needed
2399 * FIX: make install should be ok now on ùnix plateform
2400 * FIX: PATH to dictionary was wrong (missing /)
2401 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2403 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2404 * vtkGdcmReader is now able to read rgb dicom file.
2405 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2406 * added a gdcmViewer to vtk test, use mouse to control
2407 window level & window width
2409 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2410 * CMake-ification of gdcm, we have now two build system
2411 * FIX: on cygwin Wsock32 doesn't exist
2412 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2414 2003-10-06 Emanuel Ollart
2415 * FIX : compilation process wad broken.
2416 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2418 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * change gdcmViewer -> vtkgdcmViewer
2420 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2422 2003-10-06 Jean-Pierre Roux
2423 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2424 ( e.g : well known GE images with a wrong elem length,
2425 : Philips MRI Images with a wrong Huffman table)
2426 * still to be done : allow the reading of bugged LEONARDO Siemens images
2428 2003-10-03 Jean-Pierre Roux
2429 * Odd length strings are padded with '\0' (not with spaces,
2430 to remain compliant with already defined strings,
2431 like Transfert Syntax UID and others)
2433 2003-10-03 Jean-Pierre Roux
2434 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2435 to allow displaying RGB images (not only by affim ;-)
2437 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2438 * vtkGdcmReader is now able to read rgb dicom file.
2439 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2441 2003-10-03 Jean-Pierre Roux
2442 * A few nasty patches to allow the reading of a lot of nasty images
2443 ( e.g : well known GE images with a wrong elem length,
2444 : Philips MRI Images with a wrong Huffman table)
2445 * still to be done : allow the reading of bugged LEONARDO Siemens images
2447 2003-10-03 Jean-Pierre Roux
2448 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2450 2003-10-03 Jean-Pierre Roux
2451 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2452 to allow displaying RGB images (not only by affim ;-)
2454 2003-10-03 Jean-Pierre Roux
2455 * gdcmFile::GetImageDataIntoVector now
2456 - deals with MultiFrames MultiFragments Run Length Encoded files
2457 - deals with YcBcR (YBR_FULL) files
2458 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2459 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2461 (no sample found :-(
2463 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2464 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2465 Two reasons: - clear things
2466 - third parties acces gdcm through header files, so won't
2467 suffer anymore VC++ complains
2469 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2470 * add argv[1] in testvtkGdcmReader.cxx
2473 2003-09-24 Jean-Pierre Roux
2474 * The lines are now eigthy characters long.for
2475 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2477 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2478 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2479 char* to std::string. Thus, the use of strdup becomes useless. (see
2480 previous commis of Malaterre)
2481 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2482 before the last Malaterre's commit.
2484 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2485 * This commit should fix the Debug building under VC++, the problem
2486 was mainly a mixture of debug and release lib being loaded at startup.
2487 * I also remove a depency to a specific C function: strdup. Because I had
2488 to force the link to msvcrtd (whereas strdup is in libc).
2490 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2491 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2492 located in the gdcmCommon.h file. All use of reference of tha has been
2493 changed to now use the variable GDCM_UNFOUND.
2495 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2497 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2498 Dicom dictionary. The test suite can now be run again. Note:
2499 I'm note very happy with the " (RET)" changes. I believe this
2500 RETAINED comment should be dropped when parsing the dictionary.
2501 - PACKAGER corrected
2503 - AUTHORS updated and now in alphabetical order
2504 * Makefile.am now exports gdcm.dsw for Windoze users.
2506 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * cygwin complains about missing std:: in subdir Test/
2509 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2510 * remove some methods that are now in gdcmHeaderHelper
2512 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2513 * vtkGdcmReader set spacing and origin correctly
2515 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * Fix a few delete/delete[] mismatch
2518 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2519 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2520 interpretation to data given by gdcmHeader. For instance there are
2521 heuristics to get informations (look at different places).
2522 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2523 sorting DICOM images based on different strategies.
2524 * modified Makefiles accordingly.
2526 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2528 when building in debug mode
2529 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2530 src/win32/gdcmdll.dsp
2531 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2533 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2534 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2537 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * src/win32/libgdcmjpeg12.dsp was not dos format
2539 * src/win32/libgdcmjpeg12.dsp :
2540 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2541 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2543 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2544 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2546 * src/gdcmFile.cxx : bug fix in affectation type
2547 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2548 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2549 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2550 symbols... future problem ?
2552 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2553 * src/win32/libgdcmijpeg12.dsp was missing
2554 * modified gdcm.dsw accordingly
2556 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2559 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2560 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2561 commit of JPR (before his hollidays to facilitate our work).
2562 * setup.py : bug fix in code. Modifications made while the last commit
2563 of JPR. The code hasn't been tested before the commit... it's so
2564 useless to make that (for best programmer that is JPR) !!!
2566 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * tagged the current version as Version0_3 (i.e. version 0.3)
2569 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2570 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2571 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2572 * *.dsp : modifications to use new libgdcmijpeg8 library
2573 * setup.py : bug fix on VTKPATH variable
2574 * PACKAGER : adding all concerning windows
2576 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2579 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2580 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2581 test suite reported error.
2582 * PACKAGER file added (describes what a packager must do when
2583 packaging a new release).
2584 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2585 * configure.in: upgraded version number to 0.3.0
2586 * fixing build of rpm (through rpm -ta):
2587 - Doc/Makefile.am exports proper doxygen files
2588 - src/jpeg/libijg8/Makefile.am exports the include files.
2590 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2591 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2592 * src/gdcmHeader.h : formatting code
2594 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2595 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2596 We were obtaining error message from vtk. Now, creation of file list
2597 is made in an internal list to prevent this problem.
2598 Bug fix when output is empty.
2599 Bug fix in update of progress value. Previous commit for this was a bad
2601 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2603 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2604 * src/gdcmHeader.h : added method to get the file name
2605 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2606 files. Added method to remove all files on the input
2607 Added FIXME comment concerning the bad parsing of header made by
2608 ExecuteInformation method (in ExecuteData method)
2610 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2612 when using make instal.
2613 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2614 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2616 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * setup.py : adding include dir of jpeg lib to compile all sources
2618 * */Win32/*.dsp : JPR fix for windows compilation
2620 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2621 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2623 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2624 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2626 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * setup.py is again effective on un*x (takes into account the
2628 addon of the jpeg library)
2629 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2630 * Doc/Doxy* updated (includes above enhancements)
2631 * INSTALL now points to web documentation
2633 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * src/gdcmHeader.h doesn't make unnecessary reference to
2636 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2638 * src/gdcm*.[cxx|h] :
2639 - to allow compilation with gcc 3.x
2640 -- clean up of STL usage (added explicit usage of std::)
2641 -- small fixes on exceptions.
2642 Note: linking not tested !
2643 - clean of doxygen comments to avoid warnings at documentation
2645 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2646 dependent convertion).
2648 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * Clean up of previous JPR garbage commit (not even commented in the
2651 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2652 - moved all jpeg related files from src to src/jpeg/libijg8, with
2653 addition/modification of Makefile.am and configure.in.
2654 - the testSuite is still brain damage (not guilty).
2656 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2657 * WrapVTK.py : modifications to get correctly vtk source files to
2659 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2660 (FileName -> Filename)
2662 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * vtk/vtkGdcmReader.[cxx/h]:
2664 - UpdateProgress method should now be effective
2665 - removed the limitation on having only images loaded (as opposed
2667 - when building a stack of images/volume, a lesser number of
2668 gdcmHeader and gdcmFile instances should be used (hopefully
2669 accelerating things).
2670 - when building a stack of images/volumes, files which are not
2671 loadable (wrong path-filename, wrong permissions on existing file,
2672 or file not parsable by gdcm) are replaced with a black image
2673 in the stack (for the caller to notice the problem).
2675 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2678 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2679 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2680 between standard library (std) and vtk library (problems are found
2681 under Windows... thanks Windows !)
2683 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2686 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2688 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2691 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * When compiling with distutils (see setup.py) the C++ compiler is
2693 called with different flags than the default ones (with automake).
2694 In order to fix all those warning, I compiled gdcm with the command
2695 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2696 and went for warning fixes:
2697 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2698 up from unused variables.
2699 - vtk/vtkGdcmReader.cxx: potential bug fix.
2700 * src/gdcmHeader.h: Doxygen warning cleanup
2702 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * gdcmPython/gdcm.i:
2704 - typemaps correction to take into account the systematic replacement
2705 of "using namespace std" with std:: prefix e.g. std::list,
2706 std::string... (cf changes of 2003-05-21).
2707 - gdcmGlob global variable of type gdcmGlobal (defined in
2708 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2709 exported to Python a as cvar.
2710 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2711 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2712 gdcmDictSet.GetPubDictTagNames() and
2713 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2714 C++ static methods).
2715 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2716 with the above changes.
2718 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2719 * setup.py, manifest.in : bug fix under linux
2721 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2722 * Modification of setup.py to compile vtk part too. Then, we have 2
2723 wrappers which must work with same distutils. For that, we have a
2724 generic distutils in distusiltsWrapping.py ; with :
2725 - build_extWrap class to wrap generically all extensions,
2726 - ExtensionWrap base class for all wrapping extension that contains
2728 - Wrapper interface which wrap sources
2729 + In WrapSwig.py we have extension and wrapper for Swig
2730 + In WrapVTK.py we have extension and wrapper for VTK
2731 * MANIFEST.in : modifications to consider vtk directory and new python
2732 files for compilation
2734 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2735 * Added python wrappers of vtkGdcmReader vtk class (see the
2736 source in vtk/vtkGdcmReader.cxx) :
2737 - vtk/Makefile.am now builds a library
2738 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2739 python library (as opposed to _gdcm.so wich are the python
2740 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2741 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2743 - configure.in has an additional flag --enable-vtk that needs
2744 to be set to enable compilation of vtk related code, that is:
2745 + vtk/vtkGdcmReader.so and
2746 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2747 + gdcmPython/vtkgdcmPython.so (see above)
2748 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2749 be read when compressed or when HighBit + 1 != BitsStored),
2750 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2751 the usage of the python wrapper of vtkGdcmReader vtk class.
2752 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2753 * src/*.[h] all occurences of stl classes are now prefixed with
2754 std::, and all occurences of "using namespace std;" where removed.
2755 This is to avoid pollution of global namespace in included files.
2756 Apparently vtk does not avoid this pitfall: when using both
2757 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2758 collision of various stl members (principally cout...).
2759 * gdcmPython/testSuite.py now cleanly removes temprory generated
2761 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2762 comply with above changes)
2764 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2765 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2766 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2767 vtk data structure (an image Flip was required).
2768 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2769 * cosmetic changes in documentation.
2771 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2772 * src/gdcmHeader.cxx: the constructor no longer exits when an
2773 unexisting file is given as argument.
2774 * The subdirectory Data (containing all the images used for the
2775 test suite) is not part of this repository anymore. A new module
2776 containing those images is now available at
2777 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2778 with the name gdcmData.
2779 All the python scripts (including the package initialisation file
2780 gdcmPython/__init__.py) were adapated to take this change into
2781 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2783 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2784 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2785 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2786 demo of the usage of this class.
2787 Compilation of this vtk part is only done when using the --enable-vtk
2788 at configure (or autogen.sh) stage.
2790 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2791 * More memory link related corrections and documentation fixes.
2793 - maximum info is obtained with a command of the form:
2794 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2795 --show-reachable=yes PrintHeader
2796 - the remaining reachable blocks seem to come from the STL
2797 allocation scheme through the usage of map and list. It looks
2798 like this memory cannot be freed but it is not a memory leak
2799 (in fact further invocation to the STL would recollect the
2800 unused memory allthough it cannot explicitely be freed).
2801 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2802 of displaying an image parsed with gdcm and displayed with VTK.
2803 Note: some images don't seem to work e.g.
2804 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2805 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2806 Allthough this weakens the semantics, it is a ditch attempt to
2807 make gdcm more thread friendly.
2809 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2810 * Memory link hunt (by using valgrind through the command
2811 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2812 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2813 gdcmHeader::_dicom_vr.
2814 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2815 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2817 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2819 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2820 * src/Makefile.am now exports all the necessary include files at
2824 * UpdateGroupLength replaced by new one
2827 * UpdateGroupLength re-written using H-Table
2828 (named UpdateGroupLengthNew untill checks are over)
2830 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2831 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2832 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2834 - gdcmHeader::GetPubElValSet removed.
2835 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2836 UpdateGroupLength, WriteElements, Write.
2837 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2838 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2839 carried the same semantics.
2840 - src/gdcmHeaderIdo.cxx changed accordingly.
2841 - gdcmFile::WriteBase now regroups all the codes from previous
2842 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2843 - enum FileType moved to gdcmCommon.h
2844 * src/gdcmHeader.cxx AddDefault trashed
2845 * gdcmGetXSize added
2846 * getimageDataSize now calls gdcmGetXSize
2847 * Test/*.cxx changed to agree with above changes
2849 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2851 (to avoid double call by end user).
2852 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2853 by end user, since gdcmHeader::gdcmHeader now handles it.
2855 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2856 * gdcm/Doc many doxygen changes:
2857 - Doxyfile now has two different versions, DoxyfileUsers that generates
2858 the html.users end users oriented documentation and
2859 DoxyfileDeveloppers that generates the html.developper developper
2860 oriented documentation.
2861 - README changed accordingly
2862 - requirement.txt removed (old design info moved to TODO).
2863 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2864 DoxyMainPage.txt, DoxyPython.txt provide more information.
2865 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2866 be updated by simply regenerating the docs with doxygen and copying
2867 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2868 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2869 all the tests in the form "if (<map>.count() >1)" were removed.
2870 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2871 ill-formed documentation sections.
2872 * src/gdcmHeader.cxx: ditto
2874 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * setup.py fixed for un*x (needed macro for stdint.h)
2876 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2877 un*ces with sh-utils test utility.
2878 * gdcmPython/demo/test.py renamed to PrintHeader.py
2879 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2880 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2881 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2882 * src/gdcm*.cxx JPR's bad inclusion fixed.
2884 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2886 * gdcmPython/demo/test.py changed accordingly.
2888 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * gdcmPython/Makefile.am fixed linking against libstdc++
2890 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2891 * Swig subdir (historical tests of swig version 1.3.17++) removed
2892 * Test/testChangeEntete.cxx some lines commented out in order to make
2894 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2895 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2897 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2899 hence the user doesn't need this explicit call.
2900 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2901 i.e. LoadElements() call removed.
2902 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2903 - src/Makefile.am declares the proper flag for g++.
2904 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2905 for adding user defined new tags.
2906 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2907 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2908 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2910 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2911 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2912 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2913 src/Makefile.am : the project should properly compile and install
2914 with the autotools, included the python wrappers part.
2915 * gdcm.spec.in : added a spec file for RPM packaging.
2917 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2918 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2920 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2921 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2922 to exported to the environement (see gdcmPython/testSuite.py
2924 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2925 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2926 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2927 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2928 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2930 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * gdcmPython/__init__.py doesn't crash anymore when running in
2932 in InstallMode or PreInstallMode but with an environment given
2933 value of GDCM_DICT_PATH.
2934 * src/gdcmDictSet.[cxx/h] coding style.
2936 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2937 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2938 * src/gdcm.h general comments moved to TODO, and README
2939 * src/gdcm.h should now be seen as a user commodity (including it
2940 should suffice to fully use gdcm). It is nowhere including within
2941 any of the kernel files src/*.cxx and src/*.h.
2943 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2945 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2947 * src/gdcm*.cxx only include their corresponding include file
2948 (as opposed to gdcm.h)
2949 * gdcmPython/gdcm.i changed accordingly
2950 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2951 the autogen.sh generated "make snapshot" command to work.
2952 * autogen.sh removed history related references to crea package.
2954 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * distutilsSwigCPlusPlus.py work around some swig portability
2958 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2960 was done in a last ditch attempt to get setup.py _really_
2961 operationnal. The python/gdcmPython layaout add the advantage
2962 of hidding away the python related distutils specific files
2963 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2964 Alas, the src directory was out of scope (i.e. it's relative
2965 position to setup.py was ../src) which made things impossible to
2966 handle (see previous version of python/setup.py). Crossing fingers...
2968 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * python/setup.py now works on Un*x. (harder than I thougth)
2970 * python/distutilsSwigCPlusPlus.py can now have include files
2971 among the list of sources.
2973 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2974 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2975 * modifications in MSVC projects
2977 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * As stated by the first lines of Test/ExceptionAndPython/README, it
2979 looks like we can move back to original usage of exception within
2980 src/gdcm* and hence remove the errno stuff that was introduced
2981 as a quick and dirty fixture of this problem (added to the TODO).
2982 * Doc/Doxyfile configuration file for Doxygen and corresponding
2983 README file for usage added.
2984 * Test/testWrite.cxx added. This new test comes from a split of
2985 test.cxx that is now reverted to its original purpous i.e.
2986 testing the proper parsing of a Dicom related file.
2987 testWrite.cxx concentrates on testing the IO part of gdcm.
2988 * Test/bug1.cxx (containing a bug on WIn32) added.
2989 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2990 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2991 whose purpose is to publish the content of the TagNames of the
2992 Dicom public dictionary were not accessible without an
2993 instance of class gdcmHeader.
2994 - those methods are now static methods of gdcmDictSet and hence
2995 require no instances at all to be invocated.
2996 - within gdcmDictSet this change required to change some method
2997 to class methods (i.e. are now static) among which SetDictPath
2998 (renamed to BuildDictPath) and LoadDefaultPubDict.
2999 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3000 the above changes by calling the new method classes of gdcmDictSet.
3001 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3002 the above to be effective.
3003 * python/gdcmPython: in order to wrap properly the above changes
3004 for Python, swig version now needs to be > 1.3.17.
3005 * python/gdcmPython/Makefile fixed to adapt itself to new
3006 configure/make shema introduced by Johan Montagnat (thanks for the
3007 contribution). Alas this Makefile cannot be turned into a proper
3008 Makefile.am without some heavy changes in the configure.in
3009 (for python dectection).
3010 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3011 now avoids publishing the empty entries.
3013 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3014 * python/setup.py : bug fix concerning install under windows
3015 ExtraPath reused :-P
3016 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3018 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3019 * Dicts/dicomV3.dic : remove double spaces !!!
3020 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3021 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3024 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3026 method. Doxygenation.
3027 * src/gdcm.h clean up of JPR spurious comments.
3029 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3030 * python/distutilsSwigCPlusPlus.py now properly collects the
3031 shadow classes generated by "swig -c++" (gdcm.py in our case)
3032 when using "python setup.py install".
3033 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3034 reexports the working classes.
3035 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3036 by the classical C errno scheme. This is to prevent an obscure
3037 behavior of the python wrappers when importing wxPython.wx prior
3038 to gdcmPython (which ended up in an abort call). An illustration
3039 of this oddity can be found in the Test/ExceptionAndPython
3040 subdir (see the README file). This problem probably due to
3041 an combination of g++ and dynamic loading.
3042 * added Test/ExceptionAndPython (see above)
3044 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * Changed the layout of the python part to avoid bloating main
3046 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3047 i.e. the distutils arsenal. All the python related stuff is
3048 again in a python subdir, but the package itself is now in
3050 * setup.py was cleaned up:
3051 - pythonIncludePath removed
3052 - python setup.py bdist target is now functional.
3053 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3054 collision with other packages). gdcmPython/demo/*.py changed
3057 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * python subdir moved to gdcmPython (preparation of distutils packaging).
3059 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3060 distutils installer is operational.
3061 * - gdcmPython/__init__.py now properly loads the swig generated
3062 shadow classes (from gdcm.py).
3063 - gdcmPython/demo/*.py changed to import the package gdcmPython
3064 instead of gdcmPython/demo/load.py.
3065 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3067 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3069 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3070 entries within the associated public Dicom dictionary resp. the same
3071 information but sorted by the fourth field (PAT, IMG, DIR) of the
3073 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3074 are now in the "???" group.
3075 - python/gdcm.i changed accordingly,
3076 - python/demo/printGroupedPublicDict.py added, that gives an example
3077 of the above new functionalities in Python.
3079 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3080 * src/gdcm.h, gdcmHeader.cxx:
3081 - historic references to glib's g_malloc and g_free (#defined)
3082 were definitively removed.
3083 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3084 * src/gdcmElValSet.cxx:
3085 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3086 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3087 - GetElValue(string) renamed to GetElValueByName.
3088 - Added GetElementByName(string).
3089 * src/gdcmHeader.cxx: added
3090 - GetPubElValRepByNumber(guint16, guint16)
3091 - GetPubElValRepByName(string)
3092 - GetShaElValRepByNumber(guint16, guint16)
3093 - GetShaElValRepByName(string)
3094 - GetShaElValByNumber(guint16, guint16)
3095 - GetShaElValRepByName(string)
3096 - GetElValRepByNumber(guint16, guint16)
3097 - GetElValRepByName(string)
3098 - GetElValByNumber(guint16, guint16)
3099 - GetElValRepByName(string)
3100 * Doc/requirements.txt added.
3102 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * Test/Makefile building now depends on the one of libgdcm.so
3104 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3105 pixel data) aware which enables finding the address (offset) of
3106 the pixel data of JPEG encoded DICOM files. This leaves only a single
3107 file in the testSuite whose pixel data address (offset) is unknown.
3108 * python/testSuite.py changed accordingly.
3110 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3111 * VC++ has some strong limitations when working with the STL, as stated
3112 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3113 "Also note that some STL containers (map, set, queue, list, deque)
3114 cannot be exported. [...]
3115 Some STL classes contain nested classes. These classes can not
3117 This is caused by a designed limitation that once a template
3118 class is instantiated, it can not be re-instantiated and
3120 Since our usage of map<> is ubiquitous in gdcm, this "designed
3121 limitation" of VC++ is a pitfall.
3122 Hence the Python wrappers of gdcm cannot be incrementally linked
3123 against the c++ dynamic library. The dirty but only workaround is
3124 to forget about incremental link of dynamic libraries and to generate
3125 the Python wrappers library with the inclusions of the underlying C++
3127 The following modifications concern this matter on Win32/VC++:
3128 - wrapping python correct with standalone wrapped dll (don't use separate
3129 dll under windows !!!!)
3130 - python21_d debug mode enabled (ask Frog how to use it :-)
3131 - NO problem with having an STL member of class for example string in C++
3132 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3133 - Python test of dcmlib in Python is ok under windows on a large set
3135 * removed glib references
3136 * typedef's inserted in gdcm.i for correct swig type management
3138 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3139 * python/demo/*.py load.py extracted from test.py. Added explore.py
3140 that only displays required tags and testAll.py that parses all
3141 the files of the testsuite without using unittest.
3142 * python/testSuite.py other additional test on new files added.
3143 * Data/* new test files added accordingly to the testSuite.
3144 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3145 the vr in the file differs from the one of the dictionary.
3147 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3148 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3149 values, but limits itself to values which are below a user specified
3150 size (by default 1024 bytes).
3151 * python/gdcm.i : elements not loaded (because their size is above the
3152 user specified treshold) are exported with their TagKey as key of the
3153 python dictionary. This enables the testsuite to make some checks
3154 on the unloaded elements (since we have their offset and size).
3155 * python/testSuite.py
3156 - now tests for the existence and proper value of the pixel data
3157 - two new examples added.
3158 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3160 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3162 aware. See the strategy comments in gdcmHeader::FindeLength().
3163 * Test/test.cxx now accepts a filename as first argument.
3164 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3165 * python/testSuite.py changed to integrate test on above files.
3167 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3169 the vr was also RET.
3170 * python/testSuite.py more tests added.
3172 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3173 * python/testSuite.py unittest test suite added (uses Data)
3174 * Data/* dcm and acr files for the test suite.
3175 * glib dependance removed from un*x version. We now use ISO C99
3176 7.18 Integer types (see stdint.h)
3177 - python/Makefile, src/Makefile src/gdcm.h
3178 * src/ when an explicit vr (like dicom files) suddenly poped an
3179 implicit element we use to mark the underlying DictEntry of the
3180 concerned ElValue with "Implicit". This strategy was damageable
3181 too the public or provite dictionaries, since some of their vr
3182 would be changed. Since Header::FindLength heavily relies on the
3183 detection by Header::FindVR of falsely explicit elements, I
3184 added an extra ImplicitVr member to ElValue (boolean).
3185 The rest of the changes we the necessary adaptations.
3187 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3190 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3192 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3193 * Adaptation for porting to VC++:
3195 o forced to use std namespace (for string to be known)
3196 o all class use __declspec export style on WIN32
3197 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3198 (in stdlib.h on Win32 but in std:: for gcc)
3199 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3200 variable GDCM_DICT_PATH.
3201 * src/gdcmHeader.cxx verbose comments made discrete.
3203 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3204 * python/gdcm.i: added a typemap that converts a C++ hashing table
3205 to native Python dictionary.
3206 * python/demo/test.py:
3207 - now uses the native dictionary for exploration of gdcmHeader.
3208 - takes an optional filename argument (the file to parse).
3209 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3210 PubElVals hashing table.
3211 * Dicts/dicomV3.dic removed error prone trailing spaces.
3213 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3214 * Python wrapping process moved away from src/Makefile to
3215 newly created python/Makefile (as well as gdcm.i)
3216 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3217 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3218 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3219 from the environement variable GDCM_DICT_PATH (when existing).
3220 * src/gdcmDict::GetTag bug fix.
3222 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3223 * Straightforward temporary fixes for swig to build the python wrappers.
3224 src/Makefile now has a python working entry [by working we mean
3225 that we can import de shadow classes without errors].
3227 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * hashtest.cxx removed (since already in Test)
3229 * src/gdcmlib.h renamed to src/gdcm.h
3230 * src/dcm.i renamed to src/gdcm.i
3231 * src/Makefile prepared for python wrapping
3233 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3234 * src/gdcmHeader.cxx :
3235 - Parsing of header is now separated from loading of element values
3236 (see gdcmHeader::LoadElements).
3237 - general clean up of hopefully all file access (creation of
3238 ReadInt16 and ReadInt32)
3240 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3241 * src/gdcmHeader.cxx :
3242 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3244 - SetLgrElem renamed to SetLength
3245 - GetLgrElem renamed to GetLength
3246 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3247 * src/gdcmElValSet.cxx fixed both GetElValue methods
3248 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3249 due to IdoDude was cleaned out.
3251 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3252 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3253 concentrates on finding the value representation (when it exists).
3254 RecupLgr now only finds the element value length, and it avoids
3255 returning the unecessary skL (skipped length).
3256 Also, offsetCourant was simply removed (with taille_fich) since
3257 it was redundant with the File position internals (by using
3258 ftell and fseek). This also made skL (see above in RecupLgr) usage
3260 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3261 on the libido specificities which are handled through class
3263 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3266 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3267 * Truckload of changes. Parsing of header is barely functional
3268 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3270 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * src/gdcmHeader.cxx many addons of low level methods
3273 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3275 and _IdDcmSWAP_LONG.
3277 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * This corresponds to all the changes decided at the meeting of
3279 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob