1 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
3 * SerieHeader::AddFileName() creates as many Coherent Files lists
4 (same Serie UID) as it founds different Serie UID
5 amongst the files instead of discarting any file
6 that doesn't match with the first one he found.
7 * SerieHeader::OrderGdcmFileList has now one parameter :
8 the Coherent Files list the user wants to sort
9 * SerieHeader::GetFirstCoherentFileList() |
10 * SerieHeader::GetLastCoherentFileList() | allow to parse
11 the set of Coherent Files lists
12 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
13 compatibility (it returns the *first* Coherent Files list,
14 since there was only one before)
15 * Test/TestSerieHeader gets gdcmData as a default root directory
17 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Remove friend between DocEntry and File classes
19 * Remove friend between PixelReadConverter and RLEFramesInfo,
22 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
24 0002|0000. The value was incorrect.
26 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
29 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmUtil.cxx : compilation fix on Win32
31 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
32 variable, to be easy found. Add methods to change the default UID.
33 Amelioration of the CreateUniqueUID to use the correct default UID.
34 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
37 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * Test/TestVR.cxx : fix memory leaks
40 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Rewrite the base 256 to base 10 conversion, using string operation only.
42 This allows us to get rid of the problematic 64bits integer type (does not
43 always exist on target platform).
45 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
46 * Add construct and destructor to class gdcm::Debug to close the debug file
48 * Don't let uset to open twice the same file
49 * gdcm has now an official UID prefix,
50 supplied by http://www.medicalconnections.co.uk
51 1.2.826.0.1.3680043.2.1143
52 (Thx to Mathieu for providing URL)
53 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
54 to be able to perform some more tests
55 * gdcm::ContentEntry : Contructors and Destructor are now protected,
56 in order to be sure no user will try to use them.
57 (at user level, only the children classes are meaningfull)
59 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * move RLEInfo & JPEGInfo from Document to File
62 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * FIX : remove so many friend between classes
65 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
67 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
69 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
70 In order to avoid missbehaviour :
71 . gdcm::DocEntry is now specialized in
72 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
73 - gdcm::ContentEntry (Dicom entry with a 'content')
74 . gdcm::ContentEntry is specialized in
75 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
76 characters value, or integers)
77 - gdcm::BinEntry (Dicom entry with a non strig representable value
78 (user hasn't any longer to thing about the precedence of his dynamic_casts)
80 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Test/VTKTest*.cxx : bug fix under linux
83 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
85 use with python. Some methods are moved from Document to ElementSet or
86 DocEntrySet. The equivalent methods to ElementSet have been added to
87 SQItem and are virtual in DocEntrySet. Methods that may have the same code
88 in SQItem and ElementSet is directly placed in DocEntrySet
90 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Test/VTKTest*.cxx : remove the show variable in each test method because
92 it's useless (the viewer variable replace this variable)
94 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDocument.cxx : bug fix on potential memory leak
96 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
97 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
98 Add ClearXxx methods to remove all the content of the list or map
99 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
101 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
102 * methods ReplaceOrCreate renamed as Insert
103 (nobody will be any longer confused by 'CreateOrReplace')
105 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
106 * Grealty simplify the JPEg decompression, no need to differenciate based on
107 the JPEG possible type (with/without fragment, with/without multiple frame).
108 Everything is done throught the JPEG IO Suspension mechanism in IJG
110 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * Stage 3 of normalization :
112 in order to avoid any missunderstanding while reading method names :
113 - All the methods xxxEntry now deal with dicom Entries
114 - Methods GetEntry splitted into
117 - Method SetEntry renamed as SetEntryValue
118 - Method SetEntryBinArea let as it was
120 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
121 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
122 - Position correctly the entry points for JPEG2000 and JPEG-LS
123 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
125 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
127 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
128 with other method names
129 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
130 * Test/TestDicomDirElement.cxx : add new test
132 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
133 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
134 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
135 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
136 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
137 So can't you use __int64 in ostream at all.
139 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * bug fix for compilation on MSVC6
141 * gdcmPython/gdcm.i : rename of classes missed
143 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
144 * Stage 2 of names normalization :
145 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
146 (easy to understand ...)
147 - gdcm::FileHelper replaces old class gdcm::File
149 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
151 type and not a string. So, there remove problems on the format of the
154 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * Add Example/TestPapyrus.cxx
156 - reads a Papyrus file (gdcm::Header compliant),
157 - gets the pixels of all the images, using low level iterators
158 - writes an multiframes Dicom image.
159 (Just to show it's *possible* to do that)
160 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
163 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
165 Thus, DicomDirXXX are created with a flad that indicates if the created
166 object is empty or not (when not empty, the DicomDirElement is used to
169 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
171 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
173 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
176 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
178 Remove all access to the hash-tables or lists in the objects.
180 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
182 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
183 be complient with all the gdcm source code
185 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
189 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
193 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * Test/ : rename VTK tests to have a best name for the tests
195 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
196 GetFirstEntry/GetNextEntry use
198 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
199 * In SerieHeader::ImagePositionPatientOrdering()
200 // a Dicom 'Serie' may contain scout views
201 // and images may have differents directions.
202 // -> More than one may have the same 'pos'
203 // Sorting has then NO meaning !
204 Thx to Eduardo Davila for reporting bug.
206 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
208 test. Now it's on image content and not on the resulting visualisation...
209 might solve the problem on linux when using the OpenGL drivers
211 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
212 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
213 DicomDirSerie, DicomDirImage
214 Dict, DictSet classes :
215 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
216 -remove InitTraversal method.
217 * UPD Test programs + Example programs
219 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
220 * remove useless and never updated keyword \ingroup
221 * Solve pb when structure (list, map, ...) is empty.
222 Thx to Benoit for reporting bug
224 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
225 * Taking into account of 'Transfer Syntax' value
226 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
229 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
231 is no memory access violation
232 * gdcmPython/demo : add python demos using VTK
234 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
235 * FIX 'Dictionnary' is now spelt 'Dictionary'
236 'wether' is now spelt 'whether'
237 'archieve' is now spelt 'archive' ;-)
239 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
240 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
241 related methods, in order not to expose internal mechanisms
244 * REM methods that exposed internal mechanisms :
245 DicomDir::GetDicomDirPatients()
246 DicomDirPatient::GetDicomDirStudies()
247 DicomDirStudy::GetDicomDirSeries()
248 DicomDirSerie::GetDicomDirImages()
249 * UPD Test programs :
253 * UPD Example program
255 * ADD DictSet methods
259 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Removed the Print/indent/default parameter mess. There is absolutely no
261 reason to have to methods, moreover with the second taking the ostream as
262 *SECOND* parameter. This was clearly a bad hack to get things compile.
264 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 * Complete rewrite of the GetMacAddress code. Now the code is *much*
266 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
267 Unfortunately the main code does not work on SunOS, thus provide a specific
268 code for this platform only (and Win32 of course). Since this seems to be
269 working, change CreateUniqueUID to use GetMACAddress instead of the
270 problematic GctestetIPAddress
272 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * Unfortunately to be able to test gdcmDirList I had to break the API
274 a little. Now the class is not a std::list anymore but has a member
275 std::vector (more ITK compatible). Allow unit testing on Win32 and
278 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
279 * Update SerieHeader to take into account a Serie Instance UID to properly
282 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
283 * ENH - Comment out Mathieu's (dangerous) Super Hack
284 for dealing with BIGENDIAN processors
285 - Move equivalent stuff to BinEntry::WriteContent
286 When necessary, 16 Bits Pixels are swapped in a small buffer
287 and then written. This avoid allocating a huge buffer, in
288 PixelWriteConvertor, and avoid modifying the Pixel Area.
290 Probabely, the same operation will have to be done when we want
291 to write image with Big Endian Transfert Syntax,
292 and we are working on Little Endian Processor
294 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
297 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
298 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
299 all the dict content.
300 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
302 * Test/TestDict.cxx : add a new test for the dict classes
304 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
306 file. Debug is yanked if compiled with NDEBUG
308 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * src/gdcmDictSet.h : set the default output to the os variable
310 * src/gdcmDictEntry.[h|cxx] : add the Print method
311 * gdcmPython/demo/ : add a new test
313 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
314 * merging of Test/PrintDicomDir and Test/TestDicomDir
315 * removal of now redundant Test/PrintDicomDir
316 * enhancement of Example/PrintDicomDir
318 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * Now, python test might work on systems
320 * Add the PrintDicomDir test
322 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
323 * FIX : First entry following group 0002 was lost for
324 Explicit Big Endian Transfer Syntax files
325 (group and elem not swaped)
327 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
329 Big Endian Transfer Syntax supposed the group following 0002
330 begins always by element 0000 (element 0000 is *optional*)
331 To avoid further troubles, let's be pessimistic, and use
332 Document::HandleOutOfGroup0002() method
333 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
334 (related pb not yet solved)
336 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * Bug fix for the python part use
338 * Now, PrintHeader.py pass... but outside the ctest use. shit !
340 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
343 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
344 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
345 a string and should ask the global TS dict what are the propreties of
348 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
349 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
350 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
351 to swap the Swap Code, at parsing time, when we come out of group 0002
352 and Transfer Syntax is Big Endian
353 We should be able to read now 'true DICOM" Big Endian coded images
354 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
355 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
357 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Hopefully fix the bug on MacOSX and static global initialization.
359 This is the only -minor- patch I found that both please MacOSX and VS6.
360 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
361 but this would require a lot of change. Another approach would be that Global
362 create those string and GDCM_UNFOUND becomes a pointer to a string (which
363 gdcm::Global would destroy at exit).
365 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
366 * Fix bug on MacOSX with static initialization in a multy threaded
367 environment. static const string in a header file used to be ill
368 initialized provoquing the freeze of any tests. patch should solve this
371 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
372 * According to Benoit's suggestion, and without any objection from anybody
373 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
374 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
375 - method gdcmDicomDirObject::GetEntry() renamed as
376 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
378 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
380 you debug/warning message just as c++ streams which make them very convinient
381 to use. Once this is stabilize I will change the ostringstrem to be
382 redirected to a file (ofstream).
383 * Properly support C99 extension: __FUNCTION__ which allow us to display
384 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
386 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
387 * Removal of useless and dangerous methods :
388 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
389 GetDocEntryByName, GetEntryByName, GetDictEntryByName
390 * Removal of usless methods :
391 Dict::PrintByName, Dict::GetDictEntryByName
392 * Commenting out of probabely useless methods :
393 Dict::GetDictEntryNames()
394 Dict::GetDictEntryNamesByCategory()
395 DictSet::GetPubDictEntryNames()
396 DictSet::GetPubDictEntryNamesByCategory()
397 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
398 * ENH : Use dicomTS.dic as described in 2004 version
399 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
400 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
401 Add Accessors on VM (Value Multiplicity), and VM related methods
402 * ADD : Add a list of 'Dicom Attribute types', as found in
403 http://medical.nema.org/dicom/2004/04_15PU.PDF
405 * ADD : Add dicomGroupNameAbbreviations.dic
406 should be used to write a method to replace the former
407 Dict::GetDictEntryNamesByCategory()
409 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
411 to read in the file... and only it ! Length is the efective length of the
412 data in the DocEntry structure
414 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
415 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
416 And now use a static function call instead, with a global variable. i
417 This is much closer to the VTK approach. Hopefully should be bulletproof
418 and easier to use...hopefully
420 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
421 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
423 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
426 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
428 ValEntry, BinEntry, SeqEntry creation or replace
430 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
431 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
432 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
434 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
435 when specifying the VR
436 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
437 * src/gdcmDocEntry.cxx : amelioration of print
439 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
440 * ADD : Add the method Util::IsCurrentProcessorBigEndian
441 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
442 * ADD Method Document::ComputeGroupLength
443 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
444 in order to allow further VR modification by user
445 * REM : removal of once-called method File::WriteBase
446 integration of its code in formerly one-line method File::Write
448 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
450 replace the different values "??", "Unkn", "Unknown".
451 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
452 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
453 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
454 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
456 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
459 * Set the gdcm::Base class to some Printable classes
461 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmFile.[h|cxx] : add the Print method
463 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
464 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
465 * src/gdcmDocument.h : remove the PrintLevel informations
466 * Example/PrintFile.cxx : use the new gdcm::File::Print
468 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
470 problems when compiling with the python wrapping
472 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
474 writting in ImplicitVR
476 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
477 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
478 JPEG decompression, especially when dicom frames are split into several
479 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
480 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
482 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmHeader.cxx : change the initialisation of default header.
484 Now, this header is readable by gdm, e-film, DicomWorks
486 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
488 Rename Decompressed to Raw
489 * Use the API changes in gdcm::File.
490 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
493 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
495 each added entry in the header. Replace the 'Planes' field by the 'Number
498 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
500 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
502 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
504 At this time, this image isn't readable by e-film... waiting JPR help to
507 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
509 DocEntry. Now use methods of the Document !
511 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * Test/ShowDicomSeq.cxx : bug fix
514 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
516 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
517 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
518 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
520 * Test/TestCopyRescaleDicom.cxx : remove unused variable
521 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
522 containing found sequences
524 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
527 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
528 Some fields in BinEntry must be copied to not seg fault when making the :
529 gdcm::File *copy = new gdcm::File( copyH );
530 and tests are now made on good variables
532 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
534 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
536 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
537 * Add vtkGdcmWriter example and test
539 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * Test/TestUtil.cxx : reformat the source code
541 * vtk/vtkGdcmReader.cxx : remove and change prints
542 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
544 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
545 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
547 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
549 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
551 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
553 by an eof to prevent all bad read of the file... and in this case, the
556 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * Example/Volume2Dicom.cxx : comment unused variables
558 * Test/PrintDicomDir.cxx : comment unused variables
559 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
560 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
561 method that is redondant with AddEntry.
562 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
565 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * Bug fix due my last commit (compilation under Windows).
567 * Example/Volume2Dicom : bug fix in the file and reformatting source code
568 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
570 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 - Remove printf / sprintf
573 - include iostream AFTER gdcm so we don't get warnings
574 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
576 - Also remove tons of include from header files, hopefully this should
577 speeup the compilation time, since it was becoming a dog slow.
578 - Remove gdcm.h as it include way too many files and slow down compilation
579 (plus it is not up to date)
580 - remove 'using namespace std' this is BAD !
582 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * Remove memory leaks on the DicomDir
584 * Remove some useless data in DicomDirObject
585 * Add usefull methods in SQItem, to be complient withe the ElementSet
587 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
590 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
592 future, with convertion)
593 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
594 and ImageDataSize values. Remove the method to get the PixelReadConverter
595 from the output of the class
597 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
600 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
602 and vtkErrorMacro use.
603 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
605 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
606 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
608 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
609 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
610 The string leaves only in the fonction. So when we make a .c_str(), we
611 get the pointeur on the first element, element that will be destroyed
612 immediately after thee instruction.
613 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
614 file has been opened : the test must be made on the content of the
615 pointer and not directly on the pointer !
618 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
620 the python part recompiles
622 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
624 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
625 X session is killed (for my computer... it seems to not be identic on
628 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
630 avoid problems (otherwise, the difference test between the visible image
631 and the reference is incorrect. If the reference is greater than the
632 screen resolution, it's produce errors).
633 Can be used for only one image. Can be used with a visible flag.
634 * vtk/vtkGdcmReader.cxx : remove commented codes.
635 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
636 under windows at compilation
637 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
639 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
641 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
643 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
644 tests on the image size X, Y, Z
646 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
648 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
649 between the class name and the file name
651 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/ : fix compilation warnings for the Write method (2 different
653 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
654 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
655 variable... create a static method in gdcm::Document to access to
656 this variable content.
658 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
660 file, to be accessed by other files (like gdcmFile). Remove commented
661 code. Move the change of the header to the gdcmFile, using the
663 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
664 To be sure of that (and simplify calls), the Write of the header now
665 gets a file name and not a file pointer (std::ifstream).
666 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
667 DocEntryArchive. Remove all open of the written file
669 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
670 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
672 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
674 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
676 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
677 some corresponding methods. Write correctly the file and check before
679 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
680 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
681 is now on RGB data (as before my last commit
682 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
684 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
686 Add a print information of the type of the entry
687 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
688 It was in the gdcmFile, and all write have been regrouped
689 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
690 Write correctly all dicom files (in decompressed mode only at this time)
691 * Test/ : test on files are now made using Raw data and not color data if
693 * Example/PrintFile.cxx : add more printings
695 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
696 * Amelioration of code, remove some code copy. For the loading of
697 BinEntry (in gdcmDocument), add the test to verify if the file is already
700 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
702 remove a DocEntry in the header (push an empty DocEntry)
703 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
704 lines. Bug fix in the initialization of the PixelConvert and the
706 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
707 use in TestCopyDicom (now this test can run under windows... but fails)
708 * Test/TestCopyDicom.cxx : amelioration of the test :
709 - test the pixels written
710 - add test points to quickly find where is the error
711 - can set a file name input and output in arguments
712 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
713 amelioration of the test output
715 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
717 all replaced DocEntry's
718 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
719 Now, each needed DocEntry to modify is duplicated, modified and inserted
720 to the header using DocEntryArchive. Thus, after save, we can restore the
721 header initial state.
723 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
726 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
727 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
728 correct to copy it. The DictEntry is specified at the DocEntry creation,
729 then, it musn't change in the time.
730 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
731 header correctly. At this time, the change is only made for the first
732 level of the Document. In the future, it might consider sequences.
733 The change is made by replacing a DocEntry by an other that is created
734 outside the class. The old value is kept. When we restore the header
735 status, the added DocEntry is deleted and replaced by the old value.
736 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
737 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
738 set the write type to explicit VR, implicit VR or ACR. Add methods to set
739 the write mode to native, decompressed or RGB (but not used at this time)
741 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
743 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
745 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
747 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
749 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
750 set because already copied when copying the BinEntry's of the header
751 * Test/TestAllReadCompareDicom.cxx : remove warnings
753 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
755 Two problems appear when doing it :
756 - with the gdcmFile : when the GetImageData method is called, the pixels
757 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
758 data (pixels). And each structure destruct the data when it's
759 destructed. So we have two destructions for the same data. To solve it,
760 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
761 data or not. If it doesn't own data, then they will not destroyed by
763 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
764 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
765 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
766 create a double destruction of the same DocEntry's. So, to solve it,
767 the TagHT is simply cleared and the DicomDir* elements are destroyed.
768 * TODO : add an entry concerning memory leaks in the DicomDir
770 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
771 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
772 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
775 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
777 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
778 after it have been deleted
780 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * FIX: src/* fix the doxygen warnings.
782 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
783 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
784 was erroneously defined with a size of 15 instead of 16. [many thanks
785 to Jean Michel Rouet for pointing out this bug].
787 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
788 1. Finish merging JMR patch for writting DICOM from scratch
789 2. Fix -hopefully- bug with MONOCHROME and space vs null character
790 3. Use const ref when possible
791 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
792 5. A few more comments
793 6. CreateUniqueUID can now be called without parameter"
795 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
796 * ENH: Slightly bigger patch:
797 1. Getting toward full integration of JMR patch for writting dicom from scratch
798 2. Update Test to test part of this patch: CreateUniqueUID
799 3. File was not close properly in gdcmDict
800 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
801 5. Use of const ref instead of copy (speed issue)
802 6. Remove temporary (duplicate) string in TranslateToKey
803 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
804 8. Do not repeat virtual in subclasses
805 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
807 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * Apply first patch toward better string comparison when dealing with broken
809 DICOM files. Essentially the string could be padded with a space instead
810 of a null character as defined by standard
812 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
814 because never used... and in the same time, that's remove some memory leaks
816 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
817 * src/gdcmFile.cxx : now delete the PixelConvert instance.
818 * In examples and tests : change the type of image data variables from void*
819 to uint8_t*. Remmove all delete on image data variables
821 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
823 Verify the file pointer value before open the file, and if it's not null,
824 a verbose message is generated.
825 Close correctly the file when the file isn't considered dicom-like. The
826 correctly close is a call to CloseFile.
827 When closing the file pointer, test if its not null to close the file.
828 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
829 file. For an uncompressed image, the copied data correspond in the least
830 case to the image size (calculated) or the image size specified in the
831 header. A verbose is generated if these two size mismatch
833 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
835 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
836 break under windows (with msvc6 compilation).
838 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
840 compiling with MSVC6)
842 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * Bugs fix for the Windows build with VC6
844 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
845 needed (only for projects required VTK). If the VTK is included in all
846 projects, there is conflicts with the jpeg lib of vtk when compiling the
847 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
848 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
849 when compiling the gdcm_wrap.cxx file (created by the compilation of the
851 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
852 (like it's already made for the cout use). Otherwise, conflict with the
855 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
858 - comments on the DicomDir::Method related usage added.
859 - now that we use the namespace gdcm, a lot of internal classes do
860 NOT need to be wrapped anymore.
861 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
862 DicomDir::Method) new example added.
864 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
865 * Improve string manipulation. I now inforce the notion of 'DicomString'
866 A DicomString can contain as many \0 as they want
867 and it is *always* of even length.
868 We only support odd length for very rare case.
869 And in the near future this should be removed.
871 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
872 * /binary_write/ gdcm source. Now even on big endian we are writting
873 little endian. This should -heopfully- fix some tests
875 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
876 * Now the dictionary is compiled into gdcm lib. This is a default
877 behavior, thus any dic file specified is picked before failback to
878 the one comiled into lib
880 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 * Change internals for gdcmDict. Don't use any 'new' any more.
882 This should definitely solve any leak problem, and we should be
883 as fast as before, as long as don't modify too much the dictionary.
885 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
886 * STYLE: ivars should start with a capital letter.
887 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
888 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
890 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
892 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
893 new 2004 dictionaries added (thanks to JPR).
894 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
895 * CLEANUP_ROUND (15) for gdcmPixelConvert
896 - RLEFrame::NumberFragments is now of type unsigned int
897 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
898 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
901 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 * Initial work in gathering all transfer syntax accessors. clearly
903 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
904 ivars, but only one transfersyntax (class) ivar with equivalent method on
907 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
909 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
910 discussed (plus I didn't like having a 2000 lines patch not commited)
912 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
914 * CLEANUP_ROUND (14) for gdcmPixelConvert
915 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
916 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
917 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
919 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
920 anymore and hence avoids storing a copy of PixelConvert::Decompressed
921 into File::Pixel_Data.
923 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
924 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
925 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
926 * CLEANUP_ROUND (13) for gdcmPixelConvert
927 Substituted File::ParsePixelData() with PixelConvert::Print() new
929 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
930 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
931 method to those classes.
932 - src/gdcmFile.[cxx|h]:
933 -- Added a ::Print() method.
934 -- PixelConverter is now a reference instead of a member.
935 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
936 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
938 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
939 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
940 collaboration diagram and inheritance diagram should be generated with
942 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
943 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
944 pointlessly wrapped (see
945 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
946 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
947 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
948 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
949 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
950 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
951 -- File::Initialise: PixelConverter setup moved away to
952 PixelConverter::GrabInformationsFromHeader()
953 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
954 interpretation moved away to PixelConverter::BuildRGBImage()
956 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
957 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
958 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
960 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
961 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
962 displayed on Win32 when a brutal abort() occurs (because of uncatched
963 exception). See TODO new entry of this commit for more on this.
964 * TODO added new entry.
965 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
966 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
967 - HandleColor is no longer called from gdcmFile.cxx
968 - gdcmPixelConvert.cxx clean up on method arguments and internal
969 variable names for semantical coherence.
971 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
972 * Finished lossless transition, not only do we now read all lossless jpeg
973 images, without the need of the Cornwell lib, but we do read them properly now
974 * To reduce code (well to avoid code duplication), I defined a common place
975 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
976 redefine symbols. This is not perfect but this the best solution I found for a
977 compilation time jpeg option.
979 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
980 * Update jpeg ijg lib to support lossless jpeg implementation
981 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
983 * Also added a special copyright for dcmtk since we use their bugfixes.
986 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
988 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
989 matters, as stated in warning note at begining of %include section).
990 * src/gdcmDicomDir*.[cxx|h]: coding style
991 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
992 * src/gdcmJpeg8.cxx: doxygen fix.
993 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
994 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
995 from File:: to PixelConvert::.
997 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
999 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1000 - more code moved away from File:: to PixelConvert::
1001 - fat setup of PixelConverter set in place in File::Initialise.
1003 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1005 namespace at the file system level. So now you should convert your examples
1007 gdcmHeader -> gdcm::Header
1008 It would be nice if people keep in mind to no open the namespace, since it
1009 allows compilation on broken plateform which were defining common symbol in
1010 the standart namespace (like LP, Unknown ...)
1012 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1013 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1014 The JPEG fragments are now parsed at the same stage than the RLE
1015 information. All code related to JPEG is now in gdcmPixelConvert:
1016 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1017 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1018 export a gdcmFile:: method. Those are simply global functions
1019 (for the time being this is better than having them attach to
1020 either gdcmFile:: or gdcmPixelConvert::).
1021 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1022 and stores the result in a gdcmJPEGFragmentsInfo.
1023 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1024 code (among other stuff) moved away from gdcmFile:; to
1027 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1029 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1030 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1031 clean up of RLE related code.
1032 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1033 - src/gdcmRLE.cxx removed
1034 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1035 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1036 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1037 * CLEANUP_ROUND (9) for gdcmPixelConvert
1038 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1039 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1040 away from gdcmFile:: to gdcmPixelConvert::.
1042 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1043 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1044 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1045 This is because Parse7Fe0 used to parse the pixels to compute the
1046 length. This task was passed over to FindDocEntryLengthOB() a long
1047 time ago, EXCEPT I had forgotten the OW case...
1048 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1049 we just recylce the code for parsing RLE fragments and computing
1051 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1052 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1053 with the retired Parse7Fe0().
1054 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1055 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1057 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1059 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1060 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1061 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1062 * CLEANUP_ROUND (4) for gdcmPixelConvert
1063 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1064 to return an unused length.
1066 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1067 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1068 this should be cleanner from the plane view. The iostream are erally a pain
1069 to use to do simple stuff.
1071 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1072 * Redo the compilation of the ijg jpeg library. Now only one source is
1073 necesseray. No need to rename file by hand what so ever. CMake handle the
1074 copying of the file within different directory, configure header file to
1075 modify some symbol. The only addition made to ijg wasd a mangle table so
1076 that symbol are different whether we are within 8bits or 12bits.
1078 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * Added documentation of vtkgdcmReader on Website:
1080 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1081 with it's binary name).
1082 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1083 the Website to be more complete.
1084 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1085 doxygenated documentation.
1086 - Doc/DoxyVtkGdcmReaderExamples.txt added
1087 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1088 DoxyVtkGdmReaderExamples.html )
1089 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1090 * CLEANUP_ROUND (3) for gdcmPixelConvert
1091 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1093 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * CLEANUP_ROUND (2) for gdcmPixelConvert
1095 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1097 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * CLEANUP_ROUND for gdcmPixelConvert:
1099 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1100 - src/gdcmPixelStuff[h|cxx] removed
1101 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1102 - src/CMakeLists.txt changed accordingly
1103 * GDCMHOME clean up:
1104 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1105 gdcmVersion.py moved to newly created ATTIC related
1106 gdcmPython/SetupOldies/ directory.
1107 * Autotools clean up:
1108 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1109 - autogen.sh configure.in acinclude.m4 python.m4 removed
1111 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1113 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1114 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1116 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * TODO updated with Mathieu suggestions. I proposed a template for
1118 describing TODO entries and used it for new entries.
1119 * Added Doc/Website/CodingStyle.html, Developpers.html,
1120 DeveloppersPython.html, GdcmDataCvs.html and
1121 DownloadVersion0_1.html, DownloadVersion0_3.html.
1122 * Some Doc/*.txt Doxygen files (which do not really concern the
1123 documentation itself, but the website) moved to html and
1124 placed in directory Doc/Website:
1125 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1126 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1127 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1128 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1129 * CMakeLists.txt changed accordingly.
1130 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1131 DeveloppersPython.html
1132 * INSTALL nows refers to Doc/Website/Installation.html
1134 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * Added Doc/Website directory, that contains a first raw version
1138 2004-09-23 Jean-Pierre Roux
1139 * FIX In order not to be poluted any longer by casting problems,
1140 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1141 we can now delete[] it safely
1142 * VoidArea is now called BinArea (less confusing name),
1143 and all the methods called ...VoidArea... are now ... BinArea...
1144 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1146 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1148 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1149 up to the destructor of gdcmElementSet to clean up TagHt and it's
1152 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1154 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1156 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * ENH: added some utility method that builds a flat dictionary
1158 holding all the Dicom entries contained in the recursive structure
1159 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1160 an example of usage.
1161 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1162 BuildFlatHashTable() that build a flat dictionary.
1163 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1164 gdcmDocument is now a friend of gdcmElementSet.
1165 - src/gdcmElementSet.cxx: clean up.
1166 - Example/FlatHashTablePrint.cxx added.
1167 - Example/CmakeLists.txt changed accordingly
1169 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1171 moved away from gdcmDocEntrySet (since this class is an abstract class
1172 acting like an interface). SQDepthLevel and BaseTagKey are now
1174 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1175 and associated accessors. Doxygenation of the class.
1176 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1178 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1179 Use SQDepthLevel accessor instead. ::Print() adapted.
1180 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1181 - src/gdcmDocument.cxx changed accordingly.
1183 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1185 - The following is the doxygen comment of the typedef declaration
1186 of gdcmTagKey in src/gdcmCommon.h:
1187 gdcmTagKey is made to old an "universal" (as in URL, Universal
1188 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1189 A dicom tag always has a group and an element, but a set of tags
1190 embeded in various (optionally nested) sequences and sharing
1191 the same group and element all share the same (group, element)
1192 "identifier". Hence the (group, element) cannot be used as an
1193 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1194 In order to construct a proper tag identifier (i.e. a key) we
1195 consider the following definition of a TagKey:
1196 - let Group, Element be the string representation of the
1197 group and element dicom tag members,
1198 - let ItemNumber be the string representation of the integer
1199 index of the considered item number of a sequence,
1200 Let the key of a tag embeded in a sequence, noted SeqTag, be
1202 /ItemNumber#Group|Element
1203 where "/", "#" and "|" are characters acting as separators.
1204 Then the general form of a gdcmTagKey is given by:
1205 Group|Element<SeqTag>
1206 where <SeqTag> means NO or many instances of SeqTag.
1207 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1210 but the gdcmTagKey of a tag "embeded" is the first item of
1211 a sequence, itself nested in the third item of a sequence is the
1213 0004|1220/2#0008|0082/0#0008|0090
1214 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1215 order to hold the new sequence compatible key. Previously, the
1216 GetKey() method would look in the underlying gdcmDictEntry.
1217 - src/gdcmDocEntry.cxx:
1218 -- constructor now copies the underlying DictEntry key, in the local
1220 -- ::Print: displays the member Key, instead of the (group, element).
1221 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1222 - src/gdcmDocEntrySet.h:xi
1223 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1224 -- now has a new BaseTagKey member.
1226 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1227 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1229 This poses the problem with the semantics of the following lines
1230 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1231 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1232 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1233 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1234 to the long FIXME note for what the problem is. Nevertheless in
1235 order to get things working the dicom dictionary was altered !
1236 Please fix things urgently...
1237 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1238 information), see above note on moving the member VoidArea. Nevertheless
1239 the following entries previously correctly set as US are now inproperly
1241 0028 1201 OW IMG Red Palette Color Lookup Table Data
1242 0028 1202 OW IMG Green Palette Color Lookup Table Data
1243 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1244 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1245 of gdcmDocEntry moved to gdcmSeqEntry.
1246 * src/gdcmSeqEntry.cxx: STYLE.
1248 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1251 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1252 * gdcmPython/testSuite.py: all the test suite in python is now moved
1253 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1254 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1255 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1257 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1259 to avoid inclusion recursion until STL is reached.
1260 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1261 mecanism. errno.h is not included in gdcm anymore.
1262 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1263 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1265 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1266 gdcmData/TestAllEntryVerifyReference.txt
1267 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1268 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1269 exception_on_error parameter.
1270 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1271 - vtk/vtkGdcmReader.cxx changed accordingly,
1272 - Example/*.cxx and Test/*.cxx changed accordingly.
1274 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1276 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1277 enable_sequences removed from gdcmHeader constructor and dependencies.
1278 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1279 * gdcmPython/demo/PrintHeader.py: dummy fix.
1280 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1281 skip_shadow removed from gdcmHeader constructor and dependencies.
1282 * Example/*.cxx and Test/*.cxx changed accordingly.
1284 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1285 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1286 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1288 2004-07-21 Jean-Pierre Roux
1289 * FIX Now, Parsing and Printing a DICOMDIR do work!
1290 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1292 2004-07-20 Jean-Pierre Roux
1293 * FIX Some brain damaged headers have Zero-Lenght fields
1294 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1296 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1297 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1298 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1299 variable (instance of gdcmDebug) by a definition macro, and the instance
1300 is now in static in the gdcmDebug class
1301 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1302 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1304 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * WARNING: ctest now depends more tightly on gdcmData. You should
1306 check out gdcmData properly for things to run smoothly...
1307 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1308 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1309 we need the pixels not be loaded in order to use the ValEntry
1310 that displays position and size).
1311 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1312 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1313 be deprecated. If you have any doubts about the advantages of a
1314 modern scripting language (read Python) versus grass root C++ (i.e.
1315 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1316 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1317 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1318 Anyhow, consider documenting the gdcmData images in
1319 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1321 * Test/CMakeLists.txt:
1322 - now uses TestAllEntryVerify.cxx
1323 - specific comments on oldACR00001.ima (now renamed in gdcmData
1324 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1325 gdcmData/TestAllEntryVerifyReference.txt
1328 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1329 * src/*.[h|cxx] : typedef clean up
1330 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1331 - TagKey renamed to gdcmTagKey (for external usage)
1332 - VRKey renamed to gdcmVRKey (for external usage)
1333 - removal of typedef duplication.
1334 - Removed all unecessary inline keyword from class inline definitions.
1335 - Some method|function(void) declarations replaced with method|function().
1336 * src/jpeg/libijg12/jdhuff12.c:
1337 - printf polluting ctest removed.
1338 - TAB removal for comminting
1340 - TestAllReadCompareDicom.cxx: added a test that compares all the
1341 images in gdcmDataImages.h with corresponding images in
1342 gdcmData/BaselineDicom/. When baseline images are not present
1343 this test creates them.
1344 Note: we need to validate each reference image, but before that
1345 I'd like to rename them with a more explicit name...
1346 - CMakeLists.txt: changed accordingly.
1347 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1348 including each header needed).
1350 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1352 test suite to the Example directory. Are concerned:
1357 - TestWriteSimple.cxx
1358 * Test/CMakeLists.txt: added some comments on reasons for black listing
1359 image gdcmData/oldACR00001.ima
1361 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1362 * Test/CmakeList.txt: removed the following from black list (to be coherent
1363 with removal from gdcmData):
1364 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1365 - gdcm-MR-PHILIPS-16.dcm
1367 Added the following because after last cvs update, they cause
1368 ctest -R TestReadWriteReadCompare
1370 - gdcm-MR-SIEMENS-16-1.acr
1372 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1373 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1374 new comments in this file) we temporarily (sigh) move to a weaker
1376 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1377 we don't need to black list the following images anymore:
1378 - 8BitsUncompressedColor.dcm
1380 - US-PAL-8-10x-echo.dcm
1381 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1382 fixes and the beautified code ;-)
1383 This fixes the bug introduced in version 1.42 (when beautifying)
1384 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1385 Note: ctest was blind to this bug (this means we need to still
1386 improve the test suite). The bug could be detected by using
1387 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1389 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1390 and by displaying the (garbage) produced file temp.XDCM...
1392 2004-06-29 Jean-Pierre Roux
1393 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1394 - replace by uggly but working old code :-(
1395 A lot of things should be OK again.
1396 It's really urgent to have a test suite that *tests*,
1397 to prevent Frog's beautifying sessions to break all the stuff
1398 (twice, withing a fortnigh ...)
1400 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1402 redundancy) to added Test/TestReadWriteReadCompare.cxx
1403 * Test/CmakeList.txt: because the compare test of
1404 Test/TestReadWriteReadCompare.cxx fails, the following images are
1405 black listed: - 8BitsUncompressedColor.dcm
1407 - US-PAL-8-10x-echo.dcm
1408 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1409 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1410 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1411 and ad-hoc kludge. This kludge is now removed, and on encountering
1412 such an image (OB field brain damaged) we set errno. Then in
1413 ::FindDocLength() we "fix" the length as being ALL what remains
1414 in the file (until EOF). We then proceed, hoping for the best...
1415 This fixes a SegFault in ShowDicom when trying to write such an
1417 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1418 (because TestWriteRead breaks on it, after a non conformal commit?).
1419 ctest now runs properly, except for MakeDicomDir (which was always
1420 broken) and the Python related stuff (still not fixed).
1422 2004-06-24 Jean-Pierre Roux
1423 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1424 FIX : Test/TestReadWrite now iterates on all the file names
1425 (instead of infinite loop)
1426 ENH : Test/TestWriteRead now iterates on all the file names
1428 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1431 2004-06-24 Jean-Pierre Roux
1432 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1433 when SamplesPerPixel =3
1434 - now Write is no longer confused by
1435 'BitsAllocated = 12" and 'BitsStored=12"
1436 - "UN" value representation Elements are now written correctly
1437 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1438 ENH : - now gdcmHeader has its own Write methods
1439 (in order to split the job that has not to be done
1442 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1444 loop on the same image until memory went out.
1445 Note: this means we still have gobs of memory loss in PrintDocument
1446 * src/gdcmDocument.cxx: fixes problem on parsing on file
1447 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1449 2004-06-24 Jean-Pierre Roux
1450 FIX : Write - All the Sequences and Sequence Item are now written
1451 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1452 is added a the end, when necessary.
1453 - A lot of brain-damaged images, that were read correctly are
1454 now written correctly
1455 - length compatible BinEntry are now loaded correctly
1456 (even for odd groups)
1457 Note : only Explicit Value Representation was checked.
1458 (question : is implicit VR really necessary for gdcm ?)
1460 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1461 * DEVELOPPER: added a proposition of coding style.
1462 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1465 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1467 Use the gdcmDocEntry::Print() and Write() instead.
1468 * src/gdcmDocument.cxx: bug fix.
1470 2004-06-22 Jean-Pierre Roux
1471 FIX : gdcmDocument.cxx
1472 - Now we do recognize the JpegLossLess format (there was a misstyping in
1473 code 'beautyfication' :-(
1474 - Now we automaticaticaly load the Luts, if any
1476 2004-06-22 Jean-Pierre Roux
1477 In order : to write Sequences, whatever their imbrication level,
1478 : to allow user to create his own Sequences
1479 a lot of modif where necessary (adding, moving, or virtualising methods)
1481 WARNING : save your own sources *before* cvs up !
1484 ADD virtual void Write(FILE *fp, FileType filetype);
1487 ADD virtual void Write(FILE *fp, FileType filetype);
1488 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1491 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1492 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1493 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1494 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1495 ADD std::string GetEntryByName(TagName name);
1496 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1498 std::string vr = "unkn",
1499 std::string fourth = "unkn",
1500 std::string name = "unkn");
1501 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1502 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1503 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1504 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1505 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1506 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1507 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1508 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1511 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1512 ADD virtual std::string GetEntryByName (TagName tagName);
1513 ADD virtual std::string GetEntryVRByName (TagName tagName);
1514 REM virtual bool Write(FILE *, FileType);
1515 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1516 FILE *_fp, FileType type);
1517 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1518 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1519 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1520 REM virtual std::string GetEntryByName (std::string tagName);
1521 REM virtual std::string GetEntryVRByName (std::string tagName);
1522 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1523 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1524 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1526 std::string vr = "unkn",
1527 std::string fourth = "unkn",
1528 std::string name = "unkn");
1529 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1530 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1531 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1532 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1535 ADD virtual void Write(FILE *fp, FileType filetype);
1538 ADD virtual void Write(FILE *fp,FileType filetype);
1541 ADD virtual void Write(FILE *fp, FileType filetype);
1542 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1543 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1544 REM std::string GetEntryByName(TagName name);
1547 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1549 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1550 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1551 The default constructor invoked by the line
1552 gdcmHeader *f1 = new gdcmHeader( header );
1553 was gdcmHeader::gdcmHeader(bool) instead of the expected
1554 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1555 Hence the parsing wasn't executed... See also below.
1556 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1557 as explicit constructor didn't do the trick to fix the above problem.
1558 Could anyone explain why ?
1559 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1560 properly calls gdcmValEntry::Print() (that was weed out from
1561 code related to gdcmBinEntry).
1563 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * In order to fix memory leaks:
1565 - Test/TestWriteSimple.cxx: added cleaning of free store through
1567 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1568 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1569 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1570 (through the call to ::AddDicomDirMeta()) or the destructor
1571 would crash when deleting uninitialized ::metaElems].
1572 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1573 - src/gdcmDocument.cxx:
1574 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1575 from dynamic stores.
1576 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1577 was causing memory leaks.
1578 - src/gdcmSQItem.cxx:
1579 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1580 cleanly handled with polymophism: sorry but my milage is low).
1581 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1582 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1583 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1584 This avoids SegFaulting.
1585 - src/gdcmSQItem.h: coding style.
1587 - Test/TestWriteSimple still severely sucks. The output image content
1588 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1589 damaged when displayed with vtkgdcmViewer.
1590 - on memory leaks: TestWriteSimple leaks really less (see entry
1591 of 2004-06-18 in Changelog file for the call to valgrind).
1592 - on segfaults: ctest now passes all the tests but one (no more
1594 * Erroneous leading white fix:
1595 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1596 white[s] (as opposed to from >> xxx, that removes it [them].
1597 - src/gdcmTS.cxx: ditto.
1598 - gdcmPython/testSuite.py: dirty related kludge removed.
1599 * src/*: remaining references to gdcmParser removed.
1600 * src/*[cxx|h]: added copy[way]left header.
1603 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1604 * In order to fix writing of dicom files:
1605 - Test/TestWriteSimple.cxx: a simpler example of writing.
1606 - Test/CMakeLists.txt changed accordingly.
1607 - src/gdcmDocument.cxx:
1608 -- The destructor now recursilvely removes potential sequences.
1609 -- Bug fix in ::IsJPEG2000()
1610 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1611 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1613 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1614 to only declared) and build on top of
1615 ::GetDocEntryByNumber(guint16, guint16).
1616 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1617 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1618 for usage in destructor and treatement of promotion in
1619 ::ReplaceOrCreateByNumber().
1620 - src/gdcmSQItem.cxx: destructor should better handle his job.
1621 Test/TestWriteSimple now runs (or at least it DOES something).
1622 * We can now start hutting memory links. A good starting point is:
1623 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1624 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1625 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1627 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1628 * Valgrind note: after Mathieu Malaterre teached me how to read
1629 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1631 Using gcc, you can force the STL to use malloc and to free memory as
1632 soon as possible by globally disabling memory caching.
1633 With 3.2.2 and later, you should export the environment variable
1634 GLIBCPP_FORCE_NEW before running your program.
1635 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1636 simply vanish (it is still not clear to me, whether this means that
1637 STL std::string leaks or if valgrind believes it leaks...).
1638 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1639 running bin/gdcmTests makeDicomDir):
1640 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1641 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1643 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1644 SegFaulting (I drowned in DicomDir related code when trying to
1645 understand why the list is empty...).
1646 * src/gdcmDocument.h: first BSD license header try.
1647 * Doc/License.txt added.
1649 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * src/gdcmDocument.[h|cxx]:
1651 - Clean up of the Transfer related predicates. They are now all based
1652 on new method isGivenTransferSyntax, that (should) handle properly
1653 the padding problem.
1654 - general clean up, simplification, and coding style.
1655 - Specific clean up of Parse7FE0() (umproperly named actually).
1656 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1658 2004-06-14 Jean-Pierre Roux
1660 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1661 - fix the display of SQItem ordinal number
1662 - add the GetSQItemByOrdinalNumber method
1663 - remove some useless never written private methods
1665 2004-06-14 Jean-Pierre Roux
1667 - adding a constructor taking a gdcmDocEntry as an input param
1668 - ReplaceOrCreateByNumber now returns :
1669 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1670 a gdcmValEntry * if a string value is passed as a param
1672 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1673 according to the param type (no longer sets a gdcmDocEntry)
1674 - GetValEntryByNumber, GetBinEntryByNumber added
1675 - NewValEntryByNumber and NewBinEntryByNumber added
1677 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1679 - GetSQItemNumber and SetSQItemNumber added, to provide
1680 a (relative) Item identier inside a given Sequence
1681 \warning : some pb remaining around this number
1683 - AddEntry now takes the Item Number as a param
1685 - adding a constructor taking a gdcmDocEntry as an input param
1687 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1688 * Memory leak hunt with the following command:
1689 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1690 --show-reachable=yes gdcmTests PrintDocument
1691 It looks like many (all?) leaks are due to the STL (or a bad usage
1692 of the STL. The lines producing the leaks now have a comment with
1693 a "MEMORY LEAK" tag: you can retrieve them with
1694 grep "MEMORY LEAK" src/*
1695 Here are two typical examples which I can't help fixing:
1700 char * test = "babo";
1701 name = test; //// <--- valgrind detects 960 bytes lost in
1702 //// call to std::string::operator=(char const*)
1703 name.clear(); //// Doesn't help !
1711 std::cout << "Type a bunch of characters followed by RETURN: ";
1712 getline(std::cin, line); //// <--- valgrind dectects a loss
1713 //// of 1320 bytes in call to
1714 /// std::basic_istream<>& std::getline<>
1720 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1721 * src/gdcmHeader.[cxx|h]:
1722 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1723 and related, moved away to gdcmDocument.
1724 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1725 the corresponding protected accessors of inherited class
1726 gdcmDocument, removed ! As a consequence gdcmFile had to be
1727 declared friend of class gdcmDocument (see below).
1728 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1729 - Clean up of undefined or unused methods.
1730 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1731 account the changes to gdcmHeader.h).
1732 * src/gdcmDocument.h:
1733 - gdcmFile is now a friend class (in order to take into account the
1734 changes to gdcmHeader.h).
1735 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1736 (see changes to gdcmHeader.h).
1737 - Accessors (reading on the form GetEntry*) are now public.
1738 - Clean up of undefined or unused methods.
1739 * src/gdcmDocument.cxx:
1740 - adaptation to changes to gdcmDocument.h
1741 - ::OpenFile now writes a verbose message when file cannot be opened.
1742 - some std::string properly set to VRKey
1743 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1744 references to gdcmDocument.
1745 * Test/TestFindTags.cxx: changed accordingly to above changes.
1746 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1747 cvs repository gdcmData.
1749 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1750 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1751 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1752 conflicts with gdcmValEntry::voidArea.
1753 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1754 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1755 Value representation between StringRepresentable and BinaryRepresentable.
1756 * src/gdcmDocument.cxx:
1757 - method ParseDES: proper indentation restored and usage of
1758 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1759 - method LoadDocEntry: the fingerprint left in the SetValue() of
1760 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1761 removed. Reverting to previous code segment with the proper
1762 dynamic_cast< gdcmValEntry* >.
1763 Note: this was (partially) breaking the python test suite
1764 (gdcmPython/testSuite.py) that made usage of the above
1765 fingerprint to check presence of "Pixel Data".
1766 * src/gdcmDocEntry.h: coding style.
1767 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1768 now taken into account.
1769 * gdcmPython/gdcm.i: adaptation to the new internal representation
1770 of gdcm (exit gdcmParser, hello gdcmDocument).
1771 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1773 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1774 anymore, but instead prints the loaded Python dictionary.
1775 * .... alas, the python testSuite is still broken.
1777 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1778 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1780 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1781 * src/gdcmUtil.h : export methods
1783 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1786 * Initial addition of automatic python testing
1787 * Initial addition of automatic image comparison
1789 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1790 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1791 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1793 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1794 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1795 * Test/ShowDicom.cxx : bug fix for msvc compilation
1796 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1798 2004-05-04 Jean-Pierre Roux
1799 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1800 new concepts (and new classes) :
1801 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1802 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1803 - Sequence Doc Entries (gdcmSeqEntries)
1804 a Sequence is composed of Items.
1805 Each item is a set of Doc Entries (this is recursive)
1806 The non uniqueness of the 'Dicom tag' is due to this recursivity
1807 (never taken into account)
1808 Our unability to add a new 'entry' in the header
1809 at the proper location (neither in the H-Table (map or multimap),
1810 nor in the Chained List is also due to this recursivity.
1811 Don't try, right now, to use/modify/compile these new sources :
1812 nothing is finished.
1813 We just commit all the stuff, 'as is', in order not to loose it.
1815 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1816 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1818 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1819 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1820 file prefix (SetFilePrefix)
1822 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * Add a new test: ShowDicom, for now this is just the c++ version of
1824 checkRead.sh, later it will be able to compare the image read against a
1826 * Replace the DEBUG on the stack with a global entry in cmake interface:
1827 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1829 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1830 * Add an example subdir, with a real example on how to read + write a
1833 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1835 * Doc/CMakeLists.txt: the main page is now properly differentiated
1836 between the developper and user version.
1837 * Doc/doxygen.config.in: dropped search related obsolete flags
1838 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1840 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * DEVELOPPER: added some helpfull comments for compile/test/install
1844 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1846 src directory, now generated in the build dir.
1847 2. Tests as mentionned smarter
1849 4. Add a new method in gdcmDict that return the PubDict by name
1850 this is interesting for 3rd party lib like ITK,
1851 where we could set the institution name / patient name...
1853 * ENH: 1. Now the test suite is working for real
1854 2. All binaries are now output in the gdcm-bin directory
1855 (this was not true before)
1857 2004-04-28 Jean-Pierre Roux
1858 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1859 SeQuence indented printing of Dicom Header.
1860 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1861 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1862 Computation of SQDepthLevel is now part of gdcmHeader constructor
1863 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1864 tree-like structure of a Dicom Header.
1865 * FIX Test code cleaning
1867 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1868 * ENH: Adding automatic testing
1869 1. Need a DartConfig.cmake to submit to public
1870 2. Add a test driver gdcmTest.cxx
1871 3. gdcmTestMain, an helper for the main test driver gdcmTest
1872 4. Files in Test don't have a main anymore, this becomes interesting
1873 when we add more and more tests, thus dsw don't have to load
1875 * ENH: Adding a GDCM_DATA_ROOT for testing
1876 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1877 one file instead of seven + some small cleanup
1879 2004-04-22 Jean-Pierre Roux
1880 * ENH Minor changes to the Print() methods.
1881 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1882 Header printing. Example given with :
1883 > PrintHeader fileName 2 new
1884 (SQ based tree-like structure still to be done for the Header ...)
1886 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1888 1. I have added some unsigned where needed
1889 2. Some function parameter not used -> (void)
1890 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1891 4. g++ don't like character '\' in comment
1892 5. #define jpeg_create_decompress jCreaDecompress
1893 this really need to be fixed
1894 6. virtualize destructor of gdcmObject ... leakage
1895 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1896 this also really need to be fixed
1897 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1898 remove compression file
1899 (as we only do decompression, right ?)
1900 * ENH: Change malloc/calloc/free with c++ equivalent
1902 2004-04-21 Jean-Pierre Roux
1903 * FIX gdcmHeaderHelper::GetXSpacing
1904 when a single value is found (bug ?), xpacing is now
1905 defaulted to yspacing
1907 2004-04-19 Jean-Pierre Roux
1908 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1909 * ENH add parameters :
1910 bool exception_on_error = false,
1911 bool enable_sequences = false,
1912 bool ignore_shadow = false
1913 to the gdcmFile constructors to be full gdcmParser compliant
1914 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1915 to allow reading of PAPYRUS 3.0 files
1917 2004-04-06 Jean-Pierre Roux
1918 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1920 2004-04-02 Jean-Pierre Roux
1921 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1922 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1923 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1925 2004-03-30 Jean-Pierre Roux
1926 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1927 for ACR file, written out as DICOM files (hope so...)
1929 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1931 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1932 moved to base class gdcmParser and only the specialisation is kept
1934 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1935 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1936 already does the job.
1937 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1938 (to be consistent with gdcmParser::WriteEntries).
1940 2004-03-30 Benoit Regrain
1941 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1942 upate of the object's instance. It's passed to 2 in the unfavorable
1943 case : one in the ExecuteInformation, one in the ExecuteData
1945 2004-03-29 Jean-Pierre Roux
1946 * ENH : Check on file type to be written moved
1947 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1948 * FIX : gdcmObject::ResetBoundaries now stops properly
1949 when end-of-list is reached
1950 : gdcmVersion modified (as Benoit Regrain asked)
1952 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1953 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1954 * src/gdcmUtil.cxx: added forgotten iostream include.
1955 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1956 equivalent to ExplicitVR in existing code).
1958 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1960 now contains all the gdcmGlobal related code.
1961 * minor coding style and doxygenation changes.
1963 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1965 now contains all the Debug related code.
1966 * minor clean-up of includes in src/*.cxx
1967 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1968 CreateCleanString) removed.
1969 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1970 * Doc/DoxyMainPageUser.txt added.
1971 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1972 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1973 src/gdcmDirList.cxx)
1975 2004-03-24 Jean-Pierre Roux
1976 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1978 2004-03-23 Jean-Pierre Roux
1979 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1980 big endian made volumes
1981 * ENH Now gdcmParser constructor and destructor are protected to forbid
1982 end user to instanciate class gdcmParser
1983 (only gdcmHeader and gdcmDicomDir are meaningfull)
1985 2004-03-22 Benoit Regrain
1986 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1987 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1988 gdcmSerie to gdcmDicomDirSerie
1990 2004-03-19 Jean-Pierre Roux
1991 * ENH Now the tree-like structure describing a DICOMDIR comming from
1992 an already existing DICOMDIR file is consistent with
1993 the home-made tree-like structure build ex-nihilo
1994 or build from the files held (recursively) in a Directory
1995 functions gdcmDicomDir::CheckBoundaries()
1996 gdcmObject::SetBoundaries() added
1998 2004-03-17 Jean-Pierre Roux
1999 * REM (Eric Boix bug) : removal of meaningless
2000 gdcmDicomDirImage::NewImage function.
2001 * FIX now file names and directory name are written properly in the
2003 * FIX now gdcmDicomDir constructor may be call without any trick
2006 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2008 of gdcmDicomDirImage::NewImage as empty function.
2010 2004-02-28 Jean-Pierre Roux
2011 * ENH add gdcmDicomDir:NewPatient
2012 add gdcmDicomDirPatient:NewStudy
2013 add gdcmDicomDirStudy:NewSerie
2014 add gdcmDicomDirSerie:NewImage
2015 to allow making gdcDicomDir object.
2016 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2017 (as opposite to the gdcmHeader chained list)
2019 2004-02-11 Benoit Regrain
2020 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2021 when using from python
2023 2004-02-10 Benoit Regrain
2024 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2025 * FIX : in gdcmDicomDir when the directory is empty
2026 * ENH : add callback and methods to get the progression of dicomDir
2029 2004-02-06 Jean-Pierre Roux
2030 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2031 - GDCM_META added to gdcmDicomDirType
2032 - class gdcmMeta created
2033 * ENH : - A brief summary is now displayed at the beginning of
2034 'testDicomDir' to help disaster magnitude estimation
2035 * REM : Now useless Test/explDICOMDIR.cxx
2037 2004-02-05 Benoit Regrain
2038 * ENH : add methods in gdcmObject to get the hash table or the list of
2040 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2041 * FIX : wrapping python for TagHeaderEntryHT
2043 2004-02-04 Benoit Regrain
2044 * FIX : even length for some strings when writting the dicom dir
2045 * FIX : sort the images in the dicom dir
2046 * FIX : Bug fix for python use of dicom dir
2047 * ADD : a python demo
2049 2004-02-04 Jean-Pierre Roux
2050 * FIX : Final solution (?) for icone embedded images
2051 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2052 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2053 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2054 gdcmData/gdcm-MR-SIEMENS-16.acr1
2055 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2056 to make full checking easier
2058 2004-02-04 Benoit Regrain
2059 * FIX : WriteEntries : coding style & logic in parameters
2060 * FIX : Set the elements to create the DicomDir in a dictionary file
2062 2004-02-03 Benoit Regrain
2063 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2064 * gdcmDicomDir : add the load of directory
2065 * Bug fix and print add-on
2067 2004-02-03 Jean-Pierre Roux
2068 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2069 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2070 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2071 * FIX gdcmParser.cxx : 'group length' elements are now considered
2072 as integers, even for shadow groups, when file is Implicit VR
2074 2004-02-02 Jean-Pierre Roux
2075 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2077 of the last synonym :-(
2078 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2080 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2081 * FIX taking into account the possible 7fe0,0010 multiplicity
2082 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2083 to allow removal of references to 7fe0,0010, to deal with
2084 ACR-NEMA images, when 0028,0200 is meaningfull
2086 2004-01-31 Jean-Pierre Roux
2087 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2088 no longer writes 'Un' on disk
2089 * FIX SQ elements with actual length are now dealt with corectly
2090 * FIX gdcmFile::WriteBase make the difference, for color images, between
2091 the length (for Palette expanded images)
2092 and Raw Length (non expanded image + Palette)
2093 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2094 (that broke Write). Replaced by UL.
2095 Aware user will reload the field if he
2096 thinks it's necesssary
2098 2004-01-30 Jean-Pierre Roux
2099 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2100 when 'dirty Acr' is found, to be compliant with the new
2101 IsReadable() methods.
2103 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2104 (no DOUBLE images in kosher DICOM,
2105 but so usefull for people that miss them ;-)
2107 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2108 DICOMDIR related utilities (not checked as Windoze compliant)
2110 2004-01-28 Jean-Pierre Roux
2111 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2113 2004-01-27 Jean-Pierre Roux
2114 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2115 to allow skipping the shadow elements, to save memory space.
2116 The TRUE value for this param has to be used
2117 with a FALSE value for the 'enable_sequence' param.
2118 ('public elements' may be embedded in 'shadow Sequences')
2119 * gdcmHeader methods now deal with 'embedded icones images' in the header
2120 (even when an 'icone image sequence' is announced by the
2121 element (0x0088,0x0200), but there is NO icone at all ...
2123 * gdcmHeader sometimes Image Location value doesn't follow
2124 the supposed processor endianity (see gdcmData/cr172241.dcm).
2127 * gdcmHeader add the method
2128 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2129 to get *all* the Header Entries with the same tag.
2130 GetHeaderEntrySameName is probabely *useless*
2131 (no meaning : Name is *not* an identifier within the Dictionary)
2133 2004-01-26 Benoit Regrain
2134 * Bug fix in the print of hexadecimal representations. Remove long fields
2135 in the print and add a third level of print to print them
2137 2004-01-23 Benoit Regrain
2138 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2139 * Bug fix on test suite after remove the strip made on not string fields
2140 * Split the IsReadable method between gdcmParser which test that the file
2141 is dicom and gdcmHeader which test that it's an image file
2143 2004-01-22 Benoit Regrain
2144 * DicomDir : clean code, add methods, set variables in protected or private
2145 * gdcmUtil : bug fix for the clean string method
2147 2004-01-19 Benoit Regrain
2148 * Add the use of shadow dictionaries
2149 * bug fix and coding style
2151 2004-01-19 Benoit Regrain
2152 * src/gdcmFile.cxx : bug fix concerning the close of file
2153 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2154 * Add the update of header entries using the shadow library
2156 2004-01-19 Benoit Regrain
2157 * removal of file gdcmHeader2.cxx
2158 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2159 inheriting from gdcmParser. This split is to prepare the integration
2160 of dicom dir parsing
2161 * bug fix under python
2163 2004-01-16 Jean-Pierre Roux
2164 * REM removal of class gdcmHeaderEntrySet
2165 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2166 * ADD add file gdcmHeader2.cxx
2167 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2169 2004-01-15 Benoit Regrain
2170 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2171 entries created while parsing the header. Thus, they will be destroyed
2172 when the gdcmDictSet will be destroyed
2173 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2176 2004-01-15 Benoit Regrain
2177 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2178 made a fatal error because of the memory release at the end of program.
2179 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2180 some memory and vtk seems to have some problems with that.
2181 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2183 2004-01-14 Benoit Regrain
2184 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2185 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2186 * src/*.[h|cxx] : make changes due to class name changes
2187 * gdcmPython/demo/*.py : bug fix due to method names
2189 2004-01-13 Benoit Regrain
2190 * src/*.[h|cxx] : coding style
2191 * vtk/*.[h|cxx] : coding style
2193 2004-01-13 Benoit Regrain
2194 * gdcmPython/testSuite.py : test the readable flag of file for tests
2195 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2196 It's lied to the stl compilation by MSVC (windows, always windows...)
2197 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2199 2004-01-12 Benoit Regrain
2200 * src/*.h : add comments
2201 * src/gdcmDictSet.h : set the method BuildDictPath in public
2202 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2203 directly setted in the source code
2204 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2207 2004-01-09 Benoit Regrain
2208 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2209 * setup.py : use a reference to gdcmVERSION
2211 2004-01-07 Benoit Regrain
2212 * Modification to compile with the distutils.
2215 2003-12-10 Benoit Regrain
2216 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2217 can use a gdcmHeaderHelper to load data
2218 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2219 made in the source code
2221 2003-12-10 Benoit Regrain
2222 * Update Windows projects and .cvsignore files
2224 2003-11-12 Jean-Pierre Roux
2225 * ENH gdcmHeader constructor has one more parameter (default value : false)
2226 that allows the user to 'go inside' the SeQuences only
2228 gdcmElValSet:Print takes it into account
2230 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2231 * ENH: Update gdcmPython/CMakeLists
2232 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2233 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2235 2003-11-10 Jean-Pierre Roux
2236 * FIX : gdcmHeader::LoadElements is now based
2237 on the ListTag listElem member,
2238 not longer on the TagElValueHT tagHt member
2239 * ENH : PrintPubElVal shows (temporarily) both results,
2240 with the tagHt member and the listElem member.
2241 (it's easier to 'see' the problems when using Printheader)
2243 * FIX : old private member LgrElem is now splitted into
2244 ReadLength : Length actually found on disk (updated only
2245 if bug fixing is necessary), for internal
2247 UsableLength : Updated by FixFoundLength, to fix a bug
2248 or to allow Parser going on.
2249 Will allow to re-write a kosher header when a SeQuence
2250 with a length (not 0000) is found
2251 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2252 because gdcmElValSet::Add does not update ListElem
2255 2003-11-07 Jean-Pierre Roux
2256 * FIX misstyping in Transfert Syntax name table
2257 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2258 when they have an actual length (not 0000 nor FFFFF)
2259 (Nobody should care of it, but DICOMDIR explorers)
2261 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2264 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * ENH: vtkGdcmReader now supports LUT !
2266 (vtkgdcmViewer for now is not able to use them though)
2268 2003-11-05 Jean-Pierre Roux
2269 * in testSuite.py : new files names for checking the package
2270 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2271 that returns the pixel area size to the *aware* (vtk) user
2272 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2274 2003-11-05 Benoit Regrain
2275 * in testSuite.py : Modify the rules for checking the paths
2276 : Explicit error messages
2277 * in __init__.py : Related modif
2279 2003-11-03 Jean-Pierre Roux
2280 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2281 to be used by aware (vtk) users that want to manage
2282 LUT (and no to turn the PALETTE image into an RGB pixels one)
2283 * GetPixelType now returns 8U for 24 Bits images
2284 (vtkGdcmReader compliant)
2286 2003-10-31 Jean-Pierre Roux
2287 * Removal of *all* gdcmData images and add them again
2288 in order to loose the 'history' of un-anonymised images
2290 2003-10-31 Jean-Pierre Roux
2291 * RMV : removal of useless jBitsInJsample.h
2292 for both 8 and 12 Bits JPEG Lossy Libraries
2294 2003-10-31 Jean-Pierre Roux
2295 * ENH : Add the functions gdcmFile::GetImageDataRaw
2296 gdcmFile::GetImageDataIntoVectorRaw
2297 that act as GetImageData and GetImageDataIntoVector
2298 except the making of an RGB Plane from Gray Plane + LUT
2299 Intended to aware (vtk) users who know how to manage
2302 GetLUTRGBA return a R,G,B,A LUT if any
2303 lgrTotaleRaw gives the 'Raw' length
2304 GetImageDataRaw returns the gray Plane
2305 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2306 (They stay Grey, just like with other Dicom viewers :-(
2308 2003-10-30 Jean-Pierre Roux
2309 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2311 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2312 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2313 being coherents dicom files.
2315 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2316 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2318 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2319 * ENH: Two steps is necessary to please VC++ compiler...
2320 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2321 * ENH: Add include dir to medcon lib
2322 * FIX: only one function is being exported for now !
2323 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2325 2003-10-29 Jean-Pierre Roux
2326 * adding gdcmHeader::GetLUTRGBA
2327 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2328 --> Mathieu, the modif u're waiting for is not yet committed
2329 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2331 2003-10-27 Jean-Pierre Roux
2332 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2333 00191113.dcm DermaColorLossLess.dcm
2334 MxTwinLossLess.dcm RadBWLossLess.dcm
2335 * ENH: For version prior to vtkImageViewer2 -r 1.19
2336 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2338 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * Removal of ido stuff in CMakeLists.txt
2341 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2342 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2343 * FIX: remove a call to ->Modified ... see comments
2344 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2346 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2347 * FIX: Problem with path for libvtkgdcmPython
2348 * ENH: Try adding a search script for python site-package
2349 * RMV: Remove some file from medcon lib that are not necessary
2350 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2351 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2352 * FIX: More pragma disable fro VC++,
2353 I don't think I break something as it is also disable in VTK/ITK.
2354 But it fasten debug compilation time.
2356 2003-10-23 Jean-Pierre Roux
2357 * gdcm now deals with 16 Bits Run Length Encoded images
2358 (they are compressed as 2 planes images,
2359 one for the high Bytes, the other for low Bytes)
2361 2003-10-22 Jean-Pierre Roux
2362 * Now CheckRead takes into account :
2363 - the bugged 'Leonardo' Siemens images
2364 - the XA images, sent thru the burning VPRO station
2365 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2368 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2369 * FIX: When copying a Makefile.am to CMakeLists.txt
2370 one should remove the '\'
2372 2003-10-22 Jean-Pierre Roux
2373 * in gdcmData adding a bugged 'Leonardo' Siemens image
2374 (wrong lengths in header)
2375 OK with gdcm, KO with the other viewers :-)
2376 * add a GE dlx XA image, thru the VEPRO burning station
2379 2003-10-21 Jean-Pierre Roux
2380 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2381 for a brutal checking of vtkgdcmViewer compliance
2383 2003-10-21 Jean-Pierre Roux
2384 * add the files for 'xmedcon' Jpeg Lossless library
2385 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2387 2003-10-21 Jean-Pierre Roux
2388 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2390 2003-10-21 Jean-Pierre Roux
2391 * garbage Siemens 'Leonardo' images dealt with
2392 (the patch is easy to remove)
2393 * cosmetic changes to avoid warnings
2395 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2397 no need to press 'r' now.
2399 2003-10-20 Jean-Pierre Roux
2400 * upgrade of checkRead.sh checkWrite.sh according
2401 to new Jpeg Lossless decompressor
2402 * add US.3405.1.dcm, a genuine RGB medical file ...
2403 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2404 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2406 2003-10-15 Jean-Pierre Roux
2407 * general anonymisation in gdcmData
2408 * adding the 'color files' from
2409 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2410 * adding some well knowed bugged-header images
2411 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2412 waiting for their inclusion in Python testsuite
2414 2003-10-15 Jean-Pierre Roux
2415 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2416 no longer seg faults when file is not found
2418 2003-10-14 Jean-Pierre Roux
2419 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2422 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * TODO: *.in file to genereate a UseGDCM later
2425 2003-10-14 Jean-Pierre Roux
2426 * Some supposed-to-be Dicom Images have no preamble.
2427 OpenFile takes it into account
2428 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2429 * Missing elements added in dicomV3.dic
2430 (just to be affraid : have a look at
2431 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2432 and do it again next year ;->
2434 2003-10-13 Jean-Pierre Roux
2435 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2436 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2437 But there are NOT. It's fixed !
2439 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * FIX: "jpeglib.h" was not found on VC++
2441 * FIX: vtkgdcm was not being installed
2443 2003-10-10 Jean-Pierre Roux
2444 * ENH : OpenFile closes the file if it *really* doesn't look like
2445 an ACR-NEMA / DICOM one.
2446 * FIX : testWrite no longer writes an empty file if the source file
2447 is not gdcm Readable
2448 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2451 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * FIX: CMake generate now documentation
2453 * ENH: out of source doc build !
2454 * ENH: Generate both user and dev documentation
2455 * ENH: Should work on windows too
2456 * ENH: Only one doxygen config.in file is needed
2457 * FIX: make install should be ok now on ùnix plateform
2458 * FIX: PATH to dictionary was wrong (missing /)
2459 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2461 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2462 * vtkGdcmReader is now able to read rgb dicom file.
2463 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2464 * added a gdcmViewer to vtk test, use mouse to control
2465 window level & window width
2467 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2468 * CMake-ification of gdcm, we have now two build system
2469 * FIX: on cygwin Wsock32 doesn't exist
2470 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2472 2003-10-06 Emanuel Ollart
2473 * FIX : compilation process wad broken.
2474 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2476 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2477 * change gdcmViewer -> vtkgdcmViewer
2478 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2480 2003-10-06 Jean-Pierre Roux
2481 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2482 ( e.g : well known GE images with a wrong elem length,
2483 : Philips MRI Images with a wrong Huffman table)
2484 * still to be done : allow the reading of bugged LEONARDO Siemens images
2486 2003-10-03 Jean-Pierre Roux
2487 * Odd length strings are padded with '\0' (not with spaces,
2488 to remain compliant with already defined strings,
2489 like Transfert Syntax UID and others)
2491 2003-10-03 Jean-Pierre Roux
2492 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2493 to allow displaying RGB images (not only by affim ;-)
2495 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2496 * vtkGdcmReader is now able to read rgb dicom file.
2497 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2499 2003-10-03 Jean-Pierre Roux
2500 * A few nasty patches to allow the reading of a lot of nasty images
2501 ( e.g : well known GE images with a wrong elem length,
2502 : Philips MRI Images with a wrong Huffman table)
2503 * still to be done : allow the reading of bugged LEONARDO Siemens images
2505 2003-10-03 Jean-Pierre Roux
2506 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2508 2003-10-03 Jean-Pierre Roux
2509 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2510 to allow displaying RGB images (not only by affim ;-)
2512 2003-10-03 Jean-Pierre Roux
2513 * gdcmFile::GetImageDataIntoVector now
2514 - deals with MultiFrames MultiFragments Run Length Encoded files
2515 - deals with YcBcR (YBR_FULL) files
2516 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2517 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2519 (no sample found :-(
2521 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2522 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2523 Two reasons: - clear things
2524 - third parties acces gdcm through header files, so won't
2525 suffer anymore VC++ complains
2527 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2528 * add argv[1] in testvtkGdcmReader.cxx
2531 2003-09-24 Jean-Pierre Roux
2532 * The lines are now eigthy characters long.for
2533 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2535 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2536 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2537 char* to std::string. Thus, the use of strdup becomes useless. (see
2538 previous commis of Malaterre)
2539 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2540 before the last Malaterre's commit.
2542 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2543 * This commit should fix the Debug building under VC++, the problem
2544 was mainly a mixture of debug and release lib being loaded at startup.
2545 * I also remove a depency to a specific C function: strdup. Because I had
2546 to force the link to msvcrtd (whereas strdup is in libc).
2548 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2549 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2550 located in the gdcmCommon.h file. All use of reference of tha has been
2551 changed to now use the variable GDCM_UNFOUND.
2553 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2555 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2556 Dicom dictionary. The test suite can now be run again. Note:
2557 I'm note very happy with the " (RET)" changes. I believe this
2558 RETAINED comment should be dropped when parsing the dictionary.
2559 - PACKAGER corrected
2561 - AUTHORS updated and now in alphabetical order
2562 * Makefile.am now exports gdcm.dsw for Windoze users.
2564 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2565 * cygwin complains about missing std:: in subdir Test/
2567 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2568 * remove some methods that are now in gdcmHeaderHelper
2570 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2571 * vtkGdcmReader set spacing and origin correctly
2573 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2574 * Fix a few delete/delete[] mismatch
2576 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2577 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2578 interpretation to data given by gdcmHeader. For instance there are
2579 heuristics to get informations (look at different places).
2580 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2581 sorting DICOM images based on different strategies.
2582 * modified Makefiles accordingly.
2584 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2585 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2586 when building in debug mode
2587 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2588 src/win32/gdcmdll.dsp
2589 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2591 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2592 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2595 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2596 * src/win32/libgdcmjpeg12.dsp was not dos format
2597 * src/win32/libgdcmjpeg12.dsp :
2598 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2599 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2601 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2602 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2604 * src/gdcmFile.cxx : bug fix in affectation type
2605 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2606 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2607 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2608 symbols... future problem ?
2610 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2611 * src/win32/libgdcmijpeg12.dsp was missing
2612 * modified gdcm.dsw accordingly
2614 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2615 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2617 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2618 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2619 commit of JPR (before his hollidays to facilitate our work).
2620 * setup.py : bug fix in code. Modifications made while the last commit
2621 of JPR. The code hasn't been tested before the commit... it's so
2622 useless to make that (for best programmer that is JPR) !!!
2624 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * tagged the current version as Version0_3 (i.e. version 0.3)
2627 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2628 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2629 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2630 * *.dsp : modifications to use new libgdcmijpeg8 library
2631 * setup.py : bug fix on VTKPATH variable
2632 * PACKAGER : adding all concerning windows
2634 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2637 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2638 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2639 test suite reported error.
2640 * PACKAGER file added (describes what a packager must do when
2641 packaging a new release).
2642 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2643 * configure.in: upgraded version number to 0.3.0
2644 * fixing build of rpm (through rpm -ta):
2645 - Doc/Makefile.am exports proper doxygen files
2646 - src/jpeg/libijg8/Makefile.am exports the include files.
2648 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2649 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2650 * src/gdcmHeader.h : formatting code
2652 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2653 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2654 We were obtaining error message from vtk. Now, creation of file list
2655 is made in an internal list to prevent this problem.
2656 Bug fix when output is empty.
2657 Bug fix in update of progress value. Previous commit for this was a bad
2659 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2661 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2662 * src/gdcmHeader.h : added method to get the file name
2663 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2664 files. Added method to remove all files on the input
2665 Added FIXME comment concerning the bad parsing of header made by
2666 ExecuteInformation method (in ExecuteData method)
2668 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2670 when using make instal.
2671 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2672 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2674 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2675 * setup.py : adding include dir of jpeg lib to compile all sources
2676 * */Win32/*.dsp : JPR fix for windows compilation
2678 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2679 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2681 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2682 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2684 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * setup.py is again effective on un*x (takes into account the
2686 addon of the jpeg library)
2687 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2688 * Doc/Doxy* updated (includes above enhancements)
2689 * INSTALL now points to web documentation
2691 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * src/gdcmHeader.h doesn't make unnecessary reference to
2694 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2696 * src/gdcm*.[cxx|h] :
2697 - to allow compilation with gcc 3.x
2698 -- clean up of STL usage (added explicit usage of std::)
2699 -- small fixes on exceptions.
2700 Note: linking not tested !
2701 - clean of doxygen comments to avoid warnings at documentation
2703 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2704 dependent convertion).
2706 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2707 * Clean up of previous JPR garbage commit (not even commented in the
2709 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2710 - moved all jpeg related files from src to src/jpeg/libijg8, with
2711 addition/modification of Makefile.am and configure.in.
2712 - the testSuite is still brain damage (not guilty).
2714 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2715 * WrapVTK.py : modifications to get correctly vtk source files to
2717 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2718 (FileName -> Filename)
2720 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * vtk/vtkGdcmReader.[cxx/h]:
2722 - UpdateProgress method should now be effective
2723 - removed the limitation on having only images loaded (as opposed
2725 - when building a stack of images/volume, a lesser number of
2726 gdcmHeader and gdcmFile instances should be used (hopefully
2727 accelerating things).
2728 - when building a stack of images/volumes, files which are not
2729 loadable (wrong path-filename, wrong permissions on existing file,
2730 or file not parsable by gdcm) are replaced with a black image
2731 in the stack (for the caller to notice the problem).
2733 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2736 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2737 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2738 between standard library (std) and vtk library (problems are found
2739 under Windows... thanks Windows !)
2741 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2744 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2746 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2749 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * When compiling with distutils (see setup.py) the C++ compiler is
2751 called with different flags than the default ones (with automake).
2752 In order to fix all those warning, I compiled gdcm with the command
2753 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2754 and went for warning fixes:
2755 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2756 up from unused variables.
2757 - vtk/vtkGdcmReader.cxx: potential bug fix.
2758 * src/gdcmHeader.h: Doxygen warning cleanup
2760 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * gdcmPython/gdcm.i:
2762 - typemaps correction to take into account the systematic replacement
2763 of "using namespace std" with std:: prefix e.g. std::list,
2764 std::string... (cf changes of 2003-05-21).
2765 - gdcmGlob global variable of type gdcmGlobal (defined in
2766 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2767 exported to Python a as cvar.
2768 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2769 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2770 gdcmDictSet.GetPubDictTagNames() and
2771 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2772 C++ static methods).
2773 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2774 with the above changes.
2776 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2777 * setup.py, manifest.in : bug fix under linux
2779 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2780 * Modification of setup.py to compile vtk part too. Then, we have 2
2781 wrappers which must work with same distutils. For that, we have a
2782 generic distutils in distusiltsWrapping.py ; with :
2783 - build_extWrap class to wrap generically all extensions,
2784 - ExtensionWrap base class for all wrapping extension that contains
2786 - Wrapper interface which wrap sources
2787 + In WrapSwig.py we have extension and wrapper for Swig
2788 + In WrapVTK.py we have extension and wrapper for VTK
2789 * MANIFEST.in : modifications to consider vtk directory and new python
2790 files for compilation
2792 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2793 * Added python wrappers of vtkGdcmReader vtk class (see the
2794 source in vtk/vtkGdcmReader.cxx) :
2795 - vtk/Makefile.am now builds a library
2796 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2797 python library (as opposed to _gdcm.so wich are the python
2798 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2799 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2801 - configure.in has an additional flag --enable-vtk that needs
2802 to be set to enable compilation of vtk related code, that is:
2803 + vtk/vtkGdcmReader.so and
2804 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2805 + gdcmPython/vtkgdcmPython.so (see above)
2806 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2807 be read when compressed or when HighBit + 1 != BitsStored),
2808 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2809 the usage of the python wrapper of vtkGdcmReader vtk class.
2810 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2811 * src/*.[h] all occurences of stl classes are now prefixed with
2812 std::, and all occurences of "using namespace std;" where removed.
2813 This is to avoid pollution of global namespace in included files.
2814 Apparently vtk does not avoid this pitfall: when using both
2815 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2816 collision of various stl members (principally cout...).
2817 * gdcmPython/testSuite.py now cleanly removes temprory generated
2819 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2820 comply with above changes)
2822 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2823 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2824 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2825 vtk data structure (an image Flip was required).
2826 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2827 * cosmetic changes in documentation.
2829 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2830 * src/gdcmHeader.cxx: the constructor no longer exits when an
2831 unexisting file is given as argument.
2832 * The subdirectory Data (containing all the images used for the
2833 test suite) is not part of this repository anymore. A new module
2834 containing those images is now available at
2835 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2836 with the name gdcmData.
2837 All the python scripts (including the package initialisation file
2838 gdcmPython/__init__.py) were adapated to take this change into
2839 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2841 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2842 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2843 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2844 demo of the usage of this class.
2845 Compilation of this vtk part is only done when using the --enable-vtk
2846 at configure (or autogen.sh) stage.
2848 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2849 * More memory link related corrections and documentation fixes.
2851 - maximum info is obtained with a command of the form:
2852 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2853 --show-reachable=yes PrintHeader
2854 - the remaining reachable blocks seem to come from the STL
2855 allocation scheme through the usage of map and list. It looks
2856 like this memory cannot be freed but it is not a memory leak
2857 (in fact further invocation to the STL would recollect the
2858 unused memory allthough it cannot explicitely be freed).
2859 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2860 of displaying an image parsed with gdcm and displayed with VTK.
2861 Note: some images don't seem to work e.g.
2862 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2863 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2864 Allthough this weakens the semantics, it is a ditch attempt to
2865 make gdcm more thread friendly.
2867 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2868 * Memory link hunt (by using valgrind through the command
2869 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2870 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2871 gdcmHeader::_dicom_vr.
2872 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2873 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2875 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2877 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2878 * src/Makefile.am now exports all the necessary include files at
2882 * UpdateGroupLength replaced by new one
2885 * UpdateGroupLength re-written using H-Table
2886 (named UpdateGroupLengthNew untill checks are over)
2888 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2889 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2890 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2892 - gdcmHeader::GetPubElValSet removed.
2893 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2894 UpdateGroupLength, WriteElements, Write.
2895 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2896 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2897 carried the same semantics.
2898 - src/gdcmHeaderIdo.cxx changed accordingly.
2899 - gdcmFile::WriteBase now regroups all the codes from previous
2900 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2901 - enum FileType moved to gdcmCommon.h
2902 * src/gdcmHeader.cxx AddDefault trashed
2903 * gdcmGetXSize added
2904 * getimageDataSize now calls gdcmGetXSize
2905 * Test/*.cxx changed to agree with above changes
2907 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2909 (to avoid double call by end user).
2910 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2911 by end user, since gdcmHeader::gdcmHeader now handles it.
2913 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2914 * gdcm/Doc many doxygen changes:
2915 - Doxyfile now has two different versions, DoxyfileUsers that generates
2916 the html.users end users oriented documentation and
2917 DoxyfileDeveloppers that generates the html.developper developper
2918 oriented documentation.
2919 - README changed accordingly
2920 - requirement.txt removed (old design info moved to TODO).
2921 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2922 DoxyMainPage.txt, DoxyPython.txt provide more information.
2923 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2924 be updated by simply regenerating the docs with doxygen and copying
2925 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2926 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2927 all the tests in the form "if (<map>.count() >1)" were removed.
2928 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2929 ill-formed documentation sections.
2930 * src/gdcmHeader.cxx: ditto
2932 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * setup.py fixed for un*x (needed macro for stdint.h)
2934 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2935 un*ces with sh-utils test utility.
2936 * gdcmPython/demo/test.py renamed to PrintHeader.py
2937 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2938 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2939 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2940 * src/gdcm*.cxx JPR's bad inclusion fixed.
2942 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2944 * gdcmPython/demo/test.py changed accordingly.
2946 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2947 * gdcmPython/Makefile.am fixed linking against libstdc++
2948 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2949 * Swig subdir (historical tests of swig version 1.3.17++) removed
2950 * Test/testChangeEntete.cxx some lines commented out in order to make
2952 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2953 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2955 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2957 hence the user doesn't need this explicit call.
2958 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2959 i.e. LoadElements() call removed.
2960 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2961 - src/Makefile.am declares the proper flag for g++.
2962 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2963 for adding user defined new tags.
2964 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2965 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2966 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2968 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2969 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2970 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2971 src/Makefile.am : the project should properly compile and install
2972 with the autotools, included the python wrappers part.
2973 * gdcm.spec.in : added a spec file for RPM packaging.
2975 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2976 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2978 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2979 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2980 to exported to the environement (see gdcmPython/testSuite.py
2982 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2983 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2984 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2985 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2986 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2988 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * gdcmPython/__init__.py doesn't crash anymore when running in
2990 in InstallMode or PreInstallMode but with an environment given
2991 value of GDCM_DICT_PATH.
2992 * src/gdcmDictSet.[cxx/h] coding style.
2994 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2996 * src/gdcm.h general comments moved to TODO, and README
2997 * src/gdcm.h should now be seen as a user commodity (including it
2998 should suffice to fully use gdcm). It is nowhere including within
2999 any of the kernel files src/*.cxx and src/*.h.
3001 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3002 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3003 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3005 * src/gdcm*.cxx only include their corresponding include file
3006 (as opposed to gdcm.h)
3007 * gdcmPython/gdcm.i changed accordingly
3008 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3009 the autogen.sh generated "make snapshot" command to work.
3010 * autogen.sh removed history related references to crea package.
3012 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3013 * distutilsSwigCPlusPlus.py work around some swig portability
3016 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3017 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3018 was done in a last ditch attempt to get setup.py _really_
3019 operationnal. The python/gdcmPython layaout add the advantage
3020 of hidding away the python related distutils specific files
3021 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3022 Alas, the src directory was out of scope (i.e. it's relative
3023 position to setup.py was ../src) which made things impossible to
3024 handle (see previous version of python/setup.py). Crossing fingers...
3026 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3027 * python/setup.py now works on Un*x. (harder than I thougth)
3028 * python/distutilsSwigCPlusPlus.py can now have include files
3029 among the list of sources.
3031 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3032 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3033 * modifications in MSVC projects
3035 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * As stated by the first lines of Test/ExceptionAndPython/README, it
3037 looks like we can move back to original usage of exception within
3038 src/gdcm* and hence remove the errno stuff that was introduced
3039 as a quick and dirty fixture of this problem (added to the TODO).
3040 * Doc/Doxyfile configuration file for Doxygen and corresponding
3041 README file for usage added.
3042 * Test/testWrite.cxx added. This new test comes from a split of
3043 test.cxx that is now reverted to its original purpous i.e.
3044 testing the proper parsing of a Dicom related file.
3045 testWrite.cxx concentrates on testing the IO part of gdcm.
3046 * Test/bug1.cxx (containing a bug on WIn32) added.
3047 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3048 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3049 whose purpose is to publish the content of the TagNames of the
3050 Dicom public dictionary were not accessible without an
3051 instance of class gdcmHeader.
3052 - those methods are now static methods of gdcmDictSet and hence
3053 require no instances at all to be invocated.
3054 - within gdcmDictSet this change required to change some method
3055 to class methods (i.e. are now static) among which SetDictPath
3056 (renamed to BuildDictPath) and LoadDefaultPubDict.
3057 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3058 the above changes by calling the new method classes of gdcmDictSet.
3059 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3060 the above to be effective.
3061 * python/gdcmPython: in order to wrap properly the above changes
3062 for Python, swig version now needs to be > 1.3.17.
3063 * python/gdcmPython/Makefile fixed to adapt itself to new
3064 configure/make shema introduced by Johan Montagnat (thanks for the
3065 contribution). Alas this Makefile cannot be turned into a proper
3066 Makefile.am without some heavy changes in the configure.in
3067 (for python dectection).
3068 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3069 now avoids publishing the empty entries.
3071 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3072 * python/setup.py : bug fix concerning install under windows
3073 ExtraPath reused :-P
3074 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3076 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3077 * Dicts/dicomV3.dic : remove double spaces !!!
3078 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3079 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3082 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3083 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3084 method. Doxygenation.
3085 * src/gdcm.h clean up of JPR spurious comments.
3087 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * python/distutilsSwigCPlusPlus.py now properly collects the
3089 shadow classes generated by "swig -c++" (gdcm.py in our case)
3090 when using "python setup.py install".
3091 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3092 reexports the working classes.
3093 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3094 by the classical C errno scheme. This is to prevent an obscure
3095 behavior of the python wrappers when importing wxPython.wx prior
3096 to gdcmPython (which ended up in an abort call). An illustration
3097 of this oddity can be found in the Test/ExceptionAndPython
3098 subdir (see the README file). This problem probably due to
3099 an combination of g++ and dynamic loading.
3100 * added Test/ExceptionAndPython (see above)
3102 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * Changed the layout of the python part to avoid bloating main
3104 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3105 i.e. the distutils arsenal. All the python related stuff is
3106 again in a python subdir, but the package itself is now in
3108 * setup.py was cleaned up:
3109 - pythonIncludePath removed
3110 - python setup.py bdist target is now functional.
3111 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3112 collision with other packages). gdcmPython/demo/*.py changed
3115 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * python subdir moved to gdcmPython (preparation of distutils packaging).
3117 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3118 distutils installer is operational.
3119 * - gdcmPython/__init__.py now properly loads the swig generated
3120 shadow classes (from gdcm.py).
3121 - gdcmPython/demo/*.py changed to import the package gdcmPython
3122 instead of gdcmPython/demo/load.py.
3123 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3125 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3126 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3127 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3128 entries within the associated public Dicom dictionary resp. the same
3129 information but sorted by the fourth field (PAT, IMG, DIR) of the
3131 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3132 are now in the "???" group.
3133 - python/gdcm.i changed accordingly,
3134 - python/demo/printGroupedPublicDict.py added, that gives an example
3135 of the above new functionalities in Python.
3137 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcm.h, gdcmHeader.cxx:
3139 - historic references to glib's g_malloc and g_free (#defined)
3140 were definitively removed.
3141 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3142 * src/gdcmElValSet.cxx:
3143 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3144 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3145 - GetElValue(string) renamed to GetElValueByName.
3146 - Added GetElementByName(string).
3147 * src/gdcmHeader.cxx: added
3148 - GetPubElValRepByNumber(guint16, guint16)
3149 - GetPubElValRepByName(string)
3150 - GetShaElValRepByNumber(guint16, guint16)
3151 - GetShaElValRepByName(string)
3152 - GetShaElValByNumber(guint16, guint16)
3153 - GetShaElValRepByName(string)
3154 - GetElValRepByNumber(guint16, guint16)
3155 - GetElValRepByName(string)
3156 - GetElValByNumber(guint16, guint16)
3157 - GetElValRepByName(string)
3158 * Doc/requirements.txt added.
3160 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * Test/Makefile building now depends on the one of libgdcm.so
3162 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3163 pixel data) aware which enables finding the address (offset) of
3164 the pixel data of JPEG encoded DICOM files. This leaves only a single
3165 file in the testSuite whose pixel data address (offset) is unknown.
3166 * python/testSuite.py changed accordingly.
3168 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3169 * VC++ has some strong limitations when working with the STL, as stated
3170 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3171 "Also note that some STL containers (map, set, queue, list, deque)
3172 cannot be exported. [...]
3173 Some STL classes contain nested classes. These classes can not
3175 This is caused by a designed limitation that once a template
3176 class is instantiated, it can not be re-instantiated and
3178 Since our usage of map<> is ubiquitous in gdcm, this "designed
3179 limitation" of VC++ is a pitfall.
3180 Hence the Python wrappers of gdcm cannot be incrementally linked
3181 against the c++ dynamic library. The dirty but only workaround is
3182 to forget about incremental link of dynamic libraries and to generate
3183 the Python wrappers library with the inclusions of the underlying C++
3185 The following modifications concern this matter on Win32/VC++:
3186 - wrapping python correct with standalone wrapped dll (don't use separate
3187 dll under windows !!!!)
3188 - python21_d debug mode enabled (ask Frog how to use it :-)
3189 - NO problem with having an STL member of class for example string in C++
3190 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3191 - Python test of dcmlib in Python is ok under windows on a large set
3193 * removed glib references
3194 * typedef's inserted in gdcm.i for correct swig type management
3196 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3197 * python/demo/*.py load.py extracted from test.py. Added explore.py
3198 that only displays required tags and testAll.py that parses all
3199 the files of the testsuite without using unittest.
3200 * python/testSuite.py other additional test on new files added.
3201 * Data/* new test files added accordingly to the testSuite.
3202 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3203 the vr in the file differs from the one of the dictionary.
3205 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3206 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3207 values, but limits itself to values which are below a user specified
3208 size (by default 1024 bytes).
3209 * python/gdcm.i : elements not loaded (because their size is above the
3210 user specified treshold) are exported with their TagKey as key of the
3211 python dictionary. This enables the testsuite to make some checks
3212 on the unloaded elements (since we have their offset and size).
3213 * python/testSuite.py
3214 - now tests for the existence and proper value of the pixel data
3215 - two new examples added.
3216 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3218 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3219 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3220 aware. See the strategy comments in gdcmHeader::FindeLength().
3221 * Test/test.cxx now accepts a filename as first argument.
3222 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3223 * python/testSuite.py changed to integrate test on above files.
3225 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3226 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3227 the vr was also RET.
3228 * python/testSuite.py more tests added.
3230 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * python/testSuite.py unittest test suite added (uses Data)
3232 * Data/* dcm and acr files for the test suite.
3233 * glib dependance removed from un*x version. We now use ISO C99
3234 7.18 Integer types (see stdint.h)
3235 - python/Makefile, src/Makefile src/gdcm.h
3236 * src/ when an explicit vr (like dicom files) suddenly poped an
3237 implicit element we use to mark the underlying DictEntry of the
3238 concerned ElValue with "Implicit". This strategy was damageable
3239 too the public or provite dictionaries, since some of their vr
3240 would be changed. Since Header::FindLength heavily relies on the
3241 detection by Header::FindVR of falsely explicit elements, I
3242 added an extra ImplicitVr member to ElValue (boolean).
3243 The rest of the changes we the necessary adaptations.
3245 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3248 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3250 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3251 * Adaptation for porting to VC++:
3253 o forced to use std namespace (for string to be known)
3254 o all class use __declspec export style on WIN32
3255 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3256 (in stdlib.h on Win32 but in std:: for gcc)
3257 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3258 variable GDCM_DICT_PATH.
3259 * src/gdcmHeader.cxx verbose comments made discrete.
3261 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3262 * python/gdcm.i: added a typemap that converts a C++ hashing table
3263 to native Python dictionary.
3264 * python/demo/test.py:
3265 - now uses the native dictionary for exploration of gdcmHeader.
3266 - takes an optional filename argument (the file to parse).
3267 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3268 PubElVals hashing table.
3269 * Dicts/dicomV3.dic removed error prone trailing spaces.
3271 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * Python wrapping process moved away from src/Makefile to
3273 newly created python/Makefile (as well as gdcm.i)
3274 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3275 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3276 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3277 from the environement variable GDCM_DICT_PATH (when existing).
3278 * src/gdcmDict::GetTag bug fix.
3280 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * Straightforward temporary fixes for swig to build the python wrappers.
3282 src/Makefile now has a python working entry [by working we mean
3283 that we can import de shadow classes without errors].
3285 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * hashtest.cxx removed (since already in Test)
3287 * src/gdcmlib.h renamed to src/gdcm.h
3288 * src/dcm.i renamed to src/gdcm.i
3289 * src/Makefile prepared for python wrapping
3291 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3292 * src/gdcmHeader.cxx :
3293 - Parsing of header is now separated from loading of element values
3294 (see gdcmHeader::LoadElements).
3295 - general clean up of hopefully all file access (creation of
3296 ReadInt16 and ReadInt32)
3298 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * src/gdcmHeader.cxx :
3300 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3302 - SetLgrElem renamed to SetLength
3303 - GetLgrElem renamed to GetLength
3304 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3305 * src/gdcmElValSet.cxx fixed both GetElValue methods
3306 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3307 due to IdoDude was cleaned out.
3309 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3310 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3311 concentrates on finding the value representation (when it exists).
3312 RecupLgr now only finds the element value length, and it avoids
3313 returning the unecessary skL (skipped length).
3314 Also, offsetCourant was simply removed (with taille_fich) since
3315 it was redundant with the File position internals (by using
3316 ftell and fseek). This also made skL (see above in RecupLgr) usage
3318 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3319 on the libido specificities which are handled through class
3321 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3324 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3325 * Truckload of changes. Parsing of header is barely functional
3326 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3328 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3329 * src/gdcmHeader.cxx many addons of low level methods
3331 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3332 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3333 and _IdDcmSWAP_LONG.
3335 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3336 * This corresponds to all the changes decided at the meeting of
3337 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob