1 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
3 conversion of YBR to RGB pixels. So, now, the conversion is made using
6 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
8 format) to replace 'at-run' dicom files generated by the
9 TestAllReadCompareDicom test
11 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
14 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
17 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Testing/TestMAkeIcon.cxx : complete the test
20 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
23 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
27 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
30 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * Test/ : accelerate tests (it's not very significant accelerations).
32 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
34 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * Testing/TestSequence.cxx : add test for sequences of images... test that
36 we have the same serie or the same study UID
38 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
41 * src/gdcmDict.h : remove commented code
42 * src/gdcmDocument.cxx : initialize values
43 * src/gdcmFile.cxx : bug fix when reading values
44 * gdcmPython/demo/ : change file names. Remove useless files
46 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmFile.cxx : remove the default array of initialization.
48 The static array contained pointers to non-static values (comming from
49 strings). To have coherences, when creating files, these values can't be
50 static. So, the array can't be static, too ! To simplify, the array have
51 been replaced by repeted lines to insert values in the File
53 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
55 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
57 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
59 (Dicom Element) into the Sequence Item
61 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/*.cxx : first parss to normalize file organisation
64 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmDirList.[h|cxx] : add method to find a directory
66 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
68 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
69 * Finish cleaning up my JPEG mess. Should be ok now.
70 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
71 contained within the RLE* class(doh!)
73 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
74 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
75 * SerieHeader::AddFileName() creates as many Coherent Files lists
76 (same Serie UID) as it founds different Serie UID
77 amongst the files instead of discarting any file
78 that doesn't match with the first one he found.
79 * SerieHeader::OrderGdcmFileList has now one parameter :
80 the Coherent Files list the user wants to sort
81 * SerieHeader::GetFirstCoherentFileList() |
82 * SerieHeader::GetLastCoherentFileList() | allow to parse
83 the set of Coherent Files lists
84 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
85 compatibility (it returns the *first* Coherent Files list,
86 since there was only one before)
87 * Test/TestSerieHeader gets gdcmData as a default root directory
89 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Remove friend between DocEntry and File classes
91 * Remove friend between PixelReadConverter and RLEFramesInfo,
94 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
96 0002|0000. The value was incorrect.
98 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
101 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmUtil.cxx : compilation fix on Win32
103 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
104 variable, to be easy found. Add methods to change the default UID.
105 Amelioration of the CreateUniqueUID to use the correct default UID.
106 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
109 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * Test/TestVR.cxx : fix memory leaks
112 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
113 * Rewrite the base 256 to base 10 conversion, using string operation only.
114 This allows us to get rid of the problematic 64bits integer type (does not
115 always exist on target platform).
117 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
118 * Add construct and destructor to class gdcm::Debug to close the debug file
120 * Don't let uset to open twice the same file
121 * gdcm has now an official UID prefix,
122 supplied by http://www.medicalconnections.co.uk
123 1.2.826.0.1.3680043.2.1143
124 (Thx to Mathieu for providing URL)
125 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
126 to be able to perform some more tests
127 * gdcm::ContentEntry : Contructors and Destructor are now protected,
128 in order to be sure no user will try to use them.
129 (at user level, only the children classes are meaningfull)
131 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * move RLEInfo & JPEGInfo from Document to File
134 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * FIX : remove so many friend between classes
137 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
139 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
141 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
142 In order to avoid missbehaviour :
143 . gdcm::DocEntry is now specialized in
144 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
145 - gdcm::ContentEntry (Dicom entry with a 'content')
146 . gdcm::ContentEntry is specialized in
147 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
148 characters value, or integers)
149 - gdcm::BinEntry (Dicom entry with a non strig representable value
150 (user hasn't any longer to thing about the precedence of his dynamic_casts)
152 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * Test/VTKTest*.cxx : bug fix under linux
155 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
157 use with python. Some methods are moved from Document to ElementSet or
158 DocEntrySet. The equivalent methods to ElementSet have been added to
159 SQItem and are virtual in DocEntrySet. Methods that may have the same code
160 in SQItem and ElementSet is directly placed in DocEntrySet
162 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * Test/VTKTest*.cxx : remove the show variable in each test method because
164 it's useless (the viewer variable replace this variable)
166 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDocument.cxx : bug fix on potential memory leak
168 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
169 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
170 Add ClearXxx methods to remove all the content of the list or map
171 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
173 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 * methods ReplaceOrCreate renamed as Insert
175 (nobody will be any longer confused by 'CreateOrReplace')
177 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
178 * Grealty simplify the JPEg decompression, no need to differenciate based on
179 the JPEG possible type (with/without fragment, with/without multiple frame).
180 Everything is done throught the JPEG IO Suspension mechanism in IJG
182 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 * Stage 3 of normalization :
184 in order to avoid any missunderstanding while reading method names :
185 - All the methods xxxEntry now deal with dicom Entries
186 - Methods GetEntry splitted into
189 - Method SetEntry renamed as SetEntryValue
190 - Method SetEntryBinArea let as it was
192 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
193 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
194 - Position correctly the entry points for JPEG2000 and JPEG-LS
195 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
197 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
199 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
200 with other method names
201 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
202 * Test/TestDicomDirElement.cxx : add new test
204 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
205 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
206 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
207 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
208 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
209 So can't you use __int64 in ostream at all.
211 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * bug fix for compilation on MSVC6
213 * gdcmPython/gdcm.i : rename of classes missed
215 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
216 * Stage 2 of names normalization :
217 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
218 (easy to understand ...)
219 - gdcm::FileHelper replaces old class gdcm::File
221 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
223 type and not a string. So, there remove problems on the format of the
226 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
227 * Add Example/TestPapyrus.cxx
228 - reads a Papyrus file (gdcm::Header compliant),
229 - gets the pixels of all the images, using low level iterators
230 - writes an multiframes Dicom image.
231 (Just to show it's *possible* to do that)
232 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
235 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
237 Thus, DicomDirXXX are created with a flad that indicates if the created
238 object is empty or not (when not empty, the DicomDirElement is used to
241 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
243 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
245 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
248 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
250 Remove all access to the hash-tables or lists in the objects.
252 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
254 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
255 be complient with all the gdcm source code
257 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
261 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
265 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * Test/ : rename VTK tests to have a best name for the tests
267 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
268 GetFirstEntry/GetNextEntry use
270 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
271 * In SerieHeader::ImagePositionPatientOrdering()
272 // a Dicom 'Serie' may contain scout views
273 // and images may have differents directions.
274 // -> More than one may have the same 'pos'
275 // Sorting has then NO meaning !
276 Thx to Eduardo Davila for reporting bug.
278 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
280 test. Now it's on image content and not on the resulting visualisation...
281 might solve the problem on linux when using the OpenGL drivers
283 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
284 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
285 DicomDirSerie, DicomDirImage
286 Dict, DictSet classes :
287 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
288 -remove InitTraversal method.
289 * UPD Test programs + Example programs
291 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * remove useless and never updated keyword \ingroup
293 * Solve pb when structure (list, map, ...) is empty.
294 Thx to Benoit for reporting bug
296 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
297 * Taking into account of 'Transfer Syntax' value
298 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
301 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
303 is no memory access violation
304 * gdcmPython/demo : add python demos using VTK
306 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
307 * FIX 'Dictionnary' is now spelt 'Dictionary'
308 'wether' is now spelt 'whether'
309 'archieve' is now spelt 'archive' ;-)
311 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
312 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
313 related methods, in order not to expose internal mechanisms
316 * REM methods that exposed internal mechanisms :
317 DicomDir::GetDicomDirPatients()
318 DicomDirPatient::GetDicomDirStudies()
319 DicomDirStudy::GetDicomDirSeries()
320 DicomDirSerie::GetDicomDirImages()
321 * UPD Test programs :
325 * UPD Example program
327 * ADD DictSet methods
331 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Removed the Print/indent/default parameter mess. There is absolutely no
333 reason to have to methods, moreover with the second taking the ostream as
334 *SECOND* parameter. This was clearly a bad hack to get things compile.
336 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
337 * Complete rewrite of the GetMacAddress code. Now the code is *much*
338 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
339 Unfortunately the main code does not work on SunOS, thus provide a specific
340 code for this platform only (and Win32 of course). Since this seems to be
341 working, change CreateUniqueUID to use GetMACAddress instead of the
342 problematic GctestetIPAddress
344 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Unfortunately to be able to test gdcmDirList I had to break the API
346 a little. Now the class is not a std::list anymore but has a member
347 std::vector (more ITK compatible). Allow unit testing on Win32 and
350 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Update SerieHeader to take into account a Serie Instance UID to properly
354 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
355 * ENH - Comment out Mathieu's (dangerous) Super Hack
356 for dealing with BIGENDIAN processors
357 - Move equivalent stuff to BinEntry::WriteContent
358 When necessary, 16 Bits Pixels are swapped in a small buffer
359 and then written. This avoid allocating a huge buffer, in
360 PixelWriteConvertor, and avoid modifying the Pixel Area.
362 Probabely, the same operation will have to be done when we want
363 to write image with Big Endian Transfert Syntax,
364 and we are working on Little Endian Processor
366 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
369 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
370 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
371 all the dict content.
372 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
374 * Test/TestDict.cxx : add a new test for the dict classes
376 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
378 file. Debug is yanked if compiled with NDEBUG
380 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * src/gdcmDictSet.h : set the default output to the os variable
382 * src/gdcmDictEntry.[h|cxx] : add the Print method
383 * gdcmPython/demo/ : add a new test
385 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
386 * merging of Test/PrintDicomDir and Test/TestDicomDir
387 * removal of now redundant Test/PrintDicomDir
388 * enhancement of Example/PrintDicomDir
390 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * Now, python test might work on systems
392 * Add the PrintDicomDir test
394 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
395 * FIX : First entry following group 0002 was lost for
396 Explicit Big Endian Transfer Syntax files
397 (group and elem not swaped)
399 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
400 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
401 Big Endian Transfer Syntax supposed the group following 0002
402 begins always by element 0000 (element 0000 is *optional*)
403 To avoid further troubles, let's be pessimistic, and use
404 Document::HandleOutOfGroup0002() method
405 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
406 (related pb not yet solved)
408 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * Bug fix for the python part use
410 * Now, PrintHeader.py pass... but outside the ctest use. shit !
412 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
415 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
417 a string and should ask the global TS dict what are the propreties of
420 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
421 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
422 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
423 to swap the Swap Code, at parsing time, when we come out of group 0002
424 and Transfer Syntax is Big Endian
425 We should be able to read now 'true DICOM" Big Endian coded images
426 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
427 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
429 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 * Hopefully fix the bug on MacOSX and static global initialization.
431 This is the only -minor- patch I found that both please MacOSX and VS6.
432 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
433 but this would require a lot of change. Another approach would be that Global
434 create those string and GDCM_UNFOUND becomes a pointer to a string (which
435 gdcm::Global would destroy at exit).
437 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
438 * Fix bug on MacOSX with static initialization in a multy threaded
439 environment. static const string in a header file used to be ill
440 initialized provoquing the freeze of any tests. patch should solve this
443 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
444 * According to Benoit's suggestion, and without any objection from anybody
445 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
446 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
447 - method gdcmDicomDirObject::GetEntry() renamed as
448 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
450 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
451 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
452 you debug/warning message just as c++ streams which make them very convinient
453 to use. Once this is stabilize I will change the ostringstrem to be
454 redirected to a file (ofstream).
455 * Properly support C99 extension: __FUNCTION__ which allow us to display
456 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
458 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
459 * Removal of useless and dangerous methods :
460 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
461 GetDocEntryByName, GetEntryByName, GetDictEntryByName
462 * Removal of usless methods :
463 Dict::PrintByName, Dict::GetDictEntryByName
464 * Commenting out of probabely useless methods :
465 Dict::GetDictEntryNames()
466 Dict::GetDictEntryNamesByCategory()
467 DictSet::GetPubDictEntryNames()
468 DictSet::GetPubDictEntryNamesByCategory()
469 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
470 * ENH : Use dicomTS.dic as described in 2004 version
471 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
472 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
473 Add Accessors on VM (Value Multiplicity), and VM related methods
474 * ADD : Add a list of 'Dicom Attribute types', as found in
475 http://medical.nema.org/dicom/2004/04_15PU.PDF
477 * ADD : Add dicomGroupNameAbbreviations.dic
478 should be used to write a method to replace the former
479 Dict::GetDictEntryNamesByCategory()
481 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
483 to read in the file... and only it ! Length is the efective length of the
484 data in the DocEntry structure
486 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
488 And now use a static function call instead, with a global variable. i
489 This is much closer to the VTK approach. Hopefully should be bulletproof
490 and easier to use...hopefully
492 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
493 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
495 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
498 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
500 ValEntry, BinEntry, SeqEntry creation or replace
502 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
504 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
506 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
507 when specifying the VR
508 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
509 * src/gdcmDocEntry.cxx : amelioration of print
511 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
512 * ADD : Add the method Util::IsCurrentProcessorBigEndian
513 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
514 * ADD Method Document::ComputeGroupLength
515 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
516 in order to allow further VR modification by user
517 * REM : removal of once-called method File::WriteBase
518 integration of its code in formerly one-line method File::Write
520 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
522 replace the different values "??", "Unkn", "Unknown".
523 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
524 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
525 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
526 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
528 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
531 * Set the gdcm::Base class to some Printable classes
533 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * src/gdcmFile.[h|cxx] : add the Print method
535 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
536 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
537 * src/gdcmDocument.h : remove the PrintLevel informations
538 * Example/PrintFile.cxx : use the new gdcm::File::Print
540 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
542 problems when compiling with the python wrapping
544 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
546 writting in ImplicitVR
548 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
549 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
550 JPEG decompression, especially when dicom frames are split into several
551 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
552 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
554 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmHeader.cxx : change the initialisation of default header.
556 Now, this header is readable by gdm, e-film, DicomWorks
558 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
560 Rename Decompressed to Raw
561 * Use the API changes in gdcm::File.
562 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
565 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
567 each added entry in the header. Replace the 'Planes' field by the 'Number
570 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
572 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
574 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
576 At this time, this image isn't readable by e-film... waiting JPR help to
579 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
581 DocEntry. Now use methods of the Document !
583 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * Test/ShowDicomSeq.cxx : bug fix
586 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
588 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
589 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
590 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
592 * Test/TestCopyRescaleDicom.cxx : remove unused variable
593 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
594 containing found sequences
596 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
599 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
600 Some fields in BinEntry must be copied to not seg fault when making the :
601 gdcm::File *copy = new gdcm::File( copyH );
602 and tests are now made on good variables
604 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
606 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
608 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
609 * Add vtkGdcmWriter example and test
611 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * Test/TestUtil.cxx : reformat the source code
613 * vtk/vtkGdcmReader.cxx : remove and change prints
614 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
616 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
617 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
619 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
620 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
621 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
623 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
625 by an eof to prevent all bad read of the file... and in this case, the
628 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Example/Volume2Dicom.cxx : comment unused variables
630 * Test/PrintDicomDir.cxx : comment unused variables
631 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
632 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
633 method that is redondant with AddEntry.
634 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
637 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * Bug fix due my last commit (compilation under Windows).
639 * Example/Volume2Dicom : bug fix in the file and reformatting source code
640 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
642 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
644 - Remove printf / sprintf
645 - include iostream AFTER gdcm so we don't get warnings
646 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
648 - Also remove tons of include from header files, hopefully this should
649 speeup the compilation time, since it was becoming a dog slow.
650 - Remove gdcm.h as it include way too many files and slow down compilation
651 (plus it is not up to date)
652 - remove 'using namespace std' this is BAD !
654 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * Remove memory leaks on the DicomDir
656 * Remove some useless data in DicomDirObject
657 * Add usefull methods in SQItem, to be complient withe the ElementSet
659 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
662 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
664 future, with convertion)
665 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
666 and ImageDataSize values. Remove the method to get the PixelReadConverter
667 from the output of the class
669 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
670 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
672 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
674 and vtkErrorMacro use.
675 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
677 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
680 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
681 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
682 The string leaves only in the fonction. So when we make a .c_str(), we
683 get the pointeur on the first element, element that will be destroyed
684 immediately after thee instruction.
685 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
686 file has been opened : the test must be made on the content of the
687 pointer and not directly on the pointer !
690 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
692 the python part recompiles
694 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
696 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
697 X session is killed (for my computer... it seems to not be identic on
700 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
702 avoid problems (otherwise, the difference test between the visible image
703 and the reference is incorrect. If the reference is greater than the
704 screen resolution, it's produce errors).
705 Can be used for only one image. Can be used with a visible flag.
706 * vtk/vtkGdcmReader.cxx : remove commented codes.
707 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
708 under windows at compilation
709 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
711 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
713 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
714 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
715 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
716 tests on the image size X, Y, Z
718 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
720 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
721 between the class name and the file name
723 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * src/ : fix compilation warnings for the Write method (2 different
725 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
726 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
727 variable... create a static method in gdcm::Document to access to
728 this variable content.
730 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
732 file, to be accessed by other files (like gdcmFile). Remove commented
733 code. Move the change of the header to the gdcmFile, using the
735 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
736 To be sure of that (and simplify calls), the Write of the header now
737 gets a file name and not a file pointer (std::ifstream).
738 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
739 DocEntryArchive. Remove all open of the written file
741 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
744 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
746 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
748 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
749 some corresponding methods. Write correctly the file and check before
751 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
752 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
753 is now on RGB data (as before my last commit
754 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
756 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
757 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
758 Add a print information of the type of the entry
759 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
760 It was in the gdcmFile, and all write have been regrouped
761 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
762 Write correctly all dicom files (in decompressed mode only at this time)
763 * Test/ : test on files are now made using Raw data and not color data if
765 * Example/PrintFile.cxx : add more printings
767 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
768 * Amelioration of code, remove some code copy. For the loading of
769 BinEntry (in gdcmDocument), add the test to verify if the file is already
772 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
774 remove a DocEntry in the header (push an empty DocEntry)
775 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
776 lines. Bug fix in the initialization of the PixelConvert and the
778 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
779 use in TestCopyDicom (now this test can run under windows... but fails)
780 * Test/TestCopyDicom.cxx : amelioration of the test :
781 - test the pixels written
782 - add test points to quickly find where is the error
783 - can set a file name input and output in arguments
784 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
785 amelioration of the test output
787 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
789 all replaced DocEntry's
790 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
791 Now, each needed DocEntry to modify is duplicated, modified and inserted
792 to the header using DocEntryArchive. Thus, after save, we can restore the
793 header initial state.
795 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
798 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
800 correct to copy it. The DictEntry is specified at the DocEntry creation,
801 then, it musn't change in the time.
802 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
803 header correctly. At this time, the change is only made for the first
804 level of the Document. In the future, it might consider sequences.
805 The change is made by replacing a DocEntry by an other that is created
806 outside the class. The old value is kept. When we restore the header
807 status, the added DocEntry is deleted and replaced by the old value.
808 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
809 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
810 set the write type to explicit VR, implicit VR or ACR. Add methods to set
811 the write mode to native, decompressed or RGB (but not used at this time)
813 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
814 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
815 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
817 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
819 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
821 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
822 set because already copied when copying the BinEntry's of the header
823 * Test/TestAllReadCompareDicom.cxx : remove warnings
825 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
827 Two problems appear when doing it :
828 - with the gdcmFile : when the GetImageData method is called, the pixels
829 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
830 data (pixels). And each structure destruct the data when it's
831 destructed. So we have two destructions for the same data. To solve it,
832 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
833 data or not. If it doesn't own data, then they will not destroyed by
835 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
836 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
837 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
838 create a double destruction of the same DocEntry's. So, to solve it,
839 the TagHT is simply cleared and the DicomDir* elements are destroyed.
840 * TODO : add an entry concerning memory leaks in the DicomDir
842 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
844 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
847 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
848 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
849 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
850 after it have been deleted
852 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * FIX: src/* fix the doxygen warnings.
854 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
855 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
856 was erroneously defined with a size of 15 instead of 16. [many thanks
857 to Jean Michel Rouet for pointing out this bug].
859 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 1. Finish merging JMR patch for writting DICOM from scratch
861 2. Fix -hopefully- bug with MONOCHROME and space vs null character
862 3. Use const ref when possible
863 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
864 5. A few more comments
865 6. CreateUniqueUID can now be called without parameter"
867 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
868 * ENH: Slightly bigger patch:
869 1. Getting toward full integration of JMR patch for writting dicom from scratch
870 2. Update Test to test part of this patch: CreateUniqueUID
871 3. File was not close properly in gdcmDict
872 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
873 5. Use of const ref instead of copy (speed issue)
874 6. Remove temporary (duplicate) string in TranslateToKey
875 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
876 8. Do not repeat virtual in subclasses
877 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
879 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
880 * Apply first patch toward better string comparison when dealing with broken
881 DICOM files. Essentially the string could be padded with a space instead
882 of a null character as defined by standard
884 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
885 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
886 because never used... and in the same time, that's remove some memory leaks
888 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmFile.cxx : now delete the PixelConvert instance.
890 * In examples and tests : change the type of image data variables from void*
891 to uint8_t*. Remmove all delete on image data variables
893 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
895 Verify the file pointer value before open the file, and if it's not null,
896 a verbose message is generated.
897 Close correctly the file when the file isn't considered dicom-like. The
898 correctly close is a call to CloseFile.
899 When closing the file pointer, test if its not null to close the file.
900 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
901 file. For an uncompressed image, the copied data correspond in the least
902 case to the image size (calculated) or the image size specified in the
903 header. A verbose is generated if these two size mismatch
905 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
907 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
908 break under windows (with msvc6 compilation).
910 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
911 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
912 compiling with MSVC6)
914 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
915 * Bugs fix for the Windows build with VC6
916 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
917 needed (only for projects required VTK). If the VTK is included in all
918 projects, there is conflicts with the jpeg lib of vtk when compiling the
919 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
920 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
921 when compiling the gdcm_wrap.cxx file (created by the compilation of the
923 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
924 (like it's already made for the cout use). Otherwise, conflict with the
927 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
930 - comments on the DicomDir::Method related usage added.
931 - now that we use the namespace gdcm, a lot of internal classes do
932 NOT need to be wrapped anymore.
933 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
934 DicomDir::Method) new example added.
936 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
937 * Improve string manipulation. I now inforce the notion of 'DicomString'
938 A DicomString can contain as many \0 as they want
939 and it is *always* of even length.
940 We only support odd length for very rare case.
941 And in the near future this should be removed.
943 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * /binary_write/ gdcm source. Now even on big endian we are writting
945 little endian. This should -heopfully- fix some tests
947 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * Now the dictionary is compiled into gdcm lib. This is a default
949 behavior, thus any dic file specified is picked before failback to
950 the one comiled into lib
952 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
953 * Change internals for gdcmDict. Don't use any 'new' any more.
954 This should definitely solve any leak problem, and we should be
955 as fast as before, as long as don't modify too much the dictionary.
957 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * STYLE: ivars should start with a capital letter.
959 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
960 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
962 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
964 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
965 new 2004 dictionaries added (thanks to JPR).
966 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
967 * CLEANUP_ROUND (15) for gdcmPixelConvert
968 - RLEFrame::NumberFragments is now of type unsigned int
969 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
970 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
973 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
974 * Initial work in gathering all transfer syntax accessors. clearly
975 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
976 ivars, but only one transfersyntax (class) ivar with equivalent method on
979 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
980 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
981 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
982 discussed (plus I didn't like having a 2000 lines patch not commited)
984 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
986 * CLEANUP_ROUND (14) for gdcmPixelConvert
987 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
988 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
989 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
991 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
992 anymore and hence avoids storing a copy of PixelConvert::Decompressed
993 into File::Pixel_Data.
995 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
997 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
998 * CLEANUP_ROUND (13) for gdcmPixelConvert
999 Substituted File::ParsePixelData() with PixelConvert::Print() new
1001 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1002 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1003 method to those classes.
1004 - src/gdcmFile.[cxx|h]:
1005 -- Added a ::Print() method.
1006 -- PixelConverter is now a reference instead of a member.
1007 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1008 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1010 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1012 collaboration diagram and inheritance diagram should be generated with
1014 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1015 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1016 pointlessly wrapped (see
1017 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1018 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1019 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1020 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1021 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1022 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1023 -- File::Initialise: PixelConverter setup moved away to
1024 PixelConverter::GrabInformationsFromHeader()
1025 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1026 interpretation moved away to PixelConverter::BuildRGBImage()
1028 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1029 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1030 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1032 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1034 displayed on Win32 when a brutal abort() occurs (because of uncatched
1035 exception). See TODO new entry of this commit for more on this.
1036 * TODO added new entry.
1037 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1038 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1039 - HandleColor is no longer called from gdcmFile.cxx
1040 - gdcmPixelConvert.cxx clean up on method arguments and internal
1041 variable names for semantical coherence.
1043 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * Finished lossless transition, not only do we now read all lossless jpeg
1045 images, without the need of the Cornwell lib, but we do read them properly now
1046 * To reduce code (well to avoid code duplication), I defined a common place
1047 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1048 redefine symbols. This is not perfect but this the best solution I found for a
1049 compilation time jpeg option.
1051 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * Update jpeg ijg lib to support lossless jpeg implementation
1053 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1055 * Also added a special copyright for dcmtk since we use their bugfixes.
1058 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1060 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1061 matters, as stated in warning note at beginning of %include section).
1062 * src/gdcmDicomDir*.[cxx|h]: coding style
1063 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1064 * src/gdcmJpeg8.cxx: doxygen fix.
1065 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1066 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1067 from File:: to PixelConvert::.
1069 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1071 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1072 - more code moved away from File:: to PixelConvert::
1073 - fat setup of PixelConverter set in place in File::Initialise.
1075 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1077 namespace at the file system level. So now you should convert your examples
1079 gdcmHeader -> gdcm::Header
1080 It would be nice if people keep in mind to no open the namespace, since it
1081 allows compilation on broken plateform which were defining common symbol in
1082 the standart namespace (like LP, Unknown ...)
1084 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1086 The JPEG fragments are now parsed at the same stage than the RLE
1087 information. All code related to JPEG is now in gdcmPixelConvert:
1088 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1089 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1090 export a gdcmFile:: method. Those are simply global functions
1091 (for the time being this is better than having them attach to
1092 either gdcmFile:: or gdcmPixelConvert::).
1093 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1094 and stores the result in a gdcmJPEGFragmentsInfo.
1095 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1096 code (among other stuff) moved away from gdcmFile:; to
1099 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1101 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1102 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1103 clean up of RLE related code.
1104 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1105 - src/gdcmRLE.cxx removed
1106 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1107 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1108 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1109 * CLEANUP_ROUND (9) for gdcmPixelConvert
1110 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1111 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1112 away from gdcmFile:: to gdcmPixelConvert::.
1114 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1116 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1117 This is because Parse7Fe0 used to parse the pixels to compute the
1118 length. This task was passed over to FindDocEntryLengthOB() a long
1119 time ago, EXCEPT I had forgotten the OW case...
1120 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1121 we just recylce the code for parsing RLE fragments and computing
1123 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1124 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1125 with the retired Parse7Fe0().
1126 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1127 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1129 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1131 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1132 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1133 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1134 * CLEANUP_ROUND (4) for gdcmPixelConvert
1135 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1136 to return an unused length.
1138 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1139 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1140 this should be cleanner from the plane view. The iostream are erally a pain
1141 to use to do simple stuff.
1143 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1144 * Redo the compilation of the ijg jpeg library. Now only one source is
1145 necesseray. No need to rename file by hand what so ever. CMake handle the
1146 copying of the file within different directory, configure header file to
1147 modify some symbol. The only addition made to ijg wasd a mangle table so
1148 that symbol are different whether we are within 8bits or 12bits.
1150 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * Added documentation of vtkgdcmReader on Website:
1152 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1153 with it's binary name).
1154 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1155 the Website to be more complete.
1156 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1157 doxygenated documentation.
1158 - Doc/DoxyVtkGdcmReaderExamples.txt added
1159 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1160 DoxyVtkGdmReaderExamples.html )
1161 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1162 * CLEANUP_ROUND (3) for gdcmPixelConvert
1163 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1165 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * CLEANUP_ROUND (2) for gdcmPixelConvert
1167 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1169 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * CLEANUP_ROUND for gdcmPixelConvert:
1171 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1172 - src/gdcmPixelStuff[h|cxx] removed
1173 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1174 - src/CMakeLists.txt changed accordingly
1175 * GDCMHOME clean up:
1176 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1177 gdcmVersion.py moved to newly created ATTIC related
1178 gdcmPython/SetupOldies/ directory.
1179 * Autotools clean up:
1180 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1181 - autogen.sh configure.in acinclude.m4 python.m4 removed
1183 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1185 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1186 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1188 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1189 * TODO updated with Mathieu suggestions. I proposed a template for
1190 describing TODO entries and used it for new entries.
1191 * Added Doc/Website/CodingStyle.html, Developpers.html,
1192 DeveloppersPython.html, GdcmDataCvs.html and
1193 DownloadVersion0_1.html, DownloadVersion0_3.html.
1194 * Some Doc/*.txt Doxygen files (which do not really concern the
1195 documentation itself, but the website) moved to html and
1196 placed in directory Doc/Website:
1197 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1198 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1199 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1200 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1201 * CMakeLists.txt changed accordingly.
1202 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1203 DeveloppersPython.html
1204 * INSTALL nows refers to Doc/Website/Installation.html
1206 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * Added Doc/Website directory, that contains a first raw version
1210 2004-09-23 Jean-Pierre Roux
1211 * FIX In order not to be poluted any longer by casting problems,
1212 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1213 we can now delete[] it safely
1214 * VoidArea is now called BinArea (less confusing name),
1215 and all the methods called ...VoidArea... are now ... BinArea...
1216 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1218 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1220 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1221 up to the destructor of gdcmElementSet to clean up TagHt and it's
1224 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1226 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1228 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * ENH: added some utility method that builds a flat dictionary
1230 holding all the Dicom entries contained in the recursive structure
1231 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1232 an example of usage.
1233 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1234 BuildFlatHashTable() that build a flat dictionary.
1235 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1236 gdcmDocument is now a friend of gdcmElementSet.
1237 - src/gdcmElementSet.cxx: clean up.
1238 - Example/FlatHashTablePrint.cxx added.
1239 - Example/CmakeLists.txt changed accordingly
1241 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1243 moved away from gdcmDocEntrySet (since this class is an abstract class
1244 acting like an interface). SQDepthLevel and BaseTagKey are now
1246 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1247 and associated accessors. Doxygenation of the class.
1248 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1250 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1251 Use SQDepthLevel accessor instead. ::Print() adapted.
1252 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1253 - src/gdcmDocument.cxx changed accordingly.
1255 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1256 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1257 - The following is the doxygen comment of the typedef declaration
1258 of gdcmTagKey in src/gdcmCommon.h:
1259 gdcmTagKey is made to old an "universal" (as in URL, Universal
1260 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1261 A dicom tag always has a group and an element, but a set of tags
1262 embeded in various (optionally nested) sequences and sharing
1263 the same group and element all share the same (group, element)
1264 "identifier". Hence the (group, element) cannot be used as an
1265 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1266 In order to construct a proper tag identifier (i.e. a key) we
1267 consider the following definition of a TagKey:
1268 - let Group, Element be the string representation of the
1269 group and element dicom tag members,
1270 - let ItemNumber be the string representation of the integer
1271 index of the considered item number of a sequence,
1272 Let the key of a tag embeded in a sequence, noted SeqTag, be
1274 /ItemNumber#Group|Element
1275 where "/", "#" and "|" are characters acting as separators.
1276 Then the general form of a gdcmTagKey is given by:
1277 Group|Element<SeqTag>
1278 where <SeqTag> means NO or many instances of SeqTag.
1279 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1282 but the gdcmTagKey of a tag "embeded" is the first item of
1283 a sequence, itself nested in the third item of a sequence is the
1285 0004|1220/2#0008|0082/0#0008|0090
1286 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1287 order to hold the new sequence compatible key. Previously, the
1288 GetKey() method would look in the underlying gdcmDictEntry.
1289 - src/gdcmDocEntry.cxx:
1290 -- constructor now copies the underlying DictEntry key, in the local
1292 -- ::Print: displays the member Key, instead of the (group, element).
1293 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1294 - src/gdcmDocEntrySet.h:xi
1295 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1296 -- now has a new BaseTagKey member.
1298 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1299 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1301 This poses the problem with the semantics of the following lines
1302 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1303 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1304 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1305 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1306 to the long FIXME note for what the problem is. Nevertheless in
1307 order to get things working the dicom dictionary was altered !
1308 Please fix things urgently...
1309 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1310 information), see above note on moving the member VoidArea. Nevertheless
1311 the following entries previously correctly set as US are now inproperly
1313 0028 1201 OW IMG Red Palette Color Lookup Table Data
1314 0028 1202 OW IMG Green Palette Color Lookup Table Data
1315 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1316 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1317 of gdcmDocEntry moved to gdcmSeqEntry.
1318 * src/gdcmSeqEntry.cxx: STYLE.
1320 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1323 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * gdcmPython/testSuite.py: all the test suite in python is now moved
1325 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1326 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1327 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1329 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1331 to avoid inclusion recursion until STL is reached.
1332 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1333 mecanism. errno.h is not included in gdcm anymore.
1334 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1335 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1337 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1338 gdcmData/TestAllEntryVerifyReference.txt
1339 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1340 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1341 exception_on_error parameter.
1342 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1343 - vtk/vtkGdcmReader.cxx changed accordingly,
1344 - Example/*.cxx and Test/*.cxx changed accordingly.
1346 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1348 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1349 enable_sequences removed from gdcmHeader constructor and dependencies.
1350 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1351 * gdcmPython/demo/PrintHeader.py: dummy fix.
1352 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1353 skip_shadow removed from gdcmHeader constructor and dependencies.
1354 * Example/*.cxx and Test/*.cxx changed accordingly.
1356 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1358 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1360 2004-07-21 Jean-Pierre Roux
1361 * FIX Now, Parsing and Printing a DICOMDIR do work!
1362 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1364 2004-07-20 Jean-Pierre Roux
1365 * FIX Some brain damaged headers have Zero-Lenght fields
1366 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1368 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1369 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1370 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1371 variable (instance of gdcmDebug) by a definition macro, and the instance
1372 is now in static in the gdcmDebug class
1373 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1374 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1376 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * WARNING: ctest now depends more tightly on gdcmData. You should
1378 check out gdcmData properly for things to run smoothly...
1379 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1380 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1381 we need the pixels not be loaded in order to use the ValEntry
1382 that displays position and size).
1383 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1384 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1385 be deprecated. If you have any doubts about the advantages of a
1386 modern scripting language (read Python) versus grass root C++ (i.e.
1387 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1388 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1389 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1390 Anyhow, consider documenting the gdcmData images in
1391 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1393 * Test/CMakeLists.txt:
1394 - now uses TestAllEntryVerify.cxx
1395 - specific comments on oldACR00001.ima (now renamed in gdcmData
1396 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1397 gdcmData/TestAllEntryVerifyReference.txt
1400 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * src/*.[h|cxx] : typedef clean up
1402 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1403 - TagKey renamed to gdcmTagKey (for external usage)
1404 - VRKey renamed to gdcmVRKey (for external usage)
1405 - removal of typedef duplication.
1406 - Removed all unecessary inline keyword from class inline definitions.
1407 - Some method|function(void) declarations replaced with method|function().
1408 * src/jpeg/libijg12/jdhuff12.c:
1409 - printf polluting ctest removed.
1410 - TAB removal for comminting
1412 - TestAllReadCompareDicom.cxx: added a test that compares all the
1413 images in gdcmDataImages.h with corresponding images in
1414 gdcmData/BaselineDicom/. When baseline images are not present
1415 this test creates them.
1416 Note: we need to validate each reference image, but before that
1417 I'd like to rename them with a more explicit name...
1418 - CMakeLists.txt: changed accordingly.
1419 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1420 including each header needed).
1422 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1423 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1424 test suite to the Example directory. Are concerned:
1429 - TestWriteSimple.cxx
1430 * Test/CMakeLists.txt: added some comments on reasons for black listing
1431 image gdcmData/oldACR00001.ima
1433 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1434 * Test/CmakeList.txt: removed the following from black list (to be coherent
1435 with removal from gdcmData):
1436 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1437 - gdcm-MR-PHILIPS-16.dcm
1439 Added the following because after last cvs update, they cause
1440 ctest -R TestReadWriteReadCompare
1442 - gdcm-MR-SIEMENS-16-1.acr
1444 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1445 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1446 new comments in this file) we temporarily (sigh) move to a weaker
1448 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1449 we don't need to black list the following images anymore:
1450 - 8BitsUncompressedColor.dcm
1452 - US-PAL-8-10x-echo.dcm
1453 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1454 fixes and the beautified code ;-)
1455 This fixes the bug introduced in version 1.42 (when beautifying)
1456 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1457 Note: ctest was blind to this bug (this means we need to still
1458 improve the test suite). The bug could be detected by using
1459 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1461 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1462 and by displaying the (garbage) produced file temp.XDCM...
1464 2004-06-29 Jean-Pierre Roux
1465 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1466 - replace by uggly but working old code :-(
1467 A lot of things should be OK again.
1468 It's really urgent to have a test suite that *tests*,
1469 to prevent Frog's beautifying sessions to break all the stuff
1470 (twice, withing a fortnigh ...)
1472 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1474 redundancy) to added Test/TestReadWriteReadCompare.cxx
1475 * Test/CmakeList.txt: because the compare test of
1476 Test/TestReadWriteReadCompare.cxx fails, the following images are
1477 black listed: - 8BitsUncompressedColor.dcm
1479 - US-PAL-8-10x-echo.dcm
1480 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1481 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1482 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1483 and ad-hoc kludge. This kludge is now removed, and on encountering
1484 such an image (OB field brain damaged) we set errno. Then in
1485 ::FindDocLength() we "fix" the length as being ALL what remains
1486 in the file (until EOF). We then proceed, hoping for the best...
1487 This fixes a SegFault in ShowDicom when trying to write such an
1489 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1490 (because TestWriteRead breaks on it, after a non conformal commit?).
1491 ctest now runs properly, except for MakeDicomDir (which was always
1492 broken) and the Python related stuff (still not fixed).
1494 2004-06-24 Jean-Pierre Roux
1495 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1496 FIX : Test/TestReadWrite now iterates on all the file names
1497 (instead of infinite loop)
1498 ENH : Test/TestWriteRead now iterates on all the file names
1500 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1503 2004-06-24 Jean-Pierre Roux
1504 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1505 when SamplesPerPixel =3
1506 - now Write is no longer confused by
1507 'BitsAllocated = 12" and 'BitsStored=12"
1508 - "UN" value representation Elements are now written correctly
1509 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1510 ENH : - now gdcmHeader has its own Write methods
1511 (in order to split the job that has not to be done
1514 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1516 loop on the same image until memory went out.
1517 Note: this means we still have gobs of memory loss in PrintDocument
1518 * src/gdcmDocument.cxx: fixes problem on parsing on file
1519 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1521 2004-06-24 Jean-Pierre Roux
1522 FIX : Write - All the Sequences and Sequence Item are now written
1523 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1524 is added a the end, when necessary.
1525 - A lot of brain-damaged images, that were read correctly are
1526 now written correctly
1527 - length compatible BinEntry are now loaded correctly
1528 (even for odd groups)
1529 Note : only Explicit Value Representation was checked.
1530 (question : is implicit VR really necessary for gdcm ?)
1532 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * DEVELOPPER: added a proposition of coding style.
1534 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1537 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1538 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1539 Use the gdcmDocEntry::Print() and Write() instead.
1540 * src/gdcmDocument.cxx: bug fix.
1542 2004-06-22 Jean-Pierre Roux
1543 FIX : gdcmDocument.cxx
1544 - Now we do recognize the JpegLossLess format (there was a misstyping in
1545 code 'beautyfication' :-(
1546 - Now we automaticaticaly load the Luts, if any
1548 2004-06-22 Jean-Pierre Roux
1549 In order : to write Sequences, whatever their imbrication level,
1550 : to allow user to create his own Sequences
1551 a lot of modif where necessary (adding, moving, or virtualising methods)
1553 WARNING : save your own sources *before* cvs up !
1556 ADD virtual void Write(FILE *fp, FileType filetype);
1559 ADD virtual void Write(FILE *fp, FileType filetype);
1560 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1563 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1564 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1565 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1566 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1567 ADD std::string GetEntryByName(TagName name);
1568 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1570 std::string vr = "unkn",
1571 std::string fourth = "unkn",
1572 std::string name = "unkn");
1573 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1574 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1575 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1576 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1577 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1578 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1579 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1580 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1583 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1584 ADD virtual std::string GetEntryByName (TagName tagName);
1585 ADD virtual std::string GetEntryVRByName (TagName tagName);
1586 REM virtual bool Write(FILE *, FileType);
1587 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1588 FILE *_fp, FileType type);
1589 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1590 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1591 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1592 REM virtual std::string GetEntryByName (std::string tagName);
1593 REM virtual std::string GetEntryVRByName (std::string tagName);
1594 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1595 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1596 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1598 std::string vr = "unkn",
1599 std::string fourth = "unkn",
1600 std::string name = "unkn");
1601 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1602 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1603 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1604 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1607 ADD virtual void Write(FILE *fp, FileType filetype);
1610 ADD virtual void Write(FILE *fp,FileType filetype);
1613 ADD virtual void Write(FILE *fp, FileType filetype);
1614 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1615 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1616 REM std::string GetEntryByName(TagName name);
1619 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1621 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1622 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1623 The default constructor invoked by the line
1624 gdcmHeader *f1 = new gdcmHeader( header );
1625 was gdcmHeader::gdcmHeader(bool) instead of the expected
1626 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1627 Hence the parsing wasn't executed... See also below.
1628 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1629 as explicit constructor didn't do the trick to fix the above problem.
1630 Could anyone explain why ?
1631 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1632 properly calls gdcmValEntry::Print() (that was weed out from
1633 code related to gdcmBinEntry).
1635 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * In order to fix memory leaks:
1637 - Test/TestWriteSimple.cxx: added cleaning of free store through
1639 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1640 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1641 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1642 (through the call to ::AddDicomDirMeta()) or the destructor
1643 would crash when deleting uninitialized ::metaElems].
1644 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1645 - src/gdcmDocument.cxx:
1646 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1647 from dynamic stores.
1648 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1649 was causing memory leaks.
1650 - src/gdcmSQItem.cxx:
1651 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1652 cleanly handled with polymophism: sorry but my milage is low).
1653 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1654 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1655 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1656 This avoids SegFaulting.
1657 - src/gdcmSQItem.h: coding style.
1659 - Test/TestWriteSimple still severely sucks. The output image content
1660 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1661 damaged when displayed with vtkgdcmViewer.
1662 - on memory leaks: TestWriteSimple leaks really less (see entry
1663 of 2004-06-18 in Changelog file for the call to valgrind).
1664 - on segfaults: ctest now passes all the tests but one (no more
1666 * Erroneous leading white fix:
1667 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1668 white[s] (as opposed to from >> xxx, that removes it [them].
1669 - src/gdcmTS.cxx: ditto.
1670 - gdcmPython/testSuite.py: dirty related kludge removed.
1671 * src/*: remaining references to gdcmParser removed.
1672 * src/*[cxx|h]: added copy[way]left header.
1675 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * In order to fix writing of dicom files:
1677 - Test/TestWriteSimple.cxx: a simpler example of writing.
1678 - Test/CMakeLists.txt changed accordingly.
1679 - src/gdcmDocument.cxx:
1680 -- The destructor now recursilvely removes potential sequences.
1681 -- Bug fix in ::IsJPEG2000()
1682 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1683 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1685 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1686 to only declared) and build on top of
1687 ::GetDocEntryByNumber(guint16, guint16).
1688 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1689 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1690 for usage in destructor and treatement of promotion in
1691 ::ReplaceOrCreateByNumber().
1692 - src/gdcmSQItem.cxx: destructor should better handle his job.
1693 Test/TestWriteSimple now runs (or at least it DOES something).
1694 * We can now start hutting memory links. A good starting point is:
1695 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1696 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1697 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1699 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * Valgrind note: after Mathieu Malaterre teached me how to read
1701 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1703 Using gcc, you can force the STL to use malloc and to free memory as
1704 soon as possible by globally disabling memory caching.
1705 With 3.2.2 and later, you should export the environment variable
1706 GLIBCPP_FORCE_NEW before running your program.
1707 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1708 simply vanish (it is still not clear to me, whether this means that
1709 STL std::string leaks or if valgrind believes it leaks...).
1710 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1711 running bin/gdcmTests makeDicomDir):
1712 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1713 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1715 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1716 SegFaulting (I drowned in DicomDir related code when trying to
1717 understand why the list is empty...).
1718 * src/gdcmDocument.h: first BSD license header try.
1719 * Doc/License.txt added.
1721 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmDocument.[h|cxx]:
1723 - Clean up of the Transfer related predicates. They are now all based
1724 on new method isGivenTransferSyntax, that (should) handle properly
1725 the padding problem.
1726 - general clean up, simplification, and coding style.
1727 - Specific clean up of Parse7FE0() (umproperly named actually).
1728 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1730 2004-06-14 Jean-Pierre Roux
1732 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1733 - fix the display of SQItem ordinal number
1734 - add the GetSQItemByOrdinalNumber method
1735 - remove some useless never written private methods
1737 2004-06-14 Jean-Pierre Roux
1739 - adding a constructor taking a gdcmDocEntry as an input param
1740 - ReplaceOrCreateByNumber now returns :
1741 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1742 a gdcmValEntry * if a string value is passed as a param
1744 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1745 according to the param type (no longer sets a gdcmDocEntry)
1746 - GetValEntryByNumber, GetBinEntryByNumber added
1747 - NewValEntryByNumber and NewBinEntryByNumber added
1749 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1751 - GetSQItemNumber and SetSQItemNumber added, to provide
1752 a (relative) Item identier inside a given Sequence
1753 \warning : some pb remaining around this number
1755 - AddEntry now takes the Item Number as a param
1757 - adding a constructor taking a gdcmDocEntry as an input param
1759 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1760 * Memory leak hunt with the following command:
1761 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1762 --show-reachable=yes gdcmTests PrintDocument
1763 It looks like many (all?) leaks are due to the STL (or a bad usage
1764 of the STL. The lines producing the leaks now have a comment with
1765 a "MEMORY LEAK" tag: you can retrieve them with
1766 grep "MEMORY LEAK" src/*
1767 Here are two typical examples which I can't help fixing:
1772 char * test = "babo";
1773 name = test; //// <--- valgrind detects 960 bytes lost in
1774 //// call to std::string::operator=(char const*)
1775 name.clear(); //// Doesn't help !
1783 std::cout << "Type a bunch of characters followed by RETURN: ";
1784 getline(std::cin, line); //// <--- valgrind dectects a loss
1785 //// of 1320 bytes in call to
1786 /// std::basic_istream<>& std::getline<>
1792 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * src/gdcmHeader.[cxx|h]:
1794 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1795 and related, moved away to gdcmDocument.
1796 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1797 the corresponding protected accessors of inherited class
1798 gdcmDocument, removed ! As a consequence gdcmFile had to be
1799 declared friend of class gdcmDocument (see below).
1800 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1801 - Clean up of undefined or unused methods.
1802 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1803 account the changes to gdcmHeader.h).
1804 * src/gdcmDocument.h:
1805 - gdcmFile is now a friend class (in order to take into account the
1806 changes to gdcmHeader.h).
1807 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1808 (see changes to gdcmHeader.h).
1809 - Accessors (reading on the form GetEntry*) are now public.
1810 - Clean up of undefined or unused methods.
1811 * src/gdcmDocument.cxx:
1812 - adaptation to changes to gdcmDocument.h
1813 - ::OpenFile now writes a verbose message when file cannot be opened.
1814 - some std::string properly set to VRKey
1815 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1816 references to gdcmDocument.
1817 * Test/TestFindTags.cxx: changed accordingly to above changes.
1818 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1819 cvs repository gdcmData.
1821 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1823 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1824 conflicts with gdcmValEntry::voidArea.
1825 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1826 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1827 Value representation between StringRepresentable and BinaryRepresentable.
1828 * src/gdcmDocument.cxx:
1829 - method ParseDES: proper indentation restored and usage of
1830 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1831 - method LoadDocEntry: the fingerprint left in the SetValue() of
1832 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1833 removed. Reverting to previous code segment with the proper
1834 dynamic_cast< gdcmValEntry* >.
1835 Note: this was (partially) breaking the python test suite
1836 (gdcmPython/testSuite.py) that made usage of the above
1837 fingerprint to check presence of "Pixel Data".
1838 * src/gdcmDocEntry.h: coding style.
1839 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1840 now taken into account.
1841 * gdcmPython/gdcm.i: adaptation to the new internal representation
1842 of gdcm (exit gdcmParser, hello gdcmDocument).
1843 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1845 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1846 anymore, but instead prints the loaded Python dictionary.
1847 * .... alas, the python testSuite is still broken.
1849 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1850 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1852 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1853 * src/gdcmUtil.h : export methods
1855 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1858 * Initial addition of automatic python testing
1859 * Initial addition of automatic image comparison
1861 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1862 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1863 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1865 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1867 * Test/ShowDicom.cxx : bug fix for msvc compilation
1868 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1870 2004-05-04 Jean-Pierre Roux
1871 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1872 new concepts (and new classes) :
1873 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1874 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1875 - Sequence Doc Entries (gdcmSeqEntries)
1876 a Sequence is composed of Items.
1877 Each item is a set of Doc Entries (this is recursive)
1878 The non uniqueness of the 'Dicom tag' is due to this recursivity
1879 (never taken into account)
1880 Our unability to add a new 'entry' in the header
1881 at the proper location (neither in the H-Table (map or multimap),
1882 nor in the Chained List is also due to this recursivity.
1883 Don't try, right now, to use/modify/compile these new sources :
1884 nothing is finished.
1885 We just commit all the stuff, 'as is', in order not to loose it.
1887 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1888 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1890 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1891 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1892 file prefix (SetFilePrefix)
1894 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * Add a new test: ShowDicom, for now this is just the c++ version of
1896 checkRead.sh, later it will be able to compare the image read against a
1898 * Replace the DEBUG on the stack with a global entry in cmake interface:
1899 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1901 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * Add an example subdir, with a real example on how to read + write a
1905 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1907 * Doc/CMakeLists.txt: the main page is now properly differentiated
1908 between the developper and user version.
1909 * Doc/doxygen.config.in: dropped search related obsolete flags
1910 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1912 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1913 * DEVELOPPER: added some helpfull comments for compile/test/install
1916 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1918 src directory, now generated in the build dir.
1919 2. Tests as mentionned smarter
1921 4. Add a new method in gdcmDict that return the PubDict by name
1922 this is interesting for 3rd party lib like ITK,
1923 where we could set the institution name / patient name...
1925 * ENH: 1. Now the test suite is working for real
1926 2. All binaries are now output in the gdcm-bin directory
1927 (this was not true before)
1929 2004-04-28 Jean-Pierre Roux
1930 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1931 SeQuence indented printing of Dicom Header.
1932 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1933 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1934 Computation of SQDepthLevel is now part of gdcmHeader constructor
1935 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1936 tree-like structure of a Dicom Header.
1937 * FIX Test code cleaning
1939 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1940 * ENH: Adding automatic testing
1941 1. Need a DartConfig.cmake to submit to public
1942 2. Add a test driver gdcmTest.cxx
1943 3. gdcmTestMain, an helper for the main test driver gdcmTest
1944 4. Files in Test don't have a main anymore, this becomes interesting
1945 when we add more and more tests, thus dsw don't have to load
1947 * ENH: Adding a GDCM_DATA_ROOT for testing
1948 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1949 one file instead of seven + some small cleanup
1951 2004-04-22 Jean-Pierre Roux
1952 * ENH Minor changes to the Print() methods.
1953 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1954 Header printing. Example given with :
1955 > PrintHeader fileName 2 new
1956 (SQ based tree-like structure still to be done for the Header ...)
1958 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1959 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1960 1. I have added some unsigned where needed
1961 2. Some function parameter not used -> (void)
1962 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1963 4. g++ don't like character '\' in comment
1964 5. #define jpeg_create_decompress jCreaDecompress
1965 this really need to be fixed
1966 6. virtualize destructor of gdcmObject ... leakage
1967 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1968 this also really need to be fixed
1969 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1970 remove compression file
1971 (as we only do decompression, right ?)
1972 * ENH: Change malloc/calloc/free with c++ equivalent
1974 2004-04-21 Jean-Pierre Roux
1975 * FIX gdcmHeaderHelper::GetXSpacing
1976 when a single value is found (bug ?), xpacing is now
1977 defaulted to yspacing
1979 2004-04-19 Jean-Pierre Roux
1980 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1981 * ENH add parameters :
1982 bool exception_on_error = false,
1983 bool enable_sequences = false,
1984 bool ignore_shadow = false
1985 to the gdcmFile constructors to be full gdcmParser compliant
1986 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1987 to allow reading of PAPYRUS 3.0 files
1989 2004-04-06 Jean-Pierre Roux
1990 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1992 2004-04-02 Jean-Pierre Roux
1993 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1994 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1995 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1997 2004-03-30 Jean-Pierre Roux
1998 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1999 for ACR file, written out as DICOM files (hope so...)
2001 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2002 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2003 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2004 moved to base class gdcmParser and only the specialisation is kept
2006 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2007 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2008 already does the job.
2009 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2010 (to be consistent with gdcmParser::WriteEntries).
2012 2004-03-30 Benoit Regrain
2013 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2014 upate of the object's instance. It's passed to 2 in the unfavorable
2015 case : one in the ExecuteInformation, one in the ExecuteData
2017 2004-03-29 Jean-Pierre Roux
2018 * ENH : Check on file type to be written moved
2019 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2020 * FIX : gdcmObject::ResetBoundaries now stops properly
2021 when end-of-list is reached
2022 : gdcmVersion modified (as Benoit Regrain asked)
2024 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2026 * src/gdcmUtil.cxx: added forgotten iostream include.
2027 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2028 equivalent to ExplicitVR in existing code).
2030 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2031 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2032 now contains all the gdcmGlobal related code.
2033 * minor coding style and doxygenation changes.
2035 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2037 now contains all the Debug related code.
2038 * minor clean-up of includes in src/*.cxx
2039 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2040 CreateCleanString) removed.
2041 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2042 * Doc/DoxyMainPageUser.txt added.
2043 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2044 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2045 src/gdcmDirList.cxx)
2047 2004-03-24 Jean-Pierre Roux
2048 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2050 2004-03-23 Jean-Pierre Roux
2051 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2052 big endian made volumes
2053 * ENH Now gdcmParser constructor and destructor are protected to forbid
2054 end user to instanciate class gdcmParser
2055 (only gdcmHeader and gdcmDicomDir are meaningfull)
2057 2004-03-22 Benoit Regrain
2058 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2059 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2060 gdcmSerie to gdcmDicomDirSerie
2062 2004-03-19 Jean-Pierre Roux
2063 * ENH Now the tree-like structure describing a DICOMDIR comming from
2064 an already existing DICOMDIR file is consistent with
2065 the home-made tree-like structure build ex-nihilo
2066 or build from the files held (recursively) in a Directory
2067 functions gdcmDicomDir::CheckBoundaries()
2068 gdcmObject::SetBoundaries() added
2070 2004-03-17 Jean-Pierre Roux
2071 * REM (Eric Boix bug) : removal of meaningless
2072 gdcmDicomDirImage::NewImage function.
2073 * FIX now file names and directory name are written properly in the
2075 * FIX now gdcmDicomDir constructor may be call without any trick
2078 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2080 of gdcmDicomDirImage::NewImage as empty function.
2082 2004-02-28 Jean-Pierre Roux
2083 * ENH add gdcmDicomDir:NewPatient
2084 add gdcmDicomDirPatient:NewStudy
2085 add gdcmDicomDirStudy:NewSerie
2086 add gdcmDicomDirSerie:NewImage
2087 to allow making gdcDicomDir object.
2088 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2089 (as opposite to the gdcmHeader chained list)
2091 2004-02-11 Benoit Regrain
2092 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2093 when using from python
2095 2004-02-10 Benoit Regrain
2096 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2097 * FIX : in gdcmDicomDir when the directory is empty
2098 * ENH : add callback and methods to get the progression of dicomDir
2101 2004-02-06 Jean-Pierre Roux
2102 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2103 - GDCM_META added to gdcmDicomDirType
2104 - class gdcmMeta created
2105 * ENH : - A brief summary is now displayed at the beginning of
2106 'testDicomDir' to help disaster magnitude estimation
2107 * REM : Now useless Test/explDICOMDIR.cxx
2109 2004-02-05 Benoit Regrain
2110 * ENH : add methods in gdcmObject to get the hash table or the list of
2112 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2113 * FIX : wrapping python for TagHeaderEntryHT
2115 2004-02-04 Benoit Regrain
2116 * FIX : even length for some strings when writting the dicom dir
2117 * FIX : sort the images in the dicom dir
2118 * FIX : Bug fix for python use of dicom dir
2119 * ADD : a python demo
2121 2004-02-04 Jean-Pierre Roux
2122 * FIX : Final solution (?) for icone embedded images
2123 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2124 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2125 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2126 gdcmData/gdcm-MR-SIEMENS-16.acr1
2127 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2128 to make full checking easier
2130 2004-02-04 Benoit Regrain
2131 * FIX : WriteEntries : coding style & logic in parameters
2132 * FIX : Set the elements to create the DicomDir in a dictionary file
2134 2004-02-03 Benoit Regrain
2135 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2136 * gdcmDicomDir : add the load of directory
2137 * Bug fix and print add-on
2139 2004-02-03 Jean-Pierre Roux
2140 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2141 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2142 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2143 * FIX gdcmParser.cxx : 'group length' elements are now considered
2144 as integers, even for shadow groups, when file is Implicit VR
2146 2004-02-02 Jean-Pierre Roux
2147 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2149 of the last synonym :-(
2150 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2152 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2153 * FIX taking into account the possible 7fe0,0010 multiplicity
2154 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2155 to allow removal of references to 7fe0,0010, to deal with
2156 ACR-NEMA images, when 0028,0200 is meaningfull
2158 2004-01-31 Jean-Pierre Roux
2159 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2160 no longer writes 'Un' on disk
2161 * FIX SQ elements with actual length are now dealt with corectly
2162 * FIX gdcmFile::WriteBase make the difference, for color images, between
2163 the length (for Palette expanded images)
2164 and Raw Length (non expanded image + Palette)
2165 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2166 (that broke Write). Replaced by UL.
2167 Aware user will reload the field if he
2168 thinks it's necesssary
2170 2004-01-30 Jean-Pierre Roux
2171 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2172 when 'dirty Acr' is found, to be compliant with the new
2173 IsReadable() methods.
2175 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2176 (no DOUBLE images in kosher DICOM,
2177 but so usefull for people that miss them ;-)
2179 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2180 DICOMDIR related utilities (not checked as Windoze compliant)
2182 2004-01-28 Jean-Pierre Roux
2183 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2185 2004-01-27 Jean-Pierre Roux
2186 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2187 to allow skipping the shadow elements, to save memory space.
2188 The TRUE value for this param has to be used
2189 with a FALSE value for the 'enable_sequence' param.
2190 ('public elements' may be embedded in 'shadow Sequences')
2191 * gdcmHeader methods now deal with 'embedded icones images' in the header
2192 (even when an 'icone image sequence' is announced by the
2193 element (0x0088,0x0200), but there is NO icone at all ...
2195 * gdcmHeader sometimes Image Location value doesn't follow
2196 the supposed processor endianity (see gdcmData/cr172241.dcm).
2199 * gdcmHeader add the method
2200 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2201 to get *all* the Header Entries with the same tag.
2202 GetHeaderEntrySameName is probabely *useless*
2203 (no meaning : Name is *not* an identifier within the Dictionary)
2205 2004-01-26 Benoit Regrain
2206 * Bug fix in the print of hexadecimal representations. Remove long fields
2207 in the print and add a third level of print to print them
2209 2004-01-23 Benoit Regrain
2210 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2211 * Bug fix on test suite after remove the strip made on not string fields
2212 * Split the IsReadable method between gdcmParser which test that the file
2213 is dicom and gdcmHeader which test that it's an image file
2215 2004-01-22 Benoit Regrain
2216 * DicomDir : clean code, add methods, set variables in protected or private
2217 * gdcmUtil : bug fix for the clean string method
2219 2004-01-19 Benoit Regrain
2220 * Add the use of shadow dictionaries
2221 * bug fix and coding style
2223 2004-01-19 Benoit Regrain
2224 * src/gdcmFile.cxx : bug fix concerning the close of file
2225 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2226 * Add the update of header entries using the shadow library
2228 2004-01-19 Benoit Regrain
2229 * removal of file gdcmHeader2.cxx
2230 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2231 inheriting from gdcmParser. This split is to prepare the integration
2232 of dicom dir parsing
2233 * bug fix under python
2235 2004-01-16 Jean-Pierre Roux
2236 * REM removal of class gdcmHeaderEntrySet
2237 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2238 * ADD add file gdcmHeader2.cxx
2239 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2241 2004-01-15 Benoit Regrain
2242 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2243 entries created while parsing the header. Thus, they will be destroyed
2244 when the gdcmDictSet will be destroyed
2245 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2248 2004-01-15 Benoit Regrain
2249 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2250 made a fatal error because of the memory release at the end of program.
2251 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2252 some memory and vtk seems to have some problems with that.
2253 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2255 2004-01-14 Benoit Regrain
2256 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2257 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2258 * src/*.[h|cxx] : make changes due to class name changes
2259 * gdcmPython/demo/*.py : bug fix due to method names
2261 2004-01-13 Benoit Regrain
2262 * src/*.[h|cxx] : coding style
2263 * vtk/*.[h|cxx] : coding style
2265 2004-01-13 Benoit Regrain
2266 * gdcmPython/testSuite.py : test the readable flag of file for tests
2267 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2268 It's lied to the stl compilation by MSVC (windows, always windows...)
2269 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2271 2004-01-12 Benoit Regrain
2272 * src/*.h : add comments
2273 * src/gdcmDictSet.h : set the method BuildDictPath in public
2274 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2275 directly setted in the source code
2276 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2279 2004-01-09 Benoit Regrain
2280 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2281 * setup.py : use a reference to gdcmVERSION
2283 2004-01-07 Benoit Regrain
2284 * Modification to compile with the distutils.
2287 2003-12-10 Benoit Regrain
2288 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2289 can use a gdcmHeaderHelper to load data
2290 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2291 made in the source code
2293 2003-12-10 Benoit Regrain
2294 * Update Windows projects and .cvsignore files
2296 2003-11-12 Jean-Pierre Roux
2297 * ENH gdcmHeader constructor has one more parameter (default value : false)
2298 that allows the user to 'go inside' the SeQuences only
2300 gdcmElValSet:Print takes it into account
2302 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * ENH: Update gdcmPython/CMakeLists
2304 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2305 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2307 2003-11-10 Jean-Pierre Roux
2308 * FIX : gdcmHeader::LoadElements is now based
2309 on the ListTag listElem member,
2310 not longer on the TagElValueHT tagHt member
2311 * ENH : PrintPubElVal shows (temporarily) both results,
2312 with the tagHt member and the listElem member.
2313 (it's easier to 'see' the problems when using Printheader)
2315 * FIX : old private member LgrElem is now splitted into
2316 ReadLength : Length actually found on disk (updated only
2317 if bug fixing is necessary), for internal
2319 UsableLength : Updated by FixFoundLength, to fix a bug
2320 or to allow Parser going on.
2321 Will allow to re-write a kosher header when a SeQuence
2322 with a length (not 0000) is found
2323 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2324 because gdcmElValSet::Add does not update ListElem
2327 2003-11-07 Jean-Pierre Roux
2328 * FIX misstyping in Transfert Syntax name table
2329 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2330 when they have an actual length (not 0000 nor FFFFF)
2331 (Nobody should care of it, but DICOMDIR explorers)
2333 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2334 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2336 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2337 * ENH: vtkGdcmReader now supports LUT !
2338 (vtkgdcmViewer for now is not able to use them though)
2340 2003-11-05 Jean-Pierre Roux
2341 * in testSuite.py : new files names for checking the package
2342 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2343 that returns the pixel area size to the *aware* (vtk) user
2344 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2346 2003-11-05 Benoit Regrain
2347 * in testSuite.py : Modify the rules for checking the paths
2348 : Explicit error messages
2349 * in __init__.py : Related modif
2351 2003-11-03 Jean-Pierre Roux
2352 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2353 to be used by aware (vtk) users that want to manage
2354 LUT (and no to turn the PALETTE image into an RGB pixels one)
2355 * GetPixelType now returns 8U for 24 Bits images
2356 (vtkGdcmReader compliant)
2358 2003-10-31 Jean-Pierre Roux
2359 * Removal of *all* gdcmData images and add them again
2360 in order to loose the 'history' of un-anonymised images
2362 2003-10-31 Jean-Pierre Roux
2363 * RMV : removal of useless jBitsInJsample.h
2364 for both 8 and 12 Bits JPEG Lossy Libraries
2366 2003-10-31 Jean-Pierre Roux
2367 * ENH : Add the functions gdcmFile::GetImageDataRaw
2368 gdcmFile::GetImageDataIntoVectorRaw
2369 that act as GetImageData and GetImageDataIntoVector
2370 except the making of an RGB Plane from Gray Plane + LUT
2371 Intended to aware (vtk) users who know how to manage
2374 GetLUTRGBA return a R,G,B,A LUT if any
2375 lgrTotaleRaw gives the 'Raw' length
2376 GetImageDataRaw returns the gray Plane
2377 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2378 (They stay Grey, just like with other Dicom viewers :-(
2380 2003-10-30 Jean-Pierre Roux
2381 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2383 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2385 being coherents dicom files.
2387 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2390 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2391 * ENH: Two steps is necessary to please VC++ compiler...
2392 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2393 * ENH: Add include dir to medcon lib
2394 * FIX: only one function is being exported for now !
2395 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2397 2003-10-29 Jean-Pierre Roux
2398 * adding gdcmHeader::GetLUTRGBA
2399 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2400 --> Mathieu, the modif u're waiting for is not yet committed
2401 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2403 2003-10-27 Jean-Pierre Roux
2404 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2405 00191113.dcm DermaColorLossLess.dcm
2406 MxTwinLossLess.dcm RadBWLossLess.dcm
2407 * ENH: For version prior to vtkImageViewer2 -r 1.19
2408 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2410 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2411 * Removal of ido stuff in CMakeLists.txt
2413 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2414 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2415 * FIX: remove a call to ->Modified ... see comments
2416 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2418 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * FIX: Problem with path for libvtkgdcmPython
2420 * ENH: Try adding a search script for python site-package
2421 * RMV: Remove some file from medcon lib that are not necessary
2422 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2423 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2424 * FIX: More pragma disable fro VC++,
2425 I don't think I break something as it is also disable in VTK/ITK.
2426 But it fasten debug compilation time.
2428 2003-10-23 Jean-Pierre Roux
2429 * gdcm now deals with 16 Bits Run Length Encoded images
2430 (they are compressed as 2 planes images,
2431 one for the high Bytes, the other for low Bytes)
2433 2003-10-22 Jean-Pierre Roux
2434 * Now CheckRead takes into account :
2435 - the bugged 'Leonardo' Siemens images
2436 - the XA images, sent thru the burning VPRO station
2437 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2440 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2441 * FIX: When copying a Makefile.am to CMakeLists.txt
2442 one should remove the '\'
2444 2003-10-22 Jean-Pierre Roux
2445 * in gdcmData adding a bugged 'Leonardo' Siemens image
2446 (wrong lengths in header)
2447 OK with gdcm, KO with the other viewers :-)
2448 * add a GE dlx XA image, thru the VEPRO burning station
2451 2003-10-21 Jean-Pierre Roux
2452 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2453 for a brutal checking of vtkgdcmViewer compliance
2455 2003-10-21 Jean-Pierre Roux
2456 * add the files for 'xmedcon' Jpeg Lossless library
2457 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2459 2003-10-21 Jean-Pierre Roux
2460 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2462 2003-10-21 Jean-Pierre Roux
2463 * garbage Siemens 'Leonardo' images dealt with
2464 (the patch is easy to remove)
2465 * cosmetic changes to avoid warnings
2467 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2468 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2469 no need to press 'r' now.
2471 2003-10-20 Jean-Pierre Roux
2472 * upgrade of checkRead.sh checkWrite.sh according
2473 to new Jpeg Lossless decompressor
2474 * add US.3405.1.dcm, a genuine RGB medical file ...
2475 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2476 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2478 2003-10-15 Jean-Pierre Roux
2479 * general anonymisation in gdcmData
2480 * adding the 'color files' from
2481 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2482 * adding some well knowed bugged-header images
2483 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2484 waiting for their inclusion in Python testsuite
2486 2003-10-15 Jean-Pierre Roux
2487 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2488 no longer seg faults when file is not found
2490 2003-10-14 Jean-Pierre Roux
2491 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2494 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2495 * TODO: *.in file to genereate a UseGDCM later
2497 2003-10-14 Jean-Pierre Roux
2498 * Some supposed-to-be Dicom Images have no preamble.
2499 OpenFile takes it into account
2500 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2501 * Missing elements added in dicomV3.dic
2502 (just to be affraid : have a look at
2503 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2504 and do it again next year ;->
2506 2003-10-13 Jean-Pierre Roux
2507 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2508 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2509 But there are NOT. It's fixed !
2511 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * FIX: "jpeglib.h" was not found on VC++
2513 * FIX: vtkgdcm was not being installed
2515 2003-10-10 Jean-Pierre Roux
2516 * ENH : OpenFile closes the file if it *really* doesn't look like
2517 an ACR-NEMA / DICOM one.
2518 * FIX : testWrite no longer writes an empty file if the source file
2519 is not gdcm Readable
2520 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2523 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * FIX: CMake generate now documentation
2525 * ENH: out of source doc build !
2526 * ENH: Generate both user and dev documentation
2527 * ENH: Should work on windows too
2528 * ENH: Only one doxygen config.in file is needed
2529 * FIX: make install should be ok now on ùnix plateform
2530 * FIX: PATH to dictionary was wrong (missing /)
2531 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2533 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2534 * vtkGdcmReader is now able to read rgb dicom file.
2535 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2536 * added a gdcmViewer to vtk test, use mouse to control
2537 window level & window width
2539 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2540 * CMake-ification of gdcm, we have now two build system
2541 * FIX: on cygwin Wsock32 doesn't exist
2542 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2544 2003-10-06 Emanuel Ollart
2545 * FIX : compilation process wad broken.
2546 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2548 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * change gdcmViewer -> vtkgdcmViewer
2550 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2552 2003-10-06 Jean-Pierre Roux
2553 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2554 ( e.g : well known GE images with a wrong elem length,
2555 : Philips MRI Images with a wrong Huffman table)
2556 * still to be done : allow the reading of bugged LEONARDO Siemens images
2558 2003-10-03 Jean-Pierre Roux
2559 * Odd length strings are padded with '\0' (not with spaces,
2560 to remain compliant with already defined strings,
2561 like Transfert Syntax UID and others)
2563 2003-10-03 Jean-Pierre Roux
2564 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2565 to allow displaying RGB images (not only by affim ;-)
2567 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2568 * vtkGdcmReader is now able to read rgb dicom file.
2569 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2571 2003-10-03 Jean-Pierre Roux
2572 * A few nasty patches to allow the reading of a lot of nasty images
2573 ( e.g : well known GE images with a wrong elem length,
2574 : Philips MRI Images with a wrong Huffman table)
2575 * still to be done : allow the reading of bugged LEONARDO Siemens images
2577 2003-10-03 Jean-Pierre Roux
2578 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2580 2003-10-03 Jean-Pierre Roux
2581 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2582 to allow displaying RGB images (not only by affim ;-)
2584 2003-10-03 Jean-Pierre Roux
2585 * gdcmFile::GetImageDataIntoVector now
2586 - deals with MultiFrames MultiFragments Run Length Encoded files
2587 - deals with YcBcR (YBR_FULL) files
2588 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2589 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2591 (no sample found :-(
2593 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2594 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2595 Two reasons: - clear things
2596 - third parties acces gdcm through header files, so won't
2597 suffer anymore VC++ complains
2599 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2600 * add argv[1] in testvtkGdcmReader.cxx
2603 2003-09-24 Jean-Pierre Roux
2604 * The lines are now eigthy characters long.for
2605 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2607 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2608 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2609 char* to std::string. Thus, the use of strdup becomes useless. (see
2610 previous commis of Malaterre)
2611 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2612 before the last Malaterre's commit.
2614 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2615 * This commit should fix the Debug building under VC++, the problem
2616 was mainly a mixture of debug and release lib being loaded at startup.
2617 * I also remove a depency to a specific C function: strdup. Because I had
2618 to force the link to msvcrtd (whereas strdup is in libc).
2620 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2621 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2622 located in the gdcmCommon.h file. All use of reference of tha has been
2623 changed to now use the variable GDCM_UNFOUND.
2625 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2627 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2628 Dicom dictionary. The test suite can now be run again. Note:
2629 I'm note very happy with the " (RET)" changes. I believe this
2630 RETAINED comment should be dropped when parsing the dictionary.
2631 - PACKAGER corrected
2633 - AUTHORS updated and now in alphabetical order
2634 * Makefile.am now exports gdcm.dsw for Windoze users.
2636 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2637 * cygwin complains about missing std:: in subdir Test/
2639 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2640 * remove some methods that are now in gdcmHeaderHelper
2642 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2643 * vtkGdcmReader set spacing and origin correctly
2645 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * Fix a few delete/delete[] mismatch
2648 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2649 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2650 interpretation to data given by gdcmHeader. For instance there are
2651 heuristics to get informations (look at different places).
2652 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2653 sorting DICOM images based on different strategies.
2654 * modified Makefiles accordingly.
2656 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2658 when building in debug mode
2659 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2660 src/win32/gdcmdll.dsp
2661 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2663 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2664 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2667 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2668 * src/win32/libgdcmjpeg12.dsp was not dos format
2669 * src/win32/libgdcmjpeg12.dsp :
2670 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2671 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2673 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2674 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2676 * src/gdcmFile.cxx : bug fix in affectation type
2677 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2678 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2679 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2680 symbols... future problem ?
2682 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2683 * src/win32/libgdcmijpeg12.dsp was missing
2684 * modified gdcm.dsw accordingly
2686 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2687 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2689 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2690 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2691 commit of JPR (before his hollidays to facilitate our work).
2692 * setup.py : bug fix in code. Modifications made while the last commit
2693 of JPR. The code hasn't been tested before the commit... it's so
2694 useless to make that (for best programmer that is JPR) !!!
2696 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * tagged the current version as Version0_3 (i.e. version 0.3)
2699 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2700 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2701 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2702 * *.dsp : modifications to use new libgdcmijpeg8 library
2703 * setup.py : bug fix on VTKPATH variable
2704 * PACKAGER : adding all concerning windows
2706 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2707 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2709 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2710 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2711 test suite reported error.
2712 * PACKAGER file added (describes what a packager must do when
2713 packaging a new release).
2714 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2715 * configure.in: upgraded version number to 0.3.0
2716 * fixing build of rpm (through rpm -ta):
2717 - Doc/Makefile.am exports proper doxygen files
2718 - src/jpeg/libijg8/Makefile.am exports the include files.
2720 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2722 * src/gdcmHeader.h : formatting code
2724 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2726 We were obtaining error message from vtk. Now, creation of file list
2727 is made in an internal list to prevent this problem.
2728 Bug fix when output is empty.
2729 Bug fix in update of progress value. Previous commit for this was a bad
2731 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2733 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2734 * src/gdcmHeader.h : added method to get the file name
2735 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2736 files. Added method to remove all files on the input
2737 Added FIXME comment concerning the bad parsing of header made by
2738 ExecuteInformation method (in ExecuteData method)
2740 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2742 when using make instal.
2743 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2744 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2746 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2747 * setup.py : adding include dir of jpeg lib to compile all sources
2748 * */Win32/*.dsp : JPR fix for windows compilation
2750 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2753 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2754 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2756 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * setup.py is again effective on un*x (takes into account the
2758 addon of the jpeg library)
2759 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2760 * Doc/Doxy* updated (includes above enhancements)
2761 * INSTALL now points to web documentation
2763 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcmHeader.h doesn't make unnecessary reference to
2766 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2768 * src/gdcm*.[cxx|h] :
2769 - to allow compilation with gcc 3.x
2770 -- clean up of STL usage (added explicit usage of std::)
2771 -- small fixes on exceptions.
2772 Note: linking not tested !
2773 - clean of doxygen comments to avoid warnings at documentation
2775 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2776 dependent convertion).
2778 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * Clean up of previous JPR garbage commit (not even commented in the
2781 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2782 - moved all jpeg related files from src to src/jpeg/libijg8, with
2783 addition/modification of Makefile.am and configure.in.
2784 - the testSuite is still brain damage (not guilty).
2786 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2787 * WrapVTK.py : modifications to get correctly vtk source files to
2789 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2790 (FileName -> Filename)
2792 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * vtk/vtkGdcmReader.[cxx/h]:
2794 - UpdateProgress method should now be effective
2795 - removed the limitation on having only images loaded (as opposed
2797 - when building a stack of images/volume, a lesser number of
2798 gdcmHeader and gdcmFile instances should be used (hopefully
2799 accelerating things).
2800 - when building a stack of images/volumes, files which are not
2801 loadable (wrong path-filename, wrong permissions on existing file,
2802 or file not parsable by gdcm) are replaced with a black image
2803 in the stack (for the caller to notice the problem).
2805 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2808 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2809 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2810 between standard library (std) and vtk library (problems are found
2811 under Windows... thanks Windows !)
2813 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2816 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2818 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2821 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * When compiling with distutils (see setup.py) the C++ compiler is
2823 called with different flags than the default ones (with automake).
2824 In order to fix all those warning, I compiled gdcm with the command
2825 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2826 and went for warning fixes:
2827 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2828 up from unused variables.
2829 - vtk/vtkGdcmReader.cxx: potential bug fix.
2830 * src/gdcmHeader.h: Doxygen warning cleanup
2832 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * gdcmPython/gdcm.i:
2834 - typemaps correction to take into account the systematic replacement
2835 of "using namespace std" with std:: prefix e.g. std::list,
2836 std::string... (cf changes of 2003-05-21).
2837 - gdcmGlob global variable of type gdcmGlobal (defined in
2838 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2839 exported to Python a as cvar.
2840 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2841 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2842 gdcmDictSet.GetPubDictTagNames() and
2843 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2844 C++ static methods).
2845 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2846 with the above changes.
2848 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2849 * setup.py, manifest.in : bug fix under linux
2851 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2852 * Modification of setup.py to compile vtk part too. Then, we have 2
2853 wrappers which must work with same distutils. For that, we have a
2854 generic distutils in distusiltsWrapping.py ; with :
2855 - build_extWrap class to wrap generically all extensions,
2856 - ExtensionWrap base class for all wrapping extension that contains
2858 - Wrapper interface which wrap sources
2859 + In WrapSwig.py we have extension and wrapper for Swig
2860 + In WrapVTK.py we have extension and wrapper for VTK
2861 * MANIFEST.in : modifications to consider vtk directory and new python
2862 files for compilation
2864 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2865 * Added python wrappers of vtkGdcmReader vtk class (see the
2866 source in vtk/vtkGdcmReader.cxx) :
2867 - vtk/Makefile.am now builds a library
2868 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2869 python library (as opposed to _gdcm.so wich are the python
2870 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2871 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2873 - configure.in has an additional flag --enable-vtk that needs
2874 to be set to enable compilation of vtk related code, that is:
2875 + vtk/vtkGdcmReader.so and
2876 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2877 + gdcmPython/vtkgdcmPython.so (see above)
2878 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2879 be read when compressed or when HighBit + 1 != BitsStored),
2880 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2881 the usage of the python wrapper of vtkGdcmReader vtk class.
2882 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2883 * src/*.[h] all occurences of stl classes are now prefixed with
2884 std::, and all occurences of "using namespace std;" where removed.
2885 This is to avoid pollution of global namespace in included files.
2886 Apparently vtk does not avoid this pitfall: when using both
2887 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2888 collision of various stl members (principally cout...).
2889 * gdcmPython/testSuite.py now cleanly removes temprory generated
2891 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2892 comply with above changes)
2894 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2895 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2896 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2897 vtk data structure (an image Flip was required).
2898 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2899 * cosmetic changes in documentation.
2901 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2902 * src/gdcmHeader.cxx: the constructor no longer exits when an
2903 unexisting file is given as argument.
2904 * The subdirectory Data (containing all the images used for the
2905 test suite) is not part of this repository anymore. A new module
2906 containing those images is now available at
2907 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2908 with the name gdcmData.
2909 All the python scripts (including the package initialisation file
2910 gdcmPython/__init__.py) were adapated to take this change into
2911 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2913 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2914 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2915 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2916 demo of the usage of this class.
2917 Compilation of this vtk part is only done when using the --enable-vtk
2918 at configure (or autogen.sh) stage.
2920 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2921 * More memory link related corrections and documentation fixes.
2923 - maximum info is obtained with a command of the form:
2924 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2925 --show-reachable=yes PrintHeader
2926 - the remaining reachable blocks seem to come from the STL
2927 allocation scheme through the usage of map and list. It looks
2928 like this memory cannot be freed but it is not a memory leak
2929 (in fact further invocation to the STL would recollect the
2930 unused memory allthough it cannot explicitely be freed).
2931 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2932 of displaying an image parsed with gdcm and displayed with VTK.
2933 Note: some images don't seem to work e.g.
2934 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2935 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2936 Allthough this weakens the semantics, it is a ditch attempt to
2937 make gdcm more thread friendly.
2939 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2940 * Memory link hunt (by using valgrind through the command
2941 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2942 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2943 gdcmHeader::_dicom_vr.
2944 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2945 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2947 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2949 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2950 * src/Makefile.am now exports all the necessary include files at
2954 * UpdateGroupLength replaced by new one
2957 * UpdateGroupLength re-written using H-Table
2958 (named UpdateGroupLengthNew untill checks are over)
2960 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2961 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2962 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2964 - gdcmHeader::GetPubElValSet removed.
2965 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2966 UpdateGroupLength, WriteElements, Write.
2967 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2968 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2969 carried the same semantics.
2970 - src/gdcmHeaderIdo.cxx changed accordingly.
2971 - gdcmFile::WriteBase now regroups all the codes from previous
2972 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2973 - enum FileType moved to gdcmCommon.h
2974 * src/gdcmHeader.cxx AddDefault trashed
2975 * gdcmGetXSize added
2976 * getimageDataSize now calls gdcmGetXSize
2977 * Test/*.cxx changed to agree with above changes
2979 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2980 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2981 (to avoid double call by end user).
2982 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2983 by end user, since gdcmHeader::gdcmHeader now handles it.
2985 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * gdcm/Doc many doxygen changes:
2987 - Doxyfile now has two different versions, DoxyfileUsers that generates
2988 the html.users end users oriented documentation and
2989 DoxyfileDeveloppers that generates the html.developper developper
2990 oriented documentation.
2991 - README changed accordingly
2992 - requirement.txt removed (old design info moved to TODO).
2993 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2994 DoxyMainPage.txt, DoxyPython.txt provide more information.
2995 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2996 be updated by simply regenerating the docs with doxygen and copying
2997 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2998 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2999 all the tests in the form "if (<map>.count() >1)" were removed.
3000 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3001 ill-formed documentation sections.
3002 * src/gdcmHeader.cxx: ditto
3004 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3005 * setup.py fixed for un*x (needed macro for stdint.h)
3006 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3007 un*ces with sh-utils test utility.
3008 * gdcmPython/demo/test.py renamed to PrintHeader.py
3009 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3010 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3011 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3012 * src/gdcm*.cxx JPR's bad inclusion fixed.
3014 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3016 * gdcmPython/demo/test.py changed accordingly.
3018 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * gdcmPython/Makefile.am fixed linking against libstdc++
3020 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3021 * Swig subdir (historical tests of swig version 1.3.17++) removed
3022 * Test/testChangeEntete.cxx some lines commented out in order to make
3024 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3025 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3027 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3029 hence the user doesn't need this explicit call.
3030 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3031 i.e. LoadElements() call removed.
3032 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3033 - src/Makefile.am declares the proper flag for g++.
3034 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3035 for adding user defined new tags.
3036 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3037 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3038 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3040 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3041 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3042 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3043 src/Makefile.am : the project should properly compile and install
3044 with the autotools, included the python wrappers part.
3045 * gdcm.spec.in : added a spec file for RPM packaging.
3047 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3048 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3050 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3052 to exported to the environement (see gdcmPython/testSuite.py
3054 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3055 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3056 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3057 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3058 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3060 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * gdcmPython/__init__.py doesn't crash anymore when running in
3062 in InstallMode or PreInstallMode but with an environment given
3063 value of GDCM_DICT_PATH.
3064 * src/gdcmDictSet.[cxx/h] coding style.
3066 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3068 * src/gdcm.h general comments moved to TODO, and README
3069 * src/gdcm.h should now be seen as a user commodity (including it
3070 should suffice to fully use gdcm). It is nowhere including within
3071 any of the kernel files src/*.cxx and src/*.h.
3073 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3074 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3075 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3077 * src/gdcm*.cxx only include their corresponding include file
3078 (as opposed to gdcm.h)
3079 * gdcmPython/gdcm.i changed accordingly
3080 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3081 the autogen.sh generated "make snapshot" command to work.
3082 * autogen.sh removed history related references to crea package.
3084 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3085 * distutilsSwigCPlusPlus.py work around some swig portability
3088 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3090 was done in a last ditch attempt to get setup.py _really_
3091 operationnal. The python/gdcmPython layaout add the advantage
3092 of hidding away the python related distutils specific files
3093 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3094 Alas, the src directory was out of scope (i.e. it's relative
3095 position to setup.py was ../src) which made things impossible to
3096 handle (see previous version of python/setup.py). Crossing fingers...
3098 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * python/setup.py now works on Un*x. (harder than I thougth)
3100 * python/distutilsSwigCPlusPlus.py can now have include files
3101 among the list of sources.
3103 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3104 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3105 * modifications in MSVC projects
3107 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * As stated by the first lines of Test/ExceptionAndPython/README, it
3109 looks like we can move back to original usage of exception within
3110 src/gdcm* and hence remove the errno stuff that was introduced
3111 as a quick and dirty fixture of this problem (added to the TODO).
3112 * Doc/Doxyfile configuration file for Doxygen and corresponding
3113 README file for usage added.
3114 * Test/testWrite.cxx added. This new test comes from a split of
3115 test.cxx that is now reverted to its original purpous i.e.
3116 testing the proper parsing of a Dicom related file.
3117 testWrite.cxx concentrates on testing the IO part of gdcm.
3118 * Test/bug1.cxx (containing a bug on WIn32) added.
3119 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3120 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3121 whose purpose is to publish the content of the TagNames of the
3122 Dicom public dictionary were not accessible without an
3123 instance of class gdcmHeader.
3124 - those methods are now static methods of gdcmDictSet and hence
3125 require no instances at all to be invocated.
3126 - within gdcmDictSet this change required to change some method
3127 to class methods (i.e. are now static) among which SetDictPath
3128 (renamed to BuildDictPath) and LoadDefaultPubDict.
3129 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3130 the above changes by calling the new method classes of gdcmDictSet.
3131 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3132 the above to be effective.
3133 * python/gdcmPython: in order to wrap properly the above changes
3134 for Python, swig version now needs to be > 1.3.17.
3135 * python/gdcmPython/Makefile fixed to adapt itself to new
3136 configure/make shema introduced by Johan Montagnat (thanks for the
3137 contribution). Alas this Makefile cannot be turned into a proper
3138 Makefile.am without some heavy changes in the configure.in
3139 (for python dectection).
3140 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3141 now avoids publishing the empty entries.
3143 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3144 * python/setup.py : bug fix concerning install under windows
3145 ExtraPath reused :-P
3146 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3148 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3149 * Dicts/dicomV3.dic : remove double spaces !!!
3150 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3151 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3154 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3156 method. Doxygenation.
3157 * src/gdcm.h clean up of JPR spurious comments.
3159 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3160 * python/distutilsSwigCPlusPlus.py now properly collects the
3161 shadow classes generated by "swig -c++" (gdcm.py in our case)
3162 when using "python setup.py install".
3163 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3164 reexports the working classes.
3165 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3166 by the classical C errno scheme. This is to prevent an obscure
3167 behavior of the python wrappers when importing wxPython.wx prior
3168 to gdcmPython (which ended up in an abort call). An illustration
3169 of this oddity can be found in the Test/ExceptionAndPython
3170 subdir (see the README file). This problem probably due to
3171 an combination of g++ and dynamic loading.
3172 * added Test/ExceptionAndPython (see above)
3174 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3175 * Changed the layout of the python part to avoid bloating main
3176 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3177 i.e. the distutils arsenal. All the python related stuff is
3178 again in a python subdir, but the package itself is now in
3180 * setup.py was cleaned up:
3181 - pythonIncludePath removed
3182 - python setup.py bdist target is now functional.
3183 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3184 collision with other packages). gdcmPython/demo/*.py changed
3187 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * python subdir moved to gdcmPython (preparation of distutils packaging).
3189 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3190 distutils installer is operational.
3191 * - gdcmPython/__init__.py now properly loads the swig generated
3192 shadow classes (from gdcm.py).
3193 - gdcmPython/demo/*.py changed to import the package gdcmPython
3194 instead of gdcmPython/demo/load.py.
3195 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3197 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3199 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3200 entries within the associated public Dicom dictionary resp. the same
3201 information but sorted by the fourth field (PAT, IMG, DIR) of the
3203 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3204 are now in the "???" group.
3205 - python/gdcm.i changed accordingly,
3206 - python/demo/printGroupedPublicDict.py added, that gives an example
3207 of the above new functionalities in Python.
3209 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3210 * src/gdcm.h, gdcmHeader.cxx:
3211 - historic references to glib's g_malloc and g_free (#defined)
3212 were definitively removed.
3213 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3214 * src/gdcmElValSet.cxx:
3215 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3216 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3217 - GetElValue(string) renamed to GetElValueByName.
3218 - Added GetElementByName(string).
3219 * src/gdcmHeader.cxx: added
3220 - GetPubElValRepByNumber(guint16, guint16)
3221 - GetPubElValRepByName(string)
3222 - GetShaElValRepByNumber(guint16, guint16)
3223 - GetShaElValRepByName(string)
3224 - GetShaElValByNumber(guint16, guint16)
3225 - GetShaElValRepByName(string)
3226 - GetElValRepByNumber(guint16, guint16)
3227 - GetElValRepByName(string)
3228 - GetElValByNumber(guint16, guint16)
3229 - GetElValRepByName(string)
3230 * Doc/requirements.txt added.
3232 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3233 * Test/Makefile building now depends on the one of libgdcm.so
3234 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3235 pixel data) aware which enables finding the address (offset) of
3236 the pixel data of JPEG encoded DICOM files. This leaves only a single
3237 file in the testSuite whose pixel data address (offset) is unknown.
3238 * python/testSuite.py changed accordingly.
3240 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3241 * VC++ has some strong limitations when working with the STL, as stated
3242 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3243 "Also note that some STL containers (map, set, queue, list, deque)
3244 cannot be exported. [...]
3245 Some STL classes contain nested classes. These classes can not
3247 This is caused by a designed limitation that once a template
3248 class is instantiated, it can not be re-instantiated and
3250 Since our usage of map<> is ubiquitous in gdcm, this "designed
3251 limitation" of VC++ is a pitfall.
3252 Hence the Python wrappers of gdcm cannot be incrementally linked
3253 against the c++ dynamic library. The dirty but only workaround is
3254 to forget about incremental link of dynamic libraries and to generate
3255 the Python wrappers library with the inclusions of the underlying C++
3257 The following modifications concern this matter on Win32/VC++:
3258 - wrapping python correct with standalone wrapped dll (don't use separate
3259 dll under windows !!!!)
3260 - python21_d debug mode enabled (ask Frog how to use it :-)
3261 - NO problem with having an STL member of class for example string in C++
3262 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3263 - Python test of dcmlib in Python is ok under windows on a large set
3265 * removed glib references
3266 * typedef's inserted in gdcm.i for correct swig type management
3268 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3269 * python/demo/*.py load.py extracted from test.py. Added explore.py
3270 that only displays required tags and testAll.py that parses all
3271 the files of the testsuite without using unittest.
3272 * python/testSuite.py other additional test on new files added.
3273 * Data/* new test files added accordingly to the testSuite.
3274 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3275 the vr in the file differs from the one of the dictionary.
3277 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3279 values, but limits itself to values which are below a user specified
3280 size (by default 1024 bytes).
3281 * python/gdcm.i : elements not loaded (because their size is above the
3282 user specified treshold) are exported with their TagKey as key of the
3283 python dictionary. This enables the testsuite to make some checks
3284 on the unloaded elements (since we have their offset and size).
3285 * python/testSuite.py
3286 - now tests for the existence and proper value of the pixel data
3287 - two new examples added.
3288 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3290 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3291 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3292 aware. See the strategy comments in gdcmHeader::FindLength().
3293 * Test/test.cxx now accepts a filename as first argument.
3294 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3295 * python/testSuite.py changed to integrate test on above files.
3297 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3298 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3299 the vr was also RET.
3300 * python/testSuite.py more tests added.
3302 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3303 * python/testSuite.py unittest test suite added (uses Data)
3304 * Data/* dcm and acr files for the test suite.
3305 * glib dependance removed from un*x version. We now use ISO C99
3306 7.18 Integer types (see stdint.h)
3307 - python/Makefile, src/Makefile src/gdcm.h
3308 * src/ when an explicit vr (like dicom files) suddenly poped an
3309 implicit element we use to mark the underlying DictEntry of the
3310 concerned ElValue with "Implicit". This strategy was damageable
3311 too the public or provite dictionaries, since some of their vr
3312 would be changed. Since Header::FindLength heavily relies on the
3313 detection by Header::FindVR of falsely explicit elements, I
3314 added an extra ImplicitVr member to ElValue (boolean).
3315 The rest of the changes we the necessary adaptations.
3317 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3318 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3320 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3322 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3323 * Adaptation for porting to VC++:
3325 o forced to use std namespace (for string to be known)
3326 o all class use __declspec export style on WIN32
3327 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3328 (in stdlib.h on Win32 but in std:: for gcc)
3329 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3330 variable GDCM_DICT_PATH.
3331 * src/gdcmHeader.cxx verbose comments made discrete.
3333 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * python/gdcm.i: added a typemap that converts a C++ hashing table
3335 to native Python dictionary.
3336 * python/demo/test.py:
3337 - now uses the native dictionary for exploration of gdcmHeader.
3338 - takes an optional filename argument (the file to parse).
3339 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3340 PubElVals hashing table.
3341 * Dicts/dicomV3.dic removed error prone trailing spaces.
3343 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * Python wrapping process moved away from src/Makefile to
3345 newly created python/Makefile (as well as gdcm.i)
3346 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3347 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3348 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3349 from the environement variable GDCM_DICT_PATH (when existing).
3350 * src/gdcmDict::GetTag bug fix.
3352 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * Straightforward temporary fixes for swig to build the python wrappers.
3354 src/Makefile now has a python working entry [by working we mean
3355 that we can import the shadow classes without errors].
3357 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3358 * hashtest.cxx removed (since already in Test)
3359 * src/gdcmlib.h renamed to src/gdcm.h
3360 * src/dcm.i renamed to src/gdcm.i
3361 * src/Makefile prepared for python wrapping
3363 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3364 * src/gdcmHeader.cxx :
3365 - Parsing of header is now separated from loading of element values
3366 (see gdcmHeader::LoadElements).
3367 - general clean up of hopefully all file access (creation of
3368 ReadInt16 and ReadInt32)
3370 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3371 * src/gdcmHeader.cxx :
3372 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3374 - SetLgrElem renamed to SetLength
3375 - GetLgrElem renamed to GetLength
3376 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3377 * src/gdcmElValSet.cxx fixed both GetElValue methods
3378 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3379 due to IdoDude was cleaned out.
3381 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3382 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3383 concentrates on finding the value representation (when it exists).
3384 RecupLgr now only finds the element value length, and it avoids
3385 returning the unecessary skL (skipped length).
3386 Also, offsetCourant was simply removed (with taille_fich) since
3387 it was redundant with the File position internals (by using
3388 ftell and fseek). This also made skL (see above in RecupLgr) usage
3390 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3391 on the libido specificities which are handled through class
3393 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3396 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3397 * Truckload of changes. Parsing of header is barely functional
3398 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3400 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3401 * src/gdcmHeader.cxx many addons of low level methods
3403 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3404 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3405 and _IdDcmSWAP_LONG.
3407 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3408 * This corresponds to all the changes decided at the meeting of
3409 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob