1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
3 type and not a string. So, there remove problems on the format of the
6 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
8 Thus, DicomDirXXX are created with a flad that indicates if the created
9 object is empty or not (when not empty, the DicomDirElement is used to
12 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
14 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
16 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
19 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
21 Remove all access to the hash-tables or lists in the objects.
23 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
25 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
26 be complient with all the gdcm source code
28 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
32 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
36 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/ : rename VTK tests to have a best name for the tests
38 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
39 GetFirstEntry/GetNextEntry use
41 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
43 test. Now it's on image content and not on the resulting visualisation...
44 might solve the problem on linux when using the OpenGL drivers
46 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
47 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
48 DicomDirSerie, DicomDirImage
49 Dict, DictSet classes :
50 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
51 -remove InitTraversal method.
52 * UPD Test programs + Example programs
54 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
55 remove useless and never updated keyword \ingroup
57 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
59 is no memory access violation
60 * gdcmPython/demo : add python demos using VTK
62 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
63 * FIX 'Dictionnary' is now spelt 'Dictionary'
64 'wether' is now spelt 'whether'
65 'archieve' is now spelt 'archive' ;-)
67 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
68 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
69 related methods, in order not to expose internal mechanisms
72 * REM methods that exposed internal mechanisms :
73 DicomDir::GetDicomDirPatients()
74 DicomDirPatient::GetDicomDirStudies()
75 DicomDirStudy::GetDicomDirSeries()
76 DicomDirSerie::GetDicomDirImages()
87 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * Removed the Print/indent/default parameter mess. There is absolutely no
89 reason to have to methods, moreover with the second taking the ostream as
90 *SECOND* parameter. This was clearly a bad hack to get things compile.
92 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
93 * Complete rewrite of the GetMacAddress code. Now the code is *much*
94 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
95 Unfortunately the main code does not work on SunOS, thus provide a specific
96 code for this platform only (and Win32 of course). Since this seems to be
97 working, change CreateUniqueUID to use GetMACAddress instead of the
98 problematic GctestetIPAddress
100 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
101 * Unfortunately to be able to test gdcmDirList I had to break the API
102 a little. Now the class is not a std::list anymore but has a member
103 std::vector (more ITK compatible). Allow unit testing on Win32 and
106 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
107 * Update SerieHeader to take into account a Serie Instance UID to properly
110 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * ENH - Comment out Mathieu's (dangerous) Super Hack
112 for dealing with BIGENDIAN processors
113 - Move equivalent stuff to BinEntry::WriteContent
114 When necessary, 16 Bits Pixels are swapped in a small buffer
115 and then written. This avoid allocating a huge buffer, in
116 PixelWriteConvertor, and avoid modifying the Pixel Area.
118 Probabely, the same operation will have to be done when we want
119 to write image with Big Endian Transfert Syntax,
120 and we are working on Little Endian Processor
122 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
125 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
126 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
127 all the dict content.
128 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
130 * Test/TestDict.cxx : add a new test for the dict classes
132 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
133 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
134 file. Debug is yanked if compiled with NDEBUG
136 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmDictSet.h : set the default output to the os variable
138 * src/gdcmDictEntry.[h|cxx] : add the Print method
139 * gdcmPython/demo/ : add a new test
141 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
142 * merging of Test/PrintDicomDir and Test/TestDicomDir
143 * removal of now redundant Test/PrintDicomDir
144 * enhancement of Example/PrintDicomDir
146 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Now, python test might work on systems
148 * Add the PrintDicomDir test
150 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
151 * FIX : First entry following group 0002 was lost for
152 Explicit Big Endian Transfer Syntax files
153 (group and elem not swaped)
155 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
156 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
157 Big Endian Transfer Syntax supposed the group following 0002
158 begins always by element 0000 (element 0000 is *optional*)
159 To avoid further troubles, let's be pessimistic, and use
160 Document::HandleOutOfGroup0002() method
161 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
162 (related pb not yet solved)
164 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * Bug fix for the python part use
166 * Now, PrintHeader.py pass... but outside the ctest use. shit !
168 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
171 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
173 a string and should ask the global TS dict what are the propreties of
176 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
177 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
178 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
179 to swap the Swap Code, at parsing time, when we come out of group 0002
180 and Transfer Syntax is Big Endian
181 We should be able to read now 'true DICOM" Big Endian coded images
182 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
183 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
185 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Hopefully fix the bug on MacOSX and static global initialization.
187 This is the only -minor- patch I found that both please MacOSX and VS6.
188 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
189 but this would require a lot of change. Another approach would be that Global
190 create those string and GDCM_UNFOUND becomes a pointer to a string (which
191 gdcm::Global would destroy at exit).
193 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
194 * Fix bug on MacOSX with static initialization in a multy threaded
195 environment. static const string in a header file used to be ill
196 initialized provoquing the freeze of any tests. patch should solve this
199 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * According to Benoit's suggestion, and without any objection from anybody
201 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
202 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
203 - method gdcmDicomDirObject::GetEntry() renamed as
204 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
206 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
207 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
208 you debug/warning message just as c++ streams which make them very convinient
209 to use. Once this is stabilize I will change the ostringstrem to be
210 redirected to a file (ofstream).
211 * Properly support C99 extension: __FUNCTION__ which allow us to display
212 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
214 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
215 * Removal of useless and dangerous methods :
216 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
217 GetDocEntryByName, GetEntryByName, GetDictEntryByName
218 * Removal of usless methods :
219 Dict::PrintByName, Dict::GetDictEntryByName
220 * Commenting out of probabely useless methods :
221 Dict::GetDictEntryNames()
222 Dict::GetDictEntryNamesByCategory()
223 DictSet::GetPubDictEntryNames()
224 DictSet::GetPubDictEntryNamesByCategory()
225 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
226 * ENH : Use dicomTS.dic as described in 2004 version
227 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
228 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
229 Add Accessors on VM (Value Multiplicity), and VM related methods
230 * ADD : Add a list of 'Dicom Attribute types', as found in
231 http://medical.nema.org/dicom/2004/04_15PU.PDF
233 * ADD : Add dicomGroupNameAbbreviations.dic
234 should be used to write a method to replace the former
235 Dict::GetDictEntryNamesByCategory()
237 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
239 to read in the file... and only it ! Length is the efective length of the
240 data in the DocEntry structure
242 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
243 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
244 And now use a static function call instead, with a global variable. i
245 This is much closer to the VTK approach. Hopefully should be bulletproof
246 and easier to use...hopefully
248 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
249 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
251 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
254 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
256 ValEntry, BinEntry, SeqEntry creation or replace
258 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
260 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
262 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
263 when specifying the VR
264 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
265 * src/gdcmDocEntry.cxx : amelioration of print
267 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
268 * ADD : Add the method Util::IsCurrentProcessorBigEndian
269 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
270 * ADD Method Document::ComputeGroupLength
271 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
272 in order to allow further VR modification by user
273 * REM : removal of once-called method File::WriteBase
274 integration of its code in formerly one-line method File::Write
276 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
278 replace the different values "??", "Unkn", "Unknown".
279 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
280 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
281 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
282 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
284 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
287 * Set the gdcm::Base class to some Printable classes
289 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * src/gdcmFile.[h|cxx] : add the Print method
291 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
292 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
293 * src/gdcmDocument.h : remove the PrintLevel informations
294 * Example/PrintFile.cxx : use the new gdcm::File::Print
296 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
298 problems when compiling with the python wrapping
300 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
302 writting in ImplicitVR
304 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
305 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
306 JPEG decompression, especially when dicom frames are split into several
307 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
308 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
310 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmHeader.cxx : change the initialisation of default header.
312 Now, this header is readable by gdm, e-film, DicomWorks
314 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
316 Rename Decompressed to Raw
317 * Use the API changes in gdcm::File.
318 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
321 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
323 each added entry in the header. Replace the 'Planes' field by the 'Number
326 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
328 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
330 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
332 At this time, this image isn't readable by e-film... waiting JPR help to
335 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
336 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
337 DocEntry. Now use methods of the Document !
339 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * Test/ShowDicomSeq.cxx : bug fix
342 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
343 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
344 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
345 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
346 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
348 * Test/TestCopyRescaleDicom.cxx : remove unused variable
349 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
350 containing found sequences
352 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
355 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
356 Some fields in BinEntry must be copied to not seg fault when making the :
357 gdcm::File *copy = new gdcm::File( copyH );
358 and tests are now made on good variables
360 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
362 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
364 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
365 * Add vtkGdcmWriter example and test
367 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * Test/TestUtil.cxx : reformat the source code
369 * vtk/vtkGdcmReader.cxx : remove and change prints
370 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
372 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
373 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
375 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
377 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
379 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
381 by an eof to prevent all bad read of the file... and in this case, the
384 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * Example/Volume2Dicom.cxx : comment unused variables
386 * Test/PrintDicomDir.cxx : comment unused variables
387 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
388 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
389 method that is redondant with AddEntry.
390 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
393 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * Bug fix due my last commit (compilation under Windows).
395 * Example/Volume2Dicom : bug fix in the file and reformatting source code
396 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
398 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 - Remove printf / sprintf
401 - include iostream AFTER gdcm so we don't get warnings
402 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
404 - Also remove tons of include from header files, hopefully this should
405 speeup the compilation time, since it was becoming a dog slow.
406 - Remove gdcm.h as it include way too many files and slow down compilation
407 (plus it is not up to date)
408 - remove 'using namespace std' this is BAD !
410 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * Remove memory leaks on the DicomDir
412 * Remove some useless data in DicomDirObject
413 * Add usefull methods in SQItem, to be complient withe the ElementSet
415 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
416 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
418 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
420 future, with convertion)
421 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
422 and ImageDataSize values. Remove the method to get the PixelReadConverter
423 from the output of the class
425 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
428 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
430 and vtkErrorMacro use.
431 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
433 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
436 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
437 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
438 The string leaves only in the fonction. So when we make a .c_str(), we
439 get the pointeur on the first element, element that will be destroyed
440 immediately after thee instruction.
441 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
442 file has been opened : the test must be made on the content of the
443 pointer and not directly on the pointer !
446 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
448 the python part recompiles
450 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
452 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
453 X session is killed (for my computer... it seems to not be identic on
456 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
458 avoid problems (otherwise, the difference test between the visible image
459 and the reference is incorrect. If the reference is greater than the
460 screen resolution, it's produce errors).
461 Can be used for only one image. Can be used with a visible flag.
462 * vtk/vtkGdcmReader.cxx : remove commented codes.
463 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
464 under windows at compilation
465 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
467 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
469 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
471 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
472 tests on the image size X, Y, Z
474 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
476 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
477 between the class name and the file name
479 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/ : fix compilation warnings for the Write method (2 different
481 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
482 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
483 variable... create a static method in gdcm::Document to access to
484 this variable content.
486 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
488 file, to be accessed by other files (like gdcmFile). Remove commented
489 code. Move the change of the header to the gdcmFile, using the
491 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
492 To be sure of that (and simplify calls), the Write of the header now
493 gets a file name and not a file pointer (std::ifstream).
494 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
495 DocEntryArchive. Remove all open of the written file
497 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
500 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
502 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
504 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
505 some corresponding methods. Write correctly the file and check before
507 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
508 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
509 is now on RGB data (as before my last commit
510 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
512 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
514 Add a print information of the type of the entry
515 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
516 It was in the gdcmFile, and all write have been regrouped
517 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
518 Write correctly all dicom files (in decompressed mode only at this time)
519 * Test/ : test on files are now made using Raw data and not color data if
521 * Example/PrintFile.cxx : add more printings
523 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * Amelioration of code, remove some code copy. For the loading of
525 BinEntry (in gdcmDocument), add the test to verify if the file is already
528 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
530 remove a DocEntry in the header (push an empty DocEntry)
531 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
532 lines. Bug fix in the initialization of the PixelConvert and the
534 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
535 use in TestCopyDicom (now this test can run under windows... but fails)
536 * Test/TestCopyDicom.cxx : amelioration of the test :
537 - test the pixels written
538 - add test points to quickly find where is the error
539 - can set a file name input and output in arguments
540 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
541 amelioration of the test output
543 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
545 all replaced DocEntry's
546 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
547 Now, each needed DocEntry to modify is duplicated, modified and inserted
548 to the header using DocEntryArchive. Thus, after save, we can restore the
549 header initial state.
551 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
554 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
556 correct to copy it. The DictEntry is specified at the DocEntry creation,
557 then, it musn't change in the time.
558 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
559 header correctly. At this time, the change is only made for the first
560 level of the Document. In the future, it might consider sequences.
561 The change is made by replacing a DocEntry by an other that is created
562 outside the class. The old value is kept. When we restore the header
563 status, the added DocEntry is deleted and replaced by the old value.
564 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
565 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
566 set the write type to explicit VR, implicit VR or ACR. Add methods to set
567 the write mode to native, decompressed or RGB (but not used at this time)
569 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
571 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
573 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
575 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
577 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
578 set because already copied when copying the BinEntry's of the header
579 * Test/TestAllReadCompareDicom.cxx : remove warnings
581 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
583 Two problems appear when doing it :
584 - with the gdcmFile : when the GetImageData method is called, the pixels
585 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
586 data (pixels). And each structure destruct the data when it's
587 destructed. So we have two destructions for the same data. To solve it,
588 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
589 data or not. If it doesn't own data, then they will not destroyed by
591 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
592 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
593 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
594 create a double destruction of the same DocEntry's. So, to solve it,
595 the TagHT is simply cleared and the DicomDir* elements are destroyed.
596 * TODO : add an entry concerning memory leaks in the DicomDir
598 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
600 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
603 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
605 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
606 after it have been deleted
608 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * FIX: src/* fix the doxygen warnings.
610 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
611 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
612 was erroneously defined with a size of 15 instead of 16. [many thanks
613 to Jean Michel Rouet for pointing out this bug].
615 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
616 1. Finish merging JMR patch for writting DICOM from scratch
617 2. Fix -hopefully- bug with MONOCHROME and space vs null character
618 3. Use const ref when possible
619 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
620 5. A few more comments
621 6. CreateUniqueUID can now be called without parameter"
623 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
624 * ENH: Slightly bigger patch:
625 1. Getting toward full integration of JMR patch for writting dicom from scratch
626 2. Update Test to test part of this patch: CreateUniqueUID
627 3. File was not close properly in gdcmDict
628 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
629 5. Use of const ref instead of copy (speed issue)
630 6. Remove temporary (duplicate) string in TranslateToKey
631 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
632 8. Do not repeat virtual in subclasses
633 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
635 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
636 * Apply first patch toward better string comparison when dealing with broken
637 DICOM files. Essentially the string could be padded with a space instead
638 of a null character as defined by standard
640 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
642 because never used... and in the same time, that's remove some memory leaks
644 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmFile.cxx : now delete the PixelConvert instance.
646 * In examples and tests : change the type of image data variables from void*
647 to uint8_t*. Remmove all delete on image data variables
649 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
651 Verify the file pointer value before open the file, and if it's not null,
652 a verbose message is generated.
653 Close correctly the file when the file isn't considered dicom-like. The
654 correctly close is a call to CloseFile.
655 When closing the file pointer, test if its not null to close the file.
656 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
657 file. For an uncompressed image, the copied data correspond in the least
658 case to the image size (calculated) or the image size specified in the
659 header. A verbose is generated if these two size mismatch
661 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
663 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
664 break under windows (with msvc6 compilation).
666 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
668 compiling with MSVC6)
670 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * Bugs fix for the Windows build with VC6
672 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
673 needed (only for projects required VTK). If the VTK is included in all
674 projects, there is conflicts with the jpeg lib of vtk when compiling the
675 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
676 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
677 when compiling the gdcm_wrap.cxx file (created by the compilation of the
679 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
680 (like it's already made for the cout use). Otherwise, conflict with the
683 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
686 - comments on the DicomDir::Method related usage added.
687 - now that we use the namespace gdcm, a lot of internal classes do
688 NOT need to be wrapped anymore.
689 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
690 DicomDir::Method) new example added.
692 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
693 * Improve string manipulation. I now inforce the notion of 'DicomString'
694 A DicomString can contain as many \0 as they want
695 and it is *always* of even length.
696 We only support odd length for very rare case.
697 And in the near future this should be removed.
699 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
700 * /binary_write/ gdcm source. Now even on big endian we are writting
701 little endian. This should -heopfully- fix some tests
703 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
704 * Now the dictionary is compiled into gdcm lib. This is a default
705 behavior, thus any dic file specified is picked before failback to
706 the one comiled into lib
708 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
709 * Change internals for gdcmDict. Don't use any 'new' any more.
710 This should definitely solve any leak problem, and we should be
711 as fast as before, as long as don't modify too much the dictionary.
713 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
714 * STYLE: ivars should start with a capital letter.
715 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
716 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
718 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
720 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
721 new 2004 dictionaries added (thanks to JPR).
722 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
723 * CLEANUP_ROUND (15) for gdcmPixelConvert
724 - RLEFrame::NumberFragments is now of type unsigned int
725 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
726 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
729 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 * Initial work in gathering all transfer syntax accessors. clearly
731 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
732 ivars, but only one transfersyntax (class) ivar with equivalent method on
735 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
736 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
737 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
738 discussed (plus I didn't like having a 2000 lines patch not commited)
740 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
742 * CLEANUP_ROUND (14) for gdcmPixelConvert
743 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
744 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
745 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
747 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
748 anymore and hence avoids storing a copy of PixelConvert::Decompressed
749 into File::Pixel_Data.
751 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
753 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
754 * CLEANUP_ROUND (13) for gdcmPixelConvert
755 Substituted File::ParsePixelData() with PixelConvert::Print() new
757 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
758 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
759 method to those classes.
760 - src/gdcmFile.[cxx|h]:
761 -- Added a ::Print() method.
762 -- PixelConverter is now a reference instead of a member.
763 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
764 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
766 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
768 collaboration diagram and inheritance diagram should be generated with
770 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
771 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
772 pointlessly wrapped (see
773 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
774 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
775 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
776 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
777 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
778 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
779 -- File::Initialise: PixelConverter setup moved away to
780 PixelConverter::GrabInformationsFromHeader()
781 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
782 interpretation moved away to PixelConverter::BuildRGBImage()
784 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
785 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
786 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
788 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
790 displayed on Win32 when a brutal abort() occurs (because of uncatched
791 exception). See TODO new entry of this commit for more on this.
792 * TODO added new entry.
793 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
794 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
795 - HandleColor is no longer called from gdcmFile.cxx
796 - gdcmPixelConvert.cxx clean up on method arguments and internal
797 variable names for semantical coherence.
799 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
800 * Finished lossless transition, not only do we now read all lossless jpeg
801 images, without the need of the Cornwell lib, but we do read them properly now
802 * To reduce code (well to avoid code duplication), I defined a common place
803 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
804 redefine symbols. This is not perfect but this the best solution I found for a
805 compilation time jpeg option.
807 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * Update jpeg ijg lib to support lossless jpeg implementation
809 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
811 * Also added a special copyright for dcmtk since we use their bugfixes.
814 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
816 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
817 matters, as stated in warning note at begining of %include section).
818 * src/gdcmDicomDir*.[cxx|h]: coding style
819 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
820 * src/gdcmJpeg8.cxx: doxygen fix.
821 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
822 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
823 from File:: to PixelConvert::.
825 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
827 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
828 - more code moved away from File:: to PixelConvert::
829 - fat setup of PixelConverter set in place in File::Initialise.
831 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
832 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
833 namespace at the file system level. So now you should convert your examples
835 gdcmHeader -> gdcm::Header
836 It would be nice if people keep in mind to no open the namespace, since it
837 allows compilation on broken plateform which were defining common symbol in
838 the standart namespace (like LP, Unknown ...)
840 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
842 The JPEG fragments are now parsed at the same stage than the RLE
843 information. All code related to JPEG is now in gdcmPixelConvert:
844 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
845 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
846 export a gdcmFile:: method. Those are simply global functions
847 (for the time being this is better than having them attach to
848 either gdcmFile:: or gdcmPixelConvert::).
849 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
850 and stores the result in a gdcmJPEGFragmentsInfo.
851 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
852 code (among other stuff) moved away from gdcmFile:; to
855 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
857 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
858 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
859 clean up of RLE related code.
860 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
861 - src/gdcmRLE.cxx removed
862 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
863 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
864 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
865 * CLEANUP_ROUND (9) for gdcmPixelConvert
866 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
867 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
868 away from gdcmFile:: to gdcmPixelConvert::.
870 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
872 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
873 This is because Parse7Fe0 used to parse the pixels to compute the
874 length. This task was passed over to FindDocEntryLengthOB() a long
875 time ago, EXCEPT I had forgotten the OW case...
876 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
877 we just recylce the code for parsing RLE fragments and computing
879 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
880 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
881 with the retired Parse7Fe0().
882 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
883 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
885 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
886 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
887 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
888 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
889 - src/CMakeLists.txt: alphabetic order reodering + new entries.
890 * CLEANUP_ROUND (4) for gdcmPixelConvert
891 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
892 to return an unused length.
894 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
895 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
896 this should be cleanner from the plane view. The iostream are erally a pain
897 to use to do simple stuff.
899 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
900 * Redo the compilation of the ijg jpeg library. Now only one source is
901 necesseray. No need to rename file by hand what so ever. CMake handle the
902 copying of the file within different directory, configure header file to
903 modify some symbol. The only addition made to ijg wasd a mangle table so
904 that symbol are different whether we are within 8bits or 12bits.
906 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * Added documentation of vtkgdcmReader on Website:
908 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
909 with it's binary name).
910 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
911 the Website to be more complete.
912 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
913 doxygenated documentation.
914 - Doc/DoxyVtkGdcmReaderExamples.txt added
915 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
916 DoxyVtkGdmReaderExamples.html )
917 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
918 * CLEANUP_ROUND (3) for gdcmPixelConvert
919 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
921 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * CLEANUP_ROUND (2) for gdcmPixelConvert
923 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
925 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * CLEANUP_ROUND for gdcmPixelConvert:
927 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
928 - src/gdcmPixelStuff[h|cxx] removed
929 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
930 - src/CMakeLists.txt changed accordingly
932 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
933 gdcmVersion.py moved to newly created ATTIC related
934 gdcmPython/SetupOldies/ directory.
935 * Autotools clean up:
936 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
937 - autogen.sh configure.in acinclude.m4 python.m4 removed
939 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * src/*.cxx *.h Reference to License.htm fixed to License.html.
941 * Doc/CMakeLists.txt, doxygen.config.in: fix.
942 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
944 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * TODO updated with Mathieu suggestions. I proposed a template for
946 describing TODO entries and used it for new entries.
947 * Added Doc/Website/CodingStyle.html, Developpers.html,
948 DeveloppersPython.html, GdcmDataCvs.html and
949 DownloadVersion0_1.html, DownloadVersion0_3.html.
950 * Some Doc/*.txt Doxygen files (which do not really concern the
951 documentation itself, but the website) moved to html and
952 placed in directory Doc/Website:
953 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
954 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
955 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
956 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
957 * CMakeLists.txt changed accordingly.
958 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
959 DeveloppersPython.html
960 * INSTALL nows refers to Doc/Website/Installation.html
962 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * Added Doc/Website directory, that contains a first raw version
966 2004-09-23 Jean-Pierre Roux
967 * FIX In order not to be poluted any longer by casting problems,
968 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
969 we can now delete[] it safely
970 * VoidArea is now called BinArea (less confusing name),
971 and all the methods called ...VoidArea... are now ... BinArea...
972 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
974 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
976 clear) TagHT, which is an inherited member of gdcmElementSet. It is
977 up to the destructor of gdcmElementSet to clean up TagHt and it's
980 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * Test/CMakeLists.txt: update to follow gdcmData renamings.
982 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
984 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * ENH: added some utility method that builds a flat dictionary
986 holding all the Dicom entries contained in the recursive structure
987 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
989 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
990 BuildFlatHashTable() that build a flat dictionary.
991 - src/gdcmElementSet.h: added a new private GetTag() accessor.
992 gdcmDocument is now a friend of gdcmElementSet.
993 - src/gdcmElementSet.cxx: clean up.
994 - Example/FlatHashTablePrint.cxx added.
995 - Example/CmakeLists.txt changed accordingly
997 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
999 moved away from gdcmDocEntrySet (since this class is an abstract class
1000 acting like an interface). SQDepthLevel and BaseTagKey are now
1002 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1003 and associated accessors. Doxygenation of the class.
1004 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1006 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1007 Use SQDepthLevel accessor instead. ::Print() adapted.
1008 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1009 - src/gdcmDocument.cxx changed accordingly.
1011 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1013 - The following is the doxygen comment of the typedef declaration
1014 of gdcmTagKey in src/gdcmCommon.h:
1015 gdcmTagKey is made to old an "universal" (as in URL, Universal
1016 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1017 A dicom tag always has a group and an element, but a set of tags
1018 embeded in various (optionally nested) sequences and sharing
1019 the same group and element all share the same (group, element)
1020 "identifier". Hence the (group, element) cannot be used as an
1021 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1022 In order to construct a proper tag identifier (i.e. a key) we
1023 consider the following definition of a TagKey:
1024 - let Group, Element be the string representation of the
1025 group and element dicom tag members,
1026 - let ItemNumber be the string representation of the integer
1027 index of the considered item number of a sequence,
1028 Let the key of a tag embeded in a sequence, noted SeqTag, be
1030 /ItemNumber#Group|Element
1031 where "/", "#" and "|" are characters acting as separators.
1032 Then the general form of a gdcmTagKey is given by:
1033 Group|Element<SeqTag>
1034 where <SeqTag> means NO or many instances of SeqTag.
1035 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1038 but the gdcmTagKey of a tag "embeded" is the first item of
1039 a sequence, itself nested in the third item of a sequence is the
1041 0004|1220/2#0008|0082/0#0008|0090
1042 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1043 order to hold the new sequence compatible key. Previously, the
1044 GetKey() method would look in the underlying gdcmDictEntry.
1045 - src/gdcmDocEntry.cxx:
1046 -- constructor now copies the underlying DictEntry key, in the local
1048 -- ::Print: displays the member Key, instead of the (group, element).
1049 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1050 - src/gdcmDocEntrySet.h:xi
1051 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1052 -- now has a new BaseTagKey member.
1054 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1055 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1057 This poses the problem with the semantics of the following lines
1058 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1059 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1060 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1061 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1062 to the long FIXME note for what the problem is. Nevertheless in
1063 order to get things working the dicom dictionary was altered !
1064 Please fix things urgently...
1065 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1066 information), see above note on moving the member VoidArea. Nevertheless
1067 the following entries previously correctly set as US are now inproperly
1069 0028 1201 OW IMG Red Palette Color Lookup Table Data
1070 0028 1202 OW IMG Green Palette Color Lookup Table Data
1071 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1072 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1073 of gdcmDocEntry moved to gdcmSeqEntry.
1074 * src/gdcmSeqEntry.cxx: STYLE.
1076 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1077 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1079 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * gdcmPython/testSuite.py: all the test suite in python is now moved
1081 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1082 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1083 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1085 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1087 to avoid inclusion recursion until STL is reached.
1088 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1089 mecanism. errno.h is not included in gdcm anymore.
1090 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1091 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1093 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1094 gdcmData/TestAllEntryVerifyReference.txt
1095 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1096 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1097 exception_on_error parameter.
1098 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1099 - vtk/vtkGdcmReader.cxx changed accordingly,
1100 - Example/*.cxx and Test/*.cxx changed accordingly.
1102 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1104 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1105 enable_sequences removed from gdcmHeader constructor and dependencies.
1106 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1107 * gdcmPython/demo/PrintHeader.py: dummy fix.
1108 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1109 skip_shadow removed from gdcmHeader constructor and dependencies.
1110 * Example/*.cxx and Test/*.cxx changed accordingly.
1112 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1113 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1114 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1116 2004-07-21 Jean-Pierre Roux
1117 * FIX Now, Parsing and Printing a DICOMDIR do work!
1118 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1120 2004-07-20 Jean-Pierre Roux
1121 * FIX Some brain damaged headers have Zero-Lenght fields
1122 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1124 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1125 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1126 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1127 variable (instance of gdcmDebug) by a definition macro, and the instance
1128 is now in static in the gdcmDebug class
1129 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1130 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1132 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * WARNING: ctest now depends more tightly on gdcmData. You should
1134 check out gdcmData properly for things to run smoothly...
1135 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1136 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1137 we need the pixels not be loaded in order to use the ValEntry
1138 that displays position and size).
1139 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1140 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1141 be deprecated. If you have any doubts about the advantages of a
1142 modern scripting language (read Python) versus grass root C++ (i.e.
1143 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1144 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1145 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1146 Anyhow, consider documenting the gdcmData images in
1147 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1149 * Test/CMakeLists.txt:
1150 - now uses TestAllEntryVerify.cxx
1151 - specific comments on oldACR00001.ima (now renamed in gdcmData
1152 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1153 gdcmData/TestAllEntryVerifyReference.txt
1156 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * src/*.[h|cxx] : typedef clean up
1158 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1159 - TagKey renamed to gdcmTagKey (for external usage)
1160 - VRKey renamed to gdcmVRKey (for external usage)
1161 - removal of typedef duplication.
1162 - Removed all unecessary inline keyword from class inline definitions.
1163 - Some method|function(void) declarations replaced with method|function().
1164 * src/jpeg/libijg12/jdhuff12.c:
1165 - printf polluting ctest removed.
1166 - TAB removal for comminting
1168 - TestAllReadCompareDicom.cxx: added a test that compares all the
1169 images in gdcmDataImages.h with corresponding images in
1170 gdcmData/BaselineDicom/. When baseline images are not present
1171 this test creates them.
1172 Note: we need to validate each reference image, but before that
1173 I'd like to rename them with a more explicit name...
1174 - CMakeLists.txt: changed accordingly.
1175 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1176 including each header needed).
1178 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1180 test suite to the Example directory. Are concerned:
1185 - TestWriteSimple.cxx
1186 * Test/CMakeLists.txt: added some comments on reasons for black listing
1187 image gdcmData/oldACR00001.ima
1189 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * Test/CmakeList.txt: removed the following from black list (to be coherent
1191 with removal from gdcmData):
1192 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1193 - gdcm-MR-PHILIPS-16.dcm
1195 Added the following because after last cvs update, they cause
1196 ctest -R TestReadWriteReadCompare
1198 - gdcm-MR-SIEMENS-16-1.acr
1200 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1201 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1202 new comments in this file) we temporarily (sigh) move to a weaker
1204 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1205 we don't need to black list the following images anymore:
1206 - 8BitsUncompressedColor.dcm
1208 - US-PAL-8-10x-echo.dcm
1209 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1210 fixes and the beautified code ;-)
1211 This fixes the bug introduced in version 1.42 (when beautifying)
1212 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1213 Note: ctest was blind to this bug (this means we need to still
1214 improve the test suite). The bug could be detected by using
1215 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1217 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1218 and by displaying the (garbage) produced file temp.XDCM...
1220 2004-06-29 Jean-Pierre Roux
1221 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1222 - replace by uggly but working old code :-(
1223 A lot of things should be OK again.
1224 It's really urgent to have a test suite that *tests*,
1225 to prevent Frog's beautifying sessions to break all the stuff
1226 (twice, withing a fortnigh ...)
1228 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1230 redundancy) to added Test/TestReadWriteReadCompare.cxx
1231 * Test/CmakeList.txt: because the compare test of
1232 Test/TestReadWriteReadCompare.cxx fails, the following images are
1233 black listed: - 8BitsUncompressedColor.dcm
1235 - US-PAL-8-10x-echo.dcm
1236 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1237 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1238 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1239 and ad-hoc kludge. This kludge is now removed, and on encountering
1240 such an image (OB field brain damaged) we set errno. Then in
1241 ::FindDocLength() we "fix" the length as being ALL what remains
1242 in the file (until EOF). We then proceed, hoping for the best...
1243 This fixes a SegFault in ShowDicom when trying to write such an
1245 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1246 (because TestWriteRead breaks on it, after a non conformal commit?).
1247 ctest now runs properly, except for MakeDicomDir (which was always
1248 broken) and the Python related stuff (still not fixed).
1250 2004-06-24 Jean-Pierre Roux
1251 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1252 FIX : Test/TestReadWrite now iterates on all the file names
1253 (instead of infinite loop)
1254 ENH : Test/TestWriteRead now iterates on all the file names
1256 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1259 2004-06-24 Jean-Pierre Roux
1260 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1261 when SamplesPerPixel =3
1262 - now Write is no longer confused by
1263 'BitsAllocated = 12" and 'BitsStored=12"
1264 - "UN" value representation Elements are now written correctly
1265 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1266 ENH : - now gdcmHeader has its own Write methods
1267 (in order to split the job that has not to be done
1270 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1272 loop on the same image until memory went out.
1273 Note: this means we still have gobs of memory loss in PrintDocument
1274 * src/gdcmDocument.cxx: fixes problem on parsing on file
1275 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1277 2004-06-24 Jean-Pierre Roux
1278 FIX : Write - All the Sequences and Sequence Item are now written
1279 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1280 is added a the end, when necessary.
1281 - A lot of brain-damaged images, that were read correctly are
1282 now written correctly
1283 - length compatible BinEntry are now loaded correctly
1284 (even for odd groups)
1285 Note : only Explicit Value Representation was checked.
1286 (question : is implicit VR really necessary for gdcm ?)
1288 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1289 * DEVELOPPER: added a proposition of coding style.
1290 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1293 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1295 Use the gdcmDocEntry::Print() and Write() instead.
1296 * src/gdcmDocument.cxx: bug fix.
1298 2004-06-22 Jean-Pierre Roux
1299 FIX : gdcmDocument.cxx
1300 - Now we do recognize the JpegLossLess format (there was a misstyping in
1301 code 'beautyfication' :-(
1302 - Now we automaticaticaly load the Luts, if any
1304 2004-06-22 Jean-Pierre Roux
1305 In order : to write Sequences, whatever their imbrication level,
1306 : to allow user to create his own Sequences
1307 a lot of modif where necessary (adding, moving, or virtualising methods)
1309 WARNING : save your own sources *before* cvs up !
1312 ADD virtual void Write(FILE *fp, FileType filetype);
1315 ADD virtual void Write(FILE *fp, FileType filetype);
1316 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1319 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1320 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1321 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1322 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1323 ADD std::string GetEntryByName(TagName name);
1324 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1326 std::string vr = "unkn",
1327 std::string fourth = "unkn",
1328 std::string name = "unkn");
1329 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1330 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1331 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1332 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1333 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1334 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1335 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1336 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1339 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1340 ADD virtual std::string GetEntryByName (TagName tagName);
1341 ADD virtual std::string GetEntryVRByName (TagName tagName);
1342 REM virtual bool Write(FILE *, FileType);
1343 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1344 FILE *_fp, FileType type);
1345 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1346 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1347 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1348 REM virtual std::string GetEntryByName (std::string tagName);
1349 REM virtual std::string GetEntryVRByName (std::string tagName);
1350 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1351 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1352 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1354 std::string vr = "unkn",
1355 std::string fourth = "unkn",
1356 std::string name = "unkn");
1357 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1358 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1359 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1360 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1363 ADD virtual void Write(FILE *fp, FileType filetype);
1366 ADD virtual void Write(FILE *fp,FileType filetype);
1369 ADD virtual void Write(FILE *fp, FileType filetype);
1370 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1371 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1372 REM std::string GetEntryByName(TagName name);
1375 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1377 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1379 The default constructor invoked by the line
1380 gdcmHeader *f1 = new gdcmHeader( header );
1381 was gdcmHeader::gdcmHeader(bool) instead of the expected
1382 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1383 Hence the parsing wasn't executed... See also below.
1384 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1385 as explicit constructor didn't do the trick to fix the above problem.
1386 Could anyone explain why ?
1387 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1388 properly calls gdcmValEntry::Print() (that was weed out from
1389 code related to gdcmBinEntry).
1391 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1392 * In order to fix memory leaks:
1393 - Test/TestWriteSimple.cxx: added cleaning of free store through
1395 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1396 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1397 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1398 (through the call to ::AddDicomDirMeta()) or the destructor
1399 would crash when deleting uninitialized ::metaElems].
1400 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1401 - src/gdcmDocument.cxx:
1402 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1403 from dynamic stores.
1404 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1405 was causing memory leaks.
1406 - src/gdcmSQItem.cxx:
1407 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1408 cleanly handled with polymophism: sorry but my milage is low).
1409 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1410 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1411 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1412 This avoids SegFaulting.
1413 - src/gdcmSQItem.h: coding style.
1415 - Test/TestWriteSimple still severely sucks. The output image content
1416 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1417 damaged when displayed with vtkgdcmViewer.
1418 - on memory leaks: TestWriteSimple leaks really less (see entry
1419 of 2004-06-18 in Changelog file for the call to valgrind).
1420 - on segfaults: ctest now passes all the tests but one (no more
1422 * Erroneous leading white fix:
1423 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1424 white[s] (as opposed to from >> xxx, that removes it [them].
1425 - src/gdcmTS.cxx: ditto.
1426 - gdcmPython/testSuite.py: dirty related kludge removed.
1427 * src/*: remaining references to gdcmParser removed.
1428 * src/*[cxx|h]: added copy[way]left header.
1431 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1432 * In order to fix writing of dicom files:
1433 - Test/TestWriteSimple.cxx: a simpler example of writing.
1434 - Test/CMakeLists.txt changed accordingly.
1435 - src/gdcmDocument.cxx:
1436 -- The destructor now recursilvely removes potential sequences.
1437 -- Bug fix in ::IsJPEG2000()
1438 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1439 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1441 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1442 to only declared) and build on top of
1443 ::GetDocEntryByNumber(guint16, guint16).
1444 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1445 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1446 for usage in destructor and treatement of promotion in
1447 ::ReplaceOrCreateByNumber().
1448 - src/gdcmSQItem.cxx: destructor should better handle his job.
1449 Test/TestWriteSimple now runs (or at least it DOES something).
1450 * We can now start hutting memory links. A good starting point is:
1451 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1452 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1453 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1455 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * Valgrind note: after Mathieu Malaterre teached me how to read
1457 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1459 Using gcc, you can force the STL to use malloc and to free memory as
1460 soon as possible by globally disabling memory caching.
1461 With 3.2.2 and later, you should export the environment variable
1462 GLIBCPP_FORCE_NEW before running your program.
1463 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1464 simply vanish (it is still not clear to me, whether this means that
1465 STL std::string leaks or if valgrind believes it leaks...).
1466 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1467 running bin/gdcmTests makeDicomDir):
1468 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1469 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1471 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1472 SegFaulting (I drowned in DicomDir related code when trying to
1473 understand why the list is empty...).
1474 * src/gdcmDocument.h: first BSD license header try.
1475 * Doc/License.txt added.
1477 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * src/gdcmDocument.[h|cxx]:
1479 - Clean up of the Transfer related predicates. They are now all based
1480 on new method isGivenTransferSyntax, that (should) handle properly
1481 the padding problem.
1482 - general clean up, simplification, and coding style.
1483 - Specific clean up of Parse7FE0() (umproperly named actually).
1484 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1486 2004-06-14 Jean-Pierre Roux
1488 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1489 - fix the display of SQItem ordinal number
1490 - add the GetSQItemByOrdinalNumber method
1491 - remove some useless never written private methods
1493 2004-06-14 Jean-Pierre Roux
1495 - adding a constructor taking a gdcmDocEntry as an input param
1496 - ReplaceOrCreateByNumber now returns :
1497 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1498 a gdcmValEntry * if a string value is passed as a param
1500 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1501 according to the param type (no longer sets a gdcmDocEntry)
1502 - GetValEntryByNumber, GetBinEntryByNumber added
1503 - NewValEntryByNumber and NewBinEntryByNumber added
1505 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1507 - GetSQItemNumber and SetSQItemNumber added, to provide
1508 a (relative) Item identier inside a given Sequence
1509 \warning : some pb remaining around this number
1511 - AddEntry now takes the Item Number as a param
1513 - adding a constructor taking a gdcmDocEntry as an input param
1515 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1516 * Memory leak hunt with the following command:
1517 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1518 --show-reachable=yes gdcmTests PrintDocument
1519 It looks like many (all?) leaks are due to the STL (or a bad usage
1520 of the STL. The lines producing the leaks now have a comment with
1521 a "MEMORY LEAK" tag: you can retrieve them with
1522 grep "MEMORY LEAK" src/*
1523 Here are two typical examples which I can't help fixing:
1528 char * test = "babo";
1529 name = test; //// <--- valgrind detects 960 bytes lost in
1530 //// call to std::string::operator=(char const*)
1531 name.clear(); //// Doesn't help !
1539 std::cout << "Type a bunch of characters followed by RETURN: ";
1540 getline(std::cin, line); //// <--- valgrind dectects a loss
1541 //// of 1320 bytes in call to
1542 /// std::basic_istream<>& std::getline<>
1548 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1549 * src/gdcmHeader.[cxx|h]:
1550 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1551 and related, moved away to gdcmDocument.
1552 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1553 the corresponding protected accessors of inherited class
1554 gdcmDocument, removed ! As a consequence gdcmFile had to be
1555 declared friend of class gdcmDocument (see below).
1556 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1557 - Clean up of undefined or unused methods.
1558 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1559 account the changes to gdcmHeader.h).
1560 * src/gdcmDocument.h:
1561 - gdcmFile is now a friend class (in order to take into account the
1562 changes to gdcmHeader.h).
1563 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1564 (see changes to gdcmHeader.h).
1565 - Accessors (reading on the form GetEntry*) are now public.
1566 - Clean up of undefined or unused methods.
1567 * src/gdcmDocument.cxx:
1568 - adaptation to changes to gdcmDocument.h
1569 - ::OpenFile now writes a verbose message when file cannot be opened.
1570 - some std::string properly set to VRKey
1571 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1572 references to gdcmDocument.
1573 * Test/TestFindTags.cxx: changed accordingly to above changes.
1574 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1575 cvs repository gdcmData.
1577 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1578 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1579 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1580 conflicts with gdcmValEntry::voidArea.
1581 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1582 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1583 Value representation between StringRepresentable and BinaryRepresentable.
1584 * src/gdcmDocument.cxx:
1585 - method ParseDES: proper indentation restored and usage of
1586 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1587 - method LoadDocEntry: the fingerprint left in the SetValue() of
1588 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1589 removed. Reverting to previous code segment with the proper
1590 dynamic_cast< gdcmValEntry* >.
1591 Note: this was (partially) breaking the python test suite
1592 (gdcmPython/testSuite.py) that made usage of the above
1593 fingerprint to check presence of "Pixel Data".
1594 * src/gdcmDocEntry.h: coding style.
1595 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1596 now taken into account.
1597 * gdcmPython/gdcm.i: adaptation to the new internal representation
1598 of gdcm (exit gdcmParser, hello gdcmDocument).
1599 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1601 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1602 anymore, but instead prints the loaded Python dictionary.
1603 * .... alas, the python testSuite is still broken.
1605 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1606 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1608 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1609 * src/gdcmUtil.h : export methods
1611 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1614 * Initial addition of automatic python testing
1615 * Initial addition of automatic image comparison
1617 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1618 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1619 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1621 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1623 * Test/ShowDicom.cxx : bug fix for msvc compilation
1624 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1626 2004-05-04 Jean-Pierre Roux
1627 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1628 new concepts (and new classes) :
1629 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1630 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1631 - Sequence Doc Entries (gdcmSeqEntries)
1632 a Sequence is composed of Items.
1633 Each item is a set of Doc Entries (this is recursive)
1634 The non uniqueness of the 'Dicom tag' is due to this recursivity
1635 (never taken into account)
1636 Our unability to add a new 'entry' in the header
1637 at the proper location (neither in the H-Table (map or multimap),
1638 nor in the Chained List is also due to this recursivity.
1639 Don't try, right now, to use/modify/compile these new sources :
1640 nothing is finished.
1641 We just commit all the stuff, 'as is', in order not to loose it.
1643 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1644 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1646 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1648 file prefix (SetFilePrefix)
1650 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1651 * Add a new test: ShowDicom, for now this is just the c++ version of
1652 checkRead.sh, later it will be able to compare the image read against a
1654 * Replace the DEBUG on the stack with a global entry in cmake interface:
1655 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1657 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1658 * Add an example subdir, with a real example on how to read + write a
1661 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1662 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1663 * Doc/CMakeLists.txt: the main page is now properly differentiated
1664 between the developper and user version.
1665 * Doc/doxygen.config.in: dropped search related obsolete flags
1666 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1668 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1669 * DEVELOPPER: added some helpfull comments for compile/test/install
1672 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1673 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1674 src directory, now generated in the build dir.
1675 2. Tests as mentionned smarter
1677 4. Add a new method in gdcmDict that return the PubDict by name
1678 this is interesting for 3rd party lib like ITK,
1679 where we could set the institution name / patient name...
1681 * ENH: 1. Now the test suite is working for real
1682 2. All binaries are now output in the gdcm-bin directory
1683 (this was not true before)
1685 2004-04-28 Jean-Pierre Roux
1686 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1687 SeQuence indented printing of Dicom Header.
1688 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1689 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1690 Computation of SQDepthLevel is now part of gdcmHeader constructor
1691 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1692 tree-like structure of a Dicom Header.
1693 * FIX Test code cleaning
1695 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * ENH: Adding automatic testing
1697 1. Need a DartConfig.cmake to submit to public
1698 2. Add a test driver gdcmTest.cxx
1699 3. gdcmTestMain, an helper for the main test driver gdcmTest
1700 4. Files in Test don't have a main anymore, this becomes interesting
1701 when we add more and more tests, thus dsw don't have to load
1703 * ENH: Adding a GDCM_DATA_ROOT for testing
1704 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1705 one file instead of seven + some small cleanup
1707 2004-04-22 Jean-Pierre Roux
1708 * ENH Minor changes to the Print() methods.
1709 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1710 Header printing. Example given with :
1711 > PrintHeader fileName 2 new
1712 (SQ based tree-like structure still to be done for the Header ...)
1714 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1716 1. I have added some unsigned where needed
1717 2. Some function parameter not used -> (void)
1718 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1719 4. g++ don't like character '\' in comment
1720 5. #define jpeg_create_decompress jCreaDecompress
1721 this really need to be fixed
1722 6. virtualize destructor of gdcmObject ... leakage
1723 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1724 this also really need to be fixed
1725 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1726 remove compression file
1727 (as we only do decompression, right ?)
1728 * ENH: Change malloc/calloc/free with c++ equivalent
1730 2004-04-21 Jean-Pierre Roux
1731 * FIX gdcmHeaderHelper::GetXSpacing
1732 when a single value is found (bug ?), xpacing is now
1733 defaulted to yspacing
1735 2004-04-19 Jean-Pierre Roux
1736 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1737 * ENH add parameters :
1738 bool exception_on_error = false,
1739 bool enable_sequences = false,
1740 bool ignore_shadow = false
1741 to the gdcmFile constructors to be full gdcmParser compliant
1742 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1743 to allow reading of PAPYRUS 3.0 files
1745 2004-04-06 Jean-Pierre Roux
1746 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1748 2004-04-02 Jean-Pierre Roux
1749 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1750 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1751 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1753 2004-03-30 Jean-Pierre Roux
1754 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1755 for ACR file, written out as DICOM files (hope so...)
1757 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1758 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1759 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1760 moved to base class gdcmParser and only the specialisation is kept
1762 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1763 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1764 already does the job.
1765 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1766 (to be consistent with gdcmParser::WriteEntries).
1768 2004-03-30 Benoit Regrain
1769 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1770 upate of the object's instance. It's passed to 2 in the unfavorable
1771 case : one in the ExecuteInformation, one in the ExecuteData
1773 2004-03-29 Jean-Pierre Roux
1774 * ENH : Check on file type to be written moved
1775 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1776 * FIX : gdcmObject::ResetBoundaries now stops properly
1777 when end-of-list is reached
1778 : gdcmVersion modified (as Benoit Regrain asked)
1780 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1782 * src/gdcmUtil.cxx: added forgotten iostream include.
1783 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1784 equivalent to ExplicitVR in existing code).
1786 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1787 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1788 now contains all the gdcmGlobal related code.
1789 * minor coding style and doxygenation changes.
1791 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1793 now contains all the Debug related code.
1794 * minor clean-up of includes in src/*.cxx
1795 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1796 CreateCleanString) removed.
1797 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1798 * Doc/DoxyMainPageUser.txt added.
1799 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1800 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1801 src/gdcmDirList.cxx)
1803 2004-03-24 Jean-Pierre Roux
1804 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1806 2004-03-23 Jean-Pierre Roux
1807 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1808 big endian made volumes
1809 * ENH Now gdcmParser constructor and destructor are protected to forbid
1810 end user to instanciate class gdcmParser
1811 (only gdcmHeader and gdcmDicomDir are meaningfull)
1813 2004-03-22 Benoit Regrain
1814 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1815 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1816 gdcmSerie to gdcmDicomDirSerie
1818 2004-03-19 Jean-Pierre Roux
1819 * ENH Now the tree-like structure describing a DICOMDIR comming from
1820 an already existing DICOMDIR file is consistent with
1821 the home-made tree-like structure build ex-nihilo
1822 or build from the files held (recursively) in a Directory
1823 functions gdcmDicomDir::CheckBoundaries()
1824 gdcmObject::SetBoundaries() added
1826 2004-03-17 Jean-Pierre Roux
1827 * REM (Eric Boix bug) : removal of meaningless
1828 gdcmDicomDirImage::NewImage function.
1829 * FIX now file names and directory name are written properly in the
1831 * FIX now gdcmDicomDir constructor may be call without any trick
1834 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1835 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1836 of gdcmDicomDirImage::NewImage as empty function.
1838 2004-02-28 Jean-Pierre Roux
1839 * ENH add gdcmDicomDir:NewPatient
1840 add gdcmDicomDirPatient:NewStudy
1841 add gdcmDicomDirStudy:NewSerie
1842 add gdcmDicomDirSerie:NewImage
1843 to allow making gdcDicomDir object.
1844 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1845 (as opposite to the gdcmHeader chained list)
1847 2004-02-11 Benoit Regrain
1848 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1849 when using from python
1851 2004-02-10 Benoit Regrain
1852 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1853 * FIX : in gdcmDicomDir when the directory is empty
1854 * ENH : add callback and methods to get the progression of dicomDir
1857 2004-02-06 Jean-Pierre Roux
1858 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1859 - GDCM_META added to gdcmDicomDirType
1860 - class gdcmMeta created
1861 * ENH : - A brief summary is now displayed at the beginning of
1862 'testDicomDir' to help disaster magnitude estimation
1863 * REM : Now useless Test/explDICOMDIR.cxx
1865 2004-02-05 Benoit Regrain
1866 * ENH : add methods in gdcmObject to get the hash table or the list of
1868 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1869 * FIX : wrapping python for TagHeaderEntryHT
1871 2004-02-04 Benoit Regrain
1872 * FIX : even length for some strings when writting the dicom dir
1873 * FIX : sort the images in the dicom dir
1874 * FIX : Bug fix for python use of dicom dir
1875 * ADD : a python demo
1877 2004-02-04 Jean-Pierre Roux
1878 * FIX : Final solution (?) for icone embedded images
1879 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1880 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1881 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1882 gdcmData/gdcm-MR-SIEMENS-16.acr1
1883 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1884 to make full checking easier
1886 2004-02-04 Benoit Regrain
1887 * FIX : WriteEntries : coding style & logic in parameters
1888 * FIX : Set the elements to create the DicomDir in a dictionary file
1890 2004-02-03 Benoit Regrain
1891 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1892 * gdcmDicomDir : add the load of directory
1893 * Bug fix and print add-on
1895 2004-02-03 Jean-Pierre Roux
1896 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1897 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1898 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1899 * FIX gdcmParser.cxx : 'group length' elements are now considered
1900 as integers, even for shadow groups, when file is Implicit VR
1902 2004-02-02 Jean-Pierre Roux
1903 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1905 of the last synonym :-(
1906 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1908 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1909 * FIX taking into account the possible 7fe0,0010 multiplicity
1910 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1911 to allow removal of references to 7fe0,0010, to deal with
1912 ACR-NEMA images, when 0028,0200 is meaningfull
1914 2004-01-31 Jean-Pierre Roux
1915 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1916 no longer writes 'Un' on disk
1917 * FIX SQ elements with actual length are now dealt with corectly
1918 * FIX gdcmFile::WriteBase make the difference, for color images, between
1919 the length (for Palette expanded images)
1920 and Raw Length (non expanded image + Palette)
1921 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1922 (that broke Write). Replaced by UL.
1923 Aware user will reload the field if he
1924 thinks it's necesssary
1926 2004-01-30 Jean-Pierre Roux
1927 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1928 when 'dirty Acr' is found, to be compliant with the new
1929 IsReadable() methods.
1931 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1932 (no DOUBLE images in kosher DICOM,
1933 but so usefull for people that miss them ;-)
1935 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1936 DICOMDIR related utilities (not checked as Windoze compliant)
1938 2004-01-28 Jean-Pierre Roux
1939 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1941 2004-01-27 Jean-Pierre Roux
1942 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1943 to allow skipping the shadow elements, to save memory space.
1944 The TRUE value for this param has to be used
1945 with a FALSE value for the 'enable_sequence' param.
1946 ('public elements' may be embedded in 'shadow Sequences')
1947 * gdcmHeader methods now deal with 'embedded icones images' in the header
1948 (even when an 'icone image sequence' is announced by the
1949 element (0x0088,0x0200), but there is NO icone at all ...
1951 * gdcmHeader sometimes Image Location value doesn't follow
1952 the supposed processor endianity (see gdcmData/cr172241.dcm).
1955 * gdcmHeader add the method
1956 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1957 to get *all* the Header Entries with the same tag.
1958 GetHeaderEntrySameName is probabely *useless*
1959 (no meaning : Name is *not* an identifier within the Dictionary)
1961 2004-01-26 Benoit Regrain
1962 * Bug fix in the print of hexadecimal representations. Remove long fields
1963 in the print and add a third level of print to print them
1965 2004-01-23 Benoit Regrain
1966 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1967 * Bug fix on test suite after remove the strip made on not string fields
1968 * Split the IsReadable method between gdcmParser which test that the file
1969 is dicom and gdcmHeader which test that it's an image file
1971 2004-01-22 Benoit Regrain
1972 * DicomDir : clean code, add methods, set variables in protected or private
1973 * gdcmUtil : bug fix for the clean string method
1975 2004-01-19 Benoit Regrain
1976 * Add the use of shadow dictionaries
1977 * bug fix and coding style
1979 2004-01-19 Benoit Regrain
1980 * src/gdcmFile.cxx : bug fix concerning the close of file
1981 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1982 * Add the update of header entries using the shadow library
1984 2004-01-19 Benoit Regrain
1985 * removal of file gdcmHeader2.cxx
1986 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1987 inheriting from gdcmParser. This split is to prepare the integration
1988 of dicom dir parsing
1989 * bug fix under python
1991 2004-01-16 Jean-Pierre Roux
1992 * REM removal of class gdcmHeaderEntrySet
1993 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1994 * ADD add file gdcmHeader2.cxx
1995 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1997 2004-01-15 Benoit Regrain
1998 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1999 entries created while parsing the header. Thus, they will be destroyed
2000 when the gdcmDictSet will be destroyed
2001 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2004 2004-01-15 Benoit Regrain
2005 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2006 made a fatal error because of the memory release at the end of program.
2007 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2008 some memory and vtk seems to have some problems with that.
2009 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2011 2004-01-14 Benoit Regrain
2012 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2013 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2014 * src/*.[h|cxx] : make changes due to class name changes
2015 * gdcmPython/demo/*.py : bug fix due to method names
2017 2004-01-13 Benoit Regrain
2018 * src/*.[h|cxx] : coding style
2019 * vtk/*.[h|cxx] : coding style
2021 2004-01-13 Benoit Regrain
2022 * gdcmPython/testSuite.py : test the readable flag of file for tests
2023 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2024 It's lied to the stl compilation by MSVC (windows, always windows...)
2025 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2027 2004-01-12 Benoit Regrain
2028 * src/*.h : add comments
2029 * src/gdcmDictSet.h : set the method BuildDictPath in public
2030 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2031 directly setted in the source code
2032 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2035 2004-01-09 Benoit Regrain
2036 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2037 * setup.py : use a reference to gdcmVERSION
2039 2004-01-07 Benoit Regrain
2040 * Modification to compile with the distutils.
2043 2003-12-10 Benoit Regrain
2044 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2045 can use a gdcmHeaderHelper to load data
2046 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2047 made in the source code
2049 2003-12-10 Benoit Regrain
2050 * Update Windows projects and .cvsignore files
2052 2003-11-12 Jean-Pierre Roux
2053 * ENH gdcmHeader constructor has one more parameter (default value : false)
2054 that allows the user to 'go inside' the SeQuences only
2056 gdcmElValSet:Print takes it into account
2058 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2059 * ENH: Update gdcmPython/CMakeLists
2060 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2061 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2063 2003-11-10 Jean-Pierre Roux
2064 * FIX : gdcmHeader::LoadElements is now based
2065 on the ListTag listElem member,
2066 not longer on the TagElValueHT tagHt member
2067 * ENH : PrintPubElVal shows (temporarily) both results,
2068 with the tagHt member and the listElem member.
2069 (it's easier to 'see' the problems when using Printheader)
2071 * FIX : old private member LgrElem is now splitted into
2072 ReadLength : Length actually found on disk (updated only
2073 if bug fixing is necessary), for internal
2075 UsableLength : Updated by FixFoundLength, to fix a bug
2076 or to allow Parser going on.
2077 Will allow to re-write a kosher header when a SeQuence
2078 with a length (not 0000) is found
2079 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2080 because gdcmElValSet::Add does not update ListElem
2083 2003-11-07 Jean-Pierre Roux
2084 * FIX misstyping in Transfert Syntax name table
2085 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2086 when they have an actual length (not 0000 nor FFFFF)
2087 (Nobody should care of it, but DICOMDIR explorers)
2089 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2090 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2092 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * ENH: vtkGdcmReader now supports LUT !
2094 (vtkgdcmViewer for now is not able to use them though)
2096 2003-11-05 Jean-Pierre Roux
2097 * in testSuite.py : new files names for checking the package
2098 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2099 that returns the pixel area size to the *aware* (vtk) user
2100 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2102 2003-11-05 Benoit Regrain
2103 * in testSuite.py : Modify the rules for checking the paths
2104 : Explicit error messages
2105 * in __init__.py : Related modif
2107 2003-11-03 Jean-Pierre Roux
2108 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2109 to be used by aware (vtk) users that want to manage
2110 LUT (and no to turn the PALETTE image into an RGB pixels one)
2111 * GetPixelType now returns 8U for 24 Bits images
2112 (vtkGdcmReader compliant)
2114 2003-10-31 Jean-Pierre Roux
2115 * Removal of *all* gdcmData images and add them again
2116 in order to loose the 'history' of un-anonymised images
2118 2003-10-31 Jean-Pierre Roux
2119 * RMV : removal of useless jBitsInJsample.h
2120 for both 8 and 12 Bits JPEG Lossy Libraries
2122 2003-10-31 Jean-Pierre Roux
2123 * ENH : Add the functions gdcmFile::GetImageDataRaw
2124 gdcmFile::GetImageDataIntoVectorRaw
2125 that act as GetImageData and GetImageDataIntoVector
2126 except the making of an RGB Plane from Gray Plane + LUT
2127 Intended to aware (vtk) users who know how to manage
2130 GetLUTRGBA return a R,G,B,A LUT if any
2131 lgrTotaleRaw gives the 'Raw' length
2132 GetImageDataRaw returns the gray Plane
2133 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2134 (They stay Grey, just like with other Dicom viewers :-(
2136 2003-10-30 Jean-Pierre Roux
2137 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2139 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2141 being coherents dicom files.
2143 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2146 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2147 * ENH: Two steps is necessary to please VC++ compiler...
2148 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2149 * ENH: Add include dir to medcon lib
2150 * FIX: only one function is being exported for now !
2151 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2153 2003-10-29 Jean-Pierre Roux
2154 * adding gdcmHeader::GetLUTRGBA
2155 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2156 --> Mathieu, the modif u're waiting for is not yet committed
2157 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2159 2003-10-27 Jean-Pierre Roux
2160 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2161 00191113.dcm DermaColorLossLess.dcm
2162 MxTwinLossLess.dcm RadBWLossLess.dcm
2163 * ENH: For version prior to vtkImageViewer2 -r 1.19
2164 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2166 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2167 * Removal of ido stuff in CMakeLists.txt
2169 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2171 * FIX: remove a call to ->Modified ... see comments
2172 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2174 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * FIX: Problem with path for libvtkgdcmPython
2176 * ENH: Try adding a search script for python site-package
2177 * RMV: Remove some file from medcon lib that are not necessary
2178 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2179 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2180 * FIX: More pragma disable fro VC++,
2181 I don't think I break something as it is also disable in VTK/ITK.
2182 But it fasten debug compilation time.
2184 2003-10-23 Jean-Pierre Roux
2185 * gdcm now deals with 16 Bits Run Length Encoded images
2186 (they are compressed as 2 planes images,
2187 one for the high Bytes, the other for low Bytes)
2189 2003-10-22 Jean-Pierre Roux
2190 * Now CheckRead takes into account :
2191 - the bugged 'Leonardo' Siemens images
2192 - the XA images, sent thru the burning VPRO station
2193 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2196 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * FIX: When copying a Makefile.am to CMakeLists.txt
2198 one should remove the '\'
2200 2003-10-22 Jean-Pierre Roux
2201 * in gdcmData adding a bugged 'Leonardo' Siemens image
2202 (wrong lengths in header)
2203 OK with gdcm, KO with the other viewers :-)
2204 * add a GE dlx XA image, thru the VEPRO burning station
2207 2003-10-21 Jean-Pierre Roux
2208 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2209 for a brutal checking of vtkgdcmViewer compliance
2211 2003-10-21 Jean-Pierre Roux
2212 * add the files for 'xmedcon' Jpeg Lossless library
2213 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2215 2003-10-21 Jean-Pierre Roux
2216 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2218 2003-10-21 Jean-Pierre Roux
2219 * garbage Siemens 'Leonardo' images dealt with
2220 (the patch is easy to remove)
2221 * cosmetic changes to avoid warnings
2223 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2224 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2225 no need to press 'r' now.
2227 2003-10-20 Jean-Pierre Roux
2228 * upgrade of checkRead.sh checkWrite.sh according
2229 to new Jpeg Lossless decompressor
2230 * add US.3405.1.dcm, a genuine RGB medical file ...
2231 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2232 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2234 2003-10-15 Jean-Pierre Roux
2235 * general anonymisation in gdcmData
2236 * adding the 'color files' from
2237 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2238 * adding some well knowed bugged-header images
2239 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2240 waiting for their inclusion in Python testsuite
2242 2003-10-15 Jean-Pierre Roux
2243 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2244 no longer seg faults when file is not found
2246 2003-10-14 Jean-Pierre Roux
2247 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2250 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * TODO: *.in file to genereate a UseGDCM later
2253 2003-10-14 Jean-Pierre Roux
2254 * Some supposed-to-be Dicom Images have no preamble.
2255 OpenFile takes it into account
2256 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2257 * Missing elements added in dicomV3.dic
2258 (just to be affraid : have a look at
2259 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2260 and do it again next year ;->
2262 2003-10-13 Jean-Pierre Roux
2263 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2264 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2265 But there are NOT. It's fixed !
2267 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * FIX: "jpeglib.h" was not found on VC++
2269 * FIX: vtkgdcm was not being installed
2271 2003-10-10 Jean-Pierre Roux
2272 * ENH : OpenFile closes the file if it *really* doesn't look like
2273 an ACR-NEMA / DICOM one.
2274 * FIX : testWrite no longer writes an empty file if the source file
2275 is not gdcm Readable
2276 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2279 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2280 * FIX: CMake generate now documentation
2281 * ENH: out of source doc build !
2282 * ENH: Generate both user and dev documentation
2283 * ENH: Should work on windows too
2284 * ENH: Only one doxygen config.in file is needed
2285 * FIX: make install should be ok now on ùnix plateform
2286 * FIX: PATH to dictionary was wrong (missing /)
2287 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2289 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * vtkGdcmReader is now able to read rgb dicom file.
2291 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2292 * added a gdcmViewer to vtk test, use mouse to control
2293 window level & window width
2295 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2296 * CMake-ification of gdcm, we have now two build system
2297 * FIX: on cygwin Wsock32 doesn't exist
2298 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2300 2003-10-06 Emanuel Ollart
2301 * FIX : compilation process wad broken.
2302 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2304 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2305 * change gdcmViewer -> vtkgdcmViewer
2306 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2308 2003-10-06 Jean-Pierre Roux
2309 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2310 ( e.g : well known GE images with a wrong elem length,
2311 : Philips MRI Images with a wrong Huffman table)
2312 * still to be done : allow the reading of bugged LEONARDO Siemens images
2314 2003-10-03 Jean-Pierre Roux
2315 * Odd length strings are padded with '\0' (not with spaces,
2316 to remain compliant with already defined strings,
2317 like Transfert Syntax UID and others)
2319 2003-10-03 Jean-Pierre Roux
2320 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2321 to allow displaying RGB images (not only by affim ;-)
2323 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * vtkGdcmReader is now able to read rgb dicom file.
2325 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2327 2003-10-03 Jean-Pierre Roux
2328 * A few nasty patches to allow the reading of a lot of nasty images
2329 ( e.g : well known GE images with a wrong elem length,
2330 : Philips MRI Images with a wrong Huffman table)
2331 * still to be done : allow the reading of bugged LEONARDO Siemens images
2333 2003-10-03 Jean-Pierre Roux
2334 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2336 2003-10-03 Jean-Pierre Roux
2337 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2338 to allow displaying RGB images (not only by affim ;-)
2340 2003-10-03 Jean-Pierre Roux
2341 * gdcmFile::GetImageDataIntoVector now
2342 - deals with MultiFrames MultiFragments Run Length Encoded files
2343 - deals with YcBcR (YBR_FULL) files
2344 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2345 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2347 (no sample found :-(
2349 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2350 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2351 Two reasons: - clear things
2352 - third parties acces gdcm through header files, so won't
2353 suffer anymore VC++ complains
2355 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2356 * add argv[1] in testvtkGdcmReader.cxx
2359 2003-09-24 Jean-Pierre Roux
2360 * The lines are now eigthy characters long.for
2361 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2363 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2364 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2365 char* to std::string. Thus, the use of strdup becomes useless. (see
2366 previous commis of Malaterre)
2367 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2368 before the last Malaterre's commit.
2370 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2371 * This commit should fix the Debug building under VC++, the problem
2372 was mainly a mixture of debug and release lib being loaded at startup.
2373 * I also remove a depency to a specific C function: strdup. Because I had
2374 to force the link to msvcrtd (whereas strdup is in libc).
2376 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2377 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2378 located in the gdcmCommon.h file. All use of reference of tha has been
2379 changed to now use the variable GDCM_UNFOUND.
2381 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2383 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2384 Dicom dictionary. The test suite can now be run again. Note:
2385 I'm note very happy with the " (RET)" changes. I believe this
2386 RETAINED comment should be dropped when parsing the dictionary.
2387 - PACKAGER corrected
2389 - AUTHORS updated and now in alphabetical order
2390 * Makefile.am now exports gdcm.dsw for Windoze users.
2392 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2393 * cygwin complains about missing std:: in subdir Test/
2395 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * remove some methods that are now in gdcmHeaderHelper
2398 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2399 * vtkGdcmReader set spacing and origin correctly
2401 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * Fix a few delete/delete[] mismatch
2404 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2406 interpretation to data given by gdcmHeader. For instance there are
2407 heuristics to get informations (look at different places).
2408 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2409 sorting DICOM images based on different strategies.
2410 * modified Makefiles accordingly.
2412 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2413 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2414 when building in debug mode
2415 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2416 src/win32/gdcmdll.dsp
2417 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2419 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2420 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2423 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2424 * src/win32/libgdcmjpeg12.dsp was not dos format
2425 * src/win32/libgdcmjpeg12.dsp :
2426 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2427 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2429 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2430 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2432 * src/gdcmFile.cxx : bug fix in affectation type
2433 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2434 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2435 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2436 symbols... future problem ?
2438 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2439 * src/win32/libgdcmijpeg12.dsp was missing
2440 * modified gdcm.dsw accordingly
2442 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2445 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2446 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2447 commit of JPR (before his hollidays to facilitate our work).
2448 * setup.py : bug fix in code. Modifications made while the last commit
2449 of JPR. The code hasn't been tested before the commit... it's so
2450 useless to make that (for best programmer that is JPR) !!!
2452 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * tagged the current version as Version0_3 (i.e. version 0.3)
2455 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2456 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2457 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2458 * *.dsp : modifications to use new libgdcmijpeg8 library
2459 * setup.py : bug fix on VTKPATH variable
2460 * PACKAGER : adding all concerning windows
2462 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2465 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2466 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2467 test suite reported error.
2468 * PACKAGER file added (describes what a packager must do when
2469 packaging a new release).
2470 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2471 * configure.in: upgraded version number to 0.3.0
2472 * fixing build of rpm (through rpm -ta):
2473 - Doc/Makefile.am exports proper doxygen files
2474 - src/jpeg/libijg8/Makefile.am exports the include files.
2476 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2477 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2478 * src/gdcmHeader.h : formatting code
2480 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2481 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2482 We were obtaining error message from vtk. Now, creation of file list
2483 is made in an internal list to prevent this problem.
2484 Bug fix when output is empty.
2485 Bug fix in update of progress value. Previous commit for this was a bad
2487 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2489 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2490 * src/gdcmHeader.h : added method to get the file name
2491 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2492 files. Added method to remove all files on the input
2493 Added FIXME comment concerning the bad parsing of header made by
2494 ExecuteInformation method (in ExecuteData method)
2496 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2498 when using make instal.
2499 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2500 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2502 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2503 * setup.py : adding include dir of jpeg lib to compile all sources
2504 * */Win32/*.dsp : JPR fix for windows compilation
2506 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2507 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2509 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2510 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2512 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2513 * setup.py is again effective on un*x (takes into account the
2514 addon of the jpeg library)
2515 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2516 * Doc/Doxy* updated (includes above enhancements)
2517 * INSTALL now points to web documentation
2519 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * src/gdcmHeader.h doesn't make unnecessary reference to
2522 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2524 * src/gdcm*.[cxx|h] :
2525 - to allow compilation with gcc 3.x
2526 -- clean up of STL usage (added explicit usage of std::)
2527 -- small fixes on exceptions.
2528 Note: linking not tested !
2529 - clean of doxygen comments to avoid warnings at documentation
2531 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2532 dependent convertion).
2534 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * Clean up of previous JPR garbage commit (not even commented in the
2537 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2538 - moved all jpeg related files from src to src/jpeg/libijg8, with
2539 addition/modification of Makefile.am and configure.in.
2540 - the testSuite is still brain damage (not guilty).
2542 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2543 * WrapVTK.py : modifications to get correctly vtk source files to
2545 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2546 (FileName -> Filename)
2548 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2549 * vtk/vtkGdcmReader.[cxx/h]:
2550 - UpdateProgress method should now be effective
2551 - removed the limitation on having only images loaded (as opposed
2553 - when building a stack of images/volume, a lesser number of
2554 gdcmHeader and gdcmFile instances should be used (hopefully
2555 accelerating things).
2556 - when building a stack of images/volumes, files which are not
2557 loadable (wrong path-filename, wrong permissions on existing file,
2558 or file not parsable by gdcm) are replaced with a black image
2559 in the stack (for the caller to notice the problem).
2561 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2564 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2565 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2566 between standard library (std) and vtk library (problems are found
2567 under Windows... thanks Windows !)
2569 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2572 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2574 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2575 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2577 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * When compiling with distutils (see setup.py) the C++ compiler is
2579 called with different flags than the default ones (with automake).
2580 In order to fix all those warning, I compiled gdcm with the command
2581 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2582 and went for warning fixes:
2583 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2584 up from unused variables.
2585 - vtk/vtkGdcmReader.cxx: potential bug fix.
2586 * src/gdcmHeader.h: Doxygen warning cleanup
2588 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * gdcmPython/gdcm.i:
2590 - typemaps correction to take into account the systematic replacement
2591 of "using namespace std" with std:: prefix e.g. std::list,
2592 std::string... (cf changes of 2003-05-21).
2593 - gdcmGlob global variable of type gdcmGlobal (defined in
2594 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2595 exported to Python a as cvar.
2596 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2597 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2598 gdcmDictSet.GetPubDictTagNames() and
2599 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2600 C++ static methods).
2601 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2602 with the above changes.
2604 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2605 * setup.py, manifest.in : bug fix under linux
2607 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2608 * Modification of setup.py to compile vtk part too. Then, we have 2
2609 wrappers which must work with same distutils. For that, we have a
2610 generic distutils in distusiltsWrapping.py ; with :
2611 - build_extWrap class to wrap generically all extensions,
2612 - ExtensionWrap base class for all wrapping extension that contains
2614 - Wrapper interface which wrap sources
2615 + In WrapSwig.py we have extension and wrapper for Swig
2616 + In WrapVTK.py we have extension and wrapper for VTK
2617 * MANIFEST.in : modifications to consider vtk directory and new python
2618 files for compilation
2620 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2621 * Added python wrappers of vtkGdcmReader vtk class (see the
2622 source in vtk/vtkGdcmReader.cxx) :
2623 - vtk/Makefile.am now builds a library
2624 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2625 python library (as opposed to _gdcm.so wich are the python
2626 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2627 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2629 - configure.in has an additional flag --enable-vtk that needs
2630 to be set to enable compilation of vtk related code, that is:
2631 + vtk/vtkGdcmReader.so and
2632 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2633 + gdcmPython/vtkgdcmPython.so (see above)
2634 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2635 be read when compressed or when HighBit + 1 != BitsStored),
2636 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2637 the usage of the python wrapper of vtkGdcmReader vtk class.
2638 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2639 * src/*.[h] all occurences of stl classes are now prefixed with
2640 std::, and all occurences of "using namespace std;" where removed.
2641 This is to avoid pollution of global namespace in included files.
2642 Apparently vtk does not avoid this pitfall: when using both
2643 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2644 collision of various stl members (principally cout...).
2645 * gdcmPython/testSuite.py now cleanly removes temprory generated
2647 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2648 comply with above changes)
2650 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2651 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2652 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2653 vtk data structure (an image Flip was required).
2654 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2655 * cosmetic changes in documentation.
2657 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2658 * src/gdcmHeader.cxx: the constructor no longer exits when an
2659 unexisting file is given as argument.
2660 * The subdirectory Data (containing all the images used for the
2661 test suite) is not part of this repository anymore. A new module
2662 containing those images is now available at
2663 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2664 with the name gdcmData.
2665 All the python scripts (including the package initialisation file
2666 gdcmPython/__init__.py) were adapated to take this change into
2667 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2669 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2670 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2671 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2672 demo of the usage of this class.
2673 Compilation of this vtk part is only done when using the --enable-vtk
2674 at configure (or autogen.sh) stage.
2676 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2677 * More memory link related corrections and documentation fixes.
2679 - maximum info is obtained with a command of the form:
2680 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2681 --show-reachable=yes PrintHeader
2682 - the remaining reachable blocks seem to come from the STL
2683 allocation scheme through the usage of map and list. It looks
2684 like this memory cannot be freed but it is not a memory leak
2685 (in fact further invocation to the STL would recollect the
2686 unused memory allthough it cannot explicitely be freed).
2687 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2688 of displaying an image parsed with gdcm and displayed with VTK.
2689 Note: some images don't seem to work e.g.
2690 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2691 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2692 Allthough this weakens the semantics, it is a ditch attempt to
2693 make gdcm more thread friendly.
2695 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2696 * Memory link hunt (by using valgrind through the command
2697 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2698 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2699 gdcmHeader::_dicom_vr.
2700 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2701 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2703 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2705 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2706 * src/Makefile.am now exports all the necessary include files at
2710 * UpdateGroupLength replaced by new one
2713 * UpdateGroupLength re-written using H-Table
2714 (named UpdateGroupLengthNew untill checks are over)
2716 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2717 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2718 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2720 - gdcmHeader::GetPubElValSet removed.
2721 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2722 UpdateGroupLength, WriteElements, Write.
2723 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2724 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2725 carried the same semantics.
2726 - src/gdcmHeaderIdo.cxx changed accordingly.
2727 - gdcmFile::WriteBase now regroups all the codes from previous
2728 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2729 - enum FileType moved to gdcmCommon.h
2730 * src/gdcmHeader.cxx AddDefault trashed
2731 * gdcmGetXSize added
2732 * getimageDataSize now calls gdcmGetXSize
2733 * Test/*.cxx changed to agree with above changes
2735 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2737 (to avoid double call by end user).
2738 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2739 by end user, since gdcmHeader::gdcmHeader now handles it.
2741 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * gdcm/Doc many doxygen changes:
2743 - Doxyfile now has two different versions, DoxyfileUsers that generates
2744 the html.users end users oriented documentation and
2745 DoxyfileDeveloppers that generates the html.developper developper
2746 oriented documentation.
2747 - README changed accordingly
2748 - requirement.txt removed (old design info moved to TODO).
2749 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2750 DoxyMainPage.txt, DoxyPython.txt provide more information.
2751 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2752 be updated by simply regenerating the docs with doxygen and copying
2753 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2754 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2755 all the tests in the form "if (<map>.count() >1)" were removed.
2756 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2757 ill-formed documentation sections.
2758 * src/gdcmHeader.cxx: ditto
2760 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * setup.py fixed for un*x (needed macro for stdint.h)
2762 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2763 un*ces with sh-utils test utility.
2764 * gdcmPython/demo/test.py renamed to PrintHeader.py
2765 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2766 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2767 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2768 * src/gdcm*.cxx JPR's bad inclusion fixed.
2770 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2772 * gdcmPython/demo/test.py changed accordingly.
2774 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * gdcmPython/Makefile.am fixed linking against libstdc++
2776 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2777 * Swig subdir (historical tests of swig version 1.3.17++) removed
2778 * Test/testChangeEntete.cxx some lines commented out in order to make
2780 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2781 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2783 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2785 hence the user doesn't need this explicit call.
2786 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2787 i.e. LoadElements() call removed.
2788 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2789 - src/Makefile.am declares the proper flag for g++.
2790 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2791 for adding user defined new tags.
2792 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2793 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2794 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2796 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2797 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2798 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2799 src/Makefile.am : the project should properly compile and install
2800 with the autotools, included the python wrappers part.
2801 * gdcm.spec.in : added a spec file for RPM packaging.
2803 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2804 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2806 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2808 to exported to the environement (see gdcmPython/testSuite.py
2810 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2811 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2812 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2813 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2814 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2816 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * gdcmPython/__init__.py doesn't crash anymore when running in
2818 in InstallMode or PreInstallMode but with an environment given
2819 value of GDCM_DICT_PATH.
2820 * src/gdcmDictSet.[cxx/h] coding style.
2822 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2824 * src/gdcm.h general comments moved to TODO, and README
2825 * src/gdcm.h should now be seen as a user commodity (including it
2826 should suffice to fully use gdcm). It is nowhere including within
2827 any of the kernel files src/*.cxx and src/*.h.
2829 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2831 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2833 * src/gdcm*.cxx only include their corresponding include file
2834 (as opposed to gdcm.h)
2835 * gdcmPython/gdcm.i changed accordingly
2836 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2837 the autogen.sh generated "make snapshot" command to work.
2838 * autogen.sh removed history related references to crea package.
2840 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * distutilsSwigCPlusPlus.py work around some swig portability
2844 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2846 was done in a last ditch attempt to get setup.py _really_
2847 operationnal. The python/gdcmPython layaout add the advantage
2848 of hidding away the python related distutils specific files
2849 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2850 Alas, the src directory was out of scope (i.e. it's relative
2851 position to setup.py was ../src) which made things impossible to
2852 handle (see previous version of python/setup.py). Crossing fingers...
2854 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * python/setup.py now works on Un*x. (harder than I thougth)
2856 * python/distutilsSwigCPlusPlus.py can now have include files
2857 among the list of sources.
2859 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2860 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2861 * modifications in MSVC projects
2863 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * As stated by the first lines of Test/ExceptionAndPython/README, it
2865 looks like we can move back to original usage of exception within
2866 src/gdcm* and hence remove the errno stuff that was introduced
2867 as a quick and dirty fixture of this problem (added to the TODO).
2868 * Doc/Doxyfile configuration file for Doxygen and corresponding
2869 README file for usage added.
2870 * Test/testWrite.cxx added. This new test comes from a split of
2871 test.cxx that is now reverted to its original purpous i.e.
2872 testing the proper parsing of a Dicom related file.
2873 testWrite.cxx concentrates on testing the IO part of gdcm.
2874 * Test/bug1.cxx (containing a bug on WIn32) added.
2875 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2876 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2877 whose purpose is to publish the content of the TagNames of the
2878 Dicom public dictionary were not accessible without an
2879 instance of class gdcmHeader.
2880 - those methods are now static methods of gdcmDictSet and hence
2881 require no instances at all to be invocated.
2882 - within gdcmDictSet this change required to change some method
2883 to class methods (i.e. are now static) among which SetDictPath
2884 (renamed to BuildDictPath) and LoadDefaultPubDict.
2885 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2886 the above changes by calling the new method classes of gdcmDictSet.
2887 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2888 the above to be effective.
2889 * python/gdcmPython: in order to wrap properly the above changes
2890 for Python, swig version now needs to be > 1.3.17.
2891 * python/gdcmPython/Makefile fixed to adapt itself to new
2892 configure/make shema introduced by Johan Montagnat (thanks for the
2893 contribution). Alas this Makefile cannot be turned into a proper
2894 Makefile.am without some heavy changes in the configure.in
2895 (for python dectection).
2896 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2897 now avoids publishing the empty entries.
2899 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2900 * python/setup.py : bug fix concerning install under windows
2901 ExtraPath reused :-P
2902 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2904 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2905 * Dicts/dicomV3.dic : remove double spaces !!!
2906 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2907 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2910 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2912 method. Doxygenation.
2913 * src/gdcm.h clean up of JPR spurious comments.
2915 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * python/distutilsSwigCPlusPlus.py now properly collects the
2917 shadow classes generated by "swig -c++" (gdcm.py in our case)
2918 when using "python setup.py install".
2919 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2920 reexports the working classes.
2921 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2922 by the classical C errno scheme. This is to prevent an obscure
2923 behavior of the python wrappers when importing wxPython.wx prior
2924 to gdcmPython (which ended up in an abort call). An illustration
2925 of this oddity can be found in the Test/ExceptionAndPython
2926 subdir (see the README file). This problem probably due to
2927 an combination of g++ and dynamic loading.
2928 * added Test/ExceptionAndPython (see above)
2930 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * Changed the layout of the python part to avoid bloating main
2932 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2933 i.e. the distutils arsenal. All the python related stuff is
2934 again in a python subdir, but the package itself is now in
2936 * setup.py was cleaned up:
2937 - pythonIncludePath removed
2938 - python setup.py bdist target is now functional.
2939 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2940 collision with other packages). gdcmPython/demo/*.py changed
2943 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * python subdir moved to gdcmPython (preparation of distutils packaging).
2945 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2946 distutils installer is operational.
2947 * - gdcmPython/__init__.py now properly loads the swig generated
2948 shadow classes (from gdcm.py).
2949 - gdcmPython/demo/*.py changed to import the package gdcmPython
2950 instead of gdcmPython/demo/load.py.
2951 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2953 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2955 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2956 entries within the associated public Dicom dictionary resp. the same
2957 information but sorted by the fourth field (PAT, IMG, DIR) of the
2959 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2960 are now in the "???" group.
2961 - python/gdcm.i changed accordingly,
2962 - python/demo/printGroupedPublicDict.py added, that gives an example
2963 of the above new functionalities in Python.
2965 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2966 * src/gdcm.h, gdcmHeader.cxx:
2967 - historic references to glib's g_malloc and g_free (#defined)
2968 were definitively removed.
2969 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2970 * src/gdcmElValSet.cxx:
2971 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2972 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2973 - GetElValue(string) renamed to GetElValueByName.
2974 - Added GetElementByName(string).
2975 * src/gdcmHeader.cxx: added
2976 - GetPubElValRepByNumber(guint16, guint16)
2977 - GetPubElValRepByName(string)
2978 - GetShaElValRepByNumber(guint16, guint16)
2979 - GetShaElValRepByName(string)
2980 - GetShaElValByNumber(guint16, guint16)
2981 - GetShaElValRepByName(string)
2982 - GetElValRepByNumber(guint16, guint16)
2983 - GetElValRepByName(string)
2984 - GetElValByNumber(guint16, guint16)
2985 - GetElValRepByName(string)
2986 * Doc/requirements.txt added.
2988 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * Test/Makefile building now depends on the one of libgdcm.so
2990 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2991 pixel data) aware which enables finding the address (offset) of
2992 the pixel data of JPEG encoded DICOM files. This leaves only a single
2993 file in the testSuite whose pixel data address (offset) is unknown.
2994 * python/testSuite.py changed accordingly.
2996 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2997 * VC++ has some strong limitations when working with the STL, as stated
2998 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2999 "Also note that some STL containers (map, set, queue, list, deque)
3000 cannot be exported. [...]
3001 Some STL classes contain nested classes. These classes can not
3003 This is caused by a designed limitation that once a template
3004 class is instantiated, it can not be re-instantiated and
3006 Since our usage of map<> is ubiquitous in gdcm, this "designed
3007 limitation" of VC++ is a pitfall.
3008 Hence the Python wrappers of gdcm cannot be incrementally linked
3009 against the c++ dynamic library. The dirty but only workaround is
3010 to forget about incremental link of dynamic libraries and to generate
3011 the Python wrappers library with the inclusions of the underlying C++
3013 The following modifications concern this matter on Win32/VC++:
3014 - wrapping python correct with standalone wrapped dll (don't use separate
3015 dll under windows !!!!)
3016 - python21_d debug mode enabled (ask Frog how to use it :-)
3017 - NO problem with having an STL member of class for example string in C++
3018 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3019 - Python test of dcmlib in Python is ok under windows on a large set
3021 * removed glib references
3022 * typedef's inserted in gdcm.i for correct swig type management
3024 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * python/demo/*.py load.py extracted from test.py. Added explore.py
3026 that only displays required tags and testAll.py that parses all
3027 the files of the testsuite without using unittest.
3028 * python/testSuite.py other additional test on new files added.
3029 * Data/* new test files added accordingly to the testSuite.
3030 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3031 the vr in the file differs from the one of the dictionary.
3033 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3034 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3035 values, but limits itself to values which are below a user specified
3036 size (by default 1024 bytes).
3037 * python/gdcm.i : elements not loaded (because their size is above the
3038 user specified treshold) are exported with their TagKey as key of the
3039 python dictionary. This enables the testsuite to make some checks
3040 on the unloaded elements (since we have their offset and size).
3041 * python/testSuite.py
3042 - now tests for the existence and proper value of the pixel data
3043 - two new examples added.
3044 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3046 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3047 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3048 aware. See the strategy comments in gdcmHeader::FindeLength().
3049 * Test/test.cxx now accepts a filename as first argument.
3050 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3051 * python/testSuite.py changed to integrate test on above files.
3053 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3055 the vr was also RET.
3056 * python/testSuite.py more tests added.
3058 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * python/testSuite.py unittest test suite added (uses Data)
3060 * Data/* dcm and acr files for the test suite.
3061 * glib dependance removed from un*x version. We now use ISO C99
3062 7.18 Integer types (see stdint.h)
3063 - python/Makefile, src/Makefile src/gdcm.h
3064 * src/ when an explicit vr (like dicom files) suddenly poped an
3065 implicit element we use to mark the underlying DictEntry of the
3066 concerned ElValue with "Implicit". This strategy was damageable
3067 too the public or provite dictionaries, since some of their vr
3068 would be changed. Since Header::FindLength heavily relies on the
3069 detection by Header::FindVR of falsely explicit elements, I
3070 added an extra ImplicitVr member to ElValue (boolean).
3071 The rest of the changes we the necessary adaptations.
3073 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3074 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3076 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3078 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3079 * Adaptation for porting to VC++:
3081 o forced to use std namespace (for string to be known)
3082 o all class use __declspec export style on WIN32
3083 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3084 (in stdlib.h on Win32 but in std:: for gcc)
3085 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3086 variable GDCM_DICT_PATH.
3087 * src/gdcmHeader.cxx verbose comments made discrete.
3089 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3090 * python/gdcm.i: added a typemap that converts a C++ hashing table
3091 to native Python dictionary.
3092 * python/demo/test.py:
3093 - now uses the native dictionary for exploration of gdcmHeader.
3094 - takes an optional filename argument (the file to parse).
3095 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3096 PubElVals hashing table.
3097 * Dicts/dicomV3.dic removed error prone trailing spaces.
3099 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * Python wrapping process moved away from src/Makefile to
3101 newly created python/Makefile (as well as gdcm.i)
3102 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3103 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3104 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3105 from the environement variable GDCM_DICT_PATH (when existing).
3106 * src/gdcmDict::GetTag bug fix.
3108 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * Straightforward temporary fixes for swig to build the python wrappers.
3110 src/Makefile now has a python working entry [by working we mean
3111 that we can import de shadow classes without errors].
3113 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3114 * hashtest.cxx removed (since already in Test)
3115 * src/gdcmlib.h renamed to src/gdcm.h
3116 * src/dcm.i renamed to src/gdcm.i
3117 * src/Makefile prepared for python wrapping
3119 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * src/gdcmHeader.cxx :
3121 - Parsing of header is now separated from loading of element values
3122 (see gdcmHeader::LoadElements).
3123 - general clean up of hopefully all file access (creation of
3124 ReadInt16 and ReadInt32)
3126 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * src/gdcmHeader.cxx :
3128 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3130 - SetLgrElem renamed to SetLength
3131 - GetLgrElem renamed to GetLength
3132 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3133 * src/gdcmElValSet.cxx fixed both GetElValue methods
3134 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3135 due to IdoDude was cleaned out.
3137 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3139 concentrates on finding the value representation (when it exists).
3140 RecupLgr now only finds the element value length, and it avoids
3141 returning the unecessary skL (skipped length).
3142 Also, offsetCourant was simply removed (with taille_fich) since
3143 it was redundant with the File position internals (by using
3144 ftell and fseek). This also made skL (see above in RecupLgr) usage
3146 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3147 on the libido specificities which are handled through class
3149 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3152 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * Truckload of changes. Parsing of header is barely functional
3154 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3156 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3157 * src/gdcmHeader.cxx many addons of low level methods
3159 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3160 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3161 and _IdDcmSWAP_LONG.
3163 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * This corresponds to all the changes decided at the meeting of
3165 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob