1 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Builder/ : add something to facilitate the RPM creation of gdcm
4 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
7 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
9 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
10 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
12 * Fix compilation on gcc 2.96 (which does not have ios::failure)
14 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
16 and it's representation name (for the NIH)
18 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
20 conversion of YBR to RGB pixels. So, now, the conversion is made using
23 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
25 format) to replace 'at-run' dicom files generated by the
26 TestAllReadCompareDicom test
28 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
31 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
34 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * Testing/TestMAkeIcon.cxx : complete the test
37 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
40 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
44 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
47 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Test/ : accelerate tests (it's not very significant accelerations).
49 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
51 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Testing/TestSequence.cxx : add test for sequences of images... test that
53 we have the same serie or the same study UID
55 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
58 * src/gdcmDict.h : remove commented code
59 * src/gdcmDocument.cxx : initialize values
60 * src/gdcmFile.cxx : bug fix when reading values
61 * gdcmPython/demo/ : change file names. Remove useless files
63 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmFile.cxx : remove the default array of initialization.
65 The static array contained pointers to non-static values (comming from
66 strings). To have coherences, when creating files, these values can't be
67 static. So, the array can't be static, too ! To simplify, the array have
68 been replaced by repeted lines to insert values in the File
70 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
72 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
74 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
75 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
76 (Dicom Element) into the Sequence Item
78 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/*.cxx : first parss to normalize file organisation
81 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDirList.[h|cxx] : add method to find a directory
83 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
85 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * Finish cleaning up my JPEG mess. Should be ok now.
87 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
88 contained within the RLE* class(doh!)
90 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
91 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
92 * SerieHeader::AddFileName() creates as many Coherent Files lists
93 (same Serie UID) as it founds different Serie UID
94 amongst the files instead of discarting any file
95 that doesn't match with the first one he found.
96 * SerieHeader::OrderGdcmFileList has now one parameter :
97 the Coherent Files list the user wants to sort
98 * SerieHeader::GetFirstCoherentFileList() |
99 * SerieHeader::GetLastCoherentFileList() | allow to parse
100 the set of Coherent Files lists
101 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
102 compatibility (it returns the *first* Coherent Files list,
103 since there was only one before)
104 * Test/TestSerieHeader gets gdcmData as a default root directory
106 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * Remove friend between DocEntry and File classes
108 * Remove friend between PixelReadConverter and RLEFramesInfo,
111 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
113 0002|0000. The value was incorrect.
115 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
118 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmUtil.cxx : compilation fix on Win32
120 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
121 variable, to be easy found. Add methods to change the default UID.
122 Amelioration of the CreateUniqueUID to use the correct default UID.
123 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
126 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * Test/TestVR.cxx : fix memory leaks
129 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
130 * Rewrite the base 256 to base 10 conversion, using string operation only.
131 This allows us to get rid of the problematic 64bits integer type (does not
132 always exist on target platform).
134 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
135 * Add construct and destructor to class gdcm::Debug to close the debug file
137 * Don't let uset to open twice the same file
138 * gdcm has now an official UID prefix,
139 supplied by http://www.medicalconnections.co.uk
140 1.2.826.0.1.3680043.2.1143
141 (Thx to Mathieu for providing URL)
142 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
143 to be able to perform some more tests
144 * gdcm::ContentEntry : Contructors and Destructor are now protected,
145 in order to be sure no user will try to use them.
146 (at user level, only the children classes are meaningfull)
148 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * move RLEInfo & JPEGInfo from Document to File
151 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * FIX : remove so many friend between classes
154 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
156 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
158 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
159 In order to avoid missbehaviour :
160 . gdcm::DocEntry is now specialized in
161 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
162 - gdcm::ContentEntry (Dicom entry with a 'content')
163 . gdcm::ContentEntry is specialized in
164 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
165 characters value, or integers)
166 - gdcm::BinEntry (Dicom entry with a non strig representable value
167 (user hasn't any longer to thing about the precedence of his dynamic_casts)
169 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * Test/VTKTest*.cxx : bug fix under linux
172 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
174 use with python. Some methods are moved from Document to ElementSet or
175 DocEntrySet. The equivalent methods to ElementSet have been added to
176 SQItem and are virtual in DocEntrySet. Methods that may have the same code
177 in SQItem and ElementSet is directly placed in DocEntrySet
179 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * Test/VTKTest*.cxx : remove the show variable in each test method because
181 it's useless (the viewer variable replace this variable)
183 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmDocument.cxx : bug fix on potential memory leak
185 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
186 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
187 Add ClearXxx methods to remove all the content of the list or map
188 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
190 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
191 * methods ReplaceOrCreate renamed as Insert
192 (nobody will be any longer confused by 'CreateOrReplace')
194 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
195 * Grealty simplify the JPEg decompression, no need to differenciate based on
196 the JPEG possible type (with/without fragment, with/without multiple frame).
197 Everything is done throught the JPEG IO Suspension mechanism in IJG
199 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * Stage 3 of normalization :
201 in order to avoid any missunderstanding while reading method names :
202 - All the methods xxxEntry now deal with dicom Entries
203 - Methods GetEntry splitted into
206 - Method SetEntry renamed as SetEntryValue
207 - Method SetEntryBinArea let as it was
209 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
210 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
211 - Position correctly the entry points for JPEG2000 and JPEG-LS
212 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
214 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
216 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
217 with other method names
218 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
219 * Test/TestDicomDirElement.cxx : add new test
221 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
222 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
223 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
224 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
225 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
226 So can't you use __int64 in ostream at all.
228 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * bug fix for compilation on MSVC6
230 * gdcmPython/gdcm.i : rename of classes missed
232 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
233 * Stage 2 of names normalization :
234 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
235 (easy to understand ...)
236 - gdcm::FileHelper replaces old class gdcm::File
238 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
240 type and not a string. So, there remove problems on the format of the
243 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
244 * Add Example/TestPapyrus.cxx
245 - reads a Papyrus file (gdcm::Header compliant),
246 - gets the pixels of all the images, using low level iterators
247 - writes an multiframes Dicom image.
248 (Just to show it's *possible* to do that)
249 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
252 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
254 Thus, DicomDirXXX are created with a flad that indicates if the created
255 object is empty or not (when not empty, the DicomDirElement is used to
258 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
260 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
262 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
265 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
267 Remove all access to the hash-tables or lists in the objects.
269 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
271 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
272 be complient with all the gdcm source code
274 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
278 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
282 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * Test/ : rename VTK tests to have a best name for the tests
284 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
285 GetFirstEntry/GetNextEntry use
287 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
288 * In SerieHeader::ImagePositionPatientOrdering()
289 // a Dicom 'Serie' may contain scout views
290 // and images may have differents directions.
291 // -> More than one may have the same 'pos'
292 // Sorting has then NO meaning !
293 Thx to Eduardo Davila for reporting bug.
295 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
297 test. Now it's on image content and not on the resulting visualisation...
298 might solve the problem on linux when using the OpenGL drivers
300 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
301 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
302 DicomDirSerie, DicomDirImage
303 Dict, DictSet classes :
304 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
305 -remove InitTraversal method.
306 * UPD Test programs + Example programs
308 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
309 * remove useless and never updated keyword \ingroup
310 * Solve pb when structure (list, map, ...) is empty.
311 Thx to Benoit for reporting bug
313 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
314 * Taking into account of 'Transfer Syntax' value
315 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
318 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
320 is no memory access violation
321 * gdcmPython/demo : add python demos using VTK
323 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
324 * FIX 'Dictionnary' is now spelt 'Dictionary'
325 'wether' is now spelt 'whether'
326 'archieve' is now spelt 'archive' ;-)
328 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
329 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
330 related methods, in order not to expose internal mechanisms
333 * REM methods that exposed internal mechanisms :
334 DicomDir::GetDicomDirPatients()
335 DicomDirPatient::GetDicomDirStudies()
336 DicomDirStudy::GetDicomDirSeries()
337 DicomDirSerie::GetDicomDirImages()
338 * UPD Test programs :
342 * UPD Example program
344 * ADD DictSet methods
348 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
349 * Removed the Print/indent/default parameter mess. There is absolutely no
350 reason to have to methods, moreover with the second taking the ostream as
351 *SECOND* parameter. This was clearly a bad hack to get things compile.
353 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
354 * Complete rewrite of the GetMacAddress code. Now the code is *much*
355 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
356 Unfortunately the main code does not work on SunOS, thus provide a specific
357 code for this platform only (and Win32 of course). Since this seems to be
358 working, change CreateUniqueUID to use GetMACAddress instead of the
359 problematic GctestetIPAddress
361 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
362 * Unfortunately to be able to test gdcmDirList I had to break the API
363 a little. Now the class is not a std::list anymore but has a member
364 std::vector (more ITK compatible). Allow unit testing on Win32 and
367 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Update SerieHeader to take into account a Serie Instance UID to properly
371 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
372 * ENH - Comment out Mathieu's (dangerous) Super Hack
373 for dealing with BIGENDIAN processors
374 - Move equivalent stuff to BinEntry::WriteContent
375 When necessary, 16 Bits Pixels are swapped in a small buffer
376 and then written. This avoid allocating a huge buffer, in
377 PixelWriteConvertor, and avoid modifying the Pixel Area.
379 Probabely, the same operation will have to be done when we want
380 to write image with Big Endian Transfert Syntax,
381 and we are working on Little Endian Processor
383 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
386 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
387 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
388 all the dict content.
389 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
391 * Test/TestDict.cxx : add a new test for the dict classes
393 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
395 file. Debug is yanked if compiled with NDEBUG
397 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmDictSet.h : set the default output to the os variable
399 * src/gdcmDictEntry.[h|cxx] : add the Print method
400 * gdcmPython/demo/ : add a new test
402 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
403 * merging of Test/PrintDicomDir and Test/TestDicomDir
404 * removal of now redundant Test/PrintDicomDir
405 * enhancement of Example/PrintDicomDir
407 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * Now, python test might work on systems
409 * Add the PrintDicomDir test
411 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
412 * FIX : First entry following group 0002 was lost for
413 Explicit Big Endian Transfer Syntax files
414 (group and elem not swaped)
416 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
417 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
418 Big Endian Transfer Syntax supposed the group following 0002
419 begins always by element 0000 (element 0000 is *optional*)
420 To avoid further troubles, let's be pessimistic, and use
421 Document::HandleOutOfGroup0002() method
422 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
423 (related pb not yet solved)
425 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * Bug fix for the python part use
427 * Now, PrintHeader.py pass... but outside the ctest use. shit !
429 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
432 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
433 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
434 a string and should ask the global TS dict what are the propreties of
437 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
438 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
439 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
440 to swap the Swap Code, at parsing time, when we come out of group 0002
441 and Transfer Syntax is Big Endian
442 We should be able to read now 'true DICOM" Big Endian coded images
443 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
444 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
446 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Hopefully fix the bug on MacOSX and static global initialization.
448 This is the only -minor- patch I found that both please MacOSX and VS6.
449 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
450 but this would require a lot of change. Another approach would be that Global
451 create those string and GDCM_UNFOUND becomes a pointer to a string (which
452 gdcm::Global would destroy at exit).
454 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
455 * Fix bug on MacOSX with static initialization in a multy threaded
456 environment. static const string in a header file used to be ill
457 initialized provoquing the freeze of any tests. patch should solve this
460 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
461 * According to Benoit's suggestion, and without any objection from anybody
462 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
463 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
464 - method gdcmDicomDirObject::GetEntry() renamed as
465 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
467 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
469 you debug/warning message just as c++ streams which make them very convinient
470 to use. Once this is stabilize I will change the ostringstrem to be
471 redirected to a file (ofstream).
472 * Properly support C99 extension: __FUNCTION__ which allow us to display
473 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
475 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
476 * Removal of useless and dangerous methods :
477 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
478 GetDocEntryByName, GetEntryByName, GetDictEntryByName
479 * Removal of usless methods :
480 Dict::PrintByName, Dict::GetDictEntryByName
481 * Commenting out of probabely useless methods :
482 Dict::GetDictEntryNames()
483 Dict::GetDictEntryNamesByCategory()
484 DictSet::GetPubDictEntryNames()
485 DictSet::GetPubDictEntryNamesByCategory()
486 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
487 * ENH : Use dicomTS.dic as described in 2004 version
488 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
489 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
490 Add Accessors on VM (Value Multiplicity), and VM related methods
491 * ADD : Add a list of 'Dicom Attribute types', as found in
492 http://medical.nema.org/dicom/2004/04_15PU.PDF
494 * ADD : Add dicomGroupNameAbbreviations.dic
495 should be used to write a method to replace the former
496 Dict::GetDictEntryNamesByCategory()
498 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
500 to read in the file... and only it ! Length is the efective length of the
501 data in the DocEntry structure
503 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
504 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
505 And now use a static function call instead, with a global variable. i
506 This is much closer to the VTK approach. Hopefully should be bulletproof
507 and easier to use...hopefully
509 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
510 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
512 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
515 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
517 ValEntry, BinEntry, SeqEntry creation or replace
519 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
521 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
523 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
524 when specifying the VR
525 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
526 * src/gdcmDocEntry.cxx : amelioration of print
528 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
529 * ADD : Add the method Util::IsCurrentProcessorBigEndian
530 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
531 * ADD Method Document::ComputeGroupLength
532 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
533 in order to allow further VR modification by user
534 * REM : removal of once-called method File::WriteBase
535 integration of its code in formerly one-line method File::Write
537 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
539 replace the different values "??", "Unkn", "Unknown".
540 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
541 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
542 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
543 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
545 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
548 * Set the gdcm::Base class to some Printable classes
550 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * src/gdcmFile.[h|cxx] : add the Print method
552 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
553 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
554 * src/gdcmDocument.h : remove the PrintLevel informations
555 * Example/PrintFile.cxx : use the new gdcm::File::Print
557 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
559 problems when compiling with the python wrapping
561 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
563 writting in ImplicitVR
565 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
566 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
567 JPEG decompression, especially when dicom frames are split into several
568 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
569 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
571 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * src/gdcmHeader.cxx : change the initialisation of default header.
573 Now, this header is readable by gdm, e-film, DicomWorks
575 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
577 Rename Decompressed to Raw
578 * Use the API changes in gdcm::File.
579 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
582 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
584 each added entry in the header. Replace the 'Planes' field by the 'Number
587 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
589 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
591 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
593 At this time, this image isn't readable by e-film... waiting JPR help to
596 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
598 DocEntry. Now use methods of the Document !
600 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * Test/ShowDicomSeq.cxx : bug fix
603 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
605 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
606 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
607 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
609 * Test/TestCopyRescaleDicom.cxx : remove unused variable
610 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
611 containing found sequences
613 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
616 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
617 Some fields in BinEntry must be copied to not seg fault when making the :
618 gdcm::File *copy = new gdcm::File( copyH );
619 and tests are now made on good variables
621 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
623 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
625 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
626 * Add vtkGdcmWriter example and test
628 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * Test/TestUtil.cxx : reformat the source code
630 * vtk/vtkGdcmReader.cxx : remove and change prints
631 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
633 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
634 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
636 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
638 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
640 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
642 by an eof to prevent all bad read of the file... and in this case, the
645 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * Example/Volume2Dicom.cxx : comment unused variables
647 * Test/PrintDicomDir.cxx : comment unused variables
648 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
649 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
650 method that is redondant with AddEntry.
651 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
654 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * Bug fix due my last commit (compilation under Windows).
656 * Example/Volume2Dicom : bug fix in the file and reformatting source code
657 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
659 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
661 - Remove printf / sprintf
662 - include iostream AFTER gdcm so we don't get warnings
663 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
665 - Also remove tons of include from header files, hopefully this should
666 speeup the compilation time, since it was becoming a dog slow.
667 - Remove gdcm.h as it include way too many files and slow down compilation
668 (plus it is not up to date)
669 - remove 'using namespace std' this is BAD !
671 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * Remove memory leaks on the DicomDir
673 * Remove some useless data in DicomDirObject
674 * Add usefull methods in SQItem, to be complient withe the ElementSet
676 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
679 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
681 future, with convertion)
682 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
683 and ImageDataSize values. Remove the method to get the PixelReadConverter
684 from the output of the class
686 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
687 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
689 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
691 and vtkErrorMacro use.
692 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
694 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
697 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
698 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
699 The string leaves only in the fonction. So when we make a .c_str(), we
700 get the pointeur on the first element, element that will be destroyed
701 immediately after thee instruction.
702 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
703 file has been opened : the test must be made on the content of the
704 pointer and not directly on the pointer !
707 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
709 the python part recompiles
711 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
713 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
714 X session is killed (for my computer... it seems to not be identic on
717 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
719 avoid problems (otherwise, the difference test between the visible image
720 and the reference is incorrect. If the reference is greater than the
721 screen resolution, it's produce errors).
722 Can be used for only one image. Can be used with a visible flag.
723 * vtk/vtkGdcmReader.cxx : remove commented codes.
724 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
725 under windows at compilation
726 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
728 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
730 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
732 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
733 tests on the image size X, Y, Z
735 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
737 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
738 between the class name and the file name
740 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
741 * src/ : fix compilation warnings for the Write method (2 different
742 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
743 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
744 variable... create a static method in gdcm::Document to access to
745 this variable content.
747 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
748 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
749 file, to be accessed by other files (like gdcmFile). Remove commented
750 code. Move the change of the header to the gdcmFile, using the
752 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
753 To be sure of that (and simplify calls), the Write of the header now
754 gets a file name and not a file pointer (std::ifstream).
755 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
756 DocEntryArchive. Remove all open of the written file
758 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
761 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
763 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
765 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
766 some corresponding methods. Write correctly the file and check before
768 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
769 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
770 is now on RGB data (as before my last commit
771 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
773 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
774 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
775 Add a print information of the type of the entry
776 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
777 It was in the gdcmFile, and all write have been regrouped
778 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
779 Write correctly all dicom files (in decompressed mode only at this time)
780 * Test/ : test on files are now made using Raw data and not color data if
782 * Example/PrintFile.cxx : add more printings
784 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * Amelioration of code, remove some code copy. For the loading of
786 BinEntry (in gdcmDocument), add the test to verify if the file is already
789 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
790 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
791 remove a DocEntry in the header (push an empty DocEntry)
792 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
793 lines. Bug fix in the initialization of the PixelConvert and the
795 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
796 use in TestCopyDicom (now this test can run under windows... but fails)
797 * Test/TestCopyDicom.cxx : amelioration of the test :
798 - test the pixels written
799 - add test points to quickly find where is the error
800 - can set a file name input and output in arguments
801 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
802 amelioration of the test output
804 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
805 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
806 all replaced DocEntry's
807 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
808 Now, each needed DocEntry to modify is duplicated, modified and inserted
809 to the header using DocEntryArchive. Thus, after save, we can restore the
810 header initial state.
812 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
815 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
817 correct to copy it. The DictEntry is specified at the DocEntry creation,
818 then, it musn't change in the time.
819 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
820 header correctly. At this time, the change is only made for the first
821 level of the Document. In the future, it might consider sequences.
822 The change is made by replacing a DocEntry by an other that is created
823 outside the class. The old value is kept. When we restore the header
824 status, the added DocEntry is deleted and replaced by the old value.
825 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
826 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
827 set the write type to explicit VR, implicit VR or ACR. Add methods to set
828 the write mode to native, decompressed or RGB (but not used at this time)
830 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
831 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
832 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
834 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
836 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
838 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
839 set because already copied when copying the BinEntry's of the header
840 * Test/TestAllReadCompareDicom.cxx : remove warnings
842 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
844 Two problems appear when doing it :
845 - with the gdcmFile : when the GetImageData method is called, the pixels
846 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
847 data (pixels). And each structure destruct the data when it's
848 destructed. So we have two destructions for the same data. To solve it,
849 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
850 data or not. If it doesn't own data, then they will not destroyed by
852 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
853 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
854 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
855 create a double destruction of the same DocEntry's. So, to solve it,
856 the TagHT is simply cleared and the DicomDir* elements are destroyed.
857 * TODO : add an entry concerning memory leaks in the DicomDir
859 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
860 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
861 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
864 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
865 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
866 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
867 after it have been deleted
869 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * FIX: src/* fix the doxygen warnings.
871 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
872 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
873 was erroneously defined with a size of 15 instead of 16. [many thanks
874 to Jean Michel Rouet for pointing out this bug].
876 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 1. Finish merging JMR patch for writting DICOM from scratch
878 2. Fix -hopefully- bug with MONOCHROME and space vs null character
879 3. Use const ref when possible
880 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
881 5. A few more comments
882 6. CreateUniqueUID can now be called without parameter"
884 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
885 * ENH: Slightly bigger patch:
886 1. Getting toward full integration of JMR patch for writting dicom from scratch
887 2. Update Test to test part of this patch: CreateUniqueUID
888 3. File was not close properly in gdcmDict
889 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
890 5. Use of const ref instead of copy (speed issue)
891 6. Remove temporary (duplicate) string in TranslateToKey
892 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
893 8. Do not repeat virtual in subclasses
894 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
896 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
897 * Apply first patch toward better string comparison when dealing with broken
898 DICOM files. Essentially the string could be padded with a space instead
899 of a null character as defined by standard
901 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
902 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
903 because never used... and in the same time, that's remove some memory leaks
905 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * src/gdcmFile.cxx : now delete the PixelConvert instance.
907 * In examples and tests : change the type of image data variables from void*
908 to uint8_t*. Remmove all delete on image data variables
910 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
911 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
912 Verify the file pointer value before open the file, and if it's not null,
913 a verbose message is generated.
914 Close correctly the file when the file isn't considered dicom-like. The
915 correctly close is a call to CloseFile.
916 When closing the file pointer, test if its not null to close the file.
917 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
918 file. For an uncompressed image, the copied data correspond in the least
919 case to the image size (calculated) or the image size specified in the
920 header. A verbose is generated if these two size mismatch
922 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
923 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
924 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
925 break under windows (with msvc6 compilation).
927 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
928 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
929 compiling with MSVC6)
931 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
932 * Bugs fix for the Windows build with VC6
933 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
934 needed (only for projects required VTK). If the VTK is included in all
935 projects, there is conflicts with the jpeg lib of vtk when compiling the
936 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
937 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
938 when compiling the gdcm_wrap.cxx file (created by the compilation of the
940 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
941 (like it's already made for the cout use). Otherwise, conflict with the
944 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
947 - comments on the DicomDir::Method related usage added.
948 - now that we use the namespace gdcm, a lot of internal classes do
949 NOT need to be wrapped anymore.
950 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
951 DicomDir::Method) new example added.
953 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
954 * Improve string manipulation. I now inforce the notion of 'DicomString'
955 A DicomString can contain as many \0 as they want
956 and it is *always* of even length.
957 We only support odd length for very rare case.
958 And in the near future this should be removed.
960 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
961 * /binary_write/ gdcm source. Now even on big endian we are writting
962 little endian. This should -heopfully- fix some tests
964 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
965 * Now the dictionary is compiled into gdcm lib. This is a default
966 behavior, thus any dic file specified is picked before failback to
967 the one comiled into lib
969 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * Change internals for gdcmDict. Don't use any 'new' any more.
971 This should definitely solve any leak problem, and we should be
972 as fast as before, as long as don't modify too much the dictionary.
974 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
975 * STYLE: ivars should start with a capital letter.
976 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
977 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
979 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
981 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
982 new 2004 dictionaries added (thanks to JPR).
983 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
984 * CLEANUP_ROUND (15) for gdcmPixelConvert
985 - RLEFrame::NumberFragments is now of type unsigned int
986 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
987 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
990 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
991 * Initial work in gathering all transfer syntax accessors. clearly
992 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
993 ivars, but only one transfersyntax (class) ivar with equivalent method on
996 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
997 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
998 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
999 discussed (plus I didn't like having a 2000 lines patch not commited)
1001 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1002 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1003 * CLEANUP_ROUND (14) for gdcmPixelConvert
1004 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1005 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1006 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1007 CloseFile() anymore.
1008 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1009 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1010 into File::Pixel_Data.
1012 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1013 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1014 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1015 * CLEANUP_ROUND (13) for gdcmPixelConvert
1016 Substituted File::ParsePixelData() with PixelConvert::Print() new
1018 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1019 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1020 method to those classes.
1021 - src/gdcmFile.[cxx|h]:
1022 -- Added a ::Print() method.
1023 -- PixelConverter is now a reference instead of a member.
1024 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1025 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1027 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1029 collaboration diagram and inheritance diagram should be generated with
1031 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1032 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1033 pointlessly wrapped (see
1034 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1035 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1036 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1037 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1038 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1039 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1040 -- File::Initialise: PixelConverter setup moved away to
1041 PixelConverter::GrabInformationsFromHeader()
1042 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1043 interpretation moved away to PixelConverter::BuildRGBImage()
1045 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1046 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1047 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1049 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1051 displayed on Win32 when a brutal abort() occurs (because of uncatched
1052 exception). See TODO new entry of this commit for more on this.
1053 * TODO added new entry.
1054 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1055 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1056 - HandleColor is no longer called from gdcmFile.cxx
1057 - gdcmPixelConvert.cxx clean up on method arguments and internal
1058 variable names for semantical coherence.
1060 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1061 * Finished lossless transition, not only do we now read all lossless jpeg
1062 images, without the need of the Cornwell lib, but we do read them properly now
1063 * To reduce code (well to avoid code duplication), I defined a common place
1064 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1065 redefine symbols. This is not perfect but this the best solution I found for a
1066 compilation time jpeg option.
1068 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1069 * Update jpeg ijg lib to support lossless jpeg implementation
1070 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1072 * Also added a special copyright for dcmtk since we use their bugfixes.
1075 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1077 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1078 matters, as stated in warning note at beginning of %include section).
1079 * src/gdcmDicomDir*.[cxx|h]: coding style
1080 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1081 * src/gdcmJpeg8.cxx: doxygen fix.
1082 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1083 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1084 from File:: to PixelConvert::.
1086 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1088 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1089 - more code moved away from File:: to PixelConvert::
1090 - fat setup of PixelConverter set in place in File::Initialise.
1092 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1094 namespace at the file system level. So now you should convert your examples
1096 gdcmHeader -> gdcm::Header
1097 It would be nice if people keep in mind to no open the namespace, since it
1098 allows compilation on broken plateform which were defining common symbol in
1099 the standart namespace (like LP, Unknown ...)
1101 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1103 The JPEG fragments are now parsed at the same stage than the RLE
1104 information. All code related to JPEG is now in gdcmPixelConvert:
1105 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1106 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1107 export a gdcmFile:: method. Those are simply global functions
1108 (for the time being this is better than having them attach to
1109 either gdcmFile:: or gdcmPixelConvert::).
1110 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1111 and stores the result in a gdcmJPEGFragmentsInfo.
1112 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1113 code (among other stuff) moved away from gdcmFile:; to
1116 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1118 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1119 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1120 clean up of RLE related code.
1121 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1122 - src/gdcmRLE.cxx removed
1123 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1124 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1125 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1126 * CLEANUP_ROUND (9) for gdcmPixelConvert
1127 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1128 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1129 away from gdcmFile:: to gdcmPixelConvert::.
1131 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1133 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1134 This is because Parse7Fe0 used to parse the pixels to compute the
1135 length. This task was passed over to FindDocEntryLengthOB() a long
1136 time ago, EXCEPT I had forgotten the OW case...
1137 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1138 we just recylce the code for parsing RLE fragments and computing
1140 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1141 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1142 with the retired Parse7Fe0().
1143 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1144 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1146 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1148 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1149 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1150 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1151 * CLEANUP_ROUND (4) for gdcmPixelConvert
1152 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1153 to return an unused length.
1155 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1156 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1157 this should be cleanner from the plane view. The iostream are erally a pain
1158 to use to do simple stuff.
1160 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1161 * Redo the compilation of the ijg jpeg library. Now only one source is
1162 necesseray. No need to rename file by hand what so ever. CMake handle the
1163 copying of the file within different directory, configure header file to
1164 modify some symbol. The only addition made to ijg wasd a mangle table so
1165 that symbol are different whether we are within 8bits or 12bits.
1167 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * Added documentation of vtkgdcmReader on Website:
1169 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1170 with it's binary name).
1171 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1172 the Website to be more complete.
1173 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1174 doxygenated documentation.
1175 - Doc/DoxyVtkGdcmReaderExamples.txt added
1176 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1177 DoxyVtkGdmReaderExamples.html )
1178 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1179 * CLEANUP_ROUND (3) for gdcmPixelConvert
1180 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1182 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1183 * CLEANUP_ROUND (2) for gdcmPixelConvert
1184 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1186 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * CLEANUP_ROUND for gdcmPixelConvert:
1188 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1189 - src/gdcmPixelStuff[h|cxx] removed
1190 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1191 - src/CMakeLists.txt changed accordingly
1192 * GDCMHOME clean up:
1193 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1194 gdcmVersion.py moved to newly created ATTIC related
1195 gdcmPython/SetupOldies/ directory.
1196 * Autotools clean up:
1197 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1198 - autogen.sh configure.in acinclude.m4 python.m4 removed
1200 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1202 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1203 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1205 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1206 * TODO updated with Mathieu suggestions. I proposed a template for
1207 describing TODO entries and used it for new entries.
1208 * Added Doc/Website/CodingStyle.html, Developpers.html,
1209 DeveloppersPython.html, GdcmDataCvs.html and
1210 DownloadVersion0_1.html, DownloadVersion0_3.html.
1211 * Some Doc/*.txt Doxygen files (which do not really concern the
1212 documentation itself, but the website) moved to html and
1213 placed in directory Doc/Website:
1214 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1215 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1216 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1217 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1218 * CMakeLists.txt changed accordingly.
1219 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1220 DeveloppersPython.html
1221 * INSTALL nows refers to Doc/Website/Installation.html
1223 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * Added Doc/Website directory, that contains a first raw version
1227 2004-09-23 Jean-Pierre Roux
1228 * FIX In order not to be poluted any longer by casting problems,
1229 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1230 we can now delete[] it safely
1231 * VoidArea is now called BinArea (less confusing name),
1232 and all the methods called ...VoidArea... are now ... BinArea...
1233 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1235 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1236 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1237 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1238 up to the destructor of gdcmElementSet to clean up TagHt and it's
1241 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1243 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1245 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * ENH: added some utility method that builds a flat dictionary
1247 holding all the Dicom entries contained in the recursive structure
1248 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1249 an example of usage.
1250 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1251 BuildFlatHashTable() that build a flat dictionary.
1252 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1253 gdcmDocument is now a friend of gdcmElementSet.
1254 - src/gdcmElementSet.cxx: clean up.
1255 - Example/FlatHashTablePrint.cxx added.
1256 - Example/CmakeLists.txt changed accordingly
1258 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1260 moved away from gdcmDocEntrySet (since this class is an abstract class
1261 acting like an interface). SQDepthLevel and BaseTagKey are now
1263 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1264 and associated accessors. Doxygenation of the class.
1265 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1267 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1268 Use SQDepthLevel accessor instead. ::Print() adapted.
1269 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1270 - src/gdcmDocument.cxx changed accordingly.
1272 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1273 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1274 - The following is the doxygen comment of the typedef declaration
1275 of gdcmTagKey in src/gdcmCommon.h:
1276 gdcmTagKey is made to old an "universal" (as in URL, Universal
1277 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1278 A dicom tag always has a group and an element, but a set of tags
1279 embeded in various (optionally nested) sequences and sharing
1280 the same group and element all share the same (group, element)
1281 "identifier". Hence the (group, element) cannot be used as an
1282 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1283 In order to construct a proper tag identifier (i.e. a key) we
1284 consider the following definition of a TagKey:
1285 - let Group, Element be the string representation of the
1286 group and element dicom tag members,
1287 - let ItemNumber be the string representation of the integer
1288 index of the considered item number of a sequence,
1289 Let the key of a tag embeded in a sequence, noted SeqTag, be
1291 /ItemNumber#Group|Element
1292 where "/", "#" and "|" are characters acting as separators.
1293 Then the general form of a gdcmTagKey is given by:
1294 Group|Element<SeqTag>
1295 where <SeqTag> means NO or many instances of SeqTag.
1296 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1299 but the gdcmTagKey of a tag "embeded" is the first item of
1300 a sequence, itself nested in the third item of a sequence is the
1302 0004|1220/2#0008|0082/0#0008|0090
1303 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1304 order to hold the new sequence compatible key. Previously, the
1305 GetKey() method would look in the underlying gdcmDictEntry.
1306 - src/gdcmDocEntry.cxx:
1307 -- constructor now copies the underlying DictEntry key, in the local
1309 -- ::Print: displays the member Key, instead of the (group, element).
1310 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1311 - src/gdcmDocEntrySet.h:xi
1312 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1313 -- now has a new BaseTagKey member.
1315 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1316 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1318 This poses the problem with the semantics of the following lines
1319 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1320 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1321 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1322 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1323 to the long FIXME note for what the problem is. Nevertheless in
1324 order to get things working the dicom dictionary was altered !
1325 Please fix things urgently...
1326 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1327 information), see above note on moving the member VoidArea. Nevertheless
1328 the following entries previously correctly set as US are now inproperly
1330 0028 1201 OW IMG Red Palette Color Lookup Table Data
1331 0028 1202 OW IMG Green Palette Color Lookup Table Data
1332 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1333 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1334 of gdcmDocEntry moved to gdcmSeqEntry.
1335 * src/gdcmSeqEntry.cxx: STYLE.
1337 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1340 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * gdcmPython/testSuite.py: all the test suite in python is now moved
1342 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1343 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1344 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1346 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1348 to avoid inclusion recursion until STL is reached.
1349 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1350 mecanism. errno.h is not included in gdcm anymore.
1351 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1352 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1354 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1355 gdcmData/TestAllEntryVerifyReference.txt
1356 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1357 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1358 exception_on_error parameter.
1359 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1360 - vtk/vtkGdcmReader.cxx changed accordingly,
1361 - Example/*.cxx and Test/*.cxx changed accordingly.
1363 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1364 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1365 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1366 enable_sequences removed from gdcmHeader constructor and dependencies.
1367 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1368 * gdcmPython/demo/PrintHeader.py: dummy fix.
1369 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1370 skip_shadow removed from gdcmHeader constructor and dependencies.
1371 * Example/*.cxx and Test/*.cxx changed accordingly.
1373 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1375 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1377 2004-07-21 Jean-Pierre Roux
1378 * FIX Now, Parsing and Printing a DICOMDIR do work!
1379 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1381 2004-07-20 Jean-Pierre Roux
1382 * FIX Some brain damaged headers have Zero-Lenght fields
1383 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1385 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1386 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1387 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1388 variable (instance of gdcmDebug) by a definition macro, and the instance
1389 is now in static in the gdcmDebug class
1390 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1391 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1393 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * WARNING: ctest now depends more tightly on gdcmData. You should
1395 check out gdcmData properly for things to run smoothly...
1396 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1397 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1398 we need the pixels not be loaded in order to use the ValEntry
1399 that displays position and size).
1400 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1401 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1402 be deprecated. If you have any doubts about the advantages of a
1403 modern scripting language (read Python) versus grass root C++ (i.e.
1404 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1405 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1406 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1407 Anyhow, consider documenting the gdcmData images in
1408 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1410 * Test/CMakeLists.txt:
1411 - now uses TestAllEntryVerify.cxx
1412 - specific comments on oldACR00001.ima (now renamed in gdcmData
1413 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1414 gdcmData/TestAllEntryVerifyReference.txt
1417 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * src/*.[h|cxx] : typedef clean up
1419 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1420 - TagKey renamed to gdcmTagKey (for external usage)
1421 - VRKey renamed to gdcmVRKey (for external usage)
1422 - removal of typedef duplication.
1423 - Removed all unecessary inline keyword from class inline definitions.
1424 - Some method|function(void) declarations replaced with method|function().
1425 * src/jpeg/libijg12/jdhuff12.c:
1426 - printf polluting ctest removed.
1427 - TAB removal for comminting
1429 - TestAllReadCompareDicom.cxx: added a test that compares all the
1430 images in gdcmDataImages.h with corresponding images in
1431 gdcmData/BaselineDicom/. When baseline images are not present
1432 this test creates them.
1433 Note: we need to validate each reference image, but before that
1434 I'd like to rename them with a more explicit name...
1435 - CMakeLists.txt: changed accordingly.
1436 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1437 including each header needed).
1439 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1441 test suite to the Example directory. Are concerned:
1446 - TestWriteSimple.cxx
1447 * Test/CMakeLists.txt: added some comments on reasons for black listing
1448 image gdcmData/oldACR00001.ima
1450 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * Test/CmakeList.txt: removed the following from black list (to be coherent
1452 with removal from gdcmData):
1453 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1454 - gdcm-MR-PHILIPS-16.dcm
1456 Added the following because after last cvs update, they cause
1457 ctest -R TestReadWriteReadCompare
1459 - gdcm-MR-SIEMENS-16-1.acr
1461 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1462 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1463 new comments in this file) we temporarily (sigh) move to a weaker
1465 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1466 we don't need to black list the following images anymore:
1467 - 8BitsUncompressedColor.dcm
1469 - US-PAL-8-10x-echo.dcm
1470 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1471 fixes and the beautified code ;-)
1472 This fixes the bug introduced in version 1.42 (when beautifying)
1473 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1474 Note: ctest was blind to this bug (this means we need to still
1475 improve the test suite). The bug could be detected by using
1476 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1478 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1479 and by displaying the (garbage) produced file temp.XDCM...
1481 2004-06-29 Jean-Pierre Roux
1482 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1483 - replace by uggly but working old code :-(
1484 A lot of things should be OK again.
1485 It's really urgent to have a test suite that *tests*,
1486 to prevent Frog's beautifying sessions to break all the stuff
1487 (twice, withing a fortnigh ...)
1489 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1490 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1491 redundancy) to added Test/TestReadWriteReadCompare.cxx
1492 * Test/CmakeList.txt: because the compare test of
1493 Test/TestReadWriteReadCompare.cxx fails, the following images are
1494 black listed: - 8BitsUncompressedColor.dcm
1496 - US-PAL-8-10x-echo.dcm
1497 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1498 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1499 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1500 and ad-hoc kludge. This kludge is now removed, and on encountering
1501 such an image (OB field brain damaged) we set errno. Then in
1502 ::FindDocLength() we "fix" the length as being ALL what remains
1503 in the file (until EOF). We then proceed, hoping for the best...
1504 This fixes a SegFault in ShowDicom when trying to write such an
1506 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1507 (because TestWriteRead breaks on it, after a non conformal commit?).
1508 ctest now runs properly, except for MakeDicomDir (which was always
1509 broken) and the Python related stuff (still not fixed).
1511 2004-06-24 Jean-Pierre Roux
1512 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1513 FIX : Test/TestReadWrite now iterates on all the file names
1514 (instead of infinite loop)
1515 ENH : Test/TestWriteRead now iterates on all the file names
1517 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1518 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1520 2004-06-24 Jean-Pierre Roux
1521 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1522 when SamplesPerPixel =3
1523 - now Write is no longer confused by
1524 'BitsAllocated = 12" and 'BitsStored=12"
1525 - "UN" value representation Elements are now written correctly
1526 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1527 ENH : - now gdcmHeader has its own Write methods
1528 (in order to split the job that has not to be done
1531 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1532 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1533 loop on the same image until memory went out.
1534 Note: this means we still have gobs of memory loss in PrintDocument
1535 * src/gdcmDocument.cxx: fixes problem on parsing on file
1536 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1538 2004-06-24 Jean-Pierre Roux
1539 FIX : Write - All the Sequences and Sequence Item are now written
1540 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1541 is added a the end, when necessary.
1542 - A lot of brain-damaged images, that were read correctly are
1543 now written correctly
1544 - length compatible BinEntry are now loaded correctly
1545 (even for odd groups)
1546 Note : only Explicit Value Representation was checked.
1547 (question : is implicit VR really necessary for gdcm ?)
1549 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1550 * DEVELOPPER: added a proposition of coding style.
1551 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1554 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1555 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1556 Use the gdcmDocEntry::Print() and Write() instead.
1557 * src/gdcmDocument.cxx: bug fix.
1559 2004-06-22 Jean-Pierre Roux
1560 FIX : gdcmDocument.cxx
1561 - Now we do recognize the JpegLossLess format (there was a misstyping in
1562 code 'beautyfication' :-(
1563 - Now we automaticaticaly load the Luts, if any
1565 2004-06-22 Jean-Pierre Roux
1566 In order : to write Sequences, whatever their imbrication level,
1567 : to allow user to create his own Sequences
1568 a lot of modif where necessary (adding, moving, or virtualising methods)
1570 WARNING : save your own sources *before* cvs up !
1573 ADD virtual void Write(FILE *fp, FileType filetype);
1576 ADD virtual void Write(FILE *fp, FileType filetype);
1577 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1580 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1581 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1582 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1583 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1584 ADD std::string GetEntryByName(TagName name);
1585 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1587 std::string vr = "unkn",
1588 std::string fourth = "unkn",
1589 std::string name = "unkn");
1590 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1591 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1592 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1593 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1594 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1595 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1596 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1597 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1600 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1601 ADD virtual std::string GetEntryByName (TagName tagName);
1602 ADD virtual std::string GetEntryVRByName (TagName tagName);
1603 REM virtual bool Write(FILE *, FileType);
1604 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1605 FILE *_fp, FileType type);
1606 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1607 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1608 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1609 REM virtual std::string GetEntryByName (std::string tagName);
1610 REM virtual std::string GetEntryVRByName (std::string tagName);
1611 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1612 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1613 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1615 std::string vr = "unkn",
1616 std::string fourth = "unkn",
1617 std::string name = "unkn");
1618 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1619 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1620 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1621 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1624 ADD virtual void Write(FILE *fp, FileType filetype);
1627 ADD virtual void Write(FILE *fp,FileType filetype);
1630 ADD virtual void Write(FILE *fp, FileType filetype);
1631 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1632 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1633 REM std::string GetEntryByName(TagName name);
1636 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1638 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1640 The default constructor invoked by the line
1641 gdcmHeader *f1 = new gdcmHeader( header );
1642 was gdcmHeader::gdcmHeader(bool) instead of the expected
1643 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1644 Hence the parsing wasn't executed... See also below.
1645 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1646 as explicit constructor didn't do the trick to fix the above problem.
1647 Could anyone explain why ?
1648 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1649 properly calls gdcmValEntry::Print() (that was weed out from
1650 code related to gdcmBinEntry).
1652 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1653 * In order to fix memory leaks:
1654 - Test/TestWriteSimple.cxx: added cleaning of free store through
1656 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1657 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1658 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1659 (through the call to ::AddDicomDirMeta()) or the destructor
1660 would crash when deleting uninitialized ::metaElems].
1661 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1662 - src/gdcmDocument.cxx:
1663 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1664 from dynamic stores.
1665 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1666 was causing memory leaks.
1667 - src/gdcmSQItem.cxx:
1668 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1669 cleanly handled with polymophism: sorry but my milage is low).
1670 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1671 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1672 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1673 This avoids SegFaulting.
1674 - src/gdcmSQItem.h: coding style.
1676 - Test/TestWriteSimple still severely sucks. The output image content
1677 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1678 damaged when displayed with vtkgdcmViewer.
1679 - on memory leaks: TestWriteSimple leaks really less (see entry
1680 of 2004-06-18 in Changelog file for the call to valgrind).
1681 - on segfaults: ctest now passes all the tests but one (no more
1683 * Erroneous leading white fix:
1684 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1685 white[s] (as opposed to from >> xxx, that removes it [them].
1686 - src/gdcmTS.cxx: ditto.
1687 - gdcmPython/testSuite.py: dirty related kludge removed.
1688 * src/*: remaining references to gdcmParser removed.
1689 * src/*[cxx|h]: added copy[way]left header.
1692 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * In order to fix writing of dicom files:
1694 - Test/TestWriteSimple.cxx: a simpler example of writing.
1695 - Test/CMakeLists.txt changed accordingly.
1696 - src/gdcmDocument.cxx:
1697 -- The destructor now recursilvely removes potential sequences.
1698 -- Bug fix in ::IsJPEG2000()
1699 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1700 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1702 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1703 to only declared) and build on top of
1704 ::GetDocEntryByNumber(guint16, guint16).
1705 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1706 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1707 for usage in destructor and treatement of promotion in
1708 ::ReplaceOrCreateByNumber().
1709 - src/gdcmSQItem.cxx: destructor should better handle his job.
1710 Test/TestWriteSimple now runs (or at least it DOES something).
1711 * We can now start hutting memory links. A good starting point is:
1712 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1713 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1714 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1716 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1717 * Valgrind note: after Mathieu Malaterre teached me how to read
1718 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1720 Using gcc, you can force the STL to use malloc and to free memory as
1721 soon as possible by globally disabling memory caching.
1722 With 3.2.2 and later, you should export the environment variable
1723 GLIBCPP_FORCE_NEW before running your program.
1724 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1725 simply vanish (it is still not clear to me, whether this means that
1726 STL std::string leaks or if valgrind believes it leaks...).
1727 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1728 running bin/gdcmTests makeDicomDir):
1729 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1730 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1732 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1733 SegFaulting (I drowned in DicomDir related code when trying to
1734 understand why the list is empty...).
1735 * src/gdcmDocument.h: first BSD license header try.
1736 * Doc/License.txt added.
1738 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1739 * src/gdcmDocument.[h|cxx]:
1740 - Clean up of the Transfer related predicates. They are now all based
1741 on new method isGivenTransferSyntax, that (should) handle properly
1742 the padding problem.
1743 - general clean up, simplification, and coding style.
1744 - Specific clean up of Parse7FE0() (umproperly named actually).
1745 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1747 2004-06-14 Jean-Pierre Roux
1749 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1750 - fix the display of SQItem ordinal number
1751 - add the GetSQItemByOrdinalNumber method
1752 - remove some useless never written private methods
1754 2004-06-14 Jean-Pierre Roux
1756 - adding a constructor taking a gdcmDocEntry as an input param
1757 - ReplaceOrCreateByNumber now returns :
1758 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1759 a gdcmValEntry * if a string value is passed as a param
1761 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1762 according to the param type (no longer sets a gdcmDocEntry)
1763 - GetValEntryByNumber, GetBinEntryByNumber added
1764 - NewValEntryByNumber and NewBinEntryByNumber added
1766 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1768 - GetSQItemNumber and SetSQItemNumber added, to provide
1769 a (relative) Item identier inside a given Sequence
1770 \warning : some pb remaining around this number
1772 - AddEntry now takes the Item Number as a param
1774 - adding a constructor taking a gdcmDocEntry as an input param
1776 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * Memory leak hunt with the following command:
1778 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1779 --show-reachable=yes gdcmTests PrintDocument
1780 It looks like many (all?) leaks are due to the STL (or a bad usage
1781 of the STL. The lines producing the leaks now have a comment with
1782 a "MEMORY LEAK" tag: you can retrieve them with
1783 grep "MEMORY LEAK" src/*
1784 Here are two typical examples which I can't help fixing:
1789 char * test = "babo";
1790 name = test; //// <--- valgrind detects 960 bytes lost in
1791 //// call to std::string::operator=(char const*)
1792 name.clear(); //// Doesn't help !
1800 std::cout << "Type a bunch of characters followed by RETURN: ";
1801 getline(std::cin, line); //// <--- valgrind dectects a loss
1802 //// of 1320 bytes in call to
1803 /// std::basic_istream<>& std::getline<>
1809 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * src/gdcmHeader.[cxx|h]:
1811 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1812 and related, moved away to gdcmDocument.
1813 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1814 the corresponding protected accessors of inherited class
1815 gdcmDocument, removed ! As a consequence gdcmFile had to be
1816 declared friend of class gdcmDocument (see below).
1817 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1818 - Clean up of undefined or unused methods.
1819 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1820 account the changes to gdcmHeader.h).
1821 * src/gdcmDocument.h:
1822 - gdcmFile is now a friend class (in order to take into account the
1823 changes to gdcmHeader.h).
1824 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1825 (see changes to gdcmHeader.h).
1826 - Accessors (reading on the form GetEntry*) are now public.
1827 - Clean up of undefined or unused methods.
1828 * src/gdcmDocument.cxx:
1829 - adaptation to changes to gdcmDocument.h
1830 - ::OpenFile now writes a verbose message when file cannot be opened.
1831 - some std::string properly set to VRKey
1832 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1833 references to gdcmDocument.
1834 * Test/TestFindTags.cxx: changed accordingly to above changes.
1835 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1836 cvs repository gdcmData.
1838 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1840 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1841 conflicts with gdcmValEntry::voidArea.
1842 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1843 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1844 Value representation between StringRepresentable and BinaryRepresentable.
1845 * src/gdcmDocument.cxx:
1846 - method ParseDES: proper indentation restored and usage of
1847 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1848 - method LoadDocEntry: the fingerprint left in the SetValue() of
1849 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1850 removed. Reverting to previous code segment with the proper
1851 dynamic_cast< gdcmValEntry* >.
1852 Note: this was (partially) breaking the python test suite
1853 (gdcmPython/testSuite.py) that made usage of the above
1854 fingerprint to check presence of "Pixel Data".
1855 * src/gdcmDocEntry.h: coding style.
1856 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1857 now taken into account.
1858 * gdcmPython/gdcm.i: adaptation to the new internal representation
1859 of gdcm (exit gdcmParser, hello gdcmDocument).
1860 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1862 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1863 anymore, but instead prints the loaded Python dictionary.
1864 * .... alas, the python testSuite is still broken.
1866 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1867 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1869 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1870 * src/gdcmUtil.h : export methods
1872 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1875 * Initial addition of automatic python testing
1876 * Initial addition of automatic image comparison
1878 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1879 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1880 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1882 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1884 * Test/ShowDicom.cxx : bug fix for msvc compilation
1885 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1887 2004-05-04 Jean-Pierre Roux
1888 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1889 new concepts (and new classes) :
1890 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1891 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1892 - Sequence Doc Entries (gdcmSeqEntries)
1893 a Sequence is composed of Items.
1894 Each item is a set of Doc Entries (this is recursive)
1895 The non uniqueness of the 'Dicom tag' is due to this recursivity
1896 (never taken into account)
1897 Our unability to add a new 'entry' in the header
1898 at the proper location (neither in the H-Table (map or multimap),
1899 nor in the Chained List is also due to this recursivity.
1900 Don't try, right now, to use/modify/compile these new sources :
1901 nothing is finished.
1902 We just commit all the stuff, 'as is', in order not to loose it.
1904 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1907 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1908 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1909 file prefix (SetFilePrefix)
1911 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * Add a new test: ShowDicom, for now this is just the c++ version of
1913 checkRead.sh, later it will be able to compare the image read against a
1915 * Replace the DEBUG on the stack with a global entry in cmake interface:
1916 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1918 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1919 * Add an example subdir, with a real example on how to read + write a
1922 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1924 * Doc/CMakeLists.txt: the main page is now properly differentiated
1925 between the developper and user version.
1926 * Doc/doxygen.config.in: dropped search related obsolete flags
1927 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1929 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * DEVELOPPER: added some helpfull comments for compile/test/install
1933 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1935 src directory, now generated in the build dir.
1936 2. Tests as mentionned smarter
1938 4. Add a new method in gdcmDict that return the PubDict by name
1939 this is interesting for 3rd party lib like ITK,
1940 where we could set the institution name / patient name...
1942 * ENH: 1. Now the test suite is working for real
1943 2. All binaries are now output in the gdcm-bin directory
1944 (this was not true before)
1946 2004-04-28 Jean-Pierre Roux
1947 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1948 SeQuence indented printing of Dicom Header.
1949 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1950 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1951 Computation of SQDepthLevel is now part of gdcmHeader constructor
1952 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1953 tree-like structure of a Dicom Header.
1954 * FIX Test code cleaning
1956 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * ENH: Adding automatic testing
1958 1. Need a DartConfig.cmake to submit to public
1959 2. Add a test driver gdcmTest.cxx
1960 3. gdcmTestMain, an helper for the main test driver gdcmTest
1961 4. Files in Test don't have a main anymore, this becomes interesting
1962 when we add more and more tests, thus dsw don't have to load
1964 * ENH: Adding a GDCM_DATA_ROOT for testing
1965 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1966 one file instead of seven + some small cleanup
1968 2004-04-22 Jean-Pierre Roux
1969 * ENH Minor changes to the Print() methods.
1970 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1971 Header printing. Example given with :
1972 > PrintHeader fileName 2 new
1973 (SQ based tree-like structure still to be done for the Header ...)
1975 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1977 1. I have added some unsigned where needed
1978 2. Some function parameter not used -> (void)
1979 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1980 4. g++ don't like character '\' in comment
1981 5. #define jpeg_create_decompress jCreaDecompress
1982 this really need to be fixed
1983 6. virtualize destructor of gdcmObject ... leakage
1984 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1985 this also really need to be fixed
1986 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1987 remove compression file
1988 (as we only do decompression, right ?)
1989 * ENH: Change malloc/calloc/free with c++ equivalent
1991 2004-04-21 Jean-Pierre Roux
1992 * FIX gdcmHeaderHelper::GetXSpacing
1993 when a single value is found (bug ?), xpacing is now
1994 defaulted to yspacing
1996 2004-04-19 Jean-Pierre Roux
1997 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1998 * ENH add parameters :
1999 bool exception_on_error = false,
2000 bool enable_sequences = false,
2001 bool ignore_shadow = false
2002 to the gdcmFile constructors to be full gdcmParser compliant
2003 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2004 to allow reading of PAPYRUS 3.0 files
2006 2004-04-06 Jean-Pierre Roux
2007 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2009 2004-04-02 Jean-Pierre Roux
2010 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2011 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2012 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2014 2004-03-30 Jean-Pierre Roux
2015 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2016 for ACR file, written out as DICOM files (hope so...)
2018 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2020 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2021 moved to base class gdcmParser and only the specialisation is kept
2023 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2024 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2025 already does the job.
2026 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2027 (to be consistent with gdcmParser::WriteEntries).
2029 2004-03-30 Benoit Regrain
2030 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2031 upate of the object's instance. It's passed to 2 in the unfavorable
2032 case : one in the ExecuteInformation, one in the ExecuteData
2034 2004-03-29 Jean-Pierre Roux
2035 * ENH : Check on file type to be written moved
2036 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2037 * FIX : gdcmObject::ResetBoundaries now stops properly
2038 when end-of-list is reached
2039 : gdcmVersion modified (as Benoit Regrain asked)
2041 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2043 * src/gdcmUtil.cxx: added forgotten iostream include.
2044 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2045 equivalent to ExplicitVR in existing code).
2047 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2049 now contains all the gdcmGlobal related code.
2050 * minor coding style and doxygenation changes.
2052 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2054 now contains all the Debug related code.
2055 * minor clean-up of includes in src/*.cxx
2056 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2057 CreateCleanString) removed.
2058 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2059 * Doc/DoxyMainPageUser.txt added.
2060 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2061 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2062 src/gdcmDirList.cxx)
2064 2004-03-24 Jean-Pierre Roux
2065 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2067 2004-03-23 Jean-Pierre Roux
2068 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2069 big endian made volumes
2070 * ENH Now gdcmParser constructor and destructor are protected to forbid
2071 end user to instanciate class gdcmParser
2072 (only gdcmHeader and gdcmDicomDir are meaningfull)
2074 2004-03-22 Benoit Regrain
2075 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2076 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2077 gdcmSerie to gdcmDicomDirSerie
2079 2004-03-19 Jean-Pierre Roux
2080 * ENH Now the tree-like structure describing a DICOMDIR comming from
2081 an already existing DICOMDIR file is consistent with
2082 the home-made tree-like structure build ex-nihilo
2083 or build from the files held (recursively) in a Directory
2084 functions gdcmDicomDir::CheckBoundaries()
2085 gdcmObject::SetBoundaries() added
2087 2004-03-17 Jean-Pierre Roux
2088 * REM (Eric Boix bug) : removal of meaningless
2089 gdcmDicomDirImage::NewImage function.
2090 * FIX now file names and directory name are written properly in the
2092 * FIX now gdcmDicomDir constructor may be call without any trick
2095 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2097 of gdcmDicomDirImage::NewImage as empty function.
2099 2004-02-28 Jean-Pierre Roux
2100 * ENH add gdcmDicomDir:NewPatient
2101 add gdcmDicomDirPatient:NewStudy
2102 add gdcmDicomDirStudy:NewSerie
2103 add gdcmDicomDirSerie:NewImage
2104 to allow making gdcDicomDir object.
2105 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2106 (as opposite to the gdcmHeader chained list)
2108 2004-02-11 Benoit Regrain
2109 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2110 when using from python
2112 2004-02-10 Benoit Regrain
2113 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2114 * FIX : in gdcmDicomDir when the directory is empty
2115 * ENH : add callback and methods to get the progression of dicomDir
2118 2004-02-06 Jean-Pierre Roux
2119 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2120 - GDCM_META added to gdcmDicomDirType
2121 - class gdcmMeta created
2122 * ENH : - A brief summary is now displayed at the beginning of
2123 'testDicomDir' to help disaster magnitude estimation
2124 * REM : Now useless Test/explDICOMDIR.cxx
2126 2004-02-05 Benoit Regrain
2127 * ENH : add methods in gdcmObject to get the hash table or the list of
2129 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2130 * FIX : wrapping python for TagHeaderEntryHT
2132 2004-02-04 Benoit Regrain
2133 * FIX : even length for some strings when writting the dicom dir
2134 * FIX : sort the images in the dicom dir
2135 * FIX : Bug fix for python use of dicom dir
2136 * ADD : a python demo
2138 2004-02-04 Jean-Pierre Roux
2139 * FIX : Final solution (?) for icone embedded images
2140 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2141 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2142 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2143 gdcmData/gdcm-MR-SIEMENS-16.acr1
2144 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2145 to make full checking easier
2147 2004-02-04 Benoit Regrain
2148 * FIX : WriteEntries : coding style & logic in parameters
2149 * FIX : Set the elements to create the DicomDir in a dictionary file
2151 2004-02-03 Benoit Regrain
2152 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2153 * gdcmDicomDir : add the load of directory
2154 * Bug fix and print add-on
2156 2004-02-03 Jean-Pierre Roux
2157 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2158 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2159 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2160 * FIX gdcmParser.cxx : 'group length' elements are now considered
2161 as integers, even for shadow groups, when file is Implicit VR
2163 2004-02-02 Jean-Pierre Roux
2164 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2166 of the last synonym :-(
2167 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2169 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2170 * FIX taking into account the possible 7fe0,0010 multiplicity
2171 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2172 to allow removal of references to 7fe0,0010, to deal with
2173 ACR-NEMA images, when 0028,0200 is meaningfull
2175 2004-01-31 Jean-Pierre Roux
2176 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2177 no longer writes 'Un' on disk
2178 * FIX SQ elements with actual length are now dealt with corectly
2179 * FIX gdcmFile::WriteBase make the difference, for color images, between
2180 the length (for Palette expanded images)
2181 and Raw Length (non expanded image + Palette)
2182 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2183 (that broke Write). Replaced by UL.
2184 Aware user will reload the field if he
2185 thinks it's necesssary
2187 2004-01-30 Jean-Pierre Roux
2188 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2189 when 'dirty Acr' is found, to be compliant with the new
2190 IsReadable() methods.
2192 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2193 (no DOUBLE images in kosher DICOM,
2194 but so usefull for people that miss them ;-)
2196 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2197 DICOMDIR related utilities (not checked as Windoze compliant)
2199 2004-01-28 Jean-Pierre Roux
2200 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2202 2004-01-27 Jean-Pierre Roux
2203 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2204 to allow skipping the shadow elements, to save memory space.
2205 The TRUE value for this param has to be used
2206 with a FALSE value for the 'enable_sequence' param.
2207 ('public elements' may be embedded in 'shadow Sequences')
2208 * gdcmHeader methods now deal with 'embedded icones images' in the header
2209 (even when an 'icone image sequence' is announced by the
2210 element (0x0088,0x0200), but there is NO icone at all ...
2212 * gdcmHeader sometimes Image Location value doesn't follow
2213 the supposed processor endianity (see gdcmData/cr172241.dcm).
2216 * gdcmHeader add the method
2217 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2218 to get *all* the Header Entries with the same tag.
2219 GetHeaderEntrySameName is probabely *useless*
2220 (no meaning : Name is *not* an identifier within the Dictionary)
2222 2004-01-26 Benoit Regrain
2223 * Bug fix in the print of hexadecimal representations. Remove long fields
2224 in the print and add a third level of print to print them
2226 2004-01-23 Benoit Regrain
2227 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2228 * Bug fix on test suite after remove the strip made on not string fields
2229 * Split the IsReadable method between gdcmParser which test that the file
2230 is dicom and gdcmHeader which test that it's an image file
2232 2004-01-22 Benoit Regrain
2233 * DicomDir : clean code, add methods, set variables in protected or private
2234 * gdcmUtil : bug fix for the clean string method
2236 2004-01-19 Benoit Regrain
2237 * Add the use of shadow dictionaries
2238 * bug fix and coding style
2240 2004-01-19 Benoit Regrain
2241 * src/gdcmFile.cxx : bug fix concerning the close of file
2242 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2243 * Add the update of header entries using the shadow library
2245 2004-01-19 Benoit Regrain
2246 * removal of file gdcmHeader2.cxx
2247 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2248 inheriting from gdcmParser. This split is to prepare the integration
2249 of dicom dir parsing
2250 * bug fix under python
2252 2004-01-16 Jean-Pierre Roux
2253 * REM removal of class gdcmHeaderEntrySet
2254 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2255 * ADD add file gdcmHeader2.cxx
2256 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2258 2004-01-15 Benoit Regrain
2259 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2260 entries created while parsing the header. Thus, they will be destroyed
2261 when the gdcmDictSet will be destroyed
2262 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2265 2004-01-15 Benoit Regrain
2266 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2267 made a fatal error because of the memory release at the end of program.
2268 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2269 some memory and vtk seems to have some problems with that.
2270 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2272 2004-01-14 Benoit Regrain
2273 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2274 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2275 * src/*.[h|cxx] : make changes due to class name changes
2276 * gdcmPython/demo/*.py : bug fix due to method names
2278 2004-01-13 Benoit Regrain
2279 * src/*.[h|cxx] : coding style
2280 * vtk/*.[h|cxx] : coding style
2282 2004-01-13 Benoit Regrain
2283 * gdcmPython/testSuite.py : test the readable flag of file for tests
2284 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2285 It's lied to the stl compilation by MSVC (windows, always windows...)
2286 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2288 2004-01-12 Benoit Regrain
2289 * src/*.h : add comments
2290 * src/gdcmDictSet.h : set the method BuildDictPath in public
2291 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2292 directly setted in the source code
2293 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2296 2004-01-09 Benoit Regrain
2297 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2298 * setup.py : use a reference to gdcmVERSION
2300 2004-01-07 Benoit Regrain
2301 * Modification to compile with the distutils.
2304 2003-12-10 Benoit Regrain
2305 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2306 can use a gdcmHeaderHelper to load data
2307 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2308 made in the source code
2310 2003-12-10 Benoit Regrain
2311 * Update Windows projects and .cvsignore files
2313 2003-11-12 Jean-Pierre Roux
2314 * ENH gdcmHeader constructor has one more parameter (default value : false)
2315 that allows the user to 'go inside' the SeQuences only
2317 gdcmElValSet:Print takes it into account
2319 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2320 * ENH: Update gdcmPython/CMakeLists
2321 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2322 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2324 2003-11-10 Jean-Pierre Roux
2325 * FIX : gdcmHeader::LoadElements is now based
2326 on the ListTag listElem member,
2327 not longer on the TagElValueHT tagHt member
2328 * ENH : PrintPubElVal shows (temporarily) both results,
2329 with the tagHt member and the listElem member.
2330 (it's easier to 'see' the problems when using Printheader)
2332 * FIX : old private member LgrElem is now splitted into
2333 ReadLength : Length actually found on disk (updated only
2334 if bug fixing is necessary), for internal
2336 UsableLength : Updated by FixFoundLength, to fix a bug
2337 or to allow Parser going on.
2338 Will allow to re-write a kosher header when a SeQuence
2339 with a length (not 0000) is found
2340 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2341 because gdcmElValSet::Add does not update ListElem
2344 2003-11-07 Jean-Pierre Roux
2345 * FIX misstyping in Transfert Syntax name table
2346 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2347 when they have an actual length (not 0000 nor FFFFF)
2348 (Nobody should care of it, but DICOMDIR explorers)
2350 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2353 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * ENH: vtkGdcmReader now supports LUT !
2355 (vtkgdcmViewer for now is not able to use them though)
2357 2003-11-05 Jean-Pierre Roux
2358 * in testSuite.py : new files names for checking the package
2359 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2360 that returns the pixel area size to the *aware* (vtk) user
2361 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2363 2003-11-05 Benoit Regrain
2364 * in testSuite.py : Modify the rules for checking the paths
2365 : Explicit error messages
2366 * in __init__.py : Related modif
2368 2003-11-03 Jean-Pierre Roux
2369 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2370 to be used by aware (vtk) users that want to manage
2371 LUT (and no to turn the PALETTE image into an RGB pixels one)
2372 * GetPixelType now returns 8U for 24 Bits images
2373 (vtkGdcmReader compliant)
2375 2003-10-31 Jean-Pierre Roux
2376 * Removal of *all* gdcmData images and add them again
2377 in order to loose the 'history' of un-anonymised images
2379 2003-10-31 Jean-Pierre Roux
2380 * RMV : removal of useless jBitsInJsample.h
2381 for both 8 and 12 Bits JPEG Lossy Libraries
2383 2003-10-31 Jean-Pierre Roux
2384 * ENH : Add the functions gdcmFile::GetImageDataRaw
2385 gdcmFile::GetImageDataIntoVectorRaw
2386 that act as GetImageData and GetImageDataIntoVector
2387 except the making of an RGB Plane from Gray Plane + LUT
2388 Intended to aware (vtk) users who know how to manage
2391 GetLUTRGBA return a R,G,B,A LUT if any
2392 lgrTotaleRaw gives the 'Raw' length
2393 GetImageDataRaw returns the gray Plane
2394 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2395 (They stay Grey, just like with other Dicom viewers :-(
2397 2003-10-30 Jean-Pierre Roux
2398 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2400 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2402 being coherents dicom files.
2404 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2407 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2408 * ENH: Two steps is necessary to please VC++ compiler...
2409 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2410 * ENH: Add include dir to medcon lib
2411 * FIX: only one function is being exported for now !
2412 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2414 2003-10-29 Jean-Pierre Roux
2415 * adding gdcmHeader::GetLUTRGBA
2416 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2417 --> Mathieu, the modif u're waiting for is not yet committed
2418 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2420 2003-10-27 Jean-Pierre Roux
2421 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2422 00191113.dcm DermaColorLossLess.dcm
2423 MxTwinLossLess.dcm RadBWLossLess.dcm
2424 * ENH: For version prior to vtkImageViewer2 -r 1.19
2425 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2427 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * Removal of ido stuff in CMakeLists.txt
2430 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2432 * FIX: remove a call to ->Modified ... see comments
2433 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2435 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2436 * FIX: Problem with path for libvtkgdcmPython
2437 * ENH: Try adding a search script for python site-package
2438 * RMV: Remove some file from medcon lib that are not necessary
2439 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2440 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2441 * FIX: More pragma disable fro VC++,
2442 I don't think I break something as it is also disable in VTK/ITK.
2443 But it fasten debug compilation time.
2445 2003-10-23 Jean-Pierre Roux
2446 * gdcm now deals with 16 Bits Run Length Encoded images
2447 (they are compressed as 2 planes images,
2448 one for the high Bytes, the other for low Bytes)
2450 2003-10-22 Jean-Pierre Roux
2451 * Now CheckRead takes into account :
2452 - the bugged 'Leonardo' Siemens images
2453 - the XA images, sent thru the burning VPRO station
2454 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2457 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2458 * FIX: When copying a Makefile.am to CMakeLists.txt
2459 one should remove the '\'
2461 2003-10-22 Jean-Pierre Roux
2462 * in gdcmData adding a bugged 'Leonardo' Siemens image
2463 (wrong lengths in header)
2464 OK with gdcm, KO with the other viewers :-)
2465 * add a GE dlx XA image, thru the VEPRO burning station
2468 2003-10-21 Jean-Pierre Roux
2469 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2470 for a brutal checking of vtkgdcmViewer compliance
2472 2003-10-21 Jean-Pierre Roux
2473 * add the files for 'xmedcon' Jpeg Lossless library
2474 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2476 2003-10-21 Jean-Pierre Roux
2477 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2479 2003-10-21 Jean-Pierre Roux
2480 * garbage Siemens 'Leonardo' images dealt with
2481 (the patch is easy to remove)
2482 * cosmetic changes to avoid warnings
2484 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2485 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2486 no need to press 'r' now.
2488 2003-10-20 Jean-Pierre Roux
2489 * upgrade of checkRead.sh checkWrite.sh according
2490 to new Jpeg Lossless decompressor
2491 * add US.3405.1.dcm, a genuine RGB medical file ...
2492 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2493 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2495 2003-10-15 Jean-Pierre Roux
2496 * general anonymisation in gdcmData
2497 * adding the 'color files' from
2498 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2499 * adding some well knowed bugged-header images
2500 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2501 waiting for their inclusion in Python testsuite
2503 2003-10-15 Jean-Pierre Roux
2504 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2505 no longer seg faults when file is not found
2507 2003-10-14 Jean-Pierre Roux
2508 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2511 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * TODO: *.in file to genereate a UseGDCM later
2514 2003-10-14 Jean-Pierre Roux
2515 * Some supposed-to-be Dicom Images have no preamble.
2516 OpenFile takes it into account
2517 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2518 * Missing elements added in dicomV3.dic
2519 (just to be affraid : have a look at
2520 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2521 and do it again next year ;->
2523 2003-10-13 Jean-Pierre Roux
2524 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2525 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2526 But there are NOT. It's fixed !
2528 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2529 * FIX: "jpeglib.h" was not found on VC++
2530 * FIX: vtkgdcm was not being installed
2532 2003-10-10 Jean-Pierre Roux
2533 * ENH : OpenFile closes the file if it *really* doesn't look like
2534 an ACR-NEMA / DICOM one.
2535 * FIX : testWrite no longer writes an empty file if the source file
2536 is not gdcm Readable
2537 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2540 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2541 * FIX: CMake generate now documentation
2542 * ENH: out of source doc build !
2543 * ENH: Generate both user and dev documentation
2544 * ENH: Should work on windows too
2545 * ENH: Only one doxygen config.in file is needed
2546 * FIX: make install should be ok now on ùnix plateform
2547 * FIX: PATH to dictionary was wrong (missing /)
2548 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2550 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2551 * vtkGdcmReader is now able to read rgb dicom file.
2552 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2553 * added a gdcmViewer to vtk test, use mouse to control
2554 window level & window width
2556 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * CMake-ification of gdcm, we have now two build system
2558 * FIX: on cygwin Wsock32 doesn't exist
2559 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2561 2003-10-06 Emanuel Ollart
2562 * FIX : compilation process wad broken.
2563 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2565 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2566 * change gdcmViewer -> vtkgdcmViewer
2567 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2569 2003-10-06 Jean-Pierre Roux
2570 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2571 ( e.g : well known GE images with a wrong elem length,
2572 : Philips MRI Images with a wrong Huffman table)
2573 * still to be done : allow the reading of bugged LEONARDO Siemens images
2575 2003-10-03 Jean-Pierre Roux
2576 * Odd length strings are padded with '\0' (not with spaces,
2577 to remain compliant with already defined strings,
2578 like Transfert Syntax UID and others)
2580 2003-10-03 Jean-Pierre Roux
2581 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2582 to allow displaying RGB images (not only by affim ;-)
2584 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2585 * vtkGdcmReader is now able to read rgb dicom file.
2586 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2588 2003-10-03 Jean-Pierre Roux
2589 * A few nasty patches to allow the reading of a lot of nasty images
2590 ( e.g : well known GE images with a wrong elem length,
2591 : Philips MRI Images with a wrong Huffman table)
2592 * still to be done : allow the reading of bugged LEONARDO Siemens images
2594 2003-10-03 Jean-Pierre Roux
2595 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2597 2003-10-03 Jean-Pierre Roux
2598 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2599 to allow displaying RGB images (not only by affim ;-)
2601 2003-10-03 Jean-Pierre Roux
2602 * gdcmFile::GetImageDataIntoVector now
2603 - deals with MultiFrames MultiFragments Run Length Encoded files
2604 - deals with YcBcR (YBR_FULL) files
2605 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2606 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2608 (no sample found :-(
2610 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2611 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2612 Two reasons: - clear things
2613 - third parties acces gdcm through header files, so won't
2614 suffer anymore VC++ complains
2616 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2617 * add argv[1] in testvtkGdcmReader.cxx
2620 2003-09-24 Jean-Pierre Roux
2621 * The lines are now eigthy characters long.for
2622 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2624 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2625 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2626 char* to std::string. Thus, the use of strdup becomes useless. (see
2627 previous commis of Malaterre)
2628 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2629 before the last Malaterre's commit.
2631 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2632 * This commit should fix the Debug building under VC++, the problem
2633 was mainly a mixture of debug and release lib being loaded at startup.
2634 * I also remove a depency to a specific C function: strdup. Because I had
2635 to force the link to msvcrtd (whereas strdup is in libc).
2637 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2638 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2639 located in the gdcmCommon.h file. All use of reference of tha has been
2640 changed to now use the variable GDCM_UNFOUND.
2642 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2644 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2645 Dicom dictionary. The test suite can now be run again. Note:
2646 I'm note very happy with the " (RET)" changes. I believe this
2647 RETAINED comment should be dropped when parsing the dictionary.
2648 - PACKAGER corrected
2650 - AUTHORS updated and now in alphabetical order
2651 * Makefile.am now exports gdcm.dsw for Windoze users.
2653 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2654 * cygwin complains about missing std:: in subdir Test/
2656 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * remove some methods that are now in gdcmHeaderHelper
2659 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2660 * vtkGdcmReader set spacing and origin correctly
2662 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2663 * Fix a few delete/delete[] mismatch
2665 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2666 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2667 interpretation to data given by gdcmHeader. For instance there are
2668 heuristics to get informations (look at different places).
2669 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2670 sorting DICOM images based on different strategies.
2671 * modified Makefiles accordingly.
2673 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2674 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2675 when building in debug mode
2676 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2677 src/win32/gdcmdll.dsp
2678 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2680 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2681 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2684 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * src/win32/libgdcmjpeg12.dsp was not dos format
2686 * src/win32/libgdcmjpeg12.dsp :
2687 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2688 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2690 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2691 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2693 * src/gdcmFile.cxx : bug fix in affectation type
2694 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2695 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2696 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2697 symbols... future problem ?
2699 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2700 * src/win32/libgdcmijpeg12.dsp was missing
2701 * modified gdcm.dsw accordingly
2703 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2704 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2706 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2707 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2708 commit of JPR (before his hollidays to facilitate our work).
2709 * setup.py : bug fix in code. Modifications made while the last commit
2710 of JPR. The code hasn't been tested before the commit... it's so
2711 useless to make that (for best programmer that is JPR) !!!
2713 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * tagged the current version as Version0_3 (i.e. version 0.3)
2716 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2717 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2718 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2719 * *.dsp : modifications to use new libgdcmijpeg8 library
2720 * setup.py : bug fix on VTKPATH variable
2721 * PACKAGER : adding all concerning windows
2723 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2726 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2727 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2728 test suite reported error.
2729 * PACKAGER file added (describes what a packager must do when
2730 packaging a new release).
2731 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2732 * configure.in: upgraded version number to 0.3.0
2733 * fixing build of rpm (through rpm -ta):
2734 - Doc/Makefile.am exports proper doxygen files
2735 - src/jpeg/libijg8/Makefile.am exports the include files.
2737 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2739 * src/gdcmHeader.h : formatting code
2741 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2743 We were obtaining error message from vtk. Now, creation of file list
2744 is made in an internal list to prevent this problem.
2745 Bug fix when output is empty.
2746 Bug fix in update of progress value. Previous commit for this was a bad
2748 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2750 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * src/gdcmHeader.h : added method to get the file name
2752 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2753 files. Added method to remove all files on the input
2754 Added FIXME comment concerning the bad parsing of header made by
2755 ExecuteInformation method (in ExecuteData method)
2757 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2758 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2759 when using make instal.
2760 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2761 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2763 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2764 * setup.py : adding include dir of jpeg lib to compile all sources
2765 * */Win32/*.dsp : JPR fix for windows compilation
2767 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2768 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2770 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2771 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2773 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * setup.py is again effective on un*x (takes into account the
2775 addon of the jpeg library)
2776 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2777 * Doc/Doxy* updated (includes above enhancements)
2778 * INSTALL now points to web documentation
2780 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * src/gdcmHeader.h doesn't make unnecessary reference to
2783 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2785 * src/gdcm*.[cxx|h] :
2786 - to allow compilation with gcc 3.x
2787 -- clean up of STL usage (added explicit usage of std::)
2788 -- small fixes on exceptions.
2789 Note: linking not tested !
2790 - clean of doxygen comments to avoid warnings at documentation
2792 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2793 dependent convertion).
2795 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * Clean up of previous JPR garbage commit (not even commented in the
2798 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2799 - moved all jpeg related files from src to src/jpeg/libijg8, with
2800 addition/modification of Makefile.am and configure.in.
2801 - the testSuite is still brain damage (not guilty).
2803 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2804 * WrapVTK.py : modifications to get correctly vtk source files to
2806 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2807 (FileName -> Filename)
2809 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * vtk/vtkGdcmReader.[cxx/h]:
2811 - UpdateProgress method should now be effective
2812 - removed the limitation on having only images loaded (as opposed
2814 - when building a stack of images/volume, a lesser number of
2815 gdcmHeader and gdcmFile instances should be used (hopefully
2816 accelerating things).
2817 - when building a stack of images/volumes, files which are not
2818 loadable (wrong path-filename, wrong permissions on existing file,
2819 or file not parsable by gdcm) are replaced with a black image
2820 in the stack (for the caller to notice the problem).
2822 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2825 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2826 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2827 between standard library (std) and vtk library (problems are found
2828 under Windows... thanks Windows !)
2830 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2831 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2833 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2835 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2838 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * When compiling with distutils (see setup.py) the C++ compiler is
2840 called with different flags than the default ones (with automake).
2841 In order to fix all those warning, I compiled gdcm with the command
2842 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2843 and went for warning fixes:
2844 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2845 up from unused variables.
2846 - vtk/vtkGdcmReader.cxx: potential bug fix.
2847 * src/gdcmHeader.h: Doxygen warning cleanup
2849 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * gdcmPython/gdcm.i:
2851 - typemaps correction to take into account the systematic replacement
2852 of "using namespace std" with std:: prefix e.g. std::list,
2853 std::string... (cf changes of 2003-05-21).
2854 - gdcmGlob global variable of type gdcmGlobal (defined in
2855 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2856 exported to Python a as cvar.
2857 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2858 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2859 gdcmDictSet.GetPubDictTagNames() and
2860 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2861 C++ static methods).
2862 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2863 with the above changes.
2865 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2866 * setup.py, manifest.in : bug fix under linux
2868 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2869 * Modification of setup.py to compile vtk part too. Then, we have 2
2870 wrappers which must work with same distutils. For that, we have a
2871 generic distutils in distusiltsWrapping.py ; with :
2872 - build_extWrap class to wrap generically all extensions,
2873 - ExtensionWrap base class for all wrapping extension that contains
2875 - Wrapper interface which wrap sources
2876 + In WrapSwig.py we have extension and wrapper for Swig
2877 + In WrapVTK.py we have extension and wrapper for VTK
2878 * MANIFEST.in : modifications to consider vtk directory and new python
2879 files for compilation
2881 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2882 * Added python wrappers of vtkGdcmReader vtk class (see the
2883 source in vtk/vtkGdcmReader.cxx) :
2884 - vtk/Makefile.am now builds a library
2885 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2886 python library (as opposed to _gdcm.so wich are the python
2887 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2888 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2890 - configure.in has an additional flag --enable-vtk that needs
2891 to be set to enable compilation of vtk related code, that is:
2892 + vtk/vtkGdcmReader.so and
2893 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2894 + gdcmPython/vtkgdcmPython.so (see above)
2895 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2896 be read when compressed or when HighBit + 1 != BitsStored),
2897 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2898 the usage of the python wrapper of vtkGdcmReader vtk class.
2899 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2900 * src/*.[h] all occurences of stl classes are now prefixed with
2901 std::, and all occurences of "using namespace std;" where removed.
2902 This is to avoid pollution of global namespace in included files.
2903 Apparently vtk does not avoid this pitfall: when using both
2904 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2905 collision of various stl members (principally cout...).
2906 * gdcmPython/testSuite.py now cleanly removes temprory generated
2908 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2909 comply with above changes)
2911 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2912 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2913 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2914 vtk data structure (an image Flip was required).
2915 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2916 * cosmetic changes in documentation.
2918 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2919 * src/gdcmHeader.cxx: the constructor no longer exits when an
2920 unexisting file is given as argument.
2921 * The subdirectory Data (containing all the images used for the
2922 test suite) is not part of this repository anymore. A new module
2923 containing those images is now available at
2924 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2925 with the name gdcmData.
2926 All the python scripts (including the package initialisation file
2927 gdcmPython/__init__.py) were adapated to take this change into
2928 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2930 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2931 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2932 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2933 demo of the usage of this class.
2934 Compilation of this vtk part is only done when using the --enable-vtk
2935 at configure (or autogen.sh) stage.
2937 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2938 * More memory link related corrections and documentation fixes.
2940 - maximum info is obtained with a command of the form:
2941 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2942 --show-reachable=yes PrintHeader
2943 - the remaining reachable blocks seem to come from the STL
2944 allocation scheme through the usage of map and list. It looks
2945 like this memory cannot be freed but it is not a memory leak
2946 (in fact further invocation to the STL would recollect the
2947 unused memory allthough it cannot explicitely be freed).
2948 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2949 of displaying an image parsed with gdcm and displayed with VTK.
2950 Note: some images don't seem to work e.g.
2951 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2952 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2953 Allthough this weakens the semantics, it is a ditch attempt to
2954 make gdcm more thread friendly.
2956 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2957 * Memory link hunt (by using valgrind through the command
2958 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2959 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2960 gdcmHeader::_dicom_vr.
2961 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2962 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2964 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2966 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2967 * src/Makefile.am now exports all the necessary include files at
2971 * UpdateGroupLength replaced by new one
2974 * UpdateGroupLength re-written using H-Table
2975 (named UpdateGroupLengthNew untill checks are over)
2977 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2978 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2979 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2981 - gdcmHeader::GetPubElValSet removed.
2982 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2983 UpdateGroupLength, WriteElements, Write.
2984 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2985 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2986 carried the same semantics.
2987 - src/gdcmHeaderIdo.cxx changed accordingly.
2988 - gdcmFile::WriteBase now regroups all the codes from previous
2989 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2990 - enum FileType moved to gdcmCommon.h
2991 * src/gdcmHeader.cxx AddDefault trashed
2992 * gdcmGetXSize added
2993 * getimageDataSize now calls gdcmGetXSize
2994 * Test/*.cxx changed to agree with above changes
2996 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2998 (to avoid double call by end user).
2999 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3000 by end user, since gdcmHeader::gdcmHeader now handles it.
3002 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3003 * gdcm/Doc many doxygen changes:
3004 - Doxyfile now has two different versions, DoxyfileUsers that generates
3005 the html.users end users oriented documentation and
3006 DoxyfileDeveloppers that generates the html.developper developper
3007 oriented documentation.
3008 - README changed accordingly
3009 - requirement.txt removed (old design info moved to TODO).
3010 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3011 DoxyMainPage.txt, DoxyPython.txt provide more information.
3012 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3013 be updated by simply regenerating the docs with doxygen and copying
3014 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3015 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3016 all the tests in the form "if (<map>.count() >1)" were removed.
3017 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3018 ill-formed documentation sections.
3019 * src/gdcmHeader.cxx: ditto
3021 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * setup.py fixed for un*x (needed macro for stdint.h)
3023 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3024 un*ces with sh-utils test utility.
3025 * gdcmPython/demo/test.py renamed to PrintHeader.py
3026 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3027 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3028 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3029 * src/gdcm*.cxx JPR's bad inclusion fixed.
3031 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3033 * gdcmPython/demo/test.py changed accordingly.
3035 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * gdcmPython/Makefile.am fixed linking against libstdc++
3037 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3038 * Swig subdir (historical tests of swig version 1.3.17++) removed
3039 * Test/testChangeEntete.cxx some lines commented out in order to make
3041 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3042 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3044 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3046 hence the user doesn't need this explicit call.
3047 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3048 i.e. LoadElements() call removed.
3049 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3050 - src/Makefile.am declares the proper flag for g++.
3051 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3052 for adding user defined new tags.
3053 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3054 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3055 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3057 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3058 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3059 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3060 src/Makefile.am : the project should properly compile and install
3061 with the autotools, included the python wrappers part.
3062 * gdcm.spec.in : added a spec file for RPM packaging.
3064 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3065 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3067 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3069 to exported to the environement (see gdcmPython/testSuite.py
3071 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3072 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3073 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3074 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3075 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3077 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * gdcmPython/__init__.py doesn't crash anymore when running in
3079 in InstallMode or PreInstallMode but with an environment given
3080 value of GDCM_DICT_PATH.
3081 * src/gdcmDictSet.[cxx/h] coding style.
3083 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3084 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3085 * src/gdcm.h general comments moved to TODO, and README
3086 * src/gdcm.h should now be seen as a user commodity (including it
3087 should suffice to fully use gdcm). It is nowhere including within
3088 any of the kernel files src/*.cxx and src/*.h.
3090 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3092 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3094 * src/gdcm*.cxx only include their corresponding include file
3095 (as opposed to gdcm.h)
3096 * gdcmPython/gdcm.i changed accordingly
3097 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3098 the autogen.sh generated "make snapshot" command to work.
3099 * autogen.sh removed history related references to crea package.
3101 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3102 * distutilsSwigCPlusPlus.py work around some swig portability
3105 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3106 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3107 was done in a last ditch attempt to get setup.py _really_
3108 operationnal. The python/gdcmPython layaout add the advantage
3109 of hidding away the python related distutils specific files
3110 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3111 Alas, the src directory was out of scope (i.e. it's relative
3112 position to setup.py was ../src) which made things impossible to
3113 handle (see previous version of python/setup.py). Crossing fingers...
3115 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * python/setup.py now works on Un*x. (harder than I thougth)
3117 * python/distutilsSwigCPlusPlus.py can now have include files
3118 among the list of sources.
3120 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3121 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3122 * modifications in MSVC projects
3124 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * As stated by the first lines of Test/ExceptionAndPython/README, it
3126 looks like we can move back to original usage of exception within
3127 src/gdcm* and hence remove the errno stuff that was introduced
3128 as a quick and dirty fixture of this problem (added to the TODO).
3129 * Doc/Doxyfile configuration file for Doxygen and corresponding
3130 README file for usage added.
3131 * Test/testWrite.cxx added. This new test comes from a split of
3132 test.cxx that is now reverted to its original purpous i.e.
3133 testing the proper parsing of a Dicom related file.
3134 testWrite.cxx concentrates on testing the IO part of gdcm.
3135 * Test/bug1.cxx (containing a bug on WIn32) added.
3136 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3137 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3138 whose purpose is to publish the content of the TagNames of the
3139 Dicom public dictionary were not accessible without an
3140 instance of class gdcmHeader.
3141 - those methods are now static methods of gdcmDictSet and hence
3142 require no instances at all to be invocated.
3143 - within gdcmDictSet this change required to change some method
3144 to class methods (i.e. are now static) among which SetDictPath
3145 (renamed to BuildDictPath) and LoadDefaultPubDict.
3146 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3147 the above changes by calling the new method classes of gdcmDictSet.
3148 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3149 the above to be effective.
3150 * python/gdcmPython: in order to wrap properly the above changes
3151 for Python, swig version now needs to be > 1.3.17.
3152 * python/gdcmPython/Makefile fixed to adapt itself to new
3153 configure/make shema introduced by Johan Montagnat (thanks for the
3154 contribution). Alas this Makefile cannot be turned into a proper
3155 Makefile.am without some heavy changes in the configure.in
3156 (for python dectection).
3157 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3158 now avoids publishing the empty entries.
3160 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3161 * python/setup.py : bug fix concerning install under windows
3162 ExtraPath reused :-P
3163 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3165 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3166 * Dicts/dicomV3.dic : remove double spaces !!!
3167 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3168 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3171 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3172 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3173 method. Doxygenation.
3174 * src/gdcm.h clean up of JPR spurious comments.
3176 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3177 * python/distutilsSwigCPlusPlus.py now properly collects the
3178 shadow classes generated by "swig -c++" (gdcm.py in our case)
3179 when using "python setup.py install".
3180 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3181 reexports the working classes.
3182 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3183 by the classical C errno scheme. This is to prevent an obscure
3184 behavior of the python wrappers when importing wxPython.wx prior
3185 to gdcmPython (which ended up in an abort call). An illustration
3186 of this oddity can be found in the Test/ExceptionAndPython
3187 subdir (see the README file). This problem probably due to
3188 an combination of g++ and dynamic loading.
3189 * added Test/ExceptionAndPython (see above)
3191 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3192 * Changed the layout of the python part to avoid bloating main
3193 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3194 i.e. the distutils arsenal. All the python related stuff is
3195 again in a python subdir, but the package itself is now in
3197 * setup.py was cleaned up:
3198 - pythonIncludePath removed
3199 - python setup.py bdist target is now functional.
3200 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3201 collision with other packages). gdcmPython/demo/*.py changed
3204 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * python subdir moved to gdcmPython (preparation of distutils packaging).
3206 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3207 distutils installer is operational.
3208 * - gdcmPython/__init__.py now properly loads the swig generated
3209 shadow classes (from gdcm.py).
3210 - gdcmPython/demo/*.py changed to import the package gdcmPython
3211 instead of gdcmPython/demo/load.py.
3212 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3214 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3215 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3216 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3217 entries within the associated public Dicom dictionary resp. the same
3218 information but sorted by the fourth field (PAT, IMG, DIR) of the
3220 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3221 are now in the "???" group.
3222 - python/gdcm.i changed accordingly,
3223 - python/demo/printGroupedPublicDict.py added, that gives an example
3224 of the above new functionalities in Python.
3226 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3227 * src/gdcm.h, gdcmHeader.cxx:
3228 - historic references to glib's g_malloc and g_free (#defined)
3229 were definitively removed.
3230 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3231 * src/gdcmElValSet.cxx:
3232 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3233 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3234 - GetElValue(string) renamed to GetElValueByName.
3235 - Added GetElementByName(string).
3236 * src/gdcmHeader.cxx: added
3237 - GetPubElValRepByNumber(guint16, guint16)
3238 - GetPubElValRepByName(string)
3239 - GetShaElValRepByNumber(guint16, guint16)
3240 - GetShaElValRepByName(string)
3241 - GetShaElValByNumber(guint16, guint16)
3242 - GetShaElValRepByName(string)
3243 - GetElValRepByNumber(guint16, guint16)
3244 - GetElValRepByName(string)
3245 - GetElValByNumber(guint16, guint16)
3246 - GetElValRepByName(string)
3247 * Doc/requirements.txt added.
3249 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3250 * Test/Makefile building now depends on the one of libgdcm.so
3251 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3252 pixel data) aware which enables finding the address (offset) of
3253 the pixel data of JPEG encoded DICOM files. This leaves only a single
3254 file in the testSuite whose pixel data address (offset) is unknown.
3255 * python/testSuite.py changed accordingly.
3257 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3258 * VC++ has some strong limitations when working with the STL, as stated
3259 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3260 "Also note that some STL containers (map, set, queue, list, deque)
3261 cannot be exported. [...]
3262 Some STL classes contain nested classes. These classes can not
3264 This is caused by a designed limitation that once a template
3265 class is instantiated, it can not be re-instantiated and
3267 Since our usage of map<> is ubiquitous in gdcm, this "designed
3268 limitation" of VC++ is a pitfall.
3269 Hence the Python wrappers of gdcm cannot be incrementally linked
3270 against the c++ dynamic library. The dirty but only workaround is
3271 to forget about incremental link of dynamic libraries and to generate
3272 the Python wrappers library with the inclusions of the underlying C++
3274 The following modifications concern this matter on Win32/VC++:
3275 - wrapping python correct with standalone wrapped dll (don't use separate
3276 dll under windows !!!!)
3277 - python21_d debug mode enabled (ask Frog how to use it :-)
3278 - NO problem with having an STL member of class for example string in C++
3279 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3280 - Python test of dcmlib in Python is ok under windows on a large set
3282 * removed glib references
3283 * typedef's inserted in gdcm.i for correct swig type management
3285 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * python/demo/*.py load.py extracted from test.py. Added explore.py
3287 that only displays required tags and testAll.py that parses all
3288 the files of the testsuite without using unittest.
3289 * python/testSuite.py other additional test on new files added.
3290 * Data/* new test files added accordingly to the testSuite.
3291 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3292 the vr in the file differs from the one of the dictionary.
3294 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3295 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3296 values, but limits itself to values which are below a user specified
3297 size (by default 1024 bytes).
3298 * python/gdcm.i : elements not loaded (because their size is above the
3299 user specified treshold) are exported with their TagKey as key of the
3300 python dictionary. This enables the testsuite to make some checks
3301 on the unloaded elements (since we have their offset and size).
3302 * python/testSuite.py
3303 - now tests for the existence and proper value of the pixel data
3304 - two new examples added.
3305 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3307 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3309 aware. See the strategy comments in gdcmHeader::FindLength().
3310 * Test/test.cxx now accepts a filename as first argument.
3311 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3312 * python/testSuite.py changed to integrate test on above files.
3314 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3316 the vr was also RET.
3317 * python/testSuite.py more tests added.
3319 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3320 * python/testSuite.py unittest test suite added (uses Data)
3321 * Data/* dcm and acr files for the test suite.
3322 * glib dependance removed from un*x version. We now use ISO C99
3323 7.18 Integer types (see stdint.h)
3324 - python/Makefile, src/Makefile src/gdcm.h
3325 * src/ when an explicit vr (like dicom files) suddenly poped an
3326 implicit element we use to mark the underlying DictEntry of the
3327 concerned ElValue with "Implicit". This strategy was damageable
3328 too the public or provite dictionaries, since some of their vr
3329 would be changed. Since Header::FindLength heavily relies on the
3330 detection by Header::FindVR of falsely explicit elements, I
3331 added an extra ImplicitVr member to ElValue (boolean).
3332 The rest of the changes we the necessary adaptations.
3334 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3335 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3337 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3339 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3340 * Adaptation for porting to VC++:
3342 o forced to use std namespace (for string to be known)
3343 o all class use __declspec export style on WIN32
3344 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3345 (in stdlib.h on Win32 but in std:: for gcc)
3346 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3347 variable GDCM_DICT_PATH.
3348 * src/gdcmHeader.cxx verbose comments made discrete.
3350 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3351 * python/gdcm.i: added a typemap that converts a C++ hashing table
3352 to native Python dictionary.
3353 * python/demo/test.py:
3354 - now uses the native dictionary for exploration of gdcmHeader.
3355 - takes an optional filename argument (the file to parse).
3356 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3357 PubElVals hashing table.
3358 * Dicts/dicomV3.dic removed error prone trailing spaces.
3360 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3361 * Python wrapping process moved away from src/Makefile to
3362 newly created python/Makefile (as well as gdcm.i)
3363 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3364 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3365 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3366 from the environement variable GDCM_DICT_PATH (when existing).
3367 * src/gdcmDict::GetTag bug fix.
3369 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3370 * Straightforward temporary fixes for swig to build the python wrappers.
3371 src/Makefile now has a python working entry [by working we mean
3372 that we can import the shadow classes without errors].
3374 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * hashtest.cxx removed (since already in Test)
3376 * src/gdcmlib.h renamed to src/gdcm.h
3377 * src/dcm.i renamed to src/gdcm.i
3378 * src/Makefile prepared for python wrapping
3380 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3381 * src/gdcmHeader.cxx :
3382 - Parsing of header is now separated from loading of element values
3383 (see gdcmHeader::LoadElements).
3384 - general clean up of hopefully all file access (creation of
3385 ReadInt16 and ReadInt32)
3387 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3388 * src/gdcmHeader.cxx :
3389 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3391 - SetLgrElem renamed to SetLength
3392 - GetLgrElem renamed to GetLength
3393 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3394 * src/gdcmElValSet.cxx fixed both GetElValue methods
3395 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3396 due to IdoDude was cleaned out.
3398 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3399 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3400 concentrates on finding the value representation (when it exists).
3401 RecupLgr now only finds the element value length, and it avoids
3402 returning the unecessary skL (skipped length).
3403 Also, offsetCourant was simply removed (with taille_fich) since
3404 it was redundant with the File position internals (by using
3405 ftell and fseek). This also made skL (see above in RecupLgr) usage
3407 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3408 on the libido specificities which are handled through class
3410 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3413 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3414 * Truckload of changes. Parsing of header is barely functional
3415 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3417 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3418 * src/gdcmHeader.cxx many addons of low level methods
3420 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3421 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3422 and _IdDcmSWAP_LONG.
3424 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3425 * This corresponds to all the changes decided at the meeting of
3426 May 23 2002. Needless to say we are running late...