1 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
5 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
9 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * Test/ : rename VTK tests to have a best name for the tests
11 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
12 GetFirstEntry/GetNextEntry use
14 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
16 test. Now it's on image content and not on the resulting visualisation...
17 might solve the problem on linux when using the OpenGL drivers
19 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
20 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
21 DicomDirSerie, DicomDirImage
22 Dict, DictSet classes :
23 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
24 -remove InitTraversal method.
25 * UPD Test programs + Example programs
27 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
28 remove useless and never updated keyword \ingroup
30 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
32 is no memory access violation
33 * gdcmPython/demo : add python demos using VTK
35 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
36 * FIX 'Dictionnary' is now spelt 'Dictionary'
37 'wether' is now spelt 'whether'
38 'archieve' is now spelt 'archive' ;-)
40 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
41 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
42 related methods, in order not to expose internal mechanisms
45 * REM methods that exposed internal mechanisms :
46 DicomDir::GetDicomDirPatients()
47 DicomDirPatient::GetDicomDirStudies()
48 DicomDirStudy::GetDicomDirSeries()
49 DicomDirSerie::GetDicomDirImages()
60 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Removed the Print/indent/default parameter mess. There is absolutely no
62 reason to have to methods, moreover with the second taking the ostream as
63 *SECOND* parameter. This was clearly a bad hack to get things compile.
65 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * Complete rewrite of the GetMacAddress code. Now the code is *much*
67 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
68 Unfortunately the main code does not work on SunOS, thus provide a specific
69 code for this platform only (and Win32 of course). Since this seems to be
70 working, change CreateUniqueUID to use GetMACAddress instead of the
71 problematic GctestetIPAddress
73 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
74 * Unfortunately to be able to test gdcmDirList I had to break the API
75 a little. Now the class is not a std::list anymore but has a member
76 std::vector (more ITK compatible). Allow unit testing on Win32 and
79 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 * Update SerieHeader to take into account a Serie Instance UID to properly
83 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
84 * ENH - Comment out Mathieu's (dangerous) Super Hack
85 for dealing with BIGENDIAN processors
86 - Move equivalent stuff to BinEntry::WriteContent
87 When necessary, 16 Bits Pixels are swapped in a small buffer
88 and then written. This avoid allocating a huge buffer, in
89 PixelWriteConvertor, and avoid modifying the Pixel Area.
91 Probabely, the same operation will have to be done when we want
92 to write image with Big Endian Transfert Syntax,
93 and we are working on Little Endian Processor
95 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
98 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
99 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
100 all the dict content.
101 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
103 * Test/TestDict.cxx : add a new test for the dict classes
105 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
106 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
107 file. Debug is yanked if compiled with NDEBUG
109 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmDictSet.h : set the default output to the os variable
111 * src/gdcmDictEntry.[h|cxx] : add the Print method
112 * gdcmPython/demo/ : add a new test
114 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
115 * merging of Test/PrintDicomDir and Test/TestDicomDir
116 * removal of now redundant Test/PrintDicomDir
117 * enhancement of Example/PrintDicomDir
119 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * Now, python test might work on systems
121 * Add the PrintDicomDir test
123 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
124 * FIX : First entry following group 0002 was lost for
125 Explicit Big Endian Transfer Syntax files
126 (group and elem not swaped)
128 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
129 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
130 Big Endian Transfer Syntax supposed the group following 0002
131 begins always by element 0000 (element 0000 is *optional*)
132 To avoid further troubles, let's be pessimistic, and use
133 Document::HandleOutOfGroup0002() method
134 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
135 (related pb not yet solved)
137 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * Bug fix for the python part use
139 * Now, PrintHeader.py pass... but outside the ctest use. shit !
141 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
144 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
145 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
146 a string and should ask the global TS dict what are the propreties of
149 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
150 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
151 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
152 to swap the Swap Code, at parsing time, when we come out of group 0002
153 and Transfer Syntax is Big Endian
154 We should be able to read now 'true DICOM" Big Endian coded images
155 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
156 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
158 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 * Hopefully fix the bug on MacOSX and static global initialization.
160 This is the only -minor- patch I found that both please MacOSX and VS6.
161 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
162 but this would require a lot of change. Another approach would be that Global
163 create those string and GDCM_UNFOUND becomes a pointer to a string (which
164 gdcm::Global would destroy at exit).
166 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Fix bug on MacOSX with static initialization in a multy threaded
168 environment. static const string in a header file used to be ill
169 initialized provoquing the freeze of any tests. patch should solve this
172 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
173 * According to Benoit's suggestion, and without any objection from anybody
174 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
175 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
176 - method gdcmDicomDirObject::GetEntry() renamed as
177 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
179 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
180 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
181 you debug/warning message just as c++ streams which make them very convinient
182 to use. Once this is stabilize I will change the ostringstrem to be
183 redirected to a file (ofstream).
184 * Properly support C99 extension: __FUNCTION__ which allow us to display
185 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
187 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
188 * Removal of useless and dangerous methods :
189 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
190 GetDocEntryByName, GetEntryByName, GetDictEntryByName
191 * Removal of usless methods :
192 Dict::PrintByName, Dict::GetDictEntryByName
193 * Commenting out of probabely useless methods :
194 Dict::GetDictEntryNames()
195 Dict::GetDictEntryNamesByCategory()
196 DictSet::GetPubDictEntryNames()
197 DictSet::GetPubDictEntryNamesByCategory()
198 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
199 * ENH : Use dicomTS.dic as described in 2004 version
200 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
201 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
202 Add Accessors on VM (Value Multiplicity), and VM related methods
203 * ADD : Add a list of 'Dicom Attribute types', as found in
204 http://medical.nema.org/dicom/2004/04_15PU.PDF
206 * ADD : Add dicomGroupNameAbbreviations.dic
207 should be used to write a method to replace the former
208 Dict::GetDictEntryNamesByCategory()
210 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
212 to read in the file... and only it ! Length is the efective length of the
213 data in the DocEntry structure
215 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
217 And now use a static function call instead, with a global variable. i
218 This is much closer to the VTK approach. Hopefully should be bulletproof
219 and easier to use...hopefully
221 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
222 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
224 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
227 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
229 ValEntry, BinEntry, SeqEntry creation or replace
231 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
233 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
235 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
236 when specifying the VR
237 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
238 * src/gdcmDocEntry.cxx : amelioration of print
240 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
241 * ADD : Add the method Util::IsCurrentProcessorBigEndian
242 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
243 * ADD Method Document::ComputeGroupLength
244 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
245 in order to allow further VR modification by user
246 * REM : removal of once-called method File::WriteBase
247 integration of its code in formerly one-line method File::Write
249 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
251 replace the different values "??", "Unkn", "Unknown".
252 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
253 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
254 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
255 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
257 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
260 * Set the gdcm::Base class to some Printable classes
262 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmFile.[h|cxx] : add the Print method
264 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
265 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
266 * src/gdcmDocument.h : remove the PrintLevel informations
267 * Example/PrintFile.cxx : use the new gdcm::File::Print
269 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
271 problems when compiling with the python wrapping
273 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
275 writting in ImplicitVR
277 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
278 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
279 JPEG decompression, especially when dicom frames are split into several
280 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
281 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
283 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmHeader.cxx : change the initialisation of default header.
285 Now, this header is readable by gdm, e-film, DicomWorks
287 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
289 Rename Decompressed to Raw
290 * Use the API changes in gdcm::File.
291 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
294 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
296 each added entry in the header. Replace the 'Planes' field by the 'Number
299 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
301 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
303 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
305 At this time, this image isn't readable by e-film... waiting JPR help to
308 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
310 DocEntry. Now use methods of the Document !
312 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * Test/ShowDicomSeq.cxx : bug fix
315 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
317 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
318 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
319 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
321 * Test/TestCopyRescaleDicom.cxx : remove unused variable
322 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
323 containing found sequences
325 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
328 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
329 Some fields in BinEntry must be copied to not seg fault when making the :
330 gdcm::File *copy = new gdcm::File( copyH );
331 and tests are now made on good variables
333 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
335 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
337 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
338 * Add vtkGdcmWriter example and test
340 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * Test/TestUtil.cxx : reformat the source code
342 * vtk/vtkGdcmReader.cxx : remove and change prints
343 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
345 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
346 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
348 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
350 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
352 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
354 by an eof to prevent all bad read of the file... and in this case, the
357 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * Example/Volume2Dicom.cxx : comment unused variables
359 * Test/PrintDicomDir.cxx : comment unused variables
360 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
361 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
362 method that is redondant with AddEntry.
363 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
366 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * Bug fix due my last commit (compilation under Windows).
368 * Example/Volume2Dicom : bug fix in the file and reformatting source code
369 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
371 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 - Remove printf / sprintf
374 - include iostream AFTER gdcm so we don't get warnings
375 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
377 - Also remove tons of include from header files, hopefully this should
378 speeup the compilation time, since it was becoming a dog slow.
379 - Remove gdcm.h as it include way too many files and slow down compilation
380 (plus it is not up to date)
381 - remove 'using namespace std' this is BAD !
383 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * Remove memory leaks on the DicomDir
385 * Remove some useless data in DicomDirObject
386 * Add usefull methods in SQItem, to be complient withe the ElementSet
388 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
391 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
393 future, with convertion)
394 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
395 and ImageDataSize values. Remove the method to get the PixelReadConverter
396 from the output of the class
398 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
401 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
403 and vtkErrorMacro use.
404 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
406 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
409 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
410 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
411 The string leaves only in the fonction. So when we make a .c_str(), we
412 get the pointeur on the first element, element that will be destroyed
413 immediately after thee instruction.
414 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
415 file has been opened : the test must be made on the content of the
416 pointer and not directly on the pointer !
419 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
421 the python part recompiles
423 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
425 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
426 X session is killed (for my computer... it seems to not be identic on
429 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
431 avoid problems (otherwise, the difference test between the visible image
432 and the reference is incorrect. If the reference is greater than the
433 screen resolution, it's produce errors).
434 Can be used for only one image. Can be used with a visible flag.
435 * vtk/vtkGdcmReader.cxx : remove commented codes.
436 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
437 under windows at compilation
438 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
440 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
442 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
444 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
445 tests on the image size X, Y, Z
447 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
449 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
450 between the class name and the file name
452 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * src/ : fix compilation warnings for the Write method (2 different
454 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
455 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
456 variable... create a static method in gdcm::Document to access to
457 this variable content.
459 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
461 file, to be accessed by other files (like gdcmFile). Remove commented
462 code. Move the change of the header to the gdcmFile, using the
464 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
465 To be sure of that (and simplify calls), the Write of the header now
466 gets a file name and not a file pointer (std::ifstream).
467 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
468 DocEntryArchive. Remove all open of the written file
470 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
473 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
475 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
477 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
478 some corresponding methods. Write correctly the file and check before
480 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
481 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
482 is now on RGB data (as before my last commit
483 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
485 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
487 Add a print information of the type of the entry
488 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
489 It was in the gdcmFile, and all write have been regrouped
490 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
491 Write correctly all dicom files (in decompressed mode only at this time)
492 * Test/ : test on files are now made using Raw data and not color data if
494 * Example/PrintFile.cxx : add more printings
496 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * Amelioration of code, remove some code copy. For the loading of
498 BinEntry (in gdcmDocument), add the test to verify if the file is already
501 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
503 remove a DocEntry in the header (push an empty DocEntry)
504 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
505 lines. Bug fix in the initialization of the PixelConvert and the
507 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
508 use in TestCopyDicom (now this test can run under windows... but fails)
509 * Test/TestCopyDicom.cxx : amelioration of the test :
510 - test the pixels written
511 - add test points to quickly find where is the error
512 - can set a file name input and output in arguments
513 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
514 amelioration of the test output
516 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
518 all replaced DocEntry's
519 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
520 Now, each needed DocEntry to modify is duplicated, modified and inserted
521 to the header using DocEntryArchive. Thus, after save, we can restore the
522 header initial state.
524 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
527 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
529 correct to copy it. The DictEntry is specified at the DocEntry creation,
530 then, it musn't change in the time.
531 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
532 header correctly. At this time, the change is only made for the first
533 level of the Document. In the future, it might consider sequences.
534 The change is made by replacing a DocEntry by an other that is created
535 outside the class. The old value is kept. When we restore the header
536 status, the added DocEntry is deleted and replaced by the old value.
537 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
538 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
539 set the write type to explicit VR, implicit VR or ACR. Add methods to set
540 the write mode to native, decompressed or RGB (but not used at this time)
542 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
544 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
546 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
548 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
550 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
551 set because already copied when copying the BinEntry's of the header
552 * Test/TestAllReadCompareDicom.cxx : remove warnings
554 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
556 Two problems appear when doing it :
557 - with the gdcmFile : when the GetImageData method is called, the pixels
558 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
559 data (pixels). And each structure destruct the data when it's
560 destructed. So we have two destructions for the same data. To solve it,
561 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
562 data or not. If it doesn't own data, then they will not destroyed by
564 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
565 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
566 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
567 create a double destruction of the same DocEntry's. So, to solve it,
568 the TagHT is simply cleared and the DicomDir* elements are destroyed.
569 * TODO : add an entry concerning memory leaks in the DicomDir
571 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
573 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
576 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
578 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
579 after it have been deleted
581 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * FIX: src/* fix the doxygen warnings.
583 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
584 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
585 was erroneously defined with a size of 15 instead of 16. [many thanks
586 to Jean Michel Rouet for pointing out this bug].
588 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
589 1. Finish merging JMR patch for writting DICOM from scratch
590 2. Fix -hopefully- bug with MONOCHROME and space vs null character
591 3. Use const ref when possible
592 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
593 5. A few more comments
594 6. CreateUniqueUID can now be called without parameter"
596 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
597 * ENH: Slightly bigger patch:
598 1. Getting toward full integration of JMR patch for writting dicom from scratch
599 2. Update Test to test part of this patch: CreateUniqueUID
600 3. File was not close properly in gdcmDict
601 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
602 5. Use of const ref instead of copy (speed issue)
603 6. Remove temporary (duplicate) string in TranslateToKey
604 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
605 8. Do not repeat virtual in subclasses
606 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
608 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
609 * Apply first patch toward better string comparison when dealing with broken
610 DICOM files. Essentially the string could be padded with a space instead
611 of a null character as defined by standard
613 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
615 because never used... and in the same time, that's remove some memory leaks
617 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * src/gdcmFile.cxx : now delete the PixelConvert instance.
619 * In examples and tests : change the type of image data variables from void*
620 to uint8_t*. Remmove all delete on image data variables
622 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
624 Verify the file pointer value before open the file, and if it's not null,
625 a verbose message is generated.
626 Close correctly the file when the file isn't considered dicom-like. The
627 correctly close is a call to CloseFile.
628 When closing the file pointer, test if its not null to close the file.
629 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
630 file. For an uncompressed image, the copied data correspond in the least
631 case to the image size (calculated) or the image size specified in the
632 header. A verbose is generated if these two size mismatch
634 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
636 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
637 break under windows (with msvc6 compilation).
639 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
641 compiling with MSVC6)
643 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * Bugs fix for the Windows build with VC6
645 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
646 needed (only for projects required VTK). If the VTK is included in all
647 projects, there is conflicts with the jpeg lib of vtk when compiling the
648 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
649 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
650 when compiling the gdcm_wrap.cxx file (created by the compilation of the
652 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
653 (like it's already made for the cout use). Otherwise, conflict with the
656 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
659 - comments on the DicomDir::Method related usage added.
660 - now that we use the namespace gdcm, a lot of internal classes do
661 NOT need to be wrapped anymore.
662 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
663 DicomDir::Method) new example added.
665 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
666 * Improve string manipulation. I now inforce the notion of 'DicomString'
667 A DicomString can contain as many \0 as they want
668 and it is *always* of even length.
669 We only support odd length for very rare case.
670 And in the near future this should be removed.
672 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
673 * /binary_write/ gdcm source. Now even on big endian we are writting
674 little endian. This should -heopfully- fix some tests
676 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
677 * Now the dictionary is compiled into gdcm lib. This is a default
678 behavior, thus any dic file specified is picked before failback to
679 the one comiled into lib
681 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * Change internals for gdcmDict. Don't use any 'new' any more.
683 This should definitely solve any leak problem, and we should be
684 as fast as before, as long as don't modify too much the dictionary.
686 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
687 * STYLE: ivars should start with a capital letter.
688 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
689 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
691 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
693 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
694 new 2004 dictionaries added (thanks to JPR).
695 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
696 * CLEANUP_ROUND (15) for gdcmPixelConvert
697 - RLEFrame::NumberFragments is now of type unsigned int
698 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
699 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
702 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
703 * Initial work in gathering all transfer syntax accessors. clearly
704 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
705 ivars, but only one transfersyntax (class) ivar with equivalent method on
708 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
709 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
710 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
711 discussed (plus I didn't like having a 2000 lines patch not commited)
713 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
715 * CLEANUP_ROUND (14) for gdcmPixelConvert
716 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
717 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
718 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
720 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
721 anymore and hence avoids storing a copy of PixelConvert::Decompressed
722 into File::Pixel_Data.
724 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
726 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
727 * CLEANUP_ROUND (13) for gdcmPixelConvert
728 Substituted File::ParsePixelData() with PixelConvert::Print() new
730 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
731 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
732 method to those classes.
733 - src/gdcmFile.[cxx|h]:
734 -- Added a ::Print() method.
735 -- PixelConverter is now a reference instead of a member.
736 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
737 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
739 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
741 collaboration diagram and inheritance diagram should be generated with
743 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
744 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
745 pointlessly wrapped (see
746 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
747 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
748 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
749 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
750 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
751 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
752 -- File::Initialise: PixelConverter setup moved away to
753 PixelConverter::GrabInformationsFromHeader()
754 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
755 interpretation moved away to PixelConverter::BuildRGBImage()
757 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
758 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
759 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
761 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
763 displayed on Win32 when a brutal abort() occurs (because of uncatched
764 exception). See TODO new entry of this commit for more on this.
765 * TODO added new entry.
766 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
767 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
768 - HandleColor is no longer called from gdcmFile.cxx
769 - gdcmPixelConvert.cxx clean up on method arguments and internal
770 variable names for semantical coherence.
772 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
773 * Finished lossless transition, not only do we now read all lossless jpeg
774 images, without the need of the Cornwell lib, but we do read them properly now
775 * To reduce code (well to avoid code duplication), I defined a common place
776 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
777 redefine symbols. This is not perfect but this the best solution I found for a
778 compilation time jpeg option.
780 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
781 * Update jpeg ijg lib to support lossless jpeg implementation
782 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
784 * Also added a special copyright for dcmtk since we use their bugfixes.
787 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
788 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
789 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
790 matters, as stated in warning note at begining of %include section).
791 * src/gdcmDicomDir*.[cxx|h]: coding style
792 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
793 * src/gdcmJpeg8.cxx: doxygen fix.
794 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
795 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
796 from File:: to PixelConvert::.
798 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
800 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
801 - more code moved away from File:: to PixelConvert::
802 - fat setup of PixelConverter set in place in File::Initialise.
804 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
805 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
806 namespace at the file system level. So now you should convert your examples
808 gdcmHeader -> gdcm::Header
809 It would be nice if people keep in mind to no open the namespace, since it
810 allows compilation on broken plateform which were defining common symbol in
811 the standart namespace (like LP, Unknown ...)
813 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
815 The JPEG fragments are now parsed at the same stage than the RLE
816 information. All code related to JPEG is now in gdcmPixelConvert:
817 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
818 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
819 export a gdcmFile:: method. Those are simply global functions
820 (for the time being this is better than having them attach to
821 either gdcmFile:: or gdcmPixelConvert::).
822 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
823 and stores the result in a gdcmJPEGFragmentsInfo.
824 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
825 code (among other stuff) moved away from gdcmFile:; to
828 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
829 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
830 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
831 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
832 clean up of RLE related code.
833 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
834 - src/gdcmRLE.cxx removed
835 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
836 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
837 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
838 * CLEANUP_ROUND (9) for gdcmPixelConvert
839 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
840 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
841 away from gdcmFile:: to gdcmPixelConvert::.
843 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
845 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
846 This is because Parse7Fe0 used to parse the pixels to compute the
847 length. This task was passed over to FindDocEntryLengthOB() a long
848 time ago, EXCEPT I had forgotten the OW case...
849 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
850 we just recylce the code for parsing RLE fragments and computing
852 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
853 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
854 with the retired Parse7Fe0().
855 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
856 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
858 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
860 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
861 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
862 - src/CMakeLists.txt: alphabetic order reodering + new entries.
863 * CLEANUP_ROUND (4) for gdcmPixelConvert
864 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
865 to return an unused length.
867 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
868 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
869 this should be cleanner from the plane view. The iostream are erally a pain
870 to use to do simple stuff.
872 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
873 * Redo the compilation of the ijg jpeg library. Now only one source is
874 necesseray. No need to rename file by hand what so ever. CMake handle the
875 copying of the file within different directory, configure header file to
876 modify some symbol. The only addition made to ijg wasd a mangle table so
877 that symbol are different whether we are within 8bits or 12bits.
879 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * Added documentation of vtkgdcmReader on Website:
881 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
882 with it's binary name).
883 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
884 the Website to be more complete.
885 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
886 doxygenated documentation.
887 - Doc/DoxyVtkGdcmReaderExamples.txt added
888 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
889 DoxyVtkGdmReaderExamples.html )
890 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
891 * CLEANUP_ROUND (3) for gdcmPixelConvert
892 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
894 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * CLEANUP_ROUND (2) for gdcmPixelConvert
896 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
898 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
899 * CLEANUP_ROUND for gdcmPixelConvert:
900 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
901 - src/gdcmPixelStuff[h|cxx] removed
902 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
903 - src/CMakeLists.txt changed accordingly
905 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
906 gdcmVersion.py moved to newly created ATTIC related
907 gdcmPython/SetupOldies/ directory.
908 * Autotools clean up:
909 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
910 - autogen.sh configure.in acinclude.m4 python.m4 removed
912 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * src/*.cxx *.h Reference to License.htm fixed to License.html.
914 * Doc/CMakeLists.txt, doxygen.config.in: fix.
915 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
917 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * TODO updated with Mathieu suggestions. I proposed a template for
919 describing TODO entries and used it for new entries.
920 * Added Doc/Website/CodingStyle.html, Developpers.html,
921 DeveloppersPython.html, GdcmDataCvs.html and
922 DownloadVersion0_1.html, DownloadVersion0_3.html.
923 * Some Doc/*.txt Doxygen files (which do not really concern the
924 documentation itself, but the website) moved to html and
925 placed in directory Doc/Website:
926 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
927 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
928 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
929 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
930 * CMakeLists.txt changed accordingly.
931 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
932 DeveloppersPython.html
933 * INSTALL nows refers to Doc/Website/Installation.html
935 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * Added Doc/Website directory, that contains a first raw version
939 2004-09-23 Jean-Pierre Roux
940 * FIX In order not to be poluted any longer by casting problems,
941 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
942 we can now delete[] it safely
943 * VoidArea is now called BinArea (less confusing name),
944 and all the methods called ...VoidArea... are now ... BinArea...
945 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
947 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
949 clear) TagHT, which is an inherited member of gdcmElementSet. It is
950 up to the destructor of gdcmElementSet to clean up TagHt and it's
953 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * Test/CMakeLists.txt: update to follow gdcmData renamings.
955 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
957 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * ENH: added some utility method that builds a flat dictionary
959 holding all the Dicom entries contained in the recursive structure
960 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
962 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
963 BuildFlatHashTable() that build a flat dictionary.
964 - src/gdcmElementSet.h: added a new private GetTag() accessor.
965 gdcmDocument is now a friend of gdcmElementSet.
966 - src/gdcmElementSet.cxx: clean up.
967 - Example/FlatHashTablePrint.cxx added.
968 - Example/CmakeLists.txt changed accordingly
970 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
971 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
972 moved away from gdcmDocEntrySet (since this class is an abstract class
973 acting like an interface). SQDepthLevel and BaseTagKey are now
975 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
976 and associated accessors. Doxygenation of the class.
977 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
979 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
980 Use SQDepthLevel accessor instead. ::Print() adapted.
981 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
982 - src/gdcmDocument.cxx changed accordingly.
984 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
986 - The following is the doxygen comment of the typedef declaration
987 of gdcmTagKey in src/gdcmCommon.h:
988 gdcmTagKey is made to old an "universal" (as in URL, Universal
989 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
990 A dicom tag always has a group and an element, but a set of tags
991 embeded in various (optionally nested) sequences and sharing
992 the same group and element all share the same (group, element)
993 "identifier". Hence the (group, element) cannot be used as an
994 identifier (in gdcm we shall refer to a "TagKey") of a tag.
995 In order to construct a proper tag identifier (i.e. a key) we
996 consider the following definition of a TagKey:
997 - let Group, Element be the string representation of the
998 group and element dicom tag members,
999 - let ItemNumber be the string representation of the integer
1000 index of the considered item number of a sequence,
1001 Let the key of a tag embeded in a sequence, noted SeqTag, be
1003 /ItemNumber#Group|Element
1004 where "/", "#" and "|" are characters acting as separators.
1005 Then the general form of a gdcmTagKey is given by:
1006 Group|Element<SeqTag>
1007 where <SeqTag> means NO or many instances of SeqTag.
1008 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1011 but the gdcmTagKey of a tag "embeded" is the first item of
1012 a sequence, itself nested in the third item of a sequence is the
1014 0004|1220/2#0008|0082/0#0008|0090
1015 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1016 order to hold the new sequence compatible key. Previously, the
1017 GetKey() method would look in the underlying gdcmDictEntry.
1018 - src/gdcmDocEntry.cxx:
1019 -- constructor now copies the underlying DictEntry key, in the local
1021 -- ::Print: displays the member Key, instead of the (group, element).
1022 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1023 - src/gdcmDocEntrySet.h:xi
1024 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1025 -- now has a new BaseTagKey member.
1027 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1028 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1030 This poses the problem with the semantics of the following lines
1031 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1032 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1033 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1034 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1035 to the long FIXME note for what the problem is. Nevertheless in
1036 order to get things working the dicom dictionary was altered !
1037 Please fix things urgently...
1038 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1039 information), see above note on moving the member VoidArea. Nevertheless
1040 the following entries previously correctly set as US are now inproperly
1042 0028 1201 OW IMG Red Palette Color Lookup Table Data
1043 0028 1202 OW IMG Green Palette Color Lookup Table Data
1044 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1045 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1046 of gdcmDocEntry moved to gdcmSeqEntry.
1047 * src/gdcmSeqEntry.cxx: STYLE.
1049 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1052 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * gdcmPython/testSuite.py: all the test suite in python is now moved
1054 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1055 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1056 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1058 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1060 to avoid inclusion recursion until STL is reached.
1061 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1062 mecanism. errno.h is not included in gdcm anymore.
1063 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1064 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1066 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1067 gdcmData/TestAllEntryVerifyReference.txt
1068 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1069 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1070 exception_on_error parameter.
1071 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1072 - vtk/vtkGdcmReader.cxx changed accordingly,
1073 - Example/*.cxx and Test/*.cxx changed accordingly.
1075 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1077 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1078 enable_sequences removed from gdcmHeader constructor and dependencies.
1079 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1080 * gdcmPython/demo/PrintHeader.py: dummy fix.
1081 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1082 skip_shadow removed from gdcmHeader constructor and dependencies.
1083 * Example/*.cxx and Test/*.cxx changed accordingly.
1085 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1087 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1089 2004-07-21 Jean-Pierre Roux
1090 * FIX Now, Parsing and Printing a DICOMDIR do work!
1091 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1093 2004-07-20 Jean-Pierre Roux
1094 * FIX Some brain damaged headers have Zero-Lenght fields
1095 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1097 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1098 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1099 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1100 variable (instance of gdcmDebug) by a definition macro, and the instance
1101 is now in static in the gdcmDebug class
1102 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1103 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1105 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * WARNING: ctest now depends more tightly on gdcmData. You should
1107 check out gdcmData properly for things to run smoothly...
1108 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1109 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1110 we need the pixels not be loaded in order to use the ValEntry
1111 that displays position and size).
1112 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1113 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1114 be deprecated. If you have any doubts about the advantages of a
1115 modern scripting language (read Python) versus grass root C++ (i.e.
1116 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1117 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1118 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1119 Anyhow, consider documenting the gdcmData images in
1120 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1122 * Test/CMakeLists.txt:
1123 - now uses TestAllEntryVerify.cxx
1124 - specific comments on oldACR00001.ima (now renamed in gdcmData
1125 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1126 gdcmData/TestAllEntryVerifyReference.txt
1129 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * src/*.[h|cxx] : typedef clean up
1131 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1132 - TagKey renamed to gdcmTagKey (for external usage)
1133 - VRKey renamed to gdcmVRKey (for external usage)
1134 - removal of typedef duplication.
1135 - Removed all unecessary inline keyword from class inline definitions.
1136 - Some method|function(void) declarations replaced with method|function().
1137 * src/jpeg/libijg12/jdhuff12.c:
1138 - printf polluting ctest removed.
1139 - TAB removal for comminting
1141 - TestAllReadCompareDicom.cxx: added a test that compares all the
1142 images in gdcmDataImages.h with corresponding images in
1143 gdcmData/BaselineDicom/. When baseline images are not present
1144 this test creates them.
1145 Note: we need to validate each reference image, but before that
1146 I'd like to rename them with a more explicit name...
1147 - CMakeLists.txt: changed accordingly.
1148 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1149 including each header needed).
1151 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1153 test suite to the Example directory. Are concerned:
1158 - TestWriteSimple.cxx
1159 * Test/CMakeLists.txt: added some comments on reasons for black listing
1160 image gdcmData/oldACR00001.ima
1162 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * Test/CmakeList.txt: removed the following from black list (to be coherent
1164 with removal from gdcmData):
1165 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1166 - gdcm-MR-PHILIPS-16.dcm
1168 Added the following because after last cvs update, they cause
1169 ctest -R TestReadWriteReadCompare
1171 - gdcm-MR-SIEMENS-16-1.acr
1173 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1174 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1175 new comments in this file) we temporarily (sigh) move to a weaker
1177 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1178 we don't need to black list the following images anymore:
1179 - 8BitsUncompressedColor.dcm
1181 - US-PAL-8-10x-echo.dcm
1182 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1183 fixes and the beautified code ;-)
1184 This fixes the bug introduced in version 1.42 (when beautifying)
1185 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1186 Note: ctest was blind to this bug (this means we need to still
1187 improve the test suite). The bug could be detected by using
1188 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1190 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1191 and by displaying the (garbage) produced file temp.XDCM...
1193 2004-06-29 Jean-Pierre Roux
1194 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1195 - replace by uggly but working old code :-(
1196 A lot of things should be OK again.
1197 It's really urgent to have a test suite that *tests*,
1198 to prevent Frog's beautifying sessions to break all the stuff
1199 (twice, withing a fortnigh ...)
1201 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1202 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1203 redundancy) to added Test/TestReadWriteReadCompare.cxx
1204 * Test/CmakeList.txt: because the compare test of
1205 Test/TestReadWriteReadCompare.cxx fails, the following images are
1206 black listed: - 8BitsUncompressedColor.dcm
1208 - US-PAL-8-10x-echo.dcm
1209 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1210 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1211 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1212 and ad-hoc kludge. This kludge is now removed, and on encountering
1213 such an image (OB field brain damaged) we set errno. Then in
1214 ::FindDocLength() we "fix" the length as being ALL what remains
1215 in the file (until EOF). We then proceed, hoping for the best...
1216 This fixes a SegFault in ShowDicom when trying to write such an
1218 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1219 (because TestWriteRead breaks on it, after a non conformal commit?).
1220 ctest now runs properly, except for MakeDicomDir (which was always
1221 broken) and the Python related stuff (still not fixed).
1223 2004-06-24 Jean-Pierre Roux
1224 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1225 FIX : Test/TestReadWrite now iterates on all the file names
1226 (instead of infinite loop)
1227 ENH : Test/TestWriteRead now iterates on all the file names
1229 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1230 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1232 2004-06-24 Jean-Pierre Roux
1233 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1234 when SamplesPerPixel =3
1235 - now Write is no longer confused by
1236 'BitsAllocated = 12" and 'BitsStored=12"
1237 - "UN" value representation Elements are now written correctly
1238 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1239 ENH : - now gdcmHeader has its own Write methods
1240 (in order to split the job that has not to be done
1243 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1244 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1245 loop on the same image until memory went out.
1246 Note: this means we still have gobs of memory loss in PrintDocument
1247 * src/gdcmDocument.cxx: fixes problem on parsing on file
1248 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1250 2004-06-24 Jean-Pierre Roux
1251 FIX : Write - All the Sequences and Sequence Item are now written
1252 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1253 is added a the end, when necessary.
1254 - A lot of brain-damaged images, that were read correctly are
1255 now written correctly
1256 - length compatible BinEntry are now loaded correctly
1257 (even for odd groups)
1258 Note : only Explicit Value Representation was checked.
1259 (question : is implicit VR really necessary for gdcm ?)
1261 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1262 * DEVELOPPER: added a proposition of coding style.
1263 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1266 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1268 Use the gdcmDocEntry::Print() and Write() instead.
1269 * src/gdcmDocument.cxx: bug fix.
1271 2004-06-22 Jean-Pierre Roux
1272 FIX : gdcmDocument.cxx
1273 - Now we do recognize the JpegLossLess format (there was a misstyping in
1274 code 'beautyfication' :-(
1275 - Now we automaticaticaly load the Luts, if any
1277 2004-06-22 Jean-Pierre Roux
1278 In order : to write Sequences, whatever their imbrication level,
1279 : to allow user to create his own Sequences
1280 a lot of modif where necessary (adding, moving, or virtualising methods)
1282 WARNING : save your own sources *before* cvs up !
1285 ADD virtual void Write(FILE *fp, FileType filetype);
1288 ADD virtual void Write(FILE *fp, FileType filetype);
1289 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1292 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1293 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1294 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1295 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1296 ADD std::string GetEntryByName(TagName name);
1297 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1299 std::string vr = "unkn",
1300 std::string fourth = "unkn",
1301 std::string name = "unkn");
1302 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1303 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1304 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1305 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1306 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1307 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1308 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1309 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1312 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1313 ADD virtual std::string GetEntryByName (TagName tagName);
1314 ADD virtual std::string GetEntryVRByName (TagName tagName);
1315 REM virtual bool Write(FILE *, FileType);
1316 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1317 FILE *_fp, FileType type);
1318 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1319 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1320 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1321 REM virtual std::string GetEntryByName (std::string tagName);
1322 REM virtual std::string GetEntryVRByName (std::string tagName);
1323 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1324 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1325 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1327 std::string vr = "unkn",
1328 std::string fourth = "unkn",
1329 std::string name = "unkn");
1330 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1331 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1332 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1333 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1336 ADD virtual void Write(FILE *fp, FileType filetype);
1339 ADD virtual void Write(FILE *fp,FileType filetype);
1342 ADD virtual void Write(FILE *fp, FileType filetype);
1343 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1344 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1345 REM std::string GetEntryByName(TagName name);
1348 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1350 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1352 The default constructor invoked by the line
1353 gdcmHeader *f1 = new gdcmHeader( header );
1354 was gdcmHeader::gdcmHeader(bool) instead of the expected
1355 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1356 Hence the parsing wasn't executed... See also below.
1357 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1358 as explicit constructor didn't do the trick to fix the above problem.
1359 Could anyone explain why ?
1360 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1361 properly calls gdcmValEntry::Print() (that was weed out from
1362 code related to gdcmBinEntry).
1364 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * In order to fix memory leaks:
1366 - Test/TestWriteSimple.cxx: added cleaning of free store through
1368 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1369 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1370 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1371 (through the call to ::AddDicomDirMeta()) or the destructor
1372 would crash when deleting uninitialized ::metaElems].
1373 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1374 - src/gdcmDocument.cxx:
1375 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1376 from dynamic stores.
1377 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1378 was causing memory leaks.
1379 - src/gdcmSQItem.cxx:
1380 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1381 cleanly handled with polymophism: sorry but my milage is low).
1382 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1383 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1384 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1385 This avoids SegFaulting.
1386 - src/gdcmSQItem.h: coding style.
1388 - Test/TestWriteSimple still severely sucks. The output image content
1389 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1390 damaged when displayed with vtkgdcmViewer.
1391 - on memory leaks: TestWriteSimple leaks really less (see entry
1392 of 2004-06-18 in Changelog file for the call to valgrind).
1393 - on segfaults: ctest now passes all the tests but one (no more
1395 * Erroneous leading white fix:
1396 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1397 white[s] (as opposed to from >> xxx, that removes it [them].
1398 - src/gdcmTS.cxx: ditto.
1399 - gdcmPython/testSuite.py: dirty related kludge removed.
1400 * src/*: remaining references to gdcmParser removed.
1401 * src/*[cxx|h]: added copy[way]left header.
1404 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * In order to fix writing of dicom files:
1406 - Test/TestWriteSimple.cxx: a simpler example of writing.
1407 - Test/CMakeLists.txt changed accordingly.
1408 - src/gdcmDocument.cxx:
1409 -- The destructor now recursilvely removes potential sequences.
1410 -- Bug fix in ::IsJPEG2000()
1411 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1412 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1414 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1415 to only declared) and build on top of
1416 ::GetDocEntryByNumber(guint16, guint16).
1417 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1418 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1419 for usage in destructor and treatement of promotion in
1420 ::ReplaceOrCreateByNumber().
1421 - src/gdcmSQItem.cxx: destructor should better handle his job.
1422 Test/TestWriteSimple now runs (or at least it DOES something).
1423 * We can now start hutting memory links. A good starting point is:
1424 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1425 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1426 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1428 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * Valgrind note: after Mathieu Malaterre teached me how to read
1430 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1432 Using gcc, you can force the STL to use malloc and to free memory as
1433 soon as possible by globally disabling memory caching.
1434 With 3.2.2 and later, you should export the environment variable
1435 GLIBCPP_FORCE_NEW before running your program.
1436 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1437 simply vanish (it is still not clear to me, whether this means that
1438 STL std::string leaks or if valgrind believes it leaks...).
1439 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1440 running bin/gdcmTests makeDicomDir):
1441 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1442 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1444 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1445 SegFaulting (I drowned in DicomDir related code when trying to
1446 understand why the list is empty...).
1447 * src/gdcmDocument.h: first BSD license header try.
1448 * Doc/License.txt added.
1450 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * src/gdcmDocument.[h|cxx]:
1452 - Clean up of the Transfer related predicates. They are now all based
1453 on new method isGivenTransferSyntax, that (should) handle properly
1454 the padding problem.
1455 - general clean up, simplification, and coding style.
1456 - Specific clean up of Parse7FE0() (umproperly named actually).
1457 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1459 2004-06-14 Jean-Pierre Roux
1461 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1462 - fix the display of SQItem ordinal number
1463 - add the GetSQItemByOrdinalNumber method
1464 - remove some useless never written private methods
1466 2004-06-14 Jean-Pierre Roux
1468 - adding a constructor taking a gdcmDocEntry as an input param
1469 - ReplaceOrCreateByNumber now returns :
1470 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1471 a gdcmValEntry * if a string value is passed as a param
1473 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1474 according to the param type (no longer sets a gdcmDocEntry)
1475 - GetValEntryByNumber, GetBinEntryByNumber added
1476 - NewValEntryByNumber and NewBinEntryByNumber added
1478 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1480 - GetSQItemNumber and SetSQItemNumber added, to provide
1481 a (relative) Item identier inside a given Sequence
1482 \warning : some pb remaining around this number
1484 - AddEntry now takes the Item Number as a param
1486 - adding a constructor taking a gdcmDocEntry as an input param
1488 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1489 * Memory leak hunt with the following command:
1490 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1491 --show-reachable=yes gdcmTests PrintDocument
1492 It looks like many (all?) leaks are due to the STL (or a bad usage
1493 of the STL. The lines producing the leaks now have a comment with
1494 a "MEMORY LEAK" tag: you can retrieve them with
1495 grep "MEMORY LEAK" src/*
1496 Here are two typical examples which I can't help fixing:
1501 char * test = "babo";
1502 name = test; //// <--- valgrind detects 960 bytes lost in
1503 //// call to std::string::operator=(char const*)
1504 name.clear(); //// Doesn't help !
1512 std::cout << "Type a bunch of characters followed by RETURN: ";
1513 getline(std::cin, line); //// <--- valgrind dectects a loss
1514 //// of 1320 bytes in call to
1515 /// std::basic_istream<>& std::getline<>
1521 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * src/gdcmHeader.[cxx|h]:
1523 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1524 and related, moved away to gdcmDocument.
1525 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1526 the corresponding protected accessors of inherited class
1527 gdcmDocument, removed ! As a consequence gdcmFile had to be
1528 declared friend of class gdcmDocument (see below).
1529 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1530 - Clean up of undefined or unused methods.
1531 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1532 account the changes to gdcmHeader.h).
1533 * src/gdcmDocument.h:
1534 - gdcmFile is now a friend class (in order to take into account the
1535 changes to gdcmHeader.h).
1536 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1537 (see changes to gdcmHeader.h).
1538 - Accessors (reading on the form GetEntry*) are now public.
1539 - Clean up of undefined or unused methods.
1540 * src/gdcmDocument.cxx:
1541 - adaptation to changes to gdcmDocument.h
1542 - ::OpenFile now writes a verbose message when file cannot be opened.
1543 - some std::string properly set to VRKey
1544 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1545 references to gdcmDocument.
1546 * Test/TestFindTags.cxx: changed accordingly to above changes.
1547 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1548 cvs repository gdcmData.
1550 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1552 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1553 conflicts with gdcmValEntry::voidArea.
1554 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1555 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1556 Value representation between StringRepresentable and BinaryRepresentable.
1557 * src/gdcmDocument.cxx:
1558 - method ParseDES: proper indentation restored and usage of
1559 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1560 - method LoadDocEntry: the fingerprint left in the SetValue() of
1561 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1562 removed. Reverting to previous code segment with the proper
1563 dynamic_cast< gdcmValEntry* >.
1564 Note: this was (partially) breaking the python test suite
1565 (gdcmPython/testSuite.py) that made usage of the above
1566 fingerprint to check presence of "Pixel Data".
1567 * src/gdcmDocEntry.h: coding style.
1568 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1569 now taken into account.
1570 * gdcmPython/gdcm.i: adaptation to the new internal representation
1571 of gdcm (exit gdcmParser, hello gdcmDocument).
1572 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1574 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1575 anymore, but instead prints the loaded Python dictionary.
1576 * .... alas, the python testSuite is still broken.
1578 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1579 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1581 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1582 * src/gdcmUtil.h : export methods
1584 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1587 * Initial addition of automatic python testing
1588 * Initial addition of automatic image comparison
1590 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1591 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1592 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1594 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1595 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1596 * Test/ShowDicom.cxx : bug fix for msvc compilation
1597 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1599 2004-05-04 Jean-Pierre Roux
1600 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1601 new concepts (and new classes) :
1602 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1603 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1604 - Sequence Doc Entries (gdcmSeqEntries)
1605 a Sequence is composed of Items.
1606 Each item is a set of Doc Entries (this is recursive)
1607 The non uniqueness of the 'Dicom tag' is due to this recursivity
1608 (never taken into account)
1609 Our unability to add a new 'entry' in the header
1610 at the proper location (neither in the H-Table (map or multimap),
1611 nor in the Chained List is also due to this recursivity.
1612 Don't try, right now, to use/modify/compile these new sources :
1613 nothing is finished.
1614 We just commit all the stuff, 'as is', in order not to loose it.
1616 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1619 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1620 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1621 file prefix (SetFilePrefix)
1623 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1624 * Add a new test: ShowDicom, for now this is just the c++ version of
1625 checkRead.sh, later it will be able to compare the image read against a
1627 * Replace the DEBUG on the stack with a global entry in cmake interface:
1628 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1630 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1631 * Add an example subdir, with a real example on how to read + write a
1634 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1635 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1636 * Doc/CMakeLists.txt: the main page is now properly differentiated
1637 between the developper and user version.
1638 * Doc/doxygen.config.in: dropped search related obsolete flags
1639 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1641 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1642 * DEVELOPPER: added some helpfull comments for compile/test/install
1645 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1647 src directory, now generated in the build dir.
1648 2. Tests as mentionned smarter
1650 4. Add a new method in gdcmDict that return the PubDict by name
1651 this is interesting for 3rd party lib like ITK,
1652 where we could set the institution name / patient name...
1654 * ENH: 1. Now the test suite is working for real
1655 2. All binaries are now output in the gdcm-bin directory
1656 (this was not true before)
1658 2004-04-28 Jean-Pierre Roux
1659 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1660 SeQuence indented printing of Dicom Header.
1661 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1662 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1663 Computation of SQDepthLevel is now part of gdcmHeader constructor
1664 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1665 tree-like structure of a Dicom Header.
1666 * FIX Test code cleaning
1668 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * ENH: Adding automatic testing
1670 1. Need a DartConfig.cmake to submit to public
1671 2. Add a test driver gdcmTest.cxx
1672 3. gdcmTestMain, an helper for the main test driver gdcmTest
1673 4. Files in Test don't have a main anymore, this becomes interesting
1674 when we add more and more tests, thus dsw don't have to load
1676 * ENH: Adding a GDCM_DATA_ROOT for testing
1677 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1678 one file instead of seven + some small cleanup
1680 2004-04-22 Jean-Pierre Roux
1681 * ENH Minor changes to the Print() methods.
1682 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1683 Header printing. Example given with :
1684 > PrintHeader fileName 2 new
1685 (SQ based tree-like structure still to be done for the Header ...)
1687 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1689 1. I have added some unsigned where needed
1690 2. Some function parameter not used -> (void)
1691 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1692 4. g++ don't like character '\' in comment
1693 5. #define jpeg_create_decompress jCreaDecompress
1694 this really need to be fixed
1695 6. virtualize destructor of gdcmObject ... leakage
1696 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1697 this also really need to be fixed
1698 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1699 remove compression file
1700 (as we only do decompression, right ?)
1701 * ENH: Change malloc/calloc/free with c++ equivalent
1703 2004-04-21 Jean-Pierre Roux
1704 * FIX gdcmHeaderHelper::GetXSpacing
1705 when a single value is found (bug ?), xpacing is now
1706 defaulted to yspacing
1708 2004-04-19 Jean-Pierre Roux
1709 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1710 * ENH add parameters :
1711 bool exception_on_error = false,
1712 bool enable_sequences = false,
1713 bool ignore_shadow = false
1714 to the gdcmFile constructors to be full gdcmParser compliant
1715 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1716 to allow reading of PAPYRUS 3.0 files
1718 2004-04-06 Jean-Pierre Roux
1719 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1721 2004-04-02 Jean-Pierre Roux
1722 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1723 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1724 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1726 2004-03-30 Jean-Pierre Roux
1727 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1728 for ACR file, written out as DICOM files (hope so...)
1730 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1731 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1732 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1733 moved to base class gdcmParser and only the specialisation is kept
1735 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1736 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1737 already does the job.
1738 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1739 (to be consistent with gdcmParser::WriteEntries).
1741 2004-03-30 Benoit Regrain
1742 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1743 upate of the object's instance. It's passed to 2 in the unfavorable
1744 case : one in the ExecuteInformation, one in the ExecuteData
1746 2004-03-29 Jean-Pierre Roux
1747 * ENH : Check on file type to be written moved
1748 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1749 * FIX : gdcmObject::ResetBoundaries now stops properly
1750 when end-of-list is reached
1751 : gdcmVersion modified (as Benoit Regrain asked)
1753 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1754 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1755 * src/gdcmUtil.cxx: added forgotten iostream include.
1756 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1757 equivalent to ExplicitVR in existing code).
1759 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1760 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1761 now contains all the gdcmGlobal related code.
1762 * minor coding style and doxygenation changes.
1764 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1766 now contains all the Debug related code.
1767 * minor clean-up of includes in src/*.cxx
1768 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1769 CreateCleanString) removed.
1770 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1771 * Doc/DoxyMainPageUser.txt added.
1772 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1773 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1774 src/gdcmDirList.cxx)
1776 2004-03-24 Jean-Pierre Roux
1777 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1779 2004-03-23 Jean-Pierre Roux
1780 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1781 big endian made volumes
1782 * ENH Now gdcmParser constructor and destructor are protected to forbid
1783 end user to instanciate class gdcmParser
1784 (only gdcmHeader and gdcmDicomDir are meaningfull)
1786 2004-03-22 Benoit Regrain
1787 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1788 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1789 gdcmSerie to gdcmDicomDirSerie
1791 2004-03-19 Jean-Pierre Roux
1792 * ENH Now the tree-like structure describing a DICOMDIR comming from
1793 an already existing DICOMDIR file is consistent with
1794 the home-made tree-like structure build ex-nihilo
1795 or build from the files held (recursively) in a Directory
1796 functions gdcmDicomDir::CheckBoundaries()
1797 gdcmObject::SetBoundaries() added
1799 2004-03-17 Jean-Pierre Roux
1800 * REM (Eric Boix bug) : removal of meaningless
1801 gdcmDicomDirImage::NewImage function.
1802 * FIX now file names and directory name are written properly in the
1804 * FIX now gdcmDicomDir constructor may be call without any trick
1807 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1808 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1809 of gdcmDicomDirImage::NewImage as empty function.
1811 2004-02-28 Jean-Pierre Roux
1812 * ENH add gdcmDicomDir:NewPatient
1813 add gdcmDicomDirPatient:NewStudy
1814 add gdcmDicomDirStudy:NewSerie
1815 add gdcmDicomDirSerie:NewImage
1816 to allow making gdcDicomDir object.
1817 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1818 (as opposite to the gdcmHeader chained list)
1820 2004-02-11 Benoit Regrain
1821 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1822 when using from python
1824 2004-02-10 Benoit Regrain
1825 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1826 * FIX : in gdcmDicomDir when the directory is empty
1827 * ENH : add callback and methods to get the progression of dicomDir
1830 2004-02-06 Jean-Pierre Roux
1831 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1832 - GDCM_META added to gdcmDicomDirType
1833 - class gdcmMeta created
1834 * ENH : - A brief summary is now displayed at the beginning of
1835 'testDicomDir' to help disaster magnitude estimation
1836 * REM : Now useless Test/explDICOMDIR.cxx
1838 2004-02-05 Benoit Regrain
1839 * ENH : add methods in gdcmObject to get the hash table or the list of
1841 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1842 * FIX : wrapping python for TagHeaderEntryHT
1844 2004-02-04 Benoit Regrain
1845 * FIX : even length for some strings when writting the dicom dir
1846 * FIX : sort the images in the dicom dir
1847 * FIX : Bug fix for python use of dicom dir
1848 * ADD : a python demo
1850 2004-02-04 Jean-Pierre Roux
1851 * FIX : Final solution (?) for icone embedded images
1852 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1853 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1854 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1855 gdcmData/gdcm-MR-SIEMENS-16.acr1
1856 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1857 to make full checking easier
1859 2004-02-04 Benoit Regrain
1860 * FIX : WriteEntries : coding style & logic in parameters
1861 * FIX : Set the elements to create the DicomDir in a dictionary file
1863 2004-02-03 Benoit Regrain
1864 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1865 * gdcmDicomDir : add the load of directory
1866 * Bug fix and print add-on
1868 2004-02-03 Jean-Pierre Roux
1869 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1870 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1871 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1872 * FIX gdcmParser.cxx : 'group length' elements are now considered
1873 as integers, even for shadow groups, when file is Implicit VR
1875 2004-02-02 Jean-Pierre Roux
1876 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1878 of the last synonym :-(
1879 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1881 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1882 * FIX taking into account the possible 7fe0,0010 multiplicity
1883 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1884 to allow removal of references to 7fe0,0010, to deal with
1885 ACR-NEMA images, when 0028,0200 is meaningfull
1887 2004-01-31 Jean-Pierre Roux
1888 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1889 no longer writes 'Un' on disk
1890 * FIX SQ elements with actual length are now dealt with corectly
1891 * FIX gdcmFile::WriteBase make the difference, for color images, between
1892 the length (for Palette expanded images)
1893 and Raw Length (non expanded image + Palette)
1894 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1895 (that broke Write). Replaced by UL.
1896 Aware user will reload the field if he
1897 thinks it's necesssary
1899 2004-01-30 Jean-Pierre Roux
1900 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1901 when 'dirty Acr' is found, to be compliant with the new
1902 IsReadable() methods.
1904 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1905 (no DOUBLE images in kosher DICOM,
1906 but so usefull for people that miss them ;-)
1908 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1909 DICOMDIR related utilities (not checked as Windoze compliant)
1911 2004-01-28 Jean-Pierre Roux
1912 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1914 2004-01-27 Jean-Pierre Roux
1915 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1916 to allow skipping the shadow elements, to save memory space.
1917 The TRUE value for this param has to be used
1918 with a FALSE value for the 'enable_sequence' param.
1919 ('public elements' may be embedded in 'shadow Sequences')
1920 * gdcmHeader methods now deal with 'embedded icones images' in the header
1921 (even when an 'icone image sequence' is announced by the
1922 element (0x0088,0x0200), but there is NO icone at all ...
1924 * gdcmHeader sometimes Image Location value doesn't follow
1925 the supposed processor endianity (see gdcmData/cr172241.dcm).
1928 * gdcmHeader add the method
1929 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1930 to get *all* the Header Entries with the same tag.
1931 GetHeaderEntrySameName is probabely *useless*
1932 (no meaning : Name is *not* an identifier within the Dictionary)
1934 2004-01-26 Benoit Regrain
1935 * Bug fix in the print of hexadecimal representations. Remove long fields
1936 in the print and add a third level of print to print them
1938 2004-01-23 Benoit Regrain
1939 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1940 * Bug fix on test suite after remove the strip made on not string fields
1941 * Split the IsReadable method between gdcmParser which test that the file
1942 is dicom and gdcmHeader which test that it's an image file
1944 2004-01-22 Benoit Regrain
1945 * DicomDir : clean code, add methods, set variables in protected or private
1946 * gdcmUtil : bug fix for the clean string method
1948 2004-01-19 Benoit Regrain
1949 * Add the use of shadow dictionaries
1950 * bug fix and coding style
1952 2004-01-19 Benoit Regrain
1953 * src/gdcmFile.cxx : bug fix concerning the close of file
1954 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1955 * Add the update of header entries using the shadow library
1957 2004-01-19 Benoit Regrain
1958 * removal of file gdcmHeader2.cxx
1959 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1960 inheriting from gdcmParser. This split is to prepare the integration
1961 of dicom dir parsing
1962 * bug fix under python
1964 2004-01-16 Jean-Pierre Roux
1965 * REM removal of class gdcmHeaderEntrySet
1966 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1967 * ADD add file gdcmHeader2.cxx
1968 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1970 2004-01-15 Benoit Regrain
1971 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1972 entries created while parsing the header. Thus, they will be destroyed
1973 when the gdcmDictSet will be destroyed
1974 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1977 2004-01-15 Benoit Regrain
1978 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1979 made a fatal error because of the memory release at the end of program.
1980 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1981 some memory and vtk seems to have some problems with that.
1982 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1984 2004-01-14 Benoit Regrain
1985 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1986 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1987 * src/*.[h|cxx] : make changes due to class name changes
1988 * gdcmPython/demo/*.py : bug fix due to method names
1990 2004-01-13 Benoit Regrain
1991 * src/*.[h|cxx] : coding style
1992 * vtk/*.[h|cxx] : coding style
1994 2004-01-13 Benoit Regrain
1995 * gdcmPython/testSuite.py : test the readable flag of file for tests
1996 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1997 It's lied to the stl compilation by MSVC (windows, always windows...)
1998 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2000 2004-01-12 Benoit Regrain
2001 * src/*.h : add comments
2002 * src/gdcmDictSet.h : set the method BuildDictPath in public
2003 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2004 directly setted in the source code
2005 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2008 2004-01-09 Benoit Regrain
2009 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2010 * setup.py : use a reference to gdcmVERSION
2012 2004-01-07 Benoit Regrain
2013 * Modification to compile with the distutils.
2016 2003-12-10 Benoit Regrain
2017 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2018 can use a gdcmHeaderHelper to load data
2019 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2020 made in the source code
2022 2003-12-10 Benoit Regrain
2023 * Update Windows projects and .cvsignore files
2025 2003-11-12 Jean-Pierre Roux
2026 * ENH gdcmHeader constructor has one more parameter (default value : false)
2027 that allows the user to 'go inside' the SeQuences only
2029 gdcmElValSet:Print takes it into account
2031 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * ENH: Update gdcmPython/CMakeLists
2033 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2034 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2036 2003-11-10 Jean-Pierre Roux
2037 * FIX : gdcmHeader::LoadElements is now based
2038 on the ListTag listElem member,
2039 not longer on the TagElValueHT tagHt member
2040 * ENH : PrintPubElVal shows (temporarily) both results,
2041 with the tagHt member and the listElem member.
2042 (it's easier to 'see' the problems when using Printheader)
2044 * FIX : old private member LgrElem is now splitted into
2045 ReadLength : Length actually found on disk (updated only
2046 if bug fixing is necessary), for internal
2048 UsableLength : Updated by FixFoundLength, to fix a bug
2049 or to allow Parser going on.
2050 Will allow to re-write a kosher header when a SeQuence
2051 with a length (not 0000) is found
2052 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2053 because gdcmElValSet::Add does not update ListElem
2056 2003-11-07 Jean-Pierre Roux
2057 * FIX misstyping in Transfert Syntax name table
2058 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2059 when they have an actual length (not 0000 nor FFFFF)
2060 (Nobody should care of it, but DICOMDIR explorers)
2062 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2063 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2065 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2066 * ENH: vtkGdcmReader now supports LUT !
2067 (vtkgdcmViewer for now is not able to use them though)
2069 2003-11-05 Jean-Pierre Roux
2070 * in testSuite.py : new files names for checking the package
2071 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2072 that returns the pixel area size to the *aware* (vtk) user
2073 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2075 2003-11-05 Benoit Regrain
2076 * in testSuite.py : Modify the rules for checking the paths
2077 : Explicit error messages
2078 * in __init__.py : Related modif
2080 2003-11-03 Jean-Pierre Roux
2081 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2082 to be used by aware (vtk) users that want to manage
2083 LUT (and no to turn the PALETTE image into an RGB pixels one)
2084 * GetPixelType now returns 8U for 24 Bits images
2085 (vtkGdcmReader compliant)
2087 2003-10-31 Jean-Pierre Roux
2088 * Removal of *all* gdcmData images and add them again
2089 in order to loose the 'history' of un-anonymised images
2091 2003-10-31 Jean-Pierre Roux
2092 * RMV : removal of useless jBitsInJsample.h
2093 for both 8 and 12 Bits JPEG Lossy Libraries
2095 2003-10-31 Jean-Pierre Roux
2096 * ENH : Add the functions gdcmFile::GetImageDataRaw
2097 gdcmFile::GetImageDataIntoVectorRaw
2098 that act as GetImageData and GetImageDataIntoVector
2099 except the making of an RGB Plane from Gray Plane + LUT
2100 Intended to aware (vtk) users who know how to manage
2103 GetLUTRGBA return a R,G,B,A LUT if any
2104 lgrTotaleRaw gives the 'Raw' length
2105 GetImageDataRaw returns the gray Plane
2106 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2107 (They stay Grey, just like with other Dicom viewers :-(
2109 2003-10-30 Jean-Pierre Roux
2110 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2112 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2113 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2114 being coherents dicom files.
2116 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2117 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2119 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2120 * ENH: Two steps is necessary to please VC++ compiler...
2121 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2122 * ENH: Add include dir to medcon lib
2123 * FIX: only one function is being exported for now !
2124 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2126 2003-10-29 Jean-Pierre Roux
2127 * adding gdcmHeader::GetLUTRGBA
2128 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2129 --> Mathieu, the modif u're waiting for is not yet committed
2130 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2132 2003-10-27 Jean-Pierre Roux
2133 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2134 00191113.dcm DermaColorLossLess.dcm
2135 MxTwinLossLess.dcm RadBWLossLess.dcm
2136 * ENH: For version prior to vtkImageViewer2 -r 1.19
2137 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2139 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * Removal of ido stuff in CMakeLists.txt
2142 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2144 * FIX: remove a call to ->Modified ... see comments
2145 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2147 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2148 * FIX: Problem with path for libvtkgdcmPython
2149 * ENH: Try adding a search script for python site-package
2150 * RMV: Remove some file from medcon lib that are not necessary
2151 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2152 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2153 * FIX: More pragma disable fro VC++,
2154 I don't think I break something as it is also disable in VTK/ITK.
2155 But it fasten debug compilation time.
2157 2003-10-23 Jean-Pierre Roux
2158 * gdcm now deals with 16 Bits Run Length Encoded images
2159 (they are compressed as 2 planes images,
2160 one for the high Bytes, the other for low Bytes)
2162 2003-10-22 Jean-Pierre Roux
2163 * Now CheckRead takes into account :
2164 - the bugged 'Leonardo' Siemens images
2165 - the XA images, sent thru the burning VPRO station
2166 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2169 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * FIX: When copying a Makefile.am to CMakeLists.txt
2171 one should remove the '\'
2173 2003-10-22 Jean-Pierre Roux
2174 * in gdcmData adding a bugged 'Leonardo' Siemens image
2175 (wrong lengths in header)
2176 OK with gdcm, KO with the other viewers :-)
2177 * add a GE dlx XA image, thru the VEPRO burning station
2180 2003-10-21 Jean-Pierre Roux
2181 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2182 for a brutal checking of vtkgdcmViewer compliance
2184 2003-10-21 Jean-Pierre Roux
2185 * add the files for 'xmedcon' Jpeg Lossless library
2186 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2188 2003-10-21 Jean-Pierre Roux
2189 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2191 2003-10-21 Jean-Pierre Roux
2192 * garbage Siemens 'Leonardo' images dealt with
2193 (the patch is easy to remove)
2194 * cosmetic changes to avoid warnings
2196 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2198 no need to press 'r' now.
2200 2003-10-20 Jean-Pierre Roux
2201 * upgrade of checkRead.sh checkWrite.sh according
2202 to new Jpeg Lossless decompressor
2203 * add US.3405.1.dcm, a genuine RGB medical file ...
2204 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2205 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2207 2003-10-15 Jean-Pierre Roux
2208 * general anonymisation in gdcmData
2209 * adding the 'color files' from
2210 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2211 * adding some well knowed bugged-header images
2212 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2213 waiting for their inclusion in Python testsuite
2215 2003-10-15 Jean-Pierre Roux
2216 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2217 no longer seg faults when file is not found
2219 2003-10-14 Jean-Pierre Roux
2220 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2223 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2224 * TODO: *.in file to genereate a UseGDCM later
2226 2003-10-14 Jean-Pierre Roux
2227 * Some supposed-to-be Dicom Images have no preamble.
2228 OpenFile takes it into account
2229 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2230 * Missing elements added in dicomV3.dic
2231 (just to be affraid : have a look at
2232 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2233 and do it again next year ;->
2235 2003-10-13 Jean-Pierre Roux
2236 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2237 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2238 But there are NOT. It's fixed !
2240 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * FIX: "jpeglib.h" was not found on VC++
2242 * FIX: vtkgdcm was not being installed
2244 2003-10-10 Jean-Pierre Roux
2245 * ENH : OpenFile closes the file if it *really* doesn't look like
2246 an ACR-NEMA / DICOM one.
2247 * FIX : testWrite no longer writes an empty file if the source file
2248 is not gdcm Readable
2249 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2252 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * FIX: CMake generate now documentation
2254 * ENH: out of source doc build !
2255 * ENH: Generate both user and dev documentation
2256 * ENH: Should work on windows too
2257 * ENH: Only one doxygen config.in file is needed
2258 * FIX: make install should be ok now on ùnix plateform
2259 * FIX: PATH to dictionary was wrong (missing /)
2260 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2262 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2263 * vtkGdcmReader is now able to read rgb dicom file.
2264 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2265 * added a gdcmViewer to vtk test, use mouse to control
2266 window level & window width
2268 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2269 * CMake-ification of gdcm, we have now two build system
2270 * FIX: on cygwin Wsock32 doesn't exist
2271 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2273 2003-10-06 Emanuel Ollart
2274 * FIX : compilation process wad broken.
2275 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2277 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * change gdcmViewer -> vtkgdcmViewer
2279 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2281 2003-10-06 Jean-Pierre Roux
2282 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2283 ( e.g : well known GE images with a wrong elem length,
2284 : Philips MRI Images with a wrong Huffman table)
2285 * still to be done : allow the reading of bugged LEONARDO Siemens images
2287 2003-10-03 Jean-Pierre Roux
2288 * Odd length strings are padded with '\0' (not with spaces,
2289 to remain compliant with already defined strings,
2290 like Transfert Syntax UID and others)
2292 2003-10-03 Jean-Pierre Roux
2293 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2294 to allow displaying RGB images (not only by affim ;-)
2296 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * vtkGdcmReader is now able to read rgb dicom file.
2298 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2300 2003-10-03 Jean-Pierre Roux
2301 * A few nasty patches to allow the reading of a lot of nasty images
2302 ( e.g : well known GE images with a wrong elem length,
2303 : Philips MRI Images with a wrong Huffman table)
2304 * still to be done : allow the reading of bugged LEONARDO Siemens images
2306 2003-10-03 Jean-Pierre Roux
2307 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2309 2003-10-03 Jean-Pierre Roux
2310 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2311 to allow displaying RGB images (not only by affim ;-)
2313 2003-10-03 Jean-Pierre Roux
2314 * gdcmFile::GetImageDataIntoVector now
2315 - deals with MultiFrames MultiFragments Run Length Encoded files
2316 - deals with YcBcR (YBR_FULL) files
2317 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2318 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2320 (no sample found :-(
2322 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2323 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2324 Two reasons: - clear things
2325 - third parties acces gdcm through header files, so won't
2326 suffer anymore VC++ complains
2328 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2329 * add argv[1] in testvtkGdcmReader.cxx
2332 2003-09-24 Jean-Pierre Roux
2333 * The lines are now eigthy characters long.for
2334 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2336 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2338 char* to std::string. Thus, the use of strdup becomes useless. (see
2339 previous commis of Malaterre)
2340 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2341 before the last Malaterre's commit.
2343 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2344 * This commit should fix the Debug building under VC++, the problem
2345 was mainly a mixture of debug and release lib being loaded at startup.
2346 * I also remove a depency to a specific C function: strdup. Because I had
2347 to force the link to msvcrtd (whereas strdup is in libc).
2349 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2350 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2351 located in the gdcmCommon.h file. All use of reference of tha has been
2352 changed to now use the variable GDCM_UNFOUND.
2354 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2356 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2357 Dicom dictionary. The test suite can now be run again. Note:
2358 I'm note very happy with the " (RET)" changes. I believe this
2359 RETAINED comment should be dropped when parsing the dictionary.
2360 - PACKAGER corrected
2362 - AUTHORS updated and now in alphabetical order
2363 * Makefile.am now exports gdcm.dsw for Windoze users.
2365 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2366 * cygwin complains about missing std:: in subdir Test/
2368 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2369 * remove some methods that are now in gdcmHeaderHelper
2371 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2372 * vtkGdcmReader set spacing and origin correctly
2374 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * Fix a few delete/delete[] mismatch
2377 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2379 interpretation to data given by gdcmHeader. For instance there are
2380 heuristics to get informations (look at different places).
2381 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2382 sorting DICOM images based on different strategies.
2383 * modified Makefiles accordingly.
2385 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2386 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2387 when building in debug mode
2388 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2389 src/win32/gdcmdll.dsp
2390 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2392 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2393 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2396 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * src/win32/libgdcmjpeg12.dsp was not dos format
2398 * src/win32/libgdcmjpeg12.dsp :
2399 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2400 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2402 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2403 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2405 * src/gdcmFile.cxx : bug fix in affectation type
2406 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2407 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2408 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2409 symbols... future problem ?
2411 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * src/win32/libgdcmijpeg12.dsp was missing
2413 * modified gdcm.dsw accordingly
2415 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2418 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2419 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2420 commit of JPR (before his hollidays to facilitate our work).
2421 * setup.py : bug fix in code. Modifications made while the last commit
2422 of JPR. The code hasn't been tested before the commit... it's so
2423 useless to make that (for best programmer that is JPR) !!!
2425 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * tagged the current version as Version0_3 (i.e. version 0.3)
2428 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2429 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2430 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2431 * *.dsp : modifications to use new libgdcmijpeg8 library
2432 * setup.py : bug fix on VTKPATH variable
2433 * PACKAGER : adding all concerning windows
2435 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2438 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2439 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2440 test suite reported error.
2441 * PACKAGER file added (describes what a packager must do when
2442 packaging a new release).
2443 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2444 * configure.in: upgraded version number to 0.3.0
2445 * fixing build of rpm (through rpm -ta):
2446 - Doc/Makefile.am exports proper doxygen files
2447 - src/jpeg/libijg8/Makefile.am exports the include files.
2449 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2450 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2451 * src/gdcmHeader.h : formatting code
2453 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2454 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2455 We were obtaining error message from vtk. Now, creation of file list
2456 is made in an internal list to prevent this problem.
2457 Bug fix when output is empty.
2458 Bug fix in update of progress value. Previous commit for this was a bad
2460 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2462 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2463 * src/gdcmHeader.h : added method to get the file name
2464 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2465 files. Added method to remove all files on the input
2466 Added FIXME comment concerning the bad parsing of header made by
2467 ExecuteInformation method (in ExecuteData method)
2469 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2470 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2471 when using make instal.
2472 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2473 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2475 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2476 * setup.py : adding include dir of jpeg lib to compile all sources
2477 * */Win32/*.dsp : JPR fix for windows compilation
2479 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2480 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2482 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2483 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2485 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * setup.py is again effective on un*x (takes into account the
2487 addon of the jpeg library)
2488 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2489 * Doc/Doxy* updated (includes above enhancements)
2490 * INSTALL now points to web documentation
2492 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * src/gdcmHeader.h doesn't make unnecessary reference to
2495 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2497 * src/gdcm*.[cxx|h] :
2498 - to allow compilation with gcc 3.x
2499 -- clean up of STL usage (added explicit usage of std::)
2500 -- small fixes on exceptions.
2501 Note: linking not tested !
2502 - clean of doxygen comments to avoid warnings at documentation
2504 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2505 dependent convertion).
2507 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * Clean up of previous JPR garbage commit (not even commented in the
2510 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2511 - moved all jpeg related files from src to src/jpeg/libijg8, with
2512 addition/modification of Makefile.am and configure.in.
2513 - the testSuite is still brain damage (not guilty).
2515 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2516 * WrapVTK.py : modifications to get correctly vtk source files to
2518 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2519 (FileName -> Filename)
2521 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * vtk/vtkGdcmReader.[cxx/h]:
2523 - UpdateProgress method should now be effective
2524 - removed the limitation on having only images loaded (as opposed
2526 - when building a stack of images/volume, a lesser number of
2527 gdcmHeader and gdcmFile instances should be used (hopefully
2528 accelerating things).
2529 - when building a stack of images/volumes, files which are not
2530 loadable (wrong path-filename, wrong permissions on existing file,
2531 or file not parsable by gdcm) are replaced with a black image
2532 in the stack (for the caller to notice the problem).
2534 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2537 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2538 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2539 between standard library (std) and vtk library (problems are found
2540 under Windows... thanks Windows !)
2542 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2545 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2547 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2550 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * When compiling with distutils (see setup.py) the C++ compiler is
2552 called with different flags than the default ones (with automake).
2553 In order to fix all those warning, I compiled gdcm with the command
2554 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2555 and went for warning fixes:
2556 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2557 up from unused variables.
2558 - vtk/vtkGdcmReader.cxx: potential bug fix.
2559 * src/gdcmHeader.h: Doxygen warning cleanup
2561 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * gdcmPython/gdcm.i:
2563 - typemaps correction to take into account the systematic replacement
2564 of "using namespace std" with std:: prefix e.g. std::list,
2565 std::string... (cf changes of 2003-05-21).
2566 - gdcmGlob global variable of type gdcmGlobal (defined in
2567 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2568 exported to Python a as cvar.
2569 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2570 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2571 gdcmDictSet.GetPubDictTagNames() and
2572 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2573 C++ static methods).
2574 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2575 with the above changes.
2577 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2578 * setup.py, manifest.in : bug fix under linux
2580 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2581 * Modification of setup.py to compile vtk part too. Then, we have 2
2582 wrappers which must work with same distutils. For that, we have a
2583 generic distutils in distusiltsWrapping.py ; with :
2584 - build_extWrap class to wrap generically all extensions,
2585 - ExtensionWrap base class for all wrapping extension that contains
2587 - Wrapper interface which wrap sources
2588 + In WrapSwig.py we have extension and wrapper for Swig
2589 + In WrapVTK.py we have extension and wrapper for VTK
2590 * MANIFEST.in : modifications to consider vtk directory and new python
2591 files for compilation
2593 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2594 * Added python wrappers of vtkGdcmReader vtk class (see the
2595 source in vtk/vtkGdcmReader.cxx) :
2596 - vtk/Makefile.am now builds a library
2597 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2598 python library (as opposed to _gdcm.so wich are the python
2599 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2600 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2602 - configure.in has an additional flag --enable-vtk that needs
2603 to be set to enable compilation of vtk related code, that is:
2604 + vtk/vtkGdcmReader.so and
2605 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2606 + gdcmPython/vtkgdcmPython.so (see above)
2607 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2608 be read when compressed or when HighBit + 1 != BitsStored),
2609 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2610 the usage of the python wrapper of vtkGdcmReader vtk class.
2611 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2612 * src/*.[h] all occurences of stl classes are now prefixed with
2613 std::, and all occurences of "using namespace std;" where removed.
2614 This is to avoid pollution of global namespace in included files.
2615 Apparently vtk does not avoid this pitfall: when using both
2616 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2617 collision of various stl members (principally cout...).
2618 * gdcmPython/testSuite.py now cleanly removes temprory generated
2620 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2621 comply with above changes)
2623 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2624 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2625 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2626 vtk data structure (an image Flip was required).
2627 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2628 * cosmetic changes in documentation.
2630 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2631 * src/gdcmHeader.cxx: the constructor no longer exits when an
2632 unexisting file is given as argument.
2633 * The subdirectory Data (containing all the images used for the
2634 test suite) is not part of this repository anymore. A new module
2635 containing those images is now available at
2636 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2637 with the name gdcmData.
2638 All the python scripts (including the package initialisation file
2639 gdcmPython/__init__.py) were adapated to take this change into
2640 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2642 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2643 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2644 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2645 demo of the usage of this class.
2646 Compilation of this vtk part is only done when using the --enable-vtk
2647 at configure (or autogen.sh) stage.
2649 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2650 * More memory link related corrections and documentation fixes.
2652 - maximum info is obtained with a command of the form:
2653 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2654 --show-reachable=yes PrintHeader
2655 - the remaining reachable blocks seem to come from the STL
2656 allocation scheme through the usage of map and list. It looks
2657 like this memory cannot be freed but it is not a memory leak
2658 (in fact further invocation to the STL would recollect the
2659 unused memory allthough it cannot explicitely be freed).
2660 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2661 of displaying an image parsed with gdcm and displayed with VTK.
2662 Note: some images don't seem to work e.g.
2663 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2664 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2665 Allthough this weakens the semantics, it is a ditch attempt to
2666 make gdcm more thread friendly.
2668 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2669 * Memory link hunt (by using valgrind through the command
2670 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2671 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2672 gdcmHeader::_dicom_vr.
2673 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2674 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2676 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2678 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2679 * src/Makefile.am now exports all the necessary include files at
2683 * UpdateGroupLength replaced by new one
2686 * UpdateGroupLength re-written using H-Table
2687 (named UpdateGroupLengthNew untill checks are over)
2689 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2690 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2691 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2693 - gdcmHeader::GetPubElValSet removed.
2694 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2695 UpdateGroupLength, WriteElements, Write.
2696 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2697 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2698 carried the same semantics.
2699 - src/gdcmHeaderIdo.cxx changed accordingly.
2700 - gdcmFile::WriteBase now regroups all the codes from previous
2701 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2702 - enum FileType moved to gdcmCommon.h
2703 * src/gdcmHeader.cxx AddDefault trashed
2704 * gdcmGetXSize added
2705 * getimageDataSize now calls gdcmGetXSize
2706 * Test/*.cxx changed to agree with above changes
2708 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2710 (to avoid double call by end user).
2711 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2712 by end user, since gdcmHeader::gdcmHeader now handles it.
2714 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * gdcm/Doc many doxygen changes:
2716 - Doxyfile now has two different versions, DoxyfileUsers that generates
2717 the html.users end users oriented documentation and
2718 DoxyfileDeveloppers that generates the html.developper developper
2719 oriented documentation.
2720 - README changed accordingly
2721 - requirement.txt removed (old design info moved to TODO).
2722 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2723 DoxyMainPage.txt, DoxyPython.txt provide more information.
2724 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2725 be updated by simply regenerating the docs with doxygen and copying
2726 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2727 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2728 all the tests in the form "if (<map>.count() >1)" were removed.
2729 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2730 ill-formed documentation sections.
2731 * src/gdcmHeader.cxx: ditto
2733 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * setup.py fixed for un*x (needed macro for stdint.h)
2735 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2736 un*ces with sh-utils test utility.
2737 * gdcmPython/demo/test.py renamed to PrintHeader.py
2738 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2739 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2740 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2741 * src/gdcm*.cxx JPR's bad inclusion fixed.
2743 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2745 * gdcmPython/demo/test.py changed accordingly.
2747 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * gdcmPython/Makefile.am fixed linking against libstdc++
2749 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2750 * Swig subdir (historical tests of swig version 1.3.17++) removed
2751 * Test/testChangeEntete.cxx some lines commented out in order to make
2753 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2754 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2756 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2758 hence the user doesn't need this explicit call.
2759 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2760 i.e. LoadElements() call removed.
2761 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2762 - src/Makefile.am declares the proper flag for g++.
2763 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2764 for adding user defined new tags.
2765 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2766 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2767 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2769 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2770 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2771 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2772 src/Makefile.am : the project should properly compile and install
2773 with the autotools, included the python wrappers part.
2774 * gdcm.spec.in : added a spec file for RPM packaging.
2776 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2777 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2779 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2781 to exported to the environement (see gdcmPython/testSuite.py
2783 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2784 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2785 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2786 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2787 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2789 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * gdcmPython/__init__.py doesn't crash anymore when running in
2791 in InstallMode or PreInstallMode but with an environment given
2792 value of GDCM_DICT_PATH.
2793 * src/gdcmDictSet.[cxx/h] coding style.
2795 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2797 * src/gdcm.h general comments moved to TODO, and README
2798 * src/gdcm.h should now be seen as a user commodity (including it
2799 should suffice to fully use gdcm). It is nowhere including within
2800 any of the kernel files src/*.cxx and src/*.h.
2802 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2804 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2806 * src/gdcm*.cxx only include their corresponding include file
2807 (as opposed to gdcm.h)
2808 * gdcmPython/gdcm.i changed accordingly
2809 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2810 the autogen.sh generated "make snapshot" command to work.
2811 * autogen.sh removed history related references to crea package.
2813 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * distutilsSwigCPlusPlus.py work around some swig portability
2817 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2819 was done in a last ditch attempt to get setup.py _really_
2820 operationnal. The python/gdcmPython layaout add the advantage
2821 of hidding away the python related distutils specific files
2822 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2823 Alas, the src directory was out of scope (i.e. it's relative
2824 position to setup.py was ../src) which made things impossible to
2825 handle (see previous version of python/setup.py). Crossing fingers...
2827 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * python/setup.py now works on Un*x. (harder than I thougth)
2829 * python/distutilsSwigCPlusPlus.py can now have include files
2830 among the list of sources.
2832 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2833 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2834 * modifications in MSVC projects
2836 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * As stated by the first lines of Test/ExceptionAndPython/README, it
2838 looks like we can move back to original usage of exception within
2839 src/gdcm* and hence remove the errno stuff that was introduced
2840 as a quick and dirty fixture of this problem (added to the TODO).
2841 * Doc/Doxyfile configuration file for Doxygen and corresponding
2842 README file for usage added.
2843 * Test/testWrite.cxx added. This new test comes from a split of
2844 test.cxx that is now reverted to its original purpous i.e.
2845 testing the proper parsing of a Dicom related file.
2846 testWrite.cxx concentrates on testing the IO part of gdcm.
2847 * Test/bug1.cxx (containing a bug on WIn32) added.
2848 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2849 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2850 whose purpose is to publish the content of the TagNames of the
2851 Dicom public dictionary were not accessible without an
2852 instance of class gdcmHeader.
2853 - those methods are now static methods of gdcmDictSet and hence
2854 require no instances at all to be invocated.
2855 - within gdcmDictSet this change required to change some method
2856 to class methods (i.e. are now static) among which SetDictPath
2857 (renamed to BuildDictPath) and LoadDefaultPubDict.
2858 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2859 the above changes by calling the new method classes of gdcmDictSet.
2860 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2861 the above to be effective.
2862 * python/gdcmPython: in order to wrap properly the above changes
2863 for Python, swig version now needs to be > 1.3.17.
2864 * python/gdcmPython/Makefile fixed to adapt itself to new
2865 configure/make shema introduced by Johan Montagnat (thanks for the
2866 contribution). Alas this Makefile cannot be turned into a proper
2867 Makefile.am without some heavy changes in the configure.in
2868 (for python dectection).
2869 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2870 now avoids publishing the empty entries.
2872 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2873 * python/setup.py : bug fix concerning install under windows
2874 ExtraPath reused :-P
2875 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2877 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2878 * Dicts/dicomV3.dic : remove double spaces !!!
2879 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2880 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2883 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2885 method. Doxygenation.
2886 * src/gdcm.h clean up of JPR spurious comments.
2888 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * python/distutilsSwigCPlusPlus.py now properly collects the
2890 shadow classes generated by "swig -c++" (gdcm.py in our case)
2891 when using "python setup.py install".
2892 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2893 reexports the working classes.
2894 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2895 by the classical C errno scheme. This is to prevent an obscure
2896 behavior of the python wrappers when importing wxPython.wx prior
2897 to gdcmPython (which ended up in an abort call). An illustration
2898 of this oddity can be found in the Test/ExceptionAndPython
2899 subdir (see the README file). This problem probably due to
2900 an combination of g++ and dynamic loading.
2901 * added Test/ExceptionAndPython (see above)
2903 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * Changed the layout of the python part to avoid bloating main
2905 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2906 i.e. the distutils arsenal. All the python related stuff is
2907 again in a python subdir, but the package itself is now in
2909 * setup.py was cleaned up:
2910 - pythonIncludePath removed
2911 - python setup.py bdist target is now functional.
2912 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2913 collision with other packages). gdcmPython/demo/*.py changed
2916 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * python subdir moved to gdcmPython (preparation of distutils packaging).
2918 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2919 distutils installer is operational.
2920 * - gdcmPython/__init__.py now properly loads the swig generated
2921 shadow classes (from gdcm.py).
2922 - gdcmPython/demo/*.py changed to import the package gdcmPython
2923 instead of gdcmPython/demo/load.py.
2924 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2926 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2927 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2928 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2929 entries within the associated public Dicom dictionary resp. the same
2930 information but sorted by the fourth field (PAT, IMG, DIR) of the
2932 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2933 are now in the "???" group.
2934 - python/gdcm.i changed accordingly,
2935 - python/demo/printGroupedPublicDict.py added, that gives an example
2936 of the above new functionalities in Python.
2938 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * src/gdcm.h, gdcmHeader.cxx:
2940 - historic references to glib's g_malloc and g_free (#defined)
2941 were definitively removed.
2942 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2943 * src/gdcmElValSet.cxx:
2944 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2945 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2946 - GetElValue(string) renamed to GetElValueByName.
2947 - Added GetElementByName(string).
2948 * src/gdcmHeader.cxx: added
2949 - GetPubElValRepByNumber(guint16, guint16)
2950 - GetPubElValRepByName(string)
2951 - GetShaElValRepByNumber(guint16, guint16)
2952 - GetShaElValRepByName(string)
2953 - GetShaElValByNumber(guint16, guint16)
2954 - GetShaElValRepByName(string)
2955 - GetElValRepByNumber(guint16, guint16)
2956 - GetElValRepByName(string)
2957 - GetElValByNumber(guint16, guint16)
2958 - GetElValRepByName(string)
2959 * Doc/requirements.txt added.
2961 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2962 * Test/Makefile building now depends on the one of libgdcm.so
2963 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2964 pixel data) aware which enables finding the address (offset) of
2965 the pixel data of JPEG encoded DICOM files. This leaves only a single
2966 file in the testSuite whose pixel data address (offset) is unknown.
2967 * python/testSuite.py changed accordingly.
2969 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2970 * VC++ has some strong limitations when working with the STL, as stated
2971 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2972 "Also note that some STL containers (map, set, queue, list, deque)
2973 cannot be exported. [...]
2974 Some STL classes contain nested classes. These classes can not
2976 This is caused by a designed limitation that once a template
2977 class is instantiated, it can not be re-instantiated and
2979 Since our usage of map<> is ubiquitous in gdcm, this "designed
2980 limitation" of VC++ is a pitfall.
2981 Hence the Python wrappers of gdcm cannot be incrementally linked
2982 against the c++ dynamic library. The dirty but only workaround is
2983 to forget about incremental link of dynamic libraries and to generate
2984 the Python wrappers library with the inclusions of the underlying C++
2986 The following modifications concern this matter on Win32/VC++:
2987 - wrapping python correct with standalone wrapped dll (don't use separate
2988 dll under windows !!!!)
2989 - python21_d debug mode enabled (ask Frog how to use it :-)
2990 - NO problem with having an STL member of class for example string in C++
2991 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2992 - Python test of dcmlib in Python is ok under windows on a large set
2994 * removed glib references
2995 * typedef's inserted in gdcm.i for correct swig type management
2997 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2998 * python/demo/*.py load.py extracted from test.py. Added explore.py
2999 that only displays required tags and testAll.py that parses all
3000 the files of the testsuite without using unittest.
3001 * python/testSuite.py other additional test on new files added.
3002 * Data/* new test files added accordingly to the testSuite.
3003 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3004 the vr in the file differs from the one of the dictionary.
3006 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3008 values, but limits itself to values which are below a user specified
3009 size (by default 1024 bytes).
3010 * python/gdcm.i : elements not loaded (because their size is above the
3011 user specified treshold) are exported with their TagKey as key of the
3012 python dictionary. This enables the testsuite to make some checks
3013 on the unloaded elements (since we have their offset and size).
3014 * python/testSuite.py
3015 - now tests for the existence and proper value of the pixel data
3016 - two new examples added.
3017 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3019 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3020 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3021 aware. See the strategy comments in gdcmHeader::FindeLength().
3022 * Test/test.cxx now accepts a filename as first argument.
3023 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3024 * python/testSuite.py changed to integrate test on above files.
3026 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3027 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3028 the vr was also RET.
3029 * python/testSuite.py more tests added.
3031 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * python/testSuite.py unittest test suite added (uses Data)
3033 * Data/* dcm and acr files for the test suite.
3034 * glib dependance removed from un*x version. We now use ISO C99
3035 7.18 Integer types (see stdint.h)
3036 - python/Makefile, src/Makefile src/gdcm.h
3037 * src/ when an explicit vr (like dicom files) suddenly poped an
3038 implicit element we use to mark the underlying DictEntry of the
3039 concerned ElValue with "Implicit". This strategy was damageable
3040 too the public or provite dictionaries, since some of their vr
3041 would be changed. Since Header::FindLength heavily relies on the
3042 detection by Header::FindVR of falsely explicit elements, I
3043 added an extra ImplicitVr member to ElValue (boolean).
3044 The rest of the changes we the necessary adaptations.
3046 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3047 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3049 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3051 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * Adaptation for porting to VC++:
3054 o forced to use std namespace (for string to be known)
3055 o all class use __declspec export style on WIN32
3056 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3057 (in stdlib.h on Win32 but in std:: for gcc)
3058 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3059 variable GDCM_DICT_PATH.
3060 * src/gdcmHeader.cxx verbose comments made discrete.
3062 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * python/gdcm.i: added a typemap that converts a C++ hashing table
3064 to native Python dictionary.
3065 * python/demo/test.py:
3066 - now uses the native dictionary for exploration of gdcmHeader.
3067 - takes an optional filename argument (the file to parse).
3068 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3069 PubElVals hashing table.
3070 * Dicts/dicomV3.dic removed error prone trailing spaces.
3072 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3073 * Python wrapping process moved away from src/Makefile to
3074 newly created python/Makefile (as well as gdcm.i)
3075 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3076 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3077 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3078 from the environement variable GDCM_DICT_PATH (when existing).
3079 * src/gdcmDict::GetTag bug fix.
3081 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * Straightforward temporary fixes for swig to build the python wrappers.
3083 src/Makefile now has a python working entry [by working we mean
3084 that we can import de shadow classes without errors].
3086 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * hashtest.cxx removed (since already in Test)
3088 * src/gdcmlib.h renamed to src/gdcm.h
3089 * src/dcm.i renamed to src/gdcm.i
3090 * src/Makefile prepared for python wrapping
3092 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * src/gdcmHeader.cxx :
3094 - Parsing of header is now separated from loading of element values
3095 (see gdcmHeader::LoadElements).
3096 - general clean up of hopefully all file access (creation of
3097 ReadInt16 and ReadInt32)
3099 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * src/gdcmHeader.cxx :
3101 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3103 - SetLgrElem renamed to SetLength
3104 - GetLgrElem renamed to GetLength
3105 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3106 * src/gdcmElValSet.cxx fixed both GetElValue methods
3107 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3108 due to IdoDude was cleaned out.
3110 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3111 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3112 concentrates on finding the value representation (when it exists).
3113 RecupLgr now only finds the element value length, and it avoids
3114 returning the unecessary skL (skipped length).
3115 Also, offsetCourant was simply removed (with taille_fich) since
3116 it was redundant with the File position internals (by using
3117 ftell and fseek). This also made skL (see above in RecupLgr) usage
3119 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3120 on the libido specificities which are handled through class
3122 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3125 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3126 * Truckload of changes. Parsing of header is barely functional
3127 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3129 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3130 * src/gdcmHeader.cxx many addons of low level methods
3132 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3134 and _IdDcmSWAP_LONG.
3136 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3137 * This corresponds to all the changes decided at the meeting of
3138 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob