1 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Now, python test might work on systems
3 * Add the PrintDicomDir test
5 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
6 * FIX : First entry following group 0002 was lost for
7 Explicit Big Endian Transfer Syntax files
8 (group and elem not swaped)
10 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
11 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
12 Big Endian Transfer Syntax supposed the group following 0002
13 begins always by element 0000 (element 0000 is *optional*)
14 To avoid further troubles, let's be pessimistic, and use
15 Document::HandleOutOfGroup0002() method
16 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
17 (related pb not yet solved)
19 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Bug fix for the python part use
21 * Now, PrintHeader.py pass... but outside the ctest use. shit !
23 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
26 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
27 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
28 a string and should ask the global TS dict what are the propreties of
31 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
32 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
33 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
34 to swap the Swap Code, at parsing time, when we come out of group 0002
35 and Transfer Syntax is Big Endian
36 We should be able to read now 'true DICOM" Big Endian coded images
37 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
38 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
40 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Hopefully fix the bug on MacOSX and static global initialization.
42 This is the only -minor- patch I found that both please MacOSX and VS6.
43 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
44 but this would require a lot of change. Another approach would be that Global
45 create those string and GDCM_UNFOUND becomes a pointer to a string (which
46 gdcm::Global would destroy at exit).
48 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 * Fix bug on MacOSX with static initialization in a multy threaded
50 environment. static const string in a header file used to be ill
51 initialized provoquing the freeze of any tests. patch should solve this
54 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
55 * According to Benoit's suggestion, and without any objection from anybody
56 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
57 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
58 - method gdcmDicomDirObject::GetEntry() renamed as
59 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
61 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
63 you debug/warning message just as c++ streams which make them very convinient
64 to use. Once this is stabilize I will change the ostringstrem to be
65 redirected to a file (ofstream).
66 * Properly support C99 extension: __FUNCTION__ which allow us to display
67 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
69 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
70 * Removal of useless and dangerous methods :
71 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
72 GetDocEntryByName, GetEntryByName, GetDictEntryByName
73 * Removal of usless methods :
74 Dict::PrintByName, Dict::GetDictEntryByName
75 * Commenting out of probabely useless methods :
76 Dict::GetDictEntryNames()
77 Dict::GetDictEntryNamesByCategory()
78 DictSet::GetPubDictEntryNames()
79 DictSet::GetPubDictEntryNamesByCategory()
80 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
81 * ENH : Use dicomTS.dic as described in 2004 version
82 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
83 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
84 Add Accessors on VM (Value Multiplicity), and VM related methods
85 * ADD : Add a list of 'Dicom Attribute types', as found in
86 http://medical.nema.org/dicom/2004/04_15PU.PDF
88 * ADD : Add dicomGroupNameAbbreviations.dic
89 should be used to write a method to replace the former
90 Dict::GetDictEntryNamesByCategory()
92 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
94 to read in the file... and only it ! Length is the efective length of the
95 data in the DocEntry structure
97 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
99 And now use a static function call instead, with a global variable. i
100 This is much closer to the VTK approach. Hopefully should be bulletproof
101 and easier to use...hopefully
103 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
104 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
106 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
109 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
111 ValEntry, BinEntry, SeqEntry creation or replace
113 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
115 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
117 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
118 when specifying the VR
119 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
120 * src/gdcmDocEntry.cxx : amelioration of print
122 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
123 * ADD : Add the method Util::IsCurrentProcessorBigEndian
124 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
125 * ADD Method Document::ComputeGroupLength
126 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
127 in order to allow further VR modification by user
128 * REM : removal of once-called method File::WriteBase
129 integration of its code in formerly one-line method File::Write
131 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
133 replace the different values "??", "Unkn", "Unknown".
134 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
135 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
136 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
137 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
139 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
142 * Set the gdcm::Base class to some Printable classes
144 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmFile.[h|cxx] : add the Print method
146 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
147 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
148 * src/gdcmDocument.h : remove the PrintLevel informations
149 * Example/PrintFile.cxx : use the new gdcm::File::Print
151 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
153 problems when compiling with the python wrapping
155 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
157 writting in ImplicitVR
159 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
160 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
161 JPEG decompression, especially when dicom frames are split into several
162 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
163 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
165 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmHeader.cxx : change the initialisation of default header.
167 Now, this header is readable by gdm, e-film, DicomWorks
169 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
171 Rename Decompressed to Raw
172 * Use the API changes in gdcm::File.
173 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
176 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
178 each added entry in the header. Replace the 'Planes' field by the 'Number
181 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
183 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
185 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
187 At this time, this image isn't readable by e-film... waiting JPR help to
190 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
192 DocEntry. Now use methods of the Document !
194 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * Test/ShowDicomSeq.cxx : bug fix
197 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
199 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
200 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
201 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
203 * Test/TestCopyRescaleDicom.cxx : remove unused variable
204 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
205 containing found sequences
207 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
210 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
211 Some fields in BinEntry must be copied to not seg fault when making the :
212 gdcm::File *copy = new gdcm::File( copyH );
213 and tests are now made on good variables
215 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
217 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
219 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
220 * Add vtkGdcmWriter example and test
222 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * Test/TestUtil.cxx : reformat the source code
224 * vtk/vtkGdcmReader.cxx : remove and change prints
225 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
227 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
228 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
230 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
232 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
234 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
236 by an eof to prevent all bad read of the file... and in this case, the
239 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * Example/Volume2Dicom.cxx : comment unused variables
241 * Test/PrintDicomDir.cxx : comment unused variables
242 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
243 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
244 method that is redondant with AddEntry.
245 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
248 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * Bug fix due my last commit (compilation under Windows).
250 * Example/Volume2Dicom : bug fix in the file and reformatting source code
251 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
253 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 - Remove printf / sprintf
256 - include iostream AFTER gdcm so we don't get warnings
257 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
259 - Also remove tons of include from header files, hopefully this should
260 speeup the compilation time, since it was becoming a dog slow.
261 - Remove gdcm.h as it include way too many files and slow down compilation
262 (plus it is not up to date)
263 - remove 'using namespace std' this is BAD !
265 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * Remove memory leaks on the DicomDir
267 * Remove some useless data in DicomDirObject
268 * Add usefull methods in SQItem, to be complient withe the ElementSet
270 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
273 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
275 future, with convertion)
276 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
277 and ImageDataSize values. Remove the method to get the PixelReadConverter
278 from the output of the class
280 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
283 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
285 and vtkErrorMacro use.
286 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
288 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
291 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
292 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
293 The string leaves only in the fonction. So when we make a .c_str(), we
294 get the pointeur on the first element, element that will be destroyed
295 immediately after thee instruction.
296 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
297 file has been opened : the test must be made on the content of the
298 pointer and not directly on the pointer !
301 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
303 the python part recompiles
305 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
307 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
308 X session is killed (for my computer... it seems to not be identic on
311 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
313 avoid problems (otherwise, the difference test between the visible image
314 and the reference is incorrect. If the reference is greater than the
315 screen resolution, it's produce errors).
316 Can be used for only one image. Can be used with a visible flag.
317 * vtk/vtkGdcmReader.cxx : remove commented codes.
318 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
319 under windows at compilation
320 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
322 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
324 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
326 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
327 tests on the image size X, Y, Z
329 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
331 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
332 between the class name and the file name
334 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * src/ : fix compilation warnings for the Write method (2 different
336 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
337 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
338 variable... create a static method in gdcm::Document to access to
339 this variable content.
341 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
343 file, to be accessed by other files (like gdcmFile). Remove commented
344 code. Move the change of the header to the gdcmFile, using the
346 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
347 To be sure of that (and simplify calls), the Write of the header now
348 gets a file name and not a file pointer (std::ifstream).
349 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
350 DocEntryArchive. Remove all open of the written file
352 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
355 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
357 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
359 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
360 some corresponding methods. Write correctly the file and check before
362 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
363 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
364 is now on RGB data (as before my last commit
365 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
367 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
369 Add a print information of the type of the entry
370 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
371 It was in the gdcmFile, and all write have been regrouped
372 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
373 Write correctly all dicom files (in decompressed mode only at this time)
374 * Test/ : test on files are now made using Raw data and not color data if
376 * Example/PrintFile.cxx : add more printings
378 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
379 * Amelioration of code, remove some code copy. For the loading of
380 BinEntry (in gdcmDocument), add the test to verify if the file is already
383 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
385 remove a DocEntry in the header (push an empty DocEntry)
386 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
387 lines. Bug fix in the initialization of the PixelConvert and the
389 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
390 use in TestCopyDicom (now this test can run under windows... but fails)
391 * Test/TestCopyDicom.cxx : amelioration of the test :
392 - test the pixels written
393 - add test points to quickly find where is the error
394 - can set a file name input and output in arguments
395 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
396 amelioration of the test output
398 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
400 all replaced DocEntry's
401 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
402 Now, each needed DocEntry to modify is duplicated, modified and inserted
403 to the header using DocEntryArchive. Thus, after save, we can restore the
404 header initial state.
406 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
409 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
411 correct to copy it. The DictEntry is specified at the DocEntry creation,
412 then, it musn't change in the time.
413 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
414 header correctly. At this time, the change is only made for the first
415 level of the Document. In the future, it might consider sequences.
416 The change is made by replacing a DocEntry by an other that is created
417 outside the class. The old value is kept. When we restore the header
418 status, the added DocEntry is deleted and replaced by the old value.
419 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
420 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
421 set the write type to explicit VR, implicit VR or ACR. Add methods to set
422 the write mode to native, decompressed or RGB (but not used at this time)
424 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
426 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
428 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
430 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
432 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
433 set because already copied when copying the BinEntry's of the header
434 * Test/TestAllReadCompareDicom.cxx : remove warnings
436 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
438 Two problems appear when doing it :
439 - with the gdcmFile : when the GetImageData method is called, the pixels
440 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
441 data (pixels). And each structure destruct the data when it's
442 destructed. So we have two destructions for the same data. To solve it,
443 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
444 data or not. If it doesn't own data, then they will not destroyed by
446 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
447 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
448 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
449 create a double destruction of the same DocEntry's. So, to solve it,
450 the TagHT is simply cleared and the DicomDir* elements are destroyed.
451 * TODO : add an entry concerning memory leaks in the DicomDir
453 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
455 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
458 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
460 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
461 after it have been deleted
463 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * FIX: src/* fix the doxygen warnings.
465 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
466 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
467 was erroneously defined with a size of 15 instead of 16. [many thanks
468 to Jean Michel Rouet for pointing out this bug].
470 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 1. Finish merging JMR patch for writting DICOM from scratch
472 2. Fix -hopefully- bug with MONOCHROME and space vs null character
473 3. Use const ref when possible
474 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
475 5. A few more comments
476 6. CreateUniqueUID can now be called without parameter"
478 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
479 * ENH: Slightly bigger patch:
480 1. Getting toward full integration of JMR patch for writting dicom from scratch
481 2. Update Test to test part of this patch: CreateUniqueUID
482 3. File was not close properly in gdcmDict
483 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
484 5. Use of const ref instead of copy (speed issue)
485 6. Remove temporary (duplicate) string in TranslateToKey
486 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
487 8. Do not repeat virtual in subclasses
488 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
490 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Apply first patch toward better string comparison when dealing with broken
492 DICOM files. Essentially the string could be padded with a space instead
493 of a null character as defined by standard
495 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
497 because never used... and in the same time, that's remove some memory leaks
499 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmFile.cxx : now delete the PixelConvert instance.
501 * In examples and tests : change the type of image data variables from void*
502 to uint8_t*. Remmove all delete on image data variables
504 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
506 Verify the file pointer value before open the file, and if it's not null,
507 a verbose message is generated.
508 Close correctly the file when the file isn't considered dicom-like. The
509 correctly close is a call to CloseFile.
510 When closing the file pointer, test if its not null to close the file.
511 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
512 file. For an uncompressed image, the copied data correspond in the least
513 case to the image size (calculated) or the image size specified in the
514 header. A verbose is generated if these two size mismatch
516 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
518 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
519 break under windows (with msvc6 compilation).
521 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
523 compiling with MSVC6)
525 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * Bugs fix for the Windows build with VC6
527 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
528 needed (only for projects required VTK). If the VTK is included in all
529 projects, there is conflicts with the jpeg lib of vtk when compiling the
530 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
531 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
532 when compiling the gdcm_wrap.cxx file (created by the compilation of the
534 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
535 (like it's already made for the cout use). Otherwise, conflict with the
538 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
541 - comments on the DicomDir::Method related usage added.
542 - now that we use the namespace gdcm, a lot of internal classes do
543 NOT need to be wrapped anymore.
544 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
545 DicomDir::Method) new example added.
547 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
548 * Improve string manipulation. I now inforce the notion of 'DicomString'
549 A DicomString can contain as many \0 as they want
550 and it is *always* of even length.
551 We only support odd length for very rare case.
552 And in the near future this should be removed.
554 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 * /binary_write/ gdcm source. Now even on big endian we are writting
556 little endian. This should -heopfully- fix some tests
558 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
559 * Now the dictionary is compiled into gdcm lib. This is a default
560 behavior, thus any dic file specified is picked before failback to
561 the one comiled into lib
563 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
564 * Change internals for gdcmDict. Don't use any 'new' any more.
565 This should definitely solve any leak problem, and we should be
566 as fast as before, as long as don't modify too much the dictionary.
568 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * STYLE: ivars should start with a capital letter.
570 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
571 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
573 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
575 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
576 new 2004 dictionaries added (thanks to JPR).
577 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
578 * CLEANUP_ROUND (15) for gdcmPixelConvert
579 - RLEFrame::NumberFragments is now of type unsigned int
580 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
581 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
584 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
585 * Initial work in gathering all transfer syntax accessors. clearly
586 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
587 ivars, but only one transfersyntax (class) ivar with equivalent method on
590 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
591 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
592 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
593 discussed (plus I didn't like having a 2000 lines patch not commited)
595 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
596 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
597 * CLEANUP_ROUND (14) for gdcmPixelConvert
598 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
599 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
600 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
602 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
603 anymore and hence avoids storing a copy of PixelConvert::Decompressed
604 into File::Pixel_Data.
606 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
608 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
609 * CLEANUP_ROUND (13) for gdcmPixelConvert
610 Substituted File::ParsePixelData() with PixelConvert::Print() new
612 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
613 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
614 method to those classes.
615 - src/gdcmFile.[cxx|h]:
616 -- Added a ::Print() method.
617 -- PixelConverter is now a reference instead of a member.
618 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
619 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
621 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
623 collaboration diagram and inheritance diagram should be generated with
625 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
626 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
627 pointlessly wrapped (see
628 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
629 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
630 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
631 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
632 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
633 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
634 -- File::Initialise: PixelConverter setup moved away to
635 PixelConverter::GrabInformationsFromHeader()
636 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
637 interpretation moved away to PixelConverter::BuildRGBImage()
639 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
640 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
641 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
643 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
644 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
645 displayed on Win32 when a brutal abort() occurs (because of uncatched
646 exception). See TODO new entry of this commit for more on this.
647 * TODO added new entry.
648 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
649 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
650 - HandleColor is no longer called from gdcmFile.cxx
651 - gdcmPixelConvert.cxx clean up on method arguments and internal
652 variable names for semantical coherence.
654 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
655 * Finished lossless transition, not only do we now read all lossless jpeg
656 images, without the need of the Cornwell lib, but we do read them properly now
657 * To reduce code (well to avoid code duplication), I defined a common place
658 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
659 redefine symbols. This is not perfect but this the best solution I found for a
660 compilation time jpeg option.
662 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
663 * Update jpeg ijg lib to support lossless jpeg implementation
664 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
666 * Also added a special copyright for dcmtk since we use their bugfixes.
669 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
671 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
672 matters, as stated in warning note at begining of %include section).
673 * src/gdcmDicomDir*.[cxx|h]: coding style
674 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
675 * src/gdcmJpeg8.cxx: doxygen fix.
676 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
677 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
678 from File:: to PixelConvert::.
680 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
682 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
683 - more code moved away from File:: to PixelConvert::
684 - fat setup of PixelConverter set in place in File::Initialise.
686 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
687 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
688 namespace at the file system level. So now you should convert your examples
690 gdcmHeader -> gdcm::Header
691 It would be nice if people keep in mind to no open the namespace, since it
692 allows compilation on broken plateform which were defining common symbol in
693 the standart namespace (like LP, Unknown ...)
695 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
697 The JPEG fragments are now parsed at the same stage than the RLE
698 information. All code related to JPEG is now in gdcmPixelConvert:
699 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
700 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
701 export a gdcmFile:: method. Those are simply global functions
702 (for the time being this is better than having them attach to
703 either gdcmFile:: or gdcmPixelConvert::).
704 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
705 and stores the result in a gdcmJPEGFragmentsInfo.
706 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
707 code (among other stuff) moved away from gdcmFile:; to
710 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
711 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
712 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
713 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
714 clean up of RLE related code.
715 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
716 - src/gdcmRLE.cxx removed
717 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
718 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
719 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
720 * CLEANUP_ROUND (9) for gdcmPixelConvert
721 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
722 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
723 away from gdcmFile:: to gdcmPixelConvert::.
725 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
727 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
728 This is because Parse7Fe0 used to parse the pixels to compute the
729 length. This task was passed over to FindDocEntryLengthOB() a long
730 time ago, EXCEPT I had forgotten the OW case...
731 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
732 we just recylce the code for parsing RLE fragments and computing
734 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
735 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
736 with the retired Parse7Fe0().
737 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
738 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
740 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
742 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
743 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
744 - src/CMakeLists.txt: alphabetic order reodering + new entries.
745 * CLEANUP_ROUND (4) for gdcmPixelConvert
746 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
747 to return an unused length.
749 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
750 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
751 this should be cleanner from the plane view. The iostream are erally a pain
752 to use to do simple stuff.
754 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
755 * Redo the compilation of the ijg jpeg library. Now only one source is
756 necesseray. No need to rename file by hand what so ever. CMake handle the
757 copying of the file within different directory, configure header file to
758 modify some symbol. The only addition made to ijg wasd a mangle table so
759 that symbol are different wether we are within 8bits or 12bits.
761 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * Added documentation of vtkgdcmReader on Website:
763 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
764 with it's binary name).
765 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
766 the Website to be more complete.
767 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
768 doxygenated documentation.
769 - Doc/DoxyVtkGdcmReaderExamples.txt added
770 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
771 DoxyVtkGdmReaderExamples.html )
772 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
773 * CLEANUP_ROUND (3) for gdcmPixelConvert
774 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
776 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * CLEANUP_ROUND (2) for gdcmPixelConvert
778 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
780 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * CLEANUP_ROUND for gdcmPixelConvert:
782 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
783 - src/gdcmPixelStuff[h|cxx] removed
784 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
785 - src/CMakeLists.txt changed accordingly
787 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
788 gdcmVersion.py moved to newly created ATTIC related
789 gdcmPython/SetupOldies/ directory.
790 * Autotools clean up:
791 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
792 - autogen.sh configure.in acinclude.m4 python.m4 removed
794 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * src/*.cxx *.h Reference to License.htm fixed to License.html.
796 * Doc/CMakeLists.txt, doxygen.config.in: fix.
797 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
799 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * TODO updated with Mathieu suggestions. I proposed a template for
801 describing TODO entries and used it for new entries.
802 * Added Doc/Website/CodingStyle.html, Developpers.html,
803 DeveloppersPython.html, GdcmDataCvs.html and
804 DownloadVersion0_1.html, DownloadVersion0_3.html.
805 * Some Doc/*.txt Doxygen files (which do not really concern the
806 documentation itself, but the website) moved to html and
807 placed in directory Doc/Website:
808 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
809 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
810 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
811 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
812 * CMakeLists.txt changed accordingly.
813 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
814 DeveloppersPython.html
815 * INSTALL nows refers to Doc/Website/Installation.html
817 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * Added Doc/Website directory, that contains a first raw version
821 2004-09-23 Jean-Pierre Roux
822 * FIX In order not to be poluted any longer by casting problems,
823 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
824 we can now delete[] it safely
825 * VoidArea is now called BinArea (less confusing name),
826 and all the methods called ...VoidArea... are now ... BinArea...
827 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
829 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
831 clear) TagHT, which is an inherited member of gdcmElementSet. It is
832 up to the destructor of gdcmElementSet to clean up TagHt and it's
835 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * Test/CMakeLists.txt: update to follow gdcmData renamings.
837 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
839 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * ENH: added some utility method that builds a flat dictionnary
841 holding all the Dicom entries contained in the recursive structure
842 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
844 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
845 BuildFlatHashTable() that build a flat dictionary.
846 - src/gdcmElementSet.h: added a new private GetTag() accessor.
847 gdcmDocument is now a friend of gdcmElementSet.
848 - src/gdcmElementSet.cxx: clean up.
849 - Example/FlatHashTablePrint.cxx added.
850 - Example/CmakeLists.txt changed accordingly
852 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
854 moved away from gdcmDocEntrySet (since this class is an abstract class
855 acting like an interface). SQDepthLevel and BaseTagKey are now
857 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
858 and associated accessors. Doxygenation of the class.
859 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
861 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
862 Use SQDepthLevel accessor instead. ::Print() adapted.
863 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
864 - src/gdcmDocument.cxx changed accordingly.
866 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
868 - The following is the doxygen comment of the typedef declaration
869 of gdcmTagKey in src/gdcmCommon.h:
870 gdcmTagKey is made to old an "universal" (as in URL, Universal
871 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
872 A dicom tag always has a group and an element, but a set of tags
873 embeded in various (optionally nested) sequences and sharing
874 the same group and element all share the same (group, element)
875 "identifier". Hence the (group, element) cannot be used as an
876 identifier (in gdcm we shall refer to a "TagKey") of a tag.
877 In order to construct a proper tag identifier (i.e. a key) we
878 consider the following definition of a TagKey:
879 - let Group, Element be the string representation of the
880 group and element dicom tag members,
881 - let ItemNumber be the string representation of the integer
882 index of the considered item number of a sequence,
883 Let the key of a tag embeded in a sequence, noted SeqTag, be
885 /ItemNumber#Group|Element
886 where "/", "#" and "|" are characters acting as separators.
887 Then the general form of a gdcmTagKey is given by:
888 Group|Element<SeqTag>
889 where <SeqTag> means NO or many instances of SeqTag.
890 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
893 but the gdcmTagKey of a tag "embeded" is the first item of
894 a sequence, itself nested in the third item of a sequence is the
896 0004|1220/2#0008|0082/0#0008|0090
897 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
898 order to hold the new sequence compatible key. Previously, the
899 GetKey() method would look in the underlying gdcmDictEntry.
900 - src/gdcmDocEntry.cxx:
901 -- constructor now copies the underlying DictEntry key, in the local
903 -- ::Print: displays the member Key, instead of the (group, element).
904 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
905 - src/gdcmDocEntrySet.h:xi
906 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
907 -- now has a new BaseTagKey member.
909 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
910 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
912 This poses the problem with the semantics of the following lines
913 LoadEntryVoidArea(0x0028,0x1201); // R LUT
914 LoadEntryVoidArea(0x0028,0x1202); // G LUT
915 LoadEntryVoidArea(0x0028,0x1203); // B LUT
916 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
917 to the long FIXME note for what the problem is. Nevertheless in
918 order to get things working the dicom dictionary was altered !
919 Please fix things urgently...
920 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
921 information), see above note on moving the member VoidArea. Nevertheless
922 the following entries previously correctly set as US are now inproperly
924 0028 1201 OW IMG Red Palette Color Lookup Table Data
925 0028 1202 OW IMG Green Palette Color Lookup Table Data
926 0028 1203 OW IMG Blue Palette Color Lookup Table Data
927 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
928 of gdcmDocEntry moved to gdcmSeqEntry.
929 * src/gdcmSeqEntry.cxx: STYLE.
931 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * Test/TestAllEntryVerify.cxx minor fix and added comments.
934 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * gdcmPython/testSuite.py: all the test suite in python is now moved
936 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
937 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
938 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
940 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
942 to avoid inclusion recursion until STL is reached.
943 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
944 mecanism. errno.h is not included in gdcm anymore.
945 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
946 (gdcmFormatError now inherits from gdcmFormatUnexpected).
948 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
949 gdcmData/TestAllEntryVerifyReference.txt
950 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
951 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
952 exception_on_error parameter.
953 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
954 - vtk/vtkGdcmReader.cxx changed accordingly,
955 - Example/*.cxx and Test/*.cxx changed accordingly.
957 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
959 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
960 enable_sequences removed from gdcmHeader constructor and dependencies.
961 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
962 * gdcmPython/demo/PrintHeader.py: dummy fix.
963 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
964 skip_shadow removed from gdcmHeader constructor and dependencies.
965 * Example/*.cxx and Test/*.cxx changed accordingly.
967 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
969 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
971 2004-07-21 Jean-Pierre Roux
972 * FIX Now, Parsing and Printing a DICOMDIR do work!
973 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
975 2004-07-20 Jean-Pierre Roux
976 * FIX Some brain damaged headers have Zero-Lenght fields
977 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
979 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
980 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
981 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
982 variable (instance of gdcmDebug) by a definition macro, and the instance
983 is now in static in the gdcmDebug class
984 * src/gdcmSQItem.h : (FIXME) remove an undefined method
985 * Test/PrintAllDocument.cxx : bug fix in the result of the test
987 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * WARNING: ctest now depends more tightly on gdcmData. You should
989 check out gdcmData properly for things to run smoothly...
990 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
991 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
992 we need the pixels not be loaded in order to use the ValEntry
993 that displays position and size).
994 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
995 This is a C++ based equivalent of gdcmPython/testSuite.py that should
996 be deprecated. If you have any doubts about the advantages of a
997 modern scripting language (read Python) versus grass root C++ (i.e.
998 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
999 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1000 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1001 Anyhow, consider documenting the gdcmData images in
1002 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1004 * Test/CMakeLists.txt:
1005 - now uses TestAllEntryVerify.cxx
1006 - specific comments on oldACR00001.ima (now renamed in gdcmData
1007 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1008 gdcmData/TestAllEntryVerifyReference.txt
1011 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * src/*.[h|cxx] : typedef clean up
1013 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1014 - TagKey renamed to gdcmTagKey (for external usage)
1015 - VRKey renamed to gdcmVRKey (for external usage)
1016 - removal of typedef duplication.
1017 - Removed all unecessary inline keyword from class inline definitions.
1018 - Some method|function(void) declarations replaced with method|function().
1019 * src/jpeg/libijg12/jdhuff12.c:
1020 - printf polluting ctest removed.
1021 - TAB removal for comminting
1023 - TestAllReadCompareDicom.cxx: added a test that compares all the
1024 images in gdcmDataImages.h with corresponding images in
1025 gdcmData/BaselineDicom/. When baseline images are not present
1026 this test creates them.
1027 Note: we need to validate each reference image, but before that
1028 I'd like to rename them with a more explicit name...
1029 - CMakeLists.txt: changed accordingly.
1030 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1031 including each header needed).
1033 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1034 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1035 test suite to the Example directory. Are concerned:
1040 - TestWriteSimple.cxx
1041 * Test/CMakeLists.txt: added some comments on reasons for black listing
1042 image gdcmData/oldACR00001.ima
1044 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1045 * Test/CmakeList.txt: removed the following from black list (to be coherent
1046 with removal from gdcmData):
1047 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1048 - gdcm-MR-PHILIPS-16.dcm
1050 Added the following because after last cvs update, they cause
1051 ctest -R TestReadWriteReadCompare
1053 - gdcm-MR-SIEMENS-16-1.acr
1055 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1056 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1057 new comments in this file) we temporarily (sigh) move to a weaker
1059 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1060 we don't need to black list the following images anymore:
1061 - 8BitsUncompressedColor.dcm
1063 - US-PAL-8-10x-echo.dcm
1064 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1065 fixes and the beautified code ;-)
1066 This fixes the bug introduced in version 1.42 (when beautifying)
1067 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1068 Note: ctest was blind to this bug (this means we need to still
1069 improve the test suite). The bug could be detected by using
1070 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1072 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1073 and by displaying the (garbage) produced file temp.XDCM...
1075 2004-06-29 Jean-Pierre Roux
1076 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1077 - replace by uggly but working old code :-(
1078 A lot of things should be OK again.
1079 It's really urgent to have a test suite that *tests*,
1080 to prevent Frog's beautifying sessions to break all the stuff
1081 (twice, withing a fortnigh ...)
1083 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1085 redundancy) to added Test/TestReadWriteReadCompare.cxx
1086 * Test/CmakeList.txt: because the compare test of
1087 Test/TestReadWriteReadCompare.cxx fails, the following images are
1088 black listed: - 8BitsUncompressedColor.dcm
1090 - US-PAL-8-10x-echo.dcm
1091 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1092 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1093 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1094 and ad-hoc kludge. This kludge is now removed, and on encountering
1095 such an image (OB field brain damaged) we set errno. Then in
1096 ::FindDocLength() we "fix" the length as being ALL what remains
1097 in the file (until EOF). We then proceed, hoping for the best...
1098 This fixes a SegFault in ShowDicom when trying to write such an
1100 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1101 (because TestWriteRead breaks on it, after a non conformal commit?).
1102 ctest now runs properly, except for MakeDicomDir (which was always
1103 broken) and the Python related stuff (still not fixed).
1105 2004-06-24 Jean-Pierre Roux
1106 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1107 FIX : Test/TestReadWrite now iterates on all the file names
1108 (instead of infinite loop)
1109 ENH : Test/TestWriteRead now iterates on all the file names
1111 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1114 2004-06-24 Jean-Pierre Roux
1115 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1116 when SamplesPerPixel =3
1117 - now Write is no longer confused by
1118 'BitsAllocated = 12" and 'BitsStored=12"
1119 - "UN" value representation Elements are now written correctly
1120 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1121 ENH : - now gdcmHeader has its own Write methods
1122 (in order to split the job that has not to be done
1125 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1127 loop on the same image until memory went out.
1128 Note: this means we still have gobs of memory loss in PrintDocument
1129 * src/gdcmDocument.cxx: fixes problem on parsing on file
1130 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1132 2004-06-24 Jean-Pierre Roux
1133 FIX : Write - All the Sequences and Sequence Item are now written
1134 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1135 is added a the end, when necessary.
1136 - A lot of brain-damaged images, that were read correctly are
1137 now written correctly
1138 - length compatible BinEntry are now loaded correctly
1139 (even for odd groups)
1140 Note : only Explicit Value Representation was checked.
1141 (question : is implicit VR really necessary for gdcm ?)
1143 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * DEVELOPPER: added a proposition of coding style.
1145 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1148 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1150 Use the gdcmDocEntry::Print() and Write() instead.
1151 * src/gdcmDocument.cxx: bug fix.
1153 2004-06-22 Jean-Pierre Roux
1154 FIX : gdcmDocument.cxx
1155 - Now we do recognize the JpegLossLess format (there was a misstyping in
1156 code 'beautyfication' :-(
1157 - Now we automaticaticaly load the Luts, if any
1159 2004-06-22 Jean-Pierre Roux
1160 In order : to write Sequences, whatever their imbrication level,
1161 : to allow user to create his own Sequences
1162 a lot of modif where necessary (adding, moving, or virtualising methods)
1164 WARNING : save your own sources *before* cvs up !
1167 ADD virtual void Write(FILE *fp, FileType filetype);
1170 ADD virtual void Write(FILE *fp, FileType filetype);
1171 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1174 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1175 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1176 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1177 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1178 ADD std::string GetEntryByName(TagName name);
1179 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1181 std::string vr = "unkn",
1182 std::string fourth = "unkn",
1183 std::string name = "unkn");
1184 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1185 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1186 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1187 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1188 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1189 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1190 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1191 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1194 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1195 ADD virtual std::string GetEntryByName (TagName tagName);
1196 ADD virtual std::string GetEntryVRByName (TagName tagName);
1197 REM virtual bool Write(FILE *, FileType);
1198 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1199 FILE *_fp, FileType type);
1200 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1201 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1202 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1203 REM virtual std::string GetEntryByName (std::string tagName);
1204 REM virtual std::string GetEntryVRByName (std::string tagName);
1205 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1206 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1207 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1209 std::string vr = "unkn",
1210 std::string fourth = "unkn",
1211 std::string name = "unkn");
1212 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1213 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1214 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1215 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1218 ADD virtual void Write(FILE *fp, FileType filetype);
1221 ADD virtual void Write(FILE *fp,FileType filetype);
1224 ADD virtual void Write(FILE *fp, FileType filetype);
1225 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1226 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1227 REM std::string GetEntryByName(TagName name);
1230 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1232 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1233 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1234 The default constructor invoked by the line
1235 gdcmHeader *f1 = new gdcmHeader( header );
1236 was gdcmHeader::gdcmHeader(bool) instead of the expected
1237 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1238 Hence the parsing wasn't executed... See also below.
1239 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1240 as explicit constructor didn't do the trick to fix the above problem.
1241 Could anyone explain why ?
1242 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1243 properly calls gdcmValEntry::Print() (that was weed out from
1244 code related to gdcmBinEntry).
1246 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * In order to fix memory leaks:
1248 - Test/TestWriteSimple.cxx: added cleaning of free store through
1250 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1251 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1252 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1253 (through the call to ::AddDicomDirMeta()) or the destructor
1254 would crash when deleting uninitialized ::metaElems].
1255 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1256 - src/gdcmDocument.cxx:
1257 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1258 from dynamic stores.
1259 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1260 was causing memory leaks.
1261 - src/gdcmSQItem.cxx:
1262 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1263 cleanly handled with polymophism: sorry but my milage is low).
1264 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1265 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1266 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1267 This avoids SegFaulting.
1268 - src/gdcmSQItem.h: coding style.
1270 - Test/TestWriteSimple still severely sucks. The output image content
1271 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1272 damaged when displayed with vtkgdcmViewer.
1273 - on memory leaks: TestWriteSimple leaks really less (see entry
1274 of 2004-06-18 in Changelog file for the call to valgrind).
1275 - on segfaults: ctest now passes all the tests but one (no more
1277 * Erroneous leading white fix:
1278 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1279 white[s] (as opposed to from >> xxx, that removes it [them].
1280 - src/gdcmTS.cxx: ditto.
1281 - gdcmPython/testSuite.py: dirty related kludge removed.
1282 * src/*: remaining references to gdcmParser removed.
1283 * src/*[cxx|h]: added copy[way]left header.
1286 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * In order to fix writing of dicom files:
1288 - Test/TestWriteSimple.cxx: a simpler example of writing.
1289 - Test/CMakeLists.txt changed accordingly.
1290 - src/gdcmDocument.cxx:
1291 -- The destructor now recursilvely removes potential sequences.
1292 -- Bug fix in ::IsJPEG2000()
1293 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1294 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1296 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1297 to only declared) and build on top of
1298 ::GetDocEntryByNumber(guint16, guint16).
1299 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1300 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1301 for usage in destructor and treatement of promotion in
1302 ::ReplaceOrCreateByNumber().
1303 - src/gdcmSQItem.cxx: destructor should better handle his job.
1304 Test/TestWriteSimple now runs (or at least it DOES something).
1305 * We can now start hutting memory links. A good starting point is:
1306 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1307 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1308 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1310 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * Valgrind note: after Mathieu Malaterre teached me how to read
1312 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1314 Using gcc, you can force the STL to use malloc and to free memory as
1315 soon as possible by globally disabling memory caching.
1316 With 3.2.2 and later, you should export the environment variable
1317 GLIBCPP_FORCE_NEW before running your program.
1318 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1319 simply vanish (it is still not clear to me, whether this means that
1320 STL std::string leaks or if valgrind believes it leaks...).
1321 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1322 running bin/gdcmTests makeDicomDir):
1323 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1324 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1326 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1327 SegFaulting (I drowned in DicomDir related code when trying to
1328 understand why the list is empty...).
1329 * src/gdcmDocument.h: first BSD license header try.
1330 * Doc/License.txt added.
1332 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * src/gdcmDocument.[h|cxx]:
1334 - Clean up of the Transfer related predicates. They are now all based
1335 on new method isGivenTransferSyntax, that (should) handle properly
1336 the padding problem.
1337 - general clean up, simplification, and coding style.
1338 - Specific clean up of Parse7FE0() (umproperly named actually).
1339 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1341 2004-06-14 Jean-Pierre Roux
1343 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1344 - fix the display of SQItem ordinal number
1345 - add the GetSQItemByOrdinalNumber method
1346 - remove some useless never written private methods
1348 2004-06-14 Jean-Pierre Roux
1350 - adding a constructor taking a gdcmDocEntry as an input param
1351 - ReplaceOrCreateByNumber now returns :
1352 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1353 a gdcmValEntry * if a string value is passed as a param
1355 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1356 according to the param type (no longer sets a gdcmDocEntry)
1357 - GetValEntryByNumber, GetBinEntryByNumber added
1358 - NewValEntryByNumber and NewBinEntryByNumber added
1360 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1362 - GetSQItemNumber and SetSQItemNumber added, to provide
1363 a (relative) Item identier inside a given Sequence
1364 \warning : some pb remaining around this number
1366 - AddEntry now takes the Item Number as a param
1368 - adding a constructor taking a gdcmDocEntry as an input param
1370 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * Memory leak hunt with the following command:
1372 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1373 --show-reachable=yes gdcmTests PrintDocument
1374 It looks like many (all?) leaks are due to the STL (or a bad usage
1375 of the STL. The lines producing the leaks now have a comment with
1376 a "MEMORY LEAK" tag: you can retrieve them with
1377 grep "MEMORY LEAK" src/*
1378 Here are two typical examples which I can't help fixing:
1383 char * test = "babo";
1384 name = test; //// <--- valgrind detects 960 bytes lost in
1385 //// call to std::string::operator=(char const*)
1386 name.clear(); //// Doesn't help !
1394 std::cout << "Type a bunch of characters followed by RETURN: ";
1395 getline(std::cin, line); //// <--- valgrind dectects a loss
1396 //// of 1320 bytes in call to
1397 /// std::basic_istream<>& std::getline<>
1403 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * src/gdcmHeader.[cxx|h]:
1405 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1406 and related, moved away to gdcmDocument.
1407 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1408 the corresponding protected accessors of inherited class
1409 gdcmDocument, removed ! As a consequence gdcmFile had to be
1410 declared friend of class gdcmDocument (see below).
1411 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1412 - Clean up of undefined or unused methods.
1413 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1414 account the changes to gdcmHeader.h).
1415 * src/gdcmDocument.h:
1416 - gdcmFile is now a friend class (in order to take into account the
1417 changes to gdcmHeader.h).
1418 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1419 (see changes to gdcmHeader.h).
1420 - Accessors (reading on the form GetEntry*) are now public.
1421 - Clean up of undefined or unused methods.
1422 * src/gdcmDocument.cxx:
1423 - adaptation to changes to gdcmDocument.h
1424 - ::OpenFile now writes a verbose message when file cannot be opened.
1425 - some std::string properly set to VRKey
1426 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1427 references to gdcmDocument.
1428 * Test/TestFindTags.cxx: changed accordingly to above changes.
1429 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1430 cvs repository gdcmData.
1432 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1434 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1435 conflicts with gdcmValEntry::voidArea.
1436 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1437 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1438 Value representation between StringRepresentable and BinaryRepresentable.
1439 * src/gdcmDocument.cxx:
1440 - method ParseDES: proper indentation restored and usage of
1441 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1442 - method LoadDocEntry: the fingerprint left in the SetValue() of
1443 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1444 removed. Reverting to previous code segment with the proper
1445 dynamic_cast< gdcmValEntry* >.
1446 Note: this was (partially) breaking the python test suite
1447 (gdcmPython/testSuite.py) that made usage of the above
1448 fingerprint to check presence of "Pixel Data".
1449 * src/gdcmDocEntry.h: coding style.
1450 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1451 now taken into account.
1452 * gdcmPython/gdcm.i: adaptation to the new internal representation
1453 of gdcm (exit gdcmParser, hello gdcmDocument).
1454 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1456 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1457 anymore, but instead prints the loaded Python dictionary.
1458 * .... alas, the python testSuite is still broken.
1460 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1461 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1463 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1464 * src/gdcmUtil.h : export methods
1466 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1467 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1469 * Initial addition of automatic python testing
1470 * Initial addition of automatic image comparison
1472 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1473 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1474 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1476 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1478 * Test/ShowDicom.cxx : bug fix for msvc compilation
1479 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1481 2004-05-04 Jean-Pierre Roux
1482 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1483 new concepts (and new classes) :
1484 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1485 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1486 - Sequence Doc Entries (gdcmSeqEntries)
1487 a Sequence is composed of Items.
1488 Each item is a set of Doc Entries (this is recursive)
1489 The non uniqueness of the 'Dicom tag' is due to this recursivity
1490 (never taken into account)
1491 Our unability to add a new 'entry' in the header
1492 at the proper location (neither in the H-Table (map or multimap),
1493 nor in the Chained List is also due to this recursivity.
1494 Don't try, right now, to use/modify/compile these new sources :
1495 nothing is finished.
1496 We just commit all the stuff, 'as is', in order not to loose it.
1498 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1499 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1501 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1502 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1503 file prefix (SetFilePrefix)
1505 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * Add a new test: ShowDicom, for now this is just the c++ version of
1507 checkRead.sh, later it will be able to compare the image read against a
1509 * Replace the DEBUG on the stack with a global entry in cmake interface:
1510 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1512 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1513 * Add an example subdir, with a real example on how to read + write a
1516 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1518 * Doc/CMakeLists.txt: the main page is now properly differentiated
1519 between the developper and user version.
1520 * Doc/doxygen.config.in: dropped search related obsolete flags
1521 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1523 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * DEVELOPPER: added some helpfull comments for compile/test/install
1527 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1528 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1529 src directory, now generated in the build dir.
1530 2. Tests as mentionned smarter
1532 4. Add a new method in gdcmDict that return the PubDict by name
1533 this is interesting for 3rd party lib like ITK,
1534 where we could set the institution name / patient name...
1536 * ENH: 1. Now the test suite is working for real
1537 2. All binaries are now output in the gdcm-bin directory
1538 (this was not true before)
1540 2004-04-28 Jean-Pierre Roux
1541 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1542 SeQuence indented printing of Dicom Header.
1543 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1544 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1545 Computation of SQDepthLevel is now part of gdcmHeader constructor
1546 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1547 tree-like structure of a Dicom Header.
1548 * FIX Test code cleaning
1550 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * ENH: Adding automatic testing
1552 1. Need a DartConfig.cmake to submit to public
1553 2. Add a test driver gdcmTest.cxx
1554 3. gdcmTestMain, an helper for the main test driver gdcmTest
1555 4. Files in Test don't have a main anymore, this becomes interesting
1556 when we add more and more tests, thus dsw don't have to load
1558 * ENH: Adding a GDCM_DATA_ROOT for testing
1559 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1560 one file instead of seven + some small cleanup
1562 2004-04-22 Jean-Pierre Roux
1563 * ENH Minor changes to the Print() methods.
1564 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1565 Header printing. Example given with :
1566 > PrintHeader fileName 2 new
1567 (SQ based tree-like structure still to be done for the Header ...)
1569 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1570 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1571 1. I have added some unsigned where needed
1572 2. Some function parameter not used -> (void)
1573 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1574 4. g++ don't like character '\' in comment
1575 5. #define jpeg_create_decompress jCreaDecompress
1576 this really need to be fixed
1577 6. virtualize destructor of gdcmObject ... leakage
1578 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1579 this also really need to be fixed
1580 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1581 remove compression file
1582 (as we only do decompression, right ?)
1583 * ENH: Change malloc/calloc/free with c++ equivalent
1585 2004-04-21 Jean-Pierre Roux
1586 * FIX gdcmHeaderHelper::GetXSpacing
1587 when a single value is found (bug ?), xpacing is now
1588 defaulted to yspacing
1590 2004-04-19 Jean-Pierre Roux
1591 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1592 * ENH add parameters :
1593 bool exception_on_error = false,
1594 bool enable_sequences = false,
1595 bool ignore_shadow = false
1596 to the gdcmFile constructors to be full gdcmParser compliant
1597 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1598 to allow reading of PAPYRUS 3.0 files
1600 2004-04-06 Jean-Pierre Roux
1601 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1603 2004-04-02 Jean-Pierre Roux
1604 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1605 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1606 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1608 2004-03-30 Jean-Pierre Roux
1609 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1610 for ACR file, written out as DICOM files (hope so...)
1612 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1613 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1614 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1615 moved to base class gdcmParser and only the specialisation is kept
1617 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1618 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1619 already does the job.
1620 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1621 (to be consistent with gdcmParser::WriteEntries).
1623 2004-03-30 Benoit Regrain
1624 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1625 upate of the object's instance. It's passed to 2 in the unfavorable
1626 case : one in the ExecuteInformation, one in the ExecuteData
1628 2004-03-29 Jean-Pierre Roux
1629 * ENH : Check on file type to be written moved
1630 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1631 * FIX : gdcmObject::ResetBoundaries now stops properly
1632 when end-of-list is reached
1633 : gdcmVersion modified (as Benoit Regrain asked)
1635 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1637 * src/gdcmUtil.cxx: added forgotten iostream include.
1638 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1639 equivalent to ExplicitVR in existing code).
1641 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1642 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1643 now contains all the gdcmGlobal related code.
1644 * minor coding style and doxygenation changes.
1646 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1648 now contains all the Debug related code.
1649 * minor clean-up of includes in src/*.cxx
1650 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1651 CreateCleanString) removed.
1652 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1653 * Doc/DoxyMainPageUser.txt added.
1654 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1655 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1656 src/gdcmDirList.cxx)
1658 2004-03-24 Jean-Pierre Roux
1659 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1661 2004-03-23 Jean-Pierre Roux
1662 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1663 big endian made volumes
1664 * ENH Now gdcmParser constructor and destructor are protected to forbid
1665 end user to instanciate class gdcmParser
1666 (only gdcmHeader and gdcmDicomDir are meaningfull)
1668 2004-03-22 Benoit Regrain
1669 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1670 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1671 gdcmSerie to gdcmDicomDirSerie
1673 2004-03-19 Jean-Pierre Roux
1674 * ENH Now the tree-like structure describing a DICOMDIR comming from
1675 an already existing DICOMDIR file is consistent with
1676 the home-made tree-like structure build ex-nihilo
1677 or build from the files held (recursively) in a Directory
1678 functions gdcmDicomDir::CheckBoundaries()
1679 gdcmObject::SetBoundaries() added
1681 2004-03-17 Jean-Pierre Roux
1682 * REM (Eric Boix bug) : removal of meaningless
1683 gdcmDicomDirImage::NewImage function.
1684 * FIX now file names and directory name are written properly in the
1686 * FIX now gdcmDicomDir constructor may be call without any trick
1689 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1690 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1691 of gdcmDicomDirImage::NewImage as empty function.
1693 2004-02-28 Jean-Pierre Roux
1694 * ENH add gdcmDicomDir:NewPatient
1695 add gdcmDicomDirPatient:NewStudy
1696 add gdcmDicomDirStudy:NewSerie
1697 add gdcmDicomDirSerie:NewImage
1698 to allow making gdcDicomDir object.
1699 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1700 (as opposite to the gdcmHeader chained list)
1702 2004-02-11 Benoit Regrain
1703 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1704 when using from python
1706 2004-02-10 Benoit Regrain
1707 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1708 * FIX : in gdcmDicomDir when the directory is empty
1709 * ENH : add callback and methods to get the progression of dicomDir
1712 2004-02-06 Jean-Pierre Roux
1713 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1714 - GDCM_META added to gdcmDicomDirType
1715 - class gdcmMeta created
1716 * ENH : - A brief summary is now displayed at the beginning of
1717 'testDicomDir' to help disaster magnitude estimation
1718 * REM : Now useless Test/explDICOMDIR.cxx
1720 2004-02-05 Benoit Regrain
1721 * ENH : add methods in gdcmObject to get the hash table or the list of
1723 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1724 * FIX : wrapping python for TagHeaderEntryHT
1726 2004-02-04 Benoit Regrain
1727 * FIX : even length for some strings when writting the dicom dir
1728 * FIX : sort the images in the dicom dir
1729 * FIX : Bug fix for python use of dicom dir
1730 * ADD : a python demo
1732 2004-02-04 Jean-Pierre Roux
1733 * FIX : Final solution (?) for icone embedded images
1734 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1735 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1736 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1737 gdcmData/gdcm-MR-SIEMENS-16.acr1
1738 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1739 to make full checking easier
1741 2004-02-04 Benoit Regrain
1742 * FIX : WriteEntries : coding style & logic in parameters
1743 * FIX : Set the elements to create the DicomDir in a dictionary file
1745 2004-02-03 Benoit Regrain
1746 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1747 * gdcmDicomDir : add the load of directory
1748 * Bug fix and print add-on
1750 2004-02-03 Jean-Pierre Roux
1751 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1752 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1753 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1754 * FIX gdcmParser.cxx : 'group length' elements are now considered
1755 as integers, even for shadow groups, when file is Implicit VR
1757 2004-02-02 Jean-Pierre Roux
1758 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1760 of the last synonym :-(
1761 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1763 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1764 * FIX taking into account the possible 7fe0,0010 multiplicity
1765 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1766 to allow removal of references to 7fe0,0010, to deal with
1767 ACR-NEMA images, when 0028,0200 is meaningfull
1769 2004-01-31 Jean-Pierre Roux
1770 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1771 no longer writes 'Un' on disk
1772 * FIX SQ elements with actual length are now dealt with corectly
1773 * FIX gdcmFile::WriteBase make the difference, for color images, between
1774 the length (for Palette expanded images)
1775 and Raw Length (non expanded image + Palette)
1776 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1777 (that broke Write). Replaced by UL.
1778 Aware user will reload the field if he
1779 thinks it's necesssary
1781 2004-01-30 Jean-Pierre Roux
1782 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1783 when 'dirty Acr' is found, to be compliant with the new
1784 IsReadable() methods.
1786 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1787 (no DOUBLE images in kosher DICOM,
1788 but so usefull for people that miss them ;-)
1790 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1791 DICOMDIR related utilities (not checked as Windoze compliant)
1793 2004-01-28 Jean-Pierre Roux
1794 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1796 2004-01-27 Jean-Pierre Roux
1797 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1798 to allow skipping the shadow elements, to save memory space.
1799 The TRUE value for this param has to be used
1800 with a FALSE value for the 'enable_sequence' param.
1801 ('public elements' may be embedded in 'shadow Sequences')
1802 * gdcmHeader methods now deal with 'embedded icones images' in the header
1803 (even when an 'icone image sequence' is announced by the
1804 element (0x0088,0x0200), but there is NO icone at all ...
1806 * gdcmHeader sometimes Image Location value doesn't follow
1807 the supposed processor endianity (see gdcmData/cr172241.dcm).
1810 * gdcmHeader add the method
1811 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1812 to get *all* the Header Entries with the same tag.
1813 GetHeaderEntrySameName is probabely *useless*
1814 (no meaning : Name is *not* an identifier within the Dictionnary)
1816 2004-01-26 Benoit Regrain
1817 * Bug fix in the print of hexadecimal representations. Remove long fields
1818 in the print and add a third level of print to print them
1820 2004-01-23 Benoit Regrain
1821 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1822 * Bug fix on test suite after remove the strip made on not string fields
1823 * Split the IsReadable method between gdcmParser which test that the file
1824 is dicom and gdcmHeader which test that it's an image file
1826 2004-01-22 Benoit Regrain
1827 * DicomDir : clean code, add methods, set variables in protected or private
1828 * gdcmUtil : bug fix for the clean string method
1830 2004-01-19 Benoit Regrain
1831 * Add the use of shadow dictionaries
1832 * bug fix and coding style
1834 2004-01-19 Benoit Regrain
1835 * src/gdcmFile.cxx : bug fix concerning the close of file
1836 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1837 * Add the update of header entries using the shadow library
1839 2004-01-19 Benoit Regrain
1840 * removal of file gdcmHeader2.cxx
1841 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1842 inheriting from gdcmParser. This split is to prepare the integration
1843 of dicom dir parsing
1844 * bug fix under python
1846 2004-01-16 Jean-Pierre Roux
1847 * REM removal of class gdcmHeaderEntrySet
1848 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1849 * ADD add file gdcmHeader2.cxx
1850 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1852 2004-01-15 Benoit Regrain
1853 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1854 entries created while parsing the header. Thus, they will be destroyed
1855 when the gdcmDictSet will be destroyed
1856 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1859 2004-01-15 Benoit Regrain
1860 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1861 made a fatal error because of the memory release at the end of program.
1862 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1863 some memory and vtk seems to have some problems with that.
1864 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1866 2004-01-14 Benoit Regrain
1867 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1868 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1869 * src/*.[h|cxx] : make changes due to class name changes
1870 * gdcmPython/demo/*.py : bug fix due to method names
1872 2004-01-13 Benoit Regrain
1873 * src/*.[h|cxx] : coding style
1874 * vtk/*.[h|cxx] : coding style
1876 2004-01-13 Benoit Regrain
1877 * gdcmPython/testSuite.py : test the readable flag of file for tests
1878 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1879 It's lied to the stl compilation by MSVC (windows, always windows...)
1880 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1882 2004-01-12 Benoit Regrain
1883 * src/*.h : add comments
1884 * src/gdcmDictSet.h : set the method BuildDictPath in public
1885 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1886 directly setted in the source code
1887 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1890 2004-01-09 Benoit Regrain
1891 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1892 * setup.py : use a reference to gdcmVERSION
1894 2004-01-07 Benoit Regrain
1895 * Modification to compile with the distutils.
1898 2003-12-10 Benoit Regrain
1899 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1900 can use a gdcmHeaderHelper to load data
1901 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1902 made in the source code
1904 2003-12-10 Benoit Regrain
1905 * Update Windows projects and .cvsignore files
1907 2003-11-12 Jean-Pierre Roux
1908 * ENH gdcmHeader constructor has one more parameter (default value : false)
1909 that allows the user to 'go inside' the SeQuences only
1911 gdcmElValSet:Print takes it into account
1913 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * ENH: Update gdcmPython/CMakeLists
1915 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1916 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1918 2003-11-10 Jean-Pierre Roux
1919 * FIX : gdcmHeader::LoadElements is now based
1920 on the ListTag listElem member,
1921 not longer on the TagElValueHT tagHt member
1922 * ENH : PrintPubElVal shows (temporarily) both results,
1923 with the tagHt member and the listElem member.
1924 (it's easier to 'see' the problems when using Printheader)
1926 * FIX : old private member LgrElem is now splitted into
1927 ReadLength : Length actually found on disk (updated only
1928 if bug fixing is necessary), for internal
1930 UsableLength : Updated by FixFoundLength, to fix a bug
1931 or to allow Parser going on.
1932 Will allow to re-write a kosher header when a SeQuence
1933 with a length (not 0000) is found
1934 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1935 because gdcmElValSet::Add does not update ListElem
1938 2003-11-07 Jean-Pierre Roux
1939 * FIX misstyping in Transfert Syntax name table
1940 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1941 when they have an actual length (not 0000 nor FFFFF)
1942 (Nobody should care of it, but DICOMDIR explorers)
1944 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1945 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1947 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * ENH: vtkGdcmReader now supports LUT !
1949 (vtkgdcmViewer for now is not able to use them though)
1951 2003-11-05 Jean-Pierre Roux
1952 * in testSuite.py : new files names for checking the package
1953 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1954 that returns the pixel area size to the *aware* (vtk) user
1955 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1957 2003-11-05 Benoit Regrain
1958 * in testSuite.py : Modify the rules for checking the paths
1959 : Explicit error messages
1960 * in __init__.py : Related modif
1962 2003-11-03 Jean-Pierre Roux
1963 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1964 to be used by aware (vtk) users that want to manage
1965 LUT (and no to turn the PALETTE image into an RGB pixels one)
1966 * GetPixelType now returns 8U for 24 Bits images
1967 (vtkGdcmReader compliant)
1969 2003-10-31 Jean-Pierre Roux
1970 * Removal of *all* gdcmData images and add them again
1971 in order to loose the 'history' of un-anonymised images
1973 2003-10-31 Jean-Pierre Roux
1974 * RMV : removal of useless jBitsInJsample.h
1975 for both 8 and 12 Bits JPEG Lossy Libraries
1977 2003-10-31 Jean-Pierre Roux
1978 * ENH : Add the functions gdcmFile::GetImageDataRaw
1979 gdcmFile::GetImageDataIntoVectorRaw
1980 that act as GetImageData and GetImageDataIntoVector
1981 except the making of an RGB Plane from Gray Plane + LUT
1982 Intended to aware (vtk) users who know how to manage
1985 GetLUTRGBA return a R,G,B,A LUT if any
1986 lgrTotaleRaw gives the 'Raw' length
1987 GetImageDataRaw returns the gray Plane
1988 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1989 (They stay Grey, just like with other Dicom viewers :-(
1991 2003-10-30 Jean-Pierre Roux
1992 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1994 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1996 being coherents dicom files.
1998 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2001 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2002 * ENH: Two steps is necessary to please VC++ compiler...
2003 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2004 * ENH: Add include dir to medcon lib
2005 * FIX: only one function is being exported for now !
2006 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2008 2003-10-29 Jean-Pierre Roux
2009 * adding gdcmHeader::GetLUTRGBA
2010 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2011 --> Mathieu, the modif u're waiting for is not yet committed
2012 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2014 2003-10-27 Jean-Pierre Roux
2015 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2016 00191113.dcm DermaColorLossLess.dcm
2017 MxTwinLossLess.dcm RadBWLossLess.dcm
2018 * ENH: For version prior to vtkImageViewer2 -r 1.19
2019 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2021 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * Removal of ido stuff in CMakeLists.txt
2024 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2025 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2026 * FIX: remove a call to ->Modified ... see comments
2027 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2029 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * FIX: Problem with path for libvtkgdcmPython
2031 * ENH: Try adding a search script for python site-package
2032 * RMV: Remove some file from medcon lib that are not necessary
2033 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2034 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2035 * FIX: More pragma disable fro VC++,
2036 I don't think I break something as it is also disable in VTK/ITK.
2037 But it fasten debug compilation time.
2039 2003-10-23 Jean-Pierre Roux
2040 * gdcm now deals with 16 Bits Run Length Encoded images
2041 (they are compressed as 2 planes images,
2042 one for the high Bytes, the other for low Bytes)
2044 2003-10-22 Jean-Pierre Roux
2045 * Now CheckRead takes into account :
2046 - the bugged 'Leonardo' Siemens images
2047 - the XA images, sent thru the burning VPRO station
2048 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2051 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2052 * FIX: When copying a Makefile.am to CMakeLists.txt
2053 one should remove the '\'
2055 2003-10-22 Jean-Pierre Roux
2056 * in gdcmData adding a bugged 'Leonardo' Siemens image
2057 (wrong lengths in header)
2058 OK with gdcm, KO with the other viewers :-)
2059 * add a GE dlx XA image, thru the VEPRO burning station
2062 2003-10-21 Jean-Pierre Roux
2063 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2064 for a brutal checking of vtkgdcmViewer compliance
2066 2003-10-21 Jean-Pierre Roux
2067 * add the files for 'xmedcon' Jpeg Lossless library
2068 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2070 2003-10-21 Jean-Pierre Roux
2071 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2073 2003-10-21 Jean-Pierre Roux
2074 * garbage Siemens 'Leonardo' images dealt with
2075 (the patch is easy to remove)
2076 * cosmetic changes to avoid warnings
2078 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2080 no need to press 'r' now.
2082 2003-10-20 Jean-Pierre Roux
2083 * upgrade of checkRead.sh checkWrite.sh according
2084 to new Jpeg Lossless decompressor
2085 * add US.3405.1.dcm, a genuine RGB medical file ...
2086 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2087 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2089 2003-10-15 Jean-Pierre Roux
2090 * general anonymisation in gdcmData
2091 * adding the 'color files' from
2092 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2093 * adding some well knowed bugged-header images
2094 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2095 waiting for their inclusion in Python testsuite
2097 2003-10-15 Jean-Pierre Roux
2098 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2099 no longer seg faults when file is not found
2101 2003-10-14 Jean-Pierre Roux
2102 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2105 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2106 * TODO: *.in file to genereate a UseGDCM later
2108 2003-10-14 Jean-Pierre Roux
2109 * Some supposed-to-be Dicom Images have no preamble.
2110 OpenFile takes it into account
2111 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2112 * Missing elements added in dicomV3.dic
2113 (just to be affraid : have a look at
2114 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2115 and do it again next year ;->
2117 2003-10-13 Jean-Pierre Roux
2118 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2119 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2120 But there are NOT. It's fixed !
2122 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2123 * FIX: "jpeglib.h" was not found on VC++
2124 * FIX: vtkgdcm was not being installed
2126 2003-10-10 Jean-Pierre Roux
2127 * ENH : OpenFile closes the file if it *really* doesn't look like
2128 an ACR-NEMA / DICOM one.
2129 * FIX : testWrite no longer writes an empty file if the source file
2130 is not gdcm Readable
2131 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2134 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2135 * FIX: CMake generate now documentation
2136 * ENH: out of source doc build !
2137 * ENH: Generate both user and dev documentation
2138 * ENH: Should work on windows too
2139 * ENH: Only one doxygen config.in file is needed
2140 * FIX: make install should be ok now on ùnix plateform
2141 * FIX: PATH to dictionary was wrong (missing /)
2142 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2144 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * vtkGdcmReader is now able to read rgb dicom file.
2146 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2147 * added a gdcmViewer to vtk test, use mouse to control
2148 window level & window width
2150 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2151 * CMake-ification of gdcm, we have now two build system
2152 * FIX: on cygwin Wsock32 doesn't exist
2153 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2155 2003-10-06 Emanuel Ollart
2156 * FIX : compilation process wad broken.
2157 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2159 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * change gdcmViewer -> vtkgdcmViewer
2161 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2163 2003-10-06 Jean-Pierre Roux
2164 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2165 ( e.g : well known GE images with a wrong elem length,
2166 : Philips MRI Images with a wrong Huffman table)
2167 * still to be done : allow the reading of bugged LEONARDO Siemens images
2169 2003-10-03 Jean-Pierre Roux
2170 * Odd length strings are padded with '\0' (not with spaces,
2171 to remain compliant with already defined strings,
2172 like Transfert Syntax UID and others)
2174 2003-10-03 Jean-Pierre Roux
2175 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2176 to allow displaying RGB images (not only by affim ;-)
2178 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * vtkGdcmReader is now able to read rgb dicom file.
2180 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2182 2003-10-03 Jean-Pierre Roux
2183 * A few nasty patches to allow the reading of a lot of nasty images
2184 ( e.g : well known GE images with a wrong elem length,
2185 : Philips MRI Images with a wrong Huffman table)
2186 * still to be done : allow the reading of bugged LEONARDO Siemens images
2188 2003-10-03 Jean-Pierre Roux
2189 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2191 2003-10-03 Jean-Pierre Roux
2192 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2193 to allow displaying RGB images (not only by affim ;-)
2195 2003-10-03 Jean-Pierre Roux
2196 * gdcmFile::GetImageDataIntoVector now
2197 - deals with MultiFrames MultiFragments Run Length Encoded files
2198 - deals with YcBcR (YBR_FULL) files
2199 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2200 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2202 (no sample found :-(
2204 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2205 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2206 Two reasons: - clear things
2207 - third parties acces gdcm through header files, so won't
2208 suffer anymore VC++ complains
2210 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2211 * add argv[1] in testvtkGdcmReader.cxx
2214 2003-09-24 Jean-Pierre Roux
2215 * The lines are now eigthy characters long.for
2216 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2218 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2219 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2220 char* to std::string. Thus, the use of strdup becomes useless. (see
2221 previous commis of Malaterre)
2222 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2223 before the last Malaterre's commit.
2225 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * This commit should fix the Debug building under VC++, the problem
2227 was mainly a mixture of debug and release lib being loaded at startup.
2228 * I also remove a depency to a specific C function: strdup. Because I had
2229 to force the link to msvcrtd (whereas strdup is in libc).
2231 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2232 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2233 located in the gdcmCommon.h file. All use of reference of tha has been
2234 changed to now use the variable GDCM_UNFOUND.
2236 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2238 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2239 Dicom dictionary. The test suite can now be run again. Note:
2240 I'm note very happy with the " (RET)" changes. I believe this
2241 RETAINED comment should be dropped when parsing the dictionary.
2242 - PACKAGER corrected
2244 - AUTHORS updated and now in alphabetical order
2245 * Makefile.am now exports gdcm.dsw for Windoze users.
2247 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2248 * cygwin complains about missing std:: in subdir Test/
2250 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * remove some methods that are now in gdcmHeaderHelper
2253 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2254 * vtkGdcmReader set spacing and origin correctly
2256 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2257 * Fix a few delete/delete[] mismatch
2259 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2260 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2261 interpretation to data given by gdcmHeader. For instance there are
2262 heuristics to get informations (look at different places).
2263 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2264 sorting DICOM images based on different strategies.
2265 * modified Makefiles accordingly.
2267 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2269 when building in debug mode
2270 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2271 src/win32/gdcmdll.dsp
2272 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2274 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2278 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * src/win32/libgdcmjpeg12.dsp was not dos format
2280 * src/win32/libgdcmjpeg12.dsp :
2281 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2282 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2284 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2285 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2287 * src/gdcmFile.cxx : bug fix in affectation type
2288 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2289 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2290 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2291 symbols... future problem ?
2293 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * src/win32/libgdcmijpeg12.dsp was missing
2295 * modified gdcm.dsw accordingly
2297 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2298 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2300 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2301 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2302 commit of JPR (before his hollidays to facilitate our work).
2303 * setup.py : bug fix in code. Modifications made while the last commit
2304 of JPR. The code hasn't been tested before the commit... it's so
2305 useless to make that (for best programmer that is JPR) !!!
2307 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * tagged the current version as Version0_3 (i.e. version 0.3)
2310 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2311 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2312 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2313 * *.dsp : modifications to use new libgdcmijpeg8 library
2314 * setup.py : bug fix on VTKPATH variable
2315 * PACKAGER : adding all concerning windows
2317 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2320 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2321 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2322 test suite reported error.
2323 * PACKAGER file added (describes what a packager must do when
2324 packaging a new release).
2325 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2326 * configure.in: upgraded version number to 0.3.0
2327 * fixing build of rpm (through rpm -ta):
2328 - Doc/Makefile.am exports proper doxygen files
2329 - src/jpeg/libijg8/Makefile.am exports the include files.
2331 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2333 * src/gdcmHeader.h : formatting code
2335 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2336 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2337 We were obtaining error message from vtk. Now, creation of file list
2338 is made in an internal list to prevent this problem.
2339 Bug fix when output is empty.
2340 Bug fix in update of progress value. Previous commit for this was a bad
2342 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2344 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2345 * src/gdcmHeader.h : added method to get the file name
2346 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2347 files. Added method to remove all files on the input
2348 Added FIXME comment concerning the bad parsing of header made by
2349 ExecuteInformation method (in ExecuteData method)
2351 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2353 when using make instal.
2354 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2355 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2357 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * setup.py : adding include dir of jpeg lib to compile all sources
2359 * */Win32/*.dsp : JPR fix for windows compilation
2361 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2362 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2364 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2365 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2367 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * setup.py is again effective on un*x (takes into account the
2369 addon of the jpeg library)
2370 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2371 * Doc/Doxy* updated (includes above enhancements)
2372 * INSTALL now points to web documentation
2374 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * src/gdcmHeader.h doesn't make unnecessary reference to
2377 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2379 * src/gdcm*.[cxx|h] :
2380 - to allow compilation with gcc 3.x
2381 -- clean up of STL usage (added explicit usage of std::)
2382 -- small fixes on exceptions.
2383 Note: linking not tested !
2384 - clean of doxygen comments to avoid warnings at documentation
2386 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2387 dependent convertion).
2389 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2390 * Clean up of previous JPR garbage commit (not even commented in the
2392 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2393 - moved all jpeg related files from src to src/jpeg/libijg8, with
2394 addition/modification of Makefile.am and configure.in.
2395 - the testSuite is still brain damage (not guilty).
2397 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * WrapVTK.py : modifications to get correctly vtk source files to
2400 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2401 (FileName -> Filename)
2403 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * vtk/vtkGdcmReader.[cxx/h]:
2405 - UpdateProgress method should now be effective
2406 - removed the limitation on having only images loaded (as opposed
2408 - when building a stack of images/volume, a lesser number of
2409 gdcmHeader and gdcmFile instances should be used (hopefully
2410 accelerating things).
2411 - when building a stack of images/volumes, files which are not
2412 loadable (wrong path-filename, wrong permissions on existing file,
2413 or file not parsable by gdcm) are replaced with a black image
2414 in the stack (for the caller to notice the problem).
2416 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2419 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2420 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2421 between standard library (std) and vtk library (problems are found
2422 under Windows... thanks Windows !)
2424 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2427 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2429 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2432 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * When compiling with distutils (see setup.py) the C++ compiler is
2434 called with different flags than the default ones (with automake).
2435 In order to fix all those warning, I compiled gdcm with the command
2436 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2437 and went for warning fixes:
2438 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2439 up from unused variables.
2440 - vtk/vtkGdcmReader.cxx: potential bug fix.
2441 * src/gdcmHeader.h: Doxygen warning cleanup
2443 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * gdcmPython/gdcm.i:
2445 - typemaps correction to take into account the systematic replacement
2446 of "using namespace std" with std:: prefix e.g. std::list,
2447 std::string... (cf changes of 2003-05-21).
2448 - gdcmGlob global variable of type gdcmGlobal (defined in
2449 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2450 exported to Python a as cvar.
2451 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2452 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2453 gdcmDictSet.GetPubDictTagNames() and
2454 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2455 C++ static methods).
2456 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2457 with the above changes.
2459 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * setup.py, manifest.in : bug fix under linux
2462 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2463 * Modification of setup.py to compile vtk part too. Then, we have 2
2464 wrappers which must work with same distutils. For that, we have a
2465 generic distutils in distusiltsWrapping.py ; with :
2466 - build_extWrap class to wrap generically all extensions,
2467 - ExtensionWrap base class for all wrapping extension that contains
2469 - Wrapper interface which wrap sources
2470 + In WrapSwig.py we have extension and wrapper for Swig
2471 + In WrapVTK.py we have extension and wrapper for VTK
2472 * MANIFEST.in : modifications to consider vtk directory and new python
2473 files for compilation
2475 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2476 * Added python wrappers of vtkGdcmReader vtk class (see the
2477 source in vtk/vtkGdcmReader.cxx) :
2478 - vtk/Makefile.am now builds a library
2479 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2480 python library (as opposed to _gdcm.so wich are the python
2481 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2482 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2484 - configure.in has an additional flag --enable-vtk that needs
2485 to be set to enable compilation of vtk related code, that is:
2486 + vtk/vtkGdcmReader.so and
2487 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2488 + gdcmPython/vtkgdcmPython.so (see above)
2489 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2490 be read when compressed or when HighBit + 1 != BitsStored),
2491 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2492 the usage of the python wrapper of vtkGdcmReader vtk class.
2493 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2494 * src/*.[h] all occurences of stl classes are now prefixed with
2495 std::, and all occurences of "using namespace std;" where removed.
2496 This is to avoid pollution of global namespace in included files.
2497 Apparently vtk does not avoid this pitfall: when using both
2498 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2499 collision of various stl members (principally cout...).
2500 * gdcmPython/testSuite.py now cleanly removes temprory generated
2502 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2503 comply with above changes)
2505 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2506 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2507 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2508 vtk data structure (an image Flip was required).
2509 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2510 * cosmetic changes in documentation.
2512 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2513 * src/gdcmHeader.cxx: the constructor no longer exits when an
2514 unexisting file is given as argument.
2515 * The subdirectory Data (containing all the images used for the
2516 test suite) is not part of this repository anymore. A new module
2517 containing those images is now available at
2518 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2519 with the name gdcmData.
2520 All the python scripts (including the package initialisation file
2521 gdcmPython/__init__.py) were adapated to take this change into
2522 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2524 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2525 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2526 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2527 demo of the usage of this class.
2528 Compilation of this vtk part is only done when using the --enable-vtk
2529 at configure (or autogen.sh) stage.
2531 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2532 * More memory link related corrections and documentation fixes.
2534 - maximum info is obtained with a command of the form:
2535 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2536 --show-reachable=yes PrintHeader
2537 - the remaining reachable blocks seem to come from the STL
2538 allocation scheme through the usage of map and list. It looks
2539 like this memory cannot be freed but it is not a memory leak
2540 (in fact further invocation to the STL would recollect the
2541 unused memory allthough it cannot explicitely be freed).
2542 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2543 of displaying an image parsed with gdcm and displayed with VTK.
2544 Note: some images don't seem to work e.g.
2545 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2546 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2547 Allthough this weakens the semantics, it is a ditch attempt to
2548 make gdcm more thread friendly.
2550 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2551 * Memory link hunt (by using valgrind through the command
2552 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2553 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2554 gdcmHeader::_dicom_vr.
2555 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2556 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2558 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2560 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2561 * src/Makefile.am now exports all the necessary include files at
2565 * UpdateGroupLength replaced by new one
2568 * UpdateGroupLength re-written using H-Table
2569 (named UpdateGroupLengthNew untill checks are over)
2571 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2572 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2573 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2575 - gdcmHeader::GetPubElValSet removed.
2576 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2577 UpdateGroupLength, WriteElements, Write.
2578 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2579 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2580 carried the same semantics.
2581 - src/gdcmHeaderIdo.cxx changed accordingly.
2582 - gdcmFile::WriteBase now regroups all the codes from previous
2583 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2584 - enum FileType moved to gdcmCommon.h
2585 * src/gdcmHeader.cxx AddDefault trashed
2586 * gdcmGetXSize added
2587 * getimageDataSize now calls gdcmGetXSize
2588 * Test/*.cxx changed to agree with above changes
2590 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2592 (to avoid double call by end user).
2593 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2594 by end user, since gdcmHeader::gdcmHeader now handles it.
2596 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2597 * gdcm/Doc many doxygen changes:
2598 - Doxyfile now has two different versions, DoxyfileUsers that generates
2599 the html.users end users oriented documentation and
2600 DoxyfileDeveloppers that generates the html.developper developper
2601 oriented documentation.
2602 - README changed accordingly
2603 - requirement.txt removed (old design info moved to TODO).
2604 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2605 DoxyMainPage.txt, DoxyPython.txt provide more information.
2606 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2607 be updated by simply regenerating the docs with doxygen and copying
2608 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2609 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2610 all the tests in the form "if (<map>.count() >1)" were removed.
2611 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2612 ill-formed documentation sections.
2613 * src/gdcmHeader.cxx: ditto
2615 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * setup.py fixed for un*x (needed macro for stdint.h)
2617 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2618 un*ces with sh-utils test utility.
2619 * gdcmPython/demo/test.py renamed to PrintHeader.py
2620 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2621 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2622 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2623 * src/gdcm*.cxx JPR's bad inclusion fixed.
2625 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2626 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2627 * gdcmPython/demo/test.py changed accordingly.
2629 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * gdcmPython/Makefile.am fixed linking against libstdc++
2631 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2632 * Swig subdir (historical tests of swig version 1.3.17++) removed
2633 * Test/testChangeEntete.cxx some lines commented out in order to make
2635 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2636 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2638 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2639 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2640 hence the user doesn't need this explicit call.
2641 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2642 i.e. LoadElements() call removed.
2643 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2644 - src/Makefile.am declares the proper flag for g++.
2645 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2646 for adding user defined new tags.
2647 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2648 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2649 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2651 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2652 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2653 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2654 src/Makefile.am : the project should properly compile and install
2655 with the autotools, included the python wrappers part.
2656 * gdcm.spec.in : added a spec file for RPM packaging.
2658 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2659 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2661 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2663 to exported to the environement (see gdcmPython/testSuite.py
2665 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2666 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2667 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2668 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2669 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2671 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * gdcmPython/__init__.py doesn't crash anymore when running in
2673 in InstallMode or PreInstallMode but with an environement given
2674 value of GDCM_DICT_PATH.
2675 * src/gdcmDictSet.[cxx/h] coding style.
2677 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2679 * src/gdcm.h general comments moved to TODO, and README
2680 * src/gdcm.h should now be seen as a user commodity (including it
2681 should suffice to fully use gdcm). It is nowhere including within
2682 any of the kernel files src/*.cxx and src/*.h.
2684 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2686 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2688 * src/gdcm*.cxx only include their corresponding include file
2689 (as opposed to gdcm.h)
2690 * gdcmPython/gdcm.i changed accordingly
2691 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2692 the autogen.sh generated "make snapshot" command to work.
2693 * autogen.sh removed history related references to crea package.
2695 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * distutilsSwigCPlusPlus.py work around some swig portability
2699 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2701 was done in a last ditch attempt to get setup.py _really_
2702 operationnal. The python/gdcmPython layaout add the advantage
2703 of hidding away the python related distutils specific files
2704 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2705 Alas, the src directory was out of scope (i.e. it's relative
2706 position to setup.py was ../src) which made things impossible to
2707 handle (see previous version of python/setup.py). Crossing fingers...
2709 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2710 * python/setup.py now works on Un*x. (harder than I thougth)
2711 * python/distutilsSwigCPlusPlus.py can now have include files
2712 among the list of sources.
2714 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2715 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2716 * modifications in MSVC projects
2718 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * As stated by the first lines of Test/ExceptionAndPython/README, it
2720 looks like we can move back to original usage of exception within
2721 src/gdcm* and hence remove the errno stuff that was introduced
2722 as a quick and dirty fixture of this problem (added to the TODO).
2723 * Doc/Doxyfile configuration file for Doxygen and corresponding
2724 README file for usage added.
2725 * Test/testWrite.cxx added. This new test comes from a split of
2726 test.cxx that is now reverted to its original purpous i.e.
2727 testing the proper parsing of a Dicom related file.
2728 testWrite.cxx concentrates on testing the IO part of gdcm.
2729 * Test/bug1.cxx (containing a bug on WIn32) added.
2730 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2731 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2732 whose purpose is to publish the content of the TagNames of the
2733 Dicom public dictionnary were not accessible without an
2734 instance of class gdcmHeader.
2735 - those methods are now static methods of gdcmDictSet and hence
2736 require no instances at all to be invocated.
2737 - within gdcmDictSet this change required to change some method
2738 to class methods (i.e. are now static) among which SetDictPath
2739 (renamed to BuildDictPath) and LoadDefaultPubDict.
2740 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2741 the above changes by calling the new method classes of gdcmDictSet.
2742 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2743 the above to be effective.
2744 * python/gdcmPython: in order to wrap properly the above changes
2745 for Python, swig version now needs to be > 1.3.17.
2746 * python/gdcmPython/Makefile fixed to adapt itself to new
2747 configure/make shema introduced by Johan Montagnat (thanks for the
2748 contribution). Alas this Makefile cannot be turned into a proper
2749 Makefile.am without some heavy changes in the configure.in
2750 (for python dectection).
2751 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2752 now avoids publishing the empty entries.
2754 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * python/setup.py : bug fix concerning install under windows
2756 ExtraPath reused :-P
2757 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2759 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2760 * Dicts/dicomV3.dic : remove double spaces !!!
2761 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2762 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2765 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2767 method. Doxygenation.
2768 * src/gdcm.h clean up of JPR spurious comments.
2770 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * python/distutilsSwigCPlusPlus.py now properly collects the
2772 shadow classes generated by "swig -c++" (gdcm.py in our case)
2773 when using "python setup.py install".
2774 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2775 reexports the working classes.
2776 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2777 by the classical C errno scheme. This is to prevent an obscure
2778 behavior of the python wrappers when importing wxPython.wx prior
2779 to gdcmPython (which ended up in an abort call). An illustration
2780 of this oddity can be found in the Test/ExceptionAndPython
2781 subdir (see the README file). This problem probably due to
2782 an combination of g++ and dynamic loading.
2783 * added Test/ExceptionAndPython (see above)
2785 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * Changed the layout of the python part to avoid bloating main
2787 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2788 i.e. the distutils arsenal. All the python related stuff is
2789 again in a python subdir, but the package itself is now in
2791 * setup.py was cleaned up:
2792 - pythonIncludePath removed
2793 - python setup.py bdist target is now functional.
2794 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2795 collision with other packages). gdcmPython/demo/*.py changed
2798 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * python subdir moved to gdcmPython (preparation of distutils packaging).
2800 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2801 distutils installer is operational.
2802 * - gdcmPython/__init__.py now properly loads the swig generated
2803 shadow classes (from gdcm.py).
2804 - gdcmPython/demo/*.py changed to import the package gdcmPython
2805 instead of gdcmPython/demo/load.py.
2806 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2808 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2810 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2811 entries within the associated public Dicom dictionary resp. the same
2812 information but sorted by the fourth field (PAT, IMG, DIR) of the
2814 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2815 are now in the "???" group.
2816 - python/gdcm.i changed accordingly,
2817 - python/demo/printGroupedPublicDict.py added, that gives an example
2818 of the above new functionalities in Python.
2820 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * src/gdcm.h, gdcmHeader.cxx:
2822 - historic references to glib's g_malloc and g_free (#defined)
2823 were definitively removed.
2824 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2825 * src/gdcmElValSet.cxx:
2826 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2827 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2828 - GetElValue(string) renamed to GetElValueByName.
2829 - Added GetElementByName(string).
2830 * src/gdcmHeader.cxx: added
2831 - GetPubElValRepByNumber(guint16, guint16)
2832 - GetPubElValRepByName(string)
2833 - GetShaElValRepByNumber(guint16, guint16)
2834 - GetShaElValRepByName(string)
2835 - GetShaElValByNumber(guint16, guint16)
2836 - GetShaElValRepByName(string)
2837 - GetElValRepByNumber(guint16, guint16)
2838 - GetElValRepByName(string)
2839 - GetElValByNumber(guint16, guint16)
2840 - GetElValRepByName(string)
2841 * Doc/requirements.txt added.
2843 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * Test/Makefile building now depends on the one of libgdcm.so
2845 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2846 pixel data) aware which enables finding the address (offset) of
2847 the pixel data of JPEG encoded DICOM files. This leaves only a single
2848 file in the testSuite whose pixel data address (offset) is unknown.
2849 * python/testSuite.py changed accordingly.
2851 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2852 * VC++ has some strong limitations when working with the STL, as stated
2853 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2854 "Also note that some STL containers (map, set, queue, list, deque)
2855 cannot be exported. [...]
2856 Some STL classes contain nested classes. These classes can not
2858 This is caused by a designed limitation that once a template
2859 class is instantiated, it can not be re-instantiated and
2861 Since our usage of map<> is ubiquitous in gdcm, this "designed
2862 limitation" of VC++ is a pitfall.
2863 Hence the Python wrappers of gdcm cannot be incrementally linked
2864 against the c++ dynamic library. The dirty but only workaround is
2865 to forget about incremental link of dynamic libraries and to generate
2866 the Python wrappers library with the inclusions of the underlying C++
2868 The following modifications concern this matter on Win32/VC++:
2869 - wrapping python correct with standalone wrapped dll (don't use separate
2870 dll under windows !!!!)
2871 - python21_d debug mode enabled (ask Frog how to use it :-)
2872 - NO problem with having an STL member of class for example string in C++
2873 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2874 - Python test of dcmlib in Python is ok under windows on a large set
2876 * removed glib references
2877 * typedef's inserted in gdcm.i for correct swig type management
2879 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * python/demo/*.py load.py extracted from test.py. Added explore.py
2881 that only displays required tags and testAll.py that parses all
2882 the files of the testsuite without using unittest.
2883 * python/testSuite.py other additional test on new files added.
2884 * Data/* new test files added accordingly to the testSuite.
2885 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2886 the vr in the file differs from the one of the dictionary.
2888 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2890 values, but limits itself to values which are below a user specified
2891 size (by default 1024 bytes).
2892 * python/gdcm.i : elements not loaded (because their size is above the
2893 user specified treshold) are exported with their TagKey as key of the
2894 python dictionary. This enables the testsuite to make some checks
2895 on the unloaded elements (since we have their offset and size).
2896 * python/testSuite.py
2897 - now tests for the existence and proper value of the pixel data
2898 - two new examples added.
2899 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2901 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2902 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2903 aware. See the strategy comments in gdcmHeader::FindeLength().
2904 * Test/test.cxx now accepts a filename as first argument.
2905 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2906 * python/testSuite.py changed to integrate test on above files.
2908 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2909 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2910 the vr was also RET.
2911 * python/testSuite.py more tests added.
2913 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2914 * python/testSuite.py unittest test suite added (uses Data)
2915 * Data/* dcm and acr files for the test suite.
2916 * glib dependance removed from un*x version. We now use ISO C99
2917 7.18 Integer types (see stdint.h)
2918 - python/Makefile, src/Makefile src/gdcm.h
2919 * src/ when an explicit vr (like dicom files) suddenly poped an
2920 implicit element we use to mark the underlying DictEntry of the
2921 concerned ElValue with "Implicit". This strategy was damageable
2922 too the public or provite dictionaries, since some of their vr
2923 would be changed. Since Header::FindLength heavily relies on the
2924 detection by Header::FindVR of falsely explicit elements, I
2925 added an extra ImplicitVr member to ElValue (boolean).
2926 The rest of the changes we the necessary adaptations.
2928 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2931 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2933 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * Adaptation for porting to VC++:
2936 o forced to use std namespace (for string to be known)
2937 o all class use __declspec export style on WIN32
2938 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2939 (in stdlib.h on Win32 but in std:: for gcc)
2940 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2941 variable GDCM_DICT_PATH.
2942 * src/gdcmHeader.cxx verbose comments made discrete.
2944 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * python/gdcm.i: added a typemap that converts a C++ hashing table
2946 to native Python dictionary.
2947 * python/demo/test.py:
2948 - now uses the native dictionary for exploration of gdcmHeader.
2949 - takes an optional filename argument (the file to parse).
2950 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2951 PubElVals hashing table.
2952 * Dicts/dicomV3.dic removed error prone trailing spaces.
2954 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * Python wrapping process moved away from src/Makefile to
2956 newly created python/Makefile (as well as gdcm.i)
2957 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2958 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2959 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2960 from the environement variable GDCM_DICT_PATH (when existing).
2961 * src/gdcmDict::GetTag bug fix.
2963 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * Straightforward temporary fixes for swig to build the python wrappers.
2965 src/Makefile now has a python working entry [by working we mean
2966 that we can import de shadow classes without errors].
2968 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * hashtest.cxx removed (since already in Test)
2970 * src/gdcmlib.h renamed to src/gdcm.h
2971 * src/dcm.i renamed to src/gdcm.i
2972 * src/Makefile prepared for python wrapping
2974 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * src/gdcmHeader.cxx :
2976 - Parsing of header is now separated from loading of element values
2977 (see gdcmHeader::LoadElements).
2978 - general clean up of hopefully all file access (creation of
2979 ReadInt16 and ReadInt32)
2981 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2982 * src/gdcmHeader.cxx :
2983 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2985 - SetLgrElem renamed to SetLength
2986 - GetLgrElem renamed to GetLength
2987 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2988 * src/gdcmElValSet.cxx fixed both GetElValue methods
2989 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2990 due to IdoDude was cleaned out.
2992 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2994 concentrates on finding the value representation (when it exists).
2995 RecupLgr now only finds the element value length, and it avoids
2996 returning the unecessary skL (skipped length).
2997 Also, offsetCourant was simply removed (with taille_fich) since
2998 it was redundant with the File position internals (by using
2999 ftell and fseek). This also made skL (see above in RecupLgr) usage
3001 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3002 on the libido specificities which are handled through class
3004 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3007 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3008 * Truckload of changes. Parsing of header is barely functional
3009 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3011 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3012 * src/gdcmHeader.cxx many addons of low level methods
3014 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3016 and _IdDcmSWAP_LONG.
3018 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3019 * This corresponds to all the changes decided at the meeting of
3020 May 23 2002. Needless to say we are running late...