1 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX : remove so many friend between classes
4 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
6 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
8 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
9 In ordrer to avoid missbehaviour :
10 . gdcm::DocEntry is now specialized in
11 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
12 - gdcm::ContentEntry (Dicom entry with a 'content')
13 . gdcm::ContentEntry is specialized in
14 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
15 characters value, or integers)
16 - gdcm::BinEntry (Dicom entry with a non strig representable value
17 (user hasn't any longer to thing about the precedence of his dynamic_casts)
19 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Test/VTKTest*.cxx : bug fix under linux
22 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
24 use with python. Some methods are moved from Document to ElementSet or
25 DocEntrySet. The equivalent methods to ElementSet have been added to
26 SQItem and are virtual in DocEntrySet. Methods that may have the same code
27 in SQItem and ElementSet is directly placed in DocEntrySet
29 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Test/VTKTest*.cxx : remove the show variable in each test method because
31 it's useless (the viewer variable replace this variable)
33 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * src/gdcmDocument.cxx : bug fix on potential memory leak
35 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
36 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
37 Add ClearXxx methods to remove all the content of the list or map
38 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
40 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
41 * methods ReplaceOrCreate renamed as Insert
42 (nobody will be any longer confused by 'CreateOrReplace')
44 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Grealty simplify the JPEg decompression, no need to differenciate based on
46 the JPEG possible type (with/without fragment, with/without multiple frame).
47 Everything is done throught the JPEG IO Suspension mechanism in IJG
49 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
50 * Stage 3 of normalization :
51 in order to avoid any missunderstanding while reading method names :
52 - All the methods xxxEntry now deal with dicom Entries
53 - Methods GetEntry splitted into
56 - Method SetEntry renamed as SetEntryValue
57 - Method SetEntryBinArea let as it was
59 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
60 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
61 - Position correctly the entry points for JPEG2000 and JPEG-LS
62 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
64 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
66 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
67 with other method names
68 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
69 * Test/TestDicomDirElement.cxx : add new test
71 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
72 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
73 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
74 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
75 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
76 So can't you use __int64 in ostream at all.
78 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * bug fix for compilation on MSVC6
80 * gdcmPython/gdcm.i : rename of classes missed
82 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
83 * Stage 2 of names normalization :
84 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
85 (easy to understand ...)
86 - gdcm::FileHelper replaces old class gdcm::File
88 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
90 type and not a string. So, there remove problems on the format of the
93 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
94 * Add Example/TestPapyrus.cxx
95 - reads a Papyrus file (gdcm::Header compliant),
96 - gets the pixels of all the images, using low level iterators
97 - writes an multiframes Dicom image.
98 (Just to show it's *possible* to do that)
99 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
102 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
104 Thus, DicomDirXXX are created with a flad that indicates if the created
105 object is empty or not (when not empty, the DicomDirElement is used to
108 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
110 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
112 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
115 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
117 Remove all access to the hash-tables or lists in the objects.
119 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
121 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
122 be complient with all the gdcm source code
124 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
128 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
132 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * Test/ : rename VTK tests to have a best name for the tests
134 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
135 GetFirstEntry/GetNextEntry use
137 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
138 * In SerieHeader::ImagePositionPatientOrdering()
139 // a Dicom 'Serie' may contain scout views
140 // and images may have differents directions.
141 // -> More than one may have the same 'pos'
142 // Sorting has then NO meaning !
143 Thx to Eduardo Davila for reporting bug.
145 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
147 test. Now it's on image content and not on the resulting visualisation...
148 might solve the problem on linux when using the OpenGL drivers
150 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
151 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
152 DicomDirSerie, DicomDirImage
153 Dict, DictSet classes :
154 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
155 -remove InitTraversal method.
156 * UPD Test programs + Example programs
158 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
159 * remove useless and never updated keyword \ingroup
160 * Solve pb when structure (list, map, ...) is empty.
161 Thx to Benoit for reporting bug
163 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * Taking into account of 'Transfer Syntax' value
165 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
168 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
170 is no memory access violation
171 * gdcmPython/demo : add python demos using VTK
173 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 * FIX 'Dictionnary' is now spelt 'Dictionary'
175 'wether' is now spelt 'whether'
176 'archieve' is now spelt 'archive' ;-)
178 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
179 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
180 related methods, in order not to expose internal mechanisms
183 * REM methods that exposed internal mechanisms :
184 DicomDir::GetDicomDirPatients()
185 DicomDirPatient::GetDicomDirStudies()
186 DicomDirStudy::GetDicomDirSeries()
187 DicomDirSerie::GetDicomDirImages()
188 * UPD Test programs :
192 * UPD Example program
194 * ADD DictSet methods
198 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
199 * Removed the Print/indent/default parameter mess. There is absolutely no
200 reason to have to methods, moreover with the second taking the ostream as
201 *SECOND* parameter. This was clearly a bad hack to get things compile.
203 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Complete rewrite of the GetMacAddress code. Now the code is *much*
205 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
206 Unfortunately the main code does not work on SunOS, thus provide a specific
207 code for this platform only (and Win32 of course). Since this seems to be
208 working, change CreateUniqueUID to use GetMACAddress instead of the
209 problematic GctestetIPAddress
211 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Unfortunately to be able to test gdcmDirList I had to break the API
213 a little. Now the class is not a std::list anymore but has a member
214 std::vector (more ITK compatible). Allow unit testing on Win32 and
217 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
218 * Update SerieHeader to take into account a Serie Instance UID to properly
221 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
222 * ENH - Comment out Mathieu's (dangerous) Super Hack
223 for dealing with BIGENDIAN processors
224 - Move equivalent stuff to BinEntry::WriteContent
225 When necessary, 16 Bits Pixels are swapped in a small buffer
226 and then written. This avoid allocating a huge buffer, in
227 PixelWriteConvertor, and avoid modifying the Pixel Area.
229 Probabely, the same operation will have to be done when we want
230 to write image with Big Endian Transfert Syntax,
231 and we are working on Little Endian Processor
233 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
236 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
237 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
238 all the dict content.
239 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
241 * Test/TestDict.cxx : add a new test for the dict classes
243 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
245 file. Debug is yanked if compiled with NDEBUG
247 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDictSet.h : set the default output to the os variable
249 * src/gdcmDictEntry.[h|cxx] : add the Print method
250 * gdcmPython/demo/ : add a new test
252 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
253 * merging of Test/PrintDicomDir and Test/TestDicomDir
254 * removal of now redundant Test/PrintDicomDir
255 * enhancement of Example/PrintDicomDir
257 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * Now, python test might work on systems
259 * Add the PrintDicomDir test
261 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
262 * FIX : First entry following group 0002 was lost for
263 Explicit Big Endian Transfer Syntax files
264 (group and elem not swaped)
266 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
267 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
268 Big Endian Transfer Syntax supposed the group following 0002
269 begins always by element 0000 (element 0000 is *optional*)
270 To avoid further troubles, let's be pessimistic, and use
271 Document::HandleOutOfGroup0002() method
272 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
273 (related pb not yet solved)
275 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * Bug fix for the python part use
277 * Now, PrintHeader.py pass... but outside the ctest use. shit !
279 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
282 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
283 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
284 a string and should ask the global TS dict what are the propreties of
287 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
288 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
289 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
290 to swap the Swap Code, at parsing time, when we come out of group 0002
291 and Transfer Syntax is Big Endian
292 We should be able to read now 'true DICOM" Big Endian coded images
293 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
294 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
296 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
297 * Hopefully fix the bug on MacOSX and static global initialization.
298 This is the only -minor- patch I found that both please MacOSX and VS6.
299 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
300 but this would require a lot of change. Another approach would be that Global
301 create those string and GDCM_UNFOUND becomes a pointer to a string (which
302 gdcm::Global would destroy at exit).
304 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * Fix bug on MacOSX with static initialization in a multy threaded
306 environment. static const string in a header file used to be ill
307 initialized provoquing the freeze of any tests. patch should solve this
310 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
311 * According to Benoit's suggestion, and without any objection from anybody
312 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
313 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
314 - method gdcmDicomDirObject::GetEntry() renamed as
315 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
317 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
318 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
319 you debug/warning message just as c++ streams which make them very convinient
320 to use. Once this is stabilize I will change the ostringstrem to be
321 redirected to a file (ofstream).
322 * Properly support C99 extension: __FUNCTION__ which allow us to display
323 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
325 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
326 * Removal of useless and dangerous methods :
327 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
328 GetDocEntryByName, GetEntryByName, GetDictEntryByName
329 * Removal of usless methods :
330 Dict::PrintByName, Dict::GetDictEntryByName
331 * Commenting out of probabely useless methods :
332 Dict::GetDictEntryNames()
333 Dict::GetDictEntryNamesByCategory()
334 DictSet::GetPubDictEntryNames()
335 DictSet::GetPubDictEntryNamesByCategory()
336 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
337 * ENH : Use dicomTS.dic as described in 2004 version
338 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
339 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
340 Add Accessors on VM (Value Multiplicity), and VM related methods
341 * ADD : Add a list of 'Dicom Attribute types', as found in
342 http://medical.nema.org/dicom/2004/04_15PU.PDF
344 * ADD : Add dicomGroupNameAbbreviations.dic
345 should be used to write a method to replace the former
346 Dict::GetDictEntryNamesByCategory()
348 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
350 to read in the file... and only it ! Length is the efective length of the
351 data in the DocEntry structure
353 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
354 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
355 And now use a static function call instead, with a global variable. i
356 This is much closer to the VTK approach. Hopefully should be bulletproof
357 and easier to use...hopefully
359 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
360 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
362 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
365 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
367 ValEntry, BinEntry, SeqEntry creation or replace
369 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
371 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
373 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
374 when specifying the VR
375 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
376 * src/gdcmDocEntry.cxx : amelioration of print
378 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
379 * ADD : Add the method Util::IsCurrentProcessorBigEndian
380 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
381 * ADD Method Document::ComputeGroupLength
382 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
383 in order to allow further VR modification by user
384 * REM : removal of once-called method File::WriteBase
385 integration of its code in formerly one-line method File::Write
387 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
389 replace the different values "??", "Unkn", "Unknown".
390 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
391 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
392 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
393 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
395 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
398 * Set the gdcm::Base class to some Printable classes
400 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
401 * src/gdcmFile.[h|cxx] : add the Print method
402 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
403 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
404 * src/gdcmDocument.h : remove the PrintLevel informations
405 * Example/PrintFile.cxx : use the new gdcm::File::Print
407 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
409 problems when compiling with the python wrapping
411 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
413 writting in ImplicitVR
415 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
416 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
417 JPEG decompression, especially when dicom frames are split into several
418 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
419 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
421 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
422 * src/gdcmHeader.cxx : change the initialisation of default header.
423 Now, this header is readable by gdm, e-film, DicomWorks
425 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
427 Rename Decompressed to Raw
428 * Use the API changes in gdcm::File.
429 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
432 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
434 each added entry in the header. Replace the 'Planes' field by the 'Number
437 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
438 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
439 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
441 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
443 At this time, this image isn't readable by e-film... waiting JPR help to
446 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
448 DocEntry. Now use methods of the Document !
450 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * Test/ShowDicomSeq.cxx : bug fix
453 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
455 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
456 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
457 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
459 * Test/TestCopyRescaleDicom.cxx : remove unused variable
460 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
461 containing found sequences
463 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
466 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
467 Some fields in BinEntry must be copied to not seg fault when making the :
468 gdcm::File *copy = new gdcm::File( copyH );
469 and tests are now made on good variables
471 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
472 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
473 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
475 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
476 * Add vtkGdcmWriter example and test
478 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * Test/TestUtil.cxx : reformat the source code
480 * vtk/vtkGdcmReader.cxx : remove and change prints
481 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
483 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
484 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
486 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
488 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
490 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
492 by an eof to prevent all bad read of the file... and in this case, the
495 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * Example/Volume2Dicom.cxx : comment unused variables
497 * Test/PrintDicomDir.cxx : comment unused variables
498 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
499 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
500 method that is redondant with AddEntry.
501 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
504 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
505 * Bug fix due my last commit (compilation under Windows).
506 * Example/Volume2Dicom : bug fix in the file and reformatting source code
507 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
509 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
511 - Remove printf / sprintf
512 - include iostream AFTER gdcm so we don't get warnings
513 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
515 - Also remove tons of include from header files, hopefully this should
516 speeup the compilation time, since it was becoming a dog slow.
517 - Remove gdcm.h as it include way too many files and slow down compilation
518 (plus it is not up to date)
519 - remove 'using namespace std' this is BAD !
521 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * Remove memory leaks on the DicomDir
523 * Remove some useless data in DicomDirObject
524 * Add usefull methods in SQItem, to be complient withe the ElementSet
526 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
529 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
531 future, with convertion)
532 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
533 and ImageDataSize values. Remove the method to get the PixelReadConverter
534 from the output of the class
536 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
539 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
541 and vtkErrorMacro use.
542 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
544 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
547 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
548 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
549 The string leaves only in the fonction. So when we make a .c_str(), we
550 get the pointeur on the first element, element that will be destroyed
551 immediately after thee instruction.
552 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
553 file has been opened : the test must be made on the content of the
554 pointer and not directly on the pointer !
557 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
559 the python part recompiles
561 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
563 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
564 X session is killed (for my computer... it seems to not be identic on
567 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
569 avoid problems (otherwise, the difference test between the visible image
570 and the reference is incorrect. If the reference is greater than the
571 screen resolution, it's produce errors).
572 Can be used for only one image. Can be used with a visible flag.
573 * vtk/vtkGdcmReader.cxx : remove commented codes.
574 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
575 under windows at compilation
576 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
578 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
580 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
581 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
582 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
583 tests on the image size X, Y, Z
585 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
587 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
588 between the class name and the file name
590 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/ : fix compilation warnings for the Write method (2 different
592 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
593 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
594 variable... create a static method in gdcm::Document to access to
595 this variable content.
597 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
599 file, to be accessed by other files (like gdcmFile). Remove commented
600 code. Move the change of the header to the gdcmFile, using the
602 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
603 To be sure of that (and simplify calls), the Write of the header now
604 gets a file name and not a file pointer (std::ifstream).
605 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
606 DocEntryArchive. Remove all open of the written file
608 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
609 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
611 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
613 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
615 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
616 some corresponding methods. Write correctly the file and check before
618 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
619 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
620 is now on RGB data (as before my last commit
621 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
623 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
625 Add a print information of the type of the entry
626 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
627 It was in the gdcmFile, and all write have been regrouped
628 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
629 Write correctly all dicom files (in decompressed mode only at this time)
630 * Test/ : test on files are now made using Raw data and not color data if
632 * Example/PrintFile.cxx : add more printings
634 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * Amelioration of code, remove some code copy. For the loading of
636 BinEntry (in gdcmDocument), add the test to verify if the file is already
639 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
641 remove a DocEntry in the header (push an empty DocEntry)
642 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
643 lines. Bug fix in the initialization of the PixelConvert and the
645 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
646 use in TestCopyDicom (now this test can run under windows... but fails)
647 * Test/TestCopyDicom.cxx : amelioration of the test :
648 - test the pixels written
649 - add test points to quickly find where is the error
650 - can set a file name input and output in arguments
651 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
652 amelioration of the test output
654 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
655 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
656 all replaced DocEntry's
657 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
658 Now, each needed DocEntry to modify is duplicated, modified and inserted
659 to the header using DocEntryArchive. Thus, after save, we can restore the
660 header initial state.
662 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
665 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
667 correct to copy it. The DictEntry is specified at the DocEntry creation,
668 then, it musn't change in the time.
669 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
670 header correctly. At this time, the change is only made for the first
671 level of the Document. In the future, it might consider sequences.
672 The change is made by replacing a DocEntry by an other that is created
673 outside the class. The old value is kept. When we restore the header
674 status, the added DocEntry is deleted and replaced by the old value.
675 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
676 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
677 set the write type to explicit VR, implicit VR or ACR. Add methods to set
678 the write mode to native, decompressed or RGB (but not used at this time)
680 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
682 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
684 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
686 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
688 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
689 set because already copied when copying the BinEntry's of the header
690 * Test/TestAllReadCompareDicom.cxx : remove warnings
692 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
693 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
694 Two problems appear when doing it :
695 - with the gdcmFile : when the GetImageData method is called, the pixels
696 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
697 data (pixels). And each structure destruct the data when it's
698 destructed. So we have two destructions for the same data. To solve it,
699 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
700 data or not. If it doesn't own data, then they will not destroyed by
702 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
703 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
704 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
705 create a double destruction of the same DocEntry's. So, to solve it,
706 the TagHT is simply cleared and the DicomDir* elements are destroyed.
707 * TODO : add an entry concerning memory leaks in the DicomDir
709 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
711 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
714 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
716 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
717 after it have been deleted
719 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * FIX: src/* fix the doxygen warnings.
721 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
722 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
723 was erroneously defined with a size of 15 instead of 16. [many thanks
724 to Jean Michel Rouet for pointing out this bug].
726 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 1. Finish merging JMR patch for writting DICOM from scratch
728 2. Fix -hopefully- bug with MONOCHROME and space vs null character
729 3. Use const ref when possible
730 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
731 5. A few more comments
732 6. CreateUniqueUID can now be called without parameter"
734 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
735 * ENH: Slightly bigger patch:
736 1. Getting toward full integration of JMR patch for writting dicom from scratch
737 2. Update Test to test part of this patch: CreateUniqueUID
738 3. File was not close properly in gdcmDict
739 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
740 5. Use of const ref instead of copy (speed issue)
741 6. Remove temporary (duplicate) string in TranslateToKey
742 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
743 8. Do not repeat virtual in subclasses
744 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
746 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
747 * Apply first patch toward better string comparison when dealing with broken
748 DICOM files. Essentially the string could be padded with a space instead
749 of a null character as defined by standard
751 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
752 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
753 because never used... and in the same time, that's remove some memory leaks
755 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
756 * src/gdcmFile.cxx : now delete the PixelConvert instance.
757 * In examples and tests : change the type of image data variables from void*
758 to uint8_t*. Remmove all delete on image data variables
760 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
761 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
762 Verify the file pointer value before open the file, and if it's not null,
763 a verbose message is generated.
764 Close correctly the file when the file isn't considered dicom-like. The
765 correctly close is a call to CloseFile.
766 When closing the file pointer, test if its not null to close the file.
767 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
768 file. For an uncompressed image, the copied data correspond in the least
769 case to the image size (calculated) or the image size specified in the
770 header. A verbose is generated if these two size mismatch
772 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
774 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
775 break under windows (with msvc6 compilation).
777 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
779 compiling with MSVC6)
781 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * Bugs fix for the Windows build with VC6
783 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
784 needed (only for projects required VTK). If the VTK is included in all
785 projects, there is conflicts with the jpeg lib of vtk when compiling the
786 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
787 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
788 when compiling the gdcm_wrap.cxx file (created by the compilation of the
790 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
791 (like it's already made for the cout use). Otherwise, conflict with the
794 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
797 - comments on the DicomDir::Method related usage added.
798 - now that we use the namespace gdcm, a lot of internal classes do
799 NOT need to be wrapped anymore.
800 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
801 DicomDir::Method) new example added.
803 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
804 * Improve string manipulation. I now inforce the notion of 'DicomString'
805 A DicomString can contain as many \0 as they want
806 and it is *always* of even length.
807 We only support odd length for very rare case.
808 And in the near future this should be removed.
810 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
811 * /binary_write/ gdcm source. Now even on big endian we are writting
812 little endian. This should -heopfully- fix some tests
814 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
815 * Now the dictionary is compiled into gdcm lib. This is a default
816 behavior, thus any dic file specified is picked before failback to
817 the one comiled into lib
819 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
820 * Change internals for gdcmDict. Don't use any 'new' any more.
821 This should definitely solve any leak problem, and we should be
822 as fast as before, as long as don't modify too much the dictionary.
824 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
825 * STYLE: ivars should start with a capital letter.
826 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
827 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
829 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
831 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
832 new 2004 dictionaries added (thanks to JPR).
833 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
834 * CLEANUP_ROUND (15) for gdcmPixelConvert
835 - RLEFrame::NumberFragments is now of type unsigned int
836 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
837 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
840 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
841 * Initial work in gathering all transfer syntax accessors. clearly
842 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
843 ivars, but only one transfersyntax (class) ivar with equivalent method on
846 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
848 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
849 discussed (plus I didn't like having a 2000 lines patch not commited)
851 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
853 * CLEANUP_ROUND (14) for gdcmPixelConvert
854 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
855 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
856 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
858 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
859 anymore and hence avoids storing a copy of PixelConvert::Decompressed
860 into File::Pixel_Data.
862 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
864 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
865 * CLEANUP_ROUND (13) for gdcmPixelConvert
866 Substituted File::ParsePixelData() with PixelConvert::Print() new
868 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
869 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
870 method to those classes.
871 - src/gdcmFile.[cxx|h]:
872 -- Added a ::Print() method.
873 -- PixelConverter is now a reference instead of a member.
874 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
875 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
877 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
878 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
879 collaboration diagram and inheritance diagram should be generated with
881 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
882 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
883 pointlessly wrapped (see
884 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
885 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
886 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
887 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
888 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
889 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
890 -- File::Initialise: PixelConverter setup moved away to
891 PixelConverter::GrabInformationsFromHeader()
892 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
893 interpretation moved away to PixelConverter::BuildRGBImage()
895 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
896 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
897 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
899 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
901 displayed on Win32 when a brutal abort() occurs (because of uncatched
902 exception). See TODO new entry of this commit for more on this.
903 * TODO added new entry.
904 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
905 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
906 - HandleColor is no longer called from gdcmFile.cxx
907 - gdcmPixelConvert.cxx clean up on method arguments and internal
908 variable names for semantical coherence.
910 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Finished lossless transition, not only do we now read all lossless jpeg
912 images, without the need of the Cornwell lib, but we do read them properly now
913 * To reduce code (well to avoid code duplication), I defined a common place
914 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
915 redefine symbols. This is not perfect but this the best solution I found for a
916 compilation time jpeg option.
918 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
919 * Update jpeg ijg lib to support lossless jpeg implementation
920 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
922 * Also added a special copyright for dcmtk since we use their bugfixes.
925 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
927 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
928 matters, as stated in warning note at begining of %include section).
929 * src/gdcmDicomDir*.[cxx|h]: coding style
930 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
931 * src/gdcmJpeg8.cxx: doxygen fix.
932 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
933 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
934 from File:: to PixelConvert::.
936 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
938 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
939 - more code moved away from File:: to PixelConvert::
940 - fat setup of PixelConverter set in place in File::Initialise.
942 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
943 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
944 namespace at the file system level. So now you should convert your examples
946 gdcmHeader -> gdcm::Header
947 It would be nice if people keep in mind to no open the namespace, since it
948 allows compilation on broken plateform which were defining common symbol in
949 the standart namespace (like LP, Unknown ...)
951 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
953 The JPEG fragments are now parsed at the same stage than the RLE
954 information. All code related to JPEG is now in gdcmPixelConvert:
955 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
956 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
957 export a gdcmFile:: method. Those are simply global functions
958 (for the time being this is better than having them attach to
959 either gdcmFile:: or gdcmPixelConvert::).
960 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
961 and stores the result in a gdcmJPEGFragmentsInfo.
962 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
963 code (among other stuff) moved away from gdcmFile:; to
966 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
968 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
969 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
970 clean up of RLE related code.
971 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
972 - src/gdcmRLE.cxx removed
973 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
974 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
975 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
976 * CLEANUP_ROUND (9) for gdcmPixelConvert
977 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
978 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
979 away from gdcmFile:: to gdcmPixelConvert::.
981 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
983 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
984 This is because Parse7Fe0 used to parse the pixels to compute the
985 length. This task was passed over to FindDocEntryLengthOB() a long
986 time ago, EXCEPT I had forgotten the OW case...
987 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
988 we just recylce the code for parsing RLE fragments and computing
990 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
991 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
992 with the retired Parse7Fe0().
993 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
994 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
996 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
998 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
999 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1000 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1001 * CLEANUP_ROUND (4) for gdcmPixelConvert
1002 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1003 to return an unused length.
1005 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1007 this should be cleanner from the plane view. The iostream are erally a pain
1008 to use to do simple stuff.
1010 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1011 * Redo the compilation of the ijg jpeg library. Now only one source is
1012 necesseray. No need to rename file by hand what so ever. CMake handle the
1013 copying of the file within different directory, configure header file to
1014 modify some symbol. The only addition made to ijg wasd a mangle table so
1015 that symbol are different whether we are within 8bits or 12bits.
1017 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * Added documentation of vtkgdcmReader on Website:
1019 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1020 with it's binary name).
1021 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1022 the Website to be more complete.
1023 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1024 doxygenated documentation.
1025 - Doc/DoxyVtkGdcmReaderExamples.txt added
1026 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1027 DoxyVtkGdmReaderExamples.html )
1028 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1029 * CLEANUP_ROUND (3) for gdcmPixelConvert
1030 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1032 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * CLEANUP_ROUND (2) for gdcmPixelConvert
1034 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1036 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * CLEANUP_ROUND for gdcmPixelConvert:
1038 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1039 - src/gdcmPixelStuff[h|cxx] removed
1040 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1041 - src/CMakeLists.txt changed accordingly
1042 * GDCMHOME clean up:
1043 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1044 gdcmVersion.py moved to newly created ATTIC related
1045 gdcmPython/SetupOldies/ directory.
1046 * Autotools clean up:
1047 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1048 - autogen.sh configure.in acinclude.m4 python.m4 removed
1050 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1052 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1053 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1055 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * TODO updated with Mathieu suggestions. I proposed a template for
1057 describing TODO entries and used it for new entries.
1058 * Added Doc/Website/CodingStyle.html, Developpers.html,
1059 DeveloppersPython.html, GdcmDataCvs.html and
1060 DownloadVersion0_1.html, DownloadVersion0_3.html.
1061 * Some Doc/*.txt Doxygen files (which do not really concern the
1062 documentation itself, but the website) moved to html and
1063 placed in directory Doc/Website:
1064 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1065 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1066 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1067 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1068 * CMakeLists.txt changed accordingly.
1069 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1070 DeveloppersPython.html
1071 * INSTALL nows refers to Doc/Website/Installation.html
1073 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * Added Doc/Website directory, that contains a first raw version
1077 2004-09-23 Jean-Pierre Roux
1078 * FIX In order not to be poluted any longer by casting problems,
1079 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1080 we can now delete[] it safely
1081 * VoidArea is now called BinArea (less confusing name),
1082 and all the methods called ...VoidArea... are now ... BinArea...
1083 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1085 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1087 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1088 up to the destructor of gdcmElementSet to clean up TagHt and it's
1091 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1092 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1093 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1095 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * ENH: added some utility method that builds a flat dictionary
1097 holding all the Dicom entries contained in the recursive structure
1098 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1099 an example of usage.
1100 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1101 BuildFlatHashTable() that build a flat dictionary.
1102 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1103 gdcmDocument is now a friend of gdcmElementSet.
1104 - src/gdcmElementSet.cxx: clean up.
1105 - Example/FlatHashTablePrint.cxx added.
1106 - Example/CmakeLists.txt changed accordingly
1108 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1110 moved away from gdcmDocEntrySet (since this class is an abstract class
1111 acting like an interface). SQDepthLevel and BaseTagKey are now
1113 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1114 and associated accessors. Doxygenation of the class.
1115 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1117 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1118 Use SQDepthLevel accessor instead. ::Print() adapted.
1119 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1120 - src/gdcmDocument.cxx changed accordingly.
1122 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1124 - The following is the doxygen comment of the typedef declaration
1125 of gdcmTagKey in src/gdcmCommon.h:
1126 gdcmTagKey is made to old an "universal" (as in URL, Universal
1127 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1128 A dicom tag always has a group and an element, but a set of tags
1129 embeded in various (optionally nested) sequences and sharing
1130 the same group and element all share the same (group, element)
1131 "identifier". Hence the (group, element) cannot be used as an
1132 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1133 In order to construct a proper tag identifier (i.e. a key) we
1134 consider the following definition of a TagKey:
1135 - let Group, Element be the string representation of the
1136 group and element dicom tag members,
1137 - let ItemNumber be the string representation of the integer
1138 index of the considered item number of a sequence,
1139 Let the key of a tag embeded in a sequence, noted SeqTag, be
1141 /ItemNumber#Group|Element
1142 where "/", "#" and "|" are characters acting as separators.
1143 Then the general form of a gdcmTagKey is given by:
1144 Group|Element<SeqTag>
1145 where <SeqTag> means NO or many instances of SeqTag.
1146 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1149 but the gdcmTagKey of a tag "embeded" is the first item of
1150 a sequence, itself nested in the third item of a sequence is the
1152 0004|1220/2#0008|0082/0#0008|0090
1153 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1154 order to hold the new sequence compatible key. Previously, the
1155 GetKey() method would look in the underlying gdcmDictEntry.
1156 - src/gdcmDocEntry.cxx:
1157 -- constructor now copies the underlying DictEntry key, in the local
1159 -- ::Print: displays the member Key, instead of the (group, element).
1160 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1161 - src/gdcmDocEntrySet.h:xi
1162 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1163 -- now has a new BaseTagKey member.
1165 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1166 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1168 This poses the problem with the semantics of the following lines
1169 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1170 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1171 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1172 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1173 to the long FIXME note for what the problem is. Nevertheless in
1174 order to get things working the dicom dictionary was altered !
1175 Please fix things urgently...
1176 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1177 information), see above note on moving the member VoidArea. Nevertheless
1178 the following entries previously correctly set as US are now inproperly
1180 0028 1201 OW IMG Red Palette Color Lookup Table Data
1181 0028 1202 OW IMG Green Palette Color Lookup Table Data
1182 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1183 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1184 of gdcmDocEntry moved to gdcmSeqEntry.
1185 * src/gdcmSeqEntry.cxx: STYLE.
1187 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1190 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * gdcmPython/testSuite.py: all the test suite in python is now moved
1192 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1193 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1194 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1196 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1198 to avoid inclusion recursion until STL is reached.
1199 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1200 mecanism. errno.h is not included in gdcm anymore.
1201 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1202 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1204 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1205 gdcmData/TestAllEntryVerifyReference.txt
1206 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1207 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1208 exception_on_error parameter.
1209 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1210 - vtk/vtkGdcmReader.cxx changed accordingly,
1211 - Example/*.cxx and Test/*.cxx changed accordingly.
1213 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1215 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1216 enable_sequences removed from gdcmHeader constructor and dependencies.
1217 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1218 * gdcmPython/demo/PrintHeader.py: dummy fix.
1219 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1220 skip_shadow removed from gdcmHeader constructor and dependencies.
1221 * Example/*.cxx and Test/*.cxx changed accordingly.
1223 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1225 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1227 2004-07-21 Jean-Pierre Roux
1228 * FIX Now, Parsing and Printing a DICOMDIR do work!
1229 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1231 2004-07-20 Jean-Pierre Roux
1232 * FIX Some brain damaged headers have Zero-Lenght fields
1233 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1235 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1236 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1237 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1238 variable (instance of gdcmDebug) by a definition macro, and the instance
1239 is now in static in the gdcmDebug class
1240 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1241 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1243 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1244 * WARNING: ctest now depends more tightly on gdcmData. You should
1245 check out gdcmData properly for things to run smoothly...
1246 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1247 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1248 we need the pixels not be loaded in order to use the ValEntry
1249 that displays position and size).
1250 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1251 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1252 be deprecated. If you have any doubts about the advantages of a
1253 modern scripting language (read Python) versus grass root C++ (i.e.
1254 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1255 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1256 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1257 Anyhow, consider documenting the gdcmData images in
1258 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1260 * Test/CMakeLists.txt:
1261 - now uses TestAllEntryVerify.cxx
1262 - specific comments on oldACR00001.ima (now renamed in gdcmData
1263 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1264 gdcmData/TestAllEntryVerifyReference.txt
1267 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1268 * src/*.[h|cxx] : typedef clean up
1269 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1270 - TagKey renamed to gdcmTagKey (for external usage)
1271 - VRKey renamed to gdcmVRKey (for external usage)
1272 - removal of typedef duplication.
1273 - Removed all unecessary inline keyword from class inline definitions.
1274 - Some method|function(void) declarations replaced with method|function().
1275 * src/jpeg/libijg12/jdhuff12.c:
1276 - printf polluting ctest removed.
1277 - TAB removal for comminting
1279 - TestAllReadCompareDicom.cxx: added a test that compares all the
1280 images in gdcmDataImages.h with corresponding images in
1281 gdcmData/BaselineDicom/. When baseline images are not present
1282 this test creates them.
1283 Note: we need to validate each reference image, but before that
1284 I'd like to rename them with a more explicit name...
1285 - CMakeLists.txt: changed accordingly.
1286 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1287 including each header needed).
1289 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1290 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1291 test suite to the Example directory. Are concerned:
1296 - TestWriteSimple.cxx
1297 * Test/CMakeLists.txt: added some comments on reasons for black listing
1298 image gdcmData/oldACR00001.ima
1300 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * Test/CmakeList.txt: removed the following from black list (to be coherent
1302 with removal from gdcmData):
1303 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1304 - gdcm-MR-PHILIPS-16.dcm
1306 Added the following because after last cvs update, they cause
1307 ctest -R TestReadWriteReadCompare
1309 - gdcm-MR-SIEMENS-16-1.acr
1311 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1312 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1313 new comments in this file) we temporarily (sigh) move to a weaker
1315 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1316 we don't need to black list the following images anymore:
1317 - 8BitsUncompressedColor.dcm
1319 - US-PAL-8-10x-echo.dcm
1320 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1321 fixes and the beautified code ;-)
1322 This fixes the bug introduced in version 1.42 (when beautifying)
1323 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1324 Note: ctest was blind to this bug (this means we need to still
1325 improve the test suite). The bug could be detected by using
1326 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1328 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1329 and by displaying the (garbage) produced file temp.XDCM...
1331 2004-06-29 Jean-Pierre Roux
1332 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1333 - replace by uggly but working old code :-(
1334 A lot of things should be OK again.
1335 It's really urgent to have a test suite that *tests*,
1336 to prevent Frog's beautifying sessions to break all the stuff
1337 (twice, withing a fortnigh ...)
1339 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1340 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1341 redundancy) to added Test/TestReadWriteReadCompare.cxx
1342 * Test/CmakeList.txt: because the compare test of
1343 Test/TestReadWriteReadCompare.cxx fails, the following images are
1344 black listed: - 8BitsUncompressedColor.dcm
1346 - US-PAL-8-10x-echo.dcm
1347 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1348 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1349 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1350 and ad-hoc kludge. This kludge is now removed, and on encountering
1351 such an image (OB field brain damaged) we set errno. Then in
1352 ::FindDocLength() we "fix" the length as being ALL what remains
1353 in the file (until EOF). We then proceed, hoping for the best...
1354 This fixes a SegFault in ShowDicom when trying to write such an
1356 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1357 (because TestWriteRead breaks on it, after a non conformal commit?).
1358 ctest now runs properly, except for MakeDicomDir (which was always
1359 broken) and the Python related stuff (still not fixed).
1361 2004-06-24 Jean-Pierre Roux
1362 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1363 FIX : Test/TestReadWrite now iterates on all the file names
1364 (instead of infinite loop)
1365 ENH : Test/TestWriteRead now iterates on all the file names
1367 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1368 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1370 2004-06-24 Jean-Pierre Roux
1371 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1372 when SamplesPerPixel =3
1373 - now Write is no longer confused by
1374 'BitsAllocated = 12" and 'BitsStored=12"
1375 - "UN" value representation Elements are now written correctly
1376 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1377 ENH : - now gdcmHeader has its own Write methods
1378 (in order to split the job that has not to be done
1381 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1383 loop on the same image until memory went out.
1384 Note: this means we still have gobs of memory loss in PrintDocument
1385 * src/gdcmDocument.cxx: fixes problem on parsing on file
1386 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1388 2004-06-24 Jean-Pierre Roux
1389 FIX : Write - All the Sequences and Sequence Item are now written
1390 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1391 is added a the end, when necessary.
1392 - A lot of brain-damaged images, that were read correctly are
1393 now written correctly
1394 - length compatible BinEntry are now loaded correctly
1395 (even for odd groups)
1396 Note : only Explicit Value Representation was checked.
1397 (question : is implicit VR really necessary for gdcm ?)
1399 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1400 * DEVELOPPER: added a proposition of coding style.
1401 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1404 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1406 Use the gdcmDocEntry::Print() and Write() instead.
1407 * src/gdcmDocument.cxx: bug fix.
1409 2004-06-22 Jean-Pierre Roux
1410 FIX : gdcmDocument.cxx
1411 - Now we do recognize the JpegLossLess format (there was a misstyping in
1412 code 'beautyfication' :-(
1413 - Now we automaticaticaly load the Luts, if any
1415 2004-06-22 Jean-Pierre Roux
1416 In order : to write Sequences, whatever their imbrication level,
1417 : to allow user to create his own Sequences
1418 a lot of modif where necessary (adding, moving, or virtualising methods)
1420 WARNING : save your own sources *before* cvs up !
1423 ADD virtual void Write(FILE *fp, FileType filetype);
1426 ADD virtual void Write(FILE *fp, FileType filetype);
1427 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1430 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1431 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1432 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1433 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1434 ADD std::string GetEntryByName(TagName name);
1435 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1437 std::string vr = "unkn",
1438 std::string fourth = "unkn",
1439 std::string name = "unkn");
1440 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1441 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1442 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1443 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1444 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1445 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1446 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1447 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1450 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1451 ADD virtual std::string GetEntryByName (TagName tagName);
1452 ADD virtual std::string GetEntryVRByName (TagName tagName);
1453 REM virtual bool Write(FILE *, FileType);
1454 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1455 FILE *_fp, FileType type);
1456 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1457 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1458 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1459 REM virtual std::string GetEntryByName (std::string tagName);
1460 REM virtual std::string GetEntryVRByName (std::string tagName);
1461 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1462 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1463 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1465 std::string vr = "unkn",
1466 std::string fourth = "unkn",
1467 std::string name = "unkn");
1468 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1469 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1470 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1471 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1474 ADD virtual void Write(FILE *fp, FileType filetype);
1477 ADD virtual void Write(FILE *fp,FileType filetype);
1480 ADD virtual void Write(FILE *fp, FileType filetype);
1481 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1482 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1483 REM std::string GetEntryByName(TagName name);
1486 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1488 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1489 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1490 The default constructor invoked by the line
1491 gdcmHeader *f1 = new gdcmHeader( header );
1492 was gdcmHeader::gdcmHeader(bool) instead of the expected
1493 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1494 Hence the parsing wasn't executed... See also below.
1495 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1496 as explicit constructor didn't do the trick to fix the above problem.
1497 Could anyone explain why ?
1498 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1499 properly calls gdcmValEntry::Print() (that was weed out from
1500 code related to gdcmBinEntry).
1502 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1503 * In order to fix memory leaks:
1504 - Test/TestWriteSimple.cxx: added cleaning of free store through
1506 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1507 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1508 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1509 (through the call to ::AddDicomDirMeta()) or the destructor
1510 would crash when deleting uninitialized ::metaElems].
1511 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1512 - src/gdcmDocument.cxx:
1513 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1514 from dynamic stores.
1515 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1516 was causing memory leaks.
1517 - src/gdcmSQItem.cxx:
1518 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1519 cleanly handled with polymophism: sorry but my milage is low).
1520 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1521 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1522 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1523 This avoids SegFaulting.
1524 - src/gdcmSQItem.h: coding style.
1526 - Test/TestWriteSimple still severely sucks. The output image content
1527 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1528 damaged when displayed with vtkgdcmViewer.
1529 - on memory leaks: TestWriteSimple leaks really less (see entry
1530 of 2004-06-18 in Changelog file for the call to valgrind).
1531 - on segfaults: ctest now passes all the tests but one (no more
1533 * Erroneous leading white fix:
1534 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1535 white[s] (as opposed to from >> xxx, that removes it [them].
1536 - src/gdcmTS.cxx: ditto.
1537 - gdcmPython/testSuite.py: dirty related kludge removed.
1538 * src/*: remaining references to gdcmParser removed.
1539 * src/*[cxx|h]: added copy[way]left header.
1542 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1543 * In order to fix writing of dicom files:
1544 - Test/TestWriteSimple.cxx: a simpler example of writing.
1545 - Test/CMakeLists.txt changed accordingly.
1546 - src/gdcmDocument.cxx:
1547 -- The destructor now recursilvely removes potential sequences.
1548 -- Bug fix in ::IsJPEG2000()
1549 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1550 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1552 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1553 to only declared) and build on top of
1554 ::GetDocEntryByNumber(guint16, guint16).
1555 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1556 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1557 for usage in destructor and treatement of promotion in
1558 ::ReplaceOrCreateByNumber().
1559 - src/gdcmSQItem.cxx: destructor should better handle his job.
1560 Test/TestWriteSimple now runs (or at least it DOES something).
1561 * We can now start hutting memory links. A good starting point is:
1562 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1563 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1564 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1566 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * Valgrind note: after Mathieu Malaterre teached me how to read
1568 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1570 Using gcc, you can force the STL to use malloc and to free memory as
1571 soon as possible by globally disabling memory caching.
1572 With 3.2.2 and later, you should export the environment variable
1573 GLIBCPP_FORCE_NEW before running your program.
1574 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1575 simply vanish (it is still not clear to me, whether this means that
1576 STL std::string leaks or if valgrind believes it leaks...).
1577 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1578 running bin/gdcmTests makeDicomDir):
1579 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1580 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1582 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1583 SegFaulting (I drowned in DicomDir related code when trying to
1584 understand why the list is empty...).
1585 * src/gdcmDocument.h: first BSD license header try.
1586 * Doc/License.txt added.
1588 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * src/gdcmDocument.[h|cxx]:
1590 - Clean up of the Transfer related predicates. They are now all based
1591 on new method isGivenTransferSyntax, that (should) handle properly
1592 the padding problem.
1593 - general clean up, simplification, and coding style.
1594 - Specific clean up of Parse7FE0() (umproperly named actually).
1595 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1597 2004-06-14 Jean-Pierre Roux
1599 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1600 - fix the display of SQItem ordinal number
1601 - add the GetSQItemByOrdinalNumber method
1602 - remove some useless never written private methods
1604 2004-06-14 Jean-Pierre Roux
1606 - adding a constructor taking a gdcmDocEntry as an input param
1607 - ReplaceOrCreateByNumber now returns :
1608 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1609 a gdcmValEntry * if a string value is passed as a param
1611 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1612 according to the param type (no longer sets a gdcmDocEntry)
1613 - GetValEntryByNumber, GetBinEntryByNumber added
1614 - NewValEntryByNumber and NewBinEntryByNumber added
1616 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1618 - GetSQItemNumber and SetSQItemNumber added, to provide
1619 a (relative) Item identier inside a given Sequence
1620 \warning : some pb remaining around this number
1622 - AddEntry now takes the Item Number as a param
1624 - adding a constructor taking a gdcmDocEntry as an input param
1626 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1627 * Memory leak hunt with the following command:
1628 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1629 --show-reachable=yes gdcmTests PrintDocument
1630 It looks like many (all?) leaks are due to the STL (or a bad usage
1631 of the STL. The lines producing the leaks now have a comment with
1632 a "MEMORY LEAK" tag: you can retrieve them with
1633 grep "MEMORY LEAK" src/*
1634 Here are two typical examples which I can't help fixing:
1639 char * test = "babo";
1640 name = test; //// <--- valgrind detects 960 bytes lost in
1641 //// call to std::string::operator=(char const*)
1642 name.clear(); //// Doesn't help !
1650 std::cout << "Type a bunch of characters followed by RETURN: ";
1651 getline(std::cin, line); //// <--- valgrind dectects a loss
1652 //// of 1320 bytes in call to
1653 /// std::basic_istream<>& std::getline<>
1659 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmHeader.[cxx|h]:
1661 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1662 and related, moved away to gdcmDocument.
1663 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1664 the corresponding protected accessors of inherited class
1665 gdcmDocument, removed ! As a consequence gdcmFile had to be
1666 declared friend of class gdcmDocument (see below).
1667 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1668 - Clean up of undefined or unused methods.
1669 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1670 account the changes to gdcmHeader.h).
1671 * src/gdcmDocument.h:
1672 - gdcmFile is now a friend class (in order to take into account the
1673 changes to gdcmHeader.h).
1674 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1675 (see changes to gdcmHeader.h).
1676 - Accessors (reading on the form GetEntry*) are now public.
1677 - Clean up of undefined or unused methods.
1678 * src/gdcmDocument.cxx:
1679 - adaptation to changes to gdcmDocument.h
1680 - ::OpenFile now writes a verbose message when file cannot be opened.
1681 - some std::string properly set to VRKey
1682 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1683 references to gdcmDocument.
1684 * Test/TestFindTags.cxx: changed accordingly to above changes.
1685 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1686 cvs repository gdcmData.
1688 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1690 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1691 conflicts with gdcmValEntry::voidArea.
1692 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1693 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1694 Value representation between StringRepresentable and BinaryRepresentable.
1695 * src/gdcmDocument.cxx:
1696 - method ParseDES: proper indentation restored and usage of
1697 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1698 - method LoadDocEntry: the fingerprint left in the SetValue() of
1699 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1700 removed. Reverting to previous code segment with the proper
1701 dynamic_cast< gdcmValEntry* >.
1702 Note: this was (partially) breaking the python test suite
1703 (gdcmPython/testSuite.py) that made usage of the above
1704 fingerprint to check presence of "Pixel Data".
1705 * src/gdcmDocEntry.h: coding style.
1706 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1707 now taken into account.
1708 * gdcmPython/gdcm.i: adaptation to the new internal representation
1709 of gdcm (exit gdcmParser, hello gdcmDocument).
1710 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1712 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1713 anymore, but instead prints the loaded Python dictionary.
1714 * .... alas, the python testSuite is still broken.
1716 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1717 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1719 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1720 * src/gdcmUtil.h : export methods
1722 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1723 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1725 * Initial addition of automatic python testing
1726 * Initial addition of automatic image comparison
1728 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1729 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1730 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1732 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1733 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1734 * Test/ShowDicom.cxx : bug fix for msvc compilation
1735 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1737 2004-05-04 Jean-Pierre Roux
1738 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1739 new concepts (and new classes) :
1740 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1741 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1742 - Sequence Doc Entries (gdcmSeqEntries)
1743 a Sequence is composed of Items.
1744 Each item is a set of Doc Entries (this is recursive)
1745 The non uniqueness of the 'Dicom tag' is due to this recursivity
1746 (never taken into account)
1747 Our unability to add a new 'entry' in the header
1748 at the proper location (neither in the H-Table (map or multimap),
1749 nor in the Chained List is also due to this recursivity.
1750 Don't try, right now, to use/modify/compile these new sources :
1751 nothing is finished.
1752 We just commit all the stuff, 'as is', in order not to loose it.
1754 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1755 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1757 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1758 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1759 file prefix (SetFilePrefix)
1761 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1762 * Add a new test: ShowDicom, for now this is just the c++ version of
1763 checkRead.sh, later it will be able to compare the image read against a
1765 * Replace the DEBUG on the stack with a global entry in cmake interface:
1766 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1768 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1769 * Add an example subdir, with a real example on how to read + write a
1772 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1773 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1774 * Doc/CMakeLists.txt: the main page is now properly differentiated
1775 between the developper and user version.
1776 * Doc/doxygen.config.in: dropped search related obsolete flags
1777 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1779 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * DEVELOPPER: added some helpfull comments for compile/test/install
1783 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1785 src directory, now generated in the build dir.
1786 2. Tests as mentionned smarter
1788 4. Add a new method in gdcmDict that return the PubDict by name
1789 this is interesting for 3rd party lib like ITK,
1790 where we could set the institution name / patient name...
1792 * ENH: 1. Now the test suite is working for real
1793 2. All binaries are now output in the gdcm-bin directory
1794 (this was not true before)
1796 2004-04-28 Jean-Pierre Roux
1797 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1798 SeQuence indented printing of Dicom Header.
1799 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1800 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1801 Computation of SQDepthLevel is now part of gdcmHeader constructor
1802 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1803 tree-like structure of a Dicom Header.
1804 * FIX Test code cleaning
1806 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * ENH: Adding automatic testing
1808 1. Need a DartConfig.cmake to submit to public
1809 2. Add a test driver gdcmTest.cxx
1810 3. gdcmTestMain, an helper for the main test driver gdcmTest
1811 4. Files in Test don't have a main anymore, this becomes interesting
1812 when we add more and more tests, thus dsw don't have to load
1814 * ENH: Adding a GDCM_DATA_ROOT for testing
1815 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1816 one file instead of seven + some small cleanup
1818 2004-04-22 Jean-Pierre Roux
1819 * ENH Minor changes to the Print() methods.
1820 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1821 Header printing. Example given with :
1822 > PrintHeader fileName 2 new
1823 (SQ based tree-like structure still to be done for the Header ...)
1825 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1826 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1827 1. I have added some unsigned where needed
1828 2. Some function parameter not used -> (void)
1829 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1830 4. g++ don't like character '\' in comment
1831 5. #define jpeg_create_decompress jCreaDecompress
1832 this really need to be fixed
1833 6. virtualize destructor of gdcmObject ... leakage
1834 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1835 this also really need to be fixed
1836 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1837 remove compression file
1838 (as we only do decompression, right ?)
1839 * ENH: Change malloc/calloc/free with c++ equivalent
1841 2004-04-21 Jean-Pierre Roux
1842 * FIX gdcmHeaderHelper::GetXSpacing
1843 when a single value is found (bug ?), xpacing is now
1844 defaulted to yspacing
1846 2004-04-19 Jean-Pierre Roux
1847 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1848 * ENH add parameters :
1849 bool exception_on_error = false,
1850 bool enable_sequences = false,
1851 bool ignore_shadow = false
1852 to the gdcmFile constructors to be full gdcmParser compliant
1853 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1854 to allow reading of PAPYRUS 3.0 files
1856 2004-04-06 Jean-Pierre Roux
1857 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1859 2004-04-02 Jean-Pierre Roux
1860 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1861 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1862 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1864 2004-03-30 Jean-Pierre Roux
1865 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1866 for ACR file, written out as DICOM files (hope so...)
1868 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1870 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1871 moved to base class gdcmParser and only the specialisation is kept
1873 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1874 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1875 already does the job.
1876 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1877 (to be consistent with gdcmParser::WriteEntries).
1879 2004-03-30 Benoit Regrain
1880 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1881 upate of the object's instance. It's passed to 2 in the unfavorable
1882 case : one in the ExecuteInformation, one in the ExecuteData
1884 2004-03-29 Jean-Pierre Roux
1885 * ENH : Check on file type to be written moved
1886 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1887 * FIX : gdcmObject::ResetBoundaries now stops properly
1888 when end-of-list is reached
1889 : gdcmVersion modified (as Benoit Regrain asked)
1891 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1892 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1893 * src/gdcmUtil.cxx: added forgotten iostream include.
1894 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1895 equivalent to ExplicitVR in existing code).
1897 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1899 now contains all the gdcmGlobal related code.
1900 * minor coding style and doxygenation changes.
1902 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1904 now contains all the Debug related code.
1905 * minor clean-up of includes in src/*.cxx
1906 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1907 CreateCleanString) removed.
1908 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1909 * Doc/DoxyMainPageUser.txt added.
1910 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1911 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1912 src/gdcmDirList.cxx)
1914 2004-03-24 Jean-Pierre Roux
1915 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1917 2004-03-23 Jean-Pierre Roux
1918 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1919 big endian made volumes
1920 * ENH Now gdcmParser constructor and destructor are protected to forbid
1921 end user to instanciate class gdcmParser
1922 (only gdcmHeader and gdcmDicomDir are meaningfull)
1924 2004-03-22 Benoit Regrain
1925 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1926 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1927 gdcmSerie to gdcmDicomDirSerie
1929 2004-03-19 Jean-Pierre Roux
1930 * ENH Now the tree-like structure describing a DICOMDIR comming from
1931 an already existing DICOMDIR file is consistent with
1932 the home-made tree-like structure build ex-nihilo
1933 or build from the files held (recursively) in a Directory
1934 functions gdcmDicomDir::CheckBoundaries()
1935 gdcmObject::SetBoundaries() added
1937 2004-03-17 Jean-Pierre Roux
1938 * REM (Eric Boix bug) : removal of meaningless
1939 gdcmDicomDirImage::NewImage function.
1940 * FIX now file names and directory name are written properly in the
1942 * FIX now gdcmDicomDir constructor may be call without any trick
1945 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1947 of gdcmDicomDirImage::NewImage as empty function.
1949 2004-02-28 Jean-Pierre Roux
1950 * ENH add gdcmDicomDir:NewPatient
1951 add gdcmDicomDirPatient:NewStudy
1952 add gdcmDicomDirStudy:NewSerie
1953 add gdcmDicomDirSerie:NewImage
1954 to allow making gdcDicomDir object.
1955 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1956 (as opposite to the gdcmHeader chained list)
1958 2004-02-11 Benoit Regrain
1959 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1960 when using from python
1962 2004-02-10 Benoit Regrain
1963 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1964 * FIX : in gdcmDicomDir when the directory is empty
1965 * ENH : add callback and methods to get the progression of dicomDir
1968 2004-02-06 Jean-Pierre Roux
1969 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1970 - GDCM_META added to gdcmDicomDirType
1971 - class gdcmMeta created
1972 * ENH : - A brief summary is now displayed at the beginning of
1973 'testDicomDir' to help disaster magnitude estimation
1974 * REM : Now useless Test/explDICOMDIR.cxx
1976 2004-02-05 Benoit Regrain
1977 * ENH : add methods in gdcmObject to get the hash table or the list of
1979 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1980 * FIX : wrapping python for TagHeaderEntryHT
1982 2004-02-04 Benoit Regrain
1983 * FIX : even length for some strings when writting the dicom dir
1984 * FIX : sort the images in the dicom dir
1985 * FIX : Bug fix for python use of dicom dir
1986 * ADD : a python demo
1988 2004-02-04 Jean-Pierre Roux
1989 * FIX : Final solution (?) for icone embedded images
1990 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1991 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1992 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1993 gdcmData/gdcm-MR-SIEMENS-16.acr1
1994 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1995 to make full checking easier
1997 2004-02-04 Benoit Regrain
1998 * FIX : WriteEntries : coding style & logic in parameters
1999 * FIX : Set the elements to create the DicomDir in a dictionary file
2001 2004-02-03 Benoit Regrain
2002 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2003 * gdcmDicomDir : add the load of directory
2004 * Bug fix and print add-on
2006 2004-02-03 Jean-Pierre Roux
2007 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2008 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2009 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2010 * FIX gdcmParser.cxx : 'group length' elements are now considered
2011 as integers, even for shadow groups, when file is Implicit VR
2013 2004-02-02 Jean-Pierre Roux
2014 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2016 of the last synonym :-(
2017 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2019 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2020 * FIX taking into account the possible 7fe0,0010 multiplicity
2021 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2022 to allow removal of references to 7fe0,0010, to deal with
2023 ACR-NEMA images, when 0028,0200 is meaningfull
2025 2004-01-31 Jean-Pierre Roux
2026 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2027 no longer writes 'Un' on disk
2028 * FIX SQ elements with actual length are now dealt with corectly
2029 * FIX gdcmFile::WriteBase make the difference, for color images, between
2030 the length (for Palette expanded images)
2031 and Raw Length (non expanded image + Palette)
2032 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2033 (that broke Write). Replaced by UL.
2034 Aware user will reload the field if he
2035 thinks it's necesssary
2037 2004-01-30 Jean-Pierre Roux
2038 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2039 when 'dirty Acr' is found, to be compliant with the new
2040 IsReadable() methods.
2042 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2043 (no DOUBLE images in kosher DICOM,
2044 but so usefull for people that miss them ;-)
2046 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2047 DICOMDIR related utilities (not checked as Windoze compliant)
2049 2004-01-28 Jean-Pierre Roux
2050 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2052 2004-01-27 Jean-Pierre Roux
2053 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2054 to allow skipping the shadow elements, to save memory space.
2055 The TRUE value for this param has to be used
2056 with a FALSE value for the 'enable_sequence' param.
2057 ('public elements' may be embedded in 'shadow Sequences')
2058 * gdcmHeader methods now deal with 'embedded icones images' in the header
2059 (even when an 'icone image sequence' is announced by the
2060 element (0x0088,0x0200), but there is NO icone at all ...
2062 * gdcmHeader sometimes Image Location value doesn't follow
2063 the supposed processor endianity (see gdcmData/cr172241.dcm).
2066 * gdcmHeader add the method
2067 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2068 to get *all* the Header Entries with the same tag.
2069 GetHeaderEntrySameName is probabely *useless*
2070 (no meaning : Name is *not* an identifier within the Dictionary)
2072 2004-01-26 Benoit Regrain
2073 * Bug fix in the print of hexadecimal representations. Remove long fields
2074 in the print and add a third level of print to print them
2076 2004-01-23 Benoit Regrain
2077 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2078 * Bug fix on test suite after remove the strip made on not string fields
2079 * Split the IsReadable method between gdcmParser which test that the file
2080 is dicom and gdcmHeader which test that it's an image file
2082 2004-01-22 Benoit Regrain
2083 * DicomDir : clean code, add methods, set variables in protected or private
2084 * gdcmUtil : bug fix for the clean string method
2086 2004-01-19 Benoit Regrain
2087 * Add the use of shadow dictionaries
2088 * bug fix and coding style
2090 2004-01-19 Benoit Regrain
2091 * src/gdcmFile.cxx : bug fix concerning the close of file
2092 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2093 * Add the update of header entries using the shadow library
2095 2004-01-19 Benoit Regrain
2096 * removal of file gdcmHeader2.cxx
2097 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2098 inheriting from gdcmParser. This split is to prepare the integration
2099 of dicom dir parsing
2100 * bug fix under python
2102 2004-01-16 Jean-Pierre Roux
2103 * REM removal of class gdcmHeaderEntrySet
2104 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2105 * ADD add file gdcmHeader2.cxx
2106 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2108 2004-01-15 Benoit Regrain
2109 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2110 entries created while parsing the header. Thus, they will be destroyed
2111 when the gdcmDictSet will be destroyed
2112 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2115 2004-01-15 Benoit Regrain
2116 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2117 made a fatal error because of the memory release at the end of program.
2118 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2119 some memory and vtk seems to have some problems with that.
2120 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2122 2004-01-14 Benoit Regrain
2123 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2124 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2125 * src/*.[h|cxx] : make changes due to class name changes
2126 * gdcmPython/demo/*.py : bug fix due to method names
2128 2004-01-13 Benoit Regrain
2129 * src/*.[h|cxx] : coding style
2130 * vtk/*.[h|cxx] : coding style
2132 2004-01-13 Benoit Regrain
2133 * gdcmPython/testSuite.py : test the readable flag of file for tests
2134 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2135 It's lied to the stl compilation by MSVC (windows, always windows...)
2136 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2138 2004-01-12 Benoit Regrain
2139 * src/*.h : add comments
2140 * src/gdcmDictSet.h : set the method BuildDictPath in public
2141 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2142 directly setted in the source code
2143 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2146 2004-01-09 Benoit Regrain
2147 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2148 * setup.py : use a reference to gdcmVERSION
2150 2004-01-07 Benoit Regrain
2151 * Modification to compile with the distutils.
2154 2003-12-10 Benoit Regrain
2155 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2156 can use a gdcmHeaderHelper to load data
2157 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2158 made in the source code
2160 2003-12-10 Benoit Regrain
2161 * Update Windows projects and .cvsignore files
2163 2003-11-12 Jean-Pierre Roux
2164 * ENH gdcmHeader constructor has one more parameter (default value : false)
2165 that allows the user to 'go inside' the SeQuences only
2167 gdcmElValSet:Print takes it into account
2169 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * ENH: Update gdcmPython/CMakeLists
2171 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2172 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2174 2003-11-10 Jean-Pierre Roux
2175 * FIX : gdcmHeader::LoadElements is now based
2176 on the ListTag listElem member,
2177 not longer on the TagElValueHT tagHt member
2178 * ENH : PrintPubElVal shows (temporarily) both results,
2179 with the tagHt member and the listElem member.
2180 (it's easier to 'see' the problems when using Printheader)
2182 * FIX : old private member LgrElem is now splitted into
2183 ReadLength : Length actually found on disk (updated only
2184 if bug fixing is necessary), for internal
2186 UsableLength : Updated by FixFoundLength, to fix a bug
2187 or to allow Parser going on.
2188 Will allow to re-write a kosher header when a SeQuence
2189 with a length (not 0000) is found
2190 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2191 because gdcmElValSet::Add does not update ListElem
2194 2003-11-07 Jean-Pierre Roux
2195 * FIX misstyping in Transfert Syntax name table
2196 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2197 when they have an actual length (not 0000 nor FFFFF)
2198 (Nobody should care of it, but DICOMDIR explorers)
2200 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2203 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2204 * ENH: vtkGdcmReader now supports LUT !
2205 (vtkgdcmViewer for now is not able to use them though)
2207 2003-11-05 Jean-Pierre Roux
2208 * in testSuite.py : new files names for checking the package
2209 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2210 that returns the pixel area size to the *aware* (vtk) user
2211 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2213 2003-11-05 Benoit Regrain
2214 * in testSuite.py : Modify the rules for checking the paths
2215 : Explicit error messages
2216 * in __init__.py : Related modif
2218 2003-11-03 Jean-Pierre Roux
2219 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2220 to be used by aware (vtk) users that want to manage
2221 LUT (and no to turn the PALETTE image into an RGB pixels one)
2222 * GetPixelType now returns 8U for 24 Bits images
2223 (vtkGdcmReader compliant)
2225 2003-10-31 Jean-Pierre Roux
2226 * Removal of *all* gdcmData images and add them again
2227 in order to loose the 'history' of un-anonymised images
2229 2003-10-31 Jean-Pierre Roux
2230 * RMV : removal of useless jBitsInJsample.h
2231 for both 8 and 12 Bits JPEG Lossy Libraries
2233 2003-10-31 Jean-Pierre Roux
2234 * ENH : Add the functions gdcmFile::GetImageDataRaw
2235 gdcmFile::GetImageDataIntoVectorRaw
2236 that act as GetImageData and GetImageDataIntoVector
2237 except the making of an RGB Plane from Gray Plane + LUT
2238 Intended to aware (vtk) users who know how to manage
2241 GetLUTRGBA return a R,G,B,A LUT if any
2242 lgrTotaleRaw gives the 'Raw' length
2243 GetImageDataRaw returns the gray Plane
2244 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2245 (They stay Grey, just like with other Dicom viewers :-(
2247 2003-10-30 Jean-Pierre Roux
2248 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2250 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2252 being coherents dicom files.
2254 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2255 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2257 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2258 * ENH: Two steps is necessary to please VC++ compiler...
2259 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2260 * ENH: Add include dir to medcon lib
2261 * FIX: only one function is being exported for now !
2262 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2264 2003-10-29 Jean-Pierre Roux
2265 * adding gdcmHeader::GetLUTRGBA
2266 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2267 --> Mathieu, the modif u're waiting for is not yet committed
2268 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2270 2003-10-27 Jean-Pierre Roux
2271 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2272 00191113.dcm DermaColorLossLess.dcm
2273 MxTwinLossLess.dcm RadBWLossLess.dcm
2274 * ENH: For version prior to vtkImageViewer2 -r 1.19
2275 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2277 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2278 * Removal of ido stuff in CMakeLists.txt
2280 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2282 * FIX: remove a call to ->Modified ... see comments
2283 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2285 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2286 * FIX: Problem with path for libvtkgdcmPython
2287 * ENH: Try adding a search script for python site-package
2288 * RMV: Remove some file from medcon lib that are not necessary
2289 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2290 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2291 * FIX: More pragma disable fro VC++,
2292 I don't think I break something as it is also disable in VTK/ITK.
2293 But it fasten debug compilation time.
2295 2003-10-23 Jean-Pierre Roux
2296 * gdcm now deals with 16 Bits Run Length Encoded images
2297 (they are compressed as 2 planes images,
2298 one for the high Bytes, the other for low Bytes)
2300 2003-10-22 Jean-Pierre Roux
2301 * Now CheckRead takes into account :
2302 - the bugged 'Leonardo' Siemens images
2303 - the XA images, sent thru the burning VPRO station
2304 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2307 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * FIX: When copying a Makefile.am to CMakeLists.txt
2309 one should remove the '\'
2311 2003-10-22 Jean-Pierre Roux
2312 * in gdcmData adding a bugged 'Leonardo' Siemens image
2313 (wrong lengths in header)
2314 OK with gdcm, KO with the other viewers :-)
2315 * add a GE dlx XA image, thru the VEPRO burning station
2318 2003-10-21 Jean-Pierre Roux
2319 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2320 for a brutal checking of vtkgdcmViewer compliance
2322 2003-10-21 Jean-Pierre Roux
2323 * add the files for 'xmedcon' Jpeg Lossless library
2324 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2326 2003-10-21 Jean-Pierre Roux
2327 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2329 2003-10-21 Jean-Pierre Roux
2330 * garbage Siemens 'Leonardo' images dealt with
2331 (the patch is easy to remove)
2332 * cosmetic changes to avoid warnings
2334 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2335 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2336 no need to press 'r' now.
2338 2003-10-20 Jean-Pierre Roux
2339 * upgrade of checkRead.sh checkWrite.sh according
2340 to new Jpeg Lossless decompressor
2341 * add US.3405.1.dcm, a genuine RGB medical file ...
2342 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2343 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2345 2003-10-15 Jean-Pierre Roux
2346 * general anonymisation in gdcmData
2347 * adding the 'color files' from
2348 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2349 * adding some well knowed bugged-header images
2350 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2351 waiting for their inclusion in Python testsuite
2353 2003-10-15 Jean-Pierre Roux
2354 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2355 no longer seg faults when file is not found
2357 2003-10-14 Jean-Pierre Roux
2358 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2361 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2362 * TODO: *.in file to genereate a UseGDCM later
2364 2003-10-14 Jean-Pierre Roux
2365 * Some supposed-to-be Dicom Images have no preamble.
2366 OpenFile takes it into account
2367 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2368 * Missing elements added in dicomV3.dic
2369 (just to be affraid : have a look at
2370 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2371 and do it again next year ;->
2373 2003-10-13 Jean-Pierre Roux
2374 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2375 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2376 But there are NOT. It's fixed !
2378 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * FIX: "jpeglib.h" was not found on VC++
2380 * FIX: vtkgdcm was not being installed
2382 2003-10-10 Jean-Pierre Roux
2383 * ENH : OpenFile closes the file if it *really* doesn't look like
2384 an ACR-NEMA / DICOM one.
2385 * FIX : testWrite no longer writes an empty file if the source file
2386 is not gdcm Readable
2387 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2390 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2391 * FIX: CMake generate now documentation
2392 * ENH: out of source doc build !
2393 * ENH: Generate both user and dev documentation
2394 * ENH: Should work on windows too
2395 * ENH: Only one doxygen config.in file is needed
2396 * FIX: make install should be ok now on ùnix plateform
2397 * FIX: PATH to dictionary was wrong (missing /)
2398 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2400 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * vtkGdcmReader is now able to read rgb dicom file.
2402 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2403 * added a gdcmViewer to vtk test, use mouse to control
2404 window level & window width
2406 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2407 * CMake-ification of gdcm, we have now two build system
2408 * FIX: on cygwin Wsock32 doesn't exist
2409 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2411 2003-10-06 Emanuel Ollart
2412 * FIX : compilation process wad broken.
2413 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2415 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2416 * change gdcmViewer -> vtkgdcmViewer
2417 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2419 2003-10-06 Jean-Pierre Roux
2420 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2421 ( e.g : well known GE images with a wrong elem length,
2422 : Philips MRI Images with a wrong Huffman table)
2423 * still to be done : allow the reading of bugged LEONARDO Siemens images
2425 2003-10-03 Jean-Pierre Roux
2426 * Odd length strings are padded with '\0' (not with spaces,
2427 to remain compliant with already defined strings,
2428 like Transfert Syntax UID and others)
2430 2003-10-03 Jean-Pierre Roux
2431 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2432 to allow displaying RGB images (not only by affim ;-)
2434 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * vtkGdcmReader is now able to read rgb dicom file.
2436 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2438 2003-10-03 Jean-Pierre Roux
2439 * A few nasty patches to allow the reading of a lot of nasty images
2440 ( e.g : well known GE images with a wrong elem length,
2441 : Philips MRI Images with a wrong Huffman table)
2442 * still to be done : allow the reading of bugged LEONARDO Siemens images
2444 2003-10-03 Jean-Pierre Roux
2445 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2447 2003-10-03 Jean-Pierre Roux
2448 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2449 to allow displaying RGB images (not only by affim ;-)
2451 2003-10-03 Jean-Pierre Roux
2452 * gdcmFile::GetImageDataIntoVector now
2453 - deals with MultiFrames MultiFragments Run Length Encoded files
2454 - deals with YcBcR (YBR_FULL) files
2455 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2456 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2458 (no sample found :-(
2460 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2462 Two reasons: - clear things
2463 - third parties acces gdcm through header files, so won't
2464 suffer anymore VC++ complains
2466 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2467 * add argv[1] in testvtkGdcmReader.cxx
2470 2003-09-24 Jean-Pierre Roux
2471 * The lines are now eigthy characters long.for
2472 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2474 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2475 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2476 char* to std::string. Thus, the use of strdup becomes useless. (see
2477 previous commis of Malaterre)
2478 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2479 before the last Malaterre's commit.
2481 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2482 * This commit should fix the Debug building under VC++, the problem
2483 was mainly a mixture of debug and release lib being loaded at startup.
2484 * I also remove a depency to a specific C function: strdup. Because I had
2485 to force the link to msvcrtd (whereas strdup is in libc).
2487 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2488 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2489 located in the gdcmCommon.h file. All use of reference of tha has been
2490 changed to now use the variable GDCM_UNFOUND.
2492 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2494 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2495 Dicom dictionary. The test suite can now be run again. Note:
2496 I'm note very happy with the " (RET)" changes. I believe this
2497 RETAINED comment should be dropped when parsing the dictionary.
2498 - PACKAGER corrected
2500 - AUTHORS updated and now in alphabetical order
2501 * Makefile.am now exports gdcm.dsw for Windoze users.
2503 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * cygwin complains about missing std:: in subdir Test/
2506 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * remove some methods that are now in gdcmHeaderHelper
2509 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2510 * vtkGdcmReader set spacing and origin correctly
2512 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2513 * Fix a few delete/delete[] mismatch
2515 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2516 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2517 interpretation to data given by gdcmHeader. For instance there are
2518 heuristics to get informations (look at different places).
2519 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2520 sorting DICOM images based on different strategies.
2521 * modified Makefiles accordingly.
2523 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2524 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2525 when building in debug mode
2526 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2527 src/win32/gdcmdll.dsp
2528 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2530 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2531 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2534 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2535 * src/win32/libgdcmjpeg12.dsp was not dos format
2536 * src/win32/libgdcmjpeg12.dsp :
2537 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2538 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2540 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2541 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2543 * src/gdcmFile.cxx : bug fix in affectation type
2544 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2545 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2546 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2547 symbols... future problem ?
2549 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2550 * src/win32/libgdcmijpeg12.dsp was missing
2551 * modified gdcm.dsw accordingly
2553 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2554 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2556 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2557 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2558 commit of JPR (before his hollidays to facilitate our work).
2559 * setup.py : bug fix in code. Modifications made while the last commit
2560 of JPR. The code hasn't been tested before the commit... it's so
2561 useless to make that (for best programmer that is JPR) !!!
2563 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * tagged the current version as Version0_3 (i.e. version 0.3)
2566 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2567 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2568 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2569 * *.dsp : modifications to use new libgdcmijpeg8 library
2570 * setup.py : bug fix on VTKPATH variable
2571 * PACKAGER : adding all concerning windows
2573 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2576 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2577 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2578 test suite reported error.
2579 * PACKAGER file added (describes what a packager must do when
2580 packaging a new release).
2581 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2582 * configure.in: upgraded version number to 0.3.0
2583 * fixing build of rpm (through rpm -ta):
2584 - Doc/Makefile.am exports proper doxygen files
2585 - src/jpeg/libijg8/Makefile.am exports the include files.
2587 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2588 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2589 * src/gdcmHeader.h : formatting code
2591 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2593 We were obtaining error message from vtk. Now, creation of file list
2594 is made in an internal list to prevent this problem.
2595 Bug fix when output is empty.
2596 Bug fix in update of progress value. Previous commit for this was a bad
2598 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2600 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2601 * src/gdcmHeader.h : added method to get the file name
2602 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2603 files. Added method to remove all files on the input
2604 Added FIXME comment concerning the bad parsing of header made by
2605 ExecuteInformation method (in ExecuteData method)
2607 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2609 when using make instal.
2610 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2611 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2613 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2614 * setup.py : adding include dir of jpeg lib to compile all sources
2615 * */Win32/*.dsp : JPR fix for windows compilation
2617 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2618 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2620 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2621 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2623 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * setup.py is again effective on un*x (takes into account the
2625 addon of the jpeg library)
2626 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2627 * Doc/Doxy* updated (includes above enhancements)
2628 * INSTALL now points to web documentation
2630 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * src/gdcmHeader.h doesn't make unnecessary reference to
2633 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2635 * src/gdcm*.[cxx|h] :
2636 - to allow compilation with gcc 3.x
2637 -- clean up of STL usage (added explicit usage of std::)
2638 -- small fixes on exceptions.
2639 Note: linking not tested !
2640 - clean of doxygen comments to avoid warnings at documentation
2642 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2643 dependent convertion).
2645 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * Clean up of previous JPR garbage commit (not even commented in the
2648 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2649 - moved all jpeg related files from src to src/jpeg/libijg8, with
2650 addition/modification of Makefile.am and configure.in.
2651 - the testSuite is still brain damage (not guilty).
2653 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2654 * WrapVTK.py : modifications to get correctly vtk source files to
2656 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2657 (FileName -> Filename)
2659 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * vtk/vtkGdcmReader.[cxx/h]:
2661 - UpdateProgress method should now be effective
2662 - removed the limitation on having only images loaded (as opposed
2664 - when building a stack of images/volume, a lesser number of
2665 gdcmHeader and gdcmFile instances should be used (hopefully
2666 accelerating things).
2667 - when building a stack of images/volumes, files which are not
2668 loadable (wrong path-filename, wrong permissions on existing file,
2669 or file not parsable by gdcm) are replaced with a black image
2670 in the stack (for the caller to notice the problem).
2672 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2673 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2675 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2676 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2677 between standard library (std) and vtk library (problems are found
2678 under Windows... thanks Windows !)
2680 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2683 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2685 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2688 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * When compiling with distutils (see setup.py) the C++ compiler is
2690 called with different flags than the default ones (with automake).
2691 In order to fix all those warning, I compiled gdcm with the command
2692 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2693 and went for warning fixes:
2694 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2695 up from unused variables.
2696 - vtk/vtkGdcmReader.cxx: potential bug fix.
2697 * src/gdcmHeader.h: Doxygen warning cleanup
2699 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * gdcmPython/gdcm.i:
2701 - typemaps correction to take into account the systematic replacement
2702 of "using namespace std" with std:: prefix e.g. std::list,
2703 std::string... (cf changes of 2003-05-21).
2704 - gdcmGlob global variable of type gdcmGlobal (defined in
2705 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2706 exported to Python a as cvar.
2707 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2708 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2709 gdcmDictSet.GetPubDictTagNames() and
2710 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2711 C++ static methods).
2712 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2713 with the above changes.
2715 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * setup.py, manifest.in : bug fix under linux
2718 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2719 * Modification of setup.py to compile vtk part too. Then, we have 2
2720 wrappers which must work with same distutils. For that, we have a
2721 generic distutils in distusiltsWrapping.py ; with :
2722 - build_extWrap class to wrap generically all extensions,
2723 - ExtensionWrap base class for all wrapping extension that contains
2725 - Wrapper interface which wrap sources
2726 + In WrapSwig.py we have extension and wrapper for Swig
2727 + In WrapVTK.py we have extension and wrapper for VTK
2728 * MANIFEST.in : modifications to consider vtk directory and new python
2729 files for compilation
2731 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2732 * Added python wrappers of vtkGdcmReader vtk class (see the
2733 source in vtk/vtkGdcmReader.cxx) :
2734 - vtk/Makefile.am now builds a library
2735 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2736 python library (as opposed to _gdcm.so wich are the python
2737 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2738 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2740 - configure.in has an additional flag --enable-vtk that needs
2741 to be set to enable compilation of vtk related code, that is:
2742 + vtk/vtkGdcmReader.so and
2743 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2744 + gdcmPython/vtkgdcmPython.so (see above)
2745 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2746 be read when compressed or when HighBit + 1 != BitsStored),
2747 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2748 the usage of the python wrapper of vtkGdcmReader vtk class.
2749 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2750 * src/*.[h] all occurences of stl classes are now prefixed with
2751 std::, and all occurences of "using namespace std;" where removed.
2752 This is to avoid pollution of global namespace in included files.
2753 Apparently vtk does not avoid this pitfall: when using both
2754 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2755 collision of various stl members (principally cout...).
2756 * gdcmPython/testSuite.py now cleanly removes temprory generated
2758 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2759 comply with above changes)
2761 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2762 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2763 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2764 vtk data structure (an image Flip was required).
2765 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2766 * cosmetic changes in documentation.
2768 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2769 * src/gdcmHeader.cxx: the constructor no longer exits when an
2770 unexisting file is given as argument.
2771 * The subdirectory Data (containing all the images used for the
2772 test suite) is not part of this repository anymore. A new module
2773 containing those images is now available at
2774 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2775 with the name gdcmData.
2776 All the python scripts (including the package initialisation file
2777 gdcmPython/__init__.py) were adapated to take this change into
2778 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2780 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2781 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2782 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2783 demo of the usage of this class.
2784 Compilation of this vtk part is only done when using the --enable-vtk
2785 at configure (or autogen.sh) stage.
2787 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2788 * More memory link related corrections and documentation fixes.
2790 - maximum info is obtained with a command of the form:
2791 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2792 --show-reachable=yes PrintHeader
2793 - the remaining reachable blocks seem to come from the STL
2794 allocation scheme through the usage of map and list. It looks
2795 like this memory cannot be freed but it is not a memory leak
2796 (in fact further invocation to the STL would recollect the
2797 unused memory allthough it cannot explicitely be freed).
2798 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2799 of displaying an image parsed with gdcm and displayed with VTK.
2800 Note: some images don't seem to work e.g.
2801 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2802 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2803 Allthough this weakens the semantics, it is a ditch attempt to
2804 make gdcm more thread friendly.
2806 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2807 * Memory link hunt (by using valgrind through the command
2808 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2809 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2810 gdcmHeader::_dicom_vr.
2811 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2812 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2814 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2816 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2817 * src/Makefile.am now exports all the necessary include files at
2821 * UpdateGroupLength replaced by new one
2824 * UpdateGroupLength re-written using H-Table
2825 (named UpdateGroupLengthNew untill checks are over)
2827 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2828 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2829 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2831 - gdcmHeader::GetPubElValSet removed.
2832 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2833 UpdateGroupLength, WriteElements, Write.
2834 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2835 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2836 carried the same semantics.
2837 - src/gdcmHeaderIdo.cxx changed accordingly.
2838 - gdcmFile::WriteBase now regroups all the codes from previous
2839 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2840 - enum FileType moved to gdcmCommon.h
2841 * src/gdcmHeader.cxx AddDefault trashed
2842 * gdcmGetXSize added
2843 * getimageDataSize now calls gdcmGetXSize
2844 * Test/*.cxx changed to agree with above changes
2846 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2848 (to avoid double call by end user).
2849 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2850 by end user, since gdcmHeader::gdcmHeader now handles it.
2852 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * gdcm/Doc many doxygen changes:
2854 - Doxyfile now has two different versions, DoxyfileUsers that generates
2855 the html.users end users oriented documentation and
2856 DoxyfileDeveloppers that generates the html.developper developper
2857 oriented documentation.
2858 - README changed accordingly
2859 - requirement.txt removed (old design info moved to TODO).
2860 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2861 DoxyMainPage.txt, DoxyPython.txt provide more information.
2862 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2863 be updated by simply regenerating the docs with doxygen and copying
2864 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2865 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2866 all the tests in the form "if (<map>.count() >1)" were removed.
2867 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2868 ill-formed documentation sections.
2869 * src/gdcmHeader.cxx: ditto
2871 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * setup.py fixed for un*x (needed macro for stdint.h)
2873 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2874 un*ces with sh-utils test utility.
2875 * gdcmPython/demo/test.py renamed to PrintHeader.py
2876 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2877 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2878 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2879 * src/gdcm*.cxx JPR's bad inclusion fixed.
2881 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2882 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2883 * gdcmPython/demo/test.py changed accordingly.
2885 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * gdcmPython/Makefile.am fixed linking against libstdc++
2887 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2888 * Swig subdir (historical tests of swig version 1.3.17++) removed
2889 * Test/testChangeEntete.cxx some lines commented out in order to make
2891 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2892 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2894 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2895 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2896 hence the user doesn't need this explicit call.
2897 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2898 i.e. LoadElements() call removed.
2899 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2900 - src/Makefile.am declares the proper flag for g++.
2901 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2902 for adding user defined new tags.
2903 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2904 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2905 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2907 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2908 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2909 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2910 src/Makefile.am : the project should properly compile and install
2911 with the autotools, included the python wrappers part.
2912 * gdcm.spec.in : added a spec file for RPM packaging.
2914 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2915 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2917 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2918 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2919 to exported to the environement (see gdcmPython/testSuite.py
2921 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2922 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2923 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2924 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2925 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2927 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * gdcmPython/__init__.py doesn't crash anymore when running in
2929 in InstallMode or PreInstallMode but with an environment given
2930 value of GDCM_DICT_PATH.
2931 * src/gdcmDictSet.[cxx/h] coding style.
2933 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2934 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2935 * src/gdcm.h general comments moved to TODO, and README
2936 * src/gdcm.h should now be seen as a user commodity (including it
2937 should suffice to fully use gdcm). It is nowhere including within
2938 any of the kernel files src/*.cxx and src/*.h.
2940 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2941 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2942 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2944 * src/gdcm*.cxx only include their corresponding include file
2945 (as opposed to gdcm.h)
2946 * gdcmPython/gdcm.i changed accordingly
2947 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2948 the autogen.sh generated "make snapshot" command to work.
2949 * autogen.sh removed history related references to crea package.
2951 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * distutilsSwigCPlusPlus.py work around some swig portability
2955 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2957 was done in a last ditch attempt to get setup.py _really_
2958 operationnal. The python/gdcmPython layaout add the advantage
2959 of hidding away the python related distutils specific files
2960 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2961 Alas, the src directory was out of scope (i.e. it's relative
2962 position to setup.py was ../src) which made things impossible to
2963 handle (see previous version of python/setup.py). Crossing fingers...
2965 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2966 * python/setup.py now works on Un*x. (harder than I thougth)
2967 * python/distutilsSwigCPlusPlus.py can now have include files
2968 among the list of sources.
2970 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2971 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2972 * modifications in MSVC projects
2974 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * As stated by the first lines of Test/ExceptionAndPython/README, it
2976 looks like we can move back to original usage of exception within
2977 src/gdcm* and hence remove the errno stuff that was introduced
2978 as a quick and dirty fixture of this problem (added to the TODO).
2979 * Doc/Doxyfile configuration file for Doxygen and corresponding
2980 README file for usage added.
2981 * Test/testWrite.cxx added. This new test comes from a split of
2982 test.cxx that is now reverted to its original purpous i.e.
2983 testing the proper parsing of a Dicom related file.
2984 testWrite.cxx concentrates on testing the IO part of gdcm.
2985 * Test/bug1.cxx (containing a bug on WIn32) added.
2986 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2987 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2988 whose purpose is to publish the content of the TagNames of the
2989 Dicom public dictionary were not accessible without an
2990 instance of class gdcmHeader.
2991 - those methods are now static methods of gdcmDictSet and hence
2992 require no instances at all to be invocated.
2993 - within gdcmDictSet this change required to change some method
2994 to class methods (i.e. are now static) among which SetDictPath
2995 (renamed to BuildDictPath) and LoadDefaultPubDict.
2996 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2997 the above changes by calling the new method classes of gdcmDictSet.
2998 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2999 the above to be effective.
3000 * python/gdcmPython: in order to wrap properly the above changes
3001 for Python, swig version now needs to be > 1.3.17.
3002 * python/gdcmPython/Makefile fixed to adapt itself to new
3003 configure/make shema introduced by Johan Montagnat (thanks for the
3004 contribution). Alas this Makefile cannot be turned into a proper
3005 Makefile.am without some heavy changes in the configure.in
3006 (for python dectection).
3007 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3008 now avoids publishing the empty entries.
3010 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3011 * python/setup.py : bug fix concerning install under windows
3012 ExtraPath reused :-P
3013 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3015 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3016 * Dicts/dicomV3.dic : remove double spaces !!!
3017 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3018 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3021 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3023 method. Doxygenation.
3024 * src/gdcm.h clean up of JPR spurious comments.
3026 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3027 * python/distutilsSwigCPlusPlus.py now properly collects the
3028 shadow classes generated by "swig -c++" (gdcm.py in our case)
3029 when using "python setup.py install".
3030 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3031 reexports the working classes.
3032 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3033 by the classical C errno scheme. This is to prevent an obscure
3034 behavior of the python wrappers when importing wxPython.wx prior
3035 to gdcmPython (which ended up in an abort call). An illustration
3036 of this oddity can be found in the Test/ExceptionAndPython
3037 subdir (see the README file). This problem probably due to
3038 an combination of g++ and dynamic loading.
3039 * added Test/ExceptionAndPython (see above)
3041 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3042 * Changed the layout of the python part to avoid bloating main
3043 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3044 i.e. the distutils arsenal. All the python related stuff is
3045 again in a python subdir, but the package itself is now in
3047 * setup.py was cleaned up:
3048 - pythonIncludePath removed
3049 - python setup.py bdist target is now functional.
3050 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3051 collision with other packages). gdcmPython/demo/*.py changed
3054 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * python subdir moved to gdcmPython (preparation of distutils packaging).
3056 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3057 distutils installer is operational.
3058 * - gdcmPython/__init__.py now properly loads the swig generated
3059 shadow classes (from gdcm.py).
3060 - gdcmPython/demo/*.py changed to import the package gdcmPython
3061 instead of gdcmPython/demo/load.py.
3062 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3064 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3066 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3067 entries within the associated public Dicom dictionary resp. the same
3068 information but sorted by the fourth field (PAT, IMG, DIR) of the
3070 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3071 are now in the "???" group.
3072 - python/gdcm.i changed accordingly,
3073 - python/demo/printGroupedPublicDict.py added, that gives an example
3074 of the above new functionalities in Python.
3076 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * src/gdcm.h, gdcmHeader.cxx:
3078 - historic references to glib's g_malloc and g_free (#defined)
3079 were definitively removed.
3080 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3081 * src/gdcmElValSet.cxx:
3082 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3083 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3084 - GetElValue(string) renamed to GetElValueByName.
3085 - Added GetElementByName(string).
3086 * src/gdcmHeader.cxx: added
3087 - GetPubElValRepByNumber(guint16, guint16)
3088 - GetPubElValRepByName(string)
3089 - GetShaElValRepByNumber(guint16, guint16)
3090 - GetShaElValRepByName(string)
3091 - GetShaElValByNumber(guint16, guint16)
3092 - GetShaElValRepByName(string)
3093 - GetElValRepByNumber(guint16, guint16)
3094 - GetElValRepByName(string)
3095 - GetElValByNumber(guint16, guint16)
3096 - GetElValRepByName(string)
3097 * Doc/requirements.txt added.
3099 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * Test/Makefile building now depends on the one of libgdcm.so
3101 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3102 pixel data) aware which enables finding the address (offset) of
3103 the pixel data of JPEG encoded DICOM files. This leaves only a single
3104 file in the testSuite whose pixel data address (offset) is unknown.
3105 * python/testSuite.py changed accordingly.
3107 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3108 * VC++ has some strong limitations when working with the STL, as stated
3109 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3110 "Also note that some STL containers (map, set, queue, list, deque)
3111 cannot be exported. [...]
3112 Some STL classes contain nested classes. These classes can not
3114 This is caused by a designed limitation that once a template
3115 class is instantiated, it can not be re-instantiated and
3117 Since our usage of map<> is ubiquitous in gdcm, this "designed
3118 limitation" of VC++ is a pitfall.
3119 Hence the Python wrappers of gdcm cannot be incrementally linked
3120 against the c++ dynamic library. The dirty but only workaround is
3121 to forget about incremental link of dynamic libraries and to generate
3122 the Python wrappers library with the inclusions of the underlying C++
3124 The following modifications concern this matter on Win32/VC++:
3125 - wrapping python correct with standalone wrapped dll (don't use separate
3126 dll under windows !!!!)
3127 - python21_d debug mode enabled (ask Frog how to use it :-)
3128 - NO problem with having an STL member of class for example string in C++
3129 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3130 - Python test of dcmlib in Python is ok under windows on a large set
3132 * removed glib references
3133 * typedef's inserted in gdcm.i for correct swig type management
3135 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3136 * python/demo/*.py load.py extracted from test.py. Added explore.py
3137 that only displays required tags and testAll.py that parses all
3138 the files of the testsuite without using unittest.
3139 * python/testSuite.py other additional test on new files added.
3140 * Data/* new test files added accordingly to the testSuite.
3141 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3142 the vr in the file differs from the one of the dictionary.
3144 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3146 values, but limits itself to values which are below a user specified
3147 size (by default 1024 bytes).
3148 * python/gdcm.i : elements not loaded (because their size is above the
3149 user specified treshold) are exported with their TagKey as key of the
3150 python dictionary. This enables the testsuite to make some checks
3151 on the unloaded elements (since we have their offset and size).
3152 * python/testSuite.py
3153 - now tests for the existence and proper value of the pixel data
3154 - two new examples added.
3155 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3157 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3158 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3159 aware. See the strategy comments in gdcmHeader::FindeLength().
3160 * Test/test.cxx now accepts a filename as first argument.
3161 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3162 * python/testSuite.py changed to integrate test on above files.
3164 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3165 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3166 the vr was also RET.
3167 * python/testSuite.py more tests added.
3169 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3170 * python/testSuite.py unittest test suite added (uses Data)
3171 * Data/* dcm and acr files for the test suite.
3172 * glib dependance removed from un*x version. We now use ISO C99
3173 7.18 Integer types (see stdint.h)
3174 - python/Makefile, src/Makefile src/gdcm.h
3175 * src/ when an explicit vr (like dicom files) suddenly poped an
3176 implicit element we use to mark the underlying DictEntry of the
3177 concerned ElValue with "Implicit". This strategy was damageable
3178 too the public or provite dictionaries, since some of their vr
3179 would be changed. Since Header::FindLength heavily relies on the
3180 detection by Header::FindVR of falsely explicit elements, I
3181 added an extra ImplicitVr member to ElValue (boolean).
3182 The rest of the changes we the necessary adaptations.
3184 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3185 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3187 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3189 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3190 * Adaptation for porting to VC++:
3192 o forced to use std namespace (for string to be known)
3193 o all class use __declspec export style on WIN32
3194 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3195 (in stdlib.h on Win32 but in std:: for gcc)
3196 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3197 variable GDCM_DICT_PATH.
3198 * src/gdcmHeader.cxx verbose comments made discrete.
3200 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * python/gdcm.i: added a typemap that converts a C++ hashing table
3202 to native Python dictionary.
3203 * python/demo/test.py:
3204 - now uses the native dictionary for exploration of gdcmHeader.
3205 - takes an optional filename argument (the file to parse).
3206 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3207 PubElVals hashing table.
3208 * Dicts/dicomV3.dic removed error prone trailing spaces.
3210 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3211 * Python wrapping process moved away from src/Makefile to
3212 newly created python/Makefile (as well as gdcm.i)
3213 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3214 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3215 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3216 from the environement variable GDCM_DICT_PATH (when existing).
3217 * src/gdcmDict::GetTag bug fix.
3219 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3220 * Straightforward temporary fixes for swig to build the python wrappers.
3221 src/Makefile now has a python working entry [by working we mean
3222 that we can import de shadow classes without errors].
3224 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3225 * hashtest.cxx removed (since already in Test)
3226 * src/gdcmlib.h renamed to src/gdcm.h
3227 * src/dcm.i renamed to src/gdcm.i
3228 * src/Makefile prepared for python wrapping
3230 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * src/gdcmHeader.cxx :
3232 - Parsing of header is now separated from loading of element values
3233 (see gdcmHeader::LoadElements).
3234 - general clean up of hopefully all file access (creation of
3235 ReadInt16 and ReadInt32)
3237 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3238 * src/gdcmHeader.cxx :
3239 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3241 - SetLgrElem renamed to SetLength
3242 - GetLgrElem renamed to GetLength
3243 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3244 * src/gdcmElValSet.cxx fixed both GetElValue methods
3245 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3246 due to IdoDude was cleaned out.
3248 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3249 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3250 concentrates on finding the value representation (when it exists).
3251 RecupLgr now only finds the element value length, and it avoids
3252 returning the unecessary skL (skipped length).
3253 Also, offsetCourant was simply removed (with taille_fich) since
3254 it was redundant with the File position internals (by using
3255 ftell and fseek). This also made skL (see above in RecupLgr) usage
3257 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3258 on the libido specificities which are handled through class
3260 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3263 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3264 * Truckload of changes. Parsing of header is barely functional
3265 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3267 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3268 * src/gdcmHeader.cxx many addons of low level methods
3270 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3272 and _IdDcmSWAP_LONG.
3274 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3275 * This corresponds to all the changes decided at the meeting of
3276 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob