1 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
4 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
8 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
11 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Test/ : accelerate tests (it's not very significant accelerations).
13 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
15 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Testing/TestSequence.cxx : add test for sequences of images... test that
17 we have the same serie or the same study UID
19 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
22 * src/gdcmDict.h : remove commented code
23 * src/gdcmDocument.cxx : initialize values
24 * src/gdcmFile.cxx : bug fix when reading values
25 * gdcmPython/demo/ : change file names. Remove useless files
27 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmFile.cxx : remove the default array of initialization.
29 The static array contained pointers to non-static values (comming from
30 strings). To have coherences, when creating files, these values can't be
31 static. So, the array can't be static, too ! To simplify, the array have
32 been replaced by repeted lines to insert values in the File
34 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
36 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
38 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
39 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
40 (Dicom Element) into the Sequence Item
42 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/*.cxx : first parss to normalize file organisation
45 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmDirList.[h|cxx] : add method to find a directory
47 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
49 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
50 * Finish cleaning up my JPEG mess. Should be ok now.
51 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
52 contained within the RLE* class(doh!)
54 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
55 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
56 * SerieHeader::AddFileName() creates as many Coherent Files lists
57 (same Serie UID) as it founds different Serie UID
58 amongst the files instead of discarting any file
59 that doesn't match with the first one he found.
60 * SerieHeader::OrderGdcmFileList has now one parameter :
61 the Coherent Files list the user wants to sort
62 * SerieHeader::GetFirstCoherentFileList() |
63 * SerieHeader::GetLastCoherentFileList() | allow to parse
64 the set of Coherent Files lists
65 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
66 compatibility (it returns the *first* Coherent Files list,
67 since there was only one before)
68 * Test/TestSerieHeader gets gdcmData as a default root directory
70 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * Remove friend between DocEntry and File classes
72 * Remove friend between PixelReadConverter and RLEFramesInfo,
75 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
77 0002|0000. The value was incorrect.
79 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
82 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * src/gdcmUtil.cxx : compilation fix on Win32
84 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
85 variable, to be easy found. Add methods to change the default UID.
86 Amelioration of the CreateUniqueUID to use the correct default UID.
87 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
90 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Test/TestVR.cxx : fix memory leaks
93 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Rewrite the base 256 to base 10 conversion, using string operation only.
95 This allows us to get rid of the problematic 64bits integer type (does not
96 always exist on target platform).
98 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
99 * Add construct and destructor to class gdcm::Debug to close the debug file
101 * Don't let uset to open twice the same file
102 * gdcm has now an official UID prefix,
103 supplied by http://www.medicalconnections.co.uk
104 1.2.826.0.1.3680043.2.1143
105 (Thx to Mathieu for providing URL)
106 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
107 to be able to perform some more tests
108 * gdcm::ContentEntry : Contructors and Destructor are now protected,
109 in order to be sure no user will try to use them.
110 (at user level, only the children classes are meaningfull)
112 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * move RLEInfo & JPEGInfo from Document to File
115 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * FIX : remove so many friend between classes
118 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
120 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
122 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
123 In order to avoid missbehaviour :
124 . gdcm::DocEntry is now specialized in
125 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
126 - gdcm::ContentEntry (Dicom entry with a 'content')
127 . gdcm::ContentEntry is specialized in
128 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
129 characters value, or integers)
130 - gdcm::BinEntry (Dicom entry with a non strig representable value
131 (user hasn't any longer to thing about the precedence of his dynamic_casts)
133 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * Test/VTKTest*.cxx : bug fix under linux
136 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
138 use with python. Some methods are moved from Document to ElementSet or
139 DocEntrySet. The equivalent methods to ElementSet have been added to
140 SQItem and are virtual in DocEntrySet. Methods that may have the same code
141 in SQItem and ElementSet is directly placed in DocEntrySet
143 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Test/VTKTest*.cxx : remove the show variable in each test method because
145 it's useless (the viewer variable replace this variable)
147 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmDocument.cxx : bug fix on potential memory leak
149 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
150 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
151 Add ClearXxx methods to remove all the content of the list or map
152 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
154 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * methods ReplaceOrCreate renamed as Insert
156 (nobody will be any longer confused by 'CreateOrReplace')
158 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 * Grealty simplify the JPEg decompression, no need to differenciate based on
160 the JPEG possible type (with/without fragment, with/without multiple frame).
161 Everything is done throught the JPEG IO Suspension mechanism in IJG
163 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * Stage 3 of normalization :
165 in order to avoid any missunderstanding while reading method names :
166 - All the methods xxxEntry now deal with dicom Entries
167 - Methods GetEntry splitted into
170 - Method SetEntry renamed as SetEntryValue
171 - Method SetEntryBinArea let as it was
173 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
174 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
175 - Position correctly the entry points for JPEG2000 and JPEG-LS
176 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
178 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
180 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
181 with other method names
182 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
183 * Test/TestDicomDirElement.cxx : add new test
185 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
187 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
188 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
189 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
190 So can't you use __int64 in ostream at all.
192 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * bug fix for compilation on MSVC6
194 * gdcmPython/gdcm.i : rename of classes missed
196 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 * Stage 2 of names normalization :
198 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
199 (easy to understand ...)
200 - gdcm::FileHelper replaces old class gdcm::File
202 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
204 type and not a string. So, there remove problems on the format of the
207 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
208 * Add Example/TestPapyrus.cxx
209 - reads a Papyrus file (gdcm::Header compliant),
210 - gets the pixels of all the images, using low level iterators
211 - writes an multiframes Dicom image.
212 (Just to show it's *possible* to do that)
213 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
216 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
218 Thus, DicomDirXXX are created with a flad that indicates if the created
219 object is empty or not (when not empty, the DicomDirElement is used to
222 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
224 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
226 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
229 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
231 Remove all access to the hash-tables or lists in the objects.
233 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
235 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
236 be complient with all the gdcm source code
238 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
242 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
243 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
246 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * Test/ : rename VTK tests to have a best name for the tests
248 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
249 GetFirstEntry/GetNextEntry use
251 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
252 * In SerieHeader::ImagePositionPatientOrdering()
253 // a Dicom 'Serie' may contain scout views
254 // and images may have differents directions.
255 // -> More than one may have the same 'pos'
256 // Sorting has then NO meaning !
257 Thx to Eduardo Davila for reporting bug.
259 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
261 test. Now it's on image content and not on the resulting visualisation...
262 might solve the problem on linux when using the OpenGL drivers
264 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
265 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
266 DicomDirSerie, DicomDirImage
267 Dict, DictSet classes :
268 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
269 -remove InitTraversal method.
270 * UPD Test programs + Example programs
272 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
273 * remove useless and never updated keyword \ingroup
274 * Solve pb when structure (list, map, ...) is empty.
275 Thx to Benoit for reporting bug
277 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
278 * Taking into account of 'Transfer Syntax' value
279 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
282 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
284 is no memory access violation
285 * gdcmPython/demo : add python demos using VTK
287 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
288 * FIX 'Dictionnary' is now spelt 'Dictionary'
289 'wether' is now spelt 'whether'
290 'archieve' is now spelt 'archive' ;-)
292 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
293 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
294 related methods, in order not to expose internal mechanisms
297 * REM methods that exposed internal mechanisms :
298 DicomDir::GetDicomDirPatients()
299 DicomDirPatient::GetDicomDirStudies()
300 DicomDirStudy::GetDicomDirSeries()
301 DicomDirSerie::GetDicomDirImages()
302 * UPD Test programs :
306 * UPD Example program
308 * ADD DictSet methods
312 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
313 * Removed the Print/indent/default parameter mess. There is absolutely no
314 reason to have to methods, moreover with the second taking the ostream as
315 *SECOND* parameter. This was clearly a bad hack to get things compile.
317 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
318 * Complete rewrite of the GetMacAddress code. Now the code is *much*
319 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
320 Unfortunately the main code does not work on SunOS, thus provide a specific
321 code for this platform only (and Win32 of course). Since this seems to be
322 working, change CreateUniqueUID to use GetMACAddress instead of the
323 problematic GctestetIPAddress
325 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * Unfortunately to be able to test gdcmDirList I had to break the API
327 a little. Now the class is not a std::list anymore but has a member
328 std::vector (more ITK compatible). Allow unit testing on Win32 and
331 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Update SerieHeader to take into account a Serie Instance UID to properly
335 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
336 * ENH - Comment out Mathieu's (dangerous) Super Hack
337 for dealing with BIGENDIAN processors
338 - Move equivalent stuff to BinEntry::WriteContent
339 When necessary, 16 Bits Pixels are swapped in a small buffer
340 and then written. This avoid allocating a huge buffer, in
341 PixelWriteConvertor, and avoid modifying the Pixel Area.
343 Probabely, the same operation will have to be done when we want
344 to write image with Big Endian Transfert Syntax,
345 and we are working on Little Endian Processor
347 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
350 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
351 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
352 all the dict content.
353 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
355 * Test/TestDict.cxx : add a new test for the dict classes
357 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
359 file. Debug is yanked if compiled with NDEBUG
361 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
362 * src/gdcmDictSet.h : set the default output to the os variable
363 * src/gdcmDictEntry.[h|cxx] : add the Print method
364 * gdcmPython/demo/ : add a new test
366 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
367 * merging of Test/PrintDicomDir and Test/TestDicomDir
368 * removal of now redundant Test/PrintDicomDir
369 * enhancement of Example/PrintDicomDir
371 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Now, python test might work on systems
373 * Add the PrintDicomDir test
375 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
376 * FIX : First entry following group 0002 was lost for
377 Explicit Big Endian Transfer Syntax files
378 (group and elem not swaped)
380 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
381 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
382 Big Endian Transfer Syntax supposed the group following 0002
383 begins always by element 0000 (element 0000 is *optional*)
384 To avoid further troubles, let's be pessimistic, and use
385 Document::HandleOutOfGroup0002() method
386 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
387 (related pb not yet solved)
389 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
390 * Bug fix for the python part use
391 * Now, PrintHeader.py pass... but outside the ctest use. shit !
393 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
396 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
397 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
398 a string and should ask the global TS dict what are the propreties of
401 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
402 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
403 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
404 to swap the Swap Code, at parsing time, when we come out of group 0002
405 and Transfer Syntax is Big Endian
406 We should be able to read now 'true DICOM" Big Endian coded images
407 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
408 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
410 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * Hopefully fix the bug on MacOSX and static global initialization.
412 This is the only -minor- patch I found that both please MacOSX and VS6.
413 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
414 but this would require a lot of change. Another approach would be that Global
415 create those string and GDCM_UNFOUND becomes a pointer to a string (which
416 gdcm::Global would destroy at exit).
418 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * Fix bug on MacOSX with static initialization in a multy threaded
420 environment. static const string in a header file used to be ill
421 initialized provoquing the freeze of any tests. patch should solve this
424 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
425 * According to Benoit's suggestion, and without any objection from anybody
426 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
427 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
428 - method gdcmDicomDirObject::GetEntry() renamed as
429 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
431 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
432 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
433 you debug/warning message just as c++ streams which make them very convinient
434 to use. Once this is stabilize I will change the ostringstrem to be
435 redirected to a file (ofstream).
436 * Properly support C99 extension: __FUNCTION__ which allow us to display
437 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
439 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
440 * Removal of useless and dangerous methods :
441 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
442 GetDocEntryByName, GetEntryByName, GetDictEntryByName
443 * Removal of usless methods :
444 Dict::PrintByName, Dict::GetDictEntryByName
445 * Commenting out of probabely useless methods :
446 Dict::GetDictEntryNames()
447 Dict::GetDictEntryNamesByCategory()
448 DictSet::GetPubDictEntryNames()
449 DictSet::GetPubDictEntryNamesByCategory()
450 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
451 * ENH : Use dicomTS.dic as described in 2004 version
452 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
453 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
454 Add Accessors on VM (Value Multiplicity), and VM related methods
455 * ADD : Add a list of 'Dicom Attribute types', as found in
456 http://medical.nema.org/dicom/2004/04_15PU.PDF
458 * ADD : Add dicomGroupNameAbbreviations.dic
459 should be used to write a method to replace the former
460 Dict::GetDictEntryNamesByCategory()
462 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
464 to read in the file... and only it ! Length is the efective length of the
465 data in the DocEntry structure
467 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
469 And now use a static function call instead, with a global variable. i
470 This is much closer to the VTK approach. Hopefully should be bulletproof
471 and easier to use...hopefully
473 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
474 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
476 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
479 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
481 ValEntry, BinEntry, SeqEntry creation or replace
483 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
485 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
487 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
488 when specifying the VR
489 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
490 * src/gdcmDocEntry.cxx : amelioration of print
492 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
493 * ADD : Add the method Util::IsCurrentProcessorBigEndian
494 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
495 * ADD Method Document::ComputeGroupLength
496 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
497 in order to allow further VR modification by user
498 * REM : removal of once-called method File::WriteBase
499 integration of its code in formerly one-line method File::Write
501 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
503 replace the different values "??", "Unkn", "Unknown".
504 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
505 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
506 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
507 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
509 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
512 * Set the gdcm::Base class to some Printable classes
514 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * src/gdcmFile.[h|cxx] : add the Print method
516 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
517 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
518 * src/gdcmDocument.h : remove the PrintLevel informations
519 * Example/PrintFile.cxx : use the new gdcm::File::Print
521 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
523 problems when compiling with the python wrapping
525 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
527 writting in ImplicitVR
529 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
530 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
531 JPEG decompression, especially when dicom frames are split into several
532 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
533 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
535 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmHeader.cxx : change the initialisation of default header.
537 Now, this header is readable by gdm, e-film, DicomWorks
539 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
541 Rename Decompressed to Raw
542 * Use the API changes in gdcm::File.
543 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
546 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
548 each added entry in the header. Replace the 'Planes' field by the 'Number
551 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
553 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
555 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
557 At this time, this image isn't readable by e-film... waiting JPR help to
560 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
562 DocEntry. Now use methods of the Document !
564 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Test/ShowDicomSeq.cxx : bug fix
567 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
569 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
570 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
571 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
573 * Test/TestCopyRescaleDicom.cxx : remove unused variable
574 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
575 containing found sequences
577 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
580 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
581 Some fields in BinEntry must be copied to not seg fault when making the :
582 gdcm::File *copy = new gdcm::File( copyH );
583 and tests are now made on good variables
585 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
587 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
589 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
590 * Add vtkGdcmWriter example and test
592 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * Test/TestUtil.cxx : reformat the source code
594 * vtk/vtkGdcmReader.cxx : remove and change prints
595 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
597 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
598 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
600 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
602 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
604 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
606 by an eof to prevent all bad read of the file... and in this case, the
609 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * Example/Volume2Dicom.cxx : comment unused variables
611 * Test/PrintDicomDir.cxx : comment unused variables
612 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
613 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
614 method that is redondant with AddEntry.
615 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
618 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * Bug fix due my last commit (compilation under Windows).
620 * Example/Volume2Dicom : bug fix in the file and reformatting source code
621 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
623 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 - Remove printf / sprintf
626 - include iostream AFTER gdcm so we don't get warnings
627 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
629 - Also remove tons of include from header files, hopefully this should
630 speeup the compilation time, since it was becoming a dog slow.
631 - Remove gdcm.h as it include way too many files and slow down compilation
632 (plus it is not up to date)
633 - remove 'using namespace std' this is BAD !
635 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * Remove memory leaks on the DicomDir
637 * Remove some useless data in DicomDirObject
638 * Add usefull methods in SQItem, to be complient withe the ElementSet
640 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
643 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
645 future, with convertion)
646 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
647 and ImageDataSize values. Remove the method to get the PixelReadConverter
648 from the output of the class
650 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
653 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
655 and vtkErrorMacro use.
656 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
658 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
661 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
662 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
663 The string leaves only in the fonction. So when we make a .c_str(), we
664 get the pointeur on the first element, element that will be destroyed
665 immediately after thee instruction.
666 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
667 file has been opened : the test must be made on the content of the
668 pointer and not directly on the pointer !
671 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
672 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
673 the python part recompiles
675 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
677 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
678 X session is killed (for my computer... it seems to not be identic on
681 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
683 avoid problems (otherwise, the difference test between the visible image
684 and the reference is incorrect. If the reference is greater than the
685 screen resolution, it's produce errors).
686 Can be used for only one image. Can be used with a visible flag.
687 * vtk/vtkGdcmReader.cxx : remove commented codes.
688 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
689 under windows at compilation
690 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
692 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
694 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
696 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
697 tests on the image size X, Y, Z
699 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
701 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
702 between the class name and the file name
704 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * src/ : fix compilation warnings for the Write method (2 different
706 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
707 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
708 variable... create a static method in gdcm::Document to access to
709 this variable content.
711 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
713 file, to be accessed by other files (like gdcmFile). Remove commented
714 code. Move the change of the header to the gdcmFile, using the
716 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
717 To be sure of that (and simplify calls), the Write of the header now
718 gets a file name and not a file pointer (std::ifstream).
719 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
720 DocEntryArchive. Remove all open of the written file
722 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
725 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
727 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
729 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
730 some corresponding methods. Write correctly the file and check before
732 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
733 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
734 is now on RGB data (as before my last commit
735 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
737 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
738 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
739 Add a print information of the type of the entry
740 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
741 It was in the gdcmFile, and all write have been regrouped
742 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
743 Write correctly all dicom files (in decompressed mode only at this time)
744 * Test/ : test on files are now made using Raw data and not color data if
746 * Example/PrintFile.cxx : add more printings
748 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * Amelioration of code, remove some code copy. For the loading of
750 BinEntry (in gdcmDocument), add the test to verify if the file is already
753 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
755 remove a DocEntry in the header (push an empty DocEntry)
756 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
757 lines. Bug fix in the initialization of the PixelConvert and the
759 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
760 use in TestCopyDicom (now this test can run under windows... but fails)
761 * Test/TestCopyDicom.cxx : amelioration of the test :
762 - test the pixels written
763 - add test points to quickly find where is the error
764 - can set a file name input and output in arguments
765 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
766 amelioration of the test output
768 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
769 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
770 all replaced DocEntry's
771 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
772 Now, each needed DocEntry to modify is duplicated, modified and inserted
773 to the header using DocEntryArchive. Thus, after save, we can restore the
774 header initial state.
776 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
779 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
780 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
781 correct to copy it. The DictEntry is specified at the DocEntry creation,
782 then, it musn't change in the time.
783 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
784 header correctly. At this time, the change is only made for the first
785 level of the Document. In the future, it might consider sequences.
786 The change is made by replacing a DocEntry by an other that is created
787 outside the class. The old value is kept. When we restore the header
788 status, the added DocEntry is deleted and replaced by the old value.
789 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
790 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
791 set the write type to explicit VR, implicit VR or ACR. Add methods to set
792 the write mode to native, decompressed or RGB (but not used at this time)
794 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
795 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
796 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
798 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
800 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
802 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
803 set because already copied when copying the BinEntry's of the header
804 * Test/TestAllReadCompareDicom.cxx : remove warnings
806 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
807 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
808 Two problems appear when doing it :
809 - with the gdcmFile : when the GetImageData method is called, the pixels
810 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
811 data (pixels). And each structure destruct the data when it's
812 destructed. So we have two destructions for the same data. To solve it,
813 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
814 data or not. If it doesn't own data, then they will not destroyed by
816 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
817 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
818 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
819 create a double destruction of the same DocEntry's. So, to solve it,
820 the TagHT is simply cleared and the DicomDir* elements are destroyed.
821 * TODO : add an entry concerning memory leaks in the DicomDir
823 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
824 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
825 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
828 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
829 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
830 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
831 after it have been deleted
833 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * FIX: src/* fix the doxygen warnings.
835 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
836 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
837 was erroneously defined with a size of 15 instead of 16. [many thanks
838 to Jean Michel Rouet for pointing out this bug].
840 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
841 1. Finish merging JMR patch for writting DICOM from scratch
842 2. Fix -hopefully- bug with MONOCHROME and space vs null character
843 3. Use const ref when possible
844 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
845 5. A few more comments
846 6. CreateUniqueUID can now be called without parameter"
848 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
849 * ENH: Slightly bigger patch:
850 1. Getting toward full integration of JMR patch for writting dicom from scratch
851 2. Update Test to test part of this patch: CreateUniqueUID
852 3. File was not close properly in gdcmDict
853 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
854 5. Use of const ref instead of copy (speed issue)
855 6. Remove temporary (duplicate) string in TranslateToKey
856 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
857 8. Do not repeat virtual in subclasses
858 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
860 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
861 * Apply first patch toward better string comparison when dealing with broken
862 DICOM files. Essentially the string could be padded with a space instead
863 of a null character as defined by standard
865 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
866 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
867 because never used... and in the same time, that's remove some memory leaks
869 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
870 * src/gdcmFile.cxx : now delete the PixelConvert instance.
871 * In examples and tests : change the type of image data variables from void*
872 to uint8_t*. Remmove all delete on image data variables
874 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
875 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
876 Verify the file pointer value before open the file, and if it's not null,
877 a verbose message is generated.
878 Close correctly the file when the file isn't considered dicom-like. The
879 correctly close is a call to CloseFile.
880 When closing the file pointer, test if its not null to close the file.
881 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
882 file. For an uncompressed image, the copied data correspond in the least
883 case to the image size (calculated) or the image size specified in the
884 header. A verbose is generated if these two size mismatch
886 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
887 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
888 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
889 break under windows (with msvc6 compilation).
891 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
892 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
893 compiling with MSVC6)
895 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
896 * Bugs fix for the Windows build with VC6
897 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
898 needed (only for projects required VTK). If the VTK is included in all
899 projects, there is conflicts with the jpeg lib of vtk when compiling the
900 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
901 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
902 when compiling the gdcm_wrap.cxx file (created by the compilation of the
904 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
905 (like it's already made for the cout use). Otherwise, conflict with the
908 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
911 - comments on the DicomDir::Method related usage added.
912 - now that we use the namespace gdcm, a lot of internal classes do
913 NOT need to be wrapped anymore.
914 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
915 DicomDir::Method) new example added.
917 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * Improve string manipulation. I now inforce the notion of 'DicomString'
919 A DicomString can contain as many \0 as they want
920 and it is *always* of even length.
921 We only support odd length for very rare case.
922 And in the near future this should be removed.
924 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
925 * /binary_write/ gdcm source. Now even on big endian we are writting
926 little endian. This should -heopfully- fix some tests
928 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Now the dictionary is compiled into gdcm lib. This is a default
930 behavior, thus any dic file specified is picked before failback to
931 the one comiled into lib
933 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * Change internals for gdcmDict. Don't use any 'new' any more.
935 This should definitely solve any leak problem, and we should be
936 as fast as before, as long as don't modify too much the dictionary.
938 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * STYLE: ivars should start with a capital letter.
940 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
941 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
943 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
945 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
946 new 2004 dictionaries added (thanks to JPR).
947 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
948 * CLEANUP_ROUND (15) for gdcmPixelConvert
949 - RLEFrame::NumberFragments is now of type unsigned int
950 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
951 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
954 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
955 * Initial work in gathering all transfer syntax accessors. clearly
956 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
957 ivars, but only one transfersyntax (class) ivar with equivalent method on
960 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
961 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
962 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
963 discussed (plus I didn't like having a 2000 lines patch not commited)
965 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
967 * CLEANUP_ROUND (14) for gdcmPixelConvert
968 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
969 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
970 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
972 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
973 anymore and hence avoids storing a copy of PixelConvert::Decompressed
974 into File::Pixel_Data.
976 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
978 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
979 * CLEANUP_ROUND (13) for gdcmPixelConvert
980 Substituted File::ParsePixelData() with PixelConvert::Print() new
982 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
983 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
984 method to those classes.
985 - src/gdcmFile.[cxx|h]:
986 -- Added a ::Print() method.
987 -- PixelConverter is now a reference instead of a member.
988 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
989 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
991 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
993 collaboration diagram and inheritance diagram should be generated with
995 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
996 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
997 pointlessly wrapped (see
998 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
999 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1000 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1001 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1002 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1003 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1004 -- File::Initialise: PixelConverter setup moved away to
1005 PixelConverter::GrabInformationsFromHeader()
1006 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1007 interpretation moved away to PixelConverter::BuildRGBImage()
1009 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1010 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1011 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1013 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1015 displayed on Win32 when a brutal abort() occurs (because of uncatched
1016 exception). See TODO new entry of this commit for more on this.
1017 * TODO added new entry.
1018 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1019 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1020 - HandleColor is no longer called from gdcmFile.cxx
1021 - gdcmPixelConvert.cxx clean up on method arguments and internal
1022 variable names for semantical coherence.
1024 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1025 * Finished lossless transition, not only do we now read all lossless jpeg
1026 images, without the need of the Cornwell lib, but we do read them properly now
1027 * To reduce code (well to avoid code duplication), I defined a common place
1028 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1029 redefine symbols. This is not perfect but this the best solution I found for a
1030 compilation time jpeg option.
1032 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * Update jpeg ijg lib to support lossless jpeg implementation
1034 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1036 * Also added a special copyright for dcmtk since we use their bugfixes.
1039 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1041 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1042 matters, as stated in warning note at beginning of %include section).
1043 * src/gdcmDicomDir*.[cxx|h]: coding style
1044 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1045 * src/gdcmJpeg8.cxx: doxygen fix.
1046 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1047 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1048 from File:: to PixelConvert::.
1050 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1052 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1053 - more code moved away from File:: to PixelConvert::
1054 - fat setup of PixelConverter set in place in File::Initialise.
1056 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1057 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1058 namespace at the file system level. So now you should convert your examples
1060 gdcmHeader -> gdcm::Header
1061 It would be nice if people keep in mind to no open the namespace, since it
1062 allows compilation on broken plateform which were defining common symbol in
1063 the standart namespace (like LP, Unknown ...)
1065 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1067 The JPEG fragments are now parsed at the same stage than the RLE
1068 information. All code related to JPEG is now in gdcmPixelConvert:
1069 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1070 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1071 export a gdcmFile:: method. Those are simply global functions
1072 (for the time being this is better than having them attach to
1073 either gdcmFile:: or gdcmPixelConvert::).
1074 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1075 and stores the result in a gdcmJPEGFragmentsInfo.
1076 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1077 code (among other stuff) moved away from gdcmFile:; to
1080 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1082 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1083 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1084 clean up of RLE related code.
1085 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1086 - src/gdcmRLE.cxx removed
1087 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1088 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1089 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1090 * CLEANUP_ROUND (9) for gdcmPixelConvert
1091 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1092 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1093 away from gdcmFile:: to gdcmPixelConvert::.
1095 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1097 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1098 This is because Parse7Fe0 used to parse the pixels to compute the
1099 length. This task was passed over to FindDocEntryLengthOB() a long
1100 time ago, EXCEPT I had forgotten the OW case...
1101 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1102 we just recylce the code for parsing RLE fragments and computing
1104 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1105 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1106 with the retired Parse7Fe0().
1107 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1108 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1110 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1111 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1112 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1113 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1114 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1115 * CLEANUP_ROUND (4) for gdcmPixelConvert
1116 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1117 to return an unused length.
1119 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1121 this should be cleanner from the plane view. The iostream are erally a pain
1122 to use to do simple stuff.
1124 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1125 * Redo the compilation of the ijg jpeg library. Now only one source is
1126 necesseray. No need to rename file by hand what so ever. CMake handle the
1127 copying of the file within different directory, configure header file to
1128 modify some symbol. The only addition made to ijg wasd a mangle table so
1129 that symbol are different whether we are within 8bits or 12bits.
1131 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * Added documentation of vtkgdcmReader on Website:
1133 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1134 with it's binary name).
1135 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1136 the Website to be more complete.
1137 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1138 doxygenated documentation.
1139 - Doc/DoxyVtkGdcmReaderExamples.txt added
1140 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1141 DoxyVtkGdmReaderExamples.html )
1142 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1143 * CLEANUP_ROUND (3) for gdcmPixelConvert
1144 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1146 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * CLEANUP_ROUND (2) for gdcmPixelConvert
1148 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1150 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * CLEANUP_ROUND for gdcmPixelConvert:
1152 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1153 - src/gdcmPixelStuff[h|cxx] removed
1154 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1155 - src/CMakeLists.txt changed accordingly
1156 * GDCMHOME clean up:
1157 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1158 gdcmVersion.py moved to newly created ATTIC related
1159 gdcmPython/SetupOldies/ directory.
1160 * Autotools clean up:
1161 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1162 - autogen.sh configure.in acinclude.m4 python.m4 removed
1164 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1166 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1167 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1169 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * TODO updated with Mathieu suggestions. I proposed a template for
1171 describing TODO entries and used it for new entries.
1172 * Added Doc/Website/CodingStyle.html, Developpers.html,
1173 DeveloppersPython.html, GdcmDataCvs.html and
1174 DownloadVersion0_1.html, DownloadVersion0_3.html.
1175 * Some Doc/*.txt Doxygen files (which do not really concern the
1176 documentation itself, but the website) moved to html and
1177 placed in directory Doc/Website:
1178 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1179 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1180 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1181 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1182 * CMakeLists.txt changed accordingly.
1183 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1184 DeveloppersPython.html
1185 * INSTALL nows refers to Doc/Website/Installation.html
1187 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * Added Doc/Website directory, that contains a first raw version
1191 2004-09-23 Jean-Pierre Roux
1192 * FIX In order not to be poluted any longer by casting problems,
1193 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1194 we can now delete[] it safely
1195 * VoidArea is now called BinArea (less confusing name),
1196 and all the methods called ...VoidArea... are now ... BinArea...
1197 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1199 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1201 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1202 up to the destructor of gdcmElementSet to clean up TagHt and it's
1205 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1206 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1207 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1209 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1210 * ENH: added some utility method that builds a flat dictionary
1211 holding all the Dicom entries contained in the recursive structure
1212 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1213 an example of usage.
1214 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1215 BuildFlatHashTable() that build a flat dictionary.
1216 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1217 gdcmDocument is now a friend of gdcmElementSet.
1218 - src/gdcmElementSet.cxx: clean up.
1219 - Example/FlatHashTablePrint.cxx added.
1220 - Example/CmakeLists.txt changed accordingly
1222 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1224 moved away from gdcmDocEntrySet (since this class is an abstract class
1225 acting like an interface). SQDepthLevel and BaseTagKey are now
1227 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1228 and associated accessors. Doxygenation of the class.
1229 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1231 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1232 Use SQDepthLevel accessor instead. ::Print() adapted.
1233 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1234 - src/gdcmDocument.cxx changed accordingly.
1236 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1238 - The following is the doxygen comment of the typedef declaration
1239 of gdcmTagKey in src/gdcmCommon.h:
1240 gdcmTagKey is made to old an "universal" (as in URL, Universal
1241 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1242 A dicom tag always has a group and an element, but a set of tags
1243 embeded in various (optionally nested) sequences and sharing
1244 the same group and element all share the same (group, element)
1245 "identifier". Hence the (group, element) cannot be used as an
1246 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1247 In order to construct a proper tag identifier (i.e. a key) we
1248 consider the following definition of a TagKey:
1249 - let Group, Element be the string representation of the
1250 group and element dicom tag members,
1251 - let ItemNumber be the string representation of the integer
1252 index of the considered item number of a sequence,
1253 Let the key of a tag embeded in a sequence, noted SeqTag, be
1255 /ItemNumber#Group|Element
1256 where "/", "#" and "|" are characters acting as separators.
1257 Then the general form of a gdcmTagKey is given by:
1258 Group|Element<SeqTag>
1259 where <SeqTag> means NO or many instances of SeqTag.
1260 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1263 but the gdcmTagKey of a tag "embeded" is the first item of
1264 a sequence, itself nested in the third item of a sequence is the
1266 0004|1220/2#0008|0082/0#0008|0090
1267 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1268 order to hold the new sequence compatible key. Previously, the
1269 GetKey() method would look in the underlying gdcmDictEntry.
1270 - src/gdcmDocEntry.cxx:
1271 -- constructor now copies the underlying DictEntry key, in the local
1273 -- ::Print: displays the member Key, instead of the (group, element).
1274 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1275 - src/gdcmDocEntrySet.h:xi
1276 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1277 -- now has a new BaseTagKey member.
1279 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1280 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1282 This poses the problem with the semantics of the following lines
1283 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1284 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1285 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1286 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1287 to the long FIXME note for what the problem is. Nevertheless in
1288 order to get things working the dicom dictionary was altered !
1289 Please fix things urgently...
1290 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1291 information), see above note on moving the member VoidArea. Nevertheless
1292 the following entries previously correctly set as US are now inproperly
1294 0028 1201 OW IMG Red Palette Color Lookup Table Data
1295 0028 1202 OW IMG Green Palette Color Lookup Table Data
1296 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1297 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1298 of gdcmDocEntry moved to gdcmSeqEntry.
1299 * src/gdcmSeqEntry.cxx: STYLE.
1301 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1304 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1305 * gdcmPython/testSuite.py: all the test suite in python is now moved
1306 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1307 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1308 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1310 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1312 to avoid inclusion recursion until STL is reached.
1313 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1314 mecanism. errno.h is not included in gdcm anymore.
1315 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1316 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1318 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1319 gdcmData/TestAllEntryVerifyReference.txt
1320 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1321 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1322 exception_on_error parameter.
1323 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1324 - vtk/vtkGdcmReader.cxx changed accordingly,
1325 - Example/*.cxx and Test/*.cxx changed accordingly.
1327 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1329 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1330 enable_sequences removed from gdcmHeader constructor and dependencies.
1331 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1332 * gdcmPython/demo/PrintHeader.py: dummy fix.
1333 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1334 skip_shadow removed from gdcmHeader constructor and dependencies.
1335 * Example/*.cxx and Test/*.cxx changed accordingly.
1337 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1339 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1341 2004-07-21 Jean-Pierre Roux
1342 * FIX Now, Parsing and Printing a DICOMDIR do work!
1343 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1345 2004-07-20 Jean-Pierre Roux
1346 * FIX Some brain damaged headers have Zero-Lenght fields
1347 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1349 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1350 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1351 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1352 variable (instance of gdcmDebug) by a definition macro, and the instance
1353 is now in static in the gdcmDebug class
1354 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1355 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1357 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1358 * WARNING: ctest now depends more tightly on gdcmData. You should
1359 check out gdcmData properly for things to run smoothly...
1360 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1361 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1362 we need the pixels not be loaded in order to use the ValEntry
1363 that displays position and size).
1364 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1365 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1366 be deprecated. If you have any doubts about the advantages of a
1367 modern scripting language (read Python) versus grass root C++ (i.e.
1368 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1369 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1370 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1371 Anyhow, consider documenting the gdcmData images in
1372 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1374 * Test/CMakeLists.txt:
1375 - now uses TestAllEntryVerify.cxx
1376 - specific comments on oldACR00001.ima (now renamed in gdcmData
1377 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1378 gdcmData/TestAllEntryVerifyReference.txt
1381 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * src/*.[h|cxx] : typedef clean up
1383 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1384 - TagKey renamed to gdcmTagKey (for external usage)
1385 - VRKey renamed to gdcmVRKey (for external usage)
1386 - removal of typedef duplication.
1387 - Removed all unecessary inline keyword from class inline definitions.
1388 - Some method|function(void) declarations replaced with method|function().
1389 * src/jpeg/libijg12/jdhuff12.c:
1390 - printf polluting ctest removed.
1391 - TAB removal for comminting
1393 - TestAllReadCompareDicom.cxx: added a test that compares all the
1394 images in gdcmDataImages.h with corresponding images in
1395 gdcmData/BaselineDicom/. When baseline images are not present
1396 this test creates them.
1397 Note: we need to validate each reference image, but before that
1398 I'd like to rename them with a more explicit name...
1399 - CMakeLists.txt: changed accordingly.
1400 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1401 including each header needed).
1403 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1405 test suite to the Example directory. Are concerned:
1410 - TestWriteSimple.cxx
1411 * Test/CMakeLists.txt: added some comments on reasons for black listing
1412 image gdcmData/oldACR00001.ima
1414 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * Test/CmakeList.txt: removed the following from black list (to be coherent
1416 with removal from gdcmData):
1417 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1418 - gdcm-MR-PHILIPS-16.dcm
1420 Added the following because after last cvs update, they cause
1421 ctest -R TestReadWriteReadCompare
1423 - gdcm-MR-SIEMENS-16-1.acr
1425 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1426 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1427 new comments in this file) we temporarily (sigh) move to a weaker
1429 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1430 we don't need to black list the following images anymore:
1431 - 8BitsUncompressedColor.dcm
1433 - US-PAL-8-10x-echo.dcm
1434 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1435 fixes and the beautified code ;-)
1436 This fixes the bug introduced in version 1.42 (when beautifying)
1437 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1438 Note: ctest was blind to this bug (this means we need to still
1439 improve the test suite). The bug could be detected by using
1440 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1442 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1443 and by displaying the (garbage) produced file temp.XDCM...
1445 2004-06-29 Jean-Pierre Roux
1446 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1447 - replace by uggly but working old code :-(
1448 A lot of things should be OK again.
1449 It's really urgent to have a test suite that *tests*,
1450 to prevent Frog's beautifying sessions to break all the stuff
1451 (twice, withing a fortnigh ...)
1453 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1454 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1455 redundancy) to added Test/TestReadWriteReadCompare.cxx
1456 * Test/CmakeList.txt: because the compare test of
1457 Test/TestReadWriteReadCompare.cxx fails, the following images are
1458 black listed: - 8BitsUncompressedColor.dcm
1460 - US-PAL-8-10x-echo.dcm
1461 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1462 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1463 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1464 and ad-hoc kludge. This kludge is now removed, and on encountering
1465 such an image (OB field brain damaged) we set errno. Then in
1466 ::FindDocLength() we "fix" the length as being ALL what remains
1467 in the file (until EOF). We then proceed, hoping for the best...
1468 This fixes a SegFault in ShowDicom when trying to write such an
1470 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1471 (because TestWriteRead breaks on it, after a non conformal commit?).
1472 ctest now runs properly, except for MakeDicomDir (which was always
1473 broken) and the Python related stuff (still not fixed).
1475 2004-06-24 Jean-Pierre Roux
1476 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1477 FIX : Test/TestReadWrite now iterates on all the file names
1478 (instead of infinite loop)
1479 ENH : Test/TestWriteRead now iterates on all the file names
1481 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1484 2004-06-24 Jean-Pierre Roux
1485 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1486 when SamplesPerPixel =3
1487 - now Write is no longer confused by
1488 'BitsAllocated = 12" and 'BitsStored=12"
1489 - "UN" value representation Elements are now written correctly
1490 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1491 ENH : - now gdcmHeader has its own Write methods
1492 (in order to split the job that has not to be done
1495 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1497 loop on the same image until memory went out.
1498 Note: this means we still have gobs of memory loss in PrintDocument
1499 * src/gdcmDocument.cxx: fixes problem on parsing on file
1500 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1502 2004-06-24 Jean-Pierre Roux
1503 FIX : Write - All the Sequences and Sequence Item are now written
1504 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1505 is added a the end, when necessary.
1506 - A lot of brain-damaged images, that were read correctly are
1507 now written correctly
1508 - length compatible BinEntry are now loaded correctly
1509 (even for odd groups)
1510 Note : only Explicit Value Representation was checked.
1511 (question : is implicit VR really necessary for gdcm ?)
1513 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * DEVELOPPER: added a proposition of coding style.
1515 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1518 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1519 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1520 Use the gdcmDocEntry::Print() and Write() instead.
1521 * src/gdcmDocument.cxx: bug fix.
1523 2004-06-22 Jean-Pierre Roux
1524 FIX : gdcmDocument.cxx
1525 - Now we do recognize the JpegLossLess format (there was a misstyping in
1526 code 'beautyfication' :-(
1527 - Now we automaticaticaly load the Luts, if any
1529 2004-06-22 Jean-Pierre Roux
1530 In order : to write Sequences, whatever their imbrication level,
1531 : to allow user to create his own Sequences
1532 a lot of modif where necessary (adding, moving, or virtualising methods)
1534 WARNING : save your own sources *before* cvs up !
1537 ADD virtual void Write(FILE *fp, FileType filetype);
1540 ADD virtual void Write(FILE *fp, FileType filetype);
1541 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1544 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1545 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1546 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1547 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1548 ADD std::string GetEntryByName(TagName name);
1549 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1551 std::string vr = "unkn",
1552 std::string fourth = "unkn",
1553 std::string name = "unkn");
1554 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1555 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1556 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1557 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1558 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1559 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1560 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1561 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1564 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1565 ADD virtual std::string GetEntryByName (TagName tagName);
1566 ADD virtual std::string GetEntryVRByName (TagName tagName);
1567 REM virtual bool Write(FILE *, FileType);
1568 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1569 FILE *_fp, FileType type);
1570 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1571 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1572 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1573 REM virtual std::string GetEntryByName (std::string tagName);
1574 REM virtual std::string GetEntryVRByName (std::string tagName);
1575 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1576 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1577 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1579 std::string vr = "unkn",
1580 std::string fourth = "unkn",
1581 std::string name = "unkn");
1582 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1583 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1584 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1585 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1588 ADD virtual void Write(FILE *fp, FileType filetype);
1591 ADD virtual void Write(FILE *fp,FileType filetype);
1594 ADD virtual void Write(FILE *fp, FileType filetype);
1595 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1596 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1597 REM std::string GetEntryByName(TagName name);
1600 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1602 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1603 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1604 The default constructor invoked by the line
1605 gdcmHeader *f1 = new gdcmHeader( header );
1606 was gdcmHeader::gdcmHeader(bool) instead of the expected
1607 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1608 Hence the parsing wasn't executed... See also below.
1609 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1610 as explicit constructor didn't do the trick to fix the above problem.
1611 Could anyone explain why ?
1612 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1613 properly calls gdcmValEntry::Print() (that was weed out from
1614 code related to gdcmBinEntry).
1616 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * In order to fix memory leaks:
1618 - Test/TestWriteSimple.cxx: added cleaning of free store through
1620 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1621 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1622 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1623 (through the call to ::AddDicomDirMeta()) or the destructor
1624 would crash when deleting uninitialized ::metaElems].
1625 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1626 - src/gdcmDocument.cxx:
1627 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1628 from dynamic stores.
1629 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1630 was causing memory leaks.
1631 - src/gdcmSQItem.cxx:
1632 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1633 cleanly handled with polymophism: sorry but my milage is low).
1634 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1635 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1636 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1637 This avoids SegFaulting.
1638 - src/gdcmSQItem.h: coding style.
1640 - Test/TestWriteSimple still severely sucks. The output image content
1641 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1642 damaged when displayed with vtkgdcmViewer.
1643 - on memory leaks: TestWriteSimple leaks really less (see entry
1644 of 2004-06-18 in Changelog file for the call to valgrind).
1645 - on segfaults: ctest now passes all the tests but one (no more
1647 * Erroneous leading white fix:
1648 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1649 white[s] (as opposed to from >> xxx, that removes it [them].
1650 - src/gdcmTS.cxx: ditto.
1651 - gdcmPython/testSuite.py: dirty related kludge removed.
1652 * src/*: remaining references to gdcmParser removed.
1653 * src/*[cxx|h]: added copy[way]left header.
1656 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * In order to fix writing of dicom files:
1658 - Test/TestWriteSimple.cxx: a simpler example of writing.
1659 - Test/CMakeLists.txt changed accordingly.
1660 - src/gdcmDocument.cxx:
1661 -- The destructor now recursilvely removes potential sequences.
1662 -- Bug fix in ::IsJPEG2000()
1663 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1664 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1666 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1667 to only declared) and build on top of
1668 ::GetDocEntryByNumber(guint16, guint16).
1669 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1670 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1671 for usage in destructor and treatement of promotion in
1672 ::ReplaceOrCreateByNumber().
1673 - src/gdcmSQItem.cxx: destructor should better handle his job.
1674 Test/TestWriteSimple now runs (or at least it DOES something).
1675 * We can now start hutting memory links. A good starting point is:
1676 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1677 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1678 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1680 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1681 * Valgrind note: after Mathieu Malaterre teached me how to read
1682 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1684 Using gcc, you can force the STL to use malloc and to free memory as
1685 soon as possible by globally disabling memory caching.
1686 With 3.2.2 and later, you should export the environment variable
1687 GLIBCPP_FORCE_NEW before running your program.
1688 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1689 simply vanish (it is still not clear to me, whether this means that
1690 STL std::string leaks or if valgrind believes it leaks...).
1691 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1692 running bin/gdcmTests makeDicomDir):
1693 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1694 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1696 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1697 SegFaulting (I drowned in DicomDir related code when trying to
1698 understand why the list is empty...).
1699 * src/gdcmDocument.h: first BSD license header try.
1700 * Doc/License.txt added.
1702 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * src/gdcmDocument.[h|cxx]:
1704 - Clean up of the Transfer related predicates. They are now all based
1705 on new method isGivenTransferSyntax, that (should) handle properly
1706 the padding problem.
1707 - general clean up, simplification, and coding style.
1708 - Specific clean up of Parse7FE0() (umproperly named actually).
1709 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1711 2004-06-14 Jean-Pierre Roux
1713 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1714 - fix the display of SQItem ordinal number
1715 - add the GetSQItemByOrdinalNumber method
1716 - remove some useless never written private methods
1718 2004-06-14 Jean-Pierre Roux
1720 - adding a constructor taking a gdcmDocEntry as an input param
1721 - ReplaceOrCreateByNumber now returns :
1722 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1723 a gdcmValEntry * if a string value is passed as a param
1725 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1726 according to the param type (no longer sets a gdcmDocEntry)
1727 - GetValEntryByNumber, GetBinEntryByNumber added
1728 - NewValEntryByNumber and NewBinEntryByNumber added
1730 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1732 - GetSQItemNumber and SetSQItemNumber added, to provide
1733 a (relative) Item identier inside a given Sequence
1734 \warning : some pb remaining around this number
1736 - AddEntry now takes the Item Number as a param
1738 - adding a constructor taking a gdcmDocEntry as an input param
1740 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1741 * Memory leak hunt with the following command:
1742 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1743 --show-reachable=yes gdcmTests PrintDocument
1744 It looks like many (all?) leaks are due to the STL (or a bad usage
1745 of the STL. The lines producing the leaks now have a comment with
1746 a "MEMORY LEAK" tag: you can retrieve them with
1747 grep "MEMORY LEAK" src/*
1748 Here are two typical examples which I can't help fixing:
1753 char * test = "babo";
1754 name = test; //// <--- valgrind detects 960 bytes lost in
1755 //// call to std::string::operator=(char const*)
1756 name.clear(); //// Doesn't help !
1764 std::cout << "Type a bunch of characters followed by RETURN: ";
1765 getline(std::cin, line); //// <--- valgrind dectects a loss
1766 //// of 1320 bytes in call to
1767 /// std::basic_istream<>& std::getline<>
1773 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * src/gdcmHeader.[cxx|h]:
1775 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1776 and related, moved away to gdcmDocument.
1777 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1778 the corresponding protected accessors of inherited class
1779 gdcmDocument, removed ! As a consequence gdcmFile had to be
1780 declared friend of class gdcmDocument (see below).
1781 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1782 - Clean up of undefined or unused methods.
1783 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1784 account the changes to gdcmHeader.h).
1785 * src/gdcmDocument.h:
1786 - gdcmFile is now a friend class (in order to take into account the
1787 changes to gdcmHeader.h).
1788 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1789 (see changes to gdcmHeader.h).
1790 - Accessors (reading on the form GetEntry*) are now public.
1791 - Clean up of undefined or unused methods.
1792 * src/gdcmDocument.cxx:
1793 - adaptation to changes to gdcmDocument.h
1794 - ::OpenFile now writes a verbose message when file cannot be opened.
1795 - some std::string properly set to VRKey
1796 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1797 references to gdcmDocument.
1798 * Test/TestFindTags.cxx: changed accordingly to above changes.
1799 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1800 cvs repository gdcmData.
1802 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1804 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1805 conflicts with gdcmValEntry::voidArea.
1806 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1807 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1808 Value representation between StringRepresentable and BinaryRepresentable.
1809 * src/gdcmDocument.cxx:
1810 - method ParseDES: proper indentation restored and usage of
1811 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1812 - method LoadDocEntry: the fingerprint left in the SetValue() of
1813 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1814 removed. Reverting to previous code segment with the proper
1815 dynamic_cast< gdcmValEntry* >.
1816 Note: this was (partially) breaking the python test suite
1817 (gdcmPython/testSuite.py) that made usage of the above
1818 fingerprint to check presence of "Pixel Data".
1819 * src/gdcmDocEntry.h: coding style.
1820 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1821 now taken into account.
1822 * gdcmPython/gdcm.i: adaptation to the new internal representation
1823 of gdcm (exit gdcmParser, hello gdcmDocument).
1824 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1826 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1827 anymore, but instead prints the loaded Python dictionary.
1828 * .... alas, the python testSuite is still broken.
1830 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1831 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1833 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1834 * src/gdcmUtil.h : export methods
1836 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1839 * Initial addition of automatic python testing
1840 * Initial addition of automatic image comparison
1842 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1843 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1844 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1846 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1847 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1848 * Test/ShowDicom.cxx : bug fix for msvc compilation
1849 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1851 2004-05-04 Jean-Pierre Roux
1852 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1853 new concepts (and new classes) :
1854 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1855 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1856 - Sequence Doc Entries (gdcmSeqEntries)
1857 a Sequence is composed of Items.
1858 Each item is a set of Doc Entries (this is recursive)
1859 The non uniqueness of the 'Dicom tag' is due to this recursivity
1860 (never taken into account)
1861 Our unability to add a new 'entry' in the header
1862 at the proper location (neither in the H-Table (map or multimap),
1863 nor in the Chained List is also due to this recursivity.
1864 Don't try, right now, to use/modify/compile these new sources :
1865 nothing is finished.
1866 We just commit all the stuff, 'as is', in order not to loose it.
1868 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1869 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1871 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1872 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1873 file prefix (SetFilePrefix)
1875 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * Add a new test: ShowDicom, for now this is just the c++ version of
1877 checkRead.sh, later it will be able to compare the image read against a
1879 * Replace the DEBUG on the stack with a global entry in cmake interface:
1880 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1882 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * Add an example subdir, with a real example on how to read + write a
1886 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1888 * Doc/CMakeLists.txt: the main page is now properly differentiated
1889 between the developper and user version.
1890 * Doc/doxygen.config.in: dropped search related obsolete flags
1891 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1893 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1894 * DEVELOPPER: added some helpfull comments for compile/test/install
1897 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1899 src directory, now generated in the build dir.
1900 2. Tests as mentionned smarter
1902 4. Add a new method in gdcmDict that return the PubDict by name
1903 this is interesting for 3rd party lib like ITK,
1904 where we could set the institution name / patient name...
1906 * ENH: 1. Now the test suite is working for real
1907 2. All binaries are now output in the gdcm-bin directory
1908 (this was not true before)
1910 2004-04-28 Jean-Pierre Roux
1911 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1912 SeQuence indented printing of Dicom Header.
1913 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1914 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1915 Computation of SQDepthLevel is now part of gdcmHeader constructor
1916 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1917 tree-like structure of a Dicom Header.
1918 * FIX Test code cleaning
1920 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * ENH: Adding automatic testing
1922 1. Need a DartConfig.cmake to submit to public
1923 2. Add a test driver gdcmTest.cxx
1924 3. gdcmTestMain, an helper for the main test driver gdcmTest
1925 4. Files in Test don't have a main anymore, this becomes interesting
1926 when we add more and more tests, thus dsw don't have to load
1928 * ENH: Adding a GDCM_DATA_ROOT for testing
1929 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1930 one file instead of seven + some small cleanup
1932 2004-04-22 Jean-Pierre Roux
1933 * ENH Minor changes to the Print() methods.
1934 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1935 Header printing. Example given with :
1936 > PrintHeader fileName 2 new
1937 (SQ based tree-like structure still to be done for the Header ...)
1939 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1940 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1941 1. I have added some unsigned where needed
1942 2. Some function parameter not used -> (void)
1943 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1944 4. g++ don't like character '\' in comment
1945 5. #define jpeg_create_decompress jCreaDecompress
1946 this really need to be fixed
1947 6. virtualize destructor of gdcmObject ... leakage
1948 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1949 this also really need to be fixed
1950 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1951 remove compression file
1952 (as we only do decompression, right ?)
1953 * ENH: Change malloc/calloc/free with c++ equivalent
1955 2004-04-21 Jean-Pierre Roux
1956 * FIX gdcmHeaderHelper::GetXSpacing
1957 when a single value is found (bug ?), xpacing is now
1958 defaulted to yspacing
1960 2004-04-19 Jean-Pierre Roux
1961 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1962 * ENH add parameters :
1963 bool exception_on_error = false,
1964 bool enable_sequences = false,
1965 bool ignore_shadow = false
1966 to the gdcmFile constructors to be full gdcmParser compliant
1967 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1968 to allow reading of PAPYRUS 3.0 files
1970 2004-04-06 Jean-Pierre Roux
1971 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1973 2004-04-02 Jean-Pierre Roux
1974 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1975 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1976 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1978 2004-03-30 Jean-Pierre Roux
1979 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1980 for ACR file, written out as DICOM files (hope so...)
1982 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1983 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1984 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1985 moved to base class gdcmParser and only the specialisation is kept
1987 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1988 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1989 already does the job.
1990 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1991 (to be consistent with gdcmParser::WriteEntries).
1993 2004-03-30 Benoit Regrain
1994 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1995 upate of the object's instance. It's passed to 2 in the unfavorable
1996 case : one in the ExecuteInformation, one in the ExecuteData
1998 2004-03-29 Jean-Pierre Roux
1999 * ENH : Check on file type to be written moved
2000 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2001 * FIX : gdcmObject::ResetBoundaries now stops properly
2002 when end-of-list is reached
2003 : gdcmVersion modified (as Benoit Regrain asked)
2005 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2007 * src/gdcmUtil.cxx: added forgotten iostream include.
2008 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2009 equivalent to ExplicitVR in existing code).
2011 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2013 now contains all the gdcmGlobal related code.
2014 * minor coding style and doxygenation changes.
2016 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2018 now contains all the Debug related code.
2019 * minor clean-up of includes in src/*.cxx
2020 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2021 CreateCleanString) removed.
2022 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2023 * Doc/DoxyMainPageUser.txt added.
2024 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2025 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2026 src/gdcmDirList.cxx)
2028 2004-03-24 Jean-Pierre Roux
2029 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2031 2004-03-23 Jean-Pierre Roux
2032 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2033 big endian made volumes
2034 * ENH Now gdcmParser constructor and destructor are protected to forbid
2035 end user to instanciate class gdcmParser
2036 (only gdcmHeader and gdcmDicomDir are meaningfull)
2038 2004-03-22 Benoit Regrain
2039 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2040 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2041 gdcmSerie to gdcmDicomDirSerie
2043 2004-03-19 Jean-Pierre Roux
2044 * ENH Now the tree-like structure describing a DICOMDIR comming from
2045 an already existing DICOMDIR file is consistent with
2046 the home-made tree-like structure build ex-nihilo
2047 or build from the files held (recursively) in a Directory
2048 functions gdcmDicomDir::CheckBoundaries()
2049 gdcmObject::SetBoundaries() added
2051 2004-03-17 Jean-Pierre Roux
2052 * REM (Eric Boix bug) : removal of meaningless
2053 gdcmDicomDirImage::NewImage function.
2054 * FIX now file names and directory name are written properly in the
2056 * FIX now gdcmDicomDir constructor may be call without any trick
2059 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2061 of gdcmDicomDirImage::NewImage as empty function.
2063 2004-02-28 Jean-Pierre Roux
2064 * ENH add gdcmDicomDir:NewPatient
2065 add gdcmDicomDirPatient:NewStudy
2066 add gdcmDicomDirStudy:NewSerie
2067 add gdcmDicomDirSerie:NewImage
2068 to allow making gdcDicomDir object.
2069 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2070 (as opposite to the gdcmHeader chained list)
2072 2004-02-11 Benoit Regrain
2073 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2074 when using from python
2076 2004-02-10 Benoit Regrain
2077 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2078 * FIX : in gdcmDicomDir when the directory is empty
2079 * ENH : add callback and methods to get the progression of dicomDir
2082 2004-02-06 Jean-Pierre Roux
2083 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2084 - GDCM_META added to gdcmDicomDirType
2085 - class gdcmMeta created
2086 * ENH : - A brief summary is now displayed at the beginning of
2087 'testDicomDir' to help disaster magnitude estimation
2088 * REM : Now useless Test/explDICOMDIR.cxx
2090 2004-02-05 Benoit Regrain
2091 * ENH : add methods in gdcmObject to get the hash table or the list of
2093 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2094 * FIX : wrapping python for TagHeaderEntryHT
2096 2004-02-04 Benoit Regrain
2097 * FIX : even length for some strings when writting the dicom dir
2098 * FIX : sort the images in the dicom dir
2099 * FIX : Bug fix for python use of dicom dir
2100 * ADD : a python demo
2102 2004-02-04 Jean-Pierre Roux
2103 * FIX : Final solution (?) for icone embedded images
2104 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2105 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2106 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2107 gdcmData/gdcm-MR-SIEMENS-16.acr1
2108 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2109 to make full checking easier
2111 2004-02-04 Benoit Regrain
2112 * FIX : WriteEntries : coding style & logic in parameters
2113 * FIX : Set the elements to create the DicomDir in a dictionary file
2115 2004-02-03 Benoit Regrain
2116 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2117 * gdcmDicomDir : add the load of directory
2118 * Bug fix and print add-on
2120 2004-02-03 Jean-Pierre Roux
2121 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2122 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2123 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2124 * FIX gdcmParser.cxx : 'group length' elements are now considered
2125 as integers, even for shadow groups, when file is Implicit VR
2127 2004-02-02 Jean-Pierre Roux
2128 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2130 of the last synonym :-(
2131 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2133 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2134 * FIX taking into account the possible 7fe0,0010 multiplicity
2135 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2136 to allow removal of references to 7fe0,0010, to deal with
2137 ACR-NEMA images, when 0028,0200 is meaningfull
2139 2004-01-31 Jean-Pierre Roux
2140 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2141 no longer writes 'Un' on disk
2142 * FIX SQ elements with actual length are now dealt with corectly
2143 * FIX gdcmFile::WriteBase make the difference, for color images, between
2144 the length (for Palette expanded images)
2145 and Raw Length (non expanded image + Palette)
2146 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2147 (that broke Write). Replaced by UL.
2148 Aware user will reload the field if he
2149 thinks it's necesssary
2151 2004-01-30 Jean-Pierre Roux
2152 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2153 when 'dirty Acr' is found, to be compliant with the new
2154 IsReadable() methods.
2156 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2157 (no DOUBLE images in kosher DICOM,
2158 but so usefull for people that miss them ;-)
2160 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2161 DICOMDIR related utilities (not checked as Windoze compliant)
2163 2004-01-28 Jean-Pierre Roux
2164 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2166 2004-01-27 Jean-Pierre Roux
2167 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2168 to allow skipping the shadow elements, to save memory space.
2169 The TRUE value for this param has to be used
2170 with a FALSE value for the 'enable_sequence' param.
2171 ('public elements' may be embedded in 'shadow Sequences')
2172 * gdcmHeader methods now deal with 'embedded icones images' in the header
2173 (even when an 'icone image sequence' is announced by the
2174 element (0x0088,0x0200), but there is NO icone at all ...
2176 * gdcmHeader sometimes Image Location value doesn't follow
2177 the supposed processor endianity (see gdcmData/cr172241.dcm).
2180 * gdcmHeader add the method
2181 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2182 to get *all* the Header Entries with the same tag.
2183 GetHeaderEntrySameName is probabely *useless*
2184 (no meaning : Name is *not* an identifier within the Dictionary)
2186 2004-01-26 Benoit Regrain
2187 * Bug fix in the print of hexadecimal representations. Remove long fields
2188 in the print and add a third level of print to print them
2190 2004-01-23 Benoit Regrain
2191 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2192 * Bug fix on test suite after remove the strip made on not string fields
2193 * Split the IsReadable method between gdcmParser which test that the file
2194 is dicom and gdcmHeader which test that it's an image file
2196 2004-01-22 Benoit Regrain
2197 * DicomDir : clean code, add methods, set variables in protected or private
2198 * gdcmUtil : bug fix for the clean string method
2200 2004-01-19 Benoit Regrain
2201 * Add the use of shadow dictionaries
2202 * bug fix and coding style
2204 2004-01-19 Benoit Regrain
2205 * src/gdcmFile.cxx : bug fix concerning the close of file
2206 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2207 * Add the update of header entries using the shadow library
2209 2004-01-19 Benoit Regrain
2210 * removal of file gdcmHeader2.cxx
2211 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2212 inheriting from gdcmParser. This split is to prepare the integration
2213 of dicom dir parsing
2214 * bug fix under python
2216 2004-01-16 Jean-Pierre Roux
2217 * REM removal of class gdcmHeaderEntrySet
2218 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2219 * ADD add file gdcmHeader2.cxx
2220 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2222 2004-01-15 Benoit Regrain
2223 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2224 entries created while parsing the header. Thus, they will be destroyed
2225 when the gdcmDictSet will be destroyed
2226 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2229 2004-01-15 Benoit Regrain
2230 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2231 made a fatal error because of the memory release at the end of program.
2232 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2233 some memory and vtk seems to have some problems with that.
2234 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2236 2004-01-14 Benoit Regrain
2237 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2238 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2239 * src/*.[h|cxx] : make changes due to class name changes
2240 * gdcmPython/demo/*.py : bug fix due to method names
2242 2004-01-13 Benoit Regrain
2243 * src/*.[h|cxx] : coding style
2244 * vtk/*.[h|cxx] : coding style
2246 2004-01-13 Benoit Regrain
2247 * gdcmPython/testSuite.py : test the readable flag of file for tests
2248 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2249 It's lied to the stl compilation by MSVC (windows, always windows...)
2250 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2252 2004-01-12 Benoit Regrain
2253 * src/*.h : add comments
2254 * src/gdcmDictSet.h : set the method BuildDictPath in public
2255 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2256 directly setted in the source code
2257 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2260 2004-01-09 Benoit Regrain
2261 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2262 * setup.py : use a reference to gdcmVERSION
2264 2004-01-07 Benoit Regrain
2265 * Modification to compile with the distutils.
2268 2003-12-10 Benoit Regrain
2269 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2270 can use a gdcmHeaderHelper to load data
2271 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2272 made in the source code
2274 2003-12-10 Benoit Regrain
2275 * Update Windows projects and .cvsignore files
2277 2003-11-12 Jean-Pierre Roux
2278 * ENH gdcmHeader constructor has one more parameter (default value : false)
2279 that allows the user to 'go inside' the SeQuences only
2281 gdcmElValSet:Print takes it into account
2283 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2284 * ENH: Update gdcmPython/CMakeLists
2285 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2286 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2288 2003-11-10 Jean-Pierre Roux
2289 * FIX : gdcmHeader::LoadElements is now based
2290 on the ListTag listElem member,
2291 not longer on the TagElValueHT tagHt member
2292 * ENH : PrintPubElVal shows (temporarily) both results,
2293 with the tagHt member and the listElem member.
2294 (it's easier to 'see' the problems when using Printheader)
2296 * FIX : old private member LgrElem is now splitted into
2297 ReadLength : Length actually found on disk (updated only
2298 if bug fixing is necessary), for internal
2300 UsableLength : Updated by FixFoundLength, to fix a bug
2301 or to allow Parser going on.
2302 Will allow to re-write a kosher header when a SeQuence
2303 with a length (not 0000) is found
2304 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2305 because gdcmElValSet::Add does not update ListElem
2308 2003-11-07 Jean-Pierre Roux
2309 * FIX misstyping in Transfert Syntax name table
2310 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2311 when they have an actual length (not 0000 nor FFFFF)
2312 (Nobody should care of it, but DICOMDIR explorers)
2314 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2315 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2317 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2318 * ENH: vtkGdcmReader now supports LUT !
2319 (vtkgdcmViewer for now is not able to use them though)
2321 2003-11-05 Jean-Pierre Roux
2322 * in testSuite.py : new files names for checking the package
2323 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2324 that returns the pixel area size to the *aware* (vtk) user
2325 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2327 2003-11-05 Benoit Regrain
2328 * in testSuite.py : Modify the rules for checking the paths
2329 : Explicit error messages
2330 * in __init__.py : Related modif
2332 2003-11-03 Jean-Pierre Roux
2333 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2334 to be used by aware (vtk) users that want to manage
2335 LUT (and no to turn the PALETTE image into an RGB pixels one)
2336 * GetPixelType now returns 8U for 24 Bits images
2337 (vtkGdcmReader compliant)
2339 2003-10-31 Jean-Pierre Roux
2340 * Removal of *all* gdcmData images and add them again
2341 in order to loose the 'history' of un-anonymised images
2343 2003-10-31 Jean-Pierre Roux
2344 * RMV : removal of useless jBitsInJsample.h
2345 for both 8 and 12 Bits JPEG Lossy Libraries
2347 2003-10-31 Jean-Pierre Roux
2348 * ENH : Add the functions gdcmFile::GetImageDataRaw
2349 gdcmFile::GetImageDataIntoVectorRaw
2350 that act as GetImageData and GetImageDataIntoVector
2351 except the making of an RGB Plane from Gray Plane + LUT
2352 Intended to aware (vtk) users who know how to manage
2355 GetLUTRGBA return a R,G,B,A LUT if any
2356 lgrTotaleRaw gives the 'Raw' length
2357 GetImageDataRaw returns the gray Plane
2358 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2359 (They stay Grey, just like with other Dicom viewers :-(
2361 2003-10-30 Jean-Pierre Roux
2362 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2364 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2365 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2366 being coherents dicom files.
2368 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2369 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2371 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2372 * ENH: Two steps is necessary to please VC++ compiler...
2373 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2374 * ENH: Add include dir to medcon lib
2375 * FIX: only one function is being exported for now !
2376 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2378 2003-10-29 Jean-Pierre Roux
2379 * adding gdcmHeader::GetLUTRGBA
2380 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2381 --> Mathieu, the modif u're waiting for is not yet committed
2382 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2384 2003-10-27 Jean-Pierre Roux
2385 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2386 00191113.dcm DermaColorLossLess.dcm
2387 MxTwinLossLess.dcm RadBWLossLess.dcm
2388 * ENH: For version prior to vtkImageViewer2 -r 1.19
2389 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2391 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2392 * Removal of ido stuff in CMakeLists.txt
2394 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2395 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2396 * FIX: remove a call to ->Modified ... see comments
2397 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2399 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * FIX: Problem with path for libvtkgdcmPython
2401 * ENH: Try adding a search script for python site-package
2402 * RMV: Remove some file from medcon lib that are not necessary
2403 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2404 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2405 * FIX: More pragma disable fro VC++,
2406 I don't think I break something as it is also disable in VTK/ITK.
2407 But it fasten debug compilation time.
2409 2003-10-23 Jean-Pierre Roux
2410 * gdcm now deals with 16 Bits Run Length Encoded images
2411 (they are compressed as 2 planes images,
2412 one for the high Bytes, the other for low Bytes)
2414 2003-10-22 Jean-Pierre Roux
2415 * Now CheckRead takes into account :
2416 - the bugged 'Leonardo' Siemens images
2417 - the XA images, sent thru the burning VPRO station
2418 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2421 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2422 * FIX: When copying a Makefile.am to CMakeLists.txt
2423 one should remove the '\'
2425 2003-10-22 Jean-Pierre Roux
2426 * in gdcmData adding a bugged 'Leonardo' Siemens image
2427 (wrong lengths in header)
2428 OK with gdcm, KO with the other viewers :-)
2429 * add a GE dlx XA image, thru the VEPRO burning station
2432 2003-10-21 Jean-Pierre Roux
2433 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2434 for a brutal checking of vtkgdcmViewer compliance
2436 2003-10-21 Jean-Pierre Roux
2437 * add the files for 'xmedcon' Jpeg Lossless library
2438 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2440 2003-10-21 Jean-Pierre Roux
2441 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2443 2003-10-21 Jean-Pierre Roux
2444 * garbage Siemens 'Leonardo' images dealt with
2445 (the patch is easy to remove)
2446 * cosmetic changes to avoid warnings
2448 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2450 no need to press 'r' now.
2452 2003-10-20 Jean-Pierre Roux
2453 * upgrade of checkRead.sh checkWrite.sh according
2454 to new Jpeg Lossless decompressor
2455 * add US.3405.1.dcm, a genuine RGB medical file ...
2456 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2457 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2459 2003-10-15 Jean-Pierre Roux
2460 * general anonymisation in gdcmData
2461 * adding the 'color files' from
2462 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2463 * adding some well knowed bugged-header images
2464 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2465 waiting for their inclusion in Python testsuite
2467 2003-10-15 Jean-Pierre Roux
2468 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2469 no longer seg faults when file is not found
2471 2003-10-14 Jean-Pierre Roux
2472 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2475 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2476 * TODO: *.in file to genereate a UseGDCM later
2478 2003-10-14 Jean-Pierre Roux
2479 * Some supposed-to-be Dicom Images have no preamble.
2480 OpenFile takes it into account
2481 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2482 * Missing elements added in dicomV3.dic
2483 (just to be affraid : have a look at
2484 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2485 and do it again next year ;->
2487 2003-10-13 Jean-Pierre Roux
2488 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2489 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2490 But there are NOT. It's fixed !
2492 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2493 * FIX: "jpeglib.h" was not found on VC++
2494 * FIX: vtkgdcm was not being installed
2496 2003-10-10 Jean-Pierre Roux
2497 * ENH : OpenFile closes the file if it *really* doesn't look like
2498 an ACR-NEMA / DICOM one.
2499 * FIX : testWrite no longer writes an empty file if the source file
2500 is not gdcm Readable
2501 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2504 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2505 * FIX: CMake generate now documentation
2506 * ENH: out of source doc build !
2507 * ENH: Generate both user and dev documentation
2508 * ENH: Should work on windows too
2509 * ENH: Only one doxygen config.in file is needed
2510 * FIX: make install should be ok now on ùnix plateform
2511 * FIX: PATH to dictionary was wrong (missing /)
2512 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2514 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2515 * vtkGdcmReader is now able to read rgb dicom file.
2516 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2517 * added a gdcmViewer to vtk test, use mouse to control
2518 window level & window width
2520 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * CMake-ification of gdcm, we have now two build system
2522 * FIX: on cygwin Wsock32 doesn't exist
2523 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2525 2003-10-06 Emanuel Ollart
2526 * FIX : compilation process wad broken.
2527 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2529 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2530 * change gdcmViewer -> vtkgdcmViewer
2531 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2533 2003-10-06 Jean-Pierre Roux
2534 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2535 ( e.g : well known GE images with a wrong elem length,
2536 : Philips MRI Images with a wrong Huffman table)
2537 * still to be done : allow the reading of bugged LEONARDO Siemens images
2539 2003-10-03 Jean-Pierre Roux
2540 * Odd length strings are padded with '\0' (not with spaces,
2541 to remain compliant with already defined strings,
2542 like Transfert Syntax UID and others)
2544 2003-10-03 Jean-Pierre Roux
2545 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2546 to allow displaying RGB images (not only by affim ;-)
2548 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * vtkGdcmReader is now able to read rgb dicom file.
2550 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2552 2003-10-03 Jean-Pierre Roux
2553 * A few nasty patches to allow the reading of a lot of nasty images
2554 ( e.g : well known GE images with a wrong elem length,
2555 : Philips MRI Images with a wrong Huffman table)
2556 * still to be done : allow the reading of bugged LEONARDO Siemens images
2558 2003-10-03 Jean-Pierre Roux
2559 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2561 2003-10-03 Jean-Pierre Roux
2562 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2563 to allow displaying RGB images (not only by affim ;-)
2565 2003-10-03 Jean-Pierre Roux
2566 * gdcmFile::GetImageDataIntoVector now
2567 - deals with MultiFrames MultiFragments Run Length Encoded files
2568 - deals with YcBcR (YBR_FULL) files
2569 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2570 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2572 (no sample found :-(
2574 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2575 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2576 Two reasons: - clear things
2577 - third parties acces gdcm through header files, so won't
2578 suffer anymore VC++ complains
2580 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2581 * add argv[1] in testvtkGdcmReader.cxx
2584 2003-09-24 Jean-Pierre Roux
2585 * The lines are now eigthy characters long.for
2586 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2588 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2589 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2590 char* to std::string. Thus, the use of strdup becomes useless. (see
2591 previous commis of Malaterre)
2592 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2593 before the last Malaterre's commit.
2595 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2596 * This commit should fix the Debug building under VC++, the problem
2597 was mainly a mixture of debug and release lib being loaded at startup.
2598 * I also remove a depency to a specific C function: strdup. Because I had
2599 to force the link to msvcrtd (whereas strdup is in libc).
2601 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2602 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2603 located in the gdcmCommon.h file. All use of reference of tha has been
2604 changed to now use the variable GDCM_UNFOUND.
2606 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2608 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2609 Dicom dictionary. The test suite can now be run again. Note:
2610 I'm note very happy with the " (RET)" changes. I believe this
2611 RETAINED comment should be dropped when parsing the dictionary.
2612 - PACKAGER corrected
2614 - AUTHORS updated and now in alphabetical order
2615 * Makefile.am now exports gdcm.dsw for Windoze users.
2617 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2618 * cygwin complains about missing std:: in subdir Test/
2620 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * remove some methods that are now in gdcmHeaderHelper
2623 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * vtkGdcmReader set spacing and origin correctly
2626 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * Fix a few delete/delete[] mismatch
2629 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2631 interpretation to data given by gdcmHeader. For instance there are
2632 heuristics to get informations (look at different places).
2633 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2634 sorting DICOM images based on different strategies.
2635 * modified Makefiles accordingly.
2637 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2638 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2639 when building in debug mode
2640 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2641 src/win32/gdcmdll.dsp
2642 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2644 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2645 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2648 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2649 * src/win32/libgdcmjpeg12.dsp was not dos format
2650 * src/win32/libgdcmjpeg12.dsp :
2651 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2652 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2654 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2655 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2657 * src/gdcmFile.cxx : bug fix in affectation type
2658 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2659 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2660 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2661 symbols... future problem ?
2663 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2664 * src/win32/libgdcmijpeg12.dsp was missing
2665 * modified gdcm.dsw accordingly
2667 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2668 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2670 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2671 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2672 commit of JPR (before his hollidays to facilitate our work).
2673 * setup.py : bug fix in code. Modifications made while the last commit
2674 of JPR. The code hasn't been tested before the commit... it's so
2675 useless to make that (for best programmer that is JPR) !!!
2677 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * tagged the current version as Version0_3 (i.e. version 0.3)
2680 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2681 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2682 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2683 * *.dsp : modifications to use new libgdcmijpeg8 library
2684 * setup.py : bug fix on VTKPATH variable
2685 * PACKAGER : adding all concerning windows
2687 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2690 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2691 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2692 test suite reported error.
2693 * PACKAGER file added (describes what a packager must do when
2694 packaging a new release).
2695 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2696 * configure.in: upgraded version number to 0.3.0
2697 * fixing build of rpm (through rpm -ta):
2698 - Doc/Makefile.am exports proper doxygen files
2699 - src/jpeg/libijg8/Makefile.am exports the include files.
2701 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2702 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2703 * src/gdcmHeader.h : formatting code
2705 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2706 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2707 We were obtaining error message from vtk. Now, creation of file list
2708 is made in an internal list to prevent this problem.
2709 Bug fix when output is empty.
2710 Bug fix in update of progress value. Previous commit for this was a bad
2712 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2714 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2715 * src/gdcmHeader.h : added method to get the file name
2716 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2717 files. Added method to remove all files on the input
2718 Added FIXME comment concerning the bad parsing of header made by
2719 ExecuteInformation method (in ExecuteData method)
2721 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2723 when using make instal.
2724 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2725 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2727 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2728 * setup.py : adding include dir of jpeg lib to compile all sources
2729 * */Win32/*.dsp : JPR fix for windows compilation
2731 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2732 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2734 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2735 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2737 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2738 * setup.py is again effective on un*x (takes into account the
2739 addon of the jpeg library)
2740 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2741 * Doc/Doxy* updated (includes above enhancements)
2742 * INSTALL now points to web documentation
2744 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * src/gdcmHeader.h doesn't make unnecessary reference to
2747 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2749 * src/gdcm*.[cxx|h] :
2750 - to allow compilation with gcc 3.x
2751 -- clean up of STL usage (added explicit usage of std::)
2752 -- small fixes on exceptions.
2753 Note: linking not tested !
2754 - clean of doxygen comments to avoid warnings at documentation
2756 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2757 dependent convertion).
2759 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * Clean up of previous JPR garbage commit (not even commented in the
2762 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2763 - moved all jpeg related files from src to src/jpeg/libijg8, with
2764 addition/modification of Makefile.am and configure.in.
2765 - the testSuite is still brain damage (not guilty).
2767 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2768 * WrapVTK.py : modifications to get correctly vtk source files to
2770 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2771 (FileName -> Filename)
2773 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * vtk/vtkGdcmReader.[cxx/h]:
2775 - UpdateProgress method should now be effective
2776 - removed the limitation on having only images loaded (as opposed
2778 - when building a stack of images/volume, a lesser number of
2779 gdcmHeader and gdcmFile instances should be used (hopefully
2780 accelerating things).
2781 - when building a stack of images/volumes, files which are not
2782 loadable (wrong path-filename, wrong permissions on existing file,
2783 or file not parsable by gdcm) are replaced with a black image
2784 in the stack (for the caller to notice the problem).
2786 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2789 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2790 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2791 between standard library (std) and vtk library (problems are found
2792 under Windows... thanks Windows !)
2794 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2797 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2799 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2802 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * When compiling with distutils (see setup.py) the C++ compiler is
2804 called with different flags than the default ones (with automake).
2805 In order to fix all those warning, I compiled gdcm with the command
2806 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2807 and went for warning fixes:
2808 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2809 up from unused variables.
2810 - vtk/vtkGdcmReader.cxx: potential bug fix.
2811 * src/gdcmHeader.h: Doxygen warning cleanup
2813 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * gdcmPython/gdcm.i:
2815 - typemaps correction to take into account the systematic replacement
2816 of "using namespace std" with std:: prefix e.g. std::list,
2817 std::string... (cf changes of 2003-05-21).
2818 - gdcmGlob global variable of type gdcmGlobal (defined in
2819 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2820 exported to Python a as cvar.
2821 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2822 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2823 gdcmDictSet.GetPubDictTagNames() and
2824 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2825 C++ static methods).
2826 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2827 with the above changes.
2829 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2830 * setup.py, manifest.in : bug fix under linux
2832 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2833 * Modification of setup.py to compile vtk part too. Then, we have 2
2834 wrappers which must work with same distutils. For that, we have a
2835 generic distutils in distusiltsWrapping.py ; with :
2836 - build_extWrap class to wrap generically all extensions,
2837 - ExtensionWrap base class for all wrapping extension that contains
2839 - Wrapper interface which wrap sources
2840 + In WrapSwig.py we have extension and wrapper for Swig
2841 + In WrapVTK.py we have extension and wrapper for VTK
2842 * MANIFEST.in : modifications to consider vtk directory and new python
2843 files for compilation
2845 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2846 * Added python wrappers of vtkGdcmReader vtk class (see the
2847 source in vtk/vtkGdcmReader.cxx) :
2848 - vtk/Makefile.am now builds a library
2849 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2850 python library (as opposed to _gdcm.so wich are the python
2851 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2852 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2854 - configure.in has an additional flag --enable-vtk that needs
2855 to be set to enable compilation of vtk related code, that is:
2856 + vtk/vtkGdcmReader.so and
2857 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2858 + gdcmPython/vtkgdcmPython.so (see above)
2859 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2860 be read when compressed or when HighBit + 1 != BitsStored),
2861 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2862 the usage of the python wrapper of vtkGdcmReader vtk class.
2863 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2864 * src/*.[h] all occurences of stl classes are now prefixed with
2865 std::, and all occurences of "using namespace std;" where removed.
2866 This is to avoid pollution of global namespace in included files.
2867 Apparently vtk does not avoid this pitfall: when using both
2868 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2869 collision of various stl members (principally cout...).
2870 * gdcmPython/testSuite.py now cleanly removes temprory generated
2872 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2873 comply with above changes)
2875 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2876 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2877 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2878 vtk data structure (an image Flip was required).
2879 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2880 * cosmetic changes in documentation.
2882 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2883 * src/gdcmHeader.cxx: the constructor no longer exits when an
2884 unexisting file is given as argument.
2885 * The subdirectory Data (containing all the images used for the
2886 test suite) is not part of this repository anymore. A new module
2887 containing those images is now available at
2888 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2889 with the name gdcmData.
2890 All the python scripts (including the package initialisation file
2891 gdcmPython/__init__.py) were adapated to take this change into
2892 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2894 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2895 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2896 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2897 demo of the usage of this class.
2898 Compilation of this vtk part is only done when using the --enable-vtk
2899 at configure (or autogen.sh) stage.
2901 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2902 * More memory link related corrections and documentation fixes.
2904 - maximum info is obtained with a command of the form:
2905 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2906 --show-reachable=yes PrintHeader
2907 - the remaining reachable blocks seem to come from the STL
2908 allocation scheme through the usage of map and list. It looks
2909 like this memory cannot be freed but it is not a memory leak
2910 (in fact further invocation to the STL would recollect the
2911 unused memory allthough it cannot explicitely be freed).
2912 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2913 of displaying an image parsed with gdcm and displayed with VTK.
2914 Note: some images don't seem to work e.g.
2915 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2916 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2917 Allthough this weakens the semantics, it is a ditch attempt to
2918 make gdcm more thread friendly.
2920 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2921 * Memory link hunt (by using valgrind through the command
2922 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2923 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2924 gdcmHeader::_dicom_vr.
2925 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2926 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2928 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2930 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2931 * src/Makefile.am now exports all the necessary include files at
2935 * UpdateGroupLength replaced by new one
2938 * UpdateGroupLength re-written using H-Table
2939 (named UpdateGroupLengthNew untill checks are over)
2941 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2942 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2943 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2945 - gdcmHeader::GetPubElValSet removed.
2946 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2947 UpdateGroupLength, WriteElements, Write.
2948 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2949 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2950 carried the same semantics.
2951 - src/gdcmHeaderIdo.cxx changed accordingly.
2952 - gdcmFile::WriteBase now regroups all the codes from previous
2953 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2954 - enum FileType moved to gdcmCommon.h
2955 * src/gdcmHeader.cxx AddDefault trashed
2956 * gdcmGetXSize added
2957 * getimageDataSize now calls gdcmGetXSize
2958 * Test/*.cxx changed to agree with above changes
2960 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2962 (to avoid double call by end user).
2963 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2964 by end user, since gdcmHeader::gdcmHeader now handles it.
2966 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * gdcm/Doc many doxygen changes:
2968 - Doxyfile now has two different versions, DoxyfileUsers that generates
2969 the html.users end users oriented documentation and
2970 DoxyfileDeveloppers that generates the html.developper developper
2971 oriented documentation.
2972 - README changed accordingly
2973 - requirement.txt removed (old design info moved to TODO).
2974 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2975 DoxyMainPage.txt, DoxyPython.txt provide more information.
2976 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2977 be updated by simply regenerating the docs with doxygen and copying
2978 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2979 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2980 all the tests in the form "if (<map>.count() >1)" were removed.
2981 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2982 ill-formed documentation sections.
2983 * src/gdcmHeader.cxx: ditto
2985 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2986 * setup.py fixed for un*x (needed macro for stdint.h)
2987 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2988 un*ces with sh-utils test utility.
2989 * gdcmPython/demo/test.py renamed to PrintHeader.py
2990 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2991 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2992 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2993 * src/gdcm*.cxx JPR's bad inclusion fixed.
2995 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2996 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2997 * gdcmPython/demo/test.py changed accordingly.
2999 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3000 * gdcmPython/Makefile.am fixed linking against libstdc++
3001 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3002 * Swig subdir (historical tests of swig version 1.3.17++) removed
3003 * Test/testChangeEntete.cxx some lines commented out in order to make
3005 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3006 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3008 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3010 hence the user doesn't need this explicit call.
3011 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3012 i.e. LoadElements() call removed.
3013 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3014 - src/Makefile.am declares the proper flag for g++.
3015 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3016 for adding user defined new tags.
3017 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3018 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3019 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3021 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3022 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3023 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3024 src/Makefile.am : the project should properly compile and install
3025 with the autotools, included the python wrappers part.
3026 * gdcm.spec.in : added a spec file for RPM packaging.
3028 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3029 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3031 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3033 to exported to the environement (see gdcmPython/testSuite.py
3035 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3036 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3037 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3038 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3039 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3041 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3042 * gdcmPython/__init__.py doesn't crash anymore when running in
3043 in InstallMode or PreInstallMode but with an environment given
3044 value of GDCM_DICT_PATH.
3045 * src/gdcmDictSet.[cxx/h] coding style.
3047 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3049 * src/gdcm.h general comments moved to TODO, and README
3050 * src/gdcm.h should now be seen as a user commodity (including it
3051 should suffice to fully use gdcm). It is nowhere including within
3052 any of the kernel files src/*.cxx and src/*.h.
3054 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3056 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3058 * src/gdcm*.cxx only include their corresponding include file
3059 (as opposed to gdcm.h)
3060 * gdcmPython/gdcm.i changed accordingly
3061 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3062 the autogen.sh generated "make snapshot" command to work.
3063 * autogen.sh removed history related references to crea package.
3065 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3066 * distutilsSwigCPlusPlus.py work around some swig portability
3069 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3071 was done in a last ditch attempt to get setup.py _really_
3072 operationnal. The python/gdcmPython layaout add the advantage
3073 of hidding away the python related distutils specific files
3074 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3075 Alas, the src directory was out of scope (i.e. it's relative
3076 position to setup.py was ../src) which made things impossible to
3077 handle (see previous version of python/setup.py). Crossing fingers...
3079 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3080 * python/setup.py now works on Un*x. (harder than I thougth)
3081 * python/distutilsSwigCPlusPlus.py can now have include files
3082 among the list of sources.
3084 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3085 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3086 * modifications in MSVC projects
3088 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3089 * As stated by the first lines of Test/ExceptionAndPython/README, it
3090 looks like we can move back to original usage of exception within
3091 src/gdcm* and hence remove the errno stuff that was introduced
3092 as a quick and dirty fixture of this problem (added to the TODO).
3093 * Doc/Doxyfile configuration file for Doxygen and corresponding
3094 README file for usage added.
3095 * Test/testWrite.cxx added. This new test comes from a split of
3096 test.cxx that is now reverted to its original purpous i.e.
3097 testing the proper parsing of a Dicom related file.
3098 testWrite.cxx concentrates on testing the IO part of gdcm.
3099 * Test/bug1.cxx (containing a bug on WIn32) added.
3100 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3101 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3102 whose purpose is to publish the content of the TagNames of the
3103 Dicom public dictionary were not accessible without an
3104 instance of class gdcmHeader.
3105 - those methods are now static methods of gdcmDictSet and hence
3106 require no instances at all to be invocated.
3107 - within gdcmDictSet this change required to change some method
3108 to class methods (i.e. are now static) among which SetDictPath
3109 (renamed to BuildDictPath) and LoadDefaultPubDict.
3110 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3111 the above changes by calling the new method classes of gdcmDictSet.
3112 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3113 the above to be effective.
3114 * python/gdcmPython: in order to wrap properly the above changes
3115 for Python, swig version now needs to be > 1.3.17.
3116 * python/gdcmPython/Makefile fixed to adapt itself to new
3117 configure/make shema introduced by Johan Montagnat (thanks for the
3118 contribution). Alas this Makefile cannot be turned into a proper
3119 Makefile.am without some heavy changes in the configure.in
3120 (for python dectection).
3121 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3122 now avoids publishing the empty entries.
3124 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3125 * python/setup.py : bug fix concerning install under windows
3126 ExtraPath reused :-P
3127 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3129 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3130 * Dicts/dicomV3.dic : remove double spaces !!!
3131 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3132 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3135 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3136 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3137 method. Doxygenation.
3138 * src/gdcm.h clean up of JPR spurious comments.
3140 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3141 * python/distutilsSwigCPlusPlus.py now properly collects the
3142 shadow classes generated by "swig -c++" (gdcm.py in our case)
3143 when using "python setup.py install".
3144 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3145 reexports the working classes.
3146 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3147 by the classical C errno scheme. This is to prevent an obscure
3148 behavior of the python wrappers when importing wxPython.wx prior
3149 to gdcmPython (which ended up in an abort call). An illustration
3150 of this oddity can be found in the Test/ExceptionAndPython
3151 subdir (see the README file). This problem probably due to
3152 an combination of g++ and dynamic loading.
3153 * added Test/ExceptionAndPython (see above)
3155 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3156 * Changed the layout of the python part to avoid bloating main
3157 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3158 i.e. the distutils arsenal. All the python related stuff is
3159 again in a python subdir, but the package itself is now in
3161 * setup.py was cleaned up:
3162 - pythonIncludePath removed
3163 - python setup.py bdist target is now functional.
3164 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3165 collision with other packages). gdcmPython/demo/*.py changed
3168 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3169 * python subdir moved to gdcmPython (preparation of distutils packaging).
3170 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3171 distutils installer is operational.
3172 * - gdcmPython/__init__.py now properly loads the swig generated
3173 shadow classes (from gdcm.py).
3174 - gdcmPython/demo/*.py changed to import the package gdcmPython
3175 instead of gdcmPython/demo/load.py.
3176 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3178 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3179 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3180 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3181 entries within the associated public Dicom dictionary resp. the same
3182 information but sorted by the fourth field (PAT, IMG, DIR) of the
3184 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3185 are now in the "???" group.
3186 - python/gdcm.i changed accordingly,
3187 - python/demo/printGroupedPublicDict.py added, that gives an example
3188 of the above new functionalities in Python.
3190 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3191 * src/gdcm.h, gdcmHeader.cxx:
3192 - historic references to glib's g_malloc and g_free (#defined)
3193 were definitively removed.
3194 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3195 * src/gdcmElValSet.cxx:
3196 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3197 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3198 - GetElValue(string) renamed to GetElValueByName.
3199 - Added GetElementByName(string).
3200 * src/gdcmHeader.cxx: added
3201 - GetPubElValRepByNumber(guint16, guint16)
3202 - GetPubElValRepByName(string)
3203 - GetShaElValRepByNumber(guint16, guint16)
3204 - GetShaElValRepByName(string)
3205 - GetShaElValByNumber(guint16, guint16)
3206 - GetShaElValRepByName(string)
3207 - GetElValRepByNumber(guint16, guint16)
3208 - GetElValRepByName(string)
3209 - GetElValByNumber(guint16, guint16)
3210 - GetElValRepByName(string)
3211 * Doc/requirements.txt added.
3213 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3214 * Test/Makefile building now depends on the one of libgdcm.so
3215 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3216 pixel data) aware which enables finding the address (offset) of
3217 the pixel data of JPEG encoded DICOM files. This leaves only a single
3218 file in the testSuite whose pixel data address (offset) is unknown.
3219 * python/testSuite.py changed accordingly.
3221 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3222 * VC++ has some strong limitations when working with the STL, as stated
3223 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3224 "Also note that some STL containers (map, set, queue, list, deque)
3225 cannot be exported. [...]
3226 Some STL classes contain nested classes. These classes can not
3228 This is caused by a designed limitation that once a template
3229 class is instantiated, it can not be re-instantiated and
3231 Since our usage of map<> is ubiquitous in gdcm, this "designed
3232 limitation" of VC++ is a pitfall.
3233 Hence the Python wrappers of gdcm cannot be incrementally linked
3234 against the c++ dynamic library. The dirty but only workaround is
3235 to forget about incremental link of dynamic libraries and to generate
3236 the Python wrappers library with the inclusions of the underlying C++
3238 The following modifications concern this matter on Win32/VC++:
3239 - wrapping python correct with standalone wrapped dll (don't use separate
3240 dll under windows !!!!)
3241 - python21_d debug mode enabled (ask Frog how to use it :-)
3242 - NO problem with having an STL member of class for example string in C++
3243 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3244 - Python test of dcmlib in Python is ok under windows on a large set
3246 * removed glib references
3247 * typedef's inserted in gdcm.i for correct swig type management
3249 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3250 * python/demo/*.py load.py extracted from test.py. Added explore.py
3251 that only displays required tags and testAll.py that parses all
3252 the files of the testsuite without using unittest.
3253 * python/testSuite.py other additional test on new files added.
3254 * Data/* new test files added accordingly to the testSuite.
3255 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3256 the vr in the file differs from the one of the dictionary.
3258 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3259 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3260 values, but limits itself to values which are below a user specified
3261 size (by default 1024 bytes).
3262 * python/gdcm.i : elements not loaded (because their size is above the
3263 user specified treshold) are exported with their TagKey as key of the
3264 python dictionary. This enables the testsuite to make some checks
3265 on the unloaded elements (since we have their offset and size).
3266 * python/testSuite.py
3267 - now tests for the existence and proper value of the pixel data
3268 - two new examples added.
3269 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3271 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3273 aware. See the strategy comments in gdcmHeader::FindLength().
3274 * Test/test.cxx now accepts a filename as first argument.
3275 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3276 * python/testSuite.py changed to integrate test on above files.
3278 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3279 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3280 the vr was also RET.
3281 * python/testSuite.py more tests added.
3283 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3284 * python/testSuite.py unittest test suite added (uses Data)
3285 * Data/* dcm and acr files for the test suite.
3286 * glib dependance removed from un*x version. We now use ISO C99
3287 7.18 Integer types (see stdint.h)
3288 - python/Makefile, src/Makefile src/gdcm.h
3289 * src/ when an explicit vr (like dicom files) suddenly poped an
3290 implicit element we use to mark the underlying DictEntry of the
3291 concerned ElValue with "Implicit". This strategy was damageable
3292 too the public or provite dictionaries, since some of their vr
3293 would be changed. Since Header::FindLength heavily relies on the
3294 detection by Header::FindVR of falsely explicit elements, I
3295 added an extra ImplicitVr member to ElValue (boolean).
3296 The rest of the changes we the necessary adaptations.
3298 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3301 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3303 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * Adaptation for porting to VC++:
3306 o forced to use std namespace (for string to be known)
3307 o all class use __declspec export style on WIN32
3308 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3309 (in stdlib.h on Win32 but in std:: for gcc)
3310 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3311 variable GDCM_DICT_PATH.
3312 * src/gdcmHeader.cxx verbose comments made discrete.
3314 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * python/gdcm.i: added a typemap that converts a C++ hashing table
3316 to native Python dictionary.
3317 * python/demo/test.py:
3318 - now uses the native dictionary for exploration of gdcmHeader.
3319 - takes an optional filename argument (the file to parse).
3320 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3321 PubElVals hashing table.
3322 * Dicts/dicomV3.dic removed error prone trailing spaces.
3324 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3325 * Python wrapping process moved away from src/Makefile to
3326 newly created python/Makefile (as well as gdcm.i)
3327 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3328 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3329 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3330 from the environement variable GDCM_DICT_PATH (when existing).
3331 * src/gdcmDict::GetTag bug fix.
3333 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * Straightforward temporary fixes for swig to build the python wrappers.
3335 src/Makefile now has a python working entry [by working we mean
3336 that we can import the shadow classes without errors].
3338 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3339 * hashtest.cxx removed (since already in Test)
3340 * src/gdcmlib.h renamed to src/gdcm.h
3341 * src/dcm.i renamed to src/gdcm.i
3342 * src/Makefile prepared for python wrapping
3344 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * src/gdcmHeader.cxx :
3346 - Parsing of header is now separated from loading of element values
3347 (see gdcmHeader::LoadElements).
3348 - general clean up of hopefully all file access (creation of
3349 ReadInt16 and ReadInt32)
3351 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3352 * src/gdcmHeader.cxx :
3353 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3355 - SetLgrElem renamed to SetLength
3356 - GetLgrElem renamed to GetLength
3357 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3358 * src/gdcmElValSet.cxx fixed both GetElValue methods
3359 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3360 due to IdoDude was cleaned out.
3362 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3363 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3364 concentrates on finding the value representation (when it exists).
3365 RecupLgr now only finds the element value length, and it avoids
3366 returning the unecessary skL (skipped length).
3367 Also, offsetCourant was simply removed (with taille_fich) since
3368 it was redundant with the File position internals (by using
3369 ftell and fseek). This also made skL (see above in RecupLgr) usage
3371 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3372 on the libido specificities which are handled through class
3374 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3377 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3378 * Truckload of changes. Parsing of header is barely functional
3379 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3381 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3382 * src/gdcmHeader.cxx many addons of low level methods
3384 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3385 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3386 and _IdDcmSWAP_LONG.
3388 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3389 * This corresponds to all the changes decided at the meeting of
3390 May 23 2002. Needless to say we are running late...