1 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
3 Thus, DicomDirXXX are created with a flad that indicates if the created
4 object is empty or not (when not empty, the DicomDirElement is used to
7 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
9 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
11 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
14 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
16 Remove all access to the hash-tables or lists in the objects.
18 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
20 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
21 be complient with all the gdcm source code
23 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
27 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
31 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * Test/ : rename VTK tests to have a best name for the tests
33 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
34 GetFirstEntry/GetNextEntry use
36 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
38 test. Now it's on image content and not on the resulting visualisation...
39 might solve the problem on linux when using the OpenGL drivers
41 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
42 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
43 DicomDirSerie, DicomDirImage
44 Dict, DictSet classes :
45 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
46 -remove InitTraversal method.
47 * UPD Test programs + Example programs
49 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
50 remove useless and never updated keyword \ingroup
52 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
54 is no memory access violation
55 * gdcmPython/demo : add python demos using VTK
57 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * FIX 'Dictionnary' is now spelt 'Dictionary'
59 'wether' is now spelt 'whether'
60 'archieve' is now spelt 'archive' ;-)
62 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
63 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
64 related methods, in order not to expose internal mechanisms
67 * REM methods that exposed internal mechanisms :
68 DicomDir::GetDicomDirPatients()
69 DicomDirPatient::GetDicomDirStudies()
70 DicomDirStudy::GetDicomDirSeries()
71 DicomDirSerie::GetDicomDirImages()
82 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Removed the Print/indent/default parameter mess. There is absolutely no
84 reason to have to methods, moreover with the second taking the ostream as
85 *SECOND* parameter. This was clearly a bad hack to get things compile.
87 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * Complete rewrite of the GetMacAddress code. Now the code is *much*
89 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
90 Unfortunately the main code does not work on SunOS, thus provide a specific
91 code for this platform only (and Win32 of course). Since this seems to be
92 working, change CreateUniqueUID to use GetMACAddress instead of the
93 problematic GctestetIPAddress
95 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Unfortunately to be able to test gdcmDirList I had to break the API
97 a little. Now the class is not a std::list anymore but has a member
98 std::vector (more ITK compatible). Allow unit testing on Win32 and
101 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * Update SerieHeader to take into account a Serie Instance UID to properly
105 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
106 * ENH - Comment out Mathieu's (dangerous) Super Hack
107 for dealing with BIGENDIAN processors
108 - Move equivalent stuff to BinEntry::WriteContent
109 When necessary, 16 Bits Pixels are swapped in a small buffer
110 and then written. This avoid allocating a huge buffer, in
111 PixelWriteConvertor, and avoid modifying the Pixel Area.
113 Probabely, the same operation will have to be done when we want
114 to write image with Big Endian Transfert Syntax,
115 and we are working on Little Endian Processor
117 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
120 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
121 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
122 all the dict content.
123 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
125 * Test/TestDict.cxx : add a new test for the dict classes
127 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
128 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
129 file. Debug is yanked if compiled with NDEBUG
131 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * src/gdcmDictSet.h : set the default output to the os variable
133 * src/gdcmDictEntry.[h|cxx] : add the Print method
134 * gdcmPython/demo/ : add a new test
136 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 * merging of Test/PrintDicomDir and Test/TestDicomDir
138 * removal of now redundant Test/PrintDicomDir
139 * enhancement of Example/PrintDicomDir
141 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * Now, python test might work on systems
143 * Add the PrintDicomDir test
145 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
146 * FIX : First entry following group 0002 was lost for
147 Explicit Big Endian Transfer Syntax files
148 (group and elem not swaped)
150 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
151 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
152 Big Endian Transfer Syntax supposed the group following 0002
153 begins always by element 0000 (element 0000 is *optional*)
154 To avoid further troubles, let's be pessimistic, and use
155 Document::HandleOutOfGroup0002() method
156 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
157 (related pb not yet solved)
159 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * Bug fix for the python part use
161 * Now, PrintHeader.py pass... but outside the ctest use. shit !
163 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
166 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
168 a string and should ask the global TS dict what are the propreties of
171 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
172 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
173 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
174 to swap the Swap Code, at parsing time, when we come out of group 0002
175 and Transfer Syntax is Big Endian
176 We should be able to read now 'true DICOM" Big Endian coded images
177 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
178 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
180 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
181 * Hopefully fix the bug on MacOSX and static global initialization.
182 This is the only -minor- patch I found that both please MacOSX and VS6.
183 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
184 but this would require a lot of change. Another approach would be that Global
185 create those string and GDCM_UNFOUND becomes a pointer to a string (which
186 gdcm::Global would destroy at exit).
188 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * Fix bug on MacOSX with static initialization in a multy threaded
190 environment. static const string in a header file used to be ill
191 initialized provoquing the freeze of any tests. patch should solve this
194 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 * According to Benoit's suggestion, and without any objection from anybody
196 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
197 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
198 - method gdcmDicomDirObject::GetEntry() renamed as
199 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
201 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
203 you debug/warning message just as c++ streams which make them very convinient
204 to use. Once this is stabilize I will change the ostringstrem to be
205 redirected to a file (ofstream).
206 * Properly support C99 extension: __FUNCTION__ which allow us to display
207 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
209 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
210 * Removal of useless and dangerous methods :
211 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
212 GetDocEntryByName, GetEntryByName, GetDictEntryByName
213 * Removal of usless methods :
214 Dict::PrintByName, Dict::GetDictEntryByName
215 * Commenting out of probabely useless methods :
216 Dict::GetDictEntryNames()
217 Dict::GetDictEntryNamesByCategory()
218 DictSet::GetPubDictEntryNames()
219 DictSet::GetPubDictEntryNamesByCategory()
220 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
221 * ENH : Use dicomTS.dic as described in 2004 version
222 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
223 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
224 Add Accessors on VM (Value Multiplicity), and VM related methods
225 * ADD : Add a list of 'Dicom Attribute types', as found in
226 http://medical.nema.org/dicom/2004/04_15PU.PDF
228 * ADD : Add dicomGroupNameAbbreviations.dic
229 should be used to write a method to replace the former
230 Dict::GetDictEntryNamesByCategory()
232 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
234 to read in the file... and only it ! Length is the efective length of the
235 data in the DocEntry structure
237 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
238 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
239 And now use a static function call instead, with a global variable. i
240 This is much closer to the VTK approach. Hopefully should be bulletproof
241 and easier to use...hopefully
243 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
246 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
249 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
251 ValEntry, BinEntry, SeqEntry creation or replace
253 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
255 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
257 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
258 when specifying the VR
259 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
260 * src/gdcmDocEntry.cxx : amelioration of print
262 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
263 * ADD : Add the method Util::IsCurrentProcessorBigEndian
264 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
265 * ADD Method Document::ComputeGroupLength
266 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
267 in order to allow further VR modification by user
268 * REM : removal of once-called method File::WriteBase
269 integration of its code in formerly one-line method File::Write
271 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
273 replace the different values "??", "Unkn", "Unknown".
274 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
275 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
276 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
277 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
279 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
282 * Set the gdcm::Base class to some Printable classes
284 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmFile.[h|cxx] : add the Print method
286 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
287 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
288 * src/gdcmDocument.h : remove the PrintLevel informations
289 * Example/PrintFile.cxx : use the new gdcm::File::Print
291 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
293 problems when compiling with the python wrapping
295 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
297 writting in ImplicitVR
299 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
300 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
301 JPEG decompression, especially when dicom frames are split into several
302 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
303 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
305 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * src/gdcmHeader.cxx : change the initialisation of default header.
307 Now, this header is readable by gdm, e-film, DicomWorks
309 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
311 Rename Decompressed to Raw
312 * Use the API changes in gdcm::File.
313 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
316 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
318 each added entry in the header. Replace the 'Planes' field by the 'Number
321 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
323 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
325 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
327 At this time, this image isn't readable by e-film... waiting JPR help to
330 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
332 DocEntry. Now use methods of the Document !
334 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * Test/ShowDicomSeq.cxx : bug fix
337 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
339 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
340 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
341 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
343 * Test/TestCopyRescaleDicom.cxx : remove unused variable
344 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
345 containing found sequences
347 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
350 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
351 Some fields in BinEntry must be copied to not seg fault when making the :
352 gdcm::File *copy = new gdcm::File( copyH );
353 and tests are now made on good variables
355 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
357 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
359 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
360 * Add vtkGdcmWriter example and test
362 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * Test/TestUtil.cxx : reformat the source code
364 * vtk/vtkGdcmReader.cxx : remove and change prints
365 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
367 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
368 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
370 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
372 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
374 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
376 by an eof to prevent all bad read of the file... and in this case, the
379 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * Example/Volume2Dicom.cxx : comment unused variables
381 * Test/PrintDicomDir.cxx : comment unused variables
382 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
383 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
384 method that is redondant with AddEntry.
385 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
388 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * Bug fix due my last commit (compilation under Windows).
390 * Example/Volume2Dicom : bug fix in the file and reformatting source code
391 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
393 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
395 - Remove printf / sprintf
396 - include iostream AFTER gdcm so we don't get warnings
397 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
399 - Also remove tons of include from header files, hopefully this should
400 speeup the compilation time, since it was becoming a dog slow.
401 - Remove gdcm.h as it include way too many files and slow down compilation
402 (plus it is not up to date)
403 - remove 'using namespace std' this is BAD !
405 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * Remove memory leaks on the DicomDir
407 * Remove some useless data in DicomDirObject
408 * Add usefull methods in SQItem, to be complient withe the ElementSet
410 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
413 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
415 future, with convertion)
416 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
417 and ImageDataSize values. Remove the method to get the PixelReadConverter
418 from the output of the class
420 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
423 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
425 and vtkErrorMacro use.
426 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
428 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
431 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
432 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
433 The string leaves only in the fonction. So when we make a .c_str(), we
434 get the pointeur on the first element, element that will be destroyed
435 immediately after thee instruction.
436 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
437 file has been opened : the test must be made on the content of the
438 pointer and not directly on the pointer !
441 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
443 the python part recompiles
445 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
447 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
448 X session is killed (for my computer... it seems to not be identic on
451 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
453 avoid problems (otherwise, the difference test between the visible image
454 and the reference is incorrect. If the reference is greater than the
455 screen resolution, it's produce errors).
456 Can be used for only one image. Can be used with a visible flag.
457 * vtk/vtkGdcmReader.cxx : remove commented codes.
458 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
459 under windows at compilation
460 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
462 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
464 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
466 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
467 tests on the image size X, Y, Z
469 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
471 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
472 between the class name and the file name
474 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * src/ : fix compilation warnings for the Write method (2 different
476 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
477 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
478 variable... create a static method in gdcm::Document to access to
479 this variable content.
481 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
483 file, to be accessed by other files (like gdcmFile). Remove commented
484 code. Move the change of the header to the gdcmFile, using the
486 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
487 To be sure of that (and simplify calls), the Write of the header now
488 gets a file name and not a file pointer (std::ifstream).
489 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
490 DocEntryArchive. Remove all open of the written file
492 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
493 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
495 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
497 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
499 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
500 some corresponding methods. Write correctly the file and check before
502 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
503 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
504 is now on RGB data (as before my last commit
505 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
507 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
509 Add a print information of the type of the entry
510 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
511 It was in the gdcmFile, and all write have been regrouped
512 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
513 Write correctly all dicom files (in decompressed mode only at this time)
514 * Test/ : test on files are now made using Raw data and not color data if
516 * Example/PrintFile.cxx : add more printings
518 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * Amelioration of code, remove some code copy. For the loading of
520 BinEntry (in gdcmDocument), add the test to verify if the file is already
523 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
525 remove a DocEntry in the header (push an empty DocEntry)
526 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
527 lines. Bug fix in the initialization of the PixelConvert and the
529 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
530 use in TestCopyDicom (now this test can run under windows... but fails)
531 * Test/TestCopyDicom.cxx : amelioration of the test :
532 - test the pixels written
533 - add test points to quickly find where is the error
534 - can set a file name input and output in arguments
535 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
536 amelioration of the test output
538 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
540 all replaced DocEntry's
541 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
542 Now, each needed DocEntry to modify is duplicated, modified and inserted
543 to the header using DocEntryArchive. Thus, after save, we can restore the
544 header initial state.
546 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
549 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
550 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
551 correct to copy it. The DictEntry is specified at the DocEntry creation,
552 then, it musn't change in the time.
553 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
554 header correctly. At this time, the change is only made for the first
555 level of the Document. In the future, it might consider sequences.
556 The change is made by replacing a DocEntry by an other that is created
557 outside the class. The old value is kept. When we restore the header
558 status, the added DocEntry is deleted and replaced by the old value.
559 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
560 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
561 set the write type to explicit VR, implicit VR or ACR. Add methods to set
562 the write mode to native, decompressed or RGB (but not used at this time)
564 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
566 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
568 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
570 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
572 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
573 set because already copied when copying the BinEntry's of the header
574 * Test/TestAllReadCompareDicom.cxx : remove warnings
576 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
578 Two problems appear when doing it :
579 - with the gdcmFile : when the GetImageData method is called, the pixels
580 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
581 data (pixels). And each structure destruct the data when it's
582 destructed. So we have two destructions for the same data. To solve it,
583 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
584 data or not. If it doesn't own data, then they will not destroyed by
586 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
587 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
588 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
589 create a double destruction of the same DocEntry's. So, to solve it,
590 the TagHT is simply cleared and the DicomDir* elements are destroyed.
591 * TODO : add an entry concerning memory leaks in the DicomDir
593 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
595 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
598 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
600 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
601 after it have been deleted
603 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * FIX: src/* fix the doxygen warnings.
605 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
606 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
607 was erroneously defined with a size of 15 instead of 16. [many thanks
608 to Jean Michel Rouet for pointing out this bug].
610 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
611 1. Finish merging JMR patch for writting DICOM from scratch
612 2. Fix -hopefully- bug with MONOCHROME and space vs null character
613 3. Use const ref when possible
614 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
615 5. A few more comments
616 6. CreateUniqueUID can now be called without parameter"
618 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
619 * ENH: Slightly bigger patch:
620 1. Getting toward full integration of JMR patch for writting dicom from scratch
621 2. Update Test to test part of this patch: CreateUniqueUID
622 3. File was not close properly in gdcmDict
623 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
624 5. Use of const ref instead of copy (speed issue)
625 6. Remove temporary (duplicate) string in TranslateToKey
626 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
627 8. Do not repeat virtual in subclasses
628 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
630 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
631 * Apply first patch toward better string comparison when dealing with broken
632 DICOM files. Essentially the string could be padded with a space instead
633 of a null character as defined by standard
635 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
636 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
637 because never used... and in the same time, that's remove some memory leaks
639 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * src/gdcmFile.cxx : now delete the PixelConvert instance.
641 * In examples and tests : change the type of image data variables from void*
642 to uint8_t*. Remmove all delete on image data variables
644 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
646 Verify the file pointer value before open the file, and if it's not null,
647 a verbose message is generated.
648 Close correctly the file when the file isn't considered dicom-like. The
649 correctly close is a call to CloseFile.
650 When closing the file pointer, test if its not null to close the file.
651 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
652 file. For an uncompressed image, the copied data correspond in the least
653 case to the image size (calculated) or the image size specified in the
654 header. A verbose is generated if these two size mismatch
656 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
658 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
659 break under windows (with msvc6 compilation).
661 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
663 compiling with MSVC6)
665 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * Bugs fix for the Windows build with VC6
667 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
668 needed (only for projects required VTK). If the VTK is included in all
669 projects, there is conflicts with the jpeg lib of vtk when compiling the
670 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
671 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
672 when compiling the gdcm_wrap.cxx file (created by the compilation of the
674 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
675 (like it's already made for the cout use). Otherwise, conflict with the
678 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
681 - comments on the DicomDir::Method related usage added.
682 - now that we use the namespace gdcm, a lot of internal classes do
683 NOT need to be wrapped anymore.
684 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
685 DicomDir::Method) new example added.
687 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
688 * Improve string manipulation. I now inforce the notion of 'DicomString'
689 A DicomString can contain as many \0 as they want
690 and it is *always* of even length.
691 We only support odd length for very rare case.
692 And in the near future this should be removed.
694 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
695 * /binary_write/ gdcm source. Now even on big endian we are writting
696 little endian. This should -heopfully- fix some tests
698 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
699 * Now the dictionary is compiled into gdcm lib. This is a default
700 behavior, thus any dic file specified is picked before failback to
701 the one comiled into lib
703 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
704 * Change internals for gdcmDict. Don't use any 'new' any more.
705 This should definitely solve any leak problem, and we should be
706 as fast as before, as long as don't modify too much the dictionary.
708 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
709 * STYLE: ivars should start with a capital letter.
710 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
711 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
713 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
715 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
716 new 2004 dictionaries added (thanks to JPR).
717 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
718 * CLEANUP_ROUND (15) for gdcmPixelConvert
719 - RLEFrame::NumberFragments is now of type unsigned int
720 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
721 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
724 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
725 * Initial work in gathering all transfer syntax accessors. clearly
726 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
727 ivars, but only one transfersyntax (class) ivar with equivalent method on
730 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
731 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
732 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
733 discussed (plus I didn't like having a 2000 lines patch not commited)
735 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
737 * CLEANUP_ROUND (14) for gdcmPixelConvert
738 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
739 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
740 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
742 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
743 anymore and hence avoids storing a copy of PixelConvert::Decompressed
744 into File::Pixel_Data.
746 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
748 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
749 * CLEANUP_ROUND (13) for gdcmPixelConvert
750 Substituted File::ParsePixelData() with PixelConvert::Print() new
752 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
753 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
754 method to those classes.
755 - src/gdcmFile.[cxx|h]:
756 -- Added a ::Print() method.
757 -- PixelConverter is now a reference instead of a member.
758 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
759 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
761 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
763 collaboration diagram and inheritance diagram should be generated with
765 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
766 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
767 pointlessly wrapped (see
768 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
769 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
770 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
771 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
772 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
773 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
774 -- File::Initialise: PixelConverter setup moved away to
775 PixelConverter::GrabInformationsFromHeader()
776 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
777 interpretation moved away to PixelConverter::BuildRGBImage()
779 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
780 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
781 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
783 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
785 displayed on Win32 when a brutal abort() occurs (because of uncatched
786 exception). See TODO new entry of this commit for more on this.
787 * TODO added new entry.
788 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
789 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
790 - HandleColor is no longer called from gdcmFile.cxx
791 - gdcmPixelConvert.cxx clean up on method arguments and internal
792 variable names for semantical coherence.
794 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
795 * Finished lossless transition, not only do we now read all lossless jpeg
796 images, without the need of the Cornwell lib, but we do read them properly now
797 * To reduce code (well to avoid code duplication), I defined a common place
798 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
799 redefine symbols. This is not perfect but this the best solution I found for a
800 compilation time jpeg option.
802 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
803 * Update jpeg ijg lib to support lossless jpeg implementation
804 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
806 * Also added a special copyright for dcmtk since we use their bugfixes.
809 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
811 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
812 matters, as stated in warning note at begining of %include section).
813 * src/gdcmDicomDir*.[cxx|h]: coding style
814 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
815 * src/gdcmJpeg8.cxx: doxygen fix.
816 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
817 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
818 from File:: to PixelConvert::.
820 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
822 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
823 - more code moved away from File:: to PixelConvert::
824 - fat setup of PixelConverter set in place in File::Initialise.
826 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
827 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
828 namespace at the file system level. So now you should convert your examples
830 gdcmHeader -> gdcm::Header
831 It would be nice if people keep in mind to no open the namespace, since it
832 allows compilation on broken plateform which were defining common symbol in
833 the standart namespace (like LP, Unknown ...)
835 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
837 The JPEG fragments are now parsed at the same stage than the RLE
838 information. All code related to JPEG is now in gdcmPixelConvert:
839 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
840 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
841 export a gdcmFile:: method. Those are simply global functions
842 (for the time being this is better than having them attach to
843 either gdcmFile:: or gdcmPixelConvert::).
844 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
845 and stores the result in a gdcmJPEGFragmentsInfo.
846 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
847 code (among other stuff) moved away from gdcmFile:; to
850 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
851 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
852 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
853 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
854 clean up of RLE related code.
855 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
856 - src/gdcmRLE.cxx removed
857 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
858 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
859 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
860 * CLEANUP_ROUND (9) for gdcmPixelConvert
861 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
862 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
863 away from gdcmFile:: to gdcmPixelConvert::.
865 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
867 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
868 This is because Parse7Fe0 used to parse the pixels to compute the
869 length. This task was passed over to FindDocEntryLengthOB() a long
870 time ago, EXCEPT I had forgotten the OW case...
871 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
872 we just recylce the code for parsing RLE fragments and computing
874 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
875 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
876 with the retired Parse7Fe0().
877 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
878 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
880 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
882 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
883 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
884 - src/CMakeLists.txt: alphabetic order reodering + new entries.
885 * CLEANUP_ROUND (4) for gdcmPixelConvert
886 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
887 to return an unused length.
889 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
891 this should be cleanner from the plane view. The iostream are erally a pain
892 to use to do simple stuff.
894 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
895 * Redo the compilation of the ijg jpeg library. Now only one source is
896 necesseray. No need to rename file by hand what so ever. CMake handle the
897 copying of the file within different directory, configure header file to
898 modify some symbol. The only addition made to ijg wasd a mangle table so
899 that symbol are different whether we are within 8bits or 12bits.
901 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * Added documentation of vtkgdcmReader on Website:
903 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
904 with it's binary name).
905 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
906 the Website to be more complete.
907 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
908 doxygenated documentation.
909 - Doc/DoxyVtkGdcmReaderExamples.txt added
910 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
911 DoxyVtkGdmReaderExamples.html )
912 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
913 * CLEANUP_ROUND (3) for gdcmPixelConvert
914 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
916 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
917 * CLEANUP_ROUND (2) for gdcmPixelConvert
918 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
920 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
921 * CLEANUP_ROUND for gdcmPixelConvert:
922 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
923 - src/gdcmPixelStuff[h|cxx] removed
924 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
925 - src/CMakeLists.txt changed accordingly
927 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
928 gdcmVersion.py moved to newly created ATTIC related
929 gdcmPython/SetupOldies/ directory.
930 * Autotools clean up:
931 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
932 - autogen.sh configure.in acinclude.m4 python.m4 removed
934 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * src/*.cxx *.h Reference to License.htm fixed to License.html.
936 * Doc/CMakeLists.txt, doxygen.config.in: fix.
937 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
939 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * TODO updated with Mathieu suggestions. I proposed a template for
941 describing TODO entries and used it for new entries.
942 * Added Doc/Website/CodingStyle.html, Developpers.html,
943 DeveloppersPython.html, GdcmDataCvs.html and
944 DownloadVersion0_1.html, DownloadVersion0_3.html.
945 * Some Doc/*.txt Doxygen files (which do not really concern the
946 documentation itself, but the website) moved to html and
947 placed in directory Doc/Website:
948 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
949 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
950 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
951 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
952 * CMakeLists.txt changed accordingly.
953 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
954 DeveloppersPython.html
955 * INSTALL nows refers to Doc/Website/Installation.html
957 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * Added Doc/Website directory, that contains a first raw version
961 2004-09-23 Jean-Pierre Roux
962 * FIX In order not to be poluted any longer by casting problems,
963 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
964 we can now delete[] it safely
965 * VoidArea is now called BinArea (less confusing name),
966 and all the methods called ...VoidArea... are now ... BinArea...
967 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
969 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
971 clear) TagHT, which is an inherited member of gdcmElementSet. It is
972 up to the destructor of gdcmElementSet to clean up TagHt and it's
975 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
976 * Test/CMakeLists.txt: update to follow gdcmData renamings.
977 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
979 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
980 * ENH: added some utility method that builds a flat dictionary
981 holding all the Dicom entries contained in the recursive structure
982 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
984 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
985 BuildFlatHashTable() that build a flat dictionary.
986 - src/gdcmElementSet.h: added a new private GetTag() accessor.
987 gdcmDocument is now a friend of gdcmElementSet.
988 - src/gdcmElementSet.cxx: clean up.
989 - Example/FlatHashTablePrint.cxx added.
990 - Example/CmakeLists.txt changed accordingly
992 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
994 moved away from gdcmDocEntrySet (since this class is an abstract class
995 acting like an interface). SQDepthLevel and BaseTagKey are now
997 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
998 and associated accessors. Doxygenation of the class.
999 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1001 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1002 Use SQDepthLevel accessor instead. ::Print() adapted.
1003 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1004 - src/gdcmDocument.cxx changed accordingly.
1006 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1008 - The following is the doxygen comment of the typedef declaration
1009 of gdcmTagKey in src/gdcmCommon.h:
1010 gdcmTagKey is made to old an "universal" (as in URL, Universal
1011 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1012 A dicom tag always has a group and an element, but a set of tags
1013 embeded in various (optionally nested) sequences and sharing
1014 the same group and element all share the same (group, element)
1015 "identifier". Hence the (group, element) cannot be used as an
1016 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1017 In order to construct a proper tag identifier (i.e. a key) we
1018 consider the following definition of a TagKey:
1019 - let Group, Element be the string representation of the
1020 group and element dicom tag members,
1021 - let ItemNumber be the string representation of the integer
1022 index of the considered item number of a sequence,
1023 Let the key of a tag embeded in a sequence, noted SeqTag, be
1025 /ItemNumber#Group|Element
1026 where "/", "#" and "|" are characters acting as separators.
1027 Then the general form of a gdcmTagKey is given by:
1028 Group|Element<SeqTag>
1029 where <SeqTag> means NO or many instances of SeqTag.
1030 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1033 but the gdcmTagKey of a tag "embeded" is the first item of
1034 a sequence, itself nested in the third item of a sequence is the
1036 0004|1220/2#0008|0082/0#0008|0090
1037 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1038 order to hold the new sequence compatible key. Previously, the
1039 GetKey() method would look in the underlying gdcmDictEntry.
1040 - src/gdcmDocEntry.cxx:
1041 -- constructor now copies the underlying DictEntry key, in the local
1043 -- ::Print: displays the member Key, instead of the (group, element).
1044 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1045 - src/gdcmDocEntrySet.h:xi
1046 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1047 -- now has a new BaseTagKey member.
1049 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1050 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1052 This poses the problem with the semantics of the following lines
1053 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1054 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1055 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1056 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1057 to the long FIXME note for what the problem is. Nevertheless in
1058 order to get things working the dicom dictionary was altered !
1059 Please fix things urgently...
1060 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1061 information), see above note on moving the member VoidArea. Nevertheless
1062 the following entries previously correctly set as US are now inproperly
1064 0028 1201 OW IMG Red Palette Color Lookup Table Data
1065 0028 1202 OW IMG Green Palette Color Lookup Table Data
1066 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1067 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1068 of gdcmDocEntry moved to gdcmSeqEntry.
1069 * src/gdcmSeqEntry.cxx: STYLE.
1071 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1074 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * gdcmPython/testSuite.py: all the test suite in python is now moved
1076 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1077 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1078 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1080 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1082 to avoid inclusion recursion until STL is reached.
1083 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1084 mecanism. errno.h is not included in gdcm anymore.
1085 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1086 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1088 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1089 gdcmData/TestAllEntryVerifyReference.txt
1090 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1091 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1092 exception_on_error parameter.
1093 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1094 - vtk/vtkGdcmReader.cxx changed accordingly,
1095 - Example/*.cxx and Test/*.cxx changed accordingly.
1097 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1099 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1100 enable_sequences removed from gdcmHeader constructor and dependencies.
1101 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1102 * gdcmPython/demo/PrintHeader.py: dummy fix.
1103 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1104 skip_shadow removed from gdcmHeader constructor and dependencies.
1105 * Example/*.cxx and Test/*.cxx changed accordingly.
1107 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1109 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1111 2004-07-21 Jean-Pierre Roux
1112 * FIX Now, Parsing and Printing a DICOMDIR do work!
1113 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1115 2004-07-20 Jean-Pierre Roux
1116 * FIX Some brain damaged headers have Zero-Lenght fields
1117 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1119 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1120 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1121 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1122 variable (instance of gdcmDebug) by a definition macro, and the instance
1123 is now in static in the gdcmDebug class
1124 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1125 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1127 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1128 * WARNING: ctest now depends more tightly on gdcmData. You should
1129 check out gdcmData properly for things to run smoothly...
1130 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1131 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1132 we need the pixels not be loaded in order to use the ValEntry
1133 that displays position and size).
1134 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1135 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1136 be deprecated. If you have any doubts about the advantages of a
1137 modern scripting language (read Python) versus grass root C++ (i.e.
1138 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1139 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1140 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1141 Anyhow, consider documenting the gdcmData images in
1142 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1144 * Test/CMakeLists.txt:
1145 - now uses TestAllEntryVerify.cxx
1146 - specific comments on oldACR00001.ima (now renamed in gdcmData
1147 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1148 gdcmData/TestAllEntryVerifyReference.txt
1151 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * src/*.[h|cxx] : typedef clean up
1153 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1154 - TagKey renamed to gdcmTagKey (for external usage)
1155 - VRKey renamed to gdcmVRKey (for external usage)
1156 - removal of typedef duplication.
1157 - Removed all unecessary inline keyword from class inline definitions.
1158 - Some method|function(void) declarations replaced with method|function().
1159 * src/jpeg/libijg12/jdhuff12.c:
1160 - printf polluting ctest removed.
1161 - TAB removal for comminting
1163 - TestAllReadCompareDicom.cxx: added a test that compares all the
1164 images in gdcmDataImages.h with corresponding images in
1165 gdcmData/BaselineDicom/. When baseline images are not present
1166 this test creates them.
1167 Note: we need to validate each reference image, but before that
1168 I'd like to rename them with a more explicit name...
1169 - CMakeLists.txt: changed accordingly.
1170 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1171 including each header needed).
1173 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1175 test suite to the Example directory. Are concerned:
1180 - TestWriteSimple.cxx
1181 * Test/CMakeLists.txt: added some comments on reasons for black listing
1182 image gdcmData/oldACR00001.ima
1184 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * Test/CmakeList.txt: removed the following from black list (to be coherent
1186 with removal from gdcmData):
1187 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1188 - gdcm-MR-PHILIPS-16.dcm
1190 Added the following because after last cvs update, they cause
1191 ctest -R TestReadWriteReadCompare
1193 - gdcm-MR-SIEMENS-16-1.acr
1195 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1196 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1197 new comments in this file) we temporarily (sigh) move to a weaker
1199 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1200 we don't need to black list the following images anymore:
1201 - 8BitsUncompressedColor.dcm
1203 - US-PAL-8-10x-echo.dcm
1204 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1205 fixes and the beautified code ;-)
1206 This fixes the bug introduced in version 1.42 (when beautifying)
1207 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1208 Note: ctest was blind to this bug (this means we need to still
1209 improve the test suite). The bug could be detected by using
1210 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1212 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1213 and by displaying the (garbage) produced file temp.XDCM...
1215 2004-06-29 Jean-Pierre Roux
1216 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1217 - replace by uggly but working old code :-(
1218 A lot of things should be OK again.
1219 It's really urgent to have a test suite that *tests*,
1220 to prevent Frog's beautifying sessions to break all the stuff
1221 (twice, withing a fortnigh ...)
1223 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1225 redundancy) to added Test/TestReadWriteReadCompare.cxx
1226 * Test/CmakeList.txt: because the compare test of
1227 Test/TestReadWriteReadCompare.cxx fails, the following images are
1228 black listed: - 8BitsUncompressedColor.dcm
1230 - US-PAL-8-10x-echo.dcm
1231 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1232 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1233 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1234 and ad-hoc kludge. This kludge is now removed, and on encountering
1235 such an image (OB field brain damaged) we set errno. Then in
1236 ::FindDocLength() we "fix" the length as being ALL what remains
1237 in the file (until EOF). We then proceed, hoping for the best...
1238 This fixes a SegFault in ShowDicom when trying to write such an
1240 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1241 (because TestWriteRead breaks on it, after a non conformal commit?).
1242 ctest now runs properly, except for MakeDicomDir (which was always
1243 broken) and the Python related stuff (still not fixed).
1245 2004-06-24 Jean-Pierre Roux
1246 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1247 FIX : Test/TestReadWrite now iterates on all the file names
1248 (instead of infinite loop)
1249 ENH : Test/TestWriteRead now iterates on all the file names
1251 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1252 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1254 2004-06-24 Jean-Pierre Roux
1255 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1256 when SamplesPerPixel =3
1257 - now Write is no longer confused by
1258 'BitsAllocated = 12" and 'BitsStored=12"
1259 - "UN" value representation Elements are now written correctly
1260 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1261 ENH : - now gdcmHeader has its own Write methods
1262 (in order to split the job that has not to be done
1265 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1266 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1267 loop on the same image until memory went out.
1268 Note: this means we still have gobs of memory loss in PrintDocument
1269 * src/gdcmDocument.cxx: fixes problem on parsing on file
1270 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1272 2004-06-24 Jean-Pierre Roux
1273 FIX : Write - All the Sequences and Sequence Item are now written
1274 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1275 is added a the end, when necessary.
1276 - A lot of brain-damaged images, that were read correctly are
1277 now written correctly
1278 - length compatible BinEntry are now loaded correctly
1279 (even for odd groups)
1280 Note : only Explicit Value Representation was checked.
1281 (question : is implicit VR really necessary for gdcm ?)
1283 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * DEVELOPPER: added a proposition of coding style.
1285 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1288 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1289 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1290 Use the gdcmDocEntry::Print() and Write() instead.
1291 * src/gdcmDocument.cxx: bug fix.
1293 2004-06-22 Jean-Pierre Roux
1294 FIX : gdcmDocument.cxx
1295 - Now we do recognize the JpegLossLess format (there was a misstyping in
1296 code 'beautyfication' :-(
1297 - Now we automaticaticaly load the Luts, if any
1299 2004-06-22 Jean-Pierre Roux
1300 In order : to write Sequences, whatever their imbrication level,
1301 : to allow user to create his own Sequences
1302 a lot of modif where necessary (adding, moving, or virtualising methods)
1304 WARNING : save your own sources *before* cvs up !
1307 ADD virtual void Write(FILE *fp, FileType filetype);
1310 ADD virtual void Write(FILE *fp, FileType filetype);
1311 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1314 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1315 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1316 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1317 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1318 ADD std::string GetEntryByName(TagName name);
1319 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1321 std::string vr = "unkn",
1322 std::string fourth = "unkn",
1323 std::string name = "unkn");
1324 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1325 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1326 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1327 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1328 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1329 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1330 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1331 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1334 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1335 ADD virtual std::string GetEntryByName (TagName tagName);
1336 ADD virtual std::string GetEntryVRByName (TagName tagName);
1337 REM virtual bool Write(FILE *, FileType);
1338 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1339 FILE *_fp, FileType type);
1340 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1341 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1342 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1343 REM virtual std::string GetEntryByName (std::string tagName);
1344 REM virtual std::string GetEntryVRByName (std::string tagName);
1345 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1346 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1347 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1349 std::string vr = "unkn",
1350 std::string fourth = "unkn",
1351 std::string name = "unkn");
1352 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1353 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1354 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1355 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1358 ADD virtual void Write(FILE *fp, FileType filetype);
1361 ADD virtual void Write(FILE *fp,FileType filetype);
1364 ADD virtual void Write(FILE *fp, FileType filetype);
1365 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1366 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1367 REM std::string GetEntryByName(TagName name);
1370 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1372 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1374 The default constructor invoked by the line
1375 gdcmHeader *f1 = new gdcmHeader( header );
1376 was gdcmHeader::gdcmHeader(bool) instead of the expected
1377 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1378 Hence the parsing wasn't executed... See also below.
1379 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1380 as explicit constructor didn't do the trick to fix the above problem.
1381 Could anyone explain why ?
1382 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1383 properly calls gdcmValEntry::Print() (that was weed out from
1384 code related to gdcmBinEntry).
1386 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * In order to fix memory leaks:
1388 - Test/TestWriteSimple.cxx: added cleaning of free store through
1390 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1391 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1392 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1393 (through the call to ::AddDicomDirMeta()) or the destructor
1394 would crash when deleting uninitialized ::metaElems].
1395 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1396 - src/gdcmDocument.cxx:
1397 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1398 from dynamic stores.
1399 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1400 was causing memory leaks.
1401 - src/gdcmSQItem.cxx:
1402 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1403 cleanly handled with polymophism: sorry but my milage is low).
1404 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1405 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1406 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1407 This avoids SegFaulting.
1408 - src/gdcmSQItem.h: coding style.
1410 - Test/TestWriteSimple still severely sucks. The output image content
1411 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1412 damaged when displayed with vtkgdcmViewer.
1413 - on memory leaks: TestWriteSimple leaks really less (see entry
1414 of 2004-06-18 in Changelog file for the call to valgrind).
1415 - on segfaults: ctest now passes all the tests but one (no more
1417 * Erroneous leading white fix:
1418 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1419 white[s] (as opposed to from >> xxx, that removes it [them].
1420 - src/gdcmTS.cxx: ditto.
1421 - gdcmPython/testSuite.py: dirty related kludge removed.
1422 * src/*: remaining references to gdcmParser removed.
1423 * src/*[cxx|h]: added copy[way]left header.
1426 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * In order to fix writing of dicom files:
1428 - Test/TestWriteSimple.cxx: a simpler example of writing.
1429 - Test/CMakeLists.txt changed accordingly.
1430 - src/gdcmDocument.cxx:
1431 -- The destructor now recursilvely removes potential sequences.
1432 -- Bug fix in ::IsJPEG2000()
1433 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1434 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1436 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1437 to only declared) and build on top of
1438 ::GetDocEntryByNumber(guint16, guint16).
1439 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1440 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1441 for usage in destructor and treatement of promotion in
1442 ::ReplaceOrCreateByNumber().
1443 - src/gdcmSQItem.cxx: destructor should better handle his job.
1444 Test/TestWriteSimple now runs (or at least it DOES something).
1445 * We can now start hutting memory links. A good starting point is:
1446 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1447 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1448 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1450 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * Valgrind note: after Mathieu Malaterre teached me how to read
1452 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1454 Using gcc, you can force the STL to use malloc and to free memory as
1455 soon as possible by globally disabling memory caching.
1456 With 3.2.2 and later, you should export the environment variable
1457 GLIBCPP_FORCE_NEW before running your program.
1458 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1459 simply vanish (it is still not clear to me, whether this means that
1460 STL std::string leaks or if valgrind believes it leaks...).
1461 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1462 running bin/gdcmTests makeDicomDir):
1463 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1464 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1466 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1467 SegFaulting (I drowned in DicomDir related code when trying to
1468 understand why the list is empty...).
1469 * src/gdcmDocument.h: first BSD license header try.
1470 * Doc/License.txt added.
1472 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * src/gdcmDocument.[h|cxx]:
1474 - Clean up of the Transfer related predicates. They are now all based
1475 on new method isGivenTransferSyntax, that (should) handle properly
1476 the padding problem.
1477 - general clean up, simplification, and coding style.
1478 - Specific clean up of Parse7FE0() (umproperly named actually).
1479 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1481 2004-06-14 Jean-Pierre Roux
1483 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1484 - fix the display of SQItem ordinal number
1485 - add the GetSQItemByOrdinalNumber method
1486 - remove some useless never written private methods
1488 2004-06-14 Jean-Pierre Roux
1490 - adding a constructor taking a gdcmDocEntry as an input param
1491 - ReplaceOrCreateByNumber now returns :
1492 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1493 a gdcmValEntry * if a string value is passed as a param
1495 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1496 according to the param type (no longer sets a gdcmDocEntry)
1497 - GetValEntryByNumber, GetBinEntryByNumber added
1498 - NewValEntryByNumber and NewBinEntryByNumber added
1500 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1502 - GetSQItemNumber and SetSQItemNumber added, to provide
1503 a (relative) Item identier inside a given Sequence
1504 \warning : some pb remaining around this number
1506 - AddEntry now takes the Item Number as a param
1508 - adding a constructor taking a gdcmDocEntry as an input param
1510 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * Memory leak hunt with the following command:
1512 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1513 --show-reachable=yes gdcmTests PrintDocument
1514 It looks like many (all?) leaks are due to the STL (or a bad usage
1515 of the STL. The lines producing the leaks now have a comment with
1516 a "MEMORY LEAK" tag: you can retrieve them with
1517 grep "MEMORY LEAK" src/*
1518 Here are two typical examples which I can't help fixing:
1523 char * test = "babo";
1524 name = test; //// <--- valgrind detects 960 bytes lost in
1525 //// call to std::string::operator=(char const*)
1526 name.clear(); //// Doesn't help !
1534 std::cout << "Type a bunch of characters followed by RETURN: ";
1535 getline(std::cin, line); //// <--- valgrind dectects a loss
1536 //// of 1320 bytes in call to
1537 /// std::basic_istream<>& std::getline<>
1543 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1544 * src/gdcmHeader.[cxx|h]:
1545 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1546 and related, moved away to gdcmDocument.
1547 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1548 the corresponding protected accessors of inherited class
1549 gdcmDocument, removed ! As a consequence gdcmFile had to be
1550 declared friend of class gdcmDocument (see below).
1551 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1552 - Clean up of undefined or unused methods.
1553 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1554 account the changes to gdcmHeader.h).
1555 * src/gdcmDocument.h:
1556 - gdcmFile is now a friend class (in order to take into account the
1557 changes to gdcmHeader.h).
1558 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1559 (see changes to gdcmHeader.h).
1560 - Accessors (reading on the form GetEntry*) are now public.
1561 - Clean up of undefined or unused methods.
1562 * src/gdcmDocument.cxx:
1563 - adaptation to changes to gdcmDocument.h
1564 - ::OpenFile now writes a verbose message when file cannot be opened.
1565 - some std::string properly set to VRKey
1566 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1567 references to gdcmDocument.
1568 * Test/TestFindTags.cxx: changed accordingly to above changes.
1569 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1570 cvs repository gdcmData.
1572 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1573 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1574 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1575 conflicts with gdcmValEntry::voidArea.
1576 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1577 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1578 Value representation between StringRepresentable and BinaryRepresentable.
1579 * src/gdcmDocument.cxx:
1580 - method ParseDES: proper indentation restored and usage of
1581 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1582 - method LoadDocEntry: the fingerprint left in the SetValue() of
1583 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1584 removed. Reverting to previous code segment with the proper
1585 dynamic_cast< gdcmValEntry* >.
1586 Note: this was (partially) breaking the python test suite
1587 (gdcmPython/testSuite.py) that made usage of the above
1588 fingerprint to check presence of "Pixel Data".
1589 * src/gdcmDocEntry.h: coding style.
1590 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1591 now taken into account.
1592 * gdcmPython/gdcm.i: adaptation to the new internal representation
1593 of gdcm (exit gdcmParser, hello gdcmDocument).
1594 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1596 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1597 anymore, but instead prints the loaded Python dictionary.
1598 * .... alas, the python testSuite is still broken.
1600 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1601 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1603 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1604 * src/gdcmUtil.h : export methods
1606 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1609 * Initial addition of automatic python testing
1610 * Initial addition of automatic image comparison
1612 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1613 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1614 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1616 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1617 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1618 * Test/ShowDicom.cxx : bug fix for msvc compilation
1619 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1621 2004-05-04 Jean-Pierre Roux
1622 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1623 new concepts (and new classes) :
1624 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1625 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1626 - Sequence Doc Entries (gdcmSeqEntries)
1627 a Sequence is composed of Items.
1628 Each item is a set of Doc Entries (this is recursive)
1629 The non uniqueness of the 'Dicom tag' is due to this recursivity
1630 (never taken into account)
1631 Our unability to add a new 'entry' in the header
1632 at the proper location (neither in the H-Table (map or multimap),
1633 nor in the Chained List is also due to this recursivity.
1634 Don't try, right now, to use/modify/compile these new sources :
1635 nothing is finished.
1636 We just commit all the stuff, 'as is', in order not to loose it.
1638 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1639 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1641 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1642 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1643 file prefix (SetFilePrefix)
1645 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * Add a new test: ShowDicom, for now this is just the c++ version of
1647 checkRead.sh, later it will be able to compare the image read against a
1649 * Replace the DEBUG on the stack with a global entry in cmake interface:
1650 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1652 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1653 * Add an example subdir, with a real example on how to read + write a
1656 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1658 * Doc/CMakeLists.txt: the main page is now properly differentiated
1659 between the developper and user version.
1660 * Doc/doxygen.config.in: dropped search related obsolete flags
1661 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1663 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1664 * DEVELOPPER: added some helpfull comments for compile/test/install
1667 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1668 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1669 src directory, now generated in the build dir.
1670 2. Tests as mentionned smarter
1672 4. Add a new method in gdcmDict that return the PubDict by name
1673 this is interesting for 3rd party lib like ITK,
1674 where we could set the institution name / patient name...
1676 * ENH: 1. Now the test suite is working for real
1677 2. All binaries are now output in the gdcm-bin directory
1678 (this was not true before)
1680 2004-04-28 Jean-Pierre Roux
1681 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1682 SeQuence indented printing of Dicom Header.
1683 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1684 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1685 Computation of SQDepthLevel is now part of gdcmHeader constructor
1686 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1687 tree-like structure of a Dicom Header.
1688 * FIX Test code cleaning
1690 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * ENH: Adding automatic testing
1692 1. Need a DartConfig.cmake to submit to public
1693 2. Add a test driver gdcmTest.cxx
1694 3. gdcmTestMain, an helper for the main test driver gdcmTest
1695 4. Files in Test don't have a main anymore, this becomes interesting
1696 when we add more and more tests, thus dsw don't have to load
1698 * ENH: Adding a GDCM_DATA_ROOT for testing
1699 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1700 one file instead of seven + some small cleanup
1702 2004-04-22 Jean-Pierre Roux
1703 * ENH Minor changes to the Print() methods.
1704 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1705 Header printing. Example given with :
1706 > PrintHeader fileName 2 new
1707 (SQ based tree-like structure still to be done for the Header ...)
1709 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1710 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1711 1. I have added some unsigned where needed
1712 2. Some function parameter not used -> (void)
1713 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1714 4. g++ don't like character '\' in comment
1715 5. #define jpeg_create_decompress jCreaDecompress
1716 this really need to be fixed
1717 6. virtualize destructor of gdcmObject ... leakage
1718 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1719 this also really need to be fixed
1720 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1721 remove compression file
1722 (as we only do decompression, right ?)
1723 * ENH: Change malloc/calloc/free with c++ equivalent
1725 2004-04-21 Jean-Pierre Roux
1726 * FIX gdcmHeaderHelper::GetXSpacing
1727 when a single value is found (bug ?), xpacing is now
1728 defaulted to yspacing
1730 2004-04-19 Jean-Pierre Roux
1731 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1732 * ENH add parameters :
1733 bool exception_on_error = false,
1734 bool enable_sequences = false,
1735 bool ignore_shadow = false
1736 to the gdcmFile constructors to be full gdcmParser compliant
1737 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1738 to allow reading of PAPYRUS 3.0 files
1740 2004-04-06 Jean-Pierre Roux
1741 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1743 2004-04-02 Jean-Pierre Roux
1744 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1745 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1746 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1748 2004-03-30 Jean-Pierre Roux
1749 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1750 for ACR file, written out as DICOM files (hope so...)
1752 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1753 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1754 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1755 moved to base class gdcmParser and only the specialisation is kept
1757 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1758 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1759 already does the job.
1760 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1761 (to be consistent with gdcmParser::WriteEntries).
1763 2004-03-30 Benoit Regrain
1764 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1765 upate of the object's instance. It's passed to 2 in the unfavorable
1766 case : one in the ExecuteInformation, one in the ExecuteData
1768 2004-03-29 Jean-Pierre Roux
1769 * ENH : Check on file type to be written moved
1770 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1771 * FIX : gdcmObject::ResetBoundaries now stops properly
1772 when end-of-list is reached
1773 : gdcmVersion modified (as Benoit Regrain asked)
1775 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1777 * src/gdcmUtil.cxx: added forgotten iostream include.
1778 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1779 equivalent to ExplicitVR in existing code).
1781 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1782 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1783 now contains all the gdcmGlobal related code.
1784 * minor coding style and doxygenation changes.
1786 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1787 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1788 now contains all the Debug related code.
1789 * minor clean-up of includes in src/*.cxx
1790 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1791 CreateCleanString) removed.
1792 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1793 * Doc/DoxyMainPageUser.txt added.
1794 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1795 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1796 src/gdcmDirList.cxx)
1798 2004-03-24 Jean-Pierre Roux
1799 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1801 2004-03-23 Jean-Pierre Roux
1802 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1803 big endian made volumes
1804 * ENH Now gdcmParser constructor and destructor are protected to forbid
1805 end user to instanciate class gdcmParser
1806 (only gdcmHeader and gdcmDicomDir are meaningfull)
1808 2004-03-22 Benoit Regrain
1809 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1810 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1811 gdcmSerie to gdcmDicomDirSerie
1813 2004-03-19 Jean-Pierre Roux
1814 * ENH Now the tree-like structure describing a DICOMDIR comming from
1815 an already existing DICOMDIR file is consistent with
1816 the home-made tree-like structure build ex-nihilo
1817 or build from the files held (recursively) in a Directory
1818 functions gdcmDicomDir::CheckBoundaries()
1819 gdcmObject::SetBoundaries() added
1821 2004-03-17 Jean-Pierre Roux
1822 * REM (Eric Boix bug) : removal of meaningless
1823 gdcmDicomDirImage::NewImage function.
1824 * FIX now file names and directory name are written properly in the
1826 * FIX now gdcmDicomDir constructor may be call without any trick
1829 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1830 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1831 of gdcmDicomDirImage::NewImage as empty function.
1833 2004-02-28 Jean-Pierre Roux
1834 * ENH add gdcmDicomDir:NewPatient
1835 add gdcmDicomDirPatient:NewStudy
1836 add gdcmDicomDirStudy:NewSerie
1837 add gdcmDicomDirSerie:NewImage
1838 to allow making gdcDicomDir object.
1839 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1840 (as opposite to the gdcmHeader chained list)
1842 2004-02-11 Benoit Regrain
1843 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1844 when using from python
1846 2004-02-10 Benoit Regrain
1847 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1848 * FIX : in gdcmDicomDir when the directory is empty
1849 * ENH : add callback and methods to get the progression of dicomDir
1852 2004-02-06 Jean-Pierre Roux
1853 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1854 - GDCM_META added to gdcmDicomDirType
1855 - class gdcmMeta created
1856 * ENH : - A brief summary is now displayed at the beginning of
1857 'testDicomDir' to help disaster magnitude estimation
1858 * REM : Now useless Test/explDICOMDIR.cxx
1860 2004-02-05 Benoit Regrain
1861 * ENH : add methods in gdcmObject to get the hash table or the list of
1863 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1864 * FIX : wrapping python for TagHeaderEntryHT
1866 2004-02-04 Benoit Regrain
1867 * FIX : even length for some strings when writting the dicom dir
1868 * FIX : sort the images in the dicom dir
1869 * FIX : Bug fix for python use of dicom dir
1870 * ADD : a python demo
1872 2004-02-04 Jean-Pierre Roux
1873 * FIX : Final solution (?) for icone embedded images
1874 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1875 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1876 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1877 gdcmData/gdcm-MR-SIEMENS-16.acr1
1878 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1879 to make full checking easier
1881 2004-02-04 Benoit Regrain
1882 * FIX : WriteEntries : coding style & logic in parameters
1883 * FIX : Set the elements to create the DicomDir in a dictionary file
1885 2004-02-03 Benoit Regrain
1886 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1887 * gdcmDicomDir : add the load of directory
1888 * Bug fix and print add-on
1890 2004-02-03 Jean-Pierre Roux
1891 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1892 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1893 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1894 * FIX gdcmParser.cxx : 'group length' elements are now considered
1895 as integers, even for shadow groups, when file is Implicit VR
1897 2004-02-02 Jean-Pierre Roux
1898 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1900 of the last synonym :-(
1901 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1903 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1904 * FIX taking into account the possible 7fe0,0010 multiplicity
1905 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1906 to allow removal of references to 7fe0,0010, to deal with
1907 ACR-NEMA images, when 0028,0200 is meaningfull
1909 2004-01-31 Jean-Pierre Roux
1910 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1911 no longer writes 'Un' on disk
1912 * FIX SQ elements with actual length are now dealt with corectly
1913 * FIX gdcmFile::WriteBase make the difference, for color images, between
1914 the length (for Palette expanded images)
1915 and Raw Length (non expanded image + Palette)
1916 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1917 (that broke Write). Replaced by UL.
1918 Aware user will reload the field if he
1919 thinks it's necesssary
1921 2004-01-30 Jean-Pierre Roux
1922 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1923 when 'dirty Acr' is found, to be compliant with the new
1924 IsReadable() methods.
1926 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1927 (no DOUBLE images in kosher DICOM,
1928 but so usefull for people that miss them ;-)
1930 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1931 DICOMDIR related utilities (not checked as Windoze compliant)
1933 2004-01-28 Jean-Pierre Roux
1934 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1936 2004-01-27 Jean-Pierre Roux
1937 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1938 to allow skipping the shadow elements, to save memory space.
1939 The TRUE value for this param has to be used
1940 with a FALSE value for the 'enable_sequence' param.
1941 ('public elements' may be embedded in 'shadow Sequences')
1942 * gdcmHeader methods now deal with 'embedded icones images' in the header
1943 (even when an 'icone image sequence' is announced by the
1944 element (0x0088,0x0200), but there is NO icone at all ...
1946 * gdcmHeader sometimes Image Location value doesn't follow
1947 the supposed processor endianity (see gdcmData/cr172241.dcm).
1950 * gdcmHeader add the method
1951 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1952 to get *all* the Header Entries with the same tag.
1953 GetHeaderEntrySameName is probabely *useless*
1954 (no meaning : Name is *not* an identifier within the Dictionary)
1956 2004-01-26 Benoit Regrain
1957 * Bug fix in the print of hexadecimal representations. Remove long fields
1958 in the print and add a third level of print to print them
1960 2004-01-23 Benoit Regrain
1961 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1962 * Bug fix on test suite after remove the strip made on not string fields
1963 * Split the IsReadable method between gdcmParser which test that the file
1964 is dicom and gdcmHeader which test that it's an image file
1966 2004-01-22 Benoit Regrain
1967 * DicomDir : clean code, add methods, set variables in protected or private
1968 * gdcmUtil : bug fix for the clean string method
1970 2004-01-19 Benoit Regrain
1971 * Add the use of shadow dictionaries
1972 * bug fix and coding style
1974 2004-01-19 Benoit Regrain
1975 * src/gdcmFile.cxx : bug fix concerning the close of file
1976 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1977 * Add the update of header entries using the shadow library
1979 2004-01-19 Benoit Regrain
1980 * removal of file gdcmHeader2.cxx
1981 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1982 inheriting from gdcmParser. This split is to prepare the integration
1983 of dicom dir parsing
1984 * bug fix under python
1986 2004-01-16 Jean-Pierre Roux
1987 * REM removal of class gdcmHeaderEntrySet
1988 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1989 * ADD add file gdcmHeader2.cxx
1990 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1992 2004-01-15 Benoit Regrain
1993 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1994 entries created while parsing the header. Thus, they will be destroyed
1995 when the gdcmDictSet will be destroyed
1996 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1999 2004-01-15 Benoit Regrain
2000 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2001 made a fatal error because of the memory release at the end of program.
2002 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2003 some memory and vtk seems to have some problems with that.
2004 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2006 2004-01-14 Benoit Regrain
2007 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2008 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2009 * src/*.[h|cxx] : make changes due to class name changes
2010 * gdcmPython/demo/*.py : bug fix due to method names
2012 2004-01-13 Benoit Regrain
2013 * src/*.[h|cxx] : coding style
2014 * vtk/*.[h|cxx] : coding style
2016 2004-01-13 Benoit Regrain
2017 * gdcmPython/testSuite.py : test the readable flag of file for tests
2018 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2019 It's lied to the stl compilation by MSVC (windows, always windows...)
2020 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2022 2004-01-12 Benoit Regrain
2023 * src/*.h : add comments
2024 * src/gdcmDictSet.h : set the method BuildDictPath in public
2025 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2026 directly setted in the source code
2027 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2030 2004-01-09 Benoit Regrain
2031 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2032 * setup.py : use a reference to gdcmVERSION
2034 2004-01-07 Benoit Regrain
2035 * Modification to compile with the distutils.
2038 2003-12-10 Benoit Regrain
2039 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2040 can use a gdcmHeaderHelper to load data
2041 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2042 made in the source code
2044 2003-12-10 Benoit Regrain
2045 * Update Windows projects and .cvsignore files
2047 2003-11-12 Jean-Pierre Roux
2048 * ENH gdcmHeader constructor has one more parameter (default value : false)
2049 that allows the user to 'go inside' the SeQuences only
2051 gdcmElValSet:Print takes it into account
2053 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * ENH: Update gdcmPython/CMakeLists
2055 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2056 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2058 2003-11-10 Jean-Pierre Roux
2059 * FIX : gdcmHeader::LoadElements is now based
2060 on the ListTag listElem member,
2061 not longer on the TagElValueHT tagHt member
2062 * ENH : PrintPubElVal shows (temporarily) both results,
2063 with the tagHt member and the listElem member.
2064 (it's easier to 'see' the problems when using Printheader)
2066 * FIX : old private member LgrElem is now splitted into
2067 ReadLength : Length actually found on disk (updated only
2068 if bug fixing is necessary), for internal
2070 UsableLength : Updated by FixFoundLength, to fix a bug
2071 or to allow Parser going on.
2072 Will allow to re-write a kosher header when a SeQuence
2073 with a length (not 0000) is found
2074 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2075 because gdcmElValSet::Add does not update ListElem
2078 2003-11-07 Jean-Pierre Roux
2079 * FIX misstyping in Transfert Syntax name table
2080 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2081 when they have an actual length (not 0000 nor FFFFF)
2082 (Nobody should care of it, but DICOMDIR explorers)
2084 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2085 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2087 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * ENH: vtkGdcmReader now supports LUT !
2089 (vtkgdcmViewer for now is not able to use them though)
2091 2003-11-05 Jean-Pierre Roux
2092 * in testSuite.py : new files names for checking the package
2093 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2094 that returns the pixel area size to the *aware* (vtk) user
2095 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2097 2003-11-05 Benoit Regrain
2098 * in testSuite.py : Modify the rules for checking the paths
2099 : Explicit error messages
2100 * in __init__.py : Related modif
2102 2003-11-03 Jean-Pierre Roux
2103 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2104 to be used by aware (vtk) users that want to manage
2105 LUT (and no to turn the PALETTE image into an RGB pixels one)
2106 * GetPixelType now returns 8U for 24 Bits images
2107 (vtkGdcmReader compliant)
2109 2003-10-31 Jean-Pierre Roux
2110 * Removal of *all* gdcmData images and add them again
2111 in order to loose the 'history' of un-anonymised images
2113 2003-10-31 Jean-Pierre Roux
2114 * RMV : removal of useless jBitsInJsample.h
2115 for both 8 and 12 Bits JPEG Lossy Libraries
2117 2003-10-31 Jean-Pierre Roux
2118 * ENH : Add the functions gdcmFile::GetImageDataRaw
2119 gdcmFile::GetImageDataIntoVectorRaw
2120 that act as GetImageData and GetImageDataIntoVector
2121 except the making of an RGB Plane from Gray Plane + LUT
2122 Intended to aware (vtk) users who know how to manage
2125 GetLUTRGBA return a R,G,B,A LUT if any
2126 lgrTotaleRaw gives the 'Raw' length
2127 GetImageDataRaw returns the gray Plane
2128 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2129 (They stay Grey, just like with other Dicom viewers :-(
2131 2003-10-30 Jean-Pierre Roux
2132 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2134 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2135 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2136 being coherents dicom files.
2138 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2139 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2141 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2142 * ENH: Two steps is necessary to please VC++ compiler...
2143 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2144 * ENH: Add include dir to medcon lib
2145 * FIX: only one function is being exported for now !
2146 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2148 2003-10-29 Jean-Pierre Roux
2149 * adding gdcmHeader::GetLUTRGBA
2150 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2151 --> Mathieu, the modif u're waiting for is not yet committed
2152 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2154 2003-10-27 Jean-Pierre Roux
2155 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2156 00191113.dcm DermaColorLossLess.dcm
2157 MxTwinLossLess.dcm RadBWLossLess.dcm
2158 * ENH: For version prior to vtkImageViewer2 -r 1.19
2159 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2161 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2162 * Removal of ido stuff in CMakeLists.txt
2164 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2165 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2166 * FIX: remove a call to ->Modified ... see comments
2167 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2169 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * FIX: Problem with path for libvtkgdcmPython
2171 * ENH: Try adding a search script for python site-package
2172 * RMV: Remove some file from medcon lib that are not necessary
2173 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2174 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2175 * FIX: More pragma disable fro VC++,
2176 I don't think I break something as it is also disable in VTK/ITK.
2177 But it fasten debug compilation time.
2179 2003-10-23 Jean-Pierre Roux
2180 * gdcm now deals with 16 Bits Run Length Encoded images
2181 (they are compressed as 2 planes images,
2182 one for the high Bytes, the other for low Bytes)
2184 2003-10-22 Jean-Pierre Roux
2185 * Now CheckRead takes into account :
2186 - the bugged 'Leonardo' Siemens images
2187 - the XA images, sent thru the burning VPRO station
2188 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2191 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * FIX: When copying a Makefile.am to CMakeLists.txt
2193 one should remove the '\'
2195 2003-10-22 Jean-Pierre Roux
2196 * in gdcmData adding a bugged 'Leonardo' Siemens image
2197 (wrong lengths in header)
2198 OK with gdcm, KO with the other viewers :-)
2199 * add a GE dlx XA image, thru the VEPRO burning station
2202 2003-10-21 Jean-Pierre Roux
2203 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2204 for a brutal checking of vtkgdcmViewer compliance
2206 2003-10-21 Jean-Pierre Roux
2207 * add the files for 'xmedcon' Jpeg Lossless library
2208 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2210 2003-10-21 Jean-Pierre Roux
2211 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2213 2003-10-21 Jean-Pierre Roux
2214 * garbage Siemens 'Leonardo' images dealt with
2215 (the patch is easy to remove)
2216 * cosmetic changes to avoid warnings
2218 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2220 no need to press 'r' now.
2222 2003-10-20 Jean-Pierre Roux
2223 * upgrade of checkRead.sh checkWrite.sh according
2224 to new Jpeg Lossless decompressor
2225 * add US.3405.1.dcm, a genuine RGB medical file ...
2226 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2227 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2229 2003-10-15 Jean-Pierre Roux
2230 * general anonymisation in gdcmData
2231 * adding the 'color files' from
2232 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2233 * adding some well knowed bugged-header images
2234 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2235 waiting for their inclusion in Python testsuite
2237 2003-10-15 Jean-Pierre Roux
2238 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2239 no longer seg faults when file is not found
2241 2003-10-14 Jean-Pierre Roux
2242 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2245 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2246 * TODO: *.in file to genereate a UseGDCM later
2248 2003-10-14 Jean-Pierre Roux
2249 * Some supposed-to-be Dicom Images have no preamble.
2250 OpenFile takes it into account
2251 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2252 * Missing elements added in dicomV3.dic
2253 (just to be affraid : have a look at
2254 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2255 and do it again next year ;->
2257 2003-10-13 Jean-Pierre Roux
2258 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2259 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2260 But there are NOT. It's fixed !
2262 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2263 * FIX: "jpeglib.h" was not found on VC++
2264 * FIX: vtkgdcm was not being installed
2266 2003-10-10 Jean-Pierre Roux
2267 * ENH : OpenFile closes the file if it *really* doesn't look like
2268 an ACR-NEMA / DICOM one.
2269 * FIX : testWrite no longer writes an empty file if the source file
2270 is not gdcm Readable
2271 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2274 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * FIX: CMake generate now documentation
2276 * ENH: out of source doc build !
2277 * ENH: Generate both user and dev documentation
2278 * ENH: Should work on windows too
2279 * ENH: Only one doxygen config.in file is needed
2280 * FIX: make install should be ok now on ùnix plateform
2281 * FIX: PATH to dictionary was wrong (missing /)
2282 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2284 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2285 * vtkGdcmReader is now able to read rgb dicom file.
2286 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2287 * added a gdcmViewer to vtk test, use mouse to control
2288 window level & window width
2290 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * CMake-ification of gdcm, we have now two build system
2292 * FIX: on cygwin Wsock32 doesn't exist
2293 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2295 2003-10-06 Emanuel Ollart
2296 * FIX : compilation process wad broken.
2297 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2299 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * change gdcmViewer -> vtkgdcmViewer
2301 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2303 2003-10-06 Jean-Pierre Roux
2304 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2305 ( e.g : well known GE images with a wrong elem length,
2306 : Philips MRI Images with a wrong Huffman table)
2307 * still to be done : allow the reading of bugged LEONARDO Siemens images
2309 2003-10-03 Jean-Pierre Roux
2310 * Odd length strings are padded with '\0' (not with spaces,
2311 to remain compliant with already defined strings,
2312 like Transfert Syntax UID and others)
2314 2003-10-03 Jean-Pierre Roux
2315 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2316 to allow displaying RGB images (not only by affim ;-)
2318 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2319 * vtkGdcmReader is now able to read rgb dicom file.
2320 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2322 2003-10-03 Jean-Pierre Roux
2323 * A few nasty patches to allow the reading of a lot of nasty images
2324 ( e.g : well known GE images with a wrong elem length,
2325 : Philips MRI Images with a wrong Huffman table)
2326 * still to be done : allow the reading of bugged LEONARDO Siemens images
2328 2003-10-03 Jean-Pierre Roux
2329 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2331 2003-10-03 Jean-Pierre Roux
2332 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2333 to allow displaying RGB images (not only by affim ;-)
2335 2003-10-03 Jean-Pierre Roux
2336 * gdcmFile::GetImageDataIntoVector now
2337 - deals with MultiFrames MultiFragments Run Length Encoded files
2338 - deals with YcBcR (YBR_FULL) files
2339 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2340 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2342 (no sample found :-(
2344 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2345 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2346 Two reasons: - clear things
2347 - third parties acces gdcm through header files, so won't
2348 suffer anymore VC++ complains
2350 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * add argv[1] in testvtkGdcmReader.cxx
2354 2003-09-24 Jean-Pierre Roux
2355 * The lines are now eigthy characters long.for
2356 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2358 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2359 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2360 char* to std::string. Thus, the use of strdup becomes useless. (see
2361 previous commis of Malaterre)
2362 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2363 before the last Malaterre's commit.
2365 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2366 * This commit should fix the Debug building under VC++, the problem
2367 was mainly a mixture of debug and release lib being loaded at startup.
2368 * I also remove a depency to a specific C function: strdup. Because I had
2369 to force the link to msvcrtd (whereas strdup is in libc).
2371 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2373 located in the gdcmCommon.h file. All use of reference of tha has been
2374 changed to now use the variable GDCM_UNFOUND.
2376 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2378 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2379 Dicom dictionary. The test suite can now be run again. Note:
2380 I'm note very happy with the " (RET)" changes. I believe this
2381 RETAINED comment should be dropped when parsing the dictionary.
2382 - PACKAGER corrected
2384 - AUTHORS updated and now in alphabetical order
2385 * Makefile.am now exports gdcm.dsw for Windoze users.
2387 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2388 * cygwin complains about missing std:: in subdir Test/
2390 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2391 * remove some methods that are now in gdcmHeaderHelper
2393 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * vtkGdcmReader set spacing and origin correctly
2396 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * Fix a few delete/delete[] mismatch
2399 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2401 interpretation to data given by gdcmHeader. For instance there are
2402 heuristics to get informations (look at different places).
2403 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2404 sorting DICOM images based on different strategies.
2405 * modified Makefiles accordingly.
2407 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2408 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2409 when building in debug mode
2410 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2411 src/win32/gdcmdll.dsp
2412 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2414 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2415 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2418 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * src/win32/libgdcmjpeg12.dsp was not dos format
2420 * src/win32/libgdcmjpeg12.dsp :
2421 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2422 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2424 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2425 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2427 * src/gdcmFile.cxx : bug fix in affectation type
2428 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2429 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2430 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2431 symbols... future problem ?
2433 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2434 * src/win32/libgdcmijpeg12.dsp was missing
2435 * modified gdcm.dsw accordingly
2437 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2438 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2440 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2441 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2442 commit of JPR (before his hollidays to facilitate our work).
2443 * setup.py : bug fix in code. Modifications made while the last commit
2444 of JPR. The code hasn't been tested before the commit... it's so
2445 useless to make that (for best programmer that is JPR) !!!
2447 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * tagged the current version as Version0_3 (i.e. version 0.3)
2450 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2451 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2452 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2453 * *.dsp : modifications to use new libgdcmijpeg8 library
2454 * setup.py : bug fix on VTKPATH variable
2455 * PACKAGER : adding all concerning windows
2457 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2460 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2461 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2462 test suite reported error.
2463 * PACKAGER file added (describes what a packager must do when
2464 packaging a new release).
2465 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2466 * configure.in: upgraded version number to 0.3.0
2467 * fixing build of rpm (through rpm -ta):
2468 - Doc/Makefile.am exports proper doxygen files
2469 - src/jpeg/libijg8/Makefile.am exports the include files.
2471 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2472 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2473 * src/gdcmHeader.h : formatting code
2475 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2476 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2477 We were obtaining error message from vtk. Now, creation of file list
2478 is made in an internal list to prevent this problem.
2479 Bug fix when output is empty.
2480 Bug fix in update of progress value. Previous commit for this was a bad
2482 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2484 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2485 * src/gdcmHeader.h : added method to get the file name
2486 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2487 files. Added method to remove all files on the input
2488 Added FIXME comment concerning the bad parsing of header made by
2489 ExecuteInformation method (in ExecuteData method)
2491 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2493 when using make instal.
2494 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2495 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2497 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2498 * setup.py : adding include dir of jpeg lib to compile all sources
2499 * */Win32/*.dsp : JPR fix for windows compilation
2501 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2502 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2504 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2505 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2507 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * setup.py is again effective on un*x (takes into account the
2509 addon of the jpeg library)
2510 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2511 * Doc/Doxy* updated (includes above enhancements)
2512 * INSTALL now points to web documentation
2514 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2515 * src/gdcmHeader.h doesn't make unnecessary reference to
2517 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2519 * src/gdcm*.[cxx|h] :
2520 - to allow compilation with gcc 3.x
2521 -- clean up of STL usage (added explicit usage of std::)
2522 -- small fixes on exceptions.
2523 Note: linking not tested !
2524 - clean of doxygen comments to avoid warnings at documentation
2526 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2527 dependent convertion).
2529 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * Clean up of previous JPR garbage commit (not even commented in the
2532 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2533 - moved all jpeg related files from src to src/jpeg/libijg8, with
2534 addition/modification of Makefile.am and configure.in.
2535 - the testSuite is still brain damage (not guilty).
2537 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2538 * WrapVTK.py : modifications to get correctly vtk source files to
2540 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2541 (FileName -> Filename)
2543 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * vtk/vtkGdcmReader.[cxx/h]:
2545 - UpdateProgress method should now be effective
2546 - removed the limitation on having only images loaded (as opposed
2548 - when building a stack of images/volume, a lesser number of
2549 gdcmHeader and gdcmFile instances should be used (hopefully
2550 accelerating things).
2551 - when building a stack of images/volumes, files which are not
2552 loadable (wrong path-filename, wrong permissions on existing file,
2553 or file not parsable by gdcm) are replaced with a black image
2554 in the stack (for the caller to notice the problem).
2556 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2559 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2560 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2561 between standard library (std) and vtk library (problems are found
2562 under Windows... thanks Windows !)
2564 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2567 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2569 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2572 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * When compiling with distutils (see setup.py) the C++ compiler is
2574 called with different flags than the default ones (with automake).
2575 In order to fix all those warning, I compiled gdcm with the command
2576 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2577 and went for warning fixes:
2578 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2579 up from unused variables.
2580 - vtk/vtkGdcmReader.cxx: potential bug fix.
2581 * src/gdcmHeader.h: Doxygen warning cleanup
2583 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2584 * gdcmPython/gdcm.i:
2585 - typemaps correction to take into account the systematic replacement
2586 of "using namespace std" with std:: prefix e.g. std::list,
2587 std::string... (cf changes of 2003-05-21).
2588 - gdcmGlob global variable of type gdcmGlobal (defined in
2589 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2590 exported to Python a as cvar.
2591 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2592 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2593 gdcmDictSet.GetPubDictTagNames() and
2594 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2595 C++ static methods).
2596 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2597 with the above changes.
2599 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2600 * setup.py, manifest.in : bug fix under linux
2602 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2603 * Modification of setup.py to compile vtk part too. Then, we have 2
2604 wrappers which must work with same distutils. For that, we have a
2605 generic distutils in distusiltsWrapping.py ; with :
2606 - build_extWrap class to wrap generically all extensions,
2607 - ExtensionWrap base class for all wrapping extension that contains
2609 - Wrapper interface which wrap sources
2610 + In WrapSwig.py we have extension and wrapper for Swig
2611 + In WrapVTK.py we have extension and wrapper for VTK
2612 * MANIFEST.in : modifications to consider vtk directory and new python
2613 files for compilation
2615 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2616 * Added python wrappers of vtkGdcmReader vtk class (see the
2617 source in vtk/vtkGdcmReader.cxx) :
2618 - vtk/Makefile.am now builds a library
2619 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2620 python library (as opposed to _gdcm.so wich are the python
2621 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2622 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2624 - configure.in has an additional flag --enable-vtk that needs
2625 to be set to enable compilation of vtk related code, that is:
2626 + vtk/vtkGdcmReader.so and
2627 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2628 + gdcmPython/vtkgdcmPython.so (see above)
2629 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2630 be read when compressed or when HighBit + 1 != BitsStored),
2631 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2632 the usage of the python wrapper of vtkGdcmReader vtk class.
2633 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2634 * src/*.[h] all occurences of stl classes are now prefixed with
2635 std::, and all occurences of "using namespace std;" where removed.
2636 This is to avoid pollution of global namespace in included files.
2637 Apparently vtk does not avoid this pitfall: when using both
2638 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2639 collision of various stl members (principally cout...).
2640 * gdcmPython/testSuite.py now cleanly removes temprory generated
2642 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2643 comply with above changes)
2645 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2646 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2647 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2648 vtk data structure (an image Flip was required).
2649 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2650 * cosmetic changes in documentation.
2652 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2653 * src/gdcmHeader.cxx: the constructor no longer exits when an
2654 unexisting file is given as argument.
2655 * The subdirectory Data (containing all the images used for the
2656 test suite) is not part of this repository anymore. A new module
2657 containing those images is now available at
2658 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2659 with the name gdcmData.
2660 All the python scripts (including the package initialisation file
2661 gdcmPython/__init__.py) were adapated to take this change into
2662 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2664 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2665 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2666 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2667 demo of the usage of this class.
2668 Compilation of this vtk part is only done when using the --enable-vtk
2669 at configure (or autogen.sh) stage.
2671 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2672 * More memory link related corrections and documentation fixes.
2674 - maximum info is obtained with a command of the form:
2675 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2676 --show-reachable=yes PrintHeader
2677 - the remaining reachable blocks seem to come from the STL
2678 allocation scheme through the usage of map and list. It looks
2679 like this memory cannot be freed but it is not a memory leak
2680 (in fact further invocation to the STL would recollect the
2681 unused memory allthough it cannot explicitely be freed).
2682 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2683 of displaying an image parsed with gdcm and displayed with VTK.
2684 Note: some images don't seem to work e.g.
2685 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2686 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2687 Allthough this weakens the semantics, it is a ditch attempt to
2688 make gdcm more thread friendly.
2690 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2691 * Memory link hunt (by using valgrind through the command
2692 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2693 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2694 gdcmHeader::_dicom_vr.
2695 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2696 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2698 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2700 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2701 * src/Makefile.am now exports all the necessary include files at
2705 * UpdateGroupLength replaced by new one
2708 * UpdateGroupLength re-written using H-Table
2709 (named UpdateGroupLengthNew untill checks are over)
2711 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2712 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2713 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2715 - gdcmHeader::GetPubElValSet removed.
2716 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2717 UpdateGroupLength, WriteElements, Write.
2718 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2719 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2720 carried the same semantics.
2721 - src/gdcmHeaderIdo.cxx changed accordingly.
2722 - gdcmFile::WriteBase now regroups all the codes from previous
2723 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2724 - enum FileType moved to gdcmCommon.h
2725 * src/gdcmHeader.cxx AddDefault trashed
2726 * gdcmGetXSize added
2727 * getimageDataSize now calls gdcmGetXSize
2728 * Test/*.cxx changed to agree with above changes
2730 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2732 (to avoid double call by end user).
2733 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2734 by end user, since gdcmHeader::gdcmHeader now handles it.
2736 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * gdcm/Doc many doxygen changes:
2738 - Doxyfile now has two different versions, DoxyfileUsers that generates
2739 the html.users end users oriented documentation and
2740 DoxyfileDeveloppers that generates the html.developper developper
2741 oriented documentation.
2742 - README changed accordingly
2743 - requirement.txt removed (old design info moved to TODO).
2744 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2745 DoxyMainPage.txt, DoxyPython.txt provide more information.
2746 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2747 be updated by simply regenerating the docs with doxygen and copying
2748 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2749 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2750 all the tests in the form "if (<map>.count() >1)" were removed.
2751 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2752 ill-formed documentation sections.
2753 * src/gdcmHeader.cxx: ditto
2755 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * setup.py fixed for un*x (needed macro for stdint.h)
2757 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2758 un*ces with sh-utils test utility.
2759 * gdcmPython/demo/test.py renamed to PrintHeader.py
2760 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2761 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2762 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2763 * src/gdcm*.cxx JPR's bad inclusion fixed.
2765 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2767 * gdcmPython/demo/test.py changed accordingly.
2769 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * gdcmPython/Makefile.am fixed linking against libstdc++
2771 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2772 * Swig subdir (historical tests of swig version 1.3.17++) removed
2773 * Test/testChangeEntete.cxx some lines commented out in order to make
2775 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2776 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2778 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2780 hence the user doesn't need this explicit call.
2781 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2782 i.e. LoadElements() call removed.
2783 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2784 - src/Makefile.am declares the proper flag for g++.
2785 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2786 for adding user defined new tags.
2787 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2788 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2789 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2791 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2792 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2793 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2794 src/Makefile.am : the project should properly compile and install
2795 with the autotools, included the python wrappers part.
2796 * gdcm.spec.in : added a spec file for RPM packaging.
2798 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2799 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2801 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2803 to exported to the environement (see gdcmPython/testSuite.py
2805 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2806 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2807 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2808 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2809 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2811 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * gdcmPython/__init__.py doesn't crash anymore when running in
2813 in InstallMode or PreInstallMode but with an environment given
2814 value of GDCM_DICT_PATH.
2815 * src/gdcmDictSet.[cxx/h] coding style.
2817 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2819 * src/gdcm.h general comments moved to TODO, and README
2820 * src/gdcm.h should now be seen as a user commodity (including it
2821 should suffice to fully use gdcm). It is nowhere including within
2822 any of the kernel files src/*.cxx and src/*.h.
2824 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2826 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2828 * src/gdcm*.cxx only include their corresponding include file
2829 (as opposed to gdcm.h)
2830 * gdcmPython/gdcm.i changed accordingly
2831 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2832 the autogen.sh generated "make snapshot" command to work.
2833 * autogen.sh removed history related references to crea package.
2835 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2836 * distutilsSwigCPlusPlus.py work around some swig portability
2839 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2841 was done in a last ditch attempt to get setup.py _really_
2842 operationnal. The python/gdcmPython layaout add the advantage
2843 of hidding away the python related distutils specific files
2844 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2845 Alas, the src directory was out of scope (i.e. it's relative
2846 position to setup.py was ../src) which made things impossible to
2847 handle (see previous version of python/setup.py). Crossing fingers...
2849 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * python/setup.py now works on Un*x. (harder than I thougth)
2851 * python/distutilsSwigCPlusPlus.py can now have include files
2852 among the list of sources.
2854 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2855 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2856 * modifications in MSVC projects
2858 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * As stated by the first lines of Test/ExceptionAndPython/README, it
2860 looks like we can move back to original usage of exception within
2861 src/gdcm* and hence remove the errno stuff that was introduced
2862 as a quick and dirty fixture of this problem (added to the TODO).
2863 * Doc/Doxyfile configuration file for Doxygen and corresponding
2864 README file for usage added.
2865 * Test/testWrite.cxx added. This new test comes from a split of
2866 test.cxx that is now reverted to its original purpous i.e.
2867 testing the proper parsing of a Dicom related file.
2868 testWrite.cxx concentrates on testing the IO part of gdcm.
2869 * Test/bug1.cxx (containing a bug on WIn32) added.
2870 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2871 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2872 whose purpose is to publish the content of the TagNames of the
2873 Dicom public dictionary were not accessible without an
2874 instance of class gdcmHeader.
2875 - those methods are now static methods of gdcmDictSet and hence
2876 require no instances at all to be invocated.
2877 - within gdcmDictSet this change required to change some method
2878 to class methods (i.e. are now static) among which SetDictPath
2879 (renamed to BuildDictPath) and LoadDefaultPubDict.
2880 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2881 the above changes by calling the new method classes of gdcmDictSet.
2882 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2883 the above to be effective.
2884 * python/gdcmPython: in order to wrap properly the above changes
2885 for Python, swig version now needs to be > 1.3.17.
2886 * python/gdcmPython/Makefile fixed to adapt itself to new
2887 configure/make shema introduced by Johan Montagnat (thanks for the
2888 contribution). Alas this Makefile cannot be turned into a proper
2889 Makefile.am without some heavy changes in the configure.in
2890 (for python dectection).
2891 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2892 now avoids publishing the empty entries.
2894 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2895 * python/setup.py : bug fix concerning install under windows
2896 ExtraPath reused :-P
2897 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2899 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2900 * Dicts/dicomV3.dic : remove double spaces !!!
2901 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2902 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2905 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2906 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2907 method. Doxygenation.
2908 * src/gdcm.h clean up of JPR spurious comments.
2910 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * python/distutilsSwigCPlusPlus.py now properly collects the
2912 shadow classes generated by "swig -c++" (gdcm.py in our case)
2913 when using "python setup.py install".
2914 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2915 reexports the working classes.
2916 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2917 by the classical C errno scheme. This is to prevent an obscure
2918 behavior of the python wrappers when importing wxPython.wx prior
2919 to gdcmPython (which ended up in an abort call). An illustration
2920 of this oddity can be found in the Test/ExceptionAndPython
2921 subdir (see the README file). This problem probably due to
2922 an combination of g++ and dynamic loading.
2923 * added Test/ExceptionAndPython (see above)
2925 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * Changed the layout of the python part to avoid bloating main
2927 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2928 i.e. the distutils arsenal. All the python related stuff is
2929 again in a python subdir, but the package itself is now in
2931 * setup.py was cleaned up:
2932 - pythonIncludePath removed
2933 - python setup.py bdist target is now functional.
2934 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2935 collision with other packages). gdcmPython/demo/*.py changed
2938 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * python subdir moved to gdcmPython (preparation of distutils packaging).
2940 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2941 distutils installer is operational.
2942 * - gdcmPython/__init__.py now properly loads the swig generated
2943 shadow classes (from gdcm.py).
2944 - gdcmPython/demo/*.py changed to import the package gdcmPython
2945 instead of gdcmPython/demo/load.py.
2946 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2948 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2950 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2951 entries within the associated public Dicom dictionary resp. the same
2952 information but sorted by the fourth field (PAT, IMG, DIR) of the
2954 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2955 are now in the "???" group.
2956 - python/gdcm.i changed accordingly,
2957 - python/demo/printGroupedPublicDict.py added, that gives an example
2958 of the above new functionalities in Python.
2960 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2961 * src/gdcm.h, gdcmHeader.cxx:
2962 - historic references to glib's g_malloc and g_free (#defined)
2963 were definitively removed.
2964 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2965 * src/gdcmElValSet.cxx:
2966 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2967 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2968 - GetElValue(string) renamed to GetElValueByName.
2969 - Added GetElementByName(string).
2970 * src/gdcmHeader.cxx: added
2971 - GetPubElValRepByNumber(guint16, guint16)
2972 - GetPubElValRepByName(string)
2973 - GetShaElValRepByNumber(guint16, guint16)
2974 - GetShaElValRepByName(string)
2975 - GetShaElValByNumber(guint16, guint16)
2976 - GetShaElValRepByName(string)
2977 - GetElValRepByNumber(guint16, guint16)
2978 - GetElValRepByName(string)
2979 - GetElValByNumber(guint16, guint16)
2980 - GetElValRepByName(string)
2981 * Doc/requirements.txt added.
2983 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2984 * Test/Makefile building now depends on the one of libgdcm.so
2985 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2986 pixel data) aware which enables finding the address (offset) of
2987 the pixel data of JPEG encoded DICOM files. This leaves only a single
2988 file in the testSuite whose pixel data address (offset) is unknown.
2989 * python/testSuite.py changed accordingly.
2991 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2992 * VC++ has some strong limitations when working with the STL, as stated
2993 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2994 "Also note that some STL containers (map, set, queue, list, deque)
2995 cannot be exported. [...]
2996 Some STL classes contain nested classes. These classes can not
2998 This is caused by a designed limitation that once a template
2999 class is instantiated, it can not be re-instantiated and
3001 Since our usage of map<> is ubiquitous in gdcm, this "designed
3002 limitation" of VC++ is a pitfall.
3003 Hence the Python wrappers of gdcm cannot be incrementally linked
3004 against the c++ dynamic library. The dirty but only workaround is
3005 to forget about incremental link of dynamic libraries and to generate
3006 the Python wrappers library with the inclusions of the underlying C++
3008 The following modifications concern this matter on Win32/VC++:
3009 - wrapping python correct with standalone wrapped dll (don't use separate
3010 dll under windows !!!!)
3011 - python21_d debug mode enabled (ask Frog how to use it :-)
3012 - NO problem with having an STL member of class for example string in C++
3013 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3014 - Python test of dcmlib in Python is ok under windows on a large set
3016 * removed glib references
3017 * typedef's inserted in gdcm.i for correct swig type management
3019 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3020 * python/demo/*.py load.py extracted from test.py. Added explore.py
3021 that only displays required tags and testAll.py that parses all
3022 the files of the testsuite without using unittest.
3023 * python/testSuite.py other additional test on new files added.
3024 * Data/* new test files added accordingly to the testSuite.
3025 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3026 the vr in the file differs from the one of the dictionary.
3028 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3030 values, but limits itself to values which are below a user specified
3031 size (by default 1024 bytes).
3032 * python/gdcm.i : elements not loaded (because their size is above the
3033 user specified treshold) are exported with their TagKey as key of the
3034 python dictionary. This enables the testsuite to make some checks
3035 on the unloaded elements (since we have their offset and size).
3036 * python/testSuite.py
3037 - now tests for the existence and proper value of the pixel data
3038 - two new examples added.
3039 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3041 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3042 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3043 aware. See the strategy comments in gdcmHeader::FindeLength().
3044 * Test/test.cxx now accepts a filename as first argument.
3045 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3046 * python/testSuite.py changed to integrate test on above files.
3048 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3049 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3050 the vr was also RET.
3051 * python/testSuite.py more tests added.
3053 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * python/testSuite.py unittest test suite added (uses Data)
3055 * Data/* dcm and acr files for the test suite.
3056 * glib dependance removed from un*x version. We now use ISO C99
3057 7.18 Integer types (see stdint.h)
3058 - python/Makefile, src/Makefile src/gdcm.h
3059 * src/ when an explicit vr (like dicom files) suddenly poped an
3060 implicit element we use to mark the underlying DictEntry of the
3061 concerned ElValue with "Implicit". This strategy was damageable
3062 too the public or provite dictionaries, since some of their vr
3063 would be changed. Since Header::FindLength heavily relies on the
3064 detection by Header::FindVR of falsely explicit elements, I
3065 added an extra ImplicitVr member to ElValue (boolean).
3066 The rest of the changes we the necessary adaptations.
3068 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3071 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3073 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3074 * Adaptation for porting to VC++:
3076 o forced to use std namespace (for string to be known)
3077 o all class use __declspec export style on WIN32
3078 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3079 (in stdlib.h on Win32 but in std:: for gcc)
3080 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3081 variable GDCM_DICT_PATH.
3082 * src/gdcmHeader.cxx verbose comments made discrete.
3084 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3085 * python/gdcm.i: added a typemap that converts a C++ hashing table
3086 to native Python dictionary.
3087 * python/demo/test.py:
3088 - now uses the native dictionary for exploration of gdcmHeader.
3089 - takes an optional filename argument (the file to parse).
3090 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3091 PubElVals hashing table.
3092 * Dicts/dicomV3.dic removed error prone trailing spaces.
3094 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * Python wrapping process moved away from src/Makefile to
3096 newly created python/Makefile (as well as gdcm.i)
3097 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3098 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3099 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3100 from the environement variable GDCM_DICT_PATH (when existing).
3101 * src/gdcmDict::GetTag bug fix.
3103 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * Straightforward temporary fixes for swig to build the python wrappers.
3105 src/Makefile now has a python working entry [by working we mean
3106 that we can import de shadow classes without errors].
3108 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * hashtest.cxx removed (since already in Test)
3110 * src/gdcmlib.h renamed to src/gdcm.h
3111 * src/dcm.i renamed to src/gdcm.i
3112 * src/Makefile prepared for python wrapping
3114 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * src/gdcmHeader.cxx :
3116 - Parsing of header is now separated from loading of element values
3117 (see gdcmHeader::LoadElements).
3118 - general clean up of hopefully all file access (creation of
3119 ReadInt16 and ReadInt32)
3121 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * src/gdcmHeader.cxx :
3123 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3125 - SetLgrElem renamed to SetLength
3126 - GetLgrElem renamed to GetLength
3127 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3128 * src/gdcmElValSet.cxx fixed both GetElValue methods
3129 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3130 due to IdoDude was cleaned out.
3132 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3134 concentrates on finding the value representation (when it exists).
3135 RecupLgr now only finds the element value length, and it avoids
3136 returning the unecessary skL (skipped length).
3137 Also, offsetCourant was simply removed (with taille_fich) since
3138 it was redundant with the File position internals (by using
3139 ftell and fseek). This also made skL (see above in RecupLgr) usage
3141 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3142 on the libido specificities which are handled through class
3144 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3147 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3148 * Truckload of changes. Parsing of header is barely functional
3149 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3151 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3152 * src/gdcmHeader.cxx many addons of low level methods
3154 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3156 and _IdDcmSWAP_LONG.
3158 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3159 * This corresponds to all the changes decided at the meeting of
3160 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob