1 2005-04-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.cxx : remove the default array of initialization.
3 The static array contained pointers to non-static values (comming from
4 strings). To have coherences, when creating files, these values can't be
5 static. So, the array can't be static, too ! To simplify, the array have
6 been replaced by repeted lines to insert values in the File
8 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
10 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
12 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
13 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
14 (Dicom Element) into the Sequence Item
16 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/*.cxx : first parss to normalize file organisation
19 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmDirList.[h|cxx] : add method to find a directory
21 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
23 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * Finish cleaning up my JPEG mess. Should be ok now.
25 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
26 contained within the RLE* class(doh!)
28 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
29 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
30 * SerieHeader::AddFileName() creates as many Coherent Files lists
31 (same Serie UID) as it founds different Serie UID
32 amongst the files instead of discarting any file
33 that doesn't match with the first one he found.
34 * SerieHeader::OrderGdcmFileList has now one parameter :
35 the Coherent Files list the user wants to sort
36 * SerieHeader::GetFirstCoherentFileList() |
37 * SerieHeader::GetLastCoherentFileList() | allow to parse
38 the set of Coherent Files lists
39 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
40 compatibility (it returns the *first* Coherent Files list,
41 since there was only one before)
42 * Test/TestSerieHeader gets gdcmData as a default root directory
44 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Remove friend between DocEntry and File classes
46 * Remove friend between PixelReadConverter and RLEFramesInfo,
49 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
51 0002|0000. The value was incorrect.
53 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
56 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmUtil.cxx : compilation fix on Win32
58 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
59 variable, to be easy found. Add methods to change the default UID.
60 Amelioration of the CreateUniqueUID to use the correct default UID.
61 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
64 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/TestVR.cxx : fix memory leaks
67 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
68 * Rewrite the base 256 to base 10 conversion, using string operation only.
69 This allows us to get rid of the problematic 64bits integer type (does not
70 always exist on target platform).
72 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
73 * Add construct and destructor to class gdcm::Debug to close the debug file
75 * Don't let uset to open twice the same file
76 * gdcm has now an official UID prefix,
77 supplied by http://www.medicalconnections.co.uk
78 1.2.826.0.1.3680043.2.1143
79 (Thx to Mathieu for providing URL)
80 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
81 to be able to perform some more tests
82 * gdcm::ContentEntry : Contructors and Destructor are now protected,
83 in order to be sure no user will try to use them.
84 (at user level, only the children classes are meaningfull)
86 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * move RLEInfo & JPEGInfo from Document to File
89 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * FIX : remove so many friend between classes
92 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
94 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
96 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
97 In order to avoid missbehaviour :
98 . gdcm::DocEntry is now specialized in
99 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
100 - gdcm::ContentEntry (Dicom entry with a 'content')
101 . gdcm::ContentEntry is specialized in
102 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
103 characters value, or integers)
104 - gdcm::BinEntry (Dicom entry with a non strig representable value
105 (user hasn't any longer to thing about the precedence of his dynamic_casts)
107 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * Test/VTKTest*.cxx : bug fix under linux
110 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
112 use with python. Some methods are moved from Document to ElementSet or
113 DocEntrySet. The equivalent methods to ElementSet have been added to
114 SQItem and are virtual in DocEntrySet. Methods that may have the same code
115 in SQItem and ElementSet is directly placed in DocEntrySet
117 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * Test/VTKTest*.cxx : remove the show variable in each test method because
119 it's useless (the viewer variable replace this variable)
121 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmDocument.cxx : bug fix on potential memory leak
123 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
124 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
125 Add ClearXxx methods to remove all the content of the list or map
126 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
128 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
129 * methods ReplaceOrCreate renamed as Insert
130 (nobody will be any longer confused by 'CreateOrReplace')
132 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
133 * Grealty simplify the JPEg decompression, no need to differenciate based on
134 the JPEG possible type (with/without fragment, with/without multiple frame).
135 Everything is done throught the JPEG IO Suspension mechanism in IJG
137 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
138 * Stage 3 of normalization :
139 in order to avoid any missunderstanding while reading method names :
140 - All the methods xxxEntry now deal with dicom Entries
141 - Methods GetEntry splitted into
144 - Method SetEntry renamed as SetEntryValue
145 - Method SetEntryBinArea let as it was
147 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
148 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
149 - Position correctly the entry points for JPEG2000 and JPEG-LS
150 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
152 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
154 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
155 with other method names
156 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
157 * Test/TestDicomDirElement.cxx : add new test
159 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
160 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
161 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
162 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
163 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
164 So can't you use __int64 in ostream at all.
166 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * bug fix for compilation on MSVC6
168 * gdcmPython/gdcm.i : rename of classes missed
170 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 * Stage 2 of names normalization :
172 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
173 (easy to understand ...)
174 - gdcm::FileHelper replaces old class gdcm::File
176 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
178 type and not a string. So, there remove problems on the format of the
181 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
182 * Add Example/TestPapyrus.cxx
183 - reads a Papyrus file (gdcm::Header compliant),
184 - gets the pixels of all the images, using low level iterators
185 - writes an multiframes Dicom image.
186 (Just to show it's *possible* to do that)
187 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
190 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
192 Thus, DicomDirXXX are created with a flad that indicates if the created
193 object is empty or not (when not empty, the DicomDirElement is used to
196 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
198 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
200 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
203 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
205 Remove all access to the hash-tables or lists in the objects.
207 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
209 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
210 be complient with all the gdcm source code
212 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
216 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
220 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Test/ : rename VTK tests to have a best name for the tests
222 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
223 GetFirstEntry/GetNextEntry use
225 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
226 * In SerieHeader::ImagePositionPatientOrdering()
227 // a Dicom 'Serie' may contain scout views
228 // and images may have differents directions.
229 // -> More than one may have the same 'pos'
230 // Sorting has then NO meaning !
231 Thx to Eduardo Davila for reporting bug.
233 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
235 test. Now it's on image content and not on the resulting visualisation...
236 might solve the problem on linux when using the OpenGL drivers
238 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
239 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
240 DicomDirSerie, DicomDirImage
241 Dict, DictSet classes :
242 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
243 -remove InitTraversal method.
244 * UPD Test programs + Example programs
246 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
247 * remove useless and never updated keyword \ingroup
248 * Solve pb when structure (list, map, ...) is empty.
249 Thx to Benoit for reporting bug
251 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
252 * Taking into account of 'Transfer Syntax' value
253 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
256 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
258 is no memory access violation
259 * gdcmPython/demo : add python demos using VTK
261 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
262 * FIX 'Dictionnary' is now spelt 'Dictionary'
263 'wether' is now spelt 'whether'
264 'archieve' is now spelt 'archive' ;-)
266 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
267 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
268 related methods, in order not to expose internal mechanisms
271 * REM methods that exposed internal mechanisms :
272 DicomDir::GetDicomDirPatients()
273 DicomDirPatient::GetDicomDirStudies()
274 DicomDirStudy::GetDicomDirSeries()
275 DicomDirSerie::GetDicomDirImages()
276 * UPD Test programs :
280 * UPD Example program
282 * ADD DictSet methods
286 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * Removed the Print/indent/default parameter mess. There is absolutely no
288 reason to have to methods, moreover with the second taking the ostream as
289 *SECOND* parameter. This was clearly a bad hack to get things compile.
291 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
292 * Complete rewrite of the GetMacAddress code. Now the code is *much*
293 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
294 Unfortunately the main code does not work on SunOS, thus provide a specific
295 code for this platform only (and Win32 of course). Since this seems to be
296 working, change CreateUniqueUID to use GetMACAddress instead of the
297 problematic GctestetIPAddress
299 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Unfortunately to be able to test gdcmDirList I had to break the API
301 a little. Now the class is not a std::list anymore but has a member
302 std::vector (more ITK compatible). Allow unit testing on Win32 and
305 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
306 * Update SerieHeader to take into account a Serie Instance UID to properly
309 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
310 * ENH - Comment out Mathieu's (dangerous) Super Hack
311 for dealing with BIGENDIAN processors
312 - Move equivalent stuff to BinEntry::WriteContent
313 When necessary, 16 Bits Pixels are swapped in a small buffer
314 and then written. This avoid allocating a huge buffer, in
315 PixelWriteConvertor, and avoid modifying the Pixel Area.
317 Probabely, the same operation will have to be done when we want
318 to write image with Big Endian Transfert Syntax,
319 and we are working on Little Endian Processor
321 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
324 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
325 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
326 all the dict content.
327 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
329 * Test/TestDict.cxx : add a new test for the dict classes
331 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
333 file. Debug is yanked if compiled with NDEBUG
335 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
336 * src/gdcmDictSet.h : set the default output to the os variable
337 * src/gdcmDictEntry.[h|cxx] : add the Print method
338 * gdcmPython/demo/ : add a new test
340 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
341 * merging of Test/PrintDicomDir and Test/TestDicomDir
342 * removal of now redundant Test/PrintDicomDir
343 * enhancement of Example/PrintDicomDir
345 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * Now, python test might work on systems
347 * Add the PrintDicomDir test
349 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
350 * FIX : First entry following group 0002 was lost for
351 Explicit Big Endian Transfer Syntax files
352 (group and elem not swaped)
354 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
355 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
356 Big Endian Transfer Syntax supposed the group following 0002
357 begins always by element 0000 (element 0000 is *optional*)
358 To avoid further troubles, let's be pessimistic, and use
359 Document::HandleOutOfGroup0002() method
360 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
361 (related pb not yet solved)
363 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
364 * Bug fix for the python part use
365 * Now, PrintHeader.py pass... but outside the ctest use. shit !
367 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
370 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
372 a string and should ask the global TS dict what are the propreties of
375 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
376 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
377 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
378 to swap the Swap Code, at parsing time, when we come out of group 0002
379 and Transfer Syntax is Big Endian
380 We should be able to read now 'true DICOM" Big Endian coded images
381 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
382 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
384 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * Hopefully fix the bug on MacOSX and static global initialization.
386 This is the only -minor- patch I found that both please MacOSX and VS6.
387 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
388 but this would require a lot of change. Another approach would be that Global
389 create those string and GDCM_UNFOUND becomes a pointer to a string (which
390 gdcm::Global would destroy at exit).
392 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
393 * Fix bug on MacOSX with static initialization in a multy threaded
394 environment. static const string in a header file used to be ill
395 initialized provoquing the freeze of any tests. patch should solve this
398 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
399 * According to Benoit's suggestion, and without any objection from anybody
400 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
401 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
402 - method gdcmDicomDirObject::GetEntry() renamed as
403 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
405 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
406 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
407 you debug/warning message just as c++ streams which make them very convinient
408 to use. Once this is stabilize I will change the ostringstrem to be
409 redirected to a file (ofstream).
410 * Properly support C99 extension: __FUNCTION__ which allow us to display
411 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
413 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
414 * Removal of useless and dangerous methods :
415 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
416 GetDocEntryByName, GetEntryByName, GetDictEntryByName
417 * Removal of usless methods :
418 Dict::PrintByName, Dict::GetDictEntryByName
419 * Commenting out of probabely useless methods :
420 Dict::GetDictEntryNames()
421 Dict::GetDictEntryNamesByCategory()
422 DictSet::GetPubDictEntryNames()
423 DictSet::GetPubDictEntryNamesByCategory()
424 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
425 * ENH : Use dicomTS.dic as described in 2004 version
426 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
427 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
428 Add Accessors on VM (Value Multiplicity), and VM related methods
429 * ADD : Add a list of 'Dicom Attribute types', as found in
430 http://medical.nema.org/dicom/2004/04_15PU.PDF
432 * ADD : Add dicomGroupNameAbbreviations.dic
433 should be used to write a method to replace the former
434 Dict::GetDictEntryNamesByCategory()
436 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
438 to read in the file... and only it ! Length is the efective length of the
439 data in the DocEntry structure
441 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
442 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
443 And now use a static function call instead, with a global variable. i
444 This is much closer to the VTK approach. Hopefully should be bulletproof
445 and easier to use...hopefully
447 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
448 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
450 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
453 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
455 ValEntry, BinEntry, SeqEntry creation or replace
457 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
459 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
461 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
462 when specifying the VR
463 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
464 * src/gdcmDocEntry.cxx : amelioration of print
466 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
467 * ADD : Add the method Util::IsCurrentProcessorBigEndian
468 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
469 * ADD Method Document::ComputeGroupLength
470 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
471 in order to allow further VR modification by user
472 * REM : removal of once-called method File::WriteBase
473 integration of its code in formerly one-line method File::Write
475 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
477 replace the different values "??", "Unkn", "Unknown".
478 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
479 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
480 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
481 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
483 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
486 * Set the gdcm::Base class to some Printable classes
488 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
489 * src/gdcmFile.[h|cxx] : add the Print method
490 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
491 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
492 * src/gdcmDocument.h : remove the PrintLevel informations
493 * Example/PrintFile.cxx : use the new gdcm::File::Print
495 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
497 problems when compiling with the python wrapping
499 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
500 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
501 writting in ImplicitVR
503 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
504 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
505 JPEG decompression, especially when dicom frames are split into several
506 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
507 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
509 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmHeader.cxx : change the initialisation of default header.
511 Now, this header is readable by gdm, e-film, DicomWorks
513 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
515 Rename Decompressed to Raw
516 * Use the API changes in gdcm::File.
517 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
520 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
522 each added entry in the header. Replace the 'Planes' field by the 'Number
525 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
527 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
529 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
531 At this time, this image isn't readable by e-film... waiting JPR help to
534 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
536 DocEntry. Now use methods of the Document !
538 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * Test/ShowDicomSeq.cxx : bug fix
541 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
543 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
544 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
545 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
547 * Test/TestCopyRescaleDicom.cxx : remove unused variable
548 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
549 containing found sequences
551 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
554 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
555 Some fields in BinEntry must be copied to not seg fault when making the :
556 gdcm::File *copy = new gdcm::File( copyH );
557 and tests are now made on good variables
559 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
561 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
563 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
564 * Add vtkGdcmWriter example and test
566 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * Test/TestUtil.cxx : reformat the source code
568 * vtk/vtkGdcmReader.cxx : remove and change prints
569 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
571 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
572 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
574 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
576 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
578 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
580 by an eof to prevent all bad read of the file... and in this case, the
583 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * Example/Volume2Dicom.cxx : comment unused variables
585 * Test/PrintDicomDir.cxx : comment unused variables
586 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
587 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
588 method that is redondant with AddEntry.
589 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
592 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * Bug fix due my last commit (compilation under Windows).
594 * Example/Volume2Dicom : bug fix in the file and reformatting source code
595 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
597 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
599 - Remove printf / sprintf
600 - include iostream AFTER gdcm so we don't get warnings
601 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
603 - Also remove tons of include from header files, hopefully this should
604 speeup the compilation time, since it was becoming a dog slow.
605 - Remove gdcm.h as it include way too many files and slow down compilation
606 (plus it is not up to date)
607 - remove 'using namespace std' this is BAD !
609 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * Remove memory leaks on the DicomDir
611 * Remove some useless data in DicomDirObject
612 * Add usefull methods in SQItem, to be complient withe the ElementSet
614 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
617 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
619 future, with convertion)
620 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
621 and ImageDataSize values. Remove the method to get the PixelReadConverter
622 from the output of the class
624 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
625 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
627 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
629 and vtkErrorMacro use.
630 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
632 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
635 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
636 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
637 The string leaves only in the fonction. So when we make a .c_str(), we
638 get the pointeur on the first element, element that will be destroyed
639 immediately after thee instruction.
640 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
641 file has been opened : the test must be made on the content of the
642 pointer and not directly on the pointer !
645 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
647 the python part recompiles
649 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
651 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
652 X session is killed (for my computer... it seems to not be identic on
655 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
657 avoid problems (otherwise, the difference test between the visible image
658 and the reference is incorrect. If the reference is greater than the
659 screen resolution, it's produce errors).
660 Can be used for only one image. Can be used with a visible flag.
661 * vtk/vtkGdcmReader.cxx : remove commented codes.
662 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
663 under windows at compilation
664 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
666 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
668 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
670 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
671 tests on the image size X, Y, Z
673 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
675 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
676 between the class name and the file name
678 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * src/ : fix compilation warnings for the Write method (2 different
680 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
681 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
682 variable... create a static method in gdcm::Document to access to
683 this variable content.
685 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
687 file, to be accessed by other files (like gdcmFile). Remove commented
688 code. Move the change of the header to the gdcmFile, using the
690 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
691 To be sure of that (and simplify calls), the Write of the header now
692 gets a file name and not a file pointer (std::ifstream).
693 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
694 DocEntryArchive. Remove all open of the written file
696 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
699 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
701 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
703 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
704 some corresponding methods. Write correctly the file and check before
706 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
707 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
708 is now on RGB data (as before my last commit
709 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
711 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
713 Add a print information of the type of the entry
714 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
715 It was in the gdcmFile, and all write have been regrouped
716 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
717 Write correctly all dicom files (in decompressed mode only at this time)
718 * Test/ : test on files are now made using Raw data and not color data if
720 * Example/PrintFile.cxx : add more printings
722 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * Amelioration of code, remove some code copy. For the loading of
724 BinEntry (in gdcmDocument), add the test to verify if the file is already
727 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
729 remove a DocEntry in the header (push an empty DocEntry)
730 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
731 lines. Bug fix in the initialization of the PixelConvert and the
733 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
734 use in TestCopyDicom (now this test can run under windows... but fails)
735 * Test/TestCopyDicom.cxx : amelioration of the test :
736 - test the pixels written
737 - add test points to quickly find where is the error
738 - can set a file name input and output in arguments
739 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
740 amelioration of the test output
742 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
743 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
744 all replaced DocEntry's
745 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
746 Now, each needed DocEntry to modify is duplicated, modified and inserted
747 to the header using DocEntryArchive. Thus, after save, we can restore the
748 header initial state.
750 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
753 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
755 correct to copy it. The DictEntry is specified at the DocEntry creation,
756 then, it musn't change in the time.
757 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
758 header correctly. At this time, the change is only made for the first
759 level of the Document. In the future, it might consider sequences.
760 The change is made by replacing a DocEntry by an other that is created
761 outside the class. The old value is kept. When we restore the header
762 status, the added DocEntry is deleted and replaced by the old value.
763 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
764 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
765 set the write type to explicit VR, implicit VR or ACR. Add methods to set
766 the write mode to native, decompressed or RGB (but not used at this time)
768 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
769 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
770 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
772 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
774 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
776 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
777 set because already copied when copying the BinEntry's of the header
778 * Test/TestAllReadCompareDicom.cxx : remove warnings
780 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
782 Two problems appear when doing it :
783 - with the gdcmFile : when the GetImageData method is called, the pixels
784 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
785 data (pixels). And each structure destruct the data when it's
786 destructed. So we have two destructions for the same data. To solve it,
787 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
788 data or not. If it doesn't own data, then they will not destroyed by
790 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
791 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
792 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
793 create a double destruction of the same DocEntry's. So, to solve it,
794 the TagHT is simply cleared and the DicomDir* elements are destroyed.
795 * TODO : add an entry concerning memory leaks in the DicomDir
797 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
799 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
802 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
803 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
804 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
805 after it have been deleted
807 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * FIX: src/* fix the doxygen warnings.
809 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
810 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
811 was erroneously defined with a size of 15 instead of 16. [many thanks
812 to Jean Michel Rouet for pointing out this bug].
814 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
815 1. Finish merging JMR patch for writting DICOM from scratch
816 2. Fix -hopefully- bug with MONOCHROME and space vs null character
817 3. Use const ref when possible
818 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
819 5. A few more comments
820 6. CreateUniqueUID can now be called without parameter"
822 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
823 * ENH: Slightly bigger patch:
824 1. Getting toward full integration of JMR patch for writting dicom from scratch
825 2. Update Test to test part of this patch: CreateUniqueUID
826 3. File was not close properly in gdcmDict
827 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
828 5. Use of const ref instead of copy (speed issue)
829 6. Remove temporary (duplicate) string in TranslateToKey
830 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
831 8. Do not repeat virtual in subclasses
832 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
834 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
835 * Apply first patch toward better string comparison when dealing with broken
836 DICOM files. Essentially the string could be padded with a space instead
837 of a null character as defined by standard
839 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
840 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
841 because never used... and in the same time, that's remove some memory leaks
843 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
844 * src/gdcmFile.cxx : now delete the PixelConvert instance.
845 * In examples and tests : change the type of image data variables from void*
846 to uint8_t*. Remmove all delete on image data variables
848 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
850 Verify the file pointer value before open the file, and if it's not null,
851 a verbose message is generated.
852 Close correctly the file when the file isn't considered dicom-like. The
853 correctly close is a call to CloseFile.
854 When closing the file pointer, test if its not null to close the file.
855 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
856 file. For an uncompressed image, the copied data correspond in the least
857 case to the image size (calculated) or the image size specified in the
858 header. A verbose is generated if these two size mismatch
860 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
862 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
863 break under windows (with msvc6 compilation).
865 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
866 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
867 compiling with MSVC6)
869 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
870 * Bugs fix for the Windows build with VC6
871 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
872 needed (only for projects required VTK). If the VTK is included in all
873 projects, there is conflicts with the jpeg lib of vtk when compiling the
874 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
875 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
876 when compiling the gdcm_wrap.cxx file (created by the compilation of the
878 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
879 (like it's already made for the cout use). Otherwise, conflict with the
882 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
883 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
885 - comments on the DicomDir::Method related usage added.
886 - now that we use the namespace gdcm, a lot of internal classes do
887 NOT need to be wrapped anymore.
888 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
889 DicomDir::Method) new example added.
891 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * Improve string manipulation. I now inforce the notion of 'DicomString'
893 A DicomString can contain as many \0 as they want
894 and it is *always* of even length.
895 We only support odd length for very rare case.
896 And in the near future this should be removed.
898 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 * /binary_write/ gdcm source. Now even on big endian we are writting
900 little endian. This should -heopfully- fix some tests
902 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
903 * Now the dictionary is compiled into gdcm lib. This is a default
904 behavior, thus any dic file specified is picked before failback to
905 the one comiled into lib
907 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * Change internals for gdcmDict. Don't use any 'new' any more.
909 This should definitely solve any leak problem, and we should be
910 as fast as before, as long as don't modify too much the dictionary.
912 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * STYLE: ivars should start with a capital letter.
914 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
915 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
917 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
919 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
920 new 2004 dictionaries added (thanks to JPR).
921 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
922 * CLEANUP_ROUND (15) for gdcmPixelConvert
923 - RLEFrame::NumberFragments is now of type unsigned int
924 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
925 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
928 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Initial work in gathering all transfer syntax accessors. clearly
930 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
931 ivars, but only one transfersyntax (class) ivar with equivalent method on
934 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
935 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
936 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
937 discussed (plus I didn't like having a 2000 lines patch not commited)
939 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
941 * CLEANUP_ROUND (14) for gdcmPixelConvert
942 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
943 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
944 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
946 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
947 anymore and hence avoids storing a copy of PixelConvert::Decompressed
948 into File::Pixel_Data.
950 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
952 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
953 * CLEANUP_ROUND (13) for gdcmPixelConvert
954 Substituted File::ParsePixelData() with PixelConvert::Print() new
956 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
957 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
958 method to those classes.
959 - src/gdcmFile.[cxx|h]:
960 -- Added a ::Print() method.
961 -- PixelConverter is now a reference instead of a member.
962 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
963 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
965 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
967 collaboration diagram and inheritance diagram should be generated with
969 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
970 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
971 pointlessly wrapped (see
972 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
973 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
974 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
975 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
976 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
977 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
978 -- File::Initialise: PixelConverter setup moved away to
979 PixelConverter::GrabInformationsFromHeader()
980 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
981 interpretation moved away to PixelConverter::BuildRGBImage()
983 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
985 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
987 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
989 displayed on Win32 when a brutal abort() occurs (because of uncatched
990 exception). See TODO new entry of this commit for more on this.
991 * TODO added new entry.
992 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
993 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
994 - HandleColor is no longer called from gdcmFile.cxx
995 - gdcmPixelConvert.cxx clean up on method arguments and internal
996 variable names for semantical coherence.
998 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
999 * Finished lossless transition, not only do we now read all lossless jpeg
1000 images, without the need of the Cornwell lib, but we do read them properly now
1001 * To reduce code (well to avoid code duplication), I defined a common place
1002 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1003 redefine symbols. This is not perfect but this the best solution I found for a
1004 compilation time jpeg option.
1006 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1007 * Update jpeg ijg lib to support lossless jpeg implementation
1008 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1010 * Also added a special copyright for dcmtk since we use their bugfixes.
1013 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1015 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1016 matters, as stated in warning note at beginning of %include section).
1017 * src/gdcmDicomDir*.[cxx|h]: coding style
1018 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1019 * src/gdcmJpeg8.cxx: doxygen fix.
1020 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1021 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1022 from File:: to PixelConvert::.
1024 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1026 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1027 - more code moved away from File:: to PixelConvert::
1028 - fat setup of PixelConverter set in place in File::Initialise.
1030 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1031 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1032 namespace at the file system level. So now you should convert your examples
1034 gdcmHeader -> gdcm::Header
1035 It would be nice if people keep in mind to no open the namespace, since it
1036 allows compilation on broken plateform which were defining common symbol in
1037 the standart namespace (like LP, Unknown ...)
1039 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1041 The JPEG fragments are now parsed at the same stage than the RLE
1042 information. All code related to JPEG is now in gdcmPixelConvert:
1043 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1044 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1045 export a gdcmFile:: method. Those are simply global functions
1046 (for the time being this is better than having them attach to
1047 either gdcmFile:: or gdcmPixelConvert::).
1048 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1049 and stores the result in a gdcmJPEGFragmentsInfo.
1050 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1051 code (among other stuff) moved away from gdcmFile:; to
1054 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1056 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1057 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1058 clean up of RLE related code.
1059 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1060 - src/gdcmRLE.cxx removed
1061 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1062 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1063 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1064 * CLEANUP_ROUND (9) for gdcmPixelConvert
1065 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1066 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1067 away from gdcmFile:: to gdcmPixelConvert::.
1069 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1071 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1072 This is because Parse7Fe0 used to parse the pixels to compute the
1073 length. This task was passed over to FindDocEntryLengthOB() a long
1074 time ago, EXCEPT I had forgotten the OW case...
1075 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1076 we just recylce the code for parsing RLE fragments and computing
1078 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1079 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1080 with the retired Parse7Fe0().
1081 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1082 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1084 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1086 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1087 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1088 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1089 * CLEANUP_ROUND (4) for gdcmPixelConvert
1090 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1091 to return an unused length.
1093 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1094 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1095 this should be cleanner from the plane view. The iostream are erally a pain
1096 to use to do simple stuff.
1098 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1099 * Redo the compilation of the ijg jpeg library. Now only one source is
1100 necesseray. No need to rename file by hand what so ever. CMake handle the
1101 copying of the file within different directory, configure header file to
1102 modify some symbol. The only addition made to ijg wasd a mangle table so
1103 that symbol are different whether we are within 8bits or 12bits.
1105 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * Added documentation of vtkgdcmReader on Website:
1107 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1108 with it's binary name).
1109 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1110 the Website to be more complete.
1111 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1112 doxygenated documentation.
1113 - Doc/DoxyVtkGdcmReaderExamples.txt added
1114 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1115 DoxyVtkGdmReaderExamples.html )
1116 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1117 * CLEANUP_ROUND (3) for gdcmPixelConvert
1118 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1120 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * CLEANUP_ROUND (2) for gdcmPixelConvert
1122 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1124 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * CLEANUP_ROUND for gdcmPixelConvert:
1126 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1127 - src/gdcmPixelStuff[h|cxx] removed
1128 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1129 - src/CMakeLists.txt changed accordingly
1130 * GDCMHOME clean up:
1131 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1132 gdcmVersion.py moved to newly created ATTIC related
1133 gdcmPython/SetupOldies/ directory.
1134 * Autotools clean up:
1135 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1136 - autogen.sh configure.in acinclude.m4 python.m4 removed
1138 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1140 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1141 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1143 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * TODO updated with Mathieu suggestions. I proposed a template for
1145 describing TODO entries and used it for new entries.
1146 * Added Doc/Website/CodingStyle.html, Developpers.html,
1147 DeveloppersPython.html, GdcmDataCvs.html and
1148 DownloadVersion0_1.html, DownloadVersion0_3.html.
1149 * Some Doc/*.txt Doxygen files (which do not really concern the
1150 documentation itself, but the website) moved to html and
1151 placed in directory Doc/Website:
1152 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1153 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1154 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1155 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1156 * CMakeLists.txt changed accordingly.
1157 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1158 DeveloppersPython.html
1159 * INSTALL nows refers to Doc/Website/Installation.html
1161 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * Added Doc/Website directory, that contains a first raw version
1165 2004-09-23 Jean-Pierre Roux
1166 * FIX In order not to be poluted any longer by casting problems,
1167 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1168 we can now delete[] it safely
1169 * VoidArea is now called BinArea (less confusing name),
1170 and all the methods called ...VoidArea... are now ... BinArea...
1171 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1173 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1175 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1176 up to the destructor of gdcmElementSet to clean up TagHt and it's
1179 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1181 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1183 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * ENH: added some utility method that builds a flat dictionary
1185 holding all the Dicom entries contained in the recursive structure
1186 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1187 an example of usage.
1188 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1189 BuildFlatHashTable() that build a flat dictionary.
1190 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1191 gdcmDocument is now a friend of gdcmElementSet.
1192 - src/gdcmElementSet.cxx: clean up.
1193 - Example/FlatHashTablePrint.cxx added.
1194 - Example/CmakeLists.txt changed accordingly
1196 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1198 moved away from gdcmDocEntrySet (since this class is an abstract class
1199 acting like an interface). SQDepthLevel and BaseTagKey are now
1201 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1202 and associated accessors. Doxygenation of the class.
1203 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1205 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1206 Use SQDepthLevel accessor instead. ::Print() adapted.
1207 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1208 - src/gdcmDocument.cxx changed accordingly.
1210 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1212 - The following is the doxygen comment of the typedef declaration
1213 of gdcmTagKey in src/gdcmCommon.h:
1214 gdcmTagKey is made to old an "universal" (as in URL, Universal
1215 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1216 A dicom tag always has a group and an element, but a set of tags
1217 embeded in various (optionally nested) sequences and sharing
1218 the same group and element all share the same (group, element)
1219 "identifier". Hence the (group, element) cannot be used as an
1220 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1221 In order to construct a proper tag identifier (i.e. a key) we
1222 consider the following definition of a TagKey:
1223 - let Group, Element be the string representation of the
1224 group and element dicom tag members,
1225 - let ItemNumber be the string representation of the integer
1226 index of the considered item number of a sequence,
1227 Let the key of a tag embeded in a sequence, noted SeqTag, be
1229 /ItemNumber#Group|Element
1230 where "/", "#" and "|" are characters acting as separators.
1231 Then the general form of a gdcmTagKey is given by:
1232 Group|Element<SeqTag>
1233 where <SeqTag> means NO or many instances of SeqTag.
1234 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1237 but the gdcmTagKey of a tag "embeded" is the first item of
1238 a sequence, itself nested in the third item of a sequence is the
1240 0004|1220/2#0008|0082/0#0008|0090
1241 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1242 order to hold the new sequence compatible key. Previously, the
1243 GetKey() method would look in the underlying gdcmDictEntry.
1244 - src/gdcmDocEntry.cxx:
1245 -- constructor now copies the underlying DictEntry key, in the local
1247 -- ::Print: displays the member Key, instead of the (group, element).
1248 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1249 - src/gdcmDocEntrySet.h:xi
1250 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1251 -- now has a new BaseTagKey member.
1253 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1254 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1256 This poses the problem with the semantics of the following lines
1257 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1258 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1259 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1260 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1261 to the long FIXME note for what the problem is. Nevertheless in
1262 order to get things working the dicom dictionary was altered !
1263 Please fix things urgently...
1264 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1265 information), see above note on moving the member VoidArea. Nevertheless
1266 the following entries previously correctly set as US are now inproperly
1268 0028 1201 OW IMG Red Palette Color Lookup Table Data
1269 0028 1202 OW IMG Green Palette Color Lookup Table Data
1270 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1271 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1272 of gdcmDocEntry moved to gdcmSeqEntry.
1273 * src/gdcmSeqEntry.cxx: STYLE.
1275 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1276 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1278 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * gdcmPython/testSuite.py: all the test suite in python is now moved
1280 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1281 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1282 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1284 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1285 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1286 to avoid inclusion recursion until STL is reached.
1287 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1288 mecanism. errno.h is not included in gdcm anymore.
1289 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1290 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1292 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1293 gdcmData/TestAllEntryVerifyReference.txt
1294 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1295 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1296 exception_on_error parameter.
1297 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1298 - vtk/vtkGdcmReader.cxx changed accordingly,
1299 - Example/*.cxx and Test/*.cxx changed accordingly.
1301 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1303 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1304 enable_sequences removed from gdcmHeader constructor and dependencies.
1305 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1306 * gdcmPython/demo/PrintHeader.py: dummy fix.
1307 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1308 skip_shadow removed from gdcmHeader constructor and dependencies.
1309 * Example/*.cxx and Test/*.cxx changed accordingly.
1311 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1313 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1315 2004-07-21 Jean-Pierre Roux
1316 * FIX Now, Parsing and Printing a DICOMDIR do work!
1317 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1319 2004-07-20 Jean-Pierre Roux
1320 * FIX Some brain damaged headers have Zero-Lenght fields
1321 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1323 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1324 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1325 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1326 variable (instance of gdcmDebug) by a definition macro, and the instance
1327 is now in static in the gdcmDebug class
1328 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1329 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1331 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * WARNING: ctest now depends more tightly on gdcmData. You should
1333 check out gdcmData properly for things to run smoothly...
1334 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1335 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1336 we need the pixels not be loaded in order to use the ValEntry
1337 that displays position and size).
1338 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1339 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1340 be deprecated. If you have any doubts about the advantages of a
1341 modern scripting language (read Python) versus grass root C++ (i.e.
1342 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1343 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1344 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1345 Anyhow, consider documenting the gdcmData images in
1346 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1348 * Test/CMakeLists.txt:
1349 - now uses TestAllEntryVerify.cxx
1350 - specific comments on oldACR00001.ima (now renamed in gdcmData
1351 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1352 gdcmData/TestAllEntryVerifyReference.txt
1355 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * src/*.[h|cxx] : typedef clean up
1357 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1358 - TagKey renamed to gdcmTagKey (for external usage)
1359 - VRKey renamed to gdcmVRKey (for external usage)
1360 - removal of typedef duplication.
1361 - Removed all unecessary inline keyword from class inline definitions.
1362 - Some method|function(void) declarations replaced with method|function().
1363 * src/jpeg/libijg12/jdhuff12.c:
1364 - printf polluting ctest removed.
1365 - TAB removal for comminting
1367 - TestAllReadCompareDicom.cxx: added a test that compares all the
1368 images in gdcmDataImages.h with corresponding images in
1369 gdcmData/BaselineDicom/. When baseline images are not present
1370 this test creates them.
1371 Note: we need to validate each reference image, but before that
1372 I'd like to rename them with a more explicit name...
1373 - CMakeLists.txt: changed accordingly.
1374 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1375 including each header needed).
1377 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1379 test suite to the Example directory. Are concerned:
1384 - TestWriteSimple.cxx
1385 * Test/CMakeLists.txt: added some comments on reasons for black listing
1386 image gdcmData/oldACR00001.ima
1388 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1389 * Test/CmakeList.txt: removed the following from black list (to be coherent
1390 with removal from gdcmData):
1391 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1392 - gdcm-MR-PHILIPS-16.dcm
1394 Added the following because after last cvs update, they cause
1395 ctest -R TestReadWriteReadCompare
1397 - gdcm-MR-SIEMENS-16-1.acr
1399 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1400 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1401 new comments in this file) we temporarily (sigh) move to a weaker
1403 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1404 we don't need to black list the following images anymore:
1405 - 8BitsUncompressedColor.dcm
1407 - US-PAL-8-10x-echo.dcm
1408 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1409 fixes and the beautified code ;-)
1410 This fixes the bug introduced in version 1.42 (when beautifying)
1411 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1412 Note: ctest was blind to this bug (this means we need to still
1413 improve the test suite). The bug could be detected by using
1414 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1416 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1417 and by displaying the (garbage) produced file temp.XDCM...
1419 2004-06-29 Jean-Pierre Roux
1420 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1421 - replace by uggly but working old code :-(
1422 A lot of things should be OK again.
1423 It's really urgent to have a test suite that *tests*,
1424 to prevent Frog's beautifying sessions to break all the stuff
1425 (twice, withing a fortnigh ...)
1427 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1428 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1429 redundancy) to added Test/TestReadWriteReadCompare.cxx
1430 * Test/CmakeList.txt: because the compare test of
1431 Test/TestReadWriteReadCompare.cxx fails, the following images are
1432 black listed: - 8BitsUncompressedColor.dcm
1434 - US-PAL-8-10x-echo.dcm
1435 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1436 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1437 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1438 and ad-hoc kludge. This kludge is now removed, and on encountering
1439 such an image (OB field brain damaged) we set errno. Then in
1440 ::FindDocLength() we "fix" the length as being ALL what remains
1441 in the file (until EOF). We then proceed, hoping for the best...
1442 This fixes a SegFault in ShowDicom when trying to write such an
1444 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1445 (because TestWriteRead breaks on it, after a non conformal commit?).
1446 ctest now runs properly, except for MakeDicomDir (which was always
1447 broken) and the Python related stuff (still not fixed).
1449 2004-06-24 Jean-Pierre Roux
1450 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1451 FIX : Test/TestReadWrite now iterates on all the file names
1452 (instead of infinite loop)
1453 ENH : Test/TestWriteRead now iterates on all the file names
1455 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1458 2004-06-24 Jean-Pierre Roux
1459 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1460 when SamplesPerPixel =3
1461 - now Write is no longer confused by
1462 'BitsAllocated = 12" and 'BitsStored=12"
1463 - "UN" value representation Elements are now written correctly
1464 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1465 ENH : - now gdcmHeader has its own Write methods
1466 (in order to split the job that has not to be done
1469 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1471 loop on the same image until memory went out.
1472 Note: this means we still have gobs of memory loss in PrintDocument
1473 * src/gdcmDocument.cxx: fixes problem on parsing on file
1474 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1476 2004-06-24 Jean-Pierre Roux
1477 FIX : Write - All the Sequences and Sequence Item are now written
1478 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1479 is added a the end, when necessary.
1480 - A lot of brain-damaged images, that were read correctly are
1481 now written correctly
1482 - length compatible BinEntry are now loaded correctly
1483 (even for odd groups)
1484 Note : only Explicit Value Representation was checked.
1485 (question : is implicit VR really necessary for gdcm ?)
1487 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * DEVELOPPER: added a proposition of coding style.
1489 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1492 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1493 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1494 Use the gdcmDocEntry::Print() and Write() instead.
1495 * src/gdcmDocument.cxx: bug fix.
1497 2004-06-22 Jean-Pierre Roux
1498 FIX : gdcmDocument.cxx
1499 - Now we do recognize the JpegLossLess format (there was a misstyping in
1500 code 'beautyfication' :-(
1501 - Now we automaticaticaly load the Luts, if any
1503 2004-06-22 Jean-Pierre Roux
1504 In order : to write Sequences, whatever their imbrication level,
1505 : to allow user to create his own Sequences
1506 a lot of modif where necessary (adding, moving, or virtualising methods)
1508 WARNING : save your own sources *before* cvs up !
1511 ADD virtual void Write(FILE *fp, FileType filetype);
1514 ADD virtual void Write(FILE *fp, FileType filetype);
1515 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1518 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1519 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1520 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1521 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1522 ADD std::string GetEntryByName(TagName name);
1523 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1525 std::string vr = "unkn",
1526 std::string fourth = "unkn",
1527 std::string name = "unkn");
1528 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1529 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1530 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1531 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1532 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1533 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1534 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1535 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1538 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1539 ADD virtual std::string GetEntryByName (TagName tagName);
1540 ADD virtual std::string GetEntryVRByName (TagName tagName);
1541 REM virtual bool Write(FILE *, FileType);
1542 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1543 FILE *_fp, FileType type);
1544 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1545 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1546 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1547 REM virtual std::string GetEntryByName (std::string tagName);
1548 REM virtual std::string GetEntryVRByName (std::string tagName);
1549 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1550 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1551 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1553 std::string vr = "unkn",
1554 std::string fourth = "unkn",
1555 std::string name = "unkn");
1556 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1557 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1558 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1559 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1562 ADD virtual void Write(FILE *fp, FileType filetype);
1565 ADD virtual void Write(FILE *fp,FileType filetype);
1568 ADD virtual void Write(FILE *fp, FileType filetype);
1569 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1570 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1571 REM std::string GetEntryByName(TagName name);
1574 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1576 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1578 The default constructor invoked by the line
1579 gdcmHeader *f1 = new gdcmHeader( header );
1580 was gdcmHeader::gdcmHeader(bool) instead of the expected
1581 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1582 Hence the parsing wasn't executed... See also below.
1583 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1584 as explicit constructor didn't do the trick to fix the above problem.
1585 Could anyone explain why ?
1586 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1587 properly calls gdcmValEntry::Print() (that was weed out from
1588 code related to gdcmBinEntry).
1590 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1591 * In order to fix memory leaks:
1592 - Test/TestWriteSimple.cxx: added cleaning of free store through
1594 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1595 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1596 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1597 (through the call to ::AddDicomDirMeta()) or the destructor
1598 would crash when deleting uninitialized ::metaElems].
1599 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1600 - src/gdcmDocument.cxx:
1601 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1602 from dynamic stores.
1603 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1604 was causing memory leaks.
1605 - src/gdcmSQItem.cxx:
1606 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1607 cleanly handled with polymophism: sorry but my milage is low).
1608 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1609 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1610 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1611 This avoids SegFaulting.
1612 - src/gdcmSQItem.h: coding style.
1614 - Test/TestWriteSimple still severely sucks. The output image content
1615 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1616 damaged when displayed with vtkgdcmViewer.
1617 - on memory leaks: TestWriteSimple leaks really less (see entry
1618 of 2004-06-18 in Changelog file for the call to valgrind).
1619 - on segfaults: ctest now passes all the tests but one (no more
1621 * Erroneous leading white fix:
1622 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1623 white[s] (as opposed to from >> xxx, that removes it [them].
1624 - src/gdcmTS.cxx: ditto.
1625 - gdcmPython/testSuite.py: dirty related kludge removed.
1626 * src/*: remaining references to gdcmParser removed.
1627 * src/*[cxx|h]: added copy[way]left header.
1630 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * In order to fix writing of dicom files:
1632 - Test/TestWriteSimple.cxx: a simpler example of writing.
1633 - Test/CMakeLists.txt changed accordingly.
1634 - src/gdcmDocument.cxx:
1635 -- The destructor now recursilvely removes potential sequences.
1636 -- Bug fix in ::IsJPEG2000()
1637 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1638 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1640 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1641 to only declared) and build on top of
1642 ::GetDocEntryByNumber(guint16, guint16).
1643 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1644 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1645 for usage in destructor and treatement of promotion in
1646 ::ReplaceOrCreateByNumber().
1647 - src/gdcmSQItem.cxx: destructor should better handle his job.
1648 Test/TestWriteSimple now runs (or at least it DOES something).
1649 * We can now start hutting memory links. A good starting point is:
1650 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1651 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1652 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1654 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1655 * Valgrind note: after Mathieu Malaterre teached me how to read
1656 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1658 Using gcc, you can force the STL to use malloc and to free memory as
1659 soon as possible by globally disabling memory caching.
1660 With 3.2.2 and later, you should export the environment variable
1661 GLIBCPP_FORCE_NEW before running your program.
1662 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1663 simply vanish (it is still not clear to me, whether this means that
1664 STL std::string leaks or if valgrind believes it leaks...).
1665 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1666 running bin/gdcmTests makeDicomDir):
1667 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1668 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1670 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1671 SegFaulting (I drowned in DicomDir related code when trying to
1672 understand why the list is empty...).
1673 * src/gdcmDocument.h: first BSD license header try.
1674 * Doc/License.txt added.
1676 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1677 * src/gdcmDocument.[h|cxx]:
1678 - Clean up of the Transfer related predicates. They are now all based
1679 on new method isGivenTransferSyntax, that (should) handle properly
1680 the padding problem.
1681 - general clean up, simplification, and coding style.
1682 - Specific clean up of Parse7FE0() (umproperly named actually).
1683 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1685 2004-06-14 Jean-Pierre Roux
1687 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1688 - fix the display of SQItem ordinal number
1689 - add the GetSQItemByOrdinalNumber method
1690 - remove some useless never written private methods
1692 2004-06-14 Jean-Pierre Roux
1694 - adding a constructor taking a gdcmDocEntry as an input param
1695 - ReplaceOrCreateByNumber now returns :
1696 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1697 a gdcmValEntry * if a string value is passed as a param
1699 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1700 according to the param type (no longer sets a gdcmDocEntry)
1701 - GetValEntryByNumber, GetBinEntryByNumber added
1702 - NewValEntryByNumber and NewBinEntryByNumber added
1704 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1706 - GetSQItemNumber and SetSQItemNumber added, to provide
1707 a (relative) Item identier inside a given Sequence
1708 \warning : some pb remaining around this number
1710 - AddEntry now takes the Item Number as a param
1712 - adding a constructor taking a gdcmDocEntry as an input param
1714 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1715 * Memory leak hunt with the following command:
1716 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1717 --show-reachable=yes gdcmTests PrintDocument
1718 It looks like many (all?) leaks are due to the STL (or a bad usage
1719 of the STL. The lines producing the leaks now have a comment with
1720 a "MEMORY LEAK" tag: you can retrieve them with
1721 grep "MEMORY LEAK" src/*
1722 Here are two typical examples which I can't help fixing:
1727 char * test = "babo";
1728 name = test; //// <--- valgrind detects 960 bytes lost in
1729 //// call to std::string::operator=(char const*)
1730 name.clear(); //// Doesn't help !
1738 std::cout << "Type a bunch of characters followed by RETURN: ";
1739 getline(std::cin, line); //// <--- valgrind dectects a loss
1740 //// of 1320 bytes in call to
1741 /// std::basic_istream<>& std::getline<>
1747 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1748 * src/gdcmHeader.[cxx|h]:
1749 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1750 and related, moved away to gdcmDocument.
1751 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1752 the corresponding protected accessors of inherited class
1753 gdcmDocument, removed ! As a consequence gdcmFile had to be
1754 declared friend of class gdcmDocument (see below).
1755 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1756 - Clean up of undefined or unused methods.
1757 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1758 account the changes to gdcmHeader.h).
1759 * src/gdcmDocument.h:
1760 - gdcmFile is now a friend class (in order to take into account the
1761 changes to gdcmHeader.h).
1762 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1763 (see changes to gdcmHeader.h).
1764 - Accessors (reading on the form GetEntry*) are now public.
1765 - Clean up of undefined or unused methods.
1766 * src/gdcmDocument.cxx:
1767 - adaptation to changes to gdcmDocument.h
1768 - ::OpenFile now writes a verbose message when file cannot be opened.
1769 - some std::string properly set to VRKey
1770 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1771 references to gdcmDocument.
1772 * Test/TestFindTags.cxx: changed accordingly to above changes.
1773 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1774 cvs repository gdcmData.
1776 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1778 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1779 conflicts with gdcmValEntry::voidArea.
1780 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1781 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1782 Value representation between StringRepresentable and BinaryRepresentable.
1783 * src/gdcmDocument.cxx:
1784 - method ParseDES: proper indentation restored and usage of
1785 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1786 - method LoadDocEntry: the fingerprint left in the SetValue() of
1787 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1788 removed. Reverting to previous code segment with the proper
1789 dynamic_cast< gdcmValEntry* >.
1790 Note: this was (partially) breaking the python test suite
1791 (gdcmPython/testSuite.py) that made usage of the above
1792 fingerprint to check presence of "Pixel Data".
1793 * src/gdcmDocEntry.h: coding style.
1794 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1795 now taken into account.
1796 * gdcmPython/gdcm.i: adaptation to the new internal representation
1797 of gdcm (exit gdcmParser, hello gdcmDocument).
1798 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1800 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1801 anymore, but instead prints the loaded Python dictionary.
1802 * .... alas, the python testSuite is still broken.
1804 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1805 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1807 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1808 * src/gdcmUtil.h : export methods
1810 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1811 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1813 * Initial addition of automatic python testing
1814 * Initial addition of automatic image comparison
1816 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1817 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1818 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1820 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1822 * Test/ShowDicom.cxx : bug fix for msvc compilation
1823 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1825 2004-05-04 Jean-Pierre Roux
1826 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1827 new concepts (and new classes) :
1828 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1829 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1830 - Sequence Doc Entries (gdcmSeqEntries)
1831 a Sequence is composed of Items.
1832 Each item is a set of Doc Entries (this is recursive)
1833 The non uniqueness of the 'Dicom tag' is due to this recursivity
1834 (never taken into account)
1835 Our unability to add a new 'entry' in the header
1836 at the proper location (neither in the H-Table (map or multimap),
1837 nor in the Chained List is also due to this recursivity.
1838 Don't try, right now, to use/modify/compile these new sources :
1839 nothing is finished.
1840 We just commit all the stuff, 'as is', in order not to loose it.
1842 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1843 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1845 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1846 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1847 file prefix (SetFilePrefix)
1849 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * Add a new test: ShowDicom, for now this is just the c++ version of
1851 checkRead.sh, later it will be able to compare the image read against a
1853 * Replace the DEBUG on the stack with a global entry in cmake interface:
1854 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1856 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * Add an example subdir, with a real example on how to read + write a
1860 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1862 * Doc/CMakeLists.txt: the main page is now properly differentiated
1863 between the developper and user version.
1864 * Doc/doxygen.config.in: dropped search related obsolete flags
1865 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1867 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * DEVELOPPER: added some helpfull comments for compile/test/install
1871 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1873 src directory, now generated in the build dir.
1874 2. Tests as mentionned smarter
1876 4. Add a new method in gdcmDict that return the PubDict by name
1877 this is interesting for 3rd party lib like ITK,
1878 where we could set the institution name / patient name...
1880 * ENH: 1. Now the test suite is working for real
1881 2. All binaries are now output in the gdcm-bin directory
1882 (this was not true before)
1884 2004-04-28 Jean-Pierre Roux
1885 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1886 SeQuence indented printing of Dicom Header.
1887 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1888 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1889 Computation of SQDepthLevel is now part of gdcmHeader constructor
1890 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1891 tree-like structure of a Dicom Header.
1892 * FIX Test code cleaning
1894 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: Adding automatic testing
1896 1. Need a DartConfig.cmake to submit to public
1897 2. Add a test driver gdcmTest.cxx
1898 3. gdcmTestMain, an helper for the main test driver gdcmTest
1899 4. Files in Test don't have a main anymore, this becomes interesting
1900 when we add more and more tests, thus dsw don't have to load
1902 * ENH: Adding a GDCM_DATA_ROOT for testing
1903 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1904 one file instead of seven + some small cleanup
1906 2004-04-22 Jean-Pierre Roux
1907 * ENH Minor changes to the Print() methods.
1908 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1909 Header printing. Example given with :
1910 > PrintHeader fileName 2 new
1911 (SQ based tree-like structure still to be done for the Header ...)
1913 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1915 1. I have added some unsigned where needed
1916 2. Some function parameter not used -> (void)
1917 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1918 4. g++ don't like character '\' in comment
1919 5. #define jpeg_create_decompress jCreaDecompress
1920 this really need to be fixed
1921 6. virtualize destructor of gdcmObject ... leakage
1922 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1923 this also really need to be fixed
1924 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1925 remove compression file
1926 (as we only do decompression, right ?)
1927 * ENH: Change malloc/calloc/free with c++ equivalent
1929 2004-04-21 Jean-Pierre Roux
1930 * FIX gdcmHeaderHelper::GetXSpacing
1931 when a single value is found (bug ?), xpacing is now
1932 defaulted to yspacing
1934 2004-04-19 Jean-Pierre Roux
1935 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1936 * ENH add parameters :
1937 bool exception_on_error = false,
1938 bool enable_sequences = false,
1939 bool ignore_shadow = false
1940 to the gdcmFile constructors to be full gdcmParser compliant
1941 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1942 to allow reading of PAPYRUS 3.0 files
1944 2004-04-06 Jean-Pierre Roux
1945 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1947 2004-04-02 Jean-Pierre Roux
1948 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1949 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1950 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1952 2004-03-30 Jean-Pierre Roux
1953 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1954 for ACR file, written out as DICOM files (hope so...)
1956 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1957 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1958 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1959 moved to base class gdcmParser and only the specialisation is kept
1961 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1962 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1963 already does the job.
1964 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1965 (to be consistent with gdcmParser::WriteEntries).
1967 2004-03-30 Benoit Regrain
1968 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1969 upate of the object's instance. It's passed to 2 in the unfavorable
1970 case : one in the ExecuteInformation, one in the ExecuteData
1972 2004-03-29 Jean-Pierre Roux
1973 * ENH : Check on file type to be written moved
1974 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1975 * FIX : gdcmObject::ResetBoundaries now stops properly
1976 when end-of-list is reached
1977 : gdcmVersion modified (as Benoit Regrain asked)
1979 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1980 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1981 * src/gdcmUtil.cxx: added forgotten iostream include.
1982 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1983 equivalent to ExplicitVR in existing code).
1985 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1987 now contains all the gdcmGlobal related code.
1988 * minor coding style and doxygenation changes.
1990 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1991 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1992 now contains all the Debug related code.
1993 * minor clean-up of includes in src/*.cxx
1994 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1995 CreateCleanString) removed.
1996 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1997 * Doc/DoxyMainPageUser.txt added.
1998 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1999 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2000 src/gdcmDirList.cxx)
2002 2004-03-24 Jean-Pierre Roux
2003 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2005 2004-03-23 Jean-Pierre Roux
2006 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2007 big endian made volumes
2008 * ENH Now gdcmParser constructor and destructor are protected to forbid
2009 end user to instanciate class gdcmParser
2010 (only gdcmHeader and gdcmDicomDir are meaningfull)
2012 2004-03-22 Benoit Regrain
2013 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2014 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2015 gdcmSerie to gdcmDicomDirSerie
2017 2004-03-19 Jean-Pierre Roux
2018 * ENH Now the tree-like structure describing a DICOMDIR comming from
2019 an already existing DICOMDIR file is consistent with
2020 the home-made tree-like structure build ex-nihilo
2021 or build from the files held (recursively) in a Directory
2022 functions gdcmDicomDir::CheckBoundaries()
2023 gdcmObject::SetBoundaries() added
2025 2004-03-17 Jean-Pierre Roux
2026 * REM (Eric Boix bug) : removal of meaningless
2027 gdcmDicomDirImage::NewImage function.
2028 * FIX now file names and directory name are written properly in the
2030 * FIX now gdcmDicomDir constructor may be call without any trick
2033 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2035 of gdcmDicomDirImage::NewImage as empty function.
2037 2004-02-28 Jean-Pierre Roux
2038 * ENH add gdcmDicomDir:NewPatient
2039 add gdcmDicomDirPatient:NewStudy
2040 add gdcmDicomDirStudy:NewSerie
2041 add gdcmDicomDirSerie:NewImage
2042 to allow making gdcDicomDir object.
2043 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2044 (as opposite to the gdcmHeader chained list)
2046 2004-02-11 Benoit Regrain
2047 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2048 when using from python
2050 2004-02-10 Benoit Regrain
2051 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2052 * FIX : in gdcmDicomDir when the directory is empty
2053 * ENH : add callback and methods to get the progression of dicomDir
2056 2004-02-06 Jean-Pierre Roux
2057 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2058 - GDCM_META added to gdcmDicomDirType
2059 - class gdcmMeta created
2060 * ENH : - A brief summary is now displayed at the beginning of
2061 'testDicomDir' to help disaster magnitude estimation
2062 * REM : Now useless Test/explDICOMDIR.cxx
2064 2004-02-05 Benoit Regrain
2065 * ENH : add methods in gdcmObject to get the hash table or the list of
2067 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2068 * FIX : wrapping python for TagHeaderEntryHT
2070 2004-02-04 Benoit Regrain
2071 * FIX : even length for some strings when writting the dicom dir
2072 * FIX : sort the images in the dicom dir
2073 * FIX : Bug fix for python use of dicom dir
2074 * ADD : a python demo
2076 2004-02-04 Jean-Pierre Roux
2077 * FIX : Final solution (?) for icone embedded images
2078 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2079 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2080 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2081 gdcmData/gdcm-MR-SIEMENS-16.acr1
2082 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2083 to make full checking easier
2085 2004-02-04 Benoit Regrain
2086 * FIX : WriteEntries : coding style & logic in parameters
2087 * FIX : Set the elements to create the DicomDir in a dictionary file
2089 2004-02-03 Benoit Regrain
2090 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2091 * gdcmDicomDir : add the load of directory
2092 * Bug fix and print add-on
2094 2004-02-03 Jean-Pierre Roux
2095 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2096 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2097 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2098 * FIX gdcmParser.cxx : 'group length' elements are now considered
2099 as integers, even for shadow groups, when file is Implicit VR
2101 2004-02-02 Jean-Pierre Roux
2102 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2104 of the last synonym :-(
2105 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2107 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2108 * FIX taking into account the possible 7fe0,0010 multiplicity
2109 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2110 to allow removal of references to 7fe0,0010, to deal with
2111 ACR-NEMA images, when 0028,0200 is meaningfull
2113 2004-01-31 Jean-Pierre Roux
2114 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2115 no longer writes 'Un' on disk
2116 * FIX SQ elements with actual length are now dealt with corectly
2117 * FIX gdcmFile::WriteBase make the difference, for color images, between
2118 the length (for Palette expanded images)
2119 and Raw Length (non expanded image + Palette)
2120 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2121 (that broke Write). Replaced by UL.
2122 Aware user will reload the field if he
2123 thinks it's necesssary
2125 2004-01-30 Jean-Pierre Roux
2126 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2127 when 'dirty Acr' is found, to be compliant with the new
2128 IsReadable() methods.
2130 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2131 (no DOUBLE images in kosher DICOM,
2132 but so usefull for people that miss them ;-)
2134 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2135 DICOMDIR related utilities (not checked as Windoze compliant)
2137 2004-01-28 Jean-Pierre Roux
2138 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2140 2004-01-27 Jean-Pierre Roux
2141 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2142 to allow skipping the shadow elements, to save memory space.
2143 The TRUE value for this param has to be used
2144 with a FALSE value for the 'enable_sequence' param.
2145 ('public elements' may be embedded in 'shadow Sequences')
2146 * gdcmHeader methods now deal with 'embedded icones images' in the header
2147 (even when an 'icone image sequence' is announced by the
2148 element (0x0088,0x0200), but there is NO icone at all ...
2150 * gdcmHeader sometimes Image Location value doesn't follow
2151 the supposed processor endianity (see gdcmData/cr172241.dcm).
2154 * gdcmHeader add the method
2155 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2156 to get *all* the Header Entries with the same tag.
2157 GetHeaderEntrySameName is probabely *useless*
2158 (no meaning : Name is *not* an identifier within the Dictionary)
2160 2004-01-26 Benoit Regrain
2161 * Bug fix in the print of hexadecimal representations. Remove long fields
2162 in the print and add a third level of print to print them
2164 2004-01-23 Benoit Regrain
2165 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2166 * Bug fix on test suite after remove the strip made on not string fields
2167 * Split the IsReadable method between gdcmParser which test that the file
2168 is dicom and gdcmHeader which test that it's an image file
2170 2004-01-22 Benoit Regrain
2171 * DicomDir : clean code, add methods, set variables in protected or private
2172 * gdcmUtil : bug fix for the clean string method
2174 2004-01-19 Benoit Regrain
2175 * Add the use of shadow dictionaries
2176 * bug fix and coding style
2178 2004-01-19 Benoit Regrain
2179 * src/gdcmFile.cxx : bug fix concerning the close of file
2180 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2181 * Add the update of header entries using the shadow library
2183 2004-01-19 Benoit Regrain
2184 * removal of file gdcmHeader2.cxx
2185 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2186 inheriting from gdcmParser. This split is to prepare the integration
2187 of dicom dir parsing
2188 * bug fix under python
2190 2004-01-16 Jean-Pierre Roux
2191 * REM removal of class gdcmHeaderEntrySet
2192 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2193 * ADD add file gdcmHeader2.cxx
2194 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2196 2004-01-15 Benoit Regrain
2197 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2198 entries created while parsing the header. Thus, they will be destroyed
2199 when the gdcmDictSet will be destroyed
2200 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2203 2004-01-15 Benoit Regrain
2204 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2205 made a fatal error because of the memory release at the end of program.
2206 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2207 some memory and vtk seems to have some problems with that.
2208 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2210 2004-01-14 Benoit Regrain
2211 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2212 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2213 * src/*.[h|cxx] : make changes due to class name changes
2214 * gdcmPython/demo/*.py : bug fix due to method names
2216 2004-01-13 Benoit Regrain
2217 * src/*.[h|cxx] : coding style
2218 * vtk/*.[h|cxx] : coding style
2220 2004-01-13 Benoit Regrain
2221 * gdcmPython/testSuite.py : test the readable flag of file for tests
2222 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2223 It's lied to the stl compilation by MSVC (windows, always windows...)
2224 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2226 2004-01-12 Benoit Regrain
2227 * src/*.h : add comments
2228 * src/gdcmDictSet.h : set the method BuildDictPath in public
2229 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2230 directly setted in the source code
2231 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2234 2004-01-09 Benoit Regrain
2235 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2236 * setup.py : use a reference to gdcmVERSION
2238 2004-01-07 Benoit Regrain
2239 * Modification to compile with the distutils.
2242 2003-12-10 Benoit Regrain
2243 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2244 can use a gdcmHeaderHelper to load data
2245 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2246 made in the source code
2248 2003-12-10 Benoit Regrain
2249 * Update Windows projects and .cvsignore files
2251 2003-11-12 Jean-Pierre Roux
2252 * ENH gdcmHeader constructor has one more parameter (default value : false)
2253 that allows the user to 'go inside' the SeQuences only
2255 gdcmElValSet:Print takes it into account
2257 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2258 * ENH: Update gdcmPython/CMakeLists
2259 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2260 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2262 2003-11-10 Jean-Pierre Roux
2263 * FIX : gdcmHeader::LoadElements is now based
2264 on the ListTag listElem member,
2265 not longer on the TagElValueHT tagHt member
2266 * ENH : PrintPubElVal shows (temporarily) both results,
2267 with the tagHt member and the listElem member.
2268 (it's easier to 'see' the problems when using Printheader)
2270 * FIX : old private member LgrElem is now splitted into
2271 ReadLength : Length actually found on disk (updated only
2272 if bug fixing is necessary), for internal
2274 UsableLength : Updated by FixFoundLength, to fix a bug
2275 or to allow Parser going on.
2276 Will allow to re-write a kosher header when a SeQuence
2277 with a length (not 0000) is found
2278 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2279 because gdcmElValSet::Add does not update ListElem
2282 2003-11-07 Jean-Pierre Roux
2283 * FIX misstyping in Transfert Syntax name table
2284 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2285 when they have an actual length (not 0000 nor FFFFF)
2286 (Nobody should care of it, but DICOMDIR explorers)
2288 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2289 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2291 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2292 * ENH: vtkGdcmReader now supports LUT !
2293 (vtkgdcmViewer for now is not able to use them though)
2295 2003-11-05 Jean-Pierre Roux
2296 * in testSuite.py : new files names for checking the package
2297 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2298 that returns the pixel area size to the *aware* (vtk) user
2299 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2301 2003-11-05 Benoit Regrain
2302 * in testSuite.py : Modify the rules for checking the paths
2303 : Explicit error messages
2304 * in __init__.py : Related modif
2306 2003-11-03 Jean-Pierre Roux
2307 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2308 to be used by aware (vtk) users that want to manage
2309 LUT (and no to turn the PALETTE image into an RGB pixels one)
2310 * GetPixelType now returns 8U for 24 Bits images
2311 (vtkGdcmReader compliant)
2313 2003-10-31 Jean-Pierre Roux
2314 * Removal of *all* gdcmData images and add them again
2315 in order to loose the 'history' of un-anonymised images
2317 2003-10-31 Jean-Pierre Roux
2318 * RMV : removal of useless jBitsInJsample.h
2319 for both 8 and 12 Bits JPEG Lossy Libraries
2321 2003-10-31 Jean-Pierre Roux
2322 * ENH : Add the functions gdcmFile::GetImageDataRaw
2323 gdcmFile::GetImageDataIntoVectorRaw
2324 that act as GetImageData and GetImageDataIntoVector
2325 except the making of an RGB Plane from Gray Plane + LUT
2326 Intended to aware (vtk) users who know how to manage
2329 GetLUTRGBA return a R,G,B,A LUT if any
2330 lgrTotaleRaw gives the 'Raw' length
2331 GetImageDataRaw returns the gray Plane
2332 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2333 (They stay Grey, just like with other Dicom viewers :-(
2335 2003-10-30 Jean-Pierre Roux
2336 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2338 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2339 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2340 being coherents dicom files.
2342 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2343 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2345 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2346 * ENH: Two steps is necessary to please VC++ compiler...
2347 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2348 * ENH: Add include dir to medcon lib
2349 * FIX: only one function is being exported for now !
2350 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2352 2003-10-29 Jean-Pierre Roux
2353 * adding gdcmHeader::GetLUTRGBA
2354 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2355 --> Mathieu, the modif u're waiting for is not yet committed
2356 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2358 2003-10-27 Jean-Pierre Roux
2359 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2360 00191113.dcm DermaColorLossLess.dcm
2361 MxTwinLossLess.dcm RadBWLossLess.dcm
2362 * ENH: For version prior to vtkImageViewer2 -r 1.19
2363 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2365 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2366 * Removal of ido stuff in CMakeLists.txt
2368 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2369 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2370 * FIX: remove a call to ->Modified ... see comments
2371 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2373 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2374 * FIX: Problem with path for libvtkgdcmPython
2375 * ENH: Try adding a search script for python site-package
2376 * RMV: Remove some file from medcon lib that are not necessary
2377 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2378 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2379 * FIX: More pragma disable fro VC++,
2380 I don't think I break something as it is also disable in VTK/ITK.
2381 But it fasten debug compilation time.
2383 2003-10-23 Jean-Pierre Roux
2384 * gdcm now deals with 16 Bits Run Length Encoded images
2385 (they are compressed as 2 planes images,
2386 one for the high Bytes, the other for low Bytes)
2388 2003-10-22 Jean-Pierre Roux
2389 * Now CheckRead takes into account :
2390 - the bugged 'Leonardo' Siemens images
2391 - the XA images, sent thru the burning VPRO station
2392 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2395 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * FIX: When copying a Makefile.am to CMakeLists.txt
2397 one should remove the '\'
2399 2003-10-22 Jean-Pierre Roux
2400 * in gdcmData adding a bugged 'Leonardo' Siemens image
2401 (wrong lengths in header)
2402 OK with gdcm, KO with the other viewers :-)
2403 * add a GE dlx XA image, thru the VEPRO burning station
2406 2003-10-21 Jean-Pierre Roux
2407 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2408 for a brutal checking of vtkgdcmViewer compliance
2410 2003-10-21 Jean-Pierre Roux
2411 * add the files for 'xmedcon' Jpeg Lossless library
2412 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2414 2003-10-21 Jean-Pierre Roux
2415 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2417 2003-10-21 Jean-Pierre Roux
2418 * garbage Siemens 'Leonardo' images dealt with
2419 (the patch is easy to remove)
2420 * cosmetic changes to avoid warnings
2422 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2424 no need to press 'r' now.
2426 2003-10-20 Jean-Pierre Roux
2427 * upgrade of checkRead.sh checkWrite.sh according
2428 to new Jpeg Lossless decompressor
2429 * add US.3405.1.dcm, a genuine RGB medical file ...
2430 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2431 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2433 2003-10-15 Jean-Pierre Roux
2434 * general anonymisation in gdcmData
2435 * adding the 'color files' from
2436 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2437 * adding some well knowed bugged-header images
2438 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2439 waiting for their inclusion in Python testsuite
2441 2003-10-15 Jean-Pierre Roux
2442 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2443 no longer seg faults when file is not found
2445 2003-10-14 Jean-Pierre Roux
2446 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2449 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * TODO: *.in file to genereate a UseGDCM later
2452 2003-10-14 Jean-Pierre Roux
2453 * Some supposed-to-be Dicom Images have no preamble.
2454 OpenFile takes it into account
2455 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2456 * Missing elements added in dicomV3.dic
2457 (just to be affraid : have a look at
2458 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2459 and do it again next year ;->
2461 2003-10-13 Jean-Pierre Roux
2462 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2463 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2464 But there are NOT. It's fixed !
2466 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2467 * FIX: "jpeglib.h" was not found on VC++
2468 * FIX: vtkgdcm was not being installed
2470 2003-10-10 Jean-Pierre Roux
2471 * ENH : OpenFile closes the file if it *really* doesn't look like
2472 an ACR-NEMA / DICOM one.
2473 * FIX : testWrite no longer writes an empty file if the source file
2474 is not gdcm Readable
2475 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2478 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2479 * FIX: CMake generate now documentation
2480 * ENH: out of source doc build !
2481 * ENH: Generate both user and dev documentation
2482 * ENH: Should work on windows too
2483 * ENH: Only one doxygen config.in file is needed
2484 * FIX: make install should be ok now on ùnix plateform
2485 * FIX: PATH to dictionary was wrong (missing /)
2486 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2488 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2489 * vtkGdcmReader is now able to read rgb dicom file.
2490 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2491 * added a gdcmViewer to vtk test, use mouse to control
2492 window level & window width
2494 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2495 * CMake-ification of gdcm, we have now two build system
2496 * FIX: on cygwin Wsock32 doesn't exist
2497 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2499 2003-10-06 Emanuel Ollart
2500 * FIX : compilation process wad broken.
2501 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2503 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * change gdcmViewer -> vtkgdcmViewer
2505 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2507 2003-10-06 Jean-Pierre Roux
2508 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2509 ( e.g : well known GE images with a wrong elem length,
2510 : Philips MRI Images with a wrong Huffman table)
2511 * still to be done : allow the reading of bugged LEONARDO Siemens images
2513 2003-10-03 Jean-Pierre Roux
2514 * Odd length strings are padded with '\0' (not with spaces,
2515 to remain compliant with already defined strings,
2516 like Transfert Syntax UID and others)
2518 2003-10-03 Jean-Pierre Roux
2519 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2520 to allow displaying RGB images (not only by affim ;-)
2522 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2523 * vtkGdcmReader is now able to read rgb dicom file.
2524 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2526 2003-10-03 Jean-Pierre Roux
2527 * A few nasty patches to allow the reading of a lot of nasty images
2528 ( e.g : well known GE images with a wrong elem length,
2529 : Philips MRI Images with a wrong Huffman table)
2530 * still to be done : allow the reading of bugged LEONARDO Siemens images
2532 2003-10-03 Jean-Pierre Roux
2533 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2535 2003-10-03 Jean-Pierre Roux
2536 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2537 to allow displaying RGB images (not only by affim ;-)
2539 2003-10-03 Jean-Pierre Roux
2540 * gdcmFile::GetImageDataIntoVector now
2541 - deals with MultiFrames MultiFragments Run Length Encoded files
2542 - deals with YcBcR (YBR_FULL) files
2543 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2544 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2546 (no sample found :-(
2548 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2549 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2550 Two reasons: - clear things
2551 - third parties acces gdcm through header files, so won't
2552 suffer anymore VC++ complains
2554 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2555 * add argv[1] in testvtkGdcmReader.cxx
2558 2003-09-24 Jean-Pierre Roux
2559 * The lines are now eigthy characters long.for
2560 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2562 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2563 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2564 char* to std::string. Thus, the use of strdup becomes useless. (see
2565 previous commis of Malaterre)
2566 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2567 before the last Malaterre's commit.
2569 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * This commit should fix the Debug building under VC++, the problem
2571 was mainly a mixture of debug and release lib being loaded at startup.
2572 * I also remove a depency to a specific C function: strdup. Because I had
2573 to force the link to msvcrtd (whereas strdup is in libc).
2575 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2576 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2577 located in the gdcmCommon.h file. All use of reference of tha has been
2578 changed to now use the variable GDCM_UNFOUND.
2580 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2582 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2583 Dicom dictionary. The test suite can now be run again. Note:
2584 I'm note very happy with the " (RET)" changes. I believe this
2585 RETAINED comment should be dropped when parsing the dictionary.
2586 - PACKAGER corrected
2588 - AUTHORS updated and now in alphabetical order
2589 * Makefile.am now exports gdcm.dsw for Windoze users.
2591 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2592 * cygwin complains about missing std:: in subdir Test/
2594 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2595 * remove some methods that are now in gdcmHeaderHelper
2597 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2598 * vtkGdcmReader set spacing and origin correctly
2600 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2601 * Fix a few delete/delete[] mismatch
2603 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2604 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2605 interpretation to data given by gdcmHeader. For instance there are
2606 heuristics to get informations (look at different places).
2607 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2608 sorting DICOM images based on different strategies.
2609 * modified Makefiles accordingly.
2611 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2612 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2613 when building in debug mode
2614 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2615 src/win32/gdcmdll.dsp
2616 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2618 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2619 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2622 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2623 * src/win32/libgdcmjpeg12.dsp was not dos format
2624 * src/win32/libgdcmjpeg12.dsp :
2625 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2626 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2628 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2629 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2631 * src/gdcmFile.cxx : bug fix in affectation type
2632 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2633 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2634 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2635 symbols... future problem ?
2637 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2638 * src/win32/libgdcmijpeg12.dsp was missing
2639 * modified gdcm.dsw accordingly
2641 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2642 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2644 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2645 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2646 commit of JPR (before his hollidays to facilitate our work).
2647 * setup.py : bug fix in code. Modifications made while the last commit
2648 of JPR. The code hasn't been tested before the commit... it's so
2649 useless to make that (for best programmer that is JPR) !!!
2651 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * tagged the current version as Version0_3 (i.e. version 0.3)
2654 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2655 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2656 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2657 * *.dsp : modifications to use new libgdcmijpeg8 library
2658 * setup.py : bug fix on VTKPATH variable
2659 * PACKAGER : adding all concerning windows
2661 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2664 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2665 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2666 test suite reported error.
2667 * PACKAGER file added (describes what a packager must do when
2668 packaging a new release).
2669 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2670 * configure.in: upgraded version number to 0.3.0
2671 * fixing build of rpm (through rpm -ta):
2672 - Doc/Makefile.am exports proper doxygen files
2673 - src/jpeg/libijg8/Makefile.am exports the include files.
2675 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2676 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2677 * src/gdcmHeader.h : formatting code
2679 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2680 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2681 We were obtaining error message from vtk. Now, creation of file list
2682 is made in an internal list to prevent this problem.
2683 Bug fix when output is empty.
2684 Bug fix in update of progress value. Previous commit for this was a bad
2686 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2688 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2689 * src/gdcmHeader.h : added method to get the file name
2690 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2691 files. Added method to remove all files on the input
2692 Added FIXME comment concerning the bad parsing of header made by
2693 ExecuteInformation method (in ExecuteData method)
2695 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2697 when using make instal.
2698 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2699 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2701 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2702 * setup.py : adding include dir of jpeg lib to compile all sources
2703 * */Win32/*.dsp : JPR fix for windows compilation
2705 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2706 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2708 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2709 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2711 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * setup.py is again effective on un*x (takes into account the
2713 addon of the jpeg library)
2714 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2715 * Doc/Doxy* updated (includes above enhancements)
2716 * INSTALL now points to web documentation
2718 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * src/gdcmHeader.h doesn't make unnecessary reference to
2721 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2723 * src/gdcm*.[cxx|h] :
2724 - to allow compilation with gcc 3.x
2725 -- clean up of STL usage (added explicit usage of std::)
2726 -- small fixes on exceptions.
2727 Note: linking not tested !
2728 - clean of doxygen comments to avoid warnings at documentation
2730 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2731 dependent convertion).
2733 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * Clean up of previous JPR garbage commit (not even commented in the
2736 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2737 - moved all jpeg related files from src to src/jpeg/libijg8, with
2738 addition/modification of Makefile.am and configure.in.
2739 - the testSuite is still brain damage (not guilty).
2741 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * WrapVTK.py : modifications to get correctly vtk source files to
2744 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2745 (FileName -> Filename)
2747 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * vtk/vtkGdcmReader.[cxx/h]:
2749 - UpdateProgress method should now be effective
2750 - removed the limitation on having only images loaded (as opposed
2752 - when building a stack of images/volume, a lesser number of
2753 gdcmHeader and gdcmFile instances should be used (hopefully
2754 accelerating things).
2755 - when building a stack of images/volumes, files which are not
2756 loadable (wrong path-filename, wrong permissions on existing file,
2757 or file not parsable by gdcm) are replaced with a black image
2758 in the stack (for the caller to notice the problem).
2760 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2763 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2764 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2765 between standard library (std) and vtk library (problems are found
2766 under Windows... thanks Windows !)
2768 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2771 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2773 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2776 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * When compiling with distutils (see setup.py) the C++ compiler is
2778 called with different flags than the default ones (with automake).
2779 In order to fix all those warning, I compiled gdcm with the command
2780 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2781 and went for warning fixes:
2782 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2783 up from unused variables.
2784 - vtk/vtkGdcmReader.cxx: potential bug fix.
2785 * src/gdcmHeader.h: Doxygen warning cleanup
2787 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2788 * gdcmPython/gdcm.i:
2789 - typemaps correction to take into account the systematic replacement
2790 of "using namespace std" with std:: prefix e.g. std::list,
2791 std::string... (cf changes of 2003-05-21).
2792 - gdcmGlob global variable of type gdcmGlobal (defined in
2793 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2794 exported to Python a as cvar.
2795 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2796 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2797 gdcmDictSet.GetPubDictTagNames() and
2798 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2799 C++ static methods).
2800 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2801 with the above changes.
2803 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2804 * setup.py, manifest.in : bug fix under linux
2806 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2807 * Modification of setup.py to compile vtk part too. Then, we have 2
2808 wrappers which must work with same distutils. For that, we have a
2809 generic distutils in distusiltsWrapping.py ; with :
2810 - build_extWrap class to wrap generically all extensions,
2811 - ExtensionWrap base class for all wrapping extension that contains
2813 - Wrapper interface which wrap sources
2814 + In WrapSwig.py we have extension and wrapper for Swig
2815 + In WrapVTK.py we have extension and wrapper for VTK
2816 * MANIFEST.in : modifications to consider vtk directory and new python
2817 files for compilation
2819 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2820 * Added python wrappers of vtkGdcmReader vtk class (see the
2821 source in vtk/vtkGdcmReader.cxx) :
2822 - vtk/Makefile.am now builds a library
2823 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2824 python library (as opposed to _gdcm.so wich are the python
2825 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2826 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2828 - configure.in has an additional flag --enable-vtk that needs
2829 to be set to enable compilation of vtk related code, that is:
2830 + vtk/vtkGdcmReader.so and
2831 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2832 + gdcmPython/vtkgdcmPython.so (see above)
2833 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2834 be read when compressed or when HighBit + 1 != BitsStored),
2835 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2836 the usage of the python wrapper of vtkGdcmReader vtk class.
2837 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2838 * src/*.[h] all occurences of stl classes are now prefixed with
2839 std::, and all occurences of "using namespace std;" where removed.
2840 This is to avoid pollution of global namespace in included files.
2841 Apparently vtk does not avoid this pitfall: when using both
2842 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2843 collision of various stl members (principally cout...).
2844 * gdcmPython/testSuite.py now cleanly removes temprory generated
2846 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2847 comply with above changes)
2849 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2850 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2851 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2852 vtk data structure (an image Flip was required).
2853 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2854 * cosmetic changes in documentation.
2856 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2857 * src/gdcmHeader.cxx: the constructor no longer exits when an
2858 unexisting file is given as argument.
2859 * The subdirectory Data (containing all the images used for the
2860 test suite) is not part of this repository anymore. A new module
2861 containing those images is now available at
2862 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2863 with the name gdcmData.
2864 All the python scripts (including the package initialisation file
2865 gdcmPython/__init__.py) were adapated to take this change into
2866 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2868 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2869 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2870 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2871 demo of the usage of this class.
2872 Compilation of this vtk part is only done when using the --enable-vtk
2873 at configure (or autogen.sh) stage.
2875 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2876 * More memory link related corrections and documentation fixes.
2878 - maximum info is obtained with a command of the form:
2879 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2880 --show-reachable=yes PrintHeader
2881 - the remaining reachable blocks seem to come from the STL
2882 allocation scheme through the usage of map and list. It looks
2883 like this memory cannot be freed but it is not a memory leak
2884 (in fact further invocation to the STL would recollect the
2885 unused memory allthough it cannot explicitely be freed).
2886 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2887 of displaying an image parsed with gdcm and displayed with VTK.
2888 Note: some images don't seem to work e.g.
2889 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2890 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2891 Allthough this weakens the semantics, it is a ditch attempt to
2892 make gdcm more thread friendly.
2894 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2895 * Memory link hunt (by using valgrind through the command
2896 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2897 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2898 gdcmHeader::_dicom_vr.
2899 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2900 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2902 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2904 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2905 * src/Makefile.am now exports all the necessary include files at
2909 * UpdateGroupLength replaced by new one
2912 * UpdateGroupLength re-written using H-Table
2913 (named UpdateGroupLengthNew untill checks are over)
2915 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2916 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2917 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2919 - gdcmHeader::GetPubElValSet removed.
2920 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2921 UpdateGroupLength, WriteElements, Write.
2922 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2923 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2924 carried the same semantics.
2925 - src/gdcmHeaderIdo.cxx changed accordingly.
2926 - gdcmFile::WriteBase now regroups all the codes from previous
2927 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2928 - enum FileType moved to gdcmCommon.h
2929 * src/gdcmHeader.cxx AddDefault trashed
2930 * gdcmGetXSize added
2931 * getimageDataSize now calls gdcmGetXSize
2932 * Test/*.cxx changed to agree with above changes
2934 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2936 (to avoid double call by end user).
2937 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2938 by end user, since gdcmHeader::gdcmHeader now handles it.
2940 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2941 * gdcm/Doc many doxygen changes:
2942 - Doxyfile now has two different versions, DoxyfileUsers that generates
2943 the html.users end users oriented documentation and
2944 DoxyfileDeveloppers that generates the html.developper developper
2945 oriented documentation.
2946 - README changed accordingly
2947 - requirement.txt removed (old design info moved to TODO).
2948 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2949 DoxyMainPage.txt, DoxyPython.txt provide more information.
2950 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2951 be updated by simply regenerating the docs with doxygen and copying
2952 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2953 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2954 all the tests in the form "if (<map>.count() >1)" were removed.
2955 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2956 ill-formed documentation sections.
2957 * src/gdcmHeader.cxx: ditto
2959 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * setup.py fixed for un*x (needed macro for stdint.h)
2961 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2962 un*ces with sh-utils test utility.
2963 * gdcmPython/demo/test.py renamed to PrintHeader.py
2964 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2965 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2966 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2967 * src/gdcm*.cxx JPR's bad inclusion fixed.
2969 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2970 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2971 * gdcmPython/demo/test.py changed accordingly.
2973 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * gdcmPython/Makefile.am fixed linking against libstdc++
2975 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2976 * Swig subdir (historical tests of swig version 1.3.17++) removed
2977 * Test/testChangeEntete.cxx some lines commented out in order to make
2979 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2980 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2982 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2983 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2984 hence the user doesn't need this explicit call.
2985 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2986 i.e. LoadElements() call removed.
2987 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2988 - src/Makefile.am declares the proper flag for g++.
2989 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2990 for adding user defined new tags.
2991 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2992 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2993 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2995 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2996 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2997 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2998 src/Makefile.am : the project should properly compile and install
2999 with the autotools, included the python wrappers part.
3000 * gdcm.spec.in : added a spec file for RPM packaging.
3002 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3003 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3005 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3007 to exported to the environement (see gdcmPython/testSuite.py
3009 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3010 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3011 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3012 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3013 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3015 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3016 * gdcmPython/__init__.py doesn't crash anymore when running in
3017 in InstallMode or PreInstallMode but with an environment given
3018 value of GDCM_DICT_PATH.
3019 * src/gdcmDictSet.[cxx/h] coding style.
3021 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3023 * src/gdcm.h general comments moved to TODO, and README
3024 * src/gdcm.h should now be seen as a user commodity (including it
3025 should suffice to fully use gdcm). It is nowhere including within
3026 any of the kernel files src/*.cxx and src/*.h.
3028 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3030 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3032 * src/gdcm*.cxx only include their corresponding include file
3033 (as opposed to gdcm.h)
3034 * gdcmPython/gdcm.i changed accordingly
3035 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3036 the autogen.sh generated "make snapshot" command to work.
3037 * autogen.sh removed history related references to crea package.
3039 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3040 * distutilsSwigCPlusPlus.py work around some swig portability
3043 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3045 was done in a last ditch attempt to get setup.py _really_
3046 operationnal. The python/gdcmPython layaout add the advantage
3047 of hidding away the python related distutils specific files
3048 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3049 Alas, the src directory was out of scope (i.e. it's relative
3050 position to setup.py was ../src) which made things impossible to
3051 handle (see previous version of python/setup.py). Crossing fingers...
3053 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * python/setup.py now works on Un*x. (harder than I thougth)
3055 * python/distutilsSwigCPlusPlus.py can now have include files
3056 among the list of sources.
3058 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3059 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3060 * modifications in MSVC projects
3062 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * As stated by the first lines of Test/ExceptionAndPython/README, it
3064 looks like we can move back to original usage of exception within
3065 src/gdcm* and hence remove the errno stuff that was introduced
3066 as a quick and dirty fixture of this problem (added to the TODO).
3067 * Doc/Doxyfile configuration file for Doxygen and corresponding
3068 README file for usage added.
3069 * Test/testWrite.cxx added. This new test comes from a split of
3070 test.cxx that is now reverted to its original purpous i.e.
3071 testing the proper parsing of a Dicom related file.
3072 testWrite.cxx concentrates on testing the IO part of gdcm.
3073 * Test/bug1.cxx (containing a bug on WIn32) added.
3074 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3075 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3076 whose purpose is to publish the content of the TagNames of the
3077 Dicom public dictionary were not accessible without an
3078 instance of class gdcmHeader.
3079 - those methods are now static methods of gdcmDictSet and hence
3080 require no instances at all to be invocated.
3081 - within gdcmDictSet this change required to change some method
3082 to class methods (i.e. are now static) among which SetDictPath
3083 (renamed to BuildDictPath) and LoadDefaultPubDict.
3084 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3085 the above changes by calling the new method classes of gdcmDictSet.
3086 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3087 the above to be effective.
3088 * python/gdcmPython: in order to wrap properly the above changes
3089 for Python, swig version now needs to be > 1.3.17.
3090 * python/gdcmPython/Makefile fixed to adapt itself to new
3091 configure/make shema introduced by Johan Montagnat (thanks for the
3092 contribution). Alas this Makefile cannot be turned into a proper
3093 Makefile.am without some heavy changes in the configure.in
3094 (for python dectection).
3095 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3096 now avoids publishing the empty entries.
3098 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3099 * python/setup.py : bug fix concerning install under windows
3100 ExtraPath reused :-P
3101 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3103 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3104 * Dicts/dicomV3.dic : remove double spaces !!!
3105 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3106 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3109 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3110 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3111 method. Doxygenation.
3112 * src/gdcm.h clean up of JPR spurious comments.
3114 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * python/distutilsSwigCPlusPlus.py now properly collects the
3116 shadow classes generated by "swig -c++" (gdcm.py in our case)
3117 when using "python setup.py install".
3118 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3119 reexports the working classes.
3120 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3121 by the classical C errno scheme. This is to prevent an obscure
3122 behavior of the python wrappers when importing wxPython.wx prior
3123 to gdcmPython (which ended up in an abort call). An illustration
3124 of this oddity can be found in the Test/ExceptionAndPython
3125 subdir (see the README file). This problem probably due to
3126 an combination of g++ and dynamic loading.
3127 * added Test/ExceptionAndPython (see above)
3129 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3130 * Changed the layout of the python part to avoid bloating main
3131 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3132 i.e. the distutils arsenal. All the python related stuff is
3133 again in a python subdir, but the package itself is now in
3135 * setup.py was cleaned up:
3136 - pythonIncludePath removed
3137 - python setup.py bdist target is now functional.
3138 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3139 collision with other packages). gdcmPython/demo/*.py changed
3142 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3143 * python subdir moved to gdcmPython (preparation of distutils packaging).
3144 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3145 distutils installer is operational.
3146 * - gdcmPython/__init__.py now properly loads the swig generated
3147 shadow classes (from gdcm.py).
3148 - gdcmPython/demo/*.py changed to import the package gdcmPython
3149 instead of gdcmPython/demo/load.py.
3150 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3152 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3154 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3155 entries within the associated public Dicom dictionary resp. the same
3156 information but sorted by the fourth field (PAT, IMG, DIR) of the
3158 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3159 are now in the "???" group.
3160 - python/gdcm.i changed accordingly,
3161 - python/demo/printGroupedPublicDict.py added, that gives an example
3162 of the above new functionalities in Python.
3164 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3165 * src/gdcm.h, gdcmHeader.cxx:
3166 - historic references to glib's g_malloc and g_free (#defined)
3167 were definitively removed.
3168 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3169 * src/gdcmElValSet.cxx:
3170 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3171 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3172 - GetElValue(string) renamed to GetElValueByName.
3173 - Added GetElementByName(string).
3174 * src/gdcmHeader.cxx: added
3175 - GetPubElValRepByNumber(guint16, guint16)
3176 - GetPubElValRepByName(string)
3177 - GetShaElValRepByNumber(guint16, guint16)
3178 - GetShaElValRepByName(string)
3179 - GetShaElValByNumber(guint16, guint16)
3180 - GetShaElValRepByName(string)
3181 - GetElValRepByNumber(guint16, guint16)
3182 - GetElValRepByName(string)
3183 - GetElValByNumber(guint16, guint16)
3184 - GetElValRepByName(string)
3185 * Doc/requirements.txt added.
3187 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * Test/Makefile building now depends on the one of libgdcm.so
3189 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3190 pixel data) aware which enables finding the address (offset) of
3191 the pixel data of JPEG encoded DICOM files. This leaves only a single
3192 file in the testSuite whose pixel data address (offset) is unknown.
3193 * python/testSuite.py changed accordingly.
3195 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3196 * VC++ has some strong limitations when working with the STL, as stated
3197 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3198 "Also note that some STL containers (map, set, queue, list, deque)
3199 cannot be exported. [...]
3200 Some STL classes contain nested classes. These classes can not
3202 This is caused by a designed limitation that once a template
3203 class is instantiated, it can not be re-instantiated and
3205 Since our usage of map<> is ubiquitous in gdcm, this "designed
3206 limitation" of VC++ is a pitfall.
3207 Hence the Python wrappers of gdcm cannot be incrementally linked
3208 against the c++ dynamic library. The dirty but only workaround is
3209 to forget about incremental link of dynamic libraries and to generate
3210 the Python wrappers library with the inclusions of the underlying C++
3212 The following modifications concern this matter on Win32/VC++:
3213 - wrapping python correct with standalone wrapped dll (don't use separate
3214 dll under windows !!!!)
3215 - python21_d debug mode enabled (ask Frog how to use it :-)
3216 - NO problem with having an STL member of class for example string in C++
3217 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3218 - Python test of dcmlib in Python is ok under windows on a large set
3220 * removed glib references
3221 * typedef's inserted in gdcm.i for correct swig type management
3223 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3224 * python/demo/*.py load.py extracted from test.py. Added explore.py
3225 that only displays required tags and testAll.py that parses all
3226 the files of the testsuite without using unittest.
3227 * python/testSuite.py other additional test on new files added.
3228 * Data/* new test files added accordingly to the testSuite.
3229 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3230 the vr in the file differs from the one of the dictionary.
3232 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3233 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3234 values, but limits itself to values which are below a user specified
3235 size (by default 1024 bytes).
3236 * python/gdcm.i : elements not loaded (because their size is above the
3237 user specified treshold) are exported with their TagKey as key of the
3238 python dictionary. This enables the testsuite to make some checks
3239 on the unloaded elements (since we have their offset and size).
3240 * python/testSuite.py
3241 - now tests for the existence and proper value of the pixel data
3242 - two new examples added.
3243 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3245 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3246 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3247 aware. See the strategy comments in gdcmHeader::FindLength().
3248 * Test/test.cxx now accepts a filename as first argument.
3249 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3250 * python/testSuite.py changed to integrate test on above files.
3252 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3253 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3254 the vr was also RET.
3255 * python/testSuite.py more tests added.
3257 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3258 * python/testSuite.py unittest test suite added (uses Data)
3259 * Data/* dcm and acr files for the test suite.
3260 * glib dependance removed from un*x version. We now use ISO C99
3261 7.18 Integer types (see stdint.h)
3262 - python/Makefile, src/Makefile src/gdcm.h
3263 * src/ when an explicit vr (like dicom files) suddenly poped an
3264 implicit element we use to mark the underlying DictEntry of the
3265 concerned ElValue with "Implicit". This strategy was damageable
3266 too the public or provite dictionaries, since some of their vr
3267 would be changed. Since Header::FindLength heavily relies on the
3268 detection by Header::FindVR of falsely explicit elements, I
3269 added an extra ImplicitVr member to ElValue (boolean).
3270 The rest of the changes we the necessary adaptations.
3272 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3273 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3275 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3277 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * Adaptation for porting to VC++:
3280 o forced to use std namespace (for string to be known)
3281 o all class use __declspec export style on WIN32
3282 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3283 (in stdlib.h on Win32 but in std:: for gcc)
3284 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3285 variable GDCM_DICT_PATH.
3286 * src/gdcmHeader.cxx verbose comments made discrete.
3288 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3289 * python/gdcm.i: added a typemap that converts a C++ hashing table
3290 to native Python dictionary.
3291 * python/demo/test.py:
3292 - now uses the native dictionary for exploration of gdcmHeader.
3293 - takes an optional filename argument (the file to parse).
3294 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3295 PubElVals hashing table.
3296 * Dicts/dicomV3.dic removed error prone trailing spaces.
3298 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3299 * Python wrapping process moved away from src/Makefile to
3300 newly created python/Makefile (as well as gdcm.i)
3301 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3302 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3303 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3304 from the environement variable GDCM_DICT_PATH (when existing).
3305 * src/gdcmDict::GetTag bug fix.
3307 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * Straightforward temporary fixes for swig to build the python wrappers.
3309 src/Makefile now has a python working entry [by working we mean
3310 that we can import the shadow classes without errors].
3312 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3313 * hashtest.cxx removed (since already in Test)
3314 * src/gdcmlib.h renamed to src/gdcm.h
3315 * src/dcm.i renamed to src/gdcm.i
3316 * src/Makefile prepared for python wrapping
3318 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3319 * src/gdcmHeader.cxx :
3320 - Parsing of header is now separated from loading of element values
3321 (see gdcmHeader::LoadElements).
3322 - general clean up of hopefully all file access (creation of
3323 ReadInt16 and ReadInt32)
3325 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3326 * src/gdcmHeader.cxx :
3327 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3329 - SetLgrElem renamed to SetLength
3330 - GetLgrElem renamed to GetLength
3331 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3332 * src/gdcmElValSet.cxx fixed both GetElValue methods
3333 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3334 due to IdoDude was cleaned out.
3336 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3338 concentrates on finding the value representation (when it exists).
3339 RecupLgr now only finds the element value length, and it avoids
3340 returning the unecessary skL (skipped length).
3341 Also, offsetCourant was simply removed (with taille_fich) since
3342 it was redundant with the File position internals (by using
3343 ftell and fseek). This also made skL (see above in RecupLgr) usage
3345 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3346 on the libido specificities which are handled through class
3348 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3351 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3352 * Truckload of changes. Parsing of header is barely functional
3353 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3355 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3356 * src/gdcmHeader.cxx many addons of low level methods
3358 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3359 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3360 and _IdDcmSWAP_LONG.
3362 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3363 * This corresponds to all the changes decided at the meeting of
3364 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob