1 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
3 DicomDirSerie, DicomDirImage
4 Dict, DictSet classes :
5 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
6 -remove InitTraversal method.
7 * UPD Test programs + Example programs
9 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
10 remove useless and never updated keyword \ingroup
12 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
14 is no memory access violation
15 * gdcmPython/demo : add python demos using VTK
17 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
18 * FIX 'Dictionnary' is now spelt 'Dictionary'
19 'wether' is now spelt 'whether'
20 'archieve' is now spelt 'archive' ;-)
22 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
23 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
24 related methods, in order not to expose internal mechanisms
27 * REM methods that exposed internal mechanisms :
28 DicomDir::GetDicomDirPatients()
29 DicomDirPatient::GetDicomDirStudies()
30 DicomDirStudy::GetDicomDirSeries()
31 DicomDirSerie::GetDicomDirImages()
42 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
43 * Removed the Print/indent/default parameter mess. There is absolutely no
44 reason to have to methods, moreover with the second taking the ostream as
45 *SECOND* parameter. This was clearly a bad hack to get things compile.
47 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 * Complete rewrite of the GetMacAddress code. Now the code is *much*
49 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
50 Unfortunately the main code does not work on SunOS, thus provide a specific
51 code for this platform only (and Win32 of course). Since this seems to be
52 working, change CreateUniqueUID to use GetMACAddress instead of the
53 problematic GctestetIPAddress
55 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
56 * Unfortunately to be able to test gdcmDirList I had to break the API
57 a little. Now the class is not a std::list anymore but has a member
58 std::vector (more ITK compatible). Allow unit testing on Win32 and
61 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 * Update SerieHeader to take into account a Serie Instance UID to properly
65 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 * ENH - Comment out Mathieu's (dangerous) Super Hack
67 for dealing with BIGENDIAN processors
68 - Move equivalent stuff to BinEntry::WriteContent
69 When necessary, 16 Bits Pixels are swapped in a small buffer
70 and then written. This avoid allocating a huge buffer, in
71 PixelWriteConvertor, and avoid modifying the Pixel Area.
73 Probabely, the same operation will have to be done when we want
74 to write image with Big Endian Transfert Syntax,
75 and we are working on Little Endian Processor
77 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
80 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
81 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
83 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
85 * Test/TestDict.cxx : add a new test for the dict classes
87 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
89 file. Debug is yanked if compiled with NDEBUG
91 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDictSet.h : set the default output to the os variable
93 * src/gdcmDictEntry.[h|cxx] : add the Print method
94 * gdcmPython/demo/ : add a new test
96 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
97 * merging of Test/PrintDicomDir and Test/TestDicomDir
98 * removal of now redundant Test/PrintDicomDir
99 * enhancement of Example/PrintDicomDir
101 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * Now, python test might work on systems
103 * Add the PrintDicomDir test
105 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
106 * FIX : First entry following group 0002 was lost for
107 Explicit Big Endian Transfer Syntax files
108 (group and elem not swaped)
110 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
112 Big Endian Transfer Syntax supposed the group following 0002
113 begins always by element 0000 (element 0000 is *optional*)
114 To avoid further troubles, let's be pessimistic, and use
115 Document::HandleOutOfGroup0002() method
116 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
117 (related pb not yet solved)
119 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * Bug fix for the python part use
121 * Now, PrintHeader.py pass... but outside the ctest use. shit !
123 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
126 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
127 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
128 a string and should ask the global TS dict what are the propreties of
131 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
132 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
133 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
134 to swap the Swap Code, at parsing time, when we come out of group 0002
135 and Transfer Syntax is Big Endian
136 We should be able to read now 'true DICOM" Big Endian coded images
137 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
138 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
140 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
141 * Hopefully fix the bug on MacOSX and static global initialization.
142 This is the only -minor- patch I found that both please MacOSX and VS6.
143 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
144 but this would require a lot of change. Another approach would be that Global
145 create those string and GDCM_UNFOUND becomes a pointer to a string (which
146 gdcm::Global would destroy at exit).
148 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
149 * Fix bug on MacOSX with static initialization in a multy threaded
150 environment. static const string in a header file used to be ill
151 initialized provoquing the freeze of any tests. patch should solve this
154 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * According to Benoit's suggestion, and without any objection from anybody
156 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
157 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
158 - method gdcmDicomDirObject::GetEntry() renamed as
159 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
161 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
162 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
163 you debug/warning message just as c++ streams which make them very convinient
164 to use. Once this is stabilize I will change the ostringstrem to be
165 redirected to a file (ofstream).
166 * Properly support C99 extension: __FUNCTION__ which allow us to display
167 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
169 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
170 * Removal of useless and dangerous methods :
171 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
172 GetDocEntryByName, GetEntryByName, GetDictEntryByName
173 * Removal of usless methods :
174 Dict::PrintByName, Dict::GetDictEntryByName
175 * Commenting out of probabely useless methods :
176 Dict::GetDictEntryNames()
177 Dict::GetDictEntryNamesByCategory()
178 DictSet::GetPubDictEntryNames()
179 DictSet::GetPubDictEntryNamesByCategory()
180 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
181 * ENH : Use dicomTS.dic as described in 2004 version
182 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
183 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
184 Add Accessors on VM (Value Multiplicity), and VM related methods
185 * ADD : Add a list of 'Dicom Attribute types', as found in
186 http://medical.nema.org/dicom/2004/04_15PU.PDF
188 * ADD : Add dicomGroupNameAbbreviations.dic
189 should be used to write a method to replace the former
190 Dict::GetDictEntryNamesByCategory()
192 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
194 to read in the file... and only it ! Length is the efective length of the
195 data in the DocEntry structure
197 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
198 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
199 And now use a static function call instead, with a global variable. i
200 This is much closer to the VTK approach. Hopefully should be bulletproof
201 and easier to use...hopefully
203 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
206 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
209 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
211 ValEntry, BinEntry, SeqEntry creation or replace
213 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
215 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
217 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
218 when specifying the VR
219 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
220 * src/gdcmDocEntry.cxx : amelioration of print
222 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
223 * ADD : Add the method Util::IsCurrentProcessorBigEndian
224 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
225 * ADD Method Document::ComputeGroupLength
226 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
227 in order to allow further VR modification by user
228 * REM : removal of once-called method File::WriteBase
229 integration of its code in formerly one-line method File::Write
231 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
233 replace the different values "??", "Unkn", "Unknown".
234 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
235 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
236 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
237 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
239 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
242 * Set the gdcm::Base class to some Printable classes
244 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmFile.[h|cxx] : add the Print method
246 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
247 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
248 * src/gdcmDocument.h : remove the PrintLevel informations
249 * Example/PrintFile.cxx : use the new gdcm::File::Print
251 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
253 problems when compiling with the python wrapping
255 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
257 writting in ImplicitVR
259 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
260 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
261 JPEG decompression, especially when dicom frames are split into several
262 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
263 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
265 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmHeader.cxx : change the initialisation of default header.
267 Now, this header is readable by gdm, e-film, DicomWorks
269 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
271 Rename Decompressed to Raw
272 * Use the API changes in gdcm::File.
273 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
276 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
278 each added entry in the header. Replace the 'Planes' field by the 'Number
281 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
283 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
285 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
287 At this time, this image isn't readable by e-film... waiting JPR help to
290 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
292 DocEntry. Now use methods of the Document !
294 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * Test/ShowDicomSeq.cxx : bug fix
297 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
299 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
300 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
301 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
303 * Test/TestCopyRescaleDicom.cxx : remove unused variable
304 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
305 containing found sequences
307 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
310 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
311 Some fields in BinEntry must be copied to not seg fault when making the :
312 gdcm::File *copy = new gdcm::File( copyH );
313 and tests are now made on good variables
315 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
317 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
319 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
320 * Add vtkGdcmWriter example and test
322 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * Test/TestUtil.cxx : reformat the source code
324 * vtk/vtkGdcmReader.cxx : remove and change prints
325 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
327 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
328 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
330 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
332 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
334 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
336 by an eof to prevent all bad read of the file... and in this case, the
339 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
340 * Example/Volume2Dicom.cxx : comment unused variables
341 * Test/PrintDicomDir.cxx : comment unused variables
342 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
343 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
344 method that is redondant with AddEntry.
345 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
348 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * Bug fix due my last commit (compilation under Windows).
350 * Example/Volume2Dicom : bug fix in the file and reformatting source code
351 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
353 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 - Remove printf / sprintf
356 - include iostream AFTER gdcm so we don't get warnings
357 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
359 - Also remove tons of include from header files, hopefully this should
360 speeup the compilation time, since it was becoming a dog slow.
361 - Remove gdcm.h as it include way too many files and slow down compilation
362 (plus it is not up to date)
363 - remove 'using namespace std' this is BAD !
365 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * Remove memory leaks on the DicomDir
367 * Remove some useless data in DicomDirObject
368 * Add usefull methods in SQItem, to be complient withe the ElementSet
370 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
373 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
375 future, with convertion)
376 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
377 and ImageDataSize values. Remove the method to get the PixelReadConverter
378 from the output of the class
380 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
383 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
385 and vtkErrorMacro use.
386 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
388 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
391 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
392 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
393 The string leaves only in the fonction. So when we make a .c_str(), we
394 get the pointeur on the first element, element that will be destroyed
395 immediately after thee instruction.
396 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
397 file has been opened : the test must be made on the content of the
398 pointer and not directly on the pointer !
401 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
403 the python part recompiles
405 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
407 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
408 X session is killed (for my computer... it seems to not be identic on
411 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
413 avoid problems (otherwise, the difference test between the visible image
414 and the reference is incorrect. If the reference is greater than the
415 screen resolution, it's produce errors).
416 Can be used for only one image. Can be used with a visible flag.
417 * vtk/vtkGdcmReader.cxx : remove commented codes.
418 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
419 under windows at compilation
420 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
422 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
424 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
426 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
427 tests on the image size X, Y, Z
429 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
431 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
432 between the class name and the file name
434 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * src/ : fix compilation warnings for the Write method (2 different
436 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
437 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
438 variable... create a static method in gdcm::Document to access to
439 this variable content.
441 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
442 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
443 file, to be accessed by other files (like gdcmFile). Remove commented
444 code. Move the change of the header to the gdcmFile, using the
446 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
447 To be sure of that (and simplify calls), the Write of the header now
448 gets a file name and not a file pointer (std::ifstream).
449 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
450 DocEntryArchive. Remove all open of the written file
452 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
455 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
457 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
459 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
460 some corresponding methods. Write correctly the file and check before
462 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
463 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
464 is now on RGB data (as before my last commit
465 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
467 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
469 Add a print information of the type of the entry
470 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
471 It was in the gdcmFile, and all write have been regrouped
472 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
473 Write correctly all dicom files (in decompressed mode only at this time)
474 * Test/ : test on files are now made using Raw data and not color data if
476 * Example/PrintFile.cxx : add more printings
478 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * Amelioration of code, remove some code copy. For the loading of
480 BinEntry (in gdcmDocument), add the test to verify if the file is already
483 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
484 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
485 remove a DocEntry in the header (push an empty DocEntry)
486 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
487 lines. Bug fix in the initialization of the PixelConvert and the
489 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
490 use in TestCopyDicom (now this test can run under windows... but fails)
491 * Test/TestCopyDicom.cxx : amelioration of the test :
492 - test the pixels written
493 - add test points to quickly find where is the error
494 - can set a file name input and output in arguments
495 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
496 amelioration of the test output
498 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
500 all replaced DocEntry's
501 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
502 Now, each needed DocEntry to modify is duplicated, modified and inserted
503 to the header using DocEntryArchive. Thus, after save, we can restore the
504 header initial state.
506 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
509 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
511 correct to copy it. The DictEntry is specified at the DocEntry creation,
512 then, it musn't change in the time.
513 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
514 header correctly. At this time, the change is only made for the first
515 level of the Document. In the future, it might consider sequences.
516 The change is made by replacing a DocEntry by an other that is created
517 outside the class. The old value is kept. When we restore the header
518 status, the added DocEntry is deleted and replaced by the old value.
519 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
520 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
521 set the write type to explicit VR, implicit VR or ACR. Add methods to set
522 the write mode to native, decompressed or RGB (but not used at this time)
524 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
526 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
528 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
529 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
530 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
532 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
533 set because already copied when copying the BinEntry's of the header
534 * Test/TestAllReadCompareDicom.cxx : remove warnings
536 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
538 Two problems appear when doing it :
539 - with the gdcmFile : when the GetImageData method is called, the pixels
540 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
541 data (pixels). And each structure destruct the data when it's
542 destructed. So we have two destructions for the same data. To solve it,
543 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
544 data or not. If it doesn't own data, then they will not destroyed by
546 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
547 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
548 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
549 create a double destruction of the same DocEntry's. So, to solve it,
550 the TagHT is simply cleared and the DicomDir* elements are destroyed.
551 * TODO : add an entry concerning memory leaks in the DicomDir
553 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
555 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
558 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
560 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
561 after it have been deleted
563 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * FIX: src/* fix the doxygen warnings.
565 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
566 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
567 was erroneously defined with a size of 15 instead of 16. [many thanks
568 to Jean Michel Rouet for pointing out this bug].
570 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
571 1. Finish merging JMR patch for writting DICOM from scratch
572 2. Fix -hopefully- bug with MONOCHROME and space vs null character
573 3. Use const ref when possible
574 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
575 5. A few more comments
576 6. CreateUniqueUID can now be called without parameter"
578 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
579 * ENH: Slightly bigger patch:
580 1. Getting toward full integration of JMR patch for writting dicom from scratch
581 2. Update Test to test part of this patch: CreateUniqueUID
582 3. File was not close properly in gdcmDict
583 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
584 5. Use of const ref instead of copy (speed issue)
585 6. Remove temporary (duplicate) string in TranslateToKey
586 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
587 8. Do not repeat virtual in subclasses
588 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
590 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
591 * Apply first patch toward better string comparison when dealing with broken
592 DICOM files. Essentially the string could be padded with a space instead
593 of a null character as defined by standard
595 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
597 because never used... and in the same time, that's remove some memory leaks
599 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * src/gdcmFile.cxx : now delete the PixelConvert instance.
601 * In examples and tests : change the type of image data variables from void*
602 to uint8_t*. Remmove all delete on image data variables
604 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
606 Verify the file pointer value before open the file, and if it's not null,
607 a verbose message is generated.
608 Close correctly the file when the file isn't considered dicom-like. The
609 correctly close is a call to CloseFile.
610 When closing the file pointer, test if its not null to close the file.
611 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
612 file. For an uncompressed image, the copied data correspond in the least
613 case to the image size (calculated) or the image size specified in the
614 header. A verbose is generated if these two size mismatch
616 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
618 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
619 break under windows (with msvc6 compilation).
621 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
623 compiling with MSVC6)
625 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Bugs fix for the Windows build with VC6
627 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
628 needed (only for projects required VTK). If the VTK is included in all
629 projects, there is conflicts with the jpeg lib of vtk when compiling the
630 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
631 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
632 when compiling the gdcm_wrap.cxx file (created by the compilation of the
634 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
635 (like it's already made for the cout use). Otherwise, conflict with the
638 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
641 - comments on the DicomDir::Method related usage added.
642 - now that we use the namespace gdcm, a lot of internal classes do
643 NOT need to be wrapped anymore.
644 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
645 DicomDir::Method) new example added.
647 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 * Improve string manipulation. I now inforce the notion of 'DicomString'
649 A DicomString can contain as many \0 as they want
650 and it is *always* of even length.
651 We only support odd length for very rare case.
652 And in the near future this should be removed.
654 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
655 * /binary_write/ gdcm source. Now even on big endian we are writting
656 little endian. This should -heopfully- fix some tests
658 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
659 * Now the dictionary is compiled into gdcm lib. This is a default
660 behavior, thus any dic file specified is picked before failback to
661 the one comiled into lib
663 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
664 * Change internals for gdcmDict. Don't use any 'new' any more.
665 This should definitely solve any leak problem, and we should be
666 as fast as before, as long as don't modify too much the dictionary.
668 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * STYLE: ivars should start with a capital letter.
670 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
671 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
673 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
675 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
676 new 2004 dictionaries added (thanks to JPR).
677 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
678 * CLEANUP_ROUND (15) for gdcmPixelConvert
679 - RLEFrame::NumberFragments is now of type unsigned int
680 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
681 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
684 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
685 * Initial work in gathering all transfer syntax accessors. clearly
686 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
687 ivars, but only one transfersyntax (class) ivar with equivalent method on
690 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
691 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
692 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
693 discussed (plus I didn't like having a 2000 lines patch not commited)
695 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
697 * CLEANUP_ROUND (14) for gdcmPixelConvert
698 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
699 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
700 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
702 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
703 anymore and hence avoids storing a copy of PixelConvert::Decompressed
704 into File::Pixel_Data.
706 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
708 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
709 * CLEANUP_ROUND (13) for gdcmPixelConvert
710 Substituted File::ParsePixelData() with PixelConvert::Print() new
712 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
713 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
714 method to those classes.
715 - src/gdcmFile.[cxx|h]:
716 -- Added a ::Print() method.
717 -- PixelConverter is now a reference instead of a member.
718 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
719 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
721 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
723 collaboration diagram and inheritance diagram should be generated with
725 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
726 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
727 pointlessly wrapped (see
728 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
729 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
730 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
731 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
732 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
733 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
734 -- File::Initialise: PixelConverter setup moved away to
735 PixelConverter::GrabInformationsFromHeader()
736 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
737 interpretation moved away to PixelConverter::BuildRGBImage()
739 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
740 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
741 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
743 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
745 displayed on Win32 when a brutal abort() occurs (because of uncatched
746 exception). See TODO new entry of this commit for more on this.
747 * TODO added new entry.
748 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
749 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
750 - HandleColor is no longer called from gdcmFile.cxx
751 - gdcmPixelConvert.cxx clean up on method arguments and internal
752 variable names for semantical coherence.
754 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
755 * Finished lossless transition, not only do we now read all lossless jpeg
756 images, without the need of the Cornwell lib, but we do read them properly now
757 * To reduce code (well to avoid code duplication), I defined a common place
758 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
759 redefine symbols. This is not perfect but this the best solution I found for a
760 compilation time jpeg option.
762 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
763 * Update jpeg ijg lib to support lossless jpeg implementation
764 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
766 * Also added a special copyright for dcmtk since we use their bugfixes.
769 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
771 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
772 matters, as stated in warning note at begining of %include section).
773 * src/gdcmDicomDir*.[cxx|h]: coding style
774 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
775 * src/gdcmJpeg8.cxx: doxygen fix.
776 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
777 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
778 from File:: to PixelConvert::.
780 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
782 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
783 - more code moved away from File:: to PixelConvert::
784 - fat setup of PixelConverter set in place in File::Initialise.
786 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
787 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
788 namespace at the file system level. So now you should convert your examples
790 gdcmHeader -> gdcm::Header
791 It would be nice if people keep in mind to no open the namespace, since it
792 allows compilation on broken plateform which were defining common symbol in
793 the standart namespace (like LP, Unknown ...)
795 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
797 The JPEG fragments are now parsed at the same stage than the RLE
798 information. All code related to JPEG is now in gdcmPixelConvert:
799 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
800 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
801 export a gdcmFile:: method. Those are simply global functions
802 (for the time being this is better than having them attach to
803 either gdcmFile:: or gdcmPixelConvert::).
804 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
805 and stores the result in a gdcmJPEGFragmentsInfo.
806 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
807 code (among other stuff) moved away from gdcmFile:; to
810 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
812 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
813 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
814 clean up of RLE related code.
815 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
816 - src/gdcmRLE.cxx removed
817 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
818 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
819 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
820 * CLEANUP_ROUND (9) for gdcmPixelConvert
821 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
822 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
823 away from gdcmFile:: to gdcmPixelConvert::.
825 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
827 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
828 This is because Parse7Fe0 used to parse the pixels to compute the
829 length. This task was passed over to FindDocEntryLengthOB() a long
830 time ago, EXCEPT I had forgotten the OW case...
831 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
832 we just recylce the code for parsing RLE fragments and computing
834 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
835 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
836 with the retired Parse7Fe0().
837 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
838 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
840 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
842 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
843 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
844 - src/CMakeLists.txt: alphabetic order reodering + new entries.
845 * CLEANUP_ROUND (4) for gdcmPixelConvert
846 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
847 to return an unused length.
849 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
851 this should be cleanner from the plane view. The iostream are erally a pain
852 to use to do simple stuff.
854 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
855 * Redo the compilation of the ijg jpeg library. Now only one source is
856 necesseray. No need to rename file by hand what so ever. CMake handle the
857 copying of the file within different directory, configure header file to
858 modify some symbol. The only addition made to ijg wasd a mangle table so
859 that symbol are different whether we are within 8bits or 12bits.
861 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * Added documentation of vtkgdcmReader on Website:
863 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
864 with it's binary name).
865 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
866 the Website to be more complete.
867 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
868 doxygenated documentation.
869 - Doc/DoxyVtkGdcmReaderExamples.txt added
870 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
871 DoxyVtkGdmReaderExamples.html )
872 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
873 * CLEANUP_ROUND (3) for gdcmPixelConvert
874 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
876 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * CLEANUP_ROUND (2) for gdcmPixelConvert
878 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
880 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * CLEANUP_ROUND for gdcmPixelConvert:
882 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
883 - src/gdcmPixelStuff[h|cxx] removed
884 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
885 - src/CMakeLists.txt changed accordingly
887 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
888 gdcmVersion.py moved to newly created ATTIC related
889 gdcmPython/SetupOldies/ directory.
890 * Autotools clean up:
891 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
892 - autogen.sh configure.in acinclude.m4 python.m4 removed
894 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * src/*.cxx *.h Reference to License.htm fixed to License.html.
896 * Doc/CMakeLists.txt, doxygen.config.in: fix.
897 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
899 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * TODO updated with Mathieu suggestions. I proposed a template for
901 describing TODO entries and used it for new entries.
902 * Added Doc/Website/CodingStyle.html, Developpers.html,
903 DeveloppersPython.html, GdcmDataCvs.html and
904 DownloadVersion0_1.html, DownloadVersion0_3.html.
905 * Some Doc/*.txt Doxygen files (which do not really concern the
906 documentation itself, but the website) moved to html and
907 placed in directory Doc/Website:
908 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
909 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
910 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
911 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
912 * CMakeLists.txt changed accordingly.
913 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
914 DeveloppersPython.html
915 * INSTALL nows refers to Doc/Website/Installation.html
917 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * Added Doc/Website directory, that contains a first raw version
921 2004-09-23 Jean-Pierre Roux
922 * FIX In order not to be poluted any longer by casting problems,
923 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
924 we can now delete[] it safely
925 * VoidArea is now called BinArea (less confusing name),
926 and all the methods called ...VoidArea... are now ... BinArea...
927 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
929 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
931 clear) TagHT, which is an inherited member of gdcmElementSet. It is
932 up to the destructor of gdcmElementSet to clean up TagHt and it's
935 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * Test/CMakeLists.txt: update to follow gdcmData renamings.
937 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
939 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * ENH: added some utility method that builds a flat dictionary
941 holding all the Dicom entries contained in the recursive structure
942 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
944 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
945 BuildFlatHashTable() that build a flat dictionary.
946 - src/gdcmElementSet.h: added a new private GetTag() accessor.
947 gdcmDocument is now a friend of gdcmElementSet.
948 - src/gdcmElementSet.cxx: clean up.
949 - Example/FlatHashTablePrint.cxx added.
950 - Example/CmakeLists.txt changed accordingly
952 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
953 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
954 moved away from gdcmDocEntrySet (since this class is an abstract class
955 acting like an interface). SQDepthLevel and BaseTagKey are now
957 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
958 and associated accessors. Doxygenation of the class.
959 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
961 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
962 Use SQDepthLevel accessor instead. ::Print() adapted.
963 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
964 - src/gdcmDocument.cxx changed accordingly.
966 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
968 - The following is the doxygen comment of the typedef declaration
969 of gdcmTagKey in src/gdcmCommon.h:
970 gdcmTagKey is made to old an "universal" (as in URL, Universal
971 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
972 A dicom tag always has a group and an element, but a set of tags
973 embeded in various (optionally nested) sequences and sharing
974 the same group and element all share the same (group, element)
975 "identifier". Hence the (group, element) cannot be used as an
976 identifier (in gdcm we shall refer to a "TagKey") of a tag.
977 In order to construct a proper tag identifier (i.e. a key) we
978 consider the following definition of a TagKey:
979 - let Group, Element be the string representation of the
980 group and element dicom tag members,
981 - let ItemNumber be the string representation of the integer
982 index of the considered item number of a sequence,
983 Let the key of a tag embeded in a sequence, noted SeqTag, be
985 /ItemNumber#Group|Element
986 where "/", "#" and "|" are characters acting as separators.
987 Then the general form of a gdcmTagKey is given by:
988 Group|Element<SeqTag>
989 where <SeqTag> means NO or many instances of SeqTag.
990 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
993 but the gdcmTagKey of a tag "embeded" is the first item of
994 a sequence, itself nested in the third item of a sequence is the
996 0004|1220/2#0008|0082/0#0008|0090
997 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
998 order to hold the new sequence compatible key. Previously, the
999 GetKey() method would look in the underlying gdcmDictEntry.
1000 - src/gdcmDocEntry.cxx:
1001 -- constructor now copies the underlying DictEntry key, in the local
1003 -- ::Print: displays the member Key, instead of the (group, element).
1004 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1005 - src/gdcmDocEntrySet.h:xi
1006 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1007 -- now has a new BaseTagKey member.
1009 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1010 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1012 This poses the problem with the semantics of the following lines
1013 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1014 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1015 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1016 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1017 to the long FIXME note for what the problem is. Nevertheless in
1018 order to get things working the dicom dictionary was altered !
1019 Please fix things urgently...
1020 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1021 information), see above note on moving the member VoidArea. Nevertheless
1022 the following entries previously correctly set as US are now inproperly
1024 0028 1201 OW IMG Red Palette Color Lookup Table Data
1025 0028 1202 OW IMG Green Palette Color Lookup Table Data
1026 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1027 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1028 of gdcmDocEntry moved to gdcmSeqEntry.
1029 * src/gdcmSeqEntry.cxx: STYLE.
1031 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1034 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * gdcmPython/testSuite.py: all the test suite in python is now moved
1036 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1037 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1038 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1040 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1042 to avoid inclusion recursion until STL is reached.
1043 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1044 mecanism. errno.h is not included in gdcm anymore.
1045 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1046 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1048 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1049 gdcmData/TestAllEntryVerifyReference.txt
1050 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1051 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1052 exception_on_error parameter.
1053 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1054 - vtk/vtkGdcmReader.cxx changed accordingly,
1055 - Example/*.cxx and Test/*.cxx changed accordingly.
1057 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1059 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1060 enable_sequences removed from gdcmHeader constructor and dependencies.
1061 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1062 * gdcmPython/demo/PrintHeader.py: dummy fix.
1063 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1064 skip_shadow removed from gdcmHeader constructor and dependencies.
1065 * Example/*.cxx and Test/*.cxx changed accordingly.
1067 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1069 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1071 2004-07-21 Jean-Pierre Roux
1072 * FIX Now, Parsing and Printing a DICOMDIR do work!
1073 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1075 2004-07-20 Jean-Pierre Roux
1076 * FIX Some brain damaged headers have Zero-Lenght fields
1077 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1079 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1080 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1081 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1082 variable (instance of gdcmDebug) by a definition macro, and the instance
1083 is now in static in the gdcmDebug class
1084 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1085 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1087 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1088 * WARNING: ctest now depends more tightly on gdcmData. You should
1089 check out gdcmData properly for things to run smoothly...
1090 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1091 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1092 we need the pixels not be loaded in order to use the ValEntry
1093 that displays position and size).
1094 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1095 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1096 be deprecated. If you have any doubts about the advantages of a
1097 modern scripting language (read Python) versus grass root C++ (i.e.
1098 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1099 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1100 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1101 Anyhow, consider documenting the gdcmData images in
1102 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1104 * Test/CMakeLists.txt:
1105 - now uses TestAllEntryVerify.cxx
1106 - specific comments on oldACR00001.ima (now renamed in gdcmData
1107 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1108 gdcmData/TestAllEntryVerifyReference.txt
1111 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * src/*.[h|cxx] : typedef clean up
1113 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1114 - TagKey renamed to gdcmTagKey (for external usage)
1115 - VRKey renamed to gdcmVRKey (for external usage)
1116 - removal of typedef duplication.
1117 - Removed all unecessary inline keyword from class inline definitions.
1118 - Some method|function(void) declarations replaced with method|function().
1119 * src/jpeg/libijg12/jdhuff12.c:
1120 - printf polluting ctest removed.
1121 - TAB removal for comminting
1123 - TestAllReadCompareDicom.cxx: added a test that compares all the
1124 images in gdcmDataImages.h with corresponding images in
1125 gdcmData/BaselineDicom/. When baseline images are not present
1126 this test creates them.
1127 Note: we need to validate each reference image, but before that
1128 I'd like to rename them with a more explicit name...
1129 - CMakeLists.txt: changed accordingly.
1130 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1131 including each header needed).
1133 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1134 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1135 test suite to the Example directory. Are concerned:
1140 - TestWriteSimple.cxx
1141 * Test/CMakeLists.txt: added some comments on reasons for black listing
1142 image gdcmData/oldACR00001.ima
1144 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * Test/CmakeList.txt: removed the following from black list (to be coherent
1146 with removal from gdcmData):
1147 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1148 - gdcm-MR-PHILIPS-16.dcm
1150 Added the following because after last cvs update, they cause
1151 ctest -R TestReadWriteReadCompare
1153 - gdcm-MR-SIEMENS-16-1.acr
1155 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1156 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1157 new comments in this file) we temporarily (sigh) move to a weaker
1159 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1160 we don't need to black list the following images anymore:
1161 - 8BitsUncompressedColor.dcm
1163 - US-PAL-8-10x-echo.dcm
1164 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1165 fixes and the beautified code ;-)
1166 This fixes the bug introduced in version 1.42 (when beautifying)
1167 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1168 Note: ctest was blind to this bug (this means we need to still
1169 improve the test suite). The bug could be detected by using
1170 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1172 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1173 and by displaying the (garbage) produced file temp.XDCM...
1175 2004-06-29 Jean-Pierre Roux
1176 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1177 - replace by uggly but working old code :-(
1178 A lot of things should be OK again.
1179 It's really urgent to have a test suite that *tests*,
1180 to prevent Frog's beautifying sessions to break all the stuff
1181 (twice, withing a fortnigh ...)
1183 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1185 redundancy) to added Test/TestReadWriteReadCompare.cxx
1186 * Test/CmakeList.txt: because the compare test of
1187 Test/TestReadWriteReadCompare.cxx fails, the following images are
1188 black listed: - 8BitsUncompressedColor.dcm
1190 - US-PAL-8-10x-echo.dcm
1191 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1192 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1193 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1194 and ad-hoc kludge. This kludge is now removed, and on encountering
1195 such an image (OB field brain damaged) we set errno. Then in
1196 ::FindDocLength() we "fix" the length as being ALL what remains
1197 in the file (until EOF). We then proceed, hoping for the best...
1198 This fixes a SegFault in ShowDicom when trying to write such an
1200 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1201 (because TestWriteRead breaks on it, after a non conformal commit?).
1202 ctest now runs properly, except for MakeDicomDir (which was always
1203 broken) and the Python related stuff (still not fixed).
1205 2004-06-24 Jean-Pierre Roux
1206 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1207 FIX : Test/TestReadWrite now iterates on all the file names
1208 (instead of infinite loop)
1209 ENH : Test/TestWriteRead now iterates on all the file names
1211 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1214 2004-06-24 Jean-Pierre Roux
1215 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1216 when SamplesPerPixel =3
1217 - now Write is no longer confused by
1218 'BitsAllocated = 12" and 'BitsStored=12"
1219 - "UN" value representation Elements are now written correctly
1220 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1221 ENH : - now gdcmHeader has its own Write methods
1222 (in order to split the job that has not to be done
1225 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1226 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1227 loop on the same image until memory went out.
1228 Note: this means we still have gobs of memory loss in PrintDocument
1229 * src/gdcmDocument.cxx: fixes problem on parsing on file
1230 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1232 2004-06-24 Jean-Pierre Roux
1233 FIX : Write - All the Sequences and Sequence Item are now written
1234 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1235 is added a the end, when necessary.
1236 - A lot of brain-damaged images, that were read correctly are
1237 now written correctly
1238 - length compatible BinEntry are now loaded correctly
1239 (even for odd groups)
1240 Note : only Explicit Value Representation was checked.
1241 (question : is implicit VR really necessary for gdcm ?)
1243 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1244 * DEVELOPPER: added a proposition of coding style.
1245 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1248 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1250 Use the gdcmDocEntry::Print() and Write() instead.
1251 * src/gdcmDocument.cxx: bug fix.
1253 2004-06-22 Jean-Pierre Roux
1254 FIX : gdcmDocument.cxx
1255 - Now we do recognize the JpegLossLess format (there was a misstyping in
1256 code 'beautyfication' :-(
1257 - Now we automaticaticaly load the Luts, if any
1259 2004-06-22 Jean-Pierre Roux
1260 In order : to write Sequences, whatever their imbrication level,
1261 : to allow user to create his own Sequences
1262 a lot of modif where necessary (adding, moving, or virtualising methods)
1264 WARNING : save your own sources *before* cvs up !
1267 ADD virtual void Write(FILE *fp, FileType filetype);
1270 ADD virtual void Write(FILE *fp, FileType filetype);
1271 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1274 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1275 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1276 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1277 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1278 ADD std::string GetEntryByName(TagName name);
1279 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1281 std::string vr = "unkn",
1282 std::string fourth = "unkn",
1283 std::string name = "unkn");
1284 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1285 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1286 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1287 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1288 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1289 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1290 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1291 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1294 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1295 ADD virtual std::string GetEntryByName (TagName tagName);
1296 ADD virtual std::string GetEntryVRByName (TagName tagName);
1297 REM virtual bool Write(FILE *, FileType);
1298 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1299 FILE *_fp, FileType type);
1300 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1301 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1302 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1303 REM virtual std::string GetEntryByName (std::string tagName);
1304 REM virtual std::string GetEntryVRByName (std::string tagName);
1305 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1306 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1307 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1309 std::string vr = "unkn",
1310 std::string fourth = "unkn",
1311 std::string name = "unkn");
1312 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1313 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1314 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1315 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1318 ADD virtual void Write(FILE *fp, FileType filetype);
1321 ADD virtual void Write(FILE *fp,FileType filetype);
1324 ADD virtual void Write(FILE *fp, FileType filetype);
1325 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1326 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1327 REM std::string GetEntryByName(TagName name);
1330 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1332 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1334 The default constructor invoked by the line
1335 gdcmHeader *f1 = new gdcmHeader( header );
1336 was gdcmHeader::gdcmHeader(bool) instead of the expected
1337 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1338 Hence the parsing wasn't executed... See also below.
1339 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1340 as explicit constructor didn't do the trick to fix the above problem.
1341 Could anyone explain why ?
1342 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1343 properly calls gdcmValEntry::Print() (that was weed out from
1344 code related to gdcmBinEntry).
1346 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * In order to fix memory leaks:
1348 - Test/TestWriteSimple.cxx: added cleaning of free store through
1350 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1351 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1352 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1353 (through the call to ::AddDicomDirMeta()) or the destructor
1354 would crash when deleting uninitialized ::metaElems].
1355 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1356 - src/gdcmDocument.cxx:
1357 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1358 from dynamic stores.
1359 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1360 was causing memory leaks.
1361 - src/gdcmSQItem.cxx:
1362 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1363 cleanly handled with polymophism: sorry but my milage is low).
1364 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1365 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1366 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1367 This avoids SegFaulting.
1368 - src/gdcmSQItem.h: coding style.
1370 - Test/TestWriteSimple still severely sucks. The output image content
1371 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1372 damaged when displayed with vtkgdcmViewer.
1373 - on memory leaks: TestWriteSimple leaks really less (see entry
1374 of 2004-06-18 in Changelog file for the call to valgrind).
1375 - on segfaults: ctest now passes all the tests but one (no more
1377 * Erroneous leading white fix:
1378 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1379 white[s] (as opposed to from >> xxx, that removes it [them].
1380 - src/gdcmTS.cxx: ditto.
1381 - gdcmPython/testSuite.py: dirty related kludge removed.
1382 * src/*: remaining references to gdcmParser removed.
1383 * src/*[cxx|h]: added copy[way]left header.
1386 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * In order to fix writing of dicom files:
1388 - Test/TestWriteSimple.cxx: a simpler example of writing.
1389 - Test/CMakeLists.txt changed accordingly.
1390 - src/gdcmDocument.cxx:
1391 -- The destructor now recursilvely removes potential sequences.
1392 -- Bug fix in ::IsJPEG2000()
1393 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1394 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1396 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1397 to only declared) and build on top of
1398 ::GetDocEntryByNumber(guint16, guint16).
1399 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1400 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1401 for usage in destructor and treatement of promotion in
1402 ::ReplaceOrCreateByNumber().
1403 - src/gdcmSQItem.cxx: destructor should better handle his job.
1404 Test/TestWriteSimple now runs (or at least it DOES something).
1405 * We can now start hutting memory links. A good starting point is:
1406 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1407 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1408 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1410 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * Valgrind note: after Mathieu Malaterre teached me how to read
1412 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1414 Using gcc, you can force the STL to use malloc and to free memory as
1415 soon as possible by globally disabling memory caching.
1416 With 3.2.2 and later, you should export the environment variable
1417 GLIBCPP_FORCE_NEW before running your program.
1418 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1419 simply vanish (it is still not clear to me, whether this means that
1420 STL std::string leaks or if valgrind believes it leaks...).
1421 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1422 running bin/gdcmTests makeDicomDir):
1423 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1424 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1426 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1427 SegFaulting (I drowned in DicomDir related code when trying to
1428 understand why the list is empty...).
1429 * src/gdcmDocument.h: first BSD license header try.
1430 * Doc/License.txt added.
1432 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * src/gdcmDocument.[h|cxx]:
1434 - Clean up of the Transfer related predicates. They are now all based
1435 on new method isGivenTransferSyntax, that (should) handle properly
1436 the padding problem.
1437 - general clean up, simplification, and coding style.
1438 - Specific clean up of Parse7FE0() (umproperly named actually).
1439 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1441 2004-06-14 Jean-Pierre Roux
1443 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1444 - fix the display of SQItem ordinal number
1445 - add the GetSQItemByOrdinalNumber method
1446 - remove some useless never written private methods
1448 2004-06-14 Jean-Pierre Roux
1450 - adding a constructor taking a gdcmDocEntry as an input param
1451 - ReplaceOrCreateByNumber now returns :
1452 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1453 a gdcmValEntry * if a string value is passed as a param
1455 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1456 according to the param type (no longer sets a gdcmDocEntry)
1457 - GetValEntryByNumber, GetBinEntryByNumber added
1458 - NewValEntryByNumber and NewBinEntryByNumber added
1460 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1462 - GetSQItemNumber and SetSQItemNumber added, to provide
1463 a (relative) Item identier inside a given Sequence
1464 \warning : some pb remaining around this number
1466 - AddEntry now takes the Item Number as a param
1468 - adding a constructor taking a gdcmDocEntry as an input param
1470 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1471 * Memory leak hunt with the following command:
1472 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1473 --show-reachable=yes gdcmTests PrintDocument
1474 It looks like many (all?) leaks are due to the STL (or a bad usage
1475 of the STL. The lines producing the leaks now have a comment with
1476 a "MEMORY LEAK" tag: you can retrieve them with
1477 grep "MEMORY LEAK" src/*
1478 Here are two typical examples which I can't help fixing:
1483 char * test = "babo";
1484 name = test; //// <--- valgrind detects 960 bytes lost in
1485 //// call to std::string::operator=(char const*)
1486 name.clear(); //// Doesn't help !
1494 std::cout << "Type a bunch of characters followed by RETURN: ";
1495 getline(std::cin, line); //// <--- valgrind dectects a loss
1496 //// of 1320 bytes in call to
1497 /// std::basic_istream<>& std::getline<>
1503 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1504 * src/gdcmHeader.[cxx|h]:
1505 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1506 and related, moved away to gdcmDocument.
1507 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1508 the corresponding protected accessors of inherited class
1509 gdcmDocument, removed ! As a consequence gdcmFile had to be
1510 declared friend of class gdcmDocument (see below).
1511 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1512 - Clean up of undefined or unused methods.
1513 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1514 account the changes to gdcmHeader.h).
1515 * src/gdcmDocument.h:
1516 - gdcmFile is now a friend class (in order to take into account the
1517 changes to gdcmHeader.h).
1518 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1519 (see changes to gdcmHeader.h).
1520 - Accessors (reading on the form GetEntry*) are now public.
1521 - Clean up of undefined or unused methods.
1522 * src/gdcmDocument.cxx:
1523 - adaptation to changes to gdcmDocument.h
1524 - ::OpenFile now writes a verbose message when file cannot be opened.
1525 - some std::string properly set to VRKey
1526 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1527 references to gdcmDocument.
1528 * Test/TestFindTags.cxx: changed accordingly to above changes.
1529 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1530 cvs repository gdcmData.
1532 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1534 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1535 conflicts with gdcmValEntry::voidArea.
1536 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1537 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1538 Value representation between StringRepresentable and BinaryRepresentable.
1539 * src/gdcmDocument.cxx:
1540 - method ParseDES: proper indentation restored and usage of
1541 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1542 - method LoadDocEntry: the fingerprint left in the SetValue() of
1543 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1544 removed. Reverting to previous code segment with the proper
1545 dynamic_cast< gdcmValEntry* >.
1546 Note: this was (partially) breaking the python test suite
1547 (gdcmPython/testSuite.py) that made usage of the above
1548 fingerprint to check presence of "Pixel Data".
1549 * src/gdcmDocEntry.h: coding style.
1550 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1551 now taken into account.
1552 * gdcmPython/gdcm.i: adaptation to the new internal representation
1553 of gdcm (exit gdcmParser, hello gdcmDocument).
1554 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1556 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1557 anymore, but instead prints the loaded Python dictionary.
1558 * .... alas, the python testSuite is still broken.
1560 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1561 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1563 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1564 * src/gdcmUtil.h : export methods
1566 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1567 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1569 * Initial addition of automatic python testing
1570 * Initial addition of automatic image comparison
1572 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1573 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1574 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1576 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1577 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1578 * Test/ShowDicom.cxx : bug fix for msvc compilation
1579 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1581 2004-05-04 Jean-Pierre Roux
1582 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1583 new concepts (and new classes) :
1584 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1585 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1586 - Sequence Doc Entries (gdcmSeqEntries)
1587 a Sequence is composed of Items.
1588 Each item is a set of Doc Entries (this is recursive)
1589 The non uniqueness of the 'Dicom tag' is due to this recursivity
1590 (never taken into account)
1591 Our unability to add a new 'entry' in the header
1592 at the proper location (neither in the H-Table (map or multimap),
1593 nor in the Chained List is also due to this recursivity.
1594 Don't try, right now, to use/modify/compile these new sources :
1595 nothing is finished.
1596 We just commit all the stuff, 'as is', in order not to loose it.
1598 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1599 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1601 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1602 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1603 file prefix (SetFilePrefix)
1605 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * Add a new test: ShowDicom, for now this is just the c++ version of
1607 checkRead.sh, later it will be able to compare the image read against a
1609 * Replace the DEBUG on the stack with a global entry in cmake interface:
1610 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1612 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1613 * Add an example subdir, with a real example on how to read + write a
1616 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1618 * Doc/CMakeLists.txt: the main page is now properly differentiated
1619 between the developper and user version.
1620 * Doc/doxygen.config.in: dropped search related obsolete flags
1621 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1623 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * DEVELOPPER: added some helpfull comments for compile/test/install
1627 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1628 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1629 src directory, now generated in the build dir.
1630 2. Tests as mentionned smarter
1632 4. Add a new method in gdcmDict that return the PubDict by name
1633 this is interesting for 3rd party lib like ITK,
1634 where we could set the institution name / patient name...
1636 * ENH: 1. Now the test suite is working for real
1637 2. All binaries are now output in the gdcm-bin directory
1638 (this was not true before)
1640 2004-04-28 Jean-Pierre Roux
1641 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1642 SeQuence indented printing of Dicom Header.
1643 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1644 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1645 Computation of SQDepthLevel is now part of gdcmHeader constructor
1646 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1647 tree-like structure of a Dicom Header.
1648 * FIX Test code cleaning
1650 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1651 * ENH: Adding automatic testing
1652 1. Need a DartConfig.cmake to submit to public
1653 2. Add a test driver gdcmTest.cxx
1654 3. gdcmTestMain, an helper for the main test driver gdcmTest
1655 4. Files in Test don't have a main anymore, this becomes interesting
1656 when we add more and more tests, thus dsw don't have to load
1658 * ENH: Adding a GDCM_DATA_ROOT for testing
1659 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1660 one file instead of seven + some small cleanup
1662 2004-04-22 Jean-Pierre Roux
1663 * ENH Minor changes to the Print() methods.
1664 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1665 Header printing. Example given with :
1666 > PrintHeader fileName 2 new
1667 (SQ based tree-like structure still to be done for the Header ...)
1669 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1670 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1671 1. I have added some unsigned where needed
1672 2. Some function parameter not used -> (void)
1673 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1674 4. g++ don't like character '\' in comment
1675 5. #define jpeg_create_decompress jCreaDecompress
1676 this really need to be fixed
1677 6. virtualize destructor of gdcmObject ... leakage
1678 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1679 this also really need to be fixed
1680 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1681 remove compression file
1682 (as we only do decompression, right ?)
1683 * ENH: Change malloc/calloc/free with c++ equivalent
1685 2004-04-21 Jean-Pierre Roux
1686 * FIX gdcmHeaderHelper::GetXSpacing
1687 when a single value is found (bug ?), xpacing is now
1688 defaulted to yspacing
1690 2004-04-19 Jean-Pierre Roux
1691 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1692 * ENH add parameters :
1693 bool exception_on_error = false,
1694 bool enable_sequences = false,
1695 bool ignore_shadow = false
1696 to the gdcmFile constructors to be full gdcmParser compliant
1697 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1698 to allow reading of PAPYRUS 3.0 files
1700 2004-04-06 Jean-Pierre Roux
1701 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1703 2004-04-02 Jean-Pierre Roux
1704 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1705 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1706 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1708 2004-03-30 Jean-Pierre Roux
1709 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1710 for ACR file, written out as DICOM files (hope so...)
1712 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1713 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1714 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1715 moved to base class gdcmParser and only the specialisation is kept
1717 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1718 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1719 already does the job.
1720 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1721 (to be consistent with gdcmParser::WriteEntries).
1723 2004-03-30 Benoit Regrain
1724 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1725 upate of the object's instance. It's passed to 2 in the unfavorable
1726 case : one in the ExecuteInformation, one in the ExecuteData
1728 2004-03-29 Jean-Pierre Roux
1729 * ENH : Check on file type to be written moved
1730 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1731 * FIX : gdcmObject::ResetBoundaries now stops properly
1732 when end-of-list is reached
1733 : gdcmVersion modified (as Benoit Regrain asked)
1735 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1737 * src/gdcmUtil.cxx: added forgotten iostream include.
1738 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1739 equivalent to ExplicitVR in existing code).
1741 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1742 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1743 now contains all the gdcmGlobal related code.
1744 * minor coding style and doxygenation changes.
1746 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1748 now contains all the Debug related code.
1749 * minor clean-up of includes in src/*.cxx
1750 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1751 CreateCleanString) removed.
1752 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1753 * Doc/DoxyMainPageUser.txt added.
1754 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1755 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1756 src/gdcmDirList.cxx)
1758 2004-03-24 Jean-Pierre Roux
1759 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1761 2004-03-23 Jean-Pierre Roux
1762 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1763 big endian made volumes
1764 * ENH Now gdcmParser constructor and destructor are protected to forbid
1765 end user to instanciate class gdcmParser
1766 (only gdcmHeader and gdcmDicomDir are meaningfull)
1768 2004-03-22 Benoit Regrain
1769 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1770 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1771 gdcmSerie to gdcmDicomDirSerie
1773 2004-03-19 Jean-Pierre Roux
1774 * ENH Now the tree-like structure describing a DICOMDIR comming from
1775 an already existing DICOMDIR file is consistent with
1776 the home-made tree-like structure build ex-nihilo
1777 or build from the files held (recursively) in a Directory
1778 functions gdcmDicomDir::CheckBoundaries()
1779 gdcmObject::SetBoundaries() added
1781 2004-03-17 Jean-Pierre Roux
1782 * REM (Eric Boix bug) : removal of meaningless
1783 gdcmDicomDirImage::NewImage function.
1784 * FIX now file names and directory name are written properly in the
1786 * FIX now gdcmDicomDir constructor may be call without any trick
1789 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1790 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1791 of gdcmDicomDirImage::NewImage as empty function.
1793 2004-02-28 Jean-Pierre Roux
1794 * ENH add gdcmDicomDir:NewPatient
1795 add gdcmDicomDirPatient:NewStudy
1796 add gdcmDicomDirStudy:NewSerie
1797 add gdcmDicomDirSerie:NewImage
1798 to allow making gdcDicomDir object.
1799 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1800 (as opposite to the gdcmHeader chained list)
1802 2004-02-11 Benoit Regrain
1803 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1804 when using from python
1806 2004-02-10 Benoit Regrain
1807 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1808 * FIX : in gdcmDicomDir when the directory is empty
1809 * ENH : add callback and methods to get the progression of dicomDir
1812 2004-02-06 Jean-Pierre Roux
1813 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1814 - GDCM_META added to gdcmDicomDirType
1815 - class gdcmMeta created
1816 * ENH : - A brief summary is now displayed at the beginning of
1817 'testDicomDir' to help disaster magnitude estimation
1818 * REM : Now useless Test/explDICOMDIR.cxx
1820 2004-02-05 Benoit Regrain
1821 * ENH : add methods in gdcmObject to get the hash table or the list of
1823 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1824 * FIX : wrapping python for TagHeaderEntryHT
1826 2004-02-04 Benoit Regrain
1827 * FIX : even length for some strings when writting the dicom dir
1828 * FIX : sort the images in the dicom dir
1829 * FIX : Bug fix for python use of dicom dir
1830 * ADD : a python demo
1832 2004-02-04 Jean-Pierre Roux
1833 * FIX : Final solution (?) for icone embedded images
1834 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1835 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1836 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1837 gdcmData/gdcm-MR-SIEMENS-16.acr1
1838 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1839 to make full checking easier
1841 2004-02-04 Benoit Regrain
1842 * FIX : WriteEntries : coding style & logic in parameters
1843 * FIX : Set the elements to create the DicomDir in a dictionary file
1845 2004-02-03 Benoit Regrain
1846 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1847 * gdcmDicomDir : add the load of directory
1848 * Bug fix and print add-on
1850 2004-02-03 Jean-Pierre Roux
1851 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1852 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1853 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1854 * FIX gdcmParser.cxx : 'group length' elements are now considered
1855 as integers, even for shadow groups, when file is Implicit VR
1857 2004-02-02 Jean-Pierre Roux
1858 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1860 of the last synonym :-(
1861 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1863 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1864 * FIX taking into account the possible 7fe0,0010 multiplicity
1865 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1866 to allow removal of references to 7fe0,0010, to deal with
1867 ACR-NEMA images, when 0028,0200 is meaningfull
1869 2004-01-31 Jean-Pierre Roux
1870 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1871 no longer writes 'Un' on disk
1872 * FIX SQ elements with actual length are now dealt with corectly
1873 * FIX gdcmFile::WriteBase make the difference, for color images, between
1874 the length (for Palette expanded images)
1875 and Raw Length (non expanded image + Palette)
1876 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1877 (that broke Write). Replaced by UL.
1878 Aware user will reload the field if he
1879 thinks it's necesssary
1881 2004-01-30 Jean-Pierre Roux
1882 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1883 when 'dirty Acr' is found, to be compliant with the new
1884 IsReadable() methods.
1886 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1887 (no DOUBLE images in kosher DICOM,
1888 but so usefull for people that miss them ;-)
1890 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1891 DICOMDIR related utilities (not checked as Windoze compliant)
1893 2004-01-28 Jean-Pierre Roux
1894 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1896 2004-01-27 Jean-Pierre Roux
1897 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1898 to allow skipping the shadow elements, to save memory space.
1899 The TRUE value for this param has to be used
1900 with a FALSE value for the 'enable_sequence' param.
1901 ('public elements' may be embedded in 'shadow Sequences')
1902 * gdcmHeader methods now deal with 'embedded icones images' in the header
1903 (even when an 'icone image sequence' is announced by the
1904 element (0x0088,0x0200), but there is NO icone at all ...
1906 * gdcmHeader sometimes Image Location value doesn't follow
1907 the supposed processor endianity (see gdcmData/cr172241.dcm).
1910 * gdcmHeader add the method
1911 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1912 to get *all* the Header Entries with the same tag.
1913 GetHeaderEntrySameName is probabely *useless*
1914 (no meaning : Name is *not* an identifier within the Dictionary)
1916 2004-01-26 Benoit Regrain
1917 * Bug fix in the print of hexadecimal representations. Remove long fields
1918 in the print and add a third level of print to print them
1920 2004-01-23 Benoit Regrain
1921 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1922 * Bug fix on test suite after remove the strip made on not string fields
1923 * Split the IsReadable method between gdcmParser which test that the file
1924 is dicom and gdcmHeader which test that it's an image file
1926 2004-01-22 Benoit Regrain
1927 * DicomDir : clean code, add methods, set variables in protected or private
1928 * gdcmUtil : bug fix for the clean string method
1930 2004-01-19 Benoit Regrain
1931 * Add the use of shadow dictionaries
1932 * bug fix and coding style
1934 2004-01-19 Benoit Regrain
1935 * src/gdcmFile.cxx : bug fix concerning the close of file
1936 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1937 * Add the update of header entries using the shadow library
1939 2004-01-19 Benoit Regrain
1940 * removal of file gdcmHeader2.cxx
1941 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1942 inheriting from gdcmParser. This split is to prepare the integration
1943 of dicom dir parsing
1944 * bug fix under python
1946 2004-01-16 Jean-Pierre Roux
1947 * REM removal of class gdcmHeaderEntrySet
1948 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1949 * ADD add file gdcmHeader2.cxx
1950 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1952 2004-01-15 Benoit Regrain
1953 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1954 entries created while parsing the header. Thus, they will be destroyed
1955 when the gdcmDictSet will be destroyed
1956 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1959 2004-01-15 Benoit Regrain
1960 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1961 made a fatal error because of the memory release at the end of program.
1962 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1963 some memory and vtk seems to have some problems with that.
1964 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1966 2004-01-14 Benoit Regrain
1967 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1968 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1969 * src/*.[h|cxx] : make changes due to class name changes
1970 * gdcmPython/demo/*.py : bug fix due to method names
1972 2004-01-13 Benoit Regrain
1973 * src/*.[h|cxx] : coding style
1974 * vtk/*.[h|cxx] : coding style
1976 2004-01-13 Benoit Regrain
1977 * gdcmPython/testSuite.py : test the readable flag of file for tests
1978 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1979 It's lied to the stl compilation by MSVC (windows, always windows...)
1980 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1982 2004-01-12 Benoit Regrain
1983 * src/*.h : add comments
1984 * src/gdcmDictSet.h : set the method BuildDictPath in public
1985 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
1986 directly setted in the source code
1987 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
1990 2004-01-09 Benoit Regrain
1991 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1992 * setup.py : use a reference to gdcmVERSION
1994 2004-01-07 Benoit Regrain
1995 * Modification to compile with the distutils.
1998 2003-12-10 Benoit Regrain
1999 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2000 can use a gdcmHeaderHelper to load data
2001 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2002 made in the source code
2004 2003-12-10 Benoit Regrain
2005 * Update Windows projects and .cvsignore files
2007 2003-11-12 Jean-Pierre Roux
2008 * ENH gdcmHeader constructor has one more parameter (default value : false)
2009 that allows the user to 'go inside' the SeQuences only
2011 gdcmElValSet:Print takes it into account
2013 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2014 * ENH: Update gdcmPython/CMakeLists
2015 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2016 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2018 2003-11-10 Jean-Pierre Roux
2019 * FIX : gdcmHeader::LoadElements is now based
2020 on the ListTag listElem member,
2021 not longer on the TagElValueHT tagHt member
2022 * ENH : PrintPubElVal shows (temporarily) both results,
2023 with the tagHt member and the listElem member.
2024 (it's easier to 'see' the problems when using Printheader)
2026 * FIX : old private member LgrElem is now splitted into
2027 ReadLength : Length actually found on disk (updated only
2028 if bug fixing is necessary), for internal
2030 UsableLength : Updated by FixFoundLength, to fix a bug
2031 or to allow Parser going on.
2032 Will allow to re-write a kosher header when a SeQuence
2033 with a length (not 0000) is found
2034 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2035 because gdcmElValSet::Add does not update ListElem
2038 2003-11-07 Jean-Pierre Roux
2039 * FIX misstyping in Transfert Syntax name table
2040 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2041 when they have an actual length (not 0000 nor FFFFF)
2042 (Nobody should care of it, but DICOMDIR explorers)
2044 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2045 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2047 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2048 * ENH: vtkGdcmReader now supports LUT !
2049 (vtkgdcmViewer for now is not able to use them though)
2051 2003-11-05 Jean-Pierre Roux
2052 * in testSuite.py : new files names for checking the package
2053 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2054 that returns the pixel area size to the *aware* (vtk) user
2055 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2057 2003-11-05 Benoit Regrain
2058 * in testSuite.py : Modify the rules for checking the paths
2059 : Explicit error messages
2060 * in __init__.py : Related modif
2062 2003-11-03 Jean-Pierre Roux
2063 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2064 to be used by aware (vtk) users that want to manage
2065 LUT (and no to turn the PALETTE image into an RGB pixels one)
2066 * GetPixelType now returns 8U for 24 Bits images
2067 (vtkGdcmReader compliant)
2069 2003-10-31 Jean-Pierre Roux
2070 * Removal of *all* gdcmData images and add them again
2071 in order to loose the 'history' of un-anonymised images
2073 2003-10-31 Jean-Pierre Roux
2074 * RMV : removal of useless jBitsInJsample.h
2075 for both 8 and 12 Bits JPEG Lossy Libraries
2077 2003-10-31 Jean-Pierre Roux
2078 * ENH : Add the functions gdcmFile::GetImageDataRaw
2079 gdcmFile::GetImageDataIntoVectorRaw
2080 that act as GetImageData and GetImageDataIntoVector
2081 except the making of an RGB Plane from Gray Plane + LUT
2082 Intended to aware (vtk) users who know how to manage
2085 GetLUTRGBA return a R,G,B,A LUT if any
2086 lgrTotaleRaw gives the 'Raw' length
2087 GetImageDataRaw returns the gray Plane
2088 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2089 (They stay Grey, just like with other Dicom viewers :-(
2091 2003-10-30 Jean-Pierre Roux
2092 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2094 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2095 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2096 being coherents dicom files.
2098 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2099 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2101 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2102 * ENH: Two steps is necessary to please VC++ compiler...
2103 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2104 * ENH: Add include dir to medcon lib
2105 * FIX: only one function is being exported for now !
2106 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2108 2003-10-29 Jean-Pierre Roux
2109 * adding gdcmHeader::GetLUTRGBA
2110 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2111 --> Mathieu, the modif u're waiting for is not yet committed
2112 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2114 2003-10-27 Jean-Pierre Roux
2115 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2116 00191113.dcm DermaColorLossLess.dcm
2117 MxTwinLossLess.dcm RadBWLossLess.dcm
2118 * ENH: For version prior to vtkImageViewer2 -r 1.19
2119 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2121 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2122 * Removal of ido stuff in CMakeLists.txt
2124 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2126 * FIX: remove a call to ->Modified ... see comments
2127 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2129 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * FIX: Problem with path for libvtkgdcmPython
2131 * ENH: Try adding a search script for python site-package
2132 * RMV: Remove some file from medcon lib that are not necessary
2133 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2134 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2135 * FIX: More pragma disable fro VC++,
2136 I don't think I break something as it is also disable in VTK/ITK.
2137 But it fasten debug compilation time.
2139 2003-10-23 Jean-Pierre Roux
2140 * gdcm now deals with 16 Bits Run Length Encoded images
2141 (they are compressed as 2 planes images,
2142 one for the high Bytes, the other for low Bytes)
2144 2003-10-22 Jean-Pierre Roux
2145 * Now CheckRead takes into account :
2146 - the bugged 'Leonardo' Siemens images
2147 - the XA images, sent thru the burning VPRO station
2148 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2151 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * FIX: When copying a Makefile.am to CMakeLists.txt
2153 one should remove the '\'
2155 2003-10-22 Jean-Pierre Roux
2156 * in gdcmData adding a bugged 'Leonardo' Siemens image
2157 (wrong lengths in header)
2158 OK with gdcm, KO with the other viewers :-)
2159 * add a GE dlx XA image, thru the VEPRO burning station
2162 2003-10-21 Jean-Pierre Roux
2163 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2164 for a brutal checking of vtkgdcmViewer compliance
2166 2003-10-21 Jean-Pierre Roux
2167 * add the files for 'xmedcon' Jpeg Lossless library
2168 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2170 2003-10-21 Jean-Pierre Roux
2171 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2173 2003-10-21 Jean-Pierre Roux
2174 * garbage Siemens 'Leonardo' images dealt with
2175 (the patch is easy to remove)
2176 * cosmetic changes to avoid warnings
2178 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2180 no need to press 'r' now.
2182 2003-10-20 Jean-Pierre Roux
2183 * upgrade of checkRead.sh checkWrite.sh according
2184 to new Jpeg Lossless decompressor
2185 * add US.3405.1.dcm, a genuine RGB medical file ...
2186 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2187 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2189 2003-10-15 Jean-Pierre Roux
2190 * general anonymisation in gdcmData
2191 * adding the 'color files' from
2192 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2193 * adding some well knowed bugged-header images
2194 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2195 waiting for their inclusion in Python testsuite
2197 2003-10-15 Jean-Pierre Roux
2198 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2199 no longer seg faults when file is not found
2201 2003-10-14 Jean-Pierre Roux
2202 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2205 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2206 * TODO: *.in file to genereate a UseGDCM later
2208 2003-10-14 Jean-Pierre Roux
2209 * Some supposed-to-be Dicom Images have no preamble.
2210 OpenFile takes it into account
2211 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2212 * Missing elements added in dicomV3.dic
2213 (just to be affraid : have a look at
2214 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2215 and do it again next year ;->
2217 2003-10-13 Jean-Pierre Roux
2218 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2219 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2220 But there are NOT. It's fixed !
2222 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2223 * FIX: "jpeglib.h" was not found on VC++
2224 * FIX: vtkgdcm was not being installed
2226 2003-10-10 Jean-Pierre Roux
2227 * ENH : OpenFile closes the file if it *really* doesn't look like
2228 an ACR-NEMA / DICOM one.
2229 * FIX : testWrite no longer writes an empty file if the source file
2230 is not gdcm Readable
2231 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2234 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * FIX: CMake generate now documentation
2236 * ENH: out of source doc build !
2237 * ENH: Generate both user and dev documentation
2238 * ENH: Should work on windows too
2239 * ENH: Only one doxygen config.in file is needed
2240 * FIX: make install should be ok now on ùnix plateform
2241 * FIX: PATH to dictionary was wrong (missing /)
2242 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2244 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2245 * vtkGdcmReader is now able to read rgb dicom file.
2246 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2247 * added a gdcmViewer to vtk test, use mouse to control
2248 window level & window width
2250 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * CMake-ification of gdcm, we have now two build system
2252 * FIX: on cygwin Wsock32 doesn't exist
2253 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2255 2003-10-06 Emanuel Ollart
2256 * FIX : compilation process wad broken.
2257 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2259 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2260 * change gdcmViewer -> vtkgdcmViewer
2261 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2263 2003-10-06 Jean-Pierre Roux
2264 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2265 ( e.g : well known GE images with a wrong elem length,
2266 : Philips MRI Images with a wrong Huffman table)
2267 * still to be done : allow the reading of bugged LEONARDO Siemens images
2269 2003-10-03 Jean-Pierre Roux
2270 * Odd length strings are padded with '\0' (not with spaces,
2271 to remain compliant with already defined strings,
2272 like Transfert Syntax UID and others)
2274 2003-10-03 Jean-Pierre Roux
2275 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2276 to allow displaying RGB images (not only by affim ;-)
2278 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2279 * vtkGdcmReader is now able to read rgb dicom file.
2280 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2282 2003-10-03 Jean-Pierre Roux
2283 * A few nasty patches to allow the reading of a lot of nasty images
2284 ( e.g : well known GE images with a wrong elem length,
2285 : Philips MRI Images with a wrong Huffman table)
2286 * still to be done : allow the reading of bugged LEONARDO Siemens images
2288 2003-10-03 Jean-Pierre Roux
2289 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2291 2003-10-03 Jean-Pierre Roux
2292 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2293 to allow displaying RGB images (not only by affim ;-)
2295 2003-10-03 Jean-Pierre Roux
2296 * gdcmFile::GetImageDataIntoVector now
2297 - deals with MultiFrames MultiFragments Run Length Encoded files
2298 - deals with YcBcR (YBR_FULL) files
2299 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2300 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2302 (no sample found :-(
2304 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2305 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2306 Two reasons: - clear things
2307 - third parties acces gdcm through header files, so won't
2308 suffer anymore VC++ complains
2310 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2311 * add argv[1] in testvtkGdcmReader.cxx
2314 2003-09-24 Jean-Pierre Roux
2315 * The lines are now eigthy characters long.for
2316 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2318 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2319 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2320 char* to std::string. Thus, the use of strdup becomes useless. (see
2321 previous commis of Malaterre)
2322 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2323 before the last Malaterre's commit.
2325 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2326 * This commit should fix the Debug building under VC++, the problem
2327 was mainly a mixture of debug and release lib being loaded at startup.
2328 * I also remove a depency to a specific C function: strdup. Because I had
2329 to force the link to msvcrtd (whereas strdup is in libc).
2331 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2333 located in the gdcmCommon.h file. All use of reference of tha has been
2334 changed to now use the variable GDCM_UNFOUND.
2336 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2338 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2339 Dicom dictionary. The test suite can now be run again. Note:
2340 I'm note very happy with the " (RET)" changes. I believe this
2341 RETAINED comment should be dropped when parsing the dictionary.
2342 - PACKAGER corrected
2344 - AUTHORS updated and now in alphabetical order
2345 * Makefile.am now exports gdcm.dsw for Windoze users.
2347 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2348 * cygwin complains about missing std:: in subdir Test/
2350 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * remove some methods that are now in gdcmHeaderHelper
2353 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * vtkGdcmReader set spacing and origin correctly
2356 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2357 * Fix a few delete/delete[] mismatch
2359 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2360 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2361 interpretation to data given by gdcmHeader. For instance there are
2362 heuristics to get informations (look at different places).
2363 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2364 sorting DICOM images based on different strategies.
2365 * modified Makefiles accordingly.
2367 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2369 when building in debug mode
2370 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2371 src/win32/gdcmdll.dsp
2372 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2374 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2378 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * src/win32/libgdcmjpeg12.dsp was not dos format
2380 * src/win32/libgdcmjpeg12.dsp :
2381 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2382 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2384 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2385 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2387 * src/gdcmFile.cxx : bug fix in affectation type
2388 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2389 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2390 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2391 symbols... future problem ?
2393 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * src/win32/libgdcmijpeg12.dsp was missing
2395 * modified gdcm.dsw accordingly
2397 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2400 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2401 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2402 commit of JPR (before his hollidays to facilitate our work).
2403 * setup.py : bug fix in code. Modifications made while the last commit
2404 of JPR. The code hasn't been tested before the commit... it's so
2405 useless to make that (for best programmer that is JPR) !!!
2407 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * tagged the current version as Version0_3 (i.e. version 0.3)
2410 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2411 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2412 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2413 * *.dsp : modifications to use new libgdcmijpeg8 library
2414 * setup.py : bug fix on VTKPATH variable
2415 * PACKAGER : adding all concerning windows
2417 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2420 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2421 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2422 test suite reported error.
2423 * PACKAGER file added (describes what a packager must do when
2424 packaging a new release).
2425 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2426 * configure.in: upgraded version number to 0.3.0
2427 * fixing build of rpm (through rpm -ta):
2428 - Doc/Makefile.am exports proper doxygen files
2429 - src/jpeg/libijg8/Makefile.am exports the include files.
2431 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2432 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2433 * src/gdcmHeader.h : formatting code
2435 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2436 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2437 We were obtaining error message from vtk. Now, creation of file list
2438 is made in an internal list to prevent this problem.
2439 Bug fix when output is empty.
2440 Bug fix in update of progress value. Previous commit for this was a bad
2442 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2444 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2445 * src/gdcmHeader.h : added method to get the file name
2446 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2447 files. Added method to remove all files on the input
2448 Added FIXME comment concerning the bad parsing of header made by
2449 ExecuteInformation method (in ExecuteData method)
2451 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2453 when using make instal.
2454 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2455 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2457 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2458 * setup.py : adding include dir of jpeg lib to compile all sources
2459 * */Win32/*.dsp : JPR fix for windows compilation
2461 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2462 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2464 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2465 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2467 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * setup.py is again effective on un*x (takes into account the
2469 addon of the jpeg library)
2470 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2471 * Doc/Doxy* updated (includes above enhancements)
2472 * INSTALL now points to web documentation
2474 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * src/gdcmHeader.h doesn't make unnecessary reference to
2477 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2479 * src/gdcm*.[cxx|h] :
2480 - to allow compilation with gcc 3.x
2481 -- clean up of STL usage (added explicit usage of std::)
2482 -- small fixes on exceptions.
2483 Note: linking not tested !
2484 - clean of doxygen comments to avoid warnings at documentation
2486 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2487 dependent convertion).
2489 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2490 * Clean up of previous JPR garbage commit (not even commented in the
2492 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2493 - moved all jpeg related files from src to src/jpeg/libijg8, with
2494 addition/modification of Makefile.am and configure.in.
2495 - the testSuite is still brain damage (not guilty).
2497 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2498 * WrapVTK.py : modifications to get correctly vtk source files to
2500 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2501 (FileName -> Filename)
2503 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * vtk/vtkGdcmReader.[cxx/h]:
2505 - UpdateProgress method should now be effective
2506 - removed the limitation on having only images loaded (as opposed
2508 - when building a stack of images/volume, a lesser number of
2509 gdcmHeader and gdcmFile instances should be used (hopefully
2510 accelerating things).
2511 - when building a stack of images/volumes, files which are not
2512 loadable (wrong path-filename, wrong permissions on existing file,
2513 or file not parsable by gdcm) are replaced with a black image
2514 in the stack (for the caller to notice the problem).
2516 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2519 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2520 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2521 between standard library (std) and vtk library (problems are found
2522 under Windows... thanks Windows !)
2524 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2527 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2529 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2532 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2533 * When compiling with distutils (see setup.py) the C++ compiler is
2534 called with different flags than the default ones (with automake).
2535 In order to fix all those warning, I compiled gdcm with the command
2536 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2537 and went for warning fixes:
2538 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2539 up from unused variables.
2540 - vtk/vtkGdcmReader.cxx: potential bug fix.
2541 * src/gdcmHeader.h: Doxygen warning cleanup
2543 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * gdcmPython/gdcm.i:
2545 - typemaps correction to take into account the systematic replacement
2546 of "using namespace std" with std:: prefix e.g. std::list,
2547 std::string... (cf changes of 2003-05-21).
2548 - gdcmGlob global variable of type gdcmGlobal (defined in
2549 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2550 exported to Python a as cvar.
2551 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2552 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2553 gdcmDictSet.GetPubDictTagNames() and
2554 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2555 C++ static methods).
2556 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2557 with the above changes.
2559 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2560 * setup.py, manifest.in : bug fix under linux
2562 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2563 * Modification of setup.py to compile vtk part too. Then, we have 2
2564 wrappers which must work with same distutils. For that, we have a
2565 generic distutils in distusiltsWrapping.py ; with :
2566 - build_extWrap class to wrap generically all extensions,
2567 - ExtensionWrap base class for all wrapping extension that contains
2569 - Wrapper interface which wrap sources
2570 + In WrapSwig.py we have extension and wrapper for Swig
2571 + In WrapVTK.py we have extension and wrapper for VTK
2572 * MANIFEST.in : modifications to consider vtk directory and new python
2573 files for compilation
2575 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2576 * Added python wrappers of vtkGdcmReader vtk class (see the
2577 source in vtk/vtkGdcmReader.cxx) :
2578 - vtk/Makefile.am now builds a library
2579 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2580 python library (as opposed to _gdcm.so wich are the python
2581 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2582 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2584 - configure.in has an additional flag --enable-vtk that needs
2585 to be set to enable compilation of vtk related code, that is:
2586 + vtk/vtkGdcmReader.so and
2587 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2588 + gdcmPython/vtkgdcmPython.so (see above)
2589 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2590 be read when compressed or when HighBit + 1 != BitsStored),
2591 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2592 the usage of the python wrapper of vtkGdcmReader vtk class.
2593 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2594 * src/*.[h] all occurences of stl classes are now prefixed with
2595 std::, and all occurences of "using namespace std;" where removed.
2596 This is to avoid pollution of global namespace in included files.
2597 Apparently vtk does not avoid this pitfall: when using both
2598 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2599 collision of various stl members (principally cout...).
2600 * gdcmPython/testSuite.py now cleanly removes temprory generated
2602 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2603 comply with above changes)
2605 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2606 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2607 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2608 vtk data structure (an image Flip was required).
2609 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2610 * cosmetic changes in documentation.
2612 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2613 * src/gdcmHeader.cxx: the constructor no longer exits when an
2614 unexisting file is given as argument.
2615 * The subdirectory Data (containing all the images used for the
2616 test suite) is not part of this repository anymore. A new module
2617 containing those images is now available at
2618 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2619 with the name gdcmData.
2620 All the python scripts (including the package initialisation file
2621 gdcmPython/__init__.py) were adapated to take this change into
2622 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2624 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2625 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2626 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2627 demo of the usage of this class.
2628 Compilation of this vtk part is only done when using the --enable-vtk
2629 at configure (or autogen.sh) stage.
2631 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2632 * More memory link related corrections and documentation fixes.
2634 - maximum info is obtained with a command of the form:
2635 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2636 --show-reachable=yes PrintHeader
2637 - the remaining reachable blocks seem to come from the STL
2638 allocation scheme through the usage of map and list. It looks
2639 like this memory cannot be freed but it is not a memory leak
2640 (in fact further invocation to the STL would recollect the
2641 unused memory allthough it cannot explicitely be freed).
2642 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2643 of displaying an image parsed with gdcm and displayed with VTK.
2644 Note: some images don't seem to work e.g.
2645 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2646 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2647 Allthough this weakens the semantics, it is a ditch attempt to
2648 make gdcm more thread friendly.
2650 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2651 * Memory link hunt (by using valgrind through the command
2652 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2653 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2654 gdcmHeader::_dicom_vr.
2655 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2656 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2658 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2660 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2661 * src/Makefile.am now exports all the necessary include files at
2665 * UpdateGroupLength replaced by new one
2668 * UpdateGroupLength re-written using H-Table
2669 (named UpdateGroupLengthNew untill checks are over)
2671 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2672 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2673 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2675 - gdcmHeader::GetPubElValSet removed.
2676 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2677 UpdateGroupLength, WriteElements, Write.
2678 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2679 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2680 carried the same semantics.
2681 - src/gdcmHeaderIdo.cxx changed accordingly.
2682 - gdcmFile::WriteBase now regroups all the codes from previous
2683 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2684 - enum FileType moved to gdcmCommon.h
2685 * src/gdcmHeader.cxx AddDefault trashed
2686 * gdcmGetXSize added
2687 * getimageDataSize now calls gdcmGetXSize
2688 * Test/*.cxx changed to agree with above changes
2690 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2692 (to avoid double call by end user).
2693 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2694 by end user, since gdcmHeader::gdcmHeader now handles it.
2696 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * gdcm/Doc many doxygen changes:
2698 - Doxyfile now has two different versions, DoxyfileUsers that generates
2699 the html.users end users oriented documentation and
2700 DoxyfileDeveloppers that generates the html.developper developper
2701 oriented documentation.
2702 - README changed accordingly
2703 - requirement.txt removed (old design info moved to TODO).
2704 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2705 DoxyMainPage.txt, DoxyPython.txt provide more information.
2706 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2707 be updated by simply regenerating the docs with doxygen and copying
2708 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2709 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2710 all the tests in the form "if (<map>.count() >1)" were removed.
2711 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2712 ill-formed documentation sections.
2713 * src/gdcmHeader.cxx: ditto
2715 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * setup.py fixed for un*x (needed macro for stdint.h)
2717 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2718 un*ces with sh-utils test utility.
2719 * gdcmPython/demo/test.py renamed to PrintHeader.py
2720 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2721 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2722 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2723 * src/gdcm*.cxx JPR's bad inclusion fixed.
2725 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2727 * gdcmPython/demo/test.py changed accordingly.
2729 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * gdcmPython/Makefile.am fixed linking against libstdc++
2731 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2732 * Swig subdir (historical tests of swig version 1.3.17++) removed
2733 * Test/testChangeEntete.cxx some lines commented out in order to make
2735 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2736 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2738 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2740 hence the user doesn't need this explicit call.
2741 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2742 i.e. LoadElements() call removed.
2743 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2744 - src/Makefile.am declares the proper flag for g++.
2745 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2746 for adding user defined new tags.
2747 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2748 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2749 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2751 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2752 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2753 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2754 src/Makefile.am : the project should properly compile and install
2755 with the autotools, included the python wrappers part.
2756 * gdcm.spec.in : added a spec file for RPM packaging.
2758 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2759 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2761 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2763 to exported to the environement (see gdcmPython/testSuite.py
2765 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2766 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2767 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2768 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2769 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2771 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * gdcmPython/__init__.py doesn't crash anymore when running in
2773 in InstallMode or PreInstallMode but with an environment given
2774 value of GDCM_DICT_PATH.
2775 * src/gdcmDictSet.[cxx/h] coding style.
2777 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2778 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2779 * src/gdcm.h general comments moved to TODO, and README
2780 * src/gdcm.h should now be seen as a user commodity (including it
2781 should suffice to fully use gdcm). It is nowhere including within
2782 any of the kernel files src/*.cxx and src/*.h.
2784 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2786 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2788 * src/gdcm*.cxx only include their corresponding include file
2789 (as opposed to gdcm.h)
2790 * gdcmPython/gdcm.i changed accordingly
2791 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2792 the autogen.sh generated "make snapshot" command to work.
2793 * autogen.sh removed history related references to crea package.
2795 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * distutilsSwigCPlusPlus.py work around some swig portability
2799 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2801 was done in a last ditch attempt to get setup.py _really_
2802 operationnal. The python/gdcmPython layaout add the advantage
2803 of hidding away the python related distutils specific files
2804 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2805 Alas, the src directory was out of scope (i.e. it's relative
2806 position to setup.py was ../src) which made things impossible to
2807 handle (see previous version of python/setup.py). Crossing fingers...
2809 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * python/setup.py now works on Un*x. (harder than I thougth)
2811 * python/distutilsSwigCPlusPlus.py can now have include files
2812 among the list of sources.
2814 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2815 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2816 * modifications in MSVC projects
2818 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * As stated by the first lines of Test/ExceptionAndPython/README, it
2820 looks like we can move back to original usage of exception within
2821 src/gdcm* and hence remove the errno stuff that was introduced
2822 as a quick and dirty fixture of this problem (added to the TODO).
2823 * Doc/Doxyfile configuration file for Doxygen and corresponding
2824 README file for usage added.
2825 * Test/testWrite.cxx added. This new test comes from a split of
2826 test.cxx that is now reverted to its original purpous i.e.
2827 testing the proper parsing of a Dicom related file.
2828 testWrite.cxx concentrates on testing the IO part of gdcm.
2829 * Test/bug1.cxx (containing a bug on WIn32) added.
2830 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2831 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2832 whose purpose is to publish the content of the TagNames of the
2833 Dicom public dictionary were not accessible without an
2834 instance of class gdcmHeader.
2835 - those methods are now static methods of gdcmDictSet and hence
2836 require no instances at all to be invocated.
2837 - within gdcmDictSet this change required to change some method
2838 to class methods (i.e. are now static) among which SetDictPath
2839 (renamed to BuildDictPath) and LoadDefaultPubDict.
2840 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2841 the above changes by calling the new method classes of gdcmDictSet.
2842 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2843 the above to be effective.
2844 * python/gdcmPython: in order to wrap properly the above changes
2845 for Python, swig version now needs to be > 1.3.17.
2846 * python/gdcmPython/Makefile fixed to adapt itself to new
2847 configure/make shema introduced by Johan Montagnat (thanks for the
2848 contribution). Alas this Makefile cannot be turned into a proper
2849 Makefile.am without some heavy changes in the configure.in
2850 (for python dectection).
2851 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2852 now avoids publishing the empty entries.
2854 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2855 * python/setup.py : bug fix concerning install under windows
2856 ExtraPath reused :-P
2857 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2859 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2860 * Dicts/dicomV3.dic : remove double spaces !!!
2861 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2862 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2865 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2866 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2867 method. Doxygenation.
2868 * src/gdcm.h clean up of JPR spurious comments.
2870 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2871 * python/distutilsSwigCPlusPlus.py now properly collects the
2872 shadow classes generated by "swig -c++" (gdcm.py in our case)
2873 when using "python setup.py install".
2874 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2875 reexports the working classes.
2876 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2877 by the classical C errno scheme. This is to prevent an obscure
2878 behavior of the python wrappers when importing wxPython.wx prior
2879 to gdcmPython (which ended up in an abort call). An illustration
2880 of this oddity can be found in the Test/ExceptionAndPython
2881 subdir (see the README file). This problem probably due to
2882 an combination of g++ and dynamic loading.
2883 * added Test/ExceptionAndPython (see above)
2885 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * Changed the layout of the python part to avoid bloating main
2887 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2888 i.e. the distutils arsenal. All the python related stuff is
2889 again in a python subdir, but the package itself is now in
2891 * setup.py was cleaned up:
2892 - pythonIncludePath removed
2893 - python setup.py bdist target is now functional.
2894 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2895 collision with other packages). gdcmPython/demo/*.py changed
2898 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2899 * python subdir moved to gdcmPython (preparation of distutils packaging).
2900 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2901 distutils installer is operational.
2902 * - gdcmPython/__init__.py now properly loads the swig generated
2903 shadow classes (from gdcm.py).
2904 - gdcmPython/demo/*.py changed to import the package gdcmPython
2905 instead of gdcmPython/demo/load.py.
2906 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2908 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2909 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2910 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2911 entries within the associated public Dicom dictionary resp. the same
2912 information but sorted by the fourth field (PAT, IMG, DIR) of the
2914 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2915 are now in the "???" group.
2916 - python/gdcm.i changed accordingly,
2917 - python/demo/printGroupedPublicDict.py added, that gives an example
2918 of the above new functionalities in Python.
2920 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2921 * src/gdcm.h, gdcmHeader.cxx:
2922 - historic references to glib's g_malloc and g_free (#defined)
2923 were definitively removed.
2924 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2925 * src/gdcmElValSet.cxx:
2926 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2927 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2928 - GetElValue(string) renamed to GetElValueByName.
2929 - Added GetElementByName(string).
2930 * src/gdcmHeader.cxx: added
2931 - GetPubElValRepByNumber(guint16, guint16)
2932 - GetPubElValRepByName(string)
2933 - GetShaElValRepByNumber(guint16, guint16)
2934 - GetShaElValRepByName(string)
2935 - GetShaElValByNumber(guint16, guint16)
2936 - GetShaElValRepByName(string)
2937 - GetElValRepByNumber(guint16, guint16)
2938 - GetElValRepByName(string)
2939 - GetElValByNumber(guint16, guint16)
2940 - GetElValRepByName(string)
2941 * Doc/requirements.txt added.
2943 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * Test/Makefile building now depends on the one of libgdcm.so
2945 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2946 pixel data) aware which enables finding the address (offset) of
2947 the pixel data of JPEG encoded DICOM files. This leaves only a single
2948 file in the testSuite whose pixel data address (offset) is unknown.
2949 * python/testSuite.py changed accordingly.
2951 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2952 * VC++ has some strong limitations when working with the STL, as stated
2953 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2954 "Also note that some STL containers (map, set, queue, list, deque)
2955 cannot be exported. [...]
2956 Some STL classes contain nested classes. These classes can not
2958 This is caused by a designed limitation that once a template
2959 class is instantiated, it can not be re-instantiated and
2961 Since our usage of map<> is ubiquitous in gdcm, this "designed
2962 limitation" of VC++ is a pitfall.
2963 Hence the Python wrappers of gdcm cannot be incrementally linked
2964 against the c++ dynamic library. The dirty but only workaround is
2965 to forget about incremental link of dynamic libraries and to generate
2966 the Python wrappers library with the inclusions of the underlying C++
2968 The following modifications concern this matter on Win32/VC++:
2969 - wrapping python correct with standalone wrapped dll (don't use separate
2970 dll under windows !!!!)
2971 - python21_d debug mode enabled (ask Frog how to use it :-)
2972 - NO problem with having an STL member of class for example string in C++
2973 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2974 - Python test of dcmlib in Python is ok under windows on a large set
2976 * removed glib references
2977 * typedef's inserted in gdcm.i for correct swig type management
2979 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2980 * python/demo/*.py load.py extracted from test.py. Added explore.py
2981 that only displays required tags and testAll.py that parses all
2982 the files of the testsuite without using unittest.
2983 * python/testSuite.py other additional test on new files added.
2984 * Data/* new test files added accordingly to the testSuite.
2985 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2986 the vr in the file differs from the one of the dictionary.
2988 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2990 values, but limits itself to values which are below a user specified
2991 size (by default 1024 bytes).
2992 * python/gdcm.i : elements not loaded (because their size is above the
2993 user specified treshold) are exported with their TagKey as key of the
2994 python dictionary. This enables the testsuite to make some checks
2995 on the unloaded elements (since we have their offset and size).
2996 * python/testSuite.py
2997 - now tests for the existence and proper value of the pixel data
2998 - two new examples added.
2999 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3001 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3002 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3003 aware. See the strategy comments in gdcmHeader::FindeLength().
3004 * Test/test.cxx now accepts a filename as first argument.
3005 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3006 * python/testSuite.py changed to integrate test on above files.
3008 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3010 the vr was also RET.
3011 * python/testSuite.py more tests added.
3013 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * python/testSuite.py unittest test suite added (uses Data)
3015 * Data/* dcm and acr files for the test suite.
3016 * glib dependance removed from un*x version. We now use ISO C99
3017 7.18 Integer types (see stdint.h)
3018 - python/Makefile, src/Makefile src/gdcm.h
3019 * src/ when an explicit vr (like dicom files) suddenly poped an
3020 implicit element we use to mark the underlying DictEntry of the
3021 concerned ElValue with "Implicit". This strategy was damageable
3022 too the public or provite dictionaries, since some of their vr
3023 would be changed. Since Header::FindLength heavily relies on the
3024 detection by Header::FindVR of falsely explicit elements, I
3025 added an extra ImplicitVr member to ElValue (boolean).
3026 The rest of the changes we the necessary adaptations.
3028 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3031 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3033 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3034 * Adaptation for porting to VC++:
3036 o forced to use std namespace (for string to be known)
3037 o all class use __declspec export style on WIN32
3038 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3039 (in stdlib.h on Win32 but in std:: for gcc)
3040 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3041 variable GDCM_DICT_PATH.
3042 * src/gdcmHeader.cxx verbose comments made discrete.
3044 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * python/gdcm.i: added a typemap that converts a C++ hashing table
3046 to native Python dictionary.
3047 * python/demo/test.py:
3048 - now uses the native dictionary for exploration of gdcmHeader.
3049 - takes an optional filename argument (the file to parse).
3050 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3051 PubElVals hashing table.
3052 * Dicts/dicomV3.dic removed error prone trailing spaces.
3054 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * Python wrapping process moved away from src/Makefile to
3056 newly created python/Makefile (as well as gdcm.i)
3057 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3058 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3059 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3060 from the environement variable GDCM_DICT_PATH (when existing).
3061 * src/gdcmDict::GetTag bug fix.
3063 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * Straightforward temporary fixes for swig to build the python wrappers.
3065 src/Makefile now has a python working entry [by working we mean
3066 that we can import de shadow classes without errors].
3068 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * hashtest.cxx removed (since already in Test)
3070 * src/gdcmlib.h renamed to src/gdcm.h
3071 * src/dcm.i renamed to src/gdcm.i
3072 * src/Makefile prepared for python wrapping
3074 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * src/gdcmHeader.cxx :
3076 - Parsing of header is now separated from loading of element values
3077 (see gdcmHeader::LoadElements).
3078 - general clean up of hopefully all file access (creation of
3079 ReadInt16 and ReadInt32)
3081 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * src/gdcmHeader.cxx :
3083 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3085 - SetLgrElem renamed to SetLength
3086 - GetLgrElem renamed to GetLength
3087 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3088 * src/gdcmElValSet.cxx fixed both GetElValue methods
3089 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3090 due to IdoDude was cleaned out.
3092 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3094 concentrates on finding the value representation (when it exists).
3095 RecupLgr now only finds the element value length, and it avoids
3096 returning the unecessary skL (skipped length).
3097 Also, offsetCourant was simply removed (with taille_fich) since
3098 it was redundant with the File position internals (by using
3099 ftell and fseek). This also made skL (see above in RecupLgr) usage
3101 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3102 on the libido specificities which are handled through class
3104 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3107 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3108 * Truckload of changes. Parsing of header is barely functional
3109 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3111 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3112 * src/gdcmHeader.cxx many addons of low level methods
3114 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3116 and _IdDcmSWAP_LONG.
3118 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3119 * This corresponds to all the changes decided at the meeting of
3120 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob