1 Mon Oct 18 10:27:49 2005 by regrain
2 * Minor coding-style clean up
3 * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
4 by the DataEntry. This unique entry considers all datas like binary datas.
5 Some methods are added to interpret - at fly - the binary datas.
6 Due to this important change, some methods of the DocEntrySet, concerning
7 the BinEntry and ValEntry classes, are erased ; and new methods for the
8 DataEntry class are created.
9 Some methods to set the ValEntry or the BinEntry are renamed to
10 correspond to the new DataEntry, like for example :
11 - SetValEntry -> SetEntryString
12 - SetBinEntry -> SetEntryBinArea
13 This change will remove all useless creation of the string when working
16 Thu Aug 25 16:59:49 2005 by jpr
18 Now Print displays the BinEntry Content (if it's printable, and loaded)
19 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
21 Appreciate the difference having a look at PrintFile result for
22 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
24 Thu Aug 25 16:55:47 2005 by jpr
26 Add methods to check the 'printability' of a bin area
28 Thu Aug 25 15:45:40 2005 by jpr
30 According to Mathieu's suggestion, Print now display FL BinEntries in a human
33 Thu Aug 25 15:12:43 2005 by jpr
35 According to Mathieu's suggestion, *all* the elements 0x000
36 are now named 'Group Length' (even if they belong to a Shadow Group')
38 Wed Aug 24 14:09:13 2005 by jpr
39 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
40 Removal of QD patch for Private Sequence + Immplicit VR.
41 Add a clean solution (Backtracking if an Item Starter is found
44 Tue Aug 23 14:57:49 2005 by jpr
46 Brutal patch, waiting till we find a clever way to guess
47 if a doc entry is a Sequence,
48 - when it's odd number
49 - and the file is Implicit VR Transfert Syntax
50 It solves temporarily some Philips Medical Systems image problems
52 Mon Aug 22 18:17:54 200 by jpr
54 Save a *few* microseconds at run time : inline method Util::GetVersion()
57 Tue Aug 23 14:58:49 2005 by jpr
58 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
59 Improve 'Print' methods
61 Sat Aug 20 11:10:24 2005by jpr
63 Use new style FileHelper contructor
65 Sat Aug 20 11:04:50 2005 by jpr
67 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
68 in order not to do the job twice when using new style FileHelper Constructor.
70 Fri Aug 19 18:31:07 2005 by malaterre
72 ENH: Provide a GetVersion function, apparently need for python
74 Fri Aug 19 15:12:15 2005 by jpr
76 Initialize UserFunction pointer to 0, even for 'deprecated' form
79 Sat Jul 30 20:27:00 2005 by jpr
80 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
81 User is now allowed to pass a Pointer to a function of his own
82 to allow modification of pixel order (i.e. : Mirror, TopDown, )
83 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
84 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
85 NB : the "uint8_t *" type of first param is just for prototyping.
86 User will Cast it according what he founds with f->GetPixelType()
87 See ctkgdcmSerieViewer for an example
89 Sat Jul 30 20:13:24 2005 by jpr
91 Add SerieHelper::IsCoherent() method to allow checking that the files with same
92 Serie UID have the same sizes and pixel type.
94 Fri Jul 29 17:07:16 2005 by jpr
97 SetSortOrderToDirect() or SetSortOrderToReverse()
98 to choose the ways the File* will be sorted.
100 Thu Jul 21 06:55:50 2005 by jpr
101 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
104 Thu Jul 21 06:55:30 2005 by jpr
106 Add an example of use for SerieHelper
108 Thu Jul 21 07:00:15 2005 by jpr
110 Extend 'Restriction' syntax :
111 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
112 std::string const &value, int op)
114 /// \brief comparaison operators
124 Wed Jul 20 15:39:00 2005 by jpr
126 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
127 (e.g. Private entries when the TS is Implict VR)
128 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
129 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
131 Wed Jul 20 16:49:41 2005 by jpr
133 Use GDCM_LEGACY for DicomDir, as well
135 Wed Jul 20 15:31:01 2005 by jpr
137 We can now anonymize 'BinEntries' as well
139 Wed Jul 20 15:29:42 2005 by jpr
141 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
142 16, written in hexadecimal.
143 (usefull to allow terminal user to pass the (private) elements he wants to
146 Tue Jul 19 17:25:53 2005 by jpr
148 Add some comments on the 'Patient Position'
150 Tue Jul 19 11:04:58 2005 by jpr
152 Add SerieHelper::AddGdcmFile(File *header) method.
153 * \brief add a gdcm::File to the first (and supposed to be unique) list
154 * of the gdcm::SerieHelper.
155 * \warning : this method should be used by aware users only!
156 * User is supposed to know the files he want to deal with
157 * and consider them they belong to the same Serie
158 * (even if their Serie UID is different)
159 * user will probabely OrderFileList() this list (actually, ordering
160 * user choosen gdm::File is the sole interest of this method)
161 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
162 * vtkGdcmReader parsing twice the same files.
163 * *no* coherence check is performed, but those specified
164 * by SerieHelper::AddRestriction()
166 Mon Jul 18 12:20:20 2005 by jpr
168 In order to prepare the future extension of SerieHelper::AddRestriction (key,
170 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
172 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
174 Sun Jul 17 06:27:49 2005 by jpr
176 Use new style for Loading files
178 Tue Jul 12 19:08:12 2005 by jpr
179 gdcmCommon.cxx, gdcmSQItem.cxx
180 To speed up DicomDir, instead of copying -and removing the source afterwards-
181 each entry of the SQItem (found after gdcm::Document parsing) towards
182 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
183 the chained list itself.
185 Tue Jul 12 16:55:43 2005 by jpr
187 AnonymizeNoLoad has now one more option :
189 to give the (single Patient) directory name whose content we want to anonymize.
191 Mon Jul 11 10:20:25 2005 by jpr
192 gdcmDicomDirStudy.cxx
195 Fri Jul 8 21:07:12 2005 by jpr
197 Add the VISIT object within DicomDir
199 Fri Jul 8 12:15:08 2005 by jpr
201 Use new style for DicomDir loading
203 Fri Jul 8 16:36:48 2005 by jpr
205 To remain unimpared, gdcm::FileHelper class needs also its
206 void FileHelper::SetLoadMode(int loadMode)
207 void FileHelper::SetFileName(std::string const &fileName)
208 bool FileHelper::Load()
210 Thu Jul 7 19:31:53 2005 by jpr
212 Begin of kosherization of Example
215 Thu Jul 7 18:37:40 2005 by jpr
217 On the way to gdcm2 ...
218 Now, the stand way to use a file is :
219 gdcm::File *f = new gdcm::File();
220 f->SetLoadMode ( user say here what he wants *not* to load );
221 f->SetFileName("myFile.gdcm");
223 Old styles are kept, not to break the C++ API.
224 - gdcm::File *f = new gdcm::File("myFile.gdcm");
225 - f->Load("myFile.gdcm");
226 Due to the syntaxic abilities of Python maybe some troubles will occur
229 Thu Jul 7 15:55:39 2005 by jpr
231 Comment out the time consuming, never used/useless
232 'Extended tag' stuff for Sequence embedded Entries
234 Thu Jul 7 15:11:38 2005 by jpr
236 Move code lines LTTG so save some CPU time.
239 Tue Jun 7 13:12:10 2005 CEST by jpr
241 Use Argument Manager in 'utilities'
243 Thu Jul 7 12:12:32 2005 by jpr
245 Due to something stupid in the gdcm::File constructor, the file was parsed
246 twice when we used old style, e.g :
247 gdcm::File *f = new gdcm::File(fileName);
248 instead of new style, e.g. :
249 gdcm::File *f = new gdcm::File( );
250 f->SetLoadMode ( choose what you want *not* to load here );
253 Wed Jul 6 11:53:43 2005 by jpr
254 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
255 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
256 param, in order not to have to recompile to gdcm::Debug::DebugOn().
258 Wed Jul 6 17:18:42 2005 by jpr
260 According to Mathieu's requirement, Load twice the same file keeps the rseult of
261 the first Load (instead of doing it twice)
263 Wed Jul 6 11:25:12 2005 by jpr
265 - Clean out the Entries if a Document is parsed more than once
266 - Uncomment (usefull) warning messages
268 Wed Jul 6 10:42:33 2005 by jpr
270 - Comment out a for the moment too much verbose warning message.
271 - Delay some statement as late as possible, to save some CPU time when they're
274 Wed Jul 6 13:01:08 2005 by jpr
276 Now gdcmFile::Load() returns false if file is not gdcm parsable
277 Only gdcmDocument::Load() did it, before.
278 Thx to Benoit for reporting bug
280 Sun Jul 3 14:42:04 2005 by jpr
282 Should avoid some troubles with 'no length' SQItems within 'true length'
284 Thx to Loic Boussel for providing data to fix the bug.
286 Sun Jul 3 14:42:04 2005 by jpr
288 Should avoid some troubles with 'no length' SQItems within 'true length'
290 Thx to Loic Boussel for providing data to fix the bug.
292 Sun Jul 3 14:47:23 2005 by jpr
296 Fri Jul 1 13:25:51 2005 by jpr
297 gdcmPixelReadConvert.cxx
298 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
299 (e.g. PrintFile on a DICOMDIR document)
301 Thu Jun 30 16:49:02 2005 by jpr
303 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
304 Boussel's Hall of Shame Dicom images
306 Wed Jun 29 17:58:33 2005 by jpr
308 Add the NO_SHADOWSEQ load mode
310 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * Quite a few new dictionaries were added in gdcm. The file:
312 gdcm/Dict/README should always explain were the info was found
313 (in case of double check). Also some dict are still only
314 express as 'template' (they contain 'xx'), therefore
315 a python script should be run first to generate a full dict.
316 In the longer term this python script should be replaced by
319 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
320 * dicomV3.dic is deprecated in favor of gdcm.dic
321 There is now a dictionary per family:
322 - dicomV3.dic -> DICOM V3
323 - Papyrus.dic -> Papyrus
324 - NIH.dic -> tags that were never allowed in the main standard
326 Fri Jun 24 12:50:20 2005 CEST by jpr
328 Pixel Spacing related problems : update comments.
329 Thx to D. Clunie for providing data to check the code
331 Fri Jun 24 12:55:58 2005 by jpr
332 Summer nights are really too hot to sleep.
333 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
335 Thu Jun 23 11:20:23 2005 by jpr
337 Extend warning message, for debugging purpose
339 Wed Jun 22 10:11:23 2005 by jpr
343 Wed Jun 22 10:00:29 2005 by jpr
344 gdcmPixelReadConvert.cxx
345 Fix misstyping, while removing spurious \t characters
347 Wed Jun 22 09:52:32 2005 by jpr
348 gdcmPixelReadConvert.cxx
349 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
351 That break at lot of viewers ...
352 We now *propagate the sign bit* upon the unused ones, better than masking them
354 Thx to Luca Picello for profiding data to fix the bug
356 Wed Jun 22 09:53:52 2005 by jpr
358 gdcm images are now "GDCM 1.1" built.
360 Mon Jun 20 19:10:17 2005 by jpr
362 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
364 Mon Jun 20 17:58:53 2005 by jpr
366 Preventive bug fix for LUT Data.
367 I said : LUT Date, *not* Palette Color
369 Sun Jun 19 17:57:29 2005 by jpr
371 To avoid warnings at compile time
373 Fri Jun 17 14:27:52 2005 by jpr
377 Fri Jun 17 14:36:07 2005 by jpr
381 Fri Jun 17 14:35:00 2005 by jpr
383 Add some accessors for debugging purpose
385 Tue Jun 14 15:56:41 2005 by jpr
386 gdcmPixelReadConvert.cxx
387 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
388 (3 * 65536 short int ...)
390 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
392 Mon Jun 13 17:43:48 2005 by jpr
393 gdcmPixelReadConvert.cxx
394 Some more oddities dealt with.
395 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
396 Still looking for accurate info on the web about it
398 Fri Jun 10 16:05:38 2005 by jpr
400 Bug fix in Load method.
401 Thx to Benoit for providing fix.
402 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
404 lantency with the Util::Format function
406 Tue Jun 7 15:48:35 2005 by jpr
408 The highy time consuming method GetMacAdress is now called just once
410 Tue Jun 7 11:58:29 2005 by jpr
411 gdcmDicomDirElement.cxx
412 Use TranslateToKey better than Format
414 Tue Jun 7 12:07:20 by jpr
416 Remove some spurious calls to Format
417 // according to 'Purify', TranslateToKey is one of the most
418 // time consuming methods.
419 // Let's try to shorten it !
421 Mon Jun 6 14:37:58 2005
422 class ArgMgr (for Arguments Manager) is designed for
423 command line arguments management
424 (to make programmer's live easier)
425 (could be used for any kind of 'command line program')
427 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
428 * Adding users file in CVSROOT for mail blaming
430 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
431 * Adding potential support for JPEG-LS DICOM files.
433 Fri Jun 3 18:05:23 2005 by jpr
435 Fix VR processing, to be CP-288 conform.
436 Now we can parse any kind of DICOM SR.
438 Fri Jun 3 11:05:15 2005 by jpr
442 Thu Jun 2 15:42:18 2005 by jpr
444 Add warning about Load Mode
446 Thu Jun 2 16:20:14 2005 by jpr
448 Harden gdcm::File::IsReadable(), in order not to be confused any longer
449 by lost of Pixel Element
451 Fri May 27 12:51:00 2005 by jpr
453 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
455 And avoid some memry leaks -hope so-
457 Wed May 25 14:54:17 2005 by jpr
459 Should avoid some memory leaks
461 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
462 * Adding potential support for mpeg and jpeg2000 through two new lin
463 - JasPer for JPEG2000
464 - libmpeg2 from the MPEG consortium
465 Also adding intial work to use this lib.
467 Fri May 20 10:27:55 2005 by jpr
470 (this time, it's wasn't dangerous at run time)
472 Thu May 19 17:31:21 2005 by jpr
474 FIX possible troubles when checking
475 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
476 Thx to Mathieu for reporting bug
478 Wed May 18 12:12:07 2005 by jpr
480 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
481 Thx to Dennis Hu for providing a sample image to fix the bug.
483 Tue May 17 14:44:09 2005 by jpr
485 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
486 before 'Pixel Spacing', when we want to get X or Y Spacing.
488 Tue May 17 19:10:49 2005 by jpr
490 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
491 at LTTG (Least Time To Go)
492 around Bits Allocated, Bits Stored, High Bit Position,
493 to avoid unaware user to mess up the stuff.
495 Tue May 3 11:43:04 2005 by jpr
497 Load returns now a bool (allow user not to call IsReadable() )
499 Tue May 3 11:51:06 2005by jpr
501 Now the gdcm::File remains unimpaired after writting, in any case
503 Fri Apr 29 17:10:55 2005by jpr
505 Don't abort the prog when File not open
507 Wed Apr 27 12:00:35 2005 by jpr
509 Removal of now useless lut-related stuff
511 Wed Apr 27 11:52:27 2005 by jpr
513 Pb of 'Bits Allocated = 12' is now dealt with in
514 FileHelper::CheckMandatoryElements, no longer in File::Write.
515 Thx to Mathieu for reporting bug.
517 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
521 Tue Apr 26 18:18:23 2005 by jpr
523 Should leave gdcm::Document constructor in a much quicker
524 and much cleaner way when anything wrong occurs.
526 Tue Apr 26 18:25:49 2005 by jpr
527 gdcmPixelReadConvert.cxx
528 Prepare MPEG Dicom encapsulated processing (within a loooong future)
530 Fri Apr 22 14:59:58 2005 by jpr
532 Modify Print() output
534 Fri Apr 22 15:37:57 2005 by jpr
536 Prepare (future) MPEG integration
538 Thu Apr 21 09:40:00 2005 by jpr
540 Taking into account Dicom MPEG
542 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
543 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
544 But this is a case where we should really signify the user there is
545 few chance the serie is really a serie...
547 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
548 * FIX : on X, the python part is correctly installed. All files are
549 installed in gdcm sub-directory
551 Tue Apr 19 11:58:19 2005 by jpr
553 Should suppress some warnings from Borland compiler
555 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * Builder/ : add something to facilitate the RPM creation of gdcm
558 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
559 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
561 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
563 Thu Apr 14 16:26:19 2005 by jpr
565 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
567 // Old style (still available) :
568 dcmdir = new gdcm::DicomDir(dirName, true);
570 // new style (user is allowed no to load Sequences an/or Shadow Groups)
571 dcmdir = new gdcm::DicomDir( );
572 dcmdir->SetParseDir(true);
573 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
574 dcmdir->Load(dirName);
576 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
577 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
579 * Fix compilation on gcc 2.96 (which does not have ios::failure)
581 Mon Apr 4 17:15:24 2005 by jpr
583 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
585 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
586 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
587 and it's representation name (for the NIH)
589 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
590 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
591 conversion of YBR to RGB pixels. So, now, the conversion is made using
594 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
596 format) to replace 'at-run' dicom files generated by the
597 TestAllReadCompareDicom test
599 Tue Mar 22 12:29:37 2005 by jpr
601 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
602 and it's VR is forced to UL
603 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
604 and/or with Shadow groups
605 use SetLoadMode (NO_SEQ | NO-SHADOW);
607 Tue Mar 22 12:40:13 2005 by jpr
609 *FIX Restore pushed out elements
611 Fri Mar 11 12:08:31 2005 by jpr
613 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
615 Fri Mar 11 12:12:13 2005 by jpr
617 Final removal of gdcmFileHelper::InitializeDefaultFile();
619 Wed Mar 9 20:29:38 2005 by jpr
621 Add Anonymize method (not yet fully checked)
623 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
626 Wed Mar 2 18:18:32 2005by jpr
628 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
631 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
634 Mon Feb 21 18:45:41 2005 by jpr
636 * Replace method CheckMetaElements by CheckManadatoryElements
637 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
638 (probabely some stuff still missing)
639 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
640 between a given call and the next one (to add images to a Serie he just
642 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
643 between a given call and the next one, or to reuse an already existing
644 Study UID (i he wants to add his own Series to an already existing Study)
646 Thu Feb 17 17:18:33 2005 by jpr
648 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
649 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
650 Thx to Benoit for reporting bug
652 Thu Feb 17 11:56:20 2005 by jpr
654 Prepare FileMetaInformationVersion (group 0002) management
656 Thu Feb 17 12:02:47 2005 by jpr
658 Group 0002 management
660 Thu Feb 17 12:03:32 2005 by jpr
661 gdcmDocEntryArchive.cxx
664 Wed Feb 16 11:19:19 2005 CET by jpr
665 gdcmPixelReadConvert.cxx
666 Taking into account MONOCHROME1 + Signed Pixels (?!)
668 Tue Feb 15 19:12:34 2005 by jpr
670 Taking into account the difference between MONOCHROME1 (low values = bright)
671 and MONOCHROME2 (low values = dark)
673 Mon Feb 14 11:45:04 2005by jpr
675 Remove some useless mask operations, to save CPU time
677 Mon Feb 14 15:51:10 2005 by jpr
679 *never* forget to re-compile just *before* committing!
681 Mon Feb 14 15:34:27 2005 by jpr
683 First commit on the post 1.0 (Version? / Tag? / Branch?) :
686 Mon Feb 14 11:45:47 2005 by jpr
688 remove useless comments
690 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Testing/TestMAkeIcon.cxx : complete the test
693 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
696 Fri Feb 11 16:22:18 2005 by jpr
698 Typo, comments, doxygenation
700 Thu Feb 10 11:55:26 2005 by jpr
702 AnonymizeNoLoad improvement
704 Thu Feb 10 10:07:19 2005 by jpr
706 Duplicate Matthieu's hack to prevent bombing in Anonymize
708 Thu Feb 10 12:20:34 2005by jpr
710 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
712 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
713 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
714 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
715 virtual bool SetValEntry(std::string const &content,
716 virtual bool SetBinEntry(uint8_t *content, int lgth,
717 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
718 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
719 virtual ValEntry *InsertValEntry(std::string const &value,
720 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
721 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
723 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
727 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
730 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * Test/ : accelerate tests (it's not very significant accelerations).
732 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
734 Mon Feb 7 15:48:34 2005 by jpr
736 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
739 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * Testing/TestSequence.cxx : add test for sequences of images... test that
741 we have the same serie or the same study UID
743 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
746 * src/gdcmDict.h : remove commented code
747 * src/gdcmDocument.cxx : initialize values
748 * src/gdcmFile.cxx : bug fix when reading values
749 * gdcmPython/demo/ : change file names. Remove useless files
751 Sun Feb 6 15:31:09 2005 by jpr
753 Update comments for DicomDir stuff
755 Sun Feb 6 15:39:35 2005 by jpr
757 * Add method File::AnonymizeNoLoad, to allow anomymizing files
758 even when the pixels are not gdcm Readable
759 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
760 to allow user to choose the elements whose value
761 he wants to white out / replace
763 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
764 * src/gdcmFile.cxx : remove the default array of initialization.
765 The static array contained pointers to non-static values (comming from
766 strings). To have coherences, when creating files, these values can't be
767 static. So, the array can't be static, too ! To simplify, the array have
768 been replaced by repeted lines to insert values in the File
770 Fri Feb 4 15:49:01 2005 by jpr
772 * Add GetFirstValEntry + GetNextValEntry, for Python users
773 * Some more Doxygenation + typo fixing
775 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
777 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
779 Thu Feb 3 18:12:46 2005 by jpr
780 gdcmPixelReadConvert.cxx
783 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
784 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
785 (Dicom Element) into the Sequence Item
787 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * src/*.cxx : first parss to normalize file organisation
790 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
791 * src/gdcmDirList.[h|cxx] : add method to find a directory
792 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
794 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
795 * Finish cleaning up my JPEG mess. Should be ok now.
796 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
797 contained within the RLE* class(doh!)
799 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
800 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
801 * SerieHeader::AddFileName() creates as many Coherent Files lists
802 (same Serie UID) as it founds different Serie UID
803 amongst the files instead of discarting any file
804 that doesn't match with the first one he found.
805 * SerieHeader::OrderGdcmFileList has now one parameter :
806 the Coherent Files list the user wants to sort
807 * SerieHeader::GetFirstCoherentFileList() |
808 * SerieHeader::GetLastCoherentFileList() | allow to parse
809 the set of Coherent Files lists
810 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
811 compatibility (it returns the *first* Coherent Files list,
812 since there was only one before)
813 * Test/TestSerieHeader gets gdcmData as a default root directory
815 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * Remove friend between DocEntry and File classes
817 * Remove friend between PixelReadConverter and RLEFramesInfo,
820 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
822 0002|0000. The value was incorrect.
824 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
825 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
827 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
828 * src/gdcmUtil.cxx : compilation fix on Win32
829 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
830 variable, to be easy found. Add methods to change the default UID.
831 Amelioration of the CreateUniqueUID to use the correct default UID.
832 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
835 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
836 * Test/TestVR.cxx : fix memory leaks
838 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
839 * Rewrite the base 256 to base 10 conversion, using string operation only.
840 This allows us to get rid of the problematic 64bits integer type (does not
841 always exist on target platform).
843 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
844 * Add construct and destructor to class gdcm::Debug to close the debug file
846 * Don't let uset to open twice the same file
847 * gdcm has now an official UID prefix,
848 supplied by http://www.medicalconnections.co.uk
849 1.2.826.0.1.3680043.2.1143
850 (Thx to Mathieu for providing URL)
851 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
852 to be able to perform some more tests
853 * gdcm::ContentEntry : Contructors and Destructor are now protected,
854 in order to be sure no user will try to use them.
855 (at user level, only the children classes are meaningfull)
857 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
858 * move RLEInfo & JPEGInfo from Document to File
860 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * FIX : remove so many friend between classes
863 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
865 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
867 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
868 In order to avoid missbehaviour :
869 . gdcm::DocEntry is now specialized in
870 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
871 - gdcm::ContentEntry (Dicom entry with a 'content')
872 . gdcm::ContentEntry is specialized in
873 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
874 characters value, or integers)
875 - gdcm::BinEntry (Dicom entry with a non strig representable value
876 (user hasn't any longer to thing about the precedence of his dynamic_casts)
878 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * Test/VTKTest*.cxx : bug fix under linux
881 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
883 use with python. Some methods are moved from Document to ElementSet or
884 DocEntrySet. The equivalent methods to ElementSet have been added to
885 SQItem and are virtual in DocEntrySet. Methods that may have the same code
886 in SQItem and ElementSet is directly placed in DocEntrySet
888 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * Test/VTKTest*.cxx : remove the show variable in each test method because
890 it's useless (the viewer variable replace this variable)
892 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * src/gdcmDocument.cxx : bug fix on potential memory leak
894 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
895 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
896 Add ClearXxx methods to remove all the content of the list or map
897 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
899 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
900 * methods ReplaceOrCreate renamed as Insert
901 (nobody will be any longer confused by 'CreateOrReplace')
903 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
904 * Grealty simplify the JPEg decompression, no need to differenciate based on
905 the JPEG possible type (with/without fragment, with/without multiple frame).
906 Everything is done throught the JPEG IO Suspension mechanism in IJG
908 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
909 * Stage 3 of normalization :
910 in order to avoid any missunderstanding while reading method names :
911 - All the methods xxxEntry now deal with dicom Entries
912 - Methods GetEntry splitted into
915 - Method SetEntry renamed as SetEntryValue
916 - Method SetEntryBinArea let as it was
918 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
919 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
920 - Position correctly the entry points for JPEG2000 and JPEG-LS
921 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
923 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
924 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
925 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
926 with other method names
927 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
928 * Test/TestDicomDirElement.cxx : add new test
930 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
931 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
932 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
933 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
934 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
935 So can't you use __int64 in ostream at all.
937 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
938 * bug fix for compilation on MSVC6
939 * gdcmPython/gdcm.i : rename of classes missed
941 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
942 * Stage 2 of names normalization :
943 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
944 (easy to understand ...)
945 - gdcm::FileHelper replaces old class gdcm::File
947 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
948 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
949 type and not a string. So, there remove problems on the format of the
952 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
953 * Add Example/TestPapyrus.cxx
954 - reads a Papyrus file (gdcm::Header compliant),
955 - gets the pixels of all the images, using low level iterators
956 - writes an multiframes Dicom image.
957 (Just to show it's *possible* to do that)
958 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
961 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
962 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
963 Thus, DicomDirXXX are created with a flad that indicates if the created
964 object is empty or not (when not empty, the DicomDirElement is used to
967 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
968 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
969 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
971 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
972 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
974 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
975 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
976 Remove all access to the hash-tables or lists in the objects.
978 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
980 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
981 be complient with all the gdcm source code
983 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
984 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
987 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
988 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
991 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
992 * Test/ : rename VTK tests to have a best name for the tests
993 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
994 GetFirstEntry/GetNextEntry use
996 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
997 * In SerieHeader::ImagePositionPatientOrdering()
998 // a Dicom 'Serie' may contain scout views
999 // and images may have differents directions.
1000 // -> More than one may have the same 'pos'
1001 // Sorting has then NO meaning !
1002 Thx to Eduardo Davila for reporting bug.
1004 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1005 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
1006 test. Now it's on image content and not on the resulting visualisation...
1007 might solve the problem on linux when using the OpenGL drivers
1009 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1010 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
1011 DicomDirSerie, DicomDirImage
1012 Dict, DictSet classes :
1013 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
1014 -remove InitTraversal method.
1015 * UPD Test programs + Example programs
1017 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1018 * remove useless and never updated keyword \ingroup
1019 * Solve pb when structure (list, map, ...) is empty.
1020 Thx to Benoit for reporting bug
1022 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1023 * Taking into account of 'Transfer Syntax' value
1024 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1027 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1028 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1029 is no memory access violation
1030 * gdcmPython/demo : add python demos using VTK
1032 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1033 * FIX 'Dictionnary' is now spelt 'Dictionary'
1034 'wether' is now spelt 'whether'
1035 'archieve' is now spelt 'archive' ;-)
1037 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1038 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1039 related methods, in order not to expose internal mechanisms
1042 * REM methods that exposed internal mechanisms :
1043 DicomDir::GetDicomDirPatients()
1044 DicomDirPatient::GetDicomDirStudies()
1045 DicomDirStudy::GetDicomDirSeries()
1046 DicomDirSerie::GetDicomDirImages()
1047 * UPD Test programs :
1051 * UPD Example program
1053 * ADD DictSet methods
1057 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1058 * Removed the Print/indent/default parameter mess. There is absolutely no
1059 reason to have to methods, moreover with the second taking the ostream as
1060 *SECOND* parameter. This was clearly a bad hack to get things compile.
1062 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1063 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1064 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1065 Unfortunately the main code does not work on SunOS, thus provide a specific
1066 code for this platform only (and Win32 of course). Since this seems to be
1067 working, change CreateUniqueUID to use GetMACAddress instead of the
1068 problematic GctestetIPAddress
1070 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * Unfortunately to be able to test gdcmDirList I had to break the API
1072 a little. Now the class is not a std::list anymore but has a member
1073 std::vector (more ITK compatible). Allow unit testing on Win32 and
1076 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1077 * Update SerieHeader to take into account a Serie Instance UID to properly
1080 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1081 * ENH - Comment out Mathieu's (dangerous) Super Hack
1082 for dealing with BIGENDIAN processors
1083 - Move equivalent stuff to BinEntry::WriteContent
1084 When necessary, 16 Bits Pixels are swapped in a small buffer
1085 and then written. This avoid allocating a huge buffer, in
1086 PixelWriteConvertor, and avoid modifying the Pixel Area.
1088 Probabely, the same operation will have to be done when we want
1089 to write image with Big Endian Transfert Syntax,
1090 and we are working on Little Endian Processor
1092 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1093 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1095 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1096 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1097 all the dict content.
1098 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1100 * Test/TestDict.cxx : add a new test for the dict classes
1102 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1103 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1104 file. Debug is yanked if compiled with NDEBUG
1106 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1107 * src/gdcmDictSet.h : set the default output to the os variable
1108 * src/gdcmDictEntry.[h|cxx] : add the Print method
1109 * gdcmPython/demo/ : add a new test
1111 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1112 * merging of Test/PrintDicomDir and Test/TestDicomDir
1113 * removal of now redundant Test/PrintDicomDir
1114 * enhancement of Example/PrintDicomDir
1116 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1117 * Now, python test might work on systems
1118 * Add the PrintDicomDir test
1120 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1121 * FIX : First entry following group 0002 was lost for
1122 Explicit Big Endian Transfer Syntax files
1123 (group and elem not swaped)
1125 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1126 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1127 Big Endian Transfer Syntax supposed the group following 0002
1128 begins always by element 0000 (element 0000 is *optional*)
1129 To avoid further troubles, let's be pessimistic, and use
1130 Document::HandleOutOfGroup0002() method
1131 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1132 (related pb not yet solved)
1134 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1135 * Bug fix for the python part use
1136 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1138 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1139 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1141 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1142 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1143 a string and should ask the global TS dict what are the propreties of
1146 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1147 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1148 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1149 to swap the Swap Code, at parsing time, when we come out of group 0002
1150 and Transfer Syntax is Big Endian
1151 We should be able to read now 'true DICOM" Big Endian coded images
1152 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1153 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1155 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1156 * Hopefully fix the bug on MacOSX and static global initialization.
1157 This is the only -minor- patch I found that both please MacOSX and VS6.
1158 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1159 but this would require a lot of change. Another approach would be that Global
1160 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1161 gdcm::Global would destroy at exit).
1163 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1164 * Fix bug on MacOSX with static initialization in a multy threaded
1165 environment. static const string in a header file used to be ill
1166 initialized provoquing the freeze of any tests. patch should solve this
1169 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1170 * According to Benoit's suggestion, and without any objection from anybody
1171 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1172 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1173 - method gdcmDicomDirObject::GetEntry() renamed as
1174 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1176 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1177 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1178 you debug/warning message just as c++ streams which make them very convinient
1179 to use. Once this is stabilize I will change the ostringstrem to be
1180 redirected to a file (ofstream).
1181 * Properly support C99 extension: __FUNCTION__ which allow us to display
1182 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1184 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1185 * Removal of useless and dangerous methods :
1186 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1187 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1188 * Removal of usless methods :
1189 Dict::PrintByName, Dict::GetDictEntryByName
1190 * Commenting out of probabely useless methods :
1191 Dict::GetDictEntryNames()
1192 Dict::GetDictEntryNamesByCategory()
1193 DictSet::GetPubDictEntryNames()
1194 DictSet::GetPubDictEntryNamesByCategory()
1195 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1196 * ENH : Use dicomTS.dic as described in 2004 version
1197 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1198 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1199 Add Accessors on VM (Value Multiplicity), and VM related methods
1200 * ADD : Add a list of 'Dicom Attribute types', as found in
1201 http://medical.nema.org/dicom/2004/04_15PU.PDF
1203 * ADD : Add dicomGroupNameAbbreviations.dic
1204 should be used to write a method to replace the former
1205 Dict::GetDictEntryNamesByCategory()
1207 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1208 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1209 to read in the file... and only it ! Length is the efective length of the
1210 data in the DocEntry structure
1212 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1213 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1214 And now use a static function call instead, with a global variable. i
1215 This is much closer to the VTK approach. Hopefully should be bulletproof
1216 and easier to use...hopefully
1218 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1219 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1221 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1222 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1224 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1225 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1226 ValEntry, BinEntry, SeqEntry creation or replace
1228 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1229 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1230 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1232 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1233 when specifying the VR
1234 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1235 * src/gdcmDocEntry.cxx : amelioration of print
1237 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1238 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1239 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1240 * ADD Method Document::ComputeGroupLength
1241 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1242 in order to allow further VR modification by user
1243 * REM : removal of once-called method File::WriteBase
1244 integration of its code in formerly one-line method File::Write
1246 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1248 replace the different values "??", "Unkn", "Unknown".
1249 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1250 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1251 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1252 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1254 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1255 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1257 * Set the gdcm::Base class to some Printable classes
1259 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1260 * src/gdcmFile.[h|cxx] : add the Print method
1261 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1262 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1263 * src/gdcmDocument.h : remove the PrintLevel informations
1264 * Example/PrintFile.cxx : use the new gdcm::File::Print
1266 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1267 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1268 problems when compiling with the python wrapping
1270 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1271 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1272 writting in ImplicitVR
1274 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1275 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1276 JPEG decompression, especially when dicom frames are split into several
1277 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1278 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1280 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1281 * src/gdcmHeader.cxx : change the initialisation of default header.
1282 Now, this header is readable by gdm, e-film, DicomWorks
1284 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1285 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1286 Rename Decompressed to Raw
1287 * Use the API changes in gdcm::File.
1288 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1291 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1292 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1293 each added entry in the header. Replace the 'Planes' field by the 'Number
1296 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1297 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1298 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1300 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1301 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1302 At this time, this image isn't readable by e-film... waiting JPR help to
1305 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1306 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1307 DocEntry. Now use methods of the Document !
1309 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1310 * Test/ShowDicomSeq.cxx : bug fix
1312 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1313 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1314 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1315 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1316 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1318 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1319 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1320 containing found sequences
1322 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1325 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1326 Some fields in BinEntry must be copied to not seg fault when making the :
1327 gdcm::File *copy = new gdcm::File( copyH );
1328 and tests are now made on good variables
1330 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1332 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1334 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1335 * Add vtkGdcmWriter example and test
1337 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1338 * Test/TestUtil.cxx : reformat the source code
1339 * vtk/vtkGdcmReader.cxx : remove and change prints
1340 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1342 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1343 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1345 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1346 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1347 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1349 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1350 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1351 by an eof to prevent all bad read of the file... and in this case, the
1352 file isn't readable.
1354 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1355 * Example/Volume2Dicom.cxx : comment unused variables
1356 * Test/PrintDicomDir.cxx : comment unused variables
1357 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1358 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1359 method that is redondant with AddEntry.
1360 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1363 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1364 * Bug fix due my last commit (compilation under Windows).
1365 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1366 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1368 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1370 - Remove printf / sprintf
1371 - include iostream AFTER gdcm so we don't get warnings
1372 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1374 - Also remove tons of include from header files, hopefully this should
1375 speeup the compilation time, since it was becoming a dog slow.
1376 - Remove gdcm.h as it include way too many files and slow down compilation
1377 (plus it is not up to date)
1378 - remove 'using namespace std' this is BAD !
1380 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * Remove memory leaks on the DicomDir
1382 * Remove some useless data in DicomDirObject
1383 * Add usefull methods in SQItem, to be complient withe the ElementSet
1385 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1386 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1388 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1389 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1390 future, with convertion)
1391 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1392 and ImageDataSize values. Remove the method to get the PixelReadConverter
1393 from the output of the class
1395 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1396 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1398 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1400 and vtkErrorMacro use.
1401 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1403 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1404 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1406 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1407 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1408 The string leaves only in the fonction. So when we make a .c_str(), we
1409 get the pointeur on the first element, element that will be destroyed
1410 immediately after thee instruction.
1411 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1412 file has been opened : the test must be made on the content of the
1413 pointer and not directly on the pointer !
1416 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1417 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1418 the python part recompiles
1420 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1421 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1422 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1423 X session is killed (for my computer... it seems to not be identic on
1426 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1427 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1428 avoid problems (otherwise, the difference test between the visible image
1429 and the reference is incorrect. If the reference is greater than the
1430 screen resolution, it's produce errors).
1431 Can be used for only one image. Can be used with a visible flag.
1432 * vtk/vtkGdcmReader.cxx : remove commented codes.
1433 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1434 under windows at compilation
1435 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1436 for grayscale images
1437 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1439 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1440 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1441 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1442 tests on the image size X, Y, Z
1444 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1445 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1446 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1447 between the class name and the file name
1449 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1450 * src/ : fix compilation warnings for the Write method (2 different
1451 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1452 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1453 variable... create a static method in gdcm::Document to access to
1454 this variable content.
1456 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1457 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1458 file, to be accessed by other files (like gdcmFile). Remove commented
1459 code. Move the change of the header to the gdcmFile, using the
1461 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1462 To be sure of that (and simplify calls), the Write of the header now
1463 gets a file name and not a file pointer (std::ifstream).
1464 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1465 DocEntryArchive. Remove all open of the written file
1467 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1468 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1470 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1471 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1472 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1474 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1475 some corresponding methods. Write correctly the file and check before
1477 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1478 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1479 is now on RGB data (as before my last commit
1480 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1482 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1483 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1484 Add a print information of the type of the entry
1485 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1486 It was in the gdcmFile, and all write have been regrouped
1487 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1488 Write correctly all dicom files (in decompressed mode only at this time)
1489 * Test/ : test on files are now made using Raw data and not color data if
1491 * Example/PrintFile.cxx : add more printings
1493 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1494 * Amelioration of code, remove some code copy. For the loading of
1495 BinEntry (in gdcmDocument), add the test to verify if the file is already
1498 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1499 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1500 remove a DocEntry in the header (push an empty DocEntry)
1501 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1502 lines. Bug fix in the initialization of the PixelConvert and the
1504 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1505 use in TestCopyDicom (now this test can run under windows... but fails)
1506 * Test/TestCopyDicom.cxx : amelioration of the test :
1507 - test the pixels written
1508 - add test points to quickly find where is the error
1509 - can set a file name input and output in arguments
1510 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1511 amelioration of the test output
1513 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1514 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1515 all replaced DocEntry's
1516 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1517 Now, each needed DocEntry to modify is duplicated, modified and inserted
1518 to the header using DocEntryArchive. Thus, after save, we can restore the
1519 header initial state.
1521 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1522 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1524 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1525 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1526 correct to copy it. The DictEntry is specified at the DocEntry creation,
1527 then, it musn't change in the time.
1528 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1529 header correctly. At this time, the change is only made for the first
1530 level of the Document. In the future, it might consider sequences.
1531 The change is made by replacing a DocEntry by an other that is created
1532 outside the class. The old value is kept. When we restore the header
1533 status, the added DocEntry is deleted and replaced by the old value.
1534 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1535 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1536 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1537 the write mode to native, decompressed or RGB (but not used at this time)
1539 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1540 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1541 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1543 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1544 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1545 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1547 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1548 set because already copied when copying the BinEntry's of the header
1549 * Test/TestAllReadCompareDicom.cxx : remove warnings
1551 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1552 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1553 Two problems appear when doing it :
1554 - with the gdcmFile : when the GetImageData method is called, the pixels
1555 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1556 data (pixels). And each structure destruct the data when it's
1557 destructed. So we have two destructions for the same data. To solve it,
1558 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1559 data or not. If it doesn't own data, then they will not destroyed by
1561 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1562 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1563 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1564 create a double destruction of the same DocEntry's. So, to solve it,
1565 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1566 * TODO : add an entry concerning memory leaks in the DicomDir
1568 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1569 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1570 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1573 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1574 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1575 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1576 after it have been deleted
1578 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * FIX: src/* fix the doxygen warnings.
1580 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1581 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1582 was erroneously defined with a size of 15 instead of 16. [many thanks
1583 to Jean Michel Rouet for pointing out this bug].
1585 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 1. Finish merging JMR patch for writting DICOM from scratch
1587 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1588 3. Use const ref when possible
1589 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1590 5. A few more comments
1591 6. CreateUniqueUID can now be called without parameter"
1593 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1594 * ENH: Slightly bigger patch:
1595 1. Getting toward full integration of JMR patch for writting dicom from scratch
1596 2. Update Test to test part of this patch: CreateUniqueUID
1597 3. File was not close properly in gdcmDict
1598 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1599 5. Use of const ref instead of copy (speed issue)
1600 6. Remove temporary (duplicate) string in TranslateToKey
1601 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1602 8. Do not repeat virtual in subclasses
1603 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1605 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1606 * Apply first patch toward better string comparison when dealing with broken
1607 DICOM files. Essentially the string could be padded with a space instead
1608 of a null character as defined by standard
1610 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1611 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1612 because never used... and in the same time, that's remove some memory leaks
1614 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1615 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1616 * In examples and tests : change the type of image data variables from void*
1617 to uint8_t*. Remmove all delete on image data variables
1619 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1620 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1621 Verify the file pointer value before open the file, and if it's not null,
1622 a verbose message is generated.
1623 Close correctly the file when the file isn't considered dicom-like. The
1624 correctly close is a call to CloseFile.
1625 When closing the file pointer, test if its not null to close the file.
1626 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1627 file. For an uncompressed image, the copied data correspond in the least
1628 case to the image size (calculated) or the image size specified in the
1629 header. A verbose is generated if these two size mismatch
1631 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1632 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1633 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1634 break under windows (with msvc6 compilation).
1636 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1637 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1638 compiling with MSVC6)
1640 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1641 * Bugs fix for the Windows build with VC6
1642 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1643 needed (only for projects required VTK). If the VTK is included in all
1644 projects, there is conflicts with the jpeg lib of vtk when compiling the
1645 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1646 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1647 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1649 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1650 (like it's already made for the cout use). Otherwise, conflict with the
1653 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1654 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1655 * gdcmPython/gdcm.i:
1656 - comments on the DicomDir::Method related usage added.
1657 - now that we use the namespace gdcm, a lot of internal classes do
1658 NOT need to be wrapped anymore.
1659 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1660 DicomDir::Method) new example added.
1662 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1663 * Improve string manipulation. I now inforce the notion of 'DicomString'
1664 A DicomString can contain as many \0 as they want
1665 and it is *always* of even length.
1666 We only support odd length for very rare case.
1667 And in the near future this should be removed.
1669 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1670 * /binary_write/ gdcm source. Now even on big endian we are writting
1671 little endian. This should -heopfully- fix some tests
1673 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * Now the dictionary is compiled into gdcm lib. This is a default
1675 behavior, thus any dic file specified is picked before failback to
1676 the one comiled into lib
1678 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * Change internals for gdcmDict. Don't use any 'new' any more.
1680 This should definitely solve any leak problem, and we should be
1681 as fast as before, as long as don't modify too much the dictionary.
1683 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * STYLE: ivars should start with a capital letter.
1685 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1686 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1688 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1690 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1691 new 2004 dictionaries added (thanks to JPR).
1692 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1693 * CLEANUP_ROUND (15) for gdcmPixelConvert
1694 - RLEFrame::NumberFragments is now of type unsigned int
1695 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1696 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1699 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * Initial work in gathering all transfer syntax accessors. clearly
1701 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1702 ivars, but only one transfersyntax (class) ivar with equivalent method on
1705 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1706 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1707 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1708 discussed (plus I didn't like having a 2000 lines patch not commited)
1710 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1711 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1712 * CLEANUP_ROUND (14) for gdcmPixelConvert
1713 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1714 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1715 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1716 CloseFile() anymore.
1717 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1718 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1719 into File::Pixel_Data.
1721 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1723 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1724 * CLEANUP_ROUND (13) for gdcmPixelConvert
1725 Substituted File::ParsePixelData() with PixelConvert::Print() new
1727 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1728 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1729 method to those classes.
1730 - src/gdcmFile.[cxx|h]:
1731 -- Added a ::Print() method.
1732 -- PixelConverter is now a reference instead of a member.
1733 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1734 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1736 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1738 collaboration diagram and inheritance diagram should be generated with
1740 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1741 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1742 pointlessly wrapped (see
1743 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1744 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1745 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1746 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1747 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1748 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1749 -- File::Initialise: PixelConverter setup moved away to
1750 PixelConverter::GrabInformationsFromHeader()
1751 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1752 interpretation moved away to PixelConverter::BuildRGBImage()
1754 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1756 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1758 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1759 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1760 displayed on Win32 when a brutal abort() occurs (because of uncatched
1761 exception). See TODO new entry of this commit for more on this.
1762 * TODO added new entry.
1763 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1764 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1765 - HandleColor is no longer called from gdcmFile.cxx
1766 - gdcmPixelConvert.cxx clean up on method arguments and internal
1767 variable names for semantical coherence.
1769 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * Finished lossless transition, not only do we now read all lossless jpeg
1771 images, without the need of the Cornwell lib, but we do read them properly now
1772 * To reduce code (well to avoid code duplication), I defined a common place
1773 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1774 redefine symbols. This is not perfect but this the best solution I found for a
1775 compilation time jpeg option.
1777 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * Update jpeg ijg lib to support lossless jpeg implementation
1779 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1781 * Also added a special copyright for dcmtk since we use their bugfixes.
1784 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1786 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1787 matters, as stated in warning note at beginning of %include section).
1788 * src/gdcmDicomDir*.[cxx|h]: coding style
1789 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1790 * src/gdcmJpeg8.cxx: doxygen fix.
1791 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1792 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1793 from File:: to PixelConvert::.
1795 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1797 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1798 - more code moved away from File:: to PixelConvert::
1799 - fat setup of PixelConverter set in place in File::Initialise.
1801 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1803 namespace at the file system level. So now you should convert your examples
1805 gdcmHeader -> gdcm::Header
1806 It would be nice if people keep in mind to no open the namespace, since it
1807 allows compilation on broken plateform which were defining common symbol in
1808 the standard namespace (like LP, Unknown ...)
1810 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1812 The JPEG fragments are now parsed at the same stage than the RLE
1813 information. All code related to JPEG is now in gdcmPixelConvert:
1814 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1815 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1816 export a gdcmFile:: method. Those are simply global functions
1817 (for the time being this is better than having them attach to
1818 either gdcmFile:: or gdcmPixelConvert::).
1819 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1820 and stores the result in a gdcmJPEGFragmentsInfo.
1821 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1822 code (among other stuff) moved away from gdcmFile:; to
1825 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1826 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1827 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1828 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1829 clean up of RLE related code.
1830 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1831 - src/gdcmRLE.cxx removed
1832 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1833 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1834 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1835 * CLEANUP_ROUND (9) for gdcmPixelConvert
1836 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1837 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1838 away from gdcmFile:: to gdcmPixelConvert::.
1840 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1842 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1843 This is because Parse7Fe0 used to parse the pixels to compute the
1844 length. This task was passed over to FindDocEntryLengthOB() a long
1845 time ago, EXCEPT I forgot the OW case...
1846 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1847 we just recylce the code for parsing RLE fragments and computing
1849 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1850 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1851 with the retired Parse7Fe0().
1852 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1853 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1855 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1856 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1857 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1858 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1859 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1860 * CLEANUP_ROUND (4) for gdcmPixelConvert
1861 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1862 to return an unused length.
1864 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1866 this should be cleanner from the plane view. The iostream are erally a pain
1867 to use to do simple stuff.
1869 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1870 * Redo the compilation of the ijg jpeg library. Now only one source is
1871 necesseray. No need to rename file by hand what so ever. CMake handle the
1872 copying of the file within different directory, configure header file to
1873 modify some symbol. The only addition made to ijg wasd a mangle table so
1874 that symbol are different whether we are within 8bits or 12bits.
1876 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * Added documentation of vtkgdcmReader on Website:
1878 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1879 with it's binary name).
1880 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1881 the Website to be more complete.
1882 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1883 doxygenated documentation.
1884 - Doc/DoxyVtkGdcmReaderExamples.txt added
1885 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1886 DoxyVtkGdmReaderExamples.html )
1887 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1888 * CLEANUP_ROUND (3) for gdcmPixelConvert
1889 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1891 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1892 * CLEANUP_ROUND (2) for gdcmPixelConvert
1893 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1895 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * CLEANUP_ROUND for gdcmPixelConvert:
1897 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1898 - src/gdcmPixelStuff[h|cxx] removed
1899 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1900 - src/CMakeLists.txt changed accordingly
1901 * GDCMHOME clean up:
1902 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1903 gdcmVersion.py moved to newly created ATTIC related
1904 gdcmPython/SetupOldies/ directory.
1905 * Autotools clean up:
1906 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1907 - autogen.sh configure.in acinclude.m4 python.m4 removed
1909 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1911 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1912 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1914 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * TODO updated with Mathieu suggestions. I proposed a template for
1916 describing TODO entries and used it for new entries.
1917 * Added Doc/Website/CodingStyle.html, Developpers.html,
1918 DeveloppersPython.html, GdcmDataCvs.html and
1919 DownloadVersion0_1.html, DownloadVersion0_3.html.
1920 * Some Doc/*.txt Doxygen files (which do not really concern the
1921 documentation itself, but the website) moved to html and
1922 placed in directory Doc/Website:
1923 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1924 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1925 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1926 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1927 * CMakeLists.txt changed accordingly.
1928 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1929 DeveloppersPython.html
1930 * INSTALL nows refers to Doc/Website/Installation.html
1932 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * Added Doc/Website directory, that contains a first raw version
1936 2004-09-23 Jean-Pierre Roux
1937 * FIX In order not to be poluted any longer by casting problems,
1938 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1939 we can now delete[] it safely
1940 * VoidArea is now called BinArea (less confusing name),
1941 and all the methods called ...VoidArea... are now ... BinArea...
1942 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1944 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1945 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1946 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1947 up to the destructor of gdcmElementSet to clean up TagHt and it's
1950 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1952 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1954 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * ENH: added some utility method that builds a flat dictionary
1956 holding all the Dicom entries contained in the recursive structure
1957 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1958 an example of usage.
1959 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1960 BuildFlatHashTable() that build a flat dictionary.
1961 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1962 gdcmDocument is now a friend of gdcmElementSet.
1963 - src/gdcmElementSet.cxx: clean up.
1964 - Example/FlatHashTablePrint.cxx added.
1965 - Example/CmakeLists.txt changed accordingly
1967 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1969 moved away from gdcmDocEntrySet (since this class is an abstract class
1970 acting like an interface). SQDepthLevel and BaseTagKey are now
1972 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1973 and associated accessors. Doxygenation of the class.
1974 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1976 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1977 Use SQDepthLevel accessor instead. ::Print() adapted.
1978 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1979 - src/gdcmDocument.cxx changed accordingly.
1981 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1983 - The following is the doxygen comment of the typedef declaration
1984 of gdcmTagKey in src/gdcmCommon.h:
1985 gdcmTagKey is made to old an "universal" (as in URL, Universal
1986 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1987 A dicom tag always has a group and an element, but a set of tags
1988 embeded in various (optionally nested) sequences and sharing
1989 the same group and element all share the same (group, element)
1990 "identifier". Hence the (group, element) cannot be used as an
1991 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1992 In order to construct a proper tag identifier (i.e. a key) we
1993 consider the following definition of a TagKey:
1994 - let Group, Element be the string representation of the
1995 group and element dicom tag members,
1996 - let ItemNumber be the string representation of the integer
1997 index of the considered item number of a sequence,
1998 Let the key of a tag embeded in a sequence, noted SeqTag, be
2000 /ItemNumber#Group|Element
2001 where "/", "#" and "|" are characters acting as separators.
2002 Then the general form of a gdcmTagKey is given by:
2003 Group|Element<SeqTag>
2004 where <SeqTag> means NO or many instances of SeqTag.
2005 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
2008 but the gdcmTagKey of a tag "embeded" is the first item of
2009 a sequence, itself nested in the third item of a sequence is the
2011 0004|1220/2#0008|0082/0#0008|0090
2012 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
2013 order to hold the new sequence compatible key. Previously, the
2014 GetKey() method would look in the underlying gdcmDictEntry.
2015 - src/gdcmDocEntry.cxx:
2016 -- constructor now copies the underlying DictEntry key, in the local
2018 -- ::Print: displays the member Key, instead of the (group, element).
2019 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2020 - src/gdcmDocEntrySet.h:xi
2021 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2022 -- now has a new BaseTagKey member.
2024 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2025 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2027 This poses the problem with the semantics of the following lines
2028 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2029 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2030 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2031 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2032 to the long FIXME note for what the problem is. Nevertheless in
2033 order to get things working the dicom dictionary was altered !
2034 Please fix things urgently...
2035 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2036 information), see above note on moving the member VoidArea. Nevertheless
2037 the following entries previously correctly set as US are now inproperly
2039 0028 1201 OW IMG Red Palette Color Lookup Table Data
2040 0028 1202 OW IMG Green Palette Color Lookup Table Data
2041 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2042 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2043 of gdcmDocEntry moved to gdcmSeqEntry.
2044 * src/gdcmSeqEntry.cxx: STYLE.
2046 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2049 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2050 * gdcmPython/testSuite.py: all the test suite in python is now moved
2051 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2052 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2053 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2055 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2057 to avoid inclusion recursion until STL is reached.
2058 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2059 mecanism. errno.h is not included in gdcm anymore.
2060 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2061 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2063 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2064 gdcmData/TestAllEntryVerifyReference.txt
2065 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2066 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2067 exception_on_error parameter.
2068 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2069 - vtk/vtkGdcmReader.cxx changed accordingly,
2070 - Example/*.cxx and Test/*.cxx changed accordingly.
2072 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2074 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2075 enable_sequences removed from gdcmHeader constructor and dependencies.
2076 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2077 * gdcmPython/demo/PrintHeader.py: dummy fix.
2078 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2079 skip_shadow removed from gdcmHeader constructor and dependencies.
2080 * Example/*.cxx and Test/*.cxx changed accordingly.
2082 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2083 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2084 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2086 2004-07-21 Jean-Pierre Roux
2087 * FIX Now, Parsing and Printing a DICOMDIR do work!
2088 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2090 2004-07-20 Jean-Pierre Roux
2091 * FIX Some brain damaged headers have Zero-Lenght fields
2092 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2094 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2095 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2096 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2097 variable (instance of gdcmDebug) by a definition macro, and the instance
2098 is now in static in the gdcmDebug class
2099 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2100 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2102 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2103 * WARNING: ctest now depends more tightly on gdcmData. You should
2104 check out gdcmData properly for things to run smoothly...
2105 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2106 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2107 we need the pixels not be loaded in order to use the ValEntry
2108 that displays position and size).
2109 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2110 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2111 be deprecated. If you have any doubts about the advantages of a
2112 modern scripting language (read Python) versus grass root C++ (i.e.
2113 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2114 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2115 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2116 Anyhow, consider documenting the gdcmData images in
2117 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2119 * Test/CMakeLists.txt:
2120 - now uses TestAllEntryVerify.cxx
2121 - specific comments on oldACR00001.ima (now renamed in gdcmData
2122 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2123 gdcmData/TestAllEntryVerifyReference.txt
2126 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * src/*.[h|cxx] : typedef clean up
2128 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2129 - TagKey renamed to gdcmTagKey (for external usage)
2130 - VRKey renamed to gdcmVRKey (for external usage)
2131 - removal of typedef duplication.
2132 - Removed all unecessary inline keyword from class inline definitions.
2133 - Some method|function(void) declarations replaced with method|function().
2134 * src/jpeg/libijg12/jdhuff12.c:
2135 - printf polluting ctest removed.
2136 - TAB removal for comminting
2138 - TestAllReadCompareDicom.cxx: added a test that compares all the
2139 images in gdcmDataImages.h with corresponding images in
2140 gdcmData/BaselineDicom/. When baseline images are not present
2141 this test creates them.
2142 Note: we need to validate each reference image, but before that
2143 I'd like to rename them with a more explicit name...
2144 - CMakeLists.txt: changed accordingly.
2145 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2146 including each header needed).
2148 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2149 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2150 test suite to the Example directory. Are concerned:
2155 - TestWriteSimple.cxx
2156 * Test/CMakeLists.txt: added some comments on reasons for black listing
2157 image gdcmData/oldACR00001.ima
2159 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * Test/CmakeList.txt: removed the following from black list (to be coherent
2161 with removal from gdcmData):
2162 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2163 - gdcm-MR-PHILIPS-16.dcm
2165 Added the following because after last cvs update, they cause
2166 ctest -R TestReadWriteReadCompare
2168 - gdcm-MR-SIEMENS-16-1.acr
2170 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2171 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2172 new comments in this file) we temporarily (sigh) move to a weaker
2174 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2175 we don't need to black list the following images anymore:
2176 - 8BitsUncompressedColor.dcm
2178 - US-PAL-8-10x-echo.dcm
2179 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2180 fixes and the beautified code ;-)
2181 This fixes the bug introduced in version 1.42 (when beautifying)
2182 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2183 Note: ctest was blind to this bug (this means we need to still
2184 improve the test suite). The bug could be detected by using
2185 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2187 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2188 and by displaying the (garbage) produced file temp.XDCM...
2190 2004-06-29 Jean-Pierre Roux
2191 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2192 - replace by uggly but working old code :-(
2193 A lot of things should be OK again.
2194 It's really urgent to have a test suite that *tests*,
2195 to prevent Frog's beautifying sessions to break all the stuff
2196 (twice, withing a fortnigh ...)
2198 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2200 redundancy) to added Test/TestReadWriteReadCompare.cxx
2201 * Test/CmakeList.txt: because the compare test of
2202 Test/TestReadWriteReadCompare.cxx fails, the following images are
2203 black listed: - 8BitsUncompressedColor.dcm
2205 - US-PAL-8-10x-echo.dcm
2206 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2207 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2208 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2209 and ad-hoc kludge. This kludge is now removed, and on encountering
2210 such an image (OB field brain damaged) we set errno. Then in
2211 ::FindDocLength() we "fix" the length as being ALL what remains
2212 in the file (until EOF). We then proceed, hoping for the best...
2213 This fixes a SegFault in ShowDicom when trying to write such an
2215 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2216 (because TestWriteRead breaks on it, after a non conformal commit?).
2217 ctest now runs properly, except for MakeDicomDir (which was always
2218 broken) and the Python related stuff (still not fixed).
2220 2004-06-24 Jean-Pierre Roux
2221 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2222 FIX : Test/TestReadWrite now iterates on all the file names
2223 (instead of infinite loop)
2224 ENH : Test/TestWriteRead now iterates on all the file names
2226 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2229 2004-06-24 Jean-Pierre Roux
2230 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2231 when SamplesPerPixel =3
2232 - now Write is no longer confused by
2233 'BitsAllocated = 12" and 'BitsStored=12"
2234 - "UN" value representation Elements are now written correctly
2235 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2236 ENH : - now gdcmHeader has its own Write methods
2237 (in order to split the job that has not to be done
2240 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2242 loop on the same image until memory went out.
2243 Note: this means we still have gobs of memory loss in PrintDocument
2244 * src/gdcmDocument.cxx: fixes problem on parsing on file
2245 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2247 2004-06-24 Jean-Pierre Roux
2248 FIX : Write - All the Sequences and Sequence Item are now written
2249 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2250 is added a the end, when necessary.
2251 - A lot of brain-damaged images, that were read correctly are
2252 now written correctly
2253 - length compatible BinEntry are now loaded correctly
2254 (even for odd groups)
2255 Note : only Explicit Value Representation was checked.
2256 (question : is implicit VR really necessary for gdcm ?)
2258 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2259 * DEVELOPPER: added a proposition of coding style.
2260 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2263 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2265 Use the gdcmDocEntry::Print() and Write() instead.
2266 * src/gdcmDocument.cxx: bug fix.
2268 2004-06-22 Jean-Pierre Roux
2269 FIX : gdcmDocument.cxx
2270 - Now we do recognize the JpegLossLess format (there was a misstyping in
2271 code 'beautyfication' :-(
2272 - Now we automaticaticaly load the Luts, if any
2274 2004-06-22 Jean-Pierre Roux
2275 In order : to write Sequences, whatever their imbrication level,
2276 : to allow user to create his own Sequences
2277 a lot of modif where necessary (adding, moving, or virtualising methods)
2279 WARNING : save your own sources *before* cvs up !
2282 ADD virtual void Write(FILE *fp, FileType filetype);
2285 ADD virtual void Write(FILE *fp, FileType filetype);
2286 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2289 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2290 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2291 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2292 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2293 ADD std::string GetEntryByName(TagName name);
2294 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2296 std::string vr = "unkn",
2297 std::string fourth = "unkn",
2298 std::string name = "unkn");
2299 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2300 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2301 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2302 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2303 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2304 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2305 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2306 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2309 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2310 ADD virtual std::string GetEntryByName (TagName tagName);
2311 ADD virtual std::string GetEntryVRByName (TagName tagName);
2312 REM virtual bool Write(FILE *, FileType);
2313 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2314 FILE *_fp, FileType type);
2315 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2316 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2317 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2318 REM virtual std::string GetEntryByName (std::string tagName);
2319 REM virtual std::string GetEntryVRByName (std::string tagName);
2320 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2321 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2322 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2324 std::string vr = "unkn",
2325 std::string fourth = "unkn",
2326 std::string name = "unkn");
2327 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2328 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2329 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2330 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2333 ADD virtual void Write(FILE *fp, FileType filetype);
2336 ADD virtual void Write(FILE *fp,FileType filetype);
2339 ADD virtual void Write(FILE *fp, FileType filetype);
2340 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2341 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2342 REM std::string GetEntryByName(TagName name);
2345 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2347 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2349 The default constructor invoked by the line
2350 gdcmHeader *f1 = new gdcmHeader( header );
2351 was gdcmHeader::gdcmHeader(bool) instead of the expected
2352 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2353 Hence the parsing wasn't executed... See also below.
2354 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2355 as explicit constructor didn't do the trick to fix the above problem.
2356 Could anyone explain why ?
2357 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2358 properly calls gdcmValEntry::Print() (that was weed out from
2359 code related to gdcmBinEntry).
2361 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * In order to fix memory leaks:
2363 - Test/TestWriteSimple.cxx: added cleaning of free store through
2365 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2366 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2367 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2368 (through the call to ::AddDicomDirMeta()) or the destructor
2369 would crash when deleting uninitialized ::metaElems].
2370 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2371 - src/gdcmDocument.cxx:
2372 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2373 from dynamic stores.
2374 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2375 was causing memory leaks.
2376 - src/gdcmSQItem.cxx:
2377 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2378 cleanly handled with polymophism: sorry but my milage is low).
2379 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2380 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2381 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2382 This avoids SegFaulting.
2383 - src/gdcmSQItem.h: coding style.
2385 - Test/TestWriteSimple still severely sucks. The output image content
2386 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2387 damaged when displayed with vtkgdcmViewer.
2388 - on memory leaks: TestWriteSimple leaks really less (see entry
2389 of 2004-06-18 in Changelog file for the call to valgrind).
2390 - on segfaults: ctest now passes all the tests but one (no more
2392 * Erroneous leading white fix:
2393 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2394 white[s] (as opposed to from >> xxx, that removes it [them].
2395 - src/gdcmTS.cxx: ditto.
2396 - gdcmPython/testSuite.py: dirty related kludge removed.
2397 * src/*: remaining references to gdcmParser removed.
2398 * src/*[cxx|h]: added copy[way]left header.
2401 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * In order to fix writing of dicom files:
2403 - Test/TestWriteSimple.cxx: a simpler example of writing.
2404 - Test/CMakeLists.txt changed accordingly.
2405 - src/gdcmDocument.cxx:
2406 -- The destructor now recursilvely removes potential sequences.
2407 -- Bug fix in ::IsJPEG2000()
2408 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2409 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2411 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2412 to only declared) and build on top of
2413 ::GetDocEntryByNumber(guint16, guint16).
2414 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2415 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2416 for usage in destructor and treatement of promotion in
2417 ::ReplaceOrCreateByNumber().
2418 - src/gdcmSQItem.cxx: destructor should better handle his job.
2419 Test/TestWriteSimple now runs (or at least it DOES something).
2420 * We can now start hutting memory links. A good starting point is:
2421 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2422 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2423 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2425 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * Valgrind note: after Mathieu Malaterre teached me how to read
2427 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2429 Using gcc, you can force the STL to use malloc and to free memory as
2430 soon as possible by globally disabling memory caching.
2431 With 3.2.2 and later, you should export the environment variable
2432 GLIBCPP_FORCE_NEW before running your program.
2433 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2434 simply vanish (it is still not clear to me, whether this means that
2435 STL std::string leaks or if valgrind believes it leaks...).
2436 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2437 running bin/gdcmTests makeDicomDir):
2438 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2439 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2441 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2442 SegFaulting (I drowned in DicomDir related code when trying to
2443 understand why the list is empty...).
2444 * src/gdcmDocument.h: first BSD license header try.
2445 * Doc/License.txt added.
2447 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * src/gdcmDocument.[h|cxx]:
2449 - Clean up of the Transfer related predicates. They are now all based
2450 on new method isGivenTransferSyntax, that (should) handle properly
2451 the padding problem.
2452 - general clean up, simplification, and coding style.
2453 - Specific clean up of Parse7FE0() (umproperly named actually).
2454 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2456 2004-06-14 Jean-Pierre Roux
2458 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2459 - fix the display of SQItem ordinal number
2460 - add the GetSQItemByOrdinalNumber method
2461 - remove some useless never written private methods
2463 2004-06-14 Jean-Pierre Roux
2465 - adding a constructor taking a gdcmDocEntry as an input param
2466 - ReplaceOrCreateByNumber now returns :
2467 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2468 a gdcmValEntry * if a string value is passed as a param
2470 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2471 according to the param type (no longer sets a gdcmDocEntry)
2472 - GetValEntryByNumber, GetBinEntryByNumber added
2473 - NewValEntryByNumber and NewBinEntryByNumber added
2475 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2477 - GetSQItemNumber and SetSQItemNumber added, to provide
2478 a (relative) Item identier inside a given Sequence
2479 \warning : some pb remaining around this number
2481 - AddEntry now takes the Item Number as a param
2483 - adding a constructor taking a gdcmDocEntry as an input param
2485 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * Memory leak hunt with the following command:
2487 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2488 --show-reachable=yes gdcmTests PrintDocument
2489 It looks like many (all?) leaks are due to the STL (or a bad usage
2490 of the STL. The lines producing the leaks now have a comment with
2491 a "MEMORY LEAK" tag: you can retrieve them with
2492 grep "MEMORY LEAK" src/*
2493 Here are two typical examples which I can't help fixing:
2498 char * test = "babo";
2499 name = test; //// <--- valgrind detects 960 bytes lost in
2500 //// call to std::string::operator=(char const*)
2501 name.clear(); //// Doesn't help !
2509 std::cout << "Type a bunch of characters followed by RETURN: ";
2510 getline(std::cin, line); //// <--- valgrind dectects a loss
2511 //// of 1320 bytes in call to
2512 /// std::basic_istream<>& std::getline<>
2518 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2519 * src/gdcmHeader.[cxx|h]:
2520 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2521 and related, moved away to gdcmDocument.
2522 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2523 the corresponding protected accessors of inherited class
2524 gdcmDocument, removed ! As a consequence gdcmFile had to be
2525 declared friend of class gdcmDocument (see below).
2526 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2527 - Clean up of undefined or unused methods.
2528 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2529 account the changes to gdcmHeader.h).
2530 * src/gdcmDocument.h:
2531 - gdcmFile is now a friend class (in order to take into account the
2532 changes to gdcmHeader.h).
2533 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2534 (see changes to gdcmHeader.h).
2535 - Accessors (reading on the form GetEntry*) are now public.
2536 - Clean up of undefined or unused methods.
2537 * src/gdcmDocument.cxx:
2538 - adaptation to changes to gdcmDocument.h
2539 - ::OpenFile now writes a verbose message when file cannot be opened.
2540 - some std::string properly set to VRKey
2541 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2542 references to gdcmDocument.
2543 * Test/TestFindTags.cxx: changed accordingly to above changes.
2544 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2545 cvs repository gdcmData.
2547 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2549 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2550 conflicts with gdcmValEntry::voidArea.
2551 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2552 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2553 Value representation between StringRepresentable and BinaryRepresentable.
2554 * src/gdcmDocument.cxx:
2555 - method ParseDES: proper indentation restored and usage of
2556 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2557 - method LoadDocEntry: the fingerprint left in the SetValue() of
2558 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2559 removed. Reverting to previous code segment with the proper
2560 dynamic_cast< gdcmValEntry* >.
2561 Note: this was (partially) breaking the python test suite
2562 (gdcmPython/testSuite.py) that made usage of the above
2563 fingerprint to check presence of "Pixel Data".
2564 * src/gdcmDocEntry.h: coding style.
2565 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2566 now taken into account.
2567 * gdcmPython/gdcm.i: adaptation to the new internal representation
2568 of gdcm (exit gdcmParser, hello gdcmDocument).
2569 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2571 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2572 anymore, but instead prints the loaded Python dictionary.
2573 * .... alas, the python testSuite is still broken.
2575 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2576 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2578 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2579 * src/gdcmUtil.h : export methods
2581 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2582 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2584 * Initial addition of automatic python testing
2585 * Initial addition of automatic image comparison
2587 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2588 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2589 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2591 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2593 * Test/ShowDicom.cxx : bug fix for msvc compilation
2594 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2596 2004-05-04 Jean-Pierre Roux
2597 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2598 new concepts (and new classes) :
2599 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2600 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2601 - Sequence Doc Entries (gdcmSeqEntries)
2602 a Sequence is composed of Items.
2603 Each item is a set of Doc Entries (this is recursive)
2604 The non uniqueness of the 'Dicom tag' is due to this recursivity
2605 (never taken into account)
2606 Our unability to add a new 'entry' in the header
2607 at the proper location (neither in the H-Table (map or multimap),
2608 nor in the Chained List is also due to this recursivity.
2609 Don't try, right now, to use/modify/compile these new sources :
2610 nothing is finished.
2611 We just commit all the stuff, 'as is', in order not to loose it.
2613 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2614 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2616 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2617 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2618 file prefix (SetFilePrefix)
2620 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * Add a new test: ShowDicom, for now this is just the c++ version of
2622 checkRead.sh, later it will be able to compare the image read against a
2624 * Replace the DEBUG on the stack with a global entry in cmake interface:
2625 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2627 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2628 * Add an example subdir, with a real example on how to read + write a
2631 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2633 * Doc/CMakeLists.txt: the main page is now properly differentiated
2634 between the developper and user version.
2635 * Doc/doxygen.config.in: dropped search related obsolete flags
2636 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2638 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2639 * DEVELOPPER: added some helpfull comments for compile/test/install
2642 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2643 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2644 src directory, now generated in the build dir.
2645 2. Tests as mentionned smarter
2647 4. Add a new method in gdcmDict that return the PubDict by name
2648 this is interesting for 3rd party lib like ITK,
2649 where we could set the institution name / patient name...
2651 * ENH: 1. Now the test suite is working for real
2652 2. All binaries are now output in the gdcm-bin directory
2653 (this was not true before)
2655 2004-04-28 Jean-Pierre Roux
2656 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2657 SeQuence indented printing of Dicom Header.
2658 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2659 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2660 Computation of SQDepthLevel is now part of gdcmHeader constructor
2661 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2662 tree-like structure of a Dicom Header.
2663 * FIX Test code cleaning
2665 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2666 * ENH: Adding automatic testing
2667 1. Need a DartConfig.cmake to submit to public
2668 2. Add a test driver gdcmTest.cxx
2669 3. gdcmTestMain, an helper for the main test driver gdcmTest
2670 4. Files in Test don't have a main anymore, this becomes interesting
2671 when we add more and more tests, thus dsw don't have to load
2673 * ENH: Adding a GDCM_DATA_ROOT for testing
2674 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2675 one file instead of seven + some small cleanup
2677 2004-04-22 Jean-Pierre Roux
2678 * ENH Minor changes to the Print() methods.
2679 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2680 Header printing. Example given with :
2681 > PrintHeader fileName 2 new
2682 (SQ based tree-like structure still to be done for the Header ...)
2684 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2686 1. I have added some unsigned where needed
2687 2. Some function parameter not used -> (void)
2688 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2689 4. g++ don't like character '\' in comment
2690 5. #define jpeg_create_decompress jCreaDecompress
2691 this really need to be fixed
2692 6. virtualize destructor of gdcmObject ... leakage
2693 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2694 this also really need to be fixed
2695 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2696 remove compression file
2697 (as we only do decompression, right ?)
2698 * ENH: Change malloc/calloc/free with c++ equivalent
2700 2004-04-21 Jean-Pierre Roux
2701 * FIX gdcmHeaderHelper::GetXSpacing
2702 when a single value is found (bug ?), xpacing is now
2703 defaulted to yspacing
2705 2004-04-19 Jean-Pierre Roux
2706 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2707 * ENH add parameters :
2708 bool exception_on_error = false,
2709 bool enable_sequences = false,
2710 bool ignore_shadow = false
2711 to the gdcmFile constructors to be full gdcmParser compliant
2712 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2713 to allow reading of PAPYRUS 3.0 files
2715 2004-04-06 Jean-Pierre Roux
2716 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2718 2004-04-02 Jean-Pierre Roux
2719 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2720 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2721 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2723 2004-03-30 Jean-Pierre Roux
2724 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2725 for ACR file, written out as DICOM files (hope so...)
2727 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2729 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2730 moved to base class gdcmParser and only the specialisation is kept
2732 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2733 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2734 already does the job.
2735 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2736 (to be consistent with gdcmParser::WriteEntries).
2738 2004-03-30 Benoit Regrain
2739 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2740 upate of the object's instance. It's passed to 2 in the unfavorable
2741 case : one in the ExecuteInformation, one in the ExecuteData
2743 2004-03-29 Jean-Pierre Roux
2744 * ENH : Check on file type to be written moved
2745 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2746 * FIX : gdcmObject::ResetBoundaries now stops properly
2747 when end-of-list is reached
2748 : gdcmVersion modified (as Benoit Regrain asked)
2750 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2752 * src/gdcmUtil.cxx: added forgotten iostream include.
2753 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2754 equivalent to ExplicitVR in existing code).
2756 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2758 now contains all the gdcmGlobal related code.
2759 * minor coding style and doxygenation changes.
2761 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2763 now contains all the Debug related code.
2764 * minor clean-up of includes in src/*.cxx
2765 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2766 CreateCleanString) removed.
2767 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2768 * Doc/DoxyMainPageUser.txt added.
2769 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2770 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2771 src/gdcmDirList.cxx)
2773 2004-03-24 Jean-Pierre Roux
2774 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2776 2004-03-23 Jean-Pierre Roux
2777 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2778 big endian made volumes
2779 * ENH Now gdcmParser constructor and destructor are protected to forbid
2780 end user to instanciate class gdcmParser
2781 (only gdcmHeader and gdcmDicomDir are meaningfull)
2783 2004-03-22 Benoit Regrain
2784 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2785 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2786 gdcmSerie to gdcmDicomDirSerie
2788 2004-03-19 Jean-Pierre Roux
2789 * ENH Now the tree-like structure describing a DICOMDIR comming from
2790 an already existing DICOMDIR file is consistent with
2791 the home-made tree-like structure build ex-nihilo
2792 or build from the files held (recursively) in a Directory
2793 functions gdcmDicomDir::CheckBoundaries()
2794 gdcmObject::SetBoundaries() added
2796 2004-03-17 Jean-Pierre Roux
2797 * REM (Eric Boix bug) : removal of meaningless
2798 gdcmDicomDirImage::NewImage function.
2799 * FIX now file names and directory name are written properly in the
2801 * FIX now gdcmDicomDir constructor may be call without any trick
2804 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2806 of gdcmDicomDirImage::NewImage as empty function.
2808 2004-02-28 Jean-Pierre Roux
2809 * ENH add gdcmDicomDir:NewPatient
2810 add gdcmDicomDirPatient:NewStudy
2811 add gdcmDicomDirStudy:NewSerie
2812 add gdcmDicomDirSerie:NewImage
2813 to allow making gdcDicomDir object.
2814 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2815 (as opposite to the gdcmHeader chained list)
2817 2004-02-11 Benoit Regrain
2818 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2819 when using from python
2821 2004-02-10 Benoit Regrain
2822 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2823 * FIX : in gdcmDicomDir when the directory is empty
2824 * ENH : add callback and methods to get the progression of dicomDir
2827 2004-02-06 Jean-Pierre Roux
2828 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2829 - GDCM_META added to gdcmDicomDirType
2830 - class gdcmMeta created
2831 * ENH : - A brief summary is now displayed at the beginning of
2832 'testDicomDir' to help disaster magnitude estimation
2833 * REM : Now useless Test/explDICOMDIR.cxx
2835 2004-02-05 Benoit Regrain
2836 * ENH : add methods in gdcmObject to get the hash table or the list of
2838 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2839 * FIX : wrapping python for TagHeaderEntryHT
2841 2004-02-04 Benoit Regrain
2842 * FIX : even length for some strings when writting the dicom dir
2843 * FIX : sort the images in the dicom dir
2844 * FIX : Bug fix for python use of dicom dir
2845 * ADD : a python demo
2847 2004-02-04 Jean-Pierre Roux
2848 * FIX : Final solution (?) for icone embedded images
2849 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2850 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2851 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2852 gdcmData/gdcm-MR-SIEMENS-16.acr1
2853 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2854 to make full checking easier
2856 2004-02-04 Benoit Regrain
2857 * FIX : WriteEntries : coding style & logic in parameters
2858 * FIX : Set the elements to create the DicomDir in a dictionary file
2860 2004-02-03 Benoit Regrain
2861 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2862 * gdcmDicomDir : add the load of directory
2863 * Bug fix and print add-on
2865 2004-02-03 Jean-Pierre Roux
2866 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2867 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2868 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2869 * FIX gdcmParser.cxx : 'group length' elements are now considered
2870 as integers, even for shadow groups, when file is Implicit VR
2872 2004-02-02 Jean-Pierre Roux
2873 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2875 of the last synonym :-(
2876 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2878 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2879 * FIX taking into account the possible 7fe0,0010 multiplicity
2880 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2881 to allow removal of references to 7fe0,0010, to deal with
2882 ACR-NEMA images, when 0028,0200 is meaningfull
2884 2004-01-31 Jean-Pierre Roux
2885 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2886 no longer writes 'Un' on disk
2887 * FIX SQ elements with actual length are now dealt with corectly
2888 * FIX gdcmFile::WriteBase make the difference, for color images, between
2889 the length (for Palette expanded images)
2890 and Raw Length (non expanded image + Palette)
2891 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2892 (that broke Write). Replaced by UL.
2893 Aware user will reload the field if he
2894 thinks it's necesssary
2896 2004-01-30 Jean-Pierre Roux
2897 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2898 when 'dirty Acr' is found, to be compliant with the new
2899 IsReadable() methods.
2901 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2902 (no DOUBLE images in kosher DICOM,
2903 but so usefull for people that miss them ;-)
2905 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2906 DICOMDIR related utilities (not checked as Windoze compliant)
2908 2004-01-28 Jean-Pierre Roux
2909 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2911 2004-01-27 Jean-Pierre Roux
2912 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2913 to allow skipping the shadow elements, to save memory space.
2914 The TRUE value for this param has to be used
2915 with a FALSE value for the 'enable_sequence' param.
2916 ('public elements' may be embedded in 'shadow Sequences')
2917 * gdcmHeader methods now deal with 'embedded icones images' in the header
2918 (even when an 'icone image sequence' is announced by the
2919 element (0x0088,0x0200), but there is NO icone at all ...
2921 * gdcmHeader sometimes Image Location value doesn't follow
2922 the supposed processor endianity (see gdcmData/cr172241.dcm).
2925 * gdcmHeader add the method
2926 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2927 to get *all* the Header Entries with the same tag.
2928 GetHeaderEntrySameName is probabely *useless*
2929 (no meaning : Name is *not* an identifier within the Dictionary)
2931 2004-01-26 Benoit Regrain
2932 * Bug fix in the print of hexadecimal representations. Remove long fields
2933 in the print and add a third level of print to print them
2935 2004-01-23 Benoit Regrain
2936 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2937 * Bug fix on test suite after remove the strip made on not string fields
2938 * Split the IsReadable method between gdcmParser which test that the file
2939 is dicom and gdcmHeader which test that it's an image file
2941 2004-01-22 Benoit Regrain
2942 * DicomDir : clean code, add methods, set variables in protected or private
2943 * gdcmUtil : bug fix for the clean string method
2945 2004-01-19 Benoit Regrain
2946 * Add the use of shadow dictionaries
2947 * bug fix and coding style
2949 2004-01-19 Benoit Regrain
2950 * src/gdcmFile.cxx : bug fix concerning the close of file
2951 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2952 * Add the update of header entries using the shadow library
2954 2004-01-19 Benoit Regrain
2955 * removal of file gdcmHeader2.cxx
2956 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2957 inheriting from gdcmParser. This split is to prepare the integration
2958 of dicom dir parsing
2959 * bug fix under python
2961 2004-01-16 Jean-Pierre Roux
2962 * REM removal of class gdcmHeaderEntrySet
2963 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2964 * ADD add file gdcmHeader2.cxx
2965 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2967 2004-01-15 Benoit Regrain
2968 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2969 entries created while parsing the header. Thus, they will be destroyed
2970 when the gdcmDictSet will be destroyed
2971 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2974 2004-01-15 Benoit Regrain
2975 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2976 made a fatal error because of the memory release at the end of program.
2977 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2978 some memory and vtk seems to have some problems with that.
2979 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2981 2004-01-14 Benoit Regrain
2982 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2983 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2984 * src/*.[h|cxx] : make changes due to class name changes
2985 * gdcmPython/demo/*.py : bug fix due to method names
2987 2004-01-13 Benoit Regrain
2988 * src/*.[h|cxx] : coding style
2989 * vtk/*.[h|cxx] : coding style
2991 2004-01-13 Benoit Regrain
2992 * gdcmPython/testSuite.py : test the readable flag of file for tests
2993 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2994 It's lied to the stl compilation by MSVC (windows, always windows...)
2995 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2997 2004-01-12 Benoit Regrain
2998 * src/*.h : add comments
2999 * src/gdcmDictSet.h : set the method BuildDictPath in public
3000 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
3001 directly setted in the source code
3002 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
3005 2004-01-09 Benoit Regrain
3006 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
3007 * setup.py : use a reference to gdcmVERSION
3009 2004-01-07 Benoit Regrain
3010 * Modification to compile with the distutils.
3013 2003-12-10 Benoit Regrain
3014 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3015 can use a gdcmHeaderHelper to load data
3016 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3017 made in the source code
3019 2003-12-10 Benoit Regrain
3020 * Update Windows projects and .cvsignore files
3022 2003-11-12 Jean-Pierre Roux
3023 * ENH gdcmHeader constructor has one more parameter (default value : false)
3024 that allows the user to 'go inside' the SeQuences only
3026 gdcmElValSet:Print takes it into account
3028 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3029 * ENH: Update gdcmPython/CMakeLists
3030 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3031 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3033 2003-11-10 Jean-Pierre Roux
3034 * FIX : gdcmHeader::LoadElements is now based
3035 on the ListTag listElem member,
3036 not longer on the TagElValueHT tagHt member
3037 * ENH : PrintPubElVal shows (temporarily) both results,
3038 with the tagHt member and the listElem member.
3039 (it's easier to 'see' the problems when using Printheader)
3041 * FIX : old private member LgrElem is now splitted into
3042 ReadLength : Length actually found on disk (updated only
3043 if bug fixing is necessary), for internal
3045 UsableLength : Updated by FixFoundLength, to fix a bug
3046 or to allow Parser going on.
3047 Will allow to re-write a kosher header when a SeQuence
3048 with a length (not 0000) is found
3049 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3050 because gdcmElValSet::Add does not update ListElem
3053 2003-11-07 Jean-Pierre Roux
3054 * FIX misstyping in Transfert Syntax name table
3055 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3056 when they have an actual length (not 0000 nor FFFFF)
3057 (Nobody should care of it, but DICOMDIR explorers)
3059 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3060 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3062 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3063 * ENH: vtkGdcmReader now supports LUT !
3064 (vtkgdcmViewer for now is not able to use them though)
3066 2003-11-05 Jean-Pierre Roux
3067 * in testSuite.py : new files names for checking the package
3068 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3069 that returns the pixel area size to the *aware* (vtk) user
3070 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3072 2003-11-05 Benoit Regrain
3073 * in testSuite.py : Modify the rules for checking the paths
3074 : Explicit error messages
3075 * in __init__.py : Related modif
3077 2003-11-03 Jean-Pierre Roux
3078 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3079 to be used by aware (vtk) users that want to manage
3080 LUT (and no to turn the PALETTE image into an RGB pixels one)
3081 * GetPixelType now returns 8U for 24 Bits images
3082 (vtkGdcmReader compliant)
3084 2003-10-31 Jean-Pierre Roux
3085 * Removal of *all* gdcmData images and add them again
3086 in order to loose the 'history' of un-anonymised images
3088 2003-10-31 Jean-Pierre Roux
3089 * RMV : removal of useless jBitsInJsample.h
3090 for both 8 and 12 Bits JPEG Lossy Libraries
3092 2003-10-31 Jean-Pierre Roux
3093 * ENH : Add the functions gdcmFile::GetImageDataRaw
3094 gdcmFile::GetImageDataIntoVectorRaw
3095 that act as GetImageData and GetImageDataIntoVector
3096 except the making of an RGB Plane from Gray Plane + LUT
3097 Intended to aware (vtk) users who know how to manage
3100 GetLUTRGBA return a R,G,B,A LUT if any
3101 lgrTotaleRaw gives the 'Raw' length
3102 GetImageDataRaw returns the gray Plane
3103 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3104 (They stay Grey, just like with other Dicom viewers :-(
3106 2003-10-30 Jean-Pierre Roux
3107 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3109 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3110 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3111 being coherents dicom files.
3113 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3114 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3116 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3117 * ENH: Two steps is necessary to please VC++ compiler...
3118 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3119 * ENH: Add include dir to medcon lib
3120 * FIX: only one function is being exported for now !
3121 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3123 2003-10-29 Jean-Pierre Roux
3124 * adding gdcmHeader::GetLUTRGBA
3125 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3126 --> Mathieu, the modif u're waiting for is not yet committed
3127 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3129 2003-10-27 Jean-Pierre Roux
3130 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3131 00191113.dcm DermaColorLossLess.dcm
3132 MxTwinLossLess.dcm RadBWLossLess.dcm
3133 * ENH: For version prior to vtkImageViewer2 -r 1.19
3134 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3136 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3137 * Removal of ido stuff in CMakeLists.txt
3139 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3140 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3141 * FIX: remove a call to ->Modified ... see comments
3142 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3144 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3145 * FIX: Problem with path for libvtkgdcmPython
3146 * ENH: Try adding a search script for python site-package
3147 * RMV: Remove some file from medcon lib that are not necessary
3148 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3149 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3150 * FIX: More pragma disable fro VC++,
3151 I don't think I break something as it is also disable in VTK/ITK.
3152 But it fasten debug compilation time.
3154 2003-10-23 Jean-Pierre Roux
3155 * gdcm now deals with 16 Bits Run Length Encoded images
3156 (they are compressed as 2 planes images,
3157 one for the high Bytes, the other for low Bytes)
3159 2003-10-22 Jean-Pierre Roux
3160 * Now CheckRead takes into account :
3161 - the bugged 'Leonardo' Siemens images
3162 - the XA images, sent thru the burning VPRO station
3163 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3166 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3167 * FIX: When copying a Makefile.am to CMakeLists.txt
3168 one should remove the '\'
3170 2003-10-22 Jean-Pierre Roux
3171 * in gdcmData adding a bugged 'Leonardo' Siemens image
3172 (wrong lengths in header)
3173 OK with gdcm, KO with the other viewers :-)
3174 * add a GE dlx XA image, thru the VEPRO burning station
3177 2003-10-21 Jean-Pierre Roux
3178 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3179 for a brutal checking of vtkgdcmViewer compliance
3181 2003-10-21 Jean-Pierre Roux
3182 * add the files for 'xmedcon' Jpeg Lossless library
3183 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3185 2003-10-21 Jean-Pierre Roux
3186 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3188 2003-10-21 Jean-Pierre Roux
3189 * garbage Siemens 'Leonardo' images dealt with
3190 (the patch is easy to remove)
3191 * cosmetic changes to avoid warnings
3193 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3194 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3195 no need to press 'r' now.
3197 2003-10-20 Jean-Pierre Roux
3198 * upgrade of checkRead.sh checkWrite.sh according
3199 to new Jpeg Lossless decompressor
3200 * add US.3405.1.dcm, a genuine RGB medical file ...
3201 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3202 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3204 2003-10-15 Jean-Pierre Roux
3205 * general anonymisation in gdcmData
3206 * adding the 'color files' from
3207 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3208 * adding some well knowed bugged-header images
3209 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3210 waiting for their inclusion in Python testsuite
3212 2003-10-15 Jean-Pierre Roux
3213 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3214 no longer seg faults when file is not found
3216 2003-10-14 Jean-Pierre Roux
3217 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3220 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3221 * TODO: *.in file to genereate a UseGDCM later
3223 2003-10-14 Jean-Pierre Roux
3224 * Some supposed-to-be Dicom Images have no preamble.
3225 OpenFile takes it into account
3226 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3227 * Missing elements added in dicomV3.dic
3228 (just to be affraid : have a look at
3229 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3230 and do it again next year ;->
3232 2003-10-13 Jean-Pierre Roux
3233 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3234 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3235 But there are NOT. It's fixed !
3237 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3238 * FIX: "jpeglib.h" was not found on VC++
3239 * FIX: vtkgdcm was not being installed
3241 2003-10-10 Jean-Pierre Roux
3242 * ENH : OpenFile closes the file if it *really* doesn't look like
3243 an ACR-NEMA / DICOM one.
3244 * FIX : testWrite no longer writes an empty file if the source file
3245 is not gdcm Readable
3246 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3249 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3250 * FIX: CMake generate now documentation
3251 * ENH: out of source doc build !
3252 * ENH: Generate both user and dev documentation
3253 * ENH: Should work on windows too
3254 * ENH: Only one doxygen config.in file is needed
3255 * FIX: make install should be ok now on Unix plateform
3256 * FIX: PATH to dictionary was wrong (missing /)
3257 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3259 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3260 * vtkGdcmReader is now able to read rgb dicom file.
3261 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3262 * added a gdcmViewer to vtk test, use mouse to control
3263 window level & window width
3265 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3266 * CMake-ification of gdcm, we have now two build system
3267 * FIX: on cygwin Wsock32 doesn't exist
3268 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3270 2003-10-06 Emanuel Ollart
3271 * FIX : compilation process wad broken.
3272 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3274 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3275 * change gdcmViewer -> vtkgdcmViewer
3276 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3278 2003-10-06 Jean-Pierre Roux
3279 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3280 ( e.g : well known GE images with a wrong elem length,
3281 : Philips MRI Images with a wrong Huffman table)
3282 * still to be done : allow the reading of bugged LEONARDO Siemens images
3284 2003-10-03 Jean-Pierre Roux
3285 * Odd length strings are padded with '\0' (not with spaces,
3286 to remain compliant with already defined strings,
3287 like Transfert Syntax UID and others)
3289 2003-10-03 Jean-Pierre Roux
3290 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3291 to allow displaying RGB images (not only by affim ;-)
3293 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3294 * vtkGdcmReader is now able to read rgb dicom file.
3295 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3297 2003-10-03 Jean-Pierre Roux
3298 * A few nasty patches to allow the reading of a lot of nasty images
3299 ( e.g : well known GE images with a wrong elem length,
3300 : Philips MRI Images with a wrong Huffman table)
3301 * still to be done : allow the reading of bugged LEONARDO Siemens images
3303 2003-10-03 Jean-Pierre Roux
3304 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3306 2003-10-03 Jean-Pierre Roux
3307 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3308 to allow displaying RGB images (not only by affim ;-)
3310 2003-10-03 Jean-Pierre Roux
3311 * gdcmFile::GetImageDataIntoVector now
3312 - deals with MultiFrames MultiFragments Run Length Encoded files
3313 - deals with YcBcR (YBR_FULL) files
3314 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3315 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3317 (no sample found :-(
3319 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3320 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3321 Two reasons: - clear things
3322 - third parties acces gdcm through header files, so won't
3323 suffer anymore VC++ complains
3325 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3326 * add argv[1] in testvtkGdcmReader.cxx
3329 2003-09-24 Jean-Pierre Roux
3330 * The lines are now eigthy characters long for
3331 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3333 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3334 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3335 char* to std::string. Thus, the use of strdup becomes useless. (see
3336 previous commis of Malaterre)
3337 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3338 before the last Malaterre's commit.
3340 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3341 * This commit should fix the Debug building under VC++, the problem
3342 was mainly a mixture of debug and release lib being loaded at startup.
3343 * I also remove a depency to a specific C function: strdup. Because I had
3344 to force the link to msvcrtd (whereas strdup is in libc).
3346 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3347 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3348 located in the gdcmCommon.h file. All use of reference of tha has been
3349 changed to now use the variable GDCM_UNFOUND.
3351 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3353 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3354 Dicom dictionary. The test suite can now be run again. Note:
3355 I'm note very happy with the " (RET)" changes. I believe this
3356 RETAINED comment should be dropped when parsing the dictionary.
3357 - PACKAGER corrected
3359 - AUTHORS updated and now in alphabetical order
3360 * Makefile.am now exports gdcm.dsw for Windoze users.
3362 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3363 * cygwin complains about missing std:: in subdir Test/
3365 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3366 * remove some methods that are now in gdcmHeaderHelper
3368 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3369 * vtkGdcmReader set spacing and origin correctly
3371 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3372 * Fix a few delete/delete[] mismatch
3374 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3375 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3376 interpretation to data given by gdcmHeader. For instance there are
3377 heuristics to get informations (look at different places).
3378 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3379 sorting DICOM images based on different strategies.
3380 * modified Makefiles accordingly.
3382 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3383 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3384 when building in debug mode
3385 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3386 src/win32/gdcmdll.dsp
3387 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3389 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3390 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3393 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3394 * src/win32/libgdcmjpeg12.dsp was not dos format
3395 * src/win32/libgdcmjpeg12.dsp :
3396 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3397 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3399 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3400 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3402 * src/gdcmFile.cxx : bug fix in affectation type
3403 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3404 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3405 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3406 symbols... future problem ?
3408 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3409 * src/win32/libgdcmijpeg12.dsp was missing
3410 * modified gdcm.dsw accordingly
3412 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3413 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3415 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3416 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3417 commit of JPR (before his hollidays to facilitate our work).
3418 * setup.py : bug fix in code. Modifications made while the last commit
3419 of JPR. The code hasn't been tested before the commit... it's so
3420 useless to make that (for best programmer that is JPR) !!!
3422 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3423 * tagged the current version as Version0_3 (i.e. version 0.3)
3425 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3426 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3427 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3428 * *.dsp : modifications to use new libgdcmijpeg8 library
3429 * setup.py : bug fix on VTKPATH variable
3430 * PACKAGER : adding all concerning windows
3432 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3433 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3435 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3436 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3437 test suite reported error.
3438 * PACKAGER file added (describes what a packager must do when
3439 packaging a new release).
3440 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3441 * configure.in: upgraded version number to 0.3.0
3442 * fixing build of rpm (through rpm -ta):
3443 - Doc/Makefile.am exports proper doxygen files
3444 - src/jpeg/libijg8/Makefile.am exports the include files.
3446 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3447 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3448 * src/gdcmHeader.h : formatting code
3450 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3451 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3452 We were obtaining error message from vtk. Now, creation of file list
3453 is made in an internal list to prevent this problem.
3454 Bug fix when output is empty.
3455 Bug fix in update of progress value. Previous commit for this was a bad
3457 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3459 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3460 * src/gdcmHeader.h : added method to get the file name
3461 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3462 files. Added method to remove all files on the input
3463 Added FIXME comment concerning the bad parsing of header made by
3464 ExecuteInformation method (in ExecuteData method)
3466 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3467 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3468 when using make instal.
3469 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3470 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3472 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3473 * setup.py : adding include dir of jpeg lib to compile all sources
3474 * */Win32/*.dsp : JPR fix for windows compilation
3476 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3477 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3479 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3480 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3482 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3483 * setup.py is again effective on un*x (takes into account the
3484 addon of the jpeg library)
3485 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3486 * Doc/Doxy* updated (includes above enhancements)
3487 * INSTALL now points to web documentation
3489 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3490 * src/gdcmHeader.h doesn't make unnecessary reference to
3492 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3494 * src/gdcm*.[cxx|h] :
3495 - to allow compilation with gcc 3.x
3496 -- clean up of STL usage (added explicit usage of std::)
3497 -- small fixes on exceptions.
3498 Note: linking not tested !
3499 - clean of doxygen comments to avoid warnings at documentation
3501 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3502 dependent convertion).
3504 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3505 * Clean up of previous JPR garbage commit (not even commented in the
3507 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3508 - moved all jpeg related files from src to src/jpeg/libijg8, with
3509 addition/modification of Makefile.am and configure.in.
3510 - the testSuite is still brain damage (not guilty).
3512 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3513 * WrapVTK.py : modifications to get correctly vtk source files to
3515 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3516 (FileName -> Filename)
3518 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3519 * vtk/vtkGdcmReader.[cxx/h]:
3520 - UpdateProgress method should now be effective
3521 - removed the limitation on having only images loaded (as opposed
3523 - when building a stack of images/volume, a lesser number of
3524 gdcmHeader and gdcmFile instances should be used (hopefully
3525 accelerating things).
3526 - when building a stack of images/volumes, files which are not
3527 loadable (wrong path-filename, wrong permissions on existing file,
3528 or file not parsable by gdcm) are replaced with a black image
3529 in the stack (for the caller to notice the problem).
3531 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3532 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3534 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3535 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3536 between standard library (std) and vtk library (problems are found
3537 under Windows... thanks Windows !)
3539 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3540 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3542 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3544 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3545 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3547 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3548 * When compiling with distutils (see setup.py) the C++ compiler is
3549 called with different flags than the default ones (with automake).
3550 In order to fix all those warning, I compiled gdcm with the command
3551 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3552 and went for warning fixes:
3553 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3554 up from unused variables.
3555 - vtk/vtkGdcmReader.cxx: potential bug fix.
3556 * src/gdcmHeader.h: Doxygen warning cleanup
3558 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3559 * gdcmPython/gdcm.i:
3560 - typemaps correction to take into account the systematic replacement
3561 of "using namespace std" with std:: prefix e.g. std::list,
3562 std::string... (cf changes of 2003-05-21).
3563 - gdcmGlob global variable of type gdcmGlobal (defined in
3564 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3565 exported to Python a as cvar.
3566 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3567 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3568 gdcmDictSet.GetPubDictTagNames() and
3569 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3570 C++ static methods).
3571 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3572 with the above changes.
3574 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3575 * setup.py, manifest.in : bug fix under linux
3577 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3578 * Modification of setup.py to compile vtk part too. Then, we have 2
3579 wrappers which must work with same distutils. For that, we have a
3580 generic distutils in distusiltsWrapping.py ; with :
3581 - build_extWrap class to wrap generically all extensions,
3582 - ExtensionWrap base class for all wrapping extension that contains
3584 - Wrapper interface which wrap sources
3585 + In WrapSwig.py we have extension and wrapper for Swig
3586 + In WrapVTK.py we have extension and wrapper for VTK
3587 * MANIFEST.in : modifications to consider vtk directory and new python
3588 files for compilation
3590 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3591 * Added python wrappers of vtkGdcmReader vtk class (see the
3592 source in vtk/vtkGdcmReader.cxx) :
3593 - vtk/Makefile.am now builds a library
3594 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3595 python library (as opposed to _gdcm.so wich are the python
3596 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3597 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3599 - configure.in has an additional flag --enable-vtk that needs
3600 to be set to enable compilation of vtk related code, that is:
3601 + vtk/vtkGdcmReader.so and
3602 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3603 + gdcmPython/vtkgdcmPython.so (see above)
3604 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3605 be read when compressed or when HighBit + 1 != BitsStored),
3606 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3607 the usage of the python wrapper of vtkGdcmReader vtk class.
3608 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3609 * src/*.[h] all occurences of stl classes are now prefixed with
3610 std::, and all occurences of "using namespace std;" where removed.
3611 This is to avoid pollution of global namespace in included files.
3612 Apparently vtk does not avoid this pitfall: when using both
3613 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3614 collision of various stl members (principally cout...).
3615 * gdcmPython/testSuite.py now cleanly removes temprory generated
3617 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3618 comply with above changes)
3620 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3621 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3622 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3623 vtk data structure (an image Flip was required).
3624 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3625 * cosmetic changes in documentation.
3627 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3628 * src/gdcmHeader.cxx: the constructor no longer exits when an
3629 unexisting file is given as argument.
3630 * The subdirectory Data (containing all the images used for the
3631 test suite) is not part of this repository anymore. A new module
3632 containing those images is now available at
3633 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3634 with the name gdcmData.
3635 All the python scripts (including the package initialisation file
3636 gdcmPython/__init__.py) were adapated to take this change into
3637 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3639 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3640 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3641 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3642 demo of the usage of this class.
3643 Compilation of this vtk part is only done when using the --enable-vtk
3644 at configure (or autogen.sh) stage.
3646 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3647 * More memory link related corrections and documentation fixes.
3649 - maximum info is obtained with a command of the form:
3650 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3651 --show-reachable=yes PrintHeader
3652 - the remaining reachable blocks seem to come from the STL
3653 allocation scheme through the usage of map and list. It looks
3654 like this memory cannot be freed but it is not a memory leak
3655 (in fact further invocation to the STL would recollect the
3656 unused memory allthough it cannot explicitely be freed).
3657 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3658 of displaying an image parsed with gdcm and displayed with VTK.
3659 Note: some images don't seem to work e.g.
3660 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3661 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3662 Allthough this weakens the semantics, it is a ditch attempt to
3663 make gdcm more thread friendly.
3665 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3666 * Memory link hunt (by using valgrind through the command
3667 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3668 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3669 gdcmHeader::_dicom_vr.
3670 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3671 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3673 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3675 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3676 * src/Makefile.am now exports all the necessary include files at
3680 * UpdateGroupLength replaced by new one
3683 * UpdateGroupLength re-written using H-Table
3684 (named UpdateGroupLengthNew untill checks are over)
3686 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3687 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3688 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3690 - gdcmHeader::GetPubElValSet removed.
3691 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3692 UpdateGroupLength, WriteElements, Write.
3693 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3694 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3695 carried the same semantics.
3696 - src/gdcmHeaderIdo.cxx changed accordingly.
3697 - gdcmFile::WriteBase now regroups all the codes from previous
3698 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3699 - enum FileType moved to gdcmCommon.h
3700 * src/gdcmHeader.cxx AddDefault trashed
3701 * gdcmGetXSize added
3702 * getimageDataSize now calls gdcmGetXSize
3703 * Test/*.cxx changed to agree with above changes
3705 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3706 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3707 (to avoid double call by end user).
3708 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3709 by end user, since gdcmHeader::gdcmHeader now handles it.
3711 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3712 * gdcm/Doc many doxygen changes:
3713 - Doxyfile now has two different versions, DoxyfileUsers that generates
3714 the html.users end users oriented documentation and
3715 DoxyfileDeveloppers that generates the html.developper developper
3716 oriented documentation.
3717 - README changed accordingly
3718 - requirement.txt removed (old design info moved to TODO).
3719 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3720 DoxyMainPage.txt, DoxyPython.txt provide more information.
3721 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3722 be updated by simply regenerating the docs with doxygen and copying
3723 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3724 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3725 all the tests in the form "if (<map>.count() >1)" were removed.
3726 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3727 ill-formed documentation sections.
3728 * src/gdcmHeader.cxx: ditto
3730 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3731 * setup.py fixed for un*x (needed macro for stdint.h)
3732 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3733 un*ces with sh-utils test utility.
3734 * gdcmPython/demo/test.py renamed to PrintHeader.py
3735 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3736 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3737 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3738 * src/gdcm*.cxx JPR's bad inclusion fixed.
3740 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3741 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3742 * gdcmPython/demo/test.py changed accordingly.
3744 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3745 * gdcmPython/Makefile.am fixed linking against libstdc++
3746 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3747 * Swig subdir (historical tests of swig version 1.3.17++) removed
3748 * Test/testChangeEntete.cxx some lines commented out in order to make
3750 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3751 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3753 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3754 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3755 hence the user doesn't need this explicit call.
3756 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3757 i.e. LoadElements() call removed.
3758 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3759 - src/Makefile.am declares the proper flag for g++.
3760 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3761 for adding user defined new tags.
3762 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3763 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3764 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3766 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3767 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3768 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3769 src/Makefile.am : the project should properly compile and install
3770 with the autotools, included the python wrappers part.
3771 * gdcm.spec.in : added a spec file for RPM packaging.
3773 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3774 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3776 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3777 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3778 to exported to the environement (see gdcmPython/testSuite.py
3780 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3781 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3782 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3783 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3784 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3786 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3787 * gdcmPython/__init__.py doesn't crash anymore when running in
3788 in InstallMode or PreInstallMode but with an environment given
3789 value of GDCM_DICT_PATH.
3790 * src/gdcmDictSet.[cxx/h] coding style.
3792 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3793 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3794 * src/gdcm.h general comments moved to TODO, and README
3795 * src/gdcm.h should now be seen as a user commodity (including it
3796 should suffice to fully use gdcm). It is nowhere including within
3797 any of the kernel files src/*.cxx and src/*.h.
3799 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3800 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3801 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3803 * src/gdcm*.cxx only include their corresponding include file
3804 (as opposed to gdcm.h)
3805 * gdcmPython/gdcm.i changed accordingly
3806 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3807 the autogen.sh generated "make snapshot" command to work.
3808 * autogen.sh removed history related references to crea package.
3810 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3811 * distutilsSwigCPlusPlus.py work around some swig portability
3814 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3815 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3816 was done in a last ditch attempt to get setup.py _really_
3817 operationnal. The python/gdcmPython layaout add the advantage
3818 of hidding away the python related distutils specific files
3819 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3820 Alas, the src directory was out of scope (i.e. it's relative
3821 position to setup.py was ../src) which made things impossible to
3822 handle (see previous version of python/setup.py). Crossing fingers...
3824 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3825 * python/setup.py now works on Un*x. (harder than I thougth)
3826 * python/distutilsSwigCPlusPlus.py can now have include files
3827 among the list of sources.
3829 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3830 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3831 * modifications in MSVC projects
3833 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3834 * As stated by the first lines of Test/ExceptionAndPython/README, it
3835 looks like we can move back to original usage of exception within
3836 src/gdcm* and hence remove the errno stuff that was introduced
3837 as a quick and dirty fixture of this problem (added to the TODO).
3838 * Doc/Doxyfile configuration file for Doxygen and corresponding
3839 README file for usage added.
3840 * Test/testWrite.cxx added. This new test comes from a split of
3841 test.cxx that is now reverted to its original purpous i.e.
3842 testing the proper parsing of a Dicom related file.
3843 testWrite.cxx concentrates on testing the IO part of gdcm.
3844 * Test/bug1.cxx (containing a bug on WIn32) added.
3845 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3846 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3847 whose purpose is to publish the content of the TagNames of the
3848 Dicom public dictionary were not accessible without an
3849 instance of class gdcmHeader.
3850 - those methods are now static methods of gdcmDictSet and hence
3851 require no instances at all to be invocated.
3852 - within gdcmDictSet this change required to change some method
3853 to class methods (i.e. are now static) among which SetDictPath
3854 (renamed to BuildDictPath) and LoadDefaultPubDict.
3855 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3856 the above changes by calling the new method classes of gdcmDictSet.
3857 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3858 the above to be effective.
3859 * python/gdcmPython: in order to wrap properly the above changes
3860 for Python, swig version now needs to be > 1.3.17.
3861 * python/gdcmPython/Makefile fixed to adapt itself to new
3862 configure/make shema introduced by Johan Montagnat (thanks for the
3863 contribution). Alas this Makefile cannot be turned into a proper
3864 Makefile.am without some heavy changes in the configure.in
3865 (for python dectection).
3866 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3867 now avoids publishing the empty entries.
3869 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3870 * python/setup.py : bug fix concerning install under windows
3871 ExtraPath reused :-P
3872 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3874 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3875 * Dicts/dicomV3.dic : remove double spaces !!!
3876 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3877 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3880 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3881 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3882 method. Doxygenation.
3883 * src/gdcm.h clean up of JPR spurious comments.
3885 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3886 * python/distutilsSwigCPlusPlus.py now properly collects the
3887 shadow classes generated by "swig -c++" (gdcm.py in our case)
3888 when using "python setup.py install".
3889 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3890 reexports the working classes.
3891 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3892 by the classical C errno scheme. This is to prevent an obscure
3893 behavior of the python wrappers when importing wxPython.wx prior
3894 to gdcmPython (which ended up in an abort call). An illustration
3895 of this oddity can be found in the Test/ExceptionAndPython
3896 subdir (see the README file). This problem probably due to
3897 an combination of g++ and dynamic loading.
3898 * added Test/ExceptionAndPython (see above)
3900 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3901 * Changed the layout of the python part to avoid bloating main
3902 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3903 i.e. the distutils arsenal. All the python related stuff is
3904 again in a python subdir, but the package itself is now in
3906 * setup.py was cleaned up:
3907 - pythonIncludePath removed
3908 - python setup.py bdist target is now functional.
3909 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3910 collision with other packages). gdcmPython/demo/*.py changed
3913 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3914 * python subdir moved to gdcmPython (preparation of distutils packaging).
3915 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3916 distutils installer is operational.
3917 * - gdcmPython/__init__.py now properly loads the swig generated
3918 shadow classes (from gdcm.py).
3919 - gdcmPython/demo/*.py changed to import the package gdcmPython
3920 instead of gdcmPython/demo/load.py.
3921 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3923 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3924 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3925 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3926 entries within the associated public Dicom dictionary resp. the same
3927 information but sorted by the fourth field (PAT, IMG, DIR) of the
3929 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3930 are now in the "???" group.
3931 - python/gdcm.i changed accordingly,
3932 - python/demo/printGroupedPublicDict.py added, that gives an example
3933 of the above new functionalities in Python.
3935 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3936 * src/gdcm.h, gdcmHeader.cxx:
3937 - historic references to glib's g_malloc and g_free (#defined)
3938 were definitively removed.
3939 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3940 * src/gdcmElValSet.cxx:
3941 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3942 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3943 - GetElValue(string) renamed to GetElValueByName.
3944 - Added GetElementByName(string).
3945 * src/gdcmHeader.cxx: added
3946 - GetPubElValRepByNumber(guint16, guint16)
3947 - GetPubElValRepByName(string)
3948 - GetShaElValRepByNumber(guint16, guint16)
3949 - GetShaElValRepByName(string)
3950 - GetShaElValByNumber(guint16, guint16)
3951 - GetShaElValRepByName(string)
3952 - GetElValRepByNumber(guint16, guint16)
3953 - GetElValRepByName(string)
3954 - GetElValByNumber(guint16, guint16)
3955 - GetElValRepByName(string)
3956 * Doc/requirements.txt added.
3958 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3959 * Test/Makefile building now depends on the one of libgdcm.so
3960 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3961 pixel data) aware which enables finding the address (offset) of
3962 the pixel data of JPEG encoded DICOM files. This leaves only a single
3963 file in the testSuite whose pixel data address (offset) is unknown.
3964 * python/testSuite.py changed accordingly.
3966 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3967 * VC++ has some strong limitations when working with the STL, as stated
3968 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3969 "Also note that some STL containers (map, set, queue, list, deque)
3970 cannot be exported. [...]
3971 Some STL classes contain nested classes. These classes can not
3973 This is caused by a designed limitation that once a template
3974 class is instantiated, it can not be re-instantiated and
3976 Since our usage of map<> is ubiquitous in gdcm, this "designed
3977 limitation" of VC++ is a pitfall.
3978 Hence the Python wrappers of gdcm cannot be incrementally linked
3979 against the c++ dynamic library. The dirty but only workaround is
3980 to forget about incremental link of dynamic libraries and to generate
3981 the Python wrappers library with the inclusions of the underlying C++
3983 The following modifications concern this matter on Win32/VC++:
3984 - wrapping python correct with standalone wrapped dll (don't use separate
3985 dll under windows !!!!)
3986 - python21_d debug mode enabled (ask Frog how to use it :-)
3987 - NO problem with having an STL member of class for example string in C++
3988 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3989 - Python test of dcmlib in Python is ok under windows on a large set
3991 * removed glib references
3992 * typedef's inserted in gdcm.i for correct swig type management
3994 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3995 * python/demo/*.py load.py extracted from test.py. Added explore.py
3996 that only displays required tags and testAll.py that parses all
3997 the files of the testsuite without using unittest.
3998 * python/testSuite.py other additional test on new files added.
3999 * Data/* new test files added accordingly to the testSuite.
4000 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
4001 the vr in the file differs from the one of the dictionary.
4003 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4004 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
4005 values, but limits itself to values which are below a user specified
4006 size (by default 1024 bytes).
4007 * python/gdcm.i : elements not loaded (because their size is above the
4008 user specified treshold) are exported with their TagKey as key of the
4009 python dictionary. This enables the testsuite to make some checks
4010 on the unloaded elements (since we have their offset and size).
4011 * python/testSuite.py
4012 - now tests for the existence and proper value of the pixel data
4013 - two new examples added.
4014 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4016 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4017 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4018 aware. See the strategy comments in gdcmHeader::FindLength().
4019 * Test/test.cxx now accepts a filename as first argument.
4020 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4021 * python/testSuite.py changed to integrate test on above files.
4023 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4024 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4025 the vr was also RET.
4026 * python/testSuite.py more tests added.
4028 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4029 * python/testSuite.py unittest test suite added (uses Data)
4030 * Data/* dcm and acr files for the test suite.
4031 * glib dependance removed from un*x version. We now use ISO C99
4032 7.18 Integer types (see stdint.h)
4033 - python/Makefile, src/Makefile src/gdcm.h
4034 * src/ when an explicit vr (like dicom files) suddenly poped an
4035 implicit element we use to mark the underlying DictEntry of the
4036 concerned ElValue with "Implicit". This strategy was damageable
4037 too the public or provite dictionaries, since some of their vr
4038 would be changed. Since Header::FindLength heavily relies on the
4039 detection by Header::FindVR of falsely explicit elements, I
4040 added an extra ImplicitVr member to ElValue (boolean).
4041 The rest of the changes we the necessary adaptations.
4043 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4044 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4046 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4048 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4049 * Adaptation for porting to VC++:
4051 o forced to use std namespace (for string to be known)
4052 o all class use __declspec export style on WIN32
4053 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4054 (in stdlib.h on Win32 but in std:: for gcc)
4055 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4056 variable GDCM_DICT_PATH.
4057 * src/gdcmHeader.cxx verbose comments made discrete.
4059 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4060 * python/gdcm.i: added a typemap that converts a C++ hashing table
4061 to native Python dictionary.
4062 * python/demo/test.py:
4063 - now uses the native dictionary for exploration of gdcmHeader.
4064 - takes an optional filename argument (the file to parse).
4065 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4066 PubElVals hashing table.
4067 * Dicts/dicomV3.dic removed error prone trailing spaces.
4069 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4070 * Python wrapping process moved away from src/Makefile to
4071 newly created python/Makefile (as well as gdcm.i)
4072 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4073 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4074 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4075 from the environement variable GDCM_DICT_PATH (when existing).
4076 * src/gdcmDict::GetTag bug fix.
4078 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4079 * Straightforward temporary fixes for swig to build the python wrappers.
4080 src/Makefile now has a python working entry [by working we mean
4081 that we can import the shadow classes without errors].
4083 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4084 * hashtest.cxx removed (since already in Test)
4085 * src/gdcmlib.h renamed to src/gdcm.h
4086 * src/dcm.i renamed to src/gdcm.i
4087 * src/Makefile prepared for python wrapping
4089 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4090 * src/gdcmHeader.cxx :
4091 - Parsing of header is now separated from loading of element values
4092 (see gdcmHeader::LoadElements).
4093 - general clean up of hopefully all file access (creation of
4094 ReadInt16 and ReadInt32)
4096 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4097 * src/gdcmHeader.cxx :
4098 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4100 - SetLgrElem renamed to SetLength
4101 - GetLgrElem renamed to GetLength
4102 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4103 * src/gdcmElValSet.cxx fixed both GetElValue methods
4104 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4105 due to IdoDude was cleaned out.
4107 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4108 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4109 concentrates on finding the value representation (when it exists).
4110 RecupLgr now only finds the element value length, and it avoids
4111 returning the unecessary skL (skipped length).
4112 Also, offsetCourant was simply removed (with taille_fich) since
4113 it was redundant with the File position internals (by using
4114 ftell and fseek). This also made skL (see above in RecupLgr) usage
4116 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4117 on the libido specificities which are handled through class
4119 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4122 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4123 * Truckload of changes. Parsing of header is barely functional
4124 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4126 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4127 * src/gdcmHeader.cxx many addons of low level methods
4129 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4130 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4131 and _IdDcmSWAP_LONG.
4133 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4134 * This corresponds to all the changes decided at the meeting of
4135 May 23 2002. Needless to say we are running late...