1 Mon Oct 24 13:34:45 EDT 2005 by malaterre
2 * Adding the OpenJPEG library. It contains a patch from Antonin compared to
3 the official release that allow us to work around the famous 16bits issues
6 Mon Oct 18 10:27:49 2005 by regrain
7 * Correctly use the VRKey for all vr variables... instead of TagName
9 * Replace the definition of VRKey from std::string to a class
10 containing a char[2]. All methods are inline to have no speed low
11 * Create the GDCM_VRUNKNOWN = " " for the VR values
13 Mon Oct 18 10:27:49 2005 by regrain
14 * Remove useless constructor of gdcm::Document
15 * Remove useless parameter in the constructor of gdcm::ElementSet
16 * Split gdcmCommon to separate the System specifications to the gdcm
19 Mon Oct 18 10:27:49 2005 by regrain
20 * Minor coding-style clean up
21 * Replace the ContentEntry and its derived classes (BinEntry and ValEntry)
22 by the DataEntry. This unique entry considers all datas like binary datas.
23 Some methods are added to interpret - at fly - the binary datas.
24 Due to this important change, some methods of the DocEntrySet, concerning
25 the BinEntry and ValEntry classes, are erased ; and new methods for the
26 DataEntry class are created.
27 Some methods to set the ValEntry or the BinEntry are renamed to
28 correspond to the new DataEntry, like for example :
29 - SetValEntry -> SetEntryString
30 - SetBinEntry -> SetEntryBinArea
31 This change will remove all useless creation of the string when working
34 Thu Aug 25 16:59:49 2005 by jpr
36 Now Print displays the BinEntry Content (if it's printable, and loaded)
37 Usefull for a lot od Implicit VR 'Bin'Entry (if we knew there VR, they wouldn't
39 Appreciate the difference having a look at PrintFile result for
40 gdcmData/SIEMENS_MAGNETOM-12-MONO2-FileSeq0.dcm.
42 Thu Aug 25 16:55:47 2005 by jpr
44 Add methods to check the 'printability' of a bin area
46 Thu Aug 25 15:45:40 2005 by jpr
48 According to Mathieu's suggestion, Print now display FL BinEntries in a human
51 Thu Aug 25 15:12:43 2005 by jpr
53 According to Mathieu's suggestion, *all* the elements 0x000
54 are now named 'Group Length' (even if they belong to a Shadow Group')
56 Wed Aug 24 14:09:13 2005 by jpr
57 gdcmDocEntry.cxx,h, gdcmDocEntrySet.cxx,h
58 Removal of QD patch for Private Sequence + Immplicit VR.
59 Add a clean solution (Backtracking if an Item Starter is found
62 Tue Aug 23 14:57:49 2005 by jpr
64 Brutal patch, waiting till we find a clever way to guess
65 if a doc entry is a Sequence,
66 - when it's odd number
67 - and the file is Implicit VR Transfert Syntax
68 It solves temporarily some Philips Medical Systems image problems
70 Mon Aug 22 18:17:54 200 by jpr
72 Save a *few* microseconds at run time : inline method Util::GetVersion()
75 Tue Aug 23 14:58:49 2005 by jpr
76 gdcmSeqEntry.cxx, gdcmDocEntry.cxx
77 Improve 'Print' methods
79 Sat Aug 20 11:10:24 2005by jpr
81 Use new style FileHelper contructor
83 Sat Aug 20 11:04:50 2005 by jpr
85 FileHelper::Initialize() doesn't call GrabInformationFromFile(),
86 in order not to do the job twice when using new style FileHelper Constructor.
88 Fri Aug 19 18:31:07 2005 by malaterre
90 ENH: Provide a GetVersion function, apparently need for python
92 Fri Aug 19 15:12:15 2005 by jpr
94 Initialize UserFunction pointer to 0, even for 'deprecated' form
97 Sat Jul 30 20:27:00 2005 by jpr
98 gdcmFileHelper.cxx, gdcmPixelReadConvertor.cxx
99 User is now allowed to pass a Pointer to a function of his own
100 to allow modification of pixel order (i.e. : Mirror, TopDown, )
101 to gdcm::FileHeleper, using SetUserFunction(userSuppliedFunction)
102 described as : void userSuppliedFunction(uint8_t *im, gdcm::File *f);
103 NB : the "uint8_t *" type of first param is just for prototyping.
104 User will Cast it according what he founds with f->GetPixelType()
105 See ctkgdcmSerieViewer for an example
107 Sat Jul 30 20:13:24 2005 by jpr
109 Add SerieHelper::IsCoherent() method to allow checking that the files with same
110 Serie UID have the same sizes and pixel type.
112 Fri Jul 29 17:07:16 2005 by jpr
115 SetSortOrderToDirect() or SetSortOrderToReverse()
116 to choose the ways the File* will be sorted.
118 Thu Jul 21 06:55:50 2005 by jpr
119 AnonymizeDicomDir.cxx, AnomymizeNoLoad.cxx, PrintFile.cxx, PrintDicomDir.cxx
122 Thu Jul 21 06:55:30 2005 by jpr
124 Add an example of use for SerieHelper
126 Thu Jul 21 07:00:15 2005 by jpr
128 Extend 'Restriction' syntax :
129 void SerieHelper::AddRestriction(uint16_t group, uint16_t elem,
130 std::string const &value, int op)
132 /// \brief comparaison operators
142 Wed Jul 20 15:39:00 2005 by jpr
144 AnonymizeNoLoad user can now ask for anonymization of 'BinEntries'
145 (e.g. Private entries when the TS is Implict VR)
146 AnonymizeNoLoad filein=... rubout=0x0009-0x0001,0x0013-0x1100
147 Thx to Luca Picello for reporting pb and supplying data to fix the bug.
149 Wed Jul 20 16:49:41 2005 by jpr
151 Use GDCM_LEGACY for DicomDir, as well
153 Wed Jul 20 15:31:01 2005 by jpr
155 We can now anonymize 'BinEntries' as well
157 Wed Jul 20 15:29:42 2005 by jpr
159 Add ArgMgrGetXInt16Enum to decode from the command line pairs of unsigned int
160 16, written in hexadecimal.
161 (usefull to allow terminal user to pass the (private) elements he wants to
164 Tue Jul 19 17:25:53 2005 by jpr
166 Add some comments on the 'Patient Position'
168 Tue Jul 19 11:04:58 2005 by jpr
170 Add SerieHelper::AddGdcmFile(File *header) method.
171 * \brief add a gdcm::File to the first (and supposed to be unique) list
172 * of the gdcm::SerieHelper.
173 * \warning : this method should be used by aware users only!
174 * User is supposed to know the files he want to deal with
175 * and consider them they belong to the same Serie
176 * (even if their Serie UID is different)
177 * user will probabely OrderFileList() this list (actually, ordering
178 * user choosen gdm::File is the sole interest of this method)
179 * Moreover, using vtkGdcmReader::SetCoherentFileList() will avoid
180 * vtkGdcmReader parsing twice the same files.
181 * *no* coherence check is performed, but those specified
182 * by SerieHelper::AddRestriction()
184 Mon Jul 18 12:20:20 2005 by jpr
186 In order to prepare the future extension of SerieHelper::AddRestriction (key,
188 operator = { EQUAL, DIFFERENT, LESS, LESSOREQUAL, GREATER, GREATEROOREQUAL}
190 bool Util::CompareDicomString(const std::string &s1, const char *s2, int op)
192 Sun Jul 17 06:27:49 2005 by jpr
194 Use new style for Loading files
196 Tue Jul 12 19:08:12 2005 by jpr
197 gdcmCommon.cxx, gdcmSQItem.cxx
198 To speed up DicomDir, instead of copying -and removing the source afterwards-
199 each entry of the SQItem (found after gdcm::Document parsing) towards
200 the gdcm::Object belonging to the gdcm::DicomDir, we just copy
201 the chained list itself.
203 Tue Jul 12 16:55:43 2005 by jpr
205 AnonymizeNoLoad has now one more option :
207 to give the (single Patient) directory name whose content we want to anonymize.
209 Mon Jul 11 10:20:25 2005 by jpr
210 gdcmDicomDirStudy.cxx
213 Fri Jul 8 21:07:12 2005 by jpr
215 Add the VISIT object within DicomDir
217 Fri Jul 8 12:15:08 2005 by jpr
219 Use new style for DicomDir loading
221 Fri Jul 8 16:36:48 2005 by jpr
223 To remain unimpared, gdcm::FileHelper class needs also its
224 void FileHelper::SetLoadMode(int loadMode)
225 void FileHelper::SetFileName(std::string const &fileName)
226 bool FileHelper::Load()
228 Thu Jul 7 19:31:53 2005 by jpr
230 Begin of kosherization of Example
233 Thu Jul 7 18:37:40 2005 by jpr
235 On the way to gdcm2 ...
236 Now, the stand way to use a file is :
237 gdcm::File *f = new gdcm::File();
238 f->SetLoadMode ( user say here what he wants *not* to load );
239 f->SetFileName("myFile.gdcm");
241 Old styles are kept, not to break the C++ API.
242 - gdcm::File *f = new gdcm::File("myFile.gdcm");
243 - f->Load("myFile.gdcm");
244 Due to the syntaxic abilities of Python maybe some troubles will occur
247 Thu Jul 7 15:55:39 2005 by jpr
249 Comment out the time consuming, never used/useless
250 'Extended tag' stuff for Sequence embedded Entries
252 Thu Jul 7 15:11:38 2005 by jpr
254 Move code lines LTTG so save some CPU time.
257 Tue Jun 7 13:12:10 2005 CEST by jpr
259 Use Argument Manager in 'utilities'
261 Thu Jul 7 12:12:32 2005 by jpr
263 Due to something stupid in the gdcm::File constructor, the file was parsed
264 twice when we used old style, e.g :
265 gdcm::File *f = new gdcm::File(fileName);
266 instead of new style, e.g. :
267 gdcm::File *f = new gdcm::File( );
268 f->SetLoadMode ( choose what you want *not* to load here );
271 Wed Jul 6 11:53:43 2005 by jpr
272 TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx
273 Now TestAllReadCompareDicom.cxx TestReadWriteReadCompare.cxx accept a third
274 param, in order not to have to recompile to gdcm::Debug::DebugOn().
276 Wed Jul 6 17:18:42 2005 by jpr
278 According to Mathieu's requirement, Load twice the same file keeps the rseult of
279 the first Load (instead of doing it twice)
281 Wed Jul 6 11:25:12 2005 by jpr
283 - Clean out the Entries if a Document is parsed more than once
284 - Uncomment (usefull) warning messages
286 Wed Jul 6 10:42:33 2005 by jpr
288 - Comment out a for the moment too much verbose warning message.
289 - Delay some statement as late as possible, to save some CPU time when they're
292 Wed Jul 6 13:01:08 2005 by jpr
294 Now gdcmFile::Load() returns false if file is not gdcm parsable
295 Only gdcmDocument::Load() did it, before.
296 Thx to Benoit for reporting bug
298 Sun Jul 3 14:42:04 2005 by jpr
300 Should avoid some troubles with 'no length' SQItems within 'true length'
302 Thx to Loic Boussel for providing data to fix the bug.
304 Sun Jul 3 14:42:04 2005 by jpr
306 Should avoid some troubles with 'no length' SQItems within 'true length'
308 Thx to Loic Boussel for providing data to fix the bug.
310 Sun Jul 3 14:47:23 2005 by jpr
314 Fri Jul 1 13:25:51 2005 by jpr
315 gdcmPixelReadConvert.cxx
316 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
317 (e.g. PrintFile on a DICOMDIR document)
319 Thu Jun 30 16:49:02 2005 by jpr
321 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
322 Boussel's Hall of Shame Dicom images
324 Wed Jun 29 17:58:33 2005 by jpr
326 Add the NO_SHADOWSEQ load mode
328 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
329 * Quite a few new dictionaries were added in gdcm. The file:
330 gdcm/Dict/README should always explain were the info was found
331 (in case of double check). Also some dict are still only
332 express as 'template' (they contain 'xx'), therefore
333 a python script should be run first to generate a full dict.
334 In the longer term this python script should be replaced by
337 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * dicomV3.dic is deprecated in favor of gdcm.dic
339 There is now a dictionary per family:
340 - dicomV3.dic -> DICOM V3
341 - Papyrus.dic -> Papyrus
342 - NIH.dic -> tags that were never allowed in the main standard
344 Fri Jun 24 12:50:20 2005 CEST by jpr
346 Pixel Spacing related problems : update comments.
347 Thx to D. Clunie for providing data to check the code
349 Fri Jun 24 12:55:58 2005 by jpr
350 Summer nights are really too hot to sleep.
351 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
353 Thu Jun 23 11:20:23 2005 by jpr
355 Extend warning message, for debugging purpose
357 Wed Jun 22 10:11:23 2005 by jpr
361 Wed Jun 22 10:00:29 2005 by jpr
362 gdcmPixelReadConvert.cxx
363 Fix misstyping, while removing spurious \t characters
365 Wed Jun 22 09:52:32 2005 by jpr
366 gdcmPixelReadConvert.cxx
367 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
369 That break at lot of viewers ...
370 We now *propagate the sign bit* upon the unused ones, better than masking them
372 Thx to Luca Picello for profiding data to fix the bug
374 Wed Jun 22 09:53:52 2005 by jpr
376 gdcm images are now "GDCM 1.1" built.
378 Mon Jun 20 19:10:17 2005 by jpr
380 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
382 Mon Jun 20 17:58:53 2005 by jpr
384 Preventive bug fix for LUT Data.
385 I said : LUT Date, *not* Palette Color
387 Sun Jun 19 17:57:29 2005 by jpr
389 To avoid warnings at compile time
391 Fri Jun 17 14:27:52 2005 by jpr
395 Fri Jun 17 14:36:07 2005 by jpr
399 Fri Jun 17 14:35:00 2005 by jpr
401 Add some accessors for debugging purpose
403 Tue Jun 14 15:56:41 2005 by jpr
404 gdcmPixelReadConvert.cxx
405 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
406 (3 * 65536 short int ...)
408 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
410 Mon Jun 13 17:43:48 2005 by jpr
411 gdcmPixelReadConvert.cxx
412 Some more oddities dealt with.
413 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
414 Still looking for accurate info on the web about it
416 Fri Jun 10 16:05:38 2005 by jpr
418 Bug fix in Load method.
419 Thx to Benoit for providing fix.
420 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
422 lantency with the Util::Format function
424 Tue Jun 7 15:48:35 2005 by jpr
426 The highy time consuming method GetMacAdress is now called just once
428 Tue Jun 7 11:58:29 2005 by jpr
429 gdcmDicomDirElement.cxx
430 Use TranslateToKey better than Format
432 Tue Jun 7 12:07:20 by jpr
434 Remove some spurious calls to Format
435 // according to 'Purify', TranslateToKey is one of the most
436 // time consuming methods.
437 // Let's try to shorten it !
439 Mon Jun 6 14:37:58 2005
440 class ArgMgr (for Arguments Manager) is designed for
441 command line arguments management
442 (to make programmer's live easier)
443 (could be used for any kind of 'command line program')
445 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Adding users file in CVSROOT for mail blaming
448 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 * Adding potential support for JPEG-LS DICOM files.
451 Fri Jun 3 18:05:23 2005 by jpr
453 Fix VR processing, to be CP-288 conform.
454 Now we can parse any kind of DICOM SR.
456 Fri Jun 3 11:05:15 2005 by jpr
460 Thu Jun 2 15:42:18 2005 by jpr
462 Add warning about Load Mode
464 Thu Jun 2 16:20:14 2005 by jpr
466 Harden gdcm::File::IsReadable(), in order not to be confused any longer
467 by lost of Pixel Element
469 Fri May 27 12:51:00 2005 by jpr
471 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
473 And avoid some memry leaks -hope so-
475 Wed May 25 14:54:17 2005 by jpr
477 Should avoid some memory leaks
479 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Adding potential support for mpeg and jpeg2000 through two new lin
481 - JasPer for JPEG2000
482 - libmpeg2 from the MPEG consortium
483 Also adding intial work to use this lib.
485 Fri May 20 10:27:55 2005 by jpr
488 (this time, it's wasn't dangerous at run time)
490 Thu May 19 17:31:21 2005 by jpr
492 FIX possible troubles when checking
493 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
494 Thx to Mathieu for reporting bug
496 Wed May 18 12:12:07 2005 by jpr
498 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
499 Thx to Dennis Hu for providing a sample image to fix the bug.
501 Tue May 17 14:44:09 2005 by jpr
503 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
504 before 'Pixel Spacing', when we want to get X or Y Spacing.
506 Tue May 17 19:10:49 2005 by jpr
508 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
509 at LTTG (Least Time To Go)
510 around Bits Allocated, Bits Stored, High Bit Position,
511 to avoid unaware user to mess up the stuff.
513 Tue May 3 11:43:04 2005 by jpr
515 Load returns now a bool (allow user not to call IsReadable() )
517 Tue May 3 11:51:06 2005by jpr
519 Now the gdcm::File remains unimpaired after writting, in any case
521 Fri Apr 29 17:10:55 2005by jpr
523 Don't abort the prog when File not open
525 Wed Apr 27 12:00:35 2005 by jpr
527 Removal of now useless lut-related stuff
529 Wed Apr 27 11:52:27 2005 by jpr
531 Pb of 'Bits Allocated = 12' is now dealt with in
532 FileHelper::CheckMandatoryElements, no longer in File::Write.
533 Thx to Mathieu for reporting bug.
535 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
539 Tue Apr 26 18:18:23 2005 by jpr
541 Should leave gdcm::Document constructor in a much quicker
542 and much cleaner way when anything wrong occurs.
544 Tue Apr 26 18:25:49 2005 by jpr
545 gdcmPixelReadConvert.cxx
546 Prepare MPEG Dicom encapsulated processing (within a loooong future)
548 Fri Apr 22 14:59:58 2005 by jpr
550 Modify Print() output
552 Fri Apr 22 15:37:57 2005 by jpr
554 Prepare (future) MPEG integration
556 Thu Apr 21 09:40:00 2005 by jpr
558 Taking into account Dicom MPEG
560 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
561 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
562 But this is a case where we should really signify the user there is
563 few chance the serie is really a serie...
565 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * FIX : on X, the python part is correctly installed. All files are
567 installed in gdcm sub-directory
569 Tue Apr 19 11:58:19 2005 by jpr
571 Should suppress some warnings from Borland compiler
573 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * Builder/ : add something to facilitate the RPM creation of gdcm
576 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
577 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
579 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
581 Thu Apr 14 16:26:19 2005 by jpr
583 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
585 // Old style (still available) :
586 dcmdir = new gdcm::DicomDir(dirName, true);
588 // new style (user is allowed no to load Sequences an/or Shadow Groups)
589 dcmdir = new gdcm::DicomDir( );
590 dcmdir->SetParseDir(true);
591 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
592 dcmdir->Load(dirName);
594 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
597 * Fix compilation on gcc 2.96 (which does not have ios::failure)
599 Mon Apr 4 17:15:24 2005 by jpr
601 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
603 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
605 and it's representation name (for the NIH)
607 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
609 conversion of YBR to RGB pixels. So, now, the conversion is made using
612 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
614 format) to replace 'at-run' dicom files generated by the
615 TestAllReadCompareDicom test
617 Tue Mar 22 12:29:37 2005 by jpr
619 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
620 and it's VR is forced to UL
621 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
622 and/or with Shadow groups
623 use SetLoadMode (NO_SEQ | NO-SHADOW);
625 Tue Mar 22 12:40:13 2005 by jpr
627 *FIX Restore pushed out elements
629 Fri Mar 11 12:08:31 2005 by jpr
631 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
633 Fri Mar 11 12:12:13 2005 by jpr
635 Final removal of gdcmFileHelper::InitializeDefaultFile();
637 Wed Mar 9 20:29:38 2005 by jpr
639 Add Anonymize method (not yet fully checked)
641 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
644 Wed Mar 2 18:18:32 2005by jpr
646 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
649 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
652 Mon Feb 21 18:45:41 2005 by jpr
654 * Replace method CheckMetaElements by CheckManadatoryElements
655 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
656 (probabely some stuff still missing)
657 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
658 between a given call and the next one (to add images to a Serie he just
660 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
661 between a given call and the next one, or to reuse an already existing
662 Study UID (i he wants to add his own Series to an already existing Study)
664 Thu Feb 17 17:18:33 2005 by jpr
666 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
667 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
668 Thx to Benoit for reporting bug
670 Thu Feb 17 11:56:20 2005 by jpr
672 Prepare FileMetaInformationVersion (group 0002) management
674 Thu Feb 17 12:02:47 2005 by jpr
676 Group 0002 management
678 Thu Feb 17 12:03:32 2005 by jpr
679 gdcmDocEntryArchive.cxx
682 Wed Feb 16 11:19:19 2005 CET by jpr
683 gdcmPixelReadConvert.cxx
684 Taking into account MONOCHROME1 + Signed Pixels (?!)
686 Tue Feb 15 19:12:34 2005 by jpr
688 Taking into account the difference between MONOCHROME1 (low values = bright)
689 and MONOCHROME2 (low values = dark)
691 Mon Feb 14 11:45:04 2005by jpr
693 Remove some useless mask operations, to save CPU time
695 Mon Feb 14 15:51:10 2005 by jpr
697 *never* forget to re-compile just *before* committing!
699 Mon Feb 14 15:34:27 2005 by jpr
701 First commit on the post 1.0 (Version? / Tag? / Branch?) :
704 Mon Feb 14 11:45:47 2005 by jpr
706 remove useless comments
708 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * Testing/TestMAkeIcon.cxx : complete the test
711 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
714 Fri Feb 11 16:22:18 2005 by jpr
716 Typo, comments, doxygenation
718 Thu Feb 10 11:55:26 2005 by jpr
720 AnonymizeNoLoad improvement
722 Thu Feb 10 10:07:19 2005 by jpr
724 Duplicate Matthieu's hack to prevent bombing in Anonymize
726 Thu Feb 10 12:20:34 2005by jpr
728 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
730 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
731 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
732 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
733 virtual bool SetValEntry(std::string const &content,
734 virtual bool SetBinEntry(uint8_t *content, int lgth,
735 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
736 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
737 virtual ValEntry *InsertValEntry(std::string const &value,
738 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
739 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
741 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
745 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
748 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
749 * Test/ : accelerate tests (it's not very significant accelerations).
750 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
752 Mon Feb 7 15:48:34 2005 by jpr
754 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
757 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * Testing/TestSequence.cxx : add test for sequences of images... test that
759 we have the same serie or the same study UID
761 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
762 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
764 * src/gdcmDict.h : remove commented code
765 * src/gdcmDocument.cxx : initialize values
766 * src/gdcmFile.cxx : bug fix when reading values
767 * gdcmPython/demo/ : change file names. Remove useless files
769 Sun Feb 6 15:31:09 2005 by jpr
771 Update comments for DicomDir stuff
773 Sun Feb 6 15:39:35 2005 by jpr
775 * Add method File::AnonymizeNoLoad, to allow anomymizing files
776 even when the pixels are not gdcm Readable
777 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
778 to allow user to choose the elements whose value
779 he wants to white out / replace
781 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
782 * src/gdcmFile.cxx : remove the default array of initialization.
783 The static array contained pointers to non-static values (comming from
784 strings). To have coherences, when creating files, these values can't be
785 static. So, the array can't be static, too ! To simplify, the array have
786 been replaced by repeted lines to insert values in the File
788 Fri Feb 4 15:49:01 2005 by jpr
790 * Add GetFirstValEntry + GetNextValEntry, for Python users
791 * Some more Doxygenation + typo fixing
793 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
794 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
795 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
797 Thu Feb 3 18:12:46 2005 by jpr
798 gdcmPixelReadConvert.cxx
801 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
802 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
803 (Dicom Element) into the Sequence Item
805 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
806 * src/*.cxx : first parss to normalize file organisation
808 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
809 * src/gdcmDirList.[h|cxx] : add method to find a directory
810 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
812 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
813 * Finish cleaning up my JPEG mess. Should be ok now.
814 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
815 contained within the RLE* class(doh!)
817 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
818 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
819 * SerieHeader::AddFileName() creates as many Coherent Files lists
820 (same Serie UID) as it founds different Serie UID
821 amongst the files instead of discarting any file
822 that doesn't match with the first one he found.
823 * SerieHeader::OrderGdcmFileList has now one parameter :
824 the Coherent Files list the user wants to sort
825 * SerieHeader::GetFirstCoherentFileList() |
826 * SerieHeader::GetLastCoherentFileList() | allow to parse
827 the set of Coherent Files lists
828 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
829 compatibility (it returns the *first* Coherent Files list,
830 since there was only one before)
831 * Test/TestSerieHeader gets gdcmData as a default root directory
833 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * Remove friend between DocEntry and File classes
835 * Remove friend between PixelReadConverter and RLEFramesInfo,
838 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
840 0002|0000. The value was incorrect.
842 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
845 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
846 * src/gdcmUtil.cxx : compilation fix on Win32
847 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
848 variable, to be easy found. Add methods to change the default UID.
849 Amelioration of the CreateUniqueUID to use the correct default UID.
850 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
853 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
854 * Test/TestVR.cxx : fix memory leaks
856 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
857 * Rewrite the base 256 to base 10 conversion, using string operation only.
858 This allows us to get rid of the problematic 64bits integer type (does not
859 always exist on target platform).
861 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
862 * Add construct and destructor to class gdcm::Debug to close the debug file
864 * Don't let uset to open twice the same file
865 * gdcm has now an official UID prefix,
866 supplied by http://www.medicalconnections.co.uk
867 1.2.826.0.1.3680043.2.1143
868 (Thx to Mathieu for providing URL)
869 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
870 to be able to perform some more tests
871 * gdcm::ContentEntry : Contructors and Destructor are now protected,
872 in order to be sure no user will try to use them.
873 (at user level, only the children classes are meaningfull)
875 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
876 * move RLEInfo & JPEGInfo from Document to File
878 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * FIX : remove so many friend between classes
881 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
882 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
883 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
885 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
886 In order to avoid missbehaviour :
887 . gdcm::DocEntry is now specialized in
888 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
889 - gdcm::ContentEntry (Dicom entry with a 'content')
890 . gdcm::ContentEntry is specialized in
891 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
892 characters value, or integers)
893 - gdcm::BinEntry (Dicom entry with a non strig representable value
894 (user hasn't any longer to thing about the precedence of his dynamic_casts)
896 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
897 * Test/VTKTest*.cxx : bug fix under linux
899 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
900 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
901 use with python. Some methods are moved from Document to ElementSet or
902 DocEntrySet. The equivalent methods to ElementSet have been added to
903 SQItem and are virtual in DocEntrySet. Methods that may have the same code
904 in SQItem and ElementSet is directly placed in DocEntrySet
906 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
907 * Test/VTKTest*.cxx : remove the show variable in each test method because
908 it's useless (the viewer variable replace this variable)
910 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
911 * src/gdcmDocument.cxx : bug fix on potential memory leak
912 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
913 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
914 Add ClearXxx methods to remove all the content of the list or map
915 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
917 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
918 * methods ReplaceOrCreate renamed as Insert
919 (nobody will be any longer confused by 'CreateOrReplace')
921 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * Grealty simplify the JPEg decompression, no need to differenciate based on
923 the JPEG possible type (with/without fragment, with/without multiple frame).
924 Everything is done throught the JPEG IO Suspension mechanism in IJG
926 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
927 * Stage 3 of normalization :
928 in order to avoid any missunderstanding while reading method names :
929 - All the methods xxxEntry now deal with dicom Entries
930 - Methods GetEntry splitted into
933 - Method SetEntry renamed as SetEntryValue
934 - Method SetEntryBinArea let as it was
936 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
937 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
938 - Position correctly the entry points for JPEG2000 and JPEG-LS
939 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
941 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
942 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
943 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
944 with other method names
945 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
946 * Test/TestDicomDirElement.cxx : add new test
948 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
949 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
950 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
951 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
952 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
953 So can't you use __int64 in ostream at all.
955 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
956 * bug fix for compilation on MSVC6
957 * gdcmPython/gdcm.i : rename of classes missed
959 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
960 * Stage 2 of names normalization :
961 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
962 (easy to understand ...)
963 - gdcm::FileHelper replaces old class gdcm::File
965 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
966 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
967 type and not a string. So, there remove problems on the format of the
970 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
971 * Add Example/TestPapyrus.cxx
972 - reads a Papyrus file (gdcm::Header compliant),
973 - gets the pixels of all the images, using low level iterators
974 - writes an multiframes Dicom image.
975 (Just to show it's *possible* to do that)
976 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
979 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
980 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
981 Thus, DicomDirXXX are created with a flad that indicates if the created
982 object is empty or not (when not empty, the DicomDirElement is used to
985 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
986 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
987 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
989 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
990 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
992 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
993 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
994 Remove all access to the hash-tables or lists in the objects.
996 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
997 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
998 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
999 be complient with all the gdcm source code
1001 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1002 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
1003 DictEntry or the VR.
1005 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1006 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
1009 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1010 * Test/ : rename VTK tests to have a best name for the tests
1011 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
1012 GetFirstEntry/GetNextEntry use
1014 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1015 * In SerieHeader::ImagePositionPatientOrdering()
1016 // a Dicom 'Serie' may contain scout views
1017 // and images may have differents directions.
1018 // -> More than one may have the same 'pos'
1019 // Sorting has then NO meaning !
1020 Thx to Eduardo Davila for reporting bug.
1022 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1023 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
1024 test. Now it's on image content and not on the resulting visualisation...
1025 might solve the problem on linux when using the OpenGL drivers
1027 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1028 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
1029 DicomDirSerie, DicomDirImage
1030 Dict, DictSet classes :
1031 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
1032 -remove InitTraversal method.
1033 * UPD Test programs + Example programs
1035 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1036 * remove useless and never updated keyword \ingroup
1037 * Solve pb when structure (list, map, ...) is empty.
1038 Thx to Benoit for reporting bug
1040 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1041 * Taking into account of 'Transfer Syntax' value
1042 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
1045 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1046 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
1047 is no memory access violation
1048 * gdcmPython/demo : add python demos using VTK
1050 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1051 * FIX 'Dictionnary' is now spelt 'Dictionary'
1052 'wether' is now spelt 'whether'
1053 'archieve' is now spelt 'archive' ;-)
1055 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1056 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
1057 related methods, in order not to expose internal mechanisms
1060 * REM methods that exposed internal mechanisms :
1061 DicomDir::GetDicomDirPatients()
1062 DicomDirPatient::GetDicomDirStudies()
1063 DicomDirStudy::GetDicomDirSeries()
1064 DicomDirSerie::GetDicomDirImages()
1065 * UPD Test programs :
1069 * UPD Example program
1071 * ADD DictSet methods
1075 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * Removed the Print/indent/default parameter mess. There is absolutely no
1077 reason to have to methods, moreover with the second taking the ostream as
1078 *SECOND* parameter. This was clearly a bad hack to get things compile.
1080 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1081 * Complete rewrite of the GetMacAddress code. Now the code is *much*
1082 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
1083 Unfortunately the main code does not work on SunOS, thus provide a specific
1084 code for this platform only (and Win32 of course). Since this seems to be
1085 working, change CreateUniqueUID to use GetMACAddress instead of the
1086 problematic GctestetIPAddress
1088 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1089 * Unfortunately to be able to test gdcmDirList I had to break the API
1090 a little. Now the class is not a std::list anymore but has a member
1091 std::vector (more ITK compatible). Allow unit testing on Win32 and
1094 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1095 * Update SerieHeader to take into account a Serie Instance UID to properly
1098 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1099 * ENH - Comment out Mathieu's (dangerous) Super Hack
1100 for dealing with BIGENDIAN processors
1101 - Move equivalent stuff to BinEntry::WriteContent
1102 When necessary, 16 Bits Pixels are swapped in a small buffer
1103 and then written. This avoid allocating a huge buffer, in
1104 PixelWriteConvertor, and avoid modifying the Pixel Area.
1106 Probabely, the same operation will have to be done when we want
1107 to write image with Big Endian Transfert Syntax,
1108 and we are working on Little Endian Processor
1110 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1111 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
1113 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
1114 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
1115 all the dict content.
1116 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
1118 * Test/TestDict.cxx : add a new test for the dict classes
1120 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1121 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
1122 file. Debug is yanked if compiled with NDEBUG
1124 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1125 * src/gdcmDictSet.h : set the default output to the os variable
1126 * src/gdcmDictEntry.[h|cxx] : add the Print method
1127 * gdcmPython/demo/ : add a new test
1129 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1130 * merging of Test/PrintDicomDir and Test/TestDicomDir
1131 * removal of now redundant Test/PrintDicomDir
1132 * enhancement of Example/PrintDicomDir
1134 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1135 * Now, python test might work on systems
1136 * Add the PrintDicomDir test
1138 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1139 * FIX : First entry following group 0002 was lost for
1140 Explicit Big Endian Transfer Syntax files
1141 (group and elem not swaped)
1143 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1144 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
1145 Big Endian Transfer Syntax supposed the group following 0002
1146 begins always by element 0000 (element 0000 is *optional*)
1147 To avoid further troubles, let's be pessimistic, and use
1148 Document::HandleOutOfGroup0002() method
1149 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
1150 (related pb not yet solved)
1152 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1153 * Bug fix for the python part use
1154 * Now, PrintHeader.py pass... but outside the ctest use. shit !
1156 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1157 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
1159 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1160 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
1161 a string and should ask the global TS dict what are the propreties of
1164 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1165 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
1166 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
1167 to swap the Swap Code, at parsing time, when we come out of group 0002
1168 and Transfer Syntax is Big Endian
1169 We should be able to read now 'true DICOM" Big Endian coded images
1170 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
1171 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
1173 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * Hopefully fix the bug on MacOSX and static global initialization.
1175 This is the only -minor- patch I found that both please MacOSX and VS6.
1176 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
1177 but this would require a lot of change. Another approach would be that Global
1178 create those string and GDCM_UNFOUND becomes a pointer to a string (which
1179 gdcm::Global would destroy at exit).
1181 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1182 * Fix bug on MacOSX with static initialization in a multy threaded
1183 environment. static const string in a header file used to be ill
1184 initialized provoquing the freeze of any tests. patch should solve this
1187 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1188 * According to Benoit's suggestion, and without any objection from anybody
1189 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
1190 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
1191 - method gdcmDicomDirObject::GetEntry() renamed as
1192 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
1194 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
1196 you debug/warning message just as c++ streams which make them very convinient
1197 to use. Once this is stabilize I will change the ostringstrem to be
1198 redirected to a file (ofstream).
1199 * Properly support C99 extension: __FUNCTION__ which allow us to display
1200 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
1202 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1203 * Removal of useless and dangerous methods :
1204 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
1205 GetDocEntryByName, GetEntryByName, GetDictEntryByName
1206 * Removal of usless methods :
1207 Dict::PrintByName, Dict::GetDictEntryByName
1208 * Commenting out of probabely useless methods :
1209 Dict::GetDictEntryNames()
1210 Dict::GetDictEntryNamesByCategory()
1211 DictSet::GetPubDictEntryNames()
1212 DictSet::GetPubDictEntryNamesByCategory()
1213 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
1214 * ENH : Use dicomTS.dic as described in 2004 version
1215 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
1216 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
1217 Add Accessors on VM (Value Multiplicity), and VM related methods
1218 * ADD : Add a list of 'Dicom Attribute types', as found in
1219 http://medical.nema.org/dicom/2004/04_15PU.PDF
1221 * ADD : Add dicomGroupNameAbbreviations.dic
1222 should be used to write a method to replace the former
1223 Dict::GetDictEntryNamesByCategory()
1225 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1226 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
1227 to read in the file... and only it ! Length is the efective length of the
1228 data in the DocEntry structure
1230 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1231 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
1232 And now use a static function call instead, with a global variable. i
1233 This is much closer to the VTK approach. Hopefully should be bulletproof
1234 and easier to use...hopefully
1236 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1237 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
1239 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1240 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
1242 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1243 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
1244 ValEntry, BinEntry, SeqEntry creation or replace
1246 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
1248 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
1250 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
1251 when specifying the VR
1252 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
1253 * src/gdcmDocEntry.cxx : amelioration of print
1255 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
1256 * ADD : Add the method Util::IsCurrentProcessorBigEndian
1257 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
1258 * ADD Method Document::ComputeGroupLength
1259 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
1260 in order to allow further VR modification by user
1261 * REM : removal of once-called method File::WriteBase
1262 integration of its code in formerly one-line method File::Write
1264 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1265 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
1266 replace the different values "??", "Unkn", "Unknown".
1267 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
1268 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
1269 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
1270 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
1272 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1273 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
1275 * Set the gdcm::Base class to some Printable classes
1277 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1278 * src/gdcmFile.[h|cxx] : add the Print method
1279 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
1280 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
1281 * src/gdcmDocument.h : remove the PrintLevel informations
1282 * Example/PrintFile.cxx : use the new gdcm::File::Print
1284 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1285 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
1286 problems when compiling with the python wrapping
1288 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1289 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
1290 writting in ImplicitVR
1292 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
1293 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
1294 JPEG decompression, especially when dicom frames are split into several
1295 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
1296 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
1298 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1299 * src/gdcmHeader.cxx : change the initialisation of default header.
1300 Now, this header is readable by gdm, e-film, DicomWorks
1302 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1303 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1304 Rename Decompressed to Raw
1305 * Use the API changes in gdcm::File.
1306 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1309 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1310 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1311 each added entry in the header. Replace the 'Planes' field by the 'Number
1314 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1315 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1316 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1318 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1320 At this time, this image isn't readable by e-film... waiting JPR help to
1323 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1324 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1325 DocEntry. Now use methods of the Document !
1327 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1328 * Test/ShowDicomSeq.cxx : bug fix
1330 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1332 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1333 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1334 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1336 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1337 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1338 containing found sequences
1340 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1341 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1343 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1344 Some fields in BinEntry must be copied to not seg fault when making the :
1345 gdcm::File *copy = new gdcm::File( copyH );
1346 and tests are now made on good variables
1348 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1349 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1350 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1352 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1353 * Add vtkGdcmWriter example and test
1355 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * Test/TestUtil.cxx : reformat the source code
1357 * vtk/vtkGdcmReader.cxx : remove and change prints
1358 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1360 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1361 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1363 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1364 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1365 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1367 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1368 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1369 by an eof to prevent all bad read of the file... and in this case, the
1370 file isn't readable.
1372 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1373 * Example/Volume2Dicom.cxx : comment unused variables
1374 * Test/PrintDicomDir.cxx : comment unused variables
1375 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1376 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1377 method that is redondant with AddEntry.
1378 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1381 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1382 * Bug fix due my last commit (compilation under Windows).
1383 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1384 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1386 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1388 - Remove printf / sprintf
1389 - include iostream AFTER gdcm so we don't get warnings
1390 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1392 - Also remove tons of include from header files, hopefully this should
1393 speeup the compilation time, since it was becoming a dog slow.
1394 - Remove gdcm.h as it include way too many files and slow down compilation
1395 (plus it is not up to date)
1396 - remove 'using namespace std' this is BAD !
1398 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * Remove memory leaks on the DicomDir
1400 * Remove some useless data in DicomDirObject
1401 * Add usefull methods in SQItem, to be complient withe the ElementSet
1403 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1404 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1406 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1407 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1408 future, with convertion)
1409 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1410 and ImageDataSize values. Remove the method to get the PixelReadConverter
1411 from the output of the class
1413 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1414 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1416 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1417 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1418 and vtkErrorMacro use.
1419 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1421 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1422 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1424 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1425 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1426 The string leaves only in the fonction. So when we make a .c_str(), we
1427 get the pointeur on the first element, element that will be destroyed
1428 immediately after thee instruction.
1429 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1430 file has been opened : the test must be made on the content of the
1431 pointer and not directly on the pointer !
1434 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1435 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1436 the python part recompiles
1438 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1439 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1440 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1441 X session is killed (for my computer... it seems to not be identic on
1444 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1445 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1446 avoid problems (otherwise, the difference test between the visible image
1447 and the reference is incorrect. If the reference is greater than the
1448 screen resolution, it's produce errors).
1449 Can be used for only one image. Can be used with a visible flag.
1450 * vtk/vtkGdcmReader.cxx : remove commented codes.
1451 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1452 under windows at compilation
1453 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1454 for grayscale images
1455 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1457 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1458 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1459 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1460 tests on the image size X, Y, Z
1462 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1463 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1464 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1465 between the class name and the file name
1467 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1468 * src/ : fix compilation warnings for the Write method (2 different
1469 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1470 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1471 variable... create a static method in gdcm::Document to access to
1472 this variable content.
1474 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1475 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1476 file, to be accessed by other files (like gdcmFile). Remove commented
1477 code. Move the change of the header to the gdcmFile, using the
1479 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1480 To be sure of that (and simplify calls), the Write of the header now
1481 gets a file name and not a file pointer (std::ifstream).
1482 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1483 DocEntryArchive. Remove all open of the written file
1485 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1486 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1488 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1489 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1490 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1492 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1493 some corresponding methods. Write correctly the file and check before
1495 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1496 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1497 is now on RGB data (as before my last commit
1498 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1500 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1502 Add a print information of the type of the entry
1503 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1504 It was in the gdcmFile, and all write have been regrouped
1505 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1506 Write correctly all dicom files (in decompressed mode only at this time)
1507 * Test/ : test on files are now made using Raw data and not color data if
1509 * Example/PrintFile.cxx : add more printings
1511 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1512 * Amelioration of code, remove some code copy. For the loading of
1513 BinEntry (in gdcmDocument), add the test to verify if the file is already
1516 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1517 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1518 remove a DocEntry in the header (push an empty DocEntry)
1519 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1520 lines. Bug fix in the initialization of the PixelConvert and the
1522 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1523 use in TestCopyDicom (now this test can run under windows... but fails)
1524 * Test/TestCopyDicom.cxx : amelioration of the test :
1525 - test the pixels written
1526 - add test points to quickly find where is the error
1527 - can set a file name input and output in arguments
1528 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1529 amelioration of the test output
1531 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1532 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1533 all replaced DocEntry's
1534 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1535 Now, each needed DocEntry to modify is duplicated, modified and inserted
1536 to the header using DocEntryArchive. Thus, after save, we can restore the
1537 header initial state.
1539 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1540 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1542 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1543 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1544 correct to copy it. The DictEntry is specified at the DocEntry creation,
1545 then, it musn't change in the time.
1546 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1547 header correctly. At this time, the change is only made for the first
1548 level of the Document. In the future, it might consider sequences.
1549 The change is made by replacing a DocEntry by an other that is created
1550 outside the class. The old value is kept. When we restore the header
1551 status, the added DocEntry is deleted and replaced by the old value.
1552 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1553 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1554 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1555 the write mode to native, decompressed or RGB (but not used at this time)
1557 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1558 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1559 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1561 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1562 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1563 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1565 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1566 set because already copied when copying the BinEntry's of the header
1567 * Test/TestAllReadCompareDicom.cxx : remove warnings
1569 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1570 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1571 Two problems appear when doing it :
1572 - with the gdcmFile : when the GetImageData method is called, the pixels
1573 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1574 data (pixels). And each structure destruct the data when it's
1575 destructed. So we have two destructions for the same data. To solve it,
1576 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1577 data or not. If it doesn't own data, then they will not destroyed by
1579 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1580 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1581 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1582 create a double destruction of the same DocEntry's. So, to solve it,
1583 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1584 * TODO : add an entry concerning memory leaks in the DicomDir
1586 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1587 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1588 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1591 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1592 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1593 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1594 after it have been deleted
1596 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1597 * FIX: src/* fix the doxygen warnings.
1598 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1599 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1600 was erroneously defined with a size of 15 instead of 16. [many thanks
1601 to Jean Michel Rouet for pointing out this bug].
1603 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1604 1. Finish merging JMR patch for writting DICOM from scratch
1605 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1606 3. Use const ref when possible
1607 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1608 5. A few more comments
1609 6. CreateUniqueUID can now be called without parameter"
1611 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * ENH: Slightly bigger patch:
1613 1. Getting toward full integration of JMR patch for writting dicom from scratch
1614 2. Update Test to test part of this patch: CreateUniqueUID
1615 3. File was not close properly in gdcmDict
1616 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1617 5. Use of const ref instead of copy (speed issue)
1618 6. Remove temporary (duplicate) string in TranslateToKey
1619 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1620 8. Do not repeat virtual in subclasses
1621 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1623 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1624 * Apply first patch toward better string comparison when dealing with broken
1625 DICOM files. Essentially the string could be padded with a space instead
1626 of a null character as defined by standard
1628 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1630 because never used... and in the same time, that's remove some memory leaks
1632 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1633 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1634 * In examples and tests : change the type of image data variables from void*
1635 to uint8_t*. Remmove all delete on image data variables
1637 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1638 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1639 Verify the file pointer value before open the file, and if it's not null,
1640 a verbose message is generated.
1641 Close correctly the file when the file isn't considered dicom-like. The
1642 correctly close is a call to CloseFile.
1643 When closing the file pointer, test if its not null to close the file.
1644 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1645 file. For an uncompressed image, the copied data correspond in the least
1646 case to the image size (calculated) or the image size specified in the
1647 header. A verbose is generated if these two size mismatch
1649 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1650 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1651 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1652 break under windows (with msvc6 compilation).
1654 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1655 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1656 compiling with MSVC6)
1658 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1659 * Bugs fix for the Windows build with VC6
1660 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1661 needed (only for projects required VTK). If the VTK is included in all
1662 projects, there is conflicts with the jpeg lib of vtk when compiling the
1663 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1664 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1665 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1667 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1668 (like it's already made for the cout use). Otherwise, conflict with the
1671 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1672 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1673 * gdcmPython/gdcm.i:
1674 - comments on the DicomDir::Method related usage added.
1675 - now that we use the namespace gdcm, a lot of internal classes do
1676 NOT need to be wrapped anymore.
1677 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1678 DicomDir::Method) new example added.
1680 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * Improve string manipulation. I now inforce the notion of 'DicomString'
1682 A DicomString can contain as many \0 as they want
1683 and it is *always* of even length.
1684 We only support odd length for very rare case.
1685 And in the near future this should be removed.
1687 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1688 * /binary_write/ gdcm source. Now even on big endian we are writting
1689 little endian. This should -heopfully- fix some tests
1691 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * Now the dictionary is compiled into gdcm lib. This is a default
1693 behavior, thus any dic file specified is picked before failback to
1694 the one comiled into lib
1696 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * Change internals for gdcmDict. Don't use any 'new' any more.
1698 This should definitely solve any leak problem, and we should be
1699 as fast as before, as long as don't modify too much the dictionary.
1701 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * STYLE: ivars should start with a capital letter.
1703 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1704 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1706 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1707 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1708 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1709 new 2004 dictionaries added (thanks to JPR).
1710 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1711 * CLEANUP_ROUND (15) for gdcmPixelConvert
1712 - RLEFrame::NumberFragments is now of type unsigned int
1713 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1714 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1717 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * Initial work in gathering all transfer syntax accessors. clearly
1719 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1720 ivars, but only one transfersyntax (class) ivar with equivalent method on
1723 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1725 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1726 discussed (plus I didn't like having a 2000 lines patch not commited)
1728 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1730 * CLEANUP_ROUND (14) for gdcmPixelConvert
1731 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1732 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1733 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1734 CloseFile() anymore.
1735 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1736 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1737 into File::Pixel_Data.
1739 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1741 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1742 * CLEANUP_ROUND (13) for gdcmPixelConvert
1743 Substituted File::ParsePixelData() with PixelConvert::Print() new
1745 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1746 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1747 method to those classes.
1748 - src/gdcmFile.[cxx|h]:
1749 -- Added a ::Print() method.
1750 -- PixelConverter is now a reference instead of a member.
1751 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1752 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1754 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1756 collaboration diagram and inheritance diagram should be generated with
1758 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1759 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1760 pointlessly wrapped (see
1761 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1762 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1763 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1764 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1765 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1766 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1767 -- File::Initialise: PixelConverter setup moved away to
1768 PixelConverter::GrabInformationsFromHeader()
1769 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1770 interpretation moved away to PixelConverter::BuildRGBImage()
1772 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1773 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1774 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1776 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1778 displayed on Win32 when a brutal abort() occurs (because of uncatched
1779 exception). See TODO new entry of this commit for more on this.
1780 * TODO added new entry.
1781 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1782 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1783 - HandleColor is no longer called from gdcmFile.cxx
1784 - gdcmPixelConvert.cxx clean up on method arguments and internal
1785 variable names for semantical coherence.
1787 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1788 * Finished lossless transition, not only do we now read all lossless jpeg
1789 images, without the need of the Cornwell lib, but we do read them properly now
1790 * To reduce code (well to avoid code duplication), I defined a common place
1791 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1792 redefine symbols. This is not perfect but this the best solution I found for a
1793 compilation time jpeg option.
1795 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * Update jpeg ijg lib to support lossless jpeg implementation
1797 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1799 * Also added a special copyright for dcmtk since we use their bugfixes.
1802 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1804 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1805 matters, as stated in warning note at beginning of %include section).
1806 * src/gdcmDicomDir*.[cxx|h]: coding style
1807 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1808 * src/gdcmJpeg8.cxx: doxygen fix.
1809 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1810 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1811 from File:: to PixelConvert::.
1813 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1814 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1815 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1816 - more code moved away from File:: to PixelConvert::
1817 - fat setup of PixelConverter set in place in File::Initialise.
1819 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1820 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1821 namespace at the file system level. So now you should convert your examples
1823 gdcmHeader -> gdcm::Header
1824 It would be nice if people keep in mind to no open the namespace, since it
1825 allows compilation on broken plateform which were defining common symbol in
1826 the standard namespace (like LP, Unknown ...)
1828 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1829 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1830 The JPEG fragments are now parsed at the same stage than the RLE
1831 information. All code related to JPEG is now in gdcmPixelConvert:
1832 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1833 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1834 export a gdcmFile:: method. Those are simply global functions
1835 (for the time being this is better than having them attach to
1836 either gdcmFile:: or gdcmPixelConvert::).
1837 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1838 and stores the result in a gdcmJPEGFragmentsInfo.
1839 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1840 code (among other stuff) moved away from gdcmFile:; to
1843 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1845 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1846 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1847 clean up of RLE related code.
1848 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1849 - src/gdcmRLE.cxx removed
1850 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1851 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1852 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1853 * CLEANUP_ROUND (9) for gdcmPixelConvert
1854 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1855 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1856 away from gdcmFile:: to gdcmPixelConvert::.
1858 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1859 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1860 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1861 This is because Parse7Fe0 used to parse the pixels to compute the
1862 length. This task was passed over to FindDocEntryLengthOB() a long
1863 time ago, EXCEPT I forgot the OW case...
1864 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1865 we just recylce the code for parsing RLE fragments and computing
1867 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1868 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1869 with the retired Parse7Fe0().
1870 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1871 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1873 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1874 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1875 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1876 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1877 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1878 * CLEANUP_ROUND (4) for gdcmPixelConvert
1879 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1880 to return an unused length.
1882 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1884 this should be cleanner from the plane view. The iostream are erally a pain
1885 to use to do simple stuff.
1887 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * Redo the compilation of the ijg jpeg library. Now only one source is
1889 necesseray. No need to rename file by hand what so ever. CMake handle the
1890 copying of the file within different directory, configure header file to
1891 modify some symbol. The only addition made to ijg wasd a mangle table so
1892 that symbol are different whether we are within 8bits or 12bits.
1894 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1895 * Added documentation of vtkgdcmReader on Website:
1896 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1897 with it's binary name).
1898 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1899 the Website to be more complete.
1900 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1901 doxygenated documentation.
1902 - Doc/DoxyVtkGdcmReaderExamples.txt added
1903 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1904 DoxyVtkGdmReaderExamples.html )
1905 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1906 * CLEANUP_ROUND (3) for gdcmPixelConvert
1907 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1909 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * CLEANUP_ROUND (2) for gdcmPixelConvert
1911 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1913 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * CLEANUP_ROUND for gdcmPixelConvert:
1915 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1916 - src/gdcmPixelStuff[h|cxx] removed
1917 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1918 - src/CMakeLists.txt changed accordingly
1919 * GDCMHOME clean up:
1920 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1921 gdcmVersion.py moved to newly created ATTIC related
1922 gdcmPython/SetupOldies/ directory.
1923 * Autotools clean up:
1924 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1925 - autogen.sh configure.in acinclude.m4 python.m4 removed
1927 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1929 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1930 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1932 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * TODO updated with Mathieu suggestions. I proposed a template for
1934 describing TODO entries and used it for new entries.
1935 * Added Doc/Website/CodingStyle.html, Developpers.html,
1936 DeveloppersPython.html, GdcmDataCvs.html and
1937 DownloadVersion0_1.html, DownloadVersion0_3.html.
1938 * Some Doc/*.txt Doxygen files (which do not really concern the
1939 documentation itself, but the website) moved to html and
1940 placed in directory Doc/Website:
1941 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1942 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1943 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1944 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1945 * CMakeLists.txt changed accordingly.
1946 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1947 DeveloppersPython.html
1948 * INSTALL nows refers to Doc/Website/Installation.html
1950 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * Added Doc/Website directory, that contains a first raw version
1954 2004-09-23 Jean-Pierre Roux
1955 * FIX In order not to be poluted any longer by casting problems,
1956 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1957 we can now delete[] it safely
1958 * VoidArea is now called BinArea (less confusing name),
1959 and all the methods called ...VoidArea... are now ... BinArea...
1960 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1962 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1964 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1965 up to the destructor of gdcmElementSet to clean up TagHt and it's
1968 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1970 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1972 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * ENH: added some utility method that builds a flat dictionary
1974 holding all the Dicom entries contained in the recursive structure
1975 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1976 an example of usage.
1977 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1978 BuildFlatHashTable() that build a flat dictionary.
1979 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1980 gdcmDocument is now a friend of gdcmElementSet.
1981 - src/gdcmElementSet.cxx: clean up.
1982 - Example/FlatHashTablePrint.cxx added.
1983 - Example/CmakeLists.txt changed accordingly
1985 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1987 moved away from gdcmDocEntrySet (since this class is an abstract class
1988 acting like an interface). SQDepthLevel and BaseTagKey are now
1990 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1991 and associated accessors. Doxygenation of the class.
1992 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1994 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1995 Use SQDepthLevel accessor instead. ::Print() adapted.
1996 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1997 - src/gdcmDocument.cxx changed accordingly.
1999 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2000 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
2001 - The following is the doxygen comment of the typedef declaration
2002 of gdcmTagKey in src/gdcmCommon.h:
2003 gdcmTagKey is made to old an "universal" (as in URL, Universal
2004 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
2005 A dicom tag always has a group and an element, but a set of tags
2006 embeded in various (optionally nested) sequences and sharing
2007 the same group and element all share the same (group, element)
2008 "identifier". Hence the (group, element) cannot be used as an
2009 identifier (in gdcm we shall refer to a "TagKey") of a tag.
2010 In order to construct a proper tag identifier (i.e. a key) we
2011 consider the following definition of a TagKey:
2012 - let Group, Element be the string representation of the
2013 group and element dicom tag members,
2014 - let ItemNumber be the string representation of the integer
2015 index of the considered item number of a sequence,
2016 Let the key of a tag embeded in a sequence, noted SeqTag, be
2018 /ItemNumber#Group|Element
2019 where "/", "#" and "|" are characters acting as separators.
2020 Then the general form of a gdcmTagKey is given by:
2021 Group|Element<SeqTag>
2022 where <SeqTag> means NO or many instances of SeqTag.
2023 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
2026 but the gdcmTagKey of a tag "embeded" is the first item of
2027 a sequence, itself nested in the third item of a sequence is the
2029 0004|1220/2#0008|0082/0#0008|0090
2030 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
2031 order to hold the new sequence compatible key. Previously, the
2032 GetKey() method would look in the underlying gdcmDictEntry.
2033 - src/gdcmDocEntry.cxx:
2034 -- constructor now copies the underlying DictEntry key, in the local
2036 -- ::Print: displays the member Key, instead of the (group, element).
2037 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
2038 - src/gdcmDocEntrySet.h:xi
2039 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
2040 -- now has a new BaseTagKey member.
2042 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
2043 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
2045 This poses the problem with the semantics of the following lines
2046 LoadEntryVoidArea(0x0028,0x1201); // R LUT
2047 LoadEntryVoidArea(0x0028,0x1202); // G LUT
2048 LoadEntryVoidArea(0x0028,0x1203); // B LUT
2049 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
2050 to the long FIXME note for what the problem is. Nevertheless in
2051 order to get things working the dicom dictionary was altered !
2052 Please fix things urgently...
2053 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
2054 information), see above note on moving the member VoidArea. Nevertheless
2055 the following entries previously correctly set as US are now inproperly
2057 0028 1201 OW IMG Red Palette Color Lookup Table Data
2058 0028 1202 OW IMG Green Palette Color Lookup Table Data
2059 0028 1203 OW IMG Blue Palette Color Lookup Table Data
2060 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
2061 of gdcmDocEntry moved to gdcmSeqEntry.
2062 * src/gdcmSeqEntry.cxx: STYLE.
2064 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * Test/TestAllEntryVerify.cxx minor fix and added comments.
2067 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * gdcmPython/testSuite.py: all the test suite in python is now moved
2069 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
2070 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
2071 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
2073 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2074 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
2075 to avoid inclusion recursion until STL is reached.
2076 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
2077 mecanism. errno.h is not included in gdcm anymore.
2078 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
2079 (gdcmFormatError now inherits from gdcmFormatUnexpected).
2081 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
2082 gdcmData/TestAllEntryVerifyReference.txt
2083 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
2084 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
2085 exception_on_error parameter.
2086 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
2087 - vtk/vtkGdcmReader.cxx changed accordingly,
2088 - Example/*.cxx and Test/*.cxx changed accordingly.
2090 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
2092 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2093 enable_sequences removed from gdcmHeader constructor and dependencies.
2094 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
2095 * gdcmPython/demo/PrintHeader.py: dummy fix.
2096 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
2097 skip_shadow removed from gdcmHeader constructor and dependencies.
2098 * Example/*.cxx and Test/*.cxx changed accordingly.
2100 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2101 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
2102 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
2104 2004-07-21 Jean-Pierre Roux
2105 * FIX Now, Parsing and Printing a DICOMDIR do work!
2106 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
2108 2004-07-20 Jean-Pierre Roux
2109 * FIX Some brain damaged headers have Zero-Lenght fields
2110 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
2112 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2113 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
2114 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
2115 variable (instance of gdcmDebug) by a definition macro, and the instance
2116 is now in static in the gdcmDebug class
2117 * src/gdcmSQItem.h : (FIXME) remove an undefined method
2118 * Test/PrintAllDocument.cxx : bug fix in the result of the test
2120 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * WARNING: ctest now depends more tightly on gdcmData. You should
2122 check out gdcmData properly for things to run smoothly...
2123 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
2124 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
2125 we need the pixels not be loaded in order to use the ValEntry
2126 that displays position and size).
2127 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
2128 This is a C++ based equivalent of gdcmPython/testSuite.py that should
2129 be deprecated. If you have any doubts about the advantages of a
2130 modern scripting language (read Python) versus grass root C++ (i.e.
2131 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
2132 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
2133 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
2134 Anyhow, consider documenting the gdcmData images in
2135 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
2137 * Test/CMakeLists.txt:
2138 - now uses TestAllEntryVerify.cxx
2139 - specific comments on oldACR00001.ima (now renamed in gdcmData
2140 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
2141 gdcmData/TestAllEntryVerifyReference.txt
2144 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * src/*.[h|cxx] : typedef clean up
2146 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
2147 - TagKey renamed to gdcmTagKey (for external usage)
2148 - VRKey renamed to gdcmVRKey (for external usage)
2149 - removal of typedef duplication.
2150 - Removed all unecessary inline keyword from class inline definitions.
2151 - Some method|function(void) declarations replaced with method|function().
2152 * src/jpeg/libijg12/jdhuff12.c:
2153 - printf polluting ctest removed.
2154 - TAB removal for comminting
2156 - TestAllReadCompareDicom.cxx: added a test that compares all the
2157 images in gdcmDataImages.h with corresponding images in
2158 gdcmData/BaselineDicom/. When baseline images are not present
2159 this test creates them.
2160 Note: we need to validate each reference image, but before that
2161 I'd like to rename them with a more explicit name...
2162 - CMakeLists.txt: changed accordingly.
2163 * Example/*.cxx: examples now only include gdcm.h (as opposed to
2164 including each header needed).
2166 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2167 * Test/*.cxx and Example/*.cxx: moved some examples away from the
2168 test suite to the Example directory. Are concerned:
2173 - TestWriteSimple.cxx
2174 * Test/CMakeLists.txt: added some comments on reasons for black listing
2175 image gdcmData/oldACR00001.ima
2177 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * Test/CmakeList.txt: removed the following from black list (to be coherent
2179 with removal from gdcmData):
2180 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
2181 - gdcm-MR-PHILIPS-16.dcm
2183 Added the following because after last cvs update, they cause
2184 ctest -R TestReadWriteReadCompare
2186 - gdcm-MR-SIEMENS-16-1.acr
2188 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
2189 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
2190 new comments in this file) we temporarily (sigh) move to a weaker
2192 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
2193 we don't need to black list the following images anymore:
2194 - 8BitsUncompressedColor.dcm
2196 - US-PAL-8-10x-echo.dcm
2197 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
2198 fixes and the beautified code ;-)
2199 This fixes the bug introduced in version 1.42 (when beautifying)
2200 that made the parsing of 8BitsRunLengthColor.dcm unproper.
2201 Note: ctest was blind to this bug (this means we need to still
2202 improve the test suite). The bug could be detected by using
2203 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
2205 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
2206 and by displaying the (garbage) produced file temp.XDCM...
2208 2004-06-29 Jean-Pierre Roux
2209 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
2210 - replace by uggly but working old code :-(
2211 A lot of things should be OK again.
2212 It's really urgent to have a test suite that *tests*,
2213 to prevent Frog's beautifying sessions to break all the stuff
2214 (twice, withing a fortnigh ...)
2216 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2217 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
2218 redundancy) to added Test/TestReadWriteReadCompare.cxx
2219 * Test/CmakeList.txt: because the compare test of
2220 Test/TestReadWriteReadCompare.cxx fails, the following images are
2221 black listed: - 8BitsUncompressedColor.dcm
2223 - US-PAL-8-10x-echo.dcm
2224 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
2225 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
2226 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
2227 and ad-hoc kludge. This kludge is now removed, and on encountering
2228 such an image (OB field brain damaged) we set errno. Then in
2229 ::FindDocLength() we "fix" the length as being ALL what remains
2230 in the file (until EOF). We then proceed, hoping for the best...
2231 This fixes a SegFault in ShowDicom when trying to write such an
2233 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
2234 (because TestWriteRead breaks on it, after a non conformal commit?).
2235 ctest now runs properly, except for MakeDicomDir (which was always
2236 broken) and the Python related stuff (still not fixed).
2238 2004-06-24 Jean-Pierre Roux
2239 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
2240 FIX : Test/TestReadWrite now iterates on all the file names
2241 (instead of infinite loop)
2242 ENH : Test/TestWriteRead now iterates on all the file names
2244 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2245 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
2247 2004-06-24 Jean-Pierre Roux
2248 FIX : - now Write drops LUT Descriptors and LUTs (if any)
2249 when SamplesPerPixel =3
2250 - now Write is no longer confused by
2251 'BitsAllocated = 12" and 'BitsStored=12"
2252 - "UN" value representation Elements are now written correctly
2253 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
2254 ENH : - now gdcmHeader has its own Write methods
2255 (in order to split the job that has not to be done
2258 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2259 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
2260 loop on the same image until memory went out.
2261 Note: this means we still have gobs of memory loss in PrintDocument
2262 * src/gdcmDocument.cxx: fixes problem on parsing on file
2263 gdcmData/16BitsJpegLosslessGrayScale.dcm.
2265 2004-06-24 Jean-Pierre Roux
2266 FIX : Write - All the Sequences and Sequence Item are now written
2267 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
2268 is added a the end, when necessary.
2269 - A lot of brain-damaged images, that were read correctly are
2270 now written correctly
2271 - length compatible BinEntry are now loaded correctly
2272 (even for odd groups)
2273 Note : only Explicit Value Representation was checked.
2274 (question : is implicit VR really necessary for gdcm ?)
2276 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * DEVELOPPER: added a proposition of coding style.
2278 * src/gdcmDocEntry.h: removed every inline declaration (for test of
2281 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
2283 Use the gdcmDocEntry::Print() and Write() instead.
2284 * src/gdcmDocument.cxx: bug fix.
2286 2004-06-22 Jean-Pierre Roux
2287 FIX : gdcmDocument.cxx
2288 - Now we do recognize the JpegLossLess format (there was a misstyping in
2289 code 'beautyfication' :-(
2290 - Now we automaticaticaly load the Luts, if any
2292 2004-06-22 Jean-Pierre Roux
2293 In order : to write Sequences, whatever their imbrication level,
2294 : to allow user to create his own Sequences
2295 a lot of modif where necessary (adding, moving, or virtualising methods)
2297 WARNING : save your own sources *before* cvs up !
2300 ADD virtual void Write(FILE *fp, FileType filetype);
2303 ADD virtual void Write(FILE *fp, FileType filetype);
2304 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2307 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2308 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2309 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2310 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2311 ADD std::string GetEntryByName(TagName name);
2312 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2314 std::string vr = "unkn",
2315 std::string fourth = "unkn",
2316 std::string name = "unkn");
2317 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2318 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2319 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2320 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2321 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2322 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2323 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2324 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2327 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2328 ADD virtual std::string GetEntryByName (TagName tagName);
2329 ADD virtual std::string GetEntryVRByName (TagName tagName);
2330 REM virtual bool Write(FILE *, FileType);
2331 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2332 FILE *_fp, FileType type);
2333 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2334 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2335 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2336 REM virtual std::string GetEntryByName (std::string tagName);
2337 REM virtual std::string GetEntryVRByName (std::string tagName);
2338 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2339 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2340 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2342 std::string vr = "unkn",
2343 std::string fourth = "unkn",
2344 std::string name = "unkn");
2345 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2346 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2347 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2348 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2351 ADD virtual void Write(FILE *fp, FileType filetype);
2354 ADD virtual void Write(FILE *fp,FileType filetype);
2357 ADD virtual void Write(FILE *fp, FileType filetype);
2358 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2359 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2360 REM std::string GetEntryByName(TagName name);
2363 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2365 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2367 The default constructor invoked by the line
2368 gdcmHeader *f1 = new gdcmHeader( header );
2369 was gdcmHeader::gdcmHeader(bool) instead of the expected
2370 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2371 Hence the parsing wasn't executed... See also below.
2372 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2373 as explicit constructor didn't do the trick to fix the above problem.
2374 Could anyone explain why ?
2375 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2376 properly calls gdcmValEntry::Print() (that was weed out from
2377 code related to gdcmBinEntry).
2379 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2380 * In order to fix memory leaks:
2381 - Test/TestWriteSimple.cxx: added cleaning of free store through
2383 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2384 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2385 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2386 (through the call to ::AddDicomDirMeta()) or the destructor
2387 would crash when deleting uninitialized ::metaElems].
2388 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2389 - src/gdcmDocument.cxx:
2390 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2391 from dynamic stores.
2392 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2393 was causing memory leaks.
2394 - src/gdcmSQItem.cxx:
2395 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2396 cleanly handled with polymophism: sorry but my milage is low).
2397 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2398 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2399 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2400 This avoids SegFaulting.
2401 - src/gdcmSQItem.h: coding style.
2403 - Test/TestWriteSimple still severely sucks. The output image content
2404 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2405 damaged when displayed with vtkgdcmViewer.
2406 - on memory leaks: TestWriteSimple leaks really less (see entry
2407 of 2004-06-18 in Changelog file for the call to valgrind).
2408 - on segfaults: ctest now passes all the tests but one (no more
2410 * Erroneous leading white fix:
2411 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2412 white[s] (as opposed to from >> xxx, that removes it [them].
2413 - src/gdcmTS.cxx: ditto.
2414 - gdcmPython/testSuite.py: dirty related kludge removed.
2415 * src/*: remaining references to gdcmParser removed.
2416 * src/*[cxx|h]: added copy[way]left header.
2419 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * In order to fix writing of dicom files:
2421 - Test/TestWriteSimple.cxx: a simpler example of writing.
2422 - Test/CMakeLists.txt changed accordingly.
2423 - src/gdcmDocument.cxx:
2424 -- The destructor now recursilvely removes potential sequences.
2425 -- Bug fix in ::IsJPEG2000()
2426 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2427 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2429 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2430 to only declared) and build on top of
2431 ::GetDocEntryByNumber(guint16, guint16).
2432 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2433 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2434 for usage in destructor and treatement of promotion in
2435 ::ReplaceOrCreateByNumber().
2436 - src/gdcmSQItem.cxx: destructor should better handle his job.
2437 Test/TestWriteSimple now runs (or at least it DOES something).
2438 * We can now start hutting memory links. A good starting point is:
2439 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2440 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2441 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2443 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * Valgrind note: after Mathieu Malaterre teached me how to read
2445 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2447 Using gcc, you can force the STL to use malloc and to free memory as
2448 soon as possible by globally disabling memory caching.
2449 With 3.2.2 and later, you should export the environment variable
2450 GLIBCPP_FORCE_NEW before running your program.
2451 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2452 simply vanish (it is still not clear to me, whether this means that
2453 STL std::string leaks or if valgrind believes it leaks...).
2454 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2455 running bin/gdcmTests makeDicomDir):
2456 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2457 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2459 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2460 SegFaulting (I drowned in DicomDir related code when trying to
2461 understand why the list is empty...).
2462 * src/gdcmDocument.h: first BSD license header try.
2463 * Doc/License.txt added.
2465 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * src/gdcmDocument.[h|cxx]:
2467 - Clean up of the Transfer related predicates. They are now all based
2468 on new method isGivenTransferSyntax, that (should) handle properly
2469 the padding problem.
2470 - general clean up, simplification, and coding style.
2471 - Specific clean up of Parse7FE0() (umproperly named actually).
2472 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2474 2004-06-14 Jean-Pierre Roux
2476 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2477 - fix the display of SQItem ordinal number
2478 - add the GetSQItemByOrdinalNumber method
2479 - remove some useless never written private methods
2481 2004-06-14 Jean-Pierre Roux
2483 - adding a constructor taking a gdcmDocEntry as an input param
2484 - ReplaceOrCreateByNumber now returns :
2485 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2486 a gdcmValEntry * if a string value is passed as a param
2488 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2489 according to the param type (no longer sets a gdcmDocEntry)
2490 - GetValEntryByNumber, GetBinEntryByNumber added
2491 - NewValEntryByNumber and NewBinEntryByNumber added
2493 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2495 - GetSQItemNumber and SetSQItemNumber added, to provide
2496 a (relative) Item identier inside a given Sequence
2497 \warning : some pb remaining around this number
2499 - AddEntry now takes the Item Number as a param
2501 - adding a constructor taking a gdcmDocEntry as an input param
2503 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Memory leak hunt with the following command:
2505 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2506 --show-reachable=yes gdcmTests PrintDocument
2507 It looks like many (all?) leaks are due to the STL (or a bad usage
2508 of the STL. The lines producing the leaks now have a comment with
2509 a "MEMORY LEAK" tag: you can retrieve them with
2510 grep "MEMORY LEAK" src/*
2511 Here are two typical examples which I can't help fixing:
2516 char * test = "babo";
2517 name = test; //// <--- valgrind detects 960 bytes lost in
2518 //// call to std::string::operator=(char const*)
2519 name.clear(); //// Doesn't help !
2527 std::cout << "Type a bunch of characters followed by RETURN: ";
2528 getline(std::cin, line); //// <--- valgrind dectects a loss
2529 //// of 1320 bytes in call to
2530 /// std::basic_istream<>& std::getline<>
2536 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * src/gdcmHeader.[cxx|h]:
2538 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2539 and related, moved away to gdcmDocument.
2540 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2541 the corresponding protected accessors of inherited class
2542 gdcmDocument, removed ! As a consequence gdcmFile had to be
2543 declared friend of class gdcmDocument (see below).
2544 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2545 - Clean up of undefined or unused methods.
2546 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2547 account the changes to gdcmHeader.h).
2548 * src/gdcmDocument.h:
2549 - gdcmFile is now a friend class (in order to take into account the
2550 changes to gdcmHeader.h).
2551 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2552 (see changes to gdcmHeader.h).
2553 - Accessors (reading on the form GetEntry*) are now public.
2554 - Clean up of undefined or unused methods.
2555 * src/gdcmDocument.cxx:
2556 - adaptation to changes to gdcmDocument.h
2557 - ::OpenFile now writes a verbose message when file cannot be opened.
2558 - some std::string properly set to VRKey
2559 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2560 references to gdcmDocument.
2561 * Test/TestFindTags.cxx: changed accordingly to above changes.
2562 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2563 cvs repository gdcmData.
2565 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2567 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2568 conflicts with gdcmValEntry::voidArea.
2569 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2570 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2571 Value representation between StringRepresentable and BinaryRepresentable.
2572 * src/gdcmDocument.cxx:
2573 - method ParseDES: proper indentation restored and usage of
2574 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2575 - method LoadDocEntry: the fingerprint left in the SetValue() of
2576 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2577 removed. Reverting to previous code segment with the proper
2578 dynamic_cast< gdcmValEntry* >.
2579 Note: this was (partially) breaking the python test suite
2580 (gdcmPython/testSuite.py) that made usage of the above
2581 fingerprint to check presence of "Pixel Data".
2582 * src/gdcmDocEntry.h: coding style.
2583 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2584 now taken into account.
2585 * gdcmPython/gdcm.i: adaptation to the new internal representation
2586 of gdcm (exit gdcmParser, hello gdcmDocument).
2587 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2589 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2590 anymore, but instead prints the loaded Python dictionary.
2591 * .... alas, the python testSuite is still broken.
2593 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2594 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2596 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2597 * src/gdcmUtil.h : export methods
2599 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2600 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2602 * Initial addition of automatic python testing
2603 * Initial addition of automatic image comparison
2605 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2606 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2607 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2609 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2610 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2611 * Test/ShowDicom.cxx : bug fix for msvc compilation
2612 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2614 2004-05-04 Jean-Pierre Roux
2615 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2616 new concepts (and new classes) :
2617 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2618 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2619 - Sequence Doc Entries (gdcmSeqEntries)
2620 a Sequence is composed of Items.
2621 Each item is a set of Doc Entries (this is recursive)
2622 The non uniqueness of the 'Dicom tag' is due to this recursivity
2623 (never taken into account)
2624 Our unability to add a new 'entry' in the header
2625 at the proper location (neither in the H-Table (map or multimap),
2626 nor in the Chained List is also due to this recursivity.
2627 Don't try, right now, to use/modify/compile these new sources :
2628 nothing is finished.
2629 We just commit all the stuff, 'as is', in order not to loose it.
2631 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2632 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2634 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2635 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2636 file prefix (SetFilePrefix)
2638 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2639 * Add a new test: ShowDicom, for now this is just the c++ version of
2640 checkRead.sh, later it will be able to compare the image read against a
2642 * Replace the DEBUG on the stack with a global entry in cmake interface:
2643 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2645 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * Add an example subdir, with a real example on how to read + write a
2649 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2651 * Doc/CMakeLists.txt: the main page is now properly differentiated
2652 between the developper and user version.
2653 * Doc/doxygen.config.in: dropped search related obsolete flags
2654 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2656 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * DEVELOPPER: added some helpfull comments for compile/test/install
2660 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2662 src directory, now generated in the build dir.
2663 2. Tests as mentionned smarter
2665 4. Add a new method in gdcmDict that return the PubDict by name
2666 this is interesting for 3rd party lib like ITK,
2667 where we could set the institution name / patient name...
2669 * ENH: 1. Now the test suite is working for real
2670 2. All binaries are now output in the gdcm-bin directory
2671 (this was not true before)
2673 2004-04-28 Jean-Pierre Roux
2674 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2675 SeQuence indented printing of Dicom Header.
2676 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2677 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2678 Computation of SQDepthLevel is now part of gdcmHeader constructor
2679 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2680 tree-like structure of a Dicom Header.
2681 * FIX Test code cleaning
2683 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2684 * ENH: Adding automatic testing
2685 1. Need a DartConfig.cmake to submit to public
2686 2. Add a test driver gdcmTest.cxx
2687 3. gdcmTestMain, an helper for the main test driver gdcmTest
2688 4. Files in Test don't have a main anymore, this becomes interesting
2689 when we add more and more tests, thus dsw don't have to load
2691 * ENH: Adding a GDCM_DATA_ROOT for testing
2692 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2693 one file instead of seven + some small cleanup
2695 2004-04-22 Jean-Pierre Roux
2696 * ENH Minor changes to the Print() methods.
2697 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2698 Header printing. Example given with :
2699 > PrintHeader fileName 2 new
2700 (SQ based tree-like structure still to be done for the Header ...)
2702 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2703 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2704 1. I have added some unsigned where needed
2705 2. Some function parameter not used -> (void)
2706 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2707 4. g++ don't like character '\' in comment
2708 5. #define jpeg_create_decompress jCreaDecompress
2709 this really need to be fixed
2710 6. virtualize destructor of gdcmObject ... leakage
2711 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2712 this also really need to be fixed
2713 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2714 remove compression file
2715 (as we only do decompression, right ?)
2716 * ENH: Change malloc/calloc/free with c++ equivalent
2718 2004-04-21 Jean-Pierre Roux
2719 * FIX gdcmHeaderHelper::GetXSpacing
2720 when a single value is found (bug ?), xpacing is now
2721 defaulted to yspacing
2723 2004-04-19 Jean-Pierre Roux
2724 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2725 * ENH add parameters :
2726 bool exception_on_error = false,
2727 bool enable_sequences = false,
2728 bool ignore_shadow = false
2729 to the gdcmFile constructors to be full gdcmParser compliant
2730 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2731 to allow reading of PAPYRUS 3.0 files
2733 2004-04-06 Jean-Pierre Roux
2734 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2736 2004-04-02 Jean-Pierre Roux
2737 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2738 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2739 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2741 2004-03-30 Jean-Pierre Roux
2742 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2743 for ACR file, written out as DICOM files (hope so...)
2745 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2747 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2748 moved to base class gdcmParser and only the specialisation is kept
2750 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2751 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2752 already does the job.
2753 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2754 (to be consistent with gdcmParser::WriteEntries).
2756 2004-03-30 Benoit Regrain
2757 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2758 upate of the object's instance. It's passed to 2 in the unfavorable
2759 case : one in the ExecuteInformation, one in the ExecuteData
2761 2004-03-29 Jean-Pierre Roux
2762 * ENH : Check on file type to be written moved
2763 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2764 * FIX : gdcmObject::ResetBoundaries now stops properly
2765 when end-of-list is reached
2766 : gdcmVersion modified (as Benoit Regrain asked)
2768 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2770 * src/gdcmUtil.cxx: added forgotten iostream include.
2771 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2772 equivalent to ExplicitVR in existing code).
2774 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2776 now contains all the gdcmGlobal related code.
2777 * minor coding style and doxygenation changes.
2779 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2781 now contains all the Debug related code.
2782 * minor clean-up of includes in src/*.cxx
2783 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2784 CreateCleanString) removed.
2785 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2786 * Doc/DoxyMainPageUser.txt added.
2787 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2788 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2789 src/gdcmDirList.cxx)
2791 2004-03-24 Jean-Pierre Roux
2792 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2794 2004-03-23 Jean-Pierre Roux
2795 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2796 big endian made volumes
2797 * ENH Now gdcmParser constructor and destructor are protected to forbid
2798 end user to instanciate class gdcmParser
2799 (only gdcmHeader and gdcmDicomDir are meaningfull)
2801 2004-03-22 Benoit Regrain
2802 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2803 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2804 gdcmSerie to gdcmDicomDirSerie
2806 2004-03-19 Jean-Pierre Roux
2807 * ENH Now the tree-like structure describing a DICOMDIR comming from
2808 an already existing DICOMDIR file is consistent with
2809 the home-made tree-like structure build ex-nihilo
2810 or build from the files held (recursively) in a Directory
2811 functions gdcmDicomDir::CheckBoundaries()
2812 gdcmObject::SetBoundaries() added
2814 2004-03-17 Jean-Pierre Roux
2815 * REM (Eric Boix bug) : removal of meaningless
2816 gdcmDicomDirImage::NewImage function.
2817 * FIX now file names and directory name are written properly in the
2819 * FIX now gdcmDicomDir constructor may be call without any trick
2822 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2824 of gdcmDicomDirImage::NewImage as empty function.
2826 2004-02-28 Jean-Pierre Roux
2827 * ENH add gdcmDicomDir:NewPatient
2828 add gdcmDicomDirPatient:NewStudy
2829 add gdcmDicomDirStudy:NewSerie
2830 add gdcmDicomDirSerie:NewImage
2831 to allow making gdcDicomDir object.
2832 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2833 (as opposite to the gdcmHeader chained list)
2835 2004-02-11 Benoit Regrain
2836 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2837 when using from python
2839 2004-02-10 Benoit Regrain
2840 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2841 * FIX : in gdcmDicomDir when the directory is empty
2842 * ENH : add callback and methods to get the progression of dicomDir
2845 2004-02-06 Jean-Pierre Roux
2846 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2847 - GDCM_META added to gdcmDicomDirType
2848 - class gdcmMeta created
2849 * ENH : - A brief summary is now displayed at the beginning of
2850 'testDicomDir' to help disaster magnitude estimation
2851 * REM : Now useless Test/explDICOMDIR.cxx
2853 2004-02-05 Benoit Regrain
2854 * ENH : add methods in gdcmObject to get the hash table or the list of
2856 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2857 * FIX : wrapping python for TagHeaderEntryHT
2859 2004-02-04 Benoit Regrain
2860 * FIX : even length for some strings when writting the dicom dir
2861 * FIX : sort the images in the dicom dir
2862 * FIX : Bug fix for python use of dicom dir
2863 * ADD : a python demo
2865 2004-02-04 Jean-Pierre Roux
2866 * FIX : Final solution (?) for icone embedded images
2867 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2868 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2869 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2870 gdcmData/gdcm-MR-SIEMENS-16.acr1
2871 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2872 to make full checking easier
2874 2004-02-04 Benoit Regrain
2875 * FIX : WriteEntries : coding style & logic in parameters
2876 * FIX : Set the elements to create the DicomDir in a dictionary file
2878 2004-02-03 Benoit Regrain
2879 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2880 * gdcmDicomDir : add the load of directory
2881 * Bug fix and print add-on
2883 2004-02-03 Jean-Pierre Roux
2884 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2885 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2886 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2887 * FIX gdcmParser.cxx : 'group length' elements are now considered
2888 as integers, even for shadow groups, when file is Implicit VR
2890 2004-02-02 Jean-Pierre Roux
2891 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2893 of the last synonym :-(
2894 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2896 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2897 * FIX taking into account the possible 7fe0,0010 multiplicity
2898 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2899 to allow removal of references to 7fe0,0010, to deal with
2900 ACR-NEMA images, when 0028,0200 is meaningfull
2902 2004-01-31 Jean-Pierre Roux
2903 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2904 no longer writes 'Un' on disk
2905 * FIX SQ elements with actual length are now dealt with corectly
2906 * FIX gdcmFile::WriteBase make the difference, for color images, between
2907 the length (for Palette expanded images)
2908 and Raw Length (non expanded image + Palette)
2909 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2910 (that broke Write). Replaced by UL.
2911 Aware user will reload the field if he
2912 thinks it's necesssary
2914 2004-01-30 Jean-Pierre Roux
2915 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2916 when 'dirty Acr' is found, to be compliant with the new
2917 IsReadable() methods.
2919 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2920 (no DOUBLE images in kosher DICOM,
2921 but so usefull for people that miss them ;-)
2923 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2924 DICOMDIR related utilities (not checked as Windoze compliant)
2926 2004-01-28 Jean-Pierre Roux
2927 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2929 2004-01-27 Jean-Pierre Roux
2930 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2931 to allow skipping the shadow elements, to save memory space.
2932 The TRUE value for this param has to be used
2933 with a FALSE value for the 'enable_sequence' param.
2934 ('public elements' may be embedded in 'shadow Sequences')
2935 * gdcmHeader methods now deal with 'embedded icones images' in the header
2936 (even when an 'icone image sequence' is announced by the
2937 element (0x0088,0x0200), but there is NO icone at all ...
2939 * gdcmHeader sometimes Image Location value doesn't follow
2940 the supposed processor endianity (see gdcmData/cr172241.dcm).
2943 * gdcmHeader add the method
2944 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2945 to get *all* the Header Entries with the same tag.
2946 GetHeaderEntrySameName is probabely *useless*
2947 (no meaning : Name is *not* an identifier within the Dictionary)
2949 2004-01-26 Benoit Regrain
2950 * Bug fix in the print of hexadecimal representations. Remove long fields
2951 in the print and add a third level of print to print them
2953 2004-01-23 Benoit Regrain
2954 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2955 * Bug fix on test suite after remove the strip made on not string fields
2956 * Split the IsReadable method between gdcmParser which test that the file
2957 is dicom and gdcmHeader which test that it's an image file
2959 2004-01-22 Benoit Regrain
2960 * DicomDir : clean code, add methods, set variables in protected or private
2961 * gdcmUtil : bug fix for the clean string method
2963 2004-01-19 Benoit Regrain
2964 * Add the use of shadow dictionaries
2965 * bug fix and coding style
2967 2004-01-19 Benoit Regrain
2968 * src/gdcmFile.cxx : bug fix concerning the close of file
2969 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2970 * Add the update of header entries using the shadow library
2972 2004-01-19 Benoit Regrain
2973 * removal of file gdcmHeader2.cxx
2974 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2975 inheriting from gdcmParser. This split is to prepare the integration
2976 of dicom dir parsing
2977 * bug fix under python
2979 2004-01-16 Jean-Pierre Roux
2980 * REM removal of class gdcmHeaderEntrySet
2981 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2982 * ADD add file gdcmHeader2.cxx
2983 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2985 2004-01-15 Benoit Regrain
2986 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2987 entries created while parsing the header. Thus, they will be destroyed
2988 when the gdcmDictSet will be destroyed
2989 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2992 2004-01-15 Benoit Regrain
2993 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2994 made a fatal error because of the memory release at the end of program.
2995 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2996 some memory and vtk seems to have some problems with that.
2997 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2999 2004-01-14 Benoit Regrain
3000 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
3001 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
3002 * src/*.[h|cxx] : make changes due to class name changes
3003 * gdcmPython/demo/*.py : bug fix due to method names
3005 2004-01-13 Benoit Regrain
3006 * src/*.[h|cxx] : coding style
3007 * vtk/*.[h|cxx] : coding style
3009 2004-01-13 Benoit Regrain
3010 * gdcmPython/testSuite.py : test the readable flag of file for tests
3011 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
3012 It's lied to the stl compilation by MSVC (windows, always windows...)
3013 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
3015 2004-01-12 Benoit Regrain
3016 * src/*.h : add comments
3017 * src/gdcmDictSet.h : set the method BuildDictPath in public
3018 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
3019 directly setted in the source code
3020 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
3023 2004-01-09 Benoit Regrain
3024 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
3025 * setup.py : use a reference to gdcmVERSION
3027 2004-01-07 Benoit Regrain
3028 * Modification to compile with the distutils.
3031 2003-12-10 Benoit Regrain
3032 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
3033 can use a gdcmHeaderHelper to load data
3034 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
3035 made in the source code
3037 2003-12-10 Benoit Regrain
3038 * Update Windows projects and .cvsignore files
3040 2003-11-12 Jean-Pierre Roux
3041 * ENH gdcmHeader constructor has one more parameter (default value : false)
3042 that allows the user to 'go inside' the SeQuences only
3044 gdcmElValSet:Print takes it into account
3046 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3047 * ENH: Update gdcmPython/CMakeLists
3048 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
3049 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
3051 2003-11-10 Jean-Pierre Roux
3052 * FIX : gdcmHeader::LoadElements is now based
3053 on the ListTag listElem member,
3054 not longer on the TagElValueHT tagHt member
3055 * ENH : PrintPubElVal shows (temporarily) both results,
3056 with the tagHt member and the listElem member.
3057 (it's easier to 'see' the problems when using Printheader)
3059 * FIX : old private member LgrElem is now splitted into
3060 ReadLength : Length actually found on disk (updated only
3061 if bug fixing is necessary), for internal
3063 UsableLength : Updated by FixFoundLength, to fix a bug
3064 or to allow Parser going on.
3065 Will allow to re-write a kosher header when a SeQuence
3066 with a length (not 0000) is found
3067 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
3068 because gdcmElValSet::Add does not update ListElem
3071 2003-11-07 Jean-Pierre Roux
3072 * FIX misstyping in Transfert Syntax name table
3073 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
3074 when they have an actual length (not 0000 nor FFFFF)
3075 (Nobody should care of it, but DICOMDIR explorers)
3077 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3078 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
3080 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3081 * ENH: vtkGdcmReader now supports LUT !
3082 (vtkgdcmViewer for now is not able to use them though)
3084 2003-11-05 Jean-Pierre Roux
3085 * in testSuite.py : new files names for checking the package
3086 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
3087 that returns the pixel area size to the *aware* (vtk) user
3088 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
3090 2003-11-05 Benoit Regrain
3091 * in testSuite.py : Modify the rules for checking the paths
3092 : Explicit error messages
3093 * in __init__.py : Related modif
3095 2003-11-03 Jean-Pierre Roux
3096 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
3097 to be used by aware (vtk) users that want to manage
3098 LUT (and no to turn the PALETTE image into an RGB pixels one)
3099 * GetPixelType now returns 8U for 24 Bits images
3100 (vtkGdcmReader compliant)
3102 2003-10-31 Jean-Pierre Roux
3103 * Removal of *all* gdcmData images and add them again
3104 in order to loose the 'history' of un-anonymised images
3106 2003-10-31 Jean-Pierre Roux
3107 * RMV : removal of useless jBitsInJsample.h
3108 for both 8 and 12 Bits JPEG Lossy Libraries
3110 2003-10-31 Jean-Pierre Roux
3111 * ENH : Add the functions gdcmFile::GetImageDataRaw
3112 gdcmFile::GetImageDataIntoVectorRaw
3113 that act as GetImageData and GetImageDataIntoVector
3114 except the making of an RGB Plane from Gray Plane + LUT
3115 Intended to aware (vtk) users who know how to manage
3118 GetLUTRGBA return a R,G,B,A LUT if any
3119 lgrTotaleRaw gives the 'Raw' length
3120 GetImageDataRaw returns the gray Plane
3121 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
3122 (They stay Grey, just like with other Dicom viewers :-(
3124 2003-10-30 Jean-Pierre Roux
3125 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
3127 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3128 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
3129 being coherents dicom files.
3131 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3132 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
3134 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
3135 * ENH: Two steps is necessary to please VC++ compiler...
3136 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
3137 * ENH: Add include dir to medcon lib
3138 * FIX: only one function is being exported for now !
3139 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
3141 2003-10-29 Jean-Pierre Roux
3142 * adding gdcmHeader::GetLUTRGBA
3143 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
3144 --> Mathieu, the modif u're waiting for is not yet committed
3145 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
3147 2003-10-27 Jean-Pierre Roux
3148 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
3149 00191113.dcm DermaColorLossLess.dcm
3150 MxTwinLossLess.dcm RadBWLossLess.dcm
3151 * ENH: For version prior to vtkImageViewer2 -r 1.19
3152 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
3154 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3155 * Removal of ido stuff in CMakeLists.txt
3157 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3158 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
3159 * FIX: remove a call to ->Modified ... see comments
3160 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
3162 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3163 * FIX: Problem with path for libvtkgdcmPython
3164 * ENH: Try adding a search script for python site-package
3165 * RMV: Remove some file from medcon lib that are not necessary
3166 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
3167 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
3168 * FIX: More pragma disable fro VC++,
3169 I don't think I break something as it is also disable in VTK/ITK.
3170 But it fasten debug compilation time.
3172 2003-10-23 Jean-Pierre Roux
3173 * gdcm now deals with 16 Bits Run Length Encoded images
3174 (they are compressed as 2 planes images,
3175 one for the high Bytes, the other for low Bytes)
3177 2003-10-22 Jean-Pierre Roux
3178 * Now CheckRead takes into account :
3179 - the bugged 'Leonardo' Siemens images
3180 - the XA images, sent thru the burning VPRO station
3181 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
3184 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3185 * FIX: When copying a Makefile.am to CMakeLists.txt
3186 one should remove the '\'
3188 2003-10-22 Jean-Pierre Roux
3189 * in gdcmData adding a bugged 'Leonardo' Siemens image
3190 (wrong lengths in header)
3191 OK with gdcm, KO with the other viewers :-)
3192 * add a GE dlx XA image, thru the VEPRO burning station
3195 2003-10-21 Jean-Pierre Roux
3196 * in gdcmData add the checkvtkgdcmViewer.sh shell script
3197 for a brutal checking of vtkgdcmViewer compliance
3199 2003-10-21 Jean-Pierre Roux
3200 * add the files for 'xmedcon' Jpeg Lossless library
3201 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
3203 2003-10-21 Jean-Pierre Roux
3204 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
3206 2003-10-21 Jean-Pierre Roux
3207 * garbage Siemens 'Leonardo' images dealt with
3208 (the patch is easy to remove)
3209 * cosmetic changes to avoid warnings
3211 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3212 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
3213 no need to press 'r' now.
3215 2003-10-20 Jean-Pierre Roux
3216 * upgrade of checkRead.sh checkWrite.sh according
3217 to new Jpeg Lossless decompressor
3218 * add US.3405.1.dcm, a genuine RGB medical file ...
3219 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
3220 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
3222 2003-10-15 Jean-Pierre Roux
3223 * general anonymisation in gdcmData
3224 * adding the 'color files' from
3225 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
3226 * adding some well knowed bugged-header images
3227 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
3228 waiting for their inclusion in Python testsuite
3230 2003-10-15 Jean-Pierre Roux
3231 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
3232 no longer seg faults when file is not found
3234 2003-10-14 Jean-Pierre Roux
3235 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
3238 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3239 * TODO: *.in file to genereate a UseGDCM later
3241 2003-10-14 Jean-Pierre Roux
3242 * Some supposed-to-be Dicom Images have no preamble.
3243 OpenFile takes it into account
3244 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
3245 * Missing elements added in dicomV3.dic
3246 (just to be affraid : have a look at
3247 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
3248 and do it again next year ;->
3250 2003-10-13 Jean-Pierre Roux
3251 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
3252 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
3253 But there are NOT. It's fixed !
3255 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3256 * FIX: "jpeglib.h" was not found on VC++
3257 * FIX: vtkgdcm was not being installed
3259 2003-10-10 Jean-Pierre Roux
3260 * ENH : OpenFile closes the file if it *really* doesn't look like
3261 an ACR-NEMA / DICOM one.
3262 * FIX : testWrite no longer writes an empty file if the source file
3263 is not gdcm Readable
3264 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
3267 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3268 * FIX: CMake generate now documentation
3269 * ENH: out of source doc build !
3270 * ENH: Generate both user and dev documentation
3271 * ENH: Should work on windows too
3272 * ENH: Only one doxygen config.in file is needed
3273 * FIX: make install should be ok now on Unix plateform
3274 * FIX: PATH to dictionary was wrong (missing /)
3275 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
3277 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3278 * vtkGdcmReader is now able to read rgb dicom file.
3279 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3280 * added a gdcmViewer to vtk test, use mouse to control
3281 window level & window width
3283 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3284 * CMake-ification of gdcm, we have now two build system
3285 * FIX: on cygwin Wsock32 doesn't exist
3286 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
3288 2003-10-06 Emanuel Ollart
3289 * FIX : compilation process wad broken.
3290 Changed gdcmViewer_sources to vtkgdcmViewer_sources
3292 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3293 * change gdcmViewer -> vtkgdcmViewer
3294 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
3296 2003-10-06 Jean-Pierre Roux
3297 * FIX :A few nasty patches to allow the reading of a lot of nasty images
3298 ( e.g : well known GE images with a wrong elem length,
3299 : Philips MRI Images with a wrong Huffman table)
3300 * still to be done : allow the reading of bugged LEONARDO Siemens images
3302 2003-10-03 Jean-Pierre Roux
3303 * Odd length strings are padded with '\0' (not with spaces,
3304 to remain compliant with already defined strings,
3305 like Transfert Syntax UID and others)
3307 2003-10-03 Jean-Pierre Roux
3308 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3309 to allow displaying RGB images (not only by affim ;-)
3311 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3312 * vtkGdcmReader is now able to read rgb dicom file.
3313 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3315 2003-10-03 Jean-Pierre Roux
3316 * A few nasty patches to allow the reading of a lot of nasty images
3317 ( e.g : well known GE images with a wrong elem length,
3318 : Philips MRI Images with a wrong Huffman table)
3319 * still to be done : allow the reading of bugged LEONARDO Siemens images
3321 2003-10-03 Jean-Pierre Roux
3322 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3324 2003-10-03 Jean-Pierre Roux
3325 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3326 to allow displaying RGB images (not only by affim ;-)
3328 2003-10-03 Jean-Pierre Roux
3329 * gdcmFile::GetImageDataIntoVector now
3330 - deals with MultiFrames MultiFragments Run Length Encoded files
3331 - deals with YcBcR (YBR_FULL) files
3332 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3333 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3335 (no sample found :-(
3337 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3338 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3339 Two reasons: - clear things
3340 - third parties acces gdcm through header files, so won't
3341 suffer anymore VC++ complains
3343 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3344 * add argv[1] in testvtkGdcmReader.cxx
3347 2003-09-24 Jean-Pierre Roux
3348 * The lines are now eigthy characters long for
3349 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3351 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3352 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3353 char* to std::string. Thus, the use of strdup becomes useless. (see
3354 previous commis of Malaterre)
3355 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3356 before the last Malaterre's commit.
3358 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3359 * This commit should fix the Debug building under VC++, the problem
3360 was mainly a mixture of debug and release lib being loaded at startup.
3361 * I also remove a depency to a specific C function: strdup. Because I had
3362 to force the link to msvcrtd (whereas strdup is in libc).
3364 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3365 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3366 located in the gdcmCommon.h file. All use of reference of tha has been
3367 changed to now use the variable GDCM_UNFOUND.
3369 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3371 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3372 Dicom dictionary. The test suite can now be run again. Note:
3373 I'm note very happy with the " (RET)" changes. I believe this
3374 RETAINED comment should be dropped when parsing the dictionary.
3375 - PACKAGER corrected
3377 - AUTHORS updated and now in alphabetical order
3378 * Makefile.am now exports gdcm.dsw for Windoze users.
3380 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3381 * cygwin complains about missing std:: in subdir Test/
3383 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3384 * remove some methods that are now in gdcmHeaderHelper
3386 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3387 * vtkGdcmReader set spacing and origin correctly
3389 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3390 * Fix a few delete/delete[] mismatch
3392 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3393 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3394 interpretation to data given by gdcmHeader. For instance there are
3395 heuristics to get informations (look at different places).
3396 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3397 sorting DICOM images based on different strategies.
3398 * modified Makefiles accordingly.
3400 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3401 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3402 when building in debug mode
3403 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3404 src/win32/gdcmdll.dsp
3405 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3407 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3408 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3411 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3412 * src/win32/libgdcmjpeg12.dsp was not dos format
3413 * src/win32/libgdcmjpeg12.dsp :
3414 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3415 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3417 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3418 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3420 * src/gdcmFile.cxx : bug fix in affectation type
3421 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3422 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3423 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3424 symbols... future problem ?
3426 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3427 * src/win32/libgdcmijpeg12.dsp was missing
3428 * modified gdcm.dsw accordingly
3430 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3431 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3433 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3434 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3435 commit of JPR (before his hollidays to facilitate our work).
3436 * setup.py : bug fix in code. Modifications made while the last commit
3437 of JPR. The code hasn't been tested before the commit... it's so
3438 useless to make that (for best programmer that is JPR) !!!
3440 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3441 * tagged the current version as Version0_3 (i.e. version 0.3)
3443 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3444 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3445 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3446 * *.dsp : modifications to use new libgdcmijpeg8 library
3447 * setup.py : bug fix on VTKPATH variable
3448 * PACKAGER : adding all concerning windows
3450 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3451 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3453 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3454 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3455 test suite reported error.
3456 * PACKAGER file added (describes what a packager must do when
3457 packaging a new release).
3458 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3459 * configure.in: upgraded version number to 0.3.0
3460 * fixing build of rpm (through rpm -ta):
3461 - Doc/Makefile.am exports proper doxygen files
3462 - src/jpeg/libijg8/Makefile.am exports the include files.
3464 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3465 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3466 * src/gdcmHeader.h : formatting code
3468 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3469 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3470 We were obtaining error message from vtk. Now, creation of file list
3471 is made in an internal list to prevent this problem.
3472 Bug fix when output is empty.
3473 Bug fix in update of progress value. Previous commit for this was a bad
3475 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3477 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3478 * src/gdcmHeader.h : added method to get the file name
3479 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3480 files. Added method to remove all files on the input
3481 Added FIXME comment concerning the bad parsing of header made by
3482 ExecuteInformation method (in ExecuteData method)
3484 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3485 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3486 when using make instal.
3487 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3488 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3490 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3491 * setup.py : adding include dir of jpeg lib to compile all sources
3492 * */Win32/*.dsp : JPR fix for windows compilation
3494 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3495 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3497 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3498 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3500 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3501 * setup.py is again effective on un*x (takes into account the
3502 addon of the jpeg library)
3503 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3504 * Doc/Doxy* updated (includes above enhancements)
3505 * INSTALL now points to web documentation
3507 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3508 * src/gdcmHeader.h doesn't make unnecessary reference to
3510 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3512 * src/gdcm*.[cxx|h] :
3513 - to allow compilation with gcc 3.x
3514 -- clean up of STL usage (added explicit usage of std::)
3515 -- small fixes on exceptions.
3516 Note: linking not tested !
3517 - clean of doxygen comments to avoid warnings at documentation
3519 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3520 dependent convertion).
3522 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3523 * Clean up of previous JPR garbage commit (not even commented in the
3525 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3526 - moved all jpeg related files from src to src/jpeg/libijg8, with
3527 addition/modification of Makefile.am and configure.in.
3528 - the testSuite is still brain damage (not guilty).
3530 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3531 * WrapVTK.py : modifications to get correctly vtk source files to
3533 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3534 (FileName -> Filename)
3536 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3537 * vtk/vtkGdcmReader.[cxx/h]:
3538 - UpdateProgress method should now be effective
3539 - removed the limitation on having only images loaded (as opposed
3541 - when building a stack of images/volume, a lesser number of
3542 gdcmHeader and gdcmFile instances should be used (hopefully
3543 accelerating things).
3544 - when building a stack of images/volumes, files which are not
3545 loadable (wrong path-filename, wrong permissions on existing file,
3546 or file not parsable by gdcm) are replaced with a black image
3547 in the stack (for the caller to notice the problem).
3549 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3550 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3552 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3553 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3554 between standard library (std) and vtk library (problems are found
3555 under Windows... thanks Windows !)
3557 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3558 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3560 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3562 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3563 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3565 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3566 * When compiling with distutils (see setup.py) the C++ compiler is
3567 called with different flags than the default ones (with automake).
3568 In order to fix all those warning, I compiled gdcm with the command
3569 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3570 and went for warning fixes:
3571 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3572 up from unused variables.
3573 - vtk/vtkGdcmReader.cxx: potential bug fix.
3574 * src/gdcmHeader.h: Doxygen warning cleanup
3576 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3577 * gdcmPython/gdcm.i:
3578 - typemaps correction to take into account the systematic replacement
3579 of "using namespace std" with std:: prefix e.g. std::list,
3580 std::string... (cf changes of 2003-05-21).
3581 - gdcmGlob global variable of type gdcmGlobal (defined in
3582 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3583 exported to Python a as cvar.
3584 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3585 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3586 gdcmDictSet.GetPubDictTagNames() and
3587 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3588 C++ static methods).
3589 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3590 with the above changes.
3592 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3593 * setup.py, manifest.in : bug fix under linux
3595 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3596 * Modification of setup.py to compile vtk part too. Then, we have 2
3597 wrappers which must work with same distutils. For that, we have a
3598 generic distutils in distusiltsWrapping.py ; with :
3599 - build_extWrap class to wrap generically all extensions,
3600 - ExtensionWrap base class for all wrapping extension that contains
3602 - Wrapper interface which wrap sources
3603 + In WrapSwig.py we have extension and wrapper for Swig
3604 + In WrapVTK.py we have extension and wrapper for VTK
3605 * MANIFEST.in : modifications to consider vtk directory and new python
3606 files for compilation
3608 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3609 * Added python wrappers of vtkGdcmReader vtk class (see the
3610 source in vtk/vtkGdcmReader.cxx) :
3611 - vtk/Makefile.am now builds a library
3612 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3613 python library (as opposed to _gdcm.so wich are the python
3614 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3615 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3617 - configure.in has an additional flag --enable-vtk that needs
3618 to be set to enable compilation of vtk related code, that is:
3619 + vtk/vtkGdcmReader.so and
3620 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3621 + gdcmPython/vtkgdcmPython.so (see above)
3622 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3623 be read when compressed or when HighBit + 1 != BitsStored),
3624 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3625 the usage of the python wrapper of vtkGdcmReader vtk class.
3626 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3627 * src/*.[h] all occurences of stl classes are now prefixed with
3628 std::, and all occurences of "using namespace std;" where removed.
3629 This is to avoid pollution of global namespace in included files.
3630 Apparently vtk does not avoid this pitfall: when using both
3631 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3632 collision of various stl members (principally cout...).
3633 * gdcmPython/testSuite.py now cleanly removes temprory generated
3635 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3636 comply with above changes)
3638 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3639 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3640 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3641 vtk data structure (an image Flip was required).
3642 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3643 * cosmetic changes in documentation.
3645 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3646 * src/gdcmHeader.cxx: the constructor no longer exits when an
3647 unexisting file is given as argument.
3648 * The subdirectory Data (containing all the images used for the
3649 test suite) is not part of this repository anymore. A new module
3650 containing those images is now available at
3651 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3652 with the name gdcmData.
3653 All the python scripts (including the package initialisation file
3654 gdcmPython/__init__.py) were adapated to take this change into
3655 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3657 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3658 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3659 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3660 demo of the usage of this class.
3661 Compilation of this vtk part is only done when using the --enable-vtk
3662 at configure (or autogen.sh) stage.
3664 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3665 * More memory link related corrections and documentation fixes.
3667 - maximum info is obtained with a command of the form:
3668 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3669 --show-reachable=yes PrintHeader
3670 - the remaining reachable blocks seem to come from the STL
3671 allocation scheme through the usage of map and list. It looks
3672 like this memory cannot be freed but it is not a memory leak
3673 (in fact further invocation to the STL would recollect the
3674 unused memory allthough it cannot explicitely be freed).
3675 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3676 of displaying an image parsed with gdcm and displayed with VTK.
3677 Note: some images don't seem to work e.g.
3678 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3679 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3680 Allthough this weakens the semantics, it is a ditch attempt to
3681 make gdcm more thread friendly.
3683 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3684 * Memory link hunt (by using valgrind through the command
3685 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3686 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3687 gdcmHeader::_dicom_vr.
3688 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3689 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3691 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3693 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3694 * src/Makefile.am now exports all the necessary include files at
3698 * UpdateGroupLength replaced by new one
3701 * UpdateGroupLength re-written using H-Table
3702 (named UpdateGroupLengthNew untill checks are over)
3704 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3705 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3706 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3708 - gdcmHeader::GetPubElValSet removed.
3709 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3710 UpdateGroupLength, WriteElements, Write.
3711 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3712 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3713 carried the same semantics.
3714 - src/gdcmHeaderIdo.cxx changed accordingly.
3715 - gdcmFile::WriteBase now regroups all the codes from previous
3716 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3717 - enum FileType moved to gdcmCommon.h
3718 * src/gdcmHeader.cxx AddDefault trashed
3719 * gdcmGetXSize added
3720 * getimageDataSize now calls gdcmGetXSize
3721 * Test/*.cxx changed to agree with above changes
3723 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3724 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3725 (to avoid double call by end user).
3726 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3727 by end user, since gdcmHeader::gdcmHeader now handles it.
3729 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3730 * gdcm/Doc many doxygen changes:
3731 - Doxyfile now has two different versions, DoxyfileUsers that generates
3732 the html.users end users oriented documentation and
3733 DoxyfileDeveloppers that generates the html.developper developper
3734 oriented documentation.
3735 - README changed accordingly
3736 - requirement.txt removed (old design info moved to TODO).
3737 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3738 DoxyMainPage.txt, DoxyPython.txt provide more information.
3739 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3740 be updated by simply regenerating the docs with doxygen and copying
3741 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3742 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3743 all the tests in the form "if (<map>.count() >1)" were removed.
3744 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3745 ill-formed documentation sections.
3746 * src/gdcmHeader.cxx: ditto
3748 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3749 * setup.py fixed for un*x (needed macro for stdint.h)
3750 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3751 un*ces with sh-utils test utility.
3752 * gdcmPython/demo/test.py renamed to PrintHeader.py
3753 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3754 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3755 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3756 * src/gdcm*.cxx JPR's bad inclusion fixed.
3758 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3759 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3760 * gdcmPython/demo/test.py changed accordingly.
3762 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3763 * gdcmPython/Makefile.am fixed linking against libstdc++
3764 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3765 * Swig subdir (historical tests of swig version 1.3.17++) removed
3766 * Test/testChangeEntete.cxx some lines commented out in order to make
3768 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3769 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3771 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3772 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3773 hence the user doesn't need this explicit call.
3774 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3775 i.e. LoadElements() call removed.
3776 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3777 - src/Makefile.am declares the proper flag for g++.
3778 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3779 for adding user defined new tags.
3780 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3781 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3782 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3784 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3785 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3786 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3787 src/Makefile.am : the project should properly compile and install
3788 with the autotools, included the python wrappers part.
3789 * gdcm.spec.in : added a spec file for RPM packaging.
3791 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3792 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3794 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3795 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3796 to exported to the environement (see gdcmPython/testSuite.py
3798 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3799 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3800 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3801 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3802 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3804 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3805 * gdcmPython/__init__.py doesn't crash anymore when running in
3806 in InstallMode or PreInstallMode but with an environment given
3807 value of GDCM_DICT_PATH.
3808 * src/gdcmDictSet.[cxx/h] coding style.
3810 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3811 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3812 * src/gdcm.h general comments moved to TODO, and README
3813 * src/gdcm.h should now be seen as a user commodity (including it
3814 should suffice to fully use gdcm). It is nowhere including within
3815 any of the kernel files src/*.cxx and src/*.h.
3817 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3818 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3819 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3821 * src/gdcm*.cxx only include their corresponding include file
3822 (as opposed to gdcm.h)
3823 * gdcmPython/gdcm.i changed accordingly
3824 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3825 the autogen.sh generated "make snapshot" command to work.
3826 * autogen.sh removed history related references to crea package.
3828 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3829 * distutilsSwigCPlusPlus.py work around some swig portability
3832 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3833 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3834 was done in a last ditch attempt to get setup.py _really_
3835 operationnal. The python/gdcmPython layaout add the advantage
3836 of hidding away the python related distutils specific files
3837 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3838 Alas, the src directory was out of scope (i.e. it's relative
3839 position to setup.py was ../src) which made things impossible to
3840 handle (see previous version of python/setup.py). Crossing fingers...
3842 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3843 * python/setup.py now works on Un*x. (harder than I thougth)
3844 * python/distutilsSwigCPlusPlus.py can now have include files
3845 among the list of sources.
3847 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3848 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3849 * modifications in MSVC projects
3851 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3852 * As stated by the first lines of Test/ExceptionAndPython/README, it
3853 looks like we can move back to original usage of exception within
3854 src/gdcm* and hence remove the errno stuff that was introduced
3855 as a quick and dirty fixture of this problem (added to the TODO).
3856 * Doc/Doxyfile configuration file for Doxygen and corresponding
3857 README file for usage added.
3858 * Test/testWrite.cxx added. This new test comes from a split of
3859 test.cxx that is now reverted to its original purpous i.e.
3860 testing the proper parsing of a Dicom related file.
3861 testWrite.cxx concentrates on testing the IO part of gdcm.
3862 * Test/bug1.cxx (containing a bug on WIn32) added.
3863 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3864 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3865 whose purpose is to publish the content of the TagNames of the
3866 Dicom public dictionary were not accessible without an
3867 instance of class gdcmHeader.
3868 - those methods are now static methods of gdcmDictSet and hence
3869 require no instances at all to be invocated.
3870 - within gdcmDictSet this change required to change some method
3871 to class methods (i.e. are now static) among which SetDictPath
3872 (renamed to BuildDictPath) and LoadDefaultPubDict.
3873 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3874 the above changes by calling the new method classes of gdcmDictSet.
3875 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3876 the above to be effective.
3877 * python/gdcmPython: in order to wrap properly the above changes
3878 for Python, swig version now needs to be > 1.3.17.
3879 * python/gdcmPython/Makefile fixed to adapt itself to new
3880 configure/make shema introduced by Johan Montagnat (thanks for the
3881 contribution). Alas this Makefile cannot be turned into a proper
3882 Makefile.am without some heavy changes in the configure.in
3883 (for python dectection).
3884 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3885 now avoids publishing the empty entries.
3887 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3888 * python/setup.py : bug fix concerning install under windows
3889 ExtraPath reused :-P
3890 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3892 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3893 * Dicts/dicomV3.dic : remove double spaces !!!
3894 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3895 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3898 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3899 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3900 method. Doxygenation.
3901 * src/gdcm.h clean up of JPR spurious comments.
3903 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3904 * python/distutilsSwigCPlusPlus.py now properly collects the
3905 shadow classes generated by "swig -c++" (gdcm.py in our case)
3906 when using "python setup.py install".
3907 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3908 reexports the working classes.
3909 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3910 by the classical C errno scheme. This is to prevent an obscure
3911 behavior of the python wrappers when importing wxPython.wx prior
3912 to gdcmPython (which ended up in an abort call). An illustration
3913 of this oddity can be found in the Test/ExceptionAndPython
3914 subdir (see the README file). This problem probably due to
3915 an combination of g++ and dynamic loading.
3916 * added Test/ExceptionAndPython (see above)
3918 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3919 * Changed the layout of the python part to avoid bloating main
3920 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3921 i.e. the distutils arsenal. All the python related stuff is
3922 again in a python subdir, but the package itself is now in
3924 * setup.py was cleaned up:
3925 - pythonIncludePath removed
3926 - python setup.py bdist target is now functional.
3927 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3928 collision with other packages). gdcmPython/demo/*.py changed
3931 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3932 * python subdir moved to gdcmPython (preparation of distutils packaging).
3933 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3934 distutils installer is operational.
3935 * - gdcmPython/__init__.py now properly loads the swig generated
3936 shadow classes (from gdcm.py).
3937 - gdcmPython/demo/*.py changed to import the package gdcmPython
3938 instead of gdcmPython/demo/load.py.
3939 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3941 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3942 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3943 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3944 entries within the associated public Dicom dictionary resp. the same
3945 information but sorted by the fourth field (PAT, IMG, DIR) of the
3947 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3948 are now in the "???" group.
3949 - python/gdcm.i changed accordingly,
3950 - python/demo/printGroupedPublicDict.py added, that gives an example
3951 of the above new functionalities in Python.
3953 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3954 * src/gdcm.h, gdcmHeader.cxx:
3955 - historic references to glib's g_malloc and g_free (#defined)
3956 were definitively removed.
3957 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3958 * src/gdcmElValSet.cxx:
3959 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3960 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3961 - GetElValue(string) renamed to GetElValueByName.
3962 - Added GetElementByName(string).
3963 * src/gdcmHeader.cxx: added
3964 - GetPubElValRepByNumber(guint16, guint16)
3965 - GetPubElValRepByName(string)
3966 - GetShaElValRepByNumber(guint16, guint16)
3967 - GetShaElValRepByName(string)
3968 - GetShaElValByNumber(guint16, guint16)
3969 - GetShaElValRepByName(string)
3970 - GetElValRepByNumber(guint16, guint16)
3971 - GetElValRepByName(string)
3972 - GetElValByNumber(guint16, guint16)
3973 - GetElValRepByName(string)
3974 * Doc/requirements.txt added.
3976 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3977 * Test/Makefile building now depends on the one of libgdcm.so
3978 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3979 pixel data) aware which enables finding the address (offset) of
3980 the pixel data of JPEG encoded DICOM files. This leaves only a single
3981 file in the testSuite whose pixel data address (offset) is unknown.
3982 * python/testSuite.py changed accordingly.
3984 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3985 * VC++ has some strong limitations when working with the STL, as stated
3986 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3987 "Also note that some STL containers (map, set, queue, list, deque)
3988 cannot be exported. [...]
3989 Some STL classes contain nested classes. These classes can not
3991 This is caused by a designed limitation that once a template
3992 class is instantiated, it can not be re-instantiated and
3994 Since our usage of map<> is ubiquitous in gdcm, this "designed
3995 limitation" of VC++ is a pitfall.
3996 Hence the Python wrappers of gdcm cannot be incrementally linked
3997 against the c++ dynamic library. The dirty but only workaround is
3998 to forget about incremental link of dynamic libraries and to generate
3999 the Python wrappers library with the inclusions of the underlying C++
4001 The following modifications concern this matter on Win32/VC++:
4002 - wrapping python correct with standalone wrapped dll (don't use separate
4003 dll under windows !!!!)
4004 - python21_d debug mode enabled (ask Frog how to use it :-)
4005 - NO problem with having an STL member of class for example string in C++
4006 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
4007 - Python test of dcmlib in Python is ok under windows on a large set
4009 * removed glib references
4010 * typedef's inserted in gdcm.i for correct swig type management
4012 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4013 * python/demo/*.py load.py extracted from test.py. Added explore.py
4014 that only displays required tags and testAll.py that parses all
4015 the files of the testsuite without using unittest.
4016 * python/testSuite.py other additional test on new files added.
4017 * Data/* new test files added accordingly to the testSuite.
4018 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
4019 the vr in the file differs from the one of the dictionary.
4021 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4022 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
4023 values, but limits itself to values which are below a user specified
4024 size (by default 1024 bytes).
4025 * python/gdcm.i : elements not loaded (because their size is above the
4026 user specified treshold) are exported with their TagKey as key of the
4027 python dictionary. This enables the testsuite to make some checks
4028 on the unloaded elements (since we have their offset and size).
4029 * python/testSuite.py
4030 - now tests for the existence and proper value of the pixel data
4031 - two new examples added.
4032 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
4034 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4035 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
4036 aware. See the strategy comments in gdcmHeader::FindLength().
4037 * Test/test.cxx now accepts a filename as first argument.
4038 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
4039 * python/testSuite.py changed to integrate test on above files.
4041 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4042 * Dicts/dicomV3.dic removed all the trailing (RET) when the
4043 the vr was also RET.
4044 * python/testSuite.py more tests added.
4046 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4047 * python/testSuite.py unittest test suite added (uses Data)
4048 * Data/* dcm and acr files for the test suite.
4049 * glib dependance removed from un*x version. We now use ISO C99
4050 7.18 Integer types (see stdint.h)
4051 - python/Makefile, src/Makefile src/gdcm.h
4052 * src/ when an explicit vr (like dicom files) suddenly poped an
4053 implicit element we use to mark the underlying DictEntry of the
4054 concerned ElValue with "Implicit". This strategy was damageable
4055 too the public or provite dictionaries, since some of their vr
4056 would be changed. Since Header::FindLength heavily relies on the
4057 detection by Header::FindVR of falsely explicit elements, I
4058 added an extra ImplicitVr member to ElValue (boolean).
4059 The rest of the changes we the necessary adaptations.
4061 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4062 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
4064 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
4066 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4067 * Adaptation for porting to VC++:
4069 o forced to use std namespace (for string to be known)
4070 o all class use __declspec export style on WIN32
4071 - src/gdcmUtil.cxx new Exit method that wraps the exit call
4072 (in stdlib.h on Win32 but in std:: for gcc)
4073 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
4074 variable GDCM_DICT_PATH.
4075 * src/gdcmHeader.cxx verbose comments made discrete.
4077 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4078 * python/gdcm.i: added a typemap that converts a C++ hashing table
4079 to native Python dictionary.
4080 * python/demo/test.py:
4081 - now uses the native dictionary for exploration of gdcmHeader.
4082 - takes an optional filename argument (the file to parse).
4083 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
4084 PubElVals hashing table.
4085 * Dicts/dicomV3.dic removed error prone trailing spaces.
4087 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4088 * Python wrapping process moved away from src/Makefile to
4089 newly created python/Makefile (as well as gdcm.i)
4090 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
4091 * src/gdcmHeader::FindLength only looks for current vr when necessary.
4092 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
4093 from the environement variable GDCM_DICT_PATH (when existing).
4094 * src/gdcmDict::GetTag bug fix.
4096 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4097 * Straightforward temporary fixes for swig to build the python wrappers.
4098 src/Makefile now has a python working entry [by working we mean
4099 that we can import the shadow classes without errors].
4101 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4102 * hashtest.cxx removed (since already in Test)
4103 * src/gdcmlib.h renamed to src/gdcm.h
4104 * src/dcm.i renamed to src/gdcm.i
4105 * src/Makefile prepared for python wrapping
4107 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4108 * src/gdcmHeader.cxx :
4109 - Parsing of header is now separated from loading of element values
4110 (see gdcmHeader::LoadElements).
4111 - general clean up of hopefully all file access (creation of
4112 ReadInt16 and ReadInt32)
4114 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4115 * src/gdcmHeader.cxx :
4116 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
4118 - SetLgrElem renamed to SetLength
4119 - GetLgrElem renamed to GetLength
4120 - ~gdcmHeader() made virtual to pesky warning messages at compile.
4121 * src/gdcmElValSet.cxx fixed both GetElValue methods
4122 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
4123 due to IdoDude was cleaned out.
4125 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4126 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
4127 concentrates on finding the value representation (when it exists).
4128 RecupLgr now only finds the element value length, and it avoids
4129 returning the unecessary skL (skipped length).
4130 Also, offsetCourant was simply removed (with taille_fich) since
4131 it was redundant with the File position internals (by using
4132 ftell and fseek). This also made skL (see above in RecupLgr) usage
4134 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
4135 on the libido specificities which are handled through class
4137 * Test/implicit_vr.dcm dicom v3 in implicit value representation
4140 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4141 * Truckload of changes. Parsing of header is barely functional
4142 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
4144 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4145 * src/gdcmHeader.cxx many addons of low level methods
4147 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4148 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
4149 and _IdDcmSWAP_LONG.
4151 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
4152 * This corresponds to all the changes decided at the meeting of
4153 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob