1 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
3 a string and should ask the global TS dict what are the propreties of
6 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
8 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
9 to swap the Swap Code, at parsing time, when we come out of group 0002
10 and Transfer Syntax is Big Endian
11 We should be able to read now 'true DICOM" Big Endian coded images
12 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
13 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
15 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
16 * Hopefully fix the bug on MacOSX and static global initialization.
17 This is the only -minor- patch I found that both please MacOSX and VS6.
18 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
19 but this would require a lot of change. Another approach would be that Global
20 create those string and GDCM_UNFOUND becomes a pointer to a string (which
21 gdcm::Global would destroy at exit).
23 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * Fix bug on MacOSX with static initialization in a multy threaded
25 environment. static const string in a header file used to be ill
26 initialized provoquing the freeze of any tests. patch should solve this
29 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
30 * According to Benoit's suggestion, and without any objection from anybody
31 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
32 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
33 - method gdcmDicomDirObject::GetEntry() renamed as
34 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
36 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
37 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
38 you debug/warning message just as c++ streams which make them very convinient
39 to use. Once this is stabilize I will change the ostringstrem to be
40 redirected to a file (ofstream).
41 * Properly support C99 extension: __FUNCTION__ which allow us to display
42 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
44 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 * Removal of useless and dangerous methods :
46 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
47 GetDocEntryByName, GetEntryByName, GetDictEntryByName
48 * Removal of usless methods :
49 Dict::PrintByName, Dict::GetDictEntryByName
50 * Commenting out of probabely useless methods :
51 Dict::GetDictEntryNames()
52 Dict::GetDictEntryNamesByCategory()
53 DictSet::GetPubDictEntryNames()
54 DictSet::GetPubDictEntryNamesByCategory()
55 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
56 * ENH : Use dicomTS.dic as described in 2004 version
57 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
58 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
59 Add Accessors on VM (Value Multiplicity), and VM related methods
60 * ADD : Add a list of 'Dicom Attribute types', as found in
61 http://medical.nema.org/dicom/2004/04_15PU.PDF
63 * ADD : Add dicomGroupNameAbbreviations.dic
64 should be used to write a method to replace the former
65 Dict::GetDictEntryNamesByCategory()
67 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
69 to read in the file... and only it ! Length is the efective length of the
70 data in the DocEntry structure
72 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
74 And now use a static function call instead, with a global variable. i
75 This is much closer to the VTK approach. Hopefully should be bulletproof
76 and easier to use...hopefully
78 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
79 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
81 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
84 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
86 ValEntry, BinEntry, SeqEntry creation or replace
88 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
90 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
92 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
93 when specifying the VR
94 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
95 * src/gdcmDocEntry.cxx : amelioration of print
97 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
98 * ADD : Add the method Util::IsCurrentProcessorBigEndian
99 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
100 * ADD Method Document::ComputeGroupLength
101 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
102 in order to allow further VR modification by user
103 * REM : removal of once-called method File::WriteBase
104 integration of its code in formerly one-line method File::Write
106 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
108 replace the different values "??", "Unkn", "Unknown".
109 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
110 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
111 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
112 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
114 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
117 * Set the gdcm::Base class to some Printable classes
119 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmFile.[h|cxx] : add the Print method
121 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
122 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
123 * src/gdcmDocument.h : remove the PrintLevel informations
124 * Example/PrintFile.cxx : use the new gdcm::File::Print
126 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
128 problems when compiling with the python wrapping
130 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
132 writting in ImplicitVR
134 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
135 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
136 JPEG decompression, especially when dicom frames are split into several
137 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
138 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
140 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmHeader.cxx : change the initialisation of default header.
142 Now, this header is readable by gdm, e-film, DicomWorks
144 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
146 Rename Decompressed to Raw
147 * Use the API changes in gdcm::File.
148 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
151 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
153 each added entry in the header. Replace the 'Planes' field by the 'Number
156 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
158 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
160 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
162 At this time, this image isn't readable by e-film... waiting JPR help to
165 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
167 DocEntry. Now use methods of the Document !
169 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * Test/ShowDicomSeq.cxx : bug fix
172 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
174 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
175 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
176 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
178 * Test/TestCopyRescaleDicom.cxx : remove unused variable
179 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
180 containing found sequences
182 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
185 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
186 Some fields in BinEntry must be copied to not seg fault when making the :
187 gdcm::File *copy = new gdcm::File( copyH );
188 and tests are now made on good variables
190 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
192 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
194 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
195 * Add vtkGdcmWriter example and test
197 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * Test/TestUtil.cxx : reformat the source code
199 * vtk/vtkGdcmReader.cxx : remove and change prints
200 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
202 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
203 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
205 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
207 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
209 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
211 by an eof to prevent all bad read of the file... and in this case, the
214 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * Example/Volume2Dicom.cxx : comment unused variables
216 * Test/PrintDicomDir.cxx : comment unused variables
217 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
218 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
219 method that is redondant with AddEntry.
220 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
223 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * Bug fix due my last commit (compilation under Windows).
225 * Example/Volume2Dicom : bug fix in the file and reformatting source code
226 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
228 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
230 - Remove printf / sprintf
231 - include iostream AFTER gdcm so we don't get warnings
232 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
234 - Also remove tons of include from header files, hopefully this should
235 speeup the compilation time, since it was becoming a dog slow.
236 - Remove gdcm.h as it include way too many files and slow down compilation
237 (plus it is not up to date)
238 - remove 'using namespace std' this is BAD !
240 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * Remove memory leaks on the DicomDir
242 * Remove some useless data in DicomDirObject
243 * Add usefull methods in SQItem, to be complient withe the ElementSet
245 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
248 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
250 future, with convertion)
251 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
252 and ImageDataSize values. Remove the method to get the PixelReadConverter
253 from the output of the class
255 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
258 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
259 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
260 and vtkErrorMacro use.
261 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
263 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
264 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
266 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
267 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
268 The string leaves only in the fonction. So when we make a .c_str(), we
269 get the pointeur on the first element, element that will be destroyed
270 immediately after thee instruction.
271 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
272 file has been opened : the test must be made on the content of the
273 pointer and not directly on the pointer !
276 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
278 the python part recompiles
280 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
281 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
282 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
283 X session is killed (for my computer... it seems to not be identic on
286 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
288 avoid problems (otherwise, the difference test between the visible image
289 and the reference is incorrect. If the reference is greater than the
290 screen resolution, it's produce errors).
291 Can be used for only one image. Can be used with a visible flag.
292 * vtk/vtkGdcmReader.cxx : remove commented codes.
293 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
294 under windows at compilation
295 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
297 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
299 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
301 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
302 tests on the image size X, Y, Z
304 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
306 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
307 between the class name and the file name
309 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * src/ : fix compilation warnings for the Write method (2 different
311 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
312 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
313 variable... create a static method in gdcm::Document to access to
314 this variable content.
316 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
318 file, to be accessed by other files (like gdcmFile). Remove commented
319 code. Move the change of the header to the gdcmFile, using the
321 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
322 To be sure of that (and simplify calls), the Write of the header now
323 gets a file name and not a file pointer (std::ifstream).
324 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
325 DocEntryArchive. Remove all open of the written file
327 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
330 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
332 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
334 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
335 some corresponding methods. Write correctly the file and check before
337 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
338 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
339 is now on RGB data (as before my last commit
340 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
342 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
343 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
344 Add a print information of the type of the entry
345 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
346 It was in the gdcmFile, and all write have been regrouped
347 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
348 Write correctly all dicom files (in decompressed mode only at this time)
349 * Test/ : test on files are now made using Raw data and not color data if
351 * Example/PrintFile.cxx : add more printings
353 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * Amelioration of code, remove some code copy. For the loading of
355 BinEntry (in gdcmDocument), add the test to verify if the file is already
358 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
360 remove a DocEntry in the header (push an empty DocEntry)
361 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
362 lines. Bug fix in the initialization of the PixelConvert and the
364 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
365 use in TestCopyDicom (now this test can run under windows... but fails)
366 * Test/TestCopyDicom.cxx : amelioration of the test :
367 - test the pixels written
368 - add test points to quickly find where is the error
369 - can set a file name input and output in arguments
370 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
371 amelioration of the test output
373 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
374 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
375 all replaced DocEntry's
376 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
377 Now, each needed DocEntry to modify is duplicated, modified and inserted
378 to the header using DocEntryArchive. Thus, after save, we can restore the
379 header initial state.
381 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
382 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
384 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
386 correct to copy it. The DictEntry is specified at the DocEntry creation,
387 then, it musn't change in the time.
388 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
389 header correctly. At this time, the change is only made for the first
390 level of the Document. In the future, it might consider sequences.
391 The change is made by replacing a DocEntry by an other that is created
392 outside the class. The old value is kept. When we restore the header
393 status, the added DocEntry is deleted and replaced by the old value.
394 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
395 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
396 set the write type to explicit VR, implicit VR or ACR. Add methods to set
397 the write mode to native, decompressed or RGB (but not used at this time)
399 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
401 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
403 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
405 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
407 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
408 set because already copied when copying the BinEntry's of the header
409 * Test/TestAllReadCompareDicom.cxx : remove warnings
411 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
413 Two problems appear when doing it :
414 - with the gdcmFile : when the GetImageData method is called, the pixels
415 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
416 data (pixels). And each structure destruct the data when it's
417 destructed. So we have two destructions for the same data. To solve it,
418 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
419 data or not. If it doesn't own data, then they will not destroyed by
421 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
422 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
423 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
424 create a double destruction of the same DocEntry's. So, to solve it,
425 the TagHT is simply cleared and the DicomDir* elements are destroyed.
426 * TODO : add an entry concerning memory leaks in the DicomDir
428 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
430 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
433 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
435 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
436 after it have been deleted
438 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * FIX: src/* fix the doxygen warnings.
440 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
441 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
442 was erroneously defined with a size of 15 instead of 16. [many thanks
443 to Jean Michel Rouet for pointing out this bug].
445 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 1. Finish merging JMR patch for writting DICOM from scratch
447 2. Fix -hopefully- bug with MONOCHROME and space vs null character
448 3. Use const ref when possible
449 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
450 5. A few more comments
451 6. CreateUniqueUID can now be called without parameter"
453 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
454 * ENH: Slightly bigger patch:
455 1. Getting toward full integration of JMR patch for writting dicom from scratch
456 2. Update Test to test part of this patch: CreateUniqueUID
457 3. File was not close properly in gdcmDict
458 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
459 5. Use of const ref instead of copy (speed issue)
460 6. Remove temporary (duplicate) string in TranslateToKey
461 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
462 8. Do not repeat virtual in subclasses
463 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
465 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
466 * Apply first patch toward better string comparison when dealing with broken
467 DICOM files. Essentially the string could be padded with a space instead
468 of a null character as defined by standard
470 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
472 because never used... and in the same time, that's remove some memory leaks
474 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * src/gdcmFile.cxx : now delete the PixelConvert instance.
476 * In examples and tests : change the type of image data variables from void*
477 to uint8_t*. Remmove all delete on image data variables
479 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
480 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
481 Verify the file pointer value before open the file, and if it's not null,
482 a verbose message is generated.
483 Close correctly the file when the file isn't considered dicom-like. The
484 correctly close is a call to CloseFile.
485 When closing the file pointer, test if its not null to close the file.
486 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
487 file. For an uncompressed image, the copied data correspond in the least
488 case to the image size (calculated) or the image size specified in the
489 header. A verbose is generated if these two size mismatch
491 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
493 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
494 break under windows (with msvc6 compilation).
496 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
497 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
498 compiling with MSVC6)
500 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * Bugs fix for the Windows build with VC6
502 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
503 needed (only for projects required VTK). If the VTK is included in all
504 projects, there is conflicts with the jpeg lib of vtk when compiling the
505 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
506 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
507 when compiling the gdcm_wrap.cxx file (created by the compilation of the
509 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
510 (like it's already made for the cout use). Otherwise, conflict with the
513 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
516 - comments on the DicomDir::Method related usage added.
517 - now that we use the namespace gdcm, a lot of internal classes do
518 NOT need to be wrapped anymore.
519 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
520 DicomDir::Method) new example added.
522 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Improve string manipulation. I now inforce the notion of 'DicomString'
524 A DicomString can contain as many \0 as they want
525 and it is *always* of even length.
526 We only support odd length for very rare case.
527 And in the near future this should be removed.
529 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
530 * /binary_write/ gdcm source. Now even on big endian we are writting
531 little endian. This should -heopfully- fix some tests
533 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
534 * Now the dictionary is compiled into gdcm lib. This is a default
535 behavior, thus any dic file specified is picked before failback to
536 the one comiled into lib
538 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
539 * Change internals for gdcmDict. Don't use any 'new' any more.
540 This should definitely solve any leak problem, and we should be
541 as fast as before, as long as don't modify too much the dictionary.
543 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * STYLE: ivars should start with a capital letter.
545 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
546 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
548 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
550 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
551 new 2004 dictionaries added (thanks to JPR).
552 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
553 * CLEANUP_ROUND (15) for gdcmPixelConvert
554 - RLEFrame::NumberFragments is now of type unsigned int
555 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
556 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
559 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
560 * Initial work in gathering all transfer syntax accessors. clearly
561 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
562 ivars, but only one transfersyntax (class) ivar with equivalent method on
565 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
567 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
568 discussed (plus I didn't like having a 2000 lines patch not commited)
570 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
572 * CLEANUP_ROUND (14) for gdcmPixelConvert
573 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
574 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
575 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
577 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
578 anymore and hence avoids storing a copy of PixelConvert::Decompressed
579 into File::Pixel_Data.
581 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
583 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
584 * CLEANUP_ROUND (13) for gdcmPixelConvert
585 Substituted File::ParsePixelData() with PixelConvert::Print() new
587 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
588 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
589 method to those classes.
590 - src/gdcmFile.[cxx|h]:
591 -- Added a ::Print() method.
592 -- PixelConverter is now a reference instead of a member.
593 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
594 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
596 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
598 collaboration diagram and inheritance diagram should be generated with
600 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
601 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
602 pointlessly wrapped (see
603 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
604 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
605 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
606 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
607 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
608 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
609 -- File::Initialise: PixelConverter setup moved away to
610 PixelConverter::GrabInformationsFromHeader()
611 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
612 interpretation moved away to PixelConverter::BuildRGBImage()
614 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
615 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
616 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
618 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
620 displayed on Win32 when a brutal abort() occurs (because of uncatched
621 exception). See TODO new entry of this commit for more on this.
622 * TODO added new entry.
623 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
624 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
625 - HandleColor is no longer called from gdcmFile.cxx
626 - gdcmPixelConvert.cxx clean up on method arguments and internal
627 variable names for semantical coherence.
629 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
630 * Finished lossless transition, not only do we now read all lossless jpeg
631 images, without the need of the Cornwell lib, but we do read them properly now
632 * To reduce code (well to avoid code duplication), I defined a common place
633 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
634 redefine symbols. This is not perfect but this the best solution I found for a
635 compilation time jpeg option.
637 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
638 * Update jpeg ijg lib to support lossless jpeg implementation
639 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
641 * Also added a special copyright for dcmtk since we use their bugfixes.
644 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
646 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
647 matters, as stated in warning note at begining of %include section).
648 * src/gdcmDicomDir*.[cxx|h]: coding style
649 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
650 * src/gdcmJpeg8.cxx: doxygen fix.
651 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
652 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
653 from File:: to PixelConvert::.
655 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
657 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
658 - more code moved away from File:: to PixelConvert::
659 - fat setup of PixelConverter set in place in File::Initialise.
661 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
662 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
663 namespace at the file system level. So now you should convert your examples
665 gdcmHeader -> gdcm::Header
666 It would be nice if people keep in mind to no open the namespace, since it
667 allows compilation on broken plateform which were defining common symbol in
668 the standart namespace (like LP, Unknown ...)
670 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
672 The JPEG fragments are now parsed at the same stage than the RLE
673 information. All code related to JPEG is now in gdcmPixelConvert:
674 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
675 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
676 export a gdcmFile:: method. Those are simply global functions
677 (for the time being this is better than having them attach to
678 either gdcmFile:: or gdcmPixelConvert::).
679 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
680 and stores the result in a gdcmJPEGFragmentsInfo.
681 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
682 code (among other stuff) moved away from gdcmFile:; to
685 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
687 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
688 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
689 clean up of RLE related code.
690 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
691 - src/gdcmRLE.cxx removed
692 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
693 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
694 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
695 * CLEANUP_ROUND (9) for gdcmPixelConvert
696 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
697 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
698 away from gdcmFile:: to gdcmPixelConvert::.
700 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
702 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
703 This is because Parse7Fe0 used to parse the pixels to compute the
704 length. This task was passed over to FindDocEntryLengthOB() a long
705 time ago, EXCEPT I had forgotten the OW case...
706 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
707 we just recylce the code for parsing RLE fragments and computing
709 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
710 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
711 with the retired Parse7Fe0().
712 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
713 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
715 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
717 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
718 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
719 - src/CMakeLists.txt: alphabetic order reodering + new entries.
720 * CLEANUP_ROUND (4) for gdcmPixelConvert
721 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
722 to return an unused length.
724 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
725 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
726 this should be cleanner from the plane view. The iostream are erally a pain
727 to use to do simple stuff.
729 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 * Redo the compilation of the ijg jpeg library. Now only one source is
731 necesseray. No need to rename file by hand what so ever. CMake handle the
732 copying of the file within different directory, configure header file to
733 modify some symbol. The only addition made to ijg wasd a mangle table so
734 that symbol are different wether we are within 8bits or 12bits.
736 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * Added documentation of vtkgdcmReader on Website:
738 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
739 with it's binary name).
740 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
741 the Website to be more complete.
742 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
743 doxygenated documentation.
744 - Doc/DoxyVtkGdcmReaderExamples.txt added
745 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
746 DoxyVtkGdmReaderExamples.html )
747 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
748 * CLEANUP_ROUND (3) for gdcmPixelConvert
749 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
751 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * CLEANUP_ROUND (2) for gdcmPixelConvert
753 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
755 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * CLEANUP_ROUND for gdcmPixelConvert:
757 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
758 - src/gdcmPixelStuff[h|cxx] removed
759 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
760 - src/CMakeLists.txt changed accordingly
762 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
763 gdcmVersion.py moved to newly created ATTIC related
764 gdcmPython/SetupOldies/ directory.
765 * Autotools clean up:
766 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
767 - autogen.sh configure.in acinclude.m4 python.m4 removed
769 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * src/*.cxx *.h Reference to License.htm fixed to License.html.
771 * Doc/CMakeLists.txt, doxygen.config.in: fix.
772 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
774 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * TODO updated with Mathieu suggestions. I proposed a template for
776 describing TODO entries and used it for new entries.
777 * Added Doc/Website/CodingStyle.html, Developpers.html,
778 DeveloppersPython.html, GdcmDataCvs.html and
779 DownloadVersion0_1.html, DownloadVersion0_3.html.
780 * Some Doc/*.txt Doxygen files (which do not really concern the
781 documentation itself, but the website) moved to html and
782 placed in directory Doc/Website:
783 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
784 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
785 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
786 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
787 * CMakeLists.txt changed accordingly.
788 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
789 DeveloppersPython.html
790 * INSTALL nows refers to Doc/Website/Installation.html
792 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * Added Doc/Website directory, that contains a first raw version
796 2004-09-23 Jean-Pierre Roux
797 * FIX In order not to be poluted any longer by casting problems,
798 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
799 we can now delete[] it safely
800 * VoidArea is now called BinArea (less confusing name),
801 and all the methods called ...VoidArea... are now ... BinArea...
802 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
804 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
806 clear) TagHT, which is an inherited member of gdcmElementSet. It is
807 up to the destructor of gdcmElementSet to clean up TagHt and it's
810 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * Test/CMakeLists.txt: update to follow gdcmData renamings.
812 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
814 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * ENH: added some utility method that builds a flat dictionnary
816 holding all the Dicom entries contained in the recursive structure
817 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
819 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
820 BuildFlatHashTable() that build a flat dictionary.
821 - src/gdcmElementSet.h: added a new private GetTag() accessor.
822 gdcmDocument is now a friend of gdcmElementSet.
823 - src/gdcmElementSet.cxx: clean up.
824 - Example/FlatHashTablePrint.cxx added.
825 - Example/CmakeLists.txt changed accordingly
827 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
829 moved away from gdcmDocEntrySet (since this class is an abstract class
830 acting like an interface). SQDepthLevel and BaseTagKey are now
832 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
833 and associated accessors. Doxygenation of the class.
834 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
836 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
837 Use SQDepthLevel accessor instead. ::Print() adapted.
838 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
839 - src/gdcmDocument.cxx changed accordingly.
841 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
843 - The following is the doxygen comment of the typedef declaration
844 of gdcmagKey in src/gdcmCommon.h:
845 gdcmTagKey is made to old an "universal" (as in URL, Universal
846 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
847 A dicom tag allways has a group and an element, but a set of tags
848 embeded in various (optionally nested) sequences and sharing
849 the same group and element all share the same (group, element)
850 "identifier". Hence the (group, element) cannot be used as an
851 identifier (in gdcm we shall refer to a "TagKey") of a tag.
852 In order to construct a proper tag identifier (i.e. a key) we
853 consider the following definition of a TagKey:
854 - let Group, Element be the string representation of the
855 group and element dicom tag members,
856 - let ItemNumber be the string representation of the integer
857 index of the considered item number of a sequence,
858 Let the key of a tag embeded in a sequence, noted SeqTag, be
860 /ItemNumber#Group|Element
861 where "/", "#" and "|" are characters acting as separators.
862 Then the general form of a gdcmTagKey is given by:
863 Group|Element<SeqTag>
864 where <SeqTag> means NO or many instances of SeqTag.
865 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
868 but the gdcmTagKey of a tag "embeded" is the first item of
869 a sequence, itself nested in the third item of a sequence is the
871 0004|1220/2#0008|0082/0#0008|0090
872 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
873 order to hold the new sequence compatible key. Previously, the
874 GetKey() method would look in the underlying gdcmDictEntry.
875 - src/gdcmDocEntry.cxx:
876 -- constructor now copies the underlying DictEntry key, in the local
878 -- ::Print: displays the member Key, instead of the (group, element).
879 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
880 - src/gdcmDocEntrySet.h:xi
881 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
882 -- now has a new BaseTagKey member.
884 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
885 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
887 This poses the problem with the semantics of the following lines
888 LoadEntryVoidArea(0x0028,0x1201); // R LUT
889 LoadEntryVoidArea(0x0028,0x1202); // G LUT
890 LoadEntryVoidArea(0x0028,0x1203); // B LUT
891 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
892 to the long FIXME note for what the problem is. Nevertheless in
893 order to get things working the dicom dictionary was altered !
894 Please fix things urgently...
895 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
896 information), see above note on moving the member VoidArea. Nevertheless
897 the following entries previously correctly set as US are now inproperly
899 0028 1201 OW IMG Red Palette Color Lookup Table Data
900 0028 1202 OW IMG Green Palette Color Lookup Table Data
901 0028 1203 OW IMG Blue Palette Color Lookup Table Data
902 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
903 of gdcmDocEntry moved to gdcmSeqEntry.
904 * src/gdcmSeqEntry.cxx: STYLE.
906 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * Test/TestAllEntryVerify.cxx minor fix and added comments.
909 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * gdcmPython/testSuite.py: all the test suite in python is now moved
911 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
912 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
913 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
915 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
917 to avoid inclusion recursion until STL is reached.
918 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
919 mecanism. errno.h is not included in gdcm anymore.
920 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
921 (gdcmFormatError now inherits from gdcmFormatUnexpected).
923 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
924 gdcmData/TestAllEntryVerifyReference.txt
925 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
926 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
927 exception_on_error parameter.
928 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
929 - vtk/vtkGdcmReader.cxx changed accordingly,
930 - Example/*.cxx and Test/*.cxx changed accordingly.
932 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
934 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
935 enable_sequences removed from gdcmHeader constructor and dependencies.
936 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
937 * gdcmPython/demo/PrintHeader.py: dummy fix.
938 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
939 skip_shadow removed from gdcmHeader constructor and dependencies.
940 * Example/*.cxx and Test/*.cxx changed accordingly.
942 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
944 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
946 2004-07-21 Jean-Pierre Roux
947 * FIX Now, Parsing and Printing a DICOMDIR do work!
948 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
950 2004-07-20 Jean-Pierre Roux
951 * FIX Some brain damaged headers have Zero-Lenght fields
952 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
954 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
955 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
956 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
957 variable (instance of gdcmDebug) by a definition macro, and the instance
958 is now in static in the gdcmDebug class
959 * src/gdcmSQItem.h : (FIXME) remove an undefined method
960 * Test/PrintAllDocument.cxx : bug fix in the result of the test
962 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * WARNING: ctest now depends more tightly on gdcmData. You should
964 check out gdcmData properly for things to run smoothly...
965 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
966 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
967 we need the pixels not be loaded in order to use the ValEntry
968 that displays position and size).
969 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
970 This is a C++ based equivalent of gdcmPython/testSuite.py that should
971 be deprecated. If you have any doubts about the advantages of a
972 modern scripting language (read Python) versus grass root C++ (i.e.
973 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
974 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
975 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
976 Anyhow, consider documenting the gdcmData images in
977 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
979 * Test/CMakeLists.txt:
980 - now uses TestAllEntryVerify.cxx
981 - specific comments on oldACR00001.ima (now renamed in gdcmData
982 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
983 gdcmData/TestAllEntryVerifyReference.txt
986 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
987 * src/*.[h|cxx] : typedef clean up
988 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
989 - TagKey renamed to gdcmTagKey (for external usage)
990 - VRKey renamed to gdcmVRKey (for external usage)
991 - removal of typedef duplication.
992 - Removed all unecessary inline keyword from class inline definitions.
993 - Some method|function(void) declarations replaced with method|function().
994 * src/jpeg/libijg12/jdhuff12.c:
995 - printf polluting ctest removed.
996 - TAB removal for comminting
998 - TestAllReadCompareDicom.cxx: added a test that compares all the
999 images in gdcmDataImages.h with corresponding images in
1000 gdcmData/BaselineDicom/. When baseline images are not present
1001 this test creates them.
1002 Note: we need to validate each reference image, but before that
1003 I'd like to rename them with a more explicit name...
1004 - CMakeLists.txt: changed accordingly.
1005 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1006 including each header needed).
1008 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1010 test suite to the Example directory. Are concerned:
1015 - TestWriteSimple.cxx
1016 * Test/CMakeLists.txt: added some comments on reasons for black listing
1017 image gdcmData/oldACR00001.ima
1019 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1020 * Test/CmakeList.txt: removed the following from black list (to be coherent
1021 with removal from gdcmData):
1022 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1023 - gdcm-MR-PHILIPS-16.dcm
1025 Added the following because after last cvs update, they cause
1026 ctest -R TestReadWriteReadCompare
1028 - gdcm-MR-SIEMENS-16-1.acr
1030 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1031 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1032 new comments in this file) we temporarily (sigh) move to a weaker
1034 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1035 we don't need to black list the following images anymore:
1036 - 8BitsUncompressedColor.dcm
1038 - US-PAL-8-10x-echo.dcm
1039 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1040 fixes and the beautified code ;-)
1041 This fixes the bug introduced in version 1.42 (when beautifying)
1042 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1043 Note: ctest was blind to this bug (this means we need to still
1044 improve the test suite). The bug could be detected by using
1045 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1047 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1048 and by displaying the (garbage) produced file temp.XDCM...
1050 2004-06-29 Jean-Pierre Roux
1051 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1052 - replace by uggly but working old code :-(
1053 A lot of things should be OK again.
1054 It's really urgent to have a test suite that *tests*,
1055 to prevent Frog's beautifying sessions to break all the stuff
1056 (twice, withing a fortnigh ...)
1058 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1060 redundancy) to added Test/TestReadWriteReadCompare.cxx
1061 * Test/CmakeList.txt: because the compare test of
1062 Test/TestReadWriteReadCompare.cxx fails, the following images are
1063 black listed: - 8BitsUncompressedColor.dcm
1065 - US-PAL-8-10x-echo.dcm
1066 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1067 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1068 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1069 and ad-hoc kludge. This kludge is now removed, and on encountering
1070 such an image (OB field brain damaged) we set errno. Then in
1071 ::FindDocLength() we "fix" the length as being ALL what remains
1072 in the file (until EOF). We then proceed, hoping for the best...
1073 This fixes a SegFault in ShowDicom when trying to write such an
1075 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1076 (because TestWriteRead breaks on it, after a non conformal commit?).
1077 ctest now runs properly, except for MakeDicomDir (which was allways
1078 broken) and the Python related stuff (still not fixed).
1080 2004-06-24 Jean-Pierre Roux
1081 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1082 FIX : Test/TestReadWrite now iterates on all the file names
1083 (instead of infinite loop)
1084 ENH : Test/TestWriteRead now iterates on all the file names
1086 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1089 2004-06-24 Jean-Pierre Roux
1090 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1091 when SamplesPerPixel =3
1092 - now Write is no longer confused by
1093 'BitsAllocated = 12" and 'BitsStored=12"
1094 - "UN" value representation Elements are now written correctly
1095 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1096 ENH : - now gdcmHeader has its own Write methods
1097 (in order to split the job that has not to be done
1100 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1102 loop on the same image until memory went out.
1103 Note: this means we still have gobs of memory loss in PrintDocument
1104 * src/gdcmDocument.cxx: fixes problem on parsing on file
1105 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1107 2004-06-24 Jean-Pierre Roux
1108 FIX : Write - All the Sequences and Sequence Item are now written
1109 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1110 is added a the end, when necessary.
1111 - A lot of brain-damaged images, that were read correctly are
1112 now written correctly
1113 - length compatible BinEntry are now loaded correctly
1114 (even for odd groups)
1115 Note : only Explicit Value Representation was checked.
1116 (question : is implicit VR really necessary for gdcm ?)
1118 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * DEVELOPPER: added a proposition of coding style.
1120 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1123 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1125 Use the gdcmDocEntry::Print() and Write() instead.
1126 * src/gdcmDocument.cxx: bug fix.
1128 2004-06-22 Jean-Pierre Roux
1129 FIX : gdcmDocument.cxx
1130 - Now we do recognize the JpegLossLess format (there was a misstyping in
1131 code 'beautyfication' :-(
1132 - Now we automaticaticaly load the Luts, if any
1134 2004-06-22 Jean-Pierre Roux
1135 In order : to write Sequences, whatever their imbrication level,
1136 : to allow user to create his own Sequences
1137 a lot of modif where necessary (adding, moving, or virtualising methods)
1139 WARNING : save your own sources *before* cvs up !
1142 ADD virtual void Write(FILE *fp, FileType filetype);
1145 ADD virtual void Write(FILE *fp, FileType filetype);
1146 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1149 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1150 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1151 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1152 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1153 ADD std::string GetEntryByName(TagName name);
1154 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1156 std::string vr = "unkn",
1157 std::string fourth = "unkn",
1158 std::string name = "unkn");
1159 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1160 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1161 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1162 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1163 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1164 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1165 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1166 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1169 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1170 ADD virtual std::string GetEntryByName (TagName tagName);
1171 ADD virtual std::string GetEntryVRByName (TagName tagName);
1172 REM virtual bool Write(FILE *, FileType);
1173 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1174 FILE *_fp, FileType type);
1175 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1176 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1177 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1178 REM virtual std::string GetEntryByName (std::string tagName);
1179 REM virtual std::string GetEntryVRByName (std::string tagName);
1180 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1181 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1182 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1184 std::string vr = "unkn",
1185 std::string fourth = "unkn",
1186 std::string name = "unkn");
1187 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1188 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1189 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1190 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1193 ADD virtual void Write(FILE *fp, FileType filetype);
1196 ADD virtual void Write(FILE *fp,FileType filetype);
1199 ADD virtual void Write(FILE *fp, FileType filetype);
1200 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1201 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1202 REM std::string GetEntryByName(TagName name);
1205 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1207 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1209 The default constructor invoked by the line
1210 gdcmHeader *f1 = new gdcmHeader( header );
1211 was gdcmHeader::gdcmHeader(bool) instead of the expected
1212 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1213 Hence the parsing wasn't executed... See also below.
1214 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1215 as explicit constructor didn't do the trick to fix the above problem.
1216 Could anyone explain why ?
1217 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1218 properly calls gdcmValEntry::Print() (that was weed out from
1219 code related to gdcmBinEntry).
1221 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1222 * In order to fix memory leaks:
1223 - Test/TestWriteSimple.cxx: added cleaning of free store through
1225 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1226 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1227 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1228 (through the call to ::AddDicomDirMeta()) or the destructor
1229 would crash when deleting uninitialized ::metaElems].
1230 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1231 - src/gdcmDocument.cxx:
1232 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1233 from dynamic stores.
1234 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1235 was causing memory leaks.
1236 - src/gdcmSQItem.cxx:
1237 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1238 cleanly handled with polymophism: sorry but my milage is low).
1239 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1240 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1241 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1242 This avoids SegFaulting.
1243 - src/gdcmSQItem.h: coding style.
1245 - Test/TestWriteSimple still severely sucks. The output image content
1246 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1247 damaged when displayed with vtkgdcmViewer.
1248 - on memory leaks: TestWriteSimple leaks really less (see entry
1249 of 2004-06-18 in Changelog file for the call to valgrind).
1250 - on segfaults: ctest now passes all the tests but one (no more
1252 * Erroneous leading white fix:
1253 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1254 white[s] (as opposed to from >> xxx, that removes it [them].
1255 - src/gdcmTS.cxx: ditto.
1256 - gdcmPython/testSuite.py: dirty related kludge removed.
1257 * src/*: remaining references to gdcmParser removed.
1258 * src/*[cxx|h]: added copy[way]left header.
1261 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1262 * In order to fix writing of dicom files:
1263 - Test/TestWriteSimple.cxx: a simpler example of writing.
1264 - Test/CMakeLists.txt changed accordingly.
1265 - src/gdcmDocument.cxx:
1266 -- The destructor now recursilvely removes potential sequences.
1267 -- Bug fix in ::IsJPEG2000()
1268 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1269 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1271 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1272 to only declared) and build on top of
1273 ::GetDocEntryByNumber(guint16, guint16).
1274 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1275 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1276 for usage in destructor and treatement of promotion in
1277 ::ReplaceOrCreateByNumber().
1278 - src/gdcmSQItem.cxx: destructor should better handle his job.
1279 Test/TestWriteSimple now runs (or at least it DOES something).
1280 * We can now start hutting memory links. A good starting point is:
1281 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1282 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1283 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1285 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1286 * Valgrind note: after Mathieu Malaterre teached me how to read
1287 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1289 Using gcc, you can force the STL to use malloc and to free memory as
1290 soon as possible by globally disabling memory caching.
1291 With 3.2.2 and later, you should export the environment variable
1292 GLIBCPP_FORCE_NEW before running your program.
1293 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1294 simply vanish (it is still not clear to me, whether this means that
1295 STL std::string leaks or if valgrind believes it leaks...).
1296 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1297 running bin/gdcmTests makeDicomDir):
1298 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1299 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1301 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1302 SegFaulting (I drowned in DicomDir related code when trying to
1303 understand why the list is empty...).
1304 * src/gdcmDocument.h: first BSD license header try.
1305 * Doc/License.txt added.
1307 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * src/gdcmDocument.[h|cxx]:
1309 - Clean up of the Transfer related predicates. They are now all based
1310 on new method isGivenTransferSyntax, that (should) handle properly
1311 the padding problem.
1312 - general clean up, simplification, and coding style.
1313 - Specific clean up of Parse7FE0() (umproperly named actually).
1314 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1316 2004-06-14 Jean-Pierre Roux
1318 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1319 - fix the display of SQItem ordinal number
1320 - add the GetSQItemByOrdinalNumber method
1321 - remove some useless never written private methods
1323 2004-06-14 Jean-Pierre Roux
1325 - adding a constructor taking a gdcmDocEntry as an input param
1326 - ReplaceOrCreateByNumber now returns :
1327 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1328 a gdcmValEntry * if a string value is passed as a param
1330 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1331 according to the param type (no longer sets a gdcmDocEntry)
1332 - GetValEntryByNumber, GetBinEntryByNumber added
1333 - NewValEntryByNumber and NewBinEntryByNumber added
1335 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1337 - GetSQItemNumber and SetSQItemNumber added, to provide
1338 a (relative) Item identier inside a given Sequence
1339 \warning : some pb remaining around this number
1341 - AddEntry now takes the Item Number as a param
1343 - adding a constructor taking a gdcmDocEntry as an input param
1345 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1346 * Memory leak hunt with the following command:
1347 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1348 --show-reachable=yes gdcmTests PrintDocument
1349 It looks like many (all?) leaks are due to the STL (or a bad usage
1350 of the STL. The lines producing the leaks now have a comment with
1351 a "MEMORY LEAK" tag: you can retrieve them with
1352 grep "MEMORY LEAK" src/*
1353 Here are two typical examples which I can't help fixing:
1358 char * test = "babo";
1359 name = test; //// <--- valgrind detects 960 bytes lost in
1360 //// call to std::string::operator=(char const*)
1361 name.clear(); //// Doesn't help !
1369 std::cout << "Type a bunch of characters followed by RETURN: ";
1370 getline(std::cin, line); //// <--- valgrind dectects a loss
1371 //// of 1320 bytes in call to
1372 /// std::basic_istream<>& std::getline<>
1378 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * src/gdcmHeader.[cxx|h]:
1380 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1381 and related, moved away to gdcmDocument.
1382 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1383 the corresponding protected accessors of inherited class
1384 gdcmDocument, removed ! As a consequence gdcmFile had to be
1385 declared friend of class gdcmDocument (see below).
1386 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1387 - Clean up of undefined or unused methods.
1388 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1389 account the changes to gdcmHeader.h).
1390 * src/gdcmDocument.h:
1391 - gdcmFile is now a friend class (in order to take into account the
1392 changes to gdcmHeader.h).
1393 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1394 (see changes to gdcmHeader.h).
1395 - Accessors (reading on the form GetEntry*) are now public.
1396 - Clean up of undefined or unused methods.
1397 * src/gdcmDocument.cxx:
1398 - adaptation to changes to gdcmDocument.h
1399 - ::OpenFile now writes a verbose message when file cannot be opened.
1400 - some std::string properly set to VRKey
1401 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1402 references to gdcmDocument.
1403 * Test/TestFindTags.cxx: changed accordingly to above changes.
1404 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1405 cvs repository gdcmData.
1407 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1409 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1410 conflicts with gdcmValEntry::voidArea.
1411 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1412 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1413 Value representation between StringRepresentable and BinaryRepresentable.
1414 * src/gdcmDocument.cxx:
1415 - method ParseDES: proper indentation restored and usage of
1416 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1417 - method LoadDocEntry: the fingerprint left in the SetValue() of
1418 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1419 removed. Reverting to previous code segment with the proper
1420 dynamic_cast< gdcmValEntry* >.
1421 Note: this was (partially) breaking the python test suite
1422 (gdcmPython/testSuite.py) that made usage of the above
1423 fingerprint to check presence of "Pixel Data".
1424 * src/gdcmDocEntry.h: coding style.
1425 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1426 now taken into account.
1427 * gdcmPython/gdcm.i: adaptation to the new internal representation
1428 of gdcm (exit gdcmParser, hello gdcmDocument).
1429 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1431 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1432 anymore, but instead prints the loaded Python dictionary.
1433 * .... alas, the python testSuite is still broken.
1435 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1436 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1438 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1439 * src/gdcmUtil.h : export methods
1441 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1442 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1444 * Initial addition of automatic python testing
1445 * Initial addition of automatic image comparison
1447 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1448 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1449 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1451 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1452 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1453 * Test/ShowDicom.cxx : bug fix for msvc compilation
1454 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1456 2004-05-04 Jean-Pierre Roux
1457 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1458 new concepts (and new classes) :
1459 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1460 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1461 - Sequence Doc Entries (gdcmSeqEntries)
1462 a Sequence is composed of Items.
1463 Each item is a set of Doc Entries (this is recursive)
1464 The non uniqueness of the 'Dicom tag' is due to this recursivity
1465 (never taken into account)
1466 Our unability to add a new 'entry' in the header
1467 at the proper location (neither in the H-Table (map or multimap),
1468 nor in the Chained List is also due to this recursivity.
1469 Don't try, right now, to use/modify/compile these new sources :
1470 nothing is finished.
1471 We just commit all the stuff, 'as is', in order not to loose it.
1473 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1474 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1476 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1478 file prefix (SetFilePrefix)
1480 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * Add a new test: ShowDicom, for now this is just the c++ version of
1482 checkRead.sh, later it will be able to compare the image read against a
1484 * Replace the DEBUG on the stack with a global entry in cmake interface:
1485 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1487 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1488 * Add an example subdir, with a real example on how to read + write a
1491 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1492 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1493 * Doc/CMakeLists.txt: the main page is now properly differentiated
1494 between the developper and user version.
1495 * Doc/doxygen.config.in: dropped search related obsolete flags
1496 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1498 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1499 * DEVELOPPER: added some helpfull comments for compile/test/install
1502 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1504 src directory, now generated in the build dir.
1505 2. Tests as mentionned smarter
1507 4. Add a new method in gdcmDict that return the PubDict by name
1508 this is interesting for 3rd party lib like ITK,
1509 where we could set the institution name / patient name...
1511 * ENH: 1. Now the test suite is working for real
1512 2. All binaries are now output in the gdcm-bin directory
1513 (this was not true before)
1515 2004-04-28 Jean-Pierre Roux
1516 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1517 SeQuence indented printing of Dicom Header.
1518 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1519 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1520 Computation of SQDepthLevel is now part of gdcmHeader constructor
1521 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1522 tree-like structure of a Dicom Header.
1523 * FIX Test code cleaning
1525 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1526 * ENH: Adding automatic testing
1527 1. Need a DartConfig.cmake to submit to public
1528 2. Add a test driver gdcmTest.cxx
1529 3. gdcmTestMain, an helper for the main test driver gdcmTest
1530 4. Files in Test don't have a main anymore, this becomes interesting
1531 when we add more and more tests, thus dsw don't have to load
1533 * ENH: Adding a GDCM_DATA_ROOT for testing
1534 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1535 one file instead of seven + some small cleanup
1537 2004-04-22 Jean-Pierre Roux
1538 * ENH Minor changes to the Print() methods.
1539 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1540 Header printing. Example given with :
1541 > PrintHeader fileName 2 new
1542 (SQ based tree-like structure still to be done for the Header ...)
1544 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1545 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1546 1. I have added some unsigned where needed
1547 2. Some function parameter not used -> (void)
1548 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1549 4. g++ don't like character '\' in comment
1550 5. #define jpeg_create_decompress jCreaDecompress
1551 this really need to be fixed
1552 6. virtualize destructor of gdcmObject ... leakage
1553 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1554 this also really need to be fixed
1555 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1556 remove compression file
1557 (as we only do decompression, right ?)
1558 * ENH: Change malloc/calloc/free with c++ equivalent
1560 2004-04-21 Jean-Pierre Roux
1561 * FIX gdcmHeaderHelper::GetXSpacing
1562 when a single value is found (bug ?), xpacing is now
1563 defaulted to yspacing
1565 2004-04-19 Jean-Pierre Roux
1566 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1567 * ENH add parameters :
1568 bool exception_on_error = false,
1569 bool enable_sequences = false,
1570 bool ignore_shadow = false
1571 to the gdcmFile constructors to be full gdcmParser compliant
1572 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1573 to allow reading of PAPYRUS 3.0 files
1575 2004-04-06 Jean-Pierre Roux
1576 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1578 2004-04-02 Jean-Pierre Roux
1579 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1580 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1581 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1583 2004-03-30 Jean-Pierre Roux
1584 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1585 for ACR file, written out as DICOM files (hope so...)
1587 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1588 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1589 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1590 moved to base class gdcmParser and only the specialisation is kept
1592 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1593 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1594 already does the job.
1595 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1596 (to be consistent with gdcmParser::WriteEntries).
1598 2004-03-30 Benoit Regrain
1599 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1600 upate of the object's instance. It's passed to 2 in the unfavorable
1601 case : one in the ExecuteInformation, one in the ExecuteData
1603 2004-03-29 Jean-Pierre Roux
1604 * ENH : Check on file type to be written moved
1605 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1606 * FIX : gdcmObject::ResetBoundaries now stops properly
1607 when end-of-list is reached
1608 : gdcmVersion modified (as Benoit Regrain asked)
1610 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1612 * src/gdcmUtil.cxx: added forgotten iostream include.
1613 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1614 equivalent to ExplicitVR in existing code).
1616 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1618 now contains all the gdcmGlobal related code.
1619 * minor coding style and doxygenation changes.
1621 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1622 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1623 now contains all the Debug related code.
1624 * minor clean-up of includes in src/*.cxx
1625 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1626 CreateCleanString) removed.
1627 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1628 * Doc/DoxyMainPageUser.txt added.
1629 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1630 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1631 src/gdcmDirList.cxx)
1633 2004-03-24 Jean-Pierre Roux
1634 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1636 2004-03-23 Jean-Pierre Roux
1637 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1638 big endian made volumes
1639 * ENH Now gdcmParser constructor and destructor are protected to forbid
1640 end user to instanciate class gdcmParser
1641 (only gdcmHeader and gdcmDicomDir are meaningfull)
1643 2004-03-22 Benoit Regrain
1644 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1645 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1646 gdcmSerie to gdcmDicomDirSerie
1648 2004-03-19 Jean-Pierre Roux
1649 * ENH Now the tree-like structure describing a DICOMDIR comming from
1650 an already existing DICOMDIR file is consistent with
1651 the home-made tree-like structure build ex-nihilo
1652 or build from the files held (recursively) in a Directory
1653 functions gdcmDicomDir::CheckBoundaries()
1654 gdcmObject::SetBoundaries() added
1656 2004-03-17 Jean-Pierre Roux
1657 * REM (Eric Boix bug) : removal of meaningless
1658 gdcmDicomDirImage::NewImage function.
1659 * FIX now file names and directory name are written properly in the
1661 * FIX now gdcmDicomDir constructor may be call without any trick
1664 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1665 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1666 of gdcmDicomDirImage::NewImage as empty function.
1668 2004-02-28 Jean-Pierre Roux
1669 * ENH add gdcmDicomDir:NewPatient
1670 add gdcmDicomDirPatient:NewStudy
1671 add gdcmDicomDirStudy:NewSerie
1672 add gdcmDicomDirSerie:NewImage
1673 to allow making gdcDicomDir object.
1674 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1675 (as opposite to the gdcmHeader chained list)
1677 2004-02-11 Benoit Regrain
1678 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1679 when using from python
1681 2004-02-10 Benoit Regrain
1682 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1683 * FIX : in gdcmDicomDir when the directory is empty
1684 * ENH : add callback and methods to get the progression of dicomDir
1687 2004-02-06 Jean-Pierre Roux
1688 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1689 - GDCM_META added to gdcmDicomDirType
1690 - class gdcmMeta created
1691 * ENH : - A brief summary is now displayed at the beginning of
1692 'testDicomDir' to help disaster magnitude estimation
1693 * REM : Now useless Test/explDICOMDIR.cxx
1695 2004-02-05 Benoit Regrain
1696 * ENH : add methods in gdcmObject to get the hash table or the list of
1698 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1699 * FIX : wrapping python for TagHeaderEntryHT
1701 2004-02-04 Benoit Regrain
1702 * FIX : even length for some strings when writting the dicom dir
1703 * FIX : sort the images in the dicom dir
1704 * FIX : Bug fix for python use of dicom dir
1705 * ADD : a python demo
1707 2004-02-04 Jean-Pierre Roux
1708 * FIX : Final solution (?) for icone embedded images
1709 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1710 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1711 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1712 gdcmData/gdcm-MR-SIEMENS-16.acr1
1713 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1714 to make full checking easier
1716 2004-02-04 Benoit Regrain
1717 * FIX : WriteEntries : coding style & logic in parameters
1718 * FIX : Set the elements to create the DicomDir in a dictionary file
1720 2004-02-03 Benoit Regrain
1721 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1722 * gdcmDicomDir : add the load of directory
1723 * Bug fix and print add-on
1725 2004-02-03 Jean-Pierre Roux
1726 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1727 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1728 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1729 * FIX gdcmParser.cxx : 'group length' elements are now considered
1730 as integers, even for shadow groups, when file is Implicit VR
1732 2004-02-02 Jean-Pierre Roux
1733 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1735 of the last synonym :-(
1736 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1738 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1739 * FIX taking into account the possible 7fe0,0010 multiplicity
1740 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1741 to allow removal of references to 7fe0,0010, to deal with
1742 ACR-NEMA images, when 0028,0200 is meaningfull
1744 2004-01-31 Jean-Pierre Roux
1745 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1746 no longer writes 'Un' on disk
1747 * FIX SQ elements with actual length are now dealt with corectly
1748 * FIX gdcmFile::WriteBase make the difference, for color images, between
1749 the length (for Palette expanded images)
1750 and Raw Length (non expanded image + Palette)
1751 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1752 (that broke Write). Replaced by UL.
1753 Aware user will reload the field if he
1754 thinks it's necesssary
1756 2004-01-30 Jean-Pierre Roux
1757 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1758 when 'dirty Acr' is found, to be compliant with the new
1759 IsReadable() methods.
1761 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1762 (no DOUBLE images in kosher DICOM,
1763 but so usefull for people that miss them ;-)
1765 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1766 DICOMDIR related utilities (not checked as Windoze compliant)
1768 2004-01-28 Jean-Pierre Roux
1769 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1771 2004-01-27 Jean-Pierre Roux
1772 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1773 to allow skipping the shadow elements, to save memory space.
1774 The TRUE value for this param has to be used
1775 with a FALSE value for the 'enable_sequence' param.
1776 ('public elements' may be embedded in 'shadow Sequences')
1777 * gdcmHeader methods now deal with 'embedded icones images' in the header
1778 (even when an 'icone image sequence' is announced by the
1779 element (0x0088,0x0200), but there is NO icone at all ...
1781 * gdcmHeader sometimes Image Location value doesn't follow
1782 the supposed processor endianity (see gdcmData/cr172241.dcm).
1785 * gdcmHeader add the method
1786 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1787 to get *all* the Header Entries with the same tag.
1788 GetHeaderEntrySameName is probabely *useless*
1789 (no meaning : Name is *not* an identifier within the Dictionnary)
1791 2004-01-26 Benoit Regrain
1792 * Bug fix in the print of hexadecimal representations. Remove long fields
1793 in the print and add a third level of print to print them
1795 2004-01-23 Benoit Regrain
1796 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1797 * Bug fix on test suite after remove the strip made on not string fields
1798 * Split the IsReadable method between gdcmParser which test that the file
1799 is dicom and gdcmHeader which test that it's an image file
1801 2004-01-22 Benoit Regrain
1802 * DicomDir : clean code, add methods, set variables in protected or private
1803 * gdcmUtil : bug fix for the clean string method
1805 2004-01-19 Benoit Regrain
1806 * Add the use of shadow dictionaries
1807 * bug fix and coding style
1809 2004-01-19 Benoit Regrain
1810 * src/gdcmFile.cxx : bug fix concerning the close of file
1811 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1812 * Add the update of header entries using the shadow library
1814 2004-01-19 Benoit Regrain
1815 * removal of file gdcmHeader2.cxx
1816 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1817 inheriting from gdcmParser. This split is to prepare the integration
1818 of dicom dir parsing
1819 * bug fix under python
1821 2004-01-16 Jean-Pierre Roux
1822 * REM removal of class gdcmHeaderEntrySet
1823 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1824 * ADD add file gdcmHeader2.cxx
1825 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1827 2004-01-15 Benoit Regrain
1828 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1829 entries created while parsing the header. Thus, they will be destroyed
1830 when the gdcmDictSet will be destroyed
1831 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1834 2004-01-15 Benoit Regrain
1835 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1836 made a fatal error because of the memory release at the end of program.
1837 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1838 some memory and vtk seems to have some problems with that.
1839 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1841 2004-01-14 Benoit Regrain
1842 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1843 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1844 * src/*.[h|cxx] : make changes due to class name changes
1845 * gdcmPython/demo/*.py : bug fix due to method names
1847 2004-01-13 Benoit Regrain
1848 * src/*.[h|cxx] : coding style
1849 * vtk/*.[h|cxx] : coding style
1851 2004-01-13 Benoit Regrain
1852 * gdcmPython/testSuite.py : test the readable flag of file for tests
1853 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1854 It's lied to the stl compilation by MSVC (windows, always windows...)
1855 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1857 2004-01-12 Benoit Regrain
1858 * src/*.h : add comments
1859 * src/gdcmDictSet.h : set the method BuildDictPath in public
1860 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1861 directly setted in the source code
1862 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1865 2004-01-09 Benoit Regrain
1866 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1867 * setup.py : use a reference to gdcmVERSION
1869 2004-01-07 Benoit Regrain
1870 * Modification to compile with the distutils.
1873 2003-12-10 Benoit Regrain
1874 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1875 can use a gdcmHeaderHelper to load data
1876 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1877 made in the source code
1879 2003-12-10 Benoit Regrain
1880 * Update Windows projects and .cvsignore files
1882 2003-11-12 Jean-Pierre Roux
1883 * ENH gdcmHeader constructor has one more parameter (default value : false)
1884 that allows the user to 'go inside' the SeQuences only
1886 gdcmElValSet:Print takes it into account
1888 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1889 * ENH: Update gdcmPython/CMakeLists
1890 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1891 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1893 2003-11-10 Jean-Pierre Roux
1894 * FIX : gdcmHeader::LoadElements is now based
1895 on the ListTag listElem member,
1896 not longer on the TagElValueHT tagHt member
1897 * ENH : PrintPubElVal shows (temporarily) both results,
1898 with the tagHt member and the listElem member.
1899 (it's easier to 'see' the problems when using Printheader)
1901 * FIX : old private member LgrElem is now splitted into
1902 ReadLength : Length actually found on disk (updated only
1903 if bug fixing is necessary), for internal
1905 UsableLength : Updated by FixFoundLength, to fix a bug
1906 or to allow Parser going on.
1907 Will allow to re-write a kosher header when a SeQuence
1908 with a length (not 0000) is found
1909 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1910 because gdcmElValSet::Add does not update ListElem
1913 2003-11-07 Jean-Pierre Roux
1914 * FIX misstyping in Transfert Syntax name table
1915 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1916 when they have an actual length (not 0000 nor FFFFF)
1917 (Nobody should care of it, but DICOMDIR explorers)
1919 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1920 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1922 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * ENH: vtkGdcmReader now supports LUT !
1924 (vtkgdcmViewer for now is not able to use them though)
1926 2003-11-05 Jean-Pierre Roux
1927 * in testSuite.py : new files names for checking the package
1928 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1929 that returns the pixel area size to the *aware* (vtk) user
1930 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1932 2003-11-05 Benoit Regrain
1933 * in testSuite.py : Modify the rules for checking the paths
1934 : Explicit error messages
1935 * in __init__.py : Related modif
1937 2003-11-03 Jean-Pierre Roux
1938 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1939 to be used by aware (vtk) users that want to manage
1940 LUT (and no to turn the PALETTE image into an RGB pixels one)
1941 * GetPixelType now returns 8U for 24 Bits images
1942 (vtkGdcmReader compliant)
1944 2003-10-31 Jean-Pierre Roux
1945 * Removal of *all* gdcmData images and add them again
1946 in order to loose the 'history' of un-anonymised images
1948 2003-10-31 Jean-Pierre Roux
1949 * RMV : removal of useless jBitsInJsample.h
1950 for both 8 and 12 Bits JPEG Lossy Libraries
1952 2003-10-31 Jean-Pierre Roux
1953 * ENH : Add the functions gdcmFile::GetImageDataRaw
1954 gdcmFile::GetImageDataIntoVectorRaw
1955 that act as GetImageData and GetImageDataIntoVector
1956 except the making of an RGB Plane from Gray Plane + LUT
1957 Intended to aware (vtk) users who know how to manage
1960 GetLUTRGBA return a R,G,B,A LUT if any
1961 lgrTotaleRaw gives the 'Raw' length
1962 GetImageDataRaw returns the gray Plane
1963 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1964 (They stay Grey, just like with other Dicom viewers :-(
1966 2003-10-30 Jean-Pierre Roux
1967 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1969 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1971 being coherents dicom files.
1973 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1974 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1976 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1977 * ENH: Two steps is necessary to please VC++ compiler...
1978 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1979 * ENH: Add include dir to medcon lib
1980 * FIX: only one function is being exported for now !
1981 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1983 2003-10-29 Jean-Pierre Roux
1984 * adding gdcmHeader::GetLUTRGBA
1985 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1986 --> Mathieu, the modif u're waiting for is not yet committed
1987 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1989 2003-10-27 Jean-Pierre Roux
1990 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1991 00191113.dcm DermaColorLossLess.dcm
1992 MxTwinLossLess.dcm RadBWLossLess.dcm
1993 * ENH: For version prior to vtkImageViewer2 -r 1.19
1994 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1996 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * Removal of ido stuff in CMakeLists.txt
1999 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2001 * FIX: remove a call to ->Modified ... see comments
2002 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2004 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * FIX: Problem with path for libvtkgdcmPython
2006 * ENH: Try adding a search script for python site-package
2007 * RMV: Remove some file from medcon lib that are not necessary
2008 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2009 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2010 * FIX: More pragma disable fro VC++,
2011 I don't think I break something as it is also disable in VTK/ITK.
2012 But it fasten debug compilation time.
2014 2003-10-23 Jean-Pierre Roux
2015 * gdcm now deals with 16 Bits Run Length Encoded images
2016 (they are compressed as 2 planes images,
2017 one for the high Bytes, the other for low Bytes)
2019 2003-10-22 Jean-Pierre Roux
2020 * Now CheckRead takes into account :
2021 - the bugged 'Leonardo' Siemens images
2022 - the XA images, sent thru the burning VPRO station
2023 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2026 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * FIX: When copying a Makefile.am to CMakeLists.txt
2028 one should remove the '\'
2030 2003-10-22 Jean-Pierre Roux
2031 * in gdcmData adding a bugged 'Leonardo' Siemens image
2032 (wrong lengths in header)
2033 OK with gdcm, KO with the other viewers :-)
2034 * add a GE dlx XA image, thru the VEPRO burning station
2037 2003-10-21 Jean-Pierre Roux
2038 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2039 for a brutal checking of vtkgdcmViewer compliance
2041 2003-10-21 Jean-Pierre Roux
2042 * add the files for 'xmedcon' Jpeg Lossless library
2043 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2045 2003-10-21 Jean-Pierre Roux
2046 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2048 2003-10-21 Jean-Pierre Roux
2049 * garbage Siemens 'Leonardo' images dealt with
2050 (the patch is easy to remove)
2051 * cosmetic changes to avoid warnings
2053 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2055 no need to press 'r' now.
2057 2003-10-20 Jean-Pierre Roux
2058 * upgrade of checkRead.sh checkWrite.sh according
2059 to new Jpeg Lossless decompressor
2060 * add US.3405.1.dcm, a genuine RGB medical file ...
2061 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2062 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2064 2003-10-15 Jean-Pierre Roux
2065 * general anonymisation in gdcmData
2066 * adding the 'color files' from
2067 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2068 * adding some well knowed bugged-header images
2069 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2070 waiting for their inclusion in Python testsuite
2072 2003-10-15 Jean-Pierre Roux
2073 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2074 no longer seg faults when file is not found
2076 2003-10-14 Jean-Pierre Roux
2077 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2080 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2081 * TODO: *.in file to genereate a UseGDCM later
2083 2003-10-14 Jean-Pierre Roux
2084 * Some supposed-to-be Dicom Images have no preamble.
2085 OpenFile takes it into account
2086 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2087 * Missing elements added in dicomV3.dic
2088 (just to be affraid : have a look at
2089 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2090 and do it again next year ;->
2092 2003-10-13 Jean-Pierre Roux
2093 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2094 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2095 But there are NOT. It's fixed !
2097 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * FIX: "jpeglib.h" was not found on VC++
2099 * FIX: vtkgdcm was not being installed
2101 2003-10-10 Jean-Pierre Roux
2102 * ENH : OpenFile closes the file if it *really* doesn't look like
2103 an ACR-NEMA / DICOM one.
2104 * FIX : testWrite no longer writes an empty file if the source file
2105 is not gdcm Readable
2106 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2109 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2110 * FIX: CMake generate now documentation
2111 * ENH: out of source doc build !
2112 * ENH: Generate both user and dev documentation
2113 * ENH: Should work on windows too
2114 * ENH: Only one doxygen config.in file is needed
2115 * FIX: make install should be ok now on ùnix plateform
2116 * FIX: PATH to dictionary was wrong (missing /)
2117 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2119 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2120 * vtkGdcmReader is now able to read rgb dicom file.
2121 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2122 * added a gdcmViewer to vtk test, use mouse to control
2123 window level & window width
2125 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2126 * CMake-ification of gdcm, we have now two build system
2127 * FIX: on cygwin Wsock32 doesn't exist
2128 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2130 2003-10-06 Emanuel Ollart
2131 * FIX : compilation process wad broken.
2132 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2134 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2135 * change gdcmViewer -> vtkgdcmViewer
2136 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2138 2003-10-06 Jean-Pierre Roux
2139 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2140 ( e.g : well known GE images with a wrong elem length,
2141 : Philips MRI Images with a wrong Huffman table)
2142 * still to be done : allow the reading of bugged LEONARDO Siemens images
2144 2003-10-03 Jean-Pierre Roux
2145 * Odd length strings are padded with '\0' (not with spaces,
2146 to remain compliant with already defined strings,
2147 like Transfert Syntax UID and others)
2149 2003-10-03 Jean-Pierre Roux
2150 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2151 to allow displaying RGB images (not only by affim ;-)
2153 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2154 * vtkGdcmReader is now able to read rgb dicom file.
2155 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2157 2003-10-03 Jean-Pierre Roux
2158 * A few nasty patches to allow the reading of a lot of nasty images
2159 ( e.g : well known GE images with a wrong elem length,
2160 : Philips MRI Images with a wrong Huffman table)
2161 * still to be done : allow the reading of bugged LEONARDO Siemens images
2163 2003-10-03 Jean-Pierre Roux
2164 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2166 2003-10-03 Jean-Pierre Roux
2167 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2168 to allow displaying RGB images (not only by affim ;-)
2170 2003-10-03 Jean-Pierre Roux
2171 * gdcmFile::GetImageDataIntoVector now
2172 - deals with MultiFrames MultiFragments Run Length Encoded files
2173 - deals with YcBcR (YBR_FULL) files
2174 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2175 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2177 (no sample found :-(
2179 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2180 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2181 Two reasons: - clear things
2182 - third parties acces gdcm through header files, so won't
2183 suffer anymore VC++ complains
2185 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * add argv[1] in testvtkGdcmReader.cxx
2189 2003-09-24 Jean-Pierre Roux
2190 * The lines are now eigthy characters long.for
2191 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2193 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2195 char* to std::string. Thus, the use of strdup becomes useless. (see
2196 previous commis of Malaterre)
2197 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2198 before the last Malaterre's commit.
2200 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * This commit should fix the Debug building under VC++, the problem
2202 was mainly a mixture of debug and release lib being loaded at startup.
2203 * I also remove a depency to a specific C function: strdup. Because I had
2204 to force the link to msvcrtd (whereas strdup is in libc).
2206 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2207 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2208 located in the gdcmCommon.h file. All use of reference of tha has been
2209 changed to now use the variable GDCM_UNFOUND.
2211 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2213 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2214 Dicom dictionary. The test suite can now be run again. Note:
2215 I'm note very happy with the " (RET)" changes. I believe this
2216 RETAINED comment should be dropped when parsing the dictionary.
2217 - PACKAGER corrected
2219 - AUTHORS updated and now in alphabetical order
2220 * Makefile.am now exports gdcm.dsw for Windoze users.
2222 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2223 * cygwin complains about missing std:: in subdir Test/
2225 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * remove some methods that are now in gdcmHeaderHelper
2228 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2229 * vtkGdcmReader set spacing and origin correctly
2231 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2232 * Fix a few delete/delete[] mismatch
2234 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2235 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2236 interpretation to data given by gdcmHeader. For instance there are
2237 heuristics to get informations (look at different places).
2238 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2239 sorting DICOM images based on different strategies.
2240 * modified Makefiles accordingly.
2242 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2243 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2244 when building in debug mode
2245 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2246 src/win32/gdcmdll.dsp
2247 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2249 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2253 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2254 * src/win32/libgdcmjpeg12.dsp was not dos format
2255 * src/win32/libgdcmjpeg12.dsp :
2256 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2257 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2259 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2260 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2262 * src/gdcmFile.cxx : bug fix in affectation type
2263 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2264 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2265 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2266 symbols... future problem ?
2268 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2269 * src/win32/libgdcmijpeg12.dsp was missing
2270 * modified gdcm.dsw accordingly
2272 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2273 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2275 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2276 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2277 commit of JPR (before his hollidays to facilitate our work).
2278 * setup.py : bug fix in code. Modifications made while the last commit
2279 of JPR. The code hasn't been tested before the commit... it's so
2280 useless to make that (for best programmer that is JPR) !!!
2282 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * tagged the current version as Version0_3 (i.e. version 0.3)
2285 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2286 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2287 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2288 * *.dsp : modifications to use new libgdcmijpeg8 library
2289 * setup.py : bug fix on VTKPATH variable
2290 * PACKAGER : adding all concerning windows
2292 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2293 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2295 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2296 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2297 test suite reported error.
2298 * PACKAGER file added (describes what a packager must do when
2299 packaging a new release).
2300 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2301 * configure.in: upgraded version number to 0.3.0
2302 * fixing build of rpm (through rpm -ta):
2303 - Doc/Makefile.am exports proper doxygen files
2304 - src/jpeg/libijg8/Makefile.am exports the include files.
2306 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2307 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2308 * src/gdcmHeader.h : formatting code
2310 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2311 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2312 We were obtaining error message from vtk. Now, creation of file list
2313 is made in an internal list to prevent this problem.
2314 Bug fix when output is empty.
2315 Bug fix in update of progress value. Previous commit for this was a bad
2317 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2319 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2320 * src/gdcmHeader.h : added method to get the file name
2321 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2322 files. Added method to remove all files on the input
2323 Added FIXME comment concerning the bad parsing of header made by
2324 ExecuteInformation method (in ExecuteData method)
2326 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2327 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2328 when using make instal.
2329 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2330 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2332 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2333 * setup.py : adding include dir of jpeg lib to compile all sources
2334 * */Win32/*.dsp : JPR fix for windows compilation
2336 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2337 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2339 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2340 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2342 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * setup.py is again effective on un*x (takes into account the
2344 addon of the jpeg library)
2345 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2346 * Doc/Doxy* updated (includes above enhancements)
2347 * INSTALL now points to web documentation
2349 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * src/gdcmHeader.h doesn't make unnecessary reference to
2352 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2354 * src/gdcm*.[cxx|h] :
2355 - to allow compilation with gcc 3.x
2356 -- clean up of STL usage (added explicit usage of std::)
2357 -- small fixes on exceptions.
2358 Note: linking not tested !
2359 - clean of doxygen comments to avoid warnings at documentation
2361 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2362 dependent convertion).
2364 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * Clean up of previous JPR garbage commit (not even commented in the
2367 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2368 - moved all jpeg related files from src to src/jpeg/libijg8, with
2369 addition/modification of Makefile.am and configure.in.
2370 - the testSuite is still brain damage (not guilty).
2372 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2373 * WrapVTK.py : modifications to get correctly vtk source files to
2375 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2376 (FileName -> Filename)
2378 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2379 * vtk/vtkGdcmReader.[cxx/h]:
2380 - UpdateProgress method should now be effective
2381 - removed the limitation on having only images loaded (as opposed
2383 - when building a stack of images/volume, a lesser number of
2384 gdcmHeader and gdcmFile instances should be used (hopefully
2385 accelerating things).
2386 - when building a stack of images/volumes, files which are not
2387 loadable (wrong path-filename, wrong permissions on existing file,
2388 or file not parsable by gdcm) are replaced with a black image
2389 in the stack (for the caller to notice the problem).
2391 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2394 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2395 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2396 between standard library (std) and vtk library (problems are found
2397 under Windows... thanks Windows !)
2399 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2402 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2404 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2405 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2407 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * When compiling with distutils (see setup.py) the C++ compiler is
2409 called with different flags than the default ones (with automake).
2410 In order to fix all those warning, I compiled gdcm with the command
2411 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2412 and went for warning fixes:
2413 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2414 up from unused variables.
2415 - vtk/vtkGdcmReader.cxx: potential bug fix.
2416 * src/gdcmHeader.h: Doxygen warning cleanup
2418 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2419 * gdcmPython/gdcm.i:
2420 - typemaps correction to take into account the systematic replacement
2421 of "using namespace std" with std:: prefix e.g. std::list,
2422 std::string... (cf changes of 2003-05-21).
2423 - gdcmGlob global variable of type gdcmGlobal (defined in
2424 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2425 exported to Python a as cvar.
2426 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2427 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2428 gdcmDictSet.GetPubDictTagNames() and
2429 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2430 C++ static methods).
2431 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2432 with the above changes.
2434 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2435 * setup.py, manifest.in : bug fix under linux
2437 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2438 * Modification of setup.py to compile vtk part too. Then, we have 2
2439 wrappers which must work with same distutils. For that, we have a
2440 generic distutils in distusiltsWrapping.py ; with :
2441 - build_extWrap class to wrap generically all extensions,
2442 - ExtensionWrap base class for all wrapping extension that contains
2444 - Wrapper interface which wrap sources
2445 + In WrapSwig.py we have extension and wrapper for Swig
2446 + In WrapVTK.py we have extension and wrapper for VTK
2447 * MANIFEST.in : modifications to consider vtk directory and new python
2448 files for compilation
2450 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2451 * Added python wrappers of vtkGdcmReader vtk class (see the
2452 source in vtk/vtkGdcmReader.cxx) :
2453 - vtk/Makefile.am now builds a library
2454 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2455 python library (as opposed to _gdcm.so wich are the python
2456 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2457 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2459 - configure.in has an additional flag --enable-vtk that needs
2460 to be set to enable compilation of vtk related code, that is:
2461 + vtk/vtkGdcmReader.so and
2462 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2463 + gdcmPython/vtkgdcmPython.so (see above)
2464 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2465 be read when compressed or when HighBit + 1 != BitsStored),
2466 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2467 the usage of the python wrapper of vtkGdcmReader vtk class.
2468 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2469 * src/*.[h] all occurences of stl classes are now prefixed with
2470 std::, and all occurences of "using namespace std;" where removed.
2471 This is to avoid pollution of global namespace in included files.
2472 Apparently vtk does not avoid this pitfall: when using both
2473 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2474 collision of various stl members (principally cout...).
2475 * gdcmPython/testSuite.py now cleanly removes temprory generated
2477 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2478 comply with above changes)
2480 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2481 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2482 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2483 vtk data structure (an image Flip was required).
2484 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2485 * cosmetic changes in documentation.
2487 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2488 * src/gdcmHeader.cxx: the constructor no longer exits when an
2489 unexisting file is given as argument.
2490 * The subdirectory Data (containing all the images used for the
2491 test suite) is not part of this repository anymore. A new module
2492 containing those images is now available at
2493 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2494 with the name gdcmData.
2495 All the python scripts (including the package initialisation file
2496 gdcmPython/__init__.py) were adapated to take this change into
2497 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2499 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2500 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2501 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2502 demo of the usage of this class.
2503 Compilation of this vtk part is only done when using the --enable-vtk
2504 at configure (or autogen.sh) stage.
2506 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2507 * More memory link related corrections and documentation fixes.
2509 - maximum info is obtained with a command of the form:
2510 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2511 --show-reachable=yes PrintHeader
2512 - the remaining reachable blocks seem to come from the STL
2513 allocation scheme through the usage of map and list. It looks
2514 like this memory cannot be freed but it is not a memory leak
2515 (in fact further invocation to the STL would recollect the
2516 unused memory allthough it cannot explicitely be freed).
2517 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2518 of displaying an image parsed with gdcm and displayed with VTK.
2519 Note: some images don't seem to work e.g.
2520 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2521 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2522 Allthough this weakens the semantics, it is a ditch attempt to
2523 make gdcm more thread friendly.
2525 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2526 * Memory link hunt (by using valgrind through the command
2527 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2528 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2529 gdcmHeader::_dicom_vr.
2530 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2531 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2533 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2535 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2536 * src/Makefile.am now exports all the necessary include files at
2540 * UpdateGroupLength replaced by new one
2543 * UpdateGroupLength re-written using H-Table
2544 (named UpdateGroupLengthNew untill checks are over)
2546 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2547 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2548 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2550 - gdcmHeader::GetPubElValSet removed.
2551 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2552 UpdateGroupLength, WriteElements, Write.
2553 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2554 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2555 carried the same semantics.
2556 - src/gdcmHeaderIdo.cxx changed accordingly.
2557 - gdcmFile::WriteBase now regroups all the codes from previous
2558 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2559 - enum FileType moved to gdcmCommon.h
2560 * src/gdcmHeader.cxx AddDefault trashed
2561 * gdcmGetXSize added
2562 * getimageDataSize now calls gdcmGetXSize
2563 * Test/*.cxx changed to agree with above changes
2565 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2567 (to avoid double call by end user).
2568 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2569 by end user, since gdcmHeader::gdcmHeader now handles it.
2571 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * gdcm/Doc many doxygen changes:
2573 - Doxyfile now has two different versions, DoxyfileUsers that generates
2574 the html.users end users oriented documentation and
2575 DoxyfileDeveloppers that generates the html.developper developper
2576 oriented documentation.
2577 - README changed accordingly
2578 - requirement.txt removed (old design info moved to TODO).
2579 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2580 DoxyMainPage.txt, DoxyPython.txt provide more information.
2581 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2582 be updated by simply regenerating the docs with doxygen and copying
2583 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2584 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2585 all the tests in the form "if (<map>.count() >1)" were removed.
2586 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2587 ill-formed documentation sections.
2588 * src/gdcmHeader.cxx: ditto
2590 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * setup.py fixed for un*x (needed macro for stdint.h)
2592 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2593 un*ces with sh-utils test utility.
2594 * gdcmPython/demo/test.py renamed to PrintHeader.py
2595 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2596 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2597 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2598 * src/gdcm*.cxx JPR's bad inclusion fixed.
2600 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2602 * gdcmPython/demo/test.py changed accordingly.
2604 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * gdcmPython/Makefile.am fixed linking against libstdc++
2606 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2607 * Swig subdir (historical tests of swig version 1.3.17++) removed
2608 * Test/testChangeEntete.cxx some lines commented out in order to make
2610 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2611 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2613 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2615 hence the user doesn't need this explicit call.
2616 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2617 i.e. LoadElements() call removed.
2618 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2619 - src/Makefile.am declares the proper flag for g++.
2620 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2621 for adding user defined new tags.
2622 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2623 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2624 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2626 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2627 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2628 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2629 src/Makefile.am : the project should properly compile and install
2630 with the autotools, included the python wrappers part.
2631 * gdcm.spec.in : added a spec file for RPM packaging.
2633 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2634 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2636 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2638 to exported to the environement (see gdcmPython/testSuite.py
2640 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2641 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2642 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2643 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2644 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2646 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * gdcmPython/__init__.py doesn't crash anymore when running in
2648 in InstallMode or PreInstallMode but with an environement given
2649 value of GDCM_DICT_PATH.
2650 * src/gdcmDictSet.[cxx/h] coding style.
2652 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2654 * src/gdcm.h general comments moved to TODO, and README
2655 * src/gdcm.h should now be seen as a user commodity (including it
2656 should suffice to fully use gdcm). It is nowhere including within
2657 any of the kernel files src/*.cxx and src/*.h.
2659 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2661 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2663 * src/gdcm*.cxx only include their corresponding include file
2664 (as opposed to gdcm.h)
2665 * gdcmPython/gdcm.i changed accordingly
2666 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2667 the autogen.sh generated "make snapshot" command to work.
2668 * autogen.sh removed history related references to crea package.
2670 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * distutilsSwigCPlusPlus.py work around some swig portability
2674 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2676 was done in a last ditch attempt to get setup.py _really_
2677 operationnal. The python/gdcmPython layaout add the advantage
2678 of hidding away the python related distutils specific files
2679 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2680 Alas, the src directory was out of scope (i.e. it's relative
2681 position to setup.py was ../src) which made things impossible to
2682 handle (see previous version of python/setup.py). Crossing fingers...
2684 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * python/setup.py now works on Un*x. (harder than I thougth)
2686 * python/distutilsSwigCPlusPlus.py can now have include files
2687 among the list of sources.
2689 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2690 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2691 * modifications in MSVC projects
2693 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2694 * As stated by the first lines of Test/ExceptionAndPython/README, it
2695 looks like we can move back to original usage of exception within
2696 src/gdcm* and hence remove the errno stuff that was introduced
2697 as a quick and dirty fixture of this problem (added to the TODO).
2698 * Doc/Doxyfile configuration file for Doxygen and corresponding
2699 README file for usage added.
2700 * Test/testWrite.cxx added. This new test comes from a split of
2701 test.cxx that is now reverted to its original purpous i.e.
2702 testing the proper parsing of a Dicom related file.
2703 testWrite.cxx concentrates on testing the IO part of gdcm.
2704 * Test/bug1.cxx (containing a bug on WIn32) added.
2705 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2706 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2707 whose purpose is to publish the content of the TagNames of the
2708 Dicom public dictionnary were not accessible without an
2709 instance of class gdcmHeader.
2710 - those methods are now static methods of gdcmDictSet and hence
2711 require no instances at all to be invocated.
2712 - within gdcmDictSet this change required to change some method
2713 to class methods (i.e. are now static) among which SetDictPath
2714 (renamed to BuildDictPath) and LoadDefaultPubDict.
2715 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2716 the above changes by calling the new method classes of gdcmDictSet.
2717 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2718 the above to be effective.
2719 * python/gdcmPython: in order to wrap properly the above changes
2720 for Python, swig version now needs to be > 1.3.17.
2721 * python/gdcmPython/Makefile fixed to adapt itself to new
2722 configure/make shema introduced by Johan Montagnat (thanks for the
2723 contribution). Alas this Makefile cannot be turned into a proper
2724 Makefile.am without some heavy changes in the configure.in
2725 (for python dectection).
2726 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2727 now avoids publishing the empty entries.
2729 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2730 * python/setup.py : bug fix concerning install under windows
2731 ExtraPath reused :-P
2732 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2734 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2735 * Dicts/dicomV3.dic : remove double spaces !!!
2736 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2737 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2740 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2742 method. Doxygenation.
2743 * src/gdcm.h clean up of JPR spurious comments.
2745 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * python/distutilsSwigCPlusPlus.py now properly collects the
2747 shadow classes generated by "swig -c++" (gdcm.py in our case)
2748 when using "python setup.py install".
2749 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2750 reexports the working classes.
2751 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2752 by the classical C errno scheme. This is to prevent an obscure
2753 behavior of the python wrappers when importing wxPython.wx prior
2754 to gdcmPython (which ended up in an abort call). An illustration
2755 of this oddity can be found in the Test/ExceptionAndPython
2756 subdir (see the README file). This problem probably due to
2757 an combination of g++ and dynamic loading.
2758 * added Test/ExceptionAndPython (see above)
2760 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * Changed the layout of the python part to avoid bloating main
2762 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2763 i.e. the distutils arsenal. All the python related stuff is
2764 again in a python subdir, but the package itself is now in
2766 * setup.py was cleaned up:
2767 - pythonIncludePath removed
2768 - python setup.py bdist target is now functional.
2769 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2770 collision with other packages). gdcmPython/demo/*.py changed
2773 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * python subdir moved to gdcmPython (preparation of distutils packaging).
2775 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2776 distutils installer is operational.
2777 * - gdcmPython/__init__.py now properly loads the swig generated
2778 shadow classes (from gdcm.py).
2779 - gdcmPython/demo/*.py changed to import the package gdcmPython
2780 instead of gdcmPython/demo/load.py.
2781 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2783 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2785 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2786 entries within the associated public Dicom dictionary resp. the same
2787 information but sorted by the fourth field (PAT, IMG, DIR) of the
2789 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2790 are now in the "???" group.
2791 - python/gdcm.i changed accordingly,
2792 - python/demo/printGroupedPublicDict.py added, that gives an example
2793 of the above new functionalities in Python.
2795 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * src/gdcm.h, gdcmHeader.cxx:
2797 - historic references to glib's g_malloc and g_free (#defined)
2798 were definitively removed.
2799 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2800 * src/gdcmElValSet.cxx:
2801 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2802 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2803 - GetElValue(string) renamed to GetElValueByName.
2804 - Added GetElementByName(string).
2805 * src/gdcmHeader.cxx: added
2806 - GetPubElValRepByNumber(guint16, guint16)
2807 - GetPubElValRepByName(string)
2808 - GetShaElValRepByNumber(guint16, guint16)
2809 - GetShaElValRepByName(string)
2810 - GetShaElValByNumber(guint16, guint16)
2811 - GetShaElValRepByName(string)
2812 - GetElValRepByNumber(guint16, guint16)
2813 - GetElValRepByName(string)
2814 - GetElValByNumber(guint16, guint16)
2815 - GetElValRepByName(string)
2816 * Doc/requirements.txt added.
2818 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * Test/Makefile building now depends on the one of libgdcm.so
2820 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2821 pixel data) aware which enables finding the address (offset) of
2822 the pixel data of JPEG encoded DICOM files. This leaves only a single
2823 file in the testSuite whose pixel data address (offset) is unknown.
2824 * python/testSuite.py changed accordingly.
2826 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2827 * VC++ has some strong limitations when working with the STL, as stated
2828 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2829 "Also note that some STL containers (map, set, queue, list, deque)
2830 cannot be exported. [...]
2831 Some STL classes contain nested classes. These classes can not
2833 This is caused by a designed limitation that once a template
2834 class is instantiated, it can not be re-instantiated and
2836 Since our usage of map<> is ubiquitous in gdcm, this "designed
2837 limitation" of VC++ is a pitfall.
2838 Hence the Python wrappers of gdcm cannot be incrementally linked
2839 against the c++ dynamic library. The dirty but only workaround is
2840 to forget about incremental link of dynamic libraries and to generate
2841 the Python wrappers library with the inclusions of the underlying C++
2843 The following modifications concern this matter on Win32/VC++:
2844 - wrapping python correct with standalone wrapped dll (don't use separate
2845 dll under windows !!!!)
2846 - python21_d debug mode enabled (ask Frog how to use it :-)
2847 - NO problem with having an STL member of class for example string in C++
2848 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2849 - Python test of dcmlib in Python is ok under windows on a large set
2851 * removed glib references
2852 * typedef's inserted in gdcm.i for correct swig type management
2854 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * python/demo/*.py load.py extracted from test.py. Added explore.py
2856 that only displays required tags and testAll.py that parses all
2857 the files of the testsuite without using unittest.
2858 * python/testSuite.py other additional test on new files added.
2859 * Data/* new test files added accordingly to the testSuite.
2860 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2861 the vr in the file differs from the one of the dictionary.
2863 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2865 values, but limits itself to values which are below a user specified
2866 size (by default 1024 bytes).
2867 * python/gdcm.i : elements not loaded (because their size is above the
2868 user specified treshold) are exported with their TagKey as key of the
2869 python dictionary. This enables the testsuite to make some checks
2870 on the unloaded elements (since we have their offset and size).
2871 * python/testSuite.py
2872 - now tests for the existence and proper value of the pixel data
2873 - two new examples added.
2874 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2876 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2877 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2878 aware. See the strategy comments in gdcmHeader::FindeLength().
2879 * Test/test.cxx now accepts a filename as first argument.
2880 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2881 * python/testSuite.py changed to integrate test on above files.
2883 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2885 the vr was also RET.
2886 * python/testSuite.py more tests added.
2888 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * python/testSuite.py unittest test suite added (uses Data)
2890 * Data/* dcm and acr files for the test suite.
2891 * glib dependance removed from un*x version. We now use ISO C99
2892 7.18 Integer types (see stdint.h)
2893 - python/Makefile, src/Makefile src/gdcm.h
2894 * src/ when an explicit vr (like dicom files) suddenly poped an
2895 implicit element we use to mark the underlying DictEntry of the
2896 concerned ElValue with "Implicit". This strategy was damageable
2897 too the public or provite dictionaries, since some of their vr
2898 would be changed. Since Header::FindLength heavily relies on the
2899 detection by Header::FindVR of falsely explicit elements, I
2900 added an extra ImplicitVr member to ElValue (boolean).
2901 The rest of the changes we the necessary adaptations.
2903 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2906 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2908 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2909 * Adaptation for porting to VC++:
2911 o forced to use std namespace (for string to be known)
2912 o all class use __declspec export style on WIN32
2913 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2914 (in stdlib.h on Win32 but in std:: for gcc)
2915 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2916 variable GDCM_DICT_PATH.
2917 * src/gdcmHeader.cxx verbose comments made discrete.
2919 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * python/gdcm.i: added a typemap that converts a C++ hashing table
2921 to native Python dictionary.
2922 * python/demo/test.py:
2923 - now uses the native dictionary for exploration of gdcmHeader.
2924 - takes an optional filename argument (the file to parse).
2925 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2926 PubElVals hashing table.
2927 * Dicts/dicomV3.dic removed error prone trailing spaces.
2929 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2930 * Python wrapping process moved away from src/Makefile to
2931 newly created python/Makefile (as well as gdcm.i)
2932 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2933 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2934 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2935 from the environement variable GDCM_DICT_PATH (when existing).
2936 * src/gdcmDict::GetTag bug fix.
2938 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2939 * Straightforward temporary fixes for swig to build the python wrappers.
2940 src/Makefile now has a python working entry [by working we mean
2941 that we can import de shadow classes without errors].
2943 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * hashtest.cxx removed (since allready in Test)
2945 * src/gdcmlib.h renamed to src/gdcm.h
2946 * src/dcm.i renamed to src/gdcm.i
2947 * src/Makefile prepared for python wrapping
2949 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * src/gdcmHeader.cxx :
2951 - Parsing of header is now separated from loading of element values
2952 (see gdcmHeader::LoadElements).
2953 - general clean up of hopefully all file access (creation of
2954 ReadInt16 and ReadInt32)
2956 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2957 * src/gdcmHeader.cxx :
2958 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2960 - SetLgrElem renamed to SetLength
2961 - GetLgrElem renamed to GetLength
2962 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2963 * src/gdcmElValSet.cxx fixed both GetElValue methods
2964 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2965 due to IdoDude was cleaned out.
2967 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2969 concentrates on finding the value representation (when it exists).
2970 RecupLgr now only finds the element value length, and it avoids
2971 returning the unecessary skL (skipped length).
2972 Also, offsetCourant was simply removed (with taille_fich) since
2973 it was redundant with the File position internals (by using
2974 ftell and fseek). This also made skL (see above in RecupLgr) usage
2976 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2977 on the libido specificities which are handled through class
2979 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2982 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2983 * Truckload of changes. Parsing of header is barely functional
2984 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2986 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2987 * src/gdcmHeader.cxx many addons of low level methods
2989 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2990 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2991 and _IdDcmSWAP_LONG.
2993 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * This corresponds to all the changes decided at the meeting of
2995 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob