1 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * dicomV3.dic is deprecated in favor of gdcm.dic
3 There is now a dictionary per family:
4 - dicomV3.dic -> DICOM V3
5 - Papyrus.dic -> Papyrus
6 - NIH.dic -> tas that were never allowed in the main standart
8 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
10 lantency with the Util::Format function
12 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Adding users file in CVSROOT for mail blaming
15 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
16 * Adding potential support for JPEG-LS DICOM files.
18 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * Adding potential support for mpeg and jpeg2000 through two new lin
21 - libmpeg2 from the MPEG consortium
22 Also adding intial work to use this lib.
24 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
28 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
29 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
30 But this is a case where we should really signify the user there is
31 few chance the serie is really a serie...
33 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * FIX : on X, the python part is correctly installed. All files are
35 installed in gdcm sub-directory
37 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * Builder/ : add something to facilitate the RPM creation of gdcm
40 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
43 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
45 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
48 * Fix compilation on gcc 2.96 (which does not have ios::failure)
50 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
52 and it's representation name (for the NIH)
54 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
56 conversion of YBR to RGB pixels. So, now, the conversion is made using
59 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
61 format) to replace 'at-run' dicom files generated by the
62 TestAllReadCompareDicom test
64 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
67 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
70 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * Testing/TestMAkeIcon.cxx : complete the test
73 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
76 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
80 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
83 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * Test/ : accelerate tests (it's not very significant accelerations).
85 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
87 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * Testing/TestSequence.cxx : add test for sequences of images... test that
89 we have the same serie or the same study UID
91 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
94 * src/gdcmDict.h : remove commented code
95 * src/gdcmDocument.cxx : initialize values
96 * src/gdcmFile.cxx : bug fix when reading values
97 * gdcmPython/demo/ : change file names. Remove useless files
99 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmFile.cxx : remove the default array of initialization.
101 The static array contained pointers to non-static values (comming from
102 strings). To have coherences, when creating files, these values can't be
103 static. So, the array can't be static, too ! To simplify, the array have
104 been replaced by repeted lines to insert values in the File
106 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
108 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
110 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
112 (Dicom Element) into the Sequence Item
114 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/*.cxx : first parss to normalize file organisation
117 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmDirList.[h|cxx] : add method to find a directory
119 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
121 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Finish cleaning up my JPEG mess. Should be ok now.
123 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
124 contained within the RLE* class(doh!)
126 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
127 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
128 * SerieHeader::AddFileName() creates as many Coherent Files lists
129 (same Serie UID) as it founds different Serie UID
130 amongst the files instead of discarting any file
131 that doesn't match with the first one he found.
132 * SerieHeader::OrderGdcmFileList has now one parameter :
133 the Coherent Files list the user wants to sort
134 * SerieHeader::GetFirstCoherentFileList() |
135 * SerieHeader::GetLastCoherentFileList() | allow to parse
136 the set of Coherent Files lists
137 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
138 compatibility (it returns the *first* Coherent Files list,
139 since there was only one before)
140 * Test/TestSerieHeader gets gdcmData as a default root directory
142 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * Remove friend between DocEntry and File classes
144 * Remove friend between PixelReadConverter and RLEFramesInfo,
147 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
149 0002|0000. The value was incorrect.
151 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
154 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmUtil.cxx : compilation fix on Win32
156 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
157 variable, to be easy found. Add methods to change the default UID.
158 Amelioration of the CreateUniqueUID to use the correct default UID.
159 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
162 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * Test/TestVR.cxx : fix memory leaks
165 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
166 * Rewrite the base 256 to base 10 conversion, using string operation only.
167 This allows us to get rid of the problematic 64bits integer type (does not
168 always exist on target platform).
170 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 * Add construct and destructor to class gdcm::Debug to close the debug file
173 * Don't let uset to open twice the same file
174 * gdcm has now an official UID prefix,
175 supplied by http://www.medicalconnections.co.uk
176 1.2.826.0.1.3680043.2.1143
177 (Thx to Mathieu for providing URL)
178 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
179 to be able to perform some more tests
180 * gdcm::ContentEntry : Contructors and Destructor are now protected,
181 in order to be sure no user will try to use them.
182 (at user level, only the children classes are meaningfull)
184 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * move RLEInfo & JPEGInfo from Document to File
187 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * FIX : remove so many friend between classes
190 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
192 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
194 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 In order to avoid missbehaviour :
196 . gdcm::DocEntry is now specialized in
197 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
198 - gdcm::ContentEntry (Dicom entry with a 'content')
199 . gdcm::ContentEntry is specialized in
200 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
201 characters value, or integers)
202 - gdcm::BinEntry (Dicom entry with a non strig representable value
203 (user hasn't any longer to thing about the precedence of his dynamic_casts)
205 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * Test/VTKTest*.cxx : bug fix under linux
208 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
210 use with python. Some methods are moved from Document to ElementSet or
211 DocEntrySet. The equivalent methods to ElementSet have been added to
212 SQItem and are virtual in DocEntrySet. Methods that may have the same code
213 in SQItem and ElementSet is directly placed in DocEntrySet
215 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * Test/VTKTest*.cxx : remove the show variable in each test method because
217 it's useless (the viewer variable replace this variable)
219 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDocument.cxx : bug fix on potential memory leak
221 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
222 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
223 Add ClearXxx methods to remove all the content of the list or map
224 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
226 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
227 * methods ReplaceOrCreate renamed as Insert
228 (nobody will be any longer confused by 'CreateOrReplace')
230 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Grealty simplify the JPEg decompression, no need to differenciate based on
232 the JPEG possible type (with/without fragment, with/without multiple frame).
233 Everything is done throught the JPEG IO Suspension mechanism in IJG
235 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
236 * Stage 3 of normalization :
237 in order to avoid any missunderstanding while reading method names :
238 - All the methods xxxEntry now deal with dicom Entries
239 - Methods GetEntry splitted into
242 - Method SetEntry renamed as SetEntryValue
243 - Method SetEntryBinArea let as it was
245 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
246 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
247 - Position correctly the entry points for JPEG2000 and JPEG-LS
248 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
250 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
252 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
253 with other method names
254 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
255 * Test/TestDicomDirElement.cxx : add new test
257 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
259 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
260 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
261 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
262 So can't you use __int64 in ostream at all.
264 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * bug fix for compilation on MSVC6
266 * gdcmPython/gdcm.i : rename of classes missed
268 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
269 * Stage 2 of names normalization :
270 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
271 (easy to understand ...)
272 - gdcm::FileHelper replaces old class gdcm::File
274 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
276 type and not a string. So, there remove problems on the format of the
279 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
280 * Add Example/TestPapyrus.cxx
281 - reads a Papyrus file (gdcm::Header compliant),
282 - gets the pixels of all the images, using low level iterators
283 - writes an multiframes Dicom image.
284 (Just to show it's *possible* to do that)
285 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
288 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
290 Thus, DicomDirXXX are created with a flad that indicates if the created
291 object is empty or not (when not empty, the DicomDirElement is used to
294 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
296 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
298 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
301 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
303 Remove all access to the hash-tables or lists in the objects.
305 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
307 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
308 be complient with all the gdcm source code
310 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
314 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
318 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * Test/ : rename VTK tests to have a best name for the tests
320 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
321 GetFirstEntry/GetNextEntry use
323 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
324 * In SerieHeader::ImagePositionPatientOrdering()
325 // a Dicom 'Serie' may contain scout views
326 // and images may have differents directions.
327 // -> More than one may have the same 'pos'
328 // Sorting has then NO meaning !
329 Thx to Eduardo Davila for reporting bug.
331 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
333 test. Now it's on image content and not on the resulting visualisation...
334 might solve the problem on linux when using the OpenGL drivers
336 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
337 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
338 DicomDirSerie, DicomDirImage
339 Dict, DictSet classes :
340 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
341 -remove InitTraversal method.
342 * UPD Test programs + Example programs
344 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
345 * remove useless and never updated keyword \ingroup
346 * Solve pb when structure (list, map, ...) is empty.
347 Thx to Benoit for reporting bug
349 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
350 * Taking into account of 'Transfer Syntax' value
351 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
354 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
356 is no memory access violation
357 * gdcmPython/demo : add python demos using VTK
359 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
360 * FIX 'Dictionnary' is now spelt 'Dictionary'
361 'wether' is now spelt 'whether'
362 'archieve' is now spelt 'archive' ;-)
364 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
365 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
366 related methods, in order not to expose internal mechanisms
369 * REM methods that exposed internal mechanisms :
370 DicomDir::GetDicomDirPatients()
371 DicomDirPatient::GetDicomDirStudies()
372 DicomDirStudy::GetDicomDirSeries()
373 DicomDirSerie::GetDicomDirImages()
374 * UPD Test programs :
378 * UPD Example program
380 * ADD DictSet methods
384 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * Removed the Print/indent/default parameter mess. There is absolutely no
386 reason to have to methods, moreover with the second taking the ostream as
387 *SECOND* parameter. This was clearly a bad hack to get things compile.
389 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
390 * Complete rewrite of the GetMacAddress code. Now the code is *much*
391 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
392 Unfortunately the main code does not work on SunOS, thus provide a specific
393 code for this platform only (and Win32 of course). Since this seems to be
394 working, change CreateUniqueUID to use GetMACAddress instead of the
395 problematic GctestetIPAddress
397 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
398 * Unfortunately to be able to test gdcmDirList I had to break the API
399 a little. Now the class is not a std::list anymore but has a member
400 std::vector (more ITK compatible). Allow unit testing on Win32 and
403 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
404 * Update SerieHeader to take into account a Serie Instance UID to properly
407 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
408 * ENH - Comment out Mathieu's (dangerous) Super Hack
409 for dealing with BIGENDIAN processors
410 - Move equivalent stuff to BinEntry::WriteContent
411 When necessary, 16 Bits Pixels are swapped in a small buffer
412 and then written. This avoid allocating a huge buffer, in
413 PixelWriteConvertor, and avoid modifying the Pixel Area.
415 Probabely, the same operation will have to be done when we want
416 to write image with Big Endian Transfert Syntax,
417 and we are working on Little Endian Processor
419 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
422 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
423 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
424 all the dict content.
425 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
427 * Test/TestDict.cxx : add a new test for the dict classes
429 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
431 file. Debug is yanked if compiled with NDEBUG
433 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmDictSet.h : set the default output to the os variable
435 * src/gdcmDictEntry.[h|cxx] : add the Print method
436 * gdcmPython/demo/ : add a new test
438 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
439 * merging of Test/PrintDicomDir and Test/TestDicomDir
440 * removal of now redundant Test/PrintDicomDir
441 * enhancement of Example/PrintDicomDir
443 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * Now, python test might work on systems
445 * Add the PrintDicomDir test
447 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
448 * FIX : First entry following group 0002 was lost for
449 Explicit Big Endian Transfer Syntax files
450 (group and elem not swaped)
452 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
453 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
454 Big Endian Transfer Syntax supposed the group following 0002
455 begins always by element 0000 (element 0000 is *optional*)
456 To avoid further troubles, let's be pessimistic, and use
457 Document::HandleOutOfGroup0002() method
458 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
459 (related pb not yet solved)
461 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * Bug fix for the python part use
463 * Now, PrintHeader.py pass... but outside the ctest use. shit !
465 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
468 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
469 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
470 a string and should ask the global TS dict what are the propreties of
473 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
474 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
475 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
476 to swap the Swap Code, at parsing time, when we come out of group 0002
477 and Transfer Syntax is Big Endian
478 We should be able to read now 'true DICOM" Big Endian coded images
479 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
480 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
482 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Hopefully fix the bug on MacOSX and static global initialization.
484 This is the only -minor- patch I found that both please MacOSX and VS6.
485 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
486 but this would require a lot of change. Another approach would be that Global
487 create those string and GDCM_UNFOUND becomes a pointer to a string (which
488 gdcm::Global would destroy at exit).
490 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Fix bug on MacOSX with static initialization in a multy threaded
492 environment. static const string in a header file used to be ill
493 initialized provoquing the freeze of any tests. patch should solve this
496 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
497 * According to Benoit's suggestion, and without any objection from anybody
498 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
499 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
500 - method gdcmDicomDirObject::GetEntry() renamed as
501 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
503 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
504 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
505 you debug/warning message just as c++ streams which make them very convinient
506 to use. Once this is stabilize I will change the ostringstrem to be
507 redirected to a file (ofstream).
508 * Properly support C99 extension: __FUNCTION__ which allow us to display
509 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
511 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
512 * Removal of useless and dangerous methods :
513 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
514 GetDocEntryByName, GetEntryByName, GetDictEntryByName
515 * Removal of usless methods :
516 Dict::PrintByName, Dict::GetDictEntryByName
517 * Commenting out of probabely useless methods :
518 Dict::GetDictEntryNames()
519 Dict::GetDictEntryNamesByCategory()
520 DictSet::GetPubDictEntryNames()
521 DictSet::GetPubDictEntryNamesByCategory()
522 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
523 * ENH : Use dicomTS.dic as described in 2004 version
524 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
525 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
526 Add Accessors on VM (Value Multiplicity), and VM related methods
527 * ADD : Add a list of 'Dicom Attribute types', as found in
528 http://medical.nema.org/dicom/2004/04_15PU.PDF
530 * ADD : Add dicomGroupNameAbbreviations.dic
531 should be used to write a method to replace the former
532 Dict::GetDictEntryNamesByCategory()
534 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
535 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
536 to read in the file... and only it ! Length is the efective length of the
537 data in the DocEntry structure
539 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
540 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
541 And now use a static function call instead, with a global variable. i
542 This is much closer to the VTK approach. Hopefully should be bulletproof
543 and easier to use...hopefully
545 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
546 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
548 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
551 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
553 ValEntry, BinEntry, SeqEntry creation or replace
555 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
556 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
557 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
559 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
560 when specifying the VR
561 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
562 * src/gdcmDocEntry.cxx : amelioration of print
564 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
565 * ADD : Add the method Util::IsCurrentProcessorBigEndian
566 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
567 * ADD Method Document::ComputeGroupLength
568 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
569 in order to allow further VR modification by user
570 * REM : removal of once-called method File::WriteBase
571 integration of its code in formerly one-line method File::Write
573 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
575 replace the different values "??", "Unkn", "Unknown".
576 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
577 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
578 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
579 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
581 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
582 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
584 * Set the gdcm::Base class to some Printable classes
586 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * src/gdcmFile.[h|cxx] : add the Print method
588 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
589 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
590 * src/gdcmDocument.h : remove the PrintLevel informations
591 * Example/PrintFile.cxx : use the new gdcm::File::Print
593 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
595 problems when compiling with the python wrapping
597 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
599 writting in ImplicitVR
601 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
602 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
603 JPEG decompression, especially when dicom frames are split into several
604 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
605 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
607 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmHeader.cxx : change the initialisation of default header.
609 Now, this header is readable by gdm, e-film, DicomWorks
611 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
613 Rename Decompressed to Raw
614 * Use the API changes in gdcm::File.
615 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
618 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
619 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
620 each added entry in the header. Replace the 'Planes' field by the 'Number
623 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
624 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
625 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
627 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
629 At this time, this image isn't readable by e-film... waiting JPR help to
632 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
634 DocEntry. Now use methods of the Document !
636 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * Test/ShowDicomSeq.cxx : bug fix
639 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
641 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
642 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
643 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
645 * Test/TestCopyRescaleDicom.cxx : remove unused variable
646 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
647 containing found sequences
649 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
652 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
653 Some fields in BinEntry must be copied to not seg fault when making the :
654 gdcm::File *copy = new gdcm::File( copyH );
655 and tests are now made on good variables
657 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
659 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
661 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
662 * Add vtkGdcmWriter example and test
664 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * Test/TestUtil.cxx : reformat the source code
666 * vtk/vtkGdcmReader.cxx : remove and change prints
667 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
669 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
670 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
672 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
674 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
676 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
678 by an eof to prevent all bad read of the file... and in this case, the
681 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Example/Volume2Dicom.cxx : comment unused variables
683 * Test/PrintDicomDir.cxx : comment unused variables
684 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
685 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
686 method that is redondant with AddEntry.
687 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
690 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Bug fix due my last commit (compilation under Windows).
692 * Example/Volume2Dicom : bug fix in the file and reformatting source code
693 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
695 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
697 - Remove printf / sprintf
698 - include iostream AFTER gdcm so we don't get warnings
699 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
701 - Also remove tons of include from header files, hopefully this should
702 speeup the compilation time, since it was becoming a dog slow.
703 - Remove gdcm.h as it include way too many files and slow down compilation
704 (plus it is not up to date)
705 - remove 'using namespace std' this is BAD !
707 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * Remove memory leaks on the DicomDir
709 * Remove some useless data in DicomDirObject
710 * Add usefull methods in SQItem, to be complient withe the ElementSet
712 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
715 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
717 future, with convertion)
718 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
719 and ImageDataSize values. Remove the method to get the PixelReadConverter
720 from the output of the class
722 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
725 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
727 and vtkErrorMacro use.
728 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
730 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
731 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
733 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
734 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
735 The string leaves only in the fonction. So when we make a .c_str(), we
736 get the pointeur on the first element, element that will be destroyed
737 immediately after thee instruction.
738 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
739 file has been opened : the test must be made on the content of the
740 pointer and not directly on the pointer !
743 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
745 the python part recompiles
747 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
748 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
749 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
750 X session is killed (for my computer... it seems to not be identic on
753 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
755 avoid problems (otherwise, the difference test between the visible image
756 and the reference is incorrect. If the reference is greater than the
757 screen resolution, it's produce errors).
758 Can be used for only one image. Can be used with a visible flag.
759 * vtk/vtkGdcmReader.cxx : remove commented codes.
760 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
761 under windows at compilation
762 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
764 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
766 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
767 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
768 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
769 tests on the image size X, Y, Z
771 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
772 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
773 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
774 between the class name and the file name
776 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/ : fix compilation warnings for the Write method (2 different
778 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
779 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
780 variable... create a static method in gdcm::Document to access to
781 this variable content.
783 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
784 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
785 file, to be accessed by other files (like gdcmFile). Remove commented
786 code. Move the change of the header to the gdcmFile, using the
788 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
789 To be sure of that (and simplify calls), the Write of the header now
790 gets a file name and not a file pointer (std::ifstream).
791 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
792 DocEntryArchive. Remove all open of the written file
794 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
795 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
797 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
798 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
799 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
801 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
802 some corresponding methods. Write correctly the file and check before
804 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
805 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
806 is now on RGB data (as before my last commit
807 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
809 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
811 Add a print information of the type of the entry
812 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
813 It was in the gdcmFile, and all write have been regrouped
814 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
815 Write correctly all dicom files (in decompressed mode only at this time)
816 * Test/ : test on files are now made using Raw data and not color data if
818 * Example/PrintFile.cxx : add more printings
820 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * Amelioration of code, remove some code copy. For the loading of
822 BinEntry (in gdcmDocument), add the test to verify if the file is already
825 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
827 remove a DocEntry in the header (push an empty DocEntry)
828 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
829 lines. Bug fix in the initialization of the PixelConvert and the
831 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
832 use in TestCopyDicom (now this test can run under windows... but fails)
833 * Test/TestCopyDicom.cxx : amelioration of the test :
834 - test the pixels written
835 - add test points to quickly find where is the error
836 - can set a file name input and output in arguments
837 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
838 amelioration of the test output
840 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
842 all replaced DocEntry's
843 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
844 Now, each needed DocEntry to modify is duplicated, modified and inserted
845 to the header using DocEntryArchive. Thus, after save, we can restore the
846 header initial state.
848 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
849 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
851 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
853 correct to copy it. The DictEntry is specified at the DocEntry creation,
854 then, it musn't change in the time.
855 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
856 header correctly. At this time, the change is only made for the first
857 level of the Document. In the future, it might consider sequences.
858 The change is made by replacing a DocEntry by an other that is created
859 outside the class. The old value is kept. When we restore the header
860 status, the added DocEntry is deleted and replaced by the old value.
861 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
862 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
863 set the write type to explicit VR, implicit VR or ACR. Add methods to set
864 the write mode to native, decompressed or RGB (but not used at this time)
866 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
867 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
868 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
870 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
871 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
872 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
874 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
875 set because already copied when copying the BinEntry's of the header
876 * Test/TestAllReadCompareDicom.cxx : remove warnings
878 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
879 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
880 Two problems appear when doing it :
881 - with the gdcmFile : when the GetImageData method is called, the pixels
882 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
883 data (pixels). And each structure destruct the data when it's
884 destructed. So we have two destructions for the same data. To solve it,
885 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
886 data or not. If it doesn't own data, then they will not destroyed by
888 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
889 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
890 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
891 create a double destruction of the same DocEntry's. So, to solve it,
892 the TagHT is simply cleared and the DicomDir* elements are destroyed.
893 * TODO : add an entry concerning memory leaks in the DicomDir
895 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
896 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
897 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
900 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
901 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
902 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
903 after it have been deleted
905 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * FIX: src/* fix the doxygen warnings.
907 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
908 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
909 was erroneously defined with a size of 15 instead of 16. [many thanks
910 to Jean Michel Rouet for pointing out this bug].
912 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 1. Finish merging JMR patch for writting DICOM from scratch
914 2. Fix -hopefully- bug with MONOCHROME and space vs null character
915 3. Use const ref when possible
916 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
917 5. A few more comments
918 6. CreateUniqueUID can now be called without parameter"
920 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
921 * ENH: Slightly bigger patch:
922 1. Getting toward full integration of JMR patch for writting dicom from scratch
923 2. Update Test to test part of this patch: CreateUniqueUID
924 3. File was not close properly in gdcmDict
925 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
926 5. Use of const ref instead of copy (speed issue)
927 6. Remove temporary (duplicate) string in TranslateToKey
928 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
929 8. Do not repeat virtual in subclasses
930 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
932 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
933 * Apply first patch toward better string comparison when dealing with broken
934 DICOM files. Essentially the string could be padded with a space instead
935 of a null character as defined by standard
937 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
938 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
939 because never used... and in the same time, that's remove some memory leaks
941 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
942 * src/gdcmFile.cxx : now delete the PixelConvert instance.
943 * In examples and tests : change the type of image data variables from void*
944 to uint8_t*. Remmove all delete on image data variables
946 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
947 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
948 Verify the file pointer value before open the file, and if it's not null,
949 a verbose message is generated.
950 Close correctly the file when the file isn't considered dicom-like. The
951 correctly close is a call to CloseFile.
952 When closing the file pointer, test if its not null to close the file.
953 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
954 file. For an uncompressed image, the copied data correspond in the least
955 case to the image size (calculated) or the image size specified in the
956 header. A verbose is generated if these two size mismatch
958 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
959 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
960 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
961 break under windows (with msvc6 compilation).
963 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
964 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
965 compiling with MSVC6)
967 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
968 * Bugs fix for the Windows build with VC6
969 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
970 needed (only for projects required VTK). If the VTK is included in all
971 projects, there is conflicts with the jpeg lib of vtk when compiling the
972 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
973 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
974 when compiling the gdcm_wrap.cxx file (created by the compilation of the
976 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
977 (like it's already made for the cout use). Otherwise, conflict with the
980 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
983 - comments on the DicomDir::Method related usage added.
984 - now that we use the namespace gdcm, a lot of internal classes do
985 NOT need to be wrapped anymore.
986 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
987 DicomDir::Method) new example added.
989 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
990 * Improve string manipulation. I now inforce the notion of 'DicomString'
991 A DicomString can contain as many \0 as they want
992 and it is *always* of even length.
993 We only support odd length for very rare case.
994 And in the near future this should be removed.
996 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
997 * /binary_write/ gdcm source. Now even on big endian we are writting
998 little endian. This should -heopfully- fix some tests
1000 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1001 * Now the dictionary is compiled into gdcm lib. This is a default
1002 behavior, thus any dic file specified is picked before failback to
1003 the one comiled into lib
1005 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * Change internals for gdcmDict. Don't use any 'new' any more.
1007 This should definitely solve any leak problem, and we should be
1008 as fast as before, as long as don't modify too much the dictionary.
1010 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1011 * STYLE: ivars should start with a capital letter.
1012 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1013 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1015 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1017 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1018 new 2004 dictionaries added (thanks to JPR).
1019 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1020 * CLEANUP_ROUND (15) for gdcmPixelConvert
1021 - RLEFrame::NumberFragments is now of type unsigned int
1022 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1023 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1026 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1027 * Initial work in gathering all transfer syntax accessors. clearly
1028 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1029 ivars, but only one transfersyntax (class) ivar with equivalent method on
1032 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1034 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1035 discussed (plus I didn't like having a 2000 lines patch not commited)
1037 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1038 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1039 * CLEANUP_ROUND (14) for gdcmPixelConvert
1040 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1041 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1042 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1043 CloseFile() anymore.
1044 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1045 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1046 into File::Pixel_Data.
1048 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1050 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1051 * CLEANUP_ROUND (13) for gdcmPixelConvert
1052 Substituted File::ParsePixelData() with PixelConvert::Print() new
1054 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1055 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1056 method to those classes.
1057 - src/gdcmFile.[cxx|h]:
1058 -- Added a ::Print() method.
1059 -- PixelConverter is now a reference instead of a member.
1060 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1061 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1063 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1065 collaboration diagram and inheritance diagram should be generated with
1067 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1068 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1069 pointlessly wrapped (see
1070 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1071 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1072 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1073 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1074 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1075 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1076 -- File::Initialise: PixelConverter setup moved away to
1077 PixelConverter::GrabInformationsFromHeader()
1078 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1079 interpretation moved away to PixelConverter::BuildRGBImage()
1081 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1082 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1083 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1085 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1087 displayed on Win32 when a brutal abort() occurs (because of uncatched
1088 exception). See TODO new entry of this commit for more on this.
1089 * TODO added new entry.
1090 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1091 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1092 - HandleColor is no longer called from gdcmFile.cxx
1093 - gdcmPixelConvert.cxx clean up on method arguments and internal
1094 variable names for semantical coherence.
1096 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1097 * Finished lossless transition, not only do we now read all lossless jpeg
1098 images, without the need of the Cornwell lib, but we do read them properly now
1099 * To reduce code (well to avoid code duplication), I defined a common place
1100 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1101 redefine symbols. This is not perfect but this the best solution I found for a
1102 compilation time jpeg option.
1104 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1105 * Update jpeg ijg lib to support lossless jpeg implementation
1106 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1108 * Also added a special copyright for dcmtk since we use their bugfixes.
1111 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1113 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1114 matters, as stated in warning note at beginning of %include section).
1115 * src/gdcmDicomDir*.[cxx|h]: coding style
1116 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1117 * src/gdcmJpeg8.cxx: doxygen fix.
1118 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1119 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1120 from File:: to PixelConvert::.
1122 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1124 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1125 - more code moved away from File:: to PixelConvert::
1126 - fat setup of PixelConverter set in place in File::Initialise.
1128 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1129 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1130 namespace at the file system level. So now you should convert your examples
1132 gdcmHeader -> gdcm::Header
1133 It would be nice if people keep in mind to no open the namespace, since it
1134 allows compilation on broken plateform which were defining common symbol in
1135 the standart namespace (like LP, Unknown ...)
1137 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1138 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1139 The JPEG fragments are now parsed at the same stage than the RLE
1140 information. All code related to JPEG is now in gdcmPixelConvert:
1141 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1142 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1143 export a gdcmFile:: method. Those are simply global functions
1144 (for the time being this is better than having them attach to
1145 either gdcmFile:: or gdcmPixelConvert::).
1146 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1147 and stores the result in a gdcmJPEGFragmentsInfo.
1148 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1149 code (among other stuff) moved away from gdcmFile:; to
1152 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1154 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1155 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1156 clean up of RLE related code.
1157 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1158 - src/gdcmRLE.cxx removed
1159 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1160 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1161 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1162 * CLEANUP_ROUND (9) for gdcmPixelConvert
1163 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1164 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1165 away from gdcmFile:: to gdcmPixelConvert::.
1167 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1168 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1169 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1170 This is because Parse7Fe0 used to parse the pixels to compute the
1171 length. This task was passed over to FindDocEntryLengthOB() a long
1172 time ago, EXCEPT I had forgotten the OW case...
1173 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1174 we just recylce the code for parsing RLE fragments and computing
1176 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1177 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1178 with the retired Parse7Fe0().
1179 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1180 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1182 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1183 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1184 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1185 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1186 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1187 * CLEANUP_ROUND (4) for gdcmPixelConvert
1188 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1189 to return an unused length.
1191 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1192 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1193 this should be cleanner from the plane view. The iostream are erally a pain
1194 to use to do simple stuff.
1196 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1197 * Redo the compilation of the ijg jpeg library. Now only one source is
1198 necesseray. No need to rename file by hand what so ever. CMake handle the
1199 copying of the file within different directory, configure header file to
1200 modify some symbol. The only addition made to ijg wasd a mangle table so
1201 that symbol are different whether we are within 8bits or 12bits.
1203 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1204 * Added documentation of vtkgdcmReader on Website:
1205 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1206 with it's binary name).
1207 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1208 the Website to be more complete.
1209 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1210 doxygenated documentation.
1211 - Doc/DoxyVtkGdcmReaderExamples.txt added
1212 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1213 DoxyVtkGdmReaderExamples.html )
1214 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1215 * CLEANUP_ROUND (3) for gdcmPixelConvert
1216 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1218 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * CLEANUP_ROUND (2) for gdcmPixelConvert
1220 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1222 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * CLEANUP_ROUND for gdcmPixelConvert:
1224 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1225 - src/gdcmPixelStuff[h|cxx] removed
1226 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1227 - src/CMakeLists.txt changed accordingly
1228 * GDCMHOME clean up:
1229 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1230 gdcmVersion.py moved to newly created ATTIC related
1231 gdcmPython/SetupOldies/ directory.
1232 * Autotools clean up:
1233 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1234 - autogen.sh configure.in acinclude.m4 python.m4 removed
1236 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1238 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1239 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1241 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * TODO updated with Mathieu suggestions. I proposed a template for
1243 describing TODO entries and used it for new entries.
1244 * Added Doc/Website/CodingStyle.html, Developpers.html,
1245 DeveloppersPython.html, GdcmDataCvs.html and
1246 DownloadVersion0_1.html, DownloadVersion0_3.html.
1247 * Some Doc/*.txt Doxygen files (which do not really concern the
1248 documentation itself, but the website) moved to html and
1249 placed in directory Doc/Website:
1250 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1251 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1252 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1253 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1254 * CMakeLists.txt changed accordingly.
1255 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1256 DeveloppersPython.html
1257 * INSTALL nows refers to Doc/Website/Installation.html
1259 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * Added Doc/Website directory, that contains a first raw version
1263 2004-09-23 Jean-Pierre Roux
1264 * FIX In order not to be poluted any longer by casting problems,
1265 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1266 we can now delete[] it safely
1267 * VoidArea is now called BinArea (less confusing name),
1268 and all the methods called ...VoidArea... are now ... BinArea...
1269 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1271 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1272 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1273 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1274 up to the destructor of gdcmElementSet to clean up TagHt and it's
1277 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1278 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1279 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1281 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1282 * ENH: added some utility method that builds a flat dictionary
1283 holding all the Dicom entries contained in the recursive structure
1284 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1285 an example of usage.
1286 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1287 BuildFlatHashTable() that build a flat dictionary.
1288 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1289 gdcmDocument is now a friend of gdcmElementSet.
1290 - src/gdcmElementSet.cxx: clean up.
1291 - Example/FlatHashTablePrint.cxx added.
1292 - Example/CmakeLists.txt changed accordingly
1294 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1296 moved away from gdcmDocEntrySet (since this class is an abstract class
1297 acting like an interface). SQDepthLevel and BaseTagKey are now
1299 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1300 and associated accessors. Doxygenation of the class.
1301 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1303 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1304 Use SQDepthLevel accessor instead. ::Print() adapted.
1305 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1306 - src/gdcmDocument.cxx changed accordingly.
1308 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1309 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1310 - The following is the doxygen comment of the typedef declaration
1311 of gdcmTagKey in src/gdcmCommon.h:
1312 gdcmTagKey is made to old an "universal" (as in URL, Universal
1313 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1314 A dicom tag always has a group and an element, but a set of tags
1315 embeded in various (optionally nested) sequences and sharing
1316 the same group and element all share the same (group, element)
1317 "identifier". Hence the (group, element) cannot be used as an
1318 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1319 In order to construct a proper tag identifier (i.e. a key) we
1320 consider the following definition of a TagKey:
1321 - let Group, Element be the string representation of the
1322 group and element dicom tag members,
1323 - let ItemNumber be the string representation of the integer
1324 index of the considered item number of a sequence,
1325 Let the key of a tag embeded in a sequence, noted SeqTag, be
1327 /ItemNumber#Group|Element
1328 where "/", "#" and "|" are characters acting as separators.
1329 Then the general form of a gdcmTagKey is given by:
1330 Group|Element<SeqTag>
1331 where <SeqTag> means NO or many instances of SeqTag.
1332 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1335 but the gdcmTagKey of a tag "embeded" is the first item of
1336 a sequence, itself nested in the third item of a sequence is the
1338 0004|1220/2#0008|0082/0#0008|0090
1339 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1340 order to hold the new sequence compatible key. Previously, the
1341 GetKey() method would look in the underlying gdcmDictEntry.
1342 - src/gdcmDocEntry.cxx:
1343 -- constructor now copies the underlying DictEntry key, in the local
1345 -- ::Print: displays the member Key, instead of the (group, element).
1346 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1347 - src/gdcmDocEntrySet.h:xi
1348 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1349 -- now has a new BaseTagKey member.
1351 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1352 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1354 This poses the problem with the semantics of the following lines
1355 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1356 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1357 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1358 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1359 to the long FIXME note for what the problem is. Nevertheless in
1360 order to get things working the dicom dictionary was altered !
1361 Please fix things urgently...
1362 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1363 information), see above note on moving the member VoidArea. Nevertheless
1364 the following entries previously correctly set as US are now inproperly
1366 0028 1201 OW IMG Red Palette Color Lookup Table Data
1367 0028 1202 OW IMG Green Palette Color Lookup Table Data
1368 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1369 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1370 of gdcmDocEntry moved to gdcmSeqEntry.
1371 * src/gdcmSeqEntry.cxx: STYLE.
1373 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1376 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * gdcmPython/testSuite.py: all the test suite in python is now moved
1378 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1379 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1380 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1382 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1384 to avoid inclusion recursion until STL is reached.
1385 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1386 mecanism. errno.h is not included in gdcm anymore.
1387 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1388 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1390 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1391 gdcmData/TestAllEntryVerifyReference.txt
1392 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1393 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1394 exception_on_error parameter.
1395 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1396 - vtk/vtkGdcmReader.cxx changed accordingly,
1397 - Example/*.cxx and Test/*.cxx changed accordingly.
1399 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1400 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1401 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1402 enable_sequences removed from gdcmHeader constructor and dependencies.
1403 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1404 * gdcmPython/demo/PrintHeader.py: dummy fix.
1405 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1406 skip_shadow removed from gdcmHeader constructor and dependencies.
1407 * Example/*.cxx and Test/*.cxx changed accordingly.
1409 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1411 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1413 2004-07-21 Jean-Pierre Roux
1414 * FIX Now, Parsing and Printing a DICOMDIR do work!
1415 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1417 2004-07-20 Jean-Pierre Roux
1418 * FIX Some brain damaged headers have Zero-Lenght fields
1419 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1421 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1422 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1423 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1424 variable (instance of gdcmDebug) by a definition macro, and the instance
1425 is now in static in the gdcmDebug class
1426 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1427 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1429 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * WARNING: ctest now depends more tightly on gdcmData. You should
1431 check out gdcmData properly for things to run smoothly...
1432 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1433 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1434 we need the pixels not be loaded in order to use the ValEntry
1435 that displays position and size).
1436 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1437 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1438 be deprecated. If you have any doubts about the advantages of a
1439 modern scripting language (read Python) versus grass root C++ (i.e.
1440 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1441 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1442 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1443 Anyhow, consider documenting the gdcmData images in
1444 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1446 * Test/CMakeLists.txt:
1447 - now uses TestAllEntryVerify.cxx
1448 - specific comments on oldACR00001.ima (now renamed in gdcmData
1449 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1450 gdcmData/TestAllEntryVerifyReference.txt
1453 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1454 * src/*.[h|cxx] : typedef clean up
1455 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1456 - TagKey renamed to gdcmTagKey (for external usage)
1457 - VRKey renamed to gdcmVRKey (for external usage)
1458 - removal of typedef duplication.
1459 - Removed all unecessary inline keyword from class inline definitions.
1460 - Some method|function(void) declarations replaced with method|function().
1461 * src/jpeg/libijg12/jdhuff12.c:
1462 - printf polluting ctest removed.
1463 - TAB removal for comminting
1465 - TestAllReadCompareDicom.cxx: added a test that compares all the
1466 images in gdcmDataImages.h with corresponding images in
1467 gdcmData/BaselineDicom/. When baseline images are not present
1468 this test creates them.
1469 Note: we need to validate each reference image, but before that
1470 I'd like to rename them with a more explicit name...
1471 - CMakeLists.txt: changed accordingly.
1472 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1473 including each header needed).
1475 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1476 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1477 test suite to the Example directory. Are concerned:
1482 - TestWriteSimple.cxx
1483 * Test/CMakeLists.txt: added some comments on reasons for black listing
1484 image gdcmData/oldACR00001.ima
1486 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * Test/CmakeList.txt: removed the following from black list (to be coherent
1488 with removal from gdcmData):
1489 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1490 - gdcm-MR-PHILIPS-16.dcm
1492 Added the following because after last cvs update, they cause
1493 ctest -R TestReadWriteReadCompare
1495 - gdcm-MR-SIEMENS-16-1.acr
1497 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1498 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1499 new comments in this file) we temporarily (sigh) move to a weaker
1501 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1502 we don't need to black list the following images anymore:
1503 - 8BitsUncompressedColor.dcm
1505 - US-PAL-8-10x-echo.dcm
1506 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1507 fixes and the beautified code ;-)
1508 This fixes the bug introduced in version 1.42 (when beautifying)
1509 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1510 Note: ctest was blind to this bug (this means we need to still
1511 improve the test suite). The bug could be detected by using
1512 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1514 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1515 and by displaying the (garbage) produced file temp.XDCM...
1517 2004-06-29 Jean-Pierre Roux
1518 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1519 - replace by uggly but working old code :-(
1520 A lot of things should be OK again.
1521 It's really urgent to have a test suite that *tests*,
1522 to prevent Frog's beautifying sessions to break all the stuff
1523 (twice, withing a fortnigh ...)
1525 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1526 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1527 redundancy) to added Test/TestReadWriteReadCompare.cxx
1528 * Test/CmakeList.txt: because the compare test of
1529 Test/TestReadWriteReadCompare.cxx fails, the following images are
1530 black listed: - 8BitsUncompressedColor.dcm
1532 - US-PAL-8-10x-echo.dcm
1533 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1534 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1535 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1536 and ad-hoc kludge. This kludge is now removed, and on encountering
1537 such an image (OB field brain damaged) we set errno. Then in
1538 ::FindDocLength() we "fix" the length as being ALL what remains
1539 in the file (until EOF). We then proceed, hoping for the best...
1540 This fixes a SegFault in ShowDicom when trying to write such an
1542 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1543 (because TestWriteRead breaks on it, after a non conformal commit?).
1544 ctest now runs properly, except for MakeDicomDir (which was always
1545 broken) and the Python related stuff (still not fixed).
1547 2004-06-24 Jean-Pierre Roux
1548 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1549 FIX : Test/TestReadWrite now iterates on all the file names
1550 (instead of infinite loop)
1551 ENH : Test/TestWriteRead now iterates on all the file names
1553 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1556 2004-06-24 Jean-Pierre Roux
1557 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1558 when SamplesPerPixel =3
1559 - now Write is no longer confused by
1560 'BitsAllocated = 12" and 'BitsStored=12"
1561 - "UN" value representation Elements are now written correctly
1562 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1563 ENH : - now gdcmHeader has its own Write methods
1564 (in order to split the job that has not to be done
1567 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1569 loop on the same image until memory went out.
1570 Note: this means we still have gobs of memory loss in PrintDocument
1571 * src/gdcmDocument.cxx: fixes problem on parsing on file
1572 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1574 2004-06-24 Jean-Pierre Roux
1575 FIX : Write - All the Sequences and Sequence Item are now written
1576 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1577 is added a the end, when necessary.
1578 - A lot of brain-damaged images, that were read correctly are
1579 now written correctly
1580 - length compatible BinEntry are now loaded correctly
1581 (even for odd groups)
1582 Note : only Explicit Value Representation was checked.
1583 (question : is implicit VR really necessary for gdcm ?)
1585 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1586 * DEVELOPPER: added a proposition of coding style.
1587 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1590 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1591 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1592 Use the gdcmDocEntry::Print() and Write() instead.
1593 * src/gdcmDocument.cxx: bug fix.
1595 2004-06-22 Jean-Pierre Roux
1596 FIX : gdcmDocument.cxx
1597 - Now we do recognize the JpegLossLess format (there was a misstyping in
1598 code 'beautyfication' :-(
1599 - Now we automaticaticaly load the Luts, if any
1601 2004-06-22 Jean-Pierre Roux
1602 In order : to write Sequences, whatever their imbrication level,
1603 : to allow user to create his own Sequences
1604 a lot of modif where necessary (adding, moving, or virtualising methods)
1606 WARNING : save your own sources *before* cvs up !
1609 ADD virtual void Write(FILE *fp, FileType filetype);
1612 ADD virtual void Write(FILE *fp, FileType filetype);
1613 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1616 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1617 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1618 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1619 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1620 ADD std::string GetEntryByName(TagName name);
1621 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1623 std::string vr = "unkn",
1624 std::string fourth = "unkn",
1625 std::string name = "unkn");
1626 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1627 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1628 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1629 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1630 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1631 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1632 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1633 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1636 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1637 ADD virtual std::string GetEntryByName (TagName tagName);
1638 ADD virtual std::string GetEntryVRByName (TagName tagName);
1639 REM virtual bool Write(FILE *, FileType);
1640 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1641 FILE *_fp, FileType type);
1642 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1643 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1644 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1645 REM virtual std::string GetEntryByName (std::string tagName);
1646 REM virtual std::string GetEntryVRByName (std::string tagName);
1647 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1648 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1649 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1651 std::string vr = "unkn",
1652 std::string fourth = "unkn",
1653 std::string name = "unkn");
1654 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1655 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1656 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1657 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1660 ADD virtual void Write(FILE *fp, FileType filetype);
1663 ADD virtual void Write(FILE *fp,FileType filetype);
1666 ADD virtual void Write(FILE *fp, FileType filetype);
1667 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1668 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1669 REM std::string GetEntryByName(TagName name);
1672 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1674 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1675 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1676 The default constructor invoked by the line
1677 gdcmHeader *f1 = new gdcmHeader( header );
1678 was gdcmHeader::gdcmHeader(bool) instead of the expected
1679 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1680 Hence the parsing wasn't executed... See also below.
1681 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1682 as explicit constructor didn't do the trick to fix the above problem.
1683 Could anyone explain why ?
1684 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1685 properly calls gdcmValEntry::Print() (that was weed out from
1686 code related to gdcmBinEntry).
1688 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1689 * In order to fix memory leaks:
1690 - Test/TestWriteSimple.cxx: added cleaning of free store through
1692 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1693 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1694 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1695 (through the call to ::AddDicomDirMeta()) or the destructor
1696 would crash when deleting uninitialized ::metaElems].
1697 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1698 - src/gdcmDocument.cxx:
1699 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1700 from dynamic stores.
1701 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1702 was causing memory leaks.
1703 - src/gdcmSQItem.cxx:
1704 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1705 cleanly handled with polymophism: sorry but my milage is low).
1706 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1707 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1708 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1709 This avoids SegFaulting.
1710 - src/gdcmSQItem.h: coding style.
1712 - Test/TestWriteSimple still severely sucks. The output image content
1713 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1714 damaged when displayed with vtkgdcmViewer.
1715 - on memory leaks: TestWriteSimple leaks really less (see entry
1716 of 2004-06-18 in Changelog file for the call to valgrind).
1717 - on segfaults: ctest now passes all the tests but one (no more
1719 * Erroneous leading white fix:
1720 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1721 white[s] (as opposed to from >> xxx, that removes it [them].
1722 - src/gdcmTS.cxx: ditto.
1723 - gdcmPython/testSuite.py: dirty related kludge removed.
1724 * src/*: remaining references to gdcmParser removed.
1725 * src/*[cxx|h]: added copy[way]left header.
1728 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * In order to fix writing of dicom files:
1730 - Test/TestWriteSimple.cxx: a simpler example of writing.
1731 - Test/CMakeLists.txt changed accordingly.
1732 - src/gdcmDocument.cxx:
1733 -- The destructor now recursilvely removes potential sequences.
1734 -- Bug fix in ::IsJPEG2000()
1735 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1736 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1738 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1739 to only declared) and build on top of
1740 ::GetDocEntryByNumber(guint16, guint16).
1741 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1742 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1743 for usage in destructor and treatement of promotion in
1744 ::ReplaceOrCreateByNumber().
1745 - src/gdcmSQItem.cxx: destructor should better handle his job.
1746 Test/TestWriteSimple now runs (or at least it DOES something).
1747 * We can now start hutting memory links. A good starting point is:
1748 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1749 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1750 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1752 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1753 * Valgrind note: after Mathieu Malaterre teached me how to read
1754 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1756 Using gcc, you can force the STL to use malloc and to free memory as
1757 soon as possible by globally disabling memory caching.
1758 With 3.2.2 and later, you should export the environment variable
1759 GLIBCPP_FORCE_NEW before running your program.
1760 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1761 simply vanish (it is still not clear to me, whether this means that
1762 STL std::string leaks or if valgrind believes it leaks...).
1763 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1764 running bin/gdcmTests makeDicomDir):
1765 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1766 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1768 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1769 SegFaulting (I drowned in DicomDir related code when trying to
1770 understand why the list is empty...).
1771 * src/gdcmDocument.h: first BSD license header try.
1772 * Doc/License.txt added.
1774 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1775 * src/gdcmDocument.[h|cxx]:
1776 - Clean up of the Transfer related predicates. They are now all based
1777 on new method isGivenTransferSyntax, that (should) handle properly
1778 the padding problem.
1779 - general clean up, simplification, and coding style.
1780 - Specific clean up of Parse7FE0() (umproperly named actually).
1781 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1783 2004-06-14 Jean-Pierre Roux
1785 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1786 - fix the display of SQItem ordinal number
1787 - add the GetSQItemByOrdinalNumber method
1788 - remove some useless never written private methods
1790 2004-06-14 Jean-Pierre Roux
1792 - adding a constructor taking a gdcmDocEntry as an input param
1793 - ReplaceOrCreateByNumber now returns :
1794 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1795 a gdcmValEntry * if a string value is passed as a param
1797 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1798 according to the param type (no longer sets a gdcmDocEntry)
1799 - GetValEntryByNumber, GetBinEntryByNumber added
1800 - NewValEntryByNumber and NewBinEntryByNumber added
1802 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1804 - GetSQItemNumber and SetSQItemNumber added, to provide
1805 a (relative) Item identier inside a given Sequence
1806 \warning : some pb remaining around this number
1808 - AddEntry now takes the Item Number as a param
1810 - adding a constructor taking a gdcmDocEntry as an input param
1812 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * Memory leak hunt with the following command:
1814 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1815 --show-reachable=yes gdcmTests PrintDocument
1816 It looks like many (all?) leaks are due to the STL (or a bad usage
1817 of the STL. The lines producing the leaks now have a comment with
1818 a "MEMORY LEAK" tag: you can retrieve them with
1819 grep "MEMORY LEAK" src/*
1820 Here are two typical examples which I can't help fixing:
1825 char * test = "babo";
1826 name = test; //// <--- valgrind detects 960 bytes lost in
1827 //// call to std::string::operator=(char const*)
1828 name.clear(); //// Doesn't help !
1836 std::cout << "Type a bunch of characters followed by RETURN: ";
1837 getline(std::cin, line); //// <--- valgrind dectects a loss
1838 //// of 1320 bytes in call to
1839 /// std::basic_istream<>& std::getline<>
1845 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * src/gdcmHeader.[cxx|h]:
1847 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1848 and related, moved away to gdcmDocument.
1849 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1850 the corresponding protected accessors of inherited class
1851 gdcmDocument, removed ! As a consequence gdcmFile had to be
1852 declared friend of class gdcmDocument (see below).
1853 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1854 - Clean up of undefined or unused methods.
1855 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1856 account the changes to gdcmHeader.h).
1857 * src/gdcmDocument.h:
1858 - gdcmFile is now a friend class (in order to take into account the
1859 changes to gdcmHeader.h).
1860 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1861 (see changes to gdcmHeader.h).
1862 - Accessors (reading on the form GetEntry*) are now public.
1863 - Clean up of undefined or unused methods.
1864 * src/gdcmDocument.cxx:
1865 - adaptation to changes to gdcmDocument.h
1866 - ::OpenFile now writes a verbose message when file cannot be opened.
1867 - some std::string properly set to VRKey
1868 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1869 references to gdcmDocument.
1870 * Test/TestFindTags.cxx: changed accordingly to above changes.
1871 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1872 cvs repository gdcmData.
1874 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1876 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1877 conflicts with gdcmValEntry::voidArea.
1878 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1879 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1880 Value representation between StringRepresentable and BinaryRepresentable.
1881 * src/gdcmDocument.cxx:
1882 - method ParseDES: proper indentation restored and usage of
1883 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1884 - method LoadDocEntry: the fingerprint left in the SetValue() of
1885 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1886 removed. Reverting to previous code segment with the proper
1887 dynamic_cast< gdcmValEntry* >.
1888 Note: this was (partially) breaking the python test suite
1889 (gdcmPython/testSuite.py) that made usage of the above
1890 fingerprint to check presence of "Pixel Data".
1891 * src/gdcmDocEntry.h: coding style.
1892 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1893 now taken into account.
1894 * gdcmPython/gdcm.i: adaptation to the new internal representation
1895 of gdcm (exit gdcmParser, hello gdcmDocument).
1896 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1898 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1899 anymore, but instead prints the loaded Python dictionary.
1900 * .... alas, the python testSuite is still broken.
1902 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1903 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1905 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1906 * src/gdcmUtil.h : export methods
1908 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1911 * Initial addition of automatic python testing
1912 * Initial addition of automatic image comparison
1914 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1915 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1916 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1918 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1919 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1920 * Test/ShowDicom.cxx : bug fix for msvc compilation
1921 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1923 2004-05-04 Jean-Pierre Roux
1924 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1925 new concepts (and new classes) :
1926 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1927 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1928 - Sequence Doc Entries (gdcmSeqEntries)
1929 a Sequence is composed of Items.
1930 Each item is a set of Doc Entries (this is recursive)
1931 The non uniqueness of the 'Dicom tag' is due to this recursivity
1932 (never taken into account)
1933 Our unability to add a new 'entry' in the header
1934 at the proper location (neither in the H-Table (map or multimap),
1935 nor in the Chained List is also due to this recursivity.
1936 Don't try, right now, to use/modify/compile these new sources :
1937 nothing is finished.
1938 We just commit all the stuff, 'as is', in order not to loose it.
1940 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1941 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1943 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1944 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1945 file prefix (SetFilePrefix)
1947 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * Add a new test: ShowDicom, for now this is just the c++ version of
1949 checkRead.sh, later it will be able to compare the image read against a
1951 * Replace the DEBUG on the stack with a global entry in cmake interface:
1952 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1954 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1955 * Add an example subdir, with a real example on how to read + write a
1958 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1960 * Doc/CMakeLists.txt: the main page is now properly differentiated
1961 between the developper and user version.
1962 * Doc/doxygen.config.in: dropped search related obsolete flags
1963 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1965 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1966 * DEVELOPPER: added some helpfull comments for compile/test/install
1969 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1971 src directory, now generated in the build dir.
1972 2. Tests as mentionned smarter
1974 4. Add a new method in gdcmDict that return the PubDict by name
1975 this is interesting for 3rd party lib like ITK,
1976 where we could set the institution name / patient name...
1978 * ENH: 1. Now the test suite is working for real
1979 2. All binaries are now output in the gdcm-bin directory
1980 (this was not true before)
1982 2004-04-28 Jean-Pierre Roux
1983 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1984 SeQuence indented printing of Dicom Header.
1985 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1986 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1987 Computation of SQDepthLevel is now part of gdcmHeader constructor
1988 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1989 tree-like structure of a Dicom Header.
1990 * FIX Test code cleaning
1992 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * ENH: Adding automatic testing
1994 1. Need a DartConfig.cmake to submit to public
1995 2. Add a test driver gdcmTest.cxx
1996 3. gdcmTestMain, an helper for the main test driver gdcmTest
1997 4. Files in Test don't have a main anymore, this becomes interesting
1998 when we add more and more tests, thus dsw don't have to load
2000 * ENH: Adding a GDCM_DATA_ROOT for testing
2001 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2002 one file instead of seven + some small cleanup
2004 2004-04-22 Jean-Pierre Roux
2005 * ENH Minor changes to the Print() methods.
2006 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2007 Header printing. Example given with :
2008 > PrintHeader fileName 2 new
2009 (SQ based tree-like structure still to be done for the Header ...)
2011 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2013 1. I have added some unsigned where needed
2014 2. Some function parameter not used -> (void)
2015 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2016 4. g++ don't like character '\' in comment
2017 5. #define jpeg_create_decompress jCreaDecompress
2018 this really need to be fixed
2019 6. virtualize destructor of gdcmObject ... leakage
2020 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2021 this also really need to be fixed
2022 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2023 remove compression file
2024 (as we only do decompression, right ?)
2025 * ENH: Change malloc/calloc/free with c++ equivalent
2027 2004-04-21 Jean-Pierre Roux
2028 * FIX gdcmHeaderHelper::GetXSpacing
2029 when a single value is found (bug ?), xpacing is now
2030 defaulted to yspacing
2032 2004-04-19 Jean-Pierre Roux
2033 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2034 * ENH add parameters :
2035 bool exception_on_error = false,
2036 bool enable_sequences = false,
2037 bool ignore_shadow = false
2038 to the gdcmFile constructors to be full gdcmParser compliant
2039 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2040 to allow reading of PAPYRUS 3.0 files
2042 2004-04-06 Jean-Pierre Roux
2043 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2045 2004-04-02 Jean-Pierre Roux
2046 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2047 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2048 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2050 2004-03-30 Jean-Pierre Roux
2051 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2052 for ACR file, written out as DICOM files (hope so...)
2054 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2055 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2056 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2057 moved to base class gdcmParser and only the specialisation is kept
2059 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2060 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2061 already does the job.
2062 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2063 (to be consistent with gdcmParser::WriteEntries).
2065 2004-03-30 Benoit Regrain
2066 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2067 upate of the object's instance. It's passed to 2 in the unfavorable
2068 case : one in the ExecuteInformation, one in the ExecuteData
2070 2004-03-29 Jean-Pierre Roux
2071 * ENH : Check on file type to be written moved
2072 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2073 * FIX : gdcmObject::ResetBoundaries now stops properly
2074 when end-of-list is reached
2075 : gdcmVersion modified (as Benoit Regrain asked)
2077 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2079 * src/gdcmUtil.cxx: added forgotten iostream include.
2080 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2081 equivalent to ExplicitVR in existing code).
2083 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2084 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2085 now contains all the gdcmGlobal related code.
2086 * minor coding style and doxygenation changes.
2088 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2090 now contains all the Debug related code.
2091 * minor clean-up of includes in src/*.cxx
2092 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2093 CreateCleanString) removed.
2094 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2095 * Doc/DoxyMainPageUser.txt added.
2096 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2097 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2098 src/gdcmDirList.cxx)
2100 2004-03-24 Jean-Pierre Roux
2101 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2103 2004-03-23 Jean-Pierre Roux
2104 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2105 big endian made volumes
2106 * ENH Now gdcmParser constructor and destructor are protected to forbid
2107 end user to instanciate class gdcmParser
2108 (only gdcmHeader and gdcmDicomDir are meaningfull)
2110 2004-03-22 Benoit Regrain
2111 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2112 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2113 gdcmSerie to gdcmDicomDirSerie
2115 2004-03-19 Jean-Pierre Roux
2116 * ENH Now the tree-like structure describing a DICOMDIR comming from
2117 an already existing DICOMDIR file is consistent with
2118 the home-made tree-like structure build ex-nihilo
2119 or build from the files held (recursively) in a Directory
2120 functions gdcmDicomDir::CheckBoundaries()
2121 gdcmObject::SetBoundaries() added
2123 2004-03-17 Jean-Pierre Roux
2124 * REM (Eric Boix bug) : removal of meaningless
2125 gdcmDicomDirImage::NewImage function.
2126 * FIX now file names and directory name are written properly in the
2128 * FIX now gdcmDicomDir constructor may be call without any trick
2131 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2133 of gdcmDicomDirImage::NewImage as empty function.
2135 2004-02-28 Jean-Pierre Roux
2136 * ENH add gdcmDicomDir:NewPatient
2137 add gdcmDicomDirPatient:NewStudy
2138 add gdcmDicomDirStudy:NewSerie
2139 add gdcmDicomDirSerie:NewImage
2140 to allow making gdcDicomDir object.
2141 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2142 (as opposite to the gdcmHeader chained list)
2144 2004-02-11 Benoit Regrain
2145 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2146 when using from python
2148 2004-02-10 Benoit Regrain
2149 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2150 * FIX : in gdcmDicomDir when the directory is empty
2151 * ENH : add callback and methods to get the progression of dicomDir
2154 2004-02-06 Jean-Pierre Roux
2155 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2156 - GDCM_META added to gdcmDicomDirType
2157 - class gdcmMeta created
2158 * ENH : - A brief summary is now displayed at the beginning of
2159 'testDicomDir' to help disaster magnitude estimation
2160 * REM : Now useless Test/explDICOMDIR.cxx
2162 2004-02-05 Benoit Regrain
2163 * ENH : add methods in gdcmObject to get the hash table or the list of
2165 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2166 * FIX : wrapping python for TagHeaderEntryHT
2168 2004-02-04 Benoit Regrain
2169 * FIX : even length for some strings when writting the dicom dir
2170 * FIX : sort the images in the dicom dir
2171 * FIX : Bug fix for python use of dicom dir
2172 * ADD : a python demo
2174 2004-02-04 Jean-Pierre Roux
2175 * FIX : Final solution (?) for icone embedded images
2176 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2177 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2178 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2179 gdcmData/gdcm-MR-SIEMENS-16.acr1
2180 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2181 to make full checking easier
2183 2004-02-04 Benoit Regrain
2184 * FIX : WriteEntries : coding style & logic in parameters
2185 * FIX : Set the elements to create the DicomDir in a dictionary file
2187 2004-02-03 Benoit Regrain
2188 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2189 * gdcmDicomDir : add the load of directory
2190 * Bug fix and print add-on
2192 2004-02-03 Jean-Pierre Roux
2193 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2194 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2195 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2196 * FIX gdcmParser.cxx : 'group length' elements are now considered
2197 as integers, even for shadow groups, when file is Implicit VR
2199 2004-02-02 Jean-Pierre Roux
2200 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2202 of the last synonym :-(
2203 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2205 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2206 * FIX taking into account the possible 7fe0,0010 multiplicity
2207 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2208 to allow removal of references to 7fe0,0010, to deal with
2209 ACR-NEMA images, when 0028,0200 is meaningfull
2211 2004-01-31 Jean-Pierre Roux
2212 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2213 no longer writes 'Un' on disk
2214 * FIX SQ elements with actual length are now dealt with corectly
2215 * FIX gdcmFile::WriteBase make the difference, for color images, between
2216 the length (for Palette expanded images)
2217 and Raw Length (non expanded image + Palette)
2218 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2219 (that broke Write). Replaced by UL.
2220 Aware user will reload the field if he
2221 thinks it's necesssary
2223 2004-01-30 Jean-Pierre Roux
2224 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2225 when 'dirty Acr' is found, to be compliant with the new
2226 IsReadable() methods.
2228 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2229 (no DOUBLE images in kosher DICOM,
2230 but so usefull for people that miss them ;-)
2232 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2233 DICOMDIR related utilities (not checked as Windoze compliant)
2235 2004-01-28 Jean-Pierre Roux
2236 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2238 2004-01-27 Jean-Pierre Roux
2239 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2240 to allow skipping the shadow elements, to save memory space.
2241 The TRUE value for this param has to be used
2242 with a FALSE value for the 'enable_sequence' param.
2243 ('public elements' may be embedded in 'shadow Sequences')
2244 * gdcmHeader methods now deal with 'embedded icones images' in the header
2245 (even when an 'icone image sequence' is announced by the
2246 element (0x0088,0x0200), but there is NO icone at all ...
2248 * gdcmHeader sometimes Image Location value doesn't follow
2249 the supposed processor endianity (see gdcmData/cr172241.dcm).
2252 * gdcmHeader add the method
2253 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2254 to get *all* the Header Entries with the same tag.
2255 GetHeaderEntrySameName is probabely *useless*
2256 (no meaning : Name is *not* an identifier within the Dictionary)
2258 2004-01-26 Benoit Regrain
2259 * Bug fix in the print of hexadecimal representations. Remove long fields
2260 in the print and add a third level of print to print them
2262 2004-01-23 Benoit Regrain
2263 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2264 * Bug fix on test suite after remove the strip made on not string fields
2265 * Split the IsReadable method between gdcmParser which test that the file
2266 is dicom and gdcmHeader which test that it's an image file
2268 2004-01-22 Benoit Regrain
2269 * DicomDir : clean code, add methods, set variables in protected or private
2270 * gdcmUtil : bug fix for the clean string method
2272 2004-01-19 Benoit Regrain
2273 * Add the use of shadow dictionaries
2274 * bug fix and coding style
2276 2004-01-19 Benoit Regrain
2277 * src/gdcmFile.cxx : bug fix concerning the close of file
2278 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2279 * Add the update of header entries using the shadow library
2281 2004-01-19 Benoit Regrain
2282 * removal of file gdcmHeader2.cxx
2283 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2284 inheriting from gdcmParser. This split is to prepare the integration
2285 of dicom dir parsing
2286 * bug fix under python
2288 2004-01-16 Jean-Pierre Roux
2289 * REM removal of class gdcmHeaderEntrySet
2290 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2291 * ADD add file gdcmHeader2.cxx
2292 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2294 2004-01-15 Benoit Regrain
2295 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2296 entries created while parsing the header. Thus, they will be destroyed
2297 when the gdcmDictSet will be destroyed
2298 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2301 2004-01-15 Benoit Regrain
2302 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2303 made a fatal error because of the memory release at the end of program.
2304 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2305 some memory and vtk seems to have some problems with that.
2306 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2308 2004-01-14 Benoit Regrain
2309 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2310 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2311 * src/*.[h|cxx] : make changes due to class name changes
2312 * gdcmPython/demo/*.py : bug fix due to method names
2314 2004-01-13 Benoit Regrain
2315 * src/*.[h|cxx] : coding style
2316 * vtk/*.[h|cxx] : coding style
2318 2004-01-13 Benoit Regrain
2319 * gdcmPython/testSuite.py : test the readable flag of file for tests
2320 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2321 It's lied to the stl compilation by MSVC (windows, always windows...)
2322 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2324 2004-01-12 Benoit Regrain
2325 * src/*.h : add comments
2326 * src/gdcmDictSet.h : set the method BuildDictPath in public
2327 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2328 directly setted in the source code
2329 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2332 2004-01-09 Benoit Regrain
2333 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2334 * setup.py : use a reference to gdcmVERSION
2336 2004-01-07 Benoit Regrain
2337 * Modification to compile with the distutils.
2340 2003-12-10 Benoit Regrain
2341 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2342 can use a gdcmHeaderHelper to load data
2343 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2344 made in the source code
2346 2003-12-10 Benoit Regrain
2347 * Update Windows projects and .cvsignore files
2349 2003-11-12 Jean-Pierre Roux
2350 * ENH gdcmHeader constructor has one more parameter (default value : false)
2351 that allows the user to 'go inside' the SeQuences only
2353 gdcmElValSet:Print takes it into account
2355 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2356 * ENH: Update gdcmPython/CMakeLists
2357 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2358 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2360 2003-11-10 Jean-Pierre Roux
2361 * FIX : gdcmHeader::LoadElements is now based
2362 on the ListTag listElem member,
2363 not longer on the TagElValueHT tagHt member
2364 * ENH : PrintPubElVal shows (temporarily) both results,
2365 with the tagHt member and the listElem member.
2366 (it's easier to 'see' the problems when using Printheader)
2368 * FIX : old private member LgrElem is now splitted into
2369 ReadLength : Length actually found on disk (updated only
2370 if bug fixing is necessary), for internal
2372 UsableLength : Updated by FixFoundLength, to fix a bug
2373 or to allow Parser going on.
2374 Will allow to re-write a kosher header when a SeQuence
2375 with a length (not 0000) is found
2376 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2377 because gdcmElValSet::Add does not update ListElem
2380 2003-11-07 Jean-Pierre Roux
2381 * FIX misstyping in Transfert Syntax name table
2382 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2383 when they have an actual length (not 0000 nor FFFFF)
2384 (Nobody should care of it, but DICOMDIR explorers)
2386 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2387 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2389 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2390 * ENH: vtkGdcmReader now supports LUT !
2391 (vtkgdcmViewer for now is not able to use them though)
2393 2003-11-05 Jean-Pierre Roux
2394 * in testSuite.py : new files names for checking the package
2395 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2396 that returns the pixel area size to the *aware* (vtk) user
2397 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2399 2003-11-05 Benoit Regrain
2400 * in testSuite.py : Modify the rules for checking the paths
2401 : Explicit error messages
2402 * in __init__.py : Related modif
2404 2003-11-03 Jean-Pierre Roux
2405 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2406 to be used by aware (vtk) users that want to manage
2407 LUT (and no to turn the PALETTE image into an RGB pixels one)
2408 * GetPixelType now returns 8U for 24 Bits images
2409 (vtkGdcmReader compliant)
2411 2003-10-31 Jean-Pierre Roux
2412 * Removal of *all* gdcmData images and add them again
2413 in order to loose the 'history' of un-anonymised images
2415 2003-10-31 Jean-Pierre Roux
2416 * RMV : removal of useless jBitsInJsample.h
2417 for both 8 and 12 Bits JPEG Lossy Libraries
2419 2003-10-31 Jean-Pierre Roux
2420 * ENH : Add the functions gdcmFile::GetImageDataRaw
2421 gdcmFile::GetImageDataIntoVectorRaw
2422 that act as GetImageData and GetImageDataIntoVector
2423 except the making of an RGB Plane from Gray Plane + LUT
2424 Intended to aware (vtk) users who know how to manage
2427 GetLUTRGBA return a R,G,B,A LUT if any
2428 lgrTotaleRaw gives the 'Raw' length
2429 GetImageDataRaw returns the gray Plane
2430 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2431 (They stay Grey, just like with other Dicom viewers :-(
2433 2003-10-30 Jean-Pierre Roux
2434 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2436 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2437 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2438 being coherents dicom files.
2440 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2441 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2443 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2444 * ENH: Two steps is necessary to please VC++ compiler...
2445 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2446 * ENH: Add include dir to medcon lib
2447 * FIX: only one function is being exported for now !
2448 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2450 2003-10-29 Jean-Pierre Roux
2451 * adding gdcmHeader::GetLUTRGBA
2452 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2453 --> Mathieu, the modif u're waiting for is not yet committed
2454 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2456 2003-10-27 Jean-Pierre Roux
2457 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2458 00191113.dcm DermaColorLossLess.dcm
2459 MxTwinLossLess.dcm RadBWLossLess.dcm
2460 * ENH: For version prior to vtkImageViewer2 -r 1.19
2461 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2463 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2464 * Removal of ido stuff in CMakeLists.txt
2466 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2467 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2468 * FIX: remove a call to ->Modified ... see comments
2469 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2471 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2472 * FIX: Problem with path for libvtkgdcmPython
2473 * ENH: Try adding a search script for python site-package
2474 * RMV: Remove some file from medcon lib that are not necessary
2475 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2476 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2477 * FIX: More pragma disable fro VC++,
2478 I don't think I break something as it is also disable in VTK/ITK.
2479 But it fasten debug compilation time.
2481 2003-10-23 Jean-Pierre Roux
2482 * gdcm now deals with 16 Bits Run Length Encoded images
2483 (they are compressed as 2 planes images,
2484 one for the high Bytes, the other for low Bytes)
2486 2003-10-22 Jean-Pierre Roux
2487 * Now CheckRead takes into account :
2488 - the bugged 'Leonardo' Siemens images
2489 - the XA images, sent thru the burning VPRO station
2490 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2493 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2494 * FIX: When copying a Makefile.am to CMakeLists.txt
2495 one should remove the '\'
2497 2003-10-22 Jean-Pierre Roux
2498 * in gdcmData adding a bugged 'Leonardo' Siemens image
2499 (wrong lengths in header)
2500 OK with gdcm, KO with the other viewers :-)
2501 * add a GE dlx XA image, thru the VEPRO burning station
2504 2003-10-21 Jean-Pierre Roux
2505 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2506 for a brutal checking of vtkgdcmViewer compliance
2508 2003-10-21 Jean-Pierre Roux
2509 * add the files for 'xmedcon' Jpeg Lossless library
2510 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2512 2003-10-21 Jean-Pierre Roux
2513 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2515 2003-10-21 Jean-Pierre Roux
2516 * garbage Siemens 'Leonardo' images dealt with
2517 (the patch is easy to remove)
2518 * cosmetic changes to avoid warnings
2520 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2522 no need to press 'r' now.
2524 2003-10-20 Jean-Pierre Roux
2525 * upgrade of checkRead.sh checkWrite.sh according
2526 to new Jpeg Lossless decompressor
2527 * add US.3405.1.dcm, a genuine RGB medical file ...
2528 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2529 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2531 2003-10-15 Jean-Pierre Roux
2532 * general anonymisation in gdcmData
2533 * adding the 'color files' from
2534 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2535 * adding some well knowed bugged-header images
2536 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2537 waiting for their inclusion in Python testsuite
2539 2003-10-15 Jean-Pierre Roux
2540 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2541 no longer seg faults when file is not found
2543 2003-10-14 Jean-Pierre Roux
2544 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2547 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2548 * TODO: *.in file to genereate a UseGDCM later
2550 2003-10-14 Jean-Pierre Roux
2551 * Some supposed-to-be Dicom Images have no preamble.
2552 OpenFile takes it into account
2553 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2554 * Missing elements added in dicomV3.dic
2555 (just to be affraid : have a look at
2556 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2557 and do it again next year ;->
2559 2003-10-13 Jean-Pierre Roux
2560 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2561 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2562 But there are NOT. It's fixed !
2564 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2565 * FIX: "jpeglib.h" was not found on VC++
2566 * FIX: vtkgdcm was not being installed
2568 2003-10-10 Jean-Pierre Roux
2569 * ENH : OpenFile closes the file if it *really* doesn't look like
2570 an ACR-NEMA / DICOM one.
2571 * FIX : testWrite no longer writes an empty file if the source file
2572 is not gdcm Readable
2573 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2576 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2577 * FIX: CMake generate now documentation
2578 * ENH: out of source doc build !
2579 * ENH: Generate both user and dev documentation
2580 * ENH: Should work on windows too
2581 * ENH: Only one doxygen config.in file is needed
2582 * FIX: make install should be ok now on ùnix plateform
2583 * FIX: PATH to dictionary was wrong (missing /)
2584 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2586 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2587 * vtkGdcmReader is now able to read rgb dicom file.
2588 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2589 * added a gdcmViewer to vtk test, use mouse to control
2590 window level & window width
2592 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2593 * CMake-ification of gdcm, we have now two build system
2594 * FIX: on cygwin Wsock32 doesn't exist
2595 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2597 2003-10-06 Emanuel Ollart
2598 * FIX : compilation process wad broken.
2599 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2601 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2602 * change gdcmViewer -> vtkgdcmViewer
2603 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2605 2003-10-06 Jean-Pierre Roux
2606 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2607 ( e.g : well known GE images with a wrong elem length,
2608 : Philips MRI Images with a wrong Huffman table)
2609 * still to be done : allow the reading of bugged LEONARDO Siemens images
2611 2003-10-03 Jean-Pierre Roux
2612 * Odd length strings are padded with '\0' (not with spaces,
2613 to remain compliant with already defined strings,
2614 like Transfert Syntax UID and others)
2616 2003-10-03 Jean-Pierre Roux
2617 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2618 to allow displaying RGB images (not only by affim ;-)
2620 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * vtkGdcmReader is now able to read rgb dicom file.
2622 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2624 2003-10-03 Jean-Pierre Roux
2625 * A few nasty patches to allow the reading of a lot of nasty images
2626 ( e.g : well known GE images with a wrong elem length,
2627 : Philips MRI Images with a wrong Huffman table)
2628 * still to be done : allow the reading of bugged LEONARDO Siemens images
2630 2003-10-03 Jean-Pierre Roux
2631 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2633 2003-10-03 Jean-Pierre Roux
2634 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2635 to allow displaying RGB images (not only by affim ;-)
2637 2003-10-03 Jean-Pierre Roux
2638 * gdcmFile::GetImageDataIntoVector now
2639 - deals with MultiFrames MultiFragments Run Length Encoded files
2640 - deals with YcBcR (YBR_FULL) files
2641 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2642 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2644 (no sample found :-(
2646 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2647 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2648 Two reasons: - clear things
2649 - third parties acces gdcm through header files, so won't
2650 suffer anymore VC++ complains
2652 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2653 * add argv[1] in testvtkGdcmReader.cxx
2656 2003-09-24 Jean-Pierre Roux
2657 * The lines are now eigthy characters long.for
2658 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2660 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2661 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2662 char* to std::string. Thus, the use of strdup becomes useless. (see
2663 previous commis of Malaterre)
2664 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2665 before the last Malaterre's commit.
2667 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2668 * This commit should fix the Debug building under VC++, the problem
2669 was mainly a mixture of debug and release lib being loaded at startup.
2670 * I also remove a depency to a specific C function: strdup. Because I had
2671 to force the link to msvcrtd (whereas strdup is in libc).
2673 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2674 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2675 located in the gdcmCommon.h file. All use of reference of tha has been
2676 changed to now use the variable GDCM_UNFOUND.
2678 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2680 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2681 Dicom dictionary. The test suite can now be run again. Note:
2682 I'm note very happy with the " (RET)" changes. I believe this
2683 RETAINED comment should be dropped when parsing the dictionary.
2684 - PACKAGER corrected
2686 - AUTHORS updated and now in alphabetical order
2687 * Makefile.am now exports gdcm.dsw for Windoze users.
2689 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2690 * cygwin complains about missing std:: in subdir Test/
2692 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2693 * remove some methods that are now in gdcmHeaderHelper
2695 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2696 * vtkGdcmReader set spacing and origin correctly
2698 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2699 * Fix a few delete/delete[] mismatch
2701 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2702 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2703 interpretation to data given by gdcmHeader. For instance there are
2704 heuristics to get informations (look at different places).
2705 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2706 sorting DICOM images based on different strategies.
2707 * modified Makefiles accordingly.
2709 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2710 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2711 when building in debug mode
2712 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2713 src/win32/gdcmdll.dsp
2714 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2716 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2717 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2720 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2721 * src/win32/libgdcmjpeg12.dsp was not dos format
2722 * src/win32/libgdcmjpeg12.dsp :
2723 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2724 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2726 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2727 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2729 * src/gdcmFile.cxx : bug fix in affectation type
2730 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2731 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2732 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2733 symbols... future problem ?
2735 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2736 * src/win32/libgdcmijpeg12.dsp was missing
2737 * modified gdcm.dsw accordingly
2739 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2740 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2742 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2743 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2744 commit of JPR (before his hollidays to facilitate our work).
2745 * setup.py : bug fix in code. Modifications made while the last commit
2746 of JPR. The code hasn't been tested before the commit... it's so
2747 useless to make that (for best programmer that is JPR) !!!
2749 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * tagged the current version as Version0_3 (i.e. version 0.3)
2752 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2753 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2754 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2755 * *.dsp : modifications to use new libgdcmijpeg8 library
2756 * setup.py : bug fix on VTKPATH variable
2757 * PACKAGER : adding all concerning windows
2759 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2762 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2763 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2764 test suite reported error.
2765 * PACKAGER file added (describes what a packager must do when
2766 packaging a new release).
2767 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2768 * configure.in: upgraded version number to 0.3.0
2769 * fixing build of rpm (through rpm -ta):
2770 - Doc/Makefile.am exports proper doxygen files
2771 - src/jpeg/libijg8/Makefile.am exports the include files.
2773 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2774 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2775 * src/gdcmHeader.h : formatting code
2777 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2778 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2779 We were obtaining error message from vtk. Now, creation of file list
2780 is made in an internal list to prevent this problem.
2781 Bug fix when output is empty.
2782 Bug fix in update of progress value. Previous commit for this was a bad
2784 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2786 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2787 * src/gdcmHeader.h : added method to get the file name
2788 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2789 files. Added method to remove all files on the input
2790 Added FIXME comment concerning the bad parsing of header made by
2791 ExecuteInformation method (in ExecuteData method)
2793 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2795 when using make instal.
2796 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2797 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2799 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2800 * setup.py : adding include dir of jpeg lib to compile all sources
2801 * */Win32/*.dsp : JPR fix for windows compilation
2803 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2804 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2806 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2807 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2809 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * setup.py is again effective on un*x (takes into account the
2811 addon of the jpeg library)
2812 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2813 * Doc/Doxy* updated (includes above enhancements)
2814 * INSTALL now points to web documentation
2816 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * src/gdcmHeader.h doesn't make unnecessary reference to
2819 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2821 * src/gdcm*.[cxx|h] :
2822 - to allow compilation with gcc 3.x
2823 -- clean up of STL usage (added explicit usage of std::)
2824 -- small fixes on exceptions.
2825 Note: linking not tested !
2826 - clean of doxygen comments to avoid warnings at documentation
2828 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2829 dependent convertion).
2831 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * Clean up of previous JPR garbage commit (not even commented in the
2834 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2835 - moved all jpeg related files from src to src/jpeg/libijg8, with
2836 addition/modification of Makefile.am and configure.in.
2837 - the testSuite is still brain damage (not guilty).
2839 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2840 * WrapVTK.py : modifications to get correctly vtk source files to
2842 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2843 (FileName -> Filename)
2845 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2846 * vtk/vtkGdcmReader.[cxx/h]:
2847 - UpdateProgress method should now be effective
2848 - removed the limitation on having only images loaded (as opposed
2850 - when building a stack of images/volume, a lesser number of
2851 gdcmHeader and gdcmFile instances should be used (hopefully
2852 accelerating things).
2853 - when building a stack of images/volumes, files which are not
2854 loadable (wrong path-filename, wrong permissions on existing file,
2855 or file not parsable by gdcm) are replaced with a black image
2856 in the stack (for the caller to notice the problem).
2858 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2861 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2862 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2863 between standard library (std) and vtk library (problems are found
2864 under Windows... thanks Windows !)
2866 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2869 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2871 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2874 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * When compiling with distutils (see setup.py) the C++ compiler is
2876 called with different flags than the default ones (with automake).
2877 In order to fix all those warning, I compiled gdcm with the command
2878 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2879 and went for warning fixes:
2880 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2881 up from unused variables.
2882 - vtk/vtkGdcmReader.cxx: potential bug fix.
2883 * src/gdcmHeader.h: Doxygen warning cleanup
2885 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * gdcmPython/gdcm.i:
2887 - typemaps correction to take into account the systematic replacement
2888 of "using namespace std" with std:: prefix e.g. std::list,
2889 std::string... (cf changes of 2003-05-21).
2890 - gdcmGlob global variable of type gdcmGlobal (defined in
2891 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2892 exported to Python a as cvar.
2893 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2894 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2895 gdcmDictSet.GetPubDictTagNames() and
2896 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2897 C++ static methods).
2898 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2899 with the above changes.
2901 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2902 * setup.py, manifest.in : bug fix under linux
2904 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2905 * Modification of setup.py to compile vtk part too. Then, we have 2
2906 wrappers which must work with same distutils. For that, we have a
2907 generic distutils in distusiltsWrapping.py ; with :
2908 - build_extWrap class to wrap generically all extensions,
2909 - ExtensionWrap base class for all wrapping extension that contains
2911 - Wrapper interface which wrap sources
2912 + In WrapSwig.py we have extension and wrapper for Swig
2913 + In WrapVTK.py we have extension and wrapper for VTK
2914 * MANIFEST.in : modifications to consider vtk directory and new python
2915 files for compilation
2917 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2918 * Added python wrappers of vtkGdcmReader vtk class (see the
2919 source in vtk/vtkGdcmReader.cxx) :
2920 - vtk/Makefile.am now builds a library
2921 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2922 python library (as opposed to _gdcm.so wich are the python
2923 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2924 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2926 - configure.in has an additional flag --enable-vtk that needs
2927 to be set to enable compilation of vtk related code, that is:
2928 + vtk/vtkGdcmReader.so and
2929 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2930 + gdcmPython/vtkgdcmPython.so (see above)
2931 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2932 be read when compressed or when HighBit + 1 != BitsStored),
2933 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2934 the usage of the python wrapper of vtkGdcmReader vtk class.
2935 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2936 * src/*.[h] all occurences of stl classes are now prefixed with
2937 std::, and all occurences of "using namespace std;" where removed.
2938 This is to avoid pollution of global namespace in included files.
2939 Apparently vtk does not avoid this pitfall: when using both
2940 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2941 collision of various stl members (principally cout...).
2942 * gdcmPython/testSuite.py now cleanly removes temprory generated
2944 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2945 comply with above changes)
2947 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2948 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2949 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2950 vtk data structure (an image Flip was required).
2951 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2952 * cosmetic changes in documentation.
2954 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2955 * src/gdcmHeader.cxx: the constructor no longer exits when an
2956 unexisting file is given as argument.
2957 * The subdirectory Data (containing all the images used for the
2958 test suite) is not part of this repository anymore. A new module
2959 containing those images is now available at
2960 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2961 with the name gdcmData.
2962 All the python scripts (including the package initialisation file
2963 gdcmPython/__init__.py) were adapated to take this change into
2964 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2966 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2967 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2968 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2969 demo of the usage of this class.
2970 Compilation of this vtk part is only done when using the --enable-vtk
2971 at configure (or autogen.sh) stage.
2973 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2974 * More memory link related corrections and documentation fixes.
2976 - maximum info is obtained with a command of the form:
2977 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2978 --show-reachable=yes PrintHeader
2979 - the remaining reachable blocks seem to come from the STL
2980 allocation scheme through the usage of map and list. It looks
2981 like this memory cannot be freed but it is not a memory leak
2982 (in fact further invocation to the STL would recollect the
2983 unused memory allthough it cannot explicitely be freed).
2984 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2985 of displaying an image parsed with gdcm and displayed with VTK.
2986 Note: some images don't seem to work e.g.
2987 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2988 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2989 Allthough this weakens the semantics, it is a ditch attempt to
2990 make gdcm more thread friendly.
2992 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2993 * Memory link hunt (by using valgrind through the command
2994 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2995 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2996 gdcmHeader::_dicom_vr.
2997 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2998 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3000 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3002 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3003 * src/Makefile.am now exports all the necessary include files at
3007 * UpdateGroupLength replaced by new one
3010 * UpdateGroupLength re-written using H-Table
3011 (named UpdateGroupLengthNew untill checks are over)
3013 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3014 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3015 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3017 - gdcmHeader::GetPubElValSet removed.
3018 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3019 UpdateGroupLength, WriteElements, Write.
3020 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3021 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3022 carried the same semantics.
3023 - src/gdcmHeaderIdo.cxx changed accordingly.
3024 - gdcmFile::WriteBase now regroups all the codes from previous
3025 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3026 - enum FileType moved to gdcmCommon.h
3027 * src/gdcmHeader.cxx AddDefault trashed
3028 * gdcmGetXSize added
3029 * getimageDataSize now calls gdcmGetXSize
3030 * Test/*.cxx changed to agree with above changes
3032 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3034 (to avoid double call by end user).
3035 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3036 by end user, since gdcmHeader::gdcmHeader now handles it.
3038 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * gdcm/Doc many doxygen changes:
3040 - Doxyfile now has two different versions, DoxyfileUsers that generates
3041 the html.users end users oriented documentation and
3042 DoxyfileDeveloppers that generates the html.developper developper
3043 oriented documentation.
3044 - README changed accordingly
3045 - requirement.txt removed (old design info moved to TODO).
3046 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3047 DoxyMainPage.txt, DoxyPython.txt provide more information.
3048 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3049 be updated by simply regenerating the docs with doxygen and copying
3050 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3051 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3052 all the tests in the form "if (<map>.count() >1)" were removed.
3053 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3054 ill-formed documentation sections.
3055 * src/gdcmHeader.cxx: ditto
3057 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3058 * setup.py fixed for un*x (needed macro for stdint.h)
3059 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3060 un*ces with sh-utils test utility.
3061 * gdcmPython/demo/test.py renamed to PrintHeader.py
3062 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3063 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3064 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3065 * src/gdcm*.cxx JPR's bad inclusion fixed.
3067 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3068 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3069 * gdcmPython/demo/test.py changed accordingly.
3071 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * gdcmPython/Makefile.am fixed linking against libstdc++
3073 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3074 * Swig subdir (historical tests of swig version 1.3.17++) removed
3075 * Test/testChangeEntete.cxx some lines commented out in order to make
3077 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3078 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3080 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3081 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3082 hence the user doesn't need this explicit call.
3083 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3084 i.e. LoadElements() call removed.
3085 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3086 - src/Makefile.am declares the proper flag for g++.
3087 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3088 for adding user defined new tags.
3089 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3090 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3091 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3093 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3094 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3095 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3096 src/Makefile.am : the project should properly compile and install
3097 with the autotools, included the python wrappers part.
3098 * gdcm.spec.in : added a spec file for RPM packaging.
3100 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3101 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3103 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3104 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3105 to exported to the environement (see gdcmPython/testSuite.py
3107 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3108 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3109 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3110 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3111 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3113 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3114 * gdcmPython/__init__.py doesn't crash anymore when running in
3115 in InstallMode or PreInstallMode but with an environment given
3116 value of GDCM_DICT_PATH.
3117 * src/gdcmDictSet.[cxx/h] coding style.
3119 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3121 * src/gdcm.h general comments moved to TODO, and README
3122 * src/gdcm.h should now be seen as a user commodity (including it
3123 should suffice to fully use gdcm). It is nowhere including within
3124 any of the kernel files src/*.cxx and src/*.h.
3126 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3128 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3130 * src/gdcm*.cxx only include their corresponding include file
3131 (as opposed to gdcm.h)
3132 * gdcmPython/gdcm.i changed accordingly
3133 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3134 the autogen.sh generated "make snapshot" command to work.
3135 * autogen.sh removed history related references to crea package.
3137 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * distutilsSwigCPlusPlus.py work around some swig portability
3141 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3143 was done in a last ditch attempt to get setup.py _really_
3144 operationnal. The python/gdcmPython layaout add the advantage
3145 of hidding away the python related distutils specific files
3146 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3147 Alas, the src directory was out of scope (i.e. it's relative
3148 position to setup.py was ../src) which made things impossible to
3149 handle (see previous version of python/setup.py). Crossing fingers...
3151 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3152 * python/setup.py now works on Un*x. (harder than I thougth)
3153 * python/distutilsSwigCPlusPlus.py can now have include files
3154 among the list of sources.
3156 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3157 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3158 * modifications in MSVC projects
3160 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * As stated by the first lines of Test/ExceptionAndPython/README, it
3162 looks like we can move back to original usage of exception within
3163 src/gdcm* and hence remove the errno stuff that was introduced
3164 as a quick and dirty fixture of this problem (added to the TODO).
3165 * Doc/Doxyfile configuration file for Doxygen and corresponding
3166 README file for usage added.
3167 * Test/testWrite.cxx added. This new test comes from a split of
3168 test.cxx that is now reverted to its original purpous i.e.
3169 testing the proper parsing of a Dicom related file.
3170 testWrite.cxx concentrates on testing the IO part of gdcm.
3171 * Test/bug1.cxx (containing a bug on WIn32) added.
3172 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3173 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3174 whose purpose is to publish the content of the TagNames of the
3175 Dicom public dictionary were not accessible without an
3176 instance of class gdcmHeader.
3177 - those methods are now static methods of gdcmDictSet and hence
3178 require no instances at all to be invocated.
3179 - within gdcmDictSet this change required to change some method
3180 to class methods (i.e. are now static) among which SetDictPath
3181 (renamed to BuildDictPath) and LoadDefaultPubDict.
3182 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3183 the above changes by calling the new method classes of gdcmDictSet.
3184 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3185 the above to be effective.
3186 * python/gdcmPython: in order to wrap properly the above changes
3187 for Python, swig version now needs to be > 1.3.17.
3188 * python/gdcmPython/Makefile fixed to adapt itself to new
3189 configure/make shema introduced by Johan Montagnat (thanks for the
3190 contribution). Alas this Makefile cannot be turned into a proper
3191 Makefile.am without some heavy changes in the configure.in
3192 (for python dectection).
3193 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3194 now avoids publishing the empty entries.
3196 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3197 * python/setup.py : bug fix concerning install under windows
3198 ExtraPath reused :-P
3199 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3201 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3202 * Dicts/dicomV3.dic : remove double spaces !!!
3203 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3204 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3207 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3208 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3209 method. Doxygenation.
3210 * src/gdcm.h clean up of JPR spurious comments.
3212 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3213 * python/distutilsSwigCPlusPlus.py now properly collects the
3214 shadow classes generated by "swig -c++" (gdcm.py in our case)
3215 when using "python setup.py install".
3216 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3217 reexports the working classes.
3218 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3219 by the classical C errno scheme. This is to prevent an obscure
3220 behavior of the python wrappers when importing wxPython.wx prior
3221 to gdcmPython (which ended up in an abort call). An illustration
3222 of this oddity can be found in the Test/ExceptionAndPython
3223 subdir (see the README file). This problem probably due to
3224 an combination of g++ and dynamic loading.
3225 * added Test/ExceptionAndPython (see above)
3227 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * Changed the layout of the python part to avoid bloating main
3229 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3230 i.e. the distutils arsenal. All the python related stuff is
3231 again in a python subdir, but the package itself is now in
3233 * setup.py was cleaned up:
3234 - pythonIncludePath removed
3235 - python setup.py bdist target is now functional.
3236 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3237 collision with other packages). gdcmPython/demo/*.py changed
3240 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3241 * python subdir moved to gdcmPython (preparation of distutils packaging).
3242 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3243 distutils installer is operational.
3244 * - gdcmPython/__init__.py now properly loads the swig generated
3245 shadow classes (from gdcm.py).
3246 - gdcmPython/demo/*.py changed to import the package gdcmPython
3247 instead of gdcmPython/demo/load.py.
3248 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3250 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3251 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3252 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3253 entries within the associated public Dicom dictionary resp. the same
3254 information but sorted by the fourth field (PAT, IMG, DIR) of the
3256 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3257 are now in the "???" group.
3258 - python/gdcm.i changed accordingly,
3259 - python/demo/printGroupedPublicDict.py added, that gives an example
3260 of the above new functionalities in Python.
3262 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * src/gdcm.h, gdcmHeader.cxx:
3264 - historic references to glib's g_malloc and g_free (#defined)
3265 were definitively removed.
3266 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3267 * src/gdcmElValSet.cxx:
3268 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3269 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3270 - GetElValue(string) renamed to GetElValueByName.
3271 - Added GetElementByName(string).
3272 * src/gdcmHeader.cxx: added
3273 - GetPubElValRepByNumber(guint16, guint16)
3274 - GetPubElValRepByName(string)
3275 - GetShaElValRepByNumber(guint16, guint16)
3276 - GetShaElValRepByName(string)
3277 - GetShaElValByNumber(guint16, guint16)
3278 - GetShaElValRepByName(string)
3279 - GetElValRepByNumber(guint16, guint16)
3280 - GetElValRepByName(string)
3281 - GetElValByNumber(guint16, guint16)
3282 - GetElValRepByName(string)
3283 * Doc/requirements.txt added.
3285 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * Test/Makefile building now depends on the one of libgdcm.so
3287 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3288 pixel data) aware which enables finding the address (offset) of
3289 the pixel data of JPEG encoded DICOM files. This leaves only a single
3290 file in the testSuite whose pixel data address (offset) is unknown.
3291 * python/testSuite.py changed accordingly.
3293 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3294 * VC++ has some strong limitations when working with the STL, as stated
3295 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3296 "Also note that some STL containers (map, set, queue, list, deque)
3297 cannot be exported. [...]
3298 Some STL classes contain nested classes. These classes can not
3300 This is caused by a designed limitation that once a template
3301 class is instantiated, it can not be re-instantiated and
3303 Since our usage of map<> is ubiquitous in gdcm, this "designed
3304 limitation" of VC++ is a pitfall.
3305 Hence the Python wrappers of gdcm cannot be incrementally linked
3306 against the c++ dynamic library. The dirty but only workaround is
3307 to forget about incremental link of dynamic libraries and to generate
3308 the Python wrappers library with the inclusions of the underlying C++
3310 The following modifications concern this matter on Win32/VC++:
3311 - wrapping python correct with standalone wrapped dll (don't use separate
3312 dll under windows !!!!)
3313 - python21_d debug mode enabled (ask Frog how to use it :-)
3314 - NO problem with having an STL member of class for example string in C++
3315 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3316 - Python test of dcmlib in Python is ok under windows on a large set
3318 * removed glib references
3319 * typedef's inserted in gdcm.i for correct swig type management
3321 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3322 * python/demo/*.py load.py extracted from test.py. Added explore.py
3323 that only displays required tags and testAll.py that parses all
3324 the files of the testsuite without using unittest.
3325 * python/testSuite.py other additional test on new files added.
3326 * Data/* new test files added accordingly to the testSuite.
3327 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3328 the vr in the file differs from the one of the dictionary.
3330 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3332 values, but limits itself to values which are below a user specified
3333 size (by default 1024 bytes).
3334 * python/gdcm.i : elements not loaded (because their size is above the
3335 user specified treshold) are exported with their TagKey as key of the
3336 python dictionary. This enables the testsuite to make some checks
3337 on the unloaded elements (since we have their offset and size).
3338 * python/testSuite.py
3339 - now tests for the existence and proper value of the pixel data
3340 - two new examples added.
3341 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3343 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3345 aware. See the strategy comments in gdcmHeader::FindLength().
3346 * Test/test.cxx now accepts a filename as first argument.
3347 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3348 * python/testSuite.py changed to integrate test on above files.
3350 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3351 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3352 the vr was also RET.
3353 * python/testSuite.py more tests added.
3355 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3356 * python/testSuite.py unittest test suite added (uses Data)
3357 * Data/* dcm and acr files for the test suite.
3358 * glib dependance removed from un*x version. We now use ISO C99
3359 7.18 Integer types (see stdint.h)
3360 - python/Makefile, src/Makefile src/gdcm.h
3361 * src/ when an explicit vr (like dicom files) suddenly poped an
3362 implicit element we use to mark the underlying DictEntry of the
3363 concerned ElValue with "Implicit". This strategy was damageable
3364 too the public or provite dictionaries, since some of their vr
3365 would be changed. Since Header::FindLength heavily relies on the
3366 detection by Header::FindVR of falsely explicit elements, I
3367 added an extra ImplicitVr member to ElValue (boolean).
3368 The rest of the changes we the necessary adaptations.
3370 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3371 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3373 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3375 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3376 * Adaptation for porting to VC++:
3378 o forced to use std namespace (for string to be known)
3379 o all class use __declspec export style on WIN32
3380 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3381 (in stdlib.h on Win32 but in std:: for gcc)
3382 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3383 variable GDCM_DICT_PATH.
3384 * src/gdcmHeader.cxx verbose comments made discrete.
3386 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3387 * python/gdcm.i: added a typemap that converts a C++ hashing table
3388 to native Python dictionary.
3389 * python/demo/test.py:
3390 - now uses the native dictionary for exploration of gdcmHeader.
3391 - takes an optional filename argument (the file to parse).
3392 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3393 PubElVals hashing table.
3394 * Dicts/dicomV3.dic removed error prone trailing spaces.
3396 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3397 * Python wrapping process moved away from src/Makefile to
3398 newly created python/Makefile (as well as gdcm.i)
3399 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3400 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3401 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3402 from the environement variable GDCM_DICT_PATH (when existing).
3403 * src/gdcmDict::GetTag bug fix.
3405 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3406 * Straightforward temporary fixes for swig to build the python wrappers.
3407 src/Makefile now has a python working entry [by working we mean
3408 that we can import the shadow classes without errors].
3410 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3411 * hashtest.cxx removed (since already in Test)
3412 * src/gdcmlib.h renamed to src/gdcm.h
3413 * src/dcm.i renamed to src/gdcm.i
3414 * src/Makefile prepared for python wrapping
3416 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3417 * src/gdcmHeader.cxx :
3418 - Parsing of header is now separated from loading of element values
3419 (see gdcmHeader::LoadElements).
3420 - general clean up of hopefully all file access (creation of
3421 ReadInt16 and ReadInt32)
3423 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3424 * src/gdcmHeader.cxx :
3425 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3427 - SetLgrElem renamed to SetLength
3428 - GetLgrElem renamed to GetLength
3429 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3430 * src/gdcmElValSet.cxx fixed both GetElValue methods
3431 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3432 due to IdoDude was cleaned out.
3434 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3435 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3436 concentrates on finding the value representation (when it exists).
3437 RecupLgr now only finds the element value length, and it avoids
3438 returning the unecessary skL (skipped length).
3439 Also, offsetCourant was simply removed (with taille_fich) since
3440 it was redundant with the File position internals (by using
3441 ftell and fseek). This also made skL (see above in RecupLgr) usage
3443 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3444 on the libido specificities which are handled through class
3446 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3449 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3450 * Truckload of changes. Parsing of header is barely functional
3451 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3453 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3454 * src/gdcmHeader.cxx many addons of low level methods
3456 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3457 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3458 and _IdDcmSWAP_LONG.
3460 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3461 * This corresponds to all the changes decided at the meeting of
3462 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob