1 Sun Jul 3 14:42:04 2005 by jpr
3 Should avoid some troubles with 'no length' SQItems within 'true length'
5 Thx to Loic Boussel for providing data to fix the bug.
7 Sun Jul 3 14:47:23 2005 by jpr
11 Fri Jul 1 13:25:51 2005 by jpr
12 gdcmPixelReadConvert.cxx
13 Initialize RLEInfo and JPEGInfo to 0 a avoid further problems
14 (e.g. PrintFile on a DICOMDIR document)
16 Thu Jun 30 16:49:02 2005 by jpr
18 Enhance gdcm::File::IsReable() heuristics to be able to process some Loic
19 Boussel's Hall of Shame Dicom images
21 Wed Jun 29 17:58:33 2005 by jpr
23 Add the NO_SHADOWSEQ load mode
25 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
26 * Quite a few new dictionaries were added in gdcm. The file:
27 gdcm/Dict/README should always explain were the info was found
28 (in case of double check). Also some dict are still only
29 express as 'template' (they contain 'xx'), therefore
30 a python script should be run first to generate a full dict.
31 In the longer term this python script should be replaced by
34 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * dicomV3.dic is deprecated in favor of gdcm.dic
36 There is now a dictionary per family:
37 - dicomV3.dic -> DICOM V3
38 - Papyrus.dic -> Papyrus
39 - NIH.dic -> tas that were never allowed in the main standart
41 Fri Jun 24 12:50:20 2005 CEST by jpr
43 Pixel Spacing related problems : update comments.
44 Thx to D. Clunie for providing data to check the code
46 Fri Jun 24 12:55:58 2005 by jpr
47 Summer nights are really too hot to sleep.
48 Coding style : kosherization of all the 'if's (300 amongst 900 were haram)
50 Thu Jun 23 11:20:23 2005 by jpr
52 Extend warning message, for debugging purpose
54 Wed Jun 22 10:11:23 2005 by jpr
58 Wed Jun 22 10:00:29 2005 by jpr
59 gdcmPixelReadConvert.cxx
60 Fix misstyping, while removing spurious \t characters
62 Wed Jun 22 09:52:32 2005 by jpr
63 gdcmPixelReadConvert.cxx
64 Some constructors (at least one ...) use BitsAllocated =! BitsStored for
66 That break at lot of viewers ...
67 We now *propagate the sign bit* upon the unused ones, better than masking them
69 Thx to Luca Picello for profiding data to fix the bug
71 Wed Jun 22 09:53:52 2005 by jpr
73 gdcm images are now "GDCM 1.1" built.
75 Mon Jun 20 19:10:17 2005 by jpr
77 Avoid re writing Palette Color Lookup Table UID when Palette Color is removed
79 Mon Jun 20 17:58:53 2005 by jpr
81 Preventive bug fix for LUT Data.
82 I said : LUT Date, *not* Palette Color
84 Sun Jun 19 17:57:29 2005 by jpr
86 To avoid warnings at compile time
88 Fri Jun 17 14:27:52 2005 by jpr
92 Fri Jun 17 14:36:07 2005 by jpr
96 Fri Jun 17 14:35:00 2005 by jpr
98 Add some accessors for debugging purpose
100 Tue Jun 14 15:56:41 2005 by jpr
101 gdcmPixelReadConvert.cxx
102 Now gdcm deals with 16 bits per pixel images with 16 bits Palette colors
103 (3 * 65536 short int ...)
105 "Segmented Palettes" pb still pending, but I never saw any viewer dealing with it.
107 Mon Jun 13 17:43:48 2005 by jpr
108 gdcmPixelReadConvert.cxx
109 Some more oddities dealt with.
110 Doesn't work yet with 65536 entries 16 Bits LUT (?!?), with 16 bits pixels.
111 Still looking for accurate info on the web about it
114 Fri Jun 10 16:05:38 2005 by jpr
116 Bug fix in Load method.
117 Thx to Benoit for providing fix.
118 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
120 lantency with the Util::Format function
122 Tue Jun 7 15:48:35 2005 by jpr
124 The highy time consuming method GetMacAdress is now called just once
126 Tue Jun 7 11:58:29 2005 by jpr
127 gdcmDicomDirElement.cxx
128 Use TranslateToKey better than Format
130 Tue Jun 7 12:07:20 by jpr
132 Remove some spurious calls to Format
133 // according to 'Purify', TranslateToKey is one of the most
134 // time consuming methods.
135 // Let's try to shorten it !
137 Mon Jun 6 14:37:58 2005
138 class ArgMgr (for Arguments Manager) is designed for
139 command line arguments management
140 (to make programmer's live easier)
141 (could be used for any kind of 'command line program')
143 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
144 * Adding users file in CVSROOT for mail blaming
146 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
147 * Adding potential support for JPEG-LS DICOM files.
149 Fri Jun 3 18:05:23 2005 by jpr
151 Fix VR processing, to be CP-288 conform.
152 Now we can parse any kind of DICOM SR.
154 Fri Jun 3 11:05:15 2005 by jpr
158 Thu Jun 2 15:42:18 2005 by jpr
160 Add warning about Load Mode
162 Thu Jun 2 16:20:14 2005 by jpr
164 Harden gdcm::File::IsReadable(), in order not to be confused any longer
165 by lost of Pixel Element
167 Fri May 27 12:51:00 2005 by jpr
169 To avoid pushing out twice the meta elements, wile trying to write 'ACR-NEMA-
171 And avoid some memry leaks -hope so-
173 Wed May 25 14:54:17 2005 by jpr
175 Should avoid some memory leaks
177 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
178 * Adding potential support for mpeg and jpeg2000 through two new lin
179 - JasPer for JPEG2000
180 - libmpeg2 from the MPEG consortium
181 Also adding intial work to use this lib.
183 Fri May 20 10:27:55 2005 by jpr
186 (this time, it's wasn't dangerous at run time)
188 Thu May 19 17:31:21 2005 by jpr
190 FIX possible troubles when checking
191 'Hight Bit Position' vs 'Bits Allocated' and 'Bits Stored'
192 Thx to Mathieu for reporting bug
194 Wed May 18 12:12:07 2005 by jpr
196 Fix : now dcm deals with 'No preamble', Big Endian Explicit VR group 0002.
197 Thx to Dennis Hu for providing a sample image to fix the bug.
199 Tue May 17 14:44:09 2005 by jpr
201 ENH : According to David Clunie's advice, we check now 'Imager Pixel Spacing'
202 before 'Pixel Spacing', when we want to get X or Y Spacing.
204 Tue May 17 19:10:49 2005 by jpr
206 ENH : Now, FileHelper::CheckMandatoryElements() makes some consistency checking,
207 at LTTG (Least Time To Go)
208 around Bits Allocated, Bits Stored, High Bit Position,
209 to avoid unaware user to mess up the stuff.
211 Tue May 3 11:43:04 2005 by jpr
213 Load returns now a bool (allow user not to call IsReadable() )
215 Tue May 3 11:51:06 2005by jpr
217 Now the gdcm::File remains unimpaired after writting, in any case
219 Fri Apr 29 17:10:55 2005by jpr
221 Don't abort the prog when File not open
223 Wed Apr 27 12:00:35 2005 by jpr
225 Removal of now useless lut-related stuff
227 Wed Apr 27 11:52:27 2005 by jpr
229 Pb of 'Bits Allocated = 12' is now dealt with in
230 FileHelper::CheckMandatoryElements, no longer in File::Write.
231 Thx to Mathieu for reporting bug.
232 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
236 Tue Apr 26 18:18:23 2005 by jpr
238 Should leave gdcm::Document constructor in a much quicker
239 and much cleaner way when anything wrong occurs.
241 Tue Apr 26 18:25:49 2005 by jpr
242 gdcmPixelReadConvert.cxx
243 Prepare MPEG Dicom encapsulated processing (within a loooong future)
245 Fri Apr 22 14:59:58 2005 by jpr
247 Modify Print() output
249 Fri Apr 22 15:37:57 2005 by jpr
251 Prepare (future) MPEG integration
253 Thu Apr 21 09:40:00 2005 by jpr
255 Taking into account Dicom MPEG
257 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
259 But this is a case where we should really signify the user there is
260 few chance the serie is really a serie...
262 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * FIX : on X, the python part is correctly installed. All files are
264 installed in gdcm sub-directory
266 Tue Apr 19 11:58:19 2005 by jpr
268 Should suppress some warnings from Borland compiler
270 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * Builder/ : add something to facilitate the RPM creation of gdcm
273 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
274 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
276 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
278 Thu Apr 14 16:26:19 2005 by jpr
280 Now, user can ask gdcm::DicomDir to skip SeqEntries or shadow groups, when
282 // Old style (still available) :
283 dcmdir = new gdcm::DicomDir(dirName, true);
285 // new style (user is allowed no to load Sequences an/or Shadow Groups)
286 dcmdir = new gdcm::DicomDir( );
287 dcmdir->SetParseDir(true);
288 dcmdir->SetLoadMode(NO_SEQ | NO_SHADOW);
289 dcmdir->Load(dirName);
291 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
292 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
294 * Fix compilation on gcc 2.96 (which does not have ios::failure)
296 Mon Apr 4 17:15:24 2005 by jpr
298 Fix stupid bug when writting ACR-NEMA image from 'ACR-LibIDO' one.
300 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
302 and it's representation name (for the NIH)
304 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
306 conversion of YBR to RGB pixels. So, now, the conversion is made using
309 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
310 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
311 format) to replace 'at-run' dicom files generated by the
312 TestAllReadCompareDicom test
314 Tue Mar 22 12:29:37 2005 by jpr
316 * FIX : element 0x0000 of shadow groups is now force to a ValEntry,
317 and it's VR is forced to UL
318 * ENH : user id now allowed to tell he doesn't want to deal with Sequences
319 and/or with Shadow groups
320 use SetLoadMode (NO_SEQ | NO-SHADOW);
322 Tue Mar 22 12:40:13 2005 by jpr
324 *FIX Restore pushed out elements
326 Fri Mar 11 12:08:31 2005 by jpr
328 Remove spurious #define MAX_SIZE_PRINT_ELEMENT_VALUE
330 Fri Mar 11 12:12:13 2005 by jpr
332 Final removal of gdcmFileHelper::InitializeDefaultFile();
334 Wed Mar 9 20:29:38 2005 by jpr
336 Add Anonymize method (not yet fully checked)
338 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
341 Wed Mar 2 18:18:32 2005by jpr
343 Fix gdcm::FileHelper::CheckMandatoryElements() to take into account David
346 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
349 Mon Feb 21 18:45:41 2005 by jpr
351 * Replace method CheckMetaElements by CheckManadatoryElements
352 To deal with the pb of UID's, and with Type 1 an Type 2 Entries
353 (probabely some stuff still missing)
354 * We shall have to decide the way we proceed to allow user 'freeze' Serie UID
355 between a given call and the next one (to add images to a Serie he just
357 * We shall have to decide the way we proceed to allow user 'freeze' Study UID
358 between a given call and the next one, or to reuse an already existing
359 Study UID (i he wants to add his own Series to an already existing Study)
361 Thu Feb 17 17:18:33 2005 by jpr
363 To avoid further pb, Initialize defaults now Photochromatic Interpretation to
364 MONOCHROME2 (low values = dark), better than MONOCHRONE1.
365 Thx to Benoit for reporting bug
367 Thu Feb 17 11:56:20 2005 by jpr
369 Prepare FileMetaInformationVersion (group 0002) management
371 Thu Feb 17 12:02:47 2005 by jpr
373 Group 0002 management
375 Thu Feb 17 12:03:32 2005 by jpr
376 gdcmDocEntryArchive.cxx
379 Wed Feb 16 11:19:19 2005 CET by jpr
380 gdcmPixelReadConvert.cxx
381 Taking into account MONOCHROME1 + Signed Pixels (?!)
383 Tue Feb 15 19:12:34 2005 by jpr
385 Taking into account the difference between MONOCHROME1 (low values = bright)
386 and MONOCHROME2 (low values = dark)
388 Mon Feb 14 11:45:04 2005by jpr
390 Remove some useless mask operations, to save CPU time
392 Mon Feb 14 15:51:10 2005 by jpr
394 *never* forget to re-compile just *before* committing!
396 Mon Feb 14 15:34:27 2005 by jpr
398 First commit on the post 1.0 (Version? / Tag? / Branch?) :
401 Mon Feb 14 11:45:47 2005 by jpr
403 remove useless comments
405 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * Testing/TestMAkeIcon.cxx : complete the test
408 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memory leaks
411 Fri Feb 11 16:22:18 2005 by jpr
413 Typo, comments, doxygenation
415 Thu Feb 10 11:55:26 2005 by jpr
417 AnonymizeNoLoad improvement
419 Thu Feb 10 10:07:19 2005 by jpr
421 Duplicate Matthieu's hack to prevent bombing in Anonymize
423 Thu Feb 10 12:20:34 2005by jpr
425 The following gdcm::DocEntrySet methods, no re-definable is child classes are no
427 virtual ValEntry *GetValEntry(uint16_t group, uint16_t elem);
428 virtual BinEntry *GetBinEntry(uint16_t group, uint16_t elem);
429 virtual SeqEntry *GetSeqEntry(uint16_t group, uint16_t elem);
430 virtual bool SetValEntry(std::string const &content,
431 virtual bool SetBinEntry(uint8_t *content, int lgth,
432 virtual bool SetValEntry(std::string const &content, ValEntry *entry);
433 virtual bool SetBinEntry(uint8_t *content, int lgth, BinEntry *entry);
434 virtual ValEntry *InsertValEntry(std::string const &value,
435 virtual BinEntry *InsertBinEntry(uint8_t *binArea, int lgth,
436 virtual SeqEntry *InsertSeqEntry(uint16_t group, uint16_t elem);
438 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
442 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
445 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
446 * Test/ : accelerate tests (it's not very significant accelerations).
447 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
449 Mon Feb 7 15:48:34 2005 by jpr
451 Add some commented out lines to prepare future version of 'Full DICOMDIR' stuff
454 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * Testing/TestSequence.cxx : add test for sequences of images... test that
456 we have the same serie or the same study UID
458 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
461 * src/gdcmDict.h : remove commented code
462 * src/gdcmDocument.cxx : initialize values
463 * src/gdcmFile.cxx : bug fix when reading values
464 * gdcmPython/demo/ : change file names. Remove useless files
466 Sun Feb 6 15:31:09 2005 by jpr
468 Update comments for DicomDir stuff
470 Sun Feb 6 15:39:35 2005 by jpr
472 * Add method File::AnonymizeNoLoad, to allow anomymizing files
473 even when the pixels are not gdcm Readable
474 * Add methods File::AddAnonymizeElement and File::ClearAnonymizeList
475 to allow user to choose the elements whose value
476 he wants to white out / replace
478 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
479 * src/gdcmFile.cxx : remove the default array of initialization.
480 The static array contained pointers to non-static values (comming from
481 strings). To have coherences, when creating files, these values can't be
482 static. So, the array can't be static, too ! To simplify, the array have
483 been replaced by repeted lines to insert values in the File
485 Fri Feb 4 15:49:01 2005 by jpr
487 * Add GetFirstValEntry + GetNextValEntry, for Python users
488 * Some more Doxygenation + typo fixing
490 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
492 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
494 Thu Feb 3 18:12:46 2005 by jpr
495 gdcmPixelReadConvert.cxx
498 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
499 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
500 (Dicom Element) into the Sequence Item
502 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/*.cxx : first parss to normalize file organisation
505 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
506 * src/gdcmDirList.[h|cxx] : add method to find a directory
507 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
509 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
510 * Finish cleaning up my JPEG mess. Should be ok now.
511 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
512 contained within the RLE* class(doh!)
514 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
515 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
516 * SerieHeader::AddFileName() creates as many Coherent Files lists
517 (same Serie UID) as it founds different Serie UID
518 amongst the files instead of discarting any file
519 that doesn't match with the first one he found.
520 * SerieHeader::OrderGdcmFileList has now one parameter :
521 the Coherent Files list the user wants to sort
522 * SerieHeader::GetFirstCoherentFileList() |
523 * SerieHeader::GetLastCoherentFileList() | allow to parse
524 the set of Coherent Files lists
525 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
526 compatibility (it returns the *first* Coherent Files list,
527 since there was only one before)
528 * Test/TestSerieHeader gets gdcmData as a default root directory
530 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * Remove friend between DocEntry and File classes
532 * Remove friend between PixelReadConverter and RLEFramesInfo,
535 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
537 0002|0000. The value was incorrect.
539 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
542 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmUtil.cxx : compilation fix on Win32
544 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
545 variable, to be easy found. Add methods to change the default UID.
546 Amelioration of the CreateUniqueUID to use the correct default UID.
547 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
550 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
551 * Test/TestVR.cxx : fix memory leaks
553 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 * Rewrite the base 256 to base 10 conversion, using string operation only.
555 This allows us to get rid of the problematic 64bits integer type (does not
556 always exist on target platform).
558 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
559 * Add construct and destructor to class gdcm::Debug to close the debug file
561 * Don't let uset to open twice the same file
562 * gdcm has now an official UID prefix,
563 supplied by http://www.medicalconnections.co.uk
564 1.2.826.0.1.3680043.2.1143
565 (Thx to Mathieu for providing URL)
566 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
567 to be able to perform some more tests
568 * gdcm::ContentEntry : Contructors and Destructor are now protected,
569 in order to be sure no user will try to use them.
570 (at user level, only the children classes are meaningfull)
572 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * move RLEInfo & JPEGInfo from Document to File
575 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * FIX : remove so many friend between classes
578 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
579 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
580 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
582 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
583 In order to avoid missbehaviour :
584 . gdcm::DocEntry is now specialized in
585 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
586 - gdcm::ContentEntry (Dicom entry with a 'content')
587 . gdcm::ContentEntry is specialized in
588 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
589 characters value, or integers)
590 - gdcm::BinEntry (Dicom entry with a non strig representable value
591 (user hasn't any longer to thing about the precedence of his dynamic_casts)
593 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
594 * Test/VTKTest*.cxx : bug fix under linux
596 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
598 use with python. Some methods are moved from Document to ElementSet or
599 DocEntrySet. The equivalent methods to ElementSet have been added to
600 SQItem and are virtual in DocEntrySet. Methods that may have the same code
601 in SQItem and ElementSet is directly placed in DocEntrySet
603 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
604 * Test/VTKTest*.cxx : remove the show variable in each test method because
605 it's useless (the viewer variable replace this variable)
607 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * src/gdcmDocument.cxx : bug fix on potential memory leak
609 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
610 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
611 Add ClearXxx methods to remove all the content of the list or map
612 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
614 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
615 * methods ReplaceOrCreate renamed as Insert
616 (nobody will be any longer confused by 'CreateOrReplace')
618 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
619 * Grealty simplify the JPEg decompression, no need to differenciate based on
620 the JPEG possible type (with/without fragment, with/without multiple frame).
621 Everything is done throught the JPEG IO Suspension mechanism in IJG
623 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
624 * Stage 3 of normalization :
625 in order to avoid any missunderstanding while reading method names :
626 - All the methods xxxEntry now deal with dicom Entries
627 - Methods GetEntry splitted into
630 - Method SetEntry renamed as SetEntryValue
631 - Method SetEntryBinArea let as it was
633 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
634 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
635 - Position correctly the entry points for JPEG2000 and JPEG-LS
636 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
638 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
640 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
641 with other method names
642 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
643 * Test/TestDicomDirElement.cxx : add new test
645 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
646 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
647 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
648 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
649 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
650 So can't you use __int64 in ostream at all.
652 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
653 * bug fix for compilation on MSVC6
654 * gdcmPython/gdcm.i : rename of classes missed
656 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
657 * Stage 2 of names normalization :
658 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
659 (easy to understand ...)
660 - gdcm::FileHelper replaces old class gdcm::File
662 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
664 type and not a string. So, there remove problems on the format of the
667 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
668 * Add Example/TestPapyrus.cxx
669 - reads a Papyrus file (gdcm::Header compliant),
670 - gets the pixels of all the images, using low level iterators
671 - writes an multiframes Dicom image.
672 (Just to show it's *possible* to do that)
673 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
676 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
678 Thus, DicomDirXXX are created with a flad that indicates if the created
679 object is empty or not (when not empty, the DicomDirElement is used to
682 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
683 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
684 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
686 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
687 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
689 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
690 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
691 Remove all access to the hash-tables or lists in the objects.
693 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
695 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
696 be complient with all the gdcm source code
698 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
699 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
702 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
706 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
707 * Test/ : rename VTK tests to have a best name for the tests
708 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
709 GetFirstEntry/GetNextEntry use
711 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
712 * In SerieHeader::ImagePositionPatientOrdering()
713 // a Dicom 'Serie' may contain scout views
714 // and images may have differents directions.
715 // -> More than one may have the same 'pos'
716 // Sorting has then NO meaning !
717 Thx to Eduardo Davila for reporting bug.
719 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
720 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
721 test. Now it's on image content and not on the resulting visualisation...
722 might solve the problem on linux when using the OpenGL drivers
724 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
725 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
726 DicomDirSerie, DicomDirImage
727 Dict, DictSet classes :
728 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
729 -remove InitTraversal method.
730 * UPD Test programs + Example programs
732 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
733 * remove useless and never updated keyword \ingroup
734 * Solve pb when structure (list, map, ...) is empty.
735 Thx to Benoit for reporting bug
737 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
738 * Taking into account of 'Transfer Syntax' value
739 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
742 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
743 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
744 is no memory access violation
745 * gdcmPython/demo : add python demos using VTK
747 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
748 * FIX 'Dictionnary' is now spelt 'Dictionary'
749 'wether' is now spelt 'whether'
750 'archieve' is now spelt 'archive' ;-)
752 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
753 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
754 related methods, in order not to expose internal mechanisms
757 * REM methods that exposed internal mechanisms :
758 DicomDir::GetDicomDirPatients()
759 DicomDirPatient::GetDicomDirStudies()
760 DicomDirStudy::GetDicomDirSeries()
761 DicomDirSerie::GetDicomDirImages()
762 * UPD Test programs :
766 * UPD Example program
768 * ADD DictSet methods
772 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
773 * Removed the Print/indent/default parameter mess. There is absolutely no
774 reason to have to methods, moreover with the second taking the ostream as
775 *SECOND* parameter. This was clearly a bad hack to get things compile.
777 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
778 * Complete rewrite of the GetMacAddress code. Now the code is *much*
779 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
780 Unfortunately the main code does not work on SunOS, thus provide a specific
781 code for this platform only (and Win32 of course). Since this seems to be
782 working, change CreateUniqueUID to use GetMACAddress instead of the
783 problematic GctestetIPAddress
785 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
786 * Unfortunately to be able to test gdcmDirList I had to break the API
787 a little. Now the class is not a std::list anymore but has a member
788 std::vector (more ITK compatible). Allow unit testing on Win32 and
791 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
792 * Update SerieHeader to take into account a Serie Instance UID to properly
795 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
796 * ENH - Comment out Mathieu's (dangerous) Super Hack
797 for dealing with BIGENDIAN processors
798 - Move equivalent stuff to BinEntry::WriteContent
799 When necessary, 16 Bits Pixels are swapped in a small buffer
800 and then written. This avoid allocating a huge buffer, in
801 PixelWriteConvertor, and avoid modifying the Pixel Area.
803 Probabely, the same operation will have to be done when we want
804 to write image with Big Endian Transfert Syntax,
805 and we are working on Little Endian Processor
807 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
808 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
810 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
811 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
812 all the dict content.
813 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
815 * Test/TestDict.cxx : add a new test for the dict classes
817 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
818 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
819 file. Debug is yanked if compiled with NDEBUG
821 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmDictSet.h : set the default output to the os variable
823 * src/gdcmDictEntry.[h|cxx] : add the Print method
824 * gdcmPython/demo/ : add a new test
826 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
827 * merging of Test/PrintDicomDir and Test/TestDicomDir
828 * removal of now redundant Test/PrintDicomDir
829 * enhancement of Example/PrintDicomDir
831 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
832 * Now, python test might work on systems
833 * Add the PrintDicomDir test
835 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
836 * FIX : First entry following group 0002 was lost for
837 Explicit Big Endian Transfer Syntax files
838 (group and elem not swaped)
840 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
841 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
842 Big Endian Transfer Syntax supposed the group following 0002
843 begins always by element 0000 (element 0000 is *optional*)
844 To avoid further troubles, let's be pessimistic, and use
845 Document::HandleOutOfGroup0002() method
846 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
847 (related pb not yet solved)
849 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * Bug fix for the python part use
851 * Now, PrintHeader.py pass... but outside the ctest use. shit !
853 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
854 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
856 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
857 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
858 a string and should ask the global TS dict what are the propreties of
861 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
862 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
863 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
864 to swap the Swap Code, at parsing time, when we come out of group 0002
865 and Transfer Syntax is Big Endian
866 We should be able to read now 'true DICOM" Big Endian coded images
867 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
868 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
870 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
871 * Hopefully fix the bug on MacOSX and static global initialization.
872 This is the only -minor- patch I found that both please MacOSX and VS6.
873 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
874 but this would require a lot of change. Another approach would be that Global
875 create those string and GDCM_UNFOUND becomes a pointer to a string (which
876 gdcm::Global would destroy at exit).
878 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
879 * Fix bug on MacOSX with static initialization in a multy threaded
880 environment. static const string in a header file used to be ill
881 initialized provoquing the freeze of any tests. patch should solve this
884 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
885 * According to Benoit's suggestion, and without any objection from anybody
886 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
887 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
888 - method gdcmDicomDirObject::GetEntry() renamed as
889 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
891 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
893 you debug/warning message just as c++ streams which make them very convinient
894 to use. Once this is stabilize I will change the ostringstrem to be
895 redirected to a file (ofstream).
896 * Properly support C99 extension: __FUNCTION__ which allow us to display
897 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
899 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
900 * Removal of useless and dangerous methods :
901 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
902 GetDocEntryByName, GetEntryByName, GetDictEntryByName
903 * Removal of usless methods :
904 Dict::PrintByName, Dict::GetDictEntryByName
905 * Commenting out of probabely useless methods :
906 Dict::GetDictEntryNames()
907 Dict::GetDictEntryNamesByCategory()
908 DictSet::GetPubDictEntryNames()
909 DictSet::GetPubDictEntryNamesByCategory()
910 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
911 * ENH : Use dicomTS.dic as described in 2004 version
912 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
913 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
914 Add Accessors on VM (Value Multiplicity), and VM related methods
915 * ADD : Add a list of 'Dicom Attribute types', as found in
916 http://medical.nema.org/dicom/2004/04_15PU.PDF
918 * ADD : Add dicomGroupNameAbbreviations.dic
919 should be used to write a method to replace the former
920 Dict::GetDictEntryNamesByCategory()
922 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
923 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
924 to read in the file... and only it ! Length is the efective length of the
925 data in the DocEntry structure
927 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
929 And now use a static function call instead, with a global variable. i
930 This is much closer to the VTK approach. Hopefully should be bulletproof
931 and easier to use...hopefully
933 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
934 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
936 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
937 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
939 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
940 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
941 ValEntry, BinEntry, SeqEntry creation or replace
943 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
944 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
945 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
947 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
948 when specifying the VR
949 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
950 * src/gdcmDocEntry.cxx : amelioration of print
952 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
953 * ADD : Add the method Util::IsCurrentProcessorBigEndian
954 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
955 * ADD Method Document::ComputeGroupLength
956 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
957 in order to allow further VR modification by user
958 * REM : removal of once-called method File::WriteBase
959 integration of its code in formerly one-line method File::Write
961 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
962 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
963 replace the different values "??", "Unkn", "Unknown".
964 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
965 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
966 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
967 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
969 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
970 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
972 * Set the gdcm::Base class to some Printable classes
974 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
975 * src/gdcmFile.[h|cxx] : add the Print method
976 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
977 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
978 * src/gdcmDocument.h : remove the PrintLevel informations
979 * Example/PrintFile.cxx : use the new gdcm::File::Print
981 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
982 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
983 problems when compiling with the python wrapping
985 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
986 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
987 writting in ImplicitVR
989 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
990 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
991 JPEG decompression, especially when dicom frames are split into several
992 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
993 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
995 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
996 * src/gdcmHeader.cxx : change the initialisation of default header.
997 Now, this header is readable by gdm, e-film, DicomWorks
999 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
1001 Rename Decompressed to Raw
1002 * Use the API changes in gdcm::File.
1003 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
1006 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1007 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
1008 each added entry in the header. Replace the 'Planes' field by the 'Number
1011 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1012 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
1013 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
1015 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1016 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
1017 At this time, this image isn't readable by e-film... waiting JPR help to
1020 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1021 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
1022 DocEntry. Now use methods of the Document !
1024 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1025 * Test/ShowDicomSeq.cxx : bug fix
1027 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1028 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
1029 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
1030 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
1031 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
1033 * Test/TestCopyRescaleDicom.cxx : remove unused variable
1034 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
1035 containing found sequences
1037 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1038 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
1040 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
1041 Some fields in BinEntry must be copied to not seg fault when making the :
1042 gdcm::File *copy = new gdcm::File( copyH );
1043 and tests are now made on good variables
1045 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1046 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
1047 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
1049 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
1050 * Add vtkGdcmWriter example and test
1052 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1053 * Test/TestUtil.cxx : reformat the source code
1054 * vtk/vtkGdcmReader.cxx : remove and change prints
1055 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
1057 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
1058 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
1060 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1061 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
1062 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
1064 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1065 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
1066 by an eof to prevent all bad read of the file... and in this case, the
1067 file isn't readable.
1069 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1070 * Example/Volume2Dicom.cxx : comment unused variables
1071 * Test/PrintDicomDir.cxx : comment unused variables
1072 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
1073 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
1074 method that is redondant with AddEntry.
1075 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
1078 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1079 * Bug fix due my last commit (compilation under Windows).
1080 * Example/Volume2Dicom : bug fix in the file and reformatting source code
1081 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
1083 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1085 - Remove printf / sprintf
1086 - include iostream AFTER gdcm so we don't get warnings
1087 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
1089 - Also remove tons of include from header files, hopefully this should
1090 speeup the compilation time, since it was becoming a dog slow.
1091 - Remove gdcm.h as it include way too many files and slow down compilation
1092 (plus it is not up to date)
1093 - remove 'using namespace std' this is BAD !
1095 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1096 * Remove memory leaks on the DicomDir
1097 * Remove some useless data in DicomDirObject
1098 * Add usefull methods in SQItem, to be complient withe the ElementSet
1100 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1101 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
1103 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1104 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
1105 future, with convertion)
1106 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
1107 and ImageDataSize values. Remove the method to get the PixelReadConverter
1108 from the output of the class
1110 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1111 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
1113 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1114 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
1115 and vtkErrorMacro use.
1116 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
1118 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1119 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
1121 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
1122 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
1123 The string leaves only in the fonction. So when we make a .c_str(), we
1124 get the pointeur on the first element, element that will be destroyed
1125 immediately after thee instruction.
1126 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
1127 file has been opened : the test must be made on the content of the
1128 pointer and not directly on the pointer !
1131 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1132 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
1133 the python part recompiles
1135 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1136 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
1137 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
1138 X session is killed (for my computer... it seems to not be identic on
1141 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1142 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
1143 avoid problems (otherwise, the difference test between the visible image
1144 and the reference is incorrect. If the reference is greater than the
1145 screen resolution, it's produce errors).
1146 Can be used for only one image. Can be used with a visible flag.
1147 * vtk/vtkGdcmReader.cxx : remove commented codes.
1148 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
1149 under windows at compilation
1150 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
1151 for grayscale images
1152 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
1154 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1155 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
1156 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
1157 tests on the image size X, Y, Z
1159 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1160 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
1161 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
1162 between the class name and the file name
1164 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1165 * src/ : fix compilation warnings for the Write method (2 different
1166 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
1167 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
1168 variable... create a static method in gdcm::Document to access to
1169 this variable content.
1171 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1172 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
1173 file, to be accessed by other files (like gdcmFile). Remove commented
1174 code. Move the change of the header to the gdcmFile, using the
1176 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
1177 To be sure of that (and simplify calls), the Write of the header now
1178 gets a file name and not a file pointer (std::ifstream).
1179 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
1180 DocEntryArchive. Remove all open of the written file
1182 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1183 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
1185 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1186 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
1187 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
1189 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
1190 some corresponding methods. Write correctly the file and check before
1192 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
1193 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
1194 is now on RGB data (as before my last commit
1195 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
1197 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1198 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
1199 Add a print information of the type of the entry
1200 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
1201 It was in the gdcmFile, and all write have been regrouped
1202 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
1203 Write correctly all dicom files (in decompressed mode only at this time)
1204 * Test/ : test on files are now made using Raw data and not color data if
1206 * Example/PrintFile.cxx : add more printings
1208 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1209 * Amelioration of code, remove some code copy. For the loading of
1210 BinEntry (in gdcmDocument), add the test to verify if the file is already
1213 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
1215 remove a DocEntry in the header (push an empty DocEntry)
1216 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
1217 lines. Bug fix in the initialization of the PixelConvert and the
1219 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
1220 use in TestCopyDicom (now this test can run under windows... but fails)
1221 * Test/TestCopyDicom.cxx : amelioration of the test :
1222 - test the pixels written
1223 - add test points to quickly find where is the error
1224 - can set a file name input and output in arguments
1225 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
1226 amelioration of the test output
1228 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1229 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
1230 all replaced DocEntry's
1231 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
1232 Now, each needed DocEntry to modify is duplicated, modified and inserted
1233 to the header using DocEntryArchive. Thus, after save, we can restore the
1234 header initial state.
1236 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1237 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
1239 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1240 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
1241 correct to copy it. The DictEntry is specified at the DocEntry creation,
1242 then, it musn't change in the time.
1243 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
1244 header correctly. At this time, the change is only made for the first
1245 level of the Document. In the future, it might consider sequences.
1246 The change is made by replacing a DocEntry by an other that is created
1247 outside the class. The old value is kept. When we restore the header
1248 status, the added DocEntry is deleted and replaced by the old value.
1249 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
1250 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
1251 set the write type to explicit VR, implicit VR or ACR. Add methods to set
1252 the write mode to native, decompressed or RGB (but not used at this time)
1254 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1255 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
1256 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
1258 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1259 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
1260 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
1262 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
1263 set because already copied when copying the BinEntry's of the header
1264 * Test/TestAllReadCompareDicom.cxx : remove warnings
1266 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1267 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
1268 Two problems appear when doing it :
1269 - with the gdcmFile : when the GetImageData method is called, the pixels
1270 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
1271 data (pixels). And each structure destruct the data when it's
1272 destructed. So we have two destructions for the same data. To solve it,
1273 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
1274 data or not. If it doesn't own data, then they will not destroyed by
1276 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
1277 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
1278 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
1279 create a double destruction of the same DocEntry's. So, to solve it,
1280 the TagHT is simply cleared and the DicomDir* elements are destroyed.
1281 * TODO : add an entry concerning memory leaks in the DicomDir
1283 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1284 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
1285 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
1288 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1289 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
1290 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
1291 after it have been deleted
1293 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * FIX: src/* fix the doxygen warnings.
1295 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
1296 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
1297 was erroneously defined with a size of 15 instead of 16. [many thanks
1298 to Jean Michel Rouet for pointing out this bug].
1300 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 1. Finish merging JMR patch for writting DICOM from scratch
1302 2. Fix -hopefully- bug with MONOCHROME and space vs null character
1303 3. Use const ref when possible
1304 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
1305 5. A few more comments
1306 6. CreateUniqueUID can now be called without parameter"
1308 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * ENH: Slightly bigger patch:
1310 1. Getting toward full integration of JMR patch for writting dicom from scratch
1311 2. Update Test to test part of this patch: CreateUniqueUID
1312 3. File was not close properly in gdcmDict
1313 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
1314 5. Use of const ref instead of copy (speed issue)
1315 6. Remove temporary (duplicate) string in TranslateToKey
1316 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
1317 8. Do not repeat virtual in subclasses
1318 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
1320 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1321 * Apply first patch toward better string comparison when dealing with broken
1322 DICOM files. Essentially the string could be padded with a space instead
1323 of a null character as defined by standard
1325 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1326 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
1327 because never used... and in the same time, that's remove some memory leaks
1329 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1330 * src/gdcmFile.cxx : now delete the PixelConvert instance.
1331 * In examples and tests : change the type of image data variables from void*
1332 to uint8_t*. Remmove all delete on image data variables
1334 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
1336 Verify the file pointer value before open the file, and if it's not null,
1337 a verbose message is generated.
1338 Close correctly the file when the file isn't considered dicom-like. The
1339 correctly close is a call to CloseFile.
1340 When closing the file pointer, test if its not null to close the file.
1341 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
1342 file. For an uncompressed image, the copied data correspond in the least
1343 case to the image size (calculated) or the image size specified in the
1344 header. A verbose is generated if these two size mismatch
1346 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1347 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
1348 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
1349 break under windows (with msvc6 compilation).
1351 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
1353 compiling with MSVC6)
1355 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * Bugs fix for the Windows build with VC6
1357 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
1358 needed (only for projects required VTK). If the VTK is included in all
1359 projects, there is conflicts with the jpeg lib of vtk when compiling the
1360 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
1361 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
1362 when compiling the gdcm_wrap.cxx file (created by the compilation of the
1364 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
1365 (like it's already made for the cout use). Otherwise, conflict with the
1368 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1369 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
1370 * gdcmPython/gdcm.i:
1371 - comments on the DicomDir::Method related usage added.
1372 - now that we use the namespace gdcm, a lot of internal classes do
1373 NOT need to be wrapped anymore.
1374 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
1375 DicomDir::Method) new example added.
1377 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1378 * Improve string manipulation. I now inforce the notion of 'DicomString'
1379 A DicomString can contain as many \0 as they want
1380 and it is *always* of even length.
1381 We only support odd length for very rare case.
1382 And in the near future this should be removed.
1384 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1385 * /binary_write/ gdcm source. Now even on big endian we are writting
1386 little endian. This should -heopfully- fix some tests
1388 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1389 * Now the dictionary is compiled into gdcm lib. This is a default
1390 behavior, thus any dic file specified is picked before failback to
1391 the one comiled into lib
1393 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1394 * Change internals for gdcmDict. Don't use any 'new' any more.
1395 This should definitely solve any leak problem, and we should be
1396 as fast as before, as long as don't modify too much the dictionary.
1398 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1399 * STYLE: ivars should start with a capital letter.
1400 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1401 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1403 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1405 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1406 new 2004 dictionaries added (thanks to JPR).
1407 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1408 * CLEANUP_ROUND (15) for gdcmPixelConvert
1409 - RLEFrame::NumberFragments is now of type unsigned int
1410 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1411 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1414 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1415 * Initial work in gathering all transfer syntax accessors. clearly
1416 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1417 ivars, but only one transfersyntax (class) ivar with equivalent method on
1420 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1421 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1422 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1423 discussed (plus I didn't like having a 2000 lines patch not commited)
1425 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1427 * CLEANUP_ROUND (14) for gdcmPixelConvert
1428 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1429 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1430 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1431 CloseFile() anymore.
1432 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1433 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1434 into File::Pixel_Data.
1436 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1437 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1438 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1439 * CLEANUP_ROUND (13) for gdcmPixelConvert
1440 Substituted File::ParsePixelData() with PixelConvert::Print() new
1442 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1443 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1444 method to those classes.
1445 - src/gdcmFile.[cxx|h]:
1446 -- Added a ::Print() method.
1447 -- PixelConverter is now a reference instead of a member.
1448 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1449 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1451 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1453 collaboration diagram and inheritance diagram should be generated with
1455 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1456 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1457 pointlessly wrapped (see
1458 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1459 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1460 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1461 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1462 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1463 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1464 -- File::Initialise: PixelConverter setup moved away to
1465 PixelConverter::GrabInformationsFromHeader()
1466 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1467 interpretation moved away to PixelConverter::BuildRGBImage()
1469 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1470 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1471 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1473 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1475 displayed on Win32 when a brutal abort() occurs (because of uncatched
1476 exception). See TODO new entry of this commit for more on this.
1477 * TODO added new entry.
1478 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1479 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1480 - HandleColor is no longer called from gdcmFile.cxx
1481 - gdcmPixelConvert.cxx clean up on method arguments and internal
1482 variable names for semantical coherence.
1484 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * Finished lossless transition, not only do we now read all lossless jpeg
1486 images, without the need of the Cornwell lib, but we do read them properly now
1487 * To reduce code (well to avoid code duplication), I defined a common place
1488 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1489 redefine symbols. This is not perfect but this the best solution I found for a
1490 compilation time jpeg option.
1492 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1493 * Update jpeg ijg lib to support lossless jpeg implementation
1494 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1496 * Also added a special copyright for dcmtk since we use their bugfixes.
1499 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1501 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1502 matters, as stated in warning note at beginning of %include section).
1503 * src/gdcmDicomDir*.[cxx|h]: coding style
1504 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1505 * src/gdcmJpeg8.cxx: doxygen fix.
1506 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1507 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1508 from File:: to PixelConvert::.
1510 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1512 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1513 - more code moved away from File:: to PixelConvert::
1514 - fat setup of PixelConverter set in place in File::Initialise.
1516 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1518 namespace at the file system level. So now you should convert your examples
1520 gdcmHeader -> gdcm::Header
1521 It would be nice if people keep in mind to no open the namespace, since it
1522 allows compilation on broken plateform which were defining common symbol in
1523 the standart namespace (like LP, Unknown ...)
1525 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1526 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1527 The JPEG fragments are now parsed at the same stage than the RLE
1528 information. All code related to JPEG is now in gdcmPixelConvert:
1529 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1530 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1531 export a gdcmFile:: method. Those are simply global functions
1532 (for the time being this is better than having them attach to
1533 either gdcmFile:: or gdcmPixelConvert::).
1534 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1535 and stores the result in a gdcmJPEGFragmentsInfo.
1536 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1537 code (among other stuff) moved away from gdcmFile:; to
1540 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1541 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1542 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1543 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1544 clean up of RLE related code.
1545 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1546 - src/gdcmRLE.cxx removed
1547 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1548 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1549 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1550 * CLEANUP_ROUND (9) for gdcmPixelConvert
1551 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1552 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1553 away from gdcmFile:: to gdcmPixelConvert::.
1555 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1557 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1558 This is because Parse7Fe0 used to parse the pixels to compute the
1559 length. This task was passed over to FindDocEntryLengthOB() a long
1560 time ago, EXCEPT I had forgotten the OW case...
1561 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1562 we just recylce the code for parsing RLE fragments and computing
1564 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1565 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1566 with the retired Parse7Fe0().
1567 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1568 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1570 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1571 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1572 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1573 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1574 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1575 * CLEANUP_ROUND (4) for gdcmPixelConvert
1576 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1577 to return an unused length.
1579 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1580 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1581 this should be cleanner from the plane view. The iostream are erally a pain
1582 to use to do simple stuff.
1584 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1585 * Redo the compilation of the ijg jpeg library. Now only one source is
1586 necesseray. No need to rename file by hand what so ever. CMake handle the
1587 copying of the file within different directory, configure header file to
1588 modify some symbol. The only addition made to ijg wasd a mangle table so
1589 that symbol are different whether we are within 8bits or 12bits.
1591 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * Added documentation of vtkgdcmReader on Website:
1593 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1594 with it's binary name).
1595 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1596 the Website to be more complete.
1597 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1598 doxygenated documentation.
1599 - Doc/DoxyVtkGdcmReaderExamples.txt added
1600 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1601 DoxyVtkGdmReaderExamples.html )
1602 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1603 * CLEANUP_ROUND (3) for gdcmPixelConvert
1604 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1606 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1607 * CLEANUP_ROUND (2) for gdcmPixelConvert
1608 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1610 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * CLEANUP_ROUND for gdcmPixelConvert:
1612 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1613 - src/gdcmPixelStuff[h|cxx] removed
1614 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1615 - src/CMakeLists.txt changed accordingly
1616 * GDCMHOME clean up:
1617 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1618 gdcmVersion.py moved to newly created ATTIC related
1619 gdcmPython/SetupOldies/ directory.
1620 * Autotools clean up:
1621 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1622 - autogen.sh configure.in acinclude.m4 python.m4 removed
1624 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1626 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1627 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1629 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * TODO updated with Mathieu suggestions. I proposed a template for
1631 describing TODO entries and used it for new entries.
1632 * Added Doc/Website/CodingStyle.html, Developpers.html,
1633 DeveloppersPython.html, GdcmDataCvs.html and
1634 DownloadVersion0_1.html, DownloadVersion0_3.html.
1635 * Some Doc/*.txt Doxygen files (which do not really concern the
1636 documentation itself, but the website) moved to html and
1637 placed in directory Doc/Website:
1638 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1639 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1640 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1641 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1642 * CMakeLists.txt changed accordingly.
1643 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1644 DeveloppersPython.html
1645 * INSTALL nows refers to Doc/Website/Installation.html
1647 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1648 * Added Doc/Website directory, that contains a first raw version
1651 2004-09-23 Jean-Pierre Roux
1652 * FIX In order not to be poluted any longer by casting problems,
1653 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1654 we can now delete[] it safely
1655 * VoidArea is now called BinArea (less confusing name),
1656 and all the methods called ...VoidArea... are now ... BinArea...
1657 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1659 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1661 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1662 up to the destructor of gdcmElementSet to clean up TagHt and it's
1665 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1667 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1669 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * ENH: added some utility method that builds a flat dictionary
1671 holding all the Dicom entries contained in the recursive structure
1672 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1673 an example of usage.
1674 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1675 BuildFlatHashTable() that build a flat dictionary.
1676 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1677 gdcmDocument is now a friend of gdcmElementSet.
1678 - src/gdcmElementSet.cxx: clean up.
1679 - Example/FlatHashTablePrint.cxx added.
1680 - Example/CmakeLists.txt changed accordingly
1682 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1684 moved away from gdcmDocEntrySet (since this class is an abstract class
1685 acting like an interface). SQDepthLevel and BaseTagKey are now
1687 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1688 and associated accessors. Doxygenation of the class.
1689 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1691 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1692 Use SQDepthLevel accessor instead. ::Print() adapted.
1693 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1694 - src/gdcmDocument.cxx changed accordingly.
1696 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1698 - The following is the doxygen comment of the typedef declaration
1699 of gdcmTagKey in src/gdcmCommon.h:
1700 gdcmTagKey is made to old an "universal" (as in URL, Universal
1701 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1702 A dicom tag always has a group and an element, but a set of tags
1703 embeded in various (optionally nested) sequences and sharing
1704 the same group and element all share the same (group, element)
1705 "identifier". Hence the (group, element) cannot be used as an
1706 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1707 In order to construct a proper tag identifier (i.e. a key) we
1708 consider the following definition of a TagKey:
1709 - let Group, Element be the string representation of the
1710 group and element dicom tag members,
1711 - let ItemNumber be the string representation of the integer
1712 index of the considered item number of a sequence,
1713 Let the key of a tag embeded in a sequence, noted SeqTag, be
1715 /ItemNumber#Group|Element
1716 where "/", "#" and "|" are characters acting as separators.
1717 Then the general form of a gdcmTagKey is given by:
1718 Group|Element<SeqTag>
1719 where <SeqTag> means NO or many instances of SeqTag.
1720 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1723 but the gdcmTagKey of a tag "embeded" is the first item of
1724 a sequence, itself nested in the third item of a sequence is the
1726 0004|1220/2#0008|0082/0#0008|0090
1727 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1728 order to hold the new sequence compatible key. Previously, the
1729 GetKey() method would look in the underlying gdcmDictEntry.
1730 - src/gdcmDocEntry.cxx:
1731 -- constructor now copies the underlying DictEntry key, in the local
1733 -- ::Print: displays the member Key, instead of the (group, element).
1734 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1735 - src/gdcmDocEntrySet.h:xi
1736 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1737 -- now has a new BaseTagKey member.
1739 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1740 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1742 This poses the problem with the semantics of the following lines
1743 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1744 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1745 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1746 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1747 to the long FIXME note for what the problem is. Nevertheless in
1748 order to get things working the dicom dictionary was altered !
1749 Please fix things urgently...
1750 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1751 information), see above note on moving the member VoidArea. Nevertheless
1752 the following entries previously correctly set as US are now inproperly
1754 0028 1201 OW IMG Red Palette Color Lookup Table Data
1755 0028 1202 OW IMG Green Palette Color Lookup Table Data
1756 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1757 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1758 of gdcmDocEntry moved to gdcmSeqEntry.
1759 * src/gdcmSeqEntry.cxx: STYLE.
1761 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1764 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * gdcmPython/testSuite.py: all the test suite in python is now moved
1766 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1767 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1768 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1770 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1771 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1772 to avoid inclusion recursion until STL is reached.
1773 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1774 mecanism. errno.h is not included in gdcm anymore.
1775 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1776 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1778 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1779 gdcmData/TestAllEntryVerifyReference.txt
1780 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1781 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1782 exception_on_error parameter.
1783 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1784 - vtk/vtkGdcmReader.cxx changed accordingly,
1785 - Example/*.cxx and Test/*.cxx changed accordingly.
1787 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1789 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1790 enable_sequences removed from gdcmHeader constructor and dependencies.
1791 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1792 * gdcmPython/demo/PrintHeader.py: dummy fix.
1793 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1794 skip_shadow removed from gdcmHeader constructor and dependencies.
1795 * Example/*.cxx and Test/*.cxx changed accordingly.
1797 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1799 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1801 2004-07-21 Jean-Pierre Roux
1802 * FIX Now, Parsing and Printing a DICOMDIR do work!
1803 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1805 2004-07-20 Jean-Pierre Roux
1806 * FIX Some brain damaged headers have Zero-Lenght fields
1807 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1809 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1810 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1811 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1812 variable (instance of gdcmDebug) by a definition macro, and the instance
1813 is now in static in the gdcmDebug class
1814 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1815 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1817 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * WARNING: ctest now depends more tightly on gdcmData. You should
1819 check out gdcmData properly for things to run smoothly...
1820 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1821 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1822 we need the pixels not be loaded in order to use the ValEntry
1823 that displays position and size).
1824 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1825 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1826 be deprecated. If you have any doubts about the advantages of a
1827 modern scripting language (read Python) versus grass root C++ (i.e.
1828 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1829 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1830 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1831 Anyhow, consider documenting the gdcmData images in
1832 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1834 * Test/CMakeLists.txt:
1835 - now uses TestAllEntryVerify.cxx
1836 - specific comments on oldACR00001.ima (now renamed in gdcmData
1837 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1838 gdcmData/TestAllEntryVerifyReference.txt
1841 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1842 * src/*.[h|cxx] : typedef clean up
1843 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1844 - TagKey renamed to gdcmTagKey (for external usage)
1845 - VRKey renamed to gdcmVRKey (for external usage)
1846 - removal of typedef duplication.
1847 - Removed all unecessary inline keyword from class inline definitions.
1848 - Some method|function(void) declarations replaced with method|function().
1849 * src/jpeg/libijg12/jdhuff12.c:
1850 - printf polluting ctest removed.
1851 - TAB removal for comminting
1853 - TestAllReadCompareDicom.cxx: added a test that compares all the
1854 images in gdcmDataImages.h with corresponding images in
1855 gdcmData/BaselineDicom/. When baseline images are not present
1856 this test creates them.
1857 Note: we need to validate each reference image, but before that
1858 I'd like to rename them with a more explicit name...
1859 - CMakeLists.txt: changed accordingly.
1860 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1861 including each header needed).
1863 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1865 test suite to the Example directory. Are concerned:
1870 - TestWriteSimple.cxx
1871 * Test/CMakeLists.txt: added some comments on reasons for black listing
1872 image gdcmData/oldACR00001.ima
1874 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * Test/CmakeList.txt: removed the following from black list (to be coherent
1876 with removal from gdcmData):
1877 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1878 - gdcm-MR-PHILIPS-16.dcm
1880 Added the following because after last cvs update, they cause
1881 ctest -R TestReadWriteReadCompare
1883 - gdcm-MR-SIEMENS-16-1.acr
1885 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1886 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1887 new comments in this file) we temporarily (sigh) move to a weaker
1889 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1890 we don't need to black list the following images anymore:
1891 - 8BitsUncompressedColor.dcm
1893 - US-PAL-8-10x-echo.dcm
1894 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1895 fixes and the beautified code ;-)
1896 This fixes the bug introduced in version 1.42 (when beautifying)
1897 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1898 Note: ctest was blind to this bug (this means we need to still
1899 improve the test suite). The bug could be detected by using
1900 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1902 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1903 and by displaying the (garbage) produced file temp.XDCM...
1905 2004-06-29 Jean-Pierre Roux
1906 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1907 - replace by uggly but working old code :-(
1908 A lot of things should be OK again.
1909 It's really urgent to have a test suite that *tests*,
1910 to prevent Frog's beautifying sessions to break all the stuff
1911 (twice, withing a fortnigh ...)
1913 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1915 redundancy) to added Test/TestReadWriteReadCompare.cxx
1916 * Test/CmakeList.txt: because the compare test of
1917 Test/TestReadWriteReadCompare.cxx fails, the following images are
1918 black listed: - 8BitsUncompressedColor.dcm
1920 - US-PAL-8-10x-echo.dcm
1921 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1922 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1923 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1924 and ad-hoc kludge. This kludge is now removed, and on encountering
1925 such an image (OB field brain damaged) we set errno. Then in
1926 ::FindDocLength() we "fix" the length as being ALL what remains
1927 in the file (until EOF). We then proceed, hoping for the best...
1928 This fixes a SegFault in ShowDicom when trying to write such an
1930 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1931 (because TestWriteRead breaks on it, after a non conformal commit?).
1932 ctest now runs properly, except for MakeDicomDir (which was always
1933 broken) and the Python related stuff (still not fixed).
1935 2004-06-24 Jean-Pierre Roux
1936 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1937 FIX : Test/TestReadWrite now iterates on all the file names
1938 (instead of infinite loop)
1939 ENH : Test/TestWriteRead now iterates on all the file names
1941 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1944 2004-06-24 Jean-Pierre Roux
1945 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1946 when SamplesPerPixel =3
1947 - now Write is no longer confused by
1948 'BitsAllocated = 12" and 'BitsStored=12"
1949 - "UN" value representation Elements are now written correctly
1950 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1951 ENH : - now gdcmHeader has its own Write methods
1952 (in order to split the job that has not to be done
1955 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1957 loop on the same image until memory went out.
1958 Note: this means we still have gobs of memory loss in PrintDocument
1959 * src/gdcmDocument.cxx: fixes problem on parsing on file
1960 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1962 2004-06-24 Jean-Pierre Roux
1963 FIX : Write - All the Sequences and Sequence Item are now written
1964 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1965 is added a the end, when necessary.
1966 - A lot of brain-damaged images, that were read correctly are
1967 now written correctly
1968 - length compatible BinEntry are now loaded correctly
1969 (even for odd groups)
1970 Note : only Explicit Value Representation was checked.
1971 (question : is implicit VR really necessary for gdcm ?)
1973 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * DEVELOPPER: added a proposition of coding style.
1975 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1978 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1980 Use the gdcmDocEntry::Print() and Write() instead.
1981 * src/gdcmDocument.cxx: bug fix.
1983 2004-06-22 Jean-Pierre Roux
1984 FIX : gdcmDocument.cxx
1985 - Now we do recognize the JpegLossLess format (there was a misstyping in
1986 code 'beautyfication' :-(
1987 - Now we automaticaticaly load the Luts, if any
1989 2004-06-22 Jean-Pierre Roux
1990 In order : to write Sequences, whatever their imbrication level,
1991 : to allow user to create his own Sequences
1992 a lot of modif where necessary (adding, moving, or virtualising methods)
1994 WARNING : save your own sources *before* cvs up !
1997 ADD virtual void Write(FILE *fp, FileType filetype);
2000 ADD virtual void Write(FILE *fp, FileType filetype);
2001 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
2004 ADD virtual void Write (FILE *fp, FileType filetype)=0;
2005 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
2006 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
2007 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
2008 ADD std::string GetEntryByName(TagName name);
2009 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2011 std::string vr = "unkn",
2012 std::string fourth = "unkn",
2013 std::string name = "unkn");
2014 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2015 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2016 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2017 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
2018 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
2019 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2020 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
2021 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
2024 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
2025 ADD virtual std::string GetEntryByName (TagName tagName);
2026 ADD virtual std::string GetEntryVRByName (TagName tagName);
2027 REM virtual bool Write(FILE *, FileType);
2028 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
2029 FILE *_fp, FileType type);
2030 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
2031 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
2032 REM virtual bool WriteEntries(FILE *_fp,FileType type);
2033 REM virtual std::string GetEntryByName (std::string tagName);
2034 REM virtual std::string GetEntryVRByName (std::string tagName);
2035 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
2036 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
2037 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
2039 std::string vr = "unkn",
2040 std::string fourth = "unkn",
2041 std::string name = "unkn");
2042 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
2043 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
2044 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
2045 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
2048 ADD virtual void Write(FILE *fp, FileType filetype);
2051 ADD virtual void Write(FILE *fp,FileType filetype);
2054 ADD virtual void Write(FILE *fp, FileType filetype);
2055 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
2056 REM std::string GetEntryByNumber(guint16 group, guint16 element);
2057 REM std::string GetEntryByName(TagName name);
2060 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
2062 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
2064 The default constructor invoked by the line
2065 gdcmHeader *f1 = new gdcmHeader( header );
2066 was gdcmHeader::gdcmHeader(bool) instead of the expected
2067 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
2068 Hence the parsing wasn't executed... See also below.
2069 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
2070 as explicit constructor didn't do the trick to fix the above problem.
2071 Could anyone explain why ?
2072 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
2073 properly calls gdcmValEntry::Print() (that was weed out from
2074 code related to gdcmBinEntry).
2076 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * In order to fix memory leaks:
2078 - Test/TestWriteSimple.cxx: added cleaning of free store through
2080 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
2081 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
2082 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
2083 (through the call to ::AddDicomDirMeta()) or the destructor
2084 would crash when deleting uninitialized ::metaElems].
2085 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
2086 - src/gdcmDocument.cxx:
2087 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
2088 from dynamic stores.
2089 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
2090 was causing memory leaks.
2091 - src/gdcmSQItem.cxx:
2092 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
2093 cleanly handled with polymophism: sorry but my milage is low).
2094 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
2095 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
2096 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
2097 This avoids SegFaulting.
2098 - src/gdcmSQItem.h: coding style.
2100 - Test/TestWriteSimple still severely sucks. The output image content
2101 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
2102 damaged when displayed with vtkgdcmViewer.
2103 - on memory leaks: TestWriteSimple leaks really less (see entry
2104 of 2004-06-18 in Changelog file for the call to valgrind).
2105 - on segfaults: ctest now passes all the tests but one (no more
2107 * Erroneous leading white fix:
2108 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
2109 white[s] (as opposed to from >> xxx, that removes it [them].
2110 - src/gdcmTS.cxx: ditto.
2111 - gdcmPython/testSuite.py: dirty related kludge removed.
2112 * src/*: remaining references to gdcmParser removed.
2113 * src/*[cxx|h]: added copy[way]left header.
2116 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * In order to fix writing of dicom files:
2118 - Test/TestWriteSimple.cxx: a simpler example of writing.
2119 - Test/CMakeLists.txt changed accordingly.
2120 - src/gdcmDocument.cxx:
2121 -- The destructor now recursilvely removes potential sequences.
2122 -- Bug fix in ::IsJPEG2000()
2123 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
2124 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
2126 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
2127 to only declared) and build on top of
2128 ::GetDocEntryByNumber(guint16, guint16).
2129 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
2130 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
2131 for usage in destructor and treatement of promotion in
2132 ::ReplaceOrCreateByNumber().
2133 - src/gdcmSQItem.cxx: destructor should better handle his job.
2134 Test/TestWriteSimple now runs (or at least it DOES something).
2135 * We can now start hutting memory links. A good starting point is:
2136 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
2137 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
2138 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
2140 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * Valgrind note: after Mathieu Malaterre teached me how to read
2142 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
2144 Using gcc, you can force the STL to use malloc and to free memory as
2145 soon as possible by globally disabling memory caching.
2146 With 3.2.2 and later, you should export the environment variable
2147 GLIBCPP_FORCE_NEW before running your program.
2148 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
2149 simply vanish (it is still not clear to me, whether this means that
2150 STL std::string leaks or if valgrind believes it leaks...).
2151 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
2152 running bin/gdcmTests makeDicomDir):
2153 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
2154 - Test/makeDicomDir.cxx now properly traps empty lists and returns
2156 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
2157 SegFaulting (I drowned in DicomDir related code when trying to
2158 understand why the list is empty...).
2159 * src/gdcmDocument.h: first BSD license header try.
2160 * Doc/License.txt added.
2162 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2163 * src/gdcmDocument.[h|cxx]:
2164 - Clean up of the Transfer related predicates. They are now all based
2165 on new method isGivenTransferSyntax, that (should) handle properly
2166 the padding problem.
2167 - general clean up, simplification, and coding style.
2168 - Specific clean up of Parse7FE0() (umproperly named actually).
2169 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
2171 2004-06-14 Jean-Pierre Roux
2173 - fix the display of Sequence Delimitor (SQDepthLevel pb)
2174 - fix the display of SQItem ordinal number
2175 - add the GetSQItemByOrdinalNumber method
2176 - remove some useless never written private methods
2178 2004-06-14 Jean-Pierre Roux
2180 - adding a constructor taking a gdcmDocEntry as an input param
2181 - ReplaceOrCreateByNumber now returns :
2182 a gdcmBinEntry * if a Binary (void *) value is passed as a param
2183 a gdcmValEntry * if a string value is passed as a param
2185 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
2186 according to the param type (no longer sets a gdcmDocEntry)
2187 - GetValEntryByNumber, GetBinEntryByNumber added
2188 - NewValEntryByNumber and NewBinEntryByNumber added
2190 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
2192 - GetSQItemNumber and SetSQItemNumber added, to provide
2193 a (relative) Item identier inside a given Sequence
2194 \warning : some pb remaining around this number
2196 - AddEntry now takes the Item Number as a param
2198 - adding a constructor taking a gdcmDocEntry as an input param
2200 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * Memory leak hunt with the following command:
2202 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2203 --show-reachable=yes gdcmTests PrintDocument
2204 It looks like many (all?) leaks are due to the STL (or a bad usage
2205 of the STL. The lines producing the leaks now have a comment with
2206 a "MEMORY LEAK" tag: you can retrieve them with
2207 grep "MEMORY LEAK" src/*
2208 Here are two typical examples which I can't help fixing:
2213 char * test = "babo";
2214 name = test; //// <--- valgrind detects 960 bytes lost in
2215 //// call to std::string::operator=(char const*)
2216 name.clear(); //// Doesn't help !
2224 std::cout << "Type a bunch of characters followed by RETURN: ";
2225 getline(std::cin, line); //// <--- valgrind dectects a loss
2226 //// of 1320 bytes in call to
2227 /// std::basic_istream<>& std::getline<>
2233 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * src/gdcmHeader.[cxx|h]:
2235 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
2236 and related, moved away to gdcmDocument.
2237 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
2238 the corresponding protected accessors of inherited class
2239 gdcmDocument, removed ! As a consequence gdcmFile had to be
2240 declared friend of class gdcmDocument (see below).
2241 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
2242 - Clean up of undefined or unused methods.
2243 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
2244 account the changes to gdcmHeader.h).
2245 * src/gdcmDocument.h:
2246 - gdcmFile is now a friend class (in order to take into account the
2247 changes to gdcmHeader.h).
2248 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
2249 (see changes to gdcmHeader.h).
2250 - Accessors (reading on the form GetEntry*) are now public.
2251 - Clean up of undefined or unused methods.
2252 * src/gdcmDocument.cxx:
2253 - adaptation to changes to gdcmDocument.h
2254 - ::OpenFile now writes a verbose message when file cannot be opened.
2255 - some std::string properly set to VRKey
2256 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
2257 references to gdcmDocument.
2258 * Test/TestFindTags.cxx: changed accordingly to above changes.
2259 * gdcmPython/testSuite.py: adapted to renaming of acr files in
2260 cvs repository gdcmData.
2262 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
2264 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
2265 conflicts with gdcmValEntry::voidArea.
2266 * src/gdcmValEntry.cxx: unmatching comment wiped out.
2267 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
2268 Value representation between StringRepresentable and BinaryRepresentable.
2269 * src/gdcmDocument.cxx:
2270 - method ParseDES: proper indentation restored and usage of
2271 gdcmVR::IsVROfGdcmStringRepresentable wired in.
2272 - method LoadDocEntry: the fingerprint left in the SetValue() of
2273 unloaded entries (length > MaxSizeLoadEntry) had curiously been
2274 removed. Reverting to previous code segment with the proper
2275 dynamic_cast< gdcmValEntry* >.
2276 Note: this was (partially) breaking the python test suite
2277 (gdcmPython/testSuite.py) that made usage of the above
2278 fingerprint to check presence of "Pixel Data".
2279 * src/gdcmDocEntry.h: coding style.
2280 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
2281 now taken into account.
2282 * gdcmPython/gdcm.i: adaptation to the new internal representation
2283 of gdcm (exit gdcmParser, hello gdcmDocument).
2284 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
2286 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
2287 anymore, but instead prints the loaded Python dictionary.
2288 * .... alas, the python testSuite is still broken.
2290 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2291 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
2293 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
2294 * src/gdcmUtil.h : export methods
2296 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
2299 * Initial addition of automatic python testing
2300 * Initial addition of automatic image comparison
2302 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2303 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
2304 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
2306 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2307 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
2308 * Test/ShowDicom.cxx : bug fix for msvc compilation
2309 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
2311 2004-05-04 Jean-Pierre Roux
2312 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
2313 new concepts (and new classes) :
2314 a 'gdcmDocument' is composed of a set of Doc Entries, that are
2315 - elementary gdcmDocEntries (former gdcmHeaderEntries)
2316 - Sequence Doc Entries (gdcmSeqEntries)
2317 a Sequence is composed of Items.
2318 Each item is a set of Doc Entries (this is recursive)
2319 The non uniqueness of the 'Dicom tag' is due to this recursivity
2320 (never taken into account)
2321 Our unability to add a new 'entry' in the header
2322 at the proper location (neither in the H-Table (map or multimap),
2323 nor in the Chained List is also due to this recursivity.
2324 Don't try, right now, to use/modify/compile these new sources :
2325 nothing is finished.
2326 We just commit all the stuff, 'as is', in order not to loose it.
2328 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2329 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
2331 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
2333 file prefix (SetFilePrefix)
2335 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2336 * Add a new test: ShowDicom, for now this is just the c++ version of
2337 checkRead.sh, later it will be able to compare the image read against a
2339 * Replace the DEBUG on the stack with a global entry in cmake interface:
2340 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
2342 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2343 * Add an example subdir, with a real example on how to read + write a
2346 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
2348 * Doc/CMakeLists.txt: the main page is now properly differentiated
2349 between the developper and user version.
2350 * Doc/doxygen.config.in: dropped search related obsolete flags
2351 * src/gdcmParser.h, gdcmHeader.h: doxygenation
2353 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * DEVELOPPER: added some helpfull comments for compile/test/install
2357 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2358 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
2359 src directory, now generated in the build dir.
2360 2. Tests as mentionned smarter
2362 4. Add a new method in gdcmDict that return the PubDict by name
2363 this is interesting for 3rd party lib like ITK,
2364 where we could set the institution name / patient name...
2366 * ENH: 1. Now the test suite is working for real
2367 2. All binaries are now output in the gdcm-bin directory
2368 (this was not true before)
2370 2004-04-28 Jean-Pierre Roux
2371 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
2372 SeQuence indented printing of Dicom Header.
2373 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
2374 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
2375 Computation of SQDepthLevel is now part of gdcmHeader constructor
2376 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
2377 tree-like structure of a Dicom Header.
2378 * FIX Test code cleaning
2380 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2381 * ENH: Adding automatic testing
2382 1. Need a DartConfig.cmake to submit to public
2383 2. Add a test driver gdcmTest.cxx
2384 3. gdcmTestMain, an helper for the main test driver gdcmTest
2385 4. Files in Test don't have a main anymore, this becomes interesting
2386 when we add more and more tests, thus dsw don't have to load
2388 * ENH: Adding a GDCM_DATA_ROOT for testing
2389 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2390 one file instead of seven + some small cleanup
2392 2004-04-22 Jean-Pierre Roux
2393 * ENH Minor changes to the Print() methods.
2394 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2395 Header printing. Example given with :
2396 > PrintHeader fileName 2 new
2397 (SQ based tree-like structure still to be done for the Header ...)
2399 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2401 1. I have added some unsigned where needed
2402 2. Some function parameter not used -> (void)
2403 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2404 4. g++ don't like character '\' in comment
2405 5. #define jpeg_create_decompress jCreaDecompress
2406 this really need to be fixed
2407 6. virtualize destructor of gdcmObject ... leakage
2408 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2409 this also really need to be fixed
2410 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2411 remove compression file
2412 (as we only do decompression, right ?)
2413 * ENH: Change malloc/calloc/free with c++ equivalent
2415 2004-04-21 Jean-Pierre Roux
2416 * FIX gdcmHeaderHelper::GetXSpacing
2417 when a single value is found (bug ?), xpacing is now
2418 defaulted to yspacing
2420 2004-04-19 Jean-Pierre Roux
2421 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2422 * ENH add parameters :
2423 bool exception_on_error = false,
2424 bool enable_sequences = false,
2425 bool ignore_shadow = false
2426 to the gdcmFile constructors to be full gdcmParser compliant
2427 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2428 to allow reading of PAPYRUS 3.0 files
2430 2004-04-06 Jean-Pierre Roux
2431 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2433 2004-04-02 Jean-Pierre Roux
2434 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2435 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2436 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2438 2004-03-30 Jean-Pierre Roux
2439 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2440 for ACR file, written out as DICOM files (hope so...)
2442 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2444 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2445 moved to base class gdcmParser and only the specialisation is kept
2447 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2448 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2449 already does the job.
2450 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2451 (to be consistent with gdcmParser::WriteEntries).
2453 2004-03-30 Benoit Regrain
2454 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2455 upate of the object's instance. It's passed to 2 in the unfavorable
2456 case : one in the ExecuteInformation, one in the ExecuteData
2458 2004-03-29 Jean-Pierre Roux
2459 * ENH : Check on file type to be written moved
2460 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2461 * FIX : gdcmObject::ResetBoundaries now stops properly
2462 when end-of-list is reached
2463 : gdcmVersion modified (as Benoit Regrain asked)
2465 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2467 * src/gdcmUtil.cxx: added forgotten iostream include.
2468 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2469 equivalent to ExplicitVR in existing code).
2471 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2473 now contains all the gdcmGlobal related code.
2474 * minor coding style and doxygenation changes.
2476 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2477 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2478 now contains all the Debug related code.
2479 * minor clean-up of includes in src/*.cxx
2480 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2481 CreateCleanString) removed.
2482 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2483 * Doc/DoxyMainPageUser.txt added.
2484 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2485 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2486 src/gdcmDirList.cxx)
2488 2004-03-24 Jean-Pierre Roux
2489 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2491 2004-03-23 Jean-Pierre Roux
2492 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2493 big endian made volumes
2494 * ENH Now gdcmParser constructor and destructor are protected to forbid
2495 end user to instanciate class gdcmParser
2496 (only gdcmHeader and gdcmDicomDir are meaningfull)
2498 2004-03-22 Benoit Regrain
2499 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2500 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2501 gdcmSerie to gdcmDicomDirSerie
2503 2004-03-19 Jean-Pierre Roux
2504 * ENH Now the tree-like structure describing a DICOMDIR comming from
2505 an already existing DICOMDIR file is consistent with
2506 the home-made tree-like structure build ex-nihilo
2507 or build from the files held (recursively) in a Directory
2508 functions gdcmDicomDir::CheckBoundaries()
2509 gdcmObject::SetBoundaries() added
2511 2004-03-17 Jean-Pierre Roux
2512 * REM (Eric Boix bug) : removal of meaningless
2513 gdcmDicomDirImage::NewImage function.
2514 * FIX now file names and directory name are written properly in the
2516 * FIX now gdcmDicomDir constructor may be call without any trick
2519 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2521 of gdcmDicomDirImage::NewImage as empty function.
2523 2004-02-28 Jean-Pierre Roux
2524 * ENH add gdcmDicomDir:NewPatient
2525 add gdcmDicomDirPatient:NewStudy
2526 add gdcmDicomDirStudy:NewSerie
2527 add gdcmDicomDirSerie:NewImage
2528 to allow making gdcDicomDir object.
2529 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2530 (as opposite to the gdcmHeader chained list)
2532 2004-02-11 Benoit Regrain
2533 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2534 when using from python
2536 2004-02-10 Benoit Regrain
2537 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2538 * FIX : in gdcmDicomDir when the directory is empty
2539 * ENH : add callback and methods to get the progression of dicomDir
2542 2004-02-06 Jean-Pierre Roux
2543 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2544 - GDCM_META added to gdcmDicomDirType
2545 - class gdcmMeta created
2546 * ENH : - A brief summary is now displayed at the beginning of
2547 'testDicomDir' to help disaster magnitude estimation
2548 * REM : Now useless Test/explDICOMDIR.cxx
2550 2004-02-05 Benoit Regrain
2551 * ENH : add methods in gdcmObject to get the hash table or the list of
2553 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2554 * FIX : wrapping python for TagHeaderEntryHT
2556 2004-02-04 Benoit Regrain
2557 * FIX : even length for some strings when writting the dicom dir
2558 * FIX : sort the images in the dicom dir
2559 * FIX : Bug fix for python use of dicom dir
2560 * ADD : a python demo
2562 2004-02-04 Jean-Pierre Roux
2563 * FIX : Final solution (?) for icone embedded images
2564 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2565 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2566 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2567 gdcmData/gdcm-MR-SIEMENS-16.acr1
2568 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2569 to make full checking easier
2571 2004-02-04 Benoit Regrain
2572 * FIX : WriteEntries : coding style & logic in parameters
2573 * FIX : Set the elements to create the DicomDir in a dictionary file
2575 2004-02-03 Benoit Regrain
2576 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2577 * gdcmDicomDir : add the load of directory
2578 * Bug fix and print add-on
2580 2004-02-03 Jean-Pierre Roux
2581 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2582 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2583 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2584 * FIX gdcmParser.cxx : 'group length' elements are now considered
2585 as integers, even for shadow groups, when file is Implicit VR
2587 2004-02-02 Jean-Pierre Roux
2588 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2590 of the last synonym :-(
2591 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2593 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2594 * FIX taking into account the possible 7fe0,0010 multiplicity
2595 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2596 to allow removal of references to 7fe0,0010, to deal with
2597 ACR-NEMA images, when 0028,0200 is meaningfull
2599 2004-01-31 Jean-Pierre Roux
2600 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2601 no longer writes 'Un' on disk
2602 * FIX SQ elements with actual length are now dealt with corectly
2603 * FIX gdcmFile::WriteBase make the difference, for color images, between
2604 the length (for Palette expanded images)
2605 and Raw Length (non expanded image + Palette)
2606 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2607 (that broke Write). Replaced by UL.
2608 Aware user will reload the field if he
2609 thinks it's necesssary
2611 2004-01-30 Jean-Pierre Roux
2612 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2613 when 'dirty Acr' is found, to be compliant with the new
2614 IsReadable() methods.
2616 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2617 (no DOUBLE images in kosher DICOM,
2618 but so usefull for people that miss them ;-)
2620 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2621 DICOMDIR related utilities (not checked as Windoze compliant)
2623 2004-01-28 Jean-Pierre Roux
2624 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2626 2004-01-27 Jean-Pierre Roux
2627 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2628 to allow skipping the shadow elements, to save memory space.
2629 The TRUE value for this param has to be used
2630 with a FALSE value for the 'enable_sequence' param.
2631 ('public elements' may be embedded in 'shadow Sequences')
2632 * gdcmHeader methods now deal with 'embedded icones images' in the header
2633 (even when an 'icone image sequence' is announced by the
2634 element (0x0088,0x0200), but there is NO icone at all ...
2636 * gdcmHeader sometimes Image Location value doesn't follow
2637 the supposed processor endianity (see gdcmData/cr172241.dcm).
2640 * gdcmHeader add the method
2641 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2642 to get *all* the Header Entries with the same tag.
2643 GetHeaderEntrySameName is probabely *useless*
2644 (no meaning : Name is *not* an identifier within the Dictionary)
2646 2004-01-26 Benoit Regrain
2647 * Bug fix in the print of hexadecimal representations. Remove long fields
2648 in the print and add a third level of print to print them
2650 2004-01-23 Benoit Regrain
2651 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2652 * Bug fix on test suite after remove the strip made on not string fields
2653 * Split the IsReadable method between gdcmParser which test that the file
2654 is dicom and gdcmHeader which test that it's an image file
2656 2004-01-22 Benoit Regrain
2657 * DicomDir : clean code, add methods, set variables in protected or private
2658 * gdcmUtil : bug fix for the clean string method
2660 2004-01-19 Benoit Regrain
2661 * Add the use of shadow dictionaries
2662 * bug fix and coding style
2664 2004-01-19 Benoit Regrain
2665 * src/gdcmFile.cxx : bug fix concerning the close of file
2666 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2667 * Add the update of header entries using the shadow library
2669 2004-01-19 Benoit Regrain
2670 * removal of file gdcmHeader2.cxx
2671 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2672 inheriting from gdcmParser. This split is to prepare the integration
2673 of dicom dir parsing
2674 * bug fix under python
2676 2004-01-16 Jean-Pierre Roux
2677 * REM removal of class gdcmHeaderEntrySet
2678 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2679 * ADD add file gdcmHeader2.cxx
2680 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2682 2004-01-15 Benoit Regrain
2683 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2684 entries created while parsing the header. Thus, they will be destroyed
2685 when the gdcmDictSet will be destroyed
2686 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2689 2004-01-15 Benoit Regrain
2690 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2691 made a fatal error because of the memory release at the end of program.
2692 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2693 some memory and vtk seems to have some problems with that.
2694 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2696 2004-01-14 Benoit Regrain
2697 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2698 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2699 * src/*.[h|cxx] : make changes due to class name changes
2700 * gdcmPython/demo/*.py : bug fix due to method names
2702 2004-01-13 Benoit Regrain
2703 * src/*.[h|cxx] : coding style
2704 * vtk/*.[h|cxx] : coding style
2706 2004-01-13 Benoit Regrain
2707 * gdcmPython/testSuite.py : test the readable flag of file for tests
2708 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2709 It's lied to the stl compilation by MSVC (windows, always windows...)
2710 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2712 2004-01-12 Benoit Regrain
2713 * src/*.h : add comments
2714 * src/gdcmDictSet.h : set the method BuildDictPath in public
2715 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2716 directly setted in the source code
2717 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2720 2004-01-09 Benoit Regrain
2721 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2722 * setup.py : use a reference to gdcmVERSION
2724 2004-01-07 Benoit Regrain
2725 * Modification to compile with the distutils.
2728 2003-12-10 Benoit Regrain
2729 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2730 can use a gdcmHeaderHelper to load data
2731 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2732 made in the source code
2734 2003-12-10 Benoit Regrain
2735 * Update Windows projects and .cvsignore files
2737 2003-11-12 Jean-Pierre Roux
2738 * ENH gdcmHeader constructor has one more parameter (default value : false)
2739 that allows the user to 'go inside' the SeQuences only
2741 gdcmElValSet:Print takes it into account
2743 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2744 * ENH: Update gdcmPython/CMakeLists
2745 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2746 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2748 2003-11-10 Jean-Pierre Roux
2749 * FIX : gdcmHeader::LoadElements is now based
2750 on the ListTag listElem member,
2751 not longer on the TagElValueHT tagHt member
2752 * ENH : PrintPubElVal shows (temporarily) both results,
2753 with the tagHt member and the listElem member.
2754 (it's easier to 'see' the problems when using Printheader)
2756 * FIX : old private member LgrElem is now splitted into
2757 ReadLength : Length actually found on disk (updated only
2758 if bug fixing is necessary), for internal
2760 UsableLength : Updated by FixFoundLength, to fix a bug
2761 or to allow Parser going on.
2762 Will allow to re-write a kosher header when a SeQuence
2763 with a length (not 0000) is found
2764 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2765 because gdcmElValSet::Add does not update ListElem
2768 2003-11-07 Jean-Pierre Roux
2769 * FIX misstyping in Transfert Syntax name table
2770 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2771 when they have an actual length (not 0000 nor FFFFF)
2772 (Nobody should care of it, but DICOMDIR explorers)
2774 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2775 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2777 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2778 * ENH: vtkGdcmReader now supports LUT !
2779 (vtkgdcmViewer for now is not able to use them though)
2781 2003-11-05 Jean-Pierre Roux
2782 * in testSuite.py : new files names for checking the package
2783 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2784 that returns the pixel area size to the *aware* (vtk) user
2785 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2787 2003-11-05 Benoit Regrain
2788 * in testSuite.py : Modify the rules for checking the paths
2789 : Explicit error messages
2790 * in __init__.py : Related modif
2792 2003-11-03 Jean-Pierre Roux
2793 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2794 to be used by aware (vtk) users that want to manage
2795 LUT (and no to turn the PALETTE image into an RGB pixels one)
2796 * GetPixelType now returns 8U for 24 Bits images
2797 (vtkGdcmReader compliant)
2799 2003-10-31 Jean-Pierre Roux
2800 * Removal of *all* gdcmData images and add them again
2801 in order to loose the 'history' of un-anonymised images
2803 2003-10-31 Jean-Pierre Roux
2804 * RMV : removal of useless jBitsInJsample.h
2805 for both 8 and 12 Bits JPEG Lossy Libraries
2807 2003-10-31 Jean-Pierre Roux
2808 * ENH : Add the functions gdcmFile::GetImageDataRaw
2809 gdcmFile::GetImageDataIntoVectorRaw
2810 that act as GetImageData and GetImageDataIntoVector
2811 except the making of an RGB Plane from Gray Plane + LUT
2812 Intended to aware (vtk) users who know how to manage
2815 GetLUTRGBA return a R,G,B,A LUT if any
2816 lgrTotaleRaw gives the 'Raw' length
2817 GetImageDataRaw returns the gray Plane
2818 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2819 (They stay Grey, just like with other Dicom viewers :-(
2821 2003-10-30 Jean-Pierre Roux
2822 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2824 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2825 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2826 being coherents dicom files.
2828 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2829 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2831 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2832 * ENH: Two steps is necessary to please VC++ compiler...
2833 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2834 * ENH: Add include dir to medcon lib
2835 * FIX: only one function is being exported for now !
2836 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2838 2003-10-29 Jean-Pierre Roux
2839 * adding gdcmHeader::GetLUTRGBA
2840 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2841 --> Mathieu, the modif u're waiting for is not yet committed
2842 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2844 2003-10-27 Jean-Pierre Roux
2845 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2846 00191113.dcm DermaColorLossLess.dcm
2847 MxTwinLossLess.dcm RadBWLossLess.dcm
2848 * ENH: For version prior to vtkImageViewer2 -r 1.19
2849 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2851 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2852 * Removal of ido stuff in CMakeLists.txt
2854 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2855 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2856 * FIX: remove a call to ->Modified ... see comments
2857 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2859 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2860 * FIX: Problem with path for libvtkgdcmPython
2861 * ENH: Try adding a search script for python site-package
2862 * RMV: Remove some file from medcon lib that are not necessary
2863 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2864 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2865 * FIX: More pragma disable fro VC++,
2866 I don't think I break something as it is also disable in VTK/ITK.
2867 But it fasten debug compilation time.
2869 2003-10-23 Jean-Pierre Roux
2870 * gdcm now deals with 16 Bits Run Length Encoded images
2871 (they are compressed as 2 planes images,
2872 one for the high Bytes, the other for low Bytes)
2874 2003-10-22 Jean-Pierre Roux
2875 * Now CheckRead takes into account :
2876 - the bugged 'Leonardo' Siemens images
2877 - the XA images, sent thru the burning VPRO station
2878 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2881 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2882 * FIX: When copying a Makefile.am to CMakeLists.txt
2883 one should remove the '\'
2885 2003-10-22 Jean-Pierre Roux
2886 * in gdcmData adding a bugged 'Leonardo' Siemens image
2887 (wrong lengths in header)
2888 OK with gdcm, KO with the other viewers :-)
2889 * add a GE dlx XA image, thru the VEPRO burning station
2892 2003-10-21 Jean-Pierre Roux
2893 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2894 for a brutal checking of vtkgdcmViewer compliance
2896 2003-10-21 Jean-Pierre Roux
2897 * add the files for 'xmedcon' Jpeg Lossless library
2898 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2900 2003-10-21 Jean-Pierre Roux
2901 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2903 2003-10-21 Jean-Pierre Roux
2904 * garbage Siemens 'Leonardo' images dealt with
2905 (the patch is easy to remove)
2906 * cosmetic changes to avoid warnings
2908 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2909 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2910 no need to press 'r' now.
2912 2003-10-20 Jean-Pierre Roux
2913 * upgrade of checkRead.sh checkWrite.sh according
2914 to new Jpeg Lossless decompressor
2915 * add US.3405.1.dcm, a genuine RGB medical file ...
2916 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2917 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2919 2003-10-15 Jean-Pierre Roux
2920 * general anonymisation in gdcmData
2921 * adding the 'color files' from
2922 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2923 * adding some well knowed bugged-header images
2924 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2925 waiting for their inclusion in Python testsuite
2927 2003-10-15 Jean-Pierre Roux
2928 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2929 no longer seg faults when file is not found
2931 2003-10-14 Jean-Pierre Roux
2932 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2935 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2936 * TODO: *.in file to genereate a UseGDCM later
2938 2003-10-14 Jean-Pierre Roux
2939 * Some supposed-to-be Dicom Images have no preamble.
2940 OpenFile takes it into account
2941 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2942 * Missing elements added in dicomV3.dic
2943 (just to be affraid : have a look at
2944 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2945 and do it again next year ;->
2947 2003-10-13 Jean-Pierre Roux
2948 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2949 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2950 But there are NOT. It's fixed !
2952 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2953 * FIX: "jpeglib.h" was not found on VC++
2954 * FIX: vtkgdcm was not being installed
2956 2003-10-10 Jean-Pierre Roux
2957 * ENH : OpenFile closes the file if it *really* doesn't look like
2958 an ACR-NEMA / DICOM one.
2959 * FIX : testWrite no longer writes an empty file if the source file
2960 is not gdcm Readable
2961 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2964 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2965 * FIX: CMake generate now documentation
2966 * ENH: out of source doc build !
2967 * ENH: Generate both user and dev documentation
2968 * ENH: Should work on windows too
2969 * ENH: Only one doxygen config.in file is needed
2970 * FIX: make install should be ok now on ùnix plateform
2971 * FIX: PATH to dictionary was wrong (missing /)
2972 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2974 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2975 * vtkGdcmReader is now able to read rgb dicom file.
2976 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2977 * added a gdcmViewer to vtk test, use mouse to control
2978 window level & window width
2980 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2981 * CMake-ification of gdcm, we have now two build system
2982 * FIX: on cygwin Wsock32 doesn't exist
2983 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2985 2003-10-06 Emanuel Ollart
2986 * FIX : compilation process wad broken.
2987 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2989 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2990 * change gdcmViewer -> vtkgdcmViewer
2991 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2993 2003-10-06 Jean-Pierre Roux
2994 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2995 ( e.g : well known GE images with a wrong elem length,
2996 : Philips MRI Images with a wrong Huffman table)
2997 * still to be done : allow the reading of bugged LEONARDO Siemens images
2999 2003-10-03 Jean-Pierre Roux
3000 * Odd length strings are padded with '\0' (not with spaces,
3001 to remain compliant with already defined strings,
3002 like Transfert Syntax UID and others)
3004 2003-10-03 Jean-Pierre Roux
3005 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3006 to allow displaying RGB images (not only by affim ;-)
3008 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3009 * vtkGdcmReader is now able to read rgb dicom file.
3010 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
3012 2003-10-03 Jean-Pierre Roux
3013 * A few nasty patches to allow the reading of a lot of nasty images
3014 ( e.g : well known GE images with a wrong elem length,
3015 : Philips MRI Images with a wrong Huffman table)
3016 * still to be done : allow the reading of bugged LEONARDO Siemens images
3018 2003-10-03 Jean-Pierre Roux
3019 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
3021 2003-10-03 Jean-Pierre Roux
3022 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
3023 to allow displaying RGB images (not only by affim ;-)
3025 2003-10-03 Jean-Pierre Roux
3026 * gdcmFile::GetImageDataIntoVector now
3027 - deals with MultiFrames MultiFragments Run Length Encoded files
3028 - deals with YcBcR (YBR_FULL) files
3029 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
3030 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
3032 (no sample found :-(
3034 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3035 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
3036 Two reasons: - clear things
3037 - third parties acces gdcm through header files, so won't
3038 suffer anymore VC++ complains
3040 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3041 * add argv[1] in testvtkGdcmReader.cxx
3044 2003-09-24 Jean-Pierre Roux
3045 * The lines are now eigthy characters long.for
3046 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
3048 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3049 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3050 char* to std::string. Thus, the use of strdup becomes useless. (see
3051 previous commis of Malaterre)
3052 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
3053 before the last Malaterre's commit.
3055 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3056 * This commit should fix the Debug building under VC++, the problem
3057 was mainly a mixture of debug and release lib being loaded at startup.
3058 * I also remove a depency to a specific C function: strdup. Because I had
3059 to force the link to msvcrtd (whereas strdup is in libc).
3061 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3062 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
3063 located in the gdcmCommon.h file. All use of reference of tha has been
3064 changed to now use the variable GDCM_UNFOUND.
3066 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3068 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
3069 Dicom dictionary. The test suite can now be run again. Note:
3070 I'm note very happy with the " (RET)" changes. I believe this
3071 RETAINED comment should be dropped when parsing the dictionary.
3072 - PACKAGER corrected
3074 - AUTHORS updated and now in alphabetical order
3075 * Makefile.am now exports gdcm.dsw for Windoze users.
3077 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3078 * cygwin complains about missing std:: in subdir Test/
3080 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3081 * remove some methods that are now in gdcmHeaderHelper
3083 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3084 * vtkGdcmReader set spacing and origin correctly
3086 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3087 * Fix a few delete/delete[] mismatch
3089 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3090 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
3091 interpretation to data given by gdcmHeader. For instance there are
3092 heuristics to get informations (look at different places).
3093 * it also include a specific class: gdcmSerieHeaderHelper devoted to
3094 sorting DICOM images based on different strategies.
3095 * modified Makefiles accordingly.
3097 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3098 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
3099 when building in debug mode
3100 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
3101 src/win32/gdcmdll.dsp
3102 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
3104 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3105 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
3108 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3109 * src/win32/libgdcmjpeg12.dsp was not dos format
3110 * src/win32/libgdcmjpeg12.dsp :
3111 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
3112 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
3114 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3115 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
3117 * src/gdcmFile.cxx : bug fix in affectation type
3118 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
3119 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
3120 * Modifs of MVSC projects to compile them. Not concerning 2 identic
3121 symbols... future problem ?
3123 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3124 * src/win32/libgdcmijpeg12.dsp was missing
3125 * modified gdcm.dsw accordingly
3127 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3128 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3130 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3131 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3132 commit of JPR (before his hollidays to facilitate our work).
3133 * setup.py : bug fix in code. Modifications made while the last commit
3134 of JPR. The code hasn't been tested before the commit... it's so
3135 useless to make that (for best programmer that is JPR) !!!
3137 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * tagged the current version as Version0_3 (i.e. version 0.3)
3140 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3141 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
3142 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
3143 * *.dsp : modifications to use new libgdcmijpeg8 library
3144 * setup.py : bug fix on VTKPATH variable
3145 * PACKAGER : adding all concerning windows
3147 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3148 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
3150 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
3151 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
3152 test suite reported error.
3153 * PACKAGER file added (describes what a packager must do when
3154 packaging a new release).
3155 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
3156 * configure.in: upgraded version number to 0.3.0
3157 * fixing build of rpm (through rpm -ta):
3158 - Doc/Makefile.am exports proper doxygen files
3159 - src/jpeg/libijg8/Makefile.am exports the include files.
3161 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3162 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
3163 * src/gdcmHeader.h : formatting code
3165 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3166 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
3167 We were obtaining error message from vtk. Now, creation of file list
3168 is made in an internal list to prevent this problem.
3169 Bug fix when output is empty.
3170 Bug fix in update of progress value. Previous commit for this was a bad
3172 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
3174 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3175 * src/gdcmHeader.h : added method to get the file name
3176 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
3177 files. Added method to remove all files on the input
3178 Added FIXME comment concerning the bad parsing of header made by
3179 ExecuteInformation method (in ExecuteData method)
3181 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
3183 when using make instal.
3184 * src/gdcmFile.cxx : bug fix under Window after JPR commit
3185 RQ : the JPR doesn't appear in the ChangeLog... normal for him
3187 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3188 * setup.py : adding include dir of jpeg lib to compile all sources
3189 * */Win32/*.dsp : JPR fix for windows compilation
3191 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3192 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
3194 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
3195 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
3197 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * setup.py is again effective on un*x (takes into account the
3199 addon of the jpeg library)
3200 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
3201 * Doc/Doxy* updated (includes above enhancements)
3202 * INSTALL now points to web documentation
3204 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * src/gdcmHeader.h doesn't make unnecessary reference to
3207 * gdcmPython/Makefile.am now avoids calling the wrappers for the
3209 * src/gdcm*.[cxx|h] :
3210 - to allow compilation with gcc 3.x
3211 -- clean up of STL usage (added explicit usage of std::)
3212 -- small fixes on exceptions.
3213 Note: linking not tested !
3214 - clean of doxygen comments to avoid warnings at documentation
3216 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
3217 dependent convertion).
3219 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3220 * Clean up of previous JPR garbage commit (not even commented in the
3222 - Test/Makefile.am removed the reference to unexisting testTS.cxx
3223 - moved all jpeg related files from src to src/jpeg/libijg8, with
3224 addition/modification of Makefile.am and configure.in.
3225 - the testSuite is still brain damage (not guilty).
3227 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3228 * WrapVTK.py : modifications to get correctly vtk source files to
3230 * vtk/vtkGdcmReader.cxx : modification for an already existing name
3231 (FileName -> Filename)
3233 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3234 * vtk/vtkGdcmReader.[cxx/h]:
3235 - UpdateProgress method should now be effective
3236 - removed the limitation on having only images loaded (as opposed
3238 - when building a stack of images/volume, a lesser number of
3239 gdcmHeader and gdcmFile instances should be used (hopefully
3240 accelerating things).
3241 - when building a stack of images/volumes, files which are not
3242 loadable (wrong path-filename, wrong permissions on existing file,
3243 or file not parsable by gdcm) are replaced with a black image
3244 in the stack (for the caller to notice the problem).
3246 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
3249 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3250 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
3251 between standard library (std) and vtk library (problems are found
3252 under Windows... thanks Windows !)
3254 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3255 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
3257 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
3259 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3260 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
3262 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * When compiling with distutils (see setup.py) the C++ compiler is
3264 called with different flags than the default ones (with automake).
3265 In order to fix all those warning, I compiled gdcm with the command
3266 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
3267 and went for warning fixes:
3268 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
3269 up from unused variables.
3270 - vtk/vtkGdcmReader.cxx: potential bug fix.
3271 * src/gdcmHeader.h: Doxygen warning cleanup
3273 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * gdcmPython/gdcm.i:
3275 - typemaps correction to take into account the systematic replacement
3276 of "using namespace std" with std:: prefix e.g. std::list,
3277 std::string... (cf changes of 2003-05-21).
3278 - gdcmGlob global variable of type gdcmGlobal (defined in
3279 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
3280 exported to Python a as cvar.
3281 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
3282 and GetPubDictTagNamesByCategory() as a replacement for deprecated
3283 gdcmDictSet.GetPubDictTagNames() and
3284 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
3285 C++ static methods).
3286 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
3287 with the above changes.
3289 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3290 * setup.py, manifest.in : bug fix under linux
3292 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3293 * Modification of setup.py to compile vtk part too. Then, we have 2
3294 wrappers which must work with same distutils. For that, we have a
3295 generic distutils in distusiltsWrapping.py ; with :
3296 - build_extWrap class to wrap generically all extensions,
3297 - ExtensionWrap base class for all wrapping extension that contains
3299 - Wrapper interface which wrap sources
3300 + In WrapSwig.py we have extension and wrapper for Swig
3301 + In WrapVTK.py we have extension and wrapper for VTK
3302 * MANIFEST.in : modifications to consider vtk directory and new python
3303 files for compilation
3305 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
3306 * Added python wrappers of vtkGdcmReader vtk class (see the
3307 source in vtk/vtkGdcmReader.cxx) :
3308 - vtk/Makefile.am now builds a library
3309 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
3310 python library (as opposed to _gdcm.so wich are the python
3311 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
3312 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
3314 - configure.in has an additional flag --enable-vtk that needs
3315 to be set to enable compilation of vtk related code, that is:
3316 + vtk/vtkGdcmReader.so and
3317 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
3318 + gdcmPython/vtkgdcmPython.so (see above)
3319 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
3320 be read when compressed or when HighBit + 1 != BitsStored),
3321 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
3322 the usage of the python wrapper of vtkGdcmReader vtk class.
3323 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
3324 * src/*.[h] all occurences of stl classes are now prefixed with
3325 std::, and all occurences of "using namespace std;" where removed.
3326 This is to avoid pollution of global namespace in included files.
3327 Apparently vtk does not avoid this pitfall: when using both
3328 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
3329 collision of various stl members (principally cout...).
3330 * gdcmPython/testSuite.py now cleanly removes temprory generated
3332 * gdcmPython/gdcm.i now declares a typemap for std::string (to
3333 comply with above changes)
3335 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3336 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
3337 * vtk/vtkGdcmReader.cxx now properly inports the image in the
3338 vtk data structure (an image Flip was required).
3339 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
3340 * cosmetic changes in documentation.
3342 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3343 * src/gdcmHeader.cxx: the constructor no longer exits when an
3344 unexisting file is given as argument.
3345 * The subdirectory Data (containing all the images used for the
3346 test suite) is not part of this repository anymore. A new module
3347 containing those images is now available at
3348 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
3349 with the name gdcmData.
3350 All the python scripts (including the package initialisation file
3351 gdcmPython/__init__.py) were adapated to take this change into
3352 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
3354 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3355 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
3356 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
3357 demo of the usage of this class.
3358 Compilation of this vtk part is only done when using the --enable-vtk
3359 at configure (or autogen.sh) stage.
3361 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3362 * More memory link related corrections and documentation fixes.
3364 - maximum info is obtained with a command of the form:
3365 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
3366 --show-reachable=yes PrintHeader
3367 - the remaining reachable blocks seem to come from the STL
3368 allocation scheme through the usage of map and list. It looks
3369 like this memory cannot be freed but it is not a memory leak
3370 (in fact further invocation to the STL would recollect the
3371 unused memory allthough it cannot explicitely be freed).
3372 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
3373 of displaying an image parsed with gdcm and displayed with VTK.
3374 Note: some images don't seem to work e.g.
3375 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
3376 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
3377 Allthough this weakens the semantics, it is a ditch attempt to
3378 make gdcm more thread friendly.
3380 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3381 * Memory link hunt (by using valgrind through the command
3382 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3383 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3384 gdcmHeader::_dicom_vr.
3385 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3386 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3388 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3390 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3391 * src/Makefile.am now exports all the necessary include files at
3395 * UpdateGroupLength replaced by new one
3398 * UpdateGroupLength re-written using H-Table
3399 (named UpdateGroupLengthNew untill checks are over)
3401 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3402 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3403 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3405 - gdcmHeader::GetPubElValSet removed.
3406 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3407 UpdateGroupLength, WriteElements, Write.
3408 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3409 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3410 carried the same semantics.
3411 - src/gdcmHeaderIdo.cxx changed accordingly.
3412 - gdcmFile::WriteBase now regroups all the codes from previous
3413 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3414 - enum FileType moved to gdcmCommon.h
3415 * src/gdcmHeader.cxx AddDefault trashed
3416 * gdcmGetXSize added
3417 * getimageDataSize now calls gdcmGetXSize
3418 * Test/*.cxx changed to agree with above changes
3420 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3421 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3422 (to avoid double call by end user).
3423 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3424 by end user, since gdcmHeader::gdcmHeader now handles it.
3426 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3427 * gdcm/Doc many doxygen changes:
3428 - Doxyfile now has two different versions, DoxyfileUsers that generates
3429 the html.users end users oriented documentation and
3430 DoxyfileDeveloppers that generates the html.developper developper
3431 oriented documentation.
3432 - README changed accordingly
3433 - requirement.txt removed (old design info moved to TODO).
3434 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3435 DoxyMainPage.txt, DoxyPython.txt provide more information.
3436 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3437 be updated by simply regenerating the docs with doxygen and copying
3438 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3439 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3440 all the tests in the form "if (<map>.count() >1)" were removed.
3441 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3442 ill-formed documentation sections.
3443 * src/gdcmHeader.cxx: ditto
3445 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3446 * setup.py fixed for un*x (needed macro for stdint.h)
3447 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3448 un*ces with sh-utils test utility.
3449 * gdcmPython/demo/test.py renamed to PrintHeader.py
3450 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3451 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3452 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3453 * src/gdcm*.cxx JPR's bad inclusion fixed.
3455 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3456 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3457 * gdcmPython/demo/test.py changed accordingly.
3459 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3460 * gdcmPython/Makefile.am fixed linking against libstdc++
3461 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3462 * Swig subdir (historical tests of swig version 1.3.17++) removed
3463 * Test/testChangeEntete.cxx some lines commented out in order to make
3465 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3466 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3468 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3469 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3470 hence the user doesn't need this explicit call.
3471 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3472 i.e. LoadElements() call removed.
3473 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3474 - src/Makefile.am declares the proper flag for g++.
3475 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3476 for adding user defined new tags.
3477 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3478 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3479 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3481 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3482 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3483 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3484 src/Makefile.am : the project should properly compile and install
3485 with the autotools, included the python wrappers part.
3486 * gdcm.spec.in : added a spec file for RPM packaging.
3488 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3489 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3491 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3492 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3493 to exported to the environement (see gdcmPython/testSuite.py
3495 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3496 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3497 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3498 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3499 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3501 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3502 * gdcmPython/__init__.py doesn't crash anymore when running in
3503 in InstallMode or PreInstallMode but with an environment given
3504 value of GDCM_DICT_PATH.
3505 * src/gdcmDictSet.[cxx/h] coding style.
3507 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3508 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3509 * src/gdcm.h general comments moved to TODO, and README
3510 * src/gdcm.h should now be seen as a user commodity (including it
3511 should suffice to fully use gdcm). It is nowhere including within
3512 any of the kernel files src/*.cxx and src/*.h.
3514 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3515 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3516 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3518 * src/gdcm*.cxx only include their corresponding include file
3519 (as opposed to gdcm.h)
3520 * gdcmPython/gdcm.i changed accordingly
3521 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3522 the autogen.sh generated "make snapshot" command to work.
3523 * autogen.sh removed history related references to crea package.
3525 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3526 * distutilsSwigCPlusPlus.py work around some swig portability
3529 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3530 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3531 was done in a last ditch attempt to get setup.py _really_
3532 operationnal. The python/gdcmPython layaout add the advantage
3533 of hidding away the python related distutils specific files
3534 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3535 Alas, the src directory was out of scope (i.e. it's relative
3536 position to setup.py was ../src) which made things impossible to
3537 handle (see previous version of python/setup.py). Crossing fingers...
3539 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3540 * python/setup.py now works on Un*x. (harder than I thougth)
3541 * python/distutilsSwigCPlusPlus.py can now have include files
3542 among the list of sources.
3544 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3545 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3546 * modifications in MSVC projects
3548 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3549 * As stated by the first lines of Test/ExceptionAndPython/README, it
3550 looks like we can move back to original usage of exception within
3551 src/gdcm* and hence remove the errno stuff that was introduced
3552 as a quick and dirty fixture of this problem (added to the TODO).
3553 * Doc/Doxyfile configuration file for Doxygen and corresponding
3554 README file for usage added.
3555 * Test/testWrite.cxx added. This new test comes from a split of
3556 test.cxx that is now reverted to its original purpous i.e.
3557 testing the proper parsing of a Dicom related file.
3558 testWrite.cxx concentrates on testing the IO part of gdcm.
3559 * Test/bug1.cxx (containing a bug on WIn32) added.
3560 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3561 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3562 whose purpose is to publish the content of the TagNames of the
3563 Dicom public dictionary were not accessible without an
3564 instance of class gdcmHeader.
3565 - those methods are now static methods of gdcmDictSet and hence
3566 require no instances at all to be invocated.
3567 - within gdcmDictSet this change required to change some method
3568 to class methods (i.e. are now static) among which SetDictPath
3569 (renamed to BuildDictPath) and LoadDefaultPubDict.
3570 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3571 the above changes by calling the new method classes of gdcmDictSet.
3572 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3573 the above to be effective.
3574 * python/gdcmPython: in order to wrap properly the above changes
3575 for Python, swig version now needs to be > 1.3.17.
3576 * python/gdcmPython/Makefile fixed to adapt itself to new
3577 configure/make shema introduced by Johan Montagnat (thanks for the
3578 contribution). Alas this Makefile cannot be turned into a proper
3579 Makefile.am without some heavy changes in the configure.in
3580 (for python dectection).
3581 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3582 now avoids publishing the empty entries.
3584 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3585 * python/setup.py : bug fix concerning install under windows
3586 ExtraPath reused :-P
3587 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3589 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3590 * Dicts/dicomV3.dic : remove double spaces !!!
3591 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3592 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3595 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3596 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3597 method. Doxygenation.
3598 * src/gdcm.h clean up of JPR spurious comments.
3600 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3601 * python/distutilsSwigCPlusPlus.py now properly collects the
3602 shadow classes generated by "swig -c++" (gdcm.py in our case)
3603 when using "python setup.py install".
3604 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3605 reexports the working classes.
3606 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3607 by the classical C errno scheme. This is to prevent an obscure
3608 behavior of the python wrappers when importing wxPython.wx prior
3609 to gdcmPython (which ended up in an abort call). An illustration
3610 of this oddity can be found in the Test/ExceptionAndPython
3611 subdir (see the README file). This problem probably due to
3612 an combination of g++ and dynamic loading.
3613 * added Test/ExceptionAndPython (see above)
3615 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3616 * Changed the layout of the python part to avoid bloating main
3617 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3618 i.e. the distutils arsenal. All the python related stuff is
3619 again in a python subdir, but the package itself is now in
3621 * setup.py was cleaned up:
3622 - pythonIncludePath removed
3623 - python setup.py bdist target is now functional.
3624 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3625 collision with other packages). gdcmPython/demo/*.py changed
3628 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3629 * python subdir moved to gdcmPython (preparation of distutils packaging).
3630 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3631 distutils installer is operational.
3632 * - gdcmPython/__init__.py now properly loads the swig generated
3633 shadow classes (from gdcm.py).
3634 - gdcmPython/demo/*.py changed to import the package gdcmPython
3635 instead of gdcmPython/demo/load.py.
3636 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3638 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3639 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3640 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3641 entries within the associated public Dicom dictionary resp. the same
3642 information but sorted by the fourth field (PAT, IMG, DIR) of the
3644 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3645 are now in the "???" group.
3646 - python/gdcm.i changed accordingly,
3647 - python/demo/printGroupedPublicDict.py added, that gives an example
3648 of the above new functionalities in Python.
3650 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3651 * src/gdcm.h, gdcmHeader.cxx:
3652 - historic references to glib's g_malloc and g_free (#defined)
3653 were definitively removed.
3654 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3655 * src/gdcmElValSet.cxx:
3656 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3657 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3658 - GetElValue(string) renamed to GetElValueByName.
3659 - Added GetElementByName(string).
3660 * src/gdcmHeader.cxx: added
3661 - GetPubElValRepByNumber(guint16, guint16)
3662 - GetPubElValRepByName(string)
3663 - GetShaElValRepByNumber(guint16, guint16)
3664 - GetShaElValRepByName(string)
3665 - GetShaElValByNumber(guint16, guint16)
3666 - GetShaElValRepByName(string)
3667 - GetElValRepByNumber(guint16, guint16)
3668 - GetElValRepByName(string)
3669 - GetElValByNumber(guint16, guint16)
3670 - GetElValRepByName(string)
3671 * Doc/requirements.txt added.
3673 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3674 * Test/Makefile building now depends on the one of libgdcm.so
3675 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3676 pixel data) aware which enables finding the address (offset) of
3677 the pixel data of JPEG encoded DICOM files. This leaves only a single
3678 file in the testSuite whose pixel data address (offset) is unknown.
3679 * python/testSuite.py changed accordingly.
3681 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3682 * VC++ has some strong limitations when working with the STL, as stated
3683 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3684 "Also note that some STL containers (map, set, queue, list, deque)
3685 cannot be exported. [...]
3686 Some STL classes contain nested classes. These classes can not
3688 This is caused by a designed limitation that once a template
3689 class is instantiated, it can not be re-instantiated and
3691 Since our usage of map<> is ubiquitous in gdcm, this "designed
3692 limitation" of VC++ is a pitfall.
3693 Hence the Python wrappers of gdcm cannot be incrementally linked
3694 against the c++ dynamic library. The dirty but only workaround is
3695 to forget about incremental link of dynamic libraries and to generate
3696 the Python wrappers library with the inclusions of the underlying C++
3698 The following modifications concern this matter on Win32/VC++:
3699 - wrapping python correct with standalone wrapped dll (don't use separate
3700 dll under windows !!!!)
3701 - python21_d debug mode enabled (ask Frog how to use it :-)
3702 - NO problem with having an STL member of class for example string in C++
3703 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3704 - Python test of dcmlib in Python is ok under windows on a large set
3706 * removed glib references
3707 * typedef's inserted in gdcm.i for correct swig type management
3709 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3710 * python/demo/*.py load.py extracted from test.py. Added explore.py
3711 that only displays required tags and testAll.py that parses all
3712 the files of the testsuite without using unittest.
3713 * python/testSuite.py other additional test on new files added.
3714 * Data/* new test files added accordingly to the testSuite.
3715 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3716 the vr in the file differs from the one of the dictionary.
3718 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3719 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3720 values, but limits itself to values which are below a user specified
3721 size (by default 1024 bytes).
3722 * python/gdcm.i : elements not loaded (because their size is above the
3723 user specified treshold) are exported with their TagKey as key of the
3724 python dictionary. This enables the testsuite to make some checks
3725 on the unloaded elements (since we have their offset and size).
3726 * python/testSuite.py
3727 - now tests for the existence and proper value of the pixel data
3728 - two new examples added.
3729 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3731 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3732 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3733 aware. See the strategy comments in gdcmHeader::FindLength().
3734 * Test/test.cxx now accepts a filename as first argument.
3735 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3736 * python/testSuite.py changed to integrate test on above files.
3738 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3739 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3740 the vr was also RET.
3741 * python/testSuite.py more tests added.
3743 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3744 * python/testSuite.py unittest test suite added (uses Data)
3745 * Data/* dcm and acr files for the test suite.
3746 * glib dependance removed from un*x version. We now use ISO C99
3747 7.18 Integer types (see stdint.h)
3748 - python/Makefile, src/Makefile src/gdcm.h
3749 * src/ when an explicit vr (like dicom files) suddenly poped an
3750 implicit element we use to mark the underlying DictEntry of the
3751 concerned ElValue with "Implicit". This strategy was damageable
3752 too the public or provite dictionaries, since some of their vr
3753 would be changed. Since Header::FindLength heavily relies on the
3754 detection by Header::FindVR of falsely explicit elements, I
3755 added an extra ImplicitVr member to ElValue (boolean).
3756 The rest of the changes we the necessary adaptations.
3758 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3759 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3761 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3763 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3764 * Adaptation for porting to VC++:
3766 o forced to use std namespace (for string to be known)
3767 o all class use __declspec export style on WIN32
3768 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3769 (in stdlib.h on Win32 but in std:: for gcc)
3770 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3771 variable GDCM_DICT_PATH.
3772 * src/gdcmHeader.cxx verbose comments made discrete.
3774 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3775 * python/gdcm.i: added a typemap that converts a C++ hashing table
3776 to native Python dictionary.
3777 * python/demo/test.py:
3778 - now uses the native dictionary for exploration of gdcmHeader.
3779 - takes an optional filename argument (the file to parse).
3780 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3781 PubElVals hashing table.
3782 * Dicts/dicomV3.dic removed error prone trailing spaces.
3784 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3785 * Python wrapping process moved away from src/Makefile to
3786 newly created python/Makefile (as well as gdcm.i)
3787 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3788 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3789 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3790 from the environement variable GDCM_DICT_PATH (when existing).
3791 * src/gdcmDict::GetTag bug fix.
3793 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3794 * Straightforward temporary fixes for swig to build the python wrappers.
3795 src/Makefile now has a python working entry [by working we mean
3796 that we can import the shadow classes without errors].
3798 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3799 * hashtest.cxx removed (since already in Test)
3800 * src/gdcmlib.h renamed to src/gdcm.h
3801 * src/dcm.i renamed to src/gdcm.i
3802 * src/Makefile prepared for python wrapping
3804 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3805 * src/gdcmHeader.cxx :
3806 - Parsing of header is now separated from loading of element values
3807 (see gdcmHeader::LoadElements).
3808 - general clean up of hopefully all file access (creation of
3809 ReadInt16 and ReadInt32)
3811 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3812 * src/gdcmHeader.cxx :
3813 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3815 - SetLgrElem renamed to SetLength
3816 - GetLgrElem renamed to GetLength
3817 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3818 * src/gdcmElValSet.cxx fixed both GetElValue methods
3819 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3820 due to IdoDude was cleaned out.
3822 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3823 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3824 concentrates on finding the value representation (when it exists).
3825 RecupLgr now only finds the element value length, and it avoids
3826 returning the unecessary skL (skipped length).
3827 Also, offsetCourant was simply removed (with taille_fich) since
3828 it was redundant with the File position internals (by using
3829 ftell and fseek). This also made skL (see above in RecupLgr) usage
3831 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3832 on the libido specificities which are handled through class
3834 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3837 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3838 * Truckload of changes. Parsing of header is barely functional
3839 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3841 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3842 * src/gdcmHeader.cxx many addons of low level methods
3844 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3845 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3846 and _IdDcmSWAP_LONG.
3848 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3849 * This corresponds to all the changes decided at the meeting of
3850 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob