1 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Rewrite the base 256 to base 10 conversion, using string operation only.
3 This allos us to get rid of the problematic 64bits integer type (does not
4 alwyas exist on target platform).
6 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * Add construct and destructor to class gdcm::Debug to close the debug file
9 * Don't let uset to open twice the same file
10 * gdcm has now an official UID prefix,
11 supplied by http://www.medicalconnections.co.uk
12 1.2.826.0.1.3680043.2.1143
13 (Thx to Mathieu for providing URL)
14 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
15 to be able to perform some more tests
16 * gdcm::ContentEntry : Contructors and Destructor are now protected,
17 in order to be sure no user will try to use them.
18 (at user level, only the children classes are meaningfull)
20 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * move RLEInfo & JPEGInfo from Document to File
23 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * FIX : remove so many friend between classes
26 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
28 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
30 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
31 In order to avoid missbehaviour :
32 . gdcm::DocEntry is now specialized in
33 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
34 - gdcm::ContentEntry (Dicom entry with a 'content')
35 . gdcm::ContentEntry is specialized in
36 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
37 characters value, or integers)
38 - gdcm::BinEntry (Dicom entry with a non strig representable value
39 (user hasn't any longer to thing about the precedence of his dynamic_casts)
41 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Test/VTKTest*.cxx : bug fix under linux
44 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
46 use with python. Some methods are moved from Document to ElementSet or
47 DocEntrySet. The equivalent methods to ElementSet have been added to
48 SQItem and are virtual in DocEntrySet. Methods that may have the same code
49 in SQItem and ElementSet is directly placed in DocEntrySet
51 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Test/VTKTest*.cxx : remove the show variable in each test method because
53 it's useless (the viewer variable replace this variable)
55 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmDocument.cxx : bug fix on potential memory leak
57 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
58 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
59 Add ClearXxx methods to remove all the content of the list or map
60 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
62 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
63 * methods ReplaceOrCreate renamed as Insert
64 (nobody will be any longer confused by 'CreateOrReplace')
66 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * Grealty simplify the JPEg decompression, no need to differenciate based on
68 the JPEG possible type (with/without fragment, with/without multiple frame).
69 Everything is done throught the JPEG IO Suspension mechanism in IJG
71 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
72 * Stage 3 of normalization :
73 in order to avoid any missunderstanding while reading method names :
74 - All the methods xxxEntry now deal with dicom Entries
75 - Methods GetEntry splitted into
78 - Method SetEntry renamed as SetEntryValue
79 - Method SetEntryBinArea let as it was
81 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
82 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
83 - Position correctly the entry points for JPEG2000 and JPEG-LS
84 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
86 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
88 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
89 with other method names
90 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
91 * Test/TestDicomDirElement.cxx : add new test
93 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
95 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
96 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
97 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
98 So can't you use __int64 in ostream at all.
100 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * bug fix for compilation on MSVC6
102 * gdcmPython/gdcm.i : rename of classes missed
104 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
105 * Stage 2 of names normalization :
106 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
107 (easy to understand ...)
108 - gdcm::FileHelper replaces old class gdcm::File
110 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
112 type and not a string. So, there remove problems on the format of the
115 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * Add Example/TestPapyrus.cxx
117 - reads a Papyrus file (gdcm::Header compliant),
118 - gets the pixels of all the images, using low level iterators
119 - writes an multiframes Dicom image.
120 (Just to show it's *possible* to do that)
121 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
124 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
126 Thus, DicomDirXXX are created with a flad that indicates if the created
127 object is empty or not (when not empty, the DicomDirElement is used to
130 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
132 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
134 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
137 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
139 Remove all access to the hash-tables or lists in the objects.
141 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
143 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
144 be complient with all the gdcm source code
146 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
150 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
154 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * Test/ : rename VTK tests to have a best name for the tests
156 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
157 GetFirstEntry/GetNextEntry use
159 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * In SerieHeader::ImagePositionPatientOrdering()
161 // a Dicom 'Serie' may contain scout views
162 // and images may have differents directions.
163 // -> More than one may have the same 'pos'
164 // Sorting has then NO meaning !
165 Thx to Eduardo Davila for reporting bug.
167 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
169 test. Now it's on image content and not on the resulting visualisation...
170 might solve the problem on linux when using the OpenGL drivers
172 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
173 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
174 DicomDirSerie, DicomDirImage
175 Dict, DictSet classes :
176 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
177 -remove InitTraversal method.
178 * UPD Test programs + Example programs
180 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
181 * remove useless and never updated keyword \ingroup
182 * Solve pb when structure (list, map, ...) is empty.
183 Thx to Benoit for reporting bug
185 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
186 * Taking into account of 'Transfer Syntax' value
187 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
190 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
192 is no memory access violation
193 * gdcmPython/demo : add python demos using VTK
195 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
196 * FIX 'Dictionnary' is now spelt 'Dictionary'
197 'wether' is now spelt 'whether'
198 'archieve' is now spelt 'archive' ;-)
200 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
201 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
202 related methods, in order not to expose internal mechanisms
205 * REM methods that exposed internal mechanisms :
206 DicomDir::GetDicomDirPatients()
207 DicomDirPatient::GetDicomDirStudies()
208 DicomDirStudy::GetDicomDirSeries()
209 DicomDirSerie::GetDicomDirImages()
210 * UPD Test programs :
214 * UPD Example program
216 * ADD DictSet methods
220 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Removed the Print/indent/default parameter mess. There is absolutely no
222 reason to have to methods, moreover with the second taking the ostream as
223 *SECOND* parameter. This was clearly a bad hack to get things compile.
225 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
226 * Complete rewrite of the GetMacAddress code. Now the code is *much*
227 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
228 Unfortunately the main code does not work on SunOS, thus provide a specific
229 code for this platform only (and Win32 of course). Since this seems to be
230 working, change CreateUniqueUID to use GetMACAddress instead of the
231 problematic GctestetIPAddress
233 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
234 * Unfortunately to be able to test gdcmDirList I had to break the API
235 a little. Now the class is not a std::list anymore but has a member
236 std::vector (more ITK compatible). Allow unit testing on Win32 and
239 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
240 * Update SerieHeader to take into account a Serie Instance UID to properly
243 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
244 * ENH - Comment out Mathieu's (dangerous) Super Hack
245 for dealing with BIGENDIAN processors
246 - Move equivalent stuff to BinEntry::WriteContent
247 When necessary, 16 Bits Pixels are swapped in a small buffer
248 and then written. This avoid allocating a huge buffer, in
249 PixelWriteConvertor, and avoid modifying the Pixel Area.
251 Probabely, the same operation will have to be done when we want
252 to write image with Big Endian Transfert Syntax,
253 and we are working on Little Endian Processor
255 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
258 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
259 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
260 all the dict content.
261 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
263 * Test/TestDict.cxx : add a new test for the dict classes
265 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
267 file. Debug is yanked if compiled with NDEBUG
269 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmDictSet.h : set the default output to the os variable
271 * src/gdcmDictEntry.[h|cxx] : add the Print method
272 * gdcmPython/demo/ : add a new test
274 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
275 * merging of Test/PrintDicomDir and Test/TestDicomDir
276 * removal of now redundant Test/PrintDicomDir
277 * enhancement of Example/PrintDicomDir
279 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * Now, python test might work on systems
281 * Add the PrintDicomDir test
283 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
284 * FIX : First entry following group 0002 was lost for
285 Explicit Big Endian Transfer Syntax files
286 (group and elem not swaped)
288 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
289 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
290 Big Endian Transfer Syntax supposed the group following 0002
291 begins always by element 0000 (element 0000 is *optional*)
292 To avoid further troubles, let's be pessimistic, and use
293 Document::HandleOutOfGroup0002() method
294 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
295 (related pb not yet solved)
297 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * Bug fix for the python part use
299 * Now, PrintHeader.py pass... but outside the ctest use. shit !
301 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
304 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
306 a string and should ask the global TS dict what are the propreties of
309 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
310 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
311 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
312 to swap the Swap Code, at parsing time, when we come out of group 0002
313 and Transfer Syntax is Big Endian
314 We should be able to read now 'true DICOM" Big Endian coded images
315 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
316 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
318 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Hopefully fix the bug on MacOSX and static global initialization.
320 This is the only -minor- patch I found that both please MacOSX and VS6.
321 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
322 but this would require a lot of change. Another approach would be that Global
323 create those string and GDCM_UNFOUND becomes a pointer to a string (which
324 gdcm::Global would destroy at exit).
326 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Fix bug on MacOSX with static initialization in a multy threaded
328 environment. static const string in a header file used to be ill
329 initialized provoquing the freeze of any tests. patch should solve this
332 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * According to Benoit's suggestion, and without any objection from anybody
334 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
335 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
336 - method gdcmDicomDirObject::GetEntry() renamed as
337 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
339 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
341 you debug/warning message just as c++ streams which make them very convinient
342 to use. Once this is stabilize I will change the ostringstrem to be
343 redirected to a file (ofstream).
344 * Properly support C99 extension: __FUNCTION__ which allow us to display
345 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
347 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
348 * Removal of useless and dangerous methods :
349 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
350 GetDocEntryByName, GetEntryByName, GetDictEntryByName
351 * Removal of usless methods :
352 Dict::PrintByName, Dict::GetDictEntryByName
353 * Commenting out of probabely useless methods :
354 Dict::GetDictEntryNames()
355 Dict::GetDictEntryNamesByCategory()
356 DictSet::GetPubDictEntryNames()
357 DictSet::GetPubDictEntryNamesByCategory()
358 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
359 * ENH : Use dicomTS.dic as described in 2004 version
360 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
361 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
362 Add Accessors on VM (Value Multiplicity), and VM related methods
363 * ADD : Add a list of 'Dicom Attribute types', as found in
364 http://medical.nema.org/dicom/2004/04_15PU.PDF
366 * ADD : Add dicomGroupNameAbbreviations.dic
367 should be used to write a method to replace the former
368 Dict::GetDictEntryNamesByCategory()
370 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
372 to read in the file... and only it ! Length is the efective length of the
373 data in the DocEntry structure
375 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
377 And now use a static function call instead, with a global variable. i
378 This is much closer to the VTK approach. Hopefully should be bulletproof
379 and easier to use...hopefully
381 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
382 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
384 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
385 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
387 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
389 ValEntry, BinEntry, SeqEntry creation or replace
391 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
393 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
395 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
396 when specifying the VR
397 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
398 * src/gdcmDocEntry.cxx : amelioration of print
400 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
401 * ADD : Add the method Util::IsCurrentProcessorBigEndian
402 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
403 * ADD Method Document::ComputeGroupLength
404 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
405 in order to allow further VR modification by user
406 * REM : removal of once-called method File::WriteBase
407 integration of its code in formerly one-line method File::Write
409 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
411 replace the different values "??", "Unkn", "Unknown".
412 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
413 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
414 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
415 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
417 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
420 * Set the gdcm::Base class to some Printable classes
422 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmFile.[h|cxx] : add the Print method
424 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
425 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
426 * src/gdcmDocument.h : remove the PrintLevel informations
427 * Example/PrintFile.cxx : use the new gdcm::File::Print
429 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
431 problems when compiling with the python wrapping
433 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
435 writting in ImplicitVR
437 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
438 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
439 JPEG decompression, especially when dicom frames are split into several
440 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
441 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
443 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
444 * src/gdcmHeader.cxx : change the initialisation of default header.
445 Now, this header is readable by gdm, e-film, DicomWorks
447 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
449 Rename Decompressed to Raw
450 * Use the API changes in gdcm::File.
451 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
454 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
456 each added entry in the header. Replace the 'Planes' field by the 'Number
459 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
461 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
463 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
465 At this time, this image isn't readable by e-film... waiting JPR help to
468 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
470 DocEntry. Now use methods of the Document !
472 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * Test/ShowDicomSeq.cxx : bug fix
475 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
476 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
477 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
478 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
479 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
481 * Test/TestCopyRescaleDicom.cxx : remove unused variable
482 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
483 containing found sequences
485 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
488 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
489 Some fields in BinEntry must be copied to not seg fault when making the :
490 gdcm::File *copy = new gdcm::File( copyH );
491 and tests are now made on good variables
493 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
495 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
497 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
498 * Add vtkGdcmWriter example and test
500 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * Test/TestUtil.cxx : reformat the source code
502 * vtk/vtkGdcmReader.cxx : remove and change prints
503 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
505 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
506 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
508 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
509 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
510 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
512 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
514 by an eof to prevent all bad read of the file... and in this case, the
517 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * Example/Volume2Dicom.cxx : comment unused variables
519 * Test/PrintDicomDir.cxx : comment unused variables
520 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
521 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
522 method that is redondant with AddEntry.
523 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
526 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * Bug fix due my last commit (compilation under Windows).
528 * Example/Volume2Dicom : bug fix in the file and reformatting source code
529 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
531 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
533 - Remove printf / sprintf
534 - include iostream AFTER gdcm so we don't get warnings
535 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
537 - Also remove tons of include from header files, hopefully this should
538 speeup the compilation time, since it was becoming a dog slow.
539 - Remove gdcm.h as it include way too many files and slow down compilation
540 (plus it is not up to date)
541 - remove 'using namespace std' this is BAD !
543 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * Remove memory leaks on the DicomDir
545 * Remove some useless data in DicomDirObject
546 * Add usefull methods in SQItem, to be complient withe the ElementSet
548 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
551 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
553 future, with convertion)
554 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
555 and ImageDataSize values. Remove the method to get the PixelReadConverter
556 from the output of the class
558 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
559 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
561 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
563 and vtkErrorMacro use.
564 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
566 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
569 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
570 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
571 The string leaves only in the fonction. So when we make a .c_str(), we
572 get the pointeur on the first element, element that will be destroyed
573 immediately after thee instruction.
574 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
575 file has been opened : the test must be made on the content of the
576 pointer and not directly on the pointer !
579 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
581 the python part recompiles
583 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
585 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
586 X session is killed (for my computer... it seems to not be identic on
589 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
590 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
591 avoid problems (otherwise, the difference test between the visible image
592 and the reference is incorrect. If the reference is greater than the
593 screen resolution, it's produce errors).
594 Can be used for only one image. Can be used with a visible flag.
595 * vtk/vtkGdcmReader.cxx : remove commented codes.
596 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
597 under windows at compilation
598 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
600 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
602 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
604 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
605 tests on the image size X, Y, Z
607 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
609 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
610 between the class name and the file name
612 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * src/ : fix compilation warnings for the Write method (2 different
614 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
615 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
616 variable... create a static method in gdcm::Document to access to
617 this variable content.
619 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
620 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
621 file, to be accessed by other files (like gdcmFile). Remove commented
622 code. Move the change of the header to the gdcmFile, using the
624 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
625 To be sure of that (and simplify calls), the Write of the header now
626 gets a file name and not a file pointer (std::ifstream).
627 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
628 DocEntryArchive. Remove all open of the written file
630 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
633 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
634 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
635 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
637 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
638 some corresponding methods. Write correctly the file and check before
640 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
641 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
642 is now on RGB data (as before my last commit
643 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
645 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
647 Add a print information of the type of the entry
648 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
649 It was in the gdcmFile, and all write have been regrouped
650 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
651 Write correctly all dicom files (in decompressed mode only at this time)
652 * Test/ : test on files are now made using Raw data and not color data if
654 * Example/PrintFile.cxx : add more printings
656 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * Amelioration of code, remove some code copy. For the loading of
658 BinEntry (in gdcmDocument), add the test to verify if the file is already
661 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
663 remove a DocEntry in the header (push an empty DocEntry)
664 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
665 lines. Bug fix in the initialization of the PixelConvert and the
667 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
668 use in TestCopyDicom (now this test can run under windows... but fails)
669 * Test/TestCopyDicom.cxx : amelioration of the test :
670 - test the pixels written
671 - add test points to quickly find where is the error
672 - can set a file name input and output in arguments
673 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
674 amelioration of the test output
676 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
677 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
678 all replaced DocEntry's
679 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
680 Now, each needed DocEntry to modify is duplicated, modified and inserted
681 to the header using DocEntryArchive. Thus, after save, we can restore the
682 header initial state.
684 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
687 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
689 correct to copy it. The DictEntry is specified at the DocEntry creation,
690 then, it musn't change in the time.
691 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
692 header correctly. At this time, the change is only made for the first
693 level of the Document. In the future, it might consider sequences.
694 The change is made by replacing a DocEntry by an other that is created
695 outside the class. The old value is kept. When we restore the header
696 status, the added DocEntry is deleted and replaced by the old value.
697 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
698 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
699 set the write type to explicit VR, implicit VR or ACR. Add methods to set
700 the write mode to native, decompressed or RGB (but not used at this time)
702 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
704 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
706 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
707 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
708 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
710 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
711 set because already copied when copying the BinEntry's of the header
712 * Test/TestAllReadCompareDicom.cxx : remove warnings
714 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
716 Two problems appear when doing it :
717 - with the gdcmFile : when the GetImageData method is called, the pixels
718 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
719 data (pixels). And each structure destruct the data when it's
720 destructed. So we have two destructions for the same data. To solve it,
721 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
722 data or not. If it doesn't own data, then they will not destroyed by
724 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
725 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
726 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
727 create a double destruction of the same DocEntry's. So, to solve it,
728 the TagHT is simply cleared and the DicomDir* elements are destroyed.
729 * TODO : add an entry concerning memory leaks in the DicomDir
731 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
733 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
736 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
738 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
739 after it have been deleted
741 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * FIX: src/* fix the doxygen warnings.
743 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
744 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
745 was erroneously defined with a size of 15 instead of 16. [many thanks
746 to Jean Michel Rouet for pointing out this bug].
748 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
749 1. Finish merging JMR patch for writting DICOM from scratch
750 2. Fix -hopefully- bug with MONOCHROME and space vs null character
751 3. Use const ref when possible
752 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
753 5. A few more comments
754 6. CreateUniqueUID can now be called without parameter"
756 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
757 * ENH: Slightly bigger patch:
758 1. Getting toward full integration of JMR patch for writting dicom from scratch
759 2. Update Test to test part of this patch: CreateUniqueUID
760 3. File was not close properly in gdcmDict
761 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
762 5. Use of const ref instead of copy (speed issue)
763 6. Remove temporary (duplicate) string in TranslateToKey
764 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
765 8. Do not repeat virtual in subclasses
766 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
768 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
769 * Apply first patch toward better string comparison when dealing with broken
770 DICOM files. Essentially the string could be padded with a space instead
771 of a null character as defined by standard
773 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
774 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
775 because never used... and in the same time, that's remove some memory leaks
777 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
778 * src/gdcmFile.cxx : now delete the PixelConvert instance.
779 * In examples and tests : change the type of image data variables from void*
780 to uint8_t*. Remmove all delete on image data variables
782 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
784 Verify the file pointer value before open the file, and if it's not null,
785 a verbose message is generated.
786 Close correctly the file when the file isn't considered dicom-like. The
787 correctly close is a call to CloseFile.
788 When closing the file pointer, test if its not null to close the file.
789 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
790 file. For an uncompressed image, the copied data correspond in the least
791 case to the image size (calculated) or the image size specified in the
792 header. A verbose is generated if these two size mismatch
794 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
795 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
796 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
797 break under windows (with msvc6 compilation).
799 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
800 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
801 compiling with MSVC6)
803 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * Bugs fix for the Windows build with VC6
805 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
806 needed (only for projects required VTK). If the VTK is included in all
807 projects, there is conflicts with the jpeg lib of vtk when compiling the
808 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
809 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
810 when compiling the gdcm_wrap.cxx file (created by the compilation of the
812 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
813 (like it's already made for the cout use). Otherwise, conflict with the
816 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
819 - comments on the DicomDir::Method related usage added.
820 - now that we use the namespace gdcm, a lot of internal classes do
821 NOT need to be wrapped anymore.
822 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
823 DicomDir::Method) new example added.
825 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
826 * Improve string manipulation. I now inforce the notion of 'DicomString'
827 A DicomString can contain as many \0 as they want
828 and it is *always* of even length.
829 We only support odd length for very rare case.
830 And in the near future this should be removed.
832 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
833 * /binary_write/ gdcm source. Now even on big endian we are writting
834 little endian. This should -heopfully- fix some tests
836 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
837 * Now the dictionary is compiled into gdcm lib. This is a default
838 behavior, thus any dic file specified is picked before failback to
839 the one comiled into lib
841 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * Change internals for gdcmDict. Don't use any 'new' any more.
843 This should definitely solve any leak problem, and we should be
844 as fast as before, as long as don't modify too much the dictionary.
846 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * STYLE: ivars should start with a capital letter.
848 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
849 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
851 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
853 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
854 new 2004 dictionaries added (thanks to JPR).
855 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
856 * CLEANUP_ROUND (15) for gdcmPixelConvert
857 - RLEFrame::NumberFragments is now of type unsigned int
858 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
859 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
862 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
863 * Initial work in gathering all transfer syntax accessors. clearly
864 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
865 ivars, but only one transfersyntax (class) ivar with equivalent method on
868 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
869 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
870 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
871 discussed (plus I didn't like having a 2000 lines patch not commited)
873 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
875 * CLEANUP_ROUND (14) for gdcmPixelConvert
876 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
877 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
878 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
880 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
881 anymore and hence avoids storing a copy of PixelConvert::Decompressed
882 into File::Pixel_Data.
884 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
886 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
887 * CLEANUP_ROUND (13) for gdcmPixelConvert
888 Substituted File::ParsePixelData() with PixelConvert::Print() new
890 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
891 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
892 method to those classes.
893 - src/gdcmFile.[cxx|h]:
894 -- Added a ::Print() method.
895 -- PixelConverter is now a reference instead of a member.
896 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
897 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
899 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
901 collaboration diagram and inheritance diagram should be generated with
903 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
904 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
905 pointlessly wrapped (see
906 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
907 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
908 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
909 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
910 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
911 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
912 -- File::Initialise: PixelConverter setup moved away to
913 PixelConverter::GrabInformationsFromHeader()
914 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
915 interpretation moved away to PixelConverter::BuildRGBImage()
917 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
918 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
919 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
921 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
923 displayed on Win32 when a brutal abort() occurs (because of uncatched
924 exception). See TODO new entry of this commit for more on this.
925 * TODO added new entry.
926 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
927 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
928 - HandleColor is no longer called from gdcmFile.cxx
929 - gdcmPixelConvert.cxx clean up on method arguments and internal
930 variable names for semantical coherence.
932 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
933 * Finished lossless transition, not only do we now read all lossless jpeg
934 images, without the need of the Cornwell lib, but we do read them properly now
935 * To reduce code (well to avoid code duplication), I defined a common place
936 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
937 redefine symbols. This is not perfect but this the best solution I found for a
938 compilation time jpeg option.
940 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Update jpeg ijg lib to support lossless jpeg implementation
942 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
944 * Also added a special copyright for dcmtk since we use their bugfixes.
947 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
949 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
950 matters, as stated in warning note at begining of %include section).
951 * src/gdcmDicomDir*.[cxx|h]: coding style
952 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
953 * src/gdcmJpeg8.cxx: doxygen fix.
954 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
955 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
956 from File:: to PixelConvert::.
958 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
960 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
961 - more code moved away from File:: to PixelConvert::
962 - fat setup of PixelConverter set in place in File::Initialise.
964 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
965 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
966 namespace at the file system level. So now you should convert your examples
968 gdcmHeader -> gdcm::Header
969 It would be nice if people keep in mind to no open the namespace, since it
970 allows compilation on broken plateform which were defining common symbol in
971 the standart namespace (like LP, Unknown ...)
973 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
975 The JPEG fragments are now parsed at the same stage than the RLE
976 information. All code related to JPEG is now in gdcmPixelConvert:
977 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
978 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
979 export a gdcmFile:: method. Those are simply global functions
980 (for the time being this is better than having them attach to
981 either gdcmFile:: or gdcmPixelConvert::).
982 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
983 and stores the result in a gdcmJPEGFragmentsInfo.
984 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
985 code (among other stuff) moved away from gdcmFile:; to
988 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
990 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
991 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
992 clean up of RLE related code.
993 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
994 - src/gdcmRLE.cxx removed
995 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
996 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
997 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
998 * CLEANUP_ROUND (9) for gdcmPixelConvert
999 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1000 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1001 away from gdcmFile:: to gdcmPixelConvert::.
1003 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1005 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1006 This is because Parse7Fe0 used to parse the pixels to compute the
1007 length. This task was passed over to FindDocEntryLengthOB() a long
1008 time ago, EXCEPT I had forgotten the OW case...
1009 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1010 we just recylce the code for parsing RLE fragments and computing
1012 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1013 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1014 with the retired Parse7Fe0().
1015 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1016 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1018 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1020 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1021 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1022 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1023 * CLEANUP_ROUND (4) for gdcmPixelConvert
1024 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1025 to return an unused length.
1027 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1028 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1029 this should be cleanner from the plane view. The iostream are erally a pain
1030 to use to do simple stuff.
1032 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * Redo the compilation of the ijg jpeg library. Now only one source is
1034 necesseray. No need to rename file by hand what so ever. CMake handle the
1035 copying of the file within different directory, configure header file to
1036 modify some symbol. The only addition made to ijg wasd a mangle table so
1037 that symbol are different whether we are within 8bits or 12bits.
1039 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * Added documentation of vtkgdcmReader on Website:
1041 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1042 with it's binary name).
1043 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1044 the Website to be more complete.
1045 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1046 doxygenated documentation.
1047 - Doc/DoxyVtkGdcmReaderExamples.txt added
1048 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1049 DoxyVtkGdmReaderExamples.html )
1050 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1051 * CLEANUP_ROUND (3) for gdcmPixelConvert
1052 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1054 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * CLEANUP_ROUND (2) for gdcmPixelConvert
1056 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1058 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * CLEANUP_ROUND for gdcmPixelConvert:
1060 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1061 - src/gdcmPixelStuff[h|cxx] removed
1062 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1063 - src/CMakeLists.txt changed accordingly
1064 * GDCMHOME clean up:
1065 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1066 gdcmVersion.py moved to newly created ATTIC related
1067 gdcmPython/SetupOldies/ directory.
1068 * Autotools clean up:
1069 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1070 - autogen.sh configure.in acinclude.m4 python.m4 removed
1072 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1074 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1075 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1077 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * TODO updated with Mathieu suggestions. I proposed a template for
1079 describing TODO entries and used it for new entries.
1080 * Added Doc/Website/CodingStyle.html, Developpers.html,
1081 DeveloppersPython.html, GdcmDataCvs.html and
1082 DownloadVersion0_1.html, DownloadVersion0_3.html.
1083 * Some Doc/*.txt Doxygen files (which do not really concern the
1084 documentation itself, but the website) moved to html and
1085 placed in directory Doc/Website:
1086 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1087 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1088 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1089 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1090 * CMakeLists.txt changed accordingly.
1091 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1092 DeveloppersPython.html
1093 * INSTALL nows refers to Doc/Website/Installation.html
1095 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * Added Doc/Website directory, that contains a first raw version
1099 2004-09-23 Jean-Pierre Roux
1100 * FIX In order not to be poluted any longer by casting problems,
1101 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1102 we can now delete[] it safely
1103 * VoidArea is now called BinArea (less confusing name),
1104 and all the methods called ...VoidArea... are now ... BinArea...
1105 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1107 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1109 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1110 up to the destructor of gdcmElementSet to clean up TagHt and it's
1113 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1115 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1117 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * ENH: added some utility method that builds a flat dictionary
1119 holding all the Dicom entries contained in the recursive structure
1120 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1121 an example of usage.
1122 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1123 BuildFlatHashTable() that build a flat dictionary.
1124 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1125 gdcmDocument is now a friend of gdcmElementSet.
1126 - src/gdcmElementSet.cxx: clean up.
1127 - Example/FlatHashTablePrint.cxx added.
1128 - Example/CmakeLists.txt changed accordingly
1130 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1132 moved away from gdcmDocEntrySet (since this class is an abstract class
1133 acting like an interface). SQDepthLevel and BaseTagKey are now
1135 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1136 and associated accessors. Doxygenation of the class.
1137 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1139 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1140 Use SQDepthLevel accessor instead. ::Print() adapted.
1141 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1142 - src/gdcmDocument.cxx changed accordingly.
1144 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1146 - The following is the doxygen comment of the typedef declaration
1147 of gdcmTagKey in src/gdcmCommon.h:
1148 gdcmTagKey is made to old an "universal" (as in URL, Universal
1149 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1150 A dicom tag always has a group and an element, but a set of tags
1151 embeded in various (optionally nested) sequences and sharing
1152 the same group and element all share the same (group, element)
1153 "identifier". Hence the (group, element) cannot be used as an
1154 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1155 In order to construct a proper tag identifier (i.e. a key) we
1156 consider the following definition of a TagKey:
1157 - let Group, Element be the string representation of the
1158 group and element dicom tag members,
1159 - let ItemNumber be the string representation of the integer
1160 index of the considered item number of a sequence,
1161 Let the key of a tag embeded in a sequence, noted SeqTag, be
1163 /ItemNumber#Group|Element
1164 where "/", "#" and "|" are characters acting as separators.
1165 Then the general form of a gdcmTagKey is given by:
1166 Group|Element<SeqTag>
1167 where <SeqTag> means NO or many instances of SeqTag.
1168 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1171 but the gdcmTagKey of a tag "embeded" is the first item of
1172 a sequence, itself nested in the third item of a sequence is the
1174 0004|1220/2#0008|0082/0#0008|0090
1175 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1176 order to hold the new sequence compatible key. Previously, the
1177 GetKey() method would look in the underlying gdcmDictEntry.
1178 - src/gdcmDocEntry.cxx:
1179 -- constructor now copies the underlying DictEntry key, in the local
1181 -- ::Print: displays the member Key, instead of the (group, element).
1182 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1183 - src/gdcmDocEntrySet.h:xi
1184 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1185 -- now has a new BaseTagKey member.
1187 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1188 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1190 This poses the problem with the semantics of the following lines
1191 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1192 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1193 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1194 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1195 to the long FIXME note for what the problem is. Nevertheless in
1196 order to get things working the dicom dictionary was altered !
1197 Please fix things urgently...
1198 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1199 information), see above note on moving the member VoidArea. Nevertheless
1200 the following entries previously correctly set as US are now inproperly
1202 0028 1201 OW IMG Red Palette Color Lookup Table Data
1203 0028 1202 OW IMG Green Palette Color Lookup Table Data
1204 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1205 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1206 of gdcmDocEntry moved to gdcmSeqEntry.
1207 * src/gdcmSeqEntry.cxx: STYLE.
1209 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1210 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1212 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * gdcmPython/testSuite.py: all the test suite in python is now moved
1214 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1215 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1216 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1218 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1220 to avoid inclusion recursion until STL is reached.
1221 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1222 mecanism. errno.h is not included in gdcm anymore.
1223 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1224 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1226 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1227 gdcmData/TestAllEntryVerifyReference.txt
1228 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1229 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1230 exception_on_error parameter.
1231 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1232 - vtk/vtkGdcmReader.cxx changed accordingly,
1233 - Example/*.cxx and Test/*.cxx changed accordingly.
1235 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1236 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1237 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1238 enable_sequences removed from gdcmHeader constructor and dependencies.
1239 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1240 * gdcmPython/demo/PrintHeader.py: dummy fix.
1241 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1242 skip_shadow removed from gdcmHeader constructor and dependencies.
1243 * Example/*.cxx and Test/*.cxx changed accordingly.
1245 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1247 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1249 2004-07-21 Jean-Pierre Roux
1250 * FIX Now, Parsing and Printing a DICOMDIR do work!
1251 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1253 2004-07-20 Jean-Pierre Roux
1254 * FIX Some brain damaged headers have Zero-Lenght fields
1255 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1257 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1258 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1259 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1260 variable (instance of gdcmDebug) by a definition macro, and the instance
1261 is now in static in the gdcmDebug class
1262 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1263 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1265 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1266 * WARNING: ctest now depends more tightly on gdcmData. You should
1267 check out gdcmData properly for things to run smoothly...
1268 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1269 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1270 we need the pixels not be loaded in order to use the ValEntry
1271 that displays position and size).
1272 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1273 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1274 be deprecated. If you have any doubts about the advantages of a
1275 modern scripting language (read Python) versus grass root C++ (i.e.
1276 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1277 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1278 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1279 Anyhow, consider documenting the gdcmData images in
1280 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1282 * Test/CMakeLists.txt:
1283 - now uses TestAllEntryVerify.cxx
1284 - specific comments on oldACR00001.ima (now renamed in gdcmData
1285 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1286 gdcmData/TestAllEntryVerifyReference.txt
1289 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1290 * src/*.[h|cxx] : typedef clean up
1291 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1292 - TagKey renamed to gdcmTagKey (for external usage)
1293 - VRKey renamed to gdcmVRKey (for external usage)
1294 - removal of typedef duplication.
1295 - Removed all unecessary inline keyword from class inline definitions.
1296 - Some method|function(void) declarations replaced with method|function().
1297 * src/jpeg/libijg12/jdhuff12.c:
1298 - printf polluting ctest removed.
1299 - TAB removal for comminting
1301 - TestAllReadCompareDicom.cxx: added a test that compares all the
1302 images in gdcmDataImages.h with corresponding images in
1303 gdcmData/BaselineDicom/. When baseline images are not present
1304 this test creates them.
1305 Note: we need to validate each reference image, but before that
1306 I'd like to rename them with a more explicit name...
1307 - CMakeLists.txt: changed accordingly.
1308 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1309 including each header needed).
1311 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1313 test suite to the Example directory. Are concerned:
1318 - TestWriteSimple.cxx
1319 * Test/CMakeLists.txt: added some comments on reasons for black listing
1320 image gdcmData/oldACR00001.ima
1322 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1323 * Test/CmakeList.txt: removed the following from black list (to be coherent
1324 with removal from gdcmData):
1325 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1326 - gdcm-MR-PHILIPS-16.dcm
1328 Added the following because after last cvs update, they cause
1329 ctest -R TestReadWriteReadCompare
1331 - gdcm-MR-SIEMENS-16-1.acr
1333 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1334 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1335 new comments in this file) we temporarily (sigh) move to a weaker
1337 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1338 we don't need to black list the following images anymore:
1339 - 8BitsUncompressedColor.dcm
1341 - US-PAL-8-10x-echo.dcm
1342 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1343 fixes and the beautified code ;-)
1344 This fixes the bug introduced in version 1.42 (when beautifying)
1345 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1346 Note: ctest was blind to this bug (this means we need to still
1347 improve the test suite). The bug could be detected by using
1348 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1350 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1351 and by displaying the (garbage) produced file temp.XDCM...
1353 2004-06-29 Jean-Pierre Roux
1354 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1355 - replace by uggly but working old code :-(
1356 A lot of things should be OK again.
1357 It's really urgent to have a test suite that *tests*,
1358 to prevent Frog's beautifying sessions to break all the stuff
1359 (twice, withing a fortnigh ...)
1361 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1362 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1363 redundancy) to added Test/TestReadWriteReadCompare.cxx
1364 * Test/CmakeList.txt: because the compare test of
1365 Test/TestReadWriteReadCompare.cxx fails, the following images are
1366 black listed: - 8BitsUncompressedColor.dcm
1368 - US-PAL-8-10x-echo.dcm
1369 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1370 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1371 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1372 and ad-hoc kludge. This kludge is now removed, and on encountering
1373 such an image (OB field brain damaged) we set errno. Then in
1374 ::FindDocLength() we "fix" the length as being ALL what remains
1375 in the file (until EOF). We then proceed, hoping for the best...
1376 This fixes a SegFault in ShowDicom when trying to write such an
1378 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1379 (because TestWriteRead breaks on it, after a non conformal commit?).
1380 ctest now runs properly, except for MakeDicomDir (which was always
1381 broken) and the Python related stuff (still not fixed).
1383 2004-06-24 Jean-Pierre Roux
1384 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1385 FIX : Test/TestReadWrite now iterates on all the file names
1386 (instead of infinite loop)
1387 ENH : Test/TestWriteRead now iterates on all the file names
1389 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1390 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1392 2004-06-24 Jean-Pierre Roux
1393 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1394 when SamplesPerPixel =3
1395 - now Write is no longer confused by
1396 'BitsAllocated = 12" and 'BitsStored=12"
1397 - "UN" value representation Elements are now written correctly
1398 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1399 ENH : - now gdcmHeader has its own Write methods
1400 (in order to split the job that has not to be done
1403 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1405 loop on the same image until memory went out.
1406 Note: this means we still have gobs of memory loss in PrintDocument
1407 * src/gdcmDocument.cxx: fixes problem on parsing on file
1408 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1410 2004-06-24 Jean-Pierre Roux
1411 FIX : Write - All the Sequences and Sequence Item are now written
1412 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1413 is added a the end, when necessary.
1414 - A lot of brain-damaged images, that were read correctly are
1415 now written correctly
1416 - length compatible BinEntry are now loaded correctly
1417 (even for odd groups)
1418 Note : only Explicit Value Representation was checked.
1419 (question : is implicit VR really necessary for gdcm ?)
1421 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * DEVELOPPER: added a proposition of coding style.
1423 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1426 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1428 Use the gdcmDocEntry::Print() and Write() instead.
1429 * src/gdcmDocument.cxx: bug fix.
1431 2004-06-22 Jean-Pierre Roux
1432 FIX : gdcmDocument.cxx
1433 - Now we do recognize the JpegLossLess format (there was a misstyping in
1434 code 'beautyfication' :-(
1435 - Now we automaticaticaly load the Luts, if any
1437 2004-06-22 Jean-Pierre Roux
1438 In order : to write Sequences, whatever their imbrication level,
1439 : to allow user to create his own Sequences
1440 a lot of modif where necessary (adding, moving, or virtualising methods)
1442 WARNING : save your own sources *before* cvs up !
1445 ADD virtual void Write(FILE *fp, FileType filetype);
1448 ADD virtual void Write(FILE *fp, FileType filetype);
1449 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1452 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1453 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1454 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1455 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1456 ADD std::string GetEntryByName(TagName name);
1457 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1459 std::string vr = "unkn",
1460 std::string fourth = "unkn",
1461 std::string name = "unkn");
1462 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1463 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1464 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1465 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1466 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1467 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1468 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1469 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1472 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1473 ADD virtual std::string GetEntryByName (TagName tagName);
1474 ADD virtual std::string GetEntryVRByName (TagName tagName);
1475 REM virtual bool Write(FILE *, FileType);
1476 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1477 FILE *_fp, FileType type);
1478 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1479 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1480 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1481 REM virtual std::string GetEntryByName (std::string tagName);
1482 REM virtual std::string GetEntryVRByName (std::string tagName);
1483 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1484 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1485 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1487 std::string vr = "unkn",
1488 std::string fourth = "unkn",
1489 std::string name = "unkn");
1490 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1491 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1492 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1493 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1496 ADD virtual void Write(FILE *fp, FileType filetype);
1499 ADD virtual void Write(FILE *fp,FileType filetype);
1502 ADD virtual void Write(FILE *fp, FileType filetype);
1503 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1504 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1505 REM std::string GetEntryByName(TagName name);
1508 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1510 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1512 The default constructor invoked by the line
1513 gdcmHeader *f1 = new gdcmHeader( header );
1514 was gdcmHeader::gdcmHeader(bool) instead of the expected
1515 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1516 Hence the parsing wasn't executed... See also below.
1517 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1518 as explicit constructor didn't do the trick to fix the above problem.
1519 Could anyone explain why ?
1520 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1521 properly calls gdcmValEntry::Print() (that was weed out from
1522 code related to gdcmBinEntry).
1524 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1525 * In order to fix memory leaks:
1526 - Test/TestWriteSimple.cxx: added cleaning of free store through
1528 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1529 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1530 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1531 (through the call to ::AddDicomDirMeta()) or the destructor
1532 would crash when deleting uninitialized ::metaElems].
1533 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1534 - src/gdcmDocument.cxx:
1535 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1536 from dynamic stores.
1537 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1538 was causing memory leaks.
1539 - src/gdcmSQItem.cxx:
1540 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1541 cleanly handled with polymophism: sorry but my milage is low).
1542 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1543 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1544 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1545 This avoids SegFaulting.
1546 - src/gdcmSQItem.h: coding style.
1548 - Test/TestWriteSimple still severely sucks. The output image content
1549 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1550 damaged when displayed with vtkgdcmViewer.
1551 - on memory leaks: TestWriteSimple leaks really less (see entry
1552 of 2004-06-18 in Changelog file for the call to valgrind).
1553 - on segfaults: ctest now passes all the tests but one (no more
1555 * Erroneous leading white fix:
1556 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1557 white[s] (as opposed to from >> xxx, that removes it [them].
1558 - src/gdcmTS.cxx: ditto.
1559 - gdcmPython/testSuite.py: dirty related kludge removed.
1560 * src/*: remaining references to gdcmParser removed.
1561 * src/*[cxx|h]: added copy[way]left header.
1564 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1565 * In order to fix writing of dicom files:
1566 - Test/TestWriteSimple.cxx: a simpler example of writing.
1567 - Test/CMakeLists.txt changed accordingly.
1568 - src/gdcmDocument.cxx:
1569 -- The destructor now recursilvely removes potential sequences.
1570 -- Bug fix in ::IsJPEG2000()
1571 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1572 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1574 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1575 to only declared) and build on top of
1576 ::GetDocEntryByNumber(guint16, guint16).
1577 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1578 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1579 for usage in destructor and treatement of promotion in
1580 ::ReplaceOrCreateByNumber().
1581 - src/gdcmSQItem.cxx: destructor should better handle his job.
1582 Test/TestWriteSimple now runs (or at least it DOES something).
1583 * We can now start hutting memory links. A good starting point is:
1584 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1585 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1586 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1588 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * Valgrind note: after Mathieu Malaterre teached me how to read
1590 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1592 Using gcc, you can force the STL to use malloc and to free memory as
1593 soon as possible by globally disabling memory caching.
1594 With 3.2.2 and later, you should export the environment variable
1595 GLIBCPP_FORCE_NEW before running your program.
1596 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1597 simply vanish (it is still not clear to me, whether this means that
1598 STL std::string leaks or if valgrind believes it leaks...).
1599 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1600 running bin/gdcmTests makeDicomDir):
1601 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1602 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1604 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1605 SegFaulting (I drowned in DicomDir related code when trying to
1606 understand why the list is empty...).
1607 * src/gdcmDocument.h: first BSD license header try.
1608 * Doc/License.txt added.
1610 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * src/gdcmDocument.[h|cxx]:
1612 - Clean up of the Transfer related predicates. They are now all based
1613 on new method isGivenTransferSyntax, that (should) handle properly
1614 the padding problem.
1615 - general clean up, simplification, and coding style.
1616 - Specific clean up of Parse7FE0() (umproperly named actually).
1617 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1619 2004-06-14 Jean-Pierre Roux
1621 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1622 - fix the display of SQItem ordinal number
1623 - add the GetSQItemByOrdinalNumber method
1624 - remove some useless never written private methods
1626 2004-06-14 Jean-Pierre Roux
1628 - adding a constructor taking a gdcmDocEntry as an input param
1629 - ReplaceOrCreateByNumber now returns :
1630 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1631 a gdcmValEntry * if a string value is passed as a param
1633 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1634 according to the param type (no longer sets a gdcmDocEntry)
1635 - GetValEntryByNumber, GetBinEntryByNumber added
1636 - NewValEntryByNumber and NewBinEntryByNumber added
1638 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1640 - GetSQItemNumber and SetSQItemNumber added, to provide
1641 a (relative) Item identier inside a given Sequence
1642 \warning : some pb remaining around this number
1644 - AddEntry now takes the Item Number as a param
1646 - adding a constructor taking a gdcmDocEntry as an input param
1648 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1649 * Memory leak hunt with the following command:
1650 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1651 --show-reachable=yes gdcmTests PrintDocument
1652 It looks like many (all?) leaks are due to the STL (or a bad usage
1653 of the STL. The lines producing the leaks now have a comment with
1654 a "MEMORY LEAK" tag: you can retrieve them with
1655 grep "MEMORY LEAK" src/*
1656 Here are two typical examples which I can't help fixing:
1661 char * test = "babo";
1662 name = test; //// <--- valgrind detects 960 bytes lost in
1663 //// call to std::string::operator=(char const*)
1664 name.clear(); //// Doesn't help !
1672 std::cout << "Type a bunch of characters followed by RETURN: ";
1673 getline(std::cin, line); //// <--- valgrind dectects a loss
1674 //// of 1320 bytes in call to
1675 /// std::basic_istream<>& std::getline<>
1681 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * src/gdcmHeader.[cxx|h]:
1683 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1684 and related, moved away to gdcmDocument.
1685 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1686 the corresponding protected accessors of inherited class
1687 gdcmDocument, removed ! As a consequence gdcmFile had to be
1688 declared friend of class gdcmDocument (see below).
1689 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1690 - Clean up of undefined or unused methods.
1691 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1692 account the changes to gdcmHeader.h).
1693 * src/gdcmDocument.h:
1694 - gdcmFile is now a friend class (in order to take into account the
1695 changes to gdcmHeader.h).
1696 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1697 (see changes to gdcmHeader.h).
1698 - Accessors (reading on the form GetEntry*) are now public.
1699 - Clean up of undefined or unused methods.
1700 * src/gdcmDocument.cxx:
1701 - adaptation to changes to gdcmDocument.h
1702 - ::OpenFile now writes a verbose message when file cannot be opened.
1703 - some std::string properly set to VRKey
1704 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1705 references to gdcmDocument.
1706 * Test/TestFindTags.cxx: changed accordingly to above changes.
1707 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1708 cvs repository gdcmData.
1710 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1711 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1712 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1713 conflicts with gdcmValEntry::voidArea.
1714 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1715 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1716 Value representation between StringRepresentable and BinaryRepresentable.
1717 * src/gdcmDocument.cxx:
1718 - method ParseDES: proper indentation restored and usage of
1719 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1720 - method LoadDocEntry: the fingerprint left in the SetValue() of
1721 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1722 removed. Reverting to previous code segment with the proper
1723 dynamic_cast< gdcmValEntry* >.
1724 Note: this was (partially) breaking the python test suite
1725 (gdcmPython/testSuite.py) that made usage of the above
1726 fingerprint to check presence of "Pixel Data".
1727 * src/gdcmDocEntry.h: coding style.
1728 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1729 now taken into account.
1730 * gdcmPython/gdcm.i: adaptation to the new internal representation
1731 of gdcm (exit gdcmParser, hello gdcmDocument).
1732 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1734 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1735 anymore, but instead prints the loaded Python dictionary.
1736 * .... alas, the python testSuite is still broken.
1738 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1739 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1741 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1742 * src/gdcmUtil.h : export methods
1744 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1747 * Initial addition of automatic python testing
1748 * Initial addition of automatic image comparison
1750 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1751 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1752 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1754 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1755 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1756 * Test/ShowDicom.cxx : bug fix for msvc compilation
1757 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1759 2004-05-04 Jean-Pierre Roux
1760 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1761 new concepts (and new classes) :
1762 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1763 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1764 - Sequence Doc Entries (gdcmSeqEntries)
1765 a Sequence is composed of Items.
1766 Each item is a set of Doc Entries (this is recursive)
1767 The non uniqueness of the 'Dicom tag' is due to this recursivity
1768 (never taken into account)
1769 Our unability to add a new 'entry' in the header
1770 at the proper location (neither in the H-Table (map or multimap),
1771 nor in the Chained List is also due to this recursivity.
1772 Don't try, right now, to use/modify/compile these new sources :
1773 nothing is finished.
1774 We just commit all the stuff, 'as is', in order not to loose it.
1776 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1777 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1779 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1780 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1781 file prefix (SetFilePrefix)
1783 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * Add a new test: ShowDicom, for now this is just the c++ version of
1785 checkRead.sh, later it will be able to compare the image read against a
1787 * Replace the DEBUG on the stack with a global entry in cmake interface:
1788 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1790 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * Add an example subdir, with a real example on how to read + write a
1794 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1795 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1796 * Doc/CMakeLists.txt: the main page is now properly differentiated
1797 between the developper and user version.
1798 * Doc/doxygen.config.in: dropped search related obsolete flags
1799 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1801 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * DEVELOPPER: added some helpfull comments for compile/test/install
1805 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1807 src directory, now generated in the build dir.
1808 2. Tests as mentionned smarter
1810 4. Add a new method in gdcmDict that return the PubDict by name
1811 this is interesting for 3rd party lib like ITK,
1812 where we could set the institution name / patient name...
1814 * ENH: 1. Now the test suite is working for real
1815 2. All binaries are now output in the gdcm-bin directory
1816 (this was not true before)
1818 2004-04-28 Jean-Pierre Roux
1819 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1820 SeQuence indented printing of Dicom Header.
1821 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1822 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1823 Computation of SQDepthLevel is now part of gdcmHeader constructor
1824 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1825 tree-like structure of a Dicom Header.
1826 * FIX Test code cleaning
1828 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * ENH: Adding automatic testing
1830 1. Need a DartConfig.cmake to submit to public
1831 2. Add a test driver gdcmTest.cxx
1832 3. gdcmTestMain, an helper for the main test driver gdcmTest
1833 4. Files in Test don't have a main anymore, this becomes interesting
1834 when we add more and more tests, thus dsw don't have to load
1836 * ENH: Adding a GDCM_DATA_ROOT for testing
1837 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1838 one file instead of seven + some small cleanup
1840 2004-04-22 Jean-Pierre Roux
1841 * ENH Minor changes to the Print() methods.
1842 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1843 Header printing. Example given with :
1844 > PrintHeader fileName 2 new
1845 (SQ based tree-like structure still to be done for the Header ...)
1847 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1848 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1849 1. I have added some unsigned where needed
1850 2. Some function parameter not used -> (void)
1851 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1852 4. g++ don't like character '\' in comment
1853 5. #define jpeg_create_decompress jCreaDecompress
1854 this really need to be fixed
1855 6. virtualize destructor of gdcmObject ... leakage
1856 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1857 this also really need to be fixed
1858 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1859 remove compression file
1860 (as we only do decompression, right ?)
1861 * ENH: Change malloc/calloc/free with c++ equivalent
1863 2004-04-21 Jean-Pierre Roux
1864 * FIX gdcmHeaderHelper::GetXSpacing
1865 when a single value is found (bug ?), xpacing is now
1866 defaulted to yspacing
1868 2004-04-19 Jean-Pierre Roux
1869 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1870 * ENH add parameters :
1871 bool exception_on_error = false,
1872 bool enable_sequences = false,
1873 bool ignore_shadow = false
1874 to the gdcmFile constructors to be full gdcmParser compliant
1875 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1876 to allow reading of PAPYRUS 3.0 files
1878 2004-04-06 Jean-Pierre Roux
1879 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1881 2004-04-02 Jean-Pierre Roux
1882 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1883 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1884 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1886 2004-03-30 Jean-Pierre Roux
1887 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1888 for ACR file, written out as DICOM files (hope so...)
1890 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1892 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1893 moved to base class gdcmParser and only the specialisation is kept
1895 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1896 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1897 already does the job.
1898 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1899 (to be consistent with gdcmParser::WriteEntries).
1901 2004-03-30 Benoit Regrain
1902 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1903 upate of the object's instance. It's passed to 2 in the unfavorable
1904 case : one in the ExecuteInformation, one in the ExecuteData
1906 2004-03-29 Jean-Pierre Roux
1907 * ENH : Check on file type to be written moved
1908 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1909 * FIX : gdcmObject::ResetBoundaries now stops properly
1910 when end-of-list is reached
1911 : gdcmVersion modified (as Benoit Regrain asked)
1913 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1915 * src/gdcmUtil.cxx: added forgotten iostream include.
1916 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1917 equivalent to ExplicitVR in existing code).
1919 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1920 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1921 now contains all the gdcmGlobal related code.
1922 * minor coding style and doxygenation changes.
1924 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1926 now contains all the Debug related code.
1927 * minor clean-up of includes in src/*.cxx
1928 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1929 CreateCleanString) removed.
1930 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1931 * Doc/DoxyMainPageUser.txt added.
1932 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1933 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1934 src/gdcmDirList.cxx)
1936 2004-03-24 Jean-Pierre Roux
1937 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1939 2004-03-23 Jean-Pierre Roux
1940 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1941 big endian made volumes
1942 * ENH Now gdcmParser constructor and destructor are protected to forbid
1943 end user to instanciate class gdcmParser
1944 (only gdcmHeader and gdcmDicomDir are meaningfull)
1946 2004-03-22 Benoit Regrain
1947 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1948 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1949 gdcmSerie to gdcmDicomDirSerie
1951 2004-03-19 Jean-Pierre Roux
1952 * ENH Now the tree-like structure describing a DICOMDIR comming from
1953 an already existing DICOMDIR file is consistent with
1954 the home-made tree-like structure build ex-nihilo
1955 or build from the files held (recursively) in a Directory
1956 functions gdcmDicomDir::CheckBoundaries()
1957 gdcmObject::SetBoundaries() added
1959 2004-03-17 Jean-Pierre Roux
1960 * REM (Eric Boix bug) : removal of meaningless
1961 gdcmDicomDirImage::NewImage function.
1962 * FIX now file names and directory name are written properly in the
1964 * FIX now gdcmDicomDir constructor may be call without any trick
1967 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1969 of gdcmDicomDirImage::NewImage as empty function.
1971 2004-02-28 Jean-Pierre Roux
1972 * ENH add gdcmDicomDir:NewPatient
1973 add gdcmDicomDirPatient:NewStudy
1974 add gdcmDicomDirStudy:NewSerie
1975 add gdcmDicomDirSerie:NewImage
1976 to allow making gdcDicomDir object.
1977 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1978 (as opposite to the gdcmHeader chained list)
1980 2004-02-11 Benoit Regrain
1981 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1982 when using from python
1984 2004-02-10 Benoit Regrain
1985 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1986 * FIX : in gdcmDicomDir when the directory is empty
1987 * ENH : add callback and methods to get the progression of dicomDir
1990 2004-02-06 Jean-Pierre Roux
1991 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1992 - GDCM_META added to gdcmDicomDirType
1993 - class gdcmMeta created
1994 * ENH : - A brief summary is now displayed at the beginning of
1995 'testDicomDir' to help disaster magnitude estimation
1996 * REM : Now useless Test/explDICOMDIR.cxx
1998 2004-02-05 Benoit Regrain
1999 * ENH : add methods in gdcmObject to get the hash table or the list of
2001 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2002 * FIX : wrapping python for TagHeaderEntryHT
2004 2004-02-04 Benoit Regrain
2005 * FIX : even length for some strings when writting the dicom dir
2006 * FIX : sort the images in the dicom dir
2007 * FIX : Bug fix for python use of dicom dir
2008 * ADD : a python demo
2010 2004-02-04 Jean-Pierre Roux
2011 * FIX : Final solution (?) for icone embedded images
2012 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2013 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2014 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2015 gdcmData/gdcm-MR-SIEMENS-16.acr1
2016 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2017 to make full checking easier
2019 2004-02-04 Benoit Regrain
2020 * FIX : WriteEntries : coding style & logic in parameters
2021 * FIX : Set the elements to create the DicomDir in a dictionary file
2023 2004-02-03 Benoit Regrain
2024 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2025 * gdcmDicomDir : add the load of directory
2026 * Bug fix and print add-on
2028 2004-02-03 Jean-Pierre Roux
2029 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2030 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2031 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2032 * FIX gdcmParser.cxx : 'group length' elements are now considered
2033 as integers, even for shadow groups, when file is Implicit VR
2035 2004-02-02 Jean-Pierre Roux
2036 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2038 of the last synonym :-(
2039 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2041 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2042 * FIX taking into account the possible 7fe0,0010 multiplicity
2043 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2044 to allow removal of references to 7fe0,0010, to deal with
2045 ACR-NEMA images, when 0028,0200 is meaningfull
2047 2004-01-31 Jean-Pierre Roux
2048 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2049 no longer writes 'Un' on disk
2050 * FIX SQ elements with actual length are now dealt with corectly
2051 * FIX gdcmFile::WriteBase make the difference, for color images, between
2052 the length (for Palette expanded images)
2053 and Raw Length (non expanded image + Palette)
2054 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2055 (that broke Write). Replaced by UL.
2056 Aware user will reload the field if he
2057 thinks it's necesssary
2059 2004-01-30 Jean-Pierre Roux
2060 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2061 when 'dirty Acr' is found, to be compliant with the new
2062 IsReadable() methods.
2064 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2065 (no DOUBLE images in kosher DICOM,
2066 but so usefull for people that miss them ;-)
2068 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2069 DICOMDIR related utilities (not checked as Windoze compliant)
2071 2004-01-28 Jean-Pierre Roux
2072 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2074 2004-01-27 Jean-Pierre Roux
2075 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2076 to allow skipping the shadow elements, to save memory space.
2077 The TRUE value for this param has to be used
2078 with a FALSE value for the 'enable_sequence' param.
2079 ('public elements' may be embedded in 'shadow Sequences')
2080 * gdcmHeader methods now deal with 'embedded icones images' in the header
2081 (even when an 'icone image sequence' is announced by the
2082 element (0x0088,0x0200), but there is NO icone at all ...
2084 * gdcmHeader sometimes Image Location value doesn't follow
2085 the supposed processor endianity (see gdcmData/cr172241.dcm).
2088 * gdcmHeader add the method
2089 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2090 to get *all* the Header Entries with the same tag.
2091 GetHeaderEntrySameName is probabely *useless*
2092 (no meaning : Name is *not* an identifier within the Dictionary)
2094 2004-01-26 Benoit Regrain
2095 * Bug fix in the print of hexadecimal representations. Remove long fields
2096 in the print and add a third level of print to print them
2098 2004-01-23 Benoit Regrain
2099 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2100 * Bug fix on test suite after remove the strip made on not string fields
2101 * Split the IsReadable method between gdcmParser which test that the file
2102 is dicom and gdcmHeader which test that it's an image file
2104 2004-01-22 Benoit Regrain
2105 * DicomDir : clean code, add methods, set variables in protected or private
2106 * gdcmUtil : bug fix for the clean string method
2108 2004-01-19 Benoit Regrain
2109 * Add the use of shadow dictionaries
2110 * bug fix and coding style
2112 2004-01-19 Benoit Regrain
2113 * src/gdcmFile.cxx : bug fix concerning the close of file
2114 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2115 * Add the update of header entries using the shadow library
2117 2004-01-19 Benoit Regrain
2118 * removal of file gdcmHeader2.cxx
2119 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2120 inheriting from gdcmParser. This split is to prepare the integration
2121 of dicom dir parsing
2122 * bug fix under python
2124 2004-01-16 Jean-Pierre Roux
2125 * REM removal of class gdcmHeaderEntrySet
2126 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2127 * ADD add file gdcmHeader2.cxx
2128 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2130 2004-01-15 Benoit Regrain
2131 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2132 entries created while parsing the header. Thus, they will be destroyed
2133 when the gdcmDictSet will be destroyed
2134 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2137 2004-01-15 Benoit Regrain
2138 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2139 made a fatal error because of the memory release at the end of program.
2140 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2141 some memory and vtk seems to have some problems with that.
2142 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2144 2004-01-14 Benoit Regrain
2145 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2146 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2147 * src/*.[h|cxx] : make changes due to class name changes
2148 * gdcmPython/demo/*.py : bug fix due to method names
2150 2004-01-13 Benoit Regrain
2151 * src/*.[h|cxx] : coding style
2152 * vtk/*.[h|cxx] : coding style
2154 2004-01-13 Benoit Regrain
2155 * gdcmPython/testSuite.py : test the readable flag of file for tests
2156 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2157 It's lied to the stl compilation by MSVC (windows, always windows...)
2158 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2160 2004-01-12 Benoit Regrain
2161 * src/*.h : add comments
2162 * src/gdcmDictSet.h : set the method BuildDictPath in public
2163 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2164 directly setted in the source code
2165 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2168 2004-01-09 Benoit Regrain
2169 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2170 * setup.py : use a reference to gdcmVERSION
2172 2004-01-07 Benoit Regrain
2173 * Modification to compile with the distutils.
2176 2003-12-10 Benoit Regrain
2177 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2178 can use a gdcmHeaderHelper to load data
2179 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2180 made in the source code
2182 2003-12-10 Benoit Regrain
2183 * Update Windows projects and .cvsignore files
2185 2003-11-12 Jean-Pierre Roux
2186 * ENH gdcmHeader constructor has one more parameter (default value : false)
2187 that allows the user to 'go inside' the SeQuences only
2189 gdcmElValSet:Print takes it into account
2191 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * ENH: Update gdcmPython/CMakeLists
2193 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2194 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2196 2003-11-10 Jean-Pierre Roux
2197 * FIX : gdcmHeader::LoadElements is now based
2198 on the ListTag listElem member,
2199 not longer on the TagElValueHT tagHt member
2200 * ENH : PrintPubElVal shows (temporarily) both results,
2201 with the tagHt member and the listElem member.
2202 (it's easier to 'see' the problems when using Printheader)
2204 * FIX : old private member LgrElem is now splitted into
2205 ReadLength : Length actually found on disk (updated only
2206 if bug fixing is necessary), for internal
2208 UsableLength : Updated by FixFoundLength, to fix a bug
2209 or to allow Parser going on.
2210 Will allow to re-write a kosher header when a SeQuence
2211 with a length (not 0000) is found
2212 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2213 because gdcmElValSet::Add does not update ListElem
2216 2003-11-07 Jean-Pierre Roux
2217 * FIX misstyping in Transfert Syntax name table
2218 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2219 when they have an actual length (not 0000 nor FFFFF)
2220 (Nobody should care of it, but DICOMDIR explorers)
2222 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2223 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2225 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * ENH: vtkGdcmReader now supports LUT !
2227 (vtkgdcmViewer for now is not able to use them though)
2229 2003-11-05 Jean-Pierre Roux
2230 * in testSuite.py : new files names for checking the package
2231 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2232 that returns the pixel area size to the *aware* (vtk) user
2233 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2235 2003-11-05 Benoit Regrain
2236 * in testSuite.py : Modify the rules for checking the paths
2237 : Explicit error messages
2238 * in __init__.py : Related modif
2240 2003-11-03 Jean-Pierre Roux
2241 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2242 to be used by aware (vtk) users that want to manage
2243 LUT (and no to turn the PALETTE image into an RGB pixels one)
2244 * GetPixelType now returns 8U for 24 Bits images
2245 (vtkGdcmReader compliant)
2247 2003-10-31 Jean-Pierre Roux
2248 * Removal of *all* gdcmData images and add them again
2249 in order to loose the 'history' of un-anonymised images
2251 2003-10-31 Jean-Pierre Roux
2252 * RMV : removal of useless jBitsInJsample.h
2253 for both 8 and 12 Bits JPEG Lossy Libraries
2255 2003-10-31 Jean-Pierre Roux
2256 * ENH : Add the functions gdcmFile::GetImageDataRaw
2257 gdcmFile::GetImageDataIntoVectorRaw
2258 that act as GetImageData and GetImageDataIntoVector
2259 except the making of an RGB Plane from Gray Plane + LUT
2260 Intended to aware (vtk) users who know how to manage
2263 GetLUTRGBA return a R,G,B,A LUT if any
2264 lgrTotaleRaw gives the 'Raw' length
2265 GetImageDataRaw returns the gray Plane
2266 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2267 (They stay Grey, just like with other Dicom viewers :-(
2269 2003-10-30 Jean-Pierre Roux
2270 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2272 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2273 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2274 being coherents dicom files.
2276 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2277 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2279 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2280 * ENH: Two steps is necessary to please VC++ compiler...
2281 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2282 * ENH: Add include dir to medcon lib
2283 * FIX: only one function is being exported for now !
2284 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2286 2003-10-29 Jean-Pierre Roux
2287 * adding gdcmHeader::GetLUTRGBA
2288 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2289 --> Mathieu, the modif u're waiting for is not yet committed
2290 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2292 2003-10-27 Jean-Pierre Roux
2293 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2294 00191113.dcm DermaColorLossLess.dcm
2295 MxTwinLossLess.dcm RadBWLossLess.dcm
2296 * ENH: For version prior to vtkImageViewer2 -r 1.19
2297 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2299 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * Removal of ido stuff in CMakeLists.txt
2302 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2303 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2304 * FIX: remove a call to ->Modified ... see comments
2305 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2307 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * FIX: Problem with path for libvtkgdcmPython
2309 * ENH: Try adding a search script for python site-package
2310 * RMV: Remove some file from medcon lib that are not necessary
2311 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2312 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2313 * FIX: More pragma disable fro VC++,
2314 I don't think I break something as it is also disable in VTK/ITK.
2315 But it fasten debug compilation time.
2317 2003-10-23 Jean-Pierre Roux
2318 * gdcm now deals with 16 Bits Run Length Encoded images
2319 (they are compressed as 2 planes images,
2320 one for the high Bytes, the other for low Bytes)
2322 2003-10-22 Jean-Pierre Roux
2323 * Now CheckRead takes into account :
2324 - the bugged 'Leonardo' Siemens images
2325 - the XA images, sent thru the burning VPRO station
2326 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2329 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2330 * FIX: When copying a Makefile.am to CMakeLists.txt
2331 one should remove the '\'
2333 2003-10-22 Jean-Pierre Roux
2334 * in gdcmData adding a bugged 'Leonardo' Siemens image
2335 (wrong lengths in header)
2336 OK with gdcm, KO with the other viewers :-)
2337 * add a GE dlx XA image, thru the VEPRO burning station
2340 2003-10-21 Jean-Pierre Roux
2341 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2342 for a brutal checking of vtkgdcmViewer compliance
2344 2003-10-21 Jean-Pierre Roux
2345 * add the files for 'xmedcon' Jpeg Lossless library
2346 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2348 2003-10-21 Jean-Pierre Roux
2349 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2351 2003-10-21 Jean-Pierre Roux
2352 * garbage Siemens 'Leonardo' images dealt with
2353 (the patch is easy to remove)
2354 * cosmetic changes to avoid warnings
2356 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2357 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2358 no need to press 'r' now.
2360 2003-10-20 Jean-Pierre Roux
2361 * upgrade of checkRead.sh checkWrite.sh according
2362 to new Jpeg Lossless decompressor
2363 * add US.3405.1.dcm, a genuine RGB medical file ...
2364 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2365 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2367 2003-10-15 Jean-Pierre Roux
2368 * general anonymisation in gdcmData
2369 * adding the 'color files' from
2370 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2371 * adding some well knowed bugged-header images
2372 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2373 waiting for their inclusion in Python testsuite
2375 2003-10-15 Jean-Pierre Roux
2376 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2377 no longer seg faults when file is not found
2379 2003-10-14 Jean-Pierre Roux
2380 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2383 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2384 * TODO: *.in file to genereate a UseGDCM later
2386 2003-10-14 Jean-Pierre Roux
2387 * Some supposed-to-be Dicom Images have no preamble.
2388 OpenFile takes it into account
2389 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2390 * Missing elements added in dicomV3.dic
2391 (just to be affraid : have a look at
2392 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2393 and do it again next year ;->
2395 2003-10-13 Jean-Pierre Roux
2396 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2397 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2398 But there are NOT. It's fixed !
2400 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * FIX: "jpeglib.h" was not found on VC++
2402 * FIX: vtkgdcm was not being installed
2404 2003-10-10 Jean-Pierre Roux
2405 * ENH : OpenFile closes the file if it *really* doesn't look like
2406 an ACR-NEMA / DICOM one.
2407 * FIX : testWrite no longer writes an empty file if the source file
2408 is not gdcm Readable
2409 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2412 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2413 * FIX: CMake generate now documentation
2414 * ENH: out of source doc build !
2415 * ENH: Generate both user and dev documentation
2416 * ENH: Should work on windows too
2417 * ENH: Only one doxygen config.in file is needed
2418 * FIX: make install should be ok now on ùnix plateform
2419 * FIX: PATH to dictionary was wrong (missing /)
2420 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2422 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2423 * vtkGdcmReader is now able to read rgb dicom file.
2424 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2425 * added a gdcmViewer to vtk test, use mouse to control
2426 window level & window width
2428 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2429 * CMake-ification of gdcm, we have now two build system
2430 * FIX: on cygwin Wsock32 doesn't exist
2431 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2433 2003-10-06 Emanuel Ollart
2434 * FIX : compilation process wad broken.
2435 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2437 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2438 * change gdcmViewer -> vtkgdcmViewer
2439 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2441 2003-10-06 Jean-Pierre Roux
2442 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2443 ( e.g : well known GE images with a wrong elem length,
2444 : Philips MRI Images with a wrong Huffman table)
2445 * still to be done : allow the reading of bugged LEONARDO Siemens images
2447 2003-10-03 Jean-Pierre Roux
2448 * Odd length strings are padded with '\0' (not with spaces,
2449 to remain compliant with already defined strings,
2450 like Transfert Syntax UID and others)
2452 2003-10-03 Jean-Pierre Roux
2453 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2454 to allow displaying RGB images (not only by affim ;-)
2456 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2457 * vtkGdcmReader is now able to read rgb dicom file.
2458 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2460 2003-10-03 Jean-Pierre Roux
2461 * A few nasty patches to allow the reading of a lot of nasty images
2462 ( e.g : well known GE images with a wrong elem length,
2463 : Philips MRI Images with a wrong Huffman table)
2464 * still to be done : allow the reading of bugged LEONARDO Siemens images
2466 2003-10-03 Jean-Pierre Roux
2467 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2469 2003-10-03 Jean-Pierre Roux
2470 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2471 to allow displaying RGB images (not only by affim ;-)
2473 2003-10-03 Jean-Pierre Roux
2474 * gdcmFile::GetImageDataIntoVector now
2475 - deals with MultiFrames MultiFragments Run Length Encoded files
2476 - deals with YcBcR (YBR_FULL) files
2477 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2478 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2480 (no sample found :-(
2482 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2483 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2484 Two reasons: - clear things
2485 - third parties acces gdcm through header files, so won't
2486 suffer anymore VC++ complains
2488 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2489 * add argv[1] in testvtkGdcmReader.cxx
2492 2003-09-24 Jean-Pierre Roux
2493 * The lines are now eigthy characters long.for
2494 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2496 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2497 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2498 char* to std::string. Thus, the use of strdup becomes useless. (see
2499 previous commis of Malaterre)
2500 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2501 before the last Malaterre's commit.
2503 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2504 * This commit should fix the Debug building under VC++, the problem
2505 was mainly a mixture of debug and release lib being loaded at startup.
2506 * I also remove a depency to a specific C function: strdup. Because I had
2507 to force the link to msvcrtd (whereas strdup is in libc).
2509 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2510 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2511 located in the gdcmCommon.h file. All use of reference of tha has been
2512 changed to now use the variable GDCM_UNFOUND.
2514 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2516 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2517 Dicom dictionary. The test suite can now be run again. Note:
2518 I'm note very happy with the " (RET)" changes. I believe this
2519 RETAINED comment should be dropped when parsing the dictionary.
2520 - PACKAGER corrected
2522 - AUTHORS updated and now in alphabetical order
2523 * Makefile.am now exports gdcm.dsw for Windoze users.
2525 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2526 * cygwin complains about missing std:: in subdir Test/
2528 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2529 * remove some methods that are now in gdcmHeaderHelper
2531 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2532 * vtkGdcmReader set spacing and origin correctly
2534 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2535 * Fix a few delete/delete[] mismatch
2537 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2538 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2539 interpretation to data given by gdcmHeader. For instance there are
2540 heuristics to get informations (look at different places).
2541 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2542 sorting DICOM images based on different strategies.
2543 * modified Makefiles accordingly.
2545 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2546 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2547 when building in debug mode
2548 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2549 src/win32/gdcmdll.dsp
2550 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2552 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2553 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2556 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * src/win32/libgdcmjpeg12.dsp was not dos format
2558 * src/win32/libgdcmjpeg12.dsp :
2559 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2560 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2562 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2563 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2565 * src/gdcmFile.cxx : bug fix in affectation type
2566 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2567 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2568 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2569 symbols... future problem ?
2571 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2572 * src/win32/libgdcmijpeg12.dsp was missing
2573 * modified gdcm.dsw accordingly
2575 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2578 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2579 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2580 commit of JPR (before his hollidays to facilitate our work).
2581 * setup.py : bug fix in code. Modifications made while the last commit
2582 of JPR. The code hasn't been tested before the commit... it's so
2583 useless to make that (for best programmer that is JPR) !!!
2585 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * tagged the current version as Version0_3 (i.e. version 0.3)
2588 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2589 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2590 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2591 * *.dsp : modifications to use new libgdcmijpeg8 library
2592 * setup.py : bug fix on VTKPATH variable
2593 * PACKAGER : adding all concerning windows
2595 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2598 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2599 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2600 test suite reported error.
2601 * PACKAGER file added (describes what a packager must do when
2602 packaging a new release).
2603 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2604 * configure.in: upgraded version number to 0.3.0
2605 * fixing build of rpm (through rpm -ta):
2606 - Doc/Makefile.am exports proper doxygen files
2607 - src/jpeg/libijg8/Makefile.am exports the include files.
2609 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2610 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2611 * src/gdcmHeader.h : formatting code
2613 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2614 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2615 We were obtaining error message from vtk. Now, creation of file list
2616 is made in an internal list to prevent this problem.
2617 Bug fix when output is empty.
2618 Bug fix in update of progress value. Previous commit for this was a bad
2620 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2622 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2623 * src/gdcmHeader.h : added method to get the file name
2624 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2625 files. Added method to remove all files on the input
2626 Added FIXME comment concerning the bad parsing of header made by
2627 ExecuteInformation method (in ExecuteData method)
2629 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2631 when using make instal.
2632 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2633 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2635 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2636 * setup.py : adding include dir of jpeg lib to compile all sources
2637 * */Win32/*.dsp : JPR fix for windows compilation
2639 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2640 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2642 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2643 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2645 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * setup.py is again effective on un*x (takes into account the
2647 addon of the jpeg library)
2648 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2649 * Doc/Doxy* updated (includes above enhancements)
2650 * INSTALL now points to web documentation
2652 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * src/gdcmHeader.h doesn't make unnecessary reference to
2655 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2657 * src/gdcm*.[cxx|h] :
2658 - to allow compilation with gcc 3.x
2659 -- clean up of STL usage (added explicit usage of std::)
2660 -- small fixes on exceptions.
2661 Note: linking not tested !
2662 - clean of doxygen comments to avoid warnings at documentation
2664 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2665 dependent convertion).
2667 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * Clean up of previous JPR garbage commit (not even commented in the
2670 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2671 - moved all jpeg related files from src to src/jpeg/libijg8, with
2672 addition/modification of Makefile.am and configure.in.
2673 - the testSuite is still brain damage (not guilty).
2675 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2676 * WrapVTK.py : modifications to get correctly vtk source files to
2678 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2679 (FileName -> Filename)
2681 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * vtk/vtkGdcmReader.[cxx/h]:
2683 - UpdateProgress method should now be effective
2684 - removed the limitation on having only images loaded (as opposed
2686 - when building a stack of images/volume, a lesser number of
2687 gdcmHeader and gdcmFile instances should be used (hopefully
2688 accelerating things).
2689 - when building a stack of images/volumes, files which are not
2690 loadable (wrong path-filename, wrong permissions on existing file,
2691 or file not parsable by gdcm) are replaced with a black image
2692 in the stack (for the caller to notice the problem).
2694 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2697 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2698 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2699 between standard library (std) and vtk library (problems are found
2700 under Windows... thanks Windows !)
2702 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2705 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2707 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2710 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * When compiling with distutils (see setup.py) the C++ compiler is
2712 called with different flags than the default ones (with automake).
2713 In order to fix all those warning, I compiled gdcm with the command
2714 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2715 and went for warning fixes:
2716 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2717 up from unused variables.
2718 - vtk/vtkGdcmReader.cxx: potential bug fix.
2719 * src/gdcmHeader.h: Doxygen warning cleanup
2721 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * gdcmPython/gdcm.i:
2723 - typemaps correction to take into account the systematic replacement
2724 of "using namespace std" with std:: prefix e.g. std::list,
2725 std::string... (cf changes of 2003-05-21).
2726 - gdcmGlob global variable of type gdcmGlobal (defined in
2727 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2728 exported to Python a as cvar.
2729 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2730 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2731 gdcmDictSet.GetPubDictTagNames() and
2732 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2733 C++ static methods).
2734 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2735 with the above changes.
2737 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * setup.py, manifest.in : bug fix under linux
2740 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2741 * Modification of setup.py to compile vtk part too. Then, we have 2
2742 wrappers which must work with same distutils. For that, we have a
2743 generic distutils in distusiltsWrapping.py ; with :
2744 - build_extWrap class to wrap generically all extensions,
2745 - ExtensionWrap base class for all wrapping extension that contains
2747 - Wrapper interface which wrap sources
2748 + In WrapSwig.py we have extension and wrapper for Swig
2749 + In WrapVTK.py we have extension and wrapper for VTK
2750 * MANIFEST.in : modifications to consider vtk directory and new python
2751 files for compilation
2753 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2754 * Added python wrappers of vtkGdcmReader vtk class (see the
2755 source in vtk/vtkGdcmReader.cxx) :
2756 - vtk/Makefile.am now builds a library
2757 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2758 python library (as opposed to _gdcm.so wich are the python
2759 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2760 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2762 - configure.in has an additional flag --enable-vtk that needs
2763 to be set to enable compilation of vtk related code, that is:
2764 + vtk/vtkGdcmReader.so and
2765 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2766 + gdcmPython/vtkgdcmPython.so (see above)
2767 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2768 be read when compressed or when HighBit + 1 != BitsStored),
2769 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2770 the usage of the python wrapper of vtkGdcmReader vtk class.
2771 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2772 * src/*.[h] all occurences of stl classes are now prefixed with
2773 std::, and all occurences of "using namespace std;" where removed.
2774 This is to avoid pollution of global namespace in included files.
2775 Apparently vtk does not avoid this pitfall: when using both
2776 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2777 collision of various stl members (principally cout...).
2778 * gdcmPython/testSuite.py now cleanly removes temprory generated
2780 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2781 comply with above changes)
2783 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2784 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2785 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2786 vtk data structure (an image Flip was required).
2787 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2788 * cosmetic changes in documentation.
2790 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2791 * src/gdcmHeader.cxx: the constructor no longer exits when an
2792 unexisting file is given as argument.
2793 * The subdirectory Data (containing all the images used for the
2794 test suite) is not part of this repository anymore. A new module
2795 containing those images is now available at
2796 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2797 with the name gdcmData.
2798 All the python scripts (including the package initialisation file
2799 gdcmPython/__init__.py) were adapated to take this change into
2800 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2802 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2803 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2804 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2805 demo of the usage of this class.
2806 Compilation of this vtk part is only done when using the --enable-vtk
2807 at configure (or autogen.sh) stage.
2809 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2810 * More memory link related corrections and documentation fixes.
2812 - maximum info is obtained with a command of the form:
2813 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2814 --show-reachable=yes PrintHeader
2815 - the remaining reachable blocks seem to come from the STL
2816 allocation scheme through the usage of map and list. It looks
2817 like this memory cannot be freed but it is not a memory leak
2818 (in fact further invocation to the STL would recollect the
2819 unused memory allthough it cannot explicitely be freed).
2820 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2821 of displaying an image parsed with gdcm and displayed with VTK.
2822 Note: some images don't seem to work e.g.
2823 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2824 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2825 Allthough this weakens the semantics, it is a ditch attempt to
2826 make gdcm more thread friendly.
2828 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2829 * Memory link hunt (by using valgrind through the command
2830 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2831 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2832 gdcmHeader::_dicom_vr.
2833 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2834 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2836 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2838 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2839 * src/Makefile.am now exports all the necessary include files at
2843 * UpdateGroupLength replaced by new one
2846 * UpdateGroupLength re-written using H-Table
2847 (named UpdateGroupLengthNew untill checks are over)
2849 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2850 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2851 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2853 - gdcmHeader::GetPubElValSet removed.
2854 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2855 UpdateGroupLength, WriteElements, Write.
2856 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2857 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2858 carried the same semantics.
2859 - src/gdcmHeaderIdo.cxx changed accordingly.
2860 - gdcmFile::WriteBase now regroups all the codes from previous
2861 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2862 - enum FileType moved to gdcmCommon.h
2863 * src/gdcmHeader.cxx AddDefault trashed
2864 * gdcmGetXSize added
2865 * getimageDataSize now calls gdcmGetXSize
2866 * Test/*.cxx changed to agree with above changes
2868 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2870 (to avoid double call by end user).
2871 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2872 by end user, since gdcmHeader::gdcmHeader now handles it.
2874 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * gdcm/Doc many doxygen changes:
2876 - Doxyfile now has two different versions, DoxyfileUsers that generates
2877 the html.users end users oriented documentation and
2878 DoxyfileDeveloppers that generates the html.developper developper
2879 oriented documentation.
2880 - README changed accordingly
2881 - requirement.txt removed (old design info moved to TODO).
2882 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2883 DoxyMainPage.txt, DoxyPython.txt provide more information.
2884 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2885 be updated by simply regenerating the docs with doxygen and copying
2886 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2887 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2888 all the tests in the form "if (<map>.count() >1)" were removed.
2889 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2890 ill-formed documentation sections.
2891 * src/gdcmHeader.cxx: ditto
2893 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * setup.py fixed for un*x (needed macro for stdint.h)
2895 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2896 un*ces with sh-utils test utility.
2897 * gdcmPython/demo/test.py renamed to PrintHeader.py
2898 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2899 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2900 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2901 * src/gdcm*.cxx JPR's bad inclusion fixed.
2903 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2905 * gdcmPython/demo/test.py changed accordingly.
2907 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * gdcmPython/Makefile.am fixed linking against libstdc++
2909 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2910 * Swig subdir (historical tests of swig version 1.3.17++) removed
2911 * Test/testChangeEntete.cxx some lines commented out in order to make
2913 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2914 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2916 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2918 hence the user doesn't need this explicit call.
2919 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2920 i.e. LoadElements() call removed.
2921 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2922 - src/Makefile.am declares the proper flag for g++.
2923 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2924 for adding user defined new tags.
2925 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2926 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2927 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2929 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2930 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2931 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2932 src/Makefile.am : the project should properly compile and install
2933 with the autotools, included the python wrappers part.
2934 * gdcm.spec.in : added a spec file for RPM packaging.
2936 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2937 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2939 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2940 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2941 to exported to the environement (see gdcmPython/testSuite.py
2943 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2944 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2945 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2946 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2947 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2949 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * gdcmPython/__init__.py doesn't crash anymore when running in
2951 in InstallMode or PreInstallMode but with an environment given
2952 value of GDCM_DICT_PATH.
2953 * src/gdcmDictSet.[cxx/h] coding style.
2955 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2957 * src/gdcm.h general comments moved to TODO, and README
2958 * src/gdcm.h should now be seen as a user commodity (including it
2959 should suffice to fully use gdcm). It is nowhere including within
2960 any of the kernel files src/*.cxx and src/*.h.
2962 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2963 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2964 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2966 * src/gdcm*.cxx only include their corresponding include file
2967 (as opposed to gdcm.h)
2968 * gdcmPython/gdcm.i changed accordingly
2969 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2970 the autogen.sh generated "make snapshot" command to work.
2971 * autogen.sh removed history related references to crea package.
2973 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * distutilsSwigCPlusPlus.py work around some swig portability
2977 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2979 was done in a last ditch attempt to get setup.py _really_
2980 operationnal. The python/gdcmPython layaout add the advantage
2981 of hidding away the python related distutils specific files
2982 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2983 Alas, the src directory was out of scope (i.e. it's relative
2984 position to setup.py was ../src) which made things impossible to
2985 handle (see previous version of python/setup.py). Crossing fingers...
2987 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * python/setup.py now works on Un*x. (harder than I thougth)
2989 * python/distutilsSwigCPlusPlus.py can now have include files
2990 among the list of sources.
2992 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2993 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2994 * modifications in MSVC projects
2996 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * As stated by the first lines of Test/ExceptionAndPython/README, it
2998 looks like we can move back to original usage of exception within
2999 src/gdcm* and hence remove the errno stuff that was introduced
3000 as a quick and dirty fixture of this problem (added to the TODO).
3001 * Doc/Doxyfile configuration file for Doxygen and corresponding
3002 README file for usage added.
3003 * Test/testWrite.cxx added. This new test comes from a split of
3004 test.cxx that is now reverted to its original purpous i.e.
3005 testing the proper parsing of a Dicom related file.
3006 testWrite.cxx concentrates on testing the IO part of gdcm.
3007 * Test/bug1.cxx (containing a bug on WIn32) added.
3008 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3009 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3010 whose purpose is to publish the content of the TagNames of the
3011 Dicom public dictionary were not accessible without an
3012 instance of class gdcmHeader.
3013 - those methods are now static methods of gdcmDictSet and hence
3014 require no instances at all to be invocated.
3015 - within gdcmDictSet this change required to change some method
3016 to class methods (i.e. are now static) among which SetDictPath
3017 (renamed to BuildDictPath) and LoadDefaultPubDict.
3018 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3019 the above changes by calling the new method classes of gdcmDictSet.
3020 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3021 the above to be effective.
3022 * python/gdcmPython: in order to wrap properly the above changes
3023 for Python, swig version now needs to be > 1.3.17.
3024 * python/gdcmPython/Makefile fixed to adapt itself to new
3025 configure/make shema introduced by Johan Montagnat (thanks for the
3026 contribution). Alas this Makefile cannot be turned into a proper
3027 Makefile.am without some heavy changes in the configure.in
3028 (for python dectection).
3029 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3030 now avoids publishing the empty entries.
3032 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3033 * python/setup.py : bug fix concerning install under windows
3034 ExtraPath reused :-P
3035 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3037 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3038 * Dicts/dicomV3.dic : remove double spaces !!!
3039 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3040 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3043 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3044 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3045 method. Doxygenation.
3046 * src/gdcm.h clean up of JPR spurious comments.
3048 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3049 * python/distutilsSwigCPlusPlus.py now properly collects the
3050 shadow classes generated by "swig -c++" (gdcm.py in our case)
3051 when using "python setup.py install".
3052 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3053 reexports the working classes.
3054 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3055 by the classical C errno scheme. This is to prevent an obscure
3056 behavior of the python wrappers when importing wxPython.wx prior
3057 to gdcmPython (which ended up in an abort call). An illustration
3058 of this oddity can be found in the Test/ExceptionAndPython
3059 subdir (see the README file). This problem probably due to
3060 an combination of g++ and dynamic loading.
3061 * added Test/ExceptionAndPython (see above)
3063 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3064 * Changed the layout of the python part to avoid bloating main
3065 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3066 i.e. the distutils arsenal. All the python related stuff is
3067 again in a python subdir, but the package itself is now in
3069 * setup.py was cleaned up:
3070 - pythonIncludePath removed
3071 - python setup.py bdist target is now functional.
3072 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3073 collision with other packages). gdcmPython/demo/*.py changed
3076 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * python subdir moved to gdcmPython (preparation of distutils packaging).
3078 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3079 distutils installer is operational.
3080 * - gdcmPython/__init__.py now properly loads the swig generated
3081 shadow classes (from gdcm.py).
3082 - gdcmPython/demo/*.py changed to import the package gdcmPython
3083 instead of gdcmPython/demo/load.py.
3084 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3086 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3087 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3088 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3089 entries within the associated public Dicom dictionary resp. the same
3090 information but sorted by the fourth field (PAT, IMG, DIR) of the
3092 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3093 are now in the "???" group.
3094 - python/gdcm.i changed accordingly,
3095 - python/demo/printGroupedPublicDict.py added, that gives an example
3096 of the above new functionalities in Python.
3098 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3099 * src/gdcm.h, gdcmHeader.cxx:
3100 - historic references to glib's g_malloc and g_free (#defined)
3101 were definitively removed.
3102 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3103 * src/gdcmElValSet.cxx:
3104 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3105 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3106 - GetElValue(string) renamed to GetElValueByName.
3107 - Added GetElementByName(string).
3108 * src/gdcmHeader.cxx: added
3109 - GetPubElValRepByNumber(guint16, guint16)
3110 - GetPubElValRepByName(string)
3111 - GetShaElValRepByNumber(guint16, guint16)
3112 - GetShaElValRepByName(string)
3113 - GetShaElValByNumber(guint16, guint16)
3114 - GetShaElValRepByName(string)
3115 - GetElValRepByNumber(guint16, guint16)
3116 - GetElValRepByName(string)
3117 - GetElValByNumber(guint16, guint16)
3118 - GetElValRepByName(string)
3119 * Doc/requirements.txt added.
3121 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3122 * Test/Makefile building now depends on the one of libgdcm.so
3123 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3124 pixel data) aware which enables finding the address (offset) of
3125 the pixel data of JPEG encoded DICOM files. This leaves only a single
3126 file in the testSuite whose pixel data address (offset) is unknown.
3127 * python/testSuite.py changed accordingly.
3129 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3130 * VC++ has some strong limitations when working with the STL, as stated
3131 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3132 "Also note that some STL containers (map, set, queue, list, deque)
3133 cannot be exported. [...]
3134 Some STL classes contain nested classes. These classes can not
3136 This is caused by a designed limitation that once a template
3137 class is instantiated, it can not be re-instantiated and
3139 Since our usage of map<> is ubiquitous in gdcm, this "designed
3140 limitation" of VC++ is a pitfall.
3141 Hence the Python wrappers of gdcm cannot be incrementally linked
3142 against the c++ dynamic library. The dirty but only workaround is
3143 to forget about incremental link of dynamic libraries and to generate
3144 the Python wrappers library with the inclusions of the underlying C++
3146 The following modifications concern this matter on Win32/VC++:
3147 - wrapping python correct with standalone wrapped dll (don't use separate
3148 dll under windows !!!!)
3149 - python21_d debug mode enabled (ask Frog how to use it :-)
3150 - NO problem with having an STL member of class for example string in C++
3151 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3152 - Python test of dcmlib in Python is ok under windows on a large set
3154 * removed glib references
3155 * typedef's inserted in gdcm.i for correct swig type management
3157 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3158 * python/demo/*.py load.py extracted from test.py. Added explore.py
3159 that only displays required tags and testAll.py that parses all
3160 the files of the testsuite without using unittest.
3161 * python/testSuite.py other additional test on new files added.
3162 * Data/* new test files added accordingly to the testSuite.
3163 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3164 the vr in the file differs from the one of the dictionary.
3166 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3167 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3168 values, but limits itself to values which are below a user specified
3169 size (by default 1024 bytes).
3170 * python/gdcm.i : elements not loaded (because their size is above the
3171 user specified treshold) are exported with their TagKey as key of the
3172 python dictionary. This enables the testsuite to make some checks
3173 on the unloaded elements (since we have their offset and size).
3174 * python/testSuite.py
3175 - now tests for the existence and proper value of the pixel data
3176 - two new examples added.
3177 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3179 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3180 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3181 aware. See the strategy comments in gdcmHeader::FindeLength().
3182 * Test/test.cxx now accepts a filename as first argument.
3183 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3184 * python/testSuite.py changed to integrate test on above files.
3186 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3187 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3188 the vr was also RET.
3189 * python/testSuite.py more tests added.
3191 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3192 * python/testSuite.py unittest test suite added (uses Data)
3193 * Data/* dcm and acr files for the test suite.
3194 * glib dependance removed from un*x version. We now use ISO C99
3195 7.18 Integer types (see stdint.h)
3196 - python/Makefile, src/Makefile src/gdcm.h
3197 * src/ when an explicit vr (like dicom files) suddenly poped an
3198 implicit element we use to mark the underlying DictEntry of the
3199 concerned ElValue with "Implicit". This strategy was damageable
3200 too the public or provite dictionaries, since some of their vr
3201 would be changed. Since Header::FindLength heavily relies on the
3202 detection by Header::FindVR of falsely explicit elements, I
3203 added an extra ImplicitVr member to ElValue (boolean).
3204 The rest of the changes we the necessary adaptations.
3206 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3207 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3209 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3211 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3212 * Adaptation for porting to VC++:
3214 o forced to use std namespace (for string to be known)
3215 o all class use __declspec export style on WIN32
3216 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3217 (in stdlib.h on Win32 but in std:: for gcc)
3218 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3219 variable GDCM_DICT_PATH.
3220 * src/gdcmHeader.cxx verbose comments made discrete.
3222 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3223 * python/gdcm.i: added a typemap that converts a C++ hashing table
3224 to native Python dictionary.
3225 * python/demo/test.py:
3226 - now uses the native dictionary for exploration of gdcmHeader.
3227 - takes an optional filename argument (the file to parse).
3228 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3229 PubElVals hashing table.
3230 * Dicts/dicomV3.dic removed error prone trailing spaces.
3232 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3233 * Python wrapping process moved away from src/Makefile to
3234 newly created python/Makefile (as well as gdcm.i)
3235 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3236 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3237 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3238 from the environement variable GDCM_DICT_PATH (when existing).
3239 * src/gdcmDict::GetTag bug fix.
3241 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3242 * Straightforward temporary fixes for swig to build the python wrappers.
3243 src/Makefile now has a python working entry [by working we mean
3244 that we can import de shadow classes without errors].
3246 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * hashtest.cxx removed (since already in Test)
3248 * src/gdcmlib.h renamed to src/gdcm.h
3249 * src/dcm.i renamed to src/gdcm.i
3250 * src/Makefile prepared for python wrapping
3252 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3253 * src/gdcmHeader.cxx :
3254 - Parsing of header is now separated from loading of element values
3255 (see gdcmHeader::LoadElements).
3256 - general clean up of hopefully all file access (creation of
3257 ReadInt16 and ReadInt32)
3259 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3260 * src/gdcmHeader.cxx :
3261 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3263 - SetLgrElem renamed to SetLength
3264 - GetLgrElem renamed to GetLength
3265 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3266 * src/gdcmElValSet.cxx fixed both GetElValue methods
3267 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3268 due to IdoDude was cleaned out.
3270 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3272 concentrates on finding the value representation (when it exists).
3273 RecupLgr now only finds the element value length, and it avoids
3274 returning the unecessary skL (skipped length).
3275 Also, offsetCourant was simply removed (with taille_fich) since
3276 it was redundant with the File position internals (by using
3277 ftell and fseek). This also made skL (see above in RecupLgr) usage
3279 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3280 on the libido specificities which are handled through class
3282 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3285 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3286 * Truckload of changes. Parsing of header is barely functional
3287 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3289 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3290 * src/gdcmHeader.cxx many addons of low level methods
3292 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3293 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3294 and _IdDcmSWAP_LONG.
3296 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3297 * This corresponds to all the changes decided at the meeting of
3298 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob