1 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
3 file. Debug is yanked if compiled with NDEBUG
5 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDictSet.h : set the default output to the os variable
7 * src/gdcmDictEntry.[h|cxx] : add the Print method
8 * gdcmPython/demo/ : add a new test
10 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
11 * merging of Test/PrintDicomDir and Test/TestDicomDir
12 * removal of now redundant Test/PrintDicomDir
13 * enhancement of Example/PrintDicomDir
15 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Now, python test might work on systems
17 * Add the PrintDicomDir test
19 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
20 * FIX : First entry following group 0002 was lost for
21 Explicit Big Endian Transfer Syntax files
22 (group and elem not swaped)
24 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
25 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
26 Big Endian Transfer Syntax supposed the group following 0002
27 begins always by element 0000 (element 0000 is *optional*)
28 To avoid further troubles, let's be pessimistic, and use
29 Document::HandleOutOfGroup0002() method
30 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
31 (related pb not yet solved)
33 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Bug fix for the python part use
35 * Now, PrintHeader.py pass... but outside the ctest use. shit !
37 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
40 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
42 a string and should ask the global TS dict what are the propreties of
45 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
46 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
47 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
48 to swap the Swap Code, at parsing time, when we come out of group 0002
49 and Transfer Syntax is Big Endian
50 We should be able to read now 'true DICOM" Big Endian coded images
51 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
52 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
54 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
55 * Hopefully fix the bug on MacOSX and static global initialization.
56 This is the only -minor- patch I found that both please MacOSX and VS6.
57 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
58 but this would require a lot of change. Another approach would be that Global
59 create those string and GDCM_UNFOUND becomes a pointer to a string (which
60 gdcm::Global would destroy at exit).
62 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
63 * Fix bug on MacOSX with static initialization in a multy threaded
64 environment. static const string in a header file used to be ill
65 initialized provoquing the freeze of any tests. patch should solve this
68 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
69 * According to Benoit's suggestion, and without any objection from anybody
70 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
71 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
72 - method gdcmDicomDirObject::GetEntry() renamed as
73 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
75 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
77 you debug/warning message just as c++ streams which make them very convinient
78 to use. Once this is stabilize I will change the ostringstrem to be
79 redirected to a file (ofstream).
80 * Properly support C99 extension: __FUNCTION__ which allow us to display
81 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
83 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
84 * Removal of useless and dangerous methods :
85 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
86 GetDocEntryByName, GetEntryByName, GetDictEntryByName
87 * Removal of usless methods :
88 Dict::PrintByName, Dict::GetDictEntryByName
89 * Commenting out of probabely useless methods :
90 Dict::GetDictEntryNames()
91 Dict::GetDictEntryNamesByCategory()
92 DictSet::GetPubDictEntryNames()
93 DictSet::GetPubDictEntryNamesByCategory()
94 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
95 * ENH : Use dicomTS.dic as described in 2004 version
96 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
97 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
98 Add Accessors on VM (Value Multiplicity), and VM related methods
99 * ADD : Add a list of 'Dicom Attribute types', as found in
100 http://medical.nema.org/dicom/2004/04_15PU.PDF
102 * ADD : Add dicomGroupNameAbbreviations.dic
103 should be used to write a method to replace the former
104 Dict::GetDictEntryNamesByCategory()
106 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
108 to read in the file... and only it ! Length is the efective length of the
109 data in the DocEntry structure
111 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
113 And now use a static function call instead, with a global variable. i
114 This is much closer to the VTK approach. Hopefully should be bulletproof
115 and easier to use...hopefully
117 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
120 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
123 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
125 ValEntry, BinEntry, SeqEntry creation or replace
127 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
129 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
131 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
132 when specifying the VR
133 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
134 * src/gdcmDocEntry.cxx : amelioration of print
136 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
137 * ADD : Add the method Util::IsCurrentProcessorBigEndian
138 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
139 * ADD Method Document::ComputeGroupLength
140 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
141 in order to allow further VR modification by user
142 * REM : removal of once-called method File::WriteBase
143 integration of its code in formerly one-line method File::Write
145 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
147 replace the different values "??", "Unkn", "Unknown".
148 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
149 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
150 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
151 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
153 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
156 * Set the gdcm::Base class to some Printable classes
158 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmFile.[h|cxx] : add the Print method
160 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
161 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
162 * src/gdcmDocument.h : remove the PrintLevel informations
163 * Example/PrintFile.cxx : use the new gdcm::File::Print
165 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
167 problems when compiling with the python wrapping
169 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
171 writting in ImplicitVR
173 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
174 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
175 JPEG decompression, especially when dicom frames are split into several
176 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
177 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
179 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmHeader.cxx : change the initialisation of default header.
181 Now, this header is readable by gdm, e-film, DicomWorks
183 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
185 Rename Decompressed to Raw
186 * Use the API changes in gdcm::File.
187 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
190 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
192 each added entry in the header. Replace the 'Planes' field by the 'Number
195 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
197 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
199 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
201 At this time, this image isn't readable by e-film... waiting JPR help to
204 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
206 DocEntry. Now use methods of the Document !
208 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * Test/ShowDicomSeq.cxx : bug fix
211 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
213 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
214 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
215 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
217 * Test/TestCopyRescaleDicom.cxx : remove unused variable
218 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
219 containing found sequences
221 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
224 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
225 Some fields in BinEntry must be copied to not seg fault when making the :
226 gdcm::File *copy = new gdcm::File( copyH );
227 and tests are now made on good variables
229 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
231 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
233 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
234 * Add vtkGdcmWriter example and test
236 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * Test/TestUtil.cxx : reformat the source code
238 * vtk/vtkGdcmReader.cxx : remove and change prints
239 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
241 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
242 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
244 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
246 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
248 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
250 by an eof to prevent all bad read of the file... and in this case, the
253 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * Example/Volume2Dicom.cxx : comment unused variables
255 * Test/PrintDicomDir.cxx : comment unused variables
256 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
257 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
258 method that is redondant with AddEntry.
259 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
262 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * Bug fix due my last commit (compilation under Windows).
264 * Example/Volume2Dicom : bug fix in the file and reformatting source code
265 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
267 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
269 - Remove printf / sprintf
270 - include iostream AFTER gdcm so we don't get warnings
271 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
273 - Also remove tons of include from header files, hopefully this should
274 speeup the compilation time, since it was becoming a dog slow.
275 - Remove gdcm.h as it include way too many files and slow down compilation
276 (plus it is not up to date)
277 - remove 'using namespace std' this is BAD !
279 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * Remove memory leaks on the DicomDir
281 * Remove some useless data in DicomDirObject
282 * Add usefull methods in SQItem, to be complient withe the ElementSet
284 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
287 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
289 future, with convertion)
290 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
291 and ImageDataSize values. Remove the method to get the PixelReadConverter
292 from the output of the class
294 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
297 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
299 and vtkErrorMacro use.
300 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
302 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
305 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
306 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
307 The string leaves only in the fonction. So when we make a .c_str(), we
308 get the pointeur on the first element, element that will be destroyed
309 immediately after thee instruction.
310 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
311 file has been opened : the test must be made on the content of the
312 pointer and not directly on the pointer !
315 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
317 the python part recompiles
319 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
321 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
322 X session is killed (for my computer... it seems to not be identic on
325 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
327 avoid problems (otherwise, the difference test between the visible image
328 and the reference is incorrect. If the reference is greater than the
329 screen resolution, it's produce errors).
330 Can be used for only one image. Can be used with a visible flag.
331 * vtk/vtkGdcmReader.cxx : remove commented codes.
332 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
333 under windows at compilation
334 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
336 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
338 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
340 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
341 tests on the image size X, Y, Z
343 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
344 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
345 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
346 between the class name and the file name
348 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * src/ : fix compilation warnings for the Write method (2 different
350 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
351 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
352 variable... create a static method in gdcm::Document to access to
353 this variable content.
355 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
357 file, to be accessed by other files (like gdcmFile). Remove commented
358 code. Move the change of the header to the gdcmFile, using the
360 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
361 To be sure of that (and simplify calls), the Write of the header now
362 gets a file name and not a file pointer (std::ifstream).
363 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
364 DocEntryArchive. Remove all open of the written file
366 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
369 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
371 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
373 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
374 some corresponding methods. Write correctly the file and check before
376 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
377 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
378 is now on RGB data (as before my last commit
379 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
381 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
382 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
383 Add a print information of the type of the entry
384 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
385 It was in the gdcmFile, and all write have been regrouped
386 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
387 Write correctly all dicom files (in decompressed mode only at this time)
388 * Test/ : test on files are now made using Raw data and not color data if
390 * Example/PrintFile.cxx : add more printings
392 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * Amelioration of code, remove some code copy. For the loading of
394 BinEntry (in gdcmDocument), add the test to verify if the file is already
397 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
399 remove a DocEntry in the header (push an empty DocEntry)
400 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
401 lines. Bug fix in the initialization of the PixelConvert and the
403 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
404 use in TestCopyDicom (now this test can run under windows... but fails)
405 * Test/TestCopyDicom.cxx : amelioration of the test :
406 - test the pixels written
407 - add test points to quickly find where is the error
408 - can set a file name input and output in arguments
409 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
410 amelioration of the test output
412 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
414 all replaced DocEntry's
415 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
416 Now, each needed DocEntry to modify is duplicated, modified and inserted
417 to the header using DocEntryArchive. Thus, after save, we can restore the
418 header initial state.
420 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
423 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
425 correct to copy it. The DictEntry is specified at the DocEntry creation,
426 then, it musn't change in the time.
427 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
428 header correctly. At this time, the change is only made for the first
429 level of the Document. In the future, it might consider sequences.
430 The change is made by replacing a DocEntry by an other that is created
431 outside the class. The old value is kept. When we restore the header
432 status, the added DocEntry is deleted and replaced by the old value.
433 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
434 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
435 set the write type to explicit VR, implicit VR or ACR. Add methods to set
436 the write mode to native, decompressed or RGB (but not used at this time)
438 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
440 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
442 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
444 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
446 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
447 set because already copied when copying the BinEntry's of the header
448 * Test/TestAllReadCompareDicom.cxx : remove warnings
450 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
452 Two problems appear when doing it :
453 - with the gdcmFile : when the GetImageData method is called, the pixels
454 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
455 data (pixels). And each structure destruct the data when it's
456 destructed. So we have two destructions for the same data. To solve it,
457 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
458 data or not. If it doesn't own data, then they will not destroyed by
460 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
461 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
462 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
463 create a double destruction of the same DocEntry's. So, to solve it,
464 the TagHT is simply cleared and the DicomDir* elements are destroyed.
465 * TODO : add an entry concerning memory leaks in the DicomDir
467 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
468 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
469 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
472 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
474 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
475 after it have been deleted
477 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * FIX: src/* fix the doxygen warnings.
479 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
480 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
481 was erroneously defined with a size of 15 instead of 16. [many thanks
482 to Jean Michel Rouet for pointing out this bug].
484 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
485 1. Finish merging JMR patch for writting DICOM from scratch
486 2. Fix -hopefully- bug with MONOCHROME and space vs null character
487 3. Use const ref when possible
488 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
489 5. A few more comments
490 6. CreateUniqueUID can now be called without parameter"
492 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
493 * ENH: Slightly bigger patch:
494 1. Getting toward full integration of JMR patch for writting dicom from scratch
495 2. Update Test to test part of this patch: CreateUniqueUID
496 3. File was not close properly in gdcmDict
497 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
498 5. Use of const ref instead of copy (speed issue)
499 6. Remove temporary (duplicate) string in TranslateToKey
500 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
501 8. Do not repeat virtual in subclasses
502 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
504 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
505 * Apply first patch toward better string comparison when dealing with broken
506 DICOM files. Essentially the string could be padded with a space instead
507 of a null character as defined by standard
509 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
510 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
511 because never used... and in the same time, that's remove some memory leaks
513 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmFile.cxx : now delete the PixelConvert instance.
515 * In examples and tests : change the type of image data variables from void*
516 to uint8_t*. Remmove all delete on image data variables
518 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
520 Verify the file pointer value before open the file, and if it's not null,
521 a verbose message is generated.
522 Close correctly the file when the file isn't considered dicom-like. The
523 correctly close is a call to CloseFile.
524 When closing the file pointer, test if its not null to close the file.
525 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
526 file. For an uncompressed image, the copied data correspond in the least
527 case to the image size (calculated) or the image size specified in the
528 header. A verbose is generated if these two size mismatch
530 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
532 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
533 break under windows (with msvc6 compilation).
535 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
537 compiling with MSVC6)
539 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * Bugs fix for the Windows build with VC6
541 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
542 needed (only for projects required VTK). If the VTK is included in all
543 projects, there is conflicts with the jpeg lib of vtk when compiling the
544 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
545 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
546 when compiling the gdcm_wrap.cxx file (created by the compilation of the
548 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
549 (like it's already made for the cout use). Otherwise, conflict with the
552 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
555 - comments on the DicomDir::Method related usage added.
556 - now that we use the namespace gdcm, a lot of internal classes do
557 NOT need to be wrapped anymore.
558 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
559 DicomDir::Method) new example added.
561 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
562 * Improve string manipulation. I now inforce the notion of 'DicomString'
563 A DicomString can contain as many \0 as they want
564 and it is *always* of even length.
565 We only support odd length for very rare case.
566 And in the near future this should be removed.
568 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * /binary_write/ gdcm source. Now even on big endian we are writting
570 little endian. This should -heopfully- fix some tests
572 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
573 * Now the dictionary is compiled into gdcm lib. This is a default
574 behavior, thus any dic file specified is picked before failback to
575 the one comiled into lib
577 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
578 * Change internals for gdcmDict. Don't use any 'new' any more.
579 This should definitely solve any leak problem, and we should be
580 as fast as before, as long as don't modify too much the dictionary.
582 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
583 * STYLE: ivars should start with a capital letter.
584 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
585 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
587 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
589 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
590 new 2004 dictionaries added (thanks to JPR).
591 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
592 * CLEANUP_ROUND (15) for gdcmPixelConvert
593 - RLEFrame::NumberFragments is now of type unsigned int
594 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
595 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
598 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
599 * Initial work in gathering all transfer syntax accessors. clearly
600 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
601 ivars, but only one transfersyntax (class) ivar with equivalent method on
604 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
606 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
607 discussed (plus I didn't like having a 2000 lines patch not commited)
609 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
611 * CLEANUP_ROUND (14) for gdcmPixelConvert
612 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
613 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
614 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
616 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
617 anymore and hence avoids storing a copy of PixelConvert::Decompressed
618 into File::Pixel_Data.
620 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
621 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
622 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
623 * CLEANUP_ROUND (13) for gdcmPixelConvert
624 Substituted File::ParsePixelData() with PixelConvert::Print() new
626 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
627 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
628 method to those classes.
629 - src/gdcmFile.[cxx|h]:
630 -- Added a ::Print() method.
631 -- PixelConverter is now a reference instead of a member.
632 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
633 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
635 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
637 collaboration diagram and inheritance diagram should be generated with
639 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
640 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
641 pointlessly wrapped (see
642 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
643 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
644 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
645 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
646 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
647 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
648 -- File::Initialise: PixelConverter setup moved away to
649 PixelConverter::GrabInformationsFromHeader()
650 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
651 interpretation moved away to PixelConverter::BuildRGBImage()
653 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
654 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
655 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
657 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
659 displayed on Win32 when a brutal abort() occurs (because of uncatched
660 exception). See TODO new entry of this commit for more on this.
661 * TODO added new entry.
662 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
663 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
664 - HandleColor is no longer called from gdcmFile.cxx
665 - gdcmPixelConvert.cxx clean up on method arguments and internal
666 variable names for semantical coherence.
668 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * Finished lossless transition, not only do we now read all lossless jpeg
670 images, without the need of the Cornwell lib, but we do read them properly now
671 * To reduce code (well to avoid code duplication), I defined a common place
672 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
673 redefine symbols. This is not perfect but this the best solution I found for a
674 compilation time jpeg option.
676 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
677 * Update jpeg ijg lib to support lossless jpeg implementation
678 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
680 * Also added a special copyright for dcmtk since we use their bugfixes.
683 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
685 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
686 matters, as stated in warning note at begining of %include section).
687 * src/gdcmDicomDir*.[cxx|h]: coding style
688 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
689 * src/gdcmJpeg8.cxx: doxygen fix.
690 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
691 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
692 from File:: to PixelConvert::.
694 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
696 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
697 - more code moved away from File:: to PixelConvert::
698 - fat setup of PixelConverter set in place in File::Initialise.
700 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
701 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
702 namespace at the file system level. So now you should convert your examples
704 gdcmHeader -> gdcm::Header
705 It would be nice if people keep in mind to no open the namespace, since it
706 allows compilation on broken plateform which were defining common symbol in
707 the standart namespace (like LP, Unknown ...)
709 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
711 The JPEG fragments are now parsed at the same stage than the RLE
712 information. All code related to JPEG is now in gdcmPixelConvert:
713 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
714 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
715 export a gdcmFile:: method. Those are simply global functions
716 (for the time being this is better than having them attach to
717 either gdcmFile:: or gdcmPixelConvert::).
718 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
719 and stores the result in a gdcmJPEGFragmentsInfo.
720 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
721 code (among other stuff) moved away from gdcmFile:; to
724 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
726 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
727 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
728 clean up of RLE related code.
729 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
730 - src/gdcmRLE.cxx removed
731 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
732 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
733 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
734 * CLEANUP_ROUND (9) for gdcmPixelConvert
735 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
736 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
737 away from gdcmFile:: to gdcmPixelConvert::.
739 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
741 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
742 This is because Parse7Fe0 used to parse the pixels to compute the
743 length. This task was passed over to FindDocEntryLengthOB() a long
744 time ago, EXCEPT I had forgotten the OW case...
745 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
746 we just recylce the code for parsing RLE fragments and computing
748 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
749 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
750 with the retired Parse7Fe0().
751 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
752 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
754 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
756 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
757 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
758 - src/CMakeLists.txt: alphabetic order reodering + new entries.
759 * CLEANUP_ROUND (4) for gdcmPixelConvert
760 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
761 to return an unused length.
763 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
764 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
765 this should be cleanner from the plane view. The iostream are erally a pain
766 to use to do simple stuff.
768 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
769 * Redo the compilation of the ijg jpeg library. Now only one source is
770 necesseray. No need to rename file by hand what so ever. CMake handle the
771 copying of the file within different directory, configure header file to
772 modify some symbol. The only addition made to ijg wasd a mangle table so
773 that symbol are different wether we are within 8bits or 12bits.
775 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * Added documentation of vtkgdcmReader on Website:
777 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
778 with it's binary name).
779 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
780 the Website to be more complete.
781 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
782 doxygenated documentation.
783 - Doc/DoxyVtkGdcmReaderExamples.txt added
784 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
785 DoxyVtkGdmReaderExamples.html )
786 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
787 * CLEANUP_ROUND (3) for gdcmPixelConvert
788 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
790 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * CLEANUP_ROUND (2) for gdcmPixelConvert
792 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
794 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * CLEANUP_ROUND for gdcmPixelConvert:
796 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
797 - src/gdcmPixelStuff[h|cxx] removed
798 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
799 - src/CMakeLists.txt changed accordingly
801 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
802 gdcmVersion.py moved to newly created ATTIC related
803 gdcmPython/SetupOldies/ directory.
804 * Autotools clean up:
805 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
806 - autogen.sh configure.in acinclude.m4 python.m4 removed
808 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
809 * src/*.cxx *.h Reference to License.htm fixed to License.html.
810 * Doc/CMakeLists.txt, doxygen.config.in: fix.
811 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
813 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * TODO updated with Mathieu suggestions. I proposed a template for
815 describing TODO entries and used it for new entries.
816 * Added Doc/Website/CodingStyle.html, Developpers.html,
817 DeveloppersPython.html, GdcmDataCvs.html and
818 DownloadVersion0_1.html, DownloadVersion0_3.html.
819 * Some Doc/*.txt Doxygen files (which do not really concern the
820 documentation itself, but the website) moved to html and
821 placed in directory Doc/Website:
822 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
823 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
824 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
825 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
826 * CMakeLists.txt changed accordingly.
827 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
828 DeveloppersPython.html
829 * INSTALL nows refers to Doc/Website/Installation.html
831 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
832 * Added Doc/Website directory, that contains a first raw version
835 2004-09-23 Jean-Pierre Roux
836 * FIX In order not to be poluted any longer by casting problems,
837 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
838 we can now delete[] it safely
839 * VoidArea is now called BinArea (less confusing name),
840 and all the methods called ...VoidArea... are now ... BinArea...
841 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
843 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
845 clear) TagHT, which is an inherited member of gdcmElementSet. It is
846 up to the destructor of gdcmElementSet to clean up TagHt and it's
849 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * Test/CMakeLists.txt: update to follow gdcmData renamings.
851 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
853 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * ENH: added some utility method that builds a flat dictionnary
855 holding all the Dicom entries contained in the recursive structure
856 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
858 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
859 BuildFlatHashTable() that build a flat dictionary.
860 - src/gdcmElementSet.h: added a new private GetTag() accessor.
861 gdcmDocument is now a friend of gdcmElementSet.
862 - src/gdcmElementSet.cxx: clean up.
863 - Example/FlatHashTablePrint.cxx added.
864 - Example/CmakeLists.txt changed accordingly
866 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
868 moved away from gdcmDocEntrySet (since this class is an abstract class
869 acting like an interface). SQDepthLevel and BaseTagKey are now
871 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
872 and associated accessors. Doxygenation of the class.
873 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
875 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
876 Use SQDepthLevel accessor instead. ::Print() adapted.
877 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
878 - src/gdcmDocument.cxx changed accordingly.
880 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
882 - The following is the doxygen comment of the typedef declaration
883 of gdcmTagKey in src/gdcmCommon.h:
884 gdcmTagKey is made to old an "universal" (as in URL, Universal
885 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
886 A dicom tag always has a group and an element, but a set of tags
887 embeded in various (optionally nested) sequences and sharing
888 the same group and element all share the same (group, element)
889 "identifier". Hence the (group, element) cannot be used as an
890 identifier (in gdcm we shall refer to a "TagKey") of a tag.
891 In order to construct a proper tag identifier (i.e. a key) we
892 consider the following definition of a TagKey:
893 - let Group, Element be the string representation of the
894 group and element dicom tag members,
895 - let ItemNumber be the string representation of the integer
896 index of the considered item number of a sequence,
897 Let the key of a tag embeded in a sequence, noted SeqTag, be
899 /ItemNumber#Group|Element
900 where "/", "#" and "|" are characters acting as separators.
901 Then the general form of a gdcmTagKey is given by:
902 Group|Element<SeqTag>
903 where <SeqTag> means NO or many instances of SeqTag.
904 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
907 but the gdcmTagKey of a tag "embeded" is the first item of
908 a sequence, itself nested in the third item of a sequence is the
910 0004|1220/2#0008|0082/0#0008|0090
911 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
912 order to hold the new sequence compatible key. Previously, the
913 GetKey() method would look in the underlying gdcmDictEntry.
914 - src/gdcmDocEntry.cxx:
915 -- constructor now copies the underlying DictEntry key, in the local
917 -- ::Print: displays the member Key, instead of the (group, element).
918 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
919 - src/gdcmDocEntrySet.h:xi
920 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
921 -- now has a new BaseTagKey member.
923 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
924 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
926 This poses the problem with the semantics of the following lines
927 LoadEntryVoidArea(0x0028,0x1201); // R LUT
928 LoadEntryVoidArea(0x0028,0x1202); // G LUT
929 LoadEntryVoidArea(0x0028,0x1203); // B LUT
930 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
931 to the long FIXME note for what the problem is. Nevertheless in
932 order to get things working the dicom dictionary was altered !
933 Please fix things urgently...
934 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
935 information), see above note on moving the member VoidArea. Nevertheless
936 the following entries previously correctly set as US are now inproperly
938 0028 1201 OW IMG Red Palette Color Lookup Table Data
939 0028 1202 OW IMG Green Palette Color Lookup Table Data
940 0028 1203 OW IMG Blue Palette Color Lookup Table Data
941 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
942 of gdcmDocEntry moved to gdcmSeqEntry.
943 * src/gdcmSeqEntry.cxx: STYLE.
945 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Test/TestAllEntryVerify.cxx minor fix and added comments.
948 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * gdcmPython/testSuite.py: all the test suite in python is now moved
950 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
951 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
952 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
954 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
955 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
956 to avoid inclusion recursion until STL is reached.
957 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
958 mecanism. errno.h is not included in gdcm anymore.
959 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
960 (gdcmFormatError now inherits from gdcmFormatUnexpected).
962 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
963 gdcmData/TestAllEntryVerifyReference.txt
964 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
965 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
966 exception_on_error parameter.
967 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
968 - vtk/vtkGdcmReader.cxx changed accordingly,
969 - Example/*.cxx and Test/*.cxx changed accordingly.
971 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
973 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
974 enable_sequences removed from gdcmHeader constructor and dependencies.
975 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
976 * gdcmPython/demo/PrintHeader.py: dummy fix.
977 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
978 skip_shadow removed from gdcmHeader constructor and dependencies.
979 * Example/*.cxx and Test/*.cxx changed accordingly.
981 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
983 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
985 2004-07-21 Jean-Pierre Roux
986 * FIX Now, Parsing and Printing a DICOMDIR do work!
987 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
989 2004-07-20 Jean-Pierre Roux
990 * FIX Some brain damaged headers have Zero-Lenght fields
991 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
993 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
994 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
995 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
996 variable (instance of gdcmDebug) by a definition macro, and the instance
997 is now in static in the gdcmDebug class
998 * src/gdcmSQItem.h : (FIXME) remove an undefined method
999 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1001 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1002 * WARNING: ctest now depends more tightly on gdcmData. You should
1003 check out gdcmData properly for things to run smoothly...
1004 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1005 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1006 we need the pixels not be loaded in order to use the ValEntry
1007 that displays position and size).
1008 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1009 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1010 be deprecated. If you have any doubts about the advantages of a
1011 modern scripting language (read Python) versus grass root C++ (i.e.
1012 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1013 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1014 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1015 Anyhow, consider documenting the gdcmData images in
1016 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1018 * Test/CMakeLists.txt:
1019 - now uses TestAllEntryVerify.cxx
1020 - specific comments on oldACR00001.ima (now renamed in gdcmData
1021 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1022 gdcmData/TestAllEntryVerifyReference.txt
1025 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * src/*.[h|cxx] : typedef clean up
1027 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1028 - TagKey renamed to gdcmTagKey (for external usage)
1029 - VRKey renamed to gdcmVRKey (for external usage)
1030 - removal of typedef duplication.
1031 - Removed all unecessary inline keyword from class inline definitions.
1032 - Some method|function(void) declarations replaced with method|function().
1033 * src/jpeg/libijg12/jdhuff12.c:
1034 - printf polluting ctest removed.
1035 - TAB removal for comminting
1037 - TestAllReadCompareDicom.cxx: added a test that compares all the
1038 images in gdcmDataImages.h with corresponding images in
1039 gdcmData/BaselineDicom/. When baseline images are not present
1040 this test creates them.
1041 Note: we need to validate each reference image, but before that
1042 I'd like to rename them with a more explicit name...
1043 - CMakeLists.txt: changed accordingly.
1044 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1045 including each header needed).
1047 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1049 test suite to the Example directory. Are concerned:
1054 - TestWriteSimple.cxx
1055 * Test/CMakeLists.txt: added some comments on reasons for black listing
1056 image gdcmData/oldACR00001.ima
1058 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * Test/CmakeList.txt: removed the following from black list (to be coherent
1060 with removal from gdcmData):
1061 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1062 - gdcm-MR-PHILIPS-16.dcm
1064 Added the following because after last cvs update, they cause
1065 ctest -R TestReadWriteReadCompare
1067 - gdcm-MR-SIEMENS-16-1.acr
1069 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1070 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1071 new comments in this file) we temporarily (sigh) move to a weaker
1073 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1074 we don't need to black list the following images anymore:
1075 - 8BitsUncompressedColor.dcm
1077 - US-PAL-8-10x-echo.dcm
1078 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1079 fixes and the beautified code ;-)
1080 This fixes the bug introduced in version 1.42 (when beautifying)
1081 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1082 Note: ctest was blind to this bug (this means we need to still
1083 improve the test suite). The bug could be detected by using
1084 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1086 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1087 and by displaying the (garbage) produced file temp.XDCM...
1089 2004-06-29 Jean-Pierre Roux
1090 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1091 - replace by uggly but working old code :-(
1092 A lot of things should be OK again.
1093 It's really urgent to have a test suite that *tests*,
1094 to prevent Frog's beautifying sessions to break all the stuff
1095 (twice, withing a fortnigh ...)
1097 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1099 redundancy) to added Test/TestReadWriteReadCompare.cxx
1100 * Test/CmakeList.txt: because the compare test of
1101 Test/TestReadWriteReadCompare.cxx fails, the following images are
1102 black listed: - 8BitsUncompressedColor.dcm
1104 - US-PAL-8-10x-echo.dcm
1105 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1106 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1107 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1108 and ad-hoc kludge. This kludge is now removed, and on encountering
1109 such an image (OB field brain damaged) we set errno. Then in
1110 ::FindDocLength() we "fix" the length as being ALL what remains
1111 in the file (until EOF). We then proceed, hoping for the best...
1112 This fixes a SegFault in ShowDicom when trying to write such an
1114 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1115 (because TestWriteRead breaks on it, after a non conformal commit?).
1116 ctest now runs properly, except for MakeDicomDir (which was always
1117 broken) and the Python related stuff (still not fixed).
1119 2004-06-24 Jean-Pierre Roux
1120 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1121 FIX : Test/TestReadWrite now iterates on all the file names
1122 (instead of infinite loop)
1123 ENH : Test/TestWriteRead now iterates on all the file names
1125 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1128 2004-06-24 Jean-Pierre Roux
1129 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1130 when SamplesPerPixel =3
1131 - now Write is no longer confused by
1132 'BitsAllocated = 12" and 'BitsStored=12"
1133 - "UN" value representation Elements are now written correctly
1134 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1135 ENH : - now gdcmHeader has its own Write methods
1136 (in order to split the job that has not to be done
1139 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1141 loop on the same image until memory went out.
1142 Note: this means we still have gobs of memory loss in PrintDocument
1143 * src/gdcmDocument.cxx: fixes problem on parsing on file
1144 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1146 2004-06-24 Jean-Pierre Roux
1147 FIX : Write - All the Sequences and Sequence Item are now written
1148 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1149 is added a the end, when necessary.
1150 - A lot of brain-damaged images, that were read correctly are
1151 now written correctly
1152 - length compatible BinEntry are now loaded correctly
1153 (even for odd groups)
1154 Note : only Explicit Value Representation was checked.
1155 (question : is implicit VR really necessary for gdcm ?)
1157 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * DEVELOPPER: added a proposition of coding style.
1159 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1162 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1164 Use the gdcmDocEntry::Print() and Write() instead.
1165 * src/gdcmDocument.cxx: bug fix.
1167 2004-06-22 Jean-Pierre Roux
1168 FIX : gdcmDocument.cxx
1169 - Now we do recognize the JpegLossLess format (there was a misstyping in
1170 code 'beautyfication' :-(
1171 - Now we automaticaticaly load the Luts, if any
1173 2004-06-22 Jean-Pierre Roux
1174 In order : to write Sequences, whatever their imbrication level,
1175 : to allow user to create his own Sequences
1176 a lot of modif where necessary (adding, moving, or virtualising methods)
1178 WARNING : save your own sources *before* cvs up !
1181 ADD virtual void Write(FILE *fp, FileType filetype);
1184 ADD virtual void Write(FILE *fp, FileType filetype);
1185 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1188 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1189 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1190 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1191 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1192 ADD std::string GetEntryByName(TagName name);
1193 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1195 std::string vr = "unkn",
1196 std::string fourth = "unkn",
1197 std::string name = "unkn");
1198 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1199 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1200 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1201 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1202 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1203 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1204 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1205 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1208 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1209 ADD virtual std::string GetEntryByName (TagName tagName);
1210 ADD virtual std::string GetEntryVRByName (TagName tagName);
1211 REM virtual bool Write(FILE *, FileType);
1212 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1213 FILE *_fp, FileType type);
1214 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1215 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1216 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1217 REM virtual std::string GetEntryByName (std::string tagName);
1218 REM virtual std::string GetEntryVRByName (std::string tagName);
1219 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1220 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1221 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1223 std::string vr = "unkn",
1224 std::string fourth = "unkn",
1225 std::string name = "unkn");
1226 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1227 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1228 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1229 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1232 ADD virtual void Write(FILE *fp, FileType filetype);
1235 ADD virtual void Write(FILE *fp,FileType filetype);
1238 ADD virtual void Write(FILE *fp, FileType filetype);
1239 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1240 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1241 REM std::string GetEntryByName(TagName name);
1244 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1246 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1248 The default constructor invoked by the line
1249 gdcmHeader *f1 = new gdcmHeader( header );
1250 was gdcmHeader::gdcmHeader(bool) instead of the expected
1251 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1252 Hence the parsing wasn't executed... See also below.
1253 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1254 as explicit constructor didn't do the trick to fix the above problem.
1255 Could anyone explain why ?
1256 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1257 properly calls gdcmValEntry::Print() (that was weed out from
1258 code related to gdcmBinEntry).
1260 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * In order to fix memory leaks:
1262 - Test/TestWriteSimple.cxx: added cleaning of free store through
1264 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1265 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1266 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1267 (through the call to ::AddDicomDirMeta()) or the destructor
1268 would crash when deleting uninitialized ::metaElems].
1269 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1270 - src/gdcmDocument.cxx:
1271 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1272 from dynamic stores.
1273 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1274 was causing memory leaks.
1275 - src/gdcmSQItem.cxx:
1276 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1277 cleanly handled with polymophism: sorry but my milage is low).
1278 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1279 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1280 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1281 This avoids SegFaulting.
1282 - src/gdcmSQItem.h: coding style.
1284 - Test/TestWriteSimple still severely sucks. The output image content
1285 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1286 damaged when displayed with vtkgdcmViewer.
1287 - on memory leaks: TestWriteSimple leaks really less (see entry
1288 of 2004-06-18 in Changelog file for the call to valgrind).
1289 - on segfaults: ctest now passes all the tests but one (no more
1291 * Erroneous leading white fix:
1292 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1293 white[s] (as opposed to from >> xxx, that removes it [them].
1294 - src/gdcmTS.cxx: ditto.
1295 - gdcmPython/testSuite.py: dirty related kludge removed.
1296 * src/*: remaining references to gdcmParser removed.
1297 * src/*[cxx|h]: added copy[way]left header.
1300 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * In order to fix writing of dicom files:
1302 - Test/TestWriteSimple.cxx: a simpler example of writing.
1303 - Test/CMakeLists.txt changed accordingly.
1304 - src/gdcmDocument.cxx:
1305 -- The destructor now recursilvely removes potential sequences.
1306 -- Bug fix in ::IsJPEG2000()
1307 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1308 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1310 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1311 to only declared) and build on top of
1312 ::GetDocEntryByNumber(guint16, guint16).
1313 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1314 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1315 for usage in destructor and treatement of promotion in
1316 ::ReplaceOrCreateByNumber().
1317 - src/gdcmSQItem.cxx: destructor should better handle his job.
1318 Test/TestWriteSimple now runs (or at least it DOES something).
1319 * We can now start hutting memory links. A good starting point is:
1320 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1321 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1322 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1324 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * Valgrind note: after Mathieu Malaterre teached me how to read
1326 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1328 Using gcc, you can force the STL to use malloc and to free memory as
1329 soon as possible by globally disabling memory caching.
1330 With 3.2.2 and later, you should export the environment variable
1331 GLIBCPP_FORCE_NEW before running your program.
1332 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1333 simply vanish (it is still not clear to me, whether this means that
1334 STL std::string leaks or if valgrind believes it leaks...).
1335 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1336 running bin/gdcmTests makeDicomDir):
1337 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1338 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1340 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1341 SegFaulting (I drowned in DicomDir related code when trying to
1342 understand why the list is empty...).
1343 * src/gdcmDocument.h: first BSD license header try.
1344 * Doc/License.txt added.
1346 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1347 * src/gdcmDocument.[h|cxx]:
1348 - Clean up of the Transfer related predicates. They are now all based
1349 on new method isGivenTransferSyntax, that (should) handle properly
1350 the padding problem.
1351 - general clean up, simplification, and coding style.
1352 - Specific clean up of Parse7FE0() (umproperly named actually).
1353 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1355 2004-06-14 Jean-Pierre Roux
1357 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1358 - fix the display of SQItem ordinal number
1359 - add the GetSQItemByOrdinalNumber method
1360 - remove some useless never written private methods
1362 2004-06-14 Jean-Pierre Roux
1364 - adding a constructor taking a gdcmDocEntry as an input param
1365 - ReplaceOrCreateByNumber now returns :
1366 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1367 a gdcmValEntry * if a string value is passed as a param
1369 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1370 according to the param type (no longer sets a gdcmDocEntry)
1371 - GetValEntryByNumber, GetBinEntryByNumber added
1372 - NewValEntryByNumber and NewBinEntryByNumber added
1374 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1376 - GetSQItemNumber and SetSQItemNumber added, to provide
1377 a (relative) Item identier inside a given Sequence
1378 \warning : some pb remaining around this number
1380 - AddEntry now takes the Item Number as a param
1382 - adding a constructor taking a gdcmDocEntry as an input param
1384 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1385 * Memory leak hunt with the following command:
1386 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1387 --show-reachable=yes gdcmTests PrintDocument
1388 It looks like many (all?) leaks are due to the STL (or a bad usage
1389 of the STL. The lines producing the leaks now have a comment with
1390 a "MEMORY LEAK" tag: you can retrieve them with
1391 grep "MEMORY LEAK" src/*
1392 Here are two typical examples which I can't help fixing:
1397 char * test = "babo";
1398 name = test; //// <--- valgrind detects 960 bytes lost in
1399 //// call to std::string::operator=(char const*)
1400 name.clear(); //// Doesn't help !
1408 std::cout << "Type a bunch of characters followed by RETURN: ";
1409 getline(std::cin, line); //// <--- valgrind dectects a loss
1410 //// of 1320 bytes in call to
1411 /// std::basic_istream<>& std::getline<>
1417 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * src/gdcmHeader.[cxx|h]:
1419 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1420 and related, moved away to gdcmDocument.
1421 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1422 the corresponding protected accessors of inherited class
1423 gdcmDocument, removed ! As a consequence gdcmFile had to be
1424 declared friend of class gdcmDocument (see below).
1425 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1426 - Clean up of undefined or unused methods.
1427 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1428 account the changes to gdcmHeader.h).
1429 * src/gdcmDocument.h:
1430 - gdcmFile is now a friend class (in order to take into account the
1431 changes to gdcmHeader.h).
1432 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1433 (see changes to gdcmHeader.h).
1434 - Accessors (reading on the form GetEntry*) are now public.
1435 - Clean up of undefined or unused methods.
1436 * src/gdcmDocument.cxx:
1437 - adaptation to changes to gdcmDocument.h
1438 - ::OpenFile now writes a verbose message when file cannot be opened.
1439 - some std::string properly set to VRKey
1440 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1441 references to gdcmDocument.
1442 * Test/TestFindTags.cxx: changed accordingly to above changes.
1443 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1444 cvs repository gdcmData.
1446 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1448 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1449 conflicts with gdcmValEntry::voidArea.
1450 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1451 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1452 Value representation between StringRepresentable and BinaryRepresentable.
1453 * src/gdcmDocument.cxx:
1454 - method ParseDES: proper indentation restored and usage of
1455 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1456 - method LoadDocEntry: the fingerprint left in the SetValue() of
1457 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1458 removed. Reverting to previous code segment with the proper
1459 dynamic_cast< gdcmValEntry* >.
1460 Note: this was (partially) breaking the python test suite
1461 (gdcmPython/testSuite.py) that made usage of the above
1462 fingerprint to check presence of "Pixel Data".
1463 * src/gdcmDocEntry.h: coding style.
1464 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1465 now taken into account.
1466 * gdcmPython/gdcm.i: adaptation to the new internal representation
1467 of gdcm (exit gdcmParser, hello gdcmDocument).
1468 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1470 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1471 anymore, but instead prints the loaded Python dictionary.
1472 * .... alas, the python testSuite is still broken.
1474 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1475 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1477 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1478 * src/gdcmUtil.h : export methods
1480 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1483 * Initial addition of automatic python testing
1484 * Initial addition of automatic image comparison
1486 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1487 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1488 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1490 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1491 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1492 * Test/ShowDicom.cxx : bug fix for msvc compilation
1493 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1495 2004-05-04 Jean-Pierre Roux
1496 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1497 new concepts (and new classes) :
1498 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1499 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1500 - Sequence Doc Entries (gdcmSeqEntries)
1501 a Sequence is composed of Items.
1502 Each item is a set of Doc Entries (this is recursive)
1503 The non uniqueness of the 'Dicom tag' is due to this recursivity
1504 (never taken into account)
1505 Our unability to add a new 'entry' in the header
1506 at the proper location (neither in the H-Table (map or multimap),
1507 nor in the Chained List is also due to this recursivity.
1508 Don't try, right now, to use/modify/compile these new sources :
1509 nothing is finished.
1510 We just commit all the stuff, 'as is', in order not to loose it.
1512 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1515 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1516 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1517 file prefix (SetFilePrefix)
1519 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1520 * Add a new test: ShowDicom, for now this is just the c++ version of
1521 checkRead.sh, later it will be able to compare the image read against a
1523 * Replace the DEBUG on the stack with a global entry in cmake interface:
1524 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1526 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1527 * Add an example subdir, with a real example on how to read + write a
1530 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1532 * Doc/CMakeLists.txt: the main page is now properly differentiated
1533 between the developper and user version.
1534 * Doc/doxygen.config.in: dropped search related obsolete flags
1535 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1537 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1538 * DEVELOPPER: added some helpfull comments for compile/test/install
1541 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1542 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1543 src directory, now generated in the build dir.
1544 2. Tests as mentionned smarter
1546 4. Add a new method in gdcmDict that return the PubDict by name
1547 this is interesting for 3rd party lib like ITK,
1548 where we could set the institution name / patient name...
1550 * ENH: 1. Now the test suite is working for real
1551 2. All binaries are now output in the gdcm-bin directory
1552 (this was not true before)
1554 2004-04-28 Jean-Pierre Roux
1555 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1556 SeQuence indented printing of Dicom Header.
1557 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1558 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1559 Computation of SQDepthLevel is now part of gdcmHeader constructor
1560 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1561 tree-like structure of a Dicom Header.
1562 * FIX Test code cleaning
1564 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1565 * ENH: Adding automatic testing
1566 1. Need a DartConfig.cmake to submit to public
1567 2. Add a test driver gdcmTest.cxx
1568 3. gdcmTestMain, an helper for the main test driver gdcmTest
1569 4. Files in Test don't have a main anymore, this becomes interesting
1570 when we add more and more tests, thus dsw don't have to load
1572 * ENH: Adding a GDCM_DATA_ROOT for testing
1573 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1574 one file instead of seven + some small cleanup
1576 2004-04-22 Jean-Pierre Roux
1577 * ENH Minor changes to the Print() methods.
1578 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1579 Header printing. Example given with :
1580 > PrintHeader fileName 2 new
1581 (SQ based tree-like structure still to be done for the Header ...)
1583 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1584 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1585 1. I have added some unsigned where needed
1586 2. Some function parameter not used -> (void)
1587 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1588 4. g++ don't like character '\' in comment
1589 5. #define jpeg_create_decompress jCreaDecompress
1590 this really need to be fixed
1591 6. virtualize destructor of gdcmObject ... leakage
1592 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1593 this also really need to be fixed
1594 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1595 remove compression file
1596 (as we only do decompression, right ?)
1597 * ENH: Change malloc/calloc/free with c++ equivalent
1599 2004-04-21 Jean-Pierre Roux
1600 * FIX gdcmHeaderHelper::GetXSpacing
1601 when a single value is found (bug ?), xpacing is now
1602 defaulted to yspacing
1604 2004-04-19 Jean-Pierre Roux
1605 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1606 * ENH add parameters :
1607 bool exception_on_error = false,
1608 bool enable_sequences = false,
1609 bool ignore_shadow = false
1610 to the gdcmFile constructors to be full gdcmParser compliant
1611 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1612 to allow reading of PAPYRUS 3.0 files
1614 2004-04-06 Jean-Pierre Roux
1615 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1617 2004-04-02 Jean-Pierre Roux
1618 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1619 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1620 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1622 2004-03-30 Jean-Pierre Roux
1623 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1624 for ACR file, written out as DICOM files (hope so...)
1626 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1627 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1628 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1629 moved to base class gdcmParser and only the specialisation is kept
1631 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1632 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1633 already does the job.
1634 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1635 (to be consistent with gdcmParser::WriteEntries).
1637 2004-03-30 Benoit Regrain
1638 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1639 upate of the object's instance. It's passed to 2 in the unfavorable
1640 case : one in the ExecuteInformation, one in the ExecuteData
1642 2004-03-29 Jean-Pierre Roux
1643 * ENH : Check on file type to be written moved
1644 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1645 * FIX : gdcmObject::ResetBoundaries now stops properly
1646 when end-of-list is reached
1647 : gdcmVersion modified (as Benoit Regrain asked)
1649 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1651 * src/gdcmUtil.cxx: added forgotten iostream include.
1652 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1653 equivalent to ExplicitVR in existing code).
1655 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1656 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1657 now contains all the gdcmGlobal related code.
1658 * minor coding style and doxygenation changes.
1660 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1661 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1662 now contains all the Debug related code.
1663 * minor clean-up of includes in src/*.cxx
1664 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1665 CreateCleanString) removed.
1666 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1667 * Doc/DoxyMainPageUser.txt added.
1668 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1669 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1670 src/gdcmDirList.cxx)
1672 2004-03-24 Jean-Pierre Roux
1673 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1675 2004-03-23 Jean-Pierre Roux
1676 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1677 big endian made volumes
1678 * ENH Now gdcmParser constructor and destructor are protected to forbid
1679 end user to instanciate class gdcmParser
1680 (only gdcmHeader and gdcmDicomDir are meaningfull)
1682 2004-03-22 Benoit Regrain
1683 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1684 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1685 gdcmSerie to gdcmDicomDirSerie
1687 2004-03-19 Jean-Pierre Roux
1688 * ENH Now the tree-like structure describing a DICOMDIR comming from
1689 an already existing DICOMDIR file is consistent with
1690 the home-made tree-like structure build ex-nihilo
1691 or build from the files held (recursively) in a Directory
1692 functions gdcmDicomDir::CheckBoundaries()
1693 gdcmObject::SetBoundaries() added
1695 2004-03-17 Jean-Pierre Roux
1696 * REM (Eric Boix bug) : removal of meaningless
1697 gdcmDicomDirImage::NewImage function.
1698 * FIX now file names and directory name are written properly in the
1700 * FIX now gdcmDicomDir constructor may be call without any trick
1703 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1704 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1705 of gdcmDicomDirImage::NewImage as empty function.
1707 2004-02-28 Jean-Pierre Roux
1708 * ENH add gdcmDicomDir:NewPatient
1709 add gdcmDicomDirPatient:NewStudy
1710 add gdcmDicomDirStudy:NewSerie
1711 add gdcmDicomDirSerie:NewImage
1712 to allow making gdcDicomDir object.
1713 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1714 (as opposite to the gdcmHeader chained list)
1716 2004-02-11 Benoit Regrain
1717 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1718 when using from python
1720 2004-02-10 Benoit Regrain
1721 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1722 * FIX : in gdcmDicomDir when the directory is empty
1723 * ENH : add callback and methods to get the progression of dicomDir
1726 2004-02-06 Jean-Pierre Roux
1727 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1728 - GDCM_META added to gdcmDicomDirType
1729 - class gdcmMeta created
1730 * ENH : - A brief summary is now displayed at the beginning of
1731 'testDicomDir' to help disaster magnitude estimation
1732 * REM : Now useless Test/explDICOMDIR.cxx
1734 2004-02-05 Benoit Regrain
1735 * ENH : add methods in gdcmObject to get the hash table or the list of
1737 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1738 * FIX : wrapping python for TagHeaderEntryHT
1740 2004-02-04 Benoit Regrain
1741 * FIX : even length for some strings when writting the dicom dir
1742 * FIX : sort the images in the dicom dir
1743 * FIX : Bug fix for python use of dicom dir
1744 * ADD : a python demo
1746 2004-02-04 Jean-Pierre Roux
1747 * FIX : Final solution (?) for icone embedded images
1748 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1749 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1750 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1751 gdcmData/gdcm-MR-SIEMENS-16.acr1
1752 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1753 to make full checking easier
1755 2004-02-04 Benoit Regrain
1756 * FIX : WriteEntries : coding style & logic in parameters
1757 * FIX : Set the elements to create the DicomDir in a dictionary file
1759 2004-02-03 Benoit Regrain
1760 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1761 * gdcmDicomDir : add the load of directory
1762 * Bug fix and print add-on
1764 2004-02-03 Jean-Pierre Roux
1765 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1766 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1767 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1768 * FIX gdcmParser.cxx : 'group length' elements are now considered
1769 as integers, even for shadow groups, when file is Implicit VR
1771 2004-02-02 Jean-Pierre Roux
1772 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1774 of the last synonym :-(
1775 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1777 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1778 * FIX taking into account the possible 7fe0,0010 multiplicity
1779 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1780 to allow removal of references to 7fe0,0010, to deal with
1781 ACR-NEMA images, when 0028,0200 is meaningfull
1783 2004-01-31 Jean-Pierre Roux
1784 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1785 no longer writes 'Un' on disk
1786 * FIX SQ elements with actual length are now dealt with corectly
1787 * FIX gdcmFile::WriteBase make the difference, for color images, between
1788 the length (for Palette expanded images)
1789 and Raw Length (non expanded image + Palette)
1790 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1791 (that broke Write). Replaced by UL.
1792 Aware user will reload the field if he
1793 thinks it's necesssary
1795 2004-01-30 Jean-Pierre Roux
1796 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1797 when 'dirty Acr' is found, to be compliant with the new
1798 IsReadable() methods.
1800 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1801 (no DOUBLE images in kosher DICOM,
1802 but so usefull for people that miss them ;-)
1804 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1805 DICOMDIR related utilities (not checked as Windoze compliant)
1807 2004-01-28 Jean-Pierre Roux
1808 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1810 2004-01-27 Jean-Pierre Roux
1811 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1812 to allow skipping the shadow elements, to save memory space.
1813 The TRUE value for this param has to be used
1814 with a FALSE value for the 'enable_sequence' param.
1815 ('public elements' may be embedded in 'shadow Sequences')
1816 * gdcmHeader methods now deal with 'embedded icones images' in the header
1817 (even when an 'icone image sequence' is announced by the
1818 element (0x0088,0x0200), but there is NO icone at all ...
1820 * gdcmHeader sometimes Image Location value doesn't follow
1821 the supposed processor endianity (see gdcmData/cr172241.dcm).
1824 * gdcmHeader add the method
1825 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1826 to get *all* the Header Entries with the same tag.
1827 GetHeaderEntrySameName is probabely *useless*
1828 (no meaning : Name is *not* an identifier within the Dictionnary)
1830 2004-01-26 Benoit Regrain
1831 * Bug fix in the print of hexadecimal representations. Remove long fields
1832 in the print and add a third level of print to print them
1834 2004-01-23 Benoit Regrain
1835 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1836 * Bug fix on test suite after remove the strip made on not string fields
1837 * Split the IsReadable method between gdcmParser which test that the file
1838 is dicom and gdcmHeader which test that it's an image file
1840 2004-01-22 Benoit Regrain
1841 * DicomDir : clean code, add methods, set variables in protected or private
1842 * gdcmUtil : bug fix for the clean string method
1844 2004-01-19 Benoit Regrain
1845 * Add the use of shadow dictionaries
1846 * bug fix and coding style
1848 2004-01-19 Benoit Regrain
1849 * src/gdcmFile.cxx : bug fix concerning the close of file
1850 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1851 * Add the update of header entries using the shadow library
1853 2004-01-19 Benoit Regrain
1854 * removal of file gdcmHeader2.cxx
1855 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1856 inheriting from gdcmParser. This split is to prepare the integration
1857 of dicom dir parsing
1858 * bug fix under python
1860 2004-01-16 Jean-Pierre Roux
1861 * REM removal of class gdcmHeaderEntrySet
1862 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1863 * ADD add file gdcmHeader2.cxx
1864 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1866 2004-01-15 Benoit Regrain
1867 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1868 entries created while parsing the header. Thus, they will be destroyed
1869 when the gdcmDictSet will be destroyed
1870 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1873 2004-01-15 Benoit Regrain
1874 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1875 made a fatal error because of the memory release at the end of program.
1876 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1877 some memory and vtk seems to have some problems with that.
1878 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1880 2004-01-14 Benoit Regrain
1881 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1882 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1883 * src/*.[h|cxx] : make changes due to class name changes
1884 * gdcmPython/demo/*.py : bug fix due to method names
1886 2004-01-13 Benoit Regrain
1887 * src/*.[h|cxx] : coding style
1888 * vtk/*.[h|cxx] : coding style
1890 2004-01-13 Benoit Regrain
1891 * gdcmPython/testSuite.py : test the readable flag of file for tests
1892 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1893 It's lied to the stl compilation by MSVC (windows, always windows...)
1894 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1896 2004-01-12 Benoit Regrain
1897 * src/*.h : add comments
1898 * src/gdcmDictSet.h : set the method BuildDictPath in public
1899 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1900 directly setted in the source code
1901 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1904 2004-01-09 Benoit Regrain
1905 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1906 * setup.py : use a reference to gdcmVERSION
1908 2004-01-07 Benoit Regrain
1909 * Modification to compile with the distutils.
1912 2003-12-10 Benoit Regrain
1913 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1914 can use a gdcmHeaderHelper to load data
1915 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1916 made in the source code
1918 2003-12-10 Benoit Regrain
1919 * Update Windows projects and .cvsignore files
1921 2003-11-12 Jean-Pierre Roux
1922 * ENH gdcmHeader constructor has one more parameter (default value : false)
1923 that allows the user to 'go inside' the SeQuences only
1925 gdcmElValSet:Print takes it into account
1927 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * ENH: Update gdcmPython/CMakeLists
1929 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1930 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1932 2003-11-10 Jean-Pierre Roux
1933 * FIX : gdcmHeader::LoadElements is now based
1934 on the ListTag listElem member,
1935 not longer on the TagElValueHT tagHt member
1936 * ENH : PrintPubElVal shows (temporarily) both results,
1937 with the tagHt member and the listElem member.
1938 (it's easier to 'see' the problems when using Printheader)
1940 * FIX : old private member LgrElem is now splitted into
1941 ReadLength : Length actually found on disk (updated only
1942 if bug fixing is necessary), for internal
1944 UsableLength : Updated by FixFoundLength, to fix a bug
1945 or to allow Parser going on.
1946 Will allow to re-write a kosher header when a SeQuence
1947 with a length (not 0000) is found
1948 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1949 because gdcmElValSet::Add does not update ListElem
1952 2003-11-07 Jean-Pierre Roux
1953 * FIX misstyping in Transfert Syntax name table
1954 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1955 when they have an actual length (not 0000 nor FFFFF)
1956 (Nobody should care of it, but DICOMDIR explorers)
1958 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1959 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1961 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * ENH: vtkGdcmReader now supports LUT !
1963 (vtkgdcmViewer for now is not able to use them though)
1965 2003-11-05 Jean-Pierre Roux
1966 * in testSuite.py : new files names for checking the package
1967 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1968 that returns the pixel area size to the *aware* (vtk) user
1969 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1971 2003-11-05 Benoit Regrain
1972 * in testSuite.py : Modify the rules for checking the paths
1973 : Explicit error messages
1974 * in __init__.py : Related modif
1976 2003-11-03 Jean-Pierre Roux
1977 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1978 to be used by aware (vtk) users that want to manage
1979 LUT (and no to turn the PALETTE image into an RGB pixels one)
1980 * GetPixelType now returns 8U for 24 Bits images
1981 (vtkGdcmReader compliant)
1983 2003-10-31 Jean-Pierre Roux
1984 * Removal of *all* gdcmData images and add them again
1985 in order to loose the 'history' of un-anonymised images
1987 2003-10-31 Jean-Pierre Roux
1988 * RMV : removal of useless jBitsInJsample.h
1989 for both 8 and 12 Bits JPEG Lossy Libraries
1991 2003-10-31 Jean-Pierre Roux
1992 * ENH : Add the functions gdcmFile::GetImageDataRaw
1993 gdcmFile::GetImageDataIntoVectorRaw
1994 that act as GetImageData and GetImageDataIntoVector
1995 except the making of an RGB Plane from Gray Plane + LUT
1996 Intended to aware (vtk) users who know how to manage
1999 GetLUTRGBA return a R,G,B,A LUT if any
2000 lgrTotaleRaw gives the 'Raw' length
2001 GetImageDataRaw returns the gray Plane
2002 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2003 (They stay Grey, just like with other Dicom viewers :-(
2005 2003-10-30 Jean-Pierre Roux
2006 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2008 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2009 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2010 being coherents dicom files.
2012 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2015 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2016 * ENH: Two steps is necessary to please VC++ compiler...
2017 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2018 * ENH: Add include dir to medcon lib
2019 * FIX: only one function is being exported for now !
2020 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2022 2003-10-29 Jean-Pierre Roux
2023 * adding gdcmHeader::GetLUTRGBA
2024 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2025 --> Mathieu, the modif u're waiting for is not yet committed
2026 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2028 2003-10-27 Jean-Pierre Roux
2029 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2030 00191113.dcm DermaColorLossLess.dcm
2031 MxTwinLossLess.dcm RadBWLossLess.dcm
2032 * ENH: For version prior to vtkImageViewer2 -r 1.19
2033 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2035 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2036 * Removal of ido stuff in CMakeLists.txt
2038 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2040 * FIX: remove a call to ->Modified ... see comments
2041 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2043 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2044 * FIX: Problem with path for libvtkgdcmPython
2045 * ENH: Try adding a search script for python site-package
2046 * RMV: Remove some file from medcon lib that are not necessary
2047 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2048 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2049 * FIX: More pragma disable fro VC++,
2050 I don't think I break something as it is also disable in VTK/ITK.
2051 But it fasten debug compilation time.
2053 2003-10-23 Jean-Pierre Roux
2054 * gdcm now deals with 16 Bits Run Length Encoded images
2055 (they are compressed as 2 planes images,
2056 one for the high Bytes, the other for low Bytes)
2058 2003-10-22 Jean-Pierre Roux
2059 * Now CheckRead takes into account :
2060 - the bugged 'Leonardo' Siemens images
2061 - the XA images, sent thru the burning VPRO station
2062 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2065 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2066 * FIX: When copying a Makefile.am to CMakeLists.txt
2067 one should remove the '\'
2069 2003-10-22 Jean-Pierre Roux
2070 * in gdcmData adding a bugged 'Leonardo' Siemens image
2071 (wrong lengths in header)
2072 OK with gdcm, KO with the other viewers :-)
2073 * add a GE dlx XA image, thru the VEPRO burning station
2076 2003-10-21 Jean-Pierre Roux
2077 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2078 for a brutal checking of vtkgdcmViewer compliance
2080 2003-10-21 Jean-Pierre Roux
2081 * add the files for 'xmedcon' Jpeg Lossless library
2082 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2084 2003-10-21 Jean-Pierre Roux
2085 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2087 2003-10-21 Jean-Pierre Roux
2088 * garbage Siemens 'Leonardo' images dealt with
2089 (the patch is easy to remove)
2090 * cosmetic changes to avoid warnings
2092 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2094 no need to press 'r' now.
2096 2003-10-20 Jean-Pierre Roux
2097 * upgrade of checkRead.sh checkWrite.sh according
2098 to new Jpeg Lossless decompressor
2099 * add US.3405.1.dcm, a genuine RGB medical file ...
2100 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2101 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2103 2003-10-15 Jean-Pierre Roux
2104 * general anonymisation in gdcmData
2105 * adding the 'color files' from
2106 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2107 * adding some well knowed bugged-header images
2108 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2109 waiting for their inclusion in Python testsuite
2111 2003-10-15 Jean-Pierre Roux
2112 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2113 no longer seg faults when file is not found
2115 2003-10-14 Jean-Pierre Roux
2116 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2119 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2120 * TODO: *.in file to genereate a UseGDCM later
2122 2003-10-14 Jean-Pierre Roux
2123 * Some supposed-to-be Dicom Images have no preamble.
2124 OpenFile takes it into account
2125 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2126 * Missing elements added in dicomV3.dic
2127 (just to be affraid : have a look at
2128 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2129 and do it again next year ;->
2131 2003-10-13 Jean-Pierre Roux
2132 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2133 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2134 But there are NOT. It's fixed !
2136 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2137 * FIX: "jpeglib.h" was not found on VC++
2138 * FIX: vtkgdcm was not being installed
2140 2003-10-10 Jean-Pierre Roux
2141 * ENH : OpenFile closes the file if it *really* doesn't look like
2142 an ACR-NEMA / DICOM one.
2143 * FIX : testWrite no longer writes an empty file if the source file
2144 is not gdcm Readable
2145 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2148 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * FIX: CMake generate now documentation
2150 * ENH: out of source doc build !
2151 * ENH: Generate both user and dev documentation
2152 * ENH: Should work on windows too
2153 * ENH: Only one doxygen config.in file is needed
2154 * FIX: make install should be ok now on ùnix plateform
2155 * FIX: PATH to dictionary was wrong (missing /)
2156 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2158 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2159 * vtkGdcmReader is now able to read rgb dicom file.
2160 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2161 * added a gdcmViewer to vtk test, use mouse to control
2162 window level & window width
2164 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2165 * CMake-ification of gdcm, we have now two build system
2166 * FIX: on cygwin Wsock32 doesn't exist
2167 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2169 2003-10-06 Emanuel Ollart
2170 * FIX : compilation process wad broken.
2171 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2173 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2174 * change gdcmViewer -> vtkgdcmViewer
2175 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2177 2003-10-06 Jean-Pierre Roux
2178 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2179 ( e.g : well known GE images with a wrong elem length,
2180 : Philips MRI Images with a wrong Huffman table)
2181 * still to be done : allow the reading of bugged LEONARDO Siemens images
2183 2003-10-03 Jean-Pierre Roux
2184 * Odd length strings are padded with '\0' (not with spaces,
2185 to remain compliant with already defined strings,
2186 like Transfert Syntax UID and others)
2188 2003-10-03 Jean-Pierre Roux
2189 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2190 to allow displaying RGB images (not only by affim ;-)
2192 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * vtkGdcmReader is now able to read rgb dicom file.
2194 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2196 2003-10-03 Jean-Pierre Roux
2197 * A few nasty patches to allow the reading of a lot of nasty images
2198 ( e.g : well known GE images with a wrong elem length,
2199 : Philips MRI Images with a wrong Huffman table)
2200 * still to be done : allow the reading of bugged LEONARDO Siemens images
2202 2003-10-03 Jean-Pierre Roux
2203 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2205 2003-10-03 Jean-Pierre Roux
2206 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2207 to allow displaying RGB images (not only by affim ;-)
2209 2003-10-03 Jean-Pierre Roux
2210 * gdcmFile::GetImageDataIntoVector now
2211 - deals with MultiFrames MultiFragments Run Length Encoded files
2212 - deals with YcBcR (YBR_FULL) files
2213 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2214 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2216 (no sample found :-(
2218 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2220 Two reasons: - clear things
2221 - third parties acces gdcm through header files, so won't
2222 suffer anymore VC++ complains
2224 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2225 * add argv[1] in testvtkGdcmReader.cxx
2228 2003-09-24 Jean-Pierre Roux
2229 * The lines are now eigthy characters long.for
2230 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2232 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2233 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2234 char* to std::string. Thus, the use of strdup becomes useless. (see
2235 previous commis of Malaterre)
2236 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2237 before the last Malaterre's commit.
2239 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * This commit should fix the Debug building under VC++, the problem
2241 was mainly a mixture of debug and release lib being loaded at startup.
2242 * I also remove a depency to a specific C function: strdup. Because I had
2243 to force the link to msvcrtd (whereas strdup is in libc).
2245 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2246 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2247 located in the gdcmCommon.h file. All use of reference of tha has been
2248 changed to now use the variable GDCM_UNFOUND.
2250 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2252 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2253 Dicom dictionary. The test suite can now be run again. Note:
2254 I'm note very happy with the " (RET)" changes. I believe this
2255 RETAINED comment should be dropped when parsing the dictionary.
2256 - PACKAGER corrected
2258 - AUTHORS updated and now in alphabetical order
2259 * Makefile.am now exports gdcm.dsw for Windoze users.
2261 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2262 * cygwin complains about missing std:: in subdir Test/
2264 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * remove some methods that are now in gdcmHeaderHelper
2267 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * vtkGdcmReader set spacing and origin correctly
2270 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2271 * Fix a few delete/delete[] mismatch
2273 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2275 interpretation to data given by gdcmHeader. For instance there are
2276 heuristics to get informations (look at different places).
2277 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2278 sorting DICOM images based on different strategies.
2279 * modified Makefiles accordingly.
2281 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2282 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2283 when building in debug mode
2284 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2285 src/win32/gdcmdll.dsp
2286 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2288 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2289 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2292 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2293 * src/win32/libgdcmjpeg12.dsp was not dos format
2294 * src/win32/libgdcmjpeg12.dsp :
2295 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2296 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2298 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2299 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2301 * src/gdcmFile.cxx : bug fix in affectation type
2302 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2303 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2304 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2305 symbols... future problem ?
2307 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * src/win32/libgdcmijpeg12.dsp was missing
2309 * modified gdcm.dsw accordingly
2311 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2312 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2314 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2315 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2316 commit of JPR (before his hollidays to facilitate our work).
2317 * setup.py : bug fix in code. Modifications made while the last commit
2318 of JPR. The code hasn't been tested before the commit... it's so
2319 useless to make that (for best programmer that is JPR) !!!
2321 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * tagged the current version as Version0_3 (i.e. version 0.3)
2324 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2325 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2326 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2327 * *.dsp : modifications to use new libgdcmijpeg8 library
2328 * setup.py : bug fix on VTKPATH variable
2329 * PACKAGER : adding all concerning windows
2331 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2334 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2335 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2336 test suite reported error.
2337 * PACKAGER file added (describes what a packager must do when
2338 packaging a new release).
2339 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2340 * configure.in: upgraded version number to 0.3.0
2341 * fixing build of rpm (through rpm -ta):
2342 - Doc/Makefile.am exports proper doxygen files
2343 - src/jpeg/libijg8/Makefile.am exports the include files.
2345 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2346 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2347 * src/gdcmHeader.h : formatting code
2349 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2350 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2351 We were obtaining error message from vtk. Now, creation of file list
2352 is made in an internal list to prevent this problem.
2353 Bug fix when output is empty.
2354 Bug fix in update of progress value. Previous commit for this was a bad
2356 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2358 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2359 * src/gdcmHeader.h : added method to get the file name
2360 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2361 files. Added method to remove all files on the input
2362 Added FIXME comment concerning the bad parsing of header made by
2363 ExecuteInformation method (in ExecuteData method)
2365 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2366 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2367 when using make instal.
2368 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2369 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2371 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * setup.py : adding include dir of jpeg lib to compile all sources
2373 * */Win32/*.dsp : JPR fix for windows compilation
2375 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2376 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2378 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2379 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2381 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * setup.py is again effective on un*x (takes into account the
2383 addon of the jpeg library)
2384 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2385 * Doc/Doxy* updated (includes above enhancements)
2386 * INSTALL now points to web documentation
2388 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * src/gdcmHeader.h doesn't make unnecessary reference to
2391 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2393 * src/gdcm*.[cxx|h] :
2394 - to allow compilation with gcc 3.x
2395 -- clean up of STL usage (added explicit usage of std::)
2396 -- small fixes on exceptions.
2397 Note: linking not tested !
2398 - clean of doxygen comments to avoid warnings at documentation
2400 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2401 dependent convertion).
2403 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * Clean up of previous JPR garbage commit (not even commented in the
2406 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2407 - moved all jpeg related files from src to src/jpeg/libijg8, with
2408 addition/modification of Makefile.am and configure.in.
2409 - the testSuite is still brain damage (not guilty).
2411 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2412 * WrapVTK.py : modifications to get correctly vtk source files to
2414 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2415 (FileName -> Filename)
2417 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * vtk/vtkGdcmReader.[cxx/h]:
2419 - UpdateProgress method should now be effective
2420 - removed the limitation on having only images loaded (as opposed
2422 - when building a stack of images/volume, a lesser number of
2423 gdcmHeader and gdcmFile instances should be used (hopefully
2424 accelerating things).
2425 - when building a stack of images/volumes, files which are not
2426 loadable (wrong path-filename, wrong permissions on existing file,
2427 or file not parsable by gdcm) are replaced with a black image
2428 in the stack (for the caller to notice the problem).
2430 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2433 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2434 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2435 between standard library (std) and vtk library (problems are found
2436 under Windows... thanks Windows !)
2438 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2441 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2443 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2446 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * When compiling with distutils (see setup.py) the C++ compiler is
2448 called with different flags than the default ones (with automake).
2449 In order to fix all those warning, I compiled gdcm with the command
2450 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2451 and went for warning fixes:
2452 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2453 up from unused variables.
2454 - vtk/vtkGdcmReader.cxx: potential bug fix.
2455 * src/gdcmHeader.h: Doxygen warning cleanup
2457 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * gdcmPython/gdcm.i:
2459 - typemaps correction to take into account the systematic replacement
2460 of "using namespace std" with std:: prefix e.g. std::list,
2461 std::string... (cf changes of 2003-05-21).
2462 - gdcmGlob global variable of type gdcmGlobal (defined in
2463 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2464 exported to Python a as cvar.
2465 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2466 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2467 gdcmDictSet.GetPubDictTagNames() and
2468 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2469 C++ static methods).
2470 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2471 with the above changes.
2473 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2474 * setup.py, manifest.in : bug fix under linux
2476 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2477 * Modification of setup.py to compile vtk part too. Then, we have 2
2478 wrappers which must work with same distutils. For that, we have a
2479 generic distutils in distusiltsWrapping.py ; with :
2480 - build_extWrap class to wrap generically all extensions,
2481 - ExtensionWrap base class for all wrapping extension that contains
2483 - Wrapper interface which wrap sources
2484 + In WrapSwig.py we have extension and wrapper for Swig
2485 + In WrapVTK.py we have extension and wrapper for VTK
2486 * MANIFEST.in : modifications to consider vtk directory and new python
2487 files for compilation
2489 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2490 * Added python wrappers of vtkGdcmReader vtk class (see the
2491 source in vtk/vtkGdcmReader.cxx) :
2492 - vtk/Makefile.am now builds a library
2493 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2494 python library (as opposed to _gdcm.so wich are the python
2495 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2496 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2498 - configure.in has an additional flag --enable-vtk that needs
2499 to be set to enable compilation of vtk related code, that is:
2500 + vtk/vtkGdcmReader.so and
2501 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2502 + gdcmPython/vtkgdcmPython.so (see above)
2503 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2504 be read when compressed or when HighBit + 1 != BitsStored),
2505 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2506 the usage of the python wrapper of vtkGdcmReader vtk class.
2507 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2508 * src/*.[h] all occurences of stl classes are now prefixed with
2509 std::, and all occurences of "using namespace std;" where removed.
2510 This is to avoid pollution of global namespace in included files.
2511 Apparently vtk does not avoid this pitfall: when using both
2512 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2513 collision of various stl members (principally cout...).
2514 * gdcmPython/testSuite.py now cleanly removes temprory generated
2516 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2517 comply with above changes)
2519 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2520 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2521 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2522 vtk data structure (an image Flip was required).
2523 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2524 * cosmetic changes in documentation.
2526 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2527 * src/gdcmHeader.cxx: the constructor no longer exits when an
2528 unexisting file is given as argument.
2529 * The subdirectory Data (containing all the images used for the
2530 test suite) is not part of this repository anymore. A new module
2531 containing those images is now available at
2532 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2533 with the name gdcmData.
2534 All the python scripts (including the package initialisation file
2535 gdcmPython/__init__.py) were adapated to take this change into
2536 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2538 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2539 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2540 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2541 demo of the usage of this class.
2542 Compilation of this vtk part is only done when using the --enable-vtk
2543 at configure (or autogen.sh) stage.
2545 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2546 * More memory link related corrections and documentation fixes.
2548 - maximum info is obtained with a command of the form:
2549 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2550 --show-reachable=yes PrintHeader
2551 - the remaining reachable blocks seem to come from the STL
2552 allocation scheme through the usage of map and list. It looks
2553 like this memory cannot be freed but it is not a memory leak
2554 (in fact further invocation to the STL would recollect the
2555 unused memory allthough it cannot explicitely be freed).
2556 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2557 of displaying an image parsed with gdcm and displayed with VTK.
2558 Note: some images don't seem to work e.g.
2559 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2560 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2561 Allthough this weakens the semantics, it is a ditch attempt to
2562 make gdcm more thread friendly.
2564 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2565 * Memory link hunt (by using valgrind through the command
2566 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2567 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2568 gdcmHeader::_dicom_vr.
2569 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2570 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2572 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2574 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2575 * src/Makefile.am now exports all the necessary include files at
2579 * UpdateGroupLength replaced by new one
2582 * UpdateGroupLength re-written using H-Table
2583 (named UpdateGroupLengthNew untill checks are over)
2585 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2586 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2587 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2589 - gdcmHeader::GetPubElValSet removed.
2590 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2591 UpdateGroupLength, WriteElements, Write.
2592 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2593 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2594 carried the same semantics.
2595 - src/gdcmHeaderIdo.cxx changed accordingly.
2596 - gdcmFile::WriteBase now regroups all the codes from previous
2597 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2598 - enum FileType moved to gdcmCommon.h
2599 * src/gdcmHeader.cxx AddDefault trashed
2600 * gdcmGetXSize added
2601 * getimageDataSize now calls gdcmGetXSize
2602 * Test/*.cxx changed to agree with above changes
2604 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2606 (to avoid double call by end user).
2607 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2608 by end user, since gdcmHeader::gdcmHeader now handles it.
2610 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * gdcm/Doc many doxygen changes:
2612 - Doxyfile now has two different versions, DoxyfileUsers that generates
2613 the html.users end users oriented documentation and
2614 DoxyfileDeveloppers that generates the html.developper developper
2615 oriented documentation.
2616 - README changed accordingly
2617 - requirement.txt removed (old design info moved to TODO).
2618 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2619 DoxyMainPage.txt, DoxyPython.txt provide more information.
2620 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2621 be updated by simply regenerating the docs with doxygen and copying
2622 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2623 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2624 all the tests in the form "if (<map>.count() >1)" were removed.
2625 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2626 ill-formed documentation sections.
2627 * src/gdcmHeader.cxx: ditto
2629 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * setup.py fixed for un*x (needed macro for stdint.h)
2631 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2632 un*ces with sh-utils test utility.
2633 * gdcmPython/demo/test.py renamed to PrintHeader.py
2634 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2635 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2636 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2637 * src/gdcm*.cxx JPR's bad inclusion fixed.
2639 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2641 * gdcmPython/demo/test.py changed accordingly.
2643 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2644 * gdcmPython/Makefile.am fixed linking against libstdc++
2645 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2646 * Swig subdir (historical tests of swig version 1.3.17++) removed
2647 * Test/testChangeEntete.cxx some lines commented out in order to make
2649 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2650 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2652 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2654 hence the user doesn't need this explicit call.
2655 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2656 i.e. LoadElements() call removed.
2657 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2658 - src/Makefile.am declares the proper flag for g++.
2659 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2660 for adding user defined new tags.
2661 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2662 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2663 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2665 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2666 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2667 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2668 src/Makefile.am : the project should properly compile and install
2669 with the autotools, included the python wrappers part.
2670 * gdcm.spec.in : added a spec file for RPM packaging.
2672 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2673 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2675 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2677 to exported to the environement (see gdcmPython/testSuite.py
2679 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2680 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2681 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2682 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2683 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2685 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * gdcmPython/__init__.py doesn't crash anymore when running in
2687 in InstallMode or PreInstallMode but with an environement given
2688 value of GDCM_DICT_PATH.
2689 * src/gdcmDictSet.[cxx/h] coding style.
2691 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2693 * src/gdcm.h general comments moved to TODO, and README
2694 * src/gdcm.h should now be seen as a user commodity (including it
2695 should suffice to fully use gdcm). It is nowhere including within
2696 any of the kernel files src/*.cxx and src/*.h.
2698 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2699 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2700 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2702 * src/gdcm*.cxx only include their corresponding include file
2703 (as opposed to gdcm.h)
2704 * gdcmPython/gdcm.i changed accordingly
2705 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2706 the autogen.sh generated "make snapshot" command to work.
2707 * autogen.sh removed history related references to crea package.
2709 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2710 * distutilsSwigCPlusPlus.py work around some swig portability
2713 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2715 was done in a last ditch attempt to get setup.py _really_
2716 operationnal. The python/gdcmPython layaout add the advantage
2717 of hidding away the python related distutils specific files
2718 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2719 Alas, the src directory was out of scope (i.e. it's relative
2720 position to setup.py was ../src) which made things impossible to
2721 handle (see previous version of python/setup.py). Crossing fingers...
2723 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * python/setup.py now works on Un*x. (harder than I thougth)
2725 * python/distutilsSwigCPlusPlus.py can now have include files
2726 among the list of sources.
2728 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2730 * modifications in MSVC projects
2732 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * As stated by the first lines of Test/ExceptionAndPython/README, it
2734 looks like we can move back to original usage of exception within
2735 src/gdcm* and hence remove the errno stuff that was introduced
2736 as a quick and dirty fixture of this problem (added to the TODO).
2737 * Doc/Doxyfile configuration file for Doxygen and corresponding
2738 README file for usage added.
2739 * Test/testWrite.cxx added. This new test comes from a split of
2740 test.cxx that is now reverted to its original purpous i.e.
2741 testing the proper parsing of a Dicom related file.
2742 testWrite.cxx concentrates on testing the IO part of gdcm.
2743 * Test/bug1.cxx (containing a bug on WIn32) added.
2744 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2745 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2746 whose purpose is to publish the content of the TagNames of the
2747 Dicom public dictionnary were not accessible without an
2748 instance of class gdcmHeader.
2749 - those methods are now static methods of gdcmDictSet and hence
2750 require no instances at all to be invocated.
2751 - within gdcmDictSet this change required to change some method
2752 to class methods (i.e. are now static) among which SetDictPath
2753 (renamed to BuildDictPath) and LoadDefaultPubDict.
2754 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2755 the above changes by calling the new method classes of gdcmDictSet.
2756 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2757 the above to be effective.
2758 * python/gdcmPython: in order to wrap properly the above changes
2759 for Python, swig version now needs to be > 1.3.17.
2760 * python/gdcmPython/Makefile fixed to adapt itself to new
2761 configure/make shema introduced by Johan Montagnat (thanks for the
2762 contribution). Alas this Makefile cannot be turned into a proper
2763 Makefile.am without some heavy changes in the configure.in
2764 (for python dectection).
2765 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2766 now avoids publishing the empty entries.
2768 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2769 * python/setup.py : bug fix concerning install under windows
2770 ExtraPath reused :-P
2771 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2773 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2774 * Dicts/dicomV3.dic : remove double spaces !!!
2775 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2776 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2779 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2781 method. Doxygenation.
2782 * src/gdcm.h clean up of JPR spurious comments.
2784 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * python/distutilsSwigCPlusPlus.py now properly collects the
2786 shadow classes generated by "swig -c++" (gdcm.py in our case)
2787 when using "python setup.py install".
2788 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2789 reexports the working classes.
2790 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2791 by the classical C errno scheme. This is to prevent an obscure
2792 behavior of the python wrappers when importing wxPython.wx prior
2793 to gdcmPython (which ended up in an abort call). An illustration
2794 of this oddity can be found in the Test/ExceptionAndPython
2795 subdir (see the README file). This problem probably due to
2796 an combination of g++ and dynamic loading.
2797 * added Test/ExceptionAndPython (see above)
2799 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * Changed the layout of the python part to avoid bloating main
2801 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2802 i.e. the distutils arsenal. All the python related stuff is
2803 again in a python subdir, but the package itself is now in
2805 * setup.py was cleaned up:
2806 - pythonIncludePath removed
2807 - python setup.py bdist target is now functional.
2808 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2809 collision with other packages). gdcmPython/demo/*.py changed
2812 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * python subdir moved to gdcmPython (preparation of distutils packaging).
2814 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2815 distutils installer is operational.
2816 * - gdcmPython/__init__.py now properly loads the swig generated
2817 shadow classes (from gdcm.py).
2818 - gdcmPython/demo/*.py changed to import the package gdcmPython
2819 instead of gdcmPython/demo/load.py.
2820 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2822 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2824 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2825 entries within the associated public Dicom dictionary resp. the same
2826 information but sorted by the fourth field (PAT, IMG, DIR) of the
2828 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2829 are now in the "???" group.
2830 - python/gdcm.i changed accordingly,
2831 - python/demo/printGroupedPublicDict.py added, that gives an example
2832 of the above new functionalities in Python.
2834 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * src/gdcm.h, gdcmHeader.cxx:
2836 - historic references to glib's g_malloc and g_free (#defined)
2837 were definitively removed.
2838 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2839 * src/gdcmElValSet.cxx:
2840 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2841 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2842 - GetElValue(string) renamed to GetElValueByName.
2843 - Added GetElementByName(string).
2844 * src/gdcmHeader.cxx: added
2845 - GetPubElValRepByNumber(guint16, guint16)
2846 - GetPubElValRepByName(string)
2847 - GetShaElValRepByNumber(guint16, guint16)
2848 - GetShaElValRepByName(string)
2849 - GetShaElValByNumber(guint16, guint16)
2850 - GetShaElValRepByName(string)
2851 - GetElValRepByNumber(guint16, guint16)
2852 - GetElValRepByName(string)
2853 - GetElValByNumber(guint16, guint16)
2854 - GetElValRepByName(string)
2855 * Doc/requirements.txt added.
2857 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * Test/Makefile building now depends on the one of libgdcm.so
2859 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2860 pixel data) aware which enables finding the address (offset) of
2861 the pixel data of JPEG encoded DICOM files. This leaves only a single
2862 file in the testSuite whose pixel data address (offset) is unknown.
2863 * python/testSuite.py changed accordingly.
2865 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2866 * VC++ has some strong limitations when working with the STL, as stated
2867 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2868 "Also note that some STL containers (map, set, queue, list, deque)
2869 cannot be exported. [...]
2870 Some STL classes contain nested classes. These classes can not
2872 This is caused by a designed limitation that once a template
2873 class is instantiated, it can not be re-instantiated and
2875 Since our usage of map<> is ubiquitous in gdcm, this "designed
2876 limitation" of VC++ is a pitfall.
2877 Hence the Python wrappers of gdcm cannot be incrementally linked
2878 against the c++ dynamic library. The dirty but only workaround is
2879 to forget about incremental link of dynamic libraries and to generate
2880 the Python wrappers library with the inclusions of the underlying C++
2882 The following modifications concern this matter on Win32/VC++:
2883 - wrapping python correct with standalone wrapped dll (don't use separate
2884 dll under windows !!!!)
2885 - python21_d debug mode enabled (ask Frog how to use it :-)
2886 - NO problem with having an STL member of class for example string in C++
2887 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2888 - Python test of dcmlib in Python is ok under windows on a large set
2890 * removed glib references
2891 * typedef's inserted in gdcm.i for correct swig type management
2893 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2894 * python/demo/*.py load.py extracted from test.py. Added explore.py
2895 that only displays required tags and testAll.py that parses all
2896 the files of the testsuite without using unittest.
2897 * python/testSuite.py other additional test on new files added.
2898 * Data/* new test files added accordingly to the testSuite.
2899 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2900 the vr in the file differs from the one of the dictionary.
2902 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2903 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2904 values, but limits itself to values which are below a user specified
2905 size (by default 1024 bytes).
2906 * python/gdcm.i : elements not loaded (because their size is above the
2907 user specified treshold) are exported with their TagKey as key of the
2908 python dictionary. This enables the testsuite to make some checks
2909 on the unloaded elements (since we have their offset and size).
2910 * python/testSuite.py
2911 - now tests for the existence and proper value of the pixel data
2912 - two new examples added.
2913 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2915 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2917 aware. See the strategy comments in gdcmHeader::FindeLength().
2918 * Test/test.cxx now accepts a filename as first argument.
2919 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2920 * python/testSuite.py changed to integrate test on above files.
2922 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2924 the vr was also RET.
2925 * python/testSuite.py more tests added.
2927 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * python/testSuite.py unittest test suite added (uses Data)
2929 * Data/* dcm and acr files for the test suite.
2930 * glib dependance removed from un*x version. We now use ISO C99
2931 7.18 Integer types (see stdint.h)
2932 - python/Makefile, src/Makefile src/gdcm.h
2933 * src/ when an explicit vr (like dicom files) suddenly poped an
2934 implicit element we use to mark the underlying DictEntry of the
2935 concerned ElValue with "Implicit". This strategy was damageable
2936 too the public or provite dictionaries, since some of their vr
2937 would be changed. Since Header::FindLength heavily relies on the
2938 detection by Header::FindVR of falsely explicit elements, I
2939 added an extra ImplicitVr member to ElValue (boolean).
2940 The rest of the changes we the necessary adaptations.
2942 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2943 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2945 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2947 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * Adaptation for porting to VC++:
2950 o forced to use std namespace (for string to be known)
2951 o all class use __declspec export style on WIN32
2952 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2953 (in stdlib.h on Win32 but in std:: for gcc)
2954 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2955 variable GDCM_DICT_PATH.
2956 * src/gdcmHeader.cxx verbose comments made discrete.
2958 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * python/gdcm.i: added a typemap that converts a C++ hashing table
2960 to native Python dictionary.
2961 * python/demo/test.py:
2962 - now uses the native dictionary for exploration of gdcmHeader.
2963 - takes an optional filename argument (the file to parse).
2964 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2965 PubElVals hashing table.
2966 * Dicts/dicomV3.dic removed error prone trailing spaces.
2968 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * Python wrapping process moved away from src/Makefile to
2970 newly created python/Makefile (as well as gdcm.i)
2971 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2972 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2973 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2974 from the environement variable GDCM_DICT_PATH (when existing).
2975 * src/gdcmDict::GetTag bug fix.
2977 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * Straightforward temporary fixes for swig to build the python wrappers.
2979 src/Makefile now has a python working entry [by working we mean
2980 that we can import de shadow classes without errors].
2982 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2983 * hashtest.cxx removed (since already in Test)
2984 * src/gdcmlib.h renamed to src/gdcm.h
2985 * src/dcm.i renamed to src/gdcm.i
2986 * src/Makefile prepared for python wrapping
2988 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcmHeader.cxx :
2990 - Parsing of header is now separated from loading of element values
2991 (see gdcmHeader::LoadElements).
2992 - general clean up of hopefully all file access (creation of
2993 ReadInt16 and ReadInt32)
2995 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2996 * src/gdcmHeader.cxx :
2997 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2999 - SetLgrElem renamed to SetLength
3000 - GetLgrElem renamed to GetLength
3001 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3002 * src/gdcmElValSet.cxx fixed both GetElValue methods
3003 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3004 due to IdoDude was cleaned out.
3006 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3008 concentrates on finding the value representation (when it exists).
3009 RecupLgr now only finds the element value length, and it avoids
3010 returning the unecessary skL (skipped length).
3011 Also, offsetCourant was simply removed (with taille_fich) since
3012 it was redundant with the File position internals (by using
3013 ftell and fseek). This also made skL (see above in RecupLgr) usage
3015 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3016 on the libido specificities which are handled through class
3018 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3021 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * Truckload of changes. Parsing of header is barely functional
3023 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3025 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3026 * src/gdcmHeader.cxx many addons of low level methods
3028 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3030 and _IdDcmSWAP_LONG.
3032 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * This corresponds to all the changes decided at the meeting of
3034 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob