1 2005-01-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Bug fix for the python part use
3 * Now, PrintHeader.py pass... but outside the ctest use. shit !
5 2005-01-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
8 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
10 a string and should ask the global TS dict what are the propreties of
13 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
14 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
15 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
16 to swap the Swap Code, at parsing time, when we come out of group 0002
17 and Transfer Syntax is Big Endian
18 We should be able to read now 'true DICOM" Big Endian coded images
19 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
20 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
22 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Hopefully fix the bug on MacOSX and static global initialization.
24 This is the only -minor- patch I found that both please MacOSX and VS6.
25 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
26 but this would require a lot of change. Another approach would be that Global
27 create those string and GDCM_UNFOUND becomes a pointer to a string (which
28 gdcm::Global would destroy at exit).
30 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
31 * Fix bug on MacOSX with static initialization in a multy threaded
32 environment. static const string in a header file used to be ill
33 initialized provoquing the freeze of any tests. patch should solve this
36 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 * According to Benoit's suggestion, and without any objection from anybody
38 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
39 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
40 - method gdcmDicomDirObject::GetEntry() renamed as
41 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
43 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
45 you debug/warning message just as c++ streams which make them very convinient
46 to use. Once this is stabilize I will change the ostringstrem to be
47 redirected to a file (ofstream).
48 * Properly support C99 extension: __FUNCTION__ which allow us to display
49 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
51 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
52 * Removal of useless and dangerous methods :
53 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
54 GetDocEntryByName, GetEntryByName, GetDictEntryByName
55 * Removal of usless methods :
56 Dict::PrintByName, Dict::GetDictEntryByName
57 * Commenting out of probabely useless methods :
58 Dict::GetDictEntryNames()
59 Dict::GetDictEntryNamesByCategory()
60 DictSet::GetPubDictEntryNames()
61 DictSet::GetPubDictEntryNamesByCategory()
62 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
63 * ENH : Use dicomTS.dic as described in 2004 version
64 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
65 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
66 Add Accessors on VM (Value Multiplicity), and VM related methods
67 * ADD : Add a list of 'Dicom Attribute types', as found in
68 http://medical.nema.org/dicom/2004/04_15PU.PDF
70 * ADD : Add dicomGroupNameAbbreviations.dic
71 should be used to write a method to replace the former
72 Dict::GetDictEntryNamesByCategory()
74 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
76 to read in the file... and only it ! Length is the efective length of the
77 data in the DocEntry structure
79 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
81 And now use a static function call instead, with a global variable. i
82 This is much closer to the VTK approach. Hopefully should be bulletproof
83 and easier to use...hopefully
85 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
88 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
91 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
93 ValEntry, BinEntry, SeqEntry creation or replace
95 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
97 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
99 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
100 when specifying the VR
101 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
102 * src/gdcmDocEntry.cxx : amelioration of print
104 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
105 * ADD : Add the method Util::IsCurrentProcessorBigEndian
106 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
107 * ADD Method Document::ComputeGroupLength
108 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
109 in order to allow further VR modification by user
110 * REM : removal of once-called method File::WriteBase
111 integration of its code in formerly one-line method File::Write
113 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
115 replace the different values "??", "Unkn", "Unknown".
116 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
117 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
118 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
119 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
121 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
124 * Set the gdcm::Base class to some Printable classes
126 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmFile.[h|cxx] : add the Print method
128 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
129 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
130 * src/gdcmDocument.h : remove the PrintLevel informations
131 * Example/PrintFile.cxx : use the new gdcm::File::Print
133 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
135 problems when compiling with the python wrapping
137 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
139 writting in ImplicitVR
141 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
142 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
143 JPEG decompression, especially when dicom frames are split into several
144 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
145 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
147 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmHeader.cxx : change the initialisation of default header.
149 Now, this header is readable by gdm, e-film, DicomWorks
151 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
153 Rename Decompressed to Raw
154 * Use the API changes in gdcm::File.
155 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
158 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
160 each added entry in the header. Replace the 'Planes' field by the 'Number
163 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
165 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
167 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
169 At this time, this image isn't readable by e-film... waiting JPR help to
172 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
174 DocEntry. Now use methods of the Document !
176 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * Test/ShowDicomSeq.cxx : bug fix
179 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
181 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
182 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
183 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
185 * Test/TestCopyRescaleDicom.cxx : remove unused variable
186 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
187 containing found sequences
189 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
192 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
193 Some fields in BinEntry must be copied to not seg fault when making the :
194 gdcm::File *copy = new gdcm::File( copyH );
195 and tests are now made on good variables
197 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
199 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
201 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
202 * Add vtkGdcmWriter example and test
204 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * Test/TestUtil.cxx : reformat the source code
206 * vtk/vtkGdcmReader.cxx : remove and change prints
207 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
209 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
210 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
212 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
214 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
216 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
218 by an eof to prevent all bad read of the file... and in this case, the
221 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Example/Volume2Dicom.cxx : comment unused variables
223 * Test/PrintDicomDir.cxx : comment unused variables
224 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
225 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
226 method that is redondant with AddEntry.
227 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
230 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * Bug fix due my last commit (compilation under Windows).
232 * Example/Volume2Dicom : bug fix in the file and reformatting source code
233 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
235 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
237 - Remove printf / sprintf
238 - include iostream AFTER gdcm so we don't get warnings
239 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
241 - Also remove tons of include from header files, hopefully this should
242 speeup the compilation time, since it was becoming a dog slow.
243 - Remove gdcm.h as it include way too many files and slow down compilation
244 (plus it is not up to date)
245 - remove 'using namespace std' this is BAD !
247 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * Remove memory leaks on the DicomDir
249 * Remove some useless data in DicomDirObject
250 * Add usefull methods in SQItem, to be complient withe the ElementSet
252 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
255 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
257 future, with convertion)
258 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
259 and ImageDataSize values. Remove the method to get the PixelReadConverter
260 from the output of the class
262 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
265 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
267 and vtkErrorMacro use.
268 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
270 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
273 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
274 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
275 The string leaves only in the fonction. So when we make a .c_str(), we
276 get the pointeur on the first element, element that will be destroyed
277 immediately after thee instruction.
278 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
279 file has been opened : the test must be made on the content of the
280 pointer and not directly on the pointer !
283 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
285 the python part recompiles
287 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
289 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
290 X session is killed (for my computer... it seems to not be identic on
293 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
295 avoid problems (otherwise, the difference test between the visible image
296 and the reference is incorrect. If the reference is greater than the
297 screen resolution, it's produce errors).
298 Can be used for only one image. Can be used with a visible flag.
299 * vtk/vtkGdcmReader.cxx : remove commented codes.
300 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
301 under windows at compilation
302 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
304 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
306 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
308 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
309 tests on the image size X, Y, Z
311 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
313 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
314 between the class name and the file name
316 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/ : fix compilation warnings for the Write method (2 different
318 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
319 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
320 variable... create a static method in gdcm::Document to access to
321 this variable content.
323 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
325 file, to be accessed by other files (like gdcmFile). Remove commented
326 code. Move the change of the header to the gdcmFile, using the
328 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
329 To be sure of that (and simplify calls), the Write of the header now
330 gets a file name and not a file pointer (std::ifstream).
331 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
332 DocEntryArchive. Remove all open of the written file
334 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
337 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
339 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
341 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
342 some corresponding methods. Write correctly the file and check before
344 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
345 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
346 is now on RGB data (as before my last commit
347 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
349 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
351 Add a print information of the type of the entry
352 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
353 It was in the gdcmFile, and all write have been regrouped
354 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
355 Write correctly all dicom files (in decompressed mode only at this time)
356 * Test/ : test on files are now made using Raw data and not color data if
358 * Example/PrintFile.cxx : add more printings
360 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * Amelioration of code, remove some code copy. For the loading of
362 BinEntry (in gdcmDocument), add the test to verify if the file is already
365 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
367 remove a DocEntry in the header (push an empty DocEntry)
368 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
369 lines. Bug fix in the initialization of the PixelConvert and the
371 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
372 use in TestCopyDicom (now this test can run under windows... but fails)
373 * Test/TestCopyDicom.cxx : amelioration of the test :
374 - test the pixels written
375 - add test points to quickly find where is the error
376 - can set a file name input and output in arguments
377 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
378 amelioration of the test output
380 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
382 all replaced DocEntry's
383 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
384 Now, each needed DocEntry to modify is duplicated, modified and inserted
385 to the header using DocEntryArchive. Thus, after save, we can restore the
386 header initial state.
388 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
391 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
393 correct to copy it. The DictEntry is specified at the DocEntry creation,
394 then, it musn't change in the time.
395 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
396 header correctly. At this time, the change is only made for the first
397 level of the Document. In the future, it might consider sequences.
398 The change is made by replacing a DocEntry by an other that is created
399 outside the class. The old value is kept. When we restore the header
400 status, the added DocEntry is deleted and replaced by the old value.
401 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
402 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
403 set the write type to explicit VR, implicit VR or ACR. Add methods to set
404 the write mode to native, decompressed or RGB (but not used at this time)
406 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
407 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
408 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
410 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
411 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
412 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
414 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
415 set because already copied when copying the BinEntry's of the header
416 * Test/TestAllReadCompareDicom.cxx : remove warnings
418 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
420 Two problems appear when doing it :
421 - with the gdcmFile : when the GetImageData method is called, the pixels
422 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
423 data (pixels). And each structure destruct the data when it's
424 destructed. So we have two destructions for the same data. To solve it,
425 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
426 data or not. If it doesn't own data, then they will not destroyed by
428 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
429 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
430 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
431 create a double destruction of the same DocEntry's. So, to solve it,
432 the TagHT is simply cleared and the DicomDir* elements are destroyed.
433 * TODO : add an entry concerning memory leaks in the DicomDir
435 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
437 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
440 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
442 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
443 after it have been deleted
445 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
446 * FIX: src/* fix the doxygen warnings.
447 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
448 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
449 was erroneously defined with a size of 15 instead of 16. [many thanks
450 to Jean Michel Rouet for pointing out this bug].
452 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
453 1. Finish merging JMR patch for writting DICOM from scratch
454 2. Fix -hopefully- bug with MONOCHROME and space vs null character
455 3. Use const ref when possible
456 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
457 5. A few more comments
458 6. CreateUniqueUID can now be called without parameter"
460 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
461 * ENH: Slightly bigger patch:
462 1. Getting toward full integration of JMR patch for writting dicom from scratch
463 2. Update Test to test part of this patch: CreateUniqueUID
464 3. File was not close properly in gdcmDict
465 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
466 5. Use of const ref instead of copy (speed issue)
467 6. Remove temporary (duplicate) string in TranslateToKey
468 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
469 8. Do not repeat virtual in subclasses
470 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
472 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * Apply first patch toward better string comparison when dealing with broken
474 DICOM files. Essentially the string could be padded with a space instead
475 of a null character as defined by standard
477 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
479 because never used... and in the same time, that's remove some memory leaks
481 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmFile.cxx : now delete the PixelConvert instance.
483 * In examples and tests : change the type of image data variables from void*
484 to uint8_t*. Remmove all delete on image data variables
486 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
488 Verify the file pointer value before open the file, and if it's not null,
489 a verbose message is generated.
490 Close correctly the file when the file isn't considered dicom-like. The
491 correctly close is a call to CloseFile.
492 When closing the file pointer, test if its not null to close the file.
493 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
494 file. For an uncompressed image, the copied data correspond in the least
495 case to the image size (calculated) or the image size specified in the
496 header. A verbose is generated if these two size mismatch
498 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
500 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
501 break under windows (with msvc6 compilation).
503 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
505 compiling with MSVC6)
507 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * Bugs fix for the Windows build with VC6
509 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
510 needed (only for projects required VTK). If the VTK is included in all
511 projects, there is conflicts with the jpeg lib of vtk when compiling the
512 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
513 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
514 when compiling the gdcm_wrap.cxx file (created by the compilation of the
516 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
517 (like it's already made for the cout use). Otherwise, conflict with the
520 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
523 - comments on the DicomDir::Method related usage added.
524 - now that we use the namespace gdcm, a lot of internal classes do
525 NOT need to be wrapped anymore.
526 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
527 DicomDir::Method) new example added.
529 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
530 * Improve string manipulation. I now inforce the notion of 'DicomString'
531 A DicomString can contain as many \0 as they want
532 and it is *always* of even length.
533 We only support odd length for very rare case.
534 And in the near future this should be removed.
536 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
537 * /binary_write/ gdcm source. Now even on big endian we are writting
538 little endian. This should -heopfully- fix some tests
540 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
541 * Now the dictionary is compiled into gdcm lib. This is a default
542 behavior, thus any dic file specified is picked before failback to
543 the one comiled into lib
545 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
546 * Change internals for gdcmDict. Don't use any 'new' any more.
547 This should definitely solve any leak problem, and we should be
548 as fast as before, as long as don't modify too much the dictionary.
550 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
551 * STYLE: ivars should start with a capital letter.
552 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
553 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
555 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
557 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
558 new 2004 dictionaries added (thanks to JPR).
559 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
560 * CLEANUP_ROUND (15) for gdcmPixelConvert
561 - RLEFrame::NumberFragments is now of type unsigned int
562 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
563 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
566 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
567 * Initial work in gathering all transfer syntax accessors. clearly
568 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
569 ivars, but only one transfersyntax (class) ivar with equivalent method on
572 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
573 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
574 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
575 discussed (plus I didn't like having a 2000 lines patch not commited)
577 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
579 * CLEANUP_ROUND (14) for gdcmPixelConvert
580 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
581 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
582 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
584 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
585 anymore and hence avoids storing a copy of PixelConvert::Decompressed
586 into File::Pixel_Data.
588 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
590 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
591 * CLEANUP_ROUND (13) for gdcmPixelConvert
592 Substituted File::ParsePixelData() with PixelConvert::Print() new
594 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
595 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
596 method to those classes.
597 - src/gdcmFile.[cxx|h]:
598 -- Added a ::Print() method.
599 -- PixelConverter is now a reference instead of a member.
600 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
601 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
603 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
605 collaboration diagram and inheritance diagram should be generated with
607 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
608 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
609 pointlessly wrapped (see
610 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
611 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
612 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
613 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
614 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
615 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
616 -- File::Initialise: PixelConverter setup moved away to
617 PixelConverter::GrabInformationsFromHeader()
618 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
619 interpretation moved away to PixelConverter::BuildRGBImage()
621 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
622 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
623 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
625 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
626 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
627 displayed on Win32 when a brutal abort() occurs (because of uncatched
628 exception). See TODO new entry of this commit for more on this.
629 * TODO added new entry.
630 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
631 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
632 - HandleColor is no longer called from gdcmFile.cxx
633 - gdcmPixelConvert.cxx clean up on method arguments and internal
634 variable names for semantical coherence.
636 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
637 * Finished lossless transition, not only do we now read all lossless jpeg
638 images, without the need of the Cornwell lib, but we do read them properly now
639 * To reduce code (well to avoid code duplication), I defined a common place
640 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
641 redefine symbols. This is not perfect but this the best solution I found for a
642 compilation time jpeg option.
644 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
645 * Update jpeg ijg lib to support lossless jpeg implementation
646 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
648 * Also added a special copyright for dcmtk since we use their bugfixes.
651 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
653 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
654 matters, as stated in warning note at begining of %include section).
655 * src/gdcmDicomDir*.[cxx|h]: coding style
656 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
657 * src/gdcmJpeg8.cxx: doxygen fix.
658 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
659 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
660 from File:: to PixelConvert::.
662 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
663 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
664 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
665 - more code moved away from File:: to PixelConvert::
666 - fat setup of PixelConverter set in place in File::Initialise.
668 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
670 namespace at the file system level. So now you should convert your examples
672 gdcmHeader -> gdcm::Header
673 It would be nice if people keep in mind to no open the namespace, since it
674 allows compilation on broken plateform which were defining common symbol in
675 the standart namespace (like LP, Unknown ...)
677 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
679 The JPEG fragments are now parsed at the same stage than the RLE
680 information. All code related to JPEG is now in gdcmPixelConvert:
681 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
682 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
683 export a gdcmFile:: method. Those are simply global functions
684 (for the time being this is better than having them attach to
685 either gdcmFile:: or gdcmPixelConvert::).
686 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
687 and stores the result in a gdcmJPEGFragmentsInfo.
688 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
689 code (among other stuff) moved away from gdcmFile:; to
692 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
694 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
695 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
696 clean up of RLE related code.
697 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
698 - src/gdcmRLE.cxx removed
699 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
700 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
701 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
702 * CLEANUP_ROUND (9) for gdcmPixelConvert
703 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
704 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
705 away from gdcmFile:: to gdcmPixelConvert::.
707 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
708 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
709 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
710 This is because Parse7Fe0 used to parse the pixels to compute the
711 length. This task was passed over to FindDocEntryLengthOB() a long
712 time ago, EXCEPT I had forgotten the OW case...
713 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
714 we just recylce the code for parsing RLE fragments and computing
716 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
717 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
718 with the retired Parse7Fe0().
719 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
720 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
722 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
724 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
725 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
726 - src/CMakeLists.txt: alphabetic order reodering + new entries.
727 * CLEANUP_ROUND (4) for gdcmPixelConvert
728 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
729 to return an unused length.
731 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
732 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
733 this should be cleanner from the plane view. The iostream are erally a pain
734 to use to do simple stuff.
736 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
737 * Redo the compilation of the ijg jpeg library. Now only one source is
738 necesseray. No need to rename file by hand what so ever. CMake handle the
739 copying of the file within different directory, configure header file to
740 modify some symbol. The only addition made to ijg wasd a mangle table so
741 that symbol are different wether we are within 8bits or 12bits.
743 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * Added documentation of vtkgdcmReader on Website:
745 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
746 with it's binary name).
747 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
748 the Website to be more complete.
749 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
750 doxygenated documentation.
751 - Doc/DoxyVtkGdcmReaderExamples.txt added
752 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
753 DoxyVtkGdmReaderExamples.html )
754 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
755 * CLEANUP_ROUND (3) for gdcmPixelConvert
756 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
758 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
759 * CLEANUP_ROUND (2) for gdcmPixelConvert
760 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
762 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * CLEANUP_ROUND for gdcmPixelConvert:
764 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
765 - src/gdcmPixelStuff[h|cxx] removed
766 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
767 - src/CMakeLists.txt changed accordingly
769 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
770 gdcmVersion.py moved to newly created ATTIC related
771 gdcmPython/SetupOldies/ directory.
772 * Autotools clean up:
773 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
774 - autogen.sh configure.in acinclude.m4 python.m4 removed
776 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * src/*.cxx *.h Reference to License.htm fixed to License.html.
778 * Doc/CMakeLists.txt, doxygen.config.in: fix.
779 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
781 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * TODO updated with Mathieu suggestions. I proposed a template for
783 describing TODO entries and used it for new entries.
784 * Added Doc/Website/CodingStyle.html, Developpers.html,
785 DeveloppersPython.html, GdcmDataCvs.html and
786 DownloadVersion0_1.html, DownloadVersion0_3.html.
787 * Some Doc/*.txt Doxygen files (which do not really concern the
788 documentation itself, but the website) moved to html and
789 placed in directory Doc/Website:
790 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
791 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
792 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
793 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
794 * CMakeLists.txt changed accordingly.
795 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
796 DeveloppersPython.html
797 * INSTALL nows refers to Doc/Website/Installation.html
799 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * Added Doc/Website directory, that contains a first raw version
803 2004-09-23 Jean-Pierre Roux
804 * FIX In order not to be poluted any longer by casting problems,
805 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
806 we can now delete[] it safely
807 * VoidArea is now called BinArea (less confusing name),
808 and all the methods called ...VoidArea... are now ... BinArea...
809 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
811 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
813 clear) TagHT, which is an inherited member of gdcmElementSet. It is
814 up to the destructor of gdcmElementSet to clean up TagHt and it's
817 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * Test/CMakeLists.txt: update to follow gdcmData renamings.
819 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
821 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
822 * ENH: added some utility method that builds a flat dictionnary
823 holding all the Dicom entries contained in the recursive structure
824 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
826 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
827 BuildFlatHashTable() that build a flat dictionary.
828 - src/gdcmElementSet.h: added a new private GetTag() accessor.
829 gdcmDocument is now a friend of gdcmElementSet.
830 - src/gdcmElementSet.cxx: clean up.
831 - Example/FlatHashTablePrint.cxx added.
832 - Example/CmakeLists.txt changed accordingly
834 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
836 moved away from gdcmDocEntrySet (since this class is an abstract class
837 acting like an interface). SQDepthLevel and BaseTagKey are now
839 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
840 and associated accessors. Doxygenation of the class.
841 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
843 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
844 Use SQDepthLevel accessor instead. ::Print() adapted.
845 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
846 - src/gdcmDocument.cxx changed accordingly.
848 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
850 - The following is the doxygen comment of the typedef declaration
851 of gdcmagKey in src/gdcmCommon.h:
852 gdcmTagKey is made to old an "universal" (as in URL, Universal
853 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
854 A dicom tag allways has a group and an element, but a set of tags
855 embeded in various (optionally nested) sequences and sharing
856 the same group and element all share the same (group, element)
857 "identifier". Hence the (group, element) cannot be used as an
858 identifier (in gdcm we shall refer to a "TagKey") of a tag.
859 In order to construct a proper tag identifier (i.e. a key) we
860 consider the following definition of a TagKey:
861 - let Group, Element be the string representation of the
862 group and element dicom tag members,
863 - let ItemNumber be the string representation of the integer
864 index of the considered item number of a sequence,
865 Let the key of a tag embeded in a sequence, noted SeqTag, be
867 /ItemNumber#Group|Element
868 where "/", "#" and "|" are characters acting as separators.
869 Then the general form of a gdcmTagKey is given by:
870 Group|Element<SeqTag>
871 where <SeqTag> means NO or many instances of SeqTag.
872 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
875 but the gdcmTagKey of a tag "embeded" is the first item of
876 a sequence, itself nested in the third item of a sequence is the
878 0004|1220/2#0008|0082/0#0008|0090
879 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
880 order to hold the new sequence compatible key. Previously, the
881 GetKey() method would look in the underlying gdcmDictEntry.
882 - src/gdcmDocEntry.cxx:
883 -- constructor now copies the underlying DictEntry key, in the local
885 -- ::Print: displays the member Key, instead of the (group, element).
886 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
887 - src/gdcmDocEntrySet.h:xi
888 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
889 -- now has a new BaseTagKey member.
891 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
892 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
894 This poses the problem with the semantics of the following lines
895 LoadEntryVoidArea(0x0028,0x1201); // R LUT
896 LoadEntryVoidArea(0x0028,0x1202); // G LUT
897 LoadEntryVoidArea(0x0028,0x1203); // B LUT
898 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
899 to the long FIXME note for what the problem is. Nevertheless in
900 order to get things working the dicom dictionary was altered !
901 Please fix things urgently...
902 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
903 information), see above note on moving the member VoidArea. Nevertheless
904 the following entries previously correctly set as US are now inproperly
906 0028 1201 OW IMG Red Palette Color Lookup Table Data
907 0028 1202 OW IMG Green Palette Color Lookup Table Data
908 0028 1203 OW IMG Blue Palette Color Lookup Table Data
909 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
910 of gdcmDocEntry moved to gdcmSeqEntry.
911 * src/gdcmSeqEntry.cxx: STYLE.
913 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * Test/TestAllEntryVerify.cxx minor fix and added comments.
916 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
917 * gdcmPython/testSuite.py: all the test suite in python is now moved
918 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
919 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
920 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
922 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
924 to avoid inclusion recursion until STL is reached.
925 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
926 mecanism. errno.h is not included in gdcm anymore.
927 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
928 (gdcmFormatError now inherits from gdcmFormatUnexpected).
930 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
931 gdcmData/TestAllEntryVerifyReference.txt
932 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
933 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
934 exception_on_error parameter.
935 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
936 - vtk/vtkGdcmReader.cxx changed accordingly,
937 - Example/*.cxx and Test/*.cxx changed accordingly.
939 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
941 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
942 enable_sequences removed from gdcmHeader constructor and dependencies.
943 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
944 * gdcmPython/demo/PrintHeader.py: dummy fix.
945 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
946 skip_shadow removed from gdcmHeader constructor and dependencies.
947 * Example/*.cxx and Test/*.cxx changed accordingly.
949 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
951 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
953 2004-07-21 Jean-Pierre Roux
954 * FIX Now, Parsing and Printing a DICOMDIR do work!
955 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
957 2004-07-20 Jean-Pierre Roux
958 * FIX Some brain damaged headers have Zero-Lenght fields
959 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
961 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
962 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
963 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
964 variable (instance of gdcmDebug) by a definition macro, and the instance
965 is now in static in the gdcmDebug class
966 * src/gdcmSQItem.h : (FIXME) remove an undefined method
967 * Test/PrintAllDocument.cxx : bug fix in the result of the test
969 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * WARNING: ctest now depends more tightly on gdcmData. You should
971 check out gdcmData properly for things to run smoothly...
972 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
973 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
974 we need the pixels not be loaded in order to use the ValEntry
975 that displays position and size).
976 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
977 This is a C++ based equivalent of gdcmPython/testSuite.py that should
978 be deprecated. If you have any doubts about the advantages of a
979 modern scripting language (read Python) versus grass root C++ (i.e.
980 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
981 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
982 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
983 Anyhow, consider documenting the gdcmData images in
984 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
986 * Test/CMakeLists.txt:
987 - now uses TestAllEntryVerify.cxx
988 - specific comments on oldACR00001.ima (now renamed in gdcmData
989 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
990 gdcmData/TestAllEntryVerifyReference.txt
993 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * src/*.[h|cxx] : typedef clean up
995 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
996 - TagKey renamed to gdcmTagKey (for external usage)
997 - VRKey renamed to gdcmVRKey (for external usage)
998 - removal of typedef duplication.
999 - Removed all unecessary inline keyword from class inline definitions.
1000 - Some method|function(void) declarations replaced with method|function().
1001 * src/jpeg/libijg12/jdhuff12.c:
1002 - printf polluting ctest removed.
1003 - TAB removal for comminting
1005 - TestAllReadCompareDicom.cxx: added a test that compares all the
1006 images in gdcmDataImages.h with corresponding images in
1007 gdcmData/BaselineDicom/. When baseline images are not present
1008 this test creates them.
1009 Note: we need to validate each reference image, but before that
1010 I'd like to rename them with a more explicit name...
1011 - CMakeLists.txt: changed accordingly.
1012 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1013 including each header needed).
1015 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1017 test suite to the Example directory. Are concerned:
1022 - TestWriteSimple.cxx
1023 * Test/CMakeLists.txt: added some comments on reasons for black listing
1024 image gdcmData/oldACR00001.ima
1026 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * Test/CmakeList.txt: removed the following from black list (to be coherent
1028 with removal from gdcmData):
1029 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1030 - gdcm-MR-PHILIPS-16.dcm
1032 Added the following because after last cvs update, they cause
1033 ctest -R TestReadWriteReadCompare
1035 - gdcm-MR-SIEMENS-16-1.acr
1037 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1038 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1039 new comments in this file) we temporarily (sigh) move to a weaker
1041 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1042 we don't need to black list the following images anymore:
1043 - 8BitsUncompressedColor.dcm
1045 - US-PAL-8-10x-echo.dcm
1046 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1047 fixes and the beautified code ;-)
1048 This fixes the bug introduced in version 1.42 (when beautifying)
1049 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1050 Note: ctest was blind to this bug (this means we need to still
1051 improve the test suite). The bug could be detected by using
1052 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1054 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1055 and by displaying the (garbage) produced file temp.XDCM...
1057 2004-06-29 Jean-Pierre Roux
1058 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1059 - replace by uggly but working old code :-(
1060 A lot of things should be OK again.
1061 It's really urgent to have a test suite that *tests*,
1062 to prevent Frog's beautifying sessions to break all the stuff
1063 (twice, withing a fortnigh ...)
1065 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1067 redundancy) to added Test/TestReadWriteReadCompare.cxx
1068 * Test/CmakeList.txt: because the compare test of
1069 Test/TestReadWriteReadCompare.cxx fails, the following images are
1070 black listed: - 8BitsUncompressedColor.dcm
1072 - US-PAL-8-10x-echo.dcm
1073 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1074 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1075 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1076 and ad-hoc kludge. This kludge is now removed, and on encountering
1077 such an image (OB field brain damaged) we set errno. Then in
1078 ::FindDocLength() we "fix" the length as being ALL what remains
1079 in the file (until EOF). We then proceed, hoping for the best...
1080 This fixes a SegFault in ShowDicom when trying to write such an
1082 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1083 (because TestWriteRead breaks on it, after a non conformal commit?).
1084 ctest now runs properly, except for MakeDicomDir (which was allways
1085 broken) and the Python related stuff (still not fixed).
1087 2004-06-24 Jean-Pierre Roux
1088 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1089 FIX : Test/TestReadWrite now iterates on all the file names
1090 (instead of infinite loop)
1091 ENH : Test/TestWriteRead now iterates on all the file names
1093 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1096 2004-06-24 Jean-Pierre Roux
1097 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1098 when SamplesPerPixel =3
1099 - now Write is no longer confused by
1100 'BitsAllocated = 12" and 'BitsStored=12"
1101 - "UN" value representation Elements are now written correctly
1102 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1103 ENH : - now gdcmHeader has its own Write methods
1104 (in order to split the job that has not to be done
1107 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1109 loop on the same image until memory went out.
1110 Note: this means we still have gobs of memory loss in PrintDocument
1111 * src/gdcmDocument.cxx: fixes problem on parsing on file
1112 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1114 2004-06-24 Jean-Pierre Roux
1115 FIX : Write - All the Sequences and Sequence Item are now written
1116 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1117 is added a the end, when necessary.
1118 - A lot of brain-damaged images, that were read correctly are
1119 now written correctly
1120 - length compatible BinEntry are now loaded correctly
1121 (even for odd groups)
1122 Note : only Explicit Value Representation was checked.
1123 (question : is implicit VR really necessary for gdcm ?)
1125 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * DEVELOPPER: added a proposition of coding style.
1127 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1130 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1132 Use the gdcmDocEntry::Print() and Write() instead.
1133 * src/gdcmDocument.cxx: bug fix.
1135 2004-06-22 Jean-Pierre Roux
1136 FIX : gdcmDocument.cxx
1137 - Now we do recognize the JpegLossLess format (there was a misstyping in
1138 code 'beautyfication' :-(
1139 - Now we automaticaticaly load the Luts, if any
1141 2004-06-22 Jean-Pierre Roux
1142 In order : to write Sequences, whatever their imbrication level,
1143 : to allow user to create his own Sequences
1144 a lot of modif where necessary (adding, moving, or virtualising methods)
1146 WARNING : save your own sources *before* cvs up !
1149 ADD virtual void Write(FILE *fp, FileType filetype);
1152 ADD virtual void Write(FILE *fp, FileType filetype);
1153 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1156 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1157 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1158 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1159 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1160 ADD std::string GetEntryByName(TagName name);
1161 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1163 std::string vr = "unkn",
1164 std::string fourth = "unkn",
1165 std::string name = "unkn");
1166 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1167 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1168 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1169 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1170 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1171 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1172 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1173 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1176 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1177 ADD virtual std::string GetEntryByName (TagName tagName);
1178 ADD virtual std::string GetEntryVRByName (TagName tagName);
1179 REM virtual bool Write(FILE *, FileType);
1180 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1181 FILE *_fp, FileType type);
1182 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1183 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1184 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1185 REM virtual std::string GetEntryByName (std::string tagName);
1186 REM virtual std::string GetEntryVRByName (std::string tagName);
1187 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1188 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1189 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1191 std::string vr = "unkn",
1192 std::string fourth = "unkn",
1193 std::string name = "unkn");
1194 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1195 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1196 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1197 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1200 ADD virtual void Write(FILE *fp, FileType filetype);
1203 ADD virtual void Write(FILE *fp,FileType filetype);
1206 ADD virtual void Write(FILE *fp, FileType filetype);
1207 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1208 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1209 REM std::string GetEntryByName(TagName name);
1212 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1214 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1216 The default constructor invoked by the line
1217 gdcmHeader *f1 = new gdcmHeader( header );
1218 was gdcmHeader::gdcmHeader(bool) instead of the expected
1219 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1220 Hence the parsing wasn't executed... See also below.
1221 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1222 as explicit constructor didn't do the trick to fix the above problem.
1223 Could anyone explain why ?
1224 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1225 properly calls gdcmValEntry::Print() (that was weed out from
1226 code related to gdcmBinEntry).
1228 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * In order to fix memory leaks:
1230 - Test/TestWriteSimple.cxx: added cleaning of free store through
1232 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1233 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1234 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1235 (through the call to ::AddDicomDirMeta()) or the destructor
1236 would crash when deleting uninitialized ::metaElems].
1237 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1238 - src/gdcmDocument.cxx:
1239 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1240 from dynamic stores.
1241 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1242 was causing memory leaks.
1243 - src/gdcmSQItem.cxx:
1244 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1245 cleanly handled with polymophism: sorry but my milage is low).
1246 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1247 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1248 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1249 This avoids SegFaulting.
1250 - src/gdcmSQItem.h: coding style.
1252 - Test/TestWriteSimple still severely sucks. The output image content
1253 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1254 damaged when displayed with vtkgdcmViewer.
1255 - on memory leaks: TestWriteSimple leaks really less (see entry
1256 of 2004-06-18 in Changelog file for the call to valgrind).
1257 - on segfaults: ctest now passes all the tests but one (no more
1259 * Erroneous leading white fix:
1260 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1261 white[s] (as opposed to from >> xxx, that removes it [them].
1262 - src/gdcmTS.cxx: ditto.
1263 - gdcmPython/testSuite.py: dirty related kludge removed.
1264 * src/*: remaining references to gdcmParser removed.
1265 * src/*[cxx|h]: added copy[way]left header.
1268 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * In order to fix writing of dicom files:
1270 - Test/TestWriteSimple.cxx: a simpler example of writing.
1271 - Test/CMakeLists.txt changed accordingly.
1272 - src/gdcmDocument.cxx:
1273 -- The destructor now recursilvely removes potential sequences.
1274 -- Bug fix in ::IsJPEG2000()
1275 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1276 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1278 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1279 to only declared) and build on top of
1280 ::GetDocEntryByNumber(guint16, guint16).
1281 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1282 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1283 for usage in destructor and treatement of promotion in
1284 ::ReplaceOrCreateByNumber().
1285 - src/gdcmSQItem.cxx: destructor should better handle his job.
1286 Test/TestWriteSimple now runs (or at least it DOES something).
1287 * We can now start hutting memory links. A good starting point is:
1288 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1289 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1290 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1292 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * Valgrind note: after Mathieu Malaterre teached me how to read
1294 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1296 Using gcc, you can force the STL to use malloc and to free memory as
1297 soon as possible by globally disabling memory caching.
1298 With 3.2.2 and later, you should export the environment variable
1299 GLIBCPP_FORCE_NEW before running your program.
1300 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1301 simply vanish (it is still not clear to me, whether this means that
1302 STL std::string leaks or if valgrind believes it leaks...).
1303 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1304 running bin/gdcmTests makeDicomDir):
1305 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1306 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1308 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1309 SegFaulting (I drowned in DicomDir related code when trying to
1310 understand why the list is empty...).
1311 * src/gdcmDocument.h: first BSD license header try.
1312 * Doc/License.txt added.
1314 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1315 * src/gdcmDocument.[h|cxx]:
1316 - Clean up of the Transfer related predicates. They are now all based
1317 on new method isGivenTransferSyntax, that (should) handle properly
1318 the padding problem.
1319 - general clean up, simplification, and coding style.
1320 - Specific clean up of Parse7FE0() (umproperly named actually).
1321 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1323 2004-06-14 Jean-Pierre Roux
1325 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1326 - fix the display of SQItem ordinal number
1327 - add the GetSQItemByOrdinalNumber method
1328 - remove some useless never written private methods
1330 2004-06-14 Jean-Pierre Roux
1332 - adding a constructor taking a gdcmDocEntry as an input param
1333 - ReplaceOrCreateByNumber now returns :
1334 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1335 a gdcmValEntry * if a string value is passed as a param
1337 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1338 according to the param type (no longer sets a gdcmDocEntry)
1339 - GetValEntryByNumber, GetBinEntryByNumber added
1340 - NewValEntryByNumber and NewBinEntryByNumber added
1342 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1344 - GetSQItemNumber and SetSQItemNumber added, to provide
1345 a (relative) Item identier inside a given Sequence
1346 \warning : some pb remaining around this number
1348 - AddEntry now takes the Item Number as a param
1350 - adding a constructor taking a gdcmDocEntry as an input param
1352 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1353 * Memory leak hunt with the following command:
1354 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1355 --show-reachable=yes gdcmTests PrintDocument
1356 It looks like many (all?) leaks are due to the STL (or a bad usage
1357 of the STL. The lines producing the leaks now have a comment with
1358 a "MEMORY LEAK" tag: you can retrieve them with
1359 grep "MEMORY LEAK" src/*
1360 Here are two typical examples which I can't help fixing:
1365 char * test = "babo";
1366 name = test; //// <--- valgrind detects 960 bytes lost in
1367 //// call to std::string::operator=(char const*)
1368 name.clear(); //// Doesn't help !
1376 std::cout << "Type a bunch of characters followed by RETURN: ";
1377 getline(std::cin, line); //// <--- valgrind dectects a loss
1378 //// of 1320 bytes in call to
1379 /// std::basic_istream<>& std::getline<>
1385 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * src/gdcmHeader.[cxx|h]:
1387 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1388 and related, moved away to gdcmDocument.
1389 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1390 the corresponding protected accessors of inherited class
1391 gdcmDocument, removed ! As a consequence gdcmFile had to be
1392 declared friend of class gdcmDocument (see below).
1393 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1394 - Clean up of undefined or unused methods.
1395 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1396 account the changes to gdcmHeader.h).
1397 * src/gdcmDocument.h:
1398 - gdcmFile is now a friend class (in order to take into account the
1399 changes to gdcmHeader.h).
1400 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1401 (see changes to gdcmHeader.h).
1402 - Accessors (reading on the form GetEntry*) are now public.
1403 - Clean up of undefined or unused methods.
1404 * src/gdcmDocument.cxx:
1405 - adaptation to changes to gdcmDocument.h
1406 - ::OpenFile now writes a verbose message when file cannot be opened.
1407 - some std::string properly set to VRKey
1408 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1409 references to gdcmDocument.
1410 * Test/TestFindTags.cxx: changed accordingly to above changes.
1411 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1412 cvs repository gdcmData.
1414 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1416 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1417 conflicts with gdcmValEntry::voidArea.
1418 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1419 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1420 Value representation between StringRepresentable and BinaryRepresentable.
1421 * src/gdcmDocument.cxx:
1422 - method ParseDES: proper indentation restored and usage of
1423 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1424 - method LoadDocEntry: the fingerprint left in the SetValue() of
1425 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1426 removed. Reverting to previous code segment with the proper
1427 dynamic_cast< gdcmValEntry* >.
1428 Note: this was (partially) breaking the python test suite
1429 (gdcmPython/testSuite.py) that made usage of the above
1430 fingerprint to check presence of "Pixel Data".
1431 * src/gdcmDocEntry.h: coding style.
1432 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1433 now taken into account.
1434 * gdcmPython/gdcm.i: adaptation to the new internal representation
1435 of gdcm (exit gdcmParser, hello gdcmDocument).
1436 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1438 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1439 anymore, but instead prints the loaded Python dictionary.
1440 * .... alas, the python testSuite is still broken.
1442 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1443 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1445 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1446 * src/gdcmUtil.h : export methods
1448 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1449 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1451 * Initial addition of automatic python testing
1452 * Initial addition of automatic image comparison
1454 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1455 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1456 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1458 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1459 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1460 * Test/ShowDicom.cxx : bug fix for msvc compilation
1461 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1463 2004-05-04 Jean-Pierre Roux
1464 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1465 new concepts (and new classes) :
1466 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1467 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1468 - Sequence Doc Entries (gdcmSeqEntries)
1469 a Sequence is composed of Items.
1470 Each item is a set of Doc Entries (this is recursive)
1471 The non uniqueness of the 'Dicom tag' is due to this recursivity
1472 (never taken into account)
1473 Our unability to add a new 'entry' in the header
1474 at the proper location (neither in the H-Table (map or multimap),
1475 nor in the Chained List is also due to this recursivity.
1476 Don't try, right now, to use/modify/compile these new sources :
1477 nothing is finished.
1478 We just commit all the stuff, 'as is', in order not to loose it.
1480 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1483 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1484 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1485 file prefix (SetFilePrefix)
1487 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1488 * Add a new test: ShowDicom, for now this is just the c++ version of
1489 checkRead.sh, later it will be able to compare the image read against a
1491 * Replace the DEBUG on the stack with a global entry in cmake interface:
1492 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1494 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1495 * Add an example subdir, with a real example on how to read + write a
1498 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1499 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1500 * Doc/CMakeLists.txt: the main page is now properly differentiated
1501 between the developper and user version.
1502 * Doc/doxygen.config.in: dropped search related obsolete flags
1503 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1505 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1506 * DEVELOPPER: added some helpfull comments for compile/test/install
1509 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1511 src directory, now generated in the build dir.
1512 2. Tests as mentionned smarter
1514 4. Add a new method in gdcmDict that return the PubDict by name
1515 this is interesting for 3rd party lib like ITK,
1516 where we could set the institution name / patient name...
1518 * ENH: 1. Now the test suite is working for real
1519 2. All binaries are now output in the gdcm-bin directory
1520 (this was not true before)
1522 2004-04-28 Jean-Pierre Roux
1523 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1524 SeQuence indented printing of Dicom Header.
1525 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1526 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1527 Computation of SQDepthLevel is now part of gdcmHeader constructor
1528 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1529 tree-like structure of a Dicom Header.
1530 * FIX Test code cleaning
1532 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1533 * ENH: Adding automatic testing
1534 1. Need a DartConfig.cmake to submit to public
1535 2. Add a test driver gdcmTest.cxx
1536 3. gdcmTestMain, an helper for the main test driver gdcmTest
1537 4. Files in Test don't have a main anymore, this becomes interesting
1538 when we add more and more tests, thus dsw don't have to load
1540 * ENH: Adding a GDCM_DATA_ROOT for testing
1541 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1542 one file instead of seven + some small cleanup
1544 2004-04-22 Jean-Pierre Roux
1545 * ENH Minor changes to the Print() methods.
1546 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1547 Header printing. Example given with :
1548 > PrintHeader fileName 2 new
1549 (SQ based tree-like structure still to be done for the Header ...)
1551 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1552 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1553 1. I have added some unsigned where needed
1554 2. Some function parameter not used -> (void)
1555 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1556 4. g++ don't like character '\' in comment
1557 5. #define jpeg_create_decompress jCreaDecompress
1558 this really need to be fixed
1559 6. virtualize destructor of gdcmObject ... leakage
1560 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1561 this also really need to be fixed
1562 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1563 remove compression file
1564 (as we only do decompression, right ?)
1565 * ENH: Change malloc/calloc/free with c++ equivalent
1567 2004-04-21 Jean-Pierre Roux
1568 * FIX gdcmHeaderHelper::GetXSpacing
1569 when a single value is found (bug ?), xpacing is now
1570 defaulted to yspacing
1572 2004-04-19 Jean-Pierre Roux
1573 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1574 * ENH add parameters :
1575 bool exception_on_error = false,
1576 bool enable_sequences = false,
1577 bool ignore_shadow = false
1578 to the gdcmFile constructors to be full gdcmParser compliant
1579 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1580 to allow reading of PAPYRUS 3.0 files
1582 2004-04-06 Jean-Pierre Roux
1583 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1585 2004-04-02 Jean-Pierre Roux
1586 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1587 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1588 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1590 2004-03-30 Jean-Pierre Roux
1591 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1592 for ACR file, written out as DICOM files (hope so...)
1594 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1596 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1597 moved to base class gdcmParser and only the specialisation is kept
1599 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1600 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1601 already does the job.
1602 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1603 (to be consistent with gdcmParser::WriteEntries).
1605 2004-03-30 Benoit Regrain
1606 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1607 upate of the object's instance. It's passed to 2 in the unfavorable
1608 case : one in the ExecuteInformation, one in the ExecuteData
1610 2004-03-29 Jean-Pierre Roux
1611 * ENH : Check on file type to be written moved
1612 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1613 * FIX : gdcmObject::ResetBoundaries now stops properly
1614 when end-of-list is reached
1615 : gdcmVersion modified (as Benoit Regrain asked)
1617 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1618 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1619 * src/gdcmUtil.cxx: added forgotten iostream include.
1620 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1621 equivalent to ExplicitVR in existing code).
1623 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1625 now contains all the gdcmGlobal related code.
1626 * minor coding style and doxygenation changes.
1628 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1630 now contains all the Debug related code.
1631 * minor clean-up of includes in src/*.cxx
1632 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1633 CreateCleanString) removed.
1634 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1635 * Doc/DoxyMainPageUser.txt added.
1636 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1637 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1638 src/gdcmDirList.cxx)
1640 2004-03-24 Jean-Pierre Roux
1641 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1643 2004-03-23 Jean-Pierre Roux
1644 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1645 big endian made volumes
1646 * ENH Now gdcmParser constructor and destructor are protected to forbid
1647 end user to instanciate class gdcmParser
1648 (only gdcmHeader and gdcmDicomDir are meaningfull)
1650 2004-03-22 Benoit Regrain
1651 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1652 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1653 gdcmSerie to gdcmDicomDirSerie
1655 2004-03-19 Jean-Pierre Roux
1656 * ENH Now the tree-like structure describing a DICOMDIR comming from
1657 an already existing DICOMDIR file is consistent with
1658 the home-made tree-like structure build ex-nihilo
1659 or build from the files held (recursively) in a Directory
1660 functions gdcmDicomDir::CheckBoundaries()
1661 gdcmObject::SetBoundaries() added
1663 2004-03-17 Jean-Pierre Roux
1664 * REM (Eric Boix bug) : removal of meaningless
1665 gdcmDicomDirImage::NewImage function.
1666 * FIX now file names and directory name are written properly in the
1668 * FIX now gdcmDicomDir constructor may be call without any trick
1671 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1672 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1673 of gdcmDicomDirImage::NewImage as empty function.
1675 2004-02-28 Jean-Pierre Roux
1676 * ENH add gdcmDicomDir:NewPatient
1677 add gdcmDicomDirPatient:NewStudy
1678 add gdcmDicomDirStudy:NewSerie
1679 add gdcmDicomDirSerie:NewImage
1680 to allow making gdcDicomDir object.
1681 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1682 (as opposite to the gdcmHeader chained list)
1684 2004-02-11 Benoit Regrain
1685 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1686 when using from python
1688 2004-02-10 Benoit Regrain
1689 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1690 * FIX : in gdcmDicomDir when the directory is empty
1691 * ENH : add callback and methods to get the progression of dicomDir
1694 2004-02-06 Jean-Pierre Roux
1695 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1696 - GDCM_META added to gdcmDicomDirType
1697 - class gdcmMeta created
1698 * ENH : - A brief summary is now displayed at the beginning of
1699 'testDicomDir' to help disaster magnitude estimation
1700 * REM : Now useless Test/explDICOMDIR.cxx
1702 2004-02-05 Benoit Regrain
1703 * ENH : add methods in gdcmObject to get the hash table or the list of
1705 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1706 * FIX : wrapping python for TagHeaderEntryHT
1708 2004-02-04 Benoit Regrain
1709 * FIX : even length for some strings when writting the dicom dir
1710 * FIX : sort the images in the dicom dir
1711 * FIX : Bug fix for python use of dicom dir
1712 * ADD : a python demo
1714 2004-02-04 Jean-Pierre Roux
1715 * FIX : Final solution (?) for icone embedded images
1716 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1717 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1718 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1719 gdcmData/gdcm-MR-SIEMENS-16.acr1
1720 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1721 to make full checking easier
1723 2004-02-04 Benoit Regrain
1724 * FIX : WriteEntries : coding style & logic in parameters
1725 * FIX : Set the elements to create the DicomDir in a dictionary file
1727 2004-02-03 Benoit Regrain
1728 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1729 * gdcmDicomDir : add the load of directory
1730 * Bug fix and print add-on
1732 2004-02-03 Jean-Pierre Roux
1733 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1734 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1735 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1736 * FIX gdcmParser.cxx : 'group length' elements are now considered
1737 as integers, even for shadow groups, when file is Implicit VR
1739 2004-02-02 Jean-Pierre Roux
1740 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1742 of the last synonym :-(
1743 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1745 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1746 * FIX taking into account the possible 7fe0,0010 multiplicity
1747 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1748 to allow removal of references to 7fe0,0010, to deal with
1749 ACR-NEMA images, when 0028,0200 is meaningfull
1751 2004-01-31 Jean-Pierre Roux
1752 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1753 no longer writes 'Un' on disk
1754 * FIX SQ elements with actual length are now dealt with corectly
1755 * FIX gdcmFile::WriteBase make the difference, for color images, between
1756 the length (for Palette expanded images)
1757 and Raw Length (non expanded image + Palette)
1758 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1759 (that broke Write). Replaced by UL.
1760 Aware user will reload the field if he
1761 thinks it's necesssary
1763 2004-01-30 Jean-Pierre Roux
1764 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1765 when 'dirty Acr' is found, to be compliant with the new
1766 IsReadable() methods.
1768 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1769 (no DOUBLE images in kosher DICOM,
1770 but so usefull for people that miss them ;-)
1772 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1773 DICOMDIR related utilities (not checked as Windoze compliant)
1775 2004-01-28 Jean-Pierre Roux
1776 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1778 2004-01-27 Jean-Pierre Roux
1779 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1780 to allow skipping the shadow elements, to save memory space.
1781 The TRUE value for this param has to be used
1782 with a FALSE value for the 'enable_sequence' param.
1783 ('public elements' may be embedded in 'shadow Sequences')
1784 * gdcmHeader methods now deal with 'embedded icones images' in the header
1785 (even when an 'icone image sequence' is announced by the
1786 element (0x0088,0x0200), but there is NO icone at all ...
1788 * gdcmHeader sometimes Image Location value doesn't follow
1789 the supposed processor endianity (see gdcmData/cr172241.dcm).
1792 * gdcmHeader add the method
1793 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1794 to get *all* the Header Entries with the same tag.
1795 GetHeaderEntrySameName is probabely *useless*
1796 (no meaning : Name is *not* an identifier within the Dictionnary)
1798 2004-01-26 Benoit Regrain
1799 * Bug fix in the print of hexadecimal representations. Remove long fields
1800 in the print and add a third level of print to print them
1802 2004-01-23 Benoit Regrain
1803 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1804 * Bug fix on test suite after remove the strip made on not string fields
1805 * Split the IsReadable method between gdcmParser which test that the file
1806 is dicom and gdcmHeader which test that it's an image file
1808 2004-01-22 Benoit Regrain
1809 * DicomDir : clean code, add methods, set variables in protected or private
1810 * gdcmUtil : bug fix for the clean string method
1812 2004-01-19 Benoit Regrain
1813 * Add the use of shadow dictionaries
1814 * bug fix and coding style
1816 2004-01-19 Benoit Regrain
1817 * src/gdcmFile.cxx : bug fix concerning the close of file
1818 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1819 * Add the update of header entries using the shadow library
1821 2004-01-19 Benoit Regrain
1822 * removal of file gdcmHeader2.cxx
1823 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1824 inheriting from gdcmParser. This split is to prepare the integration
1825 of dicom dir parsing
1826 * bug fix under python
1828 2004-01-16 Jean-Pierre Roux
1829 * REM removal of class gdcmHeaderEntrySet
1830 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1831 * ADD add file gdcmHeader2.cxx
1832 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1834 2004-01-15 Benoit Regrain
1835 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1836 entries created while parsing the header. Thus, they will be destroyed
1837 when the gdcmDictSet will be destroyed
1838 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1841 2004-01-15 Benoit Regrain
1842 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1843 made a fatal error because of the memory release at the end of program.
1844 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1845 some memory and vtk seems to have some problems with that.
1846 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1848 2004-01-14 Benoit Regrain
1849 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1850 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1851 * src/*.[h|cxx] : make changes due to class name changes
1852 * gdcmPython/demo/*.py : bug fix due to method names
1854 2004-01-13 Benoit Regrain
1855 * src/*.[h|cxx] : coding style
1856 * vtk/*.[h|cxx] : coding style
1858 2004-01-13 Benoit Regrain
1859 * gdcmPython/testSuite.py : test the readable flag of file for tests
1860 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1861 It's lied to the stl compilation by MSVC (windows, always windows...)
1862 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1864 2004-01-12 Benoit Regrain
1865 * src/*.h : add comments
1866 * src/gdcmDictSet.h : set the method BuildDictPath in public
1867 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1868 directly setted in the source code
1869 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1872 2004-01-09 Benoit Regrain
1873 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1874 * setup.py : use a reference to gdcmVERSION
1876 2004-01-07 Benoit Regrain
1877 * Modification to compile with the distutils.
1880 2003-12-10 Benoit Regrain
1881 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1882 can use a gdcmHeaderHelper to load data
1883 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1884 made in the source code
1886 2003-12-10 Benoit Regrain
1887 * Update Windows projects and .cvsignore files
1889 2003-11-12 Jean-Pierre Roux
1890 * ENH gdcmHeader constructor has one more parameter (default value : false)
1891 that allows the user to 'go inside' the SeQuences only
1893 gdcmElValSet:Print takes it into account
1895 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1896 * ENH: Update gdcmPython/CMakeLists
1897 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1898 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1900 2003-11-10 Jean-Pierre Roux
1901 * FIX : gdcmHeader::LoadElements is now based
1902 on the ListTag listElem member,
1903 not longer on the TagElValueHT tagHt member
1904 * ENH : PrintPubElVal shows (temporarily) both results,
1905 with the tagHt member and the listElem member.
1906 (it's easier to 'see' the problems when using Printheader)
1908 * FIX : old private member LgrElem is now splitted into
1909 ReadLength : Length actually found on disk (updated only
1910 if bug fixing is necessary), for internal
1912 UsableLength : Updated by FixFoundLength, to fix a bug
1913 or to allow Parser going on.
1914 Will allow to re-write a kosher header when a SeQuence
1915 with a length (not 0000) is found
1916 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1917 because gdcmElValSet::Add does not update ListElem
1920 2003-11-07 Jean-Pierre Roux
1921 * FIX misstyping in Transfert Syntax name table
1922 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1923 when they have an actual length (not 0000 nor FFFFF)
1924 (Nobody should care of it, but DICOMDIR explorers)
1926 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1929 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1930 * ENH: vtkGdcmReader now supports LUT !
1931 (vtkgdcmViewer for now is not able to use them though)
1933 2003-11-05 Jean-Pierre Roux
1934 * in testSuite.py : new files names for checking the package
1935 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1936 that returns the pixel area size to the *aware* (vtk) user
1937 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1939 2003-11-05 Benoit Regrain
1940 * in testSuite.py : Modify the rules for checking the paths
1941 : Explicit error messages
1942 * in __init__.py : Related modif
1944 2003-11-03 Jean-Pierre Roux
1945 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1946 to be used by aware (vtk) users that want to manage
1947 LUT (and no to turn the PALETTE image into an RGB pixels one)
1948 * GetPixelType now returns 8U for 24 Bits images
1949 (vtkGdcmReader compliant)
1951 2003-10-31 Jean-Pierre Roux
1952 * Removal of *all* gdcmData images and add them again
1953 in order to loose the 'history' of un-anonymised images
1955 2003-10-31 Jean-Pierre Roux
1956 * RMV : removal of useless jBitsInJsample.h
1957 for both 8 and 12 Bits JPEG Lossy Libraries
1959 2003-10-31 Jean-Pierre Roux
1960 * ENH : Add the functions gdcmFile::GetImageDataRaw
1961 gdcmFile::GetImageDataIntoVectorRaw
1962 that act as GetImageData and GetImageDataIntoVector
1963 except the making of an RGB Plane from Gray Plane + LUT
1964 Intended to aware (vtk) users who know how to manage
1967 GetLUTRGBA return a R,G,B,A LUT if any
1968 lgrTotaleRaw gives the 'Raw' length
1969 GetImageDataRaw returns the gray Plane
1970 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1971 (They stay Grey, just like with other Dicom viewers :-(
1973 2003-10-30 Jean-Pierre Roux
1974 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1976 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1978 being coherents dicom files.
1980 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1983 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1984 * ENH: Two steps is necessary to please VC++ compiler...
1985 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1986 * ENH: Add include dir to medcon lib
1987 * FIX: only one function is being exported for now !
1988 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1990 2003-10-29 Jean-Pierre Roux
1991 * adding gdcmHeader::GetLUTRGBA
1992 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1993 --> Mathieu, the modif u're waiting for is not yet committed
1994 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1996 2003-10-27 Jean-Pierre Roux
1997 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1998 00191113.dcm DermaColorLossLess.dcm
1999 MxTwinLossLess.dcm RadBWLossLess.dcm
2000 * ENH: For version prior to vtkImageViewer2 -r 1.19
2001 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2003 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * Removal of ido stuff in CMakeLists.txt
2006 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2007 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2008 * FIX: remove a call to ->Modified ... see comments
2009 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2011 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * FIX: Problem with path for libvtkgdcmPython
2013 * ENH: Try adding a search script for python site-package
2014 * RMV: Remove some file from medcon lib that are not necessary
2015 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2016 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2017 * FIX: More pragma disable fro VC++,
2018 I don't think I break something as it is also disable in VTK/ITK.
2019 But it fasten debug compilation time.
2021 2003-10-23 Jean-Pierre Roux
2022 * gdcm now deals with 16 Bits Run Length Encoded images
2023 (they are compressed as 2 planes images,
2024 one for the high Bytes, the other for low Bytes)
2026 2003-10-22 Jean-Pierre Roux
2027 * Now CheckRead takes into account :
2028 - the bugged 'Leonardo' Siemens images
2029 - the XA images, sent thru the burning VPRO station
2030 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2033 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2034 * FIX: When copying a Makefile.am to CMakeLists.txt
2035 one should remove the '\'
2037 2003-10-22 Jean-Pierre Roux
2038 * in gdcmData adding a bugged 'Leonardo' Siemens image
2039 (wrong lengths in header)
2040 OK with gdcm, KO with the other viewers :-)
2041 * add a GE dlx XA image, thru the VEPRO burning station
2044 2003-10-21 Jean-Pierre Roux
2045 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2046 for a brutal checking of vtkgdcmViewer compliance
2048 2003-10-21 Jean-Pierre Roux
2049 * add the files for 'xmedcon' Jpeg Lossless library
2050 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2052 2003-10-21 Jean-Pierre Roux
2053 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2055 2003-10-21 Jean-Pierre Roux
2056 * garbage Siemens 'Leonardo' images dealt with
2057 (the patch is easy to remove)
2058 * cosmetic changes to avoid warnings
2060 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2062 no need to press 'r' now.
2064 2003-10-20 Jean-Pierre Roux
2065 * upgrade of checkRead.sh checkWrite.sh according
2066 to new Jpeg Lossless decompressor
2067 * add US.3405.1.dcm, a genuine RGB medical file ...
2068 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2069 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2071 2003-10-15 Jean-Pierre Roux
2072 * general anonymisation in gdcmData
2073 * adding the 'color files' from
2074 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2075 * adding some well knowed bugged-header images
2076 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2077 waiting for their inclusion in Python testsuite
2079 2003-10-15 Jean-Pierre Roux
2080 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2081 no longer seg faults when file is not found
2083 2003-10-14 Jean-Pierre Roux
2084 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2087 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * TODO: *.in file to genereate a UseGDCM later
2090 2003-10-14 Jean-Pierre Roux
2091 * Some supposed-to-be Dicom Images have no preamble.
2092 OpenFile takes it into account
2093 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2094 * Missing elements added in dicomV3.dic
2095 (just to be affraid : have a look at
2096 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2097 and do it again next year ;->
2099 2003-10-13 Jean-Pierre Roux
2100 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2101 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2102 But there are NOT. It's fixed !
2104 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * FIX: "jpeglib.h" was not found on VC++
2106 * FIX: vtkgdcm was not being installed
2108 2003-10-10 Jean-Pierre Roux
2109 * ENH : OpenFile closes the file if it *really* doesn't look like
2110 an ACR-NEMA / DICOM one.
2111 * FIX : testWrite no longer writes an empty file if the source file
2112 is not gdcm Readable
2113 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2116 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2117 * FIX: CMake generate now documentation
2118 * ENH: out of source doc build !
2119 * ENH: Generate both user and dev documentation
2120 * ENH: Should work on windows too
2121 * ENH: Only one doxygen config.in file is needed
2122 * FIX: make install should be ok now on ùnix plateform
2123 * FIX: PATH to dictionary was wrong (missing /)
2124 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2126 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2127 * vtkGdcmReader is now able to read rgb dicom file.
2128 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2129 * added a gdcmViewer to vtk test, use mouse to control
2130 window level & window width
2132 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2133 * CMake-ification of gdcm, we have now two build system
2134 * FIX: on cygwin Wsock32 doesn't exist
2135 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2137 2003-10-06 Emanuel Ollart
2138 * FIX : compilation process wad broken.
2139 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2141 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2142 * change gdcmViewer -> vtkgdcmViewer
2143 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2145 2003-10-06 Jean-Pierre Roux
2146 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2147 ( e.g : well known GE images with a wrong elem length,
2148 : Philips MRI Images with a wrong Huffman table)
2149 * still to be done : allow the reading of bugged LEONARDO Siemens images
2151 2003-10-03 Jean-Pierre Roux
2152 * Odd length strings are padded with '\0' (not with spaces,
2153 to remain compliant with already defined strings,
2154 like Transfert Syntax UID and others)
2156 2003-10-03 Jean-Pierre Roux
2157 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2158 to allow displaying RGB images (not only by affim ;-)
2160 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2161 * vtkGdcmReader is now able to read rgb dicom file.
2162 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2164 2003-10-03 Jean-Pierre Roux
2165 * A few nasty patches to allow the reading of a lot of nasty images
2166 ( e.g : well known GE images with a wrong elem length,
2167 : Philips MRI Images with a wrong Huffman table)
2168 * still to be done : allow the reading of bugged LEONARDO Siemens images
2170 2003-10-03 Jean-Pierre Roux
2171 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2173 2003-10-03 Jean-Pierre Roux
2174 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2175 to allow displaying RGB images (not only by affim ;-)
2177 2003-10-03 Jean-Pierre Roux
2178 * gdcmFile::GetImageDataIntoVector now
2179 - deals with MultiFrames MultiFragments Run Length Encoded files
2180 - deals with YcBcR (YBR_FULL) files
2181 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2182 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2184 (no sample found :-(
2186 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2187 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2188 Two reasons: - clear things
2189 - third parties acces gdcm through header files, so won't
2190 suffer anymore VC++ complains
2192 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * add argv[1] in testvtkGdcmReader.cxx
2196 2003-09-24 Jean-Pierre Roux
2197 * The lines are now eigthy characters long.for
2198 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2200 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2201 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2202 char* to std::string. Thus, the use of strdup becomes useless. (see
2203 previous commis of Malaterre)
2204 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2205 before the last Malaterre's commit.
2207 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2208 * This commit should fix the Debug building under VC++, the problem
2209 was mainly a mixture of debug and release lib being loaded at startup.
2210 * I also remove a depency to a specific C function: strdup. Because I had
2211 to force the link to msvcrtd (whereas strdup is in libc).
2213 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2214 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2215 located in the gdcmCommon.h file. All use of reference of tha has been
2216 changed to now use the variable GDCM_UNFOUND.
2218 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2220 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2221 Dicom dictionary. The test suite can now be run again. Note:
2222 I'm note very happy with the " (RET)" changes. I believe this
2223 RETAINED comment should be dropped when parsing the dictionary.
2224 - PACKAGER corrected
2226 - AUTHORS updated and now in alphabetical order
2227 * Makefile.am now exports gdcm.dsw for Windoze users.
2229 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2230 * cygwin complains about missing std:: in subdir Test/
2232 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2233 * remove some methods that are now in gdcmHeaderHelper
2235 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * vtkGdcmReader set spacing and origin correctly
2238 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2239 * Fix a few delete/delete[] mismatch
2241 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2242 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2243 interpretation to data given by gdcmHeader. For instance there are
2244 heuristics to get informations (look at different places).
2245 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2246 sorting DICOM images based on different strategies.
2247 * modified Makefiles accordingly.
2249 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2251 when building in debug mode
2252 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2253 src/win32/gdcmdll.dsp
2254 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2256 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2257 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2260 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2261 * src/win32/libgdcmjpeg12.dsp was not dos format
2262 * src/win32/libgdcmjpeg12.dsp :
2263 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2264 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2266 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2267 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2269 * src/gdcmFile.cxx : bug fix in affectation type
2270 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2271 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2272 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2273 symbols... future problem ?
2275 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2276 * src/win32/libgdcmijpeg12.dsp was missing
2277 * modified gdcm.dsw accordingly
2279 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2280 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2282 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2283 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2284 commit of JPR (before his hollidays to facilitate our work).
2285 * setup.py : bug fix in code. Modifications made while the last commit
2286 of JPR. The code hasn't been tested before the commit... it's so
2287 useless to make that (for best programmer that is JPR) !!!
2289 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * tagged the current version as Version0_3 (i.e. version 0.3)
2292 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2293 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2294 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2295 * *.dsp : modifications to use new libgdcmijpeg8 library
2296 * setup.py : bug fix on VTKPATH variable
2297 * PACKAGER : adding all concerning windows
2299 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2302 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2303 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2304 test suite reported error.
2305 * PACKAGER file added (describes what a packager must do when
2306 packaging a new release).
2307 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2308 * configure.in: upgraded version number to 0.3.0
2309 * fixing build of rpm (through rpm -ta):
2310 - Doc/Makefile.am exports proper doxygen files
2311 - src/jpeg/libijg8/Makefile.am exports the include files.
2313 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2314 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2315 * src/gdcmHeader.h : formatting code
2317 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2318 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2319 We were obtaining error message from vtk. Now, creation of file list
2320 is made in an internal list to prevent this problem.
2321 Bug fix when output is empty.
2322 Bug fix in update of progress value. Previous commit for this was a bad
2324 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2326 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2327 * src/gdcmHeader.h : added method to get the file name
2328 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2329 files. Added method to remove all files on the input
2330 Added FIXME comment concerning the bad parsing of header made by
2331 ExecuteInformation method (in ExecuteData method)
2333 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2335 when using make instal.
2336 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2337 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2339 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2340 * setup.py : adding include dir of jpeg lib to compile all sources
2341 * */Win32/*.dsp : JPR fix for windows compilation
2343 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2344 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2346 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2347 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2349 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * setup.py is again effective on un*x (takes into account the
2351 addon of the jpeg library)
2352 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2353 * Doc/Doxy* updated (includes above enhancements)
2354 * INSTALL now points to web documentation
2356 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcmHeader.h doesn't make unnecessary reference to
2359 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2361 * src/gdcm*.[cxx|h] :
2362 - to allow compilation with gcc 3.x
2363 -- clean up of STL usage (added explicit usage of std::)
2364 -- small fixes on exceptions.
2365 Note: linking not tested !
2366 - clean of doxygen comments to avoid warnings at documentation
2368 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2369 dependent convertion).
2371 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * Clean up of previous JPR garbage commit (not even commented in the
2374 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2375 - moved all jpeg related files from src to src/jpeg/libijg8, with
2376 addition/modification of Makefile.am and configure.in.
2377 - the testSuite is still brain damage (not guilty).
2379 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2380 * WrapVTK.py : modifications to get correctly vtk source files to
2382 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2383 (FileName -> Filename)
2385 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * vtk/vtkGdcmReader.[cxx/h]:
2387 - UpdateProgress method should now be effective
2388 - removed the limitation on having only images loaded (as opposed
2390 - when building a stack of images/volume, a lesser number of
2391 gdcmHeader and gdcmFile instances should be used (hopefully
2392 accelerating things).
2393 - when building a stack of images/volumes, files which are not
2394 loadable (wrong path-filename, wrong permissions on existing file,
2395 or file not parsable by gdcm) are replaced with a black image
2396 in the stack (for the caller to notice the problem).
2398 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2401 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2402 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2403 between standard library (std) and vtk library (problems are found
2404 under Windows... thanks Windows !)
2406 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2409 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2411 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2412 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2414 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * When compiling with distutils (see setup.py) the C++ compiler is
2416 called with different flags than the default ones (with automake).
2417 In order to fix all those warning, I compiled gdcm with the command
2418 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2419 and went for warning fixes:
2420 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2421 up from unused variables.
2422 - vtk/vtkGdcmReader.cxx: potential bug fix.
2423 * src/gdcmHeader.h: Doxygen warning cleanup
2425 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * gdcmPython/gdcm.i:
2427 - typemaps correction to take into account the systematic replacement
2428 of "using namespace std" with std:: prefix e.g. std::list,
2429 std::string... (cf changes of 2003-05-21).
2430 - gdcmGlob global variable of type gdcmGlobal (defined in
2431 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2432 exported to Python a as cvar.
2433 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2434 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2435 gdcmDictSet.GetPubDictTagNames() and
2436 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2437 C++ static methods).
2438 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2439 with the above changes.
2441 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2442 * setup.py, manifest.in : bug fix under linux
2444 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2445 * Modification of setup.py to compile vtk part too. Then, we have 2
2446 wrappers which must work with same distutils. For that, we have a
2447 generic distutils in distusiltsWrapping.py ; with :
2448 - build_extWrap class to wrap generically all extensions,
2449 - ExtensionWrap base class for all wrapping extension that contains
2451 - Wrapper interface which wrap sources
2452 + In WrapSwig.py we have extension and wrapper for Swig
2453 + In WrapVTK.py we have extension and wrapper for VTK
2454 * MANIFEST.in : modifications to consider vtk directory and new python
2455 files for compilation
2457 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2458 * Added python wrappers of vtkGdcmReader vtk class (see the
2459 source in vtk/vtkGdcmReader.cxx) :
2460 - vtk/Makefile.am now builds a library
2461 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2462 python library (as opposed to _gdcm.so wich are the python
2463 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2464 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2466 - configure.in has an additional flag --enable-vtk that needs
2467 to be set to enable compilation of vtk related code, that is:
2468 + vtk/vtkGdcmReader.so and
2469 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2470 + gdcmPython/vtkgdcmPython.so (see above)
2471 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2472 be read when compressed or when HighBit + 1 != BitsStored),
2473 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2474 the usage of the python wrapper of vtkGdcmReader vtk class.
2475 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2476 * src/*.[h] all occurences of stl classes are now prefixed with
2477 std::, and all occurences of "using namespace std;" where removed.
2478 This is to avoid pollution of global namespace in included files.
2479 Apparently vtk does not avoid this pitfall: when using both
2480 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2481 collision of various stl members (principally cout...).
2482 * gdcmPython/testSuite.py now cleanly removes temprory generated
2484 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2485 comply with above changes)
2487 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2488 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2489 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2490 vtk data structure (an image Flip was required).
2491 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2492 * cosmetic changes in documentation.
2494 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2495 * src/gdcmHeader.cxx: the constructor no longer exits when an
2496 unexisting file is given as argument.
2497 * The subdirectory Data (containing all the images used for the
2498 test suite) is not part of this repository anymore. A new module
2499 containing those images is now available at
2500 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2501 with the name gdcmData.
2502 All the python scripts (including the package initialisation file
2503 gdcmPython/__init__.py) were adapated to take this change into
2504 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2506 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2507 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2508 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2509 demo of the usage of this class.
2510 Compilation of this vtk part is only done when using the --enable-vtk
2511 at configure (or autogen.sh) stage.
2513 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2514 * More memory link related corrections and documentation fixes.
2516 - maximum info is obtained with a command of the form:
2517 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2518 --show-reachable=yes PrintHeader
2519 - the remaining reachable blocks seem to come from the STL
2520 allocation scheme through the usage of map and list. It looks
2521 like this memory cannot be freed but it is not a memory leak
2522 (in fact further invocation to the STL would recollect the
2523 unused memory allthough it cannot explicitely be freed).
2524 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2525 of displaying an image parsed with gdcm and displayed with VTK.
2526 Note: some images don't seem to work e.g.
2527 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2528 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2529 Allthough this weakens the semantics, it is a ditch attempt to
2530 make gdcm more thread friendly.
2532 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2533 * Memory link hunt (by using valgrind through the command
2534 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2535 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2536 gdcmHeader::_dicom_vr.
2537 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2538 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2540 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2542 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2543 * src/Makefile.am now exports all the necessary include files at
2547 * UpdateGroupLength replaced by new one
2550 * UpdateGroupLength re-written using H-Table
2551 (named UpdateGroupLengthNew untill checks are over)
2553 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2554 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2555 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2557 - gdcmHeader::GetPubElValSet removed.
2558 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2559 UpdateGroupLength, WriteElements, Write.
2560 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2561 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2562 carried the same semantics.
2563 - src/gdcmHeaderIdo.cxx changed accordingly.
2564 - gdcmFile::WriteBase now regroups all the codes from previous
2565 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2566 - enum FileType moved to gdcmCommon.h
2567 * src/gdcmHeader.cxx AddDefault trashed
2568 * gdcmGetXSize added
2569 * getimageDataSize now calls gdcmGetXSize
2570 * Test/*.cxx changed to agree with above changes
2572 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2574 (to avoid double call by end user).
2575 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2576 by end user, since gdcmHeader::gdcmHeader now handles it.
2578 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * gdcm/Doc many doxygen changes:
2580 - Doxyfile now has two different versions, DoxyfileUsers that generates
2581 the html.users end users oriented documentation and
2582 DoxyfileDeveloppers that generates the html.developper developper
2583 oriented documentation.
2584 - README changed accordingly
2585 - requirement.txt removed (old design info moved to TODO).
2586 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2587 DoxyMainPage.txt, DoxyPython.txt provide more information.
2588 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2589 be updated by simply regenerating the docs with doxygen and copying
2590 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2591 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2592 all the tests in the form "if (<map>.count() >1)" were removed.
2593 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2594 ill-formed documentation sections.
2595 * src/gdcmHeader.cxx: ditto
2597 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * setup.py fixed for un*x (needed macro for stdint.h)
2599 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2600 un*ces with sh-utils test utility.
2601 * gdcmPython/demo/test.py renamed to PrintHeader.py
2602 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2603 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2604 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2605 * src/gdcm*.cxx JPR's bad inclusion fixed.
2607 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2609 * gdcmPython/demo/test.py changed accordingly.
2611 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * gdcmPython/Makefile.am fixed linking against libstdc++
2613 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2614 * Swig subdir (historical tests of swig version 1.3.17++) removed
2615 * Test/testChangeEntete.cxx some lines commented out in order to make
2617 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2618 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2620 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2621 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2622 hence the user doesn't need this explicit call.
2623 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2624 i.e. LoadElements() call removed.
2625 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2626 - src/Makefile.am declares the proper flag for g++.
2627 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2628 for adding user defined new tags.
2629 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2630 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2631 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2633 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2634 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2635 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2636 src/Makefile.am : the project should properly compile and install
2637 with the autotools, included the python wrappers part.
2638 * gdcm.spec.in : added a spec file for RPM packaging.
2640 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2641 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2643 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2644 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2645 to exported to the environement (see gdcmPython/testSuite.py
2647 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2648 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2649 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2650 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2651 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2653 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * gdcmPython/__init__.py doesn't crash anymore when running in
2655 in InstallMode or PreInstallMode but with an environement given
2656 value of GDCM_DICT_PATH.
2657 * src/gdcmDictSet.[cxx/h] coding style.
2659 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2661 * src/gdcm.h general comments moved to TODO, and README
2662 * src/gdcm.h should now be seen as a user commodity (including it
2663 should suffice to fully use gdcm). It is nowhere including within
2664 any of the kernel files src/*.cxx and src/*.h.
2666 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2668 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2670 * src/gdcm*.cxx only include their corresponding include file
2671 (as opposed to gdcm.h)
2672 * gdcmPython/gdcm.i changed accordingly
2673 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2674 the autogen.sh generated "make snapshot" command to work.
2675 * autogen.sh removed history related references to crea package.
2677 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * distutilsSwigCPlusPlus.py work around some swig portability
2681 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2683 was done in a last ditch attempt to get setup.py _really_
2684 operationnal. The python/gdcmPython layaout add the advantage
2685 of hidding away the python related distutils specific files
2686 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2687 Alas, the src directory was out of scope (i.e. it's relative
2688 position to setup.py was ../src) which made things impossible to
2689 handle (see previous version of python/setup.py). Crossing fingers...
2691 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * python/setup.py now works on Un*x. (harder than I thougth)
2693 * python/distutilsSwigCPlusPlus.py can now have include files
2694 among the list of sources.
2696 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2697 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2698 * modifications in MSVC projects
2700 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * As stated by the first lines of Test/ExceptionAndPython/README, it
2702 looks like we can move back to original usage of exception within
2703 src/gdcm* and hence remove the errno stuff that was introduced
2704 as a quick and dirty fixture of this problem (added to the TODO).
2705 * Doc/Doxyfile configuration file for Doxygen and corresponding
2706 README file for usage added.
2707 * Test/testWrite.cxx added. This new test comes from a split of
2708 test.cxx that is now reverted to its original purpous i.e.
2709 testing the proper parsing of a Dicom related file.
2710 testWrite.cxx concentrates on testing the IO part of gdcm.
2711 * Test/bug1.cxx (containing a bug on WIn32) added.
2712 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2713 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2714 whose purpose is to publish the content of the TagNames of the
2715 Dicom public dictionnary were not accessible without an
2716 instance of class gdcmHeader.
2717 - those methods are now static methods of gdcmDictSet and hence
2718 require no instances at all to be invocated.
2719 - within gdcmDictSet this change required to change some method
2720 to class methods (i.e. are now static) among which SetDictPath
2721 (renamed to BuildDictPath) and LoadDefaultPubDict.
2722 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2723 the above changes by calling the new method classes of gdcmDictSet.
2724 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2725 the above to be effective.
2726 * python/gdcmPython: in order to wrap properly the above changes
2727 for Python, swig version now needs to be > 1.3.17.
2728 * python/gdcmPython/Makefile fixed to adapt itself to new
2729 configure/make shema introduced by Johan Montagnat (thanks for the
2730 contribution). Alas this Makefile cannot be turned into a proper
2731 Makefile.am without some heavy changes in the configure.in
2732 (for python dectection).
2733 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2734 now avoids publishing the empty entries.
2736 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2737 * python/setup.py : bug fix concerning install under windows
2738 ExtraPath reused :-P
2739 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2741 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * Dicts/dicomV3.dic : remove double spaces !!!
2743 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2744 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2747 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2749 method. Doxygenation.
2750 * src/gdcm.h clean up of JPR spurious comments.
2752 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * python/distutilsSwigCPlusPlus.py now properly collects the
2754 shadow classes generated by "swig -c++" (gdcm.py in our case)
2755 when using "python setup.py install".
2756 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2757 reexports the working classes.
2758 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2759 by the classical C errno scheme. This is to prevent an obscure
2760 behavior of the python wrappers when importing wxPython.wx prior
2761 to gdcmPython (which ended up in an abort call). An illustration
2762 of this oddity can be found in the Test/ExceptionAndPython
2763 subdir (see the README file). This problem probably due to
2764 an combination of g++ and dynamic loading.
2765 * added Test/ExceptionAndPython (see above)
2767 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * Changed the layout of the python part to avoid bloating main
2769 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2770 i.e. the distutils arsenal. All the python related stuff is
2771 again in a python subdir, but the package itself is now in
2773 * setup.py was cleaned up:
2774 - pythonIncludePath removed
2775 - python setup.py bdist target is now functional.
2776 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2777 collision with other packages). gdcmPython/demo/*.py changed
2780 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * python subdir moved to gdcmPython (preparation of distutils packaging).
2782 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2783 distutils installer is operational.
2784 * - gdcmPython/__init__.py now properly loads the swig generated
2785 shadow classes (from gdcm.py).
2786 - gdcmPython/demo/*.py changed to import the package gdcmPython
2787 instead of gdcmPython/demo/load.py.
2788 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2790 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2792 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2793 entries within the associated public Dicom dictionary resp. the same
2794 information but sorted by the fourth field (PAT, IMG, DIR) of the
2796 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2797 are now in the "???" group.
2798 - python/gdcm.i changed accordingly,
2799 - python/demo/printGroupedPublicDict.py added, that gives an example
2800 of the above new functionalities in Python.
2802 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * src/gdcm.h, gdcmHeader.cxx:
2804 - historic references to glib's g_malloc and g_free (#defined)
2805 were definitively removed.
2806 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2807 * src/gdcmElValSet.cxx:
2808 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2809 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2810 - GetElValue(string) renamed to GetElValueByName.
2811 - Added GetElementByName(string).
2812 * src/gdcmHeader.cxx: added
2813 - GetPubElValRepByNumber(guint16, guint16)
2814 - GetPubElValRepByName(string)
2815 - GetShaElValRepByNumber(guint16, guint16)
2816 - GetShaElValRepByName(string)
2817 - GetShaElValByNumber(guint16, guint16)
2818 - GetShaElValRepByName(string)
2819 - GetElValRepByNumber(guint16, guint16)
2820 - GetElValRepByName(string)
2821 - GetElValByNumber(guint16, guint16)
2822 - GetElValRepByName(string)
2823 * Doc/requirements.txt added.
2825 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * Test/Makefile building now depends on the one of libgdcm.so
2827 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2828 pixel data) aware which enables finding the address (offset) of
2829 the pixel data of JPEG encoded DICOM files. This leaves only a single
2830 file in the testSuite whose pixel data address (offset) is unknown.
2831 * python/testSuite.py changed accordingly.
2833 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2834 * VC++ has some strong limitations when working with the STL, as stated
2835 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2836 "Also note that some STL containers (map, set, queue, list, deque)
2837 cannot be exported. [...]
2838 Some STL classes contain nested classes. These classes can not
2840 This is caused by a designed limitation that once a template
2841 class is instantiated, it can not be re-instantiated and
2843 Since our usage of map<> is ubiquitous in gdcm, this "designed
2844 limitation" of VC++ is a pitfall.
2845 Hence the Python wrappers of gdcm cannot be incrementally linked
2846 against the c++ dynamic library. The dirty but only workaround is
2847 to forget about incremental link of dynamic libraries and to generate
2848 the Python wrappers library with the inclusions of the underlying C++
2850 The following modifications concern this matter on Win32/VC++:
2851 - wrapping python correct with standalone wrapped dll (don't use separate
2852 dll under windows !!!!)
2853 - python21_d debug mode enabled (ask Frog how to use it :-)
2854 - NO problem with having an STL member of class for example string in C++
2855 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2856 - Python test of dcmlib in Python is ok under windows on a large set
2858 * removed glib references
2859 * typedef's inserted in gdcm.i for correct swig type management
2861 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2862 * python/demo/*.py load.py extracted from test.py. Added explore.py
2863 that only displays required tags and testAll.py that parses all
2864 the files of the testsuite without using unittest.
2865 * python/testSuite.py other additional test on new files added.
2866 * Data/* new test files added accordingly to the testSuite.
2867 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2868 the vr in the file differs from the one of the dictionary.
2870 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2871 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2872 values, but limits itself to values which are below a user specified
2873 size (by default 1024 bytes).
2874 * python/gdcm.i : elements not loaded (because their size is above the
2875 user specified treshold) are exported with their TagKey as key of the
2876 python dictionary. This enables the testsuite to make some checks
2877 on the unloaded elements (since we have their offset and size).
2878 * python/testSuite.py
2879 - now tests for the existence and proper value of the pixel data
2880 - two new examples added.
2881 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2883 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2885 aware. See the strategy comments in gdcmHeader::FindeLength().
2886 * Test/test.cxx now accepts a filename as first argument.
2887 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2888 * python/testSuite.py changed to integrate test on above files.
2890 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2891 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2892 the vr was also RET.
2893 * python/testSuite.py more tests added.
2895 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * python/testSuite.py unittest test suite added (uses Data)
2897 * Data/* dcm and acr files for the test suite.
2898 * glib dependance removed from un*x version. We now use ISO C99
2899 7.18 Integer types (see stdint.h)
2900 - python/Makefile, src/Makefile src/gdcm.h
2901 * src/ when an explicit vr (like dicom files) suddenly poped an
2902 implicit element we use to mark the underlying DictEntry of the
2903 concerned ElValue with "Implicit". This strategy was damageable
2904 too the public or provite dictionaries, since some of their vr
2905 would be changed. Since Header::FindLength heavily relies on the
2906 detection by Header::FindVR of falsely explicit elements, I
2907 added an extra ImplicitVr member to ElValue (boolean).
2908 The rest of the changes we the necessary adaptations.
2910 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2913 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2915 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * Adaptation for porting to VC++:
2918 o forced to use std namespace (for string to be known)
2919 o all class use __declspec export style on WIN32
2920 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2921 (in stdlib.h on Win32 but in std:: for gcc)
2922 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2923 variable GDCM_DICT_PATH.
2924 * src/gdcmHeader.cxx verbose comments made discrete.
2926 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2927 * python/gdcm.i: added a typemap that converts a C++ hashing table
2928 to native Python dictionary.
2929 * python/demo/test.py:
2930 - now uses the native dictionary for exploration of gdcmHeader.
2931 - takes an optional filename argument (the file to parse).
2932 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2933 PubElVals hashing table.
2934 * Dicts/dicomV3.dic removed error prone trailing spaces.
2936 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2937 * Python wrapping process moved away from src/Makefile to
2938 newly created python/Makefile (as well as gdcm.i)
2939 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2940 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2941 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2942 from the environement variable GDCM_DICT_PATH (when existing).
2943 * src/gdcmDict::GetTag bug fix.
2945 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2946 * Straightforward temporary fixes for swig to build the python wrappers.
2947 src/Makefile now has a python working entry [by working we mean
2948 that we can import de shadow classes without errors].
2950 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * hashtest.cxx removed (since allready in Test)
2952 * src/gdcmlib.h renamed to src/gdcm.h
2953 * src/dcm.i renamed to src/gdcm.i
2954 * src/Makefile prepared for python wrapping
2956 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2957 * src/gdcmHeader.cxx :
2958 - Parsing of header is now separated from loading of element values
2959 (see gdcmHeader::LoadElements).
2960 - general clean up of hopefully all file access (creation of
2961 ReadInt16 and ReadInt32)
2963 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * src/gdcmHeader.cxx :
2965 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2967 - SetLgrElem renamed to SetLength
2968 - GetLgrElem renamed to GetLength
2969 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2970 * src/gdcmElValSet.cxx fixed both GetElValue methods
2971 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2972 due to IdoDude was cleaned out.
2974 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2976 concentrates on finding the value representation (when it exists).
2977 RecupLgr now only finds the element value length, and it avoids
2978 returning the unecessary skL (skipped length).
2979 Also, offsetCourant was simply removed (with taille_fich) since
2980 it was redundant with the File position internals (by using
2981 ftell and fseek). This also made skL (see above in RecupLgr) usage
2983 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2984 on the libido specificities which are handled through class
2986 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2989 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2990 * Truckload of changes. Parsing of header is barely functional
2991 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2993 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2994 * src/gdcmHeader.cxx many addons of low level methods
2996 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2998 and _IdDcmSWAP_LONG.
3000 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3001 * This corresponds to all the changes decided at the meeting of
3002 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob