1 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
3 use with python. Some methods ard moved from Document to ElementSet or
4 DocEntrySet. The equivalent methods to ElementSet have been added to
5 SQItem and are virtual in DocEntrySet. Methods that may have the same code
6 in SQItem and ElementSet is directly placed in DocEntrySet
8 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Test/VTKTest*.cxx : remove the show variable in each test method because
10 it's useless (the viewer variable replace this variable)
12 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmDocument.cxx : bug fix on potential memory leak
14 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
15 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
16 Add ClearXxx methods to remove all the content of the list or map
17 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
19 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
20 * Grealty simplify the JPEg decompression, no need to differenciate based on
21 the JPEG possible type (with/without fragment, with/without multiple frame).
22 Everything is done throught the JPEG IO Suspension mechanism in IJG
24 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
26 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
27 with other method names
28 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
29 * Test/TestDicomDirElement.cxx : add new test
31 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
33 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
34 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
35 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
36 So can't you use __int64 in ostream at all.
38 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * bug fix for compilation on MSVC6
40 * gdcmPython/gdcm.i : rename of classes missed
42 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
44 type and not a string. So, there remove problems on the format of the
47 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
49 Thus, DicomDirXXX are created with a flad that indicates if the created
50 object is empty or not (when not empty, the DicomDirElement is used to
53 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
55 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
57 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
60 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
62 Remove all access to the hash-tables or lists in the objects.
64 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
66 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
67 be complient with all the gdcm source code
69 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
73 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
77 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * Test/ : rename VTK tests to have a best name for the tests
79 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
80 GetFirstEntry/GetNextEntry use
82 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
84 test. Now it's on image content and not on the resulting visualisation...
85 might solve the problem on linux when using the OpenGL drivers
87 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
88 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
89 DicomDirSerie, DicomDirImage
90 Dict, DictSet classes :
91 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
92 -remove InitTraversal method.
93 * UPD Test programs + Example programs
95 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
96 remove useless and never updated keyword \ingroup
98 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
100 is no memory access violation
101 * gdcmPython/demo : add python demos using VTK
103 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
104 * FIX 'Dictionnary' is now spelt 'Dictionary'
105 'wether' is now spelt 'whether'
106 'archieve' is now spelt 'archive' ;-)
108 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
109 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
110 related methods, in order not to expose internal mechanisms
113 * REM methods that exposed internal mechanisms :
114 DicomDir::GetDicomDirPatients()
115 DicomDirPatient::GetDicomDirStudies()
116 DicomDirStudy::GetDicomDirSeries()
117 DicomDirSerie::GetDicomDirImages()
118 * UPD Test programs :
122 * UPD Example program
124 * ADD DictSet methods
128 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
129 * Removed the Print/indent/default parameter mess. There is absolutely no
130 reason to have to methods, moreover with the second taking the ostream as
131 *SECOND* parameter. This was clearly a bad hack to get things compile.
133 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
134 * Complete rewrite of the GetMacAddress code. Now the code is *much*
135 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
136 Unfortunately the main code does not work on SunOS, thus provide a specific
137 code for this platform only (and Win32 of course). Since this seems to be
138 working, change CreateUniqueUID to use GetMACAddress instead of the
139 problematic GctestetIPAddress
141 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
142 * Unfortunately to be able to test gdcmDirList I had to break the API
143 a little. Now the class is not a std::list anymore but has a member
144 std::vector (more ITK compatible). Allow unit testing on Win32 and
147 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
148 * Update SerieHeader to take into account a Serie Instance UID to properly
151 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
152 * ENH - Comment out Mathieu's (dangerous) Super Hack
153 for dealing with BIGENDIAN processors
154 - Move equivalent stuff to BinEntry::WriteContent
155 When necessary, 16 Bits Pixels are swapped in a small buffer
156 and then written. This avoid allocating a huge buffer, in
157 PixelWriteConvertor, and avoid modifying the Pixel Area.
159 Probabely, the same operation will have to be done when we want
160 to write image with Big Endian Transfert Syntax,
161 and we are working on Little Endian Processor
163 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
166 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
167 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
168 all the dict content.
169 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
171 * Test/TestDict.cxx : add a new test for the dict classes
173 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
174 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
175 file. Debug is yanked if compiled with NDEBUG
177 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmDictSet.h : set the default output to the os variable
179 * src/gdcmDictEntry.[h|cxx] : add the Print method
180 * gdcmPython/demo/ : add a new test
182 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
183 * merging of Test/PrintDicomDir and Test/TestDicomDir
184 * removal of now redundant Test/PrintDicomDir
185 * enhancement of Example/PrintDicomDir
187 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * Now, python test might work on systems
189 * Add the PrintDicomDir test
191 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
192 * FIX : First entry following group 0002 was lost for
193 Explicit Big Endian Transfer Syntax files
194 (group and elem not swaped)
196 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
197 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
198 Big Endian Transfer Syntax supposed the group following 0002
199 begins always by element 0000 (element 0000 is *optional*)
200 To avoid further troubles, let's be pessimistic, and use
201 Document::HandleOutOfGroup0002() method
202 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
203 (related pb not yet solved)
205 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * Bug fix for the python part use
207 * Now, PrintHeader.py pass... but outside the ctest use. shit !
209 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
212 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
213 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
214 a string and should ask the global TS dict what are the propreties of
217 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
218 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
219 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
220 to swap the Swap Code, at parsing time, when we come out of group 0002
221 and Transfer Syntax is Big Endian
222 We should be able to read now 'true DICOM" Big Endian coded images
223 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
224 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
226 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
227 * Hopefully fix the bug on MacOSX and static global initialization.
228 This is the only -minor- patch I found that both please MacOSX and VS6.
229 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
230 but this would require a lot of change. Another approach would be that Global
231 create those string and GDCM_UNFOUND becomes a pointer to a string (which
232 gdcm::Global would destroy at exit).
234 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Fix bug on MacOSX with static initialization in a multy threaded
236 environment. static const string in a header file used to be ill
237 initialized provoquing the freeze of any tests. patch should solve this
240 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
241 * According to Benoit's suggestion, and without any objection from anybody
242 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
243 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
244 - method gdcmDicomDirObject::GetEntry() renamed as
245 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
247 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
248 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
249 you debug/warning message just as c++ streams which make them very convinient
250 to use. Once this is stabilize I will change the ostringstrem to be
251 redirected to a file (ofstream).
252 * Properly support C99 extension: __FUNCTION__ which allow us to display
253 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
255 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
256 * Removal of useless and dangerous methods :
257 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
258 GetDocEntryByName, GetEntryByName, GetDictEntryByName
259 * Removal of usless methods :
260 Dict::PrintByName, Dict::GetDictEntryByName
261 * Commenting out of probabely useless methods :
262 Dict::GetDictEntryNames()
263 Dict::GetDictEntryNamesByCategory()
264 DictSet::GetPubDictEntryNames()
265 DictSet::GetPubDictEntryNamesByCategory()
266 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
267 * ENH : Use dicomTS.dic as described in 2004 version
268 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
269 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
270 Add Accessors on VM (Value Multiplicity), and VM related methods
271 * ADD : Add a list of 'Dicom Attribute types', as found in
272 http://medical.nema.org/dicom/2004/04_15PU.PDF
274 * ADD : Add dicomGroupNameAbbreviations.dic
275 should be used to write a method to replace the former
276 Dict::GetDictEntryNamesByCategory()
278 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
280 to read in the file... and only it ! Length is the efective length of the
281 data in the DocEntry structure
283 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
284 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
285 And now use a static function call instead, with a global variable. i
286 This is much closer to the VTK approach. Hopefully should be bulletproof
287 and easier to use...hopefully
289 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
292 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
295 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
297 ValEntry, BinEntry, SeqEntry creation or replace
299 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
301 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
303 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
304 when specifying the VR
305 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
306 * src/gdcmDocEntry.cxx : amelioration of print
308 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
309 * ADD : Add the method Util::IsCurrentProcessorBigEndian
310 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
311 * ADD Method Document::ComputeGroupLength
312 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
313 in order to allow further VR modification by user
314 * REM : removal of once-called method File::WriteBase
315 integration of its code in formerly one-line method File::Write
317 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
318 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
319 replace the different values "??", "Unkn", "Unknown".
320 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
321 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
322 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
323 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
325 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
328 * Set the gdcm::Base class to some Printable classes
330 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmFile.[h|cxx] : add the Print method
332 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
333 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
334 * src/gdcmDocument.h : remove the PrintLevel informations
335 * Example/PrintFile.cxx : use the new gdcm::File::Print
337 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
339 problems when compiling with the python wrapping
341 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
343 writting in ImplicitVR
345 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
346 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
347 JPEG decompression, especially when dicom frames are split into several
348 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
349 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
351 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmHeader.cxx : change the initialisation of default header.
353 Now, this header is readable by gdm, e-film, DicomWorks
355 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
356 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
357 Rename Decompressed to Raw
358 * Use the API changes in gdcm::File.
359 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
362 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
364 each added entry in the header. Replace the 'Planes' field by the 'Number
367 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
369 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
371 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
373 At this time, this image isn't readable by e-film... waiting JPR help to
376 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
378 DocEntry. Now use methods of the Document !
380 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
381 * Test/ShowDicomSeq.cxx : bug fix
383 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
385 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
386 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
387 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
389 * Test/TestCopyRescaleDicom.cxx : remove unused variable
390 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
391 containing found sequences
393 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
396 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
397 Some fields in BinEntry must be copied to not seg fault when making the :
398 gdcm::File *copy = new gdcm::File( copyH );
399 and tests are now made on good variables
401 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
402 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
403 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
405 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
406 * Add vtkGdcmWriter example and test
408 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * Test/TestUtil.cxx : reformat the source code
410 * vtk/vtkGdcmReader.cxx : remove and change prints
411 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
413 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
414 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
416 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
418 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
420 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
422 by an eof to prevent all bad read of the file... and in this case, the
425 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * Example/Volume2Dicom.cxx : comment unused variables
427 * Test/PrintDicomDir.cxx : comment unused variables
428 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
429 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
430 method that is redondant with AddEntry.
431 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
434 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * Bug fix due my last commit (compilation under Windows).
436 * Example/Volume2Dicom : bug fix in the file and reformatting source code
437 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
439 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 - Remove printf / sprintf
442 - include iostream AFTER gdcm so we don't get warnings
443 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
445 - Also remove tons of include from header files, hopefully this should
446 speeup the compilation time, since it was becoming a dog slow.
447 - Remove gdcm.h as it include way too many files and slow down compilation
448 (plus it is not up to date)
449 - remove 'using namespace std' this is BAD !
451 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * Remove memory leaks on the DicomDir
453 * Remove some useless data in DicomDirObject
454 * Add usefull methods in SQItem, to be complient withe the ElementSet
456 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
459 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
461 future, with convertion)
462 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
463 and ImageDataSize values. Remove the method to get the PixelReadConverter
464 from the output of the class
466 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
467 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
469 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
471 and vtkErrorMacro use.
472 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
474 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
477 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
478 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
479 The string leaves only in the fonction. So when we make a .c_str(), we
480 get the pointeur on the first element, element that will be destroyed
481 immediately after thee instruction.
482 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
483 file has been opened : the test must be made on the content of the
484 pointer and not directly on the pointer !
487 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
488 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
489 the python part recompiles
491 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
493 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
494 X session is killed (for my computer... it seems to not be identic on
497 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
498 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
499 avoid problems (otherwise, the difference test between the visible image
500 and the reference is incorrect. If the reference is greater than the
501 screen resolution, it's produce errors).
502 Can be used for only one image. Can be used with a visible flag.
503 * vtk/vtkGdcmReader.cxx : remove commented codes.
504 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
505 under windows at compilation
506 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
508 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
510 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
512 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
513 tests on the image size X, Y, Z
515 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
517 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
518 between the class name and the file name
520 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/ : fix compilation warnings for the Write method (2 different
522 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
523 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
524 variable... create a static method in gdcm::Document to access to
525 this variable content.
527 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
529 file, to be accessed by other files (like gdcmFile). Remove commented
530 code. Move the change of the header to the gdcmFile, using the
532 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
533 To be sure of that (and simplify calls), the Write of the header now
534 gets a file name and not a file pointer (std::ifstream).
535 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
536 DocEntryArchive. Remove all open of the written file
538 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
539 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
541 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
543 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
545 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
546 some corresponding methods. Write correctly the file and check before
548 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
549 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
550 is now on RGB data (as before my last commit
551 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
553 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
554 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
555 Add a print information of the type of the entry
556 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
557 It was in the gdcmFile, and all write have been regrouped
558 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
559 Write correctly all dicom files (in decompressed mode only at this time)
560 * Test/ : test on files are now made using Raw data and not color data if
562 * Example/PrintFile.cxx : add more printings
564 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * Amelioration of code, remove some code copy. For the loading of
566 BinEntry (in gdcmDocument), add the test to verify if the file is already
569 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
571 remove a DocEntry in the header (push an empty DocEntry)
572 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
573 lines. Bug fix in the initialization of the PixelConvert and the
575 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
576 use in TestCopyDicom (now this test can run under windows... but fails)
577 * Test/TestCopyDicom.cxx : amelioration of the test :
578 - test the pixels written
579 - add test points to quickly find where is the error
580 - can set a file name input and output in arguments
581 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
582 amelioration of the test output
584 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
586 all replaced DocEntry's
587 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
588 Now, each needed DocEntry to modify is duplicated, modified and inserted
589 to the header using DocEntryArchive. Thus, after save, we can restore the
590 header initial state.
592 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
593 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
595 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
597 correct to copy it. The DictEntry is specified at the DocEntry creation,
598 then, it musn't change in the time.
599 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
600 header correctly. At this time, the change is only made for the first
601 level of the Document. In the future, it might consider sequences.
602 The change is made by replacing a DocEntry by an other that is created
603 outside the class. The old value is kept. When we restore the header
604 status, the added DocEntry is deleted and replaced by the old value.
605 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
606 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
607 set the write type to explicit VR, implicit VR or ACR. Add methods to set
608 the write mode to native, decompressed or RGB (but not used at this time)
610 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
612 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
614 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
616 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
618 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
619 set because already copied when copying the BinEntry's of the header
620 * Test/TestAllReadCompareDicom.cxx : remove warnings
622 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
624 Two problems appear when doing it :
625 - with the gdcmFile : when the GetImageData method is called, the pixels
626 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
627 data (pixels). And each structure destruct the data when it's
628 destructed. So we have two destructions for the same data. To solve it,
629 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
630 data or not. If it doesn't own data, then they will not destroyed by
632 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
633 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
634 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
635 create a double destruction of the same DocEntry's. So, to solve it,
636 the TagHT is simply cleared and the DicomDir* elements are destroyed.
637 * TODO : add an entry concerning memory leaks in the DicomDir
639 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
641 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
644 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
646 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
647 after it have been deleted
649 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * FIX: src/* fix the doxygen warnings.
651 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
652 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
653 was erroneously defined with a size of 15 instead of 16. [many thanks
654 to Jean Michel Rouet for pointing out this bug].
656 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
657 1. Finish merging JMR patch for writting DICOM from scratch
658 2. Fix -hopefully- bug with MONOCHROME and space vs null character
659 3. Use const ref when possible
660 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
661 5. A few more comments
662 6. CreateUniqueUID can now be called without parameter"
664 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
665 * ENH: Slightly bigger patch:
666 1. Getting toward full integration of JMR patch for writting dicom from scratch
667 2. Update Test to test part of this patch: CreateUniqueUID
668 3. File was not close properly in gdcmDict
669 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
670 5. Use of const ref instead of copy (speed issue)
671 6. Remove temporary (duplicate) string in TranslateToKey
672 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
673 8. Do not repeat virtual in subclasses
674 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
676 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
677 * Apply first patch toward better string comparison when dealing with broken
678 DICOM files. Essentially the string could be padded with a space instead
679 of a null character as defined by standard
681 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
683 because never used... and in the same time, that's remove some memory leaks
685 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * src/gdcmFile.cxx : now delete the PixelConvert instance.
687 * In examples and tests : change the type of image data variables from void*
688 to uint8_t*. Remmove all delete on image data variables
690 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
692 Verify the file pointer value before open the file, and if it's not null,
693 a verbose message is generated.
694 Close correctly the file when the file isn't considered dicom-like. The
695 correctly close is a call to CloseFile.
696 When closing the file pointer, test if its not null to close the file.
697 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
698 file. For an uncompressed image, the copied data correspond in the least
699 case to the image size (calculated) or the image size specified in the
700 header. A verbose is generated if these two size mismatch
702 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
704 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
705 break under windows (with msvc6 compilation).
707 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
709 compiling with MSVC6)
711 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * Bugs fix for the Windows build with VC6
713 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
714 needed (only for projects required VTK). If the VTK is included in all
715 projects, there is conflicts with the jpeg lib of vtk when compiling the
716 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
717 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
718 when compiling the gdcm_wrap.cxx file (created by the compilation of the
720 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
721 (like it's already made for the cout use). Otherwise, conflict with the
724 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
727 - comments on the DicomDir::Method related usage added.
728 - now that we use the namespace gdcm, a lot of internal classes do
729 NOT need to be wrapped anymore.
730 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
731 DicomDir::Method) new example added.
733 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * Improve string manipulation. I now inforce the notion of 'DicomString'
735 A DicomString can contain as many \0 as they want
736 and it is *always* of even length.
737 We only support odd length for very rare case.
738 And in the near future this should be removed.
740 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
741 * /binary_write/ gdcm source. Now even on big endian we are writting
742 little endian. This should -heopfully- fix some tests
744 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
745 * Now the dictionary is compiled into gdcm lib. This is a default
746 behavior, thus any dic file specified is picked before failback to
747 the one comiled into lib
749 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
750 * Change internals for gdcmDict. Don't use any 'new' any more.
751 This should definitely solve any leak problem, and we should be
752 as fast as before, as long as don't modify too much the dictionary.
754 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
755 * STYLE: ivars should start with a capital letter.
756 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
757 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
759 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
761 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
762 new 2004 dictionaries added (thanks to JPR).
763 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
764 * CLEANUP_ROUND (15) for gdcmPixelConvert
765 - RLEFrame::NumberFragments is now of type unsigned int
766 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
767 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
770 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
771 * Initial work in gathering all transfer syntax accessors. clearly
772 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
773 ivars, but only one transfersyntax (class) ivar with equivalent method on
776 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
778 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
779 discussed (plus I didn't like having a 2000 lines patch not commited)
781 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
783 * CLEANUP_ROUND (14) for gdcmPixelConvert
784 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
785 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
786 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
788 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
789 anymore and hence avoids storing a copy of PixelConvert::Decompressed
790 into File::Pixel_Data.
792 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
794 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
795 * CLEANUP_ROUND (13) for gdcmPixelConvert
796 Substituted File::ParsePixelData() with PixelConvert::Print() new
798 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
799 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
800 method to those classes.
801 - src/gdcmFile.[cxx|h]:
802 -- Added a ::Print() method.
803 -- PixelConverter is now a reference instead of a member.
804 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
805 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
807 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
809 collaboration diagram and inheritance diagram should be generated with
811 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
812 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
813 pointlessly wrapped (see
814 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
815 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
816 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
817 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
818 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
819 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
820 -- File::Initialise: PixelConverter setup moved away to
821 PixelConverter::GrabInformationsFromHeader()
822 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
823 interpretation moved away to PixelConverter::BuildRGBImage()
825 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
826 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
827 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
829 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
831 displayed on Win32 when a brutal abort() occurs (because of uncatched
832 exception). See TODO new entry of this commit for more on this.
833 * TODO added new entry.
834 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
835 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
836 - HandleColor is no longer called from gdcmFile.cxx
837 - gdcmPixelConvert.cxx clean up on method arguments and internal
838 variable names for semantical coherence.
840 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
841 * Finished lossless transition, not only do we now read all lossless jpeg
842 images, without the need of the Cornwell lib, but we do read them properly now
843 * To reduce code (well to avoid code duplication), I defined a common place
844 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
845 redefine symbols. This is not perfect but this the best solution I found for a
846 compilation time jpeg option.
848 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
849 * Update jpeg ijg lib to support lossless jpeg implementation
850 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
852 * Also added a special copyright for dcmtk since we use their bugfixes.
855 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
857 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
858 matters, as stated in warning note at begining of %include section).
859 * src/gdcmDicomDir*.[cxx|h]: coding style
860 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
861 * src/gdcmJpeg8.cxx: doxygen fix.
862 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
863 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
864 from File:: to PixelConvert::.
866 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
868 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
869 - more code moved away from File:: to PixelConvert::
870 - fat setup of PixelConverter set in place in File::Initialise.
872 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
873 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
874 namespace at the file system level. So now you should convert your examples
876 gdcmHeader -> gdcm::Header
877 It would be nice if people keep in mind to no open the namespace, since it
878 allows compilation on broken plateform which were defining common symbol in
879 the standart namespace (like LP, Unknown ...)
881 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
883 The JPEG fragments are now parsed at the same stage than the RLE
884 information. All code related to JPEG is now in gdcmPixelConvert:
885 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
886 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
887 export a gdcmFile:: method. Those are simply global functions
888 (for the time being this is better than having them attach to
889 either gdcmFile:: or gdcmPixelConvert::).
890 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
891 and stores the result in a gdcmJPEGFragmentsInfo.
892 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
893 code (among other stuff) moved away from gdcmFile:; to
896 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
898 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
899 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
900 clean up of RLE related code.
901 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
902 - src/gdcmRLE.cxx removed
903 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
904 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
905 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
906 * CLEANUP_ROUND (9) for gdcmPixelConvert
907 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
908 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
909 away from gdcmFile:: to gdcmPixelConvert::.
911 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
912 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
913 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
914 This is because Parse7Fe0 used to parse the pixels to compute the
915 length. This task was passed over to FindDocEntryLengthOB() a long
916 time ago, EXCEPT I had forgotten the OW case...
917 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
918 we just recylce the code for parsing RLE fragments and computing
920 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
921 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
922 with the retired Parse7Fe0().
923 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
924 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
926 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
927 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
928 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
929 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
930 - src/CMakeLists.txt: alphabetic order reodering + new entries.
931 * CLEANUP_ROUND (4) for gdcmPixelConvert
932 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
933 to return an unused length.
935 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
937 this should be cleanner from the plane view. The iostream are erally a pain
938 to use to do simple stuff.
940 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * Redo the compilation of the ijg jpeg library. Now only one source is
942 necesseray. No need to rename file by hand what so ever. CMake handle the
943 copying of the file within different directory, configure header file to
944 modify some symbol. The only addition made to ijg wasd a mangle table so
945 that symbol are different whether we are within 8bits or 12bits.
947 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Added documentation of vtkgdcmReader on Website:
949 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
950 with it's binary name).
951 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
952 the Website to be more complete.
953 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
954 doxygenated documentation.
955 - Doc/DoxyVtkGdcmReaderExamples.txt added
956 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
957 DoxyVtkGdmReaderExamples.html )
958 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
959 * CLEANUP_ROUND (3) for gdcmPixelConvert
960 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
962 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * CLEANUP_ROUND (2) for gdcmPixelConvert
964 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
966 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * CLEANUP_ROUND for gdcmPixelConvert:
968 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
969 - src/gdcmPixelStuff[h|cxx] removed
970 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
971 - src/CMakeLists.txt changed accordingly
973 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
974 gdcmVersion.py moved to newly created ATTIC related
975 gdcmPython/SetupOldies/ directory.
976 * Autotools clean up:
977 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
978 - autogen.sh configure.in acinclude.m4 python.m4 removed
980 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/*.cxx *.h Reference to License.htm fixed to License.html.
982 * Doc/CMakeLists.txt, doxygen.config.in: fix.
983 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
985 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * TODO updated with Mathieu suggestions. I proposed a template for
987 describing TODO entries and used it for new entries.
988 * Added Doc/Website/CodingStyle.html, Developpers.html,
989 DeveloppersPython.html, GdcmDataCvs.html and
990 DownloadVersion0_1.html, DownloadVersion0_3.html.
991 * Some Doc/*.txt Doxygen files (which do not really concern the
992 documentation itself, but the website) moved to html and
993 placed in directory Doc/Website:
994 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
995 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
996 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
997 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
998 * CMakeLists.txt changed accordingly.
999 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1000 DeveloppersPython.html
1001 * INSTALL nows refers to Doc/Website/Installation.html
1003 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Added Doc/Website directory, that contains a first raw version
1007 2004-09-23 Jean-Pierre Roux
1008 * FIX In order not to be poluted any longer by casting problems,
1009 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1010 we can now delete[] it safely
1011 * VoidArea is now called BinArea (less confusing name),
1012 and all the methods called ...VoidArea... are now ... BinArea...
1013 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1015 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1017 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1018 up to the destructor of gdcmElementSet to clean up TagHt and it's
1021 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1023 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1025 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * ENH: added some utility method that builds a flat dictionary
1027 holding all the Dicom entries contained in the recursive structure
1028 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1029 an example of usage.
1030 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1031 BuildFlatHashTable() that build a flat dictionary.
1032 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1033 gdcmDocument is now a friend of gdcmElementSet.
1034 - src/gdcmElementSet.cxx: clean up.
1035 - Example/FlatHashTablePrint.cxx added.
1036 - Example/CmakeLists.txt changed accordingly
1038 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1039 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1040 moved away from gdcmDocEntrySet (since this class is an abstract class
1041 acting like an interface). SQDepthLevel and BaseTagKey are now
1043 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1044 and associated accessors. Doxygenation of the class.
1045 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1047 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1048 Use SQDepthLevel accessor instead. ::Print() adapted.
1049 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1050 - src/gdcmDocument.cxx changed accordingly.
1052 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1054 - The following is the doxygen comment of the typedef declaration
1055 of gdcmTagKey in src/gdcmCommon.h:
1056 gdcmTagKey is made to old an "universal" (as in URL, Universal
1057 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1058 A dicom tag always has a group and an element, but a set of tags
1059 embeded in various (optionally nested) sequences and sharing
1060 the same group and element all share the same (group, element)
1061 "identifier". Hence the (group, element) cannot be used as an
1062 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1063 In order to construct a proper tag identifier (i.e. a key) we
1064 consider the following definition of a TagKey:
1065 - let Group, Element be the string representation of the
1066 group and element dicom tag members,
1067 - let ItemNumber be the string representation of the integer
1068 index of the considered item number of a sequence,
1069 Let the key of a tag embeded in a sequence, noted SeqTag, be
1071 /ItemNumber#Group|Element
1072 where "/", "#" and "|" are characters acting as separators.
1073 Then the general form of a gdcmTagKey is given by:
1074 Group|Element<SeqTag>
1075 where <SeqTag> means NO or many instances of SeqTag.
1076 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1079 but the gdcmTagKey of a tag "embeded" is the first item of
1080 a sequence, itself nested in the third item of a sequence is the
1082 0004|1220/2#0008|0082/0#0008|0090
1083 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1084 order to hold the new sequence compatible key. Previously, the
1085 GetKey() method would look in the underlying gdcmDictEntry.
1086 - src/gdcmDocEntry.cxx:
1087 -- constructor now copies the underlying DictEntry key, in the local
1089 -- ::Print: displays the member Key, instead of the (group, element).
1090 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1091 - src/gdcmDocEntrySet.h:xi
1092 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1093 -- now has a new BaseTagKey member.
1095 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1096 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1098 This poses the problem with the semantics of the following lines
1099 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1100 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1101 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1102 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1103 to the long FIXME note for what the problem is. Nevertheless in
1104 order to get things working the dicom dictionary was altered !
1105 Please fix things urgently...
1106 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1107 information), see above note on moving the member VoidArea. Nevertheless
1108 the following entries previously correctly set as US are now inproperly
1110 0028 1201 OW IMG Red Palette Color Lookup Table Data
1111 0028 1202 OW IMG Green Palette Color Lookup Table Data
1112 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1113 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1114 of gdcmDocEntry moved to gdcmSeqEntry.
1115 * src/gdcmSeqEntry.cxx: STYLE.
1117 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1120 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * gdcmPython/testSuite.py: all the test suite in python is now moved
1122 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1123 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1124 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1126 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1128 to avoid inclusion recursion until STL is reached.
1129 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1130 mecanism. errno.h is not included in gdcm anymore.
1131 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1132 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1134 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1135 gdcmData/TestAllEntryVerifyReference.txt
1136 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1137 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1138 exception_on_error parameter.
1139 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1140 - vtk/vtkGdcmReader.cxx changed accordingly,
1141 - Example/*.cxx and Test/*.cxx changed accordingly.
1143 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1145 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1146 enable_sequences removed from gdcmHeader constructor and dependencies.
1147 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1148 * gdcmPython/demo/PrintHeader.py: dummy fix.
1149 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1150 skip_shadow removed from gdcmHeader constructor and dependencies.
1151 * Example/*.cxx and Test/*.cxx changed accordingly.
1153 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1155 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1157 2004-07-21 Jean-Pierre Roux
1158 * FIX Now, Parsing and Printing a DICOMDIR do work!
1159 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1161 2004-07-20 Jean-Pierre Roux
1162 * FIX Some brain damaged headers have Zero-Lenght fields
1163 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1165 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1166 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1167 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1168 variable (instance of gdcmDebug) by a definition macro, and the instance
1169 is now in static in the gdcmDebug class
1170 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1171 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1173 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1174 * WARNING: ctest now depends more tightly on gdcmData. You should
1175 check out gdcmData properly for things to run smoothly...
1176 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1177 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1178 we need the pixels not be loaded in order to use the ValEntry
1179 that displays position and size).
1180 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1181 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1182 be deprecated. If you have any doubts about the advantages of a
1183 modern scripting language (read Python) versus grass root C++ (i.e.
1184 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1185 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1186 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1187 Anyhow, consider documenting the gdcmData images in
1188 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1190 * Test/CMakeLists.txt:
1191 - now uses TestAllEntryVerify.cxx
1192 - specific comments on oldACR00001.ima (now renamed in gdcmData
1193 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1194 gdcmData/TestAllEntryVerifyReference.txt
1197 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * src/*.[h|cxx] : typedef clean up
1199 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1200 - TagKey renamed to gdcmTagKey (for external usage)
1201 - VRKey renamed to gdcmVRKey (for external usage)
1202 - removal of typedef duplication.
1203 - Removed all unecessary inline keyword from class inline definitions.
1204 - Some method|function(void) declarations replaced with method|function().
1205 * src/jpeg/libijg12/jdhuff12.c:
1206 - printf polluting ctest removed.
1207 - TAB removal for comminting
1209 - TestAllReadCompareDicom.cxx: added a test that compares all the
1210 images in gdcmDataImages.h with corresponding images in
1211 gdcmData/BaselineDicom/. When baseline images are not present
1212 this test creates them.
1213 Note: we need to validate each reference image, but before that
1214 I'd like to rename them with a more explicit name...
1215 - CMakeLists.txt: changed accordingly.
1216 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1217 including each header needed).
1219 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1221 test suite to the Example directory. Are concerned:
1226 - TestWriteSimple.cxx
1227 * Test/CMakeLists.txt: added some comments on reasons for black listing
1228 image gdcmData/oldACR00001.ima
1230 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * Test/CmakeList.txt: removed the following from black list (to be coherent
1232 with removal from gdcmData):
1233 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1234 - gdcm-MR-PHILIPS-16.dcm
1236 Added the following because after last cvs update, they cause
1237 ctest -R TestReadWriteReadCompare
1239 - gdcm-MR-SIEMENS-16-1.acr
1241 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1242 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1243 new comments in this file) we temporarily (sigh) move to a weaker
1245 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1246 we don't need to black list the following images anymore:
1247 - 8BitsUncompressedColor.dcm
1249 - US-PAL-8-10x-echo.dcm
1250 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1251 fixes and the beautified code ;-)
1252 This fixes the bug introduced in version 1.42 (when beautifying)
1253 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1254 Note: ctest was blind to this bug (this means we need to still
1255 improve the test suite). The bug could be detected by using
1256 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1258 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1259 and by displaying the (garbage) produced file temp.XDCM...
1261 2004-06-29 Jean-Pierre Roux
1262 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1263 - replace by uggly but working old code :-(
1264 A lot of things should be OK again.
1265 It's really urgent to have a test suite that *tests*,
1266 to prevent Frog's beautifying sessions to break all the stuff
1267 (twice, withing a fortnigh ...)
1269 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1271 redundancy) to added Test/TestReadWriteReadCompare.cxx
1272 * Test/CmakeList.txt: because the compare test of
1273 Test/TestReadWriteReadCompare.cxx fails, the following images are
1274 black listed: - 8BitsUncompressedColor.dcm
1276 - US-PAL-8-10x-echo.dcm
1277 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1278 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1279 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1280 and ad-hoc kludge. This kludge is now removed, and on encountering
1281 such an image (OB field brain damaged) we set errno. Then in
1282 ::FindDocLength() we "fix" the length as being ALL what remains
1283 in the file (until EOF). We then proceed, hoping for the best...
1284 This fixes a SegFault in ShowDicom when trying to write such an
1286 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1287 (because TestWriteRead breaks on it, after a non conformal commit?).
1288 ctest now runs properly, except for MakeDicomDir (which was always
1289 broken) and the Python related stuff (still not fixed).
1291 2004-06-24 Jean-Pierre Roux
1292 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1293 FIX : Test/TestReadWrite now iterates on all the file names
1294 (instead of infinite loop)
1295 ENH : Test/TestWriteRead now iterates on all the file names
1297 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1298 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1300 2004-06-24 Jean-Pierre Roux
1301 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1302 when SamplesPerPixel =3
1303 - now Write is no longer confused by
1304 'BitsAllocated = 12" and 'BitsStored=12"
1305 - "UN" value representation Elements are now written correctly
1306 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1307 ENH : - now gdcmHeader has its own Write methods
1308 (in order to split the job that has not to be done
1311 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1313 loop on the same image until memory went out.
1314 Note: this means we still have gobs of memory loss in PrintDocument
1315 * src/gdcmDocument.cxx: fixes problem on parsing on file
1316 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1318 2004-06-24 Jean-Pierre Roux
1319 FIX : Write - All the Sequences and Sequence Item are now written
1320 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1321 is added a the end, when necessary.
1322 - A lot of brain-damaged images, that were read correctly are
1323 now written correctly
1324 - length compatible BinEntry are now loaded correctly
1325 (even for odd groups)
1326 Note : only Explicit Value Representation was checked.
1327 (question : is implicit VR really necessary for gdcm ?)
1329 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * DEVELOPPER: added a proposition of coding style.
1331 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1334 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1336 Use the gdcmDocEntry::Print() and Write() instead.
1337 * src/gdcmDocument.cxx: bug fix.
1339 2004-06-22 Jean-Pierre Roux
1340 FIX : gdcmDocument.cxx
1341 - Now we do recognize the JpegLossLess format (there was a misstyping in
1342 code 'beautyfication' :-(
1343 - Now we automaticaticaly load the Luts, if any
1345 2004-06-22 Jean-Pierre Roux
1346 In order : to write Sequences, whatever their imbrication level,
1347 : to allow user to create his own Sequences
1348 a lot of modif where necessary (adding, moving, or virtualising methods)
1350 WARNING : save your own sources *before* cvs up !
1353 ADD virtual void Write(FILE *fp, FileType filetype);
1356 ADD virtual void Write(FILE *fp, FileType filetype);
1357 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1360 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1361 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1362 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1363 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1364 ADD std::string GetEntryByName(TagName name);
1365 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1367 std::string vr = "unkn",
1368 std::string fourth = "unkn",
1369 std::string name = "unkn");
1370 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1371 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1372 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1373 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1374 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1375 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1376 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1377 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1380 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1381 ADD virtual std::string GetEntryByName (TagName tagName);
1382 ADD virtual std::string GetEntryVRByName (TagName tagName);
1383 REM virtual bool Write(FILE *, FileType);
1384 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1385 FILE *_fp, FileType type);
1386 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1387 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1388 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1389 REM virtual std::string GetEntryByName (std::string tagName);
1390 REM virtual std::string GetEntryVRByName (std::string tagName);
1391 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1392 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1393 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1395 std::string vr = "unkn",
1396 std::string fourth = "unkn",
1397 std::string name = "unkn");
1398 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1399 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1400 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1401 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1404 ADD virtual void Write(FILE *fp, FileType filetype);
1407 ADD virtual void Write(FILE *fp,FileType filetype);
1410 ADD virtual void Write(FILE *fp, FileType filetype);
1411 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1412 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1413 REM std::string GetEntryByName(TagName name);
1416 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1418 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1420 The default constructor invoked by the line
1421 gdcmHeader *f1 = new gdcmHeader( header );
1422 was gdcmHeader::gdcmHeader(bool) instead of the expected
1423 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1424 Hence the parsing wasn't executed... See also below.
1425 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1426 as explicit constructor didn't do the trick to fix the above problem.
1427 Could anyone explain why ?
1428 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1429 properly calls gdcmValEntry::Print() (that was weed out from
1430 code related to gdcmBinEntry).
1432 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * In order to fix memory leaks:
1434 - Test/TestWriteSimple.cxx: added cleaning of free store through
1436 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1437 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1438 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1439 (through the call to ::AddDicomDirMeta()) or the destructor
1440 would crash when deleting uninitialized ::metaElems].
1441 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1442 - src/gdcmDocument.cxx:
1443 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1444 from dynamic stores.
1445 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1446 was causing memory leaks.
1447 - src/gdcmSQItem.cxx:
1448 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1449 cleanly handled with polymophism: sorry but my milage is low).
1450 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1451 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1452 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1453 This avoids SegFaulting.
1454 - src/gdcmSQItem.h: coding style.
1456 - Test/TestWriteSimple still severely sucks. The output image content
1457 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1458 damaged when displayed with vtkgdcmViewer.
1459 - on memory leaks: TestWriteSimple leaks really less (see entry
1460 of 2004-06-18 in Changelog file for the call to valgrind).
1461 - on segfaults: ctest now passes all the tests but one (no more
1463 * Erroneous leading white fix:
1464 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1465 white[s] (as opposed to from >> xxx, that removes it [them].
1466 - src/gdcmTS.cxx: ditto.
1467 - gdcmPython/testSuite.py: dirty related kludge removed.
1468 * src/*: remaining references to gdcmParser removed.
1469 * src/*[cxx|h]: added copy[way]left header.
1472 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * In order to fix writing of dicom files:
1474 - Test/TestWriteSimple.cxx: a simpler example of writing.
1475 - Test/CMakeLists.txt changed accordingly.
1476 - src/gdcmDocument.cxx:
1477 -- The destructor now recursilvely removes potential sequences.
1478 -- Bug fix in ::IsJPEG2000()
1479 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1480 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1482 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1483 to only declared) and build on top of
1484 ::GetDocEntryByNumber(guint16, guint16).
1485 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1486 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1487 for usage in destructor and treatement of promotion in
1488 ::ReplaceOrCreateByNumber().
1489 - src/gdcmSQItem.cxx: destructor should better handle his job.
1490 Test/TestWriteSimple now runs (or at least it DOES something).
1491 * We can now start hutting memory links. A good starting point is:
1492 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1493 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1494 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1496 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * Valgrind note: after Mathieu Malaterre teached me how to read
1498 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1500 Using gcc, you can force the STL to use malloc and to free memory as
1501 soon as possible by globally disabling memory caching.
1502 With 3.2.2 and later, you should export the environment variable
1503 GLIBCPP_FORCE_NEW before running your program.
1504 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1505 simply vanish (it is still not clear to me, whether this means that
1506 STL std::string leaks or if valgrind believes it leaks...).
1507 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1508 running bin/gdcmTests makeDicomDir):
1509 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1510 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1512 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1513 SegFaulting (I drowned in DicomDir related code when trying to
1514 understand why the list is empty...).
1515 * src/gdcmDocument.h: first BSD license header try.
1516 * Doc/License.txt added.
1518 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1519 * src/gdcmDocument.[h|cxx]:
1520 - Clean up of the Transfer related predicates. They are now all based
1521 on new method isGivenTransferSyntax, that (should) handle properly
1522 the padding problem.
1523 - general clean up, simplification, and coding style.
1524 - Specific clean up of Parse7FE0() (umproperly named actually).
1525 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1527 2004-06-14 Jean-Pierre Roux
1529 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1530 - fix the display of SQItem ordinal number
1531 - add the GetSQItemByOrdinalNumber method
1532 - remove some useless never written private methods
1534 2004-06-14 Jean-Pierre Roux
1536 - adding a constructor taking a gdcmDocEntry as an input param
1537 - ReplaceOrCreateByNumber now returns :
1538 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1539 a gdcmValEntry * if a string value is passed as a param
1541 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1542 according to the param type (no longer sets a gdcmDocEntry)
1543 - GetValEntryByNumber, GetBinEntryByNumber added
1544 - NewValEntryByNumber and NewBinEntryByNumber added
1546 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1548 - GetSQItemNumber and SetSQItemNumber added, to provide
1549 a (relative) Item identier inside a given Sequence
1550 \warning : some pb remaining around this number
1552 - AddEntry now takes the Item Number as a param
1554 - adding a constructor taking a gdcmDocEntry as an input param
1556 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1557 * Memory leak hunt with the following command:
1558 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1559 --show-reachable=yes gdcmTests PrintDocument
1560 It looks like many (all?) leaks are due to the STL (or a bad usage
1561 of the STL. The lines producing the leaks now have a comment with
1562 a "MEMORY LEAK" tag: you can retrieve them with
1563 grep "MEMORY LEAK" src/*
1564 Here are two typical examples which I can't help fixing:
1569 char * test = "babo";
1570 name = test; //// <--- valgrind detects 960 bytes lost in
1571 //// call to std::string::operator=(char const*)
1572 name.clear(); //// Doesn't help !
1580 std::cout << "Type a bunch of characters followed by RETURN: ";
1581 getline(std::cin, line); //// <--- valgrind dectects a loss
1582 //// of 1320 bytes in call to
1583 /// std::basic_istream<>& std::getline<>
1589 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1590 * src/gdcmHeader.[cxx|h]:
1591 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1592 and related, moved away to gdcmDocument.
1593 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1594 the corresponding protected accessors of inherited class
1595 gdcmDocument, removed ! As a consequence gdcmFile had to be
1596 declared friend of class gdcmDocument (see below).
1597 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1598 - Clean up of undefined or unused methods.
1599 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1600 account the changes to gdcmHeader.h).
1601 * src/gdcmDocument.h:
1602 - gdcmFile is now a friend class (in order to take into account the
1603 changes to gdcmHeader.h).
1604 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1605 (see changes to gdcmHeader.h).
1606 - Accessors (reading on the form GetEntry*) are now public.
1607 - Clean up of undefined or unused methods.
1608 * src/gdcmDocument.cxx:
1609 - adaptation to changes to gdcmDocument.h
1610 - ::OpenFile now writes a verbose message when file cannot be opened.
1611 - some std::string properly set to VRKey
1612 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1613 references to gdcmDocument.
1614 * Test/TestFindTags.cxx: changed accordingly to above changes.
1615 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1616 cvs repository gdcmData.
1618 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1619 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1620 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1621 conflicts with gdcmValEntry::voidArea.
1622 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1623 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1624 Value representation between StringRepresentable and BinaryRepresentable.
1625 * src/gdcmDocument.cxx:
1626 - method ParseDES: proper indentation restored and usage of
1627 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1628 - method LoadDocEntry: the fingerprint left in the SetValue() of
1629 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1630 removed. Reverting to previous code segment with the proper
1631 dynamic_cast< gdcmValEntry* >.
1632 Note: this was (partially) breaking the python test suite
1633 (gdcmPython/testSuite.py) that made usage of the above
1634 fingerprint to check presence of "Pixel Data".
1635 * src/gdcmDocEntry.h: coding style.
1636 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1637 now taken into account.
1638 * gdcmPython/gdcm.i: adaptation to the new internal representation
1639 of gdcm (exit gdcmParser, hello gdcmDocument).
1640 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1642 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1643 anymore, but instead prints the loaded Python dictionary.
1644 * .... alas, the python testSuite is still broken.
1646 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1649 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1650 * src/gdcmUtil.h : export methods
1652 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1653 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1655 * Initial addition of automatic python testing
1656 * Initial addition of automatic image comparison
1658 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1659 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1660 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1662 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1663 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1664 * Test/ShowDicom.cxx : bug fix for msvc compilation
1665 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1667 2004-05-04 Jean-Pierre Roux
1668 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1669 new concepts (and new classes) :
1670 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1671 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1672 - Sequence Doc Entries (gdcmSeqEntries)
1673 a Sequence is composed of Items.
1674 Each item is a set of Doc Entries (this is recursive)
1675 The non uniqueness of the 'Dicom tag' is due to this recursivity
1676 (never taken into account)
1677 Our unability to add a new 'entry' in the header
1678 at the proper location (neither in the H-Table (map or multimap),
1679 nor in the Chained List is also due to this recursivity.
1680 Don't try, right now, to use/modify/compile these new sources :
1681 nothing is finished.
1682 We just commit all the stuff, 'as is', in order not to loose it.
1684 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1685 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1687 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1688 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1689 file prefix (SetFilePrefix)
1691 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * Add a new test: ShowDicom, for now this is just the c++ version of
1693 checkRead.sh, later it will be able to compare the image read against a
1695 * Replace the DEBUG on the stack with a global entry in cmake interface:
1696 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1698 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * Add an example subdir, with a real example on how to read + write a
1702 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1704 * Doc/CMakeLists.txt: the main page is now properly differentiated
1705 between the developper and user version.
1706 * Doc/doxygen.config.in: dropped search related obsolete flags
1707 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1709 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1710 * DEVELOPPER: added some helpfull comments for compile/test/install
1713 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1714 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1715 src directory, now generated in the build dir.
1716 2. Tests as mentionned smarter
1718 4. Add a new method in gdcmDict that return the PubDict by name
1719 this is interesting for 3rd party lib like ITK,
1720 where we could set the institution name / patient name...
1722 * ENH: 1. Now the test suite is working for real
1723 2. All binaries are now output in the gdcm-bin directory
1724 (this was not true before)
1726 2004-04-28 Jean-Pierre Roux
1727 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1728 SeQuence indented printing of Dicom Header.
1729 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1730 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1731 Computation of SQDepthLevel is now part of gdcmHeader constructor
1732 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1733 tree-like structure of a Dicom Header.
1734 * FIX Test code cleaning
1736 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * ENH: Adding automatic testing
1738 1. Need a DartConfig.cmake to submit to public
1739 2. Add a test driver gdcmTest.cxx
1740 3. gdcmTestMain, an helper for the main test driver gdcmTest
1741 4. Files in Test don't have a main anymore, this becomes interesting
1742 when we add more and more tests, thus dsw don't have to load
1744 * ENH: Adding a GDCM_DATA_ROOT for testing
1745 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1746 one file instead of seven + some small cleanup
1748 2004-04-22 Jean-Pierre Roux
1749 * ENH Minor changes to the Print() methods.
1750 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1751 Header printing. Example given with :
1752 > PrintHeader fileName 2 new
1753 (SQ based tree-like structure still to be done for the Header ...)
1755 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1757 1. I have added some unsigned where needed
1758 2. Some function parameter not used -> (void)
1759 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1760 4. g++ don't like character '\' in comment
1761 5. #define jpeg_create_decompress jCreaDecompress
1762 this really need to be fixed
1763 6. virtualize destructor of gdcmObject ... leakage
1764 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1765 this also really need to be fixed
1766 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1767 remove compression file
1768 (as we only do decompression, right ?)
1769 * ENH: Change malloc/calloc/free with c++ equivalent
1771 2004-04-21 Jean-Pierre Roux
1772 * FIX gdcmHeaderHelper::GetXSpacing
1773 when a single value is found (bug ?), xpacing is now
1774 defaulted to yspacing
1776 2004-04-19 Jean-Pierre Roux
1777 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1778 * ENH add parameters :
1779 bool exception_on_error = false,
1780 bool enable_sequences = false,
1781 bool ignore_shadow = false
1782 to the gdcmFile constructors to be full gdcmParser compliant
1783 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1784 to allow reading of PAPYRUS 3.0 files
1786 2004-04-06 Jean-Pierre Roux
1787 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1789 2004-04-02 Jean-Pierre Roux
1790 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1791 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1792 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1794 2004-03-30 Jean-Pierre Roux
1795 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1796 for ACR file, written out as DICOM files (hope so...)
1798 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1800 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1801 moved to base class gdcmParser and only the specialisation is kept
1803 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1804 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1805 already does the job.
1806 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1807 (to be consistent with gdcmParser::WriteEntries).
1809 2004-03-30 Benoit Regrain
1810 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1811 upate of the object's instance. It's passed to 2 in the unfavorable
1812 case : one in the ExecuteInformation, one in the ExecuteData
1814 2004-03-29 Jean-Pierre Roux
1815 * ENH : Check on file type to be written moved
1816 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1817 * FIX : gdcmObject::ResetBoundaries now stops properly
1818 when end-of-list is reached
1819 : gdcmVersion modified (as Benoit Regrain asked)
1821 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1823 * src/gdcmUtil.cxx: added forgotten iostream include.
1824 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1825 equivalent to ExplicitVR in existing code).
1827 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1829 now contains all the gdcmGlobal related code.
1830 * minor coding style and doxygenation changes.
1832 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1833 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1834 now contains all the Debug related code.
1835 * minor clean-up of includes in src/*.cxx
1836 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1837 CreateCleanString) removed.
1838 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1839 * Doc/DoxyMainPageUser.txt added.
1840 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1841 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1842 src/gdcmDirList.cxx)
1844 2004-03-24 Jean-Pierre Roux
1845 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1847 2004-03-23 Jean-Pierre Roux
1848 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1849 big endian made volumes
1850 * ENH Now gdcmParser constructor and destructor are protected to forbid
1851 end user to instanciate class gdcmParser
1852 (only gdcmHeader and gdcmDicomDir are meaningfull)
1854 2004-03-22 Benoit Regrain
1855 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1856 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1857 gdcmSerie to gdcmDicomDirSerie
1859 2004-03-19 Jean-Pierre Roux
1860 * ENH Now the tree-like structure describing a DICOMDIR comming from
1861 an already existing DICOMDIR file is consistent with
1862 the home-made tree-like structure build ex-nihilo
1863 or build from the files held (recursively) in a Directory
1864 functions gdcmDicomDir::CheckBoundaries()
1865 gdcmObject::SetBoundaries() added
1867 2004-03-17 Jean-Pierre Roux
1868 * REM (Eric Boix bug) : removal of meaningless
1869 gdcmDicomDirImage::NewImage function.
1870 * FIX now file names and directory name are written properly in the
1872 * FIX now gdcmDicomDir constructor may be call without any trick
1875 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1877 of gdcmDicomDirImage::NewImage as empty function.
1879 2004-02-28 Jean-Pierre Roux
1880 * ENH add gdcmDicomDir:NewPatient
1881 add gdcmDicomDirPatient:NewStudy
1882 add gdcmDicomDirStudy:NewSerie
1883 add gdcmDicomDirSerie:NewImage
1884 to allow making gdcDicomDir object.
1885 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1886 (as opposite to the gdcmHeader chained list)
1888 2004-02-11 Benoit Regrain
1889 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1890 when using from python
1892 2004-02-10 Benoit Regrain
1893 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1894 * FIX : in gdcmDicomDir when the directory is empty
1895 * ENH : add callback and methods to get the progression of dicomDir
1898 2004-02-06 Jean-Pierre Roux
1899 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1900 - GDCM_META added to gdcmDicomDirType
1901 - class gdcmMeta created
1902 * ENH : - A brief summary is now displayed at the beginning of
1903 'testDicomDir' to help disaster magnitude estimation
1904 * REM : Now useless Test/explDICOMDIR.cxx
1906 2004-02-05 Benoit Regrain
1907 * ENH : add methods in gdcmObject to get the hash table or the list of
1909 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1910 * FIX : wrapping python for TagHeaderEntryHT
1912 2004-02-04 Benoit Regrain
1913 * FIX : even length for some strings when writting the dicom dir
1914 * FIX : sort the images in the dicom dir
1915 * FIX : Bug fix for python use of dicom dir
1916 * ADD : a python demo
1918 2004-02-04 Jean-Pierre Roux
1919 * FIX : Final solution (?) for icone embedded images
1920 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1921 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1922 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1923 gdcmData/gdcm-MR-SIEMENS-16.acr1
1924 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1925 to make full checking easier
1927 2004-02-04 Benoit Regrain
1928 * FIX : WriteEntries : coding style & logic in parameters
1929 * FIX : Set the elements to create the DicomDir in a dictionary file
1931 2004-02-03 Benoit Regrain
1932 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1933 * gdcmDicomDir : add the load of directory
1934 * Bug fix and print add-on
1936 2004-02-03 Jean-Pierre Roux
1937 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1938 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1939 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1940 * FIX gdcmParser.cxx : 'group length' elements are now considered
1941 as integers, even for shadow groups, when file is Implicit VR
1943 2004-02-02 Jean-Pierre Roux
1944 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1946 of the last synonym :-(
1947 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1949 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1950 * FIX taking into account the possible 7fe0,0010 multiplicity
1951 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1952 to allow removal of references to 7fe0,0010, to deal with
1953 ACR-NEMA images, when 0028,0200 is meaningfull
1955 2004-01-31 Jean-Pierre Roux
1956 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1957 no longer writes 'Un' on disk
1958 * FIX SQ elements with actual length are now dealt with corectly
1959 * FIX gdcmFile::WriteBase make the difference, for color images, between
1960 the length (for Palette expanded images)
1961 and Raw Length (non expanded image + Palette)
1962 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1963 (that broke Write). Replaced by UL.
1964 Aware user will reload the field if he
1965 thinks it's necesssary
1967 2004-01-30 Jean-Pierre Roux
1968 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1969 when 'dirty Acr' is found, to be compliant with the new
1970 IsReadable() methods.
1972 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1973 (no DOUBLE images in kosher DICOM,
1974 but so usefull for people that miss them ;-)
1976 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1977 DICOMDIR related utilities (not checked as Windoze compliant)
1979 2004-01-28 Jean-Pierre Roux
1980 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1982 2004-01-27 Jean-Pierre Roux
1983 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1984 to allow skipping the shadow elements, to save memory space.
1985 The TRUE value for this param has to be used
1986 with a FALSE value for the 'enable_sequence' param.
1987 ('public elements' may be embedded in 'shadow Sequences')
1988 * gdcmHeader methods now deal with 'embedded icones images' in the header
1989 (even when an 'icone image sequence' is announced by the
1990 element (0x0088,0x0200), but there is NO icone at all ...
1992 * gdcmHeader sometimes Image Location value doesn't follow
1993 the supposed processor endianity (see gdcmData/cr172241.dcm).
1996 * gdcmHeader add the method
1997 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1998 to get *all* the Header Entries with the same tag.
1999 GetHeaderEntrySameName is probabely *useless*
2000 (no meaning : Name is *not* an identifier within the Dictionary)
2002 2004-01-26 Benoit Regrain
2003 * Bug fix in the print of hexadecimal representations. Remove long fields
2004 in the print and add a third level of print to print them
2006 2004-01-23 Benoit Regrain
2007 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2008 * Bug fix on test suite after remove the strip made on not string fields
2009 * Split the IsReadable method between gdcmParser which test that the file
2010 is dicom and gdcmHeader which test that it's an image file
2012 2004-01-22 Benoit Regrain
2013 * DicomDir : clean code, add methods, set variables in protected or private
2014 * gdcmUtil : bug fix for the clean string method
2016 2004-01-19 Benoit Regrain
2017 * Add the use of shadow dictionaries
2018 * bug fix and coding style
2020 2004-01-19 Benoit Regrain
2021 * src/gdcmFile.cxx : bug fix concerning the close of file
2022 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2023 * Add the update of header entries using the shadow library
2025 2004-01-19 Benoit Regrain
2026 * removal of file gdcmHeader2.cxx
2027 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2028 inheriting from gdcmParser. This split is to prepare the integration
2029 of dicom dir parsing
2030 * bug fix under python
2032 2004-01-16 Jean-Pierre Roux
2033 * REM removal of class gdcmHeaderEntrySet
2034 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2035 * ADD add file gdcmHeader2.cxx
2036 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2038 2004-01-15 Benoit Regrain
2039 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2040 entries created while parsing the header. Thus, they will be destroyed
2041 when the gdcmDictSet will be destroyed
2042 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2045 2004-01-15 Benoit Regrain
2046 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2047 made a fatal error because of the memory release at the end of program.
2048 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2049 some memory and vtk seems to have some problems with that.
2050 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2052 2004-01-14 Benoit Regrain
2053 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2054 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2055 * src/*.[h|cxx] : make changes due to class name changes
2056 * gdcmPython/demo/*.py : bug fix due to method names
2058 2004-01-13 Benoit Regrain
2059 * src/*.[h|cxx] : coding style
2060 * vtk/*.[h|cxx] : coding style
2062 2004-01-13 Benoit Regrain
2063 * gdcmPython/testSuite.py : test the readable flag of file for tests
2064 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2065 It's lied to the stl compilation by MSVC (windows, always windows...)
2066 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2068 2004-01-12 Benoit Regrain
2069 * src/*.h : add comments
2070 * src/gdcmDictSet.h : set the method BuildDictPath in public
2071 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2072 directly setted in the source code
2073 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2076 2004-01-09 Benoit Regrain
2077 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2078 * setup.py : use a reference to gdcmVERSION
2080 2004-01-07 Benoit Regrain
2081 * Modification to compile with the distutils.
2084 2003-12-10 Benoit Regrain
2085 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2086 can use a gdcmHeaderHelper to load data
2087 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2088 made in the source code
2090 2003-12-10 Benoit Regrain
2091 * Update Windows projects and .cvsignore files
2093 2003-11-12 Jean-Pierre Roux
2094 * ENH gdcmHeader constructor has one more parameter (default value : false)
2095 that allows the user to 'go inside' the SeQuences only
2097 gdcmElValSet:Print takes it into account
2099 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * ENH: Update gdcmPython/CMakeLists
2101 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2102 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2104 2003-11-10 Jean-Pierre Roux
2105 * FIX : gdcmHeader::LoadElements is now based
2106 on the ListTag listElem member,
2107 not longer on the TagElValueHT tagHt member
2108 * ENH : PrintPubElVal shows (temporarily) both results,
2109 with the tagHt member and the listElem member.
2110 (it's easier to 'see' the problems when using Printheader)
2112 * FIX : old private member LgrElem is now splitted into
2113 ReadLength : Length actually found on disk (updated only
2114 if bug fixing is necessary), for internal
2116 UsableLength : Updated by FixFoundLength, to fix a bug
2117 or to allow Parser going on.
2118 Will allow to re-write a kosher header when a SeQuence
2119 with a length (not 0000) is found
2120 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2121 because gdcmElValSet::Add does not update ListElem
2124 2003-11-07 Jean-Pierre Roux
2125 * FIX misstyping in Transfert Syntax name table
2126 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2127 when they have an actual length (not 0000 nor FFFFF)
2128 (Nobody should care of it, but DICOMDIR explorers)
2130 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2131 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2133 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2134 * ENH: vtkGdcmReader now supports LUT !
2135 (vtkgdcmViewer for now is not able to use them though)
2137 2003-11-05 Jean-Pierre Roux
2138 * in testSuite.py : new files names for checking the package
2139 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2140 that returns the pixel area size to the *aware* (vtk) user
2141 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2143 2003-11-05 Benoit Regrain
2144 * in testSuite.py : Modify the rules for checking the paths
2145 : Explicit error messages
2146 * in __init__.py : Related modif
2148 2003-11-03 Jean-Pierre Roux
2149 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2150 to be used by aware (vtk) users that want to manage
2151 LUT (and no to turn the PALETTE image into an RGB pixels one)
2152 * GetPixelType now returns 8U for 24 Bits images
2153 (vtkGdcmReader compliant)
2155 2003-10-31 Jean-Pierre Roux
2156 * Removal of *all* gdcmData images and add them again
2157 in order to loose the 'history' of un-anonymised images
2159 2003-10-31 Jean-Pierre Roux
2160 * RMV : removal of useless jBitsInJsample.h
2161 for both 8 and 12 Bits JPEG Lossy Libraries
2163 2003-10-31 Jean-Pierre Roux
2164 * ENH : Add the functions gdcmFile::GetImageDataRaw
2165 gdcmFile::GetImageDataIntoVectorRaw
2166 that act as GetImageData and GetImageDataIntoVector
2167 except the making of an RGB Plane from Gray Plane + LUT
2168 Intended to aware (vtk) users who know how to manage
2171 GetLUTRGBA return a R,G,B,A LUT if any
2172 lgrTotaleRaw gives the 'Raw' length
2173 GetImageDataRaw returns the gray Plane
2174 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2175 (They stay Grey, just like with other Dicom viewers :-(
2177 2003-10-30 Jean-Pierre Roux
2178 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2180 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2181 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2182 being coherents dicom files.
2184 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2185 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2187 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2188 * ENH: Two steps is necessary to please VC++ compiler...
2189 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2190 * ENH: Add include dir to medcon lib
2191 * FIX: only one function is being exported for now !
2192 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2194 2003-10-29 Jean-Pierre Roux
2195 * adding gdcmHeader::GetLUTRGBA
2196 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2197 --> Mathieu, the modif u're waiting for is not yet committed
2198 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2200 2003-10-27 Jean-Pierre Roux
2201 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2202 00191113.dcm DermaColorLossLess.dcm
2203 MxTwinLossLess.dcm RadBWLossLess.dcm
2204 * ENH: For version prior to vtkImageViewer2 -r 1.19
2205 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2207 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2208 * Removal of ido stuff in CMakeLists.txt
2210 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2211 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2212 * FIX: remove a call to ->Modified ... see comments
2213 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2215 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2216 * FIX: Problem with path for libvtkgdcmPython
2217 * ENH: Try adding a search script for python site-package
2218 * RMV: Remove some file from medcon lib that are not necessary
2219 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2220 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2221 * FIX: More pragma disable fro VC++,
2222 I don't think I break something as it is also disable in VTK/ITK.
2223 But it fasten debug compilation time.
2225 2003-10-23 Jean-Pierre Roux
2226 * gdcm now deals with 16 Bits Run Length Encoded images
2227 (they are compressed as 2 planes images,
2228 one for the high Bytes, the other for low Bytes)
2230 2003-10-22 Jean-Pierre Roux
2231 * Now CheckRead takes into account :
2232 - the bugged 'Leonardo' Siemens images
2233 - the XA images, sent thru the burning VPRO station
2234 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2237 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2238 * FIX: When copying a Makefile.am to CMakeLists.txt
2239 one should remove the '\'
2241 2003-10-22 Jean-Pierre Roux
2242 * in gdcmData adding a bugged 'Leonardo' Siemens image
2243 (wrong lengths in header)
2244 OK with gdcm, KO with the other viewers :-)
2245 * add a GE dlx XA image, thru the VEPRO burning station
2248 2003-10-21 Jean-Pierre Roux
2249 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2250 for a brutal checking of vtkgdcmViewer compliance
2252 2003-10-21 Jean-Pierre Roux
2253 * add the files for 'xmedcon' Jpeg Lossless library
2254 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2256 2003-10-21 Jean-Pierre Roux
2257 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2259 2003-10-21 Jean-Pierre Roux
2260 * garbage Siemens 'Leonardo' images dealt with
2261 (the patch is easy to remove)
2262 * cosmetic changes to avoid warnings
2264 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2265 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2266 no need to press 'r' now.
2268 2003-10-20 Jean-Pierre Roux
2269 * upgrade of checkRead.sh checkWrite.sh according
2270 to new Jpeg Lossless decompressor
2271 * add US.3405.1.dcm, a genuine RGB medical file ...
2272 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2273 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2275 2003-10-15 Jean-Pierre Roux
2276 * general anonymisation in gdcmData
2277 * adding the 'color files' from
2278 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2279 * adding some well knowed bugged-header images
2280 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2281 waiting for their inclusion in Python testsuite
2283 2003-10-15 Jean-Pierre Roux
2284 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2285 no longer seg faults when file is not found
2287 2003-10-14 Jean-Pierre Roux
2288 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2291 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2292 * TODO: *.in file to genereate a UseGDCM later
2294 2003-10-14 Jean-Pierre Roux
2295 * Some supposed-to-be Dicom Images have no preamble.
2296 OpenFile takes it into account
2297 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2298 * Missing elements added in dicomV3.dic
2299 (just to be affraid : have a look at
2300 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2301 and do it again next year ;->
2303 2003-10-13 Jean-Pierre Roux
2304 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2305 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2306 But there are NOT. It's fixed !
2308 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2309 * FIX: "jpeglib.h" was not found on VC++
2310 * FIX: vtkgdcm was not being installed
2312 2003-10-10 Jean-Pierre Roux
2313 * ENH : OpenFile closes the file if it *really* doesn't look like
2314 an ACR-NEMA / DICOM one.
2315 * FIX : testWrite no longer writes an empty file if the source file
2316 is not gdcm Readable
2317 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2320 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * FIX: CMake generate now documentation
2322 * ENH: out of source doc build !
2323 * ENH: Generate both user and dev documentation
2324 * ENH: Should work on windows too
2325 * ENH: Only one doxygen config.in file is needed
2326 * FIX: make install should be ok now on ùnix plateform
2327 * FIX: PATH to dictionary was wrong (missing /)
2328 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2330 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2331 * vtkGdcmReader is now able to read rgb dicom file.
2332 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2333 * added a gdcmViewer to vtk test, use mouse to control
2334 window level & window width
2336 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2337 * CMake-ification of gdcm, we have now two build system
2338 * FIX: on cygwin Wsock32 doesn't exist
2339 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2341 2003-10-06 Emanuel Ollart
2342 * FIX : compilation process wad broken.
2343 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2345 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2346 * change gdcmViewer -> vtkgdcmViewer
2347 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2349 2003-10-06 Jean-Pierre Roux
2350 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2351 ( e.g : well known GE images with a wrong elem length,
2352 : Philips MRI Images with a wrong Huffman table)
2353 * still to be done : allow the reading of bugged LEONARDO Siemens images
2355 2003-10-03 Jean-Pierre Roux
2356 * Odd length strings are padded with '\0' (not with spaces,
2357 to remain compliant with already defined strings,
2358 like Transfert Syntax UID and others)
2360 2003-10-03 Jean-Pierre Roux
2361 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2362 to allow displaying RGB images (not only by affim ;-)
2364 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2365 * vtkGdcmReader is now able to read rgb dicom file.
2366 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2368 2003-10-03 Jean-Pierre Roux
2369 * A few nasty patches to allow the reading of a lot of nasty images
2370 ( e.g : well known GE images with a wrong elem length,
2371 : Philips MRI Images with a wrong Huffman table)
2372 * still to be done : allow the reading of bugged LEONARDO Siemens images
2374 2003-10-03 Jean-Pierre Roux
2375 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2377 2003-10-03 Jean-Pierre Roux
2378 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2379 to allow displaying RGB images (not only by affim ;-)
2381 2003-10-03 Jean-Pierre Roux
2382 * gdcmFile::GetImageDataIntoVector now
2383 - deals with MultiFrames MultiFragments Run Length Encoded files
2384 - deals with YcBcR (YBR_FULL) files
2385 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2386 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2388 (no sample found :-(
2390 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2391 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2392 Two reasons: - clear things
2393 - third parties acces gdcm through header files, so won't
2394 suffer anymore VC++ complains
2396 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * add argv[1] in testvtkGdcmReader.cxx
2400 2003-09-24 Jean-Pierre Roux
2401 * The lines are now eigthy characters long.for
2402 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2404 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2405 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2406 char* to std::string. Thus, the use of strdup becomes useless. (see
2407 previous commis of Malaterre)
2408 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2409 before the last Malaterre's commit.
2411 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2412 * This commit should fix the Debug building under VC++, the problem
2413 was mainly a mixture of debug and release lib being loaded at startup.
2414 * I also remove a depency to a specific C function: strdup. Because I had
2415 to force the link to msvcrtd (whereas strdup is in libc).
2417 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2418 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2419 located in the gdcmCommon.h file. All use of reference of tha has been
2420 changed to now use the variable GDCM_UNFOUND.
2422 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2424 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2425 Dicom dictionary. The test suite can now be run again. Note:
2426 I'm note very happy with the " (RET)" changes. I believe this
2427 RETAINED comment should be dropped when parsing the dictionary.
2428 - PACKAGER corrected
2430 - AUTHORS updated and now in alphabetical order
2431 * Makefile.am now exports gdcm.dsw for Windoze users.
2433 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2434 * cygwin complains about missing std:: in subdir Test/
2436 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2437 * remove some methods that are now in gdcmHeaderHelper
2439 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * vtkGdcmReader set spacing and origin correctly
2442 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * Fix a few delete/delete[] mismatch
2445 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2446 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2447 interpretation to data given by gdcmHeader. For instance there are
2448 heuristics to get informations (look at different places).
2449 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2450 sorting DICOM images based on different strategies.
2451 * modified Makefiles accordingly.
2453 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2454 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2455 when building in debug mode
2456 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2457 src/win32/gdcmdll.dsp
2458 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2460 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2464 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2465 * src/win32/libgdcmjpeg12.dsp was not dos format
2466 * src/win32/libgdcmjpeg12.dsp :
2467 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2468 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2470 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2471 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2473 * src/gdcmFile.cxx : bug fix in affectation type
2474 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2475 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2476 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2477 symbols... future problem ?
2479 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2480 * src/win32/libgdcmijpeg12.dsp was missing
2481 * modified gdcm.dsw accordingly
2483 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2484 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2486 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2487 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2488 commit of JPR (before his hollidays to facilitate our work).
2489 * setup.py : bug fix in code. Modifications made while the last commit
2490 of JPR. The code hasn't been tested before the commit... it's so
2491 useless to make that (for best programmer that is JPR) !!!
2493 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * tagged the current version as Version0_3 (i.e. version 0.3)
2496 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2497 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2498 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2499 * *.dsp : modifications to use new libgdcmijpeg8 library
2500 * setup.py : bug fix on VTKPATH variable
2501 * PACKAGER : adding all concerning windows
2503 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2506 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2507 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2508 test suite reported error.
2509 * PACKAGER file added (describes what a packager must do when
2510 packaging a new release).
2511 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2512 * configure.in: upgraded version number to 0.3.0
2513 * fixing build of rpm (through rpm -ta):
2514 - Doc/Makefile.am exports proper doxygen files
2515 - src/jpeg/libijg8/Makefile.am exports the include files.
2517 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2518 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2519 * src/gdcmHeader.h : formatting code
2521 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2522 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2523 We were obtaining error message from vtk. Now, creation of file list
2524 is made in an internal list to prevent this problem.
2525 Bug fix when output is empty.
2526 Bug fix in update of progress value. Previous commit for this was a bad
2528 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2530 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2531 * src/gdcmHeader.h : added method to get the file name
2532 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2533 files. Added method to remove all files on the input
2534 Added FIXME comment concerning the bad parsing of header made by
2535 ExecuteInformation method (in ExecuteData method)
2537 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2539 when using make instal.
2540 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2541 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2543 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2544 * setup.py : adding include dir of jpeg lib to compile all sources
2545 * */Win32/*.dsp : JPR fix for windows compilation
2547 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2548 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2550 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2551 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2553 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * setup.py is again effective on un*x (takes into account the
2555 addon of the jpeg library)
2556 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2557 * Doc/Doxy* updated (includes above enhancements)
2558 * INSTALL now points to web documentation
2560 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * src/gdcmHeader.h doesn't make unnecessary reference to
2563 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2565 * src/gdcm*.[cxx|h] :
2566 - to allow compilation with gcc 3.x
2567 -- clean up of STL usage (added explicit usage of std::)
2568 -- small fixes on exceptions.
2569 Note: linking not tested !
2570 - clean of doxygen comments to avoid warnings at documentation
2572 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2573 dependent convertion).
2575 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * Clean up of previous JPR garbage commit (not even commented in the
2578 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2579 - moved all jpeg related files from src to src/jpeg/libijg8, with
2580 addition/modification of Makefile.am and configure.in.
2581 - the testSuite is still brain damage (not guilty).
2583 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2584 * WrapVTK.py : modifications to get correctly vtk source files to
2586 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2587 (FileName -> Filename)
2589 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2590 * vtk/vtkGdcmReader.[cxx/h]:
2591 - UpdateProgress method should now be effective
2592 - removed the limitation on having only images loaded (as opposed
2594 - when building a stack of images/volume, a lesser number of
2595 gdcmHeader and gdcmFile instances should be used (hopefully
2596 accelerating things).
2597 - when building a stack of images/volumes, files which are not
2598 loadable (wrong path-filename, wrong permissions on existing file,
2599 or file not parsable by gdcm) are replaced with a black image
2600 in the stack (for the caller to notice the problem).
2602 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2605 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2606 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2607 between standard library (std) and vtk library (problems are found
2608 under Windows... thanks Windows !)
2610 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2613 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2615 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2618 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * When compiling with distutils (see setup.py) the C++ compiler is
2620 called with different flags than the default ones (with automake).
2621 In order to fix all those warning, I compiled gdcm with the command
2622 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2623 and went for warning fixes:
2624 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2625 up from unused variables.
2626 - vtk/vtkGdcmReader.cxx: potential bug fix.
2627 * src/gdcmHeader.h: Doxygen warning cleanup
2629 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * gdcmPython/gdcm.i:
2631 - typemaps correction to take into account the systematic replacement
2632 of "using namespace std" with std:: prefix e.g. std::list,
2633 std::string... (cf changes of 2003-05-21).
2634 - gdcmGlob global variable of type gdcmGlobal (defined in
2635 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2636 exported to Python a as cvar.
2637 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2638 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2639 gdcmDictSet.GetPubDictTagNames() and
2640 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2641 C++ static methods).
2642 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2643 with the above changes.
2645 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2646 * setup.py, manifest.in : bug fix under linux
2648 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2649 * Modification of setup.py to compile vtk part too. Then, we have 2
2650 wrappers which must work with same distutils. For that, we have a
2651 generic distutils in distusiltsWrapping.py ; with :
2652 - build_extWrap class to wrap generically all extensions,
2653 - ExtensionWrap base class for all wrapping extension that contains
2655 - Wrapper interface which wrap sources
2656 + In WrapSwig.py we have extension and wrapper for Swig
2657 + In WrapVTK.py we have extension and wrapper for VTK
2658 * MANIFEST.in : modifications to consider vtk directory and new python
2659 files for compilation
2661 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2662 * Added python wrappers of vtkGdcmReader vtk class (see the
2663 source in vtk/vtkGdcmReader.cxx) :
2664 - vtk/Makefile.am now builds a library
2665 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2666 python library (as opposed to _gdcm.so wich are the python
2667 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2668 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2670 - configure.in has an additional flag --enable-vtk that needs
2671 to be set to enable compilation of vtk related code, that is:
2672 + vtk/vtkGdcmReader.so and
2673 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2674 + gdcmPython/vtkgdcmPython.so (see above)
2675 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2676 be read when compressed or when HighBit + 1 != BitsStored),
2677 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2678 the usage of the python wrapper of vtkGdcmReader vtk class.
2679 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2680 * src/*.[h] all occurences of stl classes are now prefixed with
2681 std::, and all occurences of "using namespace std;" where removed.
2682 This is to avoid pollution of global namespace in included files.
2683 Apparently vtk does not avoid this pitfall: when using both
2684 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2685 collision of various stl members (principally cout...).
2686 * gdcmPython/testSuite.py now cleanly removes temprory generated
2688 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2689 comply with above changes)
2691 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2692 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2693 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2694 vtk data structure (an image Flip was required).
2695 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2696 * cosmetic changes in documentation.
2698 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2699 * src/gdcmHeader.cxx: the constructor no longer exits when an
2700 unexisting file is given as argument.
2701 * The subdirectory Data (containing all the images used for the
2702 test suite) is not part of this repository anymore. A new module
2703 containing those images is now available at
2704 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2705 with the name gdcmData.
2706 All the python scripts (including the package initialisation file
2707 gdcmPython/__init__.py) were adapated to take this change into
2708 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2710 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2711 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2712 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2713 demo of the usage of this class.
2714 Compilation of this vtk part is only done when using the --enable-vtk
2715 at configure (or autogen.sh) stage.
2717 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2718 * More memory link related corrections and documentation fixes.
2720 - maximum info is obtained with a command of the form:
2721 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2722 --show-reachable=yes PrintHeader
2723 - the remaining reachable blocks seem to come from the STL
2724 allocation scheme through the usage of map and list. It looks
2725 like this memory cannot be freed but it is not a memory leak
2726 (in fact further invocation to the STL would recollect the
2727 unused memory allthough it cannot explicitely be freed).
2728 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2729 of displaying an image parsed with gdcm and displayed with VTK.
2730 Note: some images don't seem to work e.g.
2731 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2732 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2733 Allthough this weakens the semantics, it is a ditch attempt to
2734 make gdcm more thread friendly.
2736 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2737 * Memory link hunt (by using valgrind through the command
2738 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2739 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2740 gdcmHeader::_dicom_vr.
2741 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2742 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2744 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2746 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2747 * src/Makefile.am now exports all the necessary include files at
2751 * UpdateGroupLength replaced by new one
2754 * UpdateGroupLength re-written using H-Table
2755 (named UpdateGroupLengthNew untill checks are over)
2757 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2758 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2759 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2761 - gdcmHeader::GetPubElValSet removed.
2762 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2763 UpdateGroupLength, WriteElements, Write.
2764 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2765 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2766 carried the same semantics.
2767 - src/gdcmHeaderIdo.cxx changed accordingly.
2768 - gdcmFile::WriteBase now regroups all the codes from previous
2769 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2770 - enum FileType moved to gdcmCommon.h
2771 * src/gdcmHeader.cxx AddDefault trashed
2772 * gdcmGetXSize added
2773 * getimageDataSize now calls gdcmGetXSize
2774 * Test/*.cxx changed to agree with above changes
2776 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2778 (to avoid double call by end user).
2779 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2780 by end user, since gdcmHeader::gdcmHeader now handles it.
2782 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * gdcm/Doc many doxygen changes:
2784 - Doxyfile now has two different versions, DoxyfileUsers that generates
2785 the html.users end users oriented documentation and
2786 DoxyfileDeveloppers that generates the html.developper developper
2787 oriented documentation.
2788 - README changed accordingly
2789 - requirement.txt removed (old design info moved to TODO).
2790 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2791 DoxyMainPage.txt, DoxyPython.txt provide more information.
2792 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2793 be updated by simply regenerating the docs with doxygen and copying
2794 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2795 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2796 all the tests in the form "if (<map>.count() >1)" were removed.
2797 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2798 ill-formed documentation sections.
2799 * src/gdcmHeader.cxx: ditto
2801 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * setup.py fixed for un*x (needed macro for stdint.h)
2803 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2804 un*ces with sh-utils test utility.
2805 * gdcmPython/demo/test.py renamed to PrintHeader.py
2806 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2807 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2808 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2809 * src/gdcm*.cxx JPR's bad inclusion fixed.
2811 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2813 * gdcmPython/demo/test.py changed accordingly.
2815 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2816 * gdcmPython/Makefile.am fixed linking against libstdc++
2817 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2818 * Swig subdir (historical tests of swig version 1.3.17++) removed
2819 * Test/testChangeEntete.cxx some lines commented out in order to make
2821 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2822 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2824 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2826 hence the user doesn't need this explicit call.
2827 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2828 i.e. LoadElements() call removed.
2829 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2830 - src/Makefile.am declares the proper flag for g++.
2831 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2832 for adding user defined new tags.
2833 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2834 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2835 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2837 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2838 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2839 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2840 src/Makefile.am : the project should properly compile and install
2841 with the autotools, included the python wrappers part.
2842 * gdcm.spec.in : added a spec file for RPM packaging.
2844 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2845 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2847 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2849 to exported to the environement (see gdcmPython/testSuite.py
2851 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2852 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2853 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2854 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2855 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2857 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * gdcmPython/__init__.py doesn't crash anymore when running in
2859 in InstallMode or PreInstallMode but with an environment given
2860 value of GDCM_DICT_PATH.
2861 * src/gdcmDictSet.[cxx/h] coding style.
2863 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2865 * src/gdcm.h general comments moved to TODO, and README
2866 * src/gdcm.h should now be seen as a user commodity (including it
2867 should suffice to fully use gdcm). It is nowhere including within
2868 any of the kernel files src/*.cxx and src/*.h.
2870 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2871 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2872 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2874 * src/gdcm*.cxx only include their corresponding include file
2875 (as opposed to gdcm.h)
2876 * gdcmPython/gdcm.i changed accordingly
2877 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2878 the autogen.sh generated "make snapshot" command to work.
2879 * autogen.sh removed history related references to crea package.
2881 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2882 * distutilsSwigCPlusPlus.py work around some swig portability
2885 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2887 was done in a last ditch attempt to get setup.py _really_
2888 operationnal. The python/gdcmPython layaout add the advantage
2889 of hidding away the python related distutils specific files
2890 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2891 Alas, the src directory was out of scope (i.e. it's relative
2892 position to setup.py was ../src) which made things impossible to
2893 handle (see previous version of python/setup.py). Crossing fingers...
2895 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * python/setup.py now works on Un*x. (harder than I thougth)
2897 * python/distutilsSwigCPlusPlus.py can now have include files
2898 among the list of sources.
2900 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2901 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2902 * modifications in MSVC projects
2904 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2905 * As stated by the first lines of Test/ExceptionAndPython/README, it
2906 looks like we can move back to original usage of exception within
2907 src/gdcm* and hence remove the errno stuff that was introduced
2908 as a quick and dirty fixture of this problem (added to the TODO).
2909 * Doc/Doxyfile configuration file for Doxygen and corresponding
2910 README file for usage added.
2911 * Test/testWrite.cxx added. This new test comes from a split of
2912 test.cxx that is now reverted to its original purpous i.e.
2913 testing the proper parsing of a Dicom related file.
2914 testWrite.cxx concentrates on testing the IO part of gdcm.
2915 * Test/bug1.cxx (containing a bug on WIn32) added.
2916 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2917 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2918 whose purpose is to publish the content of the TagNames of the
2919 Dicom public dictionary were not accessible without an
2920 instance of class gdcmHeader.
2921 - those methods are now static methods of gdcmDictSet and hence
2922 require no instances at all to be invocated.
2923 - within gdcmDictSet this change required to change some method
2924 to class methods (i.e. are now static) among which SetDictPath
2925 (renamed to BuildDictPath) and LoadDefaultPubDict.
2926 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2927 the above changes by calling the new method classes of gdcmDictSet.
2928 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2929 the above to be effective.
2930 * python/gdcmPython: in order to wrap properly the above changes
2931 for Python, swig version now needs to be > 1.3.17.
2932 * python/gdcmPython/Makefile fixed to adapt itself to new
2933 configure/make shema introduced by Johan Montagnat (thanks for the
2934 contribution). Alas this Makefile cannot be turned into a proper
2935 Makefile.am without some heavy changes in the configure.in
2936 (for python dectection).
2937 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2938 now avoids publishing the empty entries.
2940 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2941 * python/setup.py : bug fix concerning install under windows
2942 ExtraPath reused :-P
2943 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2945 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2946 * Dicts/dicomV3.dic : remove double spaces !!!
2947 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2948 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2951 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2953 method. Doxygenation.
2954 * src/gdcm.h clean up of JPR spurious comments.
2956 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2957 * python/distutilsSwigCPlusPlus.py now properly collects the
2958 shadow classes generated by "swig -c++" (gdcm.py in our case)
2959 when using "python setup.py install".
2960 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2961 reexports the working classes.
2962 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2963 by the classical C errno scheme. This is to prevent an obscure
2964 behavior of the python wrappers when importing wxPython.wx prior
2965 to gdcmPython (which ended up in an abort call). An illustration
2966 of this oddity can be found in the Test/ExceptionAndPython
2967 subdir (see the README file). This problem probably due to
2968 an combination of g++ and dynamic loading.
2969 * added Test/ExceptionAndPython (see above)
2971 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2972 * Changed the layout of the python part to avoid bloating main
2973 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2974 i.e. the distutils arsenal. All the python related stuff is
2975 again in a python subdir, but the package itself is now in
2977 * setup.py was cleaned up:
2978 - pythonIncludePath removed
2979 - python setup.py bdist target is now functional.
2980 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2981 collision with other packages). gdcmPython/demo/*.py changed
2984 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * python subdir moved to gdcmPython (preparation of distutils packaging).
2986 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2987 distutils installer is operational.
2988 * - gdcmPython/__init__.py now properly loads the swig generated
2989 shadow classes (from gdcm.py).
2990 - gdcmPython/demo/*.py changed to import the package gdcmPython
2991 instead of gdcmPython/demo/load.py.
2992 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2994 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2996 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2997 entries within the associated public Dicom dictionary resp. the same
2998 information but sorted by the fourth field (PAT, IMG, DIR) of the
3000 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3001 are now in the "???" group.
3002 - python/gdcm.i changed accordingly,
3003 - python/demo/printGroupedPublicDict.py added, that gives an example
3004 of the above new functionalities in Python.
3006 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcm.h, gdcmHeader.cxx:
3008 - historic references to glib's g_malloc and g_free (#defined)
3009 were definitively removed.
3010 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3011 * src/gdcmElValSet.cxx:
3012 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3013 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3014 - GetElValue(string) renamed to GetElValueByName.
3015 - Added GetElementByName(string).
3016 * src/gdcmHeader.cxx: added
3017 - GetPubElValRepByNumber(guint16, guint16)
3018 - GetPubElValRepByName(string)
3019 - GetShaElValRepByNumber(guint16, guint16)
3020 - GetShaElValRepByName(string)
3021 - GetShaElValByNumber(guint16, guint16)
3022 - GetShaElValRepByName(string)
3023 - GetElValRepByNumber(guint16, guint16)
3024 - GetElValRepByName(string)
3025 - GetElValByNumber(guint16, guint16)
3026 - GetElValRepByName(string)
3027 * Doc/requirements.txt added.
3029 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3030 * Test/Makefile building now depends on the one of libgdcm.so
3031 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3032 pixel data) aware which enables finding the address (offset) of
3033 the pixel data of JPEG encoded DICOM files. This leaves only a single
3034 file in the testSuite whose pixel data address (offset) is unknown.
3035 * python/testSuite.py changed accordingly.
3037 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3038 * VC++ has some strong limitations when working with the STL, as stated
3039 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3040 "Also note that some STL containers (map, set, queue, list, deque)
3041 cannot be exported. [...]
3042 Some STL classes contain nested classes. These classes can not
3044 This is caused by a designed limitation that once a template
3045 class is instantiated, it can not be re-instantiated and
3047 Since our usage of map<> is ubiquitous in gdcm, this "designed
3048 limitation" of VC++ is a pitfall.
3049 Hence the Python wrappers of gdcm cannot be incrementally linked
3050 against the c++ dynamic library. The dirty but only workaround is
3051 to forget about incremental link of dynamic libraries and to generate
3052 the Python wrappers library with the inclusions of the underlying C++
3054 The following modifications concern this matter on Win32/VC++:
3055 - wrapping python correct with standalone wrapped dll (don't use separate
3056 dll under windows !!!!)
3057 - python21_d debug mode enabled (ask Frog how to use it :-)
3058 - NO problem with having an STL member of class for example string in C++
3059 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3060 - Python test of dcmlib in Python is ok under windows on a large set
3062 * removed glib references
3063 * typedef's inserted in gdcm.i for correct swig type management
3065 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3066 * python/demo/*.py load.py extracted from test.py. Added explore.py
3067 that only displays required tags and testAll.py that parses all
3068 the files of the testsuite without using unittest.
3069 * python/testSuite.py other additional test on new files added.
3070 * Data/* new test files added accordingly to the testSuite.
3071 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3072 the vr in the file differs from the one of the dictionary.
3074 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3075 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3076 values, but limits itself to values which are below a user specified
3077 size (by default 1024 bytes).
3078 * python/gdcm.i : elements not loaded (because their size is above the
3079 user specified treshold) are exported with their TagKey as key of the
3080 python dictionary. This enables the testsuite to make some checks
3081 on the unloaded elements (since we have their offset and size).
3082 * python/testSuite.py
3083 - now tests for the existence and proper value of the pixel data
3084 - two new examples added.
3085 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3087 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3088 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3089 aware. See the strategy comments in gdcmHeader::FindeLength().
3090 * Test/test.cxx now accepts a filename as first argument.
3091 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3092 * python/testSuite.py changed to integrate test on above files.
3094 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3096 the vr was also RET.
3097 * python/testSuite.py more tests added.
3099 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * python/testSuite.py unittest test suite added (uses Data)
3101 * Data/* dcm and acr files for the test suite.
3102 * glib dependance removed from un*x version. We now use ISO C99
3103 7.18 Integer types (see stdint.h)
3104 - python/Makefile, src/Makefile src/gdcm.h
3105 * src/ when an explicit vr (like dicom files) suddenly poped an
3106 implicit element we use to mark the underlying DictEntry of the
3107 concerned ElValue with "Implicit". This strategy was damageable
3108 too the public or provite dictionaries, since some of their vr
3109 would be changed. Since Header::FindLength heavily relies on the
3110 detection by Header::FindVR of falsely explicit elements, I
3111 added an extra ImplicitVr member to ElValue (boolean).
3112 The rest of the changes we the necessary adaptations.
3114 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3117 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3119 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * Adaptation for porting to VC++:
3122 o forced to use std namespace (for string to be known)
3123 o all class use __declspec export style on WIN32
3124 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3125 (in stdlib.h on Win32 but in std:: for gcc)
3126 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3127 variable GDCM_DICT_PATH.
3128 * src/gdcmHeader.cxx verbose comments made discrete.
3130 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * python/gdcm.i: added a typemap that converts a C++ hashing table
3132 to native Python dictionary.
3133 * python/demo/test.py:
3134 - now uses the native dictionary for exploration of gdcmHeader.
3135 - takes an optional filename argument (the file to parse).
3136 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3137 PubElVals hashing table.
3138 * Dicts/dicomV3.dic removed error prone trailing spaces.
3140 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3141 * Python wrapping process moved away from src/Makefile to
3142 newly created python/Makefile (as well as gdcm.i)
3143 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3144 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3145 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3146 from the environement variable GDCM_DICT_PATH (when existing).
3147 * src/gdcmDict::GetTag bug fix.
3149 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * Straightforward temporary fixes for swig to build the python wrappers.
3151 src/Makefile now has a python working entry [by working we mean
3152 that we can import de shadow classes without errors].
3154 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3155 * hashtest.cxx removed (since already in Test)
3156 * src/gdcmlib.h renamed to src/gdcm.h
3157 * src/dcm.i renamed to src/gdcm.i
3158 * src/Makefile prepared for python wrapping
3160 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * src/gdcmHeader.cxx :
3162 - Parsing of header is now separated from loading of element values
3163 (see gdcmHeader::LoadElements).
3164 - general clean up of hopefully all file access (creation of
3165 ReadInt16 and ReadInt32)
3167 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3168 * src/gdcmHeader.cxx :
3169 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3171 - SetLgrElem renamed to SetLength
3172 - GetLgrElem renamed to GetLength
3173 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3174 * src/gdcmElValSet.cxx fixed both GetElValue methods
3175 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3176 due to IdoDude was cleaned out.
3178 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3179 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3180 concentrates on finding the value representation (when it exists).
3181 RecupLgr now only finds the element value length, and it avoids
3182 returning the unecessary skL (skipped length).
3183 Also, offsetCourant was simply removed (with taille_fich) since
3184 it was redundant with the File position internals (by using
3185 ftell and fseek). This also made skL (see above in RecupLgr) usage
3187 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3188 on the libido specificities which are handled through class
3190 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3193 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3194 * Truckload of changes. Parsing of header is barely functional
3195 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3197 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * src/gdcmHeader.cxx many addons of low level methods
3200 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3202 and _IdDcmSWAP_LONG.
3204 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * This corresponds to all the changes decided at the meeting of
3206 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob