1 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Update SerieHeader to take into account a Serie Instance UID to properly
5 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
6 * ENH - Comment out Mathieu's (dangerous) Super Hack
7 for dealing with BIGENDIAN processors
8 - Move equivalent stuff to BinEntry::WriteContent
9 When necessary, 16 Bits Pixels are swapped in a small buffer
10 and then written. This avoid allocating a huge buffer, in
11 PixelWriteConveror, and avoid modifying the Pixel Area.
13 Probabely, the same operation will have to be done when we want
14 to write image with Big Endian Transfert Syntax,
15 and we are working onj Little Endian Processor
17 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
20 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
21 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
23 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
25 * Test/TestDict.cxx : add a new test for the dict classes
27 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
28 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
29 file. Debug is yanked if compiled with NDEBUG
31 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmDictSet.h : set the default output to the os variable
33 * src/gdcmDictEntry.[h|cxx] : add the Print method
34 * gdcmPython/demo/ : add a new test
36 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
37 * merging of Test/PrintDicomDir and Test/TestDicomDir
38 * removal of now redundant Test/PrintDicomDir
39 * enhancement of Example/PrintDicomDir
41 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Now, python test might work on systems
43 * Add the PrintDicomDir test
45 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
46 * FIX : First entry following group 0002 was lost for
47 Explicit Big Endian Transfer Syntax files
48 (group and elem not swaped)
50 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
51 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
52 Big Endian Transfer Syntax supposed the group following 0002
53 begins always by element 0000 (element 0000 is *optional*)
54 To avoid further troubles, let's be pessimistic, and use
55 Document::HandleOutOfGroup0002() method
56 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
57 (related pb not yet solved)
59 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Bug fix for the python part use
61 * Now, PrintHeader.py pass... but outside the ctest use. shit !
63 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
66 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
68 a string and should ask the global TS dict what are the propreties of
71 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
72 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
73 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
74 to swap the Swap Code, at parsing time, when we come out of group 0002
75 and Transfer Syntax is Big Endian
76 We should be able to read now 'true DICOM" Big Endian coded images
77 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
78 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
80 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
81 * Hopefully fix the bug on MacOSX and static global initialization.
82 This is the only -minor- patch I found that both please MacOSX and VS6.
83 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
84 but this would require a lot of change. Another approach would be that Global
85 create those string and GDCM_UNFOUND becomes a pointer to a string (which
86 gdcm::Global would destroy at exit).
88 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 * Fix bug on MacOSX with static initialization in a multy threaded
90 environment. static const string in a header file used to be ill
91 initialized provoquing the freeze of any tests. patch should solve this
94 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
95 * According to Benoit's suggestion, and without any objection from anybody
96 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
97 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
98 - method gdcmDicomDirObject::GetEntry() renamed as
99 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
101 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
103 you debug/warning message just as c++ streams which make them very convinient
104 to use. Once this is stabilize I will change the ostringstrem to be
105 redirected to a file (ofstream).
106 * Properly support C99 extension: __FUNCTION__ which allow us to display
107 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
109 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
110 * Removal of useless and dangerous methods :
111 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
112 GetDocEntryByName, GetEntryByName, GetDictEntryByName
113 * Removal of usless methods :
114 Dict::PrintByName, Dict::GetDictEntryByName
115 * Commenting out of probabely useless methods :
116 Dict::GetDictEntryNames()
117 Dict::GetDictEntryNamesByCategory()
118 DictSet::GetPubDictEntryNames()
119 DictSet::GetPubDictEntryNamesByCategory()
120 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
121 * ENH : Use dicomTS.dic as described in 2004 version
122 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
123 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
124 Add Accessors on VM (Value Multiplicity), and VM related methods
125 * ADD : Add a list of 'Dicom Attribute types', as found in
126 http://medical.nema.org/dicom/2004/04_15PU.PDF
128 * ADD : Add dicomGroupNameAbbreviations.dic
129 should be used to write a method to replace the former
130 Dict::GetDictEntryNamesByCategory()
132 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
134 to read in the file... and only it ! Length is the efective length of the
135 data in the DocEntry structure
137 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
138 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
139 And now use a static function call instead, with a global variable. i
140 This is much closer to the VTK approach. Hopefully should be bulletproof
141 and easier to use...hopefully
143 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
144 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
146 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
149 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
151 ValEntry, BinEntry, SeqEntry creation or replace
153 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
155 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
157 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
158 when specifying the VR
159 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
160 * src/gdcmDocEntry.cxx : amelioration of print
162 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
163 * ADD : Add the method Util::IsCurrentProcessorBigEndian
164 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
165 * ADD Method Document::ComputeGroupLength
166 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
167 in order to allow further VR modification by user
168 * REM : removal of once-called method File::WriteBase
169 integration of its code in formerly one-line method File::Write
171 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
173 replace the different values "??", "Unkn", "Unknown".
174 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
175 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
176 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
177 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
179 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
182 * Set the gdcm::Base class to some Printable classes
184 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * src/gdcmFile.[h|cxx] : add the Print method
186 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
187 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
188 * src/gdcmDocument.h : remove the PrintLevel informations
189 * Example/PrintFile.cxx : use the new gdcm::File::Print
191 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
193 problems when compiling with the python wrapping
195 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
197 writting in ImplicitVR
199 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
200 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
201 JPEG decompression, especially when dicom frames are split into several
202 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
203 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
205 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmHeader.cxx : change the initialisation of default header.
207 Now, this header is readable by gdm, e-film, DicomWorks
209 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
211 Rename Decompressed to Raw
212 * Use the API changes in gdcm::File.
213 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
216 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
218 each added entry in the header. Replace the 'Planes' field by the 'Number
221 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
223 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
225 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
227 At this time, this image isn't readable by e-film... waiting JPR help to
230 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
232 DocEntry. Now use methods of the Document !
234 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * Test/ShowDicomSeq.cxx : bug fix
237 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
239 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
240 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
241 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
243 * Test/TestCopyRescaleDicom.cxx : remove unused variable
244 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
245 containing found sequences
247 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
250 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
251 Some fields in BinEntry must be copied to not seg fault when making the :
252 gdcm::File *copy = new gdcm::File( copyH );
253 and tests are now made on good variables
255 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
257 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
259 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
260 * Add vtkGdcmWriter example and test
262 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * Test/TestUtil.cxx : reformat the source code
264 * vtk/vtkGdcmReader.cxx : remove and change prints
265 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
267 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
268 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
270 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
272 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
274 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
276 by an eof to prevent all bad read of the file... and in this case, the
279 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * Example/Volume2Dicom.cxx : comment unused variables
281 * Test/PrintDicomDir.cxx : comment unused variables
282 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
283 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
284 method that is redondant with AddEntry.
285 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
288 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * Bug fix due my last commit (compilation under Windows).
290 * Example/Volume2Dicom : bug fix in the file and reformatting source code
291 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
293 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 - Remove printf / sprintf
296 - include iostream AFTER gdcm so we don't get warnings
297 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
299 - Also remove tons of include from header files, hopefully this should
300 speeup the compilation time, since it was becoming a dog slow.
301 - Remove gdcm.h as it include way too many files and slow down compilation
302 (plus it is not up to date)
303 - remove 'using namespace std' this is BAD !
305 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * Remove memory leaks on the DicomDir
307 * Remove some useless data in DicomDirObject
308 * Add usefull methods in SQItem, to be complient withe the ElementSet
310 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
313 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
315 future, with convertion)
316 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
317 and ImageDataSize values. Remove the method to get the PixelReadConverter
318 from the output of the class
320 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
323 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
325 and vtkErrorMacro use.
326 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
328 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
331 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
332 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
333 The string leaves only in the fonction. So when we make a .c_str(), we
334 get the pointeur on the first element, element that will be destroyed
335 immediately after thee instruction.
336 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
337 file has been opened : the test must be made on the content of the
338 pointer and not directly on the pointer !
341 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
343 the python part recompiles
345 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
347 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
348 X session is killed (for my computer... it seems to not be identic on
351 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
353 avoid problems (otherwise, the difference test between the visible image
354 and the reference is incorrect. If the reference is greater than the
355 screen resolution, it's produce errors).
356 Can be used for only one image. Can be used with a visible flag.
357 * vtk/vtkGdcmReader.cxx : remove commented codes.
358 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
359 under windows at compilation
360 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
362 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
364 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
366 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
367 tests on the image size X, Y, Z
369 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
371 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
372 between the class name and the file name
374 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/ : fix compilation warnings for the Write method (2 different
376 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
377 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
378 variable... create a static method in gdcm::Document to access to
379 this variable content.
381 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
382 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
383 file, to be accessed by other files (like gdcmFile). Remove commented
384 code. Move the change of the header to the gdcmFile, using the
386 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
387 To be sure of that (and simplify calls), the Write of the header now
388 gets a file name and not a file pointer (std::ifstream).
389 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
390 DocEntryArchive. Remove all open of the written file
392 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
395 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
397 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
399 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
400 some corresponding methods. Write correctly the file and check before
402 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
403 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
404 is now on RGB data (as before my last commit
405 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
407 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
408 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
409 Add a print information of the type of the entry
410 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
411 It was in the gdcmFile, and all write have been regrouped
412 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
413 Write correctly all dicom files (in decompressed mode only at this time)
414 * Test/ : test on files are now made using Raw data and not color data if
416 * Example/PrintFile.cxx : add more printings
418 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * Amelioration of code, remove some code copy. For the loading of
420 BinEntry (in gdcmDocument), add the test to verify if the file is already
423 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
425 remove a DocEntry in the header (push an empty DocEntry)
426 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
427 lines. Bug fix in the initialization of the PixelConvert and the
429 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
430 use in TestCopyDicom (now this test can run under windows... but fails)
431 * Test/TestCopyDicom.cxx : amelioration of the test :
432 - test the pixels written
433 - add test points to quickly find where is the error
434 - can set a file name input and output in arguments
435 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
436 amelioration of the test output
438 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
440 all replaced DocEntry's
441 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
442 Now, each needed DocEntry to modify is duplicated, modified and inserted
443 to the header using DocEntryArchive. Thus, after save, we can restore the
444 header initial state.
446 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
447 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
449 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
450 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
451 correct to copy it. The DictEntry is specified at the DocEntry creation,
452 then, it musn't change in the time.
453 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
454 header correctly. At this time, the change is only made for the first
455 level of the Document. In the future, it might consider sequences.
456 The change is made by replacing a DocEntry by an other that is created
457 outside the class. The old value is kept. When we restore the header
458 status, the added DocEntry is deleted and replaced by the old value.
459 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
460 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
461 set the write type to explicit VR, implicit VR or ACR. Add methods to set
462 the write mode to native, decompressed or RGB (but not used at this time)
464 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
466 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
468 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
470 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
472 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
473 set because already copied when copying the BinEntry's of the header
474 * Test/TestAllReadCompareDicom.cxx : remove warnings
476 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
478 Two problems appear when doing it :
479 - with the gdcmFile : when the GetImageData method is called, the pixels
480 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
481 data (pixels). And each structure destruct the data when it's
482 destructed. So we have two destructions for the same data. To solve it,
483 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
484 data or not. If it doesn't own data, then they will not destroyed by
486 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
487 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
488 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
489 create a double destruction of the same DocEntry's. So, to solve it,
490 the TagHT is simply cleared and the DicomDir* elements are destroyed.
491 * TODO : add an entry concerning memory leaks in the DicomDir
493 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
495 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
498 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
500 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
501 after it have been deleted
503 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
504 * FIX: src/* fix the doxygen warnings.
505 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
506 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
507 was erroneously defined with a size of 15 instead of 16. [many thanks
508 to Jean Michel Rouet for pointing out this bug].
510 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
511 1. Finish merging JMR patch for writting DICOM from scratch
512 2. Fix -hopefully- bug with MONOCHROME and space vs null character
513 3. Use const ref when possible
514 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
515 5. A few more comments
516 6. CreateUniqueUID can now be called without parameter"
518 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
519 * ENH: Slightly bigger patch:
520 1. Getting toward full integration of JMR patch for writting dicom from scratch
521 2. Update Test to test part of this patch: CreateUniqueUID
522 3. File was not close properly in gdcmDict
523 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
524 5. Use of const ref instead of copy (speed issue)
525 6. Remove temporary (duplicate) string in TranslateToKey
526 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
527 8. Do not repeat virtual in subclasses
528 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
530 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
531 * Apply first patch toward better string comparison when dealing with broken
532 DICOM files. Essentially the string could be padded with a space instead
533 of a null character as defined by standard
535 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
537 because never used... and in the same time, that's remove some memory leaks
539 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * src/gdcmFile.cxx : now delete the PixelConvert instance.
541 * In examples and tests : change the type of image data variables from void*
542 to uint8_t*. Remmove all delete on image data variables
544 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
546 Verify the file pointer value before open the file, and if it's not null,
547 a verbose message is generated.
548 Close correctly the file when the file isn't considered dicom-like. The
549 correctly close is a call to CloseFile.
550 When closing the file pointer, test if its not null to close the file.
551 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
552 file. For an uncompressed image, the copied data correspond in the least
553 case to the image size (calculated) or the image size specified in the
554 header. A verbose is generated if these two size mismatch
556 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
558 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
559 break under windows (with msvc6 compilation).
561 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
563 compiling with MSVC6)
565 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * Bugs fix for the Windows build with VC6
567 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
568 needed (only for projects required VTK). If the VTK is included in all
569 projects, there is conflicts with the jpeg lib of vtk when compiling the
570 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
571 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
572 when compiling the gdcm_wrap.cxx file (created by the compilation of the
574 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
575 (like it's already made for the cout use). Otherwise, conflict with the
578 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
581 - comments on the DicomDir::Method related usage added.
582 - now that we use the namespace gdcm, a lot of internal classes do
583 NOT need to be wrapped anymore.
584 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
585 DicomDir::Method) new example added.
587 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
588 * Improve string manipulation. I now inforce the notion of 'DicomString'
589 A DicomString can contain as many \0 as they want
590 and it is *always* of even length.
591 We only support odd length for very rare case.
592 And in the near future this should be removed.
594 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * /binary_write/ gdcm source. Now even on big endian we are writting
596 little endian. This should -heopfully- fix some tests
598 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
599 * Now the dictionary is compiled into gdcm lib. This is a default
600 behavior, thus any dic file specified is picked before failback to
601 the one comiled into lib
603 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
604 * Change internals for gdcmDict. Don't use any 'new' any more.
605 This should definitely solve any leak problem, and we should be
606 as fast as before, as long as don't modify too much the dictionary.
608 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
609 * STYLE: ivars should start with a capital letter.
610 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
611 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
613 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
614 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
615 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
616 new 2004 dictionaries added (thanks to JPR).
617 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
618 * CLEANUP_ROUND (15) for gdcmPixelConvert
619 - RLEFrame::NumberFragments is now of type unsigned int
620 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
621 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
624 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 * Initial work in gathering all transfer syntax accessors. clearly
626 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
627 ivars, but only one transfersyntax (class) ivar with equivalent method on
630 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
631 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
632 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
633 discussed (plus I didn't like having a 2000 lines patch not commited)
635 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
637 * CLEANUP_ROUND (14) for gdcmPixelConvert
638 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
639 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
640 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
642 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
643 anymore and hence avoids storing a copy of PixelConvert::Decompressed
644 into File::Pixel_Data.
646 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
648 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
649 * CLEANUP_ROUND (13) for gdcmPixelConvert
650 Substituted File::ParsePixelData() with PixelConvert::Print() new
652 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
653 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
654 method to those classes.
655 - src/gdcmFile.[cxx|h]:
656 -- Added a ::Print() method.
657 -- PixelConverter is now a reference instead of a member.
658 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
659 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
661 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
663 collaboration diagram and inheritance diagram should be generated with
665 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
666 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
667 pointlessly wrapped (see
668 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
669 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
670 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
671 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
672 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
673 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
674 -- File::Initialise: PixelConverter setup moved away to
675 PixelConverter::GrabInformationsFromHeader()
676 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
677 interpretation moved away to PixelConverter::BuildRGBImage()
679 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
680 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
681 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
683 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
685 displayed on Win32 when a brutal abort() occurs (because of uncatched
686 exception). See TODO new entry of this commit for more on this.
687 * TODO added new entry.
688 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
689 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
690 - HandleColor is no longer called from gdcmFile.cxx
691 - gdcmPixelConvert.cxx clean up on method arguments and internal
692 variable names for semantical coherence.
694 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
695 * Finished lossless transition, not only do we now read all lossless jpeg
696 images, without the need of the Cornwell lib, but we do read them properly now
697 * To reduce code (well to avoid code duplication), I defined a common place
698 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
699 redefine symbols. This is not perfect but this the best solution I found for a
700 compilation time jpeg option.
702 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
703 * Update jpeg ijg lib to support lossless jpeg implementation
704 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
706 * Also added a special copyright for dcmtk since we use their bugfixes.
709 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
711 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
712 matters, as stated in warning note at begining of %include section).
713 * src/gdcmDicomDir*.[cxx|h]: coding style
714 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
715 * src/gdcmJpeg8.cxx: doxygen fix.
716 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
717 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
718 from File:: to PixelConvert::.
720 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
722 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
723 - more code moved away from File:: to PixelConvert::
724 - fat setup of PixelConverter set in place in File::Initialise.
726 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
728 namespace at the file system level. So now you should convert your examples
730 gdcmHeader -> gdcm::Header
731 It would be nice if people keep in mind to no open the namespace, since it
732 allows compilation on broken plateform which were defining common symbol in
733 the standart namespace (like LP, Unknown ...)
735 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
737 The JPEG fragments are now parsed at the same stage than the RLE
738 information. All code related to JPEG is now in gdcmPixelConvert:
739 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
740 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
741 export a gdcmFile:: method. Those are simply global functions
742 (for the time being this is better than having them attach to
743 either gdcmFile:: or gdcmPixelConvert::).
744 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
745 and stores the result in a gdcmJPEGFragmentsInfo.
746 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
747 code (among other stuff) moved away from gdcmFile:; to
750 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
752 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
753 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
754 clean up of RLE related code.
755 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
756 - src/gdcmRLE.cxx removed
757 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
758 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
759 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
760 * CLEANUP_ROUND (9) for gdcmPixelConvert
761 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
762 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
763 away from gdcmFile:: to gdcmPixelConvert::.
765 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
767 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
768 This is because Parse7Fe0 used to parse the pixels to compute the
769 length. This task was passed over to FindDocEntryLengthOB() a long
770 time ago, EXCEPT I had forgotten the OW case...
771 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
772 we just recylce the code for parsing RLE fragments and computing
774 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
775 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
776 with the retired Parse7Fe0().
777 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
778 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
780 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
782 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
783 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
784 - src/CMakeLists.txt: alphabetic order reodering + new entries.
785 * CLEANUP_ROUND (4) for gdcmPixelConvert
786 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
787 to return an unused length.
789 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
790 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
791 this should be cleanner from the plane view. The iostream are erally a pain
792 to use to do simple stuff.
794 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
795 * Redo the compilation of the ijg jpeg library. Now only one source is
796 necesseray. No need to rename file by hand what so ever. CMake handle the
797 copying of the file within different directory, configure header file to
798 modify some symbol. The only addition made to ijg wasd a mangle table so
799 that symbol are different wether we are within 8bits or 12bits.
801 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
802 * Added documentation of vtkgdcmReader on Website:
803 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
804 with it's binary name).
805 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
806 the Website to be more complete.
807 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
808 doxygenated documentation.
809 - Doc/DoxyVtkGdcmReaderExamples.txt added
810 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
811 DoxyVtkGdmReaderExamples.html )
812 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
813 * CLEANUP_ROUND (3) for gdcmPixelConvert
814 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
816 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
817 * CLEANUP_ROUND (2) for gdcmPixelConvert
818 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
820 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * CLEANUP_ROUND for gdcmPixelConvert:
822 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
823 - src/gdcmPixelStuff[h|cxx] removed
824 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
825 - src/CMakeLists.txt changed accordingly
827 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
828 gdcmVersion.py moved to newly created ATTIC related
829 gdcmPython/SetupOldies/ directory.
830 * Autotools clean up:
831 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
832 - autogen.sh configure.in acinclude.m4 python.m4 removed
834 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * src/*.cxx *.h Reference to License.htm fixed to License.html.
836 * Doc/CMakeLists.txt, doxygen.config.in: fix.
837 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
839 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * TODO updated with Mathieu suggestions. I proposed a template for
841 describing TODO entries and used it for new entries.
842 * Added Doc/Website/CodingStyle.html, Developpers.html,
843 DeveloppersPython.html, GdcmDataCvs.html and
844 DownloadVersion0_1.html, DownloadVersion0_3.html.
845 * Some Doc/*.txt Doxygen files (which do not really concern the
846 documentation itself, but the website) moved to html and
847 placed in directory Doc/Website:
848 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
849 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
850 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
851 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
852 * CMakeLists.txt changed accordingly.
853 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
854 DeveloppersPython.html
855 * INSTALL nows refers to Doc/Website/Installation.html
857 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
858 * Added Doc/Website directory, that contains a first raw version
861 2004-09-23 Jean-Pierre Roux
862 * FIX In order not to be poluted any longer by casting problems,
863 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
864 we can now delete[] it safely
865 * VoidArea is now called BinArea (less confusing name),
866 and all the methods called ...VoidArea... are now ... BinArea...
867 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
869 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
871 clear) TagHT, which is an inherited member of gdcmElementSet. It is
872 up to the destructor of gdcmElementSet to clean up TagHt and it's
875 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * Test/CMakeLists.txt: update to follow gdcmData renamings.
877 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
879 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * ENH: added some utility method that builds a flat dictionnary
881 holding all the Dicom entries contained in the recursive structure
882 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
884 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
885 BuildFlatHashTable() that build a flat dictionary.
886 - src/gdcmElementSet.h: added a new private GetTag() accessor.
887 gdcmDocument is now a friend of gdcmElementSet.
888 - src/gdcmElementSet.cxx: clean up.
889 - Example/FlatHashTablePrint.cxx added.
890 - Example/CmakeLists.txt changed accordingly
892 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
894 moved away from gdcmDocEntrySet (since this class is an abstract class
895 acting like an interface). SQDepthLevel and BaseTagKey are now
897 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
898 and associated accessors. Doxygenation of the class.
899 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
901 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
902 Use SQDepthLevel accessor instead. ::Print() adapted.
903 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
904 - src/gdcmDocument.cxx changed accordingly.
906 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
908 - The following is the doxygen comment of the typedef declaration
909 of gdcmTagKey in src/gdcmCommon.h:
910 gdcmTagKey is made to old an "universal" (as in URL, Universal
911 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
912 A dicom tag always has a group and an element, but a set of tags
913 embeded in various (optionally nested) sequences and sharing
914 the same group and element all share the same (group, element)
915 "identifier". Hence the (group, element) cannot be used as an
916 identifier (in gdcm we shall refer to a "TagKey") of a tag.
917 In order to construct a proper tag identifier (i.e. a key) we
918 consider the following definition of a TagKey:
919 - let Group, Element be the string representation of the
920 group and element dicom tag members,
921 - let ItemNumber be the string representation of the integer
922 index of the considered item number of a sequence,
923 Let the key of a tag embeded in a sequence, noted SeqTag, be
925 /ItemNumber#Group|Element
926 where "/", "#" and "|" are characters acting as separators.
927 Then the general form of a gdcmTagKey is given by:
928 Group|Element<SeqTag>
929 where <SeqTag> means NO or many instances of SeqTag.
930 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
933 but the gdcmTagKey of a tag "embeded" is the first item of
934 a sequence, itself nested in the third item of a sequence is the
936 0004|1220/2#0008|0082/0#0008|0090
937 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
938 order to hold the new sequence compatible key. Previously, the
939 GetKey() method would look in the underlying gdcmDictEntry.
940 - src/gdcmDocEntry.cxx:
941 -- constructor now copies the underlying DictEntry key, in the local
943 -- ::Print: displays the member Key, instead of the (group, element).
944 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
945 - src/gdcmDocEntrySet.h:xi
946 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
947 -- now has a new BaseTagKey member.
949 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
950 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
952 This poses the problem with the semantics of the following lines
953 LoadEntryVoidArea(0x0028,0x1201); // R LUT
954 LoadEntryVoidArea(0x0028,0x1202); // G LUT
955 LoadEntryVoidArea(0x0028,0x1203); // B LUT
956 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
957 to the long FIXME note for what the problem is. Nevertheless in
958 order to get things working the dicom dictionary was altered !
959 Please fix things urgently...
960 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
961 information), see above note on moving the member VoidArea. Nevertheless
962 the following entries previously correctly set as US are now inproperly
964 0028 1201 OW IMG Red Palette Color Lookup Table Data
965 0028 1202 OW IMG Green Palette Color Lookup Table Data
966 0028 1203 OW IMG Blue Palette Color Lookup Table Data
967 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
968 of gdcmDocEntry moved to gdcmSeqEntry.
969 * src/gdcmSeqEntry.cxx: STYLE.
971 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * Test/TestAllEntryVerify.cxx minor fix and added comments.
974 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * gdcmPython/testSuite.py: all the test suite in python is now moved
976 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
977 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
978 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
980 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
982 to avoid inclusion recursion until STL is reached.
983 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
984 mecanism. errno.h is not included in gdcm anymore.
985 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
986 (gdcmFormatError now inherits from gdcmFormatUnexpected).
988 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
989 gdcmData/TestAllEntryVerifyReference.txt
990 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
991 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
992 exception_on_error parameter.
993 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
994 - vtk/vtkGdcmReader.cxx changed accordingly,
995 - Example/*.cxx and Test/*.cxx changed accordingly.
997 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
999 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1000 enable_sequences removed from gdcmHeader constructor and dependencies.
1001 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1002 * gdcmPython/demo/PrintHeader.py: dummy fix.
1003 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1004 skip_shadow removed from gdcmHeader constructor and dependencies.
1005 * Example/*.cxx and Test/*.cxx changed accordingly.
1007 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1008 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1009 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1011 2004-07-21 Jean-Pierre Roux
1012 * FIX Now, Parsing and Printing a DICOMDIR do work!
1013 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1015 2004-07-20 Jean-Pierre Roux
1016 * FIX Some brain damaged headers have Zero-Lenght fields
1017 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1019 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1020 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1021 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1022 variable (instance of gdcmDebug) by a definition macro, and the instance
1023 is now in static in the gdcmDebug class
1024 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1025 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1027 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * WARNING: ctest now depends more tightly on gdcmData. You should
1029 check out gdcmData properly for things to run smoothly...
1030 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1031 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1032 we need the pixels not be loaded in order to use the ValEntry
1033 that displays position and size).
1034 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1035 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1036 be deprecated. If you have any doubts about the advantages of a
1037 modern scripting language (read Python) versus grass root C++ (i.e.
1038 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1039 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1040 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1041 Anyhow, consider documenting the gdcmData images in
1042 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1044 * Test/CMakeLists.txt:
1045 - now uses TestAllEntryVerify.cxx
1046 - specific comments on oldACR00001.ima (now renamed in gdcmData
1047 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1048 gdcmData/TestAllEntryVerifyReference.txt
1051 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * src/*.[h|cxx] : typedef clean up
1053 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1054 - TagKey renamed to gdcmTagKey (for external usage)
1055 - VRKey renamed to gdcmVRKey (for external usage)
1056 - removal of typedef duplication.
1057 - Removed all unecessary inline keyword from class inline definitions.
1058 - Some method|function(void) declarations replaced with method|function().
1059 * src/jpeg/libijg12/jdhuff12.c:
1060 - printf polluting ctest removed.
1061 - TAB removal for comminting
1063 - TestAllReadCompareDicom.cxx: added a test that compares all the
1064 images in gdcmDataImages.h with corresponding images in
1065 gdcmData/BaselineDicom/. When baseline images are not present
1066 this test creates them.
1067 Note: we need to validate each reference image, but before that
1068 I'd like to rename them with a more explicit name...
1069 - CMakeLists.txt: changed accordingly.
1070 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1071 including each header needed).
1073 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1074 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1075 test suite to the Example directory. Are concerned:
1080 - TestWriteSimple.cxx
1081 * Test/CMakeLists.txt: added some comments on reasons for black listing
1082 image gdcmData/oldACR00001.ima
1084 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * Test/CmakeList.txt: removed the following from black list (to be coherent
1086 with removal from gdcmData):
1087 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1088 - gdcm-MR-PHILIPS-16.dcm
1090 Added the following because after last cvs update, they cause
1091 ctest -R TestReadWriteReadCompare
1093 - gdcm-MR-SIEMENS-16-1.acr
1095 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1096 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1097 new comments in this file) we temporarily (sigh) move to a weaker
1099 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1100 we don't need to black list the following images anymore:
1101 - 8BitsUncompressedColor.dcm
1103 - US-PAL-8-10x-echo.dcm
1104 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1105 fixes and the beautified code ;-)
1106 This fixes the bug introduced in version 1.42 (when beautifying)
1107 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1108 Note: ctest was blind to this bug (this means we need to still
1109 improve the test suite). The bug could be detected by using
1110 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1112 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1113 and by displaying the (garbage) produced file temp.XDCM...
1115 2004-06-29 Jean-Pierre Roux
1116 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1117 - replace by uggly but working old code :-(
1118 A lot of things should be OK again.
1119 It's really urgent to have a test suite that *tests*,
1120 to prevent Frog's beautifying sessions to break all the stuff
1121 (twice, withing a fortnigh ...)
1123 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1125 redundancy) to added Test/TestReadWriteReadCompare.cxx
1126 * Test/CmakeList.txt: because the compare test of
1127 Test/TestReadWriteReadCompare.cxx fails, the following images are
1128 black listed: - 8BitsUncompressedColor.dcm
1130 - US-PAL-8-10x-echo.dcm
1131 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1132 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1133 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1134 and ad-hoc kludge. This kludge is now removed, and on encountering
1135 such an image (OB field brain damaged) we set errno. Then in
1136 ::FindDocLength() we "fix" the length as being ALL what remains
1137 in the file (until EOF). We then proceed, hoping for the best...
1138 This fixes a SegFault in ShowDicom when trying to write such an
1140 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1141 (because TestWriteRead breaks on it, after a non conformal commit?).
1142 ctest now runs properly, except for MakeDicomDir (which was always
1143 broken) and the Python related stuff (still not fixed).
1145 2004-06-24 Jean-Pierre Roux
1146 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1147 FIX : Test/TestReadWrite now iterates on all the file names
1148 (instead of infinite loop)
1149 ENH : Test/TestWriteRead now iterates on all the file names
1151 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1154 2004-06-24 Jean-Pierre Roux
1155 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1156 when SamplesPerPixel =3
1157 - now Write is no longer confused by
1158 'BitsAllocated = 12" and 'BitsStored=12"
1159 - "UN" value representation Elements are now written correctly
1160 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1161 ENH : - now gdcmHeader has its own Write methods
1162 (in order to split the job that has not to be done
1165 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1167 loop on the same image until memory went out.
1168 Note: this means we still have gobs of memory loss in PrintDocument
1169 * src/gdcmDocument.cxx: fixes problem on parsing on file
1170 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1172 2004-06-24 Jean-Pierre Roux
1173 FIX : Write - All the Sequences and Sequence Item are now written
1174 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1175 is added a the end, when necessary.
1176 - A lot of brain-damaged images, that were read correctly are
1177 now written correctly
1178 - length compatible BinEntry are now loaded correctly
1179 (even for odd groups)
1180 Note : only Explicit Value Representation was checked.
1181 (question : is implicit VR really necessary for gdcm ?)
1183 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * DEVELOPPER: added a proposition of coding style.
1185 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1188 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1189 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1190 Use the gdcmDocEntry::Print() and Write() instead.
1191 * src/gdcmDocument.cxx: bug fix.
1193 2004-06-22 Jean-Pierre Roux
1194 FIX : gdcmDocument.cxx
1195 - Now we do recognize the JpegLossLess format (there was a misstyping in
1196 code 'beautyfication' :-(
1197 - Now we automaticaticaly load the Luts, if any
1199 2004-06-22 Jean-Pierre Roux
1200 In order : to write Sequences, whatever their imbrication level,
1201 : to allow user to create his own Sequences
1202 a lot of modif where necessary (adding, moving, or virtualising methods)
1204 WARNING : save your own sources *before* cvs up !
1207 ADD virtual void Write(FILE *fp, FileType filetype);
1210 ADD virtual void Write(FILE *fp, FileType filetype);
1211 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1214 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1215 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1216 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1217 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1218 ADD std::string GetEntryByName(TagName name);
1219 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1221 std::string vr = "unkn",
1222 std::string fourth = "unkn",
1223 std::string name = "unkn");
1224 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1225 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1226 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1227 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1228 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1229 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1230 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1231 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1234 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1235 ADD virtual std::string GetEntryByName (TagName tagName);
1236 ADD virtual std::string GetEntryVRByName (TagName tagName);
1237 REM virtual bool Write(FILE *, FileType);
1238 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1239 FILE *_fp, FileType type);
1240 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1241 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1242 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1243 REM virtual std::string GetEntryByName (std::string tagName);
1244 REM virtual std::string GetEntryVRByName (std::string tagName);
1245 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1246 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1247 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1249 std::string vr = "unkn",
1250 std::string fourth = "unkn",
1251 std::string name = "unkn");
1252 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1253 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1254 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1255 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1258 ADD virtual void Write(FILE *fp, FileType filetype);
1261 ADD virtual void Write(FILE *fp,FileType filetype);
1264 ADD virtual void Write(FILE *fp, FileType filetype);
1265 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1266 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1267 REM std::string GetEntryByName(TagName name);
1270 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1272 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1273 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1274 The default constructor invoked by the line
1275 gdcmHeader *f1 = new gdcmHeader( header );
1276 was gdcmHeader::gdcmHeader(bool) instead of the expected
1277 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1278 Hence the parsing wasn't executed... See also below.
1279 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1280 as explicit constructor didn't do the trick to fix the above problem.
1281 Could anyone explain why ?
1282 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1283 properly calls gdcmValEntry::Print() (that was weed out from
1284 code related to gdcmBinEntry).
1286 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * In order to fix memory leaks:
1288 - Test/TestWriteSimple.cxx: added cleaning of free store through
1290 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1291 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1292 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1293 (through the call to ::AddDicomDirMeta()) or the destructor
1294 would crash when deleting uninitialized ::metaElems].
1295 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1296 - src/gdcmDocument.cxx:
1297 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1298 from dynamic stores.
1299 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1300 was causing memory leaks.
1301 - src/gdcmSQItem.cxx:
1302 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1303 cleanly handled with polymophism: sorry but my milage is low).
1304 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1305 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1306 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1307 This avoids SegFaulting.
1308 - src/gdcmSQItem.h: coding style.
1310 - Test/TestWriteSimple still severely sucks. The output image content
1311 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1312 damaged when displayed with vtkgdcmViewer.
1313 - on memory leaks: TestWriteSimple leaks really less (see entry
1314 of 2004-06-18 in Changelog file for the call to valgrind).
1315 - on segfaults: ctest now passes all the tests but one (no more
1317 * Erroneous leading white fix:
1318 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1319 white[s] (as opposed to from >> xxx, that removes it [them].
1320 - src/gdcmTS.cxx: ditto.
1321 - gdcmPython/testSuite.py: dirty related kludge removed.
1322 * src/*: remaining references to gdcmParser removed.
1323 * src/*[cxx|h]: added copy[way]left header.
1326 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1327 * In order to fix writing of dicom files:
1328 - Test/TestWriteSimple.cxx: a simpler example of writing.
1329 - Test/CMakeLists.txt changed accordingly.
1330 - src/gdcmDocument.cxx:
1331 -- The destructor now recursilvely removes potential sequences.
1332 -- Bug fix in ::IsJPEG2000()
1333 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1334 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1336 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1337 to only declared) and build on top of
1338 ::GetDocEntryByNumber(guint16, guint16).
1339 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1340 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1341 for usage in destructor and treatement of promotion in
1342 ::ReplaceOrCreateByNumber().
1343 - src/gdcmSQItem.cxx: destructor should better handle his job.
1344 Test/TestWriteSimple now runs (or at least it DOES something).
1345 * We can now start hutting memory links. A good starting point is:
1346 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1347 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1348 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1350 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * Valgrind note: after Mathieu Malaterre teached me how to read
1352 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1354 Using gcc, you can force the STL to use malloc and to free memory as
1355 soon as possible by globally disabling memory caching.
1356 With 3.2.2 and later, you should export the environment variable
1357 GLIBCPP_FORCE_NEW before running your program.
1358 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1359 simply vanish (it is still not clear to me, whether this means that
1360 STL std::string leaks or if valgrind believes it leaks...).
1361 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1362 running bin/gdcmTests makeDicomDir):
1363 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1364 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1366 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1367 SegFaulting (I drowned in DicomDir related code when trying to
1368 understand why the list is empty...).
1369 * src/gdcmDocument.h: first BSD license header try.
1370 * Doc/License.txt added.
1372 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * src/gdcmDocument.[h|cxx]:
1374 - Clean up of the Transfer related predicates. They are now all based
1375 on new method isGivenTransferSyntax, that (should) handle properly
1376 the padding problem.
1377 - general clean up, simplification, and coding style.
1378 - Specific clean up of Parse7FE0() (umproperly named actually).
1379 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1381 2004-06-14 Jean-Pierre Roux
1383 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1384 - fix the display of SQItem ordinal number
1385 - add the GetSQItemByOrdinalNumber method
1386 - remove some useless never written private methods
1388 2004-06-14 Jean-Pierre Roux
1390 - adding a constructor taking a gdcmDocEntry as an input param
1391 - ReplaceOrCreateByNumber now returns :
1392 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1393 a gdcmValEntry * if a string value is passed as a param
1395 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1396 according to the param type (no longer sets a gdcmDocEntry)
1397 - GetValEntryByNumber, GetBinEntryByNumber added
1398 - NewValEntryByNumber and NewBinEntryByNumber added
1400 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1402 - GetSQItemNumber and SetSQItemNumber added, to provide
1403 a (relative) Item identier inside a given Sequence
1404 \warning : some pb remaining around this number
1406 - AddEntry now takes the Item Number as a param
1408 - adding a constructor taking a gdcmDocEntry as an input param
1410 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * Memory leak hunt with the following command:
1412 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1413 --show-reachable=yes gdcmTests PrintDocument
1414 It looks like many (all?) leaks are due to the STL (or a bad usage
1415 of the STL. The lines producing the leaks now have a comment with
1416 a "MEMORY LEAK" tag: you can retrieve them with
1417 grep "MEMORY LEAK" src/*
1418 Here are two typical examples which I can't help fixing:
1423 char * test = "babo";
1424 name = test; //// <--- valgrind detects 960 bytes lost in
1425 //// call to std::string::operator=(char const*)
1426 name.clear(); //// Doesn't help !
1434 std::cout << "Type a bunch of characters followed by RETURN: ";
1435 getline(std::cin, line); //// <--- valgrind dectects a loss
1436 //// of 1320 bytes in call to
1437 /// std::basic_istream<>& std::getline<>
1443 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1444 * src/gdcmHeader.[cxx|h]:
1445 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1446 and related, moved away to gdcmDocument.
1447 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1448 the corresponding protected accessors of inherited class
1449 gdcmDocument, removed ! As a consequence gdcmFile had to be
1450 declared friend of class gdcmDocument (see below).
1451 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1452 - Clean up of undefined or unused methods.
1453 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1454 account the changes to gdcmHeader.h).
1455 * src/gdcmDocument.h:
1456 - gdcmFile is now a friend class (in order to take into account the
1457 changes to gdcmHeader.h).
1458 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1459 (see changes to gdcmHeader.h).
1460 - Accessors (reading on the form GetEntry*) are now public.
1461 - Clean up of undefined or unused methods.
1462 * src/gdcmDocument.cxx:
1463 - adaptation to changes to gdcmDocument.h
1464 - ::OpenFile now writes a verbose message when file cannot be opened.
1465 - some std::string properly set to VRKey
1466 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1467 references to gdcmDocument.
1468 * Test/TestFindTags.cxx: changed accordingly to above changes.
1469 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1470 cvs repository gdcmData.
1472 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1474 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1475 conflicts with gdcmValEntry::voidArea.
1476 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1477 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1478 Value representation between StringRepresentable and BinaryRepresentable.
1479 * src/gdcmDocument.cxx:
1480 - method ParseDES: proper indentation restored and usage of
1481 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1482 - method LoadDocEntry: the fingerprint left in the SetValue() of
1483 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1484 removed. Reverting to previous code segment with the proper
1485 dynamic_cast< gdcmValEntry* >.
1486 Note: this was (partially) breaking the python test suite
1487 (gdcmPython/testSuite.py) that made usage of the above
1488 fingerprint to check presence of "Pixel Data".
1489 * src/gdcmDocEntry.h: coding style.
1490 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1491 now taken into account.
1492 * gdcmPython/gdcm.i: adaptation to the new internal representation
1493 of gdcm (exit gdcmParser, hello gdcmDocument).
1494 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1496 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1497 anymore, but instead prints the loaded Python dictionary.
1498 * .... alas, the python testSuite is still broken.
1500 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1503 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1504 * src/gdcmUtil.h : export methods
1506 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1509 * Initial addition of automatic python testing
1510 * Initial addition of automatic image comparison
1512 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1514 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1516 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1517 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1518 * Test/ShowDicom.cxx : bug fix for msvc compilation
1519 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1521 2004-05-04 Jean-Pierre Roux
1522 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1523 new concepts (and new classes) :
1524 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1525 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1526 - Sequence Doc Entries (gdcmSeqEntries)
1527 a Sequence is composed of Items.
1528 Each item is a set of Doc Entries (this is recursive)
1529 The non uniqueness of the 'Dicom tag' is due to this recursivity
1530 (never taken into account)
1531 Our unability to add a new 'entry' in the header
1532 at the proper location (neither in the H-Table (map or multimap),
1533 nor in the Chained List is also due to this recursivity.
1534 Don't try, right now, to use/modify/compile these new sources :
1535 nothing is finished.
1536 We just commit all the stuff, 'as is', in order not to loose it.
1538 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1539 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1541 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1542 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1543 file prefix (SetFilePrefix)
1545 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1546 * Add a new test: ShowDicom, for now this is just the c++ version of
1547 checkRead.sh, later it will be able to compare the image read against a
1549 * Replace the DEBUG on the stack with a global entry in cmake interface:
1550 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1552 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1553 * Add an example subdir, with a real example on how to read + write a
1556 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1557 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1558 * Doc/CMakeLists.txt: the main page is now properly differentiated
1559 between the developper and user version.
1560 * Doc/doxygen.config.in: dropped search related obsolete flags
1561 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1563 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * DEVELOPPER: added some helpfull comments for compile/test/install
1567 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1568 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1569 src directory, now generated in the build dir.
1570 2. Tests as mentionned smarter
1572 4. Add a new method in gdcmDict that return the PubDict by name
1573 this is interesting for 3rd party lib like ITK,
1574 where we could set the institution name / patient name...
1576 * ENH: 1. Now the test suite is working for real
1577 2. All binaries are now output in the gdcm-bin directory
1578 (this was not true before)
1580 2004-04-28 Jean-Pierre Roux
1581 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1582 SeQuence indented printing of Dicom Header.
1583 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1584 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1585 Computation of SQDepthLevel is now part of gdcmHeader constructor
1586 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1587 tree-like structure of a Dicom Header.
1588 * FIX Test code cleaning
1590 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * ENH: Adding automatic testing
1592 1. Need a DartConfig.cmake to submit to public
1593 2. Add a test driver gdcmTest.cxx
1594 3. gdcmTestMain, an helper for the main test driver gdcmTest
1595 4. Files in Test don't have a main anymore, this becomes interesting
1596 when we add more and more tests, thus dsw don't have to load
1598 * ENH: Adding a GDCM_DATA_ROOT for testing
1599 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1600 one file instead of seven + some small cleanup
1602 2004-04-22 Jean-Pierre Roux
1603 * ENH Minor changes to the Print() methods.
1604 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1605 Header printing. Example given with :
1606 > PrintHeader fileName 2 new
1607 (SQ based tree-like structure still to be done for the Header ...)
1609 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1610 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1611 1. I have added some unsigned where needed
1612 2. Some function parameter not used -> (void)
1613 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1614 4. g++ don't like character '\' in comment
1615 5. #define jpeg_create_decompress jCreaDecompress
1616 this really need to be fixed
1617 6. virtualize destructor of gdcmObject ... leakage
1618 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1619 this also really need to be fixed
1620 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1621 remove compression file
1622 (as we only do decompression, right ?)
1623 * ENH: Change malloc/calloc/free with c++ equivalent
1625 2004-04-21 Jean-Pierre Roux
1626 * FIX gdcmHeaderHelper::GetXSpacing
1627 when a single value is found (bug ?), xpacing is now
1628 defaulted to yspacing
1630 2004-04-19 Jean-Pierre Roux
1631 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1632 * ENH add parameters :
1633 bool exception_on_error = false,
1634 bool enable_sequences = false,
1635 bool ignore_shadow = false
1636 to the gdcmFile constructors to be full gdcmParser compliant
1637 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1638 to allow reading of PAPYRUS 3.0 files
1640 2004-04-06 Jean-Pierre Roux
1641 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1643 2004-04-02 Jean-Pierre Roux
1644 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1645 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1646 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1648 2004-03-30 Jean-Pierre Roux
1649 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1650 for ACR file, written out as DICOM files (hope so...)
1652 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1653 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1654 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1655 moved to base class gdcmParser and only the specialisation is kept
1657 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1658 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1659 already does the job.
1660 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1661 (to be consistent with gdcmParser::WriteEntries).
1663 2004-03-30 Benoit Regrain
1664 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1665 upate of the object's instance. It's passed to 2 in the unfavorable
1666 case : one in the ExecuteInformation, one in the ExecuteData
1668 2004-03-29 Jean-Pierre Roux
1669 * ENH : Check on file type to be written moved
1670 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1671 * FIX : gdcmObject::ResetBoundaries now stops properly
1672 when end-of-list is reached
1673 : gdcmVersion modified (as Benoit Regrain asked)
1675 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1677 * src/gdcmUtil.cxx: added forgotten iostream include.
1678 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1679 equivalent to ExplicitVR in existing code).
1681 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1683 now contains all the gdcmGlobal related code.
1684 * minor coding style and doxygenation changes.
1686 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1687 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1688 now contains all the Debug related code.
1689 * minor clean-up of includes in src/*.cxx
1690 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1691 CreateCleanString) removed.
1692 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1693 * Doc/DoxyMainPageUser.txt added.
1694 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1695 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1696 src/gdcmDirList.cxx)
1698 2004-03-24 Jean-Pierre Roux
1699 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1701 2004-03-23 Jean-Pierre Roux
1702 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1703 big endian made volumes
1704 * ENH Now gdcmParser constructor and destructor are protected to forbid
1705 end user to instanciate class gdcmParser
1706 (only gdcmHeader and gdcmDicomDir are meaningfull)
1708 2004-03-22 Benoit Regrain
1709 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1710 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1711 gdcmSerie to gdcmDicomDirSerie
1713 2004-03-19 Jean-Pierre Roux
1714 * ENH Now the tree-like structure describing a DICOMDIR comming from
1715 an already existing DICOMDIR file is consistent with
1716 the home-made tree-like structure build ex-nihilo
1717 or build from the files held (recursively) in a Directory
1718 functions gdcmDicomDir::CheckBoundaries()
1719 gdcmObject::SetBoundaries() added
1721 2004-03-17 Jean-Pierre Roux
1722 * REM (Eric Boix bug) : removal of meaningless
1723 gdcmDicomDirImage::NewImage function.
1724 * FIX now file names and directory name are written properly in the
1726 * FIX now gdcmDicomDir constructor may be call without any trick
1729 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1731 of gdcmDicomDirImage::NewImage as empty function.
1733 2004-02-28 Jean-Pierre Roux
1734 * ENH add gdcmDicomDir:NewPatient
1735 add gdcmDicomDirPatient:NewStudy
1736 add gdcmDicomDirStudy:NewSerie
1737 add gdcmDicomDirSerie:NewImage
1738 to allow making gdcDicomDir object.
1739 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1740 (as opposite to the gdcmHeader chained list)
1742 2004-02-11 Benoit Regrain
1743 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1744 when using from python
1746 2004-02-10 Benoit Regrain
1747 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1748 * FIX : in gdcmDicomDir when the directory is empty
1749 * ENH : add callback and methods to get the progression of dicomDir
1752 2004-02-06 Jean-Pierre Roux
1753 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1754 - GDCM_META added to gdcmDicomDirType
1755 - class gdcmMeta created
1756 * ENH : - A brief summary is now displayed at the beginning of
1757 'testDicomDir' to help disaster magnitude estimation
1758 * REM : Now useless Test/explDICOMDIR.cxx
1760 2004-02-05 Benoit Regrain
1761 * ENH : add methods in gdcmObject to get the hash table or the list of
1763 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1764 * FIX : wrapping python for TagHeaderEntryHT
1766 2004-02-04 Benoit Regrain
1767 * FIX : even length for some strings when writting the dicom dir
1768 * FIX : sort the images in the dicom dir
1769 * FIX : Bug fix for python use of dicom dir
1770 * ADD : a python demo
1772 2004-02-04 Jean-Pierre Roux
1773 * FIX : Final solution (?) for icone embedded images
1774 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1775 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1776 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1777 gdcmData/gdcm-MR-SIEMENS-16.acr1
1778 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1779 to make full checking easier
1781 2004-02-04 Benoit Regrain
1782 * FIX : WriteEntries : coding style & logic in parameters
1783 * FIX : Set the elements to create the DicomDir in a dictionary file
1785 2004-02-03 Benoit Regrain
1786 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1787 * gdcmDicomDir : add the load of directory
1788 * Bug fix and print add-on
1790 2004-02-03 Jean-Pierre Roux
1791 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1792 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1793 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1794 * FIX gdcmParser.cxx : 'group length' elements are now considered
1795 as integers, even for shadow groups, when file is Implicit VR
1797 2004-02-02 Jean-Pierre Roux
1798 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1800 of the last synonym :-(
1801 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1803 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1804 * FIX taking into account the possible 7fe0,0010 multiplicity
1805 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1806 to allow removal of references to 7fe0,0010, to deal with
1807 ACR-NEMA images, when 0028,0200 is meaningfull
1809 2004-01-31 Jean-Pierre Roux
1810 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1811 no longer writes 'Un' on disk
1812 * FIX SQ elements with actual length are now dealt with corectly
1813 * FIX gdcmFile::WriteBase make the difference, for color images, between
1814 the length (for Palette expanded images)
1815 and Raw Length (non expanded image + Palette)
1816 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1817 (that broke Write). Replaced by UL.
1818 Aware user will reload the field if he
1819 thinks it's necesssary
1821 2004-01-30 Jean-Pierre Roux
1822 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1823 when 'dirty Acr' is found, to be compliant with the new
1824 IsReadable() methods.
1826 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1827 (no DOUBLE images in kosher DICOM,
1828 but so usefull for people that miss them ;-)
1830 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1831 DICOMDIR related utilities (not checked as Windoze compliant)
1833 2004-01-28 Jean-Pierre Roux
1834 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1836 2004-01-27 Jean-Pierre Roux
1837 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1838 to allow skipping the shadow elements, to save memory space.
1839 The TRUE value for this param has to be used
1840 with a FALSE value for the 'enable_sequence' param.
1841 ('public elements' may be embedded in 'shadow Sequences')
1842 * gdcmHeader methods now deal with 'embedded icones images' in the header
1843 (even when an 'icone image sequence' is announced by the
1844 element (0x0088,0x0200), but there is NO icone at all ...
1846 * gdcmHeader sometimes Image Location value doesn't follow
1847 the supposed processor endianity (see gdcmData/cr172241.dcm).
1850 * gdcmHeader add the method
1851 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1852 to get *all* the Header Entries with the same tag.
1853 GetHeaderEntrySameName is probabely *useless*
1854 (no meaning : Name is *not* an identifier within the Dictionnary)
1856 2004-01-26 Benoit Regrain
1857 * Bug fix in the print of hexadecimal representations. Remove long fields
1858 in the print and add a third level of print to print them
1860 2004-01-23 Benoit Regrain
1861 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1862 * Bug fix on test suite after remove the strip made on not string fields
1863 * Split the IsReadable method between gdcmParser which test that the file
1864 is dicom and gdcmHeader which test that it's an image file
1866 2004-01-22 Benoit Regrain
1867 * DicomDir : clean code, add methods, set variables in protected or private
1868 * gdcmUtil : bug fix for the clean string method
1870 2004-01-19 Benoit Regrain
1871 * Add the use of shadow dictionaries
1872 * bug fix and coding style
1874 2004-01-19 Benoit Regrain
1875 * src/gdcmFile.cxx : bug fix concerning the close of file
1876 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1877 * Add the update of header entries using the shadow library
1879 2004-01-19 Benoit Regrain
1880 * removal of file gdcmHeader2.cxx
1881 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1882 inheriting from gdcmParser. This split is to prepare the integration
1883 of dicom dir parsing
1884 * bug fix under python
1886 2004-01-16 Jean-Pierre Roux
1887 * REM removal of class gdcmHeaderEntrySet
1888 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1889 * ADD add file gdcmHeader2.cxx
1890 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1892 2004-01-15 Benoit Regrain
1893 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1894 entries created while parsing the header. Thus, they will be destroyed
1895 when the gdcmDictSet will be destroyed
1896 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1899 2004-01-15 Benoit Regrain
1900 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1901 made a fatal error because of the memory release at the end of program.
1902 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1903 some memory and vtk seems to have some problems with that.
1904 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1906 2004-01-14 Benoit Regrain
1907 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1908 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1909 * src/*.[h|cxx] : make changes due to class name changes
1910 * gdcmPython/demo/*.py : bug fix due to method names
1912 2004-01-13 Benoit Regrain
1913 * src/*.[h|cxx] : coding style
1914 * vtk/*.[h|cxx] : coding style
1916 2004-01-13 Benoit Regrain
1917 * gdcmPython/testSuite.py : test the readable flag of file for tests
1918 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1919 It's lied to the stl compilation by MSVC (windows, always windows...)
1920 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1922 2004-01-12 Benoit Regrain
1923 * src/*.h : add comments
1924 * src/gdcmDictSet.h : set the method BuildDictPath in public
1925 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1926 directly setted in the source code
1927 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1930 2004-01-09 Benoit Regrain
1931 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1932 * setup.py : use a reference to gdcmVERSION
1934 2004-01-07 Benoit Regrain
1935 * Modification to compile with the distutils.
1938 2003-12-10 Benoit Regrain
1939 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1940 can use a gdcmHeaderHelper to load data
1941 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1942 made in the source code
1944 2003-12-10 Benoit Regrain
1945 * Update Windows projects and .cvsignore files
1947 2003-11-12 Jean-Pierre Roux
1948 * ENH gdcmHeader constructor has one more parameter (default value : false)
1949 that allows the user to 'go inside' the SeQuences only
1951 gdcmElValSet:Print takes it into account
1953 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * ENH: Update gdcmPython/CMakeLists
1955 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1956 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1958 2003-11-10 Jean-Pierre Roux
1959 * FIX : gdcmHeader::LoadElements is now based
1960 on the ListTag listElem member,
1961 not longer on the TagElValueHT tagHt member
1962 * ENH : PrintPubElVal shows (temporarily) both results,
1963 with the tagHt member and the listElem member.
1964 (it's easier to 'see' the problems when using Printheader)
1966 * FIX : old private member LgrElem is now splitted into
1967 ReadLength : Length actually found on disk (updated only
1968 if bug fixing is necessary), for internal
1970 UsableLength : Updated by FixFoundLength, to fix a bug
1971 or to allow Parser going on.
1972 Will allow to re-write a kosher header when a SeQuence
1973 with a length (not 0000) is found
1974 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1975 because gdcmElValSet::Add does not update ListElem
1978 2003-11-07 Jean-Pierre Roux
1979 * FIX misstyping in Transfert Syntax name table
1980 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1981 when they have an actual length (not 0000 nor FFFFF)
1982 (Nobody should care of it, but DICOMDIR explorers)
1984 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1987 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * ENH: vtkGdcmReader now supports LUT !
1989 (vtkgdcmViewer for now is not able to use them though)
1991 2003-11-05 Jean-Pierre Roux
1992 * in testSuite.py : new files names for checking the package
1993 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1994 that returns the pixel area size to the *aware* (vtk) user
1995 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1997 2003-11-05 Benoit Regrain
1998 * in testSuite.py : Modify the rules for checking the paths
1999 : Explicit error messages
2000 * in __init__.py : Related modif
2002 2003-11-03 Jean-Pierre Roux
2003 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2004 to be used by aware (vtk) users that want to manage
2005 LUT (and no to turn the PALETTE image into an RGB pixels one)
2006 * GetPixelType now returns 8U for 24 Bits images
2007 (vtkGdcmReader compliant)
2009 2003-10-31 Jean-Pierre Roux
2010 * Removal of *all* gdcmData images and add them again
2011 in order to loose the 'history' of un-anonymised images
2013 2003-10-31 Jean-Pierre Roux
2014 * RMV : removal of useless jBitsInJsample.h
2015 for both 8 and 12 Bits JPEG Lossy Libraries
2017 2003-10-31 Jean-Pierre Roux
2018 * ENH : Add the functions gdcmFile::GetImageDataRaw
2019 gdcmFile::GetImageDataIntoVectorRaw
2020 that act as GetImageData and GetImageDataIntoVector
2021 except the making of an RGB Plane from Gray Plane + LUT
2022 Intended to aware (vtk) users who know how to manage
2025 GetLUTRGBA return a R,G,B,A LUT if any
2026 lgrTotaleRaw gives the 'Raw' length
2027 GetImageDataRaw returns the gray Plane
2028 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2029 (They stay Grey, just like with other Dicom viewers :-(
2031 2003-10-30 Jean-Pierre Roux
2032 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2034 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2035 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2036 being coherents dicom files.
2038 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2041 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2042 * ENH: Two steps is necessary to please VC++ compiler...
2043 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2044 * ENH: Add include dir to medcon lib
2045 * FIX: only one function is being exported for now !
2046 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2048 2003-10-29 Jean-Pierre Roux
2049 * adding gdcmHeader::GetLUTRGBA
2050 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2051 --> Mathieu, the modif u're waiting for is not yet committed
2052 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2054 2003-10-27 Jean-Pierre Roux
2055 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2056 00191113.dcm DermaColorLossLess.dcm
2057 MxTwinLossLess.dcm RadBWLossLess.dcm
2058 * ENH: For version prior to vtkImageViewer2 -r 1.19
2059 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2061 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * Removal of ido stuff in CMakeLists.txt
2064 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2065 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2066 * FIX: remove a call to ->Modified ... see comments
2067 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2069 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2070 * FIX: Problem with path for libvtkgdcmPython
2071 * ENH: Try adding a search script for python site-package
2072 * RMV: Remove some file from medcon lib that are not necessary
2073 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2074 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2075 * FIX: More pragma disable fro VC++,
2076 I don't think I break something as it is also disable in VTK/ITK.
2077 But it fasten debug compilation time.
2079 2003-10-23 Jean-Pierre Roux
2080 * gdcm now deals with 16 Bits Run Length Encoded images
2081 (they are compressed as 2 planes images,
2082 one for the high Bytes, the other for low Bytes)
2084 2003-10-22 Jean-Pierre Roux
2085 * Now CheckRead takes into account :
2086 - the bugged 'Leonardo' Siemens images
2087 - the XA images, sent thru the burning VPRO station
2088 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2091 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2092 * FIX: When copying a Makefile.am to CMakeLists.txt
2093 one should remove the '\'
2095 2003-10-22 Jean-Pierre Roux
2096 * in gdcmData adding a bugged 'Leonardo' Siemens image
2097 (wrong lengths in header)
2098 OK with gdcm, KO with the other viewers :-)
2099 * add a GE dlx XA image, thru the VEPRO burning station
2102 2003-10-21 Jean-Pierre Roux
2103 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2104 for a brutal checking of vtkgdcmViewer compliance
2106 2003-10-21 Jean-Pierre Roux
2107 * add the files for 'xmedcon' Jpeg Lossless library
2108 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2110 2003-10-21 Jean-Pierre Roux
2111 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2113 2003-10-21 Jean-Pierre Roux
2114 * garbage Siemens 'Leonardo' images dealt with
2115 (the patch is easy to remove)
2116 * cosmetic changes to avoid warnings
2118 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2119 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2120 no need to press 'r' now.
2122 2003-10-20 Jean-Pierre Roux
2123 * upgrade of checkRead.sh checkWrite.sh according
2124 to new Jpeg Lossless decompressor
2125 * add US.3405.1.dcm, a genuine RGB medical file ...
2126 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2127 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2129 2003-10-15 Jean-Pierre Roux
2130 * general anonymisation in gdcmData
2131 * adding the 'color files' from
2132 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2133 * adding some well knowed bugged-header images
2134 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2135 waiting for their inclusion in Python testsuite
2137 2003-10-15 Jean-Pierre Roux
2138 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2139 no longer seg faults when file is not found
2141 2003-10-14 Jean-Pierre Roux
2142 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2145 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2146 * TODO: *.in file to genereate a UseGDCM later
2148 2003-10-14 Jean-Pierre Roux
2149 * Some supposed-to-be Dicom Images have no preamble.
2150 OpenFile takes it into account
2151 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2152 * Missing elements added in dicomV3.dic
2153 (just to be affraid : have a look at
2154 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2155 and do it again next year ;->
2157 2003-10-13 Jean-Pierre Roux
2158 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2159 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2160 But there are NOT. It's fixed !
2162 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * FIX: "jpeglib.h" was not found on VC++
2164 * FIX: vtkgdcm was not being installed
2166 2003-10-10 Jean-Pierre Roux
2167 * ENH : OpenFile closes the file if it *really* doesn't look like
2168 an ACR-NEMA / DICOM one.
2169 * FIX : testWrite no longer writes an empty file if the source file
2170 is not gdcm Readable
2171 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2174 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * FIX: CMake generate now documentation
2176 * ENH: out of source doc build !
2177 * ENH: Generate both user and dev documentation
2178 * ENH: Should work on windows too
2179 * ENH: Only one doxygen config.in file is needed
2180 * FIX: make install should be ok now on ùnix plateform
2181 * FIX: PATH to dictionary was wrong (missing /)
2182 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2184 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2185 * vtkGdcmReader is now able to read rgb dicom file.
2186 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2187 * added a gdcmViewer to vtk test, use mouse to control
2188 window level & window width
2190 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2191 * CMake-ification of gdcm, we have now two build system
2192 * FIX: on cygwin Wsock32 doesn't exist
2193 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2195 2003-10-06 Emanuel Ollart
2196 * FIX : compilation process wad broken.
2197 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2199 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2200 * change gdcmViewer -> vtkgdcmViewer
2201 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2203 2003-10-06 Jean-Pierre Roux
2204 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2205 ( e.g : well known GE images with a wrong elem length,
2206 : Philips MRI Images with a wrong Huffman table)
2207 * still to be done : allow the reading of bugged LEONARDO Siemens images
2209 2003-10-03 Jean-Pierre Roux
2210 * Odd length strings are padded with '\0' (not with spaces,
2211 to remain compliant with already defined strings,
2212 like Transfert Syntax UID and others)
2214 2003-10-03 Jean-Pierre Roux
2215 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2216 to allow displaying RGB images (not only by affim ;-)
2218 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * vtkGdcmReader is now able to read rgb dicom file.
2220 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2222 2003-10-03 Jean-Pierre Roux
2223 * A few nasty patches to allow the reading of a lot of nasty images
2224 ( e.g : well known GE images with a wrong elem length,
2225 : Philips MRI Images with a wrong Huffman table)
2226 * still to be done : allow the reading of bugged LEONARDO Siemens images
2228 2003-10-03 Jean-Pierre Roux
2229 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2231 2003-10-03 Jean-Pierre Roux
2232 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2233 to allow displaying RGB images (not only by affim ;-)
2235 2003-10-03 Jean-Pierre Roux
2236 * gdcmFile::GetImageDataIntoVector now
2237 - deals with MultiFrames MultiFragments Run Length Encoded files
2238 - deals with YcBcR (YBR_FULL) files
2239 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2240 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2242 (no sample found :-(
2244 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2245 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2246 Two reasons: - clear things
2247 - third parties acces gdcm through header files, so won't
2248 suffer anymore VC++ complains
2250 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2251 * add argv[1] in testvtkGdcmReader.cxx
2254 2003-09-24 Jean-Pierre Roux
2255 * The lines are now eigthy characters long.for
2256 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2258 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2259 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2260 char* to std::string. Thus, the use of strdup becomes useless. (see
2261 previous commis of Malaterre)
2262 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2263 before the last Malaterre's commit.
2265 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2266 * This commit should fix the Debug building under VC++, the problem
2267 was mainly a mixture of debug and release lib being loaded at startup.
2268 * I also remove a depency to a specific C function: strdup. Because I had
2269 to force the link to msvcrtd (whereas strdup is in libc).
2271 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2272 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2273 located in the gdcmCommon.h file. All use of reference of tha has been
2274 changed to now use the variable GDCM_UNFOUND.
2276 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2278 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2279 Dicom dictionary. The test suite can now be run again. Note:
2280 I'm note very happy with the " (RET)" changes. I believe this
2281 RETAINED comment should be dropped when parsing the dictionary.
2282 - PACKAGER corrected
2284 - AUTHORS updated and now in alphabetical order
2285 * Makefile.am now exports gdcm.dsw for Windoze users.
2287 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2288 * cygwin complains about missing std:: in subdir Test/
2290 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * remove some methods that are now in gdcmHeaderHelper
2293 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * vtkGdcmReader set spacing and origin correctly
2296 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2297 * Fix a few delete/delete[] mismatch
2299 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2300 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2301 interpretation to data given by gdcmHeader. For instance there are
2302 heuristics to get informations (look at different places).
2303 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2304 sorting DICOM images based on different strategies.
2305 * modified Makefiles accordingly.
2307 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2308 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2309 when building in debug mode
2310 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2311 src/win32/gdcmdll.dsp
2312 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2314 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2315 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2318 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2319 * src/win32/libgdcmjpeg12.dsp was not dos format
2320 * src/win32/libgdcmjpeg12.dsp :
2321 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2322 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2324 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2325 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2327 * src/gdcmFile.cxx : bug fix in affectation type
2328 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2329 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2330 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2331 symbols... future problem ?
2333 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2334 * src/win32/libgdcmijpeg12.dsp was missing
2335 * modified gdcm.dsw accordingly
2337 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2338 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2340 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2341 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2342 commit of JPR (before his hollidays to facilitate our work).
2343 * setup.py : bug fix in code. Modifications made while the last commit
2344 of JPR. The code hasn't been tested before the commit... it's so
2345 useless to make that (for best programmer that is JPR) !!!
2347 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * tagged the current version as Version0_3 (i.e. version 0.3)
2350 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2351 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2352 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2353 * *.dsp : modifications to use new libgdcmijpeg8 library
2354 * setup.py : bug fix on VTKPATH variable
2355 * PACKAGER : adding all concerning windows
2357 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2360 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2361 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2362 test suite reported error.
2363 * PACKAGER file added (describes what a packager must do when
2364 packaging a new release).
2365 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2366 * configure.in: upgraded version number to 0.3.0
2367 * fixing build of rpm (through rpm -ta):
2368 - Doc/Makefile.am exports proper doxygen files
2369 - src/jpeg/libijg8/Makefile.am exports the include files.
2371 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2373 * src/gdcmHeader.h : formatting code
2375 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2376 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2377 We were obtaining error message from vtk. Now, creation of file list
2378 is made in an internal list to prevent this problem.
2379 Bug fix when output is empty.
2380 Bug fix in update of progress value. Previous commit for this was a bad
2382 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2384 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2385 * src/gdcmHeader.h : added method to get the file name
2386 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2387 files. Added method to remove all files on the input
2388 Added FIXME comment concerning the bad parsing of header made by
2389 ExecuteInformation method (in ExecuteData method)
2391 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2393 when using make instal.
2394 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2395 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2397 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * setup.py : adding include dir of jpeg lib to compile all sources
2399 * */Win32/*.dsp : JPR fix for windows compilation
2401 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2402 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2404 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2405 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2407 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * setup.py is again effective on un*x (takes into account the
2409 addon of the jpeg library)
2410 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2411 * Doc/Doxy* updated (includes above enhancements)
2412 * INSTALL now points to web documentation
2414 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * src/gdcmHeader.h doesn't make unnecessary reference to
2417 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2419 * src/gdcm*.[cxx|h] :
2420 - to allow compilation with gcc 3.x
2421 -- clean up of STL usage (added explicit usage of std::)
2422 -- small fixes on exceptions.
2423 Note: linking not tested !
2424 - clean of doxygen comments to avoid warnings at documentation
2426 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2427 dependent convertion).
2429 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * Clean up of previous JPR garbage commit (not even commented in the
2432 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2433 - moved all jpeg related files from src to src/jpeg/libijg8, with
2434 addition/modification of Makefile.am and configure.in.
2435 - the testSuite is still brain damage (not guilty).
2437 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2438 * WrapVTK.py : modifications to get correctly vtk source files to
2440 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2441 (FileName -> Filename)
2443 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * vtk/vtkGdcmReader.[cxx/h]:
2445 - UpdateProgress method should now be effective
2446 - removed the limitation on having only images loaded (as opposed
2448 - when building a stack of images/volume, a lesser number of
2449 gdcmHeader and gdcmFile instances should be used (hopefully
2450 accelerating things).
2451 - when building a stack of images/volumes, files which are not
2452 loadable (wrong path-filename, wrong permissions on existing file,
2453 or file not parsable by gdcm) are replaced with a black image
2454 in the stack (for the caller to notice the problem).
2456 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2459 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2461 between standard library (std) and vtk library (problems are found
2462 under Windows... thanks Windows !)
2464 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2465 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2467 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2469 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2470 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2472 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * When compiling with distutils (see setup.py) the C++ compiler is
2474 called with different flags than the default ones (with automake).
2475 In order to fix all those warning, I compiled gdcm with the command
2476 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2477 and went for warning fixes:
2478 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2479 up from unused variables.
2480 - vtk/vtkGdcmReader.cxx: potential bug fix.
2481 * src/gdcmHeader.h: Doxygen warning cleanup
2483 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * gdcmPython/gdcm.i:
2485 - typemaps correction to take into account the systematic replacement
2486 of "using namespace std" with std:: prefix e.g. std::list,
2487 std::string... (cf changes of 2003-05-21).
2488 - gdcmGlob global variable of type gdcmGlobal (defined in
2489 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2490 exported to Python a as cvar.
2491 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2492 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2493 gdcmDictSet.GetPubDictTagNames() and
2494 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2495 C++ static methods).
2496 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2497 with the above changes.
2499 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2500 * setup.py, manifest.in : bug fix under linux
2502 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2503 * Modification of setup.py to compile vtk part too. Then, we have 2
2504 wrappers which must work with same distutils. For that, we have a
2505 generic distutils in distusiltsWrapping.py ; with :
2506 - build_extWrap class to wrap generically all extensions,
2507 - ExtensionWrap base class for all wrapping extension that contains
2509 - Wrapper interface which wrap sources
2510 + In WrapSwig.py we have extension and wrapper for Swig
2511 + In WrapVTK.py we have extension and wrapper for VTK
2512 * MANIFEST.in : modifications to consider vtk directory and new python
2513 files for compilation
2515 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2516 * Added python wrappers of vtkGdcmReader vtk class (see the
2517 source in vtk/vtkGdcmReader.cxx) :
2518 - vtk/Makefile.am now builds a library
2519 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2520 python library (as opposed to _gdcm.so wich are the python
2521 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2522 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2524 - configure.in has an additional flag --enable-vtk that needs
2525 to be set to enable compilation of vtk related code, that is:
2526 + vtk/vtkGdcmReader.so and
2527 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2528 + gdcmPython/vtkgdcmPython.so (see above)
2529 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2530 be read when compressed or when HighBit + 1 != BitsStored),
2531 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2532 the usage of the python wrapper of vtkGdcmReader vtk class.
2533 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2534 * src/*.[h] all occurences of stl classes are now prefixed with
2535 std::, and all occurences of "using namespace std;" where removed.
2536 This is to avoid pollution of global namespace in included files.
2537 Apparently vtk does not avoid this pitfall: when using both
2538 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2539 collision of various stl members (principally cout...).
2540 * gdcmPython/testSuite.py now cleanly removes temprory generated
2542 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2543 comply with above changes)
2545 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2546 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2547 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2548 vtk data structure (an image Flip was required).
2549 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2550 * cosmetic changes in documentation.
2552 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2553 * src/gdcmHeader.cxx: the constructor no longer exits when an
2554 unexisting file is given as argument.
2555 * The subdirectory Data (containing all the images used for the
2556 test suite) is not part of this repository anymore. A new module
2557 containing those images is now available at
2558 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2559 with the name gdcmData.
2560 All the python scripts (including the package initialisation file
2561 gdcmPython/__init__.py) were adapated to take this change into
2562 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2564 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2565 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2566 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2567 demo of the usage of this class.
2568 Compilation of this vtk part is only done when using the --enable-vtk
2569 at configure (or autogen.sh) stage.
2571 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2572 * More memory link related corrections and documentation fixes.
2574 - maximum info is obtained with a command of the form:
2575 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2576 --show-reachable=yes PrintHeader
2577 - the remaining reachable blocks seem to come from the STL
2578 allocation scheme through the usage of map and list. It looks
2579 like this memory cannot be freed but it is not a memory leak
2580 (in fact further invocation to the STL would recollect the
2581 unused memory allthough it cannot explicitely be freed).
2582 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2583 of displaying an image parsed with gdcm and displayed with VTK.
2584 Note: some images don't seem to work e.g.
2585 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2586 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2587 Allthough this weakens the semantics, it is a ditch attempt to
2588 make gdcm more thread friendly.
2590 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2591 * Memory link hunt (by using valgrind through the command
2592 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2593 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2594 gdcmHeader::_dicom_vr.
2595 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2596 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2598 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2600 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2601 * src/Makefile.am now exports all the necessary include files at
2605 * UpdateGroupLength replaced by new one
2608 * UpdateGroupLength re-written using H-Table
2609 (named UpdateGroupLengthNew untill checks are over)
2611 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2612 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2613 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2615 - gdcmHeader::GetPubElValSet removed.
2616 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2617 UpdateGroupLength, WriteElements, Write.
2618 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2619 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2620 carried the same semantics.
2621 - src/gdcmHeaderIdo.cxx changed accordingly.
2622 - gdcmFile::WriteBase now regroups all the codes from previous
2623 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2624 - enum FileType moved to gdcmCommon.h
2625 * src/gdcmHeader.cxx AddDefault trashed
2626 * gdcmGetXSize added
2627 * getimageDataSize now calls gdcmGetXSize
2628 * Test/*.cxx changed to agree with above changes
2630 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2632 (to avoid double call by end user).
2633 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2634 by end user, since gdcmHeader::gdcmHeader now handles it.
2636 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * gdcm/Doc many doxygen changes:
2638 - Doxyfile now has two different versions, DoxyfileUsers that generates
2639 the html.users end users oriented documentation and
2640 DoxyfileDeveloppers that generates the html.developper developper
2641 oriented documentation.
2642 - README changed accordingly
2643 - requirement.txt removed (old design info moved to TODO).
2644 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2645 DoxyMainPage.txt, DoxyPython.txt provide more information.
2646 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2647 be updated by simply regenerating the docs with doxygen and copying
2648 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2649 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2650 all the tests in the form "if (<map>.count() >1)" were removed.
2651 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2652 ill-formed documentation sections.
2653 * src/gdcmHeader.cxx: ditto
2655 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * setup.py fixed for un*x (needed macro for stdint.h)
2657 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2658 un*ces with sh-utils test utility.
2659 * gdcmPython/demo/test.py renamed to PrintHeader.py
2660 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2661 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2662 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2663 * src/gdcm*.cxx JPR's bad inclusion fixed.
2665 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2667 * gdcmPython/demo/test.py changed accordingly.
2669 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * gdcmPython/Makefile.am fixed linking against libstdc++
2671 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2672 * Swig subdir (historical tests of swig version 1.3.17++) removed
2673 * Test/testChangeEntete.cxx some lines commented out in order to make
2675 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2676 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2678 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2680 hence the user doesn't need this explicit call.
2681 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2682 i.e. LoadElements() call removed.
2683 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2684 - src/Makefile.am declares the proper flag for g++.
2685 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2686 for adding user defined new tags.
2687 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2688 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2689 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2691 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2692 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2693 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2694 src/Makefile.am : the project should properly compile and install
2695 with the autotools, included the python wrappers part.
2696 * gdcm.spec.in : added a spec file for RPM packaging.
2698 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2701 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2702 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2703 to exported to the environement (see gdcmPython/testSuite.py
2705 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2706 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2707 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2708 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2709 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2711 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * gdcmPython/__init__.py doesn't crash anymore when running in
2713 in InstallMode or PreInstallMode but with an environement given
2714 value of GDCM_DICT_PATH.
2715 * src/gdcmDictSet.[cxx/h] coding style.
2717 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2719 * src/gdcm.h general comments moved to TODO, and README
2720 * src/gdcm.h should now be seen as a user commodity (including it
2721 should suffice to fully use gdcm). It is nowhere including within
2722 any of the kernel files src/*.cxx and src/*.h.
2724 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2726 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2728 * src/gdcm*.cxx only include their corresponding include file
2729 (as opposed to gdcm.h)
2730 * gdcmPython/gdcm.i changed accordingly
2731 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2732 the autogen.sh generated "make snapshot" command to work.
2733 * autogen.sh removed history related references to crea package.
2735 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * distutilsSwigCPlusPlus.py work around some swig portability
2739 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2741 was done in a last ditch attempt to get setup.py _really_
2742 operationnal. The python/gdcmPython layaout add the advantage
2743 of hidding away the python related distutils specific files
2744 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2745 Alas, the src directory was out of scope (i.e. it's relative
2746 position to setup.py was ../src) which made things impossible to
2747 handle (see previous version of python/setup.py). Crossing fingers...
2749 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * python/setup.py now works on Un*x. (harder than I thougth)
2751 * python/distutilsSwigCPlusPlus.py can now have include files
2752 among the list of sources.
2754 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2755 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2756 * modifications in MSVC projects
2758 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * As stated by the first lines of Test/ExceptionAndPython/README, it
2760 looks like we can move back to original usage of exception within
2761 src/gdcm* and hence remove the errno stuff that was introduced
2762 as a quick and dirty fixture of this problem (added to the TODO).
2763 * Doc/Doxyfile configuration file for Doxygen and corresponding
2764 README file for usage added.
2765 * Test/testWrite.cxx added. This new test comes from a split of
2766 test.cxx that is now reverted to its original purpous i.e.
2767 testing the proper parsing of a Dicom related file.
2768 testWrite.cxx concentrates on testing the IO part of gdcm.
2769 * Test/bug1.cxx (containing a bug on WIn32) added.
2770 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2771 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2772 whose purpose is to publish the content of the TagNames of the
2773 Dicom public dictionnary were not accessible without an
2774 instance of class gdcmHeader.
2775 - those methods are now static methods of gdcmDictSet and hence
2776 require no instances at all to be invocated.
2777 - within gdcmDictSet this change required to change some method
2778 to class methods (i.e. are now static) among which SetDictPath
2779 (renamed to BuildDictPath) and LoadDefaultPubDict.
2780 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2781 the above changes by calling the new method classes of gdcmDictSet.
2782 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2783 the above to be effective.
2784 * python/gdcmPython: in order to wrap properly the above changes
2785 for Python, swig version now needs to be > 1.3.17.
2786 * python/gdcmPython/Makefile fixed to adapt itself to new
2787 configure/make shema introduced by Johan Montagnat (thanks for the
2788 contribution). Alas this Makefile cannot be turned into a proper
2789 Makefile.am without some heavy changes in the configure.in
2790 (for python dectection).
2791 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2792 now avoids publishing the empty entries.
2794 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2795 * python/setup.py : bug fix concerning install under windows
2796 ExtraPath reused :-P
2797 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2799 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2800 * Dicts/dicomV3.dic : remove double spaces !!!
2801 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2802 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2805 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2807 method. Doxygenation.
2808 * src/gdcm.h clean up of JPR spurious comments.
2810 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * python/distutilsSwigCPlusPlus.py now properly collects the
2812 shadow classes generated by "swig -c++" (gdcm.py in our case)
2813 when using "python setup.py install".
2814 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2815 reexports the working classes.
2816 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2817 by the classical C errno scheme. This is to prevent an obscure
2818 behavior of the python wrappers when importing wxPython.wx prior
2819 to gdcmPython (which ended up in an abort call). An illustration
2820 of this oddity can be found in the Test/ExceptionAndPython
2821 subdir (see the README file). This problem probably due to
2822 an combination of g++ and dynamic loading.
2823 * added Test/ExceptionAndPython (see above)
2825 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * Changed the layout of the python part to avoid bloating main
2827 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2828 i.e. the distutils arsenal. All the python related stuff is
2829 again in a python subdir, but the package itself is now in
2831 * setup.py was cleaned up:
2832 - pythonIncludePath removed
2833 - python setup.py bdist target is now functional.
2834 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2835 collision with other packages). gdcmPython/demo/*.py changed
2838 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * python subdir moved to gdcmPython (preparation of distutils packaging).
2840 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2841 distutils installer is operational.
2842 * - gdcmPython/__init__.py now properly loads the swig generated
2843 shadow classes (from gdcm.py).
2844 - gdcmPython/demo/*.py changed to import the package gdcmPython
2845 instead of gdcmPython/demo/load.py.
2846 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2848 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2850 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2851 entries within the associated public Dicom dictionary resp. the same
2852 information but sorted by the fourth field (PAT, IMG, DIR) of the
2854 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2855 are now in the "???" group.
2856 - python/gdcm.i changed accordingly,
2857 - python/demo/printGroupedPublicDict.py added, that gives an example
2858 of the above new functionalities in Python.
2860 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * src/gdcm.h, gdcmHeader.cxx:
2862 - historic references to glib's g_malloc and g_free (#defined)
2863 were definitively removed.
2864 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2865 * src/gdcmElValSet.cxx:
2866 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2867 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2868 - GetElValue(string) renamed to GetElValueByName.
2869 - Added GetElementByName(string).
2870 * src/gdcmHeader.cxx: added
2871 - GetPubElValRepByNumber(guint16, guint16)
2872 - GetPubElValRepByName(string)
2873 - GetShaElValRepByNumber(guint16, guint16)
2874 - GetShaElValRepByName(string)
2875 - GetShaElValByNumber(guint16, guint16)
2876 - GetShaElValRepByName(string)
2877 - GetElValRepByNumber(guint16, guint16)
2878 - GetElValRepByName(string)
2879 - GetElValByNumber(guint16, guint16)
2880 - GetElValRepByName(string)
2881 * Doc/requirements.txt added.
2883 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * Test/Makefile building now depends on the one of libgdcm.so
2885 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2886 pixel data) aware which enables finding the address (offset) of
2887 the pixel data of JPEG encoded DICOM files. This leaves only a single
2888 file in the testSuite whose pixel data address (offset) is unknown.
2889 * python/testSuite.py changed accordingly.
2891 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2892 * VC++ has some strong limitations when working with the STL, as stated
2893 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2894 "Also note that some STL containers (map, set, queue, list, deque)
2895 cannot be exported. [...]
2896 Some STL classes contain nested classes. These classes can not
2898 This is caused by a designed limitation that once a template
2899 class is instantiated, it can not be re-instantiated and
2901 Since our usage of map<> is ubiquitous in gdcm, this "designed
2902 limitation" of VC++ is a pitfall.
2903 Hence the Python wrappers of gdcm cannot be incrementally linked
2904 against the c++ dynamic library. The dirty but only workaround is
2905 to forget about incremental link of dynamic libraries and to generate
2906 the Python wrappers library with the inclusions of the underlying C++
2908 The following modifications concern this matter on Win32/VC++:
2909 - wrapping python correct with standalone wrapped dll (don't use separate
2910 dll under windows !!!!)
2911 - python21_d debug mode enabled (ask Frog how to use it :-)
2912 - NO problem with having an STL member of class for example string in C++
2913 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2914 - Python test of dcmlib in Python is ok under windows on a large set
2916 * removed glib references
2917 * typedef's inserted in gdcm.i for correct swig type management
2919 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * python/demo/*.py load.py extracted from test.py. Added explore.py
2921 that only displays required tags and testAll.py that parses all
2922 the files of the testsuite without using unittest.
2923 * python/testSuite.py other additional test on new files added.
2924 * Data/* new test files added accordingly to the testSuite.
2925 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2926 the vr in the file differs from the one of the dictionary.
2928 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2929 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2930 values, but limits itself to values which are below a user specified
2931 size (by default 1024 bytes).
2932 * python/gdcm.i : elements not loaded (because their size is above the
2933 user specified treshold) are exported with their TagKey as key of the
2934 python dictionary. This enables the testsuite to make some checks
2935 on the unloaded elements (since we have their offset and size).
2936 * python/testSuite.py
2937 - now tests for the existence and proper value of the pixel data
2938 - two new examples added.
2939 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2941 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2942 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2943 aware. See the strategy comments in gdcmHeader::FindeLength().
2944 * Test/test.cxx now accepts a filename as first argument.
2945 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2946 * python/testSuite.py changed to integrate test on above files.
2948 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2949 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2950 the vr was also RET.
2951 * python/testSuite.py more tests added.
2953 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2954 * python/testSuite.py unittest test suite added (uses Data)
2955 * Data/* dcm and acr files for the test suite.
2956 * glib dependance removed from un*x version. We now use ISO C99
2957 7.18 Integer types (see stdint.h)
2958 - python/Makefile, src/Makefile src/gdcm.h
2959 * src/ when an explicit vr (like dicom files) suddenly poped an
2960 implicit element we use to mark the underlying DictEntry of the
2961 concerned ElValue with "Implicit". This strategy was damageable
2962 too the public or provite dictionaries, since some of their vr
2963 would be changed. Since Header::FindLength heavily relies on the
2964 detection by Header::FindVR of falsely explicit elements, I
2965 added an extra ImplicitVr member to ElValue (boolean).
2966 The rest of the changes we the necessary adaptations.
2968 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2969 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2971 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2973 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * Adaptation for porting to VC++:
2976 o forced to use std namespace (for string to be known)
2977 o all class use __declspec export style on WIN32
2978 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2979 (in stdlib.h on Win32 but in std:: for gcc)
2980 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2981 variable GDCM_DICT_PATH.
2982 * src/gdcmHeader.cxx verbose comments made discrete.
2984 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2985 * python/gdcm.i: added a typemap that converts a C++ hashing table
2986 to native Python dictionary.
2987 * python/demo/test.py:
2988 - now uses the native dictionary for exploration of gdcmHeader.
2989 - takes an optional filename argument (the file to parse).
2990 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2991 PubElVals hashing table.
2992 * Dicts/dicomV3.dic removed error prone trailing spaces.
2994 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2995 * Python wrapping process moved away from src/Makefile to
2996 newly created python/Makefile (as well as gdcm.i)
2997 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2998 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2999 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3000 from the environement variable GDCM_DICT_PATH (when existing).
3001 * src/gdcmDict::GetTag bug fix.
3003 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3004 * Straightforward temporary fixes for swig to build the python wrappers.
3005 src/Makefile now has a python working entry [by working we mean
3006 that we can import de shadow classes without errors].
3008 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3009 * hashtest.cxx removed (since already in Test)
3010 * src/gdcmlib.h renamed to src/gdcm.h
3011 * src/dcm.i renamed to src/gdcm.i
3012 * src/Makefile prepared for python wrapping
3014 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader.cxx :
3016 - Parsing of header is now separated from loading of element values
3017 (see gdcmHeader::LoadElements).
3018 - general clean up of hopefully all file access (creation of
3019 ReadInt16 and ReadInt32)
3021 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcmHeader.cxx :
3023 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3025 - SetLgrElem renamed to SetLength
3026 - GetLgrElem renamed to GetLength
3027 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3028 * src/gdcmElValSet.cxx fixed both GetElValue methods
3029 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3030 due to IdoDude was cleaned out.
3032 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3034 concentrates on finding the value representation (when it exists).
3035 RecupLgr now only finds the element value length, and it avoids
3036 returning the unecessary skL (skipped length).
3037 Also, offsetCourant was simply removed (with taille_fich) since
3038 it was redundant with the File position internals (by using
3039 ftell and fseek). This also made skL (see above in RecupLgr) usage
3041 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3042 on the libido specificities which are handled through class
3044 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3047 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * Truckload of changes. Parsing of header is barely functional
3049 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3051 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * src/gdcmHeader.cxx many addons of low level methods
3054 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3055 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3056 and _IdDcmSWAP_LONG.
3058 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3059 * This corresponds to all the changes decided at the meeting of
3060 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob