1 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/*.cxx : first parss to normalize file organisation
4 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDirList.[h|cxx] : add method to find a directory
6 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
8 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Finish cleaning up my JPEG mess. Should be ok now.
10 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
11 contained within the RLE* class(doh!)
13 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
14 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
15 * SerieHeader::AddFileName() creates as many Coherent Files lists
16 (same Serie UID) as it founds different Serie UID
17 amongst the files instead of discarting any file
18 that doesn't match with the first one he found.
19 * SerieHeader::OrderGdcmFileList has now one parameter :
20 the Coherent Files list the user wants to sort
21 * SerieHeader::GetFirstCoherentFileList() |
22 * SerieHeader::GetLastCoherentFileList() | allow to parse
23 the set of Coherent Files lists
24 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
25 compatibility (it returns the *first* Coherent Files list,
26 since there was only one before)
27 * Test/TestSerieHeader gets gdcmData as a default root directory
29 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Remove friend between DocEntry and File classes
31 * Remove friend between PixelReadConverter and RLEFramesInfo,
34 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
36 0002|0000. The value was incorrect.
38 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
41 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmUtil.cxx : compilation fix on Win32
43 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
44 variable, to be easy found. Add methods to change the default UID.
45 Amelioration of the CreateUniqueUID to use the correct default UID.
46 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
49 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * Test/TestVR.cxx : fix memory leaks
52 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
53 * Rewrite the base 256 to base 10 conversion, using string operation only.
54 This allows us to get rid of the problematic 64bits integer type (does not
55 always exist on target platform).
57 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
58 * Add construct and destructor to class gdcm::Debug to close the debug file
60 * Don't let uset to open twice the same file
61 * gdcm has now an official UID prefix,
62 supplied by http://www.medicalconnections.co.uk
63 1.2.826.0.1.3680043.2.1143
64 (Thx to Mathieu for providing URL)
65 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
66 to be able to perform some more tests
67 * gdcm::ContentEntry : Contructors and Destructor are now protected,
68 in order to be sure no user will try to use them.
69 (at user level, only the children classes are meaningfull)
71 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * move RLEInfo & JPEGInfo from Document to File
74 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * FIX : remove so many friend between classes
77 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
79 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
81 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
82 In order to avoid missbehaviour :
83 . gdcm::DocEntry is now specialized in
84 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
85 - gdcm::ContentEntry (Dicom entry with a 'content')
86 . gdcm::ContentEntry is specialized in
87 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
88 characters value, or integers)
89 - gdcm::BinEntry (Dicom entry with a non strig representable value
90 (user hasn't any longer to thing about the precedence of his dynamic_casts)
92 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * Test/VTKTest*.cxx : bug fix under linux
95 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
97 use with python. Some methods are moved from Document to ElementSet or
98 DocEntrySet. The equivalent methods to ElementSet have been added to
99 SQItem and are virtual in DocEntrySet. Methods that may have the same code
100 in SQItem and ElementSet is directly placed in DocEntrySet
102 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * Test/VTKTest*.cxx : remove the show variable in each test method because
104 it's useless (the viewer variable replace this variable)
106 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmDocument.cxx : bug fix on potential memory leak
108 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
109 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
110 Add ClearXxx methods to remove all the content of the list or map
111 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
113 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
114 * methods ReplaceOrCreate renamed as Insert
115 (nobody will be any longer confused by 'CreateOrReplace')
117 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
118 * Grealty simplify the JPEg decompression, no need to differenciate based on
119 the JPEG possible type (with/without fragment, with/without multiple frame).
120 Everything is done throught the JPEG IO Suspension mechanism in IJG
122 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
123 * Stage 3 of normalization :
124 in order to avoid any missunderstanding while reading method names :
125 - All the methods xxxEntry now deal with dicom Entries
126 - Methods GetEntry splitted into
129 - Method SetEntry renamed as SetEntryValue
130 - Method SetEntryBinArea let as it was
132 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
133 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
134 - Position correctly the entry points for JPEG2000 and JPEG-LS
135 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
137 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
139 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
140 with other method names
141 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
142 * Test/TestDicomDirElement.cxx : add new test
144 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
145 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
146 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
147 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
148 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
149 So can't you use __int64 in ostream at all.
151 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * bug fix for compilation on MSVC6
153 * gdcmPython/gdcm.i : rename of classes missed
155 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
156 * Stage 2 of names normalization :
157 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
158 (easy to understand ...)
159 - gdcm::FileHelper replaces old class gdcm::File
161 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
163 type and not a string. So, there remove problems on the format of the
166 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
167 * Add Example/TestPapyrus.cxx
168 - reads a Papyrus file (gdcm::Header compliant),
169 - gets the pixels of all the images, using low level iterators
170 - writes an multiframes Dicom image.
171 (Just to show it's *possible* to do that)
172 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
175 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
177 Thus, DicomDirXXX are created with a flad that indicates if the created
178 object is empty or not (when not empty, the DicomDirElement is used to
181 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
183 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
185 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
188 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
190 Remove all access to the hash-tables or lists in the objects.
192 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
194 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
195 be complient with all the gdcm source code
197 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
201 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
205 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * Test/ : rename VTK tests to have a best name for the tests
207 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
208 GetFirstEntry/GetNextEntry use
210 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
211 * In SerieHeader::ImagePositionPatientOrdering()
212 // a Dicom 'Serie' may contain scout views
213 // and images may have differents directions.
214 // -> More than one may have the same 'pos'
215 // Sorting has then NO meaning !
216 Thx to Eduardo Davila for reporting bug.
218 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
220 test. Now it's on image content and not on the resulting visualisation...
221 might solve the problem on linux when using the OpenGL drivers
223 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
224 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
225 DicomDirSerie, DicomDirImage
226 Dict, DictSet classes :
227 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
228 -remove InitTraversal method.
229 * UPD Test programs + Example programs
231 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
232 * remove useless and never updated keyword \ingroup
233 * Solve pb when structure (list, map, ...) is empty.
234 Thx to Benoit for reporting bug
236 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
237 * Taking into account of 'Transfer Syntax' value
238 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
241 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
243 is no memory access violation
244 * gdcmPython/demo : add python demos using VTK
246 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
247 * FIX 'Dictionnary' is now spelt 'Dictionary'
248 'wether' is now spelt 'whether'
249 'archieve' is now spelt 'archive' ;-)
251 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
252 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
253 related methods, in order not to expose internal mechanisms
256 * REM methods that exposed internal mechanisms :
257 DicomDir::GetDicomDirPatients()
258 DicomDirPatient::GetDicomDirStudies()
259 DicomDirStudy::GetDicomDirSeries()
260 DicomDirSerie::GetDicomDirImages()
261 * UPD Test programs :
265 * UPD Example program
267 * ADD DictSet methods
271 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
272 * Removed the Print/indent/default parameter mess. There is absolutely no
273 reason to have to methods, moreover with the second taking the ostream as
274 *SECOND* parameter. This was clearly a bad hack to get things compile.
276 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * Complete rewrite of the GetMacAddress code. Now the code is *much*
278 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
279 Unfortunately the main code does not work on SunOS, thus provide a specific
280 code for this platform only (and Win32 of course). Since this seems to be
281 working, change CreateUniqueUID to use GetMACAddress instead of the
282 problematic GctestetIPAddress
284 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * Unfortunately to be able to test gdcmDirList I had to break the API
286 a little. Now the class is not a std::list anymore but has a member
287 std::vector (more ITK compatible). Allow unit testing on Win32 and
290 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
291 * Update SerieHeader to take into account a Serie Instance UID to properly
294 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
295 * ENH - Comment out Mathieu's (dangerous) Super Hack
296 for dealing with BIGENDIAN processors
297 - Move equivalent stuff to BinEntry::WriteContent
298 When necessary, 16 Bits Pixels are swapped in a small buffer
299 and then written. This avoid allocating a huge buffer, in
300 PixelWriteConvertor, and avoid modifying the Pixel Area.
302 Probabely, the same operation will have to be done when we want
303 to write image with Big Endian Transfert Syntax,
304 and we are working on Little Endian Processor
306 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
309 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
310 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
311 all the dict content.
312 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
314 * Test/TestDict.cxx : add a new test for the dict classes
316 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
318 file. Debug is yanked if compiled with NDEBUG
320 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmDictSet.h : set the default output to the os variable
322 * src/gdcmDictEntry.[h|cxx] : add the Print method
323 * gdcmPython/demo/ : add a new test
325 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
326 * merging of Test/PrintDicomDir and Test/TestDicomDir
327 * removal of now redundant Test/PrintDicomDir
328 * enhancement of Example/PrintDicomDir
330 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * Now, python test might work on systems
332 * Add the PrintDicomDir test
334 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
335 * FIX : First entry following group 0002 was lost for
336 Explicit Big Endian Transfer Syntax files
337 (group and elem not swaped)
339 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
340 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
341 Big Endian Transfer Syntax supposed the group following 0002
342 begins always by element 0000 (element 0000 is *optional*)
343 To avoid further troubles, let's be pessimistic, and use
344 Document::HandleOutOfGroup0002() method
345 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
346 (related pb not yet solved)
348 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * Bug fix for the python part use
350 * Now, PrintHeader.py pass... but outside the ctest use. shit !
352 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
353 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
355 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
356 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
357 a string and should ask the global TS dict what are the propreties of
360 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
361 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
362 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
363 to swap the Swap Code, at parsing time, when we come out of group 0002
364 and Transfer Syntax is Big Endian
365 We should be able to read now 'true DICOM" Big Endian coded images
366 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
367 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
369 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
370 * Hopefully fix the bug on MacOSX and static global initialization.
371 This is the only -minor- patch I found that both please MacOSX and VS6.
372 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
373 but this would require a lot of change. Another approach would be that Global
374 create those string and GDCM_UNFOUND becomes a pointer to a string (which
375 gdcm::Global would destroy at exit).
377 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
378 * Fix bug on MacOSX with static initialization in a multy threaded
379 environment. static const string in a header file used to be ill
380 initialized provoquing the freeze of any tests. patch should solve this
383 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
384 * According to Benoit's suggestion, and without any objection from anybody
385 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
386 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
387 - method gdcmDicomDirObject::GetEntry() renamed as
388 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
390 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
392 you debug/warning message just as c++ streams which make them very convinient
393 to use. Once this is stabilize I will change the ostringstrem to be
394 redirected to a file (ofstream).
395 * Properly support C99 extension: __FUNCTION__ which allow us to display
396 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
398 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
399 * Removal of useless and dangerous methods :
400 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
401 GetDocEntryByName, GetEntryByName, GetDictEntryByName
402 * Removal of usless methods :
403 Dict::PrintByName, Dict::GetDictEntryByName
404 * Commenting out of probabely useless methods :
405 Dict::GetDictEntryNames()
406 Dict::GetDictEntryNamesByCategory()
407 DictSet::GetPubDictEntryNames()
408 DictSet::GetPubDictEntryNamesByCategory()
409 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
410 * ENH : Use dicomTS.dic as described in 2004 version
411 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
412 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
413 Add Accessors on VM (Value Multiplicity), and VM related methods
414 * ADD : Add a list of 'Dicom Attribute types', as found in
415 http://medical.nema.org/dicom/2004/04_15PU.PDF
417 * ADD : Add dicomGroupNameAbbreviations.dic
418 should be used to write a method to replace the former
419 Dict::GetDictEntryNamesByCategory()
421 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
422 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
423 to read in the file... and only it ! Length is the efective length of the
424 data in the DocEntry structure
426 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
428 And now use a static function call instead, with a global variable. i
429 This is much closer to the VTK approach. Hopefully should be bulletproof
430 and easier to use...hopefully
432 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
433 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
435 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
438 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
439 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
440 ValEntry, BinEntry, SeqEntry creation or replace
442 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
444 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
446 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
447 when specifying the VR
448 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
449 * src/gdcmDocEntry.cxx : amelioration of print
451 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
452 * ADD : Add the method Util::IsCurrentProcessorBigEndian
453 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
454 * ADD Method Document::ComputeGroupLength
455 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
456 in order to allow further VR modification by user
457 * REM : removal of once-called method File::WriteBase
458 integration of its code in formerly one-line method File::Write
460 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
462 replace the different values "??", "Unkn", "Unknown".
463 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
464 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
465 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
466 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
468 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
471 * Set the gdcm::Base class to some Printable classes
473 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmFile.[h|cxx] : add the Print method
475 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
476 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
477 * src/gdcmDocument.h : remove the PrintLevel informations
478 * Example/PrintFile.cxx : use the new gdcm::File::Print
480 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
482 problems when compiling with the python wrapping
484 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
485 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
486 writting in ImplicitVR
488 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
489 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
490 JPEG decompression, especially when dicom frames are split into several
491 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
492 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
494 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * src/gdcmHeader.cxx : change the initialisation of default header.
496 Now, this header is readable by gdm, e-film, DicomWorks
498 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
500 Rename Decompressed to Raw
501 * Use the API changes in gdcm::File.
502 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
505 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
506 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
507 each added entry in the header. Replace the 'Planes' field by the 'Number
510 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
512 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
514 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
515 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
516 At this time, this image isn't readable by e-film... waiting JPR help to
519 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
520 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
521 DocEntry. Now use methods of the Document !
523 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * Test/ShowDicomSeq.cxx : bug fix
526 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
528 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
529 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
530 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
532 * Test/TestCopyRescaleDicom.cxx : remove unused variable
533 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
534 containing found sequences
536 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
539 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
540 Some fields in BinEntry must be copied to not seg fault when making the :
541 gdcm::File *copy = new gdcm::File( copyH );
542 and tests are now made on good variables
544 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
546 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
548 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
549 * Add vtkGdcmWriter example and test
551 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * Test/TestUtil.cxx : reformat the source code
553 * vtk/vtkGdcmReader.cxx : remove and change prints
554 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
556 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
557 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
559 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
560 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
561 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
563 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
564 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
565 by an eof to prevent all bad read of the file... and in this case, the
568 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * Example/Volume2Dicom.cxx : comment unused variables
570 * Test/PrintDicomDir.cxx : comment unused variables
571 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
572 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
573 method that is redondant with AddEntry.
574 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
577 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
578 * Bug fix due my last commit (compilation under Windows).
579 * Example/Volume2Dicom : bug fix in the file and reformatting source code
580 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
582 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
584 - Remove printf / sprintf
585 - include iostream AFTER gdcm so we don't get warnings
586 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
588 - Also remove tons of include from header files, hopefully this should
589 speeup the compilation time, since it was becoming a dog slow.
590 - Remove gdcm.h as it include way too many files and slow down compilation
591 (plus it is not up to date)
592 - remove 'using namespace std' this is BAD !
594 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
595 * Remove memory leaks on the DicomDir
596 * Remove some useless data in DicomDirObject
597 * Add usefull methods in SQItem, to be complient withe the ElementSet
599 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
602 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
604 future, with convertion)
605 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
606 and ImageDataSize values. Remove the method to get the PixelReadConverter
607 from the output of the class
609 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
612 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
614 and vtkErrorMacro use.
615 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
617 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
620 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
621 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
622 The string leaves only in the fonction. So when we make a .c_str(), we
623 get the pointeur on the first element, element that will be destroyed
624 immediately after thee instruction.
625 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
626 file has been opened : the test must be made on the content of the
627 pointer and not directly on the pointer !
630 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
632 the python part recompiles
634 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
636 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
637 X session is killed (for my computer... it seems to not be identic on
640 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
642 avoid problems (otherwise, the difference test between the visible image
643 and the reference is incorrect. If the reference is greater than the
644 screen resolution, it's produce errors).
645 Can be used for only one image. Can be used with a visible flag.
646 * vtk/vtkGdcmReader.cxx : remove commented codes.
647 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
648 under windows at compilation
649 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
651 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
653 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
655 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
656 tests on the image size X, Y, Z
658 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
660 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
661 between the class name and the file name
663 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * src/ : fix compilation warnings for the Write method (2 different
665 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
666 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
667 variable... create a static method in gdcm::Document to access to
668 this variable content.
670 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
672 file, to be accessed by other files (like gdcmFile). Remove commented
673 code. Move the change of the header to the gdcmFile, using the
675 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
676 To be sure of that (and simplify calls), the Write of the header now
677 gets a file name and not a file pointer (std::ifstream).
678 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
679 DocEntryArchive. Remove all open of the written file
681 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
684 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
686 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
688 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
689 some corresponding methods. Write correctly the file and check before
691 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
692 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
693 is now on RGB data (as before my last commit
694 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
696 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
698 Add a print information of the type of the entry
699 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
700 It was in the gdcmFile, and all write have been regrouped
701 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
702 Write correctly all dicom files (in decompressed mode only at this time)
703 * Test/ : test on files are now made using Raw data and not color data if
705 * Example/PrintFile.cxx : add more printings
707 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * Amelioration of code, remove some code copy. For the loading of
709 BinEntry (in gdcmDocument), add the test to verify if the file is already
712 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
713 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
714 remove a DocEntry in the header (push an empty DocEntry)
715 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
716 lines. Bug fix in the initialization of the PixelConvert and the
718 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
719 use in TestCopyDicom (now this test can run under windows... but fails)
720 * Test/TestCopyDicom.cxx : amelioration of the test :
721 - test the pixels written
722 - add test points to quickly find where is the error
723 - can set a file name input and output in arguments
724 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
725 amelioration of the test output
727 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
728 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
729 all replaced DocEntry's
730 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
731 Now, each needed DocEntry to modify is duplicated, modified and inserted
732 to the header using DocEntryArchive. Thus, after save, we can restore the
733 header initial state.
735 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
738 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
739 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
740 correct to copy it. The DictEntry is specified at the DocEntry creation,
741 then, it musn't change in the time.
742 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
743 header correctly. At this time, the change is only made for the first
744 level of the Document. In the future, it might consider sequences.
745 The change is made by replacing a DocEntry by an other that is created
746 outside the class. The old value is kept. When we restore the header
747 status, the added DocEntry is deleted and replaced by the old value.
748 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
749 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
750 set the write type to explicit VR, implicit VR or ACR. Add methods to set
751 the write mode to native, decompressed or RGB (but not used at this time)
753 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
754 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
755 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
757 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
758 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
759 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
761 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
762 set because already copied when copying the BinEntry's of the header
763 * Test/TestAllReadCompareDicom.cxx : remove warnings
765 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
767 Two problems appear when doing it :
768 - with the gdcmFile : when the GetImageData method is called, the pixels
769 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
770 data (pixels). And each structure destruct the data when it's
771 destructed. So we have two destructions for the same data. To solve it,
772 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
773 data or not. If it doesn't own data, then they will not destroyed by
775 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
776 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
777 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
778 create a double destruction of the same DocEntry's. So, to solve it,
779 the TagHT is simply cleared and the DicomDir* elements are destroyed.
780 * TODO : add an entry concerning memory leaks in the DicomDir
782 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
784 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
787 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
789 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
790 after it have been deleted
792 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * FIX: src/* fix the doxygen warnings.
794 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
795 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
796 was erroneously defined with a size of 15 instead of 16. [many thanks
797 to Jean Michel Rouet for pointing out this bug].
799 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
800 1. Finish merging JMR patch for writting DICOM from scratch
801 2. Fix -hopefully- bug with MONOCHROME and space vs null character
802 3. Use const ref when possible
803 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
804 5. A few more comments
805 6. CreateUniqueUID can now be called without parameter"
807 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
808 * ENH: Slightly bigger patch:
809 1. Getting toward full integration of JMR patch for writting dicom from scratch
810 2. Update Test to test part of this patch: CreateUniqueUID
811 3. File was not close properly in gdcmDict
812 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
813 5. Use of const ref instead of copy (speed issue)
814 6. Remove temporary (duplicate) string in TranslateToKey
815 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
816 8. Do not repeat virtual in subclasses
817 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
819 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
820 * Apply first patch toward better string comparison when dealing with broken
821 DICOM files. Essentially the string could be padded with a space instead
822 of a null character as defined by standard
824 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
825 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
826 because never used... and in the same time, that's remove some memory leaks
828 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
829 * src/gdcmFile.cxx : now delete the PixelConvert instance.
830 * In examples and tests : change the type of image data variables from void*
831 to uint8_t*. Remmove all delete on image data variables
833 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
835 Verify the file pointer value before open the file, and if it's not null,
836 a verbose message is generated.
837 Close correctly the file when the file isn't considered dicom-like. The
838 correctly close is a call to CloseFile.
839 When closing the file pointer, test if its not null to close the file.
840 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
841 file. For an uncompressed image, the copied data correspond in the least
842 case to the image size (calculated) or the image size specified in the
843 header. A verbose is generated if these two size mismatch
845 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
846 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
847 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
848 break under windows (with msvc6 compilation).
850 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
851 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
852 compiling with MSVC6)
854 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
855 * Bugs fix for the Windows build with VC6
856 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
857 needed (only for projects required VTK). If the VTK is included in all
858 projects, there is conflicts with the jpeg lib of vtk when compiling the
859 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
860 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
861 when compiling the gdcm_wrap.cxx file (created by the compilation of the
863 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
864 (like it's already made for the cout use). Otherwise, conflict with the
867 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
868 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
870 - comments on the DicomDir::Method related usage added.
871 - now that we use the namespace gdcm, a lot of internal classes do
872 NOT need to be wrapped anymore.
873 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
874 DicomDir::Method) new example added.
876 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * Improve string manipulation. I now inforce the notion of 'DicomString'
878 A DicomString can contain as many \0 as they want
879 and it is *always* of even length.
880 We only support odd length for very rare case.
881 And in the near future this should be removed.
883 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
884 * /binary_write/ gdcm source. Now even on big endian we are writting
885 little endian. This should -heopfully- fix some tests
887 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
888 * Now the dictionary is compiled into gdcm lib. This is a default
889 behavior, thus any dic file specified is picked before failback to
890 the one comiled into lib
892 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
893 * Change internals for gdcmDict. Don't use any 'new' any more.
894 This should definitely solve any leak problem, and we should be
895 as fast as before, as long as don't modify too much the dictionary.
897 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
898 * STYLE: ivars should start with a capital letter.
899 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
900 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
902 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
904 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
905 new 2004 dictionaries added (thanks to JPR).
906 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
907 * CLEANUP_ROUND (15) for gdcmPixelConvert
908 - RLEFrame::NumberFragments is now of type unsigned int
909 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
910 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
913 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * Initial work in gathering all transfer syntax accessors. clearly
915 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
916 ivars, but only one transfersyntax (class) ivar with equivalent method on
919 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
920 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
921 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
922 discussed (plus I didn't like having a 2000 lines patch not commited)
924 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
925 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
926 * CLEANUP_ROUND (14) for gdcmPixelConvert
927 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
928 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
929 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
931 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
932 anymore and hence avoids storing a copy of PixelConvert::Decompressed
933 into File::Pixel_Data.
935 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
937 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
938 * CLEANUP_ROUND (13) for gdcmPixelConvert
939 Substituted File::ParsePixelData() with PixelConvert::Print() new
941 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
942 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
943 method to those classes.
944 - src/gdcmFile.[cxx|h]:
945 -- Added a ::Print() method.
946 -- PixelConverter is now a reference instead of a member.
947 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
948 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
950 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
952 collaboration diagram and inheritance diagram should be generated with
954 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
955 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
956 pointlessly wrapped (see
957 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
958 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
959 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
960 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
961 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
962 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
963 -- File::Initialise: PixelConverter setup moved away to
964 PixelConverter::GrabInformationsFromHeader()
965 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
966 interpretation moved away to PixelConverter::BuildRGBImage()
968 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
970 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
972 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
973 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
974 displayed on Win32 when a brutal abort() occurs (because of uncatched
975 exception). See TODO new entry of this commit for more on this.
976 * TODO added new entry.
977 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
978 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
979 - HandleColor is no longer called from gdcmFile.cxx
980 - gdcmPixelConvert.cxx clean up on method arguments and internal
981 variable names for semantical coherence.
983 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * Finished lossless transition, not only do we now read all lossless jpeg
985 images, without the need of the Cornwell lib, but we do read them properly now
986 * To reduce code (well to avoid code duplication), I defined a common place
987 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
988 redefine symbols. This is not perfect but this the best solution I found for a
989 compilation time jpeg option.
991 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
992 * Update jpeg ijg lib to support lossless jpeg implementation
993 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
995 * Also added a special copyright for dcmtk since we use their bugfixes.
998 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1000 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1001 matters, as stated in warning note at beginning of %include section).
1002 * src/gdcmDicomDir*.[cxx|h]: coding style
1003 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1004 * src/gdcmJpeg8.cxx: doxygen fix.
1005 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1006 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1007 from File:: to PixelConvert::.
1009 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1011 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1012 - more code moved away from File:: to PixelConvert::
1013 - fat setup of PixelConverter set in place in File::Initialise.
1015 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1017 namespace at the file system level. So now you should convert your examples
1019 gdcmHeader -> gdcm::Header
1020 It would be nice if people keep in mind to no open the namespace, since it
1021 allows compilation on broken plateform which were defining common symbol in
1022 the standart namespace (like LP, Unknown ...)
1024 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1026 The JPEG fragments are now parsed at the same stage than the RLE
1027 information. All code related to JPEG is now in gdcmPixelConvert:
1028 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1029 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1030 export a gdcmFile:: method. Those are simply global functions
1031 (for the time being this is better than having them attach to
1032 either gdcmFile:: or gdcmPixelConvert::).
1033 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1034 and stores the result in a gdcmJPEGFragmentsInfo.
1035 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1036 code (among other stuff) moved away from gdcmFile:; to
1039 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1041 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1042 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1043 clean up of RLE related code.
1044 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1045 - src/gdcmRLE.cxx removed
1046 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1047 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1048 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1049 * CLEANUP_ROUND (9) for gdcmPixelConvert
1050 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1051 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1052 away from gdcmFile:: to gdcmPixelConvert::.
1054 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1056 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1057 This is because Parse7Fe0 used to parse the pixels to compute the
1058 length. This task was passed over to FindDocEntryLengthOB() a long
1059 time ago, EXCEPT I had forgotten the OW case...
1060 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1061 we just recylce the code for parsing RLE fragments and computing
1063 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1064 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1065 with the retired Parse7Fe0().
1066 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1067 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1069 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1070 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1071 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1072 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1073 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1074 * CLEANUP_ROUND (4) for gdcmPixelConvert
1075 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1076 to return an unused length.
1078 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1079 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1080 this should be cleanner from the plane view. The iostream are erally a pain
1081 to use to do simple stuff.
1083 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1084 * Redo the compilation of the ijg jpeg library. Now only one source is
1085 necesseray. No need to rename file by hand what so ever. CMake handle the
1086 copying of the file within different directory, configure header file to
1087 modify some symbol. The only addition made to ijg wasd a mangle table so
1088 that symbol are different whether we are within 8bits or 12bits.
1090 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * Added documentation of vtkgdcmReader on Website:
1092 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1093 with it's binary name).
1094 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1095 the Website to be more complete.
1096 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1097 doxygenated documentation.
1098 - Doc/DoxyVtkGdcmReaderExamples.txt added
1099 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1100 DoxyVtkGdmReaderExamples.html )
1101 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1102 * CLEANUP_ROUND (3) for gdcmPixelConvert
1103 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1105 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * CLEANUP_ROUND (2) for gdcmPixelConvert
1107 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1109 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * CLEANUP_ROUND for gdcmPixelConvert:
1111 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1112 - src/gdcmPixelStuff[h|cxx] removed
1113 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1114 - src/CMakeLists.txt changed accordingly
1115 * GDCMHOME clean up:
1116 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1117 gdcmVersion.py moved to newly created ATTIC related
1118 gdcmPython/SetupOldies/ directory.
1119 * Autotools clean up:
1120 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1121 - autogen.sh configure.in acinclude.m4 python.m4 removed
1123 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1125 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1126 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1128 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * TODO updated with Mathieu suggestions. I proposed a template for
1130 describing TODO entries and used it for new entries.
1131 * Added Doc/Website/CodingStyle.html, Developpers.html,
1132 DeveloppersPython.html, GdcmDataCvs.html and
1133 DownloadVersion0_1.html, DownloadVersion0_3.html.
1134 * Some Doc/*.txt Doxygen files (which do not really concern the
1135 documentation itself, but the website) moved to html and
1136 placed in directory Doc/Website:
1137 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1138 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1139 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1140 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1141 * CMakeLists.txt changed accordingly.
1142 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1143 DeveloppersPython.html
1144 * INSTALL nows refers to Doc/Website/Installation.html
1146 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * Added Doc/Website directory, that contains a first raw version
1150 2004-09-23 Jean-Pierre Roux
1151 * FIX In order not to be poluted any longer by casting problems,
1152 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1153 we can now delete[] it safely
1154 * VoidArea is now called BinArea (less confusing name),
1155 and all the methods called ...VoidArea... are now ... BinArea...
1156 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1158 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1160 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1161 up to the destructor of gdcmElementSet to clean up TagHt and it's
1164 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1166 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1168 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * ENH: added some utility method that builds a flat dictionary
1170 holding all the Dicom entries contained in the recursive structure
1171 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1172 an example of usage.
1173 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1174 BuildFlatHashTable() that build a flat dictionary.
1175 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1176 gdcmDocument is now a friend of gdcmElementSet.
1177 - src/gdcmElementSet.cxx: clean up.
1178 - Example/FlatHashTablePrint.cxx added.
1179 - Example/CmakeLists.txt changed accordingly
1181 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1182 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1183 moved away from gdcmDocEntrySet (since this class is an abstract class
1184 acting like an interface). SQDepthLevel and BaseTagKey are now
1186 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1187 and associated accessors. Doxygenation of the class.
1188 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1190 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1191 Use SQDepthLevel accessor instead. ::Print() adapted.
1192 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1193 - src/gdcmDocument.cxx changed accordingly.
1195 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1197 - The following is the doxygen comment of the typedef declaration
1198 of gdcmTagKey in src/gdcmCommon.h:
1199 gdcmTagKey is made to old an "universal" (as in URL, Universal
1200 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1201 A dicom tag always has a group and an element, but a set of tags
1202 embeded in various (optionally nested) sequences and sharing
1203 the same group and element all share the same (group, element)
1204 "identifier". Hence the (group, element) cannot be used as an
1205 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1206 In order to construct a proper tag identifier (i.e. a key) we
1207 consider the following definition of a TagKey:
1208 - let Group, Element be the string representation of the
1209 group and element dicom tag members,
1210 - let ItemNumber be the string representation of the integer
1211 index of the considered item number of a sequence,
1212 Let the key of a tag embeded in a sequence, noted SeqTag, be
1214 /ItemNumber#Group|Element
1215 where "/", "#" and "|" are characters acting as separators.
1216 Then the general form of a gdcmTagKey is given by:
1217 Group|Element<SeqTag>
1218 where <SeqTag> means NO or many instances of SeqTag.
1219 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1222 but the gdcmTagKey of a tag "embeded" is the first item of
1223 a sequence, itself nested in the third item of a sequence is the
1225 0004|1220/2#0008|0082/0#0008|0090
1226 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1227 order to hold the new sequence compatible key. Previously, the
1228 GetKey() method would look in the underlying gdcmDictEntry.
1229 - src/gdcmDocEntry.cxx:
1230 -- constructor now copies the underlying DictEntry key, in the local
1232 -- ::Print: displays the member Key, instead of the (group, element).
1233 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1234 - src/gdcmDocEntrySet.h:xi
1235 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1236 -- now has a new BaseTagKey member.
1238 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1239 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1241 This poses the problem with the semantics of the following lines
1242 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1243 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1244 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1245 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1246 to the long FIXME note for what the problem is. Nevertheless in
1247 order to get things working the dicom dictionary was altered !
1248 Please fix things urgently...
1249 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1250 information), see above note on moving the member VoidArea. Nevertheless
1251 the following entries previously correctly set as US are now inproperly
1253 0028 1201 OW IMG Red Palette Color Lookup Table Data
1254 0028 1202 OW IMG Green Palette Color Lookup Table Data
1255 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1256 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1257 of gdcmDocEntry moved to gdcmSeqEntry.
1258 * src/gdcmSeqEntry.cxx: STYLE.
1260 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1263 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1264 * gdcmPython/testSuite.py: all the test suite in python is now moved
1265 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1266 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1267 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1269 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1271 to avoid inclusion recursion until STL is reached.
1272 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1273 mecanism. errno.h is not included in gdcm anymore.
1274 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1275 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1277 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1278 gdcmData/TestAllEntryVerifyReference.txt
1279 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1280 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1281 exception_on_error parameter.
1282 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1283 - vtk/vtkGdcmReader.cxx changed accordingly,
1284 - Example/*.cxx and Test/*.cxx changed accordingly.
1286 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1288 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1289 enable_sequences removed from gdcmHeader constructor and dependencies.
1290 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1291 * gdcmPython/demo/PrintHeader.py: dummy fix.
1292 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1293 skip_shadow removed from gdcmHeader constructor and dependencies.
1294 * Example/*.cxx and Test/*.cxx changed accordingly.
1296 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1297 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1298 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1300 2004-07-21 Jean-Pierre Roux
1301 * FIX Now, Parsing and Printing a DICOMDIR do work!
1302 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1304 2004-07-20 Jean-Pierre Roux
1305 * FIX Some brain damaged headers have Zero-Lenght fields
1306 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1308 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1309 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1310 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1311 variable (instance of gdcmDebug) by a definition macro, and the instance
1312 is now in static in the gdcmDebug class
1313 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1314 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1316 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1317 * WARNING: ctest now depends more tightly on gdcmData. You should
1318 check out gdcmData properly for things to run smoothly...
1319 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1320 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1321 we need the pixels not be loaded in order to use the ValEntry
1322 that displays position and size).
1323 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1324 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1325 be deprecated. If you have any doubts about the advantages of a
1326 modern scripting language (read Python) versus grass root C++ (i.e.
1327 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1328 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1329 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1330 Anyhow, consider documenting the gdcmData images in
1331 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1333 * Test/CMakeLists.txt:
1334 - now uses TestAllEntryVerify.cxx
1335 - specific comments on oldACR00001.ima (now renamed in gdcmData
1336 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1337 gdcmData/TestAllEntryVerifyReference.txt
1340 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * src/*.[h|cxx] : typedef clean up
1342 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1343 - TagKey renamed to gdcmTagKey (for external usage)
1344 - VRKey renamed to gdcmVRKey (for external usage)
1345 - removal of typedef duplication.
1346 - Removed all unecessary inline keyword from class inline definitions.
1347 - Some method|function(void) declarations replaced with method|function().
1348 * src/jpeg/libijg12/jdhuff12.c:
1349 - printf polluting ctest removed.
1350 - TAB removal for comminting
1352 - TestAllReadCompareDicom.cxx: added a test that compares all the
1353 images in gdcmDataImages.h with corresponding images in
1354 gdcmData/BaselineDicom/. When baseline images are not present
1355 this test creates them.
1356 Note: we need to validate each reference image, but before that
1357 I'd like to rename them with a more explicit name...
1358 - CMakeLists.txt: changed accordingly.
1359 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1360 including each header needed).
1362 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1364 test suite to the Example directory. Are concerned:
1369 - TestWriteSimple.cxx
1370 * Test/CMakeLists.txt: added some comments on reasons for black listing
1371 image gdcmData/oldACR00001.ima
1373 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * Test/CmakeList.txt: removed the following from black list (to be coherent
1375 with removal from gdcmData):
1376 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1377 - gdcm-MR-PHILIPS-16.dcm
1379 Added the following because after last cvs update, they cause
1380 ctest -R TestReadWriteReadCompare
1382 - gdcm-MR-SIEMENS-16-1.acr
1384 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1385 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1386 new comments in this file) we temporarily (sigh) move to a weaker
1388 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1389 we don't need to black list the following images anymore:
1390 - 8BitsUncompressedColor.dcm
1392 - US-PAL-8-10x-echo.dcm
1393 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1394 fixes and the beautified code ;-)
1395 This fixes the bug introduced in version 1.42 (when beautifying)
1396 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1397 Note: ctest was blind to this bug (this means we need to still
1398 improve the test suite). The bug could be detected by using
1399 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1401 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1402 and by displaying the (garbage) produced file temp.XDCM...
1404 2004-06-29 Jean-Pierre Roux
1405 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1406 - replace by uggly but working old code :-(
1407 A lot of things should be OK again.
1408 It's really urgent to have a test suite that *tests*,
1409 to prevent Frog's beautifying sessions to break all the stuff
1410 (twice, withing a fortnigh ...)
1412 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1414 redundancy) to added Test/TestReadWriteReadCompare.cxx
1415 * Test/CmakeList.txt: because the compare test of
1416 Test/TestReadWriteReadCompare.cxx fails, the following images are
1417 black listed: - 8BitsUncompressedColor.dcm
1419 - US-PAL-8-10x-echo.dcm
1420 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1421 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1422 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1423 and ad-hoc kludge. This kludge is now removed, and on encountering
1424 such an image (OB field brain damaged) we set errno. Then in
1425 ::FindDocLength() we "fix" the length as being ALL what remains
1426 in the file (until EOF). We then proceed, hoping for the best...
1427 This fixes a SegFault in ShowDicom when trying to write such an
1429 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1430 (because TestWriteRead breaks on it, after a non conformal commit?).
1431 ctest now runs properly, except for MakeDicomDir (which was always
1432 broken) and the Python related stuff (still not fixed).
1434 2004-06-24 Jean-Pierre Roux
1435 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1436 FIX : Test/TestReadWrite now iterates on all the file names
1437 (instead of infinite loop)
1438 ENH : Test/TestWriteRead now iterates on all the file names
1440 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1441 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1443 2004-06-24 Jean-Pierre Roux
1444 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1445 when SamplesPerPixel =3
1446 - now Write is no longer confused by
1447 'BitsAllocated = 12" and 'BitsStored=12"
1448 - "UN" value representation Elements are now written correctly
1449 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1450 ENH : - now gdcmHeader has its own Write methods
1451 (in order to split the job that has not to be done
1454 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1456 loop on the same image until memory went out.
1457 Note: this means we still have gobs of memory loss in PrintDocument
1458 * src/gdcmDocument.cxx: fixes problem on parsing on file
1459 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1461 2004-06-24 Jean-Pierre Roux
1462 FIX : Write - All the Sequences and Sequence Item are now written
1463 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1464 is added a the end, when necessary.
1465 - A lot of brain-damaged images, that were read correctly are
1466 now written correctly
1467 - length compatible BinEntry are now loaded correctly
1468 (even for odd groups)
1469 Note : only Explicit Value Representation was checked.
1470 (question : is implicit VR really necessary for gdcm ?)
1472 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * DEVELOPPER: added a proposition of coding style.
1474 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1477 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1479 Use the gdcmDocEntry::Print() and Write() instead.
1480 * src/gdcmDocument.cxx: bug fix.
1482 2004-06-22 Jean-Pierre Roux
1483 FIX : gdcmDocument.cxx
1484 - Now we do recognize the JpegLossLess format (there was a misstyping in
1485 code 'beautyfication' :-(
1486 - Now we automaticaticaly load the Luts, if any
1488 2004-06-22 Jean-Pierre Roux
1489 In order : to write Sequences, whatever their imbrication level,
1490 : to allow user to create his own Sequences
1491 a lot of modif where necessary (adding, moving, or virtualising methods)
1493 WARNING : save your own sources *before* cvs up !
1496 ADD virtual void Write(FILE *fp, FileType filetype);
1499 ADD virtual void Write(FILE *fp, FileType filetype);
1500 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1503 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1504 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1505 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1506 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1507 ADD std::string GetEntryByName(TagName name);
1508 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1510 std::string vr = "unkn",
1511 std::string fourth = "unkn",
1512 std::string name = "unkn");
1513 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1514 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1515 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1516 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1517 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1518 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1519 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1520 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1523 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1524 ADD virtual std::string GetEntryByName (TagName tagName);
1525 ADD virtual std::string GetEntryVRByName (TagName tagName);
1526 REM virtual bool Write(FILE *, FileType);
1527 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1528 FILE *_fp, FileType type);
1529 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1530 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1531 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1532 REM virtual std::string GetEntryByName (std::string tagName);
1533 REM virtual std::string GetEntryVRByName (std::string tagName);
1534 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1535 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1536 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1538 std::string vr = "unkn",
1539 std::string fourth = "unkn",
1540 std::string name = "unkn");
1541 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1542 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1543 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1544 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1547 ADD virtual void Write(FILE *fp, FileType filetype);
1550 ADD virtual void Write(FILE *fp,FileType filetype);
1553 ADD virtual void Write(FILE *fp, FileType filetype);
1554 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1555 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1556 REM std::string GetEntryByName(TagName name);
1559 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1561 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1562 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1563 The default constructor invoked by the line
1564 gdcmHeader *f1 = new gdcmHeader( header );
1565 was gdcmHeader::gdcmHeader(bool) instead of the expected
1566 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1567 Hence the parsing wasn't executed... See also below.
1568 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1569 as explicit constructor didn't do the trick to fix the above problem.
1570 Could anyone explain why ?
1571 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1572 properly calls gdcmValEntry::Print() (that was weed out from
1573 code related to gdcmBinEntry).
1575 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1576 * In order to fix memory leaks:
1577 - Test/TestWriteSimple.cxx: added cleaning of free store through
1579 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1580 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1581 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1582 (through the call to ::AddDicomDirMeta()) or the destructor
1583 would crash when deleting uninitialized ::metaElems].
1584 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1585 - src/gdcmDocument.cxx:
1586 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1587 from dynamic stores.
1588 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1589 was causing memory leaks.
1590 - src/gdcmSQItem.cxx:
1591 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1592 cleanly handled with polymophism: sorry but my milage is low).
1593 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1594 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1595 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1596 This avoids SegFaulting.
1597 - src/gdcmSQItem.h: coding style.
1599 - Test/TestWriteSimple still severely sucks. The output image content
1600 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1601 damaged when displayed with vtkgdcmViewer.
1602 - on memory leaks: TestWriteSimple leaks really less (see entry
1603 of 2004-06-18 in Changelog file for the call to valgrind).
1604 - on segfaults: ctest now passes all the tests but one (no more
1606 * Erroneous leading white fix:
1607 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1608 white[s] (as opposed to from >> xxx, that removes it [them].
1609 - src/gdcmTS.cxx: ditto.
1610 - gdcmPython/testSuite.py: dirty related kludge removed.
1611 * src/*: remaining references to gdcmParser removed.
1612 * src/*[cxx|h]: added copy[way]left header.
1615 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1616 * In order to fix writing of dicom files:
1617 - Test/TestWriteSimple.cxx: a simpler example of writing.
1618 - Test/CMakeLists.txt changed accordingly.
1619 - src/gdcmDocument.cxx:
1620 -- The destructor now recursilvely removes potential sequences.
1621 -- Bug fix in ::IsJPEG2000()
1622 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1623 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1625 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1626 to only declared) and build on top of
1627 ::GetDocEntryByNumber(guint16, guint16).
1628 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1629 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1630 for usage in destructor and treatement of promotion in
1631 ::ReplaceOrCreateByNumber().
1632 - src/gdcmSQItem.cxx: destructor should better handle his job.
1633 Test/TestWriteSimple now runs (or at least it DOES something).
1634 * We can now start hutting memory links. A good starting point is:
1635 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1636 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1637 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1639 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * Valgrind note: after Mathieu Malaterre teached me how to read
1641 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1643 Using gcc, you can force the STL to use malloc and to free memory as
1644 soon as possible by globally disabling memory caching.
1645 With 3.2.2 and later, you should export the environment variable
1646 GLIBCPP_FORCE_NEW before running your program.
1647 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1648 simply vanish (it is still not clear to me, whether this means that
1649 STL std::string leaks or if valgrind believes it leaks...).
1650 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1651 running bin/gdcmTests makeDicomDir):
1652 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1653 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1655 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1656 SegFaulting (I drowned in DicomDir related code when trying to
1657 understand why the list is empty...).
1658 * src/gdcmDocument.h: first BSD license header try.
1659 * Doc/License.txt added.
1661 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1662 * src/gdcmDocument.[h|cxx]:
1663 - Clean up of the Transfer related predicates. They are now all based
1664 on new method isGivenTransferSyntax, that (should) handle properly
1665 the padding problem.
1666 - general clean up, simplification, and coding style.
1667 - Specific clean up of Parse7FE0() (umproperly named actually).
1668 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1670 2004-06-14 Jean-Pierre Roux
1672 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1673 - fix the display of SQItem ordinal number
1674 - add the GetSQItemByOrdinalNumber method
1675 - remove some useless never written private methods
1677 2004-06-14 Jean-Pierre Roux
1679 - adding a constructor taking a gdcmDocEntry as an input param
1680 - ReplaceOrCreateByNumber now returns :
1681 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1682 a gdcmValEntry * if a string value is passed as a param
1684 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1685 according to the param type (no longer sets a gdcmDocEntry)
1686 - GetValEntryByNumber, GetBinEntryByNumber added
1687 - NewValEntryByNumber and NewBinEntryByNumber added
1689 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1691 - GetSQItemNumber and SetSQItemNumber added, to provide
1692 a (relative) Item identier inside a given Sequence
1693 \warning : some pb remaining around this number
1695 - AddEntry now takes the Item Number as a param
1697 - adding a constructor taking a gdcmDocEntry as an input param
1699 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * Memory leak hunt with the following command:
1701 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1702 --show-reachable=yes gdcmTests PrintDocument
1703 It looks like many (all?) leaks are due to the STL (or a bad usage
1704 of the STL. The lines producing the leaks now have a comment with
1705 a "MEMORY LEAK" tag: you can retrieve them with
1706 grep "MEMORY LEAK" src/*
1707 Here are two typical examples which I can't help fixing:
1712 char * test = "babo";
1713 name = test; //// <--- valgrind detects 960 bytes lost in
1714 //// call to std::string::operator=(char const*)
1715 name.clear(); //// Doesn't help !
1723 std::cout << "Type a bunch of characters followed by RETURN: ";
1724 getline(std::cin, line); //// <--- valgrind dectects a loss
1725 //// of 1320 bytes in call to
1726 /// std::basic_istream<>& std::getline<>
1732 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1733 * src/gdcmHeader.[cxx|h]:
1734 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1735 and related, moved away to gdcmDocument.
1736 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1737 the corresponding protected accessors of inherited class
1738 gdcmDocument, removed ! As a consequence gdcmFile had to be
1739 declared friend of class gdcmDocument (see below).
1740 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1741 - Clean up of undefined or unused methods.
1742 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1743 account the changes to gdcmHeader.h).
1744 * src/gdcmDocument.h:
1745 - gdcmFile is now a friend class (in order to take into account the
1746 changes to gdcmHeader.h).
1747 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1748 (see changes to gdcmHeader.h).
1749 - Accessors (reading on the form GetEntry*) are now public.
1750 - Clean up of undefined or unused methods.
1751 * src/gdcmDocument.cxx:
1752 - adaptation to changes to gdcmDocument.h
1753 - ::OpenFile now writes a verbose message when file cannot be opened.
1754 - some std::string properly set to VRKey
1755 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1756 references to gdcmDocument.
1757 * Test/TestFindTags.cxx: changed accordingly to above changes.
1758 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1759 cvs repository gdcmData.
1761 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1763 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1764 conflicts with gdcmValEntry::voidArea.
1765 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1766 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1767 Value representation between StringRepresentable and BinaryRepresentable.
1768 * src/gdcmDocument.cxx:
1769 - method ParseDES: proper indentation restored and usage of
1770 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1771 - method LoadDocEntry: the fingerprint left in the SetValue() of
1772 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1773 removed. Reverting to previous code segment with the proper
1774 dynamic_cast< gdcmValEntry* >.
1775 Note: this was (partially) breaking the python test suite
1776 (gdcmPython/testSuite.py) that made usage of the above
1777 fingerprint to check presence of "Pixel Data".
1778 * src/gdcmDocEntry.h: coding style.
1779 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1780 now taken into account.
1781 * gdcmPython/gdcm.i: adaptation to the new internal representation
1782 of gdcm (exit gdcmParser, hello gdcmDocument).
1783 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1785 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1786 anymore, but instead prints the loaded Python dictionary.
1787 * .... alas, the python testSuite is still broken.
1789 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1790 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1792 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1793 * src/gdcmUtil.h : export methods
1795 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1798 * Initial addition of automatic python testing
1799 * Initial addition of automatic image comparison
1801 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1802 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1803 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1805 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1806 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1807 * Test/ShowDicom.cxx : bug fix for msvc compilation
1808 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1810 2004-05-04 Jean-Pierre Roux
1811 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1812 new concepts (and new classes) :
1813 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1814 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1815 - Sequence Doc Entries (gdcmSeqEntries)
1816 a Sequence is composed of Items.
1817 Each item is a set of Doc Entries (this is recursive)
1818 The non uniqueness of the 'Dicom tag' is due to this recursivity
1819 (never taken into account)
1820 Our unability to add a new 'entry' in the header
1821 at the proper location (neither in the H-Table (map or multimap),
1822 nor in the Chained List is also due to this recursivity.
1823 Don't try, right now, to use/modify/compile these new sources :
1824 nothing is finished.
1825 We just commit all the stuff, 'as is', in order not to loose it.
1827 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1828 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1830 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1831 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1832 file prefix (SetFilePrefix)
1834 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1835 * Add a new test: ShowDicom, for now this is just the c++ version of
1836 checkRead.sh, later it will be able to compare the image read against a
1838 * Replace the DEBUG on the stack with a global entry in cmake interface:
1839 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1841 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1842 * Add an example subdir, with a real example on how to read + write a
1845 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1847 * Doc/CMakeLists.txt: the main page is now properly differentiated
1848 between the developper and user version.
1849 * Doc/doxygen.config.in: dropped search related obsolete flags
1850 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1852 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * DEVELOPPER: added some helpfull comments for compile/test/install
1856 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1858 src directory, now generated in the build dir.
1859 2. Tests as mentionned smarter
1861 4. Add a new method in gdcmDict that return the PubDict by name
1862 this is interesting for 3rd party lib like ITK,
1863 where we could set the institution name / patient name...
1865 * ENH: 1. Now the test suite is working for real
1866 2. All binaries are now output in the gdcm-bin directory
1867 (this was not true before)
1869 2004-04-28 Jean-Pierre Roux
1870 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1871 SeQuence indented printing of Dicom Header.
1872 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1873 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1874 Computation of SQDepthLevel is now part of gdcmHeader constructor
1875 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1876 tree-like structure of a Dicom Header.
1877 * FIX Test code cleaning
1879 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * ENH: Adding automatic testing
1881 1. Need a DartConfig.cmake to submit to public
1882 2. Add a test driver gdcmTest.cxx
1883 3. gdcmTestMain, an helper for the main test driver gdcmTest
1884 4. Files in Test don't have a main anymore, this becomes interesting
1885 when we add more and more tests, thus dsw don't have to load
1887 * ENH: Adding a GDCM_DATA_ROOT for testing
1888 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1889 one file instead of seven + some small cleanup
1891 2004-04-22 Jean-Pierre Roux
1892 * ENH Minor changes to the Print() methods.
1893 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1894 Header printing. Example given with :
1895 > PrintHeader fileName 2 new
1896 (SQ based tree-like structure still to be done for the Header ...)
1898 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1899 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1900 1. I have added some unsigned where needed
1901 2. Some function parameter not used -> (void)
1902 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1903 4. g++ don't like character '\' in comment
1904 5. #define jpeg_create_decompress jCreaDecompress
1905 this really need to be fixed
1906 6. virtualize destructor of gdcmObject ... leakage
1907 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1908 this also really need to be fixed
1909 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1910 remove compression file
1911 (as we only do decompression, right ?)
1912 * ENH: Change malloc/calloc/free with c++ equivalent
1914 2004-04-21 Jean-Pierre Roux
1915 * FIX gdcmHeaderHelper::GetXSpacing
1916 when a single value is found (bug ?), xpacing is now
1917 defaulted to yspacing
1919 2004-04-19 Jean-Pierre Roux
1920 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1921 * ENH add parameters :
1922 bool exception_on_error = false,
1923 bool enable_sequences = false,
1924 bool ignore_shadow = false
1925 to the gdcmFile constructors to be full gdcmParser compliant
1926 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1927 to allow reading of PAPYRUS 3.0 files
1929 2004-04-06 Jean-Pierre Roux
1930 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1932 2004-04-02 Jean-Pierre Roux
1933 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1934 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1935 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1937 2004-03-30 Jean-Pierre Roux
1938 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1939 for ACR file, written out as DICOM files (hope so...)
1941 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1943 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1944 moved to base class gdcmParser and only the specialisation is kept
1946 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1947 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1948 already does the job.
1949 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1950 (to be consistent with gdcmParser::WriteEntries).
1952 2004-03-30 Benoit Regrain
1953 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1954 upate of the object's instance. It's passed to 2 in the unfavorable
1955 case : one in the ExecuteInformation, one in the ExecuteData
1957 2004-03-29 Jean-Pierre Roux
1958 * ENH : Check on file type to be written moved
1959 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1960 * FIX : gdcmObject::ResetBoundaries now stops properly
1961 when end-of-list is reached
1962 : gdcmVersion modified (as Benoit Regrain asked)
1964 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1966 * src/gdcmUtil.cxx: added forgotten iostream include.
1967 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1968 equivalent to ExplicitVR in existing code).
1970 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1972 now contains all the gdcmGlobal related code.
1973 * minor coding style and doxygenation changes.
1975 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1976 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1977 now contains all the Debug related code.
1978 * minor clean-up of includes in src/*.cxx
1979 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1980 CreateCleanString) removed.
1981 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1982 * Doc/DoxyMainPageUser.txt added.
1983 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1984 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1985 src/gdcmDirList.cxx)
1987 2004-03-24 Jean-Pierre Roux
1988 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1990 2004-03-23 Jean-Pierre Roux
1991 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1992 big endian made volumes
1993 * ENH Now gdcmParser constructor and destructor are protected to forbid
1994 end user to instanciate class gdcmParser
1995 (only gdcmHeader and gdcmDicomDir are meaningfull)
1997 2004-03-22 Benoit Regrain
1998 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1999 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2000 gdcmSerie to gdcmDicomDirSerie
2002 2004-03-19 Jean-Pierre Roux
2003 * ENH Now the tree-like structure describing a DICOMDIR comming from
2004 an already existing DICOMDIR file is consistent with
2005 the home-made tree-like structure build ex-nihilo
2006 or build from the files held (recursively) in a Directory
2007 functions gdcmDicomDir::CheckBoundaries()
2008 gdcmObject::SetBoundaries() added
2010 2004-03-17 Jean-Pierre Roux
2011 * REM (Eric Boix bug) : removal of meaningless
2012 gdcmDicomDirImage::NewImage function.
2013 * FIX now file names and directory name are written properly in the
2015 * FIX now gdcmDicomDir constructor may be call without any trick
2018 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2020 of gdcmDicomDirImage::NewImage as empty function.
2022 2004-02-28 Jean-Pierre Roux
2023 * ENH add gdcmDicomDir:NewPatient
2024 add gdcmDicomDirPatient:NewStudy
2025 add gdcmDicomDirStudy:NewSerie
2026 add gdcmDicomDirSerie:NewImage
2027 to allow making gdcDicomDir object.
2028 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2029 (as opposite to the gdcmHeader chained list)
2031 2004-02-11 Benoit Regrain
2032 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2033 when using from python
2035 2004-02-10 Benoit Regrain
2036 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2037 * FIX : in gdcmDicomDir when the directory is empty
2038 * ENH : add callback and methods to get the progression of dicomDir
2041 2004-02-06 Jean-Pierre Roux
2042 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2043 - GDCM_META added to gdcmDicomDirType
2044 - class gdcmMeta created
2045 * ENH : - A brief summary is now displayed at the beginning of
2046 'testDicomDir' to help disaster magnitude estimation
2047 * REM : Now useless Test/explDICOMDIR.cxx
2049 2004-02-05 Benoit Regrain
2050 * ENH : add methods in gdcmObject to get the hash table or the list of
2052 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2053 * FIX : wrapping python for TagHeaderEntryHT
2055 2004-02-04 Benoit Regrain
2056 * FIX : even length for some strings when writting the dicom dir
2057 * FIX : sort the images in the dicom dir
2058 * FIX : Bug fix for python use of dicom dir
2059 * ADD : a python demo
2061 2004-02-04 Jean-Pierre Roux
2062 * FIX : Final solution (?) for icone embedded images
2063 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2064 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2065 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2066 gdcmData/gdcm-MR-SIEMENS-16.acr1
2067 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2068 to make full checking easier
2070 2004-02-04 Benoit Regrain
2071 * FIX : WriteEntries : coding style & logic in parameters
2072 * FIX : Set the elements to create the DicomDir in a dictionary file
2074 2004-02-03 Benoit Regrain
2075 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2076 * gdcmDicomDir : add the load of directory
2077 * Bug fix and print add-on
2079 2004-02-03 Jean-Pierre Roux
2080 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2081 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2082 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2083 * FIX gdcmParser.cxx : 'group length' elements are now considered
2084 as integers, even for shadow groups, when file is Implicit VR
2086 2004-02-02 Jean-Pierre Roux
2087 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2089 of the last synonym :-(
2090 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2092 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2093 * FIX taking into account the possible 7fe0,0010 multiplicity
2094 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2095 to allow removal of references to 7fe0,0010, to deal with
2096 ACR-NEMA images, when 0028,0200 is meaningfull
2098 2004-01-31 Jean-Pierre Roux
2099 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2100 no longer writes 'Un' on disk
2101 * FIX SQ elements with actual length are now dealt with corectly
2102 * FIX gdcmFile::WriteBase make the difference, for color images, between
2103 the length (for Palette expanded images)
2104 and Raw Length (non expanded image + Palette)
2105 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2106 (that broke Write). Replaced by UL.
2107 Aware user will reload the field if he
2108 thinks it's necesssary
2110 2004-01-30 Jean-Pierre Roux
2111 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2112 when 'dirty Acr' is found, to be compliant with the new
2113 IsReadable() methods.
2115 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2116 (no DOUBLE images in kosher DICOM,
2117 but so usefull for people that miss them ;-)
2119 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2120 DICOMDIR related utilities (not checked as Windoze compliant)
2122 2004-01-28 Jean-Pierre Roux
2123 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2125 2004-01-27 Jean-Pierre Roux
2126 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2127 to allow skipping the shadow elements, to save memory space.
2128 The TRUE value for this param has to be used
2129 with a FALSE value for the 'enable_sequence' param.
2130 ('public elements' may be embedded in 'shadow Sequences')
2131 * gdcmHeader methods now deal with 'embedded icones images' in the header
2132 (even when an 'icone image sequence' is announced by the
2133 element (0x0088,0x0200), but there is NO icone at all ...
2135 * gdcmHeader sometimes Image Location value doesn't follow
2136 the supposed processor endianity (see gdcmData/cr172241.dcm).
2139 * gdcmHeader add the method
2140 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2141 to get *all* the Header Entries with the same tag.
2142 GetHeaderEntrySameName is probabely *useless*
2143 (no meaning : Name is *not* an identifier within the Dictionary)
2145 2004-01-26 Benoit Regrain
2146 * Bug fix in the print of hexadecimal representations. Remove long fields
2147 in the print and add a third level of print to print them
2149 2004-01-23 Benoit Regrain
2150 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2151 * Bug fix on test suite after remove the strip made on not string fields
2152 * Split the IsReadable method between gdcmParser which test that the file
2153 is dicom and gdcmHeader which test that it's an image file
2155 2004-01-22 Benoit Regrain
2156 * DicomDir : clean code, add methods, set variables in protected or private
2157 * gdcmUtil : bug fix for the clean string method
2159 2004-01-19 Benoit Regrain
2160 * Add the use of shadow dictionaries
2161 * bug fix and coding style
2163 2004-01-19 Benoit Regrain
2164 * src/gdcmFile.cxx : bug fix concerning the close of file
2165 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2166 * Add the update of header entries using the shadow library
2168 2004-01-19 Benoit Regrain
2169 * removal of file gdcmHeader2.cxx
2170 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2171 inheriting from gdcmParser. This split is to prepare the integration
2172 of dicom dir parsing
2173 * bug fix under python
2175 2004-01-16 Jean-Pierre Roux
2176 * REM removal of class gdcmHeaderEntrySet
2177 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2178 * ADD add file gdcmHeader2.cxx
2179 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2181 2004-01-15 Benoit Regrain
2182 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2183 entries created while parsing the header. Thus, they will be destroyed
2184 when the gdcmDictSet will be destroyed
2185 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2188 2004-01-15 Benoit Regrain
2189 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2190 made a fatal error because of the memory release at the end of program.
2191 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2192 some memory and vtk seems to have some problems with that.
2193 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2195 2004-01-14 Benoit Regrain
2196 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2197 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2198 * src/*.[h|cxx] : make changes due to class name changes
2199 * gdcmPython/demo/*.py : bug fix due to method names
2201 2004-01-13 Benoit Regrain
2202 * src/*.[h|cxx] : coding style
2203 * vtk/*.[h|cxx] : coding style
2205 2004-01-13 Benoit Regrain
2206 * gdcmPython/testSuite.py : test the readable flag of file for tests
2207 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2208 It's lied to the stl compilation by MSVC (windows, always windows...)
2209 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2211 2004-01-12 Benoit Regrain
2212 * src/*.h : add comments
2213 * src/gdcmDictSet.h : set the method BuildDictPath in public
2214 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2215 directly setted in the source code
2216 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2219 2004-01-09 Benoit Regrain
2220 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2221 * setup.py : use a reference to gdcmVERSION
2223 2004-01-07 Benoit Regrain
2224 * Modification to compile with the distutils.
2227 2003-12-10 Benoit Regrain
2228 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2229 can use a gdcmHeaderHelper to load data
2230 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2231 made in the source code
2233 2003-12-10 Benoit Regrain
2234 * Update Windows projects and .cvsignore files
2236 2003-11-12 Jean-Pierre Roux
2237 * ENH gdcmHeader constructor has one more parameter (default value : false)
2238 that allows the user to 'go inside' the SeQuences only
2240 gdcmElValSet:Print takes it into account
2242 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2243 * ENH: Update gdcmPython/CMakeLists
2244 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2245 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2247 2003-11-10 Jean-Pierre Roux
2248 * FIX : gdcmHeader::LoadElements is now based
2249 on the ListTag listElem member,
2250 not longer on the TagElValueHT tagHt member
2251 * ENH : PrintPubElVal shows (temporarily) both results,
2252 with the tagHt member and the listElem member.
2253 (it's easier to 'see' the problems when using Printheader)
2255 * FIX : old private member LgrElem is now splitted into
2256 ReadLength : Length actually found on disk (updated only
2257 if bug fixing is necessary), for internal
2259 UsableLength : Updated by FixFoundLength, to fix a bug
2260 or to allow Parser going on.
2261 Will allow to re-write a kosher header when a SeQuence
2262 with a length (not 0000) is found
2263 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2264 because gdcmElValSet::Add does not update ListElem
2267 2003-11-07 Jean-Pierre Roux
2268 * FIX misstyping in Transfert Syntax name table
2269 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2270 when they have an actual length (not 0000 nor FFFFF)
2271 (Nobody should care of it, but DICOMDIR explorers)
2273 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2276 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2277 * ENH: vtkGdcmReader now supports LUT !
2278 (vtkgdcmViewer for now is not able to use them though)
2280 2003-11-05 Jean-Pierre Roux
2281 * in testSuite.py : new files names for checking the package
2282 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2283 that returns the pixel area size to the *aware* (vtk) user
2284 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2286 2003-11-05 Benoit Regrain
2287 * in testSuite.py : Modify the rules for checking the paths
2288 : Explicit error messages
2289 * in __init__.py : Related modif
2291 2003-11-03 Jean-Pierre Roux
2292 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2293 to be used by aware (vtk) users that want to manage
2294 LUT (and no to turn the PALETTE image into an RGB pixels one)
2295 * GetPixelType now returns 8U for 24 Bits images
2296 (vtkGdcmReader compliant)
2298 2003-10-31 Jean-Pierre Roux
2299 * Removal of *all* gdcmData images and add them again
2300 in order to loose the 'history' of un-anonymised images
2302 2003-10-31 Jean-Pierre Roux
2303 * RMV : removal of useless jBitsInJsample.h
2304 for both 8 and 12 Bits JPEG Lossy Libraries
2306 2003-10-31 Jean-Pierre Roux
2307 * ENH : Add the functions gdcmFile::GetImageDataRaw
2308 gdcmFile::GetImageDataIntoVectorRaw
2309 that act as GetImageData and GetImageDataIntoVector
2310 except the making of an RGB Plane from Gray Plane + LUT
2311 Intended to aware (vtk) users who know how to manage
2314 GetLUTRGBA return a R,G,B,A LUT if any
2315 lgrTotaleRaw gives the 'Raw' length
2316 GetImageDataRaw returns the gray Plane
2317 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2318 (They stay Grey, just like with other Dicom viewers :-(
2320 2003-10-30 Jean-Pierre Roux
2321 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2323 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2325 being coherents dicom files.
2327 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2328 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2330 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2331 * ENH: Two steps is necessary to please VC++ compiler...
2332 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2333 * ENH: Add include dir to medcon lib
2334 * FIX: only one function is being exported for now !
2335 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2337 2003-10-29 Jean-Pierre Roux
2338 * adding gdcmHeader::GetLUTRGBA
2339 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2340 --> Mathieu, the modif u're waiting for is not yet committed
2341 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2343 2003-10-27 Jean-Pierre Roux
2344 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2345 00191113.dcm DermaColorLossLess.dcm
2346 MxTwinLossLess.dcm RadBWLossLess.dcm
2347 * ENH: For version prior to vtkImageViewer2 -r 1.19
2348 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2350 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * Removal of ido stuff in CMakeLists.txt
2353 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2354 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2355 * FIX: remove a call to ->Modified ... see comments
2356 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2358 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2359 * FIX: Problem with path for libvtkgdcmPython
2360 * ENH: Try adding a search script for python site-package
2361 * RMV: Remove some file from medcon lib that are not necessary
2362 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2363 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2364 * FIX: More pragma disable fro VC++,
2365 I don't think I break something as it is also disable in VTK/ITK.
2366 But it fasten debug compilation time.
2368 2003-10-23 Jean-Pierre Roux
2369 * gdcm now deals with 16 Bits Run Length Encoded images
2370 (they are compressed as 2 planes images,
2371 one for the high Bytes, the other for low Bytes)
2373 2003-10-22 Jean-Pierre Roux
2374 * Now CheckRead takes into account :
2375 - the bugged 'Leonardo' Siemens images
2376 - the XA images, sent thru the burning VPRO station
2377 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2380 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2381 * FIX: When copying a Makefile.am to CMakeLists.txt
2382 one should remove the '\'
2384 2003-10-22 Jean-Pierre Roux
2385 * in gdcmData adding a bugged 'Leonardo' Siemens image
2386 (wrong lengths in header)
2387 OK with gdcm, KO with the other viewers :-)
2388 * add a GE dlx XA image, thru the VEPRO burning station
2391 2003-10-21 Jean-Pierre Roux
2392 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2393 for a brutal checking of vtkgdcmViewer compliance
2395 2003-10-21 Jean-Pierre Roux
2396 * add the files for 'xmedcon' Jpeg Lossless library
2397 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2399 2003-10-21 Jean-Pierre Roux
2400 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2402 2003-10-21 Jean-Pierre Roux
2403 * garbage Siemens 'Leonardo' images dealt with
2404 (the patch is easy to remove)
2405 * cosmetic changes to avoid warnings
2407 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2408 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2409 no need to press 'r' now.
2411 2003-10-20 Jean-Pierre Roux
2412 * upgrade of checkRead.sh checkWrite.sh according
2413 to new Jpeg Lossless decompressor
2414 * add US.3405.1.dcm, a genuine RGB medical file ...
2415 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2416 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2418 2003-10-15 Jean-Pierre Roux
2419 * general anonymisation in gdcmData
2420 * adding the 'color files' from
2421 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2422 * adding some well knowed bugged-header images
2423 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2424 waiting for their inclusion in Python testsuite
2426 2003-10-15 Jean-Pierre Roux
2427 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2428 no longer seg faults when file is not found
2430 2003-10-14 Jean-Pierre Roux
2431 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2434 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2435 * TODO: *.in file to genereate a UseGDCM later
2437 2003-10-14 Jean-Pierre Roux
2438 * Some supposed-to-be Dicom Images have no preamble.
2439 OpenFile takes it into account
2440 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2441 * Missing elements added in dicomV3.dic
2442 (just to be affraid : have a look at
2443 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2444 and do it again next year ;->
2446 2003-10-13 Jean-Pierre Roux
2447 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2448 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2449 But there are NOT. It's fixed !
2451 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2452 * FIX: "jpeglib.h" was not found on VC++
2453 * FIX: vtkgdcm was not being installed
2455 2003-10-10 Jean-Pierre Roux
2456 * ENH : OpenFile closes the file if it *really* doesn't look like
2457 an ACR-NEMA / DICOM one.
2458 * FIX : testWrite no longer writes an empty file if the source file
2459 is not gdcm Readable
2460 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2463 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2464 * FIX: CMake generate now documentation
2465 * ENH: out of source doc build !
2466 * ENH: Generate both user and dev documentation
2467 * ENH: Should work on windows too
2468 * ENH: Only one doxygen config.in file is needed
2469 * FIX: make install should be ok now on ùnix plateform
2470 * FIX: PATH to dictionary was wrong (missing /)
2471 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2473 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2474 * vtkGdcmReader is now able to read rgb dicom file.
2475 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2476 * added a gdcmViewer to vtk test, use mouse to control
2477 window level & window width
2479 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2480 * CMake-ification of gdcm, we have now two build system
2481 * FIX: on cygwin Wsock32 doesn't exist
2482 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2484 2003-10-06 Emanuel Ollart
2485 * FIX : compilation process wad broken.
2486 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2488 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2489 * change gdcmViewer -> vtkgdcmViewer
2490 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2492 2003-10-06 Jean-Pierre Roux
2493 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2494 ( e.g : well known GE images with a wrong elem length,
2495 : Philips MRI Images with a wrong Huffman table)
2496 * still to be done : allow the reading of bugged LEONARDO Siemens images
2498 2003-10-03 Jean-Pierre Roux
2499 * Odd length strings are padded with '\0' (not with spaces,
2500 to remain compliant with already defined strings,
2501 like Transfert Syntax UID and others)
2503 2003-10-03 Jean-Pierre Roux
2504 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2505 to allow displaying RGB images (not only by affim ;-)
2507 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2508 * vtkGdcmReader is now able to read rgb dicom file.
2509 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2511 2003-10-03 Jean-Pierre Roux
2512 * A few nasty patches to allow the reading of a lot of nasty images
2513 ( e.g : well known GE images with a wrong elem length,
2514 : Philips MRI Images with a wrong Huffman table)
2515 * still to be done : allow the reading of bugged LEONARDO Siemens images
2517 2003-10-03 Jean-Pierre Roux
2518 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2520 2003-10-03 Jean-Pierre Roux
2521 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2522 to allow displaying RGB images (not only by affim ;-)
2524 2003-10-03 Jean-Pierre Roux
2525 * gdcmFile::GetImageDataIntoVector now
2526 - deals with MultiFrames MultiFragments Run Length Encoded files
2527 - deals with YcBcR (YBR_FULL) files
2528 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2529 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2531 (no sample found :-(
2533 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2534 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2535 Two reasons: - clear things
2536 - third parties acces gdcm through header files, so won't
2537 suffer anymore VC++ complains
2539 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2540 * add argv[1] in testvtkGdcmReader.cxx
2543 2003-09-24 Jean-Pierre Roux
2544 * The lines are now eigthy characters long.for
2545 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2547 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2548 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2549 char* to std::string. Thus, the use of strdup becomes useless. (see
2550 previous commis of Malaterre)
2551 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2552 before the last Malaterre's commit.
2554 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2555 * This commit should fix the Debug building under VC++, the problem
2556 was mainly a mixture of debug and release lib being loaded at startup.
2557 * I also remove a depency to a specific C function: strdup. Because I had
2558 to force the link to msvcrtd (whereas strdup is in libc).
2560 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2561 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2562 located in the gdcmCommon.h file. All use of reference of tha has been
2563 changed to now use the variable GDCM_UNFOUND.
2565 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2567 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2568 Dicom dictionary. The test suite can now be run again. Note:
2569 I'm note very happy with the " (RET)" changes. I believe this
2570 RETAINED comment should be dropped when parsing the dictionary.
2571 - PACKAGER corrected
2573 - AUTHORS updated and now in alphabetical order
2574 * Makefile.am now exports gdcm.dsw for Windoze users.
2576 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2577 * cygwin complains about missing std:: in subdir Test/
2579 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2580 * remove some methods that are now in gdcmHeaderHelper
2582 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2583 * vtkGdcmReader set spacing and origin correctly
2585 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * Fix a few delete/delete[] mismatch
2588 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2589 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2590 interpretation to data given by gdcmHeader. For instance there are
2591 heuristics to get informations (look at different places).
2592 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2593 sorting DICOM images based on different strategies.
2594 * modified Makefiles accordingly.
2596 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2597 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2598 when building in debug mode
2599 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2600 src/win32/gdcmdll.dsp
2601 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2603 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2604 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2607 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2608 * src/win32/libgdcmjpeg12.dsp was not dos format
2609 * src/win32/libgdcmjpeg12.dsp :
2610 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2611 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2613 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2614 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2616 * src/gdcmFile.cxx : bug fix in affectation type
2617 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2618 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2619 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2620 symbols... future problem ?
2622 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2623 * src/win32/libgdcmijpeg12.dsp was missing
2624 * modified gdcm.dsw accordingly
2626 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2629 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2630 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2631 commit of JPR (before his hollidays to facilitate our work).
2632 * setup.py : bug fix in code. Modifications made while the last commit
2633 of JPR. The code hasn't been tested before the commit... it's so
2634 useless to make that (for best programmer that is JPR) !!!
2636 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * tagged the current version as Version0_3 (i.e. version 0.3)
2639 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2640 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2641 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2642 * *.dsp : modifications to use new libgdcmijpeg8 library
2643 * setup.py : bug fix on VTKPATH variable
2644 * PACKAGER : adding all concerning windows
2646 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2649 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2650 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2651 test suite reported error.
2652 * PACKAGER file added (describes what a packager must do when
2653 packaging a new release).
2654 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2655 * configure.in: upgraded version number to 0.3.0
2656 * fixing build of rpm (through rpm -ta):
2657 - Doc/Makefile.am exports proper doxygen files
2658 - src/jpeg/libijg8/Makefile.am exports the include files.
2660 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2661 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2662 * src/gdcmHeader.h : formatting code
2664 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2665 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2666 We were obtaining error message from vtk. Now, creation of file list
2667 is made in an internal list to prevent this problem.
2668 Bug fix when output is empty.
2669 Bug fix in update of progress value. Previous commit for this was a bad
2671 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2673 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2674 * src/gdcmHeader.h : added method to get the file name
2675 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2676 files. Added method to remove all files on the input
2677 Added FIXME comment concerning the bad parsing of header made by
2678 ExecuteInformation method (in ExecuteData method)
2680 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2682 when using make instal.
2683 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2684 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2686 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2687 * setup.py : adding include dir of jpeg lib to compile all sources
2688 * */Win32/*.dsp : JPR fix for windows compilation
2690 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2691 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2693 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2694 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2696 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * setup.py is again effective on un*x (takes into account the
2698 addon of the jpeg library)
2699 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2700 * Doc/Doxy* updated (includes above enhancements)
2701 * INSTALL now points to web documentation
2703 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2704 * src/gdcmHeader.h doesn't make unnecessary reference to
2706 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2708 * src/gdcm*.[cxx|h] :
2709 - to allow compilation with gcc 3.x
2710 -- clean up of STL usage (added explicit usage of std::)
2711 -- small fixes on exceptions.
2712 Note: linking not tested !
2713 - clean of doxygen comments to avoid warnings at documentation
2715 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2716 dependent convertion).
2718 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * Clean up of previous JPR garbage commit (not even commented in the
2721 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2722 - moved all jpeg related files from src to src/jpeg/libijg8, with
2723 addition/modification of Makefile.am and configure.in.
2724 - the testSuite is still brain damage (not guilty).
2726 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2727 * WrapVTK.py : modifications to get correctly vtk source files to
2729 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2730 (FileName -> Filename)
2732 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * vtk/vtkGdcmReader.[cxx/h]:
2734 - UpdateProgress method should now be effective
2735 - removed the limitation on having only images loaded (as opposed
2737 - when building a stack of images/volume, a lesser number of
2738 gdcmHeader and gdcmFile instances should be used (hopefully
2739 accelerating things).
2740 - when building a stack of images/volumes, files which are not
2741 loadable (wrong path-filename, wrong permissions on existing file,
2742 or file not parsable by gdcm) are replaced with a black image
2743 in the stack (for the caller to notice the problem).
2745 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2748 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2749 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2750 between standard library (std) and vtk library (problems are found
2751 under Windows... thanks Windows !)
2753 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2756 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2758 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2761 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * When compiling with distutils (see setup.py) the C++ compiler is
2763 called with different flags than the default ones (with automake).
2764 In order to fix all those warning, I compiled gdcm with the command
2765 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2766 and went for warning fixes:
2767 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2768 up from unused variables.
2769 - vtk/vtkGdcmReader.cxx: potential bug fix.
2770 * src/gdcmHeader.h: Doxygen warning cleanup
2772 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2773 * gdcmPython/gdcm.i:
2774 - typemaps correction to take into account the systematic replacement
2775 of "using namespace std" with std:: prefix e.g. std::list,
2776 std::string... (cf changes of 2003-05-21).
2777 - gdcmGlob global variable of type gdcmGlobal (defined in
2778 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2779 exported to Python a as cvar.
2780 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2781 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2782 gdcmDictSet.GetPubDictTagNames() and
2783 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2784 C++ static methods).
2785 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2786 with the above changes.
2788 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2789 * setup.py, manifest.in : bug fix under linux
2791 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2792 * Modification of setup.py to compile vtk part too. Then, we have 2
2793 wrappers which must work with same distutils. For that, we have a
2794 generic distutils in distusiltsWrapping.py ; with :
2795 - build_extWrap class to wrap generically all extensions,
2796 - ExtensionWrap base class for all wrapping extension that contains
2798 - Wrapper interface which wrap sources
2799 + In WrapSwig.py we have extension and wrapper for Swig
2800 + In WrapVTK.py we have extension and wrapper for VTK
2801 * MANIFEST.in : modifications to consider vtk directory and new python
2802 files for compilation
2804 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2805 * Added python wrappers of vtkGdcmReader vtk class (see the
2806 source in vtk/vtkGdcmReader.cxx) :
2807 - vtk/Makefile.am now builds a library
2808 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2809 python library (as opposed to _gdcm.so wich are the python
2810 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2811 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2813 - configure.in has an additional flag --enable-vtk that needs
2814 to be set to enable compilation of vtk related code, that is:
2815 + vtk/vtkGdcmReader.so and
2816 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2817 + gdcmPython/vtkgdcmPython.so (see above)
2818 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2819 be read when compressed or when HighBit + 1 != BitsStored),
2820 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2821 the usage of the python wrapper of vtkGdcmReader vtk class.
2822 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2823 * src/*.[h] all occurences of stl classes are now prefixed with
2824 std::, and all occurences of "using namespace std;" where removed.
2825 This is to avoid pollution of global namespace in included files.
2826 Apparently vtk does not avoid this pitfall: when using both
2827 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2828 collision of various stl members (principally cout...).
2829 * gdcmPython/testSuite.py now cleanly removes temprory generated
2831 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2832 comply with above changes)
2834 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2835 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2836 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2837 vtk data structure (an image Flip was required).
2838 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2839 * cosmetic changes in documentation.
2841 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2842 * src/gdcmHeader.cxx: the constructor no longer exits when an
2843 unexisting file is given as argument.
2844 * The subdirectory Data (containing all the images used for the
2845 test suite) is not part of this repository anymore. A new module
2846 containing those images is now available at
2847 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2848 with the name gdcmData.
2849 All the python scripts (including the package initialisation file
2850 gdcmPython/__init__.py) were adapated to take this change into
2851 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2853 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2854 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2855 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2856 demo of the usage of this class.
2857 Compilation of this vtk part is only done when using the --enable-vtk
2858 at configure (or autogen.sh) stage.
2860 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2861 * More memory link related corrections and documentation fixes.
2863 - maximum info is obtained with a command of the form:
2864 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2865 --show-reachable=yes PrintHeader
2866 - the remaining reachable blocks seem to come from the STL
2867 allocation scheme through the usage of map and list. It looks
2868 like this memory cannot be freed but it is not a memory leak
2869 (in fact further invocation to the STL would recollect the
2870 unused memory allthough it cannot explicitely be freed).
2871 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2872 of displaying an image parsed with gdcm and displayed with VTK.
2873 Note: some images don't seem to work e.g.
2874 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2875 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2876 Allthough this weakens the semantics, it is a ditch attempt to
2877 make gdcm more thread friendly.
2879 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2880 * Memory link hunt (by using valgrind through the command
2881 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2882 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2883 gdcmHeader::_dicom_vr.
2884 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2885 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2887 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2889 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2890 * src/Makefile.am now exports all the necessary include files at
2894 * UpdateGroupLength replaced by new one
2897 * UpdateGroupLength re-written using H-Table
2898 (named UpdateGroupLengthNew untill checks are over)
2900 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2901 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2902 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2904 - gdcmHeader::GetPubElValSet removed.
2905 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2906 UpdateGroupLength, WriteElements, Write.
2907 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2908 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2909 carried the same semantics.
2910 - src/gdcmHeaderIdo.cxx changed accordingly.
2911 - gdcmFile::WriteBase now regroups all the codes from previous
2912 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2913 - enum FileType moved to gdcmCommon.h
2914 * src/gdcmHeader.cxx AddDefault trashed
2915 * gdcmGetXSize added
2916 * getimageDataSize now calls gdcmGetXSize
2917 * Test/*.cxx changed to agree with above changes
2919 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2921 (to avoid double call by end user).
2922 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2923 by end user, since gdcmHeader::gdcmHeader now handles it.
2925 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * gdcm/Doc many doxygen changes:
2927 - Doxyfile now has two different versions, DoxyfileUsers that generates
2928 the html.users end users oriented documentation and
2929 DoxyfileDeveloppers that generates the html.developper developper
2930 oriented documentation.
2931 - README changed accordingly
2932 - requirement.txt removed (old design info moved to TODO).
2933 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2934 DoxyMainPage.txt, DoxyPython.txt provide more information.
2935 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2936 be updated by simply regenerating the docs with doxygen and copying
2937 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2938 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2939 all the tests in the form "if (<map>.count() >1)" were removed.
2940 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2941 ill-formed documentation sections.
2942 * src/gdcmHeader.cxx: ditto
2944 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2945 * setup.py fixed for un*x (needed macro for stdint.h)
2946 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2947 un*ces with sh-utils test utility.
2948 * gdcmPython/demo/test.py renamed to PrintHeader.py
2949 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2950 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2951 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2952 * src/gdcm*.cxx JPR's bad inclusion fixed.
2954 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2956 * gdcmPython/demo/test.py changed accordingly.
2958 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * gdcmPython/Makefile.am fixed linking against libstdc++
2960 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2961 * Swig subdir (historical tests of swig version 1.3.17++) removed
2962 * Test/testChangeEntete.cxx some lines commented out in order to make
2964 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2965 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2967 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2969 hence the user doesn't need this explicit call.
2970 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2971 i.e. LoadElements() call removed.
2972 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2973 - src/Makefile.am declares the proper flag for g++.
2974 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2975 for adding user defined new tags.
2976 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2977 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2978 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2980 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2981 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2982 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2983 src/Makefile.am : the project should properly compile and install
2984 with the autotools, included the python wrappers part.
2985 * gdcm.spec.in : added a spec file for RPM packaging.
2987 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2988 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2990 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2991 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2992 to exported to the environement (see gdcmPython/testSuite.py
2994 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2995 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2996 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2997 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2998 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3000 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3001 * gdcmPython/__init__.py doesn't crash anymore when running in
3002 in InstallMode or PreInstallMode but with an environment given
3003 value of GDCM_DICT_PATH.
3004 * src/gdcmDictSet.[cxx/h] coding style.
3006 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3007 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3008 * src/gdcm.h general comments moved to TODO, and README
3009 * src/gdcm.h should now be seen as a user commodity (including it
3010 should suffice to fully use gdcm). It is nowhere including within
3011 any of the kernel files src/*.cxx and src/*.h.
3013 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3014 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3015 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3017 * src/gdcm*.cxx only include their corresponding include file
3018 (as opposed to gdcm.h)
3019 * gdcmPython/gdcm.i changed accordingly
3020 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3021 the autogen.sh generated "make snapshot" command to work.
3022 * autogen.sh removed history related references to crea package.
3024 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3025 * distutilsSwigCPlusPlus.py work around some swig portability
3028 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3030 was done in a last ditch attempt to get setup.py _really_
3031 operationnal. The python/gdcmPython layaout add the advantage
3032 of hidding away the python related distutils specific files
3033 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3034 Alas, the src directory was out of scope (i.e. it's relative
3035 position to setup.py was ../src) which made things impossible to
3036 handle (see previous version of python/setup.py). Crossing fingers...
3038 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * python/setup.py now works on Un*x. (harder than I thougth)
3040 * python/distutilsSwigCPlusPlus.py can now have include files
3041 among the list of sources.
3043 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3044 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3045 * modifications in MSVC projects
3047 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * As stated by the first lines of Test/ExceptionAndPython/README, it
3049 looks like we can move back to original usage of exception within
3050 src/gdcm* and hence remove the errno stuff that was introduced
3051 as a quick and dirty fixture of this problem (added to the TODO).
3052 * Doc/Doxyfile configuration file for Doxygen and corresponding
3053 README file for usage added.
3054 * Test/testWrite.cxx added. This new test comes from a split of
3055 test.cxx that is now reverted to its original purpous i.e.
3056 testing the proper parsing of a Dicom related file.
3057 testWrite.cxx concentrates on testing the IO part of gdcm.
3058 * Test/bug1.cxx (containing a bug on WIn32) added.
3059 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3060 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3061 whose purpose is to publish the content of the TagNames of the
3062 Dicom public dictionary were not accessible without an
3063 instance of class gdcmHeader.
3064 - those methods are now static methods of gdcmDictSet and hence
3065 require no instances at all to be invocated.
3066 - within gdcmDictSet this change required to change some method
3067 to class methods (i.e. are now static) among which SetDictPath
3068 (renamed to BuildDictPath) and LoadDefaultPubDict.
3069 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3070 the above changes by calling the new method classes of gdcmDictSet.
3071 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3072 the above to be effective.
3073 * python/gdcmPython: in order to wrap properly the above changes
3074 for Python, swig version now needs to be > 1.3.17.
3075 * python/gdcmPython/Makefile fixed to adapt itself to new
3076 configure/make shema introduced by Johan Montagnat (thanks for the
3077 contribution). Alas this Makefile cannot be turned into a proper
3078 Makefile.am without some heavy changes in the configure.in
3079 (for python dectection).
3080 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3081 now avoids publishing the empty entries.
3083 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3084 * python/setup.py : bug fix concerning install under windows
3085 ExtraPath reused :-P
3086 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3088 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3089 * Dicts/dicomV3.dic : remove double spaces !!!
3090 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3091 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3094 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3096 method. Doxygenation.
3097 * src/gdcm.h clean up of JPR spurious comments.
3099 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3100 * python/distutilsSwigCPlusPlus.py now properly collects the
3101 shadow classes generated by "swig -c++" (gdcm.py in our case)
3102 when using "python setup.py install".
3103 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3104 reexports the working classes.
3105 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3106 by the classical C errno scheme. This is to prevent an obscure
3107 behavior of the python wrappers when importing wxPython.wx prior
3108 to gdcmPython (which ended up in an abort call). An illustration
3109 of this oddity can be found in the Test/ExceptionAndPython
3110 subdir (see the README file). This problem probably due to
3111 an combination of g++ and dynamic loading.
3112 * added Test/ExceptionAndPython (see above)
3114 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3115 * Changed the layout of the python part to avoid bloating main
3116 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3117 i.e. the distutils arsenal. All the python related stuff is
3118 again in a python subdir, but the package itself is now in
3120 * setup.py was cleaned up:
3121 - pythonIncludePath removed
3122 - python setup.py bdist target is now functional.
3123 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3124 collision with other packages). gdcmPython/demo/*.py changed
3127 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3128 * python subdir moved to gdcmPython (preparation of distutils packaging).
3129 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3130 distutils installer is operational.
3131 * - gdcmPython/__init__.py now properly loads the swig generated
3132 shadow classes (from gdcm.py).
3133 - gdcmPython/demo/*.py changed to import the package gdcmPython
3134 instead of gdcmPython/demo/load.py.
3135 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3137 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3139 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3140 entries within the associated public Dicom dictionary resp. the same
3141 information but sorted by the fourth field (PAT, IMG, DIR) of the
3143 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3144 are now in the "???" group.
3145 - python/gdcm.i changed accordingly,
3146 - python/demo/printGroupedPublicDict.py added, that gives an example
3147 of the above new functionalities in Python.
3149 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * src/gdcm.h, gdcmHeader.cxx:
3151 - historic references to glib's g_malloc and g_free (#defined)
3152 were definitively removed.
3153 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3154 * src/gdcmElValSet.cxx:
3155 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3156 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3157 - GetElValue(string) renamed to GetElValueByName.
3158 - Added GetElementByName(string).
3159 * src/gdcmHeader.cxx: added
3160 - GetPubElValRepByNumber(guint16, guint16)
3161 - GetPubElValRepByName(string)
3162 - GetShaElValRepByNumber(guint16, guint16)
3163 - GetShaElValRepByName(string)
3164 - GetShaElValByNumber(guint16, guint16)
3165 - GetShaElValRepByName(string)
3166 - GetElValRepByNumber(guint16, guint16)
3167 - GetElValRepByName(string)
3168 - GetElValByNumber(guint16, guint16)
3169 - GetElValRepByName(string)
3170 * Doc/requirements.txt added.
3172 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3173 * Test/Makefile building now depends on the one of libgdcm.so
3174 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3175 pixel data) aware which enables finding the address (offset) of
3176 the pixel data of JPEG encoded DICOM files. This leaves only a single
3177 file in the testSuite whose pixel data address (offset) is unknown.
3178 * python/testSuite.py changed accordingly.
3180 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3181 * VC++ has some strong limitations when working with the STL, as stated
3182 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3183 "Also note that some STL containers (map, set, queue, list, deque)
3184 cannot be exported. [...]
3185 Some STL classes contain nested classes. These classes can not
3187 This is caused by a designed limitation that once a template
3188 class is instantiated, it can not be re-instantiated and
3190 Since our usage of map<> is ubiquitous in gdcm, this "designed
3191 limitation" of VC++ is a pitfall.
3192 Hence the Python wrappers of gdcm cannot be incrementally linked
3193 against the c++ dynamic library. The dirty but only workaround is
3194 to forget about incremental link of dynamic libraries and to generate
3195 the Python wrappers library with the inclusions of the underlying C++
3197 The following modifications concern this matter on Win32/VC++:
3198 - wrapping python correct with standalone wrapped dll (don't use separate
3199 dll under windows !!!!)
3200 - python21_d debug mode enabled (ask Frog how to use it :-)
3201 - NO problem with having an STL member of class for example string in C++
3202 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3203 - Python test of dcmlib in Python is ok under windows on a large set
3205 * removed glib references
3206 * typedef's inserted in gdcm.i for correct swig type management
3208 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3209 * python/demo/*.py load.py extracted from test.py. Added explore.py
3210 that only displays required tags and testAll.py that parses all
3211 the files of the testsuite without using unittest.
3212 * python/testSuite.py other additional test on new files added.
3213 * Data/* new test files added accordingly to the testSuite.
3214 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3215 the vr in the file differs from the one of the dictionary.
3217 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3218 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3219 values, but limits itself to values which are below a user specified
3220 size (by default 1024 bytes).
3221 * python/gdcm.i : elements not loaded (because their size is above the
3222 user specified treshold) are exported with their TagKey as key of the
3223 python dictionary. This enables the testsuite to make some checks
3224 on the unloaded elements (since we have their offset and size).
3225 * python/testSuite.py
3226 - now tests for the existence and proper value of the pixel data
3227 - two new examples added.
3228 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3230 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3231 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3232 aware. See the strategy comments in gdcmHeader::FindLength().
3233 * Test/test.cxx now accepts a filename as first argument.
3234 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3235 * python/testSuite.py changed to integrate test on above files.
3237 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3238 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3239 the vr was also RET.
3240 * python/testSuite.py more tests added.
3242 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3243 * python/testSuite.py unittest test suite added (uses Data)
3244 * Data/* dcm and acr files for the test suite.
3245 * glib dependance removed from un*x version. We now use ISO C99
3246 7.18 Integer types (see stdint.h)
3247 - python/Makefile, src/Makefile src/gdcm.h
3248 * src/ when an explicit vr (like dicom files) suddenly poped an
3249 implicit element we use to mark the underlying DictEntry of the
3250 concerned ElValue with "Implicit". This strategy was damageable
3251 too the public or provite dictionaries, since some of their vr
3252 would be changed. Since Header::FindLength heavily relies on the
3253 detection by Header::FindVR of falsely explicit elements, I
3254 added an extra ImplicitVr member to ElValue (boolean).
3255 The rest of the changes we the necessary adaptations.
3257 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3258 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3260 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3262 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3263 * Adaptation for porting to VC++:
3265 o forced to use std namespace (for string to be known)
3266 o all class use __declspec export style on WIN32
3267 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3268 (in stdlib.h on Win32 but in std:: for gcc)
3269 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3270 variable GDCM_DICT_PATH.
3271 * src/gdcmHeader.cxx verbose comments made discrete.
3273 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3274 * python/gdcm.i: added a typemap that converts a C++ hashing table
3275 to native Python dictionary.
3276 * python/demo/test.py:
3277 - now uses the native dictionary for exploration of gdcmHeader.
3278 - takes an optional filename argument (the file to parse).
3279 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3280 PubElVals hashing table.
3281 * Dicts/dicomV3.dic removed error prone trailing spaces.
3283 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3284 * Python wrapping process moved away from src/Makefile to
3285 newly created python/Makefile (as well as gdcm.i)
3286 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3287 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3288 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3289 from the environement variable GDCM_DICT_PATH (when existing).
3290 * src/gdcmDict::GetTag bug fix.
3292 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3293 * Straightforward temporary fixes for swig to build the python wrappers.
3294 src/Makefile now has a python working entry [by working we mean
3295 that we can import the shadow classes without errors].
3297 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3298 * hashtest.cxx removed (since already in Test)
3299 * src/gdcmlib.h renamed to src/gdcm.h
3300 * src/dcm.i renamed to src/gdcm.i
3301 * src/Makefile prepared for python wrapping
3303 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * src/gdcmHeader.cxx :
3305 - Parsing of header is now separated from loading of element values
3306 (see gdcmHeader::LoadElements).
3307 - general clean up of hopefully all file access (creation of
3308 ReadInt16 and ReadInt32)
3310 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * src/gdcmHeader.cxx :
3312 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3314 - SetLgrElem renamed to SetLength
3315 - GetLgrElem renamed to GetLength
3316 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3317 * src/gdcmElValSet.cxx fixed both GetElValue methods
3318 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3319 due to IdoDude was cleaned out.
3321 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3322 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3323 concentrates on finding the value representation (when it exists).
3324 RecupLgr now only finds the element value length, and it avoids
3325 returning the unecessary skL (skipped length).
3326 Also, offsetCourant was simply removed (with taille_fich) since
3327 it was redundant with the File position internals (by using
3328 ftell and fseek). This also made skL (see above in RecupLgr) usage
3330 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3331 on the libido specificities which are handled through class
3333 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3336 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * Truckload of changes. Parsing of header is barely functional
3338 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3340 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3341 * src/gdcmHeader.cxx many addons of low level methods
3343 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3345 and _IdDcmSWAP_LONG.
3347 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3348 * This corresponds to all the changes decided at the meeting of
3349 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob