1 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/VTKTest*.cxx : bug fix under linux
4 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
6 use with python. Some methods ard moved from Document to ElementSet or
7 DocEntrySet. The equivalent methods to ElementSet have been added to
8 SQItem and are virtual in DocEntrySet. Methods that may have the same code
9 in SQItem and ElementSet is directly placed in DocEntrySet
11 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Test/VTKTest*.cxx : remove the show variable in each test method because
13 it's useless (the viewer variable replace this variable)
15 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmDocument.cxx : bug fix on potential memory leak
17 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
18 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
19 Add ClearXxx methods to remove all the content of the list or map
20 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
22 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Grealty simplify the JPEg decompression, no need to differenciate based on
24 the JPEG possible type (with/without fragment, with/without multiple frame).
25 Everything is done throught the JPEG IO Suspension mechanism in IJG
27 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
29 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
30 with other method names
31 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
32 * Test/TestDicomDirElement.cxx : add new test
34 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
36 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
37 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
38 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
39 So can't you use __int64 in ostream at all.
41 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * bug fix for compilation on MSVC6
43 * gdcmPython/gdcm.i : rename of classes missed
45 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
47 type and not a string. So, there remove problems on the format of the
50 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
52 Thus, DicomDirXXX are created with a flad that indicates if the created
53 object is empty or not (when not empty, the DicomDirElement is used to
56 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
58 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
60 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
63 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
65 Remove all access to the hash-tables or lists in the objects.
67 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
69 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
70 be complient with all the gdcm source code
72 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
76 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
80 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Test/ : rename VTK tests to have a best name for the tests
82 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
83 GetFirstEntry/GetNextEntry use
85 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
87 test. Now it's on image content and not on the resulting visualisation...
88 might solve the problem on linux when using the OpenGL drivers
90 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
91 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
92 DicomDirSerie, DicomDirImage
93 Dict, DictSet classes :
94 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
95 -remove InitTraversal method.
96 * UPD Test programs + Example programs
98 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
99 remove useless and never updated keyword \ingroup
101 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
103 is no memory access violation
104 * gdcmPython/demo : add python demos using VTK
106 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
107 * FIX 'Dictionnary' is now spelt 'Dictionary'
108 'wether' is now spelt 'whether'
109 'archieve' is now spelt 'archive' ;-)
111 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
112 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
113 related methods, in order not to expose internal mechanisms
116 * REM methods that exposed internal mechanisms :
117 DicomDir::GetDicomDirPatients()
118 DicomDirPatient::GetDicomDirStudies()
119 DicomDirStudy::GetDicomDirSeries()
120 DicomDirSerie::GetDicomDirImages()
121 * UPD Test programs :
125 * UPD Example program
127 * ADD DictSet methods
131 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
132 * Removed the Print/indent/default parameter mess. There is absolutely no
133 reason to have to methods, moreover with the second taking the ostream as
134 *SECOND* parameter. This was clearly a bad hack to get things compile.
136 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * Complete rewrite of the GetMacAddress code. Now the code is *much*
138 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
139 Unfortunately the main code does not work on SunOS, thus provide a specific
140 code for this platform only (and Win32 of course). Since this seems to be
141 working, change CreateUniqueUID to use GetMACAddress instead of the
142 problematic GctestetIPAddress
144 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
145 * Unfortunately to be able to test gdcmDirList I had to break the API
146 a little. Now the class is not a std::list anymore but has a member
147 std::vector (more ITK compatible). Allow unit testing on Win32 and
150 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * Update SerieHeader to take into account a Serie Instance UID to properly
154 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
155 * ENH - Comment out Mathieu's (dangerous) Super Hack
156 for dealing with BIGENDIAN processors
157 - Move equivalent stuff to BinEntry::WriteContent
158 When necessary, 16 Bits Pixels are swapped in a small buffer
159 and then written. This avoid allocating a huge buffer, in
160 PixelWriteConvertor, and avoid modifying the Pixel Area.
162 Probabely, the same operation will have to be done when we want
163 to write image with Big Endian Transfert Syntax,
164 and we are working on Little Endian Processor
166 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
169 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
170 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
171 all the dict content.
172 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
174 * Test/TestDict.cxx : add a new test for the dict classes
176 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
177 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
178 file. Debug is yanked if compiled with NDEBUG
180 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDictSet.h : set the default output to the os variable
182 * src/gdcmDictEntry.[h|cxx] : add the Print method
183 * gdcmPython/demo/ : add a new test
185 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
186 * merging of Test/PrintDicomDir and Test/TestDicomDir
187 * removal of now redundant Test/PrintDicomDir
188 * enhancement of Example/PrintDicomDir
190 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Now, python test might work on systems
192 * Add the PrintDicomDir test
194 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
195 * FIX : First entry following group 0002 was lost for
196 Explicit Big Endian Transfer Syntax files
197 (group and elem not swaped)
199 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
200 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
201 Big Endian Transfer Syntax supposed the group following 0002
202 begins always by element 0000 (element 0000 is *optional*)
203 To avoid further troubles, let's be pessimistic, and use
204 Document::HandleOutOfGroup0002() method
205 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
206 (related pb not yet solved)
208 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * Bug fix for the python part use
210 * Now, PrintHeader.py pass... but outside the ctest use. shit !
212 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
215 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
217 a string and should ask the global TS dict what are the propreties of
220 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
221 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
222 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
223 to swap the Swap Code, at parsing time, when we come out of group 0002
224 and Transfer Syntax is Big Endian
225 We should be able to read now 'true DICOM" Big Endian coded images
226 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
227 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
229 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
230 * Hopefully fix the bug on MacOSX and static global initialization.
231 This is the only -minor- patch I found that both please MacOSX and VS6.
232 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
233 but this would require a lot of change. Another approach would be that Global
234 create those string and GDCM_UNFOUND becomes a pointer to a string (which
235 gdcm::Global would destroy at exit).
237 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
238 * Fix bug on MacOSX with static initialization in a multy threaded
239 environment. static const string in a header file used to be ill
240 initialized provoquing the freeze of any tests. patch should solve this
243 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
244 * According to Benoit's suggestion, and without any objection from anybody
245 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
246 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
247 - method gdcmDicomDirObject::GetEntry() renamed as
248 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
250 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
252 you debug/warning message just as c++ streams which make them very convinient
253 to use. Once this is stabilize I will change the ostringstrem to be
254 redirected to a file (ofstream).
255 * Properly support C99 extension: __FUNCTION__ which allow us to display
256 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
258 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
259 * Removal of useless and dangerous methods :
260 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
261 GetDocEntryByName, GetEntryByName, GetDictEntryByName
262 * Removal of usless methods :
263 Dict::PrintByName, Dict::GetDictEntryByName
264 * Commenting out of probabely useless methods :
265 Dict::GetDictEntryNames()
266 Dict::GetDictEntryNamesByCategory()
267 DictSet::GetPubDictEntryNames()
268 DictSet::GetPubDictEntryNamesByCategory()
269 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
270 * ENH : Use dicomTS.dic as described in 2004 version
271 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
272 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
273 Add Accessors on VM (Value Multiplicity), and VM related methods
274 * ADD : Add a list of 'Dicom Attribute types', as found in
275 http://medical.nema.org/dicom/2004/04_15PU.PDF
277 * ADD : Add dicomGroupNameAbbreviations.dic
278 should be used to write a method to replace the former
279 Dict::GetDictEntryNamesByCategory()
281 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
283 to read in the file... and only it ! Length is the efective length of the
284 data in the DocEntry structure
286 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
288 And now use a static function call instead, with a global variable. i
289 This is much closer to the VTK approach. Hopefully should be bulletproof
290 and easier to use...hopefully
292 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
293 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
295 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
298 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
300 ValEntry, BinEntry, SeqEntry creation or replace
302 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
304 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
306 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
307 when specifying the VR
308 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
309 * src/gdcmDocEntry.cxx : amelioration of print
311 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
312 * ADD : Add the method Util::IsCurrentProcessorBigEndian
313 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
314 * ADD Method Document::ComputeGroupLength
315 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
316 in order to allow further VR modification by user
317 * REM : removal of once-called method File::WriteBase
318 integration of its code in formerly one-line method File::Write
320 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
322 replace the different values "??", "Unkn", "Unknown".
323 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
324 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
325 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
326 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
328 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
331 * Set the gdcm::Base class to some Printable classes
333 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmFile.[h|cxx] : add the Print method
335 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
336 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
337 * src/gdcmDocument.h : remove the PrintLevel informations
338 * Example/PrintFile.cxx : use the new gdcm::File::Print
340 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
342 problems when compiling with the python wrapping
344 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
346 writting in ImplicitVR
348 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
349 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
350 JPEG decompression, especially when dicom frames are split into several
351 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
352 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
354 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmHeader.cxx : change the initialisation of default header.
356 Now, this header is readable by gdm, e-film, DicomWorks
358 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
360 Rename Decompressed to Raw
361 * Use the API changes in gdcm::File.
362 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
365 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
367 each added entry in the header. Replace the 'Planes' field by the 'Number
370 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
371 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
372 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
374 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
376 At this time, this image isn't readable by e-film... waiting JPR help to
379 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
381 DocEntry. Now use methods of the Document !
383 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * Test/ShowDicomSeq.cxx : bug fix
386 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
388 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
389 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
390 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
392 * Test/TestCopyRescaleDicom.cxx : remove unused variable
393 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
394 containing found sequences
396 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
399 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
400 Some fields in BinEntry must be copied to not seg fault when making the :
401 gdcm::File *copy = new gdcm::File( copyH );
402 and tests are now made on good variables
404 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
406 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
408 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
409 * Add vtkGdcmWriter example and test
411 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Test/TestUtil.cxx : reformat the source code
413 * vtk/vtkGdcmReader.cxx : remove and change prints
414 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
416 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
417 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
419 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
421 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
423 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
425 by an eof to prevent all bad read of the file... and in this case, the
428 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * Example/Volume2Dicom.cxx : comment unused variables
430 * Test/PrintDicomDir.cxx : comment unused variables
431 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
432 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
433 method that is redondant with AddEntry.
434 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
437 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
438 * Bug fix due my last commit (compilation under Windows).
439 * Example/Volume2Dicom : bug fix in the file and reformatting source code
440 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
442 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 - Remove printf / sprintf
445 - include iostream AFTER gdcm so we don't get warnings
446 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
448 - Also remove tons of include from header files, hopefully this should
449 speeup the compilation time, since it was becoming a dog slow.
450 - Remove gdcm.h as it include way too many files and slow down compilation
451 (plus it is not up to date)
452 - remove 'using namespace std' this is BAD !
454 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * Remove memory leaks on the DicomDir
456 * Remove some useless data in DicomDirObject
457 * Add usefull methods in SQItem, to be complient withe the ElementSet
459 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
462 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
463 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
464 future, with convertion)
465 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
466 and ImageDataSize values. Remove the method to get the PixelReadConverter
467 from the output of the class
469 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
470 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
472 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
474 and vtkErrorMacro use.
475 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
477 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
480 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
481 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
482 The string leaves only in the fonction. So when we make a .c_str(), we
483 get the pointeur on the first element, element that will be destroyed
484 immediately after thee instruction.
485 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
486 file has been opened : the test must be made on the content of the
487 pointer and not directly on the pointer !
490 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
492 the python part recompiles
494 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
496 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
497 X session is killed (for my computer... it seems to not be identic on
500 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
502 avoid problems (otherwise, the difference test between the visible image
503 and the reference is incorrect. If the reference is greater than the
504 screen resolution, it's produce errors).
505 Can be used for only one image. Can be used with a visible flag.
506 * vtk/vtkGdcmReader.cxx : remove commented codes.
507 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
508 under windows at compilation
509 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
511 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
513 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
515 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
516 tests on the image size X, Y, Z
518 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
520 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
521 between the class name and the file name
523 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/ : fix compilation warnings for the Write method (2 different
525 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
526 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
527 variable... create a static method in gdcm::Document to access to
528 this variable content.
530 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
532 file, to be accessed by other files (like gdcmFile). Remove commented
533 code. Move the change of the header to the gdcmFile, using the
535 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
536 To be sure of that (and simplify calls), the Write of the header now
537 gets a file name and not a file pointer (std::ifstream).
538 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
539 DocEntryArchive. Remove all open of the written file
541 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
544 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
546 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
548 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
549 some corresponding methods. Write correctly the file and check before
551 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
552 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
553 is now on RGB data (as before my last commit
554 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
556 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
558 Add a print information of the type of the entry
559 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
560 It was in the gdcmFile, and all write have been regrouped
561 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
562 Write correctly all dicom files (in decompressed mode only at this time)
563 * Test/ : test on files are now made using Raw data and not color data if
565 * Example/PrintFile.cxx : add more printings
567 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
568 * Amelioration of code, remove some code copy. For the loading of
569 BinEntry (in gdcmDocument), add the test to verify if the file is already
572 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
573 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
574 remove a DocEntry in the header (push an empty DocEntry)
575 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
576 lines. Bug fix in the initialization of the PixelConvert and the
578 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
579 use in TestCopyDicom (now this test can run under windows... but fails)
580 * Test/TestCopyDicom.cxx : amelioration of the test :
581 - test the pixels written
582 - add test points to quickly find where is the error
583 - can set a file name input and output in arguments
584 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
585 amelioration of the test output
587 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
588 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
589 all replaced DocEntry's
590 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
591 Now, each needed DocEntry to modify is duplicated, modified and inserted
592 to the header using DocEntryArchive. Thus, after save, we can restore the
593 header initial state.
595 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
598 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
600 correct to copy it. The DictEntry is specified at the DocEntry creation,
601 then, it musn't change in the time.
602 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
603 header correctly. At this time, the change is only made for the first
604 level of the Document. In the future, it might consider sequences.
605 The change is made by replacing a DocEntry by an other that is created
606 outside the class. The old value is kept. When we restore the header
607 status, the added DocEntry is deleted and replaced by the old value.
608 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
609 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
610 set the write type to explicit VR, implicit VR or ACR. Add methods to set
611 the write mode to native, decompressed or RGB (but not used at this time)
613 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
615 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
617 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
618 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
619 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
621 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
622 set because already copied when copying the BinEntry's of the header
623 * Test/TestAllReadCompareDicom.cxx : remove warnings
625 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
627 Two problems appear when doing it :
628 - with the gdcmFile : when the GetImageData method is called, the pixels
629 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
630 data (pixels). And each structure destruct the data when it's
631 destructed. So we have two destructions for the same data. To solve it,
632 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
633 data or not. If it doesn't own data, then they will not destroyed by
635 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
636 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
637 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
638 create a double destruction of the same DocEntry's. So, to solve it,
639 the TagHT is simply cleared and the DicomDir* elements are destroyed.
640 * TODO : add an entry concerning memory leaks in the DicomDir
642 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
644 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
647 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
649 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
650 after it have been deleted
652 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * FIX: src/* fix the doxygen warnings.
654 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
655 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
656 was erroneously defined with a size of 15 instead of 16. [many thanks
657 to Jean Michel Rouet for pointing out this bug].
659 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
660 1. Finish merging JMR patch for writting DICOM from scratch
661 2. Fix -hopefully- bug with MONOCHROME and space vs null character
662 3. Use const ref when possible
663 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
664 5. A few more comments
665 6. CreateUniqueUID can now be called without parameter"
667 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
668 * ENH: Slightly bigger patch:
669 1. Getting toward full integration of JMR patch for writting dicom from scratch
670 2. Update Test to test part of this patch: CreateUniqueUID
671 3. File was not close properly in gdcmDict
672 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
673 5. Use of const ref instead of copy (speed issue)
674 6. Remove temporary (duplicate) string in TranslateToKey
675 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
676 8. Do not repeat virtual in subclasses
677 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
679 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
680 * Apply first patch toward better string comparison when dealing with broken
681 DICOM files. Essentially the string could be padded with a space instead
682 of a null character as defined by standard
684 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
685 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
686 because never used... and in the same time, that's remove some memory leaks
688 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
689 * src/gdcmFile.cxx : now delete the PixelConvert instance.
690 * In examples and tests : change the type of image data variables from void*
691 to uint8_t*. Remmove all delete on image data variables
693 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
695 Verify the file pointer value before open the file, and if it's not null,
696 a verbose message is generated.
697 Close correctly the file when the file isn't considered dicom-like. The
698 correctly close is a call to CloseFile.
699 When closing the file pointer, test if its not null to close the file.
700 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
701 file. For an uncompressed image, the copied data correspond in the least
702 case to the image size (calculated) or the image size specified in the
703 header. A verbose is generated if these two size mismatch
705 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
707 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
708 break under windows (with msvc6 compilation).
710 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
711 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
712 compiling with MSVC6)
714 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * Bugs fix for the Windows build with VC6
716 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
717 needed (only for projects required VTK). If the VTK is included in all
718 projects, there is conflicts with the jpeg lib of vtk when compiling the
719 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
720 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
721 when compiling the gdcm_wrap.cxx file (created by the compilation of the
723 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
724 (like it's already made for the cout use). Otherwise, conflict with the
727 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
730 - comments on the DicomDir::Method related usage added.
731 - now that we use the namespace gdcm, a lot of internal classes do
732 NOT need to be wrapped anymore.
733 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
734 DicomDir::Method) new example added.
736 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
737 * Improve string manipulation. I now inforce the notion of 'DicomString'
738 A DicomString can contain as many \0 as they want
739 and it is *always* of even length.
740 We only support odd length for very rare case.
741 And in the near future this should be removed.
743 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
744 * /binary_write/ gdcm source. Now even on big endian we are writting
745 little endian. This should -heopfully- fix some tests
747 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
748 * Now the dictionary is compiled into gdcm lib. This is a default
749 behavior, thus any dic file specified is picked before failback to
750 the one comiled into lib
752 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * Change internals for gdcmDict. Don't use any 'new' any more.
754 This should definitely solve any leak problem, and we should be
755 as fast as before, as long as don't modify too much the dictionary.
757 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
758 * STYLE: ivars should start with a capital letter.
759 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
760 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
762 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
764 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
765 new 2004 dictionaries added (thanks to JPR).
766 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
767 * CLEANUP_ROUND (15) for gdcmPixelConvert
768 - RLEFrame::NumberFragments is now of type unsigned int
769 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
770 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
773 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
774 * Initial work in gathering all transfer syntax accessors. clearly
775 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
776 ivars, but only one transfersyntax (class) ivar with equivalent method on
779 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
780 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
781 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
782 discussed (plus I didn't like having a 2000 lines patch not commited)
784 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
786 * CLEANUP_ROUND (14) for gdcmPixelConvert
787 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
788 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
789 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
791 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
792 anymore and hence avoids storing a copy of PixelConvert::Decompressed
793 into File::Pixel_Data.
795 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
797 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
798 * CLEANUP_ROUND (13) for gdcmPixelConvert
799 Substituted File::ParsePixelData() with PixelConvert::Print() new
801 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
802 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
803 method to those classes.
804 - src/gdcmFile.[cxx|h]:
805 -- Added a ::Print() method.
806 -- PixelConverter is now a reference instead of a member.
807 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
808 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
810 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
812 collaboration diagram and inheritance diagram should be generated with
814 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
815 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
816 pointlessly wrapped (see
817 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
818 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
819 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
820 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
821 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
822 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
823 -- File::Initialise: PixelConverter setup moved away to
824 PixelConverter::GrabInformationsFromHeader()
825 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
826 interpretation moved away to PixelConverter::BuildRGBImage()
828 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
829 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
830 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
832 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
834 displayed on Win32 when a brutal abort() occurs (because of uncatched
835 exception). See TODO new entry of this commit for more on this.
836 * TODO added new entry.
837 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
838 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
839 - HandleColor is no longer called from gdcmFile.cxx
840 - gdcmPixelConvert.cxx clean up on method arguments and internal
841 variable names for semantical coherence.
843 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * Finished lossless transition, not only do we now read all lossless jpeg
845 images, without the need of the Cornwell lib, but we do read them properly now
846 * To reduce code (well to avoid code duplication), I defined a common place
847 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
848 redefine symbols. This is not perfect but this the best solution I found for a
849 compilation time jpeg option.
851 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
852 * Update jpeg ijg lib to support lossless jpeg implementation
853 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
855 * Also added a special copyright for dcmtk since we use their bugfixes.
858 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
860 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
861 matters, as stated in warning note at begining of %include section).
862 * src/gdcmDicomDir*.[cxx|h]: coding style
863 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
864 * src/gdcmJpeg8.cxx: doxygen fix.
865 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
866 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
867 from File:: to PixelConvert::.
869 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
871 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
872 - more code moved away from File:: to PixelConvert::
873 - fat setup of PixelConverter set in place in File::Initialise.
875 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
876 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
877 namespace at the file system level. So now you should convert your examples
879 gdcmHeader -> gdcm::Header
880 It would be nice if people keep in mind to no open the namespace, since it
881 allows compilation on broken plateform which were defining common symbol in
882 the standart namespace (like LP, Unknown ...)
884 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
886 The JPEG fragments are now parsed at the same stage than the RLE
887 information. All code related to JPEG is now in gdcmPixelConvert:
888 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
889 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
890 export a gdcmFile:: method. Those are simply global functions
891 (for the time being this is better than having them attach to
892 either gdcmFile:: or gdcmPixelConvert::).
893 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
894 and stores the result in a gdcmJPEGFragmentsInfo.
895 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
896 code (among other stuff) moved away from gdcmFile:; to
899 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
901 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
902 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
903 clean up of RLE related code.
904 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
905 - src/gdcmRLE.cxx removed
906 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
907 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
908 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
909 * CLEANUP_ROUND (9) for gdcmPixelConvert
910 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
911 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
912 away from gdcmFile:: to gdcmPixelConvert::.
914 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
916 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
917 This is because Parse7Fe0 used to parse the pixels to compute the
918 length. This task was passed over to FindDocEntryLengthOB() a long
919 time ago, EXCEPT I had forgotten the OW case...
920 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
921 we just recylce the code for parsing RLE fragments and computing
923 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
924 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
925 with the retired Parse7Fe0().
926 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
927 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
929 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
931 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
932 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
933 - src/CMakeLists.txt: alphabetic order reodering + new entries.
934 * CLEANUP_ROUND (4) for gdcmPixelConvert
935 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
936 to return an unused length.
938 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
940 this should be cleanner from the plane view. The iostream are erally a pain
941 to use to do simple stuff.
943 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * Redo the compilation of the ijg jpeg library. Now only one source is
945 necesseray. No need to rename file by hand what so ever. CMake handle the
946 copying of the file within different directory, configure header file to
947 modify some symbol. The only addition made to ijg wasd a mangle table so
948 that symbol are different whether we are within 8bits or 12bits.
950 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * Added documentation of vtkgdcmReader on Website:
952 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
953 with it's binary name).
954 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
955 the Website to be more complete.
956 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
957 doxygenated documentation.
958 - Doc/DoxyVtkGdcmReaderExamples.txt added
959 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
960 DoxyVtkGdmReaderExamples.html )
961 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
962 * CLEANUP_ROUND (3) for gdcmPixelConvert
963 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
965 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * CLEANUP_ROUND (2) for gdcmPixelConvert
967 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
969 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * CLEANUP_ROUND for gdcmPixelConvert:
971 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
972 - src/gdcmPixelStuff[h|cxx] removed
973 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
974 - src/CMakeLists.txt changed accordingly
976 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
977 gdcmVersion.py moved to newly created ATTIC related
978 gdcmPython/SetupOldies/ directory.
979 * Autotools clean up:
980 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
981 - autogen.sh configure.in acinclude.m4 python.m4 removed
983 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
984 * src/*.cxx *.h Reference to License.htm fixed to License.html.
985 * Doc/CMakeLists.txt, doxygen.config.in: fix.
986 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
988 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * TODO updated with Mathieu suggestions. I proposed a template for
990 describing TODO entries and used it for new entries.
991 * Added Doc/Website/CodingStyle.html, Developpers.html,
992 DeveloppersPython.html, GdcmDataCvs.html and
993 DownloadVersion0_1.html, DownloadVersion0_3.html.
994 * Some Doc/*.txt Doxygen files (which do not really concern the
995 documentation itself, but the website) moved to html and
996 placed in directory Doc/Website:
997 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
998 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
999 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1000 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1001 * CMakeLists.txt changed accordingly.
1002 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1003 DeveloppersPython.html
1004 * INSTALL nows refers to Doc/Website/Installation.html
1006 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * Added Doc/Website directory, that contains a first raw version
1010 2004-09-23 Jean-Pierre Roux
1011 * FIX In order not to be poluted any longer by casting problems,
1012 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1013 we can now delete[] it safely
1014 * VoidArea is now called BinArea (less confusing name),
1015 and all the methods called ...VoidArea... are now ... BinArea...
1016 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1018 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1020 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1021 up to the destructor of gdcmElementSet to clean up TagHt and it's
1024 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1026 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1028 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * ENH: added some utility method that builds a flat dictionary
1030 holding all the Dicom entries contained in the recursive structure
1031 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1032 an example of usage.
1033 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1034 BuildFlatHashTable() that build a flat dictionary.
1035 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1036 gdcmDocument is now a friend of gdcmElementSet.
1037 - src/gdcmElementSet.cxx: clean up.
1038 - Example/FlatHashTablePrint.cxx added.
1039 - Example/CmakeLists.txt changed accordingly
1041 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1043 moved away from gdcmDocEntrySet (since this class is an abstract class
1044 acting like an interface). SQDepthLevel and BaseTagKey are now
1046 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1047 and associated accessors. Doxygenation of the class.
1048 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1050 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1051 Use SQDepthLevel accessor instead. ::Print() adapted.
1052 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1053 - src/gdcmDocument.cxx changed accordingly.
1055 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1057 - The following is the doxygen comment of the typedef declaration
1058 of gdcmTagKey in src/gdcmCommon.h:
1059 gdcmTagKey is made to old an "universal" (as in URL, Universal
1060 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1061 A dicom tag always has a group and an element, but a set of tags
1062 embeded in various (optionally nested) sequences and sharing
1063 the same group and element all share the same (group, element)
1064 "identifier". Hence the (group, element) cannot be used as an
1065 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1066 In order to construct a proper tag identifier (i.e. a key) we
1067 consider the following definition of a TagKey:
1068 - let Group, Element be the string representation of the
1069 group and element dicom tag members,
1070 - let ItemNumber be the string representation of the integer
1071 index of the considered item number of a sequence,
1072 Let the key of a tag embeded in a sequence, noted SeqTag, be
1074 /ItemNumber#Group|Element
1075 where "/", "#" and "|" are characters acting as separators.
1076 Then the general form of a gdcmTagKey is given by:
1077 Group|Element<SeqTag>
1078 where <SeqTag> means NO or many instances of SeqTag.
1079 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1082 but the gdcmTagKey of a tag "embeded" is the first item of
1083 a sequence, itself nested in the third item of a sequence is the
1085 0004|1220/2#0008|0082/0#0008|0090
1086 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1087 order to hold the new sequence compatible key. Previously, the
1088 GetKey() method would look in the underlying gdcmDictEntry.
1089 - src/gdcmDocEntry.cxx:
1090 -- constructor now copies the underlying DictEntry key, in the local
1092 -- ::Print: displays the member Key, instead of the (group, element).
1093 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1094 - src/gdcmDocEntrySet.h:xi
1095 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1096 -- now has a new BaseTagKey member.
1098 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1099 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1101 This poses the problem with the semantics of the following lines
1102 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1103 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1104 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1105 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1106 to the long FIXME note for what the problem is. Nevertheless in
1107 order to get things working the dicom dictionary was altered !
1108 Please fix things urgently...
1109 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1110 information), see above note on moving the member VoidArea. Nevertheless
1111 the following entries previously correctly set as US are now inproperly
1113 0028 1201 OW IMG Red Palette Color Lookup Table Data
1114 0028 1202 OW IMG Green Palette Color Lookup Table Data
1115 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1116 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1117 of gdcmDocEntry moved to gdcmSeqEntry.
1118 * src/gdcmSeqEntry.cxx: STYLE.
1120 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1123 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * gdcmPython/testSuite.py: all the test suite in python is now moved
1125 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1126 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1127 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1129 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1130 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1131 to avoid inclusion recursion until STL is reached.
1132 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1133 mecanism. errno.h is not included in gdcm anymore.
1134 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1135 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1137 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1138 gdcmData/TestAllEntryVerifyReference.txt
1139 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1140 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1141 exception_on_error parameter.
1142 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1143 - vtk/vtkGdcmReader.cxx changed accordingly,
1144 - Example/*.cxx and Test/*.cxx changed accordingly.
1146 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1148 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1149 enable_sequences removed from gdcmHeader constructor and dependencies.
1150 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1151 * gdcmPython/demo/PrintHeader.py: dummy fix.
1152 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1153 skip_shadow removed from gdcmHeader constructor and dependencies.
1154 * Example/*.cxx and Test/*.cxx changed accordingly.
1156 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1158 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1160 2004-07-21 Jean-Pierre Roux
1161 * FIX Now, Parsing and Printing a DICOMDIR do work!
1162 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1164 2004-07-20 Jean-Pierre Roux
1165 * FIX Some brain damaged headers have Zero-Lenght fields
1166 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1168 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1169 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1170 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1171 variable (instance of gdcmDebug) by a definition macro, and the instance
1172 is now in static in the gdcmDebug class
1173 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1174 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1176 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * WARNING: ctest now depends more tightly on gdcmData. You should
1178 check out gdcmData properly for things to run smoothly...
1179 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1180 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1181 we need the pixels not be loaded in order to use the ValEntry
1182 that displays position and size).
1183 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1184 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1185 be deprecated. If you have any doubts about the advantages of a
1186 modern scripting language (read Python) versus grass root C++ (i.e.
1187 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1188 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1189 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1190 Anyhow, consider documenting the gdcmData images in
1191 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1193 * Test/CMakeLists.txt:
1194 - now uses TestAllEntryVerify.cxx
1195 - specific comments on oldACR00001.ima (now renamed in gdcmData
1196 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1197 gdcmData/TestAllEntryVerifyReference.txt
1200 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * src/*.[h|cxx] : typedef clean up
1202 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1203 - TagKey renamed to gdcmTagKey (for external usage)
1204 - VRKey renamed to gdcmVRKey (for external usage)
1205 - removal of typedef duplication.
1206 - Removed all unecessary inline keyword from class inline definitions.
1207 - Some method|function(void) declarations replaced with method|function().
1208 * src/jpeg/libijg12/jdhuff12.c:
1209 - printf polluting ctest removed.
1210 - TAB removal for comminting
1212 - TestAllReadCompareDicom.cxx: added a test that compares all the
1213 images in gdcmDataImages.h with corresponding images in
1214 gdcmData/BaselineDicom/. When baseline images are not present
1215 this test creates them.
1216 Note: we need to validate each reference image, but before that
1217 I'd like to rename them with a more explicit name...
1218 - CMakeLists.txt: changed accordingly.
1219 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1220 including each header needed).
1222 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1223 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1224 test suite to the Example directory. Are concerned:
1229 - TestWriteSimple.cxx
1230 * Test/CMakeLists.txt: added some comments on reasons for black listing
1231 image gdcmData/oldACR00001.ima
1233 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * Test/CmakeList.txt: removed the following from black list (to be coherent
1235 with removal from gdcmData):
1236 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1237 - gdcm-MR-PHILIPS-16.dcm
1239 Added the following because after last cvs update, they cause
1240 ctest -R TestReadWriteReadCompare
1242 - gdcm-MR-SIEMENS-16-1.acr
1244 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1245 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1246 new comments in this file) we temporarily (sigh) move to a weaker
1248 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1249 we don't need to black list the following images anymore:
1250 - 8BitsUncompressedColor.dcm
1252 - US-PAL-8-10x-echo.dcm
1253 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1254 fixes and the beautified code ;-)
1255 This fixes the bug introduced in version 1.42 (when beautifying)
1256 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1257 Note: ctest was blind to this bug (this means we need to still
1258 improve the test suite). The bug could be detected by using
1259 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1261 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1262 and by displaying the (garbage) produced file temp.XDCM...
1264 2004-06-29 Jean-Pierre Roux
1265 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1266 - replace by uggly but working old code :-(
1267 A lot of things should be OK again.
1268 It's really urgent to have a test suite that *tests*,
1269 to prevent Frog's beautifying sessions to break all the stuff
1270 (twice, withing a fortnigh ...)
1272 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1273 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1274 redundancy) to added Test/TestReadWriteReadCompare.cxx
1275 * Test/CmakeList.txt: because the compare test of
1276 Test/TestReadWriteReadCompare.cxx fails, the following images are
1277 black listed: - 8BitsUncompressedColor.dcm
1279 - US-PAL-8-10x-echo.dcm
1280 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1281 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1282 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1283 and ad-hoc kludge. This kludge is now removed, and on encountering
1284 such an image (OB field brain damaged) we set errno. Then in
1285 ::FindDocLength() we "fix" the length as being ALL what remains
1286 in the file (until EOF). We then proceed, hoping for the best...
1287 This fixes a SegFault in ShowDicom when trying to write such an
1289 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1290 (because TestWriteRead breaks on it, after a non conformal commit?).
1291 ctest now runs properly, except for MakeDicomDir (which was always
1292 broken) and the Python related stuff (still not fixed).
1294 2004-06-24 Jean-Pierre Roux
1295 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1296 FIX : Test/TestReadWrite now iterates on all the file names
1297 (instead of infinite loop)
1298 ENH : Test/TestWriteRead now iterates on all the file names
1300 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1301 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1303 2004-06-24 Jean-Pierre Roux
1304 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1305 when SamplesPerPixel =3
1306 - now Write is no longer confused by
1307 'BitsAllocated = 12" and 'BitsStored=12"
1308 - "UN" value representation Elements are now written correctly
1309 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1310 ENH : - now gdcmHeader has its own Write methods
1311 (in order to split the job that has not to be done
1314 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1315 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1316 loop on the same image until memory went out.
1317 Note: this means we still have gobs of memory loss in PrintDocument
1318 * src/gdcmDocument.cxx: fixes problem on parsing on file
1319 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1321 2004-06-24 Jean-Pierre Roux
1322 FIX : Write - All the Sequences and Sequence Item are now written
1323 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1324 is added a the end, when necessary.
1325 - A lot of brain-damaged images, that were read correctly are
1326 now written correctly
1327 - length compatible BinEntry are now loaded correctly
1328 (even for odd groups)
1329 Note : only Explicit Value Representation was checked.
1330 (question : is implicit VR really necessary for gdcm ?)
1332 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * DEVELOPPER: added a proposition of coding style.
1334 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1337 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1339 Use the gdcmDocEntry::Print() and Write() instead.
1340 * src/gdcmDocument.cxx: bug fix.
1342 2004-06-22 Jean-Pierre Roux
1343 FIX : gdcmDocument.cxx
1344 - Now we do recognize the JpegLossLess format (there was a misstyping in
1345 code 'beautyfication' :-(
1346 - Now we automaticaticaly load the Luts, if any
1348 2004-06-22 Jean-Pierre Roux
1349 In order : to write Sequences, whatever their imbrication level,
1350 : to allow user to create his own Sequences
1351 a lot of modif where necessary (adding, moving, or virtualising methods)
1353 WARNING : save your own sources *before* cvs up !
1356 ADD virtual void Write(FILE *fp, FileType filetype);
1359 ADD virtual void Write(FILE *fp, FileType filetype);
1360 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1363 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1364 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1365 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1366 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1367 ADD std::string GetEntryByName(TagName name);
1368 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1370 std::string vr = "unkn",
1371 std::string fourth = "unkn",
1372 std::string name = "unkn");
1373 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1374 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1375 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1376 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1377 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1378 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1379 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1380 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1383 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1384 ADD virtual std::string GetEntryByName (TagName tagName);
1385 ADD virtual std::string GetEntryVRByName (TagName tagName);
1386 REM virtual bool Write(FILE *, FileType);
1387 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1388 FILE *_fp, FileType type);
1389 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1390 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1391 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1392 REM virtual std::string GetEntryByName (std::string tagName);
1393 REM virtual std::string GetEntryVRByName (std::string tagName);
1394 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1395 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1396 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1398 std::string vr = "unkn",
1399 std::string fourth = "unkn",
1400 std::string name = "unkn");
1401 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1402 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1403 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1404 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1407 ADD virtual void Write(FILE *fp, FileType filetype);
1410 ADD virtual void Write(FILE *fp,FileType filetype);
1413 ADD virtual void Write(FILE *fp, FileType filetype);
1414 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1415 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1416 REM std::string GetEntryByName(TagName name);
1419 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1421 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1423 The default constructor invoked by the line
1424 gdcmHeader *f1 = new gdcmHeader( header );
1425 was gdcmHeader::gdcmHeader(bool) instead of the expected
1426 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1427 Hence the parsing wasn't executed... See also below.
1428 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1429 as explicit constructor didn't do the trick to fix the above problem.
1430 Could anyone explain why ?
1431 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1432 properly calls gdcmValEntry::Print() (that was weed out from
1433 code related to gdcmBinEntry).
1435 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * In order to fix memory leaks:
1437 - Test/TestWriteSimple.cxx: added cleaning of free store through
1439 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1440 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1441 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1442 (through the call to ::AddDicomDirMeta()) or the destructor
1443 would crash when deleting uninitialized ::metaElems].
1444 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1445 - src/gdcmDocument.cxx:
1446 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1447 from dynamic stores.
1448 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1449 was causing memory leaks.
1450 - src/gdcmSQItem.cxx:
1451 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1452 cleanly handled with polymophism: sorry but my milage is low).
1453 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1454 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1455 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1456 This avoids SegFaulting.
1457 - src/gdcmSQItem.h: coding style.
1459 - Test/TestWriteSimple still severely sucks. The output image content
1460 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1461 damaged when displayed with vtkgdcmViewer.
1462 - on memory leaks: TestWriteSimple leaks really less (see entry
1463 of 2004-06-18 in Changelog file for the call to valgrind).
1464 - on segfaults: ctest now passes all the tests but one (no more
1466 * Erroneous leading white fix:
1467 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1468 white[s] (as opposed to from >> xxx, that removes it [them].
1469 - src/gdcmTS.cxx: ditto.
1470 - gdcmPython/testSuite.py: dirty related kludge removed.
1471 * src/*: remaining references to gdcmParser removed.
1472 * src/*[cxx|h]: added copy[way]left header.
1475 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1476 * In order to fix writing of dicom files:
1477 - Test/TestWriteSimple.cxx: a simpler example of writing.
1478 - Test/CMakeLists.txt changed accordingly.
1479 - src/gdcmDocument.cxx:
1480 -- The destructor now recursilvely removes potential sequences.
1481 -- Bug fix in ::IsJPEG2000()
1482 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1483 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1485 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1486 to only declared) and build on top of
1487 ::GetDocEntryByNumber(guint16, guint16).
1488 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1489 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1490 for usage in destructor and treatement of promotion in
1491 ::ReplaceOrCreateByNumber().
1492 - src/gdcmSQItem.cxx: destructor should better handle his job.
1493 Test/TestWriteSimple now runs (or at least it DOES something).
1494 * We can now start hutting memory links. A good starting point is:
1495 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1496 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1497 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1499 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * Valgrind note: after Mathieu Malaterre teached me how to read
1501 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1503 Using gcc, you can force the STL to use malloc and to free memory as
1504 soon as possible by globally disabling memory caching.
1505 With 3.2.2 and later, you should export the environment variable
1506 GLIBCPP_FORCE_NEW before running your program.
1507 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1508 simply vanish (it is still not clear to me, whether this means that
1509 STL std::string leaks or if valgrind believes it leaks...).
1510 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1511 running bin/gdcmTests makeDicomDir):
1512 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1513 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1515 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1516 SegFaulting (I drowned in DicomDir related code when trying to
1517 understand why the list is empty...).
1518 * src/gdcmDocument.h: first BSD license header try.
1519 * Doc/License.txt added.
1521 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * src/gdcmDocument.[h|cxx]:
1523 - Clean up of the Transfer related predicates. They are now all based
1524 on new method isGivenTransferSyntax, that (should) handle properly
1525 the padding problem.
1526 - general clean up, simplification, and coding style.
1527 - Specific clean up of Parse7FE0() (umproperly named actually).
1528 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1530 2004-06-14 Jean-Pierre Roux
1532 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1533 - fix the display of SQItem ordinal number
1534 - add the GetSQItemByOrdinalNumber method
1535 - remove some useless never written private methods
1537 2004-06-14 Jean-Pierre Roux
1539 - adding a constructor taking a gdcmDocEntry as an input param
1540 - ReplaceOrCreateByNumber now returns :
1541 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1542 a gdcmValEntry * if a string value is passed as a param
1544 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1545 according to the param type (no longer sets a gdcmDocEntry)
1546 - GetValEntryByNumber, GetBinEntryByNumber added
1547 - NewValEntryByNumber and NewBinEntryByNumber added
1549 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1551 - GetSQItemNumber and SetSQItemNumber added, to provide
1552 a (relative) Item identier inside a given Sequence
1553 \warning : some pb remaining around this number
1555 - AddEntry now takes the Item Number as a param
1557 - adding a constructor taking a gdcmDocEntry as an input param
1559 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * Memory leak hunt with the following command:
1561 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1562 --show-reachable=yes gdcmTests PrintDocument
1563 It looks like many (all?) leaks are due to the STL (or a bad usage
1564 of the STL. The lines producing the leaks now have a comment with
1565 a "MEMORY LEAK" tag: you can retrieve them with
1566 grep "MEMORY LEAK" src/*
1567 Here are two typical examples which I can't help fixing:
1572 char * test = "babo";
1573 name = test; //// <--- valgrind detects 960 bytes lost in
1574 //// call to std::string::operator=(char const*)
1575 name.clear(); //// Doesn't help !
1583 std::cout << "Type a bunch of characters followed by RETURN: ";
1584 getline(std::cin, line); //// <--- valgrind dectects a loss
1585 //// of 1320 bytes in call to
1586 /// std::basic_istream<>& std::getline<>
1592 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1593 * src/gdcmHeader.[cxx|h]:
1594 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1595 and related, moved away to gdcmDocument.
1596 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1597 the corresponding protected accessors of inherited class
1598 gdcmDocument, removed ! As a consequence gdcmFile had to be
1599 declared friend of class gdcmDocument (see below).
1600 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1601 - Clean up of undefined or unused methods.
1602 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1603 account the changes to gdcmHeader.h).
1604 * src/gdcmDocument.h:
1605 - gdcmFile is now a friend class (in order to take into account the
1606 changes to gdcmHeader.h).
1607 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1608 (see changes to gdcmHeader.h).
1609 - Accessors (reading on the form GetEntry*) are now public.
1610 - Clean up of undefined or unused methods.
1611 * src/gdcmDocument.cxx:
1612 - adaptation to changes to gdcmDocument.h
1613 - ::OpenFile now writes a verbose message when file cannot be opened.
1614 - some std::string properly set to VRKey
1615 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1616 references to gdcmDocument.
1617 * Test/TestFindTags.cxx: changed accordingly to above changes.
1618 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1619 cvs repository gdcmData.
1621 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1622 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1623 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1624 conflicts with gdcmValEntry::voidArea.
1625 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1626 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1627 Value representation between StringRepresentable and BinaryRepresentable.
1628 * src/gdcmDocument.cxx:
1629 - method ParseDES: proper indentation restored and usage of
1630 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1631 - method LoadDocEntry: the fingerprint left in the SetValue() of
1632 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1633 removed. Reverting to previous code segment with the proper
1634 dynamic_cast< gdcmValEntry* >.
1635 Note: this was (partially) breaking the python test suite
1636 (gdcmPython/testSuite.py) that made usage of the above
1637 fingerprint to check presence of "Pixel Data".
1638 * src/gdcmDocEntry.h: coding style.
1639 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1640 now taken into account.
1641 * gdcmPython/gdcm.i: adaptation to the new internal representation
1642 of gdcm (exit gdcmParser, hello gdcmDocument).
1643 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1645 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1646 anymore, but instead prints the loaded Python dictionary.
1647 * .... alas, the python testSuite is still broken.
1649 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1650 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1652 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1653 * src/gdcmUtil.h : export methods
1655 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1658 * Initial addition of automatic python testing
1659 * Initial addition of automatic image comparison
1661 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1662 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1663 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1665 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1667 * Test/ShowDicom.cxx : bug fix for msvc compilation
1668 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1670 2004-05-04 Jean-Pierre Roux
1671 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1672 new concepts (and new classes) :
1673 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1674 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1675 - Sequence Doc Entries (gdcmSeqEntries)
1676 a Sequence is composed of Items.
1677 Each item is a set of Doc Entries (this is recursive)
1678 The non uniqueness of the 'Dicom tag' is due to this recursivity
1679 (never taken into account)
1680 Our unability to add a new 'entry' in the header
1681 at the proper location (neither in the H-Table (map or multimap),
1682 nor in the Chained List is also due to this recursivity.
1683 Don't try, right now, to use/modify/compile these new sources :
1684 nothing is finished.
1685 We just commit all the stuff, 'as is', in order not to loose it.
1687 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1688 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1690 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1691 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1692 file prefix (SetFilePrefix)
1694 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * Add a new test: ShowDicom, for now this is just the c++ version of
1696 checkRead.sh, later it will be able to compare the image read against a
1698 * Replace the DEBUG on the stack with a global entry in cmake interface:
1699 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1701 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * Add an example subdir, with a real example on how to read + write a
1705 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1707 * Doc/CMakeLists.txt: the main page is now properly differentiated
1708 between the developper and user version.
1709 * Doc/doxygen.config.in: dropped search related obsolete flags
1710 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1712 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1713 * DEVELOPPER: added some helpfull comments for compile/test/install
1716 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1717 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1718 src directory, now generated in the build dir.
1719 2. Tests as mentionned smarter
1721 4. Add a new method in gdcmDict that return the PubDict by name
1722 this is interesting for 3rd party lib like ITK,
1723 where we could set the institution name / patient name...
1725 * ENH: 1. Now the test suite is working for real
1726 2. All binaries are now output in the gdcm-bin directory
1727 (this was not true before)
1729 2004-04-28 Jean-Pierre Roux
1730 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1731 SeQuence indented printing of Dicom Header.
1732 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1733 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1734 Computation of SQDepthLevel is now part of gdcmHeader constructor
1735 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1736 tree-like structure of a Dicom Header.
1737 * FIX Test code cleaning
1739 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * ENH: Adding automatic testing
1741 1. Need a DartConfig.cmake to submit to public
1742 2. Add a test driver gdcmTest.cxx
1743 3. gdcmTestMain, an helper for the main test driver gdcmTest
1744 4. Files in Test don't have a main anymore, this becomes interesting
1745 when we add more and more tests, thus dsw don't have to load
1747 * ENH: Adding a GDCM_DATA_ROOT for testing
1748 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1749 one file instead of seven + some small cleanup
1751 2004-04-22 Jean-Pierre Roux
1752 * ENH Minor changes to the Print() methods.
1753 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1754 Header printing. Example given with :
1755 > PrintHeader fileName 2 new
1756 (SQ based tree-like structure still to be done for the Header ...)
1758 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1760 1. I have added some unsigned where needed
1761 2. Some function parameter not used -> (void)
1762 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1763 4. g++ don't like character '\' in comment
1764 5. #define jpeg_create_decompress jCreaDecompress
1765 this really need to be fixed
1766 6. virtualize destructor of gdcmObject ... leakage
1767 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1768 this also really need to be fixed
1769 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1770 remove compression file
1771 (as we only do decompression, right ?)
1772 * ENH: Change malloc/calloc/free with c++ equivalent
1774 2004-04-21 Jean-Pierre Roux
1775 * FIX gdcmHeaderHelper::GetXSpacing
1776 when a single value is found (bug ?), xpacing is now
1777 defaulted to yspacing
1779 2004-04-19 Jean-Pierre Roux
1780 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1781 * ENH add parameters :
1782 bool exception_on_error = false,
1783 bool enable_sequences = false,
1784 bool ignore_shadow = false
1785 to the gdcmFile constructors to be full gdcmParser compliant
1786 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1787 to allow reading of PAPYRUS 3.0 files
1789 2004-04-06 Jean-Pierre Roux
1790 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1792 2004-04-02 Jean-Pierre Roux
1793 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1794 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1795 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1797 2004-03-30 Jean-Pierre Roux
1798 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1799 for ACR file, written out as DICOM files (hope so...)
1801 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1803 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1804 moved to base class gdcmParser and only the specialisation is kept
1806 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1807 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1808 already does the job.
1809 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1810 (to be consistent with gdcmParser::WriteEntries).
1812 2004-03-30 Benoit Regrain
1813 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1814 upate of the object's instance. It's passed to 2 in the unfavorable
1815 case : one in the ExecuteInformation, one in the ExecuteData
1817 2004-03-29 Jean-Pierre Roux
1818 * ENH : Check on file type to be written moved
1819 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1820 * FIX : gdcmObject::ResetBoundaries now stops properly
1821 when end-of-list is reached
1822 : gdcmVersion modified (as Benoit Regrain asked)
1824 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1825 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1826 * src/gdcmUtil.cxx: added forgotten iostream include.
1827 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1828 equivalent to ExplicitVR in existing code).
1830 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1832 now contains all the gdcmGlobal related code.
1833 * minor coding style and doxygenation changes.
1835 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1837 now contains all the Debug related code.
1838 * minor clean-up of includes in src/*.cxx
1839 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1840 CreateCleanString) removed.
1841 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1842 * Doc/DoxyMainPageUser.txt added.
1843 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1844 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1845 src/gdcmDirList.cxx)
1847 2004-03-24 Jean-Pierre Roux
1848 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1850 2004-03-23 Jean-Pierre Roux
1851 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1852 big endian made volumes
1853 * ENH Now gdcmParser constructor and destructor are protected to forbid
1854 end user to instanciate class gdcmParser
1855 (only gdcmHeader and gdcmDicomDir are meaningfull)
1857 2004-03-22 Benoit Regrain
1858 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1859 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1860 gdcmSerie to gdcmDicomDirSerie
1862 2004-03-19 Jean-Pierre Roux
1863 * ENH Now the tree-like structure describing a DICOMDIR comming from
1864 an already existing DICOMDIR file is consistent with
1865 the home-made tree-like structure build ex-nihilo
1866 or build from the files held (recursively) in a Directory
1867 functions gdcmDicomDir::CheckBoundaries()
1868 gdcmObject::SetBoundaries() added
1870 2004-03-17 Jean-Pierre Roux
1871 * REM (Eric Boix bug) : removal of meaningless
1872 gdcmDicomDirImage::NewImage function.
1873 * FIX now file names and directory name are written properly in the
1875 * FIX now gdcmDicomDir constructor may be call without any trick
1878 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1880 of gdcmDicomDirImage::NewImage as empty function.
1882 2004-02-28 Jean-Pierre Roux
1883 * ENH add gdcmDicomDir:NewPatient
1884 add gdcmDicomDirPatient:NewStudy
1885 add gdcmDicomDirStudy:NewSerie
1886 add gdcmDicomDirSerie:NewImage
1887 to allow making gdcDicomDir object.
1888 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1889 (as opposite to the gdcmHeader chained list)
1891 2004-02-11 Benoit Regrain
1892 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1893 when using from python
1895 2004-02-10 Benoit Regrain
1896 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1897 * FIX : in gdcmDicomDir when the directory is empty
1898 * ENH : add callback and methods to get the progression of dicomDir
1901 2004-02-06 Jean-Pierre Roux
1902 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1903 - GDCM_META added to gdcmDicomDirType
1904 - class gdcmMeta created
1905 * ENH : - A brief summary is now displayed at the beginning of
1906 'testDicomDir' to help disaster magnitude estimation
1907 * REM : Now useless Test/explDICOMDIR.cxx
1909 2004-02-05 Benoit Regrain
1910 * ENH : add methods in gdcmObject to get the hash table or the list of
1912 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1913 * FIX : wrapping python for TagHeaderEntryHT
1915 2004-02-04 Benoit Regrain
1916 * FIX : even length for some strings when writting the dicom dir
1917 * FIX : sort the images in the dicom dir
1918 * FIX : Bug fix for python use of dicom dir
1919 * ADD : a python demo
1921 2004-02-04 Jean-Pierre Roux
1922 * FIX : Final solution (?) for icone embedded images
1923 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1924 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1925 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1926 gdcmData/gdcm-MR-SIEMENS-16.acr1
1927 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1928 to make full checking easier
1930 2004-02-04 Benoit Regrain
1931 * FIX : WriteEntries : coding style & logic in parameters
1932 * FIX : Set the elements to create the DicomDir in a dictionary file
1934 2004-02-03 Benoit Regrain
1935 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1936 * gdcmDicomDir : add the load of directory
1937 * Bug fix and print add-on
1939 2004-02-03 Jean-Pierre Roux
1940 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1941 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1942 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1943 * FIX gdcmParser.cxx : 'group length' elements are now considered
1944 as integers, even for shadow groups, when file is Implicit VR
1946 2004-02-02 Jean-Pierre Roux
1947 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1949 of the last synonym :-(
1950 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1952 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1953 * FIX taking into account the possible 7fe0,0010 multiplicity
1954 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1955 to allow removal of references to 7fe0,0010, to deal with
1956 ACR-NEMA images, when 0028,0200 is meaningfull
1958 2004-01-31 Jean-Pierre Roux
1959 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1960 no longer writes 'Un' on disk
1961 * FIX SQ elements with actual length are now dealt with corectly
1962 * FIX gdcmFile::WriteBase make the difference, for color images, between
1963 the length (for Palette expanded images)
1964 and Raw Length (non expanded image + Palette)
1965 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1966 (that broke Write). Replaced by UL.
1967 Aware user will reload the field if he
1968 thinks it's necesssary
1970 2004-01-30 Jean-Pierre Roux
1971 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1972 when 'dirty Acr' is found, to be compliant with the new
1973 IsReadable() methods.
1975 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1976 (no DOUBLE images in kosher DICOM,
1977 but so usefull for people that miss them ;-)
1979 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1980 DICOMDIR related utilities (not checked as Windoze compliant)
1982 2004-01-28 Jean-Pierre Roux
1983 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1985 2004-01-27 Jean-Pierre Roux
1986 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1987 to allow skipping the shadow elements, to save memory space.
1988 The TRUE value for this param has to be used
1989 with a FALSE value for the 'enable_sequence' param.
1990 ('public elements' may be embedded in 'shadow Sequences')
1991 * gdcmHeader methods now deal with 'embedded icones images' in the header
1992 (even when an 'icone image sequence' is announced by the
1993 element (0x0088,0x0200), but there is NO icone at all ...
1995 * gdcmHeader sometimes Image Location value doesn't follow
1996 the supposed processor endianity (see gdcmData/cr172241.dcm).
1999 * gdcmHeader add the method
2000 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2001 to get *all* the Header Entries with the same tag.
2002 GetHeaderEntrySameName is probabely *useless*
2003 (no meaning : Name is *not* an identifier within the Dictionary)
2005 2004-01-26 Benoit Regrain
2006 * Bug fix in the print of hexadecimal representations. Remove long fields
2007 in the print and add a third level of print to print them
2009 2004-01-23 Benoit Regrain
2010 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2011 * Bug fix on test suite after remove the strip made on not string fields
2012 * Split the IsReadable method between gdcmParser which test that the file
2013 is dicom and gdcmHeader which test that it's an image file
2015 2004-01-22 Benoit Regrain
2016 * DicomDir : clean code, add methods, set variables in protected or private
2017 * gdcmUtil : bug fix for the clean string method
2019 2004-01-19 Benoit Regrain
2020 * Add the use of shadow dictionaries
2021 * bug fix and coding style
2023 2004-01-19 Benoit Regrain
2024 * src/gdcmFile.cxx : bug fix concerning the close of file
2025 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2026 * Add the update of header entries using the shadow library
2028 2004-01-19 Benoit Regrain
2029 * removal of file gdcmHeader2.cxx
2030 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2031 inheriting from gdcmParser. This split is to prepare the integration
2032 of dicom dir parsing
2033 * bug fix under python
2035 2004-01-16 Jean-Pierre Roux
2036 * REM removal of class gdcmHeaderEntrySet
2037 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2038 * ADD add file gdcmHeader2.cxx
2039 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2041 2004-01-15 Benoit Regrain
2042 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2043 entries created while parsing the header. Thus, they will be destroyed
2044 when the gdcmDictSet will be destroyed
2045 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2048 2004-01-15 Benoit Regrain
2049 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2050 made a fatal error because of the memory release at the end of program.
2051 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2052 some memory and vtk seems to have some problems with that.
2053 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2055 2004-01-14 Benoit Regrain
2056 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2057 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2058 * src/*.[h|cxx] : make changes due to class name changes
2059 * gdcmPython/demo/*.py : bug fix due to method names
2061 2004-01-13 Benoit Regrain
2062 * src/*.[h|cxx] : coding style
2063 * vtk/*.[h|cxx] : coding style
2065 2004-01-13 Benoit Regrain
2066 * gdcmPython/testSuite.py : test the readable flag of file for tests
2067 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2068 It's lied to the stl compilation by MSVC (windows, always windows...)
2069 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2071 2004-01-12 Benoit Regrain
2072 * src/*.h : add comments
2073 * src/gdcmDictSet.h : set the method BuildDictPath in public
2074 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2075 directly setted in the source code
2076 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2079 2004-01-09 Benoit Regrain
2080 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2081 * setup.py : use a reference to gdcmVERSION
2083 2004-01-07 Benoit Regrain
2084 * Modification to compile with the distutils.
2087 2003-12-10 Benoit Regrain
2088 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2089 can use a gdcmHeaderHelper to load data
2090 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2091 made in the source code
2093 2003-12-10 Benoit Regrain
2094 * Update Windows projects and .cvsignore files
2096 2003-11-12 Jean-Pierre Roux
2097 * ENH gdcmHeader constructor has one more parameter (default value : false)
2098 that allows the user to 'go inside' the SeQuences only
2100 gdcmElValSet:Print takes it into account
2102 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2103 * ENH: Update gdcmPython/CMakeLists
2104 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2105 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2107 2003-11-10 Jean-Pierre Roux
2108 * FIX : gdcmHeader::LoadElements is now based
2109 on the ListTag listElem member,
2110 not longer on the TagElValueHT tagHt member
2111 * ENH : PrintPubElVal shows (temporarily) both results,
2112 with the tagHt member and the listElem member.
2113 (it's easier to 'see' the problems when using Printheader)
2115 * FIX : old private member LgrElem is now splitted into
2116 ReadLength : Length actually found on disk (updated only
2117 if bug fixing is necessary), for internal
2119 UsableLength : Updated by FixFoundLength, to fix a bug
2120 or to allow Parser going on.
2121 Will allow to re-write a kosher header when a SeQuence
2122 with a length (not 0000) is found
2123 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2124 because gdcmElValSet::Add does not update ListElem
2127 2003-11-07 Jean-Pierre Roux
2128 * FIX misstyping in Transfert Syntax name table
2129 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2130 when they have an actual length (not 0000 nor FFFFF)
2131 (Nobody should care of it, but DICOMDIR explorers)
2133 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2134 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2136 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2137 * ENH: vtkGdcmReader now supports LUT !
2138 (vtkgdcmViewer for now is not able to use them though)
2140 2003-11-05 Jean-Pierre Roux
2141 * in testSuite.py : new files names for checking the package
2142 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2143 that returns the pixel area size to the *aware* (vtk) user
2144 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2146 2003-11-05 Benoit Regrain
2147 * in testSuite.py : Modify the rules for checking the paths
2148 : Explicit error messages
2149 * in __init__.py : Related modif
2151 2003-11-03 Jean-Pierre Roux
2152 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2153 to be used by aware (vtk) users that want to manage
2154 LUT (and no to turn the PALETTE image into an RGB pixels one)
2155 * GetPixelType now returns 8U for 24 Bits images
2156 (vtkGdcmReader compliant)
2158 2003-10-31 Jean-Pierre Roux
2159 * Removal of *all* gdcmData images and add them again
2160 in order to loose the 'history' of un-anonymised images
2162 2003-10-31 Jean-Pierre Roux
2163 * RMV : removal of useless jBitsInJsample.h
2164 for both 8 and 12 Bits JPEG Lossy Libraries
2166 2003-10-31 Jean-Pierre Roux
2167 * ENH : Add the functions gdcmFile::GetImageDataRaw
2168 gdcmFile::GetImageDataIntoVectorRaw
2169 that act as GetImageData and GetImageDataIntoVector
2170 except the making of an RGB Plane from Gray Plane + LUT
2171 Intended to aware (vtk) users who know how to manage
2174 GetLUTRGBA return a R,G,B,A LUT if any
2175 lgrTotaleRaw gives the 'Raw' length
2176 GetImageDataRaw returns the gray Plane
2177 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2178 (They stay Grey, just like with other Dicom viewers :-(
2180 2003-10-30 Jean-Pierre Roux
2181 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2183 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2184 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2185 being coherents dicom files.
2187 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2188 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2190 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2191 * ENH: Two steps is necessary to please VC++ compiler...
2192 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2193 * ENH: Add include dir to medcon lib
2194 * FIX: only one function is being exported for now !
2195 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2197 2003-10-29 Jean-Pierre Roux
2198 * adding gdcmHeader::GetLUTRGBA
2199 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2200 --> Mathieu, the modif u're waiting for is not yet committed
2201 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2203 2003-10-27 Jean-Pierre Roux
2204 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2205 00191113.dcm DermaColorLossLess.dcm
2206 MxTwinLossLess.dcm RadBWLossLess.dcm
2207 * ENH: For version prior to vtkImageViewer2 -r 1.19
2208 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2210 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2211 * Removal of ido stuff in CMakeLists.txt
2213 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2214 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2215 * FIX: remove a call to ->Modified ... see comments
2216 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2218 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * FIX: Problem with path for libvtkgdcmPython
2220 * ENH: Try adding a search script for python site-package
2221 * RMV: Remove some file from medcon lib that are not necessary
2222 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2223 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2224 * FIX: More pragma disable fro VC++,
2225 I don't think I break something as it is also disable in VTK/ITK.
2226 But it fasten debug compilation time.
2228 2003-10-23 Jean-Pierre Roux
2229 * gdcm now deals with 16 Bits Run Length Encoded images
2230 (they are compressed as 2 planes images,
2231 one for the high Bytes, the other for low Bytes)
2233 2003-10-22 Jean-Pierre Roux
2234 * Now CheckRead takes into account :
2235 - the bugged 'Leonardo' Siemens images
2236 - the XA images, sent thru the burning VPRO station
2237 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2240 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * FIX: When copying a Makefile.am to CMakeLists.txt
2242 one should remove the '\'
2244 2003-10-22 Jean-Pierre Roux
2245 * in gdcmData adding a bugged 'Leonardo' Siemens image
2246 (wrong lengths in header)
2247 OK with gdcm, KO with the other viewers :-)
2248 * add a GE dlx XA image, thru the VEPRO burning station
2251 2003-10-21 Jean-Pierre Roux
2252 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2253 for a brutal checking of vtkgdcmViewer compliance
2255 2003-10-21 Jean-Pierre Roux
2256 * add the files for 'xmedcon' Jpeg Lossless library
2257 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2259 2003-10-21 Jean-Pierre Roux
2260 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2262 2003-10-21 Jean-Pierre Roux
2263 * garbage Siemens 'Leonardo' images dealt with
2264 (the patch is easy to remove)
2265 * cosmetic changes to avoid warnings
2267 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2268 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2269 no need to press 'r' now.
2271 2003-10-20 Jean-Pierre Roux
2272 * upgrade of checkRead.sh checkWrite.sh according
2273 to new Jpeg Lossless decompressor
2274 * add US.3405.1.dcm, a genuine RGB medical file ...
2275 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2276 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2278 2003-10-15 Jean-Pierre Roux
2279 * general anonymisation in gdcmData
2280 * adding the 'color files' from
2281 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2282 * adding some well knowed bugged-header images
2283 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2284 waiting for their inclusion in Python testsuite
2286 2003-10-15 Jean-Pierre Roux
2287 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2288 no longer seg faults when file is not found
2290 2003-10-14 Jean-Pierre Roux
2291 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2294 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2295 * TODO: *.in file to genereate a UseGDCM later
2297 2003-10-14 Jean-Pierre Roux
2298 * Some supposed-to-be Dicom Images have no preamble.
2299 OpenFile takes it into account
2300 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2301 * Missing elements added in dicomV3.dic
2302 (just to be affraid : have a look at
2303 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2304 and do it again next year ;->
2306 2003-10-13 Jean-Pierre Roux
2307 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2308 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2309 But there are NOT. It's fixed !
2311 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2312 * FIX: "jpeglib.h" was not found on VC++
2313 * FIX: vtkgdcm was not being installed
2315 2003-10-10 Jean-Pierre Roux
2316 * ENH : OpenFile closes the file if it *really* doesn't look like
2317 an ACR-NEMA / DICOM one.
2318 * FIX : testWrite no longer writes an empty file if the source file
2319 is not gdcm Readable
2320 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2323 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * FIX: CMake generate now documentation
2325 * ENH: out of source doc build !
2326 * ENH: Generate both user and dev documentation
2327 * ENH: Should work on windows too
2328 * ENH: Only one doxygen config.in file is needed
2329 * FIX: make install should be ok now on ùnix plateform
2330 * FIX: PATH to dictionary was wrong (missing /)
2331 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2333 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2334 * vtkGdcmReader is now able to read rgb dicom file.
2335 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2336 * added a gdcmViewer to vtk test, use mouse to control
2337 window level & window width
2339 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2340 * CMake-ification of gdcm, we have now two build system
2341 * FIX: on cygwin Wsock32 doesn't exist
2342 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2344 2003-10-06 Emanuel Ollart
2345 * FIX : compilation process wad broken.
2346 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2348 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2349 * change gdcmViewer -> vtkgdcmViewer
2350 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2352 2003-10-06 Jean-Pierre Roux
2353 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2354 ( e.g : well known GE images with a wrong elem length,
2355 : Philips MRI Images with a wrong Huffman table)
2356 * still to be done : allow the reading of bugged LEONARDO Siemens images
2358 2003-10-03 Jean-Pierre Roux
2359 * Odd length strings are padded with '\0' (not with spaces,
2360 to remain compliant with already defined strings,
2361 like Transfert Syntax UID and others)
2363 2003-10-03 Jean-Pierre Roux
2364 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2365 to allow displaying RGB images (not only by affim ;-)
2367 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2368 * vtkGdcmReader is now able to read rgb dicom file.
2369 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2371 2003-10-03 Jean-Pierre Roux
2372 * A few nasty patches to allow the reading of a lot of nasty images
2373 ( e.g : well known GE images with a wrong elem length,
2374 : Philips MRI Images with a wrong Huffman table)
2375 * still to be done : allow the reading of bugged LEONARDO Siemens images
2377 2003-10-03 Jean-Pierre Roux
2378 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2380 2003-10-03 Jean-Pierre Roux
2381 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2382 to allow displaying RGB images (not only by affim ;-)
2384 2003-10-03 Jean-Pierre Roux
2385 * gdcmFile::GetImageDataIntoVector now
2386 - deals with MultiFrames MultiFragments Run Length Encoded files
2387 - deals with YcBcR (YBR_FULL) files
2388 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2389 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2391 (no sample found :-(
2393 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2394 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2395 Two reasons: - clear things
2396 - third parties acces gdcm through header files, so won't
2397 suffer anymore VC++ complains
2399 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2400 * add argv[1] in testvtkGdcmReader.cxx
2403 2003-09-24 Jean-Pierre Roux
2404 * The lines are now eigthy characters long.for
2405 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2407 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2408 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2409 char* to std::string. Thus, the use of strdup becomes useless. (see
2410 previous commis of Malaterre)
2411 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2412 before the last Malaterre's commit.
2414 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2415 * This commit should fix the Debug building under VC++, the problem
2416 was mainly a mixture of debug and release lib being loaded at startup.
2417 * I also remove a depency to a specific C function: strdup. Because I had
2418 to force the link to msvcrtd (whereas strdup is in libc).
2420 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2421 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2422 located in the gdcmCommon.h file. All use of reference of tha has been
2423 changed to now use the variable GDCM_UNFOUND.
2425 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2427 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2428 Dicom dictionary. The test suite can now be run again. Note:
2429 I'm note very happy with the " (RET)" changes. I believe this
2430 RETAINED comment should be dropped when parsing the dictionary.
2431 - PACKAGER corrected
2433 - AUTHORS updated and now in alphabetical order
2434 * Makefile.am now exports gdcm.dsw for Windoze users.
2436 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2437 * cygwin complains about missing std:: in subdir Test/
2439 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2440 * remove some methods that are now in gdcmHeaderHelper
2442 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2443 * vtkGdcmReader set spacing and origin correctly
2445 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2446 * Fix a few delete/delete[] mismatch
2448 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2450 interpretation to data given by gdcmHeader. For instance there are
2451 heuristics to get informations (look at different places).
2452 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2453 sorting DICOM images based on different strategies.
2454 * modified Makefiles accordingly.
2456 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2457 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2458 when building in debug mode
2459 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2460 src/win32/gdcmdll.dsp
2461 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2463 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2464 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2467 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2468 * src/win32/libgdcmjpeg12.dsp was not dos format
2469 * src/win32/libgdcmjpeg12.dsp :
2470 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2471 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2473 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2474 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2476 * src/gdcmFile.cxx : bug fix in affectation type
2477 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2478 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2479 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2480 symbols... future problem ?
2482 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2483 * src/win32/libgdcmijpeg12.dsp was missing
2484 * modified gdcm.dsw accordingly
2486 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2487 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2489 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2490 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2491 commit of JPR (before his hollidays to facilitate our work).
2492 * setup.py : bug fix in code. Modifications made while the last commit
2493 of JPR. The code hasn't been tested before the commit... it's so
2494 useless to make that (for best programmer that is JPR) !!!
2496 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * tagged the current version as Version0_3 (i.e. version 0.3)
2499 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2500 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2501 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2502 * *.dsp : modifications to use new libgdcmijpeg8 library
2503 * setup.py : bug fix on VTKPATH variable
2504 * PACKAGER : adding all concerning windows
2506 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2509 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2510 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2511 test suite reported error.
2512 * PACKAGER file added (describes what a packager must do when
2513 packaging a new release).
2514 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2515 * configure.in: upgraded version number to 0.3.0
2516 * fixing build of rpm (through rpm -ta):
2517 - Doc/Makefile.am exports proper doxygen files
2518 - src/jpeg/libijg8/Makefile.am exports the include files.
2520 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2521 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2522 * src/gdcmHeader.h : formatting code
2524 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2525 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2526 We were obtaining error message from vtk. Now, creation of file list
2527 is made in an internal list to prevent this problem.
2528 Bug fix when output is empty.
2529 Bug fix in update of progress value. Previous commit for this was a bad
2531 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2533 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2534 * src/gdcmHeader.h : added method to get the file name
2535 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2536 files. Added method to remove all files on the input
2537 Added FIXME comment concerning the bad parsing of header made by
2538 ExecuteInformation method (in ExecuteData method)
2540 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2541 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2542 when using make instal.
2543 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2544 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2546 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * setup.py : adding include dir of jpeg lib to compile all sources
2548 * */Win32/*.dsp : JPR fix for windows compilation
2550 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2551 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2553 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2554 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2556 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * setup.py is again effective on un*x (takes into account the
2558 addon of the jpeg library)
2559 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2560 * Doc/Doxy* updated (includes above enhancements)
2561 * INSTALL now points to web documentation
2563 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * src/gdcmHeader.h doesn't make unnecessary reference to
2566 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2568 * src/gdcm*.[cxx|h] :
2569 - to allow compilation with gcc 3.x
2570 -- clean up of STL usage (added explicit usage of std::)
2571 -- small fixes on exceptions.
2572 Note: linking not tested !
2573 - clean of doxygen comments to avoid warnings at documentation
2575 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2576 dependent convertion).
2578 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * Clean up of previous JPR garbage commit (not even commented in the
2581 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2582 - moved all jpeg related files from src to src/jpeg/libijg8, with
2583 addition/modification of Makefile.am and configure.in.
2584 - the testSuite is still brain damage (not guilty).
2586 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2587 * WrapVTK.py : modifications to get correctly vtk source files to
2589 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2590 (FileName -> Filename)
2592 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * vtk/vtkGdcmReader.[cxx/h]:
2594 - UpdateProgress method should now be effective
2595 - removed the limitation on having only images loaded (as opposed
2597 - when building a stack of images/volume, a lesser number of
2598 gdcmHeader and gdcmFile instances should be used (hopefully
2599 accelerating things).
2600 - when building a stack of images/volumes, files which are not
2601 loadable (wrong path-filename, wrong permissions on existing file,
2602 or file not parsable by gdcm) are replaced with a black image
2603 in the stack (for the caller to notice the problem).
2605 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2608 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2609 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2610 between standard library (std) and vtk library (problems are found
2611 under Windows... thanks Windows !)
2613 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2616 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2618 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2621 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * When compiling with distutils (see setup.py) the C++ compiler is
2623 called with different flags than the default ones (with automake).
2624 In order to fix all those warning, I compiled gdcm with the command
2625 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2626 and went for warning fixes:
2627 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2628 up from unused variables.
2629 - vtk/vtkGdcmReader.cxx: potential bug fix.
2630 * src/gdcmHeader.h: Doxygen warning cleanup
2632 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * gdcmPython/gdcm.i:
2634 - typemaps correction to take into account the systematic replacement
2635 of "using namespace std" with std:: prefix e.g. std::list,
2636 std::string... (cf changes of 2003-05-21).
2637 - gdcmGlob global variable of type gdcmGlobal (defined in
2638 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2639 exported to Python a as cvar.
2640 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2641 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2642 gdcmDictSet.GetPubDictTagNames() and
2643 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2644 C++ static methods).
2645 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2646 with the above changes.
2648 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2649 * setup.py, manifest.in : bug fix under linux
2651 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2652 * Modification of setup.py to compile vtk part too. Then, we have 2
2653 wrappers which must work with same distutils. For that, we have a
2654 generic distutils in distusiltsWrapping.py ; with :
2655 - build_extWrap class to wrap generically all extensions,
2656 - ExtensionWrap base class for all wrapping extension that contains
2658 - Wrapper interface which wrap sources
2659 + In WrapSwig.py we have extension and wrapper for Swig
2660 + In WrapVTK.py we have extension and wrapper for VTK
2661 * MANIFEST.in : modifications to consider vtk directory and new python
2662 files for compilation
2664 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2665 * Added python wrappers of vtkGdcmReader vtk class (see the
2666 source in vtk/vtkGdcmReader.cxx) :
2667 - vtk/Makefile.am now builds a library
2668 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2669 python library (as opposed to _gdcm.so wich are the python
2670 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2671 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2673 - configure.in has an additional flag --enable-vtk that needs
2674 to be set to enable compilation of vtk related code, that is:
2675 + vtk/vtkGdcmReader.so and
2676 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2677 + gdcmPython/vtkgdcmPython.so (see above)
2678 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2679 be read when compressed or when HighBit + 1 != BitsStored),
2680 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2681 the usage of the python wrapper of vtkGdcmReader vtk class.
2682 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2683 * src/*.[h] all occurences of stl classes are now prefixed with
2684 std::, and all occurences of "using namespace std;" where removed.
2685 This is to avoid pollution of global namespace in included files.
2686 Apparently vtk does not avoid this pitfall: when using both
2687 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2688 collision of various stl members (principally cout...).
2689 * gdcmPython/testSuite.py now cleanly removes temprory generated
2691 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2692 comply with above changes)
2694 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2695 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2696 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2697 vtk data structure (an image Flip was required).
2698 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2699 * cosmetic changes in documentation.
2701 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2702 * src/gdcmHeader.cxx: the constructor no longer exits when an
2703 unexisting file is given as argument.
2704 * The subdirectory Data (containing all the images used for the
2705 test suite) is not part of this repository anymore. A new module
2706 containing those images is now available at
2707 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2708 with the name gdcmData.
2709 All the python scripts (including the package initialisation file
2710 gdcmPython/__init__.py) were adapated to take this change into
2711 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2713 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2714 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2715 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2716 demo of the usage of this class.
2717 Compilation of this vtk part is only done when using the --enable-vtk
2718 at configure (or autogen.sh) stage.
2720 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2721 * More memory link related corrections and documentation fixes.
2723 - maximum info is obtained with a command of the form:
2724 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2725 --show-reachable=yes PrintHeader
2726 - the remaining reachable blocks seem to come from the STL
2727 allocation scheme through the usage of map and list. It looks
2728 like this memory cannot be freed but it is not a memory leak
2729 (in fact further invocation to the STL would recollect the
2730 unused memory allthough it cannot explicitely be freed).
2731 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2732 of displaying an image parsed with gdcm and displayed with VTK.
2733 Note: some images don't seem to work e.g.
2734 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2735 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2736 Allthough this weakens the semantics, it is a ditch attempt to
2737 make gdcm more thread friendly.
2739 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2740 * Memory link hunt (by using valgrind through the command
2741 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2742 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2743 gdcmHeader::_dicom_vr.
2744 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2745 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2747 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2749 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2750 * src/Makefile.am now exports all the necessary include files at
2754 * UpdateGroupLength replaced by new one
2757 * UpdateGroupLength re-written using H-Table
2758 (named UpdateGroupLengthNew untill checks are over)
2760 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2761 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2762 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2764 - gdcmHeader::GetPubElValSet removed.
2765 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2766 UpdateGroupLength, WriteElements, Write.
2767 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2768 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2769 carried the same semantics.
2770 - src/gdcmHeaderIdo.cxx changed accordingly.
2771 - gdcmFile::WriteBase now regroups all the codes from previous
2772 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2773 - enum FileType moved to gdcmCommon.h
2774 * src/gdcmHeader.cxx AddDefault trashed
2775 * gdcmGetXSize added
2776 * getimageDataSize now calls gdcmGetXSize
2777 * Test/*.cxx changed to agree with above changes
2779 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2781 (to avoid double call by end user).
2782 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2783 by end user, since gdcmHeader::gdcmHeader now handles it.
2785 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * gdcm/Doc many doxygen changes:
2787 - Doxyfile now has two different versions, DoxyfileUsers that generates
2788 the html.users end users oriented documentation and
2789 DoxyfileDeveloppers that generates the html.developper developper
2790 oriented documentation.
2791 - README changed accordingly
2792 - requirement.txt removed (old design info moved to TODO).
2793 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2794 DoxyMainPage.txt, DoxyPython.txt provide more information.
2795 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2796 be updated by simply regenerating the docs with doxygen and copying
2797 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2798 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2799 all the tests in the form "if (<map>.count() >1)" were removed.
2800 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2801 ill-formed documentation sections.
2802 * src/gdcmHeader.cxx: ditto
2804 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * setup.py fixed for un*x (needed macro for stdint.h)
2806 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2807 un*ces with sh-utils test utility.
2808 * gdcmPython/demo/test.py renamed to PrintHeader.py
2809 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2810 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2811 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2812 * src/gdcm*.cxx JPR's bad inclusion fixed.
2814 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2816 * gdcmPython/demo/test.py changed accordingly.
2818 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * gdcmPython/Makefile.am fixed linking against libstdc++
2820 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2821 * Swig subdir (historical tests of swig version 1.3.17++) removed
2822 * Test/testChangeEntete.cxx some lines commented out in order to make
2824 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2825 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2827 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2829 hence the user doesn't need this explicit call.
2830 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2831 i.e. LoadElements() call removed.
2832 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2833 - src/Makefile.am declares the proper flag for g++.
2834 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2835 for adding user defined new tags.
2836 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2837 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2838 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2840 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2841 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2842 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2843 src/Makefile.am : the project should properly compile and install
2844 with the autotools, included the python wrappers part.
2845 * gdcm.spec.in : added a spec file for RPM packaging.
2847 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2848 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2850 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2851 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2852 to exported to the environement (see gdcmPython/testSuite.py
2854 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2855 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2856 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2857 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2858 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2860 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * gdcmPython/__init__.py doesn't crash anymore when running in
2862 in InstallMode or PreInstallMode but with an environment given
2863 value of GDCM_DICT_PATH.
2864 * src/gdcmDictSet.[cxx/h] coding style.
2866 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2868 * src/gdcm.h general comments moved to TODO, and README
2869 * src/gdcm.h should now be seen as a user commodity (including it
2870 should suffice to fully use gdcm). It is nowhere including within
2871 any of the kernel files src/*.cxx and src/*.h.
2873 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2874 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2875 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2877 * src/gdcm*.cxx only include their corresponding include file
2878 (as opposed to gdcm.h)
2879 * gdcmPython/gdcm.i changed accordingly
2880 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2881 the autogen.sh generated "make snapshot" command to work.
2882 * autogen.sh removed history related references to crea package.
2884 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * distutilsSwigCPlusPlus.py work around some swig portability
2888 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2890 was done in a last ditch attempt to get setup.py _really_
2891 operationnal. The python/gdcmPython layaout add the advantage
2892 of hidding away the python related distutils specific files
2893 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2894 Alas, the src directory was out of scope (i.e. it's relative
2895 position to setup.py was ../src) which made things impossible to
2896 handle (see previous version of python/setup.py). Crossing fingers...
2898 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2899 * python/setup.py now works on Un*x. (harder than I thougth)
2900 * python/distutilsSwigCPlusPlus.py can now have include files
2901 among the list of sources.
2903 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2904 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2905 * modifications in MSVC projects
2907 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2908 * As stated by the first lines of Test/ExceptionAndPython/README, it
2909 looks like we can move back to original usage of exception within
2910 src/gdcm* and hence remove the errno stuff that was introduced
2911 as a quick and dirty fixture of this problem (added to the TODO).
2912 * Doc/Doxyfile configuration file for Doxygen and corresponding
2913 README file for usage added.
2914 * Test/testWrite.cxx added. This new test comes from a split of
2915 test.cxx that is now reverted to its original purpous i.e.
2916 testing the proper parsing of a Dicom related file.
2917 testWrite.cxx concentrates on testing the IO part of gdcm.
2918 * Test/bug1.cxx (containing a bug on WIn32) added.
2919 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2920 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2921 whose purpose is to publish the content of the TagNames of the
2922 Dicom public dictionary were not accessible without an
2923 instance of class gdcmHeader.
2924 - those methods are now static methods of gdcmDictSet and hence
2925 require no instances at all to be invocated.
2926 - within gdcmDictSet this change required to change some method
2927 to class methods (i.e. are now static) among which SetDictPath
2928 (renamed to BuildDictPath) and LoadDefaultPubDict.
2929 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2930 the above changes by calling the new method classes of gdcmDictSet.
2931 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2932 the above to be effective.
2933 * python/gdcmPython: in order to wrap properly the above changes
2934 for Python, swig version now needs to be > 1.3.17.
2935 * python/gdcmPython/Makefile fixed to adapt itself to new
2936 configure/make shema introduced by Johan Montagnat (thanks for the
2937 contribution). Alas this Makefile cannot be turned into a proper
2938 Makefile.am without some heavy changes in the configure.in
2939 (for python dectection).
2940 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2941 now avoids publishing the empty entries.
2943 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2944 * python/setup.py : bug fix concerning install under windows
2945 ExtraPath reused :-P
2946 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2948 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2949 * Dicts/dicomV3.dic : remove double spaces !!!
2950 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2951 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2954 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2956 method. Doxygenation.
2957 * src/gdcm.h clean up of JPR spurious comments.
2959 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * python/distutilsSwigCPlusPlus.py now properly collects the
2961 shadow classes generated by "swig -c++" (gdcm.py in our case)
2962 when using "python setup.py install".
2963 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2964 reexports the working classes.
2965 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2966 by the classical C errno scheme. This is to prevent an obscure
2967 behavior of the python wrappers when importing wxPython.wx prior
2968 to gdcmPython (which ended up in an abort call). An illustration
2969 of this oddity can be found in the Test/ExceptionAndPython
2970 subdir (see the README file). This problem probably due to
2971 an combination of g++ and dynamic loading.
2972 * added Test/ExceptionAndPython (see above)
2974 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2975 * Changed the layout of the python part to avoid bloating main
2976 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2977 i.e. the distutils arsenal. All the python related stuff is
2978 again in a python subdir, but the package itself is now in
2980 * setup.py was cleaned up:
2981 - pythonIncludePath removed
2982 - python setup.py bdist target is now functional.
2983 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2984 collision with other packages). gdcmPython/demo/*.py changed
2987 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * python subdir moved to gdcmPython (preparation of distutils packaging).
2989 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2990 distutils installer is operational.
2991 * - gdcmPython/__init__.py now properly loads the swig generated
2992 shadow classes (from gdcm.py).
2993 - gdcmPython/demo/*.py changed to import the package gdcmPython
2994 instead of gdcmPython/demo/load.py.
2995 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2997 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2998 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2999 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3000 entries within the associated public Dicom dictionary resp. the same
3001 information but sorted by the fourth field (PAT, IMG, DIR) of the
3003 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3004 are now in the "???" group.
3005 - python/gdcm.i changed accordingly,
3006 - python/demo/printGroupedPublicDict.py added, that gives an example
3007 of the above new functionalities in Python.
3009 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3010 * src/gdcm.h, gdcmHeader.cxx:
3011 - historic references to glib's g_malloc and g_free (#defined)
3012 were definitively removed.
3013 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3014 * src/gdcmElValSet.cxx:
3015 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3016 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3017 - GetElValue(string) renamed to GetElValueByName.
3018 - Added GetElementByName(string).
3019 * src/gdcmHeader.cxx: added
3020 - GetPubElValRepByNumber(guint16, guint16)
3021 - GetPubElValRepByName(string)
3022 - GetShaElValRepByNumber(guint16, guint16)
3023 - GetShaElValRepByName(string)
3024 - GetShaElValByNumber(guint16, guint16)
3025 - GetShaElValRepByName(string)
3026 - GetElValRepByNumber(guint16, guint16)
3027 - GetElValRepByName(string)
3028 - GetElValByNumber(guint16, guint16)
3029 - GetElValRepByName(string)
3030 * Doc/requirements.txt added.
3032 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3033 * Test/Makefile building now depends on the one of libgdcm.so
3034 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3035 pixel data) aware which enables finding the address (offset) of
3036 the pixel data of JPEG encoded DICOM files. This leaves only a single
3037 file in the testSuite whose pixel data address (offset) is unknown.
3038 * python/testSuite.py changed accordingly.
3040 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3041 * VC++ has some strong limitations when working with the STL, as stated
3042 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3043 "Also note that some STL containers (map, set, queue, list, deque)
3044 cannot be exported. [...]
3045 Some STL classes contain nested classes. These classes can not
3047 This is caused by a designed limitation that once a template
3048 class is instantiated, it can not be re-instantiated and
3050 Since our usage of map<> is ubiquitous in gdcm, this "designed
3051 limitation" of VC++ is a pitfall.
3052 Hence the Python wrappers of gdcm cannot be incrementally linked
3053 against the c++ dynamic library. The dirty but only workaround is
3054 to forget about incremental link of dynamic libraries and to generate
3055 the Python wrappers library with the inclusions of the underlying C++
3057 The following modifications concern this matter on Win32/VC++:
3058 - wrapping python correct with standalone wrapped dll (don't use separate
3059 dll under windows !!!!)
3060 - python21_d debug mode enabled (ask Frog how to use it :-)
3061 - NO problem with having an STL member of class for example string in C++
3062 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3063 - Python test of dcmlib in Python is ok under windows on a large set
3065 * removed glib references
3066 * typedef's inserted in gdcm.i for correct swig type management
3068 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3069 * python/demo/*.py load.py extracted from test.py. Added explore.py
3070 that only displays required tags and testAll.py that parses all
3071 the files of the testsuite without using unittest.
3072 * python/testSuite.py other additional test on new files added.
3073 * Data/* new test files added accordingly to the testSuite.
3074 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3075 the vr in the file differs from the one of the dictionary.
3077 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3078 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3079 values, but limits itself to values which are below a user specified
3080 size (by default 1024 bytes).
3081 * python/gdcm.i : elements not loaded (because their size is above the
3082 user specified treshold) are exported with their TagKey as key of the
3083 python dictionary. This enables the testsuite to make some checks
3084 on the unloaded elements (since we have their offset and size).
3085 * python/testSuite.py
3086 - now tests for the existence and proper value of the pixel data
3087 - two new examples added.
3088 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3090 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3091 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3092 aware. See the strategy comments in gdcmHeader::FindeLength().
3093 * Test/test.cxx now accepts a filename as first argument.
3094 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3095 * python/testSuite.py changed to integrate test on above files.
3097 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3098 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3099 the vr was also RET.
3100 * python/testSuite.py more tests added.
3102 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * python/testSuite.py unittest test suite added (uses Data)
3104 * Data/* dcm and acr files for the test suite.
3105 * glib dependance removed from un*x version. We now use ISO C99
3106 7.18 Integer types (see stdint.h)
3107 - python/Makefile, src/Makefile src/gdcm.h
3108 * src/ when an explicit vr (like dicom files) suddenly poped an
3109 implicit element we use to mark the underlying DictEntry of the
3110 concerned ElValue with "Implicit". This strategy was damageable
3111 too the public or provite dictionaries, since some of their vr
3112 would be changed. Since Header::FindLength heavily relies on the
3113 detection by Header::FindVR of falsely explicit elements, I
3114 added an extra ImplicitVr member to ElValue (boolean).
3115 The rest of the changes we the necessary adaptations.
3117 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3118 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3120 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3122 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * Adaptation for porting to VC++:
3125 o forced to use std namespace (for string to be known)
3126 o all class use __declspec export style on WIN32
3127 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3128 (in stdlib.h on Win32 but in std:: for gcc)
3129 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3130 variable GDCM_DICT_PATH.
3131 * src/gdcmHeader.cxx verbose comments made discrete.
3133 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3134 * python/gdcm.i: added a typemap that converts a C++ hashing table
3135 to native Python dictionary.
3136 * python/demo/test.py:
3137 - now uses the native dictionary for exploration of gdcmHeader.
3138 - takes an optional filename argument (the file to parse).
3139 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3140 PubElVals hashing table.
3141 * Dicts/dicomV3.dic removed error prone trailing spaces.
3143 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3144 * Python wrapping process moved away from src/Makefile to
3145 newly created python/Makefile (as well as gdcm.i)
3146 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3147 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3148 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3149 from the environement variable GDCM_DICT_PATH (when existing).
3150 * src/gdcmDict::GetTag bug fix.
3152 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * Straightforward temporary fixes for swig to build the python wrappers.
3154 src/Makefile now has a python working entry [by working we mean
3155 that we can import de shadow classes without errors].
3157 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3158 * hashtest.cxx removed (since already in Test)
3159 * src/gdcmlib.h renamed to src/gdcm.h
3160 * src/dcm.i renamed to src/gdcm.i
3161 * src/Makefile prepared for python wrapping
3163 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3164 * src/gdcmHeader.cxx :
3165 - Parsing of header is now separated from loading of element values
3166 (see gdcmHeader::LoadElements).
3167 - general clean up of hopefully all file access (creation of
3168 ReadInt16 and ReadInt32)
3170 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3171 * src/gdcmHeader.cxx :
3172 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3174 - SetLgrElem renamed to SetLength
3175 - GetLgrElem renamed to GetLength
3176 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3177 * src/gdcmElValSet.cxx fixed both GetElValue methods
3178 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3179 due to IdoDude was cleaned out.
3181 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3182 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3183 concentrates on finding the value representation (when it exists).
3184 RecupLgr now only finds the element value length, and it avoids
3185 returning the unecessary skL (skipped length).
3186 Also, offsetCourant was simply removed (with taille_fich) since
3187 it was redundant with the File position internals (by using
3188 ftell and fseek). This also made skL (see above in RecupLgr) usage
3190 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3191 on the libido specificities which are handled through class
3193 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3196 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3197 * Truckload of changes. Parsing of header is barely functional
3198 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3200 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * src/gdcmHeader.cxx many addons of low level methods
3203 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3204 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3205 and _IdDcmSWAP_LONG.
3207 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3208 * This corresponds to all the changes decided at the meeting of
3209 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob