1 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
3 0002|0000. The value was incorrect.
5 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
8 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmUtil.cxx : compilation fix on Win32
10 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
11 variable, to be easy found. Add methods to change the default UID.
12 Amelioration of the CreateUniqueUID to use the correct default UID.
13 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
16 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * Test/TestVR.cxx : fix memory leaks
19 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
20 * Rewrite the base 256 to base 10 conversion, using string operation only.
21 This allos us to get rid of the problematic 64bits integer type (does not
22 alwyas exist on target platform).
24 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
25 * Add construct and destructor to class gdcm::Debug to close the debug file
27 * Don't let uset to open twice the same file
28 * gdcm has now an official UID prefix,
29 supplied by http://www.medicalconnections.co.uk
30 1.2.826.0.1.3680043.2.1143
31 (Thx to Mathieu for providing URL)
32 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
33 to be able to perform some more tests
34 * gdcm::ContentEntry : Contructors and Destructor are now protected,
35 in order to be sure no user will try to use them.
36 (at user level, only the children classes are meaningfull)
38 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * move RLEInfo & JPEGInfo from Document to File
41 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * FIX : remove so many friend between classes
44 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
46 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
48 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
49 In order to avoid missbehaviour :
50 . gdcm::DocEntry is now specialized in
51 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
52 - gdcm::ContentEntry (Dicom entry with a 'content')
53 . gdcm::ContentEntry is specialized in
54 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
55 characters value, or integers)
56 - gdcm::BinEntry (Dicom entry with a non strig representable value
57 (user hasn't any longer to thing about the precedence of his dynamic_casts)
59 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Test/VTKTest*.cxx : bug fix under linux
62 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
64 use with python. Some methods are moved from Document to ElementSet or
65 DocEntrySet. The equivalent methods to ElementSet have been added to
66 SQItem and are virtual in DocEntrySet. Methods that may have the same code
67 in SQItem and ElementSet is directly placed in DocEntrySet
69 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Test/VTKTest*.cxx : remove the show variable in each test method because
71 it's useless (the viewer variable replace this variable)
73 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDocument.cxx : bug fix on potential memory leak
75 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
76 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
77 Add ClearXxx methods to remove all the content of the list or map
78 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
80 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
81 * methods ReplaceOrCreate renamed as Insert
82 (nobody will be any longer confused by 'CreateOrReplace')
84 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
85 * Grealty simplify the JPEg decompression, no need to differenciate based on
86 the JPEG possible type (with/without fragment, with/without multiple frame).
87 Everything is done throught the JPEG IO Suspension mechanism in IJG
89 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
90 * Stage 3 of normalization :
91 in order to avoid any missunderstanding while reading method names :
92 - All the methods xxxEntry now deal with dicom Entries
93 - Methods GetEntry splitted into
96 - Method SetEntry renamed as SetEntryValue
97 - Method SetEntryBinArea let as it was
99 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
100 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
101 - Position correctly the entry points for JPEG2000 and JPEG-LS
102 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
104 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
106 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
107 with other method names
108 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
109 * Test/TestDicomDirElement.cxx : add new test
111 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
113 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
114 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
115 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
116 So can't you use __int64 in ostream at all.
118 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * bug fix for compilation on MSVC6
120 * gdcmPython/gdcm.i : rename of classes missed
122 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
123 * Stage 2 of names normalization :
124 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
125 (easy to understand ...)
126 - gdcm::FileHelper replaces old class gdcm::File
128 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
130 type and not a string. So, there remove problems on the format of the
133 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
134 * Add Example/TestPapyrus.cxx
135 - reads a Papyrus file (gdcm::Header compliant),
136 - gets the pixels of all the images, using low level iterators
137 - writes an multiframes Dicom image.
138 (Just to show it's *possible* to do that)
139 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
142 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
144 Thus, DicomDirXXX are created with a flad that indicates if the created
145 object is empty or not (when not empty, the DicomDirElement is used to
148 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
150 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
152 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
155 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
157 Remove all access to the hash-tables or lists in the objects.
159 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
161 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
162 be complient with all the gdcm source code
164 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
168 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
172 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * Test/ : rename VTK tests to have a best name for the tests
174 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
175 GetFirstEntry/GetNextEntry use
177 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
178 * In SerieHeader::ImagePositionPatientOrdering()
179 // a Dicom 'Serie' may contain scout views
180 // and images may have differents directions.
181 // -> More than one may have the same 'pos'
182 // Sorting has then NO meaning !
183 Thx to Eduardo Davila for reporting bug.
185 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
187 test. Now it's on image content and not on the resulting visualisation...
188 might solve the problem on linux when using the OpenGL drivers
190 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
191 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
192 DicomDirSerie, DicomDirImage
193 Dict, DictSet classes :
194 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
195 -remove InitTraversal method.
196 * UPD Test programs + Example programs
198 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
199 * remove useless and never updated keyword \ingroup
200 * Solve pb when structure (list, map, ...) is empty.
201 Thx to Benoit for reporting bug
203 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 * Taking into account of 'Transfer Syntax' value
205 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
208 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
210 is no memory access violation
211 * gdcmPython/demo : add python demos using VTK
213 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
214 * FIX 'Dictionnary' is now spelt 'Dictionary'
215 'wether' is now spelt 'whether'
216 'archieve' is now spelt 'archive' ;-)
218 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
219 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
220 related methods, in order not to expose internal mechanisms
223 * REM methods that exposed internal mechanisms :
224 DicomDir::GetDicomDirPatients()
225 DicomDirPatient::GetDicomDirStudies()
226 DicomDirStudy::GetDicomDirSeries()
227 DicomDirSerie::GetDicomDirImages()
228 * UPD Test programs :
232 * UPD Example program
234 * ADD DictSet methods
238 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
239 * Removed the Print/indent/default parameter mess. There is absolutely no
240 reason to have to methods, moreover with the second taking the ostream as
241 *SECOND* parameter. This was clearly a bad hack to get things compile.
243 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Complete rewrite of the GetMacAddress code. Now the code is *much*
245 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
246 Unfortunately the main code does not work on SunOS, thus provide a specific
247 code for this platform only (and Win32 of course). Since this seems to be
248 working, change CreateUniqueUID to use GetMACAddress instead of the
249 problematic GctestetIPAddress
251 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
252 * Unfortunately to be able to test gdcmDirList I had to break the API
253 a little. Now the class is not a std::list anymore but has a member
254 std::vector (more ITK compatible). Allow unit testing on Win32 and
257 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Update SerieHeader to take into account a Serie Instance UID to properly
261 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
262 * ENH - Comment out Mathieu's (dangerous) Super Hack
263 for dealing with BIGENDIAN processors
264 - Move equivalent stuff to BinEntry::WriteContent
265 When necessary, 16 Bits Pixels are swapped in a small buffer
266 and then written. This avoid allocating a huge buffer, in
267 PixelWriteConvertor, and avoid modifying the Pixel Area.
269 Probabely, the same operation will have to be done when we want
270 to write image with Big Endian Transfert Syntax,
271 and we are working on Little Endian Processor
273 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
276 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
277 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
278 all the dict content.
279 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
281 * Test/TestDict.cxx : add a new test for the dict classes
283 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
284 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
285 file. Debug is yanked if compiled with NDEBUG
287 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDictSet.h : set the default output to the os variable
289 * src/gdcmDictEntry.[h|cxx] : add the Print method
290 * gdcmPython/demo/ : add a new test
292 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
293 * merging of Test/PrintDicomDir and Test/TestDicomDir
294 * removal of now redundant Test/PrintDicomDir
295 * enhancement of Example/PrintDicomDir
297 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * Now, python test might work on systems
299 * Add the PrintDicomDir test
301 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
302 * FIX : First entry following group 0002 was lost for
303 Explicit Big Endian Transfer Syntax files
304 (group and elem not swaped)
306 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
307 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
308 Big Endian Transfer Syntax supposed the group following 0002
309 begins always by element 0000 (element 0000 is *optional*)
310 To avoid further troubles, let's be pessimistic, and use
311 Document::HandleOutOfGroup0002() method
312 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
313 (related pb not yet solved)
315 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * Bug fix for the python part use
317 * Now, PrintHeader.py pass... but outside the ctest use. shit !
319 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
322 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
323 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
324 a string and should ask the global TS dict what are the propreties of
327 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
328 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
329 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
330 to swap the Swap Code, at parsing time, when we come out of group 0002
331 and Transfer Syntax is Big Endian
332 We should be able to read now 'true DICOM" Big Endian coded images
333 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
334 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
336 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
337 * Hopefully fix the bug on MacOSX and static global initialization.
338 This is the only -minor- patch I found that both please MacOSX and VS6.
339 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
340 but this would require a lot of change. Another approach would be that Global
341 create those string and GDCM_UNFOUND becomes a pointer to a string (which
342 gdcm::Global would destroy at exit).
344 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Fix bug on MacOSX with static initialization in a multy threaded
346 environment. static const string in a header file used to be ill
347 initialized provoquing the freeze of any tests. patch should solve this
350 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
351 * According to Benoit's suggestion, and without any objection from anybody
352 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
353 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
354 - method gdcmDicomDirObject::GetEntry() renamed as
355 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
357 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
359 you debug/warning message just as c++ streams which make them very convinient
360 to use. Once this is stabilize I will change the ostringstrem to be
361 redirected to a file (ofstream).
362 * Properly support C99 extension: __FUNCTION__ which allow us to display
363 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
365 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
366 * Removal of useless and dangerous methods :
367 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
368 GetDocEntryByName, GetEntryByName, GetDictEntryByName
369 * Removal of usless methods :
370 Dict::PrintByName, Dict::GetDictEntryByName
371 * Commenting out of probabely useless methods :
372 Dict::GetDictEntryNames()
373 Dict::GetDictEntryNamesByCategory()
374 DictSet::GetPubDictEntryNames()
375 DictSet::GetPubDictEntryNamesByCategory()
376 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
377 * ENH : Use dicomTS.dic as described in 2004 version
378 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
379 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
380 Add Accessors on VM (Value Multiplicity), and VM related methods
381 * ADD : Add a list of 'Dicom Attribute types', as found in
382 http://medical.nema.org/dicom/2004/04_15PU.PDF
384 * ADD : Add dicomGroupNameAbbreviations.dic
385 should be used to write a method to replace the former
386 Dict::GetDictEntryNamesByCategory()
388 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
389 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
390 to read in the file... and only it ! Length is the efective length of the
391 data in the DocEntry structure
393 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
395 And now use a static function call instead, with a global variable. i
396 This is much closer to the VTK approach. Hopefully should be bulletproof
397 and easier to use...hopefully
399 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
402 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
405 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
407 ValEntry, BinEntry, SeqEntry creation or replace
409 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
411 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
413 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
414 when specifying the VR
415 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
416 * src/gdcmDocEntry.cxx : amelioration of print
418 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
419 * ADD : Add the method Util::IsCurrentProcessorBigEndian
420 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
421 * ADD Method Document::ComputeGroupLength
422 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
423 in order to allow further VR modification by user
424 * REM : removal of once-called method File::WriteBase
425 integration of its code in formerly one-line method File::Write
427 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
428 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
429 replace the different values "??", "Unkn", "Unknown".
430 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
431 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
432 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
433 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
435 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
438 * Set the gdcm::Base class to some Printable classes
440 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
441 * src/gdcmFile.[h|cxx] : add the Print method
442 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
443 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
444 * src/gdcmDocument.h : remove the PrintLevel informations
445 * Example/PrintFile.cxx : use the new gdcm::File::Print
447 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
448 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
449 problems when compiling with the python wrapping
451 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
452 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
453 writting in ImplicitVR
455 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
456 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
457 JPEG decompression, especially when dicom frames are split into several
458 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
459 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
461 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmHeader.cxx : change the initialisation of default header.
463 Now, this header is readable by gdm, e-film, DicomWorks
465 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
467 Rename Decompressed to Raw
468 * Use the API changes in gdcm::File.
469 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
472 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
473 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
474 each added entry in the header. Replace the 'Planes' field by the 'Number
477 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
479 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
481 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
483 At this time, this image isn't readable by e-film... waiting JPR help to
486 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
488 DocEntry. Now use methods of the Document !
490 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * Test/ShowDicomSeq.cxx : bug fix
493 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
494 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
495 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
496 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
497 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
499 * Test/TestCopyRescaleDicom.cxx : remove unused variable
500 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
501 containing found sequences
503 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
504 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
506 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
507 Some fields in BinEntry must be copied to not seg fault when making the :
508 gdcm::File *copy = new gdcm::File( copyH );
509 and tests are now made on good variables
511 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
513 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
515 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
516 * Add vtkGdcmWriter example and test
518 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * Test/TestUtil.cxx : reformat the source code
520 * vtk/vtkGdcmReader.cxx : remove and change prints
521 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
523 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
524 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
526 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
527 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
528 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
530 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
532 by an eof to prevent all bad read of the file... and in this case, the
535 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * Example/Volume2Dicom.cxx : comment unused variables
537 * Test/PrintDicomDir.cxx : comment unused variables
538 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
539 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
540 method that is redondant with AddEntry.
541 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
544 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * Bug fix due my last commit (compilation under Windows).
546 * Example/Volume2Dicom : bug fix in the file and reformatting source code
547 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
549 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
551 - Remove printf / sprintf
552 - include iostream AFTER gdcm so we don't get warnings
553 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
555 - Also remove tons of include from header files, hopefully this should
556 speeup the compilation time, since it was becoming a dog slow.
557 - Remove gdcm.h as it include way too many files and slow down compilation
558 (plus it is not up to date)
559 - remove 'using namespace std' this is BAD !
561 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Remove memory leaks on the DicomDir
563 * Remove some useless data in DicomDirObject
564 * Add usefull methods in SQItem, to be complient withe the ElementSet
566 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
569 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
570 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
571 future, with convertion)
572 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
573 and ImageDataSize values. Remove the method to get the PixelReadConverter
574 from the output of the class
576 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
577 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
579 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
581 and vtkErrorMacro use.
582 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
584 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
585 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
587 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
588 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
589 The string leaves only in the fonction. So when we make a .c_str(), we
590 get the pointeur on the first element, element that will be destroyed
591 immediately after thee instruction.
592 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
593 file has been opened : the test must be made on the content of the
594 pointer and not directly on the pointer !
597 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
599 the python part recompiles
601 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
602 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
603 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
604 X session is killed (for my computer... it seems to not be identic on
607 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
609 avoid problems (otherwise, the difference test between the visible image
610 and the reference is incorrect. If the reference is greater than the
611 screen resolution, it's produce errors).
612 Can be used for only one image. Can be used with a visible flag.
613 * vtk/vtkGdcmReader.cxx : remove commented codes.
614 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
615 under windows at compilation
616 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
618 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
620 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
622 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
623 tests on the image size X, Y, Z
625 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
627 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
628 between the class name and the file name
630 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
631 * src/ : fix compilation warnings for the Write method (2 different
632 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
633 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
634 variable... create a static method in gdcm::Document to access to
635 this variable content.
637 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
639 file, to be accessed by other files (like gdcmFile). Remove commented
640 code. Move the change of the header to the gdcmFile, using the
642 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
643 To be sure of that (and simplify calls), the Write of the header now
644 gets a file name and not a file pointer (std::ifstream).
645 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
646 DocEntryArchive. Remove all open of the written file
648 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
651 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
653 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
655 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
656 some corresponding methods. Write correctly the file and check before
658 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
659 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
660 is now on RGB data (as before my last commit
661 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
663 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
665 Add a print information of the type of the entry
666 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
667 It was in the gdcmFile, and all write have been regrouped
668 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
669 Write correctly all dicom files (in decompressed mode only at this time)
670 * Test/ : test on files are now made using Raw data and not color data if
672 * Example/PrintFile.cxx : add more printings
674 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * Amelioration of code, remove some code copy. For the loading of
676 BinEntry (in gdcmDocument), add the test to verify if the file is already
679 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
681 remove a DocEntry in the header (push an empty DocEntry)
682 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
683 lines. Bug fix in the initialization of the PixelConvert and the
685 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
686 use in TestCopyDicom (now this test can run under windows... but fails)
687 * Test/TestCopyDicom.cxx : amelioration of the test :
688 - test the pixels written
689 - add test points to quickly find where is the error
690 - can set a file name input and output in arguments
691 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
692 amelioration of the test output
694 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
695 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
696 all replaced DocEntry's
697 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
698 Now, each needed DocEntry to modify is duplicated, modified and inserted
699 to the header using DocEntryArchive. Thus, after save, we can restore the
700 header initial state.
702 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
703 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
705 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
707 correct to copy it. The DictEntry is specified at the DocEntry creation,
708 then, it musn't change in the time.
709 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
710 header correctly. At this time, the change is only made for the first
711 level of the Document. In the future, it might consider sequences.
712 The change is made by replacing a DocEntry by an other that is created
713 outside the class. The old value is kept. When we restore the header
714 status, the added DocEntry is deleted and replaced by the old value.
715 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
716 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
717 set the write type to explicit VR, implicit VR or ACR. Add methods to set
718 the write mode to native, decompressed or RGB (but not used at this time)
720 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
721 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
722 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
724 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
726 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
728 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
729 set because already copied when copying the BinEntry's of the header
730 * Test/TestAllReadCompareDicom.cxx : remove warnings
732 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
734 Two problems appear when doing it :
735 - with the gdcmFile : when the GetImageData method is called, the pixels
736 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
737 data (pixels). And each structure destruct the data when it's
738 destructed. So we have two destructions for the same data. To solve it,
739 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
740 data or not. If it doesn't own data, then they will not destroyed by
742 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
743 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
744 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
745 create a double destruction of the same DocEntry's. So, to solve it,
746 the TagHT is simply cleared and the DicomDir* elements are destroyed.
747 * TODO : add an entry concerning memory leaks in the DicomDir
749 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
750 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
751 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
754 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
756 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
757 after it have been deleted
759 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * FIX: src/* fix the doxygen warnings.
761 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
762 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
763 was erroneously defined with a size of 15 instead of 16. [many thanks
764 to Jean Michel Rouet for pointing out this bug].
766 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
767 1. Finish merging JMR patch for writting DICOM from scratch
768 2. Fix -hopefully- bug with MONOCHROME and space vs null character
769 3. Use const ref when possible
770 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
771 5. A few more comments
772 6. CreateUniqueUID can now be called without parameter"
774 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
775 * ENH: Slightly bigger patch:
776 1. Getting toward full integration of JMR patch for writting dicom from scratch
777 2. Update Test to test part of this patch: CreateUniqueUID
778 3. File was not close properly in gdcmDict
779 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
780 5. Use of const ref instead of copy (speed issue)
781 6. Remove temporary (duplicate) string in TranslateToKey
782 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
783 8. Do not repeat virtual in subclasses
784 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
786 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
787 * Apply first patch toward better string comparison when dealing with broken
788 DICOM files. Essentially the string could be padded with a space instead
789 of a null character as defined by standard
791 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
793 because never used... and in the same time, that's remove some memory leaks
795 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmFile.cxx : now delete the PixelConvert instance.
797 * In examples and tests : change the type of image data variables from void*
798 to uint8_t*. Remmove all delete on image data variables
800 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
802 Verify the file pointer value before open the file, and if it's not null,
803 a verbose message is generated.
804 Close correctly the file when the file isn't considered dicom-like. The
805 correctly close is a call to CloseFile.
806 When closing the file pointer, test if its not null to close the file.
807 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
808 file. For an uncompressed image, the copied data correspond in the least
809 case to the image size (calculated) or the image size specified in the
810 header. A verbose is generated if these two size mismatch
812 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
814 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
815 break under windows (with msvc6 compilation).
817 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
818 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
819 compiling with MSVC6)
821 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * Bugs fix for the Windows build with VC6
823 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
824 needed (only for projects required VTK). If the VTK is included in all
825 projects, there is conflicts with the jpeg lib of vtk when compiling the
826 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
827 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
828 when compiling the gdcm_wrap.cxx file (created by the compilation of the
830 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
831 (like it's already made for the cout use). Otherwise, conflict with the
834 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
837 - comments on the DicomDir::Method related usage added.
838 - now that we use the namespace gdcm, a lot of internal classes do
839 NOT need to be wrapped anymore.
840 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
841 DicomDir::Method) new example added.
843 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * Improve string manipulation. I now inforce the notion of 'DicomString'
845 A DicomString can contain as many \0 as they want
846 and it is *always* of even length.
847 We only support odd length for very rare case.
848 And in the near future this should be removed.
850 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
851 * /binary_write/ gdcm source. Now even on big endian we are writting
852 little endian. This should -heopfully- fix some tests
854 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
855 * Now the dictionary is compiled into gdcm lib. This is a default
856 behavior, thus any dic file specified is picked before failback to
857 the one comiled into lib
859 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * Change internals for gdcmDict. Don't use any 'new' any more.
861 This should definitely solve any leak problem, and we should be
862 as fast as before, as long as don't modify too much the dictionary.
864 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
865 * STYLE: ivars should start with a capital letter.
866 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
867 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
869 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
871 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
872 new 2004 dictionaries added (thanks to JPR).
873 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
874 * CLEANUP_ROUND (15) for gdcmPixelConvert
875 - RLEFrame::NumberFragments is now of type unsigned int
876 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
877 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
880 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 * Initial work in gathering all transfer syntax accessors. clearly
882 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
883 ivars, but only one transfersyntax (class) ivar with equivalent method on
886 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
887 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
888 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
889 discussed (plus I didn't like having a 2000 lines patch not commited)
891 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
892 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
893 * CLEANUP_ROUND (14) for gdcmPixelConvert
894 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
895 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
896 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
898 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
899 anymore and hence avoids storing a copy of PixelConvert::Decompressed
900 into File::Pixel_Data.
902 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
904 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
905 * CLEANUP_ROUND (13) for gdcmPixelConvert
906 Substituted File::ParsePixelData() with PixelConvert::Print() new
908 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
909 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
910 method to those classes.
911 - src/gdcmFile.[cxx|h]:
912 -- Added a ::Print() method.
913 -- PixelConverter is now a reference instead of a member.
914 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
915 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
917 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
919 collaboration diagram and inheritance diagram should be generated with
921 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
922 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
923 pointlessly wrapped (see
924 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
925 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
926 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
927 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
928 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
929 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
930 -- File::Initialise: PixelConverter setup moved away to
931 PixelConverter::GrabInformationsFromHeader()
932 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
933 interpretation moved away to PixelConverter::BuildRGBImage()
935 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
937 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
939 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
941 displayed on Win32 when a brutal abort() occurs (because of uncatched
942 exception). See TODO new entry of this commit for more on this.
943 * TODO added new entry.
944 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
945 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
946 - HandleColor is no longer called from gdcmFile.cxx
947 - gdcmPixelConvert.cxx clean up on method arguments and internal
948 variable names for semantical coherence.
950 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
951 * Finished lossless transition, not only do we now read all lossless jpeg
952 images, without the need of the Cornwell lib, but we do read them properly now
953 * To reduce code (well to avoid code duplication), I defined a common place
954 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
955 redefine symbols. This is not perfect but this the best solution I found for a
956 compilation time jpeg option.
958 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
959 * Update jpeg ijg lib to support lossless jpeg implementation
960 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
962 * Also added a special copyright for dcmtk since we use their bugfixes.
965 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
967 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
968 matters, as stated in warning note at begining of %include section).
969 * src/gdcmDicomDir*.[cxx|h]: coding style
970 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
971 * src/gdcmJpeg8.cxx: doxygen fix.
972 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
973 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
974 from File:: to PixelConvert::.
976 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
978 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
979 - more code moved away from File:: to PixelConvert::
980 - fat setup of PixelConverter set in place in File::Initialise.
982 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
984 namespace at the file system level. So now you should convert your examples
986 gdcmHeader -> gdcm::Header
987 It would be nice if people keep in mind to no open the namespace, since it
988 allows compilation on broken plateform which were defining common symbol in
989 the standart namespace (like LP, Unknown ...)
991 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
993 The JPEG fragments are now parsed at the same stage than the RLE
994 information. All code related to JPEG is now in gdcmPixelConvert:
995 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
996 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
997 export a gdcmFile:: method. Those are simply global functions
998 (for the time being this is better than having them attach to
999 either gdcmFile:: or gdcmPixelConvert::).
1000 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1001 and stores the result in a gdcmJPEGFragmentsInfo.
1002 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1003 code (among other stuff) moved away from gdcmFile:; to
1006 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1008 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1009 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1010 clean up of RLE related code.
1011 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1012 - src/gdcmRLE.cxx removed
1013 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1014 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1015 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1016 * CLEANUP_ROUND (9) for gdcmPixelConvert
1017 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1018 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1019 away from gdcmFile:: to gdcmPixelConvert::.
1021 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1023 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1024 This is because Parse7Fe0 used to parse the pixels to compute the
1025 length. This task was passed over to FindDocEntryLengthOB() a long
1026 time ago, EXCEPT I had forgotten the OW case...
1027 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1028 we just recylce the code for parsing RLE fragments and computing
1030 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1031 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1032 with the retired Parse7Fe0().
1033 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1034 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1036 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1038 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1039 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1040 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1041 * CLEANUP_ROUND (4) for gdcmPixelConvert
1042 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1043 to return an unused length.
1045 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1046 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1047 this should be cleanner from the plane view. The iostream are erally a pain
1048 to use to do simple stuff.
1050 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1051 * Redo the compilation of the ijg jpeg library. Now only one source is
1052 necesseray. No need to rename file by hand what so ever. CMake handle the
1053 copying of the file within different directory, configure header file to
1054 modify some symbol. The only addition made to ijg wasd a mangle table so
1055 that symbol are different whether we are within 8bits or 12bits.
1057 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * Added documentation of vtkgdcmReader on Website:
1059 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1060 with it's binary name).
1061 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1062 the Website to be more complete.
1063 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1064 doxygenated documentation.
1065 - Doc/DoxyVtkGdcmReaderExamples.txt added
1066 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1067 DoxyVtkGdmReaderExamples.html )
1068 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1069 * CLEANUP_ROUND (3) for gdcmPixelConvert
1070 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1072 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * CLEANUP_ROUND (2) for gdcmPixelConvert
1074 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1076 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1077 * CLEANUP_ROUND for gdcmPixelConvert:
1078 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1079 - src/gdcmPixelStuff[h|cxx] removed
1080 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1081 - src/CMakeLists.txt changed accordingly
1082 * GDCMHOME clean up:
1083 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1084 gdcmVersion.py moved to newly created ATTIC related
1085 gdcmPython/SetupOldies/ directory.
1086 * Autotools clean up:
1087 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1088 - autogen.sh configure.in acinclude.m4 python.m4 removed
1090 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1092 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1093 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1095 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1096 * TODO updated with Mathieu suggestions. I proposed a template for
1097 describing TODO entries and used it for new entries.
1098 * Added Doc/Website/CodingStyle.html, Developpers.html,
1099 DeveloppersPython.html, GdcmDataCvs.html and
1100 DownloadVersion0_1.html, DownloadVersion0_3.html.
1101 * Some Doc/*.txt Doxygen files (which do not really concern the
1102 documentation itself, but the website) moved to html and
1103 placed in directory Doc/Website:
1104 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1105 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1106 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1107 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1108 * CMakeLists.txt changed accordingly.
1109 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1110 DeveloppersPython.html
1111 * INSTALL nows refers to Doc/Website/Installation.html
1113 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1114 * Added Doc/Website directory, that contains a first raw version
1117 2004-09-23 Jean-Pierre Roux
1118 * FIX In order not to be poluted any longer by casting problems,
1119 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1120 we can now delete[] it safely
1121 * VoidArea is now called BinArea (less confusing name),
1122 and all the methods called ...VoidArea... are now ... BinArea...
1123 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1125 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1127 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1128 up to the destructor of gdcmElementSet to clean up TagHt and it's
1131 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1133 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1135 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * ENH: added some utility method that builds a flat dictionary
1137 holding all the Dicom entries contained in the recursive structure
1138 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1139 an example of usage.
1140 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1141 BuildFlatHashTable() that build a flat dictionary.
1142 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1143 gdcmDocument is now a friend of gdcmElementSet.
1144 - src/gdcmElementSet.cxx: clean up.
1145 - Example/FlatHashTablePrint.cxx added.
1146 - Example/CmakeLists.txt changed accordingly
1148 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1150 moved away from gdcmDocEntrySet (since this class is an abstract class
1151 acting like an interface). SQDepthLevel and BaseTagKey are now
1153 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1154 and associated accessors. Doxygenation of the class.
1155 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1157 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1158 Use SQDepthLevel accessor instead. ::Print() adapted.
1159 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1160 - src/gdcmDocument.cxx changed accordingly.
1162 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1163 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1164 - The following is the doxygen comment of the typedef declaration
1165 of gdcmTagKey in src/gdcmCommon.h:
1166 gdcmTagKey is made to old an "universal" (as in URL, Universal
1167 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1168 A dicom tag always has a group and an element, but a set of tags
1169 embeded in various (optionally nested) sequences and sharing
1170 the same group and element all share the same (group, element)
1171 "identifier". Hence the (group, element) cannot be used as an
1172 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1173 In order to construct a proper tag identifier (i.e. a key) we
1174 consider the following definition of a TagKey:
1175 - let Group, Element be the string representation of the
1176 group and element dicom tag members,
1177 - let ItemNumber be the string representation of the integer
1178 index of the considered item number of a sequence,
1179 Let the key of a tag embeded in a sequence, noted SeqTag, be
1181 /ItemNumber#Group|Element
1182 where "/", "#" and "|" are characters acting as separators.
1183 Then the general form of a gdcmTagKey is given by:
1184 Group|Element<SeqTag>
1185 where <SeqTag> means NO or many instances of SeqTag.
1186 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1189 but the gdcmTagKey of a tag "embeded" is the first item of
1190 a sequence, itself nested in the third item of a sequence is the
1192 0004|1220/2#0008|0082/0#0008|0090
1193 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1194 order to hold the new sequence compatible key. Previously, the
1195 GetKey() method would look in the underlying gdcmDictEntry.
1196 - src/gdcmDocEntry.cxx:
1197 -- constructor now copies the underlying DictEntry key, in the local
1199 -- ::Print: displays the member Key, instead of the (group, element).
1200 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1201 - src/gdcmDocEntrySet.h:xi
1202 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1203 -- now has a new BaseTagKey member.
1205 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1206 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1208 This poses the problem with the semantics of the following lines
1209 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1210 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1211 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1212 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1213 to the long FIXME note for what the problem is. Nevertheless in
1214 order to get things working the dicom dictionary was altered !
1215 Please fix things urgently...
1216 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1217 information), see above note on moving the member VoidArea. Nevertheless
1218 the following entries previously correctly set as US are now inproperly
1220 0028 1201 OW IMG Red Palette Color Lookup Table Data
1221 0028 1202 OW IMG Green Palette Color Lookup Table Data
1222 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1223 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1224 of gdcmDocEntry moved to gdcmSeqEntry.
1225 * src/gdcmSeqEntry.cxx: STYLE.
1227 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1230 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * gdcmPython/testSuite.py: all the test suite in python is now moved
1232 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1233 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1234 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1236 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1238 to avoid inclusion recursion until STL is reached.
1239 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1240 mecanism. errno.h is not included in gdcm anymore.
1241 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1242 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1244 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1245 gdcmData/TestAllEntryVerifyReference.txt
1246 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1247 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1248 exception_on_error parameter.
1249 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1250 - vtk/vtkGdcmReader.cxx changed accordingly,
1251 - Example/*.cxx and Test/*.cxx changed accordingly.
1253 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1254 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1255 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1256 enable_sequences removed from gdcmHeader constructor and dependencies.
1257 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1258 * gdcmPython/demo/PrintHeader.py: dummy fix.
1259 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1260 skip_shadow removed from gdcmHeader constructor and dependencies.
1261 * Example/*.cxx and Test/*.cxx changed accordingly.
1263 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1264 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1265 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1267 2004-07-21 Jean-Pierre Roux
1268 * FIX Now, Parsing and Printing a DICOMDIR do work!
1269 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1271 2004-07-20 Jean-Pierre Roux
1272 * FIX Some brain damaged headers have Zero-Lenght fields
1273 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1275 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1276 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1277 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1278 variable (instance of gdcmDebug) by a definition macro, and the instance
1279 is now in static in the gdcmDebug class
1280 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1281 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1283 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * WARNING: ctest now depends more tightly on gdcmData. You should
1285 check out gdcmData properly for things to run smoothly...
1286 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1287 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1288 we need the pixels not be loaded in order to use the ValEntry
1289 that displays position and size).
1290 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1291 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1292 be deprecated. If you have any doubts about the advantages of a
1293 modern scripting language (read Python) versus grass root C++ (i.e.
1294 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1295 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1296 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1297 Anyhow, consider documenting the gdcmData images in
1298 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1300 * Test/CMakeLists.txt:
1301 - now uses TestAllEntryVerify.cxx
1302 - specific comments on oldACR00001.ima (now renamed in gdcmData
1303 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1304 gdcmData/TestAllEntryVerifyReference.txt
1307 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * src/*.[h|cxx] : typedef clean up
1309 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1310 - TagKey renamed to gdcmTagKey (for external usage)
1311 - VRKey renamed to gdcmVRKey (for external usage)
1312 - removal of typedef duplication.
1313 - Removed all unecessary inline keyword from class inline definitions.
1314 - Some method|function(void) declarations replaced with method|function().
1315 * src/jpeg/libijg12/jdhuff12.c:
1316 - printf polluting ctest removed.
1317 - TAB removal for comminting
1319 - TestAllReadCompareDicom.cxx: added a test that compares all the
1320 images in gdcmDataImages.h with corresponding images in
1321 gdcmData/BaselineDicom/. When baseline images are not present
1322 this test creates them.
1323 Note: we need to validate each reference image, but before that
1324 I'd like to rename them with a more explicit name...
1325 - CMakeLists.txt: changed accordingly.
1326 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1327 including each header needed).
1329 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1331 test suite to the Example directory. Are concerned:
1336 - TestWriteSimple.cxx
1337 * Test/CMakeLists.txt: added some comments on reasons for black listing
1338 image gdcmData/oldACR00001.ima
1340 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * Test/CmakeList.txt: removed the following from black list (to be coherent
1342 with removal from gdcmData):
1343 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1344 - gdcm-MR-PHILIPS-16.dcm
1346 Added the following because after last cvs update, they cause
1347 ctest -R TestReadWriteReadCompare
1349 - gdcm-MR-SIEMENS-16-1.acr
1351 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1352 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1353 new comments in this file) we temporarily (sigh) move to a weaker
1355 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1356 we don't need to black list the following images anymore:
1357 - 8BitsUncompressedColor.dcm
1359 - US-PAL-8-10x-echo.dcm
1360 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1361 fixes and the beautified code ;-)
1362 This fixes the bug introduced in version 1.42 (when beautifying)
1363 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1364 Note: ctest was blind to this bug (this means we need to still
1365 improve the test suite). The bug could be detected by using
1366 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1368 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1369 and by displaying the (garbage) produced file temp.XDCM...
1371 2004-06-29 Jean-Pierre Roux
1372 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1373 - replace by uggly but working old code :-(
1374 A lot of things should be OK again.
1375 It's really urgent to have a test suite that *tests*,
1376 to prevent Frog's beautifying sessions to break all the stuff
1377 (twice, withing a fortnigh ...)
1379 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1380 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1381 redundancy) to added Test/TestReadWriteReadCompare.cxx
1382 * Test/CmakeList.txt: because the compare test of
1383 Test/TestReadWriteReadCompare.cxx fails, the following images are
1384 black listed: - 8BitsUncompressedColor.dcm
1386 - US-PAL-8-10x-echo.dcm
1387 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1388 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1389 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1390 and ad-hoc kludge. This kludge is now removed, and on encountering
1391 such an image (OB field brain damaged) we set errno. Then in
1392 ::FindDocLength() we "fix" the length as being ALL what remains
1393 in the file (until EOF). We then proceed, hoping for the best...
1394 This fixes a SegFault in ShowDicom when trying to write such an
1396 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1397 (because TestWriteRead breaks on it, after a non conformal commit?).
1398 ctest now runs properly, except for MakeDicomDir (which was always
1399 broken) and the Python related stuff (still not fixed).
1401 2004-06-24 Jean-Pierre Roux
1402 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1403 FIX : Test/TestReadWrite now iterates on all the file names
1404 (instead of infinite loop)
1405 ENH : Test/TestWriteRead now iterates on all the file names
1407 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1408 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1410 2004-06-24 Jean-Pierre Roux
1411 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1412 when SamplesPerPixel =3
1413 - now Write is no longer confused by
1414 'BitsAllocated = 12" and 'BitsStored=12"
1415 - "UN" value representation Elements are now written correctly
1416 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1417 ENH : - now gdcmHeader has its own Write methods
1418 (in order to split the job that has not to be done
1421 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1423 loop on the same image until memory went out.
1424 Note: this means we still have gobs of memory loss in PrintDocument
1425 * src/gdcmDocument.cxx: fixes problem on parsing on file
1426 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1428 2004-06-24 Jean-Pierre Roux
1429 FIX : Write - All the Sequences and Sequence Item are now written
1430 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1431 is added a the end, when necessary.
1432 - A lot of brain-damaged images, that were read correctly are
1433 now written correctly
1434 - length compatible BinEntry are now loaded correctly
1435 (even for odd groups)
1436 Note : only Explicit Value Representation was checked.
1437 (question : is implicit VR really necessary for gdcm ?)
1439 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * DEVELOPPER: added a proposition of coding style.
1441 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1444 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1446 Use the gdcmDocEntry::Print() and Write() instead.
1447 * src/gdcmDocument.cxx: bug fix.
1449 2004-06-22 Jean-Pierre Roux
1450 FIX : gdcmDocument.cxx
1451 - Now we do recognize the JpegLossLess format (there was a misstyping in
1452 code 'beautyfication' :-(
1453 - Now we automaticaticaly load the Luts, if any
1455 2004-06-22 Jean-Pierre Roux
1456 In order : to write Sequences, whatever their imbrication level,
1457 : to allow user to create his own Sequences
1458 a lot of modif where necessary (adding, moving, or virtualising methods)
1460 WARNING : save your own sources *before* cvs up !
1463 ADD virtual void Write(FILE *fp, FileType filetype);
1466 ADD virtual void Write(FILE *fp, FileType filetype);
1467 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1470 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1471 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1472 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1473 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1474 ADD std::string GetEntryByName(TagName name);
1475 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1477 std::string vr = "unkn",
1478 std::string fourth = "unkn",
1479 std::string name = "unkn");
1480 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1481 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1482 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1483 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1484 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1485 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1486 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1487 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1490 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1491 ADD virtual std::string GetEntryByName (TagName tagName);
1492 ADD virtual std::string GetEntryVRByName (TagName tagName);
1493 REM virtual bool Write(FILE *, FileType);
1494 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1495 FILE *_fp, FileType type);
1496 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1497 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1498 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1499 REM virtual std::string GetEntryByName (std::string tagName);
1500 REM virtual std::string GetEntryVRByName (std::string tagName);
1501 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1502 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1503 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1505 std::string vr = "unkn",
1506 std::string fourth = "unkn",
1507 std::string name = "unkn");
1508 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1509 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1510 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1511 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1514 ADD virtual void Write(FILE *fp, FileType filetype);
1517 ADD virtual void Write(FILE *fp,FileType filetype);
1520 ADD virtual void Write(FILE *fp, FileType filetype);
1521 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1522 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1523 REM std::string GetEntryByName(TagName name);
1526 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1528 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1529 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1530 The default constructor invoked by the line
1531 gdcmHeader *f1 = new gdcmHeader( header );
1532 was gdcmHeader::gdcmHeader(bool) instead of the expected
1533 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1534 Hence the parsing wasn't executed... See also below.
1535 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1536 as explicit constructor didn't do the trick to fix the above problem.
1537 Could anyone explain why ?
1538 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1539 properly calls gdcmValEntry::Print() (that was weed out from
1540 code related to gdcmBinEntry).
1542 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1543 * In order to fix memory leaks:
1544 - Test/TestWriteSimple.cxx: added cleaning of free store through
1546 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1547 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1548 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1549 (through the call to ::AddDicomDirMeta()) or the destructor
1550 would crash when deleting uninitialized ::metaElems].
1551 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1552 - src/gdcmDocument.cxx:
1553 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1554 from dynamic stores.
1555 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1556 was causing memory leaks.
1557 - src/gdcmSQItem.cxx:
1558 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1559 cleanly handled with polymophism: sorry but my milage is low).
1560 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1561 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1562 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1563 This avoids SegFaulting.
1564 - src/gdcmSQItem.h: coding style.
1566 - Test/TestWriteSimple still severely sucks. The output image content
1567 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1568 damaged when displayed with vtkgdcmViewer.
1569 - on memory leaks: TestWriteSimple leaks really less (see entry
1570 of 2004-06-18 in Changelog file for the call to valgrind).
1571 - on segfaults: ctest now passes all the tests but one (no more
1573 * Erroneous leading white fix:
1574 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1575 white[s] (as opposed to from >> xxx, that removes it [them].
1576 - src/gdcmTS.cxx: ditto.
1577 - gdcmPython/testSuite.py: dirty related kludge removed.
1578 * src/*: remaining references to gdcmParser removed.
1579 * src/*[cxx|h]: added copy[way]left header.
1582 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * In order to fix writing of dicom files:
1584 - Test/TestWriteSimple.cxx: a simpler example of writing.
1585 - Test/CMakeLists.txt changed accordingly.
1586 - src/gdcmDocument.cxx:
1587 -- The destructor now recursilvely removes potential sequences.
1588 -- Bug fix in ::IsJPEG2000()
1589 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1590 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1592 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1593 to only declared) and build on top of
1594 ::GetDocEntryByNumber(guint16, guint16).
1595 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1596 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1597 for usage in destructor and treatement of promotion in
1598 ::ReplaceOrCreateByNumber().
1599 - src/gdcmSQItem.cxx: destructor should better handle his job.
1600 Test/TestWriteSimple now runs (or at least it DOES something).
1601 * We can now start hutting memory links. A good starting point is:
1602 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1603 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1604 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1606 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1607 * Valgrind note: after Mathieu Malaterre teached me how to read
1608 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1610 Using gcc, you can force the STL to use malloc and to free memory as
1611 soon as possible by globally disabling memory caching.
1612 With 3.2.2 and later, you should export the environment variable
1613 GLIBCPP_FORCE_NEW before running your program.
1614 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1615 simply vanish (it is still not clear to me, whether this means that
1616 STL std::string leaks or if valgrind believes it leaks...).
1617 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1618 running bin/gdcmTests makeDicomDir):
1619 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1620 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1622 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1623 SegFaulting (I drowned in DicomDir related code when trying to
1624 understand why the list is empty...).
1625 * src/gdcmDocument.h: first BSD license header try.
1626 * Doc/License.txt added.
1628 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * src/gdcmDocument.[h|cxx]:
1630 - Clean up of the Transfer related predicates. They are now all based
1631 on new method isGivenTransferSyntax, that (should) handle properly
1632 the padding problem.
1633 - general clean up, simplification, and coding style.
1634 - Specific clean up of Parse7FE0() (umproperly named actually).
1635 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1637 2004-06-14 Jean-Pierre Roux
1639 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1640 - fix the display of SQItem ordinal number
1641 - add the GetSQItemByOrdinalNumber method
1642 - remove some useless never written private methods
1644 2004-06-14 Jean-Pierre Roux
1646 - adding a constructor taking a gdcmDocEntry as an input param
1647 - ReplaceOrCreateByNumber now returns :
1648 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1649 a gdcmValEntry * if a string value is passed as a param
1651 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1652 according to the param type (no longer sets a gdcmDocEntry)
1653 - GetValEntryByNumber, GetBinEntryByNumber added
1654 - NewValEntryByNumber and NewBinEntryByNumber added
1656 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1658 - GetSQItemNumber and SetSQItemNumber added, to provide
1659 a (relative) Item identier inside a given Sequence
1660 \warning : some pb remaining around this number
1662 - AddEntry now takes the Item Number as a param
1664 - adding a constructor taking a gdcmDocEntry as an input param
1666 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * Memory leak hunt with the following command:
1668 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1669 --show-reachable=yes gdcmTests PrintDocument
1670 It looks like many (all?) leaks are due to the STL (or a bad usage
1671 of the STL. The lines producing the leaks now have a comment with
1672 a "MEMORY LEAK" tag: you can retrieve them with
1673 grep "MEMORY LEAK" src/*
1674 Here are two typical examples which I can't help fixing:
1679 char * test = "babo";
1680 name = test; //// <--- valgrind detects 960 bytes lost in
1681 //// call to std::string::operator=(char const*)
1682 name.clear(); //// Doesn't help !
1690 std::cout << "Type a bunch of characters followed by RETURN: ";
1691 getline(std::cin, line); //// <--- valgrind dectects a loss
1692 //// of 1320 bytes in call to
1693 /// std::basic_istream<>& std::getline<>
1699 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * src/gdcmHeader.[cxx|h]:
1701 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1702 and related, moved away to gdcmDocument.
1703 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1704 the corresponding protected accessors of inherited class
1705 gdcmDocument, removed ! As a consequence gdcmFile had to be
1706 declared friend of class gdcmDocument (see below).
1707 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1708 - Clean up of undefined or unused methods.
1709 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1710 account the changes to gdcmHeader.h).
1711 * src/gdcmDocument.h:
1712 - gdcmFile is now a friend class (in order to take into account the
1713 changes to gdcmHeader.h).
1714 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1715 (see changes to gdcmHeader.h).
1716 - Accessors (reading on the form GetEntry*) are now public.
1717 - Clean up of undefined or unused methods.
1718 * src/gdcmDocument.cxx:
1719 - adaptation to changes to gdcmDocument.h
1720 - ::OpenFile now writes a verbose message when file cannot be opened.
1721 - some std::string properly set to VRKey
1722 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1723 references to gdcmDocument.
1724 * Test/TestFindTags.cxx: changed accordingly to above changes.
1725 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1726 cvs repository gdcmData.
1728 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1730 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1731 conflicts with gdcmValEntry::voidArea.
1732 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1733 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1734 Value representation between StringRepresentable and BinaryRepresentable.
1735 * src/gdcmDocument.cxx:
1736 - method ParseDES: proper indentation restored and usage of
1737 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1738 - method LoadDocEntry: the fingerprint left in the SetValue() of
1739 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1740 removed. Reverting to previous code segment with the proper
1741 dynamic_cast< gdcmValEntry* >.
1742 Note: this was (partially) breaking the python test suite
1743 (gdcmPython/testSuite.py) that made usage of the above
1744 fingerprint to check presence of "Pixel Data".
1745 * src/gdcmDocEntry.h: coding style.
1746 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1747 now taken into account.
1748 * gdcmPython/gdcm.i: adaptation to the new internal representation
1749 of gdcm (exit gdcmParser, hello gdcmDocument).
1750 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1752 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1753 anymore, but instead prints the loaded Python dictionary.
1754 * .... alas, the python testSuite is still broken.
1756 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1757 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1759 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1760 * src/gdcmUtil.h : export methods
1762 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1763 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1765 * Initial addition of automatic python testing
1766 * Initial addition of automatic image comparison
1768 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1769 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1770 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1772 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1773 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1774 * Test/ShowDicom.cxx : bug fix for msvc compilation
1775 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1777 2004-05-04 Jean-Pierre Roux
1778 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1779 new concepts (and new classes) :
1780 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1781 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1782 - Sequence Doc Entries (gdcmSeqEntries)
1783 a Sequence is composed of Items.
1784 Each item is a set of Doc Entries (this is recursive)
1785 The non uniqueness of the 'Dicom tag' is due to this recursivity
1786 (never taken into account)
1787 Our unability to add a new 'entry' in the header
1788 at the proper location (neither in the H-Table (map or multimap),
1789 nor in the Chained List is also due to this recursivity.
1790 Don't try, right now, to use/modify/compile these new sources :
1791 nothing is finished.
1792 We just commit all the stuff, 'as is', in order not to loose it.
1794 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1795 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1797 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1798 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1799 file prefix (SetFilePrefix)
1801 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * Add a new test: ShowDicom, for now this is just the c++ version of
1803 checkRead.sh, later it will be able to compare the image read against a
1805 * Replace the DEBUG on the stack with a global entry in cmake interface:
1806 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1808 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * Add an example subdir, with a real example on how to read + write a
1812 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1814 * Doc/CMakeLists.txt: the main page is now properly differentiated
1815 between the developper and user version.
1816 * Doc/doxygen.config.in: dropped search related obsolete flags
1817 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1819 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1820 * DEVELOPPER: added some helpfull comments for compile/test/install
1823 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1825 src directory, now generated in the build dir.
1826 2. Tests as mentionned smarter
1828 4. Add a new method in gdcmDict that return the PubDict by name
1829 this is interesting for 3rd party lib like ITK,
1830 where we could set the institution name / patient name...
1832 * ENH: 1. Now the test suite is working for real
1833 2. All binaries are now output in the gdcm-bin directory
1834 (this was not true before)
1836 2004-04-28 Jean-Pierre Roux
1837 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1838 SeQuence indented printing of Dicom Header.
1839 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1840 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1841 Computation of SQDepthLevel is now part of gdcmHeader constructor
1842 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1843 tree-like structure of a Dicom Header.
1844 * FIX Test code cleaning
1846 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1847 * ENH: Adding automatic testing
1848 1. Need a DartConfig.cmake to submit to public
1849 2. Add a test driver gdcmTest.cxx
1850 3. gdcmTestMain, an helper for the main test driver gdcmTest
1851 4. Files in Test don't have a main anymore, this becomes interesting
1852 when we add more and more tests, thus dsw don't have to load
1854 * ENH: Adding a GDCM_DATA_ROOT for testing
1855 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1856 one file instead of seven + some small cleanup
1858 2004-04-22 Jean-Pierre Roux
1859 * ENH Minor changes to the Print() methods.
1860 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1861 Header printing. Example given with :
1862 > PrintHeader fileName 2 new
1863 (SQ based tree-like structure still to be done for the Header ...)
1865 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1867 1. I have added some unsigned where needed
1868 2. Some function parameter not used -> (void)
1869 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1870 4. g++ don't like character '\' in comment
1871 5. #define jpeg_create_decompress jCreaDecompress
1872 this really need to be fixed
1873 6. virtualize destructor of gdcmObject ... leakage
1874 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1875 this also really need to be fixed
1876 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1877 remove compression file
1878 (as we only do decompression, right ?)
1879 * ENH: Change malloc/calloc/free with c++ equivalent
1881 2004-04-21 Jean-Pierre Roux
1882 * FIX gdcmHeaderHelper::GetXSpacing
1883 when a single value is found (bug ?), xpacing is now
1884 defaulted to yspacing
1886 2004-04-19 Jean-Pierre Roux
1887 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1888 * ENH add parameters :
1889 bool exception_on_error = false,
1890 bool enable_sequences = false,
1891 bool ignore_shadow = false
1892 to the gdcmFile constructors to be full gdcmParser compliant
1893 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1894 to allow reading of PAPYRUS 3.0 files
1896 2004-04-06 Jean-Pierre Roux
1897 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1899 2004-04-02 Jean-Pierre Roux
1900 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1901 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1902 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1904 2004-03-30 Jean-Pierre Roux
1905 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1906 for ACR file, written out as DICOM files (hope so...)
1908 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1909 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1910 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1911 moved to base class gdcmParser and only the specialisation is kept
1913 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1914 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1915 already does the job.
1916 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1917 (to be consistent with gdcmParser::WriteEntries).
1919 2004-03-30 Benoit Regrain
1920 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1921 upate of the object's instance. It's passed to 2 in the unfavorable
1922 case : one in the ExecuteInformation, one in the ExecuteData
1924 2004-03-29 Jean-Pierre Roux
1925 * ENH : Check on file type to be written moved
1926 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1927 * FIX : gdcmObject::ResetBoundaries now stops properly
1928 when end-of-list is reached
1929 : gdcmVersion modified (as Benoit Regrain asked)
1931 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1932 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1933 * src/gdcmUtil.cxx: added forgotten iostream include.
1934 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1935 equivalent to ExplicitVR in existing code).
1937 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1938 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1939 now contains all the gdcmGlobal related code.
1940 * minor coding style and doxygenation changes.
1942 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1944 now contains all the Debug related code.
1945 * minor clean-up of includes in src/*.cxx
1946 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1947 CreateCleanString) removed.
1948 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1949 * Doc/DoxyMainPageUser.txt added.
1950 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1951 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1952 src/gdcmDirList.cxx)
1954 2004-03-24 Jean-Pierre Roux
1955 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1957 2004-03-23 Jean-Pierre Roux
1958 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1959 big endian made volumes
1960 * ENH Now gdcmParser constructor and destructor are protected to forbid
1961 end user to instanciate class gdcmParser
1962 (only gdcmHeader and gdcmDicomDir are meaningfull)
1964 2004-03-22 Benoit Regrain
1965 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1966 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1967 gdcmSerie to gdcmDicomDirSerie
1969 2004-03-19 Jean-Pierre Roux
1970 * ENH Now the tree-like structure describing a DICOMDIR comming from
1971 an already existing DICOMDIR file is consistent with
1972 the home-made tree-like structure build ex-nihilo
1973 or build from the files held (recursively) in a Directory
1974 functions gdcmDicomDir::CheckBoundaries()
1975 gdcmObject::SetBoundaries() added
1977 2004-03-17 Jean-Pierre Roux
1978 * REM (Eric Boix bug) : removal of meaningless
1979 gdcmDicomDirImage::NewImage function.
1980 * FIX now file names and directory name are written properly in the
1982 * FIX now gdcmDicomDir constructor may be call without any trick
1985 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1987 of gdcmDicomDirImage::NewImage as empty function.
1989 2004-02-28 Jean-Pierre Roux
1990 * ENH add gdcmDicomDir:NewPatient
1991 add gdcmDicomDirPatient:NewStudy
1992 add gdcmDicomDirStudy:NewSerie
1993 add gdcmDicomDirSerie:NewImage
1994 to allow making gdcDicomDir object.
1995 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1996 (as opposite to the gdcmHeader chained list)
1998 2004-02-11 Benoit Regrain
1999 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2000 when using from python
2002 2004-02-10 Benoit Regrain
2003 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2004 * FIX : in gdcmDicomDir when the directory is empty
2005 * ENH : add callback and methods to get the progression of dicomDir
2008 2004-02-06 Jean-Pierre Roux
2009 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2010 - GDCM_META added to gdcmDicomDirType
2011 - class gdcmMeta created
2012 * ENH : - A brief summary is now displayed at the beginning of
2013 'testDicomDir' to help disaster magnitude estimation
2014 * REM : Now useless Test/explDICOMDIR.cxx
2016 2004-02-05 Benoit Regrain
2017 * ENH : add methods in gdcmObject to get the hash table or the list of
2019 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2020 * FIX : wrapping python for TagHeaderEntryHT
2022 2004-02-04 Benoit Regrain
2023 * FIX : even length for some strings when writting the dicom dir
2024 * FIX : sort the images in the dicom dir
2025 * FIX : Bug fix for python use of dicom dir
2026 * ADD : a python demo
2028 2004-02-04 Jean-Pierre Roux
2029 * FIX : Final solution (?) for icone embedded images
2030 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2031 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2032 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2033 gdcmData/gdcm-MR-SIEMENS-16.acr1
2034 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2035 to make full checking easier
2037 2004-02-04 Benoit Regrain
2038 * FIX : WriteEntries : coding style & logic in parameters
2039 * FIX : Set the elements to create the DicomDir in a dictionary file
2041 2004-02-03 Benoit Regrain
2042 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2043 * gdcmDicomDir : add the load of directory
2044 * Bug fix and print add-on
2046 2004-02-03 Jean-Pierre Roux
2047 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2048 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2049 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2050 * FIX gdcmParser.cxx : 'group length' elements are now considered
2051 as integers, even for shadow groups, when file is Implicit VR
2053 2004-02-02 Jean-Pierre Roux
2054 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2056 of the last synonym :-(
2057 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2059 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2060 * FIX taking into account the possible 7fe0,0010 multiplicity
2061 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2062 to allow removal of references to 7fe0,0010, to deal with
2063 ACR-NEMA images, when 0028,0200 is meaningfull
2065 2004-01-31 Jean-Pierre Roux
2066 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2067 no longer writes 'Un' on disk
2068 * FIX SQ elements with actual length are now dealt with corectly
2069 * FIX gdcmFile::WriteBase make the difference, for color images, between
2070 the length (for Palette expanded images)
2071 and Raw Length (non expanded image + Palette)
2072 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2073 (that broke Write). Replaced by UL.
2074 Aware user will reload the field if he
2075 thinks it's necesssary
2077 2004-01-30 Jean-Pierre Roux
2078 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2079 when 'dirty Acr' is found, to be compliant with the new
2080 IsReadable() methods.
2082 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2083 (no DOUBLE images in kosher DICOM,
2084 but so usefull for people that miss them ;-)
2086 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2087 DICOMDIR related utilities (not checked as Windoze compliant)
2089 2004-01-28 Jean-Pierre Roux
2090 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2092 2004-01-27 Jean-Pierre Roux
2093 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2094 to allow skipping the shadow elements, to save memory space.
2095 The TRUE value for this param has to be used
2096 with a FALSE value for the 'enable_sequence' param.
2097 ('public elements' may be embedded in 'shadow Sequences')
2098 * gdcmHeader methods now deal with 'embedded icones images' in the header
2099 (even when an 'icone image sequence' is announced by the
2100 element (0x0088,0x0200), but there is NO icone at all ...
2102 * gdcmHeader sometimes Image Location value doesn't follow
2103 the supposed processor endianity (see gdcmData/cr172241.dcm).
2106 * gdcmHeader add the method
2107 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2108 to get *all* the Header Entries with the same tag.
2109 GetHeaderEntrySameName is probabely *useless*
2110 (no meaning : Name is *not* an identifier within the Dictionary)
2112 2004-01-26 Benoit Regrain
2113 * Bug fix in the print of hexadecimal representations. Remove long fields
2114 in the print and add a third level of print to print them
2116 2004-01-23 Benoit Regrain
2117 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2118 * Bug fix on test suite after remove the strip made on not string fields
2119 * Split the IsReadable method between gdcmParser which test that the file
2120 is dicom and gdcmHeader which test that it's an image file
2122 2004-01-22 Benoit Regrain
2123 * DicomDir : clean code, add methods, set variables in protected or private
2124 * gdcmUtil : bug fix for the clean string method
2126 2004-01-19 Benoit Regrain
2127 * Add the use of shadow dictionaries
2128 * bug fix and coding style
2130 2004-01-19 Benoit Regrain
2131 * src/gdcmFile.cxx : bug fix concerning the close of file
2132 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2133 * Add the update of header entries using the shadow library
2135 2004-01-19 Benoit Regrain
2136 * removal of file gdcmHeader2.cxx
2137 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2138 inheriting from gdcmParser. This split is to prepare the integration
2139 of dicom dir parsing
2140 * bug fix under python
2142 2004-01-16 Jean-Pierre Roux
2143 * REM removal of class gdcmHeaderEntrySet
2144 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2145 * ADD add file gdcmHeader2.cxx
2146 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2148 2004-01-15 Benoit Regrain
2149 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2150 entries created while parsing the header. Thus, they will be destroyed
2151 when the gdcmDictSet will be destroyed
2152 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2155 2004-01-15 Benoit Regrain
2156 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2157 made a fatal error because of the memory release at the end of program.
2158 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2159 some memory and vtk seems to have some problems with that.
2160 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2162 2004-01-14 Benoit Regrain
2163 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2164 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2165 * src/*.[h|cxx] : make changes due to class name changes
2166 * gdcmPython/demo/*.py : bug fix due to method names
2168 2004-01-13 Benoit Regrain
2169 * src/*.[h|cxx] : coding style
2170 * vtk/*.[h|cxx] : coding style
2172 2004-01-13 Benoit Regrain
2173 * gdcmPython/testSuite.py : test the readable flag of file for tests
2174 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2175 It's lied to the stl compilation by MSVC (windows, always windows...)
2176 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2178 2004-01-12 Benoit Regrain
2179 * src/*.h : add comments
2180 * src/gdcmDictSet.h : set the method BuildDictPath in public
2181 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2182 directly setted in the source code
2183 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2186 2004-01-09 Benoit Regrain
2187 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2188 * setup.py : use a reference to gdcmVERSION
2190 2004-01-07 Benoit Regrain
2191 * Modification to compile with the distutils.
2194 2003-12-10 Benoit Regrain
2195 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2196 can use a gdcmHeaderHelper to load data
2197 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2198 made in the source code
2200 2003-12-10 Benoit Regrain
2201 * Update Windows projects and .cvsignore files
2203 2003-11-12 Jean-Pierre Roux
2204 * ENH gdcmHeader constructor has one more parameter (default value : false)
2205 that allows the user to 'go inside' the SeQuences only
2207 gdcmElValSet:Print takes it into account
2209 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2210 * ENH: Update gdcmPython/CMakeLists
2211 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2212 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2214 2003-11-10 Jean-Pierre Roux
2215 * FIX : gdcmHeader::LoadElements is now based
2216 on the ListTag listElem member,
2217 not longer on the TagElValueHT tagHt member
2218 * ENH : PrintPubElVal shows (temporarily) both results,
2219 with the tagHt member and the listElem member.
2220 (it's easier to 'see' the problems when using Printheader)
2222 * FIX : old private member LgrElem is now splitted into
2223 ReadLength : Length actually found on disk (updated only
2224 if bug fixing is necessary), for internal
2226 UsableLength : Updated by FixFoundLength, to fix a bug
2227 or to allow Parser going on.
2228 Will allow to re-write a kosher header when a SeQuence
2229 with a length (not 0000) is found
2230 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2231 because gdcmElValSet::Add does not update ListElem
2234 2003-11-07 Jean-Pierre Roux
2235 * FIX misstyping in Transfert Syntax name table
2236 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2237 when they have an actual length (not 0000 nor FFFFF)
2238 (Nobody should care of it, but DICOMDIR explorers)
2240 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2241 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2243 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2244 * ENH: vtkGdcmReader now supports LUT !
2245 (vtkgdcmViewer for now is not able to use them though)
2247 2003-11-05 Jean-Pierre Roux
2248 * in testSuite.py : new files names for checking the package
2249 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2250 that returns the pixel area size to the *aware* (vtk) user
2251 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2253 2003-11-05 Benoit Regrain
2254 * in testSuite.py : Modify the rules for checking the paths
2255 : Explicit error messages
2256 * in __init__.py : Related modif
2258 2003-11-03 Jean-Pierre Roux
2259 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2260 to be used by aware (vtk) users that want to manage
2261 LUT (and no to turn the PALETTE image into an RGB pixels one)
2262 * GetPixelType now returns 8U for 24 Bits images
2263 (vtkGdcmReader compliant)
2265 2003-10-31 Jean-Pierre Roux
2266 * Removal of *all* gdcmData images and add them again
2267 in order to loose the 'history' of un-anonymised images
2269 2003-10-31 Jean-Pierre Roux
2270 * RMV : removal of useless jBitsInJsample.h
2271 for both 8 and 12 Bits JPEG Lossy Libraries
2273 2003-10-31 Jean-Pierre Roux
2274 * ENH : Add the functions gdcmFile::GetImageDataRaw
2275 gdcmFile::GetImageDataIntoVectorRaw
2276 that act as GetImageData and GetImageDataIntoVector
2277 except the making of an RGB Plane from Gray Plane + LUT
2278 Intended to aware (vtk) users who know how to manage
2281 GetLUTRGBA return a R,G,B,A LUT if any
2282 lgrTotaleRaw gives the 'Raw' length
2283 GetImageDataRaw returns the gray Plane
2284 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2285 (They stay Grey, just like with other Dicom viewers :-(
2287 2003-10-30 Jean-Pierre Roux
2288 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2290 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2291 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2292 being coherents dicom files.
2294 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2295 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2297 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2298 * ENH: Two steps is necessary to please VC++ compiler...
2299 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2300 * ENH: Add include dir to medcon lib
2301 * FIX: only one function is being exported for now !
2302 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2304 2003-10-29 Jean-Pierre Roux
2305 * adding gdcmHeader::GetLUTRGBA
2306 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2307 --> Mathieu, the modif u're waiting for is not yet committed
2308 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2310 2003-10-27 Jean-Pierre Roux
2311 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2312 00191113.dcm DermaColorLossLess.dcm
2313 MxTwinLossLess.dcm RadBWLossLess.dcm
2314 * ENH: For version prior to vtkImageViewer2 -r 1.19
2315 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2317 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2318 * Removal of ido stuff in CMakeLists.txt
2320 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2322 * FIX: remove a call to ->Modified ... see comments
2323 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2325 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2326 * FIX: Problem with path for libvtkgdcmPython
2327 * ENH: Try adding a search script for python site-package
2328 * RMV: Remove some file from medcon lib that are not necessary
2329 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2330 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2331 * FIX: More pragma disable fro VC++,
2332 I don't think I break something as it is also disable in VTK/ITK.
2333 But it fasten debug compilation time.
2335 2003-10-23 Jean-Pierre Roux
2336 * gdcm now deals with 16 Bits Run Length Encoded images
2337 (they are compressed as 2 planes images,
2338 one for the high Bytes, the other for low Bytes)
2340 2003-10-22 Jean-Pierre Roux
2341 * Now CheckRead takes into account :
2342 - the bugged 'Leonardo' Siemens images
2343 - the XA images, sent thru the burning VPRO station
2344 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2347 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2348 * FIX: When copying a Makefile.am to CMakeLists.txt
2349 one should remove the '\'
2351 2003-10-22 Jean-Pierre Roux
2352 * in gdcmData adding a bugged 'Leonardo' Siemens image
2353 (wrong lengths in header)
2354 OK with gdcm, KO with the other viewers :-)
2355 * add a GE dlx XA image, thru the VEPRO burning station
2358 2003-10-21 Jean-Pierre Roux
2359 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2360 for a brutal checking of vtkgdcmViewer compliance
2362 2003-10-21 Jean-Pierre Roux
2363 * add the files for 'xmedcon' Jpeg Lossless library
2364 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2366 2003-10-21 Jean-Pierre Roux
2367 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2369 2003-10-21 Jean-Pierre Roux
2370 * garbage Siemens 'Leonardo' images dealt with
2371 (the patch is easy to remove)
2372 * cosmetic changes to avoid warnings
2374 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2376 no need to press 'r' now.
2378 2003-10-20 Jean-Pierre Roux
2379 * upgrade of checkRead.sh checkWrite.sh according
2380 to new Jpeg Lossless decompressor
2381 * add US.3405.1.dcm, a genuine RGB medical file ...
2382 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2383 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2385 2003-10-15 Jean-Pierre Roux
2386 * general anonymisation in gdcmData
2387 * adding the 'color files' from
2388 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2389 * adding some well knowed bugged-header images
2390 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2391 waiting for their inclusion in Python testsuite
2393 2003-10-15 Jean-Pierre Roux
2394 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2395 no longer seg faults when file is not found
2397 2003-10-14 Jean-Pierre Roux
2398 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2401 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2402 * TODO: *.in file to genereate a UseGDCM later
2404 2003-10-14 Jean-Pierre Roux
2405 * Some supposed-to-be Dicom Images have no preamble.
2406 OpenFile takes it into account
2407 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2408 * Missing elements added in dicomV3.dic
2409 (just to be affraid : have a look at
2410 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2411 and do it again next year ;->
2413 2003-10-13 Jean-Pierre Roux
2414 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2415 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2416 But there are NOT. It's fixed !
2418 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * FIX: "jpeglib.h" was not found on VC++
2420 * FIX: vtkgdcm was not being installed
2422 2003-10-10 Jean-Pierre Roux
2423 * ENH : OpenFile closes the file if it *really* doesn't look like
2424 an ACR-NEMA / DICOM one.
2425 * FIX : testWrite no longer writes an empty file if the source file
2426 is not gdcm Readable
2427 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2430 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2431 * FIX: CMake generate now documentation
2432 * ENH: out of source doc build !
2433 * ENH: Generate both user and dev documentation
2434 * ENH: Should work on windows too
2435 * ENH: Only one doxygen config.in file is needed
2436 * FIX: make install should be ok now on ùnix plateform
2437 * FIX: PATH to dictionary was wrong (missing /)
2438 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2440 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2441 * vtkGdcmReader is now able to read rgb dicom file.
2442 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2443 * added a gdcmViewer to vtk test, use mouse to control
2444 window level & window width
2446 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2447 * CMake-ification of gdcm, we have now two build system
2448 * FIX: on cygwin Wsock32 doesn't exist
2449 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2451 2003-10-06 Emanuel Ollart
2452 * FIX : compilation process wad broken.
2453 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2455 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2456 * change gdcmViewer -> vtkgdcmViewer
2457 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2459 2003-10-06 Jean-Pierre Roux
2460 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2461 ( e.g : well known GE images with a wrong elem length,
2462 : Philips MRI Images with a wrong Huffman table)
2463 * still to be done : allow the reading of bugged LEONARDO Siemens images
2465 2003-10-03 Jean-Pierre Roux
2466 * Odd length strings are padded with '\0' (not with spaces,
2467 to remain compliant with already defined strings,
2468 like Transfert Syntax UID and others)
2470 2003-10-03 Jean-Pierre Roux
2471 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2472 to allow displaying RGB images (not only by affim ;-)
2474 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2475 * vtkGdcmReader is now able to read rgb dicom file.
2476 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2478 2003-10-03 Jean-Pierre Roux
2479 * A few nasty patches to allow the reading of a lot of nasty images
2480 ( e.g : well known GE images with a wrong elem length,
2481 : Philips MRI Images with a wrong Huffman table)
2482 * still to be done : allow the reading of bugged LEONARDO Siemens images
2484 2003-10-03 Jean-Pierre Roux
2485 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2487 2003-10-03 Jean-Pierre Roux
2488 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2489 to allow displaying RGB images (not only by affim ;-)
2491 2003-10-03 Jean-Pierre Roux
2492 * gdcmFile::GetImageDataIntoVector now
2493 - deals with MultiFrames MultiFragments Run Length Encoded files
2494 - deals with YcBcR (YBR_FULL) files
2495 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2496 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2498 (no sample found :-(
2500 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2501 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2502 Two reasons: - clear things
2503 - third parties acces gdcm through header files, so won't
2504 suffer anymore VC++ complains
2506 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2507 * add argv[1] in testvtkGdcmReader.cxx
2510 2003-09-24 Jean-Pierre Roux
2511 * The lines are now eigthy characters long.for
2512 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2514 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2515 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2516 char* to std::string. Thus, the use of strdup becomes useless. (see
2517 previous commis of Malaterre)
2518 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2519 before the last Malaterre's commit.
2521 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2522 * This commit should fix the Debug building under VC++, the problem
2523 was mainly a mixture of debug and release lib being loaded at startup.
2524 * I also remove a depency to a specific C function: strdup. Because I had
2525 to force the link to msvcrtd (whereas strdup is in libc).
2527 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2528 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2529 located in the gdcmCommon.h file. All use of reference of tha has been
2530 changed to now use the variable GDCM_UNFOUND.
2532 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2534 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2535 Dicom dictionary. The test suite can now be run again. Note:
2536 I'm note very happy with the " (RET)" changes. I believe this
2537 RETAINED comment should be dropped when parsing the dictionary.
2538 - PACKAGER corrected
2540 - AUTHORS updated and now in alphabetical order
2541 * Makefile.am now exports gdcm.dsw for Windoze users.
2543 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2544 * cygwin complains about missing std:: in subdir Test/
2546 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2547 * remove some methods that are now in gdcmHeaderHelper
2549 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2550 * vtkGdcmReader set spacing and origin correctly
2552 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2553 * Fix a few delete/delete[] mismatch
2555 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2556 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2557 interpretation to data given by gdcmHeader. For instance there are
2558 heuristics to get informations (look at different places).
2559 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2560 sorting DICOM images based on different strategies.
2561 * modified Makefiles accordingly.
2563 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2564 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2565 when building in debug mode
2566 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2567 src/win32/gdcmdll.dsp
2568 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2570 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2571 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2574 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2575 * src/win32/libgdcmjpeg12.dsp was not dos format
2576 * src/win32/libgdcmjpeg12.dsp :
2577 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2578 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2580 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2581 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2583 * src/gdcmFile.cxx : bug fix in affectation type
2584 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2585 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2586 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2587 symbols... future problem ?
2589 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2590 * src/win32/libgdcmijpeg12.dsp was missing
2591 * modified gdcm.dsw accordingly
2593 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2594 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2596 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2597 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2598 commit of JPR (before his hollidays to facilitate our work).
2599 * setup.py : bug fix in code. Modifications made while the last commit
2600 of JPR. The code hasn't been tested before the commit... it's so
2601 useless to make that (for best programmer that is JPR) !!!
2603 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * tagged the current version as Version0_3 (i.e. version 0.3)
2606 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2607 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2608 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2609 * *.dsp : modifications to use new libgdcmijpeg8 library
2610 * setup.py : bug fix on VTKPATH variable
2611 * PACKAGER : adding all concerning windows
2613 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2616 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2617 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2618 test suite reported error.
2619 * PACKAGER file added (describes what a packager must do when
2620 packaging a new release).
2621 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2622 * configure.in: upgraded version number to 0.3.0
2623 * fixing build of rpm (through rpm -ta):
2624 - Doc/Makefile.am exports proper doxygen files
2625 - src/jpeg/libijg8/Makefile.am exports the include files.
2627 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2628 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2629 * src/gdcmHeader.h : formatting code
2631 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2632 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2633 We were obtaining error message from vtk. Now, creation of file list
2634 is made in an internal list to prevent this problem.
2635 Bug fix when output is empty.
2636 Bug fix in update of progress value. Previous commit for this was a bad
2638 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2640 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2641 * src/gdcmHeader.h : added method to get the file name
2642 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2643 files. Added method to remove all files on the input
2644 Added FIXME comment concerning the bad parsing of header made by
2645 ExecuteInformation method (in ExecuteData method)
2647 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2649 when using make instal.
2650 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2651 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2653 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2654 * setup.py : adding include dir of jpeg lib to compile all sources
2655 * */Win32/*.dsp : JPR fix for windows compilation
2657 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2660 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2661 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2663 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * setup.py is again effective on un*x (takes into account the
2665 addon of the jpeg library)
2666 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2667 * Doc/Doxy* updated (includes above enhancements)
2668 * INSTALL now points to web documentation
2670 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * src/gdcmHeader.h doesn't make unnecessary reference to
2673 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2675 * src/gdcm*.[cxx|h] :
2676 - to allow compilation with gcc 3.x
2677 -- clean up of STL usage (added explicit usage of std::)
2678 -- small fixes on exceptions.
2679 Note: linking not tested !
2680 - clean of doxygen comments to avoid warnings at documentation
2682 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2683 dependent convertion).
2685 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * Clean up of previous JPR garbage commit (not even commented in the
2688 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2689 - moved all jpeg related files from src to src/jpeg/libijg8, with
2690 addition/modification of Makefile.am and configure.in.
2691 - the testSuite is still brain damage (not guilty).
2693 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2694 * WrapVTK.py : modifications to get correctly vtk source files to
2696 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2697 (FileName -> Filename)
2699 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * vtk/vtkGdcmReader.[cxx/h]:
2701 - UpdateProgress method should now be effective
2702 - removed the limitation on having only images loaded (as opposed
2704 - when building a stack of images/volume, a lesser number of
2705 gdcmHeader and gdcmFile instances should be used (hopefully
2706 accelerating things).
2707 - when building a stack of images/volumes, files which are not
2708 loadable (wrong path-filename, wrong permissions on existing file,
2709 or file not parsable by gdcm) are replaced with a black image
2710 in the stack (for the caller to notice the problem).
2712 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2715 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2717 between standard library (std) and vtk library (problems are found
2718 under Windows... thanks Windows !)
2720 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2723 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2725 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2728 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * When compiling with distutils (see setup.py) the C++ compiler is
2730 called with different flags than the default ones (with automake).
2731 In order to fix all those warning, I compiled gdcm with the command
2732 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2733 and went for warning fixes:
2734 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2735 up from unused variables.
2736 - vtk/vtkGdcmReader.cxx: potential bug fix.
2737 * src/gdcmHeader.h: Doxygen warning cleanup
2739 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * gdcmPython/gdcm.i:
2741 - typemaps correction to take into account the systematic replacement
2742 of "using namespace std" with std:: prefix e.g. std::list,
2743 std::string... (cf changes of 2003-05-21).
2744 - gdcmGlob global variable of type gdcmGlobal (defined in
2745 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2746 exported to Python a as cvar.
2747 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2748 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2749 gdcmDictSet.GetPubDictTagNames() and
2750 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2751 C++ static methods).
2752 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2753 with the above changes.
2755 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2756 * setup.py, manifest.in : bug fix under linux
2758 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2759 * Modification of setup.py to compile vtk part too. Then, we have 2
2760 wrappers which must work with same distutils. For that, we have a
2761 generic distutils in distusiltsWrapping.py ; with :
2762 - build_extWrap class to wrap generically all extensions,
2763 - ExtensionWrap base class for all wrapping extension that contains
2765 - Wrapper interface which wrap sources
2766 + In WrapSwig.py we have extension and wrapper for Swig
2767 + In WrapVTK.py we have extension and wrapper for VTK
2768 * MANIFEST.in : modifications to consider vtk directory and new python
2769 files for compilation
2771 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2772 * Added python wrappers of vtkGdcmReader vtk class (see the
2773 source in vtk/vtkGdcmReader.cxx) :
2774 - vtk/Makefile.am now builds a library
2775 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2776 python library (as opposed to _gdcm.so wich are the python
2777 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2778 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2780 - configure.in has an additional flag --enable-vtk that needs
2781 to be set to enable compilation of vtk related code, that is:
2782 + vtk/vtkGdcmReader.so and
2783 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2784 + gdcmPython/vtkgdcmPython.so (see above)
2785 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2786 be read when compressed or when HighBit + 1 != BitsStored),
2787 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2788 the usage of the python wrapper of vtkGdcmReader vtk class.
2789 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2790 * src/*.[h] all occurences of stl classes are now prefixed with
2791 std::, and all occurences of "using namespace std;" where removed.
2792 This is to avoid pollution of global namespace in included files.
2793 Apparently vtk does not avoid this pitfall: when using both
2794 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2795 collision of various stl members (principally cout...).
2796 * gdcmPython/testSuite.py now cleanly removes temprory generated
2798 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2799 comply with above changes)
2801 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2802 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2803 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2804 vtk data structure (an image Flip was required).
2805 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2806 * cosmetic changes in documentation.
2808 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2809 * src/gdcmHeader.cxx: the constructor no longer exits when an
2810 unexisting file is given as argument.
2811 * The subdirectory Data (containing all the images used for the
2812 test suite) is not part of this repository anymore. A new module
2813 containing those images is now available at
2814 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2815 with the name gdcmData.
2816 All the python scripts (including the package initialisation file
2817 gdcmPython/__init__.py) were adapated to take this change into
2818 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2820 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2821 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2822 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2823 demo of the usage of this class.
2824 Compilation of this vtk part is only done when using the --enable-vtk
2825 at configure (or autogen.sh) stage.
2827 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2828 * More memory link related corrections and documentation fixes.
2830 - maximum info is obtained with a command of the form:
2831 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2832 --show-reachable=yes PrintHeader
2833 - the remaining reachable blocks seem to come from the STL
2834 allocation scheme through the usage of map and list. It looks
2835 like this memory cannot be freed but it is not a memory leak
2836 (in fact further invocation to the STL would recollect the
2837 unused memory allthough it cannot explicitely be freed).
2838 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2839 of displaying an image parsed with gdcm and displayed with VTK.
2840 Note: some images don't seem to work e.g.
2841 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2842 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2843 Allthough this weakens the semantics, it is a ditch attempt to
2844 make gdcm more thread friendly.
2846 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2847 * Memory link hunt (by using valgrind through the command
2848 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2849 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2850 gdcmHeader::_dicom_vr.
2851 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2852 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2854 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2856 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2857 * src/Makefile.am now exports all the necessary include files at
2861 * UpdateGroupLength replaced by new one
2864 * UpdateGroupLength re-written using H-Table
2865 (named UpdateGroupLengthNew untill checks are over)
2867 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2868 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2869 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2871 - gdcmHeader::GetPubElValSet removed.
2872 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2873 UpdateGroupLength, WriteElements, Write.
2874 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2875 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2876 carried the same semantics.
2877 - src/gdcmHeaderIdo.cxx changed accordingly.
2878 - gdcmFile::WriteBase now regroups all the codes from previous
2879 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2880 - enum FileType moved to gdcmCommon.h
2881 * src/gdcmHeader.cxx AddDefault trashed
2882 * gdcmGetXSize added
2883 * getimageDataSize now calls gdcmGetXSize
2884 * Test/*.cxx changed to agree with above changes
2886 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2888 (to avoid double call by end user).
2889 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2890 by end user, since gdcmHeader::gdcmHeader now handles it.
2892 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2893 * gdcm/Doc many doxygen changes:
2894 - Doxyfile now has two different versions, DoxyfileUsers that generates
2895 the html.users end users oriented documentation and
2896 DoxyfileDeveloppers that generates the html.developper developper
2897 oriented documentation.
2898 - README changed accordingly
2899 - requirement.txt removed (old design info moved to TODO).
2900 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2901 DoxyMainPage.txt, DoxyPython.txt provide more information.
2902 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2903 be updated by simply regenerating the docs with doxygen and copying
2904 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2905 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2906 all the tests in the form "if (<map>.count() >1)" were removed.
2907 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2908 ill-formed documentation sections.
2909 * src/gdcmHeader.cxx: ditto
2911 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2912 * setup.py fixed for un*x (needed macro for stdint.h)
2913 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2914 un*ces with sh-utils test utility.
2915 * gdcmPython/demo/test.py renamed to PrintHeader.py
2916 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2917 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2918 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2919 * src/gdcm*.cxx JPR's bad inclusion fixed.
2921 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2923 * gdcmPython/demo/test.py changed accordingly.
2925 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2926 * gdcmPython/Makefile.am fixed linking against libstdc++
2927 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2928 * Swig subdir (historical tests of swig version 1.3.17++) removed
2929 * Test/testChangeEntete.cxx some lines commented out in order to make
2931 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2932 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2934 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2935 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2936 hence the user doesn't need this explicit call.
2937 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2938 i.e. LoadElements() call removed.
2939 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2940 - src/Makefile.am declares the proper flag for g++.
2941 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2942 for adding user defined new tags.
2943 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2944 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2945 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2947 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2948 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2949 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2950 src/Makefile.am : the project should properly compile and install
2951 with the autotools, included the python wrappers part.
2952 * gdcm.spec.in : added a spec file for RPM packaging.
2954 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2955 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2957 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2959 to exported to the environement (see gdcmPython/testSuite.py
2961 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2962 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2963 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2964 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2965 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2967 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2968 * gdcmPython/__init__.py doesn't crash anymore when running in
2969 in InstallMode or PreInstallMode but with an environment given
2970 value of GDCM_DICT_PATH.
2971 * src/gdcmDictSet.[cxx/h] coding style.
2973 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2974 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2975 * src/gdcm.h general comments moved to TODO, and README
2976 * src/gdcm.h should now be seen as a user commodity (including it
2977 should suffice to fully use gdcm). It is nowhere including within
2978 any of the kernel files src/*.cxx and src/*.h.
2980 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2981 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2982 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2984 * src/gdcm*.cxx only include their corresponding include file
2985 (as opposed to gdcm.h)
2986 * gdcmPython/gdcm.i changed accordingly
2987 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2988 the autogen.sh generated "make snapshot" command to work.
2989 * autogen.sh removed history related references to crea package.
2991 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * distutilsSwigCPlusPlus.py work around some swig portability
2995 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2996 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2997 was done in a last ditch attempt to get setup.py _really_
2998 operationnal. The python/gdcmPython layaout add the advantage
2999 of hidding away the python related distutils specific files
3000 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3001 Alas, the src directory was out of scope (i.e. it's relative
3002 position to setup.py was ../src) which made things impossible to
3003 handle (see previous version of python/setup.py). Crossing fingers...
3005 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * python/setup.py now works on Un*x. (harder than I thougth)
3007 * python/distutilsSwigCPlusPlus.py can now have include files
3008 among the list of sources.
3010 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3011 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3012 * modifications in MSVC projects
3014 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * As stated by the first lines of Test/ExceptionAndPython/README, it
3016 looks like we can move back to original usage of exception within
3017 src/gdcm* and hence remove the errno stuff that was introduced
3018 as a quick and dirty fixture of this problem (added to the TODO).
3019 * Doc/Doxyfile configuration file for Doxygen and corresponding
3020 README file for usage added.
3021 * Test/testWrite.cxx added. This new test comes from a split of
3022 test.cxx that is now reverted to its original purpous i.e.
3023 testing the proper parsing of a Dicom related file.
3024 testWrite.cxx concentrates on testing the IO part of gdcm.
3025 * Test/bug1.cxx (containing a bug on WIn32) added.
3026 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3027 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3028 whose purpose is to publish the content of the TagNames of the
3029 Dicom public dictionary were not accessible without an
3030 instance of class gdcmHeader.
3031 - those methods are now static methods of gdcmDictSet and hence
3032 require no instances at all to be invocated.
3033 - within gdcmDictSet this change required to change some method
3034 to class methods (i.e. are now static) among which SetDictPath
3035 (renamed to BuildDictPath) and LoadDefaultPubDict.
3036 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3037 the above changes by calling the new method classes of gdcmDictSet.
3038 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3039 the above to be effective.
3040 * python/gdcmPython: in order to wrap properly the above changes
3041 for Python, swig version now needs to be > 1.3.17.
3042 * python/gdcmPython/Makefile fixed to adapt itself to new
3043 configure/make shema introduced by Johan Montagnat (thanks for the
3044 contribution). Alas this Makefile cannot be turned into a proper
3045 Makefile.am without some heavy changes in the configure.in
3046 (for python dectection).
3047 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3048 now avoids publishing the empty entries.
3050 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3051 * python/setup.py : bug fix concerning install under windows
3052 ExtraPath reused :-P
3053 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3055 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3056 * Dicts/dicomV3.dic : remove double spaces !!!
3057 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3058 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3061 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3062 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3063 method. Doxygenation.
3064 * src/gdcm.h clean up of JPR spurious comments.
3066 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * python/distutilsSwigCPlusPlus.py now properly collects the
3068 shadow classes generated by "swig -c++" (gdcm.py in our case)
3069 when using "python setup.py install".
3070 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3071 reexports the working classes.
3072 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3073 by the classical C errno scheme. This is to prevent an obscure
3074 behavior of the python wrappers when importing wxPython.wx prior
3075 to gdcmPython (which ended up in an abort call). An illustration
3076 of this oddity can be found in the Test/ExceptionAndPython
3077 subdir (see the README file). This problem probably due to
3078 an combination of g++ and dynamic loading.
3079 * added Test/ExceptionAndPython (see above)
3081 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3082 * Changed the layout of the python part to avoid bloating main
3083 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3084 i.e. the distutils arsenal. All the python related stuff is
3085 again in a python subdir, but the package itself is now in
3087 * setup.py was cleaned up:
3088 - pythonIncludePath removed
3089 - python setup.py bdist target is now functional.
3090 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3091 collision with other packages). gdcmPython/demo/*.py changed
3094 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * python subdir moved to gdcmPython (preparation of distutils packaging).
3096 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3097 distutils installer is operational.
3098 * - gdcmPython/__init__.py now properly loads the swig generated
3099 shadow classes (from gdcm.py).
3100 - gdcmPython/demo/*.py changed to import the package gdcmPython
3101 instead of gdcmPython/demo/load.py.
3102 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3104 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3105 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3106 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3107 entries within the associated public Dicom dictionary resp. the same
3108 information but sorted by the fourth field (PAT, IMG, DIR) of the
3110 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
3111 are now in the "???" group.
3112 - python/gdcm.i changed accordingly,
3113 - python/demo/printGroupedPublicDict.py added, that gives an example
3114 of the above new functionalities in Python.
3116 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3117 * src/gdcm.h, gdcmHeader.cxx:
3118 - historic references to glib's g_malloc and g_free (#defined)
3119 were definitively removed.
3120 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3121 * src/gdcmElValSet.cxx:
3122 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3123 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3124 - GetElValue(string) renamed to GetElValueByName.
3125 - Added GetElementByName(string).
3126 * src/gdcmHeader.cxx: added
3127 - GetPubElValRepByNumber(guint16, guint16)
3128 - GetPubElValRepByName(string)
3129 - GetShaElValRepByNumber(guint16, guint16)
3130 - GetShaElValRepByName(string)
3131 - GetShaElValByNumber(guint16, guint16)
3132 - GetShaElValRepByName(string)
3133 - GetElValRepByNumber(guint16, guint16)
3134 - GetElValRepByName(string)
3135 - GetElValByNumber(guint16, guint16)
3136 - GetElValRepByName(string)
3137 * Doc/requirements.txt added.
3139 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3140 * Test/Makefile building now depends on the one of libgdcm.so
3141 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3142 pixel data) aware which enables finding the address (offset) of
3143 the pixel data of JPEG encoded DICOM files. This leaves only a single
3144 file in the testSuite whose pixel data address (offset) is unknown.
3145 * python/testSuite.py changed accordingly.
3147 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3148 * VC++ has some strong limitations when working with the STL, as stated
3149 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3150 "Also note that some STL containers (map, set, queue, list, deque)
3151 cannot be exported. [...]
3152 Some STL classes contain nested classes. These classes can not
3154 This is caused by a designed limitation that once a template
3155 class is instantiated, it can not be re-instantiated and
3157 Since our usage of map<> is ubiquitous in gdcm, this "designed
3158 limitation" of VC++ is a pitfall.
3159 Hence the Python wrappers of gdcm cannot be incrementally linked
3160 against the c++ dynamic library. The dirty but only workaround is
3161 to forget about incremental link of dynamic libraries and to generate
3162 the Python wrappers library with the inclusions of the underlying C++
3164 The following modifications concern this matter on Win32/VC++:
3165 - wrapping python correct with standalone wrapped dll (don't use separate
3166 dll under windows !!!!)
3167 - python21_d debug mode enabled (ask Frog how to use it :-)
3168 - NO problem with having an STL member of class for example string in C++
3169 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3170 - Python test of dcmlib in Python is ok under windows on a large set
3172 * removed glib references
3173 * typedef's inserted in gdcm.i for correct swig type management
3175 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3176 * python/demo/*.py load.py extracted from test.py. Added explore.py
3177 that only displays required tags and testAll.py that parses all
3178 the files of the testsuite without using unittest.
3179 * python/testSuite.py other additional test on new files added.
3180 * Data/* new test files added accordingly to the testSuite.
3181 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3182 the vr in the file differs from the one of the dictionary.
3184 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3185 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3186 values, but limits itself to values which are below a user specified
3187 size (by default 1024 bytes).
3188 * python/gdcm.i : elements not loaded (because their size is above the
3189 user specified treshold) are exported with their TagKey as key of the
3190 python dictionary. This enables the testsuite to make some checks
3191 on the unloaded elements (since we have their offset and size).
3192 * python/testSuite.py
3193 - now tests for the existence and proper value of the pixel data
3194 - two new examples added.
3195 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3197 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3198 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3199 aware. See the strategy comments in gdcmHeader::FindeLength().
3200 * Test/test.cxx now accepts a filename as first argument.
3201 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3202 * python/testSuite.py changed to integrate test on above files.
3204 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3205 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3206 the vr was also RET.
3207 * python/testSuite.py more tests added.
3209 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3210 * python/testSuite.py unittest test suite added (uses Data)
3211 * Data/* dcm and acr files for the test suite.
3212 * glib dependance removed from un*x version. We now use ISO C99
3213 7.18 Integer types (see stdint.h)
3214 - python/Makefile, src/Makefile src/gdcm.h
3215 * src/ when an explicit vr (like dicom files) suddenly poped an
3216 implicit element we use to mark the underlying DictEntry of the
3217 concerned ElValue with "Implicit". This strategy was damageable
3218 too the public or provite dictionaries, since some of their vr
3219 would be changed. Since Header::FindLength heavily relies on the
3220 detection by Header::FindVR of falsely explicit elements, I
3221 added an extra ImplicitVr member to ElValue (boolean).
3222 The rest of the changes we the necessary adaptations.
3224 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3225 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3227 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3229 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3230 * Adaptation for porting to VC++:
3232 o forced to use std namespace (for string to be known)
3233 o all class use __declspec export style on WIN32
3234 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3235 (in stdlib.h on Win32 but in std:: for gcc)
3236 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3237 variable GDCM_DICT_PATH.
3238 * src/gdcmHeader.cxx verbose comments made discrete.
3240 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3241 * python/gdcm.i: added a typemap that converts a C++ hashing table
3242 to native Python dictionary.
3243 * python/demo/test.py:
3244 - now uses the native dictionary for exploration of gdcmHeader.
3245 - takes an optional filename argument (the file to parse).
3246 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3247 PubElVals hashing table.
3248 * Dicts/dicomV3.dic removed error prone trailing spaces.
3250 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3251 * Python wrapping process moved away from src/Makefile to
3252 newly created python/Makefile (as well as gdcm.i)
3253 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3254 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3255 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3256 from the environement variable GDCM_DICT_PATH (when existing).
3257 * src/gdcmDict::GetTag bug fix.
3259 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3260 * Straightforward temporary fixes for swig to build the python wrappers.
3261 src/Makefile now has a python working entry [by working we mean
3262 that we can import de shadow classes without errors].
3264 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * hashtest.cxx removed (since already in Test)
3266 * src/gdcmlib.h renamed to src/gdcm.h
3267 * src/dcm.i renamed to src/gdcm.i
3268 * src/Makefile prepared for python wrapping
3270 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * src/gdcmHeader.cxx :
3272 - Parsing of header is now separated from loading of element values
3273 (see gdcmHeader::LoadElements).
3274 - general clean up of hopefully all file access (creation of
3275 ReadInt16 and ReadInt32)
3277 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * src/gdcmHeader.cxx :
3279 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3281 - SetLgrElem renamed to SetLength
3282 - GetLgrElem renamed to GetLength
3283 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3284 * src/gdcmElValSet.cxx fixed both GetElValue methods
3285 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3286 due to IdoDude was cleaned out.
3288 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3289 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3290 concentrates on finding the value representation (when it exists).
3291 RecupLgr now only finds the element value length, and it avoids
3292 returning the unecessary skL (skipped length).
3293 Also, offsetCourant was simply removed (with taille_fich) since
3294 it was redundant with the File position internals (by using
3295 ftell and fseek). This also made skL (see above in RecupLgr) usage
3297 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3298 on the libido specificities which are handled through class
3300 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3303 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3304 * Truckload of changes. Parsing of header is barely functional
3305 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3307 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcmHeader.cxx many addons of low level methods
3310 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3312 and _IdDcmSWAP_LONG.
3314 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * This corresponds to all the changes decided at the meeting of
3316 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob