1 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * FIX : First entry following group 0002 was lost for
3 Explicit Big Endian Transfer Syntax files
4 (group and elem not swaped)
6 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
7 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
8 Big Endian Transfer Syntax supposed the group following 0002
9 begins always by element 0000 (element 0000 is *optional*)
10 To avoid further troubles, let's be pessimistic, and use
11 Document::HandleOutOfGroup0002() method
12 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
13 (related pb not yet solved)
15 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Bug fix for the python part use
17 * Now, PrintHeader.py pass... but outside the ctest use. shit !
19 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
22 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
24 a string and should ask the global TS dict what are the propreties of
27 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
28 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
29 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
30 to swap the Swap Code, at parsing time, when we come out of group 0002
31 and Transfer Syntax is Big Endian
32 We should be able to read now 'true DICOM" Big Endian coded images
33 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
34 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
36 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
37 * Hopefully fix the bug on MacOSX and static global initialization.
38 This is the only -minor- patch I found that both please MacOSX and VS6.
39 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
40 but this would require a lot of change. Another approach would be that Global
41 create those string and GDCM_UNFOUND becomes a pointer to a string (which
42 gdcm::Global would destroy at exit).
44 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Fix bug on MacOSX with static initialization in a multy threaded
46 environment. static const string in a header file used to be ill
47 initialized provoquing the freeze of any tests. patch should solve this
50 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
51 * According to Benoit's suggestion, and without any objection from anybody
52 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
53 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
54 - method gdcmDicomDirObject::GetEntry() renamed as
55 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
57 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
58 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
59 you debug/warning message just as c++ streams which make them very convinient
60 to use. Once this is stabilize I will change the ostringstrem to be
61 redirected to a file (ofstream).
62 * Properly support C99 extension: __FUNCTION__ which allow us to display
63 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
65 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
66 * Removal of useless and dangerous methods :
67 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
68 GetDocEntryByName, GetEntryByName, GetDictEntryByName
69 * Removal of usless methods :
70 Dict::PrintByName, Dict::GetDictEntryByName
71 * Commenting out of probabely useless methods :
72 Dict::GetDictEntryNames()
73 Dict::GetDictEntryNamesByCategory()
74 DictSet::GetPubDictEntryNames()
75 DictSet::GetPubDictEntryNamesByCategory()
76 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
77 * ENH : Use dicomTS.dic as described in 2004 version
78 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
79 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
80 Add Accessors on VM (Value Multiplicity), and VM related methods
81 * ADD : Add a list of 'Dicom Attribute types', as found in
82 http://medical.nema.org/dicom/2004/04_15PU.PDF
84 * ADD : Add dicomGroupNameAbbreviations.dic
85 should be used to write a method to replace the former
86 Dict::GetDictEntryNamesByCategory()
88 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
90 to read in the file... and only it ! Length is the efective length of the
91 data in the DocEntry structure
93 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
95 And now use a static function call instead, with a global variable. i
96 This is much closer to the VTK approach. Hopefully should be bulletproof
97 and easier to use...hopefully
99 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
100 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
102 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
105 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
107 ValEntry, BinEntry, SeqEntry creation or replace
109 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
111 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
113 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
114 when specifying the VR
115 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
116 * src/gdcmDocEntry.cxx : amelioration of print
118 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
119 * ADD : Add the method Util::IsCurrentProcessorBigEndian
120 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
121 * ADD Method Document::ComputeGroupLength
122 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
123 in order to allow further VR modification by user
124 * REM : removal of once-called method File::WriteBase
125 integration of its code in formerly one-line method File::Write
127 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
129 replace the different values "??", "Unkn", "Unknown".
130 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
131 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
132 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
133 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
135 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
138 * Set the gdcm::Base class to some Printable classes
140 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmFile.[h|cxx] : add the Print method
142 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
143 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
144 * src/gdcmDocument.h : remove the PrintLevel informations
145 * Example/PrintFile.cxx : use the new gdcm::File::Print
147 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
149 problems when compiling with the python wrapping
151 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
153 writting in ImplicitVR
155 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
156 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
157 JPEG decompression, especially when dicom frames are split into several
158 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
159 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
161 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmHeader.cxx : change the initialisation of default header.
163 Now, this header is readable by gdm, e-film, DicomWorks
165 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
167 Rename Decompressed to Raw
168 * Use the API changes in gdcm::File.
169 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
172 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
174 each added entry in the header. Replace the 'Planes' field by the 'Number
177 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
179 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
181 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
183 At this time, this image isn't readable by e-film... waiting JPR help to
186 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
188 DocEntry. Now use methods of the Document !
190 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Test/ShowDicomSeq.cxx : bug fix
193 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
195 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
196 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
197 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
199 * Test/TestCopyRescaleDicom.cxx : remove unused variable
200 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
201 containing found sequences
203 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
206 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
207 Some fields in BinEntry must be copied to not seg fault when making the :
208 gdcm::File *copy = new gdcm::File( copyH );
209 and tests are now made on good variables
211 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
213 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
215 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
216 * Add vtkGdcmWriter example and test
218 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Test/TestUtil.cxx : reformat the source code
220 * vtk/vtkGdcmReader.cxx : remove and change prints
221 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
223 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
224 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
226 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
228 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
230 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
232 by an eof to prevent all bad read of the file... and in this case, the
235 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * Example/Volume2Dicom.cxx : comment unused variables
237 * Test/PrintDicomDir.cxx : comment unused variables
238 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
239 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
240 method that is redondant with AddEntry.
241 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
244 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * Bug fix due my last commit (compilation under Windows).
246 * Example/Volume2Dicom : bug fix in the file and reformatting source code
247 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
249 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 - Remove printf / sprintf
252 - include iostream AFTER gdcm so we don't get warnings
253 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
255 - Also remove tons of include from header files, hopefully this should
256 speeup the compilation time, since it was becoming a dog slow.
257 - Remove gdcm.h as it include way too many files and slow down compilation
258 (plus it is not up to date)
259 - remove 'using namespace std' this is BAD !
261 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * Remove memory leaks on the DicomDir
263 * Remove some useless data in DicomDirObject
264 * Add usefull methods in SQItem, to be complient withe the ElementSet
266 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
269 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
271 future, with convertion)
272 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
273 and ImageDataSize values. Remove the method to get the PixelReadConverter
274 from the output of the class
276 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
279 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
281 and vtkErrorMacro use.
282 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
284 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
287 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
288 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
289 The string leaves only in the fonction. So when we make a .c_str(), we
290 get the pointeur on the first element, element that will be destroyed
291 immediately after thee instruction.
292 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
293 file has been opened : the test must be made on the content of the
294 pointer and not directly on the pointer !
297 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
299 the python part recompiles
301 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
303 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
304 X session is killed (for my computer... it seems to not be identic on
307 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
309 avoid problems (otherwise, the difference test between the visible image
310 and the reference is incorrect. If the reference is greater than the
311 screen resolution, it's produce errors).
312 Can be used for only one image. Can be used with a visible flag.
313 * vtk/vtkGdcmReader.cxx : remove commented codes.
314 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
315 under windows at compilation
316 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
318 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
320 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
322 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
323 tests on the image size X, Y, Z
325 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
327 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
328 between the class name and the file name
330 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/ : fix compilation warnings for the Write method (2 different
332 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
333 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
334 variable... create a static method in gdcm::Document to access to
335 this variable content.
337 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
339 file, to be accessed by other files (like gdcmFile). Remove commented
340 code. Move the change of the header to the gdcmFile, using the
342 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
343 To be sure of that (and simplify calls), the Write of the header now
344 gets a file name and not a file pointer (std::ifstream).
345 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
346 DocEntryArchive. Remove all open of the written file
348 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
351 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
353 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
355 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
356 some corresponding methods. Write correctly the file and check before
358 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
359 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
360 is now on RGB data (as before my last commit
361 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
363 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
364 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
365 Add a print information of the type of the entry
366 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
367 It was in the gdcmFile, and all write have been regrouped
368 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
369 Write correctly all dicom files (in decompressed mode only at this time)
370 * Test/ : test on files are now made using Raw data and not color data if
372 * Example/PrintFile.cxx : add more printings
374 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * Amelioration of code, remove some code copy. For the loading of
376 BinEntry (in gdcmDocument), add the test to verify if the file is already
379 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
380 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
381 remove a DocEntry in the header (push an empty DocEntry)
382 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
383 lines. Bug fix in the initialization of the PixelConvert and the
385 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
386 use in TestCopyDicom (now this test can run under windows... but fails)
387 * Test/TestCopyDicom.cxx : amelioration of the test :
388 - test the pixels written
389 - add test points to quickly find where is the error
390 - can set a file name input and output in arguments
391 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
392 amelioration of the test output
394 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
396 all replaced DocEntry's
397 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
398 Now, each needed DocEntry to modify is duplicated, modified and inserted
399 to the header using DocEntryArchive. Thus, after save, we can restore the
400 header initial state.
402 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
405 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
406 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
407 correct to copy it. The DictEntry is specified at the DocEntry creation,
408 then, it musn't change in the time.
409 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
410 header correctly. At this time, the change is only made for the first
411 level of the Document. In the future, it might consider sequences.
412 The change is made by replacing a DocEntry by an other that is created
413 outside the class. The old value is kept. When we restore the header
414 status, the added DocEntry is deleted and replaced by the old value.
415 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
416 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
417 set the write type to explicit VR, implicit VR or ACR. Add methods to set
418 the write mode to native, decompressed or RGB (but not used at this time)
420 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
422 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
424 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
425 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
426 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
428 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
429 set because already copied when copying the BinEntry's of the header
430 * Test/TestAllReadCompareDicom.cxx : remove warnings
432 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
434 Two problems appear when doing it :
435 - with the gdcmFile : when the GetImageData method is called, the pixels
436 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
437 data (pixels). And each structure destruct the data when it's
438 destructed. So we have two destructions for the same data. To solve it,
439 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
440 data or not. If it doesn't own data, then they will not destroyed by
442 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
443 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
444 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
445 create a double destruction of the same DocEntry's. So, to solve it,
446 the TagHT is simply cleared and the DicomDir* elements are destroyed.
447 * TODO : add an entry concerning memory leaks in the DicomDir
449 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
450 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
451 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
454 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
456 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
457 after it have been deleted
459 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * FIX: src/* fix the doxygen warnings.
461 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
462 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
463 was erroneously defined with a size of 15 instead of 16. [many thanks
464 to Jean Michel Rouet for pointing out this bug].
466 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
467 1. Finish merging JMR patch for writting DICOM from scratch
468 2. Fix -hopefully- bug with MONOCHROME and space vs null character
469 3. Use const ref when possible
470 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
471 5. A few more comments
472 6. CreateUniqueUID can now be called without parameter"
474 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
475 * ENH: Slightly bigger patch:
476 1. Getting toward full integration of JMR patch for writting dicom from scratch
477 2. Update Test to test part of this patch: CreateUniqueUID
478 3. File was not close properly in gdcmDict
479 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
480 5. Use of const ref instead of copy (speed issue)
481 6. Remove temporary (duplicate) string in TranslateToKey
482 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
483 8. Do not repeat virtual in subclasses
484 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
486 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * Apply first patch toward better string comparison when dealing with broken
488 DICOM files. Essentially the string could be padded with a space instead
489 of a null character as defined by standard
491 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
493 because never used... and in the same time, that's remove some memory leaks
495 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmFile.cxx : now delete the PixelConvert instance.
497 * In examples and tests : change the type of image data variables from void*
498 to uint8_t*. Remmove all delete on image data variables
500 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
501 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
502 Verify the file pointer value before open the file, and if it's not null,
503 a verbose message is generated.
504 Close correctly the file when the file isn't considered dicom-like. The
505 correctly close is a call to CloseFile.
506 When closing the file pointer, test if its not null to close the file.
507 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
508 file. For an uncompressed image, the copied data correspond in the least
509 case to the image size (calculated) or the image size specified in the
510 header. A verbose is generated if these two size mismatch
512 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
514 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
515 break under windows (with msvc6 compilation).
517 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
519 compiling with MSVC6)
521 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
522 * Bugs fix for the Windows build with VC6
523 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
524 needed (only for projects required VTK). If the VTK is included in all
525 projects, there is conflicts with the jpeg lib of vtk when compiling the
526 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
527 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
528 when compiling the gdcm_wrap.cxx file (created by the compilation of the
530 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
531 (like it's already made for the cout use). Otherwise, conflict with the
534 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
537 - comments on the DicomDir::Method related usage added.
538 - now that we use the namespace gdcm, a lot of internal classes do
539 NOT need to be wrapped anymore.
540 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
541 DicomDir::Method) new example added.
543 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Improve string manipulation. I now inforce the notion of 'DicomString'
545 A DicomString can contain as many \0 as they want
546 and it is *always* of even length.
547 We only support odd length for very rare case.
548 And in the near future this should be removed.
550 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
551 * /binary_write/ gdcm source. Now even on big endian we are writting
552 little endian. This should -heopfully- fix some tests
554 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 * Now the dictionary is compiled into gdcm lib. This is a default
556 behavior, thus any dic file specified is picked before failback to
557 the one comiled into lib
559 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
560 * Change internals for gdcmDict. Don't use any 'new' any more.
561 This should definitely solve any leak problem, and we should be
562 as fast as before, as long as don't modify too much the dictionary.
564 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
565 * STYLE: ivars should start with a capital letter.
566 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
567 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
569 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
570 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
571 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
572 new 2004 dictionaries added (thanks to JPR).
573 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
574 * CLEANUP_ROUND (15) for gdcmPixelConvert
575 - RLEFrame::NumberFragments is now of type unsigned int
576 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
577 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
580 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
581 * Initial work in gathering all transfer syntax accessors. clearly
582 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
583 ivars, but only one transfersyntax (class) ivar with equivalent method on
586 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
587 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
588 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
589 discussed (plus I didn't like having a 2000 lines patch not commited)
591 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
593 * CLEANUP_ROUND (14) for gdcmPixelConvert
594 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
595 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
596 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
598 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
599 anymore and hence avoids storing a copy of PixelConvert::Decompressed
600 into File::Pixel_Data.
602 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
604 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
605 * CLEANUP_ROUND (13) for gdcmPixelConvert
606 Substituted File::ParsePixelData() with PixelConvert::Print() new
608 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
609 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
610 method to those classes.
611 - src/gdcmFile.[cxx|h]:
612 -- Added a ::Print() method.
613 -- PixelConverter is now a reference instead of a member.
614 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
615 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
617 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
619 collaboration diagram and inheritance diagram should be generated with
621 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
622 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
623 pointlessly wrapped (see
624 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
625 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
626 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
627 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
628 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
629 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
630 -- File::Initialise: PixelConverter setup moved away to
631 PixelConverter::GrabInformationsFromHeader()
632 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
633 interpretation moved away to PixelConverter::BuildRGBImage()
635 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
636 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
637 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
639 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
641 displayed on Win32 when a brutal abort() occurs (because of uncatched
642 exception). See TODO new entry of this commit for more on this.
643 * TODO added new entry.
644 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
645 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
646 - HandleColor is no longer called from gdcmFile.cxx
647 - gdcmPixelConvert.cxx clean up on method arguments and internal
648 variable names for semantical coherence.
650 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
651 * Finished lossless transition, not only do we now read all lossless jpeg
652 images, without the need of the Cornwell lib, but we do read them properly now
653 * To reduce code (well to avoid code duplication), I defined a common place
654 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
655 redefine symbols. This is not perfect but this the best solution I found for a
656 compilation time jpeg option.
658 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
659 * Update jpeg ijg lib to support lossless jpeg implementation
660 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
662 * Also added a special copyright for dcmtk since we use their bugfixes.
665 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
667 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
668 matters, as stated in warning note at begining of %include section).
669 * src/gdcmDicomDir*.[cxx|h]: coding style
670 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
671 * src/gdcmJpeg8.cxx: doxygen fix.
672 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
673 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
674 from File:: to PixelConvert::.
676 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
678 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
679 - more code moved away from File:: to PixelConvert::
680 - fat setup of PixelConverter set in place in File::Initialise.
682 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
683 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
684 namespace at the file system level. So now you should convert your examples
686 gdcmHeader -> gdcm::Header
687 It would be nice if people keep in mind to no open the namespace, since it
688 allows compilation on broken plateform which were defining common symbol in
689 the standart namespace (like LP, Unknown ...)
691 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
693 The JPEG fragments are now parsed at the same stage than the RLE
694 information. All code related to JPEG is now in gdcmPixelConvert:
695 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
696 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
697 export a gdcmFile:: method. Those are simply global functions
698 (for the time being this is better than having them attach to
699 either gdcmFile:: or gdcmPixelConvert::).
700 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
701 and stores the result in a gdcmJPEGFragmentsInfo.
702 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
703 code (among other stuff) moved away from gdcmFile:; to
706 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
708 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
709 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
710 clean up of RLE related code.
711 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
712 - src/gdcmRLE.cxx removed
713 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
714 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
715 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
716 * CLEANUP_ROUND (9) for gdcmPixelConvert
717 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
718 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
719 away from gdcmFile:: to gdcmPixelConvert::.
721 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
723 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
724 This is because Parse7Fe0 used to parse the pixels to compute the
725 length. This task was passed over to FindDocEntryLengthOB() a long
726 time ago, EXCEPT I had forgotten the OW case...
727 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
728 we just recylce the code for parsing RLE fragments and computing
730 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
731 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
732 with the retired Parse7Fe0().
733 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
734 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
736 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
738 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
739 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
740 - src/CMakeLists.txt: alphabetic order reodering + new entries.
741 * CLEANUP_ROUND (4) for gdcmPixelConvert
742 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
743 to return an unused length.
745 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
746 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
747 this should be cleanner from the plane view. The iostream are erally a pain
748 to use to do simple stuff.
750 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
751 * Redo the compilation of the ijg jpeg library. Now only one source is
752 necesseray. No need to rename file by hand what so ever. CMake handle the
753 copying of the file within different directory, configure header file to
754 modify some symbol. The only addition made to ijg wasd a mangle table so
755 that symbol are different wether we are within 8bits or 12bits.
757 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * Added documentation of vtkgdcmReader on Website:
759 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
760 with it's binary name).
761 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
762 the Website to be more complete.
763 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
764 doxygenated documentation.
765 - Doc/DoxyVtkGdcmReaderExamples.txt added
766 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
767 DoxyVtkGdmReaderExamples.html )
768 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
769 * CLEANUP_ROUND (3) for gdcmPixelConvert
770 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
772 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * CLEANUP_ROUND (2) for gdcmPixelConvert
774 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
776 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * CLEANUP_ROUND for gdcmPixelConvert:
778 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
779 - src/gdcmPixelStuff[h|cxx] removed
780 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
781 - src/CMakeLists.txt changed accordingly
783 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
784 gdcmVersion.py moved to newly created ATTIC related
785 gdcmPython/SetupOldies/ directory.
786 * Autotools clean up:
787 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
788 - autogen.sh configure.in acinclude.m4 python.m4 removed
790 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * src/*.cxx *.h Reference to License.htm fixed to License.html.
792 * Doc/CMakeLists.txt, doxygen.config.in: fix.
793 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
795 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * TODO updated with Mathieu suggestions. I proposed a template for
797 describing TODO entries and used it for new entries.
798 * Added Doc/Website/CodingStyle.html, Developpers.html,
799 DeveloppersPython.html, GdcmDataCvs.html and
800 DownloadVersion0_1.html, DownloadVersion0_3.html.
801 * Some Doc/*.txt Doxygen files (which do not really concern the
802 documentation itself, but the website) moved to html and
803 placed in directory Doc/Website:
804 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
805 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
806 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
807 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
808 * CMakeLists.txt changed accordingly.
809 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
810 DeveloppersPython.html
811 * INSTALL nows refers to Doc/Website/Installation.html
813 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * Added Doc/Website directory, that contains a first raw version
817 2004-09-23 Jean-Pierre Roux
818 * FIX In order not to be poluted any longer by casting problems,
819 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
820 we can now delete[] it safely
821 * VoidArea is now called BinArea (less confusing name),
822 and all the methods called ...VoidArea... are now ... BinArea...
823 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
825 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
827 clear) TagHT, which is an inherited member of gdcmElementSet. It is
828 up to the destructor of gdcmElementSet to clean up TagHt and it's
831 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
832 * Test/CMakeLists.txt: update to follow gdcmData renamings.
833 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
835 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * ENH: added some utility method that builds a flat dictionnary
837 holding all the Dicom entries contained in the recursive structure
838 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
840 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
841 BuildFlatHashTable() that build a flat dictionary.
842 - src/gdcmElementSet.h: added a new private GetTag() accessor.
843 gdcmDocument is now a friend of gdcmElementSet.
844 - src/gdcmElementSet.cxx: clean up.
845 - Example/FlatHashTablePrint.cxx added.
846 - Example/CmakeLists.txt changed accordingly
848 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
850 moved away from gdcmDocEntrySet (since this class is an abstract class
851 acting like an interface). SQDepthLevel and BaseTagKey are now
853 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
854 and associated accessors. Doxygenation of the class.
855 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
857 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
858 Use SQDepthLevel accessor instead. ::Print() adapted.
859 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
860 - src/gdcmDocument.cxx changed accordingly.
862 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
864 - The following is the doxygen comment of the typedef declaration
865 of gdcmTagKey in src/gdcmCommon.h:
866 gdcmTagKey is made to old an "universal" (as in URL, Universal
867 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
868 A dicom tag always has a group and an element, but a set of tags
869 embeded in various (optionally nested) sequences and sharing
870 the same group and element all share the same (group, element)
871 "identifier". Hence the (group, element) cannot be used as an
872 identifier (in gdcm we shall refer to a "TagKey") of a tag.
873 In order to construct a proper tag identifier (i.e. a key) we
874 consider the following definition of a TagKey:
875 - let Group, Element be the string representation of the
876 group and element dicom tag members,
877 - let ItemNumber be the string representation of the integer
878 index of the considered item number of a sequence,
879 Let the key of a tag embeded in a sequence, noted SeqTag, be
881 /ItemNumber#Group|Element
882 where "/", "#" and "|" are characters acting as separators.
883 Then the general form of a gdcmTagKey is given by:
884 Group|Element<SeqTag>
885 where <SeqTag> means NO or many instances of SeqTag.
886 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
889 but the gdcmTagKey of a tag "embeded" is the first item of
890 a sequence, itself nested in the third item of a sequence is the
892 0004|1220/2#0008|0082/0#0008|0090
893 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
894 order to hold the new sequence compatible key. Previously, the
895 GetKey() method would look in the underlying gdcmDictEntry.
896 - src/gdcmDocEntry.cxx:
897 -- constructor now copies the underlying DictEntry key, in the local
899 -- ::Print: displays the member Key, instead of the (group, element).
900 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
901 - src/gdcmDocEntrySet.h:xi
902 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
903 -- now has a new BaseTagKey member.
905 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
906 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
908 This poses the problem with the semantics of the following lines
909 LoadEntryVoidArea(0x0028,0x1201); // R LUT
910 LoadEntryVoidArea(0x0028,0x1202); // G LUT
911 LoadEntryVoidArea(0x0028,0x1203); // B LUT
912 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
913 to the long FIXME note for what the problem is. Nevertheless in
914 order to get things working the dicom dictionary was altered !
915 Please fix things urgently...
916 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
917 information), see above note on moving the member VoidArea. Nevertheless
918 the following entries previously correctly set as US are now inproperly
920 0028 1201 OW IMG Red Palette Color Lookup Table Data
921 0028 1202 OW IMG Green Palette Color Lookup Table Data
922 0028 1203 OW IMG Blue Palette Color Lookup Table Data
923 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
924 of gdcmDocEntry moved to gdcmSeqEntry.
925 * src/gdcmSeqEntry.cxx: STYLE.
927 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * Test/TestAllEntryVerify.cxx minor fix and added comments.
930 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
931 * gdcmPython/testSuite.py: all the test suite in python is now moved
932 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
933 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
934 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
936 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
938 to avoid inclusion recursion until STL is reached.
939 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
940 mecanism. errno.h is not included in gdcm anymore.
941 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
942 (gdcmFormatError now inherits from gdcmFormatUnexpected).
944 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
945 gdcmData/TestAllEntryVerifyReference.txt
946 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
947 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
948 exception_on_error parameter.
949 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
950 - vtk/vtkGdcmReader.cxx changed accordingly,
951 - Example/*.cxx and Test/*.cxx changed accordingly.
953 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
955 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
956 enable_sequences removed from gdcmHeader constructor and dependencies.
957 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
958 * gdcmPython/demo/PrintHeader.py: dummy fix.
959 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
960 skip_shadow removed from gdcmHeader constructor and dependencies.
961 * Example/*.cxx and Test/*.cxx changed accordingly.
963 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
965 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
967 2004-07-21 Jean-Pierre Roux
968 * FIX Now, Parsing and Printing a DICOMDIR do work!
969 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
971 2004-07-20 Jean-Pierre Roux
972 * FIX Some brain damaged headers have Zero-Lenght fields
973 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
975 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
976 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
977 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
978 variable (instance of gdcmDebug) by a definition macro, and the instance
979 is now in static in the gdcmDebug class
980 * src/gdcmSQItem.h : (FIXME) remove an undefined method
981 * Test/PrintAllDocument.cxx : bug fix in the result of the test
983 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
984 * WARNING: ctest now depends more tightly on gdcmData. You should
985 check out gdcmData properly for things to run smoothly...
986 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
987 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
988 we need the pixels not be loaded in order to use the ValEntry
989 that displays position and size).
990 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
991 This is a C++ based equivalent of gdcmPython/testSuite.py that should
992 be deprecated. If you have any doubts about the advantages of a
993 modern scripting language (read Python) versus grass root C++ (i.e.
994 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
995 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
996 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
997 Anyhow, consider documenting the gdcmData images in
998 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1000 * Test/CMakeLists.txt:
1001 - now uses TestAllEntryVerify.cxx
1002 - specific comments on oldACR00001.ima (now renamed in gdcmData
1003 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1004 gdcmData/TestAllEntryVerifyReference.txt
1007 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1008 * src/*.[h|cxx] : typedef clean up
1009 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1010 - TagKey renamed to gdcmTagKey (for external usage)
1011 - VRKey renamed to gdcmVRKey (for external usage)
1012 - removal of typedef duplication.
1013 - Removed all unecessary inline keyword from class inline definitions.
1014 - Some method|function(void) declarations replaced with method|function().
1015 * src/jpeg/libijg12/jdhuff12.c:
1016 - printf polluting ctest removed.
1017 - TAB removal for comminting
1019 - TestAllReadCompareDicom.cxx: added a test that compares all the
1020 images in gdcmDataImages.h with corresponding images in
1021 gdcmData/BaselineDicom/. When baseline images are not present
1022 this test creates them.
1023 Note: we need to validate each reference image, but before that
1024 I'd like to rename them with a more explicit name...
1025 - CMakeLists.txt: changed accordingly.
1026 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1027 including each header needed).
1029 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1031 test suite to the Example directory. Are concerned:
1036 - TestWriteSimple.cxx
1037 * Test/CMakeLists.txt: added some comments on reasons for black listing
1038 image gdcmData/oldACR00001.ima
1040 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * Test/CmakeList.txt: removed the following from black list (to be coherent
1042 with removal from gdcmData):
1043 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1044 - gdcm-MR-PHILIPS-16.dcm
1046 Added the following because after last cvs update, they cause
1047 ctest -R TestReadWriteReadCompare
1049 - gdcm-MR-SIEMENS-16-1.acr
1051 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1052 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1053 new comments in this file) we temporarily (sigh) move to a weaker
1055 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1056 we don't need to black list the following images anymore:
1057 - 8BitsUncompressedColor.dcm
1059 - US-PAL-8-10x-echo.dcm
1060 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1061 fixes and the beautified code ;-)
1062 This fixes the bug introduced in version 1.42 (when beautifying)
1063 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1064 Note: ctest was blind to this bug (this means we need to still
1065 improve the test suite). The bug could be detected by using
1066 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1068 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1069 and by displaying the (garbage) produced file temp.XDCM...
1071 2004-06-29 Jean-Pierre Roux
1072 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1073 - replace by uggly but working old code :-(
1074 A lot of things should be OK again.
1075 It's really urgent to have a test suite that *tests*,
1076 to prevent Frog's beautifying sessions to break all the stuff
1077 (twice, withing a fortnigh ...)
1079 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1081 redundancy) to added Test/TestReadWriteReadCompare.cxx
1082 * Test/CmakeList.txt: because the compare test of
1083 Test/TestReadWriteReadCompare.cxx fails, the following images are
1084 black listed: - 8BitsUncompressedColor.dcm
1086 - US-PAL-8-10x-echo.dcm
1087 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1088 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1089 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1090 and ad-hoc kludge. This kludge is now removed, and on encountering
1091 such an image (OB field brain damaged) we set errno. Then in
1092 ::FindDocLength() we "fix" the length as being ALL what remains
1093 in the file (until EOF). We then proceed, hoping for the best...
1094 This fixes a SegFault in ShowDicom when trying to write such an
1096 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1097 (because TestWriteRead breaks on it, after a non conformal commit?).
1098 ctest now runs properly, except for MakeDicomDir (which was always
1099 broken) and the Python related stuff (still not fixed).
1101 2004-06-24 Jean-Pierre Roux
1102 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1103 FIX : Test/TestReadWrite now iterates on all the file names
1104 (instead of infinite loop)
1105 ENH : Test/TestWriteRead now iterates on all the file names
1107 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1110 2004-06-24 Jean-Pierre Roux
1111 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1112 when SamplesPerPixel =3
1113 - now Write is no longer confused by
1114 'BitsAllocated = 12" and 'BitsStored=12"
1115 - "UN" value representation Elements are now written correctly
1116 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1117 ENH : - now gdcmHeader has its own Write methods
1118 (in order to split the job that has not to be done
1121 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1123 loop on the same image until memory went out.
1124 Note: this means we still have gobs of memory loss in PrintDocument
1125 * src/gdcmDocument.cxx: fixes problem on parsing on file
1126 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1128 2004-06-24 Jean-Pierre Roux
1129 FIX : Write - All the Sequences and Sequence Item are now written
1130 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1131 is added a the end, when necessary.
1132 - A lot of brain-damaged images, that were read correctly are
1133 now written correctly
1134 - length compatible BinEntry are now loaded correctly
1135 (even for odd groups)
1136 Note : only Explicit Value Representation was checked.
1137 (question : is implicit VR really necessary for gdcm ?)
1139 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * DEVELOPPER: added a proposition of coding style.
1141 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1144 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1146 Use the gdcmDocEntry::Print() and Write() instead.
1147 * src/gdcmDocument.cxx: bug fix.
1149 2004-06-22 Jean-Pierre Roux
1150 FIX : gdcmDocument.cxx
1151 - Now we do recognize the JpegLossLess format (there was a misstyping in
1152 code 'beautyfication' :-(
1153 - Now we automaticaticaly load the Luts, if any
1155 2004-06-22 Jean-Pierre Roux
1156 In order : to write Sequences, whatever their imbrication level,
1157 : to allow user to create his own Sequences
1158 a lot of modif where necessary (adding, moving, or virtualising methods)
1160 WARNING : save your own sources *before* cvs up !
1163 ADD virtual void Write(FILE *fp, FileType filetype);
1166 ADD virtual void Write(FILE *fp, FileType filetype);
1167 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1170 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1171 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1172 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1173 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1174 ADD std::string GetEntryByName(TagName name);
1175 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1177 std::string vr = "unkn",
1178 std::string fourth = "unkn",
1179 std::string name = "unkn");
1180 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1181 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1182 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1183 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1184 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1185 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1186 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1187 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1190 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1191 ADD virtual std::string GetEntryByName (TagName tagName);
1192 ADD virtual std::string GetEntryVRByName (TagName tagName);
1193 REM virtual bool Write(FILE *, FileType);
1194 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1195 FILE *_fp, FileType type);
1196 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1197 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1198 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1199 REM virtual std::string GetEntryByName (std::string tagName);
1200 REM virtual std::string GetEntryVRByName (std::string tagName);
1201 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1202 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1203 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1205 std::string vr = "unkn",
1206 std::string fourth = "unkn",
1207 std::string name = "unkn");
1208 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1209 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1210 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1211 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1214 ADD virtual void Write(FILE *fp, FileType filetype);
1217 ADD virtual void Write(FILE *fp,FileType filetype);
1220 ADD virtual void Write(FILE *fp, FileType filetype);
1221 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1222 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1223 REM std::string GetEntryByName(TagName name);
1226 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1228 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1230 The default constructor invoked by the line
1231 gdcmHeader *f1 = new gdcmHeader( header );
1232 was gdcmHeader::gdcmHeader(bool) instead of the expected
1233 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1234 Hence the parsing wasn't executed... See also below.
1235 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1236 as explicit constructor didn't do the trick to fix the above problem.
1237 Could anyone explain why ?
1238 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1239 properly calls gdcmValEntry::Print() (that was weed out from
1240 code related to gdcmBinEntry).
1242 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * In order to fix memory leaks:
1244 - Test/TestWriteSimple.cxx: added cleaning of free store through
1246 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1247 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1248 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1249 (through the call to ::AddDicomDirMeta()) or the destructor
1250 would crash when deleting uninitialized ::metaElems].
1251 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1252 - src/gdcmDocument.cxx:
1253 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1254 from dynamic stores.
1255 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1256 was causing memory leaks.
1257 - src/gdcmSQItem.cxx:
1258 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1259 cleanly handled with polymophism: sorry but my milage is low).
1260 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1261 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1262 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1263 This avoids SegFaulting.
1264 - src/gdcmSQItem.h: coding style.
1266 - Test/TestWriteSimple still severely sucks. The output image content
1267 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1268 damaged when displayed with vtkgdcmViewer.
1269 - on memory leaks: TestWriteSimple leaks really less (see entry
1270 of 2004-06-18 in Changelog file for the call to valgrind).
1271 - on segfaults: ctest now passes all the tests but one (no more
1273 * Erroneous leading white fix:
1274 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1275 white[s] (as opposed to from >> xxx, that removes it [them].
1276 - src/gdcmTS.cxx: ditto.
1277 - gdcmPython/testSuite.py: dirty related kludge removed.
1278 * src/*: remaining references to gdcmParser removed.
1279 * src/*[cxx|h]: added copy[way]left header.
1282 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * In order to fix writing of dicom files:
1284 - Test/TestWriteSimple.cxx: a simpler example of writing.
1285 - Test/CMakeLists.txt changed accordingly.
1286 - src/gdcmDocument.cxx:
1287 -- The destructor now recursilvely removes potential sequences.
1288 -- Bug fix in ::IsJPEG2000()
1289 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1290 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1292 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1293 to only declared) and build on top of
1294 ::GetDocEntryByNumber(guint16, guint16).
1295 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1296 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1297 for usage in destructor and treatement of promotion in
1298 ::ReplaceOrCreateByNumber().
1299 - src/gdcmSQItem.cxx: destructor should better handle his job.
1300 Test/TestWriteSimple now runs (or at least it DOES something).
1301 * We can now start hutting memory links. A good starting point is:
1302 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1303 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1304 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1306 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1307 * Valgrind note: after Mathieu Malaterre teached me how to read
1308 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1310 Using gcc, you can force the STL to use malloc and to free memory as
1311 soon as possible by globally disabling memory caching.
1312 With 3.2.2 and later, you should export the environment variable
1313 GLIBCPP_FORCE_NEW before running your program.
1314 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1315 simply vanish (it is still not clear to me, whether this means that
1316 STL std::string leaks or if valgrind believes it leaks...).
1317 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1318 running bin/gdcmTests makeDicomDir):
1319 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1320 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1322 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1323 SegFaulting (I drowned in DicomDir related code when trying to
1324 understand why the list is empty...).
1325 * src/gdcmDocument.h: first BSD license header try.
1326 * Doc/License.txt added.
1328 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1329 * src/gdcmDocument.[h|cxx]:
1330 - Clean up of the Transfer related predicates. They are now all based
1331 on new method isGivenTransferSyntax, that (should) handle properly
1332 the padding problem.
1333 - general clean up, simplification, and coding style.
1334 - Specific clean up of Parse7FE0() (umproperly named actually).
1335 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1337 2004-06-14 Jean-Pierre Roux
1339 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1340 - fix the display of SQItem ordinal number
1341 - add the GetSQItemByOrdinalNumber method
1342 - remove some useless never written private methods
1344 2004-06-14 Jean-Pierre Roux
1346 - adding a constructor taking a gdcmDocEntry as an input param
1347 - ReplaceOrCreateByNumber now returns :
1348 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1349 a gdcmValEntry * if a string value is passed as a param
1351 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1352 according to the param type (no longer sets a gdcmDocEntry)
1353 - GetValEntryByNumber, GetBinEntryByNumber added
1354 - NewValEntryByNumber and NewBinEntryByNumber added
1356 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1358 - GetSQItemNumber and SetSQItemNumber added, to provide
1359 a (relative) Item identier inside a given Sequence
1360 \warning : some pb remaining around this number
1362 - AddEntry now takes the Item Number as a param
1364 - adding a constructor taking a gdcmDocEntry as an input param
1366 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Memory leak hunt with the following command:
1368 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1369 --show-reachable=yes gdcmTests PrintDocument
1370 It looks like many (all?) leaks are due to the STL (or a bad usage
1371 of the STL. The lines producing the leaks now have a comment with
1372 a "MEMORY LEAK" tag: you can retrieve them with
1373 grep "MEMORY LEAK" src/*
1374 Here are two typical examples which I can't help fixing:
1379 char * test = "babo";
1380 name = test; //// <--- valgrind detects 960 bytes lost in
1381 //// call to std::string::operator=(char const*)
1382 name.clear(); //// Doesn't help !
1390 std::cout << "Type a bunch of characters followed by RETURN: ";
1391 getline(std::cin, line); //// <--- valgrind dectects a loss
1392 //// of 1320 bytes in call to
1393 /// std::basic_istream<>& std::getline<>
1399 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1400 * src/gdcmHeader.[cxx|h]:
1401 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1402 and related, moved away to gdcmDocument.
1403 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1404 the corresponding protected accessors of inherited class
1405 gdcmDocument, removed ! As a consequence gdcmFile had to be
1406 declared friend of class gdcmDocument (see below).
1407 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1408 - Clean up of undefined or unused methods.
1409 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1410 account the changes to gdcmHeader.h).
1411 * src/gdcmDocument.h:
1412 - gdcmFile is now a friend class (in order to take into account the
1413 changes to gdcmHeader.h).
1414 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1415 (see changes to gdcmHeader.h).
1416 - Accessors (reading on the form GetEntry*) are now public.
1417 - Clean up of undefined or unused methods.
1418 * src/gdcmDocument.cxx:
1419 - adaptation to changes to gdcmDocument.h
1420 - ::OpenFile now writes a verbose message when file cannot be opened.
1421 - some std::string properly set to VRKey
1422 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1423 references to gdcmDocument.
1424 * Test/TestFindTags.cxx: changed accordingly to above changes.
1425 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1426 cvs repository gdcmData.
1428 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1430 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1431 conflicts with gdcmValEntry::voidArea.
1432 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1433 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1434 Value representation between StringRepresentable and BinaryRepresentable.
1435 * src/gdcmDocument.cxx:
1436 - method ParseDES: proper indentation restored and usage of
1437 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1438 - method LoadDocEntry: the fingerprint left in the SetValue() of
1439 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1440 removed. Reverting to previous code segment with the proper
1441 dynamic_cast< gdcmValEntry* >.
1442 Note: this was (partially) breaking the python test suite
1443 (gdcmPython/testSuite.py) that made usage of the above
1444 fingerprint to check presence of "Pixel Data".
1445 * src/gdcmDocEntry.h: coding style.
1446 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1447 now taken into account.
1448 * gdcmPython/gdcm.i: adaptation to the new internal representation
1449 of gdcm (exit gdcmParser, hello gdcmDocument).
1450 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1452 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1453 anymore, but instead prints the loaded Python dictionary.
1454 * .... alas, the python testSuite is still broken.
1456 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1457 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1459 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1460 * src/gdcmUtil.h : export methods
1462 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1465 * Initial addition of automatic python testing
1466 * Initial addition of automatic image comparison
1468 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1469 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1470 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1472 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1473 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1474 * Test/ShowDicom.cxx : bug fix for msvc compilation
1475 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1477 2004-05-04 Jean-Pierre Roux
1478 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1479 new concepts (and new classes) :
1480 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1481 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1482 - Sequence Doc Entries (gdcmSeqEntries)
1483 a Sequence is composed of Items.
1484 Each item is a set of Doc Entries (this is recursive)
1485 The non uniqueness of the 'Dicom tag' is due to this recursivity
1486 (never taken into account)
1487 Our unability to add a new 'entry' in the header
1488 at the proper location (neither in the H-Table (map or multimap),
1489 nor in the Chained List is also due to this recursivity.
1490 Don't try, right now, to use/modify/compile these new sources :
1491 nothing is finished.
1492 We just commit all the stuff, 'as is', in order not to loose it.
1494 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1495 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1497 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1498 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1499 file prefix (SetFilePrefix)
1501 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1502 * Add a new test: ShowDicom, for now this is just the c++ version of
1503 checkRead.sh, later it will be able to compare the image read against a
1505 * Replace the DEBUG on the stack with a global entry in cmake interface:
1506 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1508 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1509 * Add an example subdir, with a real example on how to read + write a
1512 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1513 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1514 * Doc/CMakeLists.txt: the main page is now properly differentiated
1515 between the developper and user version.
1516 * Doc/doxygen.config.in: dropped search related obsolete flags
1517 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1519 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * DEVELOPPER: added some helpfull comments for compile/test/install
1523 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1524 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1525 src directory, now generated in the build dir.
1526 2. Tests as mentionned smarter
1528 4. Add a new method in gdcmDict that return the PubDict by name
1529 this is interesting for 3rd party lib like ITK,
1530 where we could set the institution name / patient name...
1532 * ENH: 1. Now the test suite is working for real
1533 2. All binaries are now output in the gdcm-bin directory
1534 (this was not true before)
1536 2004-04-28 Jean-Pierre Roux
1537 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1538 SeQuence indented printing of Dicom Header.
1539 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1540 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1541 Computation of SQDepthLevel is now part of gdcmHeader constructor
1542 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1543 tree-like structure of a Dicom Header.
1544 * FIX Test code cleaning
1546 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1547 * ENH: Adding automatic testing
1548 1. Need a DartConfig.cmake to submit to public
1549 2. Add a test driver gdcmTest.cxx
1550 3. gdcmTestMain, an helper for the main test driver gdcmTest
1551 4. Files in Test don't have a main anymore, this becomes interesting
1552 when we add more and more tests, thus dsw don't have to load
1554 * ENH: Adding a GDCM_DATA_ROOT for testing
1555 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1556 one file instead of seven + some small cleanup
1558 2004-04-22 Jean-Pierre Roux
1559 * ENH Minor changes to the Print() methods.
1560 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1561 Header printing. Example given with :
1562 > PrintHeader fileName 2 new
1563 (SQ based tree-like structure still to be done for the Header ...)
1565 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1566 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1567 1. I have added some unsigned where needed
1568 2. Some function parameter not used -> (void)
1569 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1570 4. g++ don't like character '\' in comment
1571 5. #define jpeg_create_decompress jCreaDecompress
1572 this really need to be fixed
1573 6. virtualize destructor of gdcmObject ... leakage
1574 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1575 this also really need to be fixed
1576 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1577 remove compression file
1578 (as we only do decompression, right ?)
1579 * ENH: Change malloc/calloc/free with c++ equivalent
1581 2004-04-21 Jean-Pierre Roux
1582 * FIX gdcmHeaderHelper::GetXSpacing
1583 when a single value is found (bug ?), xpacing is now
1584 defaulted to yspacing
1586 2004-04-19 Jean-Pierre Roux
1587 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1588 * ENH add parameters :
1589 bool exception_on_error = false,
1590 bool enable_sequences = false,
1591 bool ignore_shadow = false
1592 to the gdcmFile constructors to be full gdcmParser compliant
1593 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1594 to allow reading of PAPYRUS 3.0 files
1596 2004-04-06 Jean-Pierre Roux
1597 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1599 2004-04-02 Jean-Pierre Roux
1600 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1601 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1602 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1604 2004-03-30 Jean-Pierre Roux
1605 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1606 for ACR file, written out as DICOM files (hope so...)
1608 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1610 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1611 moved to base class gdcmParser and only the specialisation is kept
1613 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1614 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1615 already does the job.
1616 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1617 (to be consistent with gdcmParser::WriteEntries).
1619 2004-03-30 Benoit Regrain
1620 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1621 upate of the object's instance. It's passed to 2 in the unfavorable
1622 case : one in the ExecuteInformation, one in the ExecuteData
1624 2004-03-29 Jean-Pierre Roux
1625 * ENH : Check on file type to be written moved
1626 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1627 * FIX : gdcmObject::ResetBoundaries now stops properly
1628 when end-of-list is reached
1629 : gdcmVersion modified (as Benoit Regrain asked)
1631 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1632 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1633 * src/gdcmUtil.cxx: added forgotten iostream include.
1634 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1635 equivalent to ExplicitVR in existing code).
1637 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1639 now contains all the gdcmGlobal related code.
1640 * minor coding style and doxygenation changes.
1642 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1644 now contains all the Debug related code.
1645 * minor clean-up of includes in src/*.cxx
1646 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1647 CreateCleanString) removed.
1648 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1649 * Doc/DoxyMainPageUser.txt added.
1650 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1651 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1652 src/gdcmDirList.cxx)
1654 2004-03-24 Jean-Pierre Roux
1655 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1657 2004-03-23 Jean-Pierre Roux
1658 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1659 big endian made volumes
1660 * ENH Now gdcmParser constructor and destructor are protected to forbid
1661 end user to instanciate class gdcmParser
1662 (only gdcmHeader and gdcmDicomDir are meaningfull)
1664 2004-03-22 Benoit Regrain
1665 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1666 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1667 gdcmSerie to gdcmDicomDirSerie
1669 2004-03-19 Jean-Pierre Roux
1670 * ENH Now the tree-like structure describing a DICOMDIR comming from
1671 an already existing DICOMDIR file is consistent with
1672 the home-made tree-like structure build ex-nihilo
1673 or build from the files held (recursively) in a Directory
1674 functions gdcmDicomDir::CheckBoundaries()
1675 gdcmObject::SetBoundaries() added
1677 2004-03-17 Jean-Pierre Roux
1678 * REM (Eric Boix bug) : removal of meaningless
1679 gdcmDicomDirImage::NewImage function.
1680 * FIX now file names and directory name are written properly in the
1682 * FIX now gdcmDicomDir constructor may be call without any trick
1685 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1686 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1687 of gdcmDicomDirImage::NewImage as empty function.
1689 2004-02-28 Jean-Pierre Roux
1690 * ENH add gdcmDicomDir:NewPatient
1691 add gdcmDicomDirPatient:NewStudy
1692 add gdcmDicomDirStudy:NewSerie
1693 add gdcmDicomDirSerie:NewImage
1694 to allow making gdcDicomDir object.
1695 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1696 (as opposite to the gdcmHeader chained list)
1698 2004-02-11 Benoit Regrain
1699 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1700 when using from python
1702 2004-02-10 Benoit Regrain
1703 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1704 * FIX : in gdcmDicomDir when the directory is empty
1705 * ENH : add callback and methods to get the progression of dicomDir
1708 2004-02-06 Jean-Pierre Roux
1709 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1710 - GDCM_META added to gdcmDicomDirType
1711 - class gdcmMeta created
1712 * ENH : - A brief summary is now displayed at the beginning of
1713 'testDicomDir' to help disaster magnitude estimation
1714 * REM : Now useless Test/explDICOMDIR.cxx
1716 2004-02-05 Benoit Regrain
1717 * ENH : add methods in gdcmObject to get the hash table or the list of
1719 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1720 * FIX : wrapping python for TagHeaderEntryHT
1722 2004-02-04 Benoit Regrain
1723 * FIX : even length for some strings when writting the dicom dir
1724 * FIX : sort the images in the dicom dir
1725 * FIX : Bug fix for python use of dicom dir
1726 * ADD : a python demo
1728 2004-02-04 Jean-Pierre Roux
1729 * FIX : Final solution (?) for icone embedded images
1730 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1731 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1732 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1733 gdcmData/gdcm-MR-SIEMENS-16.acr1
1734 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1735 to make full checking easier
1737 2004-02-04 Benoit Regrain
1738 * FIX : WriteEntries : coding style & logic in parameters
1739 * FIX : Set the elements to create the DicomDir in a dictionary file
1741 2004-02-03 Benoit Regrain
1742 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1743 * gdcmDicomDir : add the load of directory
1744 * Bug fix and print add-on
1746 2004-02-03 Jean-Pierre Roux
1747 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1748 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1749 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1750 * FIX gdcmParser.cxx : 'group length' elements are now considered
1751 as integers, even for shadow groups, when file is Implicit VR
1753 2004-02-02 Jean-Pierre Roux
1754 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1756 of the last synonym :-(
1757 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1759 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1760 * FIX taking into account the possible 7fe0,0010 multiplicity
1761 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1762 to allow removal of references to 7fe0,0010, to deal with
1763 ACR-NEMA images, when 0028,0200 is meaningfull
1765 2004-01-31 Jean-Pierre Roux
1766 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1767 no longer writes 'Un' on disk
1768 * FIX SQ elements with actual length are now dealt with corectly
1769 * FIX gdcmFile::WriteBase make the difference, for color images, between
1770 the length (for Palette expanded images)
1771 and Raw Length (non expanded image + Palette)
1772 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1773 (that broke Write). Replaced by UL.
1774 Aware user will reload the field if he
1775 thinks it's necesssary
1777 2004-01-30 Jean-Pierre Roux
1778 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1779 when 'dirty Acr' is found, to be compliant with the new
1780 IsReadable() methods.
1782 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1783 (no DOUBLE images in kosher DICOM,
1784 but so usefull for people that miss them ;-)
1786 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1787 DICOMDIR related utilities (not checked as Windoze compliant)
1789 2004-01-28 Jean-Pierre Roux
1790 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1792 2004-01-27 Jean-Pierre Roux
1793 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1794 to allow skipping the shadow elements, to save memory space.
1795 The TRUE value for this param has to be used
1796 with a FALSE value for the 'enable_sequence' param.
1797 ('public elements' may be embedded in 'shadow Sequences')
1798 * gdcmHeader methods now deal with 'embedded icones images' in the header
1799 (even when an 'icone image sequence' is announced by the
1800 element (0x0088,0x0200), but there is NO icone at all ...
1802 * gdcmHeader sometimes Image Location value doesn't follow
1803 the supposed processor endianity (see gdcmData/cr172241.dcm).
1806 * gdcmHeader add the method
1807 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1808 to get *all* the Header Entries with the same tag.
1809 GetHeaderEntrySameName is probabely *useless*
1810 (no meaning : Name is *not* an identifier within the Dictionnary)
1812 2004-01-26 Benoit Regrain
1813 * Bug fix in the print of hexadecimal representations. Remove long fields
1814 in the print and add a third level of print to print them
1816 2004-01-23 Benoit Regrain
1817 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1818 * Bug fix on test suite after remove the strip made on not string fields
1819 * Split the IsReadable method between gdcmParser which test that the file
1820 is dicom and gdcmHeader which test that it's an image file
1822 2004-01-22 Benoit Regrain
1823 * DicomDir : clean code, add methods, set variables in protected or private
1824 * gdcmUtil : bug fix for the clean string method
1826 2004-01-19 Benoit Regrain
1827 * Add the use of shadow dictionaries
1828 * bug fix and coding style
1830 2004-01-19 Benoit Regrain
1831 * src/gdcmFile.cxx : bug fix concerning the close of file
1832 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1833 * Add the update of header entries using the shadow library
1835 2004-01-19 Benoit Regrain
1836 * removal of file gdcmHeader2.cxx
1837 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1838 inheriting from gdcmParser. This split is to prepare the integration
1839 of dicom dir parsing
1840 * bug fix under python
1842 2004-01-16 Jean-Pierre Roux
1843 * REM removal of class gdcmHeaderEntrySet
1844 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1845 * ADD add file gdcmHeader2.cxx
1846 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1848 2004-01-15 Benoit Regrain
1849 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1850 entries created while parsing the header. Thus, they will be destroyed
1851 when the gdcmDictSet will be destroyed
1852 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1855 2004-01-15 Benoit Regrain
1856 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1857 made a fatal error because of the memory release at the end of program.
1858 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1859 some memory and vtk seems to have some problems with that.
1860 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1862 2004-01-14 Benoit Regrain
1863 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1864 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1865 * src/*.[h|cxx] : make changes due to class name changes
1866 * gdcmPython/demo/*.py : bug fix due to method names
1868 2004-01-13 Benoit Regrain
1869 * src/*.[h|cxx] : coding style
1870 * vtk/*.[h|cxx] : coding style
1872 2004-01-13 Benoit Regrain
1873 * gdcmPython/testSuite.py : test the readable flag of file for tests
1874 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1875 It's lied to the stl compilation by MSVC (windows, always windows...)
1876 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1878 2004-01-12 Benoit Regrain
1879 * src/*.h : add comments
1880 * src/gdcmDictSet.h : set the method BuildDictPath in public
1881 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1882 directly setted in the source code
1883 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1886 2004-01-09 Benoit Regrain
1887 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1888 * setup.py : use a reference to gdcmVERSION
1890 2004-01-07 Benoit Regrain
1891 * Modification to compile with the distutils.
1894 2003-12-10 Benoit Regrain
1895 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1896 can use a gdcmHeaderHelper to load data
1897 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1898 made in the source code
1900 2003-12-10 Benoit Regrain
1901 * Update Windows projects and .cvsignore files
1903 2003-11-12 Jean-Pierre Roux
1904 * ENH gdcmHeader constructor has one more parameter (default value : false)
1905 that allows the user to 'go inside' the SeQuences only
1907 gdcmElValSet:Print takes it into account
1909 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1910 * ENH: Update gdcmPython/CMakeLists
1911 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1912 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1914 2003-11-10 Jean-Pierre Roux
1915 * FIX : gdcmHeader::LoadElements is now based
1916 on the ListTag listElem member,
1917 not longer on the TagElValueHT tagHt member
1918 * ENH : PrintPubElVal shows (temporarily) both results,
1919 with the tagHt member and the listElem member.
1920 (it's easier to 'see' the problems when using Printheader)
1922 * FIX : old private member LgrElem is now splitted into
1923 ReadLength : Length actually found on disk (updated only
1924 if bug fixing is necessary), for internal
1926 UsableLength : Updated by FixFoundLength, to fix a bug
1927 or to allow Parser going on.
1928 Will allow to re-write a kosher header when a SeQuence
1929 with a length (not 0000) is found
1930 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1931 because gdcmElValSet::Add does not update ListElem
1934 2003-11-07 Jean-Pierre Roux
1935 * FIX misstyping in Transfert Syntax name table
1936 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1937 when they have an actual length (not 0000 nor FFFFF)
1938 (Nobody should care of it, but DICOMDIR explorers)
1940 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1943 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * ENH: vtkGdcmReader now supports LUT !
1945 (vtkgdcmViewer for now is not able to use them though)
1947 2003-11-05 Jean-Pierre Roux
1948 * in testSuite.py : new files names for checking the package
1949 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1950 that returns the pixel area size to the *aware* (vtk) user
1951 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1953 2003-11-05 Benoit Regrain
1954 * in testSuite.py : Modify the rules for checking the paths
1955 : Explicit error messages
1956 * in __init__.py : Related modif
1958 2003-11-03 Jean-Pierre Roux
1959 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1960 to be used by aware (vtk) users that want to manage
1961 LUT (and no to turn the PALETTE image into an RGB pixels one)
1962 * GetPixelType now returns 8U for 24 Bits images
1963 (vtkGdcmReader compliant)
1965 2003-10-31 Jean-Pierre Roux
1966 * Removal of *all* gdcmData images and add them again
1967 in order to loose the 'history' of un-anonymised images
1969 2003-10-31 Jean-Pierre Roux
1970 * RMV : removal of useless jBitsInJsample.h
1971 for both 8 and 12 Bits JPEG Lossy Libraries
1973 2003-10-31 Jean-Pierre Roux
1974 * ENH : Add the functions gdcmFile::GetImageDataRaw
1975 gdcmFile::GetImageDataIntoVectorRaw
1976 that act as GetImageData and GetImageDataIntoVector
1977 except the making of an RGB Plane from Gray Plane + LUT
1978 Intended to aware (vtk) users who know how to manage
1981 GetLUTRGBA return a R,G,B,A LUT if any
1982 lgrTotaleRaw gives the 'Raw' length
1983 GetImageDataRaw returns the gray Plane
1984 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1985 (They stay Grey, just like with other Dicom viewers :-(
1987 2003-10-30 Jean-Pierre Roux
1988 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1990 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1992 being coherents dicom files.
1994 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1997 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1998 * ENH: Two steps is necessary to please VC++ compiler...
1999 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2000 * ENH: Add include dir to medcon lib
2001 * FIX: only one function is being exported for now !
2002 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2004 2003-10-29 Jean-Pierre Roux
2005 * adding gdcmHeader::GetLUTRGBA
2006 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2007 --> Mathieu, the modif u're waiting for is not yet committed
2008 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2010 2003-10-27 Jean-Pierre Roux
2011 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2012 00191113.dcm DermaColorLossLess.dcm
2013 MxTwinLossLess.dcm RadBWLossLess.dcm
2014 * ENH: For version prior to vtkImageViewer2 -r 1.19
2015 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2017 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2018 * Removal of ido stuff in CMakeLists.txt
2020 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2022 * FIX: remove a call to ->Modified ... see comments
2023 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2025 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2026 * FIX: Problem with path for libvtkgdcmPython
2027 * ENH: Try adding a search script for python site-package
2028 * RMV: Remove some file from medcon lib that are not necessary
2029 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2030 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2031 * FIX: More pragma disable fro VC++,
2032 I don't think I break something as it is also disable in VTK/ITK.
2033 But it fasten debug compilation time.
2035 2003-10-23 Jean-Pierre Roux
2036 * gdcm now deals with 16 Bits Run Length Encoded images
2037 (they are compressed as 2 planes images,
2038 one for the high Bytes, the other for low Bytes)
2040 2003-10-22 Jean-Pierre Roux
2041 * Now CheckRead takes into account :
2042 - the bugged 'Leonardo' Siemens images
2043 - the XA images, sent thru the burning VPRO station
2044 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2047 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2048 * FIX: When copying a Makefile.am to CMakeLists.txt
2049 one should remove the '\'
2051 2003-10-22 Jean-Pierre Roux
2052 * in gdcmData adding a bugged 'Leonardo' Siemens image
2053 (wrong lengths in header)
2054 OK with gdcm, KO with the other viewers :-)
2055 * add a GE dlx XA image, thru the VEPRO burning station
2058 2003-10-21 Jean-Pierre Roux
2059 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2060 for a brutal checking of vtkgdcmViewer compliance
2062 2003-10-21 Jean-Pierre Roux
2063 * add the files for 'xmedcon' Jpeg Lossless library
2064 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2066 2003-10-21 Jean-Pierre Roux
2067 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2069 2003-10-21 Jean-Pierre Roux
2070 * garbage Siemens 'Leonardo' images dealt with
2071 (the patch is easy to remove)
2072 * cosmetic changes to avoid warnings
2074 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2076 no need to press 'r' now.
2078 2003-10-20 Jean-Pierre Roux
2079 * upgrade of checkRead.sh checkWrite.sh according
2080 to new Jpeg Lossless decompressor
2081 * add US.3405.1.dcm, a genuine RGB medical file ...
2082 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2083 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2085 2003-10-15 Jean-Pierre Roux
2086 * general anonymisation in gdcmData
2087 * adding the 'color files' from
2088 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2089 * adding some well knowed bugged-header images
2090 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2091 waiting for their inclusion in Python testsuite
2093 2003-10-15 Jean-Pierre Roux
2094 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2095 no longer seg faults when file is not found
2097 2003-10-14 Jean-Pierre Roux
2098 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2101 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2102 * TODO: *.in file to genereate a UseGDCM later
2104 2003-10-14 Jean-Pierre Roux
2105 * Some supposed-to-be Dicom Images have no preamble.
2106 OpenFile takes it into account
2107 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2108 * Missing elements added in dicomV3.dic
2109 (just to be affraid : have a look at
2110 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2111 and do it again next year ;->
2113 2003-10-13 Jean-Pierre Roux
2114 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2115 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2116 But there are NOT. It's fixed !
2118 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2119 * FIX: "jpeglib.h" was not found on VC++
2120 * FIX: vtkgdcm was not being installed
2122 2003-10-10 Jean-Pierre Roux
2123 * ENH : OpenFile closes the file if it *really* doesn't look like
2124 an ACR-NEMA / DICOM one.
2125 * FIX : testWrite no longer writes an empty file if the source file
2126 is not gdcm Readable
2127 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2130 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2131 * FIX: CMake generate now documentation
2132 * ENH: out of source doc build !
2133 * ENH: Generate both user and dev documentation
2134 * ENH: Should work on windows too
2135 * ENH: Only one doxygen config.in file is needed
2136 * FIX: make install should be ok now on ùnix plateform
2137 * FIX: PATH to dictionary was wrong (missing /)
2138 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2140 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2141 * vtkGdcmReader is now able to read rgb dicom file.
2142 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2143 * added a gdcmViewer to vtk test, use mouse to control
2144 window level & window width
2146 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2147 * CMake-ification of gdcm, we have now two build system
2148 * FIX: on cygwin Wsock32 doesn't exist
2149 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2151 2003-10-06 Emanuel Ollart
2152 * FIX : compilation process wad broken.
2153 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2155 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2156 * change gdcmViewer -> vtkgdcmViewer
2157 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2159 2003-10-06 Jean-Pierre Roux
2160 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2161 ( e.g : well known GE images with a wrong elem length,
2162 : Philips MRI Images with a wrong Huffman table)
2163 * still to be done : allow the reading of bugged LEONARDO Siemens images
2165 2003-10-03 Jean-Pierre Roux
2166 * Odd length strings are padded with '\0' (not with spaces,
2167 to remain compliant with already defined strings,
2168 like Transfert Syntax UID and others)
2170 2003-10-03 Jean-Pierre Roux
2171 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2172 to allow displaying RGB images (not only by affim ;-)
2174 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2175 * vtkGdcmReader is now able to read rgb dicom file.
2176 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2178 2003-10-03 Jean-Pierre Roux
2179 * A few nasty patches to allow the reading of a lot of nasty images
2180 ( e.g : well known GE images with a wrong elem length,
2181 : Philips MRI Images with a wrong Huffman table)
2182 * still to be done : allow the reading of bugged LEONARDO Siemens images
2184 2003-10-03 Jean-Pierre Roux
2185 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2187 2003-10-03 Jean-Pierre Roux
2188 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2189 to allow displaying RGB images (not only by affim ;-)
2191 2003-10-03 Jean-Pierre Roux
2192 * gdcmFile::GetImageDataIntoVector now
2193 - deals with MultiFrames MultiFragments Run Length Encoded files
2194 - deals with YcBcR (YBR_FULL) files
2195 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2196 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2198 (no sample found :-(
2200 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2201 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2202 Two reasons: - clear things
2203 - third parties acces gdcm through header files, so won't
2204 suffer anymore VC++ complains
2206 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * add argv[1] in testvtkGdcmReader.cxx
2210 2003-09-24 Jean-Pierre Roux
2211 * The lines are now eigthy characters long.for
2212 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2214 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2216 char* to std::string. Thus, the use of strdup becomes useless. (see
2217 previous commis of Malaterre)
2218 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2219 before the last Malaterre's commit.
2221 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2222 * This commit should fix the Debug building under VC++, the problem
2223 was mainly a mixture of debug and release lib being loaded at startup.
2224 * I also remove a depency to a specific C function: strdup. Because I had
2225 to force the link to msvcrtd (whereas strdup is in libc).
2227 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2228 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2229 located in the gdcmCommon.h file. All use of reference of tha has been
2230 changed to now use the variable GDCM_UNFOUND.
2232 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2234 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2235 Dicom dictionary. The test suite can now be run again. Note:
2236 I'm note very happy with the " (RET)" changes. I believe this
2237 RETAINED comment should be dropped when parsing the dictionary.
2238 - PACKAGER corrected
2240 - AUTHORS updated and now in alphabetical order
2241 * Makefile.am now exports gdcm.dsw for Windoze users.
2243 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2244 * cygwin complains about missing std:: in subdir Test/
2246 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2247 * remove some methods that are now in gdcmHeaderHelper
2249 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2250 * vtkGdcmReader set spacing and origin correctly
2252 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2253 * Fix a few delete/delete[] mismatch
2255 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2256 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2257 interpretation to data given by gdcmHeader. For instance there are
2258 heuristics to get informations (look at different places).
2259 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2260 sorting DICOM images based on different strategies.
2261 * modified Makefiles accordingly.
2263 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2264 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2265 when building in debug mode
2266 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2267 src/win32/gdcmdll.dsp
2268 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2270 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2271 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2274 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2275 * src/win32/libgdcmjpeg12.dsp was not dos format
2276 * src/win32/libgdcmjpeg12.dsp :
2277 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2278 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2280 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2281 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2283 * src/gdcmFile.cxx : bug fix in affectation type
2284 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2285 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2286 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2287 symbols... future problem ?
2289 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * src/win32/libgdcmijpeg12.dsp was missing
2291 * modified gdcm.dsw accordingly
2293 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2294 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2296 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2297 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2298 commit of JPR (before his hollidays to facilitate our work).
2299 * setup.py : bug fix in code. Modifications made while the last commit
2300 of JPR. The code hasn't been tested before the commit... it's so
2301 useless to make that (for best programmer that is JPR) !!!
2303 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2304 * tagged the current version as Version0_3 (i.e. version 0.3)
2306 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2307 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2308 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2309 * *.dsp : modifications to use new libgdcmijpeg8 library
2310 * setup.py : bug fix on VTKPATH variable
2311 * PACKAGER : adding all concerning windows
2313 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2316 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2317 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2318 test suite reported error.
2319 * PACKAGER file added (describes what a packager must do when
2320 packaging a new release).
2321 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2322 * configure.in: upgraded version number to 0.3.0
2323 * fixing build of rpm (through rpm -ta):
2324 - Doc/Makefile.am exports proper doxygen files
2325 - src/jpeg/libijg8/Makefile.am exports the include files.
2327 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2328 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2329 * src/gdcmHeader.h : formatting code
2331 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2332 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2333 We were obtaining error message from vtk. Now, creation of file list
2334 is made in an internal list to prevent this problem.
2335 Bug fix when output is empty.
2336 Bug fix in update of progress value. Previous commit for this was a bad
2338 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2340 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2341 * src/gdcmHeader.h : added method to get the file name
2342 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2343 files. Added method to remove all files on the input
2344 Added FIXME comment concerning the bad parsing of header made by
2345 ExecuteInformation method (in ExecuteData method)
2347 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2349 when using make instal.
2350 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2351 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2353 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2354 * setup.py : adding include dir of jpeg lib to compile all sources
2355 * */Win32/*.dsp : JPR fix for windows compilation
2357 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2360 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2361 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2363 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * setup.py is again effective on un*x (takes into account the
2365 addon of the jpeg library)
2366 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2367 * Doc/Doxy* updated (includes above enhancements)
2368 * INSTALL now points to web documentation
2370 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2371 * src/gdcmHeader.h doesn't make unnecessary reference to
2373 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2375 * src/gdcm*.[cxx|h] :
2376 - to allow compilation with gcc 3.x
2377 -- clean up of STL usage (added explicit usage of std::)
2378 -- small fixes on exceptions.
2379 Note: linking not tested !
2380 - clean of doxygen comments to avoid warnings at documentation
2382 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2383 dependent convertion).
2385 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * Clean up of previous JPR garbage commit (not even commented in the
2388 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2389 - moved all jpeg related files from src to src/jpeg/libijg8, with
2390 addition/modification of Makefile.am and configure.in.
2391 - the testSuite is still brain damage (not guilty).
2393 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2394 * WrapVTK.py : modifications to get correctly vtk source files to
2396 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2397 (FileName -> Filename)
2399 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * vtk/vtkGdcmReader.[cxx/h]:
2401 - UpdateProgress method should now be effective
2402 - removed the limitation on having only images loaded (as opposed
2404 - when building a stack of images/volume, a lesser number of
2405 gdcmHeader and gdcmFile instances should be used (hopefully
2406 accelerating things).
2407 - when building a stack of images/volumes, files which are not
2408 loadable (wrong path-filename, wrong permissions on existing file,
2409 or file not parsable by gdcm) are replaced with a black image
2410 in the stack (for the caller to notice the problem).
2412 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2415 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2416 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2417 between standard library (std) and vtk library (problems are found
2418 under Windows... thanks Windows !)
2420 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2423 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2425 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2428 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * When compiling with distutils (see setup.py) the C++ compiler is
2430 called with different flags than the default ones (with automake).
2431 In order to fix all those warning, I compiled gdcm with the command
2432 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2433 and went for warning fixes:
2434 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2435 up from unused variables.
2436 - vtk/vtkGdcmReader.cxx: potential bug fix.
2437 * src/gdcmHeader.h: Doxygen warning cleanup
2439 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * gdcmPython/gdcm.i:
2441 - typemaps correction to take into account the systematic replacement
2442 of "using namespace std" with std:: prefix e.g. std::list,
2443 std::string... (cf changes of 2003-05-21).
2444 - gdcmGlob global variable of type gdcmGlobal (defined in
2445 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2446 exported to Python a as cvar.
2447 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2448 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2449 gdcmDictSet.GetPubDictTagNames() and
2450 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2451 C++ static methods).
2452 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2453 with the above changes.
2455 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2456 * setup.py, manifest.in : bug fix under linux
2458 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2459 * Modification of setup.py to compile vtk part too. Then, we have 2
2460 wrappers which must work with same distutils. For that, we have a
2461 generic distutils in distusiltsWrapping.py ; with :
2462 - build_extWrap class to wrap generically all extensions,
2463 - ExtensionWrap base class for all wrapping extension that contains
2465 - Wrapper interface which wrap sources
2466 + In WrapSwig.py we have extension and wrapper for Swig
2467 + In WrapVTK.py we have extension and wrapper for VTK
2468 * MANIFEST.in : modifications to consider vtk directory and new python
2469 files for compilation
2471 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2472 * Added python wrappers of vtkGdcmReader vtk class (see the
2473 source in vtk/vtkGdcmReader.cxx) :
2474 - vtk/Makefile.am now builds a library
2475 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2476 python library (as opposed to _gdcm.so wich are the python
2477 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2478 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2480 - configure.in has an additional flag --enable-vtk that needs
2481 to be set to enable compilation of vtk related code, that is:
2482 + vtk/vtkGdcmReader.so and
2483 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2484 + gdcmPython/vtkgdcmPython.so (see above)
2485 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2486 be read when compressed or when HighBit + 1 != BitsStored),
2487 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2488 the usage of the python wrapper of vtkGdcmReader vtk class.
2489 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2490 * src/*.[h] all occurences of stl classes are now prefixed with
2491 std::, and all occurences of "using namespace std;" where removed.
2492 This is to avoid pollution of global namespace in included files.
2493 Apparently vtk does not avoid this pitfall: when using both
2494 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2495 collision of various stl members (principally cout...).
2496 * gdcmPython/testSuite.py now cleanly removes temprory generated
2498 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2499 comply with above changes)
2501 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2502 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2503 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2504 vtk data structure (an image Flip was required).
2505 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2506 * cosmetic changes in documentation.
2508 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2509 * src/gdcmHeader.cxx: the constructor no longer exits when an
2510 unexisting file is given as argument.
2511 * The subdirectory Data (containing all the images used for the
2512 test suite) is not part of this repository anymore. A new module
2513 containing those images is now available at
2514 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2515 with the name gdcmData.
2516 All the python scripts (including the package initialisation file
2517 gdcmPython/__init__.py) were adapated to take this change into
2518 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2520 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2521 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2522 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2523 demo of the usage of this class.
2524 Compilation of this vtk part is only done when using the --enable-vtk
2525 at configure (or autogen.sh) stage.
2527 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2528 * More memory link related corrections and documentation fixes.
2530 - maximum info is obtained with a command of the form:
2531 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2532 --show-reachable=yes PrintHeader
2533 - the remaining reachable blocks seem to come from the STL
2534 allocation scheme through the usage of map and list. It looks
2535 like this memory cannot be freed but it is not a memory leak
2536 (in fact further invocation to the STL would recollect the
2537 unused memory allthough it cannot explicitely be freed).
2538 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2539 of displaying an image parsed with gdcm and displayed with VTK.
2540 Note: some images don't seem to work e.g.
2541 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2542 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2543 Allthough this weakens the semantics, it is a ditch attempt to
2544 make gdcm more thread friendly.
2546 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2547 * Memory link hunt (by using valgrind through the command
2548 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2549 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2550 gdcmHeader::_dicom_vr.
2551 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2552 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2554 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2556 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2557 * src/Makefile.am now exports all the necessary include files at
2561 * UpdateGroupLength replaced by new one
2564 * UpdateGroupLength re-written using H-Table
2565 (named UpdateGroupLengthNew untill checks are over)
2567 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2568 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2569 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2571 - gdcmHeader::GetPubElValSet removed.
2572 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2573 UpdateGroupLength, WriteElements, Write.
2574 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2575 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2576 carried the same semantics.
2577 - src/gdcmHeaderIdo.cxx changed accordingly.
2578 - gdcmFile::WriteBase now regroups all the codes from previous
2579 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2580 - enum FileType moved to gdcmCommon.h
2581 * src/gdcmHeader.cxx AddDefault trashed
2582 * gdcmGetXSize added
2583 * getimageDataSize now calls gdcmGetXSize
2584 * Test/*.cxx changed to agree with above changes
2586 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2588 (to avoid double call by end user).
2589 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2590 by end user, since gdcmHeader::gdcmHeader now handles it.
2592 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * gdcm/Doc many doxygen changes:
2594 - Doxyfile now has two different versions, DoxyfileUsers that generates
2595 the html.users end users oriented documentation and
2596 DoxyfileDeveloppers that generates the html.developper developper
2597 oriented documentation.
2598 - README changed accordingly
2599 - requirement.txt removed (old design info moved to TODO).
2600 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2601 DoxyMainPage.txt, DoxyPython.txt provide more information.
2602 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2603 be updated by simply regenerating the docs with doxygen and copying
2604 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2605 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2606 all the tests in the form "if (<map>.count() >1)" were removed.
2607 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2608 ill-formed documentation sections.
2609 * src/gdcmHeader.cxx: ditto
2611 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * setup.py fixed for un*x (needed macro for stdint.h)
2613 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2614 un*ces with sh-utils test utility.
2615 * gdcmPython/demo/test.py renamed to PrintHeader.py
2616 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2617 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2618 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2619 * src/gdcm*.cxx JPR's bad inclusion fixed.
2621 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2623 * gdcmPython/demo/test.py changed accordingly.
2625 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2626 * gdcmPython/Makefile.am fixed linking against libstdc++
2627 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2628 * Swig subdir (historical tests of swig version 1.3.17++) removed
2629 * Test/testChangeEntete.cxx some lines commented out in order to make
2631 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2632 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2634 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2636 hence the user doesn't need this explicit call.
2637 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2638 i.e. LoadElements() call removed.
2639 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2640 - src/Makefile.am declares the proper flag for g++.
2641 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2642 for adding user defined new tags.
2643 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2644 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2645 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2647 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2648 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2649 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2650 src/Makefile.am : the project should properly compile and install
2651 with the autotools, included the python wrappers part.
2652 * gdcm.spec.in : added a spec file for RPM packaging.
2654 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2655 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2657 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2658 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2659 to exported to the environement (see gdcmPython/testSuite.py
2661 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2662 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2663 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2664 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2665 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2667 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * gdcmPython/__init__.py doesn't crash anymore when running in
2669 in InstallMode or PreInstallMode but with an environement given
2670 value of GDCM_DICT_PATH.
2671 * src/gdcmDictSet.[cxx/h] coding style.
2673 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2675 * src/gdcm.h general comments moved to TODO, and README
2676 * src/gdcm.h should now be seen as a user commodity (including it
2677 should suffice to fully use gdcm). It is nowhere including within
2678 any of the kernel files src/*.cxx and src/*.h.
2680 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2682 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2684 * src/gdcm*.cxx only include their corresponding include file
2685 (as opposed to gdcm.h)
2686 * gdcmPython/gdcm.i changed accordingly
2687 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2688 the autogen.sh generated "make snapshot" command to work.
2689 * autogen.sh removed history related references to crea package.
2691 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * distutilsSwigCPlusPlus.py work around some swig portability
2695 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2697 was done in a last ditch attempt to get setup.py _really_
2698 operationnal. The python/gdcmPython layaout add the advantage
2699 of hidding away the python related distutils specific files
2700 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2701 Alas, the src directory was out of scope (i.e. it's relative
2702 position to setup.py was ../src) which made things impossible to
2703 handle (see previous version of python/setup.py). Crossing fingers...
2705 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * python/setup.py now works on Un*x. (harder than I thougth)
2707 * python/distutilsSwigCPlusPlus.py can now have include files
2708 among the list of sources.
2710 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2711 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2712 * modifications in MSVC projects
2714 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * As stated by the first lines of Test/ExceptionAndPython/README, it
2716 looks like we can move back to original usage of exception within
2717 src/gdcm* and hence remove the errno stuff that was introduced
2718 as a quick and dirty fixture of this problem (added to the TODO).
2719 * Doc/Doxyfile configuration file for Doxygen and corresponding
2720 README file for usage added.
2721 * Test/testWrite.cxx added. This new test comes from a split of
2722 test.cxx that is now reverted to its original purpous i.e.
2723 testing the proper parsing of a Dicom related file.
2724 testWrite.cxx concentrates on testing the IO part of gdcm.
2725 * Test/bug1.cxx (containing a bug on WIn32) added.
2726 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2727 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2728 whose purpose is to publish the content of the TagNames of the
2729 Dicom public dictionnary were not accessible without an
2730 instance of class gdcmHeader.
2731 - those methods are now static methods of gdcmDictSet and hence
2732 require no instances at all to be invocated.
2733 - within gdcmDictSet this change required to change some method
2734 to class methods (i.e. are now static) among which SetDictPath
2735 (renamed to BuildDictPath) and LoadDefaultPubDict.
2736 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2737 the above changes by calling the new method classes of gdcmDictSet.
2738 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2739 the above to be effective.
2740 * python/gdcmPython: in order to wrap properly the above changes
2741 for Python, swig version now needs to be > 1.3.17.
2742 * python/gdcmPython/Makefile fixed to adapt itself to new
2743 configure/make shema introduced by Johan Montagnat (thanks for the
2744 contribution). Alas this Makefile cannot be turned into a proper
2745 Makefile.am without some heavy changes in the configure.in
2746 (for python dectection).
2747 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2748 now avoids publishing the empty entries.
2750 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2751 * python/setup.py : bug fix concerning install under windows
2752 ExtraPath reused :-P
2753 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2755 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2756 * Dicts/dicomV3.dic : remove double spaces !!!
2757 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2758 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2761 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2763 method. Doxygenation.
2764 * src/gdcm.h clean up of JPR spurious comments.
2766 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * python/distutilsSwigCPlusPlus.py now properly collects the
2768 shadow classes generated by "swig -c++" (gdcm.py in our case)
2769 when using "python setup.py install".
2770 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2771 reexports the working classes.
2772 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2773 by the classical C errno scheme. This is to prevent an obscure
2774 behavior of the python wrappers when importing wxPython.wx prior
2775 to gdcmPython (which ended up in an abort call). An illustration
2776 of this oddity can be found in the Test/ExceptionAndPython
2777 subdir (see the README file). This problem probably due to
2778 an combination of g++ and dynamic loading.
2779 * added Test/ExceptionAndPython (see above)
2781 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * Changed the layout of the python part to avoid bloating main
2783 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2784 i.e. the distutils arsenal. All the python related stuff is
2785 again in a python subdir, but the package itself is now in
2787 * setup.py was cleaned up:
2788 - pythonIncludePath removed
2789 - python setup.py bdist target is now functional.
2790 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2791 collision with other packages). gdcmPython/demo/*.py changed
2794 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * python subdir moved to gdcmPython (preparation of distutils packaging).
2796 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2797 distutils installer is operational.
2798 * - gdcmPython/__init__.py now properly loads the swig generated
2799 shadow classes (from gdcm.py).
2800 - gdcmPython/demo/*.py changed to import the package gdcmPython
2801 instead of gdcmPython/demo/load.py.
2802 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2804 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2806 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2807 entries within the associated public Dicom dictionary resp. the same
2808 information but sorted by the fourth field (PAT, IMG, DIR) of the
2810 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2811 are now in the "???" group.
2812 - python/gdcm.i changed accordingly,
2813 - python/demo/printGroupedPublicDict.py added, that gives an example
2814 of the above new functionalities in Python.
2816 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * src/gdcm.h, gdcmHeader.cxx:
2818 - historic references to glib's g_malloc and g_free (#defined)
2819 were definitively removed.
2820 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2821 * src/gdcmElValSet.cxx:
2822 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2823 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2824 - GetElValue(string) renamed to GetElValueByName.
2825 - Added GetElementByName(string).
2826 * src/gdcmHeader.cxx: added
2827 - GetPubElValRepByNumber(guint16, guint16)
2828 - GetPubElValRepByName(string)
2829 - GetShaElValRepByNumber(guint16, guint16)
2830 - GetShaElValRepByName(string)
2831 - GetShaElValByNumber(guint16, guint16)
2832 - GetShaElValRepByName(string)
2833 - GetElValRepByNumber(guint16, guint16)
2834 - GetElValRepByName(string)
2835 - GetElValByNumber(guint16, guint16)
2836 - GetElValRepByName(string)
2837 * Doc/requirements.txt added.
2839 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * Test/Makefile building now depends on the one of libgdcm.so
2841 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2842 pixel data) aware which enables finding the address (offset) of
2843 the pixel data of JPEG encoded DICOM files. This leaves only a single
2844 file in the testSuite whose pixel data address (offset) is unknown.
2845 * python/testSuite.py changed accordingly.
2847 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2848 * VC++ has some strong limitations when working with the STL, as stated
2849 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2850 "Also note that some STL containers (map, set, queue, list, deque)
2851 cannot be exported. [...]
2852 Some STL classes contain nested classes. These classes can not
2854 This is caused by a designed limitation that once a template
2855 class is instantiated, it can not be re-instantiated and
2857 Since our usage of map<> is ubiquitous in gdcm, this "designed
2858 limitation" of VC++ is a pitfall.
2859 Hence the Python wrappers of gdcm cannot be incrementally linked
2860 against the c++ dynamic library. The dirty but only workaround is
2861 to forget about incremental link of dynamic libraries and to generate
2862 the Python wrappers library with the inclusions of the underlying C++
2864 The following modifications concern this matter on Win32/VC++:
2865 - wrapping python correct with standalone wrapped dll (don't use separate
2866 dll under windows !!!!)
2867 - python21_d debug mode enabled (ask Frog how to use it :-)
2868 - NO problem with having an STL member of class for example string in C++
2869 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2870 - Python test of dcmlib in Python is ok under windows on a large set
2872 * removed glib references
2873 * typedef's inserted in gdcm.i for correct swig type management
2875 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2876 * python/demo/*.py load.py extracted from test.py. Added explore.py
2877 that only displays required tags and testAll.py that parses all
2878 the files of the testsuite without using unittest.
2879 * python/testSuite.py other additional test on new files added.
2880 * Data/* new test files added accordingly to the testSuite.
2881 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2882 the vr in the file differs from the one of the dictionary.
2884 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2886 values, but limits itself to values which are below a user specified
2887 size (by default 1024 bytes).
2888 * python/gdcm.i : elements not loaded (because their size is above the
2889 user specified treshold) are exported with their TagKey as key of the
2890 python dictionary. This enables the testsuite to make some checks
2891 on the unloaded elements (since we have their offset and size).
2892 * python/testSuite.py
2893 - now tests for the existence and proper value of the pixel data
2894 - two new examples added.
2895 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2897 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2898 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2899 aware. See the strategy comments in gdcmHeader::FindeLength().
2900 * Test/test.cxx now accepts a filename as first argument.
2901 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2902 * python/testSuite.py changed to integrate test on above files.
2904 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2905 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2906 the vr was also RET.
2907 * python/testSuite.py more tests added.
2909 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2910 * python/testSuite.py unittest test suite added (uses Data)
2911 * Data/* dcm and acr files for the test suite.
2912 * glib dependance removed from un*x version. We now use ISO C99
2913 7.18 Integer types (see stdint.h)
2914 - python/Makefile, src/Makefile src/gdcm.h
2915 * src/ when an explicit vr (like dicom files) suddenly poped an
2916 implicit element we use to mark the underlying DictEntry of the
2917 concerned ElValue with "Implicit". This strategy was damageable
2918 too the public or provite dictionaries, since some of their vr
2919 would be changed. Since Header::FindLength heavily relies on the
2920 detection by Header::FindVR of falsely explicit elements, I
2921 added an extra ImplicitVr member to ElValue (boolean).
2922 The rest of the changes we the necessary adaptations.
2924 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2927 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2929 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2930 * Adaptation for porting to VC++:
2932 o forced to use std namespace (for string to be known)
2933 o all class use __declspec export style on WIN32
2934 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2935 (in stdlib.h on Win32 but in std:: for gcc)
2936 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2937 variable GDCM_DICT_PATH.
2938 * src/gdcmHeader.cxx verbose comments made discrete.
2940 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2941 * python/gdcm.i: added a typemap that converts a C++ hashing table
2942 to native Python dictionary.
2943 * python/demo/test.py:
2944 - now uses the native dictionary for exploration of gdcmHeader.
2945 - takes an optional filename argument (the file to parse).
2946 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2947 PubElVals hashing table.
2948 * Dicts/dicomV3.dic removed error prone trailing spaces.
2950 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * Python wrapping process moved away from src/Makefile to
2952 newly created python/Makefile (as well as gdcm.i)
2953 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2954 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2955 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2956 from the environement variable GDCM_DICT_PATH (when existing).
2957 * src/gdcmDict::GetTag bug fix.
2959 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2960 * Straightforward temporary fixes for swig to build the python wrappers.
2961 src/Makefile now has a python working entry [by working we mean
2962 that we can import de shadow classes without errors].
2964 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * hashtest.cxx removed (since already in Test)
2966 * src/gdcmlib.h renamed to src/gdcm.h
2967 * src/dcm.i renamed to src/gdcm.i
2968 * src/Makefile prepared for python wrapping
2970 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2971 * src/gdcmHeader.cxx :
2972 - Parsing of header is now separated from loading of element values
2973 (see gdcmHeader::LoadElements).
2974 - general clean up of hopefully all file access (creation of
2975 ReadInt16 and ReadInt32)
2977 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2978 * src/gdcmHeader.cxx :
2979 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2981 - SetLgrElem renamed to SetLength
2982 - GetLgrElem renamed to GetLength
2983 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2984 * src/gdcmElValSet.cxx fixed both GetElValue methods
2985 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2986 due to IdoDude was cleaned out.
2988 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2989 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2990 concentrates on finding the value representation (when it exists).
2991 RecupLgr now only finds the element value length, and it avoids
2992 returning the unecessary skL (skipped length).
2993 Also, offsetCourant was simply removed (with taille_fich) since
2994 it was redundant with the File position internals (by using
2995 ftell and fseek). This also made skL (see above in RecupLgr) usage
2997 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2998 on the libido specificities which are handled through class
3000 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3003 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3004 * Truckload of changes. Parsing of header is barely functional
3005 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3007 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3008 * src/gdcmHeader.cxx many addons of low level methods
3010 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3012 and _IdDcmSWAP_LONG.
3014 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * This corresponds to all the changes decided at the meeting of
3016 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob