1 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDirList.[h|cxx] : add method to find a directory
3 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
5 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
6 * Finish cleaning up my JPEG mess. Should be ok now.
7 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
8 contained within the RLE* class(doh!)
10 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
11 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
12 * SerieHeader::AddFileName() creates as many Coherent Files lists
13 (same Serie UID) as it founds different Serie UID
14 amongst the files instead of discarting any file
15 that doesn't match with the first one he found.
16 * SerieHeader::OrderGdcmFileList has now one parameter :
17 the Coherent Files list the user wants to sort
18 * SerieHeader::GetFirstCoherentFileList() |
19 * SerieHeader::GetLastCoherentFileList() | allow to parse
20 the set of Coherent Files lists
21 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
22 compatibility (it returns the *first* Coherent Files list,
23 since there was only one before)
24 * Test/TestSerieHeader gets gdcmData as a default root directory
26 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Remove friend between DocEntry and File classes
28 * Remove friend between PixelReadConverter and RLEFramesInfo,
31 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
33 0002|0000. The value was incorrect.
35 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
38 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmUtil.cxx : compilation fix on Win32
40 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
41 variable, to be easy found. Add methods to change the default UID.
42 Amelioration of the CreateUniqueUID to use the correct default UID.
43 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
46 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Test/TestVR.cxx : fix memory leaks
49 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
50 * Rewrite the base 256 to base 10 conversion, using string operation only.
51 This allows us to get rid of the problematic 64bits integer type (does not
52 always exist on target platform).
54 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
55 * Add construct and destructor to class gdcm::Debug to close the debug file
57 * Don't let uset to open twice the same file
58 * gdcm has now an official UID prefix,
59 supplied by http://www.medicalconnections.co.uk
60 1.2.826.0.1.3680043.2.1143
61 (Thx to Mathieu for providing URL)
62 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
63 to be able to perform some more tests
64 * gdcm::ContentEntry : Contructors and Destructor are now protected,
65 in order to be sure no user will try to use them.
66 (at user level, only the children classes are meaningfull)
68 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * move RLEInfo & JPEGInfo from Document to File
71 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * FIX : remove so many friend between classes
74 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
76 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
78 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
79 In order to avoid missbehaviour :
80 . gdcm::DocEntry is now specialized in
81 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
82 - gdcm::ContentEntry (Dicom entry with a 'content')
83 . gdcm::ContentEntry is specialized in
84 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
85 characters value, or integers)
86 - gdcm::BinEntry (Dicom entry with a non strig representable value
87 (user hasn't any longer to thing about the precedence of his dynamic_casts)
89 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Test/VTKTest*.cxx : bug fix under linux
92 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
94 use with python. Some methods are moved from Document to ElementSet or
95 DocEntrySet. The equivalent methods to ElementSet have been added to
96 SQItem and are virtual in DocEntrySet. Methods that may have the same code
97 in SQItem and ElementSet is directly placed in DocEntrySet
99 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Test/VTKTest*.cxx : remove the show variable in each test method because
101 it's useless (the viewer variable replace this variable)
103 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmDocument.cxx : bug fix on potential memory leak
105 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
106 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
107 Add ClearXxx methods to remove all the content of the list or map
108 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
110 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
111 * methods ReplaceOrCreate renamed as Insert
112 (nobody will be any longer confused by 'CreateOrReplace')
114 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
115 * Grealty simplify the JPEg decompression, no need to differenciate based on
116 the JPEG possible type (with/without fragment, with/without multiple frame).
117 Everything is done throught the JPEG IO Suspension mechanism in IJG
119 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 * Stage 3 of normalization :
121 in order to avoid any missunderstanding while reading method names :
122 - All the methods xxxEntry now deal with dicom Entries
123 - Methods GetEntry splitted into
126 - Method SetEntry renamed as SetEntryValue
127 - Method SetEntryBinArea let as it was
129 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
130 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
131 - Position correctly the entry points for JPEG2000 and JPEG-LS
132 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
134 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
136 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
137 with other method names
138 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
139 * Test/TestDicomDirElement.cxx : add new test
141 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
142 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
143 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
144 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
145 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
146 So can't you use __int64 in ostream at all.
148 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * bug fix for compilation on MSVC6
150 * gdcmPython/gdcm.i : rename of classes missed
152 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
153 * Stage 2 of names normalization :
154 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
155 (easy to understand ...)
156 - gdcm::FileHelper replaces old class gdcm::File
158 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
160 type and not a string. So, there remove problems on the format of the
163 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * Add Example/TestPapyrus.cxx
165 - reads a Papyrus file (gdcm::Header compliant),
166 - gets the pixels of all the images, using low level iterators
167 - writes an multiframes Dicom image.
168 (Just to show it's *possible* to do that)
169 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
172 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
174 Thus, DicomDirXXX are created with a flad that indicates if the created
175 object is empty or not (when not empty, the DicomDirElement is used to
178 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
180 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
182 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
185 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
187 Remove all access to the hash-tables or lists in the objects.
189 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
191 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
192 be complient with all the gdcm source code
194 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
198 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
202 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * Test/ : rename VTK tests to have a best name for the tests
204 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
205 GetFirstEntry/GetNextEntry use
207 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
208 * In SerieHeader::ImagePositionPatientOrdering()
209 // a Dicom 'Serie' may contain scout views
210 // and images may have differents directions.
211 // -> More than one may have the same 'pos'
212 // Sorting has then NO meaning !
213 Thx to Eduardo Davila for reporting bug.
215 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
217 test. Now it's on image content and not on the resulting visualisation...
218 might solve the problem on linux when using the OpenGL drivers
220 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
221 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
222 DicomDirSerie, DicomDirImage
223 Dict, DictSet classes :
224 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
225 -remove InitTraversal method.
226 * UPD Test programs + Example programs
228 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
229 * remove useless and never updated keyword \ingroup
230 * Solve pb when structure (list, map, ...) is empty.
231 Thx to Benoit for reporting bug
233 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
234 * Taking into account of 'Transfer Syntax' value
235 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
238 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
240 is no memory access violation
241 * gdcmPython/demo : add python demos using VTK
243 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
244 * FIX 'Dictionnary' is now spelt 'Dictionary'
245 'wether' is now spelt 'whether'
246 'archieve' is now spelt 'archive' ;-)
248 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
249 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
250 related methods, in order not to expose internal mechanisms
253 * REM methods that exposed internal mechanisms :
254 DicomDir::GetDicomDirPatients()
255 DicomDirPatient::GetDicomDirStudies()
256 DicomDirStudy::GetDicomDirSeries()
257 DicomDirSerie::GetDicomDirImages()
258 * UPD Test programs :
262 * UPD Example program
264 * ADD DictSet methods
268 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
269 * Removed the Print/indent/default parameter mess. There is absolutely no
270 reason to have to methods, moreover with the second taking the ostream as
271 *SECOND* parameter. This was clearly a bad hack to get things compile.
273 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
274 * Complete rewrite of the GetMacAddress code. Now the code is *much*
275 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
276 Unfortunately the main code does not work on SunOS, thus provide a specific
277 code for this platform only (and Win32 of course). Since this seems to be
278 working, change CreateUniqueUID to use GetMACAddress instead of the
279 problematic GctestetIPAddress
281 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 * Unfortunately to be able to test gdcmDirList I had to break the API
283 a little. Now the class is not a std::list anymore but has a member
284 std::vector (more ITK compatible). Allow unit testing on Win32 and
287 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
288 * Update SerieHeader to take into account a Serie Instance UID to properly
291 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
292 * ENH - Comment out Mathieu's (dangerous) Super Hack
293 for dealing with BIGENDIAN processors
294 - Move equivalent stuff to BinEntry::WriteContent
295 When necessary, 16 Bits Pixels are swapped in a small buffer
296 and then written. This avoid allocating a huge buffer, in
297 PixelWriteConvertor, and avoid modifying the Pixel Area.
299 Probabely, the same operation will have to be done when we want
300 to write image with Big Endian Transfert Syntax,
301 and we are working on Little Endian Processor
303 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
306 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
307 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
308 all the dict content.
309 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
311 * Test/TestDict.cxx : add a new test for the dict classes
313 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
314 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
315 file. Debug is yanked if compiled with NDEBUG
317 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
318 * src/gdcmDictSet.h : set the default output to the os variable
319 * src/gdcmDictEntry.[h|cxx] : add the Print method
320 * gdcmPython/demo/ : add a new test
322 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
323 * merging of Test/PrintDicomDir and Test/TestDicomDir
324 * removal of now redundant Test/PrintDicomDir
325 * enhancement of Example/PrintDicomDir
327 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * Now, python test might work on systems
329 * Add the PrintDicomDir test
331 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
332 * FIX : First entry following group 0002 was lost for
333 Explicit Big Endian Transfer Syntax files
334 (group and elem not swaped)
336 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
337 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
338 Big Endian Transfer Syntax supposed the group following 0002
339 begins always by element 0000 (element 0000 is *optional*)
340 To avoid further troubles, let's be pessimistic, and use
341 Document::HandleOutOfGroup0002() method
342 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
343 (related pb not yet solved)
345 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * Bug fix for the python part use
347 * Now, PrintHeader.py pass... but outside the ctest use. shit !
349 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
352 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
354 a string and should ask the global TS dict what are the propreties of
357 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
358 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
359 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
360 to swap the Swap Code, at parsing time, when we come out of group 0002
361 and Transfer Syntax is Big Endian
362 We should be able to read now 'true DICOM" Big Endian coded images
363 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
364 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
366 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
367 * Hopefully fix the bug on MacOSX and static global initialization.
368 This is the only -minor- patch I found that both please MacOSX and VS6.
369 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
370 but this would require a lot of change. Another approach would be that Global
371 create those string and GDCM_UNFOUND becomes a pointer to a string (which
372 gdcm::Global would destroy at exit).
374 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 * Fix bug on MacOSX with static initialization in a multy threaded
376 environment. static const string in a header file used to be ill
377 initialized provoquing the freeze of any tests. patch should solve this
380 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
381 * According to Benoit's suggestion, and without any objection from anybody
382 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
383 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
384 - method gdcmDicomDirObject::GetEntry() renamed as
385 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
387 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
388 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
389 you debug/warning message just as c++ streams which make them very convinient
390 to use. Once this is stabilize I will change the ostringstrem to be
391 redirected to a file (ofstream).
392 * Properly support C99 extension: __FUNCTION__ which allow us to display
393 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
395 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
396 * Removal of useless and dangerous methods :
397 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
398 GetDocEntryByName, GetEntryByName, GetDictEntryByName
399 * Removal of usless methods :
400 Dict::PrintByName, Dict::GetDictEntryByName
401 * Commenting out of probabely useless methods :
402 Dict::GetDictEntryNames()
403 Dict::GetDictEntryNamesByCategory()
404 DictSet::GetPubDictEntryNames()
405 DictSet::GetPubDictEntryNamesByCategory()
406 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
407 * ENH : Use dicomTS.dic as described in 2004 version
408 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
409 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
410 Add Accessors on VM (Value Multiplicity), and VM related methods
411 * ADD : Add a list of 'Dicom Attribute types', as found in
412 http://medical.nema.org/dicom/2004/04_15PU.PDF
414 * ADD : Add dicomGroupNameAbbreviations.dic
415 should be used to write a method to replace the former
416 Dict::GetDictEntryNamesByCategory()
418 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
420 to read in the file... and only it ! Length is the efective length of the
421 data in the DocEntry structure
423 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
424 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
425 And now use a static function call instead, with a global variable. i
426 This is much closer to the VTK approach. Hopefully should be bulletproof
427 and easier to use...hopefully
429 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
432 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
435 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
437 ValEntry, BinEntry, SeqEntry creation or replace
439 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
441 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
443 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
444 when specifying the VR
445 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
446 * src/gdcmDocEntry.cxx : amelioration of print
448 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
449 * ADD : Add the method Util::IsCurrentProcessorBigEndian
450 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
451 * ADD Method Document::ComputeGroupLength
452 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
453 in order to allow further VR modification by user
454 * REM : removal of once-called method File::WriteBase
455 integration of its code in formerly one-line method File::Write
457 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
459 replace the different values "??", "Unkn", "Unknown".
460 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
461 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
462 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
463 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
465 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
468 * Set the gdcm::Base class to some Printable classes
470 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * src/gdcmFile.[h|cxx] : add the Print method
472 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
473 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
474 * src/gdcmDocument.h : remove the PrintLevel informations
475 * Example/PrintFile.cxx : use the new gdcm::File::Print
477 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
478 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
479 problems when compiling with the python wrapping
481 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
483 writting in ImplicitVR
485 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
486 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
487 JPEG decompression, especially when dicom frames are split into several
488 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
489 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
491 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
492 * src/gdcmHeader.cxx : change the initialisation of default header.
493 Now, this header is readable by gdm, e-film, DicomWorks
495 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
497 Rename Decompressed to Raw
498 * Use the API changes in gdcm::File.
499 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
502 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
504 each added entry in the header. Replace the 'Planes' field by the 'Number
507 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
509 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
511 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
513 At this time, this image isn't readable by e-film... waiting JPR help to
516 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
517 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
518 DocEntry. Now use methods of the Document !
520 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * Test/ShowDicomSeq.cxx : bug fix
523 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
525 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
526 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
527 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
529 * Test/TestCopyRescaleDicom.cxx : remove unused variable
530 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
531 containing found sequences
533 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
534 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
536 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
537 Some fields in BinEntry must be copied to not seg fault when making the :
538 gdcm::File *copy = new gdcm::File( copyH );
539 and tests are now made on good variables
541 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
543 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
545 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
546 * Add vtkGdcmWriter example and test
548 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * Test/TestUtil.cxx : reformat the source code
550 * vtk/vtkGdcmReader.cxx : remove and change prints
551 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
553 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
554 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
556 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
557 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
558 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
560 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
562 by an eof to prevent all bad read of the file... and in this case, the
565 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
566 * Example/Volume2Dicom.cxx : comment unused variables
567 * Test/PrintDicomDir.cxx : comment unused variables
568 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
569 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
570 method that is redondant with AddEntry.
571 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
574 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * Bug fix due my last commit (compilation under Windows).
576 * Example/Volume2Dicom : bug fix in the file and reformatting source code
577 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
579 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
581 - Remove printf / sprintf
582 - include iostream AFTER gdcm so we don't get warnings
583 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
585 - Also remove tons of include from header files, hopefully this should
586 speeup the compilation time, since it was becoming a dog slow.
587 - Remove gdcm.h as it include way too many files and slow down compilation
588 (plus it is not up to date)
589 - remove 'using namespace std' this is BAD !
591 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * Remove memory leaks on the DicomDir
593 * Remove some useless data in DicomDirObject
594 * Add usefull methods in SQItem, to be complient withe the ElementSet
596 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
599 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
600 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
601 future, with convertion)
602 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
603 and ImageDataSize values. Remove the method to get the PixelReadConverter
604 from the output of the class
606 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
609 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
611 and vtkErrorMacro use.
612 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
614 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
615 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
617 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
618 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
619 The string leaves only in the fonction. So when we make a .c_str(), we
620 get the pointeur on the first element, element that will be destroyed
621 immediately after thee instruction.
622 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
623 file has been opened : the test must be made on the content of the
624 pointer and not directly on the pointer !
627 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
629 the python part recompiles
631 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
632 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
633 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
634 X session is killed (for my computer... it seems to not be identic on
637 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
639 avoid problems (otherwise, the difference test between the visible image
640 and the reference is incorrect. If the reference is greater than the
641 screen resolution, it's produce errors).
642 Can be used for only one image. Can be used with a visible flag.
643 * vtk/vtkGdcmReader.cxx : remove commented codes.
644 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
645 under windows at compilation
646 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
648 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
650 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
652 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
653 tests on the image size X, Y, Z
655 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
657 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
658 between the class name and the file name
660 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
661 * src/ : fix compilation warnings for the Write method (2 different
662 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
663 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
664 variable... create a static method in gdcm::Document to access to
665 this variable content.
667 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
669 file, to be accessed by other files (like gdcmFile). Remove commented
670 code. Move the change of the header to the gdcmFile, using the
672 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
673 To be sure of that (and simplify calls), the Write of the header now
674 gets a file name and not a file pointer (std::ifstream).
675 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
676 DocEntryArchive. Remove all open of the written file
678 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
681 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
683 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
685 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
686 some corresponding methods. Write correctly the file and check before
688 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
689 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
690 is now on RGB data (as before my last commit
691 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
693 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
695 Add a print information of the type of the entry
696 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
697 It was in the gdcmFile, and all write have been regrouped
698 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
699 Write correctly all dicom files (in decompressed mode only at this time)
700 * Test/ : test on files are now made using Raw data and not color data if
702 * Example/PrintFile.cxx : add more printings
704 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * Amelioration of code, remove some code copy. For the loading of
706 BinEntry (in gdcmDocument), add the test to verify if the file is already
709 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
711 remove a DocEntry in the header (push an empty DocEntry)
712 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
713 lines. Bug fix in the initialization of the PixelConvert and the
715 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
716 use in TestCopyDicom (now this test can run under windows... but fails)
717 * Test/TestCopyDicom.cxx : amelioration of the test :
718 - test the pixels written
719 - add test points to quickly find where is the error
720 - can set a file name input and output in arguments
721 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
722 amelioration of the test output
724 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
726 all replaced DocEntry's
727 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
728 Now, each needed DocEntry to modify is duplicated, modified and inserted
729 to the header using DocEntryArchive. Thus, after save, we can restore the
730 header initial state.
732 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
735 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
736 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
737 correct to copy it. The DictEntry is specified at the DocEntry creation,
738 then, it musn't change in the time.
739 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
740 header correctly. At this time, the change is only made for the first
741 level of the Document. In the future, it might consider sequences.
742 The change is made by replacing a DocEntry by an other that is created
743 outside the class. The old value is kept. When we restore the header
744 status, the added DocEntry is deleted and replaced by the old value.
745 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
746 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
747 set the write type to explicit VR, implicit VR or ACR. Add methods to set
748 the write mode to native, decompressed or RGB (but not used at this time)
750 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
752 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
754 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
756 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
758 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
759 set because already copied when copying the BinEntry's of the header
760 * Test/TestAllReadCompareDicom.cxx : remove warnings
762 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
764 Two problems appear when doing it :
765 - with the gdcmFile : when the GetImageData method is called, the pixels
766 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
767 data (pixels). And each structure destruct the data when it's
768 destructed. So we have two destructions for the same data. To solve it,
769 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
770 data or not. If it doesn't own data, then they will not destroyed by
772 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
773 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
774 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
775 create a double destruction of the same DocEntry's. So, to solve it,
776 the TagHT is simply cleared and the DicomDir* elements are destroyed.
777 * TODO : add an entry concerning memory leaks in the DicomDir
779 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
780 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
781 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
784 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
785 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
786 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
787 after it have been deleted
789 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * FIX: src/* fix the doxygen warnings.
791 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
792 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
793 was erroneously defined with a size of 15 instead of 16. [many thanks
794 to Jean Michel Rouet for pointing out this bug].
796 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
797 1. Finish merging JMR patch for writting DICOM from scratch
798 2. Fix -hopefully- bug with MONOCHROME and space vs null character
799 3. Use const ref when possible
800 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
801 5. A few more comments
802 6. CreateUniqueUID can now be called without parameter"
804 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
805 * ENH: Slightly bigger patch:
806 1. Getting toward full integration of JMR patch for writting dicom from scratch
807 2. Update Test to test part of this patch: CreateUniqueUID
808 3. File was not close properly in gdcmDict
809 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
810 5. Use of const ref instead of copy (speed issue)
811 6. Remove temporary (duplicate) string in TranslateToKey
812 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
813 8. Do not repeat virtual in subclasses
814 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
816 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
817 * Apply first patch toward better string comparison when dealing with broken
818 DICOM files. Essentially the string could be padded with a space instead
819 of a null character as defined by standard
821 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
823 because never used... and in the same time, that's remove some memory leaks
825 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * src/gdcmFile.cxx : now delete the PixelConvert instance.
827 * In examples and tests : change the type of image data variables from void*
828 to uint8_t*. Remmove all delete on image data variables
830 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
831 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
832 Verify the file pointer value before open the file, and if it's not null,
833 a verbose message is generated.
834 Close correctly the file when the file isn't considered dicom-like. The
835 correctly close is a call to CloseFile.
836 When closing the file pointer, test if its not null to close the file.
837 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
838 file. For an uncompressed image, the copied data correspond in the least
839 case to the image size (calculated) or the image size specified in the
840 header. A verbose is generated if these two size mismatch
842 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
843 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
844 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
845 break under windows (with msvc6 compilation).
847 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
848 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
849 compiling with MSVC6)
851 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
852 * Bugs fix for the Windows build with VC6
853 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
854 needed (only for projects required VTK). If the VTK is included in all
855 projects, there is conflicts with the jpeg lib of vtk when compiling the
856 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
857 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
858 when compiling the gdcm_wrap.cxx file (created by the compilation of the
860 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
861 (like it's already made for the cout use). Otherwise, conflict with the
864 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
867 - comments on the DicomDir::Method related usage added.
868 - now that we use the namespace gdcm, a lot of internal classes do
869 NOT need to be wrapped anymore.
870 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
871 DicomDir::Method) new example added.
873 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
874 * Improve string manipulation. I now inforce the notion of 'DicomString'
875 A DicomString can contain as many \0 as they want
876 and it is *always* of even length.
877 We only support odd length for very rare case.
878 And in the near future this should be removed.
880 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
881 * /binary_write/ gdcm source. Now even on big endian we are writting
882 little endian. This should -heopfully- fix some tests
884 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
885 * Now the dictionary is compiled into gdcm lib. This is a default
886 behavior, thus any dic file specified is picked before failback to
887 the one comiled into lib
889 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 * Change internals for gdcmDict. Don't use any 'new' any more.
891 This should definitely solve any leak problem, and we should be
892 as fast as before, as long as don't modify too much the dictionary.
894 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
895 * STYLE: ivars should start with a capital letter.
896 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
897 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
899 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
901 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
902 new 2004 dictionaries added (thanks to JPR).
903 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
904 * CLEANUP_ROUND (15) for gdcmPixelConvert
905 - RLEFrame::NumberFragments is now of type unsigned int
906 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
907 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
910 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Initial work in gathering all transfer syntax accessors. clearly
912 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
913 ivars, but only one transfersyntax (class) ivar with equivalent method on
916 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
917 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
918 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
919 discussed (plus I didn't like having a 2000 lines patch not commited)
921 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
923 * CLEANUP_ROUND (14) for gdcmPixelConvert
924 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
925 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
926 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
928 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
929 anymore and hence avoids storing a copy of PixelConvert::Decompressed
930 into File::Pixel_Data.
932 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
934 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
935 * CLEANUP_ROUND (13) for gdcmPixelConvert
936 Substituted File::ParsePixelData() with PixelConvert::Print() new
938 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
939 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
940 method to those classes.
941 - src/gdcmFile.[cxx|h]:
942 -- Added a ::Print() method.
943 -- PixelConverter is now a reference instead of a member.
944 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
945 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
947 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
949 collaboration diagram and inheritance diagram should be generated with
951 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
952 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
953 pointlessly wrapped (see
954 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
955 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
956 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
957 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
958 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
959 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
960 -- File::Initialise: PixelConverter setup moved away to
961 PixelConverter::GrabInformationsFromHeader()
962 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
963 interpretation moved away to PixelConverter::BuildRGBImage()
965 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
966 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
967 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
969 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
971 displayed on Win32 when a brutal abort() occurs (because of uncatched
972 exception). See TODO new entry of this commit for more on this.
973 * TODO added new entry.
974 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
975 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
976 - HandleColor is no longer called from gdcmFile.cxx
977 - gdcmPixelConvert.cxx clean up on method arguments and internal
978 variable names for semantical coherence.
980 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
981 * Finished lossless transition, not only do we now read all lossless jpeg
982 images, without the need of the Cornwell lib, but we do read them properly now
983 * To reduce code (well to avoid code duplication), I defined a common place
984 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
985 redefine symbols. This is not perfect but this the best solution I found for a
986 compilation time jpeg option.
988 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * Update jpeg ijg lib to support lossless jpeg implementation
990 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
992 * Also added a special copyright for dcmtk since we use their bugfixes.
995 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
997 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
998 matters, as stated in warning note at beginning of %include section).
999 * src/gdcmDicomDir*.[cxx|h]: coding style
1000 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1001 * src/gdcmJpeg8.cxx: doxygen fix.
1002 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1003 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1004 from File:: to PixelConvert::.
1006 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1008 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1009 - more code moved away from File:: to PixelConvert::
1010 - fat setup of PixelConverter set in place in File::Initialise.
1012 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1014 namespace at the file system level. So now you should convert your examples
1016 gdcmHeader -> gdcm::Header
1017 It would be nice if people keep in mind to no open the namespace, since it
1018 allows compilation on broken plateform which were defining common symbol in
1019 the standart namespace (like LP, Unknown ...)
1021 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1023 The JPEG fragments are now parsed at the same stage than the RLE
1024 information. All code related to JPEG is now in gdcmPixelConvert:
1025 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1026 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1027 export a gdcmFile:: method. Those are simply global functions
1028 (for the time being this is better than having them attach to
1029 either gdcmFile:: or gdcmPixelConvert::).
1030 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1031 and stores the result in a gdcmJPEGFragmentsInfo.
1032 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1033 code (among other stuff) moved away from gdcmFile:; to
1036 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1038 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1039 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1040 clean up of RLE related code.
1041 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1042 - src/gdcmRLE.cxx removed
1043 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1044 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1045 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1046 * CLEANUP_ROUND (9) for gdcmPixelConvert
1047 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1048 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1049 away from gdcmFile:: to gdcmPixelConvert::.
1051 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1053 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1054 This is because Parse7Fe0 used to parse the pixels to compute the
1055 length. This task was passed over to FindDocEntryLengthOB() a long
1056 time ago, EXCEPT I had forgotten the OW case...
1057 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1058 we just recylce the code for parsing RLE fragments and computing
1060 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1061 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1062 with the retired Parse7Fe0().
1063 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1064 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1066 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1068 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1069 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1070 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1071 * CLEANUP_ROUND (4) for gdcmPixelConvert
1072 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1073 to return an unused length.
1075 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1077 this should be cleanner from the plane view. The iostream are erally a pain
1078 to use to do simple stuff.
1080 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1081 * Redo the compilation of the ijg jpeg library. Now only one source is
1082 necesseray. No need to rename file by hand what so ever. CMake handle the
1083 copying of the file within different directory, configure header file to
1084 modify some symbol. The only addition made to ijg wasd a mangle table so
1085 that symbol are different whether we are within 8bits or 12bits.
1087 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1088 * Added documentation of vtkgdcmReader on Website:
1089 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1090 with it's binary name).
1091 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1092 the Website to be more complete.
1093 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1094 doxygenated documentation.
1095 - Doc/DoxyVtkGdcmReaderExamples.txt added
1096 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1097 DoxyVtkGdmReaderExamples.html )
1098 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1099 * CLEANUP_ROUND (3) for gdcmPixelConvert
1100 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1102 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * CLEANUP_ROUND (2) for gdcmPixelConvert
1104 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1106 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * CLEANUP_ROUND for gdcmPixelConvert:
1108 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1109 - src/gdcmPixelStuff[h|cxx] removed
1110 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1111 - src/CMakeLists.txt changed accordingly
1112 * GDCMHOME clean up:
1113 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1114 gdcmVersion.py moved to newly created ATTIC related
1115 gdcmPython/SetupOldies/ directory.
1116 * Autotools clean up:
1117 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1118 - autogen.sh configure.in acinclude.m4 python.m4 removed
1120 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1122 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1123 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1125 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1126 * TODO updated with Mathieu suggestions. I proposed a template for
1127 describing TODO entries and used it for new entries.
1128 * Added Doc/Website/CodingStyle.html, Developpers.html,
1129 DeveloppersPython.html, GdcmDataCvs.html and
1130 DownloadVersion0_1.html, DownloadVersion0_3.html.
1131 * Some Doc/*.txt Doxygen files (which do not really concern the
1132 documentation itself, but the website) moved to html and
1133 placed in directory Doc/Website:
1134 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1135 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1136 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1137 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1138 * CMakeLists.txt changed accordingly.
1139 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1140 DeveloppersPython.html
1141 * INSTALL nows refers to Doc/Website/Installation.html
1143 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * Added Doc/Website directory, that contains a first raw version
1147 2004-09-23 Jean-Pierre Roux
1148 * FIX In order not to be poluted any longer by casting problems,
1149 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1150 we can now delete[] it safely
1151 * VoidArea is now called BinArea (less confusing name),
1152 and all the methods called ...VoidArea... are now ... BinArea...
1153 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1155 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1157 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1158 up to the destructor of gdcmElementSet to clean up TagHt and it's
1161 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1163 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1165 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * ENH: added some utility method that builds a flat dictionary
1167 holding all the Dicom entries contained in the recursive structure
1168 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1169 an example of usage.
1170 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1171 BuildFlatHashTable() that build a flat dictionary.
1172 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1173 gdcmDocument is now a friend of gdcmElementSet.
1174 - src/gdcmElementSet.cxx: clean up.
1175 - Example/FlatHashTablePrint.cxx added.
1176 - Example/CmakeLists.txt changed accordingly
1178 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1180 moved away from gdcmDocEntrySet (since this class is an abstract class
1181 acting like an interface). SQDepthLevel and BaseTagKey are now
1183 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1184 and associated accessors. Doxygenation of the class.
1185 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1187 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1188 Use SQDepthLevel accessor instead. ::Print() adapted.
1189 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1190 - src/gdcmDocument.cxx changed accordingly.
1192 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1194 - The following is the doxygen comment of the typedef declaration
1195 of gdcmTagKey in src/gdcmCommon.h:
1196 gdcmTagKey is made to old an "universal" (as in URL, Universal
1197 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1198 A dicom tag always has a group and an element, but a set of tags
1199 embeded in various (optionally nested) sequences and sharing
1200 the same group and element all share the same (group, element)
1201 "identifier". Hence the (group, element) cannot be used as an
1202 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1203 In order to construct a proper tag identifier (i.e. a key) we
1204 consider the following definition of a TagKey:
1205 - let Group, Element be the string representation of the
1206 group and element dicom tag members,
1207 - let ItemNumber be the string representation of the integer
1208 index of the considered item number of a sequence,
1209 Let the key of a tag embeded in a sequence, noted SeqTag, be
1211 /ItemNumber#Group|Element
1212 where "/", "#" and "|" are characters acting as separators.
1213 Then the general form of a gdcmTagKey is given by:
1214 Group|Element<SeqTag>
1215 where <SeqTag> means NO or many instances of SeqTag.
1216 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1219 but the gdcmTagKey of a tag "embeded" is the first item of
1220 a sequence, itself nested in the third item of a sequence is the
1222 0004|1220/2#0008|0082/0#0008|0090
1223 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1224 order to hold the new sequence compatible key. Previously, the
1225 GetKey() method would look in the underlying gdcmDictEntry.
1226 - src/gdcmDocEntry.cxx:
1227 -- constructor now copies the underlying DictEntry key, in the local
1229 -- ::Print: displays the member Key, instead of the (group, element).
1230 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1231 - src/gdcmDocEntrySet.h:xi
1232 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1233 -- now has a new BaseTagKey member.
1235 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1236 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1238 This poses the problem with the semantics of the following lines
1239 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1240 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1241 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1242 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1243 to the long FIXME note for what the problem is. Nevertheless in
1244 order to get things working the dicom dictionary was altered !
1245 Please fix things urgently...
1246 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1247 information), see above note on moving the member VoidArea. Nevertheless
1248 the following entries previously correctly set as US are now inproperly
1250 0028 1201 OW IMG Red Palette Color Lookup Table Data
1251 0028 1202 OW IMG Green Palette Color Lookup Table Data
1252 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1253 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1254 of gdcmDocEntry moved to gdcmSeqEntry.
1255 * src/gdcmSeqEntry.cxx: STYLE.
1257 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1258 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1260 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * gdcmPython/testSuite.py: all the test suite in python is now moved
1262 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1263 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1264 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1266 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1268 to avoid inclusion recursion until STL is reached.
1269 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1270 mecanism. errno.h is not included in gdcm anymore.
1271 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1272 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1274 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1275 gdcmData/TestAllEntryVerifyReference.txt
1276 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1277 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1278 exception_on_error parameter.
1279 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1280 - vtk/vtkGdcmReader.cxx changed accordingly,
1281 - Example/*.cxx and Test/*.cxx changed accordingly.
1283 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1285 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1286 enable_sequences removed from gdcmHeader constructor and dependencies.
1287 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1288 * gdcmPython/demo/PrintHeader.py: dummy fix.
1289 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1290 skip_shadow removed from gdcmHeader constructor and dependencies.
1291 * Example/*.cxx and Test/*.cxx changed accordingly.
1293 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1294 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1295 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1297 2004-07-21 Jean-Pierre Roux
1298 * FIX Now, Parsing and Printing a DICOMDIR do work!
1299 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1301 2004-07-20 Jean-Pierre Roux
1302 * FIX Some brain damaged headers have Zero-Lenght fields
1303 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1305 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1306 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1307 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1308 variable (instance of gdcmDebug) by a definition macro, and the instance
1309 is now in static in the gdcmDebug class
1310 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1311 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1313 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * WARNING: ctest now depends more tightly on gdcmData. You should
1315 check out gdcmData properly for things to run smoothly...
1316 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1317 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1318 we need the pixels not be loaded in order to use the ValEntry
1319 that displays position and size).
1320 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1321 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1322 be deprecated. If you have any doubts about the advantages of a
1323 modern scripting language (read Python) versus grass root C++ (i.e.
1324 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1325 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1326 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1327 Anyhow, consider documenting the gdcmData images in
1328 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1330 * Test/CMakeLists.txt:
1331 - now uses TestAllEntryVerify.cxx
1332 - specific comments on oldACR00001.ima (now renamed in gdcmData
1333 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1334 gdcmData/TestAllEntryVerifyReference.txt
1337 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * src/*.[h|cxx] : typedef clean up
1339 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1340 - TagKey renamed to gdcmTagKey (for external usage)
1341 - VRKey renamed to gdcmVRKey (for external usage)
1342 - removal of typedef duplication.
1343 - Removed all unecessary inline keyword from class inline definitions.
1344 - Some method|function(void) declarations replaced with method|function().
1345 * src/jpeg/libijg12/jdhuff12.c:
1346 - printf polluting ctest removed.
1347 - TAB removal for comminting
1349 - TestAllReadCompareDicom.cxx: added a test that compares all the
1350 images in gdcmDataImages.h with corresponding images in
1351 gdcmData/BaselineDicom/. When baseline images are not present
1352 this test creates them.
1353 Note: we need to validate each reference image, but before that
1354 I'd like to rename them with a more explicit name...
1355 - CMakeLists.txt: changed accordingly.
1356 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1357 including each header needed).
1359 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1361 test suite to the Example directory. Are concerned:
1366 - TestWriteSimple.cxx
1367 * Test/CMakeLists.txt: added some comments on reasons for black listing
1368 image gdcmData/oldACR00001.ima
1370 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * Test/CmakeList.txt: removed the following from black list (to be coherent
1372 with removal from gdcmData):
1373 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1374 - gdcm-MR-PHILIPS-16.dcm
1376 Added the following because after last cvs update, they cause
1377 ctest -R TestReadWriteReadCompare
1379 - gdcm-MR-SIEMENS-16-1.acr
1381 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1382 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1383 new comments in this file) we temporarily (sigh) move to a weaker
1385 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1386 we don't need to black list the following images anymore:
1387 - 8BitsUncompressedColor.dcm
1389 - US-PAL-8-10x-echo.dcm
1390 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1391 fixes and the beautified code ;-)
1392 This fixes the bug introduced in version 1.42 (when beautifying)
1393 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1394 Note: ctest was blind to this bug (this means we need to still
1395 improve the test suite). The bug could be detected by using
1396 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1398 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1399 and by displaying the (garbage) produced file temp.XDCM...
1401 2004-06-29 Jean-Pierre Roux
1402 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1403 - replace by uggly but working old code :-(
1404 A lot of things should be OK again.
1405 It's really urgent to have a test suite that *tests*,
1406 to prevent Frog's beautifying sessions to break all the stuff
1407 (twice, withing a fortnigh ...)
1409 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1411 redundancy) to added Test/TestReadWriteReadCompare.cxx
1412 * Test/CmakeList.txt: because the compare test of
1413 Test/TestReadWriteReadCompare.cxx fails, the following images are
1414 black listed: - 8BitsUncompressedColor.dcm
1416 - US-PAL-8-10x-echo.dcm
1417 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1418 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1419 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1420 and ad-hoc kludge. This kludge is now removed, and on encountering
1421 such an image (OB field brain damaged) we set errno. Then in
1422 ::FindDocLength() we "fix" the length as being ALL what remains
1423 in the file (until EOF). We then proceed, hoping for the best...
1424 This fixes a SegFault in ShowDicom when trying to write such an
1426 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1427 (because TestWriteRead breaks on it, after a non conformal commit?).
1428 ctest now runs properly, except for MakeDicomDir (which was always
1429 broken) and the Python related stuff (still not fixed).
1431 2004-06-24 Jean-Pierre Roux
1432 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1433 FIX : Test/TestReadWrite now iterates on all the file names
1434 (instead of infinite loop)
1435 ENH : Test/TestWriteRead now iterates on all the file names
1437 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1440 2004-06-24 Jean-Pierre Roux
1441 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1442 when SamplesPerPixel =3
1443 - now Write is no longer confused by
1444 'BitsAllocated = 12" and 'BitsStored=12"
1445 - "UN" value representation Elements are now written correctly
1446 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1447 ENH : - now gdcmHeader has its own Write methods
1448 (in order to split the job that has not to be done
1451 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1453 loop on the same image until memory went out.
1454 Note: this means we still have gobs of memory loss in PrintDocument
1455 * src/gdcmDocument.cxx: fixes problem on parsing on file
1456 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1458 2004-06-24 Jean-Pierre Roux
1459 FIX : Write - All the Sequences and Sequence Item are now written
1460 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1461 is added a the end, when necessary.
1462 - A lot of brain-damaged images, that were read correctly are
1463 now written correctly
1464 - length compatible BinEntry are now loaded correctly
1465 (even for odd groups)
1466 Note : only Explicit Value Representation was checked.
1467 (question : is implicit VR really necessary for gdcm ?)
1469 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * DEVELOPPER: added a proposition of coding style.
1471 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1474 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1476 Use the gdcmDocEntry::Print() and Write() instead.
1477 * src/gdcmDocument.cxx: bug fix.
1479 2004-06-22 Jean-Pierre Roux
1480 FIX : gdcmDocument.cxx
1481 - Now we do recognize the JpegLossLess format (there was a misstyping in
1482 code 'beautyfication' :-(
1483 - Now we automaticaticaly load the Luts, if any
1485 2004-06-22 Jean-Pierre Roux
1486 In order : to write Sequences, whatever their imbrication level,
1487 : to allow user to create his own Sequences
1488 a lot of modif where necessary (adding, moving, or virtualising methods)
1490 WARNING : save your own sources *before* cvs up !
1493 ADD virtual void Write(FILE *fp, FileType filetype);
1496 ADD virtual void Write(FILE *fp, FileType filetype);
1497 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1500 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1501 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1502 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1503 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1504 ADD std::string GetEntryByName(TagName name);
1505 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1507 std::string vr = "unkn",
1508 std::string fourth = "unkn",
1509 std::string name = "unkn");
1510 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1511 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1512 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1513 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1514 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1515 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1516 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1517 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1520 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1521 ADD virtual std::string GetEntryByName (TagName tagName);
1522 ADD virtual std::string GetEntryVRByName (TagName tagName);
1523 REM virtual bool Write(FILE *, FileType);
1524 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1525 FILE *_fp, FileType type);
1526 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1527 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1528 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1529 REM virtual std::string GetEntryByName (std::string tagName);
1530 REM virtual std::string GetEntryVRByName (std::string tagName);
1531 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1532 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1533 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1535 std::string vr = "unkn",
1536 std::string fourth = "unkn",
1537 std::string name = "unkn");
1538 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1539 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1540 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1541 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1544 ADD virtual void Write(FILE *fp, FileType filetype);
1547 ADD virtual void Write(FILE *fp,FileType filetype);
1550 ADD virtual void Write(FILE *fp, FileType filetype);
1551 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1552 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1553 REM std::string GetEntryByName(TagName name);
1556 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1558 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1559 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1560 The default constructor invoked by the line
1561 gdcmHeader *f1 = new gdcmHeader( header );
1562 was gdcmHeader::gdcmHeader(bool) instead of the expected
1563 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1564 Hence the parsing wasn't executed... See also below.
1565 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1566 as explicit constructor didn't do the trick to fix the above problem.
1567 Could anyone explain why ?
1568 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1569 properly calls gdcmValEntry::Print() (that was weed out from
1570 code related to gdcmBinEntry).
1572 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1573 * In order to fix memory leaks:
1574 - Test/TestWriteSimple.cxx: added cleaning of free store through
1576 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1577 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1578 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1579 (through the call to ::AddDicomDirMeta()) or the destructor
1580 would crash when deleting uninitialized ::metaElems].
1581 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1582 - src/gdcmDocument.cxx:
1583 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1584 from dynamic stores.
1585 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1586 was causing memory leaks.
1587 - src/gdcmSQItem.cxx:
1588 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1589 cleanly handled with polymophism: sorry but my milage is low).
1590 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1591 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1592 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1593 This avoids SegFaulting.
1594 - src/gdcmSQItem.h: coding style.
1596 - Test/TestWriteSimple still severely sucks. The output image content
1597 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1598 damaged when displayed with vtkgdcmViewer.
1599 - on memory leaks: TestWriteSimple leaks really less (see entry
1600 of 2004-06-18 in Changelog file for the call to valgrind).
1601 - on segfaults: ctest now passes all the tests but one (no more
1603 * Erroneous leading white fix:
1604 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1605 white[s] (as opposed to from >> xxx, that removes it [them].
1606 - src/gdcmTS.cxx: ditto.
1607 - gdcmPython/testSuite.py: dirty related kludge removed.
1608 * src/*: remaining references to gdcmParser removed.
1609 * src/*[cxx|h]: added copy[way]left header.
1612 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1613 * In order to fix writing of dicom files:
1614 - Test/TestWriteSimple.cxx: a simpler example of writing.
1615 - Test/CMakeLists.txt changed accordingly.
1616 - src/gdcmDocument.cxx:
1617 -- The destructor now recursilvely removes potential sequences.
1618 -- Bug fix in ::IsJPEG2000()
1619 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1620 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1622 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1623 to only declared) and build on top of
1624 ::GetDocEntryByNumber(guint16, guint16).
1625 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1626 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1627 for usage in destructor and treatement of promotion in
1628 ::ReplaceOrCreateByNumber().
1629 - src/gdcmSQItem.cxx: destructor should better handle his job.
1630 Test/TestWriteSimple now runs (or at least it DOES something).
1631 * We can now start hutting memory links. A good starting point is:
1632 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1633 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1634 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1636 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1637 * Valgrind note: after Mathieu Malaterre teached me how to read
1638 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1640 Using gcc, you can force the STL to use malloc and to free memory as
1641 soon as possible by globally disabling memory caching.
1642 With 3.2.2 and later, you should export the environment variable
1643 GLIBCPP_FORCE_NEW before running your program.
1644 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1645 simply vanish (it is still not clear to me, whether this means that
1646 STL std::string leaks or if valgrind believes it leaks...).
1647 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1648 running bin/gdcmTests makeDicomDir):
1649 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1650 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1652 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1653 SegFaulting (I drowned in DicomDir related code when trying to
1654 understand why the list is empty...).
1655 * src/gdcmDocument.h: first BSD license header try.
1656 * Doc/License.txt added.
1658 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1659 * src/gdcmDocument.[h|cxx]:
1660 - Clean up of the Transfer related predicates. They are now all based
1661 on new method isGivenTransferSyntax, that (should) handle properly
1662 the padding problem.
1663 - general clean up, simplification, and coding style.
1664 - Specific clean up of Parse7FE0() (umproperly named actually).
1665 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1667 2004-06-14 Jean-Pierre Roux
1669 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1670 - fix the display of SQItem ordinal number
1671 - add the GetSQItemByOrdinalNumber method
1672 - remove some useless never written private methods
1674 2004-06-14 Jean-Pierre Roux
1676 - adding a constructor taking a gdcmDocEntry as an input param
1677 - ReplaceOrCreateByNumber now returns :
1678 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1679 a gdcmValEntry * if a string value is passed as a param
1681 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1682 according to the param type (no longer sets a gdcmDocEntry)
1683 - GetValEntryByNumber, GetBinEntryByNumber added
1684 - NewValEntryByNumber and NewBinEntryByNumber added
1686 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1688 - GetSQItemNumber and SetSQItemNumber added, to provide
1689 a (relative) Item identier inside a given Sequence
1690 \warning : some pb remaining around this number
1692 - AddEntry now takes the Item Number as a param
1694 - adding a constructor taking a gdcmDocEntry as an input param
1696 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * Memory leak hunt with the following command:
1698 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1699 --show-reachable=yes gdcmTests PrintDocument
1700 It looks like many (all?) leaks are due to the STL (or a bad usage
1701 of the STL. The lines producing the leaks now have a comment with
1702 a "MEMORY LEAK" tag: you can retrieve them with
1703 grep "MEMORY LEAK" src/*
1704 Here are two typical examples which I can't help fixing:
1709 char * test = "babo";
1710 name = test; //// <--- valgrind detects 960 bytes lost in
1711 //// call to std::string::operator=(char const*)
1712 name.clear(); //// Doesn't help !
1720 std::cout << "Type a bunch of characters followed by RETURN: ";
1721 getline(std::cin, line); //// <--- valgrind dectects a loss
1722 //// of 1320 bytes in call to
1723 /// std::basic_istream<>& std::getline<>
1729 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * src/gdcmHeader.[cxx|h]:
1731 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1732 and related, moved away to gdcmDocument.
1733 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1734 the corresponding protected accessors of inherited class
1735 gdcmDocument, removed ! As a consequence gdcmFile had to be
1736 declared friend of class gdcmDocument (see below).
1737 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1738 - Clean up of undefined or unused methods.
1739 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1740 account the changes to gdcmHeader.h).
1741 * src/gdcmDocument.h:
1742 - gdcmFile is now a friend class (in order to take into account the
1743 changes to gdcmHeader.h).
1744 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1745 (see changes to gdcmHeader.h).
1746 - Accessors (reading on the form GetEntry*) are now public.
1747 - Clean up of undefined or unused methods.
1748 * src/gdcmDocument.cxx:
1749 - adaptation to changes to gdcmDocument.h
1750 - ::OpenFile now writes a verbose message when file cannot be opened.
1751 - some std::string properly set to VRKey
1752 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1753 references to gdcmDocument.
1754 * Test/TestFindTags.cxx: changed accordingly to above changes.
1755 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1756 cvs repository gdcmData.
1758 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1759 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1760 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1761 conflicts with gdcmValEntry::voidArea.
1762 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1763 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1764 Value representation between StringRepresentable and BinaryRepresentable.
1765 * src/gdcmDocument.cxx:
1766 - method ParseDES: proper indentation restored and usage of
1767 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1768 - method LoadDocEntry: the fingerprint left in the SetValue() of
1769 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1770 removed. Reverting to previous code segment with the proper
1771 dynamic_cast< gdcmValEntry* >.
1772 Note: this was (partially) breaking the python test suite
1773 (gdcmPython/testSuite.py) that made usage of the above
1774 fingerprint to check presence of "Pixel Data".
1775 * src/gdcmDocEntry.h: coding style.
1776 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1777 now taken into account.
1778 * gdcmPython/gdcm.i: adaptation to the new internal representation
1779 of gdcm (exit gdcmParser, hello gdcmDocument).
1780 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1782 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1783 anymore, but instead prints the loaded Python dictionary.
1784 * .... alas, the python testSuite is still broken.
1786 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1787 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1789 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1790 * src/gdcmUtil.h : export methods
1792 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1793 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1795 * Initial addition of automatic python testing
1796 * Initial addition of automatic image comparison
1798 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1800 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1802 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1803 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1804 * Test/ShowDicom.cxx : bug fix for msvc compilation
1805 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1807 2004-05-04 Jean-Pierre Roux
1808 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1809 new concepts (and new classes) :
1810 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1811 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1812 - Sequence Doc Entries (gdcmSeqEntries)
1813 a Sequence is composed of Items.
1814 Each item is a set of Doc Entries (this is recursive)
1815 The non uniqueness of the 'Dicom tag' is due to this recursivity
1816 (never taken into account)
1817 Our unability to add a new 'entry' in the header
1818 at the proper location (neither in the H-Table (map or multimap),
1819 nor in the Chained List is also due to this recursivity.
1820 Don't try, right now, to use/modify/compile these new sources :
1821 nothing is finished.
1822 We just commit all the stuff, 'as is', in order not to loose it.
1824 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1827 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1828 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1829 file prefix (SetFilePrefix)
1831 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * Add a new test: ShowDicom, for now this is just the c++ version of
1833 checkRead.sh, later it will be able to compare the image read against a
1835 * Replace the DEBUG on the stack with a global entry in cmake interface:
1836 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1838 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1839 * Add an example subdir, with a real example on how to read + write a
1842 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1844 * Doc/CMakeLists.txt: the main page is now properly differentiated
1845 between the developper and user version.
1846 * Doc/doxygen.config.in: dropped search related obsolete flags
1847 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1849 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * DEVELOPPER: added some helpfull comments for compile/test/install
1853 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1855 src directory, now generated in the build dir.
1856 2. Tests as mentionned smarter
1858 4. Add a new method in gdcmDict that return the PubDict by name
1859 this is interesting for 3rd party lib like ITK,
1860 where we could set the institution name / patient name...
1862 * ENH: 1. Now the test suite is working for real
1863 2. All binaries are now output in the gdcm-bin directory
1864 (this was not true before)
1866 2004-04-28 Jean-Pierre Roux
1867 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1868 SeQuence indented printing of Dicom Header.
1869 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1870 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1871 Computation of SQDepthLevel is now part of gdcmHeader constructor
1872 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1873 tree-like structure of a Dicom Header.
1874 * FIX Test code cleaning
1876 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * ENH: Adding automatic testing
1878 1. Need a DartConfig.cmake to submit to public
1879 2. Add a test driver gdcmTest.cxx
1880 3. gdcmTestMain, an helper for the main test driver gdcmTest
1881 4. Files in Test don't have a main anymore, this becomes interesting
1882 when we add more and more tests, thus dsw don't have to load
1884 * ENH: Adding a GDCM_DATA_ROOT for testing
1885 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1886 one file instead of seven + some small cleanup
1888 2004-04-22 Jean-Pierre Roux
1889 * ENH Minor changes to the Print() methods.
1890 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1891 Header printing. Example given with :
1892 > PrintHeader fileName 2 new
1893 (SQ based tree-like structure still to be done for the Header ...)
1895 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1896 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1897 1. I have added some unsigned where needed
1898 2. Some function parameter not used -> (void)
1899 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1900 4. g++ don't like character '\' in comment
1901 5. #define jpeg_create_decompress jCreaDecompress
1902 this really need to be fixed
1903 6. virtualize destructor of gdcmObject ... leakage
1904 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1905 this also really need to be fixed
1906 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1907 remove compression file
1908 (as we only do decompression, right ?)
1909 * ENH: Change malloc/calloc/free with c++ equivalent
1911 2004-04-21 Jean-Pierre Roux
1912 * FIX gdcmHeaderHelper::GetXSpacing
1913 when a single value is found (bug ?), xpacing is now
1914 defaulted to yspacing
1916 2004-04-19 Jean-Pierre Roux
1917 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1918 * ENH add parameters :
1919 bool exception_on_error = false,
1920 bool enable_sequences = false,
1921 bool ignore_shadow = false
1922 to the gdcmFile constructors to be full gdcmParser compliant
1923 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1924 to allow reading of PAPYRUS 3.0 files
1926 2004-04-06 Jean-Pierre Roux
1927 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1929 2004-04-02 Jean-Pierre Roux
1930 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1931 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1932 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1934 2004-03-30 Jean-Pierre Roux
1935 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1936 for ACR file, written out as DICOM files (hope so...)
1938 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1939 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1940 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1941 moved to base class gdcmParser and only the specialisation is kept
1943 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1944 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1945 already does the job.
1946 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1947 (to be consistent with gdcmParser::WriteEntries).
1949 2004-03-30 Benoit Regrain
1950 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1951 upate of the object's instance. It's passed to 2 in the unfavorable
1952 case : one in the ExecuteInformation, one in the ExecuteData
1954 2004-03-29 Jean-Pierre Roux
1955 * ENH : Check on file type to be written moved
1956 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1957 * FIX : gdcmObject::ResetBoundaries now stops properly
1958 when end-of-list is reached
1959 : gdcmVersion modified (as Benoit Regrain asked)
1961 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1962 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1963 * src/gdcmUtil.cxx: added forgotten iostream include.
1964 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1965 equivalent to ExplicitVR in existing code).
1967 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1969 now contains all the gdcmGlobal related code.
1970 * minor coding style and doxygenation changes.
1972 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1974 now contains all the Debug related code.
1975 * minor clean-up of includes in src/*.cxx
1976 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1977 CreateCleanString) removed.
1978 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1979 * Doc/DoxyMainPageUser.txt added.
1980 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1981 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1982 src/gdcmDirList.cxx)
1984 2004-03-24 Jean-Pierre Roux
1985 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1987 2004-03-23 Jean-Pierre Roux
1988 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1989 big endian made volumes
1990 * ENH Now gdcmParser constructor and destructor are protected to forbid
1991 end user to instanciate class gdcmParser
1992 (only gdcmHeader and gdcmDicomDir are meaningfull)
1994 2004-03-22 Benoit Regrain
1995 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1996 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1997 gdcmSerie to gdcmDicomDirSerie
1999 2004-03-19 Jean-Pierre Roux
2000 * ENH Now the tree-like structure describing a DICOMDIR comming from
2001 an already existing DICOMDIR file is consistent with
2002 the home-made tree-like structure build ex-nihilo
2003 or build from the files held (recursively) in a Directory
2004 functions gdcmDicomDir::CheckBoundaries()
2005 gdcmObject::SetBoundaries() added
2007 2004-03-17 Jean-Pierre Roux
2008 * REM (Eric Boix bug) : removal of meaningless
2009 gdcmDicomDirImage::NewImage function.
2010 * FIX now file names and directory name are written properly in the
2012 * FIX now gdcmDicomDir constructor may be call without any trick
2015 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2017 of gdcmDicomDirImage::NewImage as empty function.
2019 2004-02-28 Jean-Pierre Roux
2020 * ENH add gdcmDicomDir:NewPatient
2021 add gdcmDicomDirPatient:NewStudy
2022 add gdcmDicomDirStudy:NewSerie
2023 add gdcmDicomDirSerie:NewImage
2024 to allow making gdcDicomDir object.
2025 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2026 (as opposite to the gdcmHeader chained list)
2028 2004-02-11 Benoit Regrain
2029 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2030 when using from python
2032 2004-02-10 Benoit Regrain
2033 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2034 * FIX : in gdcmDicomDir when the directory is empty
2035 * ENH : add callback and methods to get the progression of dicomDir
2038 2004-02-06 Jean-Pierre Roux
2039 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2040 - GDCM_META added to gdcmDicomDirType
2041 - class gdcmMeta created
2042 * ENH : - A brief summary is now displayed at the beginning of
2043 'testDicomDir' to help disaster magnitude estimation
2044 * REM : Now useless Test/explDICOMDIR.cxx
2046 2004-02-05 Benoit Regrain
2047 * ENH : add methods in gdcmObject to get the hash table or the list of
2049 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2050 * FIX : wrapping python for TagHeaderEntryHT
2052 2004-02-04 Benoit Regrain
2053 * FIX : even length for some strings when writting the dicom dir
2054 * FIX : sort the images in the dicom dir
2055 * FIX : Bug fix for python use of dicom dir
2056 * ADD : a python demo
2058 2004-02-04 Jean-Pierre Roux
2059 * FIX : Final solution (?) for icone embedded images
2060 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2061 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2062 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2063 gdcmData/gdcm-MR-SIEMENS-16.acr1
2064 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2065 to make full checking easier
2067 2004-02-04 Benoit Regrain
2068 * FIX : WriteEntries : coding style & logic in parameters
2069 * FIX : Set the elements to create the DicomDir in a dictionary file
2071 2004-02-03 Benoit Regrain
2072 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2073 * gdcmDicomDir : add the load of directory
2074 * Bug fix and print add-on
2076 2004-02-03 Jean-Pierre Roux
2077 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2078 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2079 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2080 * FIX gdcmParser.cxx : 'group length' elements are now considered
2081 as integers, even for shadow groups, when file is Implicit VR
2083 2004-02-02 Jean-Pierre Roux
2084 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2086 of the last synonym :-(
2087 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2089 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2090 * FIX taking into account the possible 7fe0,0010 multiplicity
2091 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2092 to allow removal of references to 7fe0,0010, to deal with
2093 ACR-NEMA images, when 0028,0200 is meaningfull
2095 2004-01-31 Jean-Pierre Roux
2096 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2097 no longer writes 'Un' on disk
2098 * FIX SQ elements with actual length are now dealt with corectly
2099 * FIX gdcmFile::WriteBase make the difference, for color images, between
2100 the length (for Palette expanded images)
2101 and Raw Length (non expanded image + Palette)
2102 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2103 (that broke Write). Replaced by UL.
2104 Aware user will reload the field if he
2105 thinks it's necesssary
2107 2004-01-30 Jean-Pierre Roux
2108 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2109 when 'dirty Acr' is found, to be compliant with the new
2110 IsReadable() methods.
2112 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2113 (no DOUBLE images in kosher DICOM,
2114 but so usefull for people that miss them ;-)
2116 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2117 DICOMDIR related utilities (not checked as Windoze compliant)
2119 2004-01-28 Jean-Pierre Roux
2120 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2122 2004-01-27 Jean-Pierre Roux
2123 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2124 to allow skipping the shadow elements, to save memory space.
2125 The TRUE value for this param has to be used
2126 with a FALSE value for the 'enable_sequence' param.
2127 ('public elements' may be embedded in 'shadow Sequences')
2128 * gdcmHeader methods now deal with 'embedded icones images' in the header
2129 (even when an 'icone image sequence' is announced by the
2130 element (0x0088,0x0200), but there is NO icone at all ...
2132 * gdcmHeader sometimes Image Location value doesn't follow
2133 the supposed processor endianity (see gdcmData/cr172241.dcm).
2136 * gdcmHeader add the method
2137 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2138 to get *all* the Header Entries with the same tag.
2139 GetHeaderEntrySameName is probabely *useless*
2140 (no meaning : Name is *not* an identifier within the Dictionary)
2142 2004-01-26 Benoit Regrain
2143 * Bug fix in the print of hexadecimal representations. Remove long fields
2144 in the print and add a third level of print to print them
2146 2004-01-23 Benoit Regrain
2147 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2148 * Bug fix on test suite after remove the strip made on not string fields
2149 * Split the IsReadable method between gdcmParser which test that the file
2150 is dicom and gdcmHeader which test that it's an image file
2152 2004-01-22 Benoit Regrain
2153 * DicomDir : clean code, add methods, set variables in protected or private
2154 * gdcmUtil : bug fix for the clean string method
2156 2004-01-19 Benoit Regrain
2157 * Add the use of shadow dictionaries
2158 * bug fix and coding style
2160 2004-01-19 Benoit Regrain
2161 * src/gdcmFile.cxx : bug fix concerning the close of file
2162 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2163 * Add the update of header entries using the shadow library
2165 2004-01-19 Benoit Regrain
2166 * removal of file gdcmHeader2.cxx
2167 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2168 inheriting from gdcmParser. This split is to prepare the integration
2169 of dicom dir parsing
2170 * bug fix under python
2172 2004-01-16 Jean-Pierre Roux
2173 * REM removal of class gdcmHeaderEntrySet
2174 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2175 * ADD add file gdcmHeader2.cxx
2176 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2178 2004-01-15 Benoit Regrain
2179 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2180 entries created while parsing the header. Thus, they will be destroyed
2181 when the gdcmDictSet will be destroyed
2182 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2185 2004-01-15 Benoit Regrain
2186 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2187 made a fatal error because of the memory release at the end of program.
2188 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2189 some memory and vtk seems to have some problems with that.
2190 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2192 2004-01-14 Benoit Regrain
2193 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2194 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2195 * src/*.[h|cxx] : make changes due to class name changes
2196 * gdcmPython/demo/*.py : bug fix due to method names
2198 2004-01-13 Benoit Regrain
2199 * src/*.[h|cxx] : coding style
2200 * vtk/*.[h|cxx] : coding style
2202 2004-01-13 Benoit Regrain
2203 * gdcmPython/testSuite.py : test the readable flag of file for tests
2204 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2205 It's lied to the stl compilation by MSVC (windows, always windows...)
2206 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2208 2004-01-12 Benoit Regrain
2209 * src/*.h : add comments
2210 * src/gdcmDictSet.h : set the method BuildDictPath in public
2211 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2212 directly setted in the source code
2213 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2216 2004-01-09 Benoit Regrain
2217 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2218 * setup.py : use a reference to gdcmVERSION
2220 2004-01-07 Benoit Regrain
2221 * Modification to compile with the distutils.
2224 2003-12-10 Benoit Regrain
2225 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2226 can use a gdcmHeaderHelper to load data
2227 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2228 made in the source code
2230 2003-12-10 Benoit Regrain
2231 * Update Windows projects and .cvsignore files
2233 2003-11-12 Jean-Pierre Roux
2234 * ENH gdcmHeader constructor has one more parameter (default value : false)
2235 that allows the user to 'go inside' the SeQuences only
2237 gdcmElValSet:Print takes it into account
2239 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2240 * ENH: Update gdcmPython/CMakeLists
2241 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2242 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2244 2003-11-10 Jean-Pierre Roux
2245 * FIX : gdcmHeader::LoadElements is now based
2246 on the ListTag listElem member,
2247 not longer on the TagElValueHT tagHt member
2248 * ENH : PrintPubElVal shows (temporarily) both results,
2249 with the tagHt member and the listElem member.
2250 (it's easier to 'see' the problems when using Printheader)
2252 * FIX : old private member LgrElem is now splitted into
2253 ReadLength : Length actually found on disk (updated only
2254 if bug fixing is necessary), for internal
2256 UsableLength : Updated by FixFoundLength, to fix a bug
2257 or to allow Parser going on.
2258 Will allow to re-write a kosher header when a SeQuence
2259 with a length (not 0000) is found
2260 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2261 because gdcmElValSet::Add does not update ListElem
2264 2003-11-07 Jean-Pierre Roux
2265 * FIX misstyping in Transfert Syntax name table
2266 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2267 when they have an actual length (not 0000 nor FFFFF)
2268 (Nobody should care of it, but DICOMDIR explorers)
2270 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2271 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2273 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2274 * ENH: vtkGdcmReader now supports LUT !
2275 (vtkgdcmViewer for now is not able to use them though)
2277 2003-11-05 Jean-Pierre Roux
2278 * in testSuite.py : new files names for checking the package
2279 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2280 that returns the pixel area size to the *aware* (vtk) user
2281 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2283 2003-11-05 Benoit Regrain
2284 * in testSuite.py : Modify the rules for checking the paths
2285 : Explicit error messages
2286 * in __init__.py : Related modif
2288 2003-11-03 Jean-Pierre Roux
2289 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2290 to be used by aware (vtk) users that want to manage
2291 LUT (and no to turn the PALETTE image into an RGB pixels one)
2292 * GetPixelType now returns 8U for 24 Bits images
2293 (vtkGdcmReader compliant)
2295 2003-10-31 Jean-Pierre Roux
2296 * Removal of *all* gdcmData images and add them again
2297 in order to loose the 'history' of un-anonymised images
2299 2003-10-31 Jean-Pierre Roux
2300 * RMV : removal of useless jBitsInJsample.h
2301 for both 8 and 12 Bits JPEG Lossy Libraries
2303 2003-10-31 Jean-Pierre Roux
2304 * ENH : Add the functions gdcmFile::GetImageDataRaw
2305 gdcmFile::GetImageDataIntoVectorRaw
2306 that act as GetImageData and GetImageDataIntoVector
2307 except the making of an RGB Plane from Gray Plane + LUT
2308 Intended to aware (vtk) users who know how to manage
2311 GetLUTRGBA return a R,G,B,A LUT if any
2312 lgrTotaleRaw gives the 'Raw' length
2313 GetImageDataRaw returns the gray Plane
2314 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2315 (They stay Grey, just like with other Dicom viewers :-(
2317 2003-10-30 Jean-Pierre Roux
2318 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2320 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2322 being coherents dicom files.
2324 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2325 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2327 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2328 * ENH: Two steps is necessary to please VC++ compiler...
2329 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2330 * ENH: Add include dir to medcon lib
2331 * FIX: only one function is being exported for now !
2332 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2334 2003-10-29 Jean-Pierre Roux
2335 * adding gdcmHeader::GetLUTRGBA
2336 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2337 --> Mathieu, the modif u're waiting for is not yet committed
2338 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2340 2003-10-27 Jean-Pierre Roux
2341 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2342 00191113.dcm DermaColorLossLess.dcm
2343 MxTwinLossLess.dcm RadBWLossLess.dcm
2344 * ENH: For version prior to vtkImageViewer2 -r 1.19
2345 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2347 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2348 * Removal of ido stuff in CMakeLists.txt
2350 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2351 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2352 * FIX: remove a call to ->Modified ... see comments
2353 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2355 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2356 * FIX: Problem with path for libvtkgdcmPython
2357 * ENH: Try adding a search script for python site-package
2358 * RMV: Remove some file from medcon lib that are not necessary
2359 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2360 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2361 * FIX: More pragma disable fro VC++,
2362 I don't think I break something as it is also disable in VTK/ITK.
2363 But it fasten debug compilation time.
2365 2003-10-23 Jean-Pierre Roux
2366 * gdcm now deals with 16 Bits Run Length Encoded images
2367 (they are compressed as 2 planes images,
2368 one for the high Bytes, the other for low Bytes)
2370 2003-10-22 Jean-Pierre Roux
2371 * Now CheckRead takes into account :
2372 - the bugged 'Leonardo' Siemens images
2373 - the XA images, sent thru the burning VPRO station
2374 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2377 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2378 * FIX: When copying a Makefile.am to CMakeLists.txt
2379 one should remove the '\'
2381 2003-10-22 Jean-Pierre Roux
2382 * in gdcmData adding a bugged 'Leonardo' Siemens image
2383 (wrong lengths in header)
2384 OK with gdcm, KO with the other viewers :-)
2385 * add a GE dlx XA image, thru the VEPRO burning station
2388 2003-10-21 Jean-Pierre Roux
2389 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2390 for a brutal checking of vtkgdcmViewer compliance
2392 2003-10-21 Jean-Pierre Roux
2393 * add the files for 'xmedcon' Jpeg Lossless library
2394 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2396 2003-10-21 Jean-Pierre Roux
2397 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2399 2003-10-21 Jean-Pierre Roux
2400 * garbage Siemens 'Leonardo' images dealt with
2401 (the patch is easy to remove)
2402 * cosmetic changes to avoid warnings
2404 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2405 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2406 no need to press 'r' now.
2408 2003-10-20 Jean-Pierre Roux
2409 * upgrade of checkRead.sh checkWrite.sh according
2410 to new Jpeg Lossless decompressor
2411 * add US.3405.1.dcm, a genuine RGB medical file ...
2412 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2413 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2415 2003-10-15 Jean-Pierre Roux
2416 * general anonymisation in gdcmData
2417 * adding the 'color files' from
2418 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2419 * adding some well knowed bugged-header images
2420 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2421 waiting for their inclusion in Python testsuite
2423 2003-10-15 Jean-Pierre Roux
2424 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2425 no longer seg faults when file is not found
2427 2003-10-14 Jean-Pierre Roux
2428 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2431 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2432 * TODO: *.in file to genereate a UseGDCM later
2434 2003-10-14 Jean-Pierre Roux
2435 * Some supposed-to-be Dicom Images have no preamble.
2436 OpenFile takes it into account
2437 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2438 * Missing elements added in dicomV3.dic
2439 (just to be affraid : have a look at
2440 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2441 and do it again next year ;->
2443 2003-10-13 Jean-Pierre Roux
2444 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2445 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2446 But there are NOT. It's fixed !
2448 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2449 * FIX: "jpeglib.h" was not found on VC++
2450 * FIX: vtkgdcm was not being installed
2452 2003-10-10 Jean-Pierre Roux
2453 * ENH : OpenFile closes the file if it *really* doesn't look like
2454 an ACR-NEMA / DICOM one.
2455 * FIX : testWrite no longer writes an empty file if the source file
2456 is not gdcm Readable
2457 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2460 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * FIX: CMake generate now documentation
2462 * ENH: out of source doc build !
2463 * ENH: Generate both user and dev documentation
2464 * ENH: Should work on windows too
2465 * ENH: Only one doxygen config.in file is needed
2466 * FIX: make install should be ok now on ùnix plateform
2467 * FIX: PATH to dictionary was wrong (missing /)
2468 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2470 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2471 * vtkGdcmReader is now able to read rgb dicom file.
2472 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2473 * added a gdcmViewer to vtk test, use mouse to control
2474 window level & window width
2476 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2477 * CMake-ification of gdcm, we have now two build system
2478 * FIX: on cygwin Wsock32 doesn't exist
2479 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2481 2003-10-06 Emanuel Ollart
2482 * FIX : compilation process wad broken.
2483 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2485 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2486 * change gdcmViewer -> vtkgdcmViewer
2487 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2489 2003-10-06 Jean-Pierre Roux
2490 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2491 ( e.g : well known GE images with a wrong elem length,
2492 : Philips MRI Images with a wrong Huffman table)
2493 * still to be done : allow the reading of bugged LEONARDO Siemens images
2495 2003-10-03 Jean-Pierre Roux
2496 * Odd length strings are padded with '\0' (not with spaces,
2497 to remain compliant with already defined strings,
2498 like Transfert Syntax UID and others)
2500 2003-10-03 Jean-Pierre Roux
2501 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2502 to allow displaying RGB images (not only by affim ;-)
2504 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2505 * vtkGdcmReader is now able to read rgb dicom file.
2506 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2508 2003-10-03 Jean-Pierre Roux
2509 * A few nasty patches to allow the reading of a lot of nasty images
2510 ( e.g : well known GE images with a wrong elem length,
2511 : Philips MRI Images with a wrong Huffman table)
2512 * still to be done : allow the reading of bugged LEONARDO Siemens images
2514 2003-10-03 Jean-Pierre Roux
2515 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2517 2003-10-03 Jean-Pierre Roux
2518 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2519 to allow displaying RGB images (not only by affim ;-)
2521 2003-10-03 Jean-Pierre Roux
2522 * gdcmFile::GetImageDataIntoVector now
2523 - deals with MultiFrames MultiFragments Run Length Encoded files
2524 - deals with YcBcR (YBR_FULL) files
2525 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2526 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2528 (no sample found :-(
2530 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2531 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2532 Two reasons: - clear things
2533 - third parties acces gdcm through header files, so won't
2534 suffer anymore VC++ complains
2536 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2537 * add argv[1] in testvtkGdcmReader.cxx
2540 2003-09-24 Jean-Pierre Roux
2541 * The lines are now eigthy characters long.for
2542 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2544 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2545 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2546 char* to std::string. Thus, the use of strdup becomes useless. (see
2547 previous commis of Malaterre)
2548 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2549 before the last Malaterre's commit.
2551 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2552 * This commit should fix the Debug building under VC++, the problem
2553 was mainly a mixture of debug and release lib being loaded at startup.
2554 * I also remove a depency to a specific C function: strdup. Because I had
2555 to force the link to msvcrtd (whereas strdup is in libc).
2557 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2558 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2559 located in the gdcmCommon.h file. All use of reference of tha has been
2560 changed to now use the variable GDCM_UNFOUND.
2562 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2564 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2565 Dicom dictionary. The test suite can now be run again. Note:
2566 I'm note very happy with the " (RET)" changes. I believe this
2567 RETAINED comment should be dropped when parsing the dictionary.
2568 - PACKAGER corrected
2570 - AUTHORS updated and now in alphabetical order
2571 * Makefile.am now exports gdcm.dsw for Windoze users.
2573 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2574 * cygwin complains about missing std:: in subdir Test/
2576 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2577 * remove some methods that are now in gdcmHeaderHelper
2579 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2580 * vtkGdcmReader set spacing and origin correctly
2582 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2583 * Fix a few delete/delete[] mismatch
2585 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2587 interpretation to data given by gdcmHeader. For instance there are
2588 heuristics to get informations (look at different places).
2589 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2590 sorting DICOM images based on different strategies.
2591 * modified Makefiles accordingly.
2593 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2594 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2595 when building in debug mode
2596 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2597 src/win32/gdcmdll.dsp
2598 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2600 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2601 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2604 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2605 * src/win32/libgdcmjpeg12.dsp was not dos format
2606 * src/win32/libgdcmjpeg12.dsp :
2607 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2608 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2610 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2611 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2613 * src/gdcmFile.cxx : bug fix in affectation type
2614 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2615 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2616 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2617 symbols... future problem ?
2619 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2620 * src/win32/libgdcmijpeg12.dsp was missing
2621 * modified gdcm.dsw accordingly
2623 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2626 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2627 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2628 commit of JPR (before his hollidays to facilitate our work).
2629 * setup.py : bug fix in code. Modifications made while the last commit
2630 of JPR. The code hasn't been tested before the commit... it's so
2631 useless to make that (for best programmer that is JPR) !!!
2633 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * tagged the current version as Version0_3 (i.e. version 0.3)
2636 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2637 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2638 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2639 * *.dsp : modifications to use new libgdcmijpeg8 library
2640 * setup.py : bug fix on VTKPATH variable
2641 * PACKAGER : adding all concerning windows
2643 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2644 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2646 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2647 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2648 test suite reported error.
2649 * PACKAGER file added (describes what a packager must do when
2650 packaging a new release).
2651 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2652 * configure.in: upgraded version number to 0.3.0
2653 * fixing build of rpm (through rpm -ta):
2654 - Doc/Makefile.am exports proper doxygen files
2655 - src/jpeg/libijg8/Makefile.am exports the include files.
2657 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2659 * src/gdcmHeader.h : formatting code
2661 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2662 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2663 We were obtaining error message from vtk. Now, creation of file list
2664 is made in an internal list to prevent this problem.
2665 Bug fix when output is empty.
2666 Bug fix in update of progress value. Previous commit for this was a bad
2668 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2670 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2671 * src/gdcmHeader.h : added method to get the file name
2672 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2673 files. Added method to remove all files on the input
2674 Added FIXME comment concerning the bad parsing of header made by
2675 ExecuteInformation method (in ExecuteData method)
2677 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2679 when using make instal.
2680 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2681 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2683 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2684 * setup.py : adding include dir of jpeg lib to compile all sources
2685 * */Win32/*.dsp : JPR fix for windows compilation
2687 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2688 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2690 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2691 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2693 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2694 * setup.py is again effective on un*x (takes into account the
2695 addon of the jpeg library)
2696 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2697 * Doc/Doxy* updated (includes above enhancements)
2698 * INSTALL now points to web documentation
2700 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * src/gdcmHeader.h doesn't make unnecessary reference to
2703 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2705 * src/gdcm*.[cxx|h] :
2706 - to allow compilation with gcc 3.x
2707 -- clean up of STL usage (added explicit usage of std::)
2708 -- small fixes on exceptions.
2709 Note: linking not tested !
2710 - clean of doxygen comments to avoid warnings at documentation
2712 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2713 dependent convertion).
2715 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * Clean up of previous JPR garbage commit (not even commented in the
2718 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2719 - moved all jpeg related files from src to src/jpeg/libijg8, with
2720 addition/modification of Makefile.am and configure.in.
2721 - the testSuite is still brain damage (not guilty).
2723 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2724 * WrapVTK.py : modifications to get correctly vtk source files to
2726 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2727 (FileName -> Filename)
2729 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * vtk/vtkGdcmReader.[cxx/h]:
2731 - UpdateProgress method should now be effective
2732 - removed the limitation on having only images loaded (as opposed
2734 - when building a stack of images/volume, a lesser number of
2735 gdcmHeader and gdcmFile instances should be used (hopefully
2736 accelerating things).
2737 - when building a stack of images/volumes, files which are not
2738 loadable (wrong path-filename, wrong permissions on existing file,
2739 or file not parsable by gdcm) are replaced with a black image
2740 in the stack (for the caller to notice the problem).
2742 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2745 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2746 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2747 between standard library (std) and vtk library (problems are found
2748 under Windows... thanks Windows !)
2750 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2753 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2755 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2758 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * When compiling with distutils (see setup.py) the C++ compiler is
2760 called with different flags than the default ones (with automake).
2761 In order to fix all those warning, I compiled gdcm with the command
2762 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2763 and went for warning fixes:
2764 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2765 up from unused variables.
2766 - vtk/vtkGdcmReader.cxx: potential bug fix.
2767 * src/gdcmHeader.h: Doxygen warning cleanup
2769 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * gdcmPython/gdcm.i:
2771 - typemaps correction to take into account the systematic replacement
2772 of "using namespace std" with std:: prefix e.g. std::list,
2773 std::string... (cf changes of 2003-05-21).
2774 - gdcmGlob global variable of type gdcmGlobal (defined in
2775 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2776 exported to Python a as cvar.
2777 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2778 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2779 gdcmDictSet.GetPubDictTagNames() and
2780 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2781 C++ static methods).
2782 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2783 with the above changes.
2785 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2786 * setup.py, manifest.in : bug fix under linux
2788 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2789 * Modification of setup.py to compile vtk part too. Then, we have 2
2790 wrappers which must work with same distutils. For that, we have a
2791 generic distutils in distusiltsWrapping.py ; with :
2792 - build_extWrap class to wrap generically all extensions,
2793 - ExtensionWrap base class for all wrapping extension that contains
2795 - Wrapper interface which wrap sources
2796 + In WrapSwig.py we have extension and wrapper for Swig
2797 + In WrapVTK.py we have extension and wrapper for VTK
2798 * MANIFEST.in : modifications to consider vtk directory and new python
2799 files for compilation
2801 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2802 * Added python wrappers of vtkGdcmReader vtk class (see the
2803 source in vtk/vtkGdcmReader.cxx) :
2804 - vtk/Makefile.am now builds a library
2805 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2806 python library (as opposed to _gdcm.so wich are the python
2807 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2808 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2810 - configure.in has an additional flag --enable-vtk that needs
2811 to be set to enable compilation of vtk related code, that is:
2812 + vtk/vtkGdcmReader.so and
2813 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2814 + gdcmPython/vtkgdcmPython.so (see above)
2815 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2816 be read when compressed or when HighBit + 1 != BitsStored),
2817 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2818 the usage of the python wrapper of vtkGdcmReader vtk class.
2819 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2820 * src/*.[h] all occurences of stl classes are now prefixed with
2821 std::, and all occurences of "using namespace std;" where removed.
2822 This is to avoid pollution of global namespace in included files.
2823 Apparently vtk does not avoid this pitfall: when using both
2824 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2825 collision of various stl members (principally cout...).
2826 * gdcmPython/testSuite.py now cleanly removes temprory generated
2828 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2829 comply with above changes)
2831 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2832 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2833 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2834 vtk data structure (an image Flip was required).
2835 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2836 * cosmetic changes in documentation.
2838 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2839 * src/gdcmHeader.cxx: the constructor no longer exits when an
2840 unexisting file is given as argument.
2841 * The subdirectory Data (containing all the images used for the
2842 test suite) is not part of this repository anymore. A new module
2843 containing those images is now available at
2844 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2845 with the name gdcmData.
2846 All the python scripts (including the package initialisation file
2847 gdcmPython/__init__.py) were adapated to take this change into
2848 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2850 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2851 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2852 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2853 demo of the usage of this class.
2854 Compilation of this vtk part is only done when using the --enable-vtk
2855 at configure (or autogen.sh) stage.
2857 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2858 * More memory link related corrections and documentation fixes.
2860 - maximum info is obtained with a command of the form:
2861 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2862 --show-reachable=yes PrintHeader
2863 - the remaining reachable blocks seem to come from the STL
2864 allocation scheme through the usage of map and list. It looks
2865 like this memory cannot be freed but it is not a memory leak
2866 (in fact further invocation to the STL would recollect the
2867 unused memory allthough it cannot explicitely be freed).
2868 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2869 of displaying an image parsed with gdcm and displayed with VTK.
2870 Note: some images don't seem to work e.g.
2871 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2872 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2873 Allthough this weakens the semantics, it is a ditch attempt to
2874 make gdcm more thread friendly.
2876 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2877 * Memory link hunt (by using valgrind through the command
2878 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2879 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2880 gdcmHeader::_dicom_vr.
2881 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2882 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2884 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2886 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2887 * src/Makefile.am now exports all the necessary include files at
2891 * UpdateGroupLength replaced by new one
2894 * UpdateGroupLength re-written using H-Table
2895 (named UpdateGroupLengthNew untill checks are over)
2897 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2898 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2899 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2901 - gdcmHeader::GetPubElValSet removed.
2902 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2903 UpdateGroupLength, WriteElements, Write.
2904 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2905 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2906 carried the same semantics.
2907 - src/gdcmHeaderIdo.cxx changed accordingly.
2908 - gdcmFile::WriteBase now regroups all the codes from previous
2909 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2910 - enum FileType moved to gdcmCommon.h
2911 * src/gdcmHeader.cxx AddDefault trashed
2912 * gdcmGetXSize added
2913 * getimageDataSize now calls gdcmGetXSize
2914 * Test/*.cxx changed to agree with above changes
2916 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2918 (to avoid double call by end user).
2919 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2920 by end user, since gdcmHeader::gdcmHeader now handles it.
2922 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * gdcm/Doc many doxygen changes:
2924 - Doxyfile now has two different versions, DoxyfileUsers that generates
2925 the html.users end users oriented documentation and
2926 DoxyfileDeveloppers that generates the html.developper developper
2927 oriented documentation.
2928 - README changed accordingly
2929 - requirement.txt removed (old design info moved to TODO).
2930 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2931 DoxyMainPage.txt, DoxyPython.txt provide more information.
2932 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2933 be updated by simply regenerating the docs with doxygen and copying
2934 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2935 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2936 all the tests in the form "if (<map>.count() >1)" were removed.
2937 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2938 ill-formed documentation sections.
2939 * src/gdcmHeader.cxx: ditto
2941 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2942 * setup.py fixed for un*x (needed macro for stdint.h)
2943 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2944 un*ces with sh-utils test utility.
2945 * gdcmPython/demo/test.py renamed to PrintHeader.py
2946 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2947 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2948 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2949 * src/gdcm*.cxx JPR's bad inclusion fixed.
2951 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2953 * gdcmPython/demo/test.py changed accordingly.
2955 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2956 * gdcmPython/Makefile.am fixed linking against libstdc++
2957 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2958 * Swig subdir (historical tests of swig version 1.3.17++) removed
2959 * Test/testChangeEntete.cxx some lines commented out in order to make
2961 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2962 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2964 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2965 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2966 hence the user doesn't need this explicit call.
2967 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2968 i.e. LoadElements() call removed.
2969 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2970 - src/Makefile.am declares the proper flag for g++.
2971 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2972 for adding user defined new tags.
2973 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2974 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2975 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2977 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2978 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2979 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2980 src/Makefile.am : the project should properly compile and install
2981 with the autotools, included the python wrappers part.
2982 * gdcm.spec.in : added a spec file for RPM packaging.
2984 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2985 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2987 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2988 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2989 to exported to the environement (see gdcmPython/testSuite.py
2991 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2992 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2993 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2994 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2995 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2997 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2998 * gdcmPython/__init__.py doesn't crash anymore when running in
2999 in InstallMode or PreInstallMode but with an environment given
3000 value of GDCM_DICT_PATH.
3001 * src/gdcmDictSet.[cxx/h] coding style.
3003 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3004 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3005 * src/gdcm.h general comments moved to TODO, and README
3006 * src/gdcm.h should now be seen as a user commodity (including it
3007 should suffice to fully use gdcm). It is nowhere including within
3008 any of the kernel files src/*.cxx and src/*.h.
3010 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3011 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3012 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3014 * src/gdcm*.cxx only include their corresponding include file
3015 (as opposed to gdcm.h)
3016 * gdcmPython/gdcm.i changed accordingly
3017 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3018 the autogen.sh generated "make snapshot" command to work.
3019 * autogen.sh removed history related references to crea package.
3021 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * distutilsSwigCPlusPlus.py work around some swig portability
3025 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3026 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3027 was done in a last ditch attempt to get setup.py _really_
3028 operationnal. The python/gdcmPython layaout add the advantage
3029 of hidding away the python related distutils specific files
3030 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3031 Alas, the src directory was out of scope (i.e. it's relative
3032 position to setup.py was ../src) which made things impossible to
3033 handle (see previous version of python/setup.py). Crossing fingers...
3035 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3036 * python/setup.py now works on Un*x. (harder than I thougth)
3037 * python/distutilsSwigCPlusPlus.py can now have include files
3038 among the list of sources.
3040 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3041 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3042 * modifications in MSVC projects
3044 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * As stated by the first lines of Test/ExceptionAndPython/README, it
3046 looks like we can move back to original usage of exception within
3047 src/gdcm* and hence remove the errno stuff that was introduced
3048 as a quick and dirty fixture of this problem (added to the TODO).
3049 * Doc/Doxyfile configuration file for Doxygen and corresponding
3050 README file for usage added.
3051 * Test/testWrite.cxx added. This new test comes from a split of
3052 test.cxx that is now reverted to its original purpous i.e.
3053 testing the proper parsing of a Dicom related file.
3054 testWrite.cxx concentrates on testing the IO part of gdcm.
3055 * Test/bug1.cxx (containing a bug on WIn32) added.
3056 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3057 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3058 whose purpose is to publish the content of the TagNames of the
3059 Dicom public dictionary were not accessible without an
3060 instance of class gdcmHeader.
3061 - those methods are now static methods of gdcmDictSet and hence
3062 require no instances at all to be invocated.
3063 - within gdcmDictSet this change required to change some method
3064 to class methods (i.e. are now static) among which SetDictPath
3065 (renamed to BuildDictPath) and LoadDefaultPubDict.
3066 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3067 the above changes by calling the new method classes of gdcmDictSet.
3068 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3069 the above to be effective.
3070 * python/gdcmPython: in order to wrap properly the above changes
3071 for Python, swig version now needs to be > 1.3.17.
3072 * python/gdcmPython/Makefile fixed to adapt itself to new
3073 configure/make shema introduced by Johan Montagnat (thanks for the
3074 contribution). Alas this Makefile cannot be turned into a proper
3075 Makefile.am without some heavy changes in the configure.in
3076 (for python dectection).
3077 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3078 now avoids publishing the empty entries.
3080 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3081 * python/setup.py : bug fix concerning install under windows
3082 ExtraPath reused :-P
3083 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3085 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3086 * Dicts/dicomV3.dic : remove double spaces !!!
3087 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3088 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3091 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3092 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3093 method. Doxygenation.
3094 * src/gdcm.h clean up of JPR spurious comments.
3096 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * python/distutilsSwigCPlusPlus.py now properly collects the
3098 shadow classes generated by "swig -c++" (gdcm.py in our case)
3099 when using "python setup.py install".
3100 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3101 reexports the working classes.
3102 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3103 by the classical C errno scheme. This is to prevent an obscure
3104 behavior of the python wrappers when importing wxPython.wx prior
3105 to gdcmPython (which ended up in an abort call). An illustration
3106 of this oddity can be found in the Test/ExceptionAndPython
3107 subdir (see the README file). This problem probably due to
3108 an combination of g++ and dynamic loading.
3109 * added Test/ExceptionAndPython (see above)
3111 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3112 * Changed the layout of the python part to avoid bloating main
3113 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3114 i.e. the distutils arsenal. All the python related stuff is
3115 again in a python subdir, but the package itself is now in
3117 * setup.py was cleaned up:
3118 - pythonIncludePath removed
3119 - python setup.py bdist target is now functional.
3120 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3121 collision with other packages). gdcmPython/demo/*.py changed
3124 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3125 * python subdir moved to gdcmPython (preparation of distutils packaging).
3126 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3127 distutils installer is operational.
3128 * - gdcmPython/__init__.py now properly loads the swig generated
3129 shadow classes (from gdcm.py).
3130 - gdcmPython/demo/*.py changed to import the package gdcmPython
3131 instead of gdcmPython/demo/load.py.
3132 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3134 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3135 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3136 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3137 entries within the associated public Dicom dictionary resp. the same
3138 information but sorted by the fourth field (PAT, IMG, DIR) of the
3140 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3141 are now in the "???" group.
3142 - python/gdcm.i changed accordingly,
3143 - python/demo/printGroupedPublicDict.py added, that gives an example
3144 of the above new functionalities in Python.
3146 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3147 * src/gdcm.h, gdcmHeader.cxx:
3148 - historic references to glib's g_malloc and g_free (#defined)
3149 were definitively removed.
3150 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3151 * src/gdcmElValSet.cxx:
3152 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3153 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3154 - GetElValue(string) renamed to GetElValueByName.
3155 - Added GetElementByName(string).
3156 * src/gdcmHeader.cxx: added
3157 - GetPubElValRepByNumber(guint16, guint16)
3158 - GetPubElValRepByName(string)
3159 - GetShaElValRepByNumber(guint16, guint16)
3160 - GetShaElValRepByName(string)
3161 - GetShaElValByNumber(guint16, guint16)
3162 - GetShaElValRepByName(string)
3163 - GetElValRepByNumber(guint16, guint16)
3164 - GetElValRepByName(string)
3165 - GetElValByNumber(guint16, guint16)
3166 - GetElValRepByName(string)
3167 * Doc/requirements.txt added.
3169 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3170 * Test/Makefile building now depends on the one of libgdcm.so
3171 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3172 pixel data) aware which enables finding the address (offset) of
3173 the pixel data of JPEG encoded DICOM files. This leaves only a single
3174 file in the testSuite whose pixel data address (offset) is unknown.
3175 * python/testSuite.py changed accordingly.
3177 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3178 * VC++ has some strong limitations when working with the STL, as stated
3179 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3180 "Also note that some STL containers (map, set, queue, list, deque)
3181 cannot be exported. [...]
3182 Some STL classes contain nested classes. These classes can not
3184 This is caused by a designed limitation that once a template
3185 class is instantiated, it can not be re-instantiated and
3187 Since our usage of map<> is ubiquitous in gdcm, this "designed
3188 limitation" of VC++ is a pitfall.
3189 Hence the Python wrappers of gdcm cannot be incrementally linked
3190 against the c++ dynamic library. The dirty but only workaround is
3191 to forget about incremental link of dynamic libraries and to generate
3192 the Python wrappers library with the inclusions of the underlying C++
3194 The following modifications concern this matter on Win32/VC++:
3195 - wrapping python correct with standalone wrapped dll (don't use separate
3196 dll under windows !!!!)
3197 - python21_d debug mode enabled (ask Frog how to use it :-)
3198 - NO problem with having an STL member of class for example string in C++
3199 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3200 - Python test of dcmlib in Python is ok under windows on a large set
3202 * removed glib references
3203 * typedef's inserted in gdcm.i for correct swig type management
3205 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3206 * python/demo/*.py load.py extracted from test.py. Added explore.py
3207 that only displays required tags and testAll.py that parses all
3208 the files of the testsuite without using unittest.
3209 * python/testSuite.py other additional test on new files added.
3210 * Data/* new test files added accordingly to the testSuite.
3211 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3212 the vr in the file differs from the one of the dictionary.
3214 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3215 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3216 values, but limits itself to values which are below a user specified
3217 size (by default 1024 bytes).
3218 * python/gdcm.i : elements not loaded (because their size is above the
3219 user specified treshold) are exported with their TagKey as key of the
3220 python dictionary. This enables the testsuite to make some checks
3221 on the unloaded elements (since we have their offset and size).
3222 * python/testSuite.py
3223 - now tests for the existence and proper value of the pixel data
3224 - two new examples added.
3225 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3227 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3228 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3229 aware. See the strategy comments in gdcmHeader::FindLength().
3230 * Test/test.cxx now accepts a filename as first argument.
3231 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3232 * python/testSuite.py changed to integrate test on above files.
3234 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3235 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3236 the vr was also RET.
3237 * python/testSuite.py more tests added.
3239 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3240 * python/testSuite.py unittest test suite added (uses Data)
3241 * Data/* dcm and acr files for the test suite.
3242 * glib dependance removed from un*x version. We now use ISO C99
3243 7.18 Integer types (see stdint.h)
3244 - python/Makefile, src/Makefile src/gdcm.h
3245 * src/ when an explicit vr (like dicom files) suddenly poped an
3246 implicit element we use to mark the underlying DictEntry of the
3247 concerned ElValue with "Implicit". This strategy was damageable
3248 too the public or provite dictionaries, since some of their vr
3249 would be changed. Since Header::FindLength heavily relies on the
3250 detection by Header::FindVR of falsely explicit elements, I
3251 added an extra ImplicitVr member to ElValue (boolean).
3252 The rest of the changes we the necessary adaptations.
3254 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3255 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3257 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3259 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3260 * Adaptation for porting to VC++:
3262 o forced to use std namespace (for string to be known)
3263 o all class use __declspec export style on WIN32
3264 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3265 (in stdlib.h on Win32 but in std:: for gcc)
3266 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3267 variable GDCM_DICT_PATH.
3268 * src/gdcmHeader.cxx verbose comments made discrete.
3270 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3271 * python/gdcm.i: added a typemap that converts a C++ hashing table
3272 to native Python dictionary.
3273 * python/demo/test.py:
3274 - now uses the native dictionary for exploration of gdcmHeader.
3275 - takes an optional filename argument (the file to parse).
3276 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3277 PubElVals hashing table.
3278 * Dicts/dicomV3.dic removed error prone trailing spaces.
3280 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * Python wrapping process moved away from src/Makefile to
3282 newly created python/Makefile (as well as gdcm.i)
3283 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3284 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3285 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3286 from the environement variable GDCM_DICT_PATH (when existing).
3287 * src/gdcmDict::GetTag bug fix.
3289 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3290 * Straightforward temporary fixes for swig to build the python wrappers.
3291 src/Makefile now has a python working entry [by working we mean
3292 that we can import the shadow classes without errors].
3294 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3295 * hashtest.cxx removed (since already in Test)
3296 * src/gdcmlib.h renamed to src/gdcm.h
3297 * src/dcm.i renamed to src/gdcm.i
3298 * src/Makefile prepared for python wrapping
3300 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3301 * src/gdcmHeader.cxx :
3302 - Parsing of header is now separated from loading of element values
3303 (see gdcmHeader::LoadElements).
3304 - general clean up of hopefully all file access (creation of
3305 ReadInt16 and ReadInt32)
3307 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3308 * src/gdcmHeader.cxx :
3309 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3311 - SetLgrElem renamed to SetLength
3312 - GetLgrElem renamed to GetLength
3313 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3314 * src/gdcmElValSet.cxx fixed both GetElValue methods
3315 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3316 due to IdoDude was cleaned out.
3318 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3319 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3320 concentrates on finding the value representation (when it exists).
3321 RecupLgr now only finds the element value length, and it avoids
3322 returning the unecessary skL (skipped length).
3323 Also, offsetCourant was simply removed (with taille_fich) since
3324 it was redundant with the File position internals (by using
3325 ftell and fseek). This also made skL (see above in RecupLgr) usage
3327 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3328 on the libido specificities which are handled through class
3330 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3333 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3334 * Truckload of changes. Parsing of header is barely functional
3335 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3337 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3338 * src/gdcmHeader.cxx many addons of low level methods
3340 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3341 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3342 and _IdDcmSWAP_LONG.
3344 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * This corresponds to all the changes decided at the meeting of
3346 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob